[Libreoffice-bugs] [Bug 140767] Support for Syriac justification ("Kashida") by stretching the word-line instead of growing spaces between words (just like Arabic)
https://bugs.documentfoundation.org/show_bug.cgi?id=140767 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140857] LibreOffice's Tabbed Ribbon UI on macOS is ugly
https://bugs.documentfoundation.org/show_bug.cgi?id=140857 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140862] Custom button control shown when file is saved, not shown when re-opened, still listed in Form Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=140862 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140859] Downarrow sometimes fails in merged TABLE cells
https://bugs.documentfoundation.org/show_bug.cgi?id=140859 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136954] Crash in: epoxy_wglMakeCurrent_wrapped
https://bugs.documentfoundation.org/show_bug.cgi?id=136954 --- Comment #2 from QA Administrators --- Dear Stefan Schmaltz, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136953] Viewing: Error Adding up columns with percents
https://bugs.documentfoundation.org/show_bug.cgi?id=136953 --- Comment #3 from QA Administrators --- Dear SusanTN, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136316] TABLE PROPERTIES: Allow intermediate lines to be repeated as table heading
https://bugs.documentfoundation.org/show_bug.cgi?id=136316 --- Comment #7 from QA Administrators --- Dear Viktor Mileikovskyi, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 136316] TABLE PROPERTIES: Allow intermediate lines to be repeated as table heading
https://bugs.documentfoundation.org/show_bug.cgi?id=136316 --- Comment #7 from QA Administrators --- Dear Viktor Mileikovskyi, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 136092] Sheet protection function
https://bugs.documentfoundation.org/show_bug.cgi?id=136092 --- Comment #3 from QA Administrators --- Dear motoki, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133159] Navigator: Selected item changes to the previous one (gtk3)
https://bugs.documentfoundation.org/show_bug.cgi?id=133159 --- Comment #10 from QA Administrators --- Dear Xisco Faulí, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131110] Table creation needs to be simpler, and allow us to change the headers
https://bugs.documentfoundation.org/show_bug.cgi?id=131110 --- Comment #3 from QA Administrators --- Dear techxgames, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113192] [Digital-Signatures][OpenPGP] There's no indication of which key is which
https://bugs.documentfoundation.org/show_bug.cgi?id=113192 --- Comment #3 from QA Administrators --- Dear Eike Rathke, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 113192] [Digital-Signatures][OpenPGP] There's no indication of which key is which
https://bugs.documentfoundation.org/show_bug.cgi?id=113192 --- Comment #3 from QA Administrators --- Dear Eike Rathke, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 124183] Some tabs in tabbed mode don't get highlighted when hovering mouse over them
https://bugs.documentfoundation.org/show_bug.cgi?id=124183 --- Comment #2 from QA Administrators --- Dear Aritz Erkiaga, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124104] LibreOffice Base: Text cut off in GUI elements with font scaling enabling or when font size increased above 12 point
https://bugs.documentfoundation.org/show_bug.cgi?id=124104 --- Comment #4 from QA Administrators --- Dear Allan Macdonald, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124006] EDITING: copy & paste from AOO to LO fails for formula's
https://bugs.documentfoundation.org/show_bug.cgi?id=124006 --- Comment #5 from QA Administrators --- Dear Oliver Brinzing, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123716] Loading indicator when starting a presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=123716 --- Comment #3 from QA Administrators --- Dear Nicolas Christener, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116953] EDITING: UI: Firebird: Migration: Base fails to call QueryEditor for defined database view
https://bugs.documentfoundation.org/show_bug.cgi?id=116953 --- Comment #15 from QA Administrators --- Dear Drew Jensen, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104130] SIDEBAR: Line and arrow style labels appearing in comboboxes of Line content panel
https://bugs.documentfoundation.org/show_bug.cgi?id=104130 --- Comment #16 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137147] Provide a way to cancel formula calculation in Calc (e.g., by hitting ESC key)
https://bugs.documentfoundation.org/show_bug.cgi?id=137147 --- Comment #5 from Kevin Suo --- Created attachment 170616 --> https://bugs.documentfoundation.org/attachment.cgi?id=170616=edit Screencast in Win10 with Excel 2019 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137147] Provide a way to cancel formula calculation in Calc (e.g., by hitting ESC key)
https://bugs.documentfoundation.org/show_bug.cgi?id=137147 --- Comment #4 from Kevin Suo --- (In reply to s5t1e3v4e3...@hotmail.com from comment #3) I prepared a excel file with the following contents: Sheet1: IDValue1Value2Value3Value4Value5 1 1 2 3 4 5 2 2 3 4 5 6 3 3 4 5 6 7 ... 890361890361890362890363890364890365 Sheet2: IDValue5 1 =vlookup(A1, Sheet1.A:F, 6,0) 2 3 ... 890361 Then I fill down the formula in Sheet2 and immediately hit ESC. In Excel, after I hit ESC, it immediately stopped the fill operation, but it for the cells which were already filled with formula the calculation goes on. Also, I noticed that when I click the save icon, during the save process I have an option of hitting ESC to cancel. Actually, what the ESC do seems to be related to what task is to be canceled, see: https://docs.microsoft.com/en-us/office/vba/api/Excel.Application.EnableCancelKey -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138327] [META] sw_redlinehide regressions (track changes)
https://bugs.documentfoundation.org/show_bug.cgi?id=138327 --- Comment #1 from Aron Budea --- The feature moved out of experimental mode with the following two commits in 6.3 / 6.2: "sw_redlinehide: make layout based Show/Hide mode the default" 6.3: https://cgit.freedesktop.org/libreoffice/core/commit/?id=32902f66e7749b2d06d13f50416be5323a0c0ea9 bibisect-linux-64-6.3: commit 63dec39f2e1dab30a4c3ea8bdcea290600cf6983 Author: Jenkins Build User Date: Tue Dec 18 22:07:56 2018 +0100 source sha:32902f66e7749b2d06d13f50416be5323a0c0ea9 6.2: https://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-6-2=94c1af65367dcbc7272455cf6d4940252a289b62 bibisect-linux-64-6.2: commit ae82aa93d4536e9529688f412def4a23908f1d40 Author: Jenkins Build User Date: Wed Dec 19 08:07:30 2018 +0100 source sha:94c1af65367dcbc7272455cf6d4940252a289b62 Even before experimental mode, earlier in 6.2 it was available by setting an environment variable. https://cgit.freedesktop.org/libreoffice/core/commit/?id=ae3150b1e1863e854224c2e41c7e50991f945dad "sw_redlinehide_2: replace SW_REDLINEHIDE with ExperimentalMode config" bibisect-linux-64-6.2: commit 4bbbfbcef6c5450afe0ce58b1cd5da3da04133ed Author: Jenkins Build User Date: Wed Sep 19 22:08:58 2018 +0200 source sha:ae3150b1e1863e854224c2e41c7e50991f945dad Talks: https://archive.fosdem.org/2019/schedule/event/are_we_optimiert_yet/ https://conference.libreoffice.org/assets/Conference/Tirana/AreOptimiertMStahl.pdf -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 63789] FORMATTING: No image caption possible in Impress or Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=63789 stragu changed: What|Removed |Added Summary|FORMATTING: No image|FORMATTING: No image |caption possible in Impress |caption possible in Impress ||or Draw CC||stephane.guil...@member.fsf ||.org --- Comment #11 from stragu --- Adding Draw to the title, as the two components are tightly linked, and I assume adding the feature to Impress would mean it would be available to Draw. I can confirm it is not available in LO 7.0.4: Version: 7.0.4.2 Build ID: 00(Build:2) CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: gtk3 Locale: en-AU (en-GB); UI: en-GB Ubuntu package version: 1:7.0.4_rc2-0ubuntu0.18.04.2 Calc: threaded I'll add that users might be confused by the possibility to add a Name, Title and Description to the picture (from the right-click menu), without the option to display them anywhere. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141155] New: FILEOPEN: CSV file ignoring enclosing chars
https://bugs.documentfoundation.org/show_bug.cgi?id=141155 Bug ID: 141155 Summary: FILEOPEN: CSV file ignoring enclosing chars Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: dandekar.ab...@gmail.com Created attachment 170615 --> https://bugs.documentfoundation.org/attachment.cgi?id=170615=edit Combined pic Hi All, I have a CSV with comma in data. The data is correctly enclosed with double-quotes. CSV data is : "This is a single, cell" While importing a CSV file with enclosing chars, the preview shows the data correctly. Shown in pic_import_preview.png But after the calc opens, it puts the data in two different cells. Shown in pic_open_calc.png This is major, because once a user opens such a file and accidentaly saves it, calc adds an additional comma separator whereever the data is not with commas. i.e a new column gets added in the CSV file. This will lead to data error for all the downstream applications which are not expecting those columns. Below are the version details: Libreoffice calc Version: 6.4.6.2 Build ID: 1:6.4.6-0ubuntu0.20.04.1 CPU threads: 12; OS: Linux 5.8; UI render: default; VCL: gtk3; Locale: en-IN (en_IN); UI-Language: en-US Calc: threaded ~Abhay D -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44763] Cell styles with localized names, in Pivot Table, replaced with en-US named styles, if pivot changed in en-US UI
https://bugs.documentfoundation.org/show_bug.cgi?id=44763 --- Comment #28 from Robert Gonzalez MX --- Tested with Version: 7.1.1.2 / LibreOffice Community Build ID: fe0b08f4af1bacafe4c7ecc87ce55bb426164676 CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: kf5 Locale: es-MX (es_MX.UTF-8); UI: es-ES Calc: threaded The first thing I did was create a new file and copy the raw data from the 2015 test file with the Spanish UI. Then I made a new pivot table to review the styles. I modified the background color of the pivot table styles, to see if those properties were lost, when changing the UI. I saved the file. I changed the UI to English and restarted LibreOffice, reloaded the file and noticed that the colors were kept and the styles were renamed to their respective English without affecting the pivot table. I saved the file. I changed the UI back to Spanish and opened the file again and there were no impacts. The styles had their respective names in Spanish. >From the above, I could say that this bug is already resolved, however, I decided to review the 2015 test file. When testing with the original test file from 2015, with the UI in Spanish, the pivot table styles were linked to the English names Data Pilot XXX and there were also the names in Spanish. DataPilot Category DataPilot Corner DataPilot Field DataPilot Result DataPilot Title DataPilot Value I modified the styles to add background color to them and saved the file. I changed the UI to English and opened the file, the colors remained intact. When reviewing the styles were the above and the following: Pivot Table Category Pivot Table Corner Pivot Table Field Pivot Table Result Pivot Table Title Pivot Table Value I opened the properties of the pivot table and clicked OK and the styles were updated to "Pivot Table " losing color. Again I modified the styles to add background color to them, saved the file and changed UI to Spanish. I opened the file again and the styles were updated to Spanish without affecting the pivot table. The previous “DataPilot XXX” styles were still there, but no longer assigned. I removed them without affecting the file. >From the above, I could say that this bug is already solved, however, all tables created with previous versions must be updated. I do not update the status, for someone else to test and verify it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141154] In Web View, outline content visibility icons on the far left margin may be mostly hidden
https://bugs.documentfoundation.org/show_bug.cgi?id=141154 --- Comment #1 from j.a.sw...@gmail.com --- "LTR text" above should of course be "RTL text. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135310] [META] Writer outline content visibility bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=135310 j.a.sw...@gmail.com changed: What|Removed |Added Depends on||141154 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=141154 [Bug 141154] In Web View, outline content visibility icons on the far left margin may be mostly hidden -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141154] In Web View, outline content visibility icons on the far left margin may be mostly hidden
https://bugs.documentfoundation.org/show_bug.cgi?id=141154 j.a.sw...@gmail.com changed: What|Removed |Added Blocks||135310 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=135310 [Bug 135310] [META] Writer outline content visibility bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141154] New: In Web View, outline content visibility icons on the far left margin may be mostly hidden
https://bugs.documentfoundation.org/show_bug.cgi?id=141154 Bug ID: 141154 Summary: In Web View, outline content visibility icons on the far left margin may be mostly hidden Product: LibreOffice Version: 3.3.1 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: j.a.sw...@gmail.com Description: >From what I've seen, the way documents are displayed in Web View makes content-visibility icons on the left margin mostly disappear. Suppose a subhead is aligned to the left margin and has a content-visibility icon to the left of it. In Web View, we will have so little space to the left of the subhead that the icon will be mostly hidden. I suppose that with LTR text the same effect would occur on the right. A fix might be for Writer to leave a larger margin in Web View by default. Or to move the icon far enough right to be seen, and move left-justified subheads far enough right to allow for the icon. Steps to Reproduce: 1.Create a document with subheads and text. 2.Toggle "Show outline content visibility button" on 3.In menu: View--> Web Actual Results: Content-visibility icons are mostly hidden Expected Results: The icons should be fully visible. Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: Version: 7.2.0.0.alpha0+ / LibreOffice Community Build ID: a9bdb74c0309fca470abdaabbddea84798cbaa83 CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-03-13_09:20:13 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Opinions are like languages: Everyone has (at least) one
On 19/03/2021 19:01, John wrote: to get lectured on English by a German If we were weighing people's opinion based on their native language, which I advise against, German-speakers would fare pretty well since our languages are so closely related. Ime, foreigners tend to have a better grasp of English than many of us native speakers, since we are mostly not taught our own language. I learnt nearly all the formalities of English in my Latin lessons! The two big problems for foreigners are our large vocabulary (since we've nicked so many words from elsewhere), and (a problem with all languages) where the literal meaning and what we really mean aren't necessarily the same ... Cheers, Wol ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 140288] Crash with zero-size window when running a macro
https://bugs.documentfoundation.org/show_bug.cgi?id=140288 --- Comment #11 from Jon Rubin --- I'm still getting this crash in 7.1.2 build fe0b08f4af1bacafe4c7ecc87ce55bb426164676 I've tried to submit a crash report, but that just stops responding. Can still use this macro when not running Skia -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Alternative master/main branch proposal (Re: ANN: renaming of master branch to "main" for core repository and submodules (dictionaries, help, translations))
On 21/03/2021 10:46, Katarina Behrens wrote: C'mon folks, this is not a controversial or complicated issue in any way If it isn't controversial, why is it causing so much controversy? Technical effort to make the change is minimal. Social or indeed human impact of the change is net positive. That few folks who happen to have the largest bullhorn believe otherwise doesn't change the fact 'Where is my freedom to use whatever terminology I please regardless of how it affects others' is a bad take I *personally* have *suffered* from exactly this attitude! When Groklaw was live, I was unable to take part in any discussion that involved race, because the word "Black" was unacceptable to PJ, and the alternative would be offensive to the black people I know because (a) they are not American, and (b) they do not classify themselves as black - they are Nigerian, or Caribbean, or whatever. If you take it upon yourself to remove words from my vocabulary, you are gagging me, especially if you dictate there is no reasonable alternative. Oh - and by damaging the ability to discuss what is wrong, you make it harder to put it right! 'Let's wait for some random gits to come to their senses and only then follow the suit' is a bad take Just go ahead and rename, for f sake Just for the record - I was in full agreement with the Groklaw rule of "PJ's website, PJ's rules". And with regard to this renaming, I have no strong feelings either way. But I *do* have a *massive* problem with people bulldozing their opinions over other peoples' serious concerns - and yes I *am* concerned where all this "form over substance" political correctness is headed ... Cheers, Wol ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 137741] Fields objects should be navigable in Navigator and the Find bar
https://bugs.documentfoundation.org/show_bug.cgi?id=137741 Jim Raykowski changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |rayk...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: ANN: renaming of master branch to "main" for core repository and submodules (dictionaries, help, translations)
On 18/03/2021 17:35, Michael Meeks wrote: I do agree it is possible to carry this far too far. However its easy to see how things like the unthinking use of eg. 'blacklist' can be seen as bad - that seems like a slam-dunk to me. The problem is when it's assumed you're being racist when the words have nothing whatsoever to do with race - blacklist is a case in point. Or - as you may be aware of - the argument we've had about pubs called "The Black Boy". There's an Oxfordshire pub where the sign is a Cavalier with long black locks - or a Kent pub where the sign is a grimy miner. No race connection whatsoever, and in the Oxford case I think it pre-dates the slave trade. The worse example I came across recently was somebody objecting to the word "negro" "because its only possible use is racist" ... hang on a sec - it's pretty much exactly the normal spanish word for "black"! From the Latin word "negro" or whatever it is ... Cheers, Wol ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 137741] Fields objects should be navigable in Navigator and the Find bar
https://bugs.documentfoundation.org/show_bug.cgi?id=137741 --- Comment #10 from Jim Raykowski --- Created attachment 170614 --> https://bugs.documentfoundation.org/attachment.cgi?id=170614=edit screen shot of various field content displayed in the Navigator Here is a screen shot of a bit more 'progress' Maybe at this point it would be best to put the patch in and leave the sort fields by document location (header, footer, page, etc) for a future enhancement? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 78c33a4c3d1633b97049874305b3b49b820395a2 Author: Seth Chaiklin AuthorDate: Sun Mar 21 23:55:02 2021 +0100 Commit: Gerrit Code Review CommitDate: Sun Mar 21 23:55:02 2021 +0100 Update git submodules * Update helpcontent2 from branch 'master' to fe4dc2b8a258d4c74f203365eea755b3ac43653e - related: tdf#140949 - update help because of command name change tdf#140949 changes "Format - Page" to "Format - Page Style" in Calc. This makes it possible to use the same embed for "howtoget" as is already made for Writer. Change-Id: I8649712667029fe660ac964447a7c22ba8435d12 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/112795 Reviewed-by: Seth Chaiklin Tested-by: Jenkins diff --git a/helpcontent2 b/helpcontent2 index b672be3b0250..fe4dc2b8a258 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit b672be3b0250975f1f1879cc2ee4db3b61721838 +Subproject commit fe4dc2b8a258d4c74f203365eea755b3ac43653e ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/scalc/01/0507.xhp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit fe4dc2b8a258d4c74f203365eea755b3ac43653e Author: Seth Chaiklin AuthorDate: Sun Mar 21 23:40:58 2021 +0100 Commit: Seth Chaiklin CommitDate: Sun Mar 21 23:55:02 2021 +0100 related: tdf#140949 - update help because of command name change tdf#140949 changes "Format - Page" to "Format - Page Style" in Calc. This makes it possible to use the same embed for "howtoget" as is already made for Writer. Change-Id: I8649712667029fe660ac964447a7c22ba8435d12 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/112795 Reviewed-by: Seth Chaiklin Tested-by: Jenkins diff --git a/source/text/scalc/01/0507.xhp b/source/text/scalc/01/0507.xhp index 8be1af32e..ee875fe83 100644 --- a/source/text/scalc/01/0507.xhp +++ b/source/text/scalc/01/0507.xhp @@ -39,7 +39,7 @@ Opens a dialog where you can define the appearance of all pages in your document. - + ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 141152] A basic SUM function doesn't work
https://bugs.documentfoundation.org/show_bug.cgi?id=141152 --- Comment #4 from Uwe Auer --- (In reply to John Hallesy from comment #0) > If I run this spreadsheet on Google Sheets, the formula correctly reports > $1716.10 Couldn't understand why 39 negative numbers should correctly yield positive sum. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141152] A basic SUM function doesn't work
https://bugs.documentfoundation.org/show_bug.cgi?id=141152 --- Comment #3 from Uwe Auer --- (In reply to John Hallesy from comment #0) > If I run this spreadsheet on Google Sheets, the formula correctly reports > $1716.10 Please add the sheet itself to analyze your sheet directly. The pure textual data within you report are pointless for investigation puposes without all other information available in a real odf formatted file (as you surely know: What is shown not necessarily is identical to what is really stored in a cell) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141124] Part of TOC Index disappear after index update
https://bugs.documentfoundation.org/show_bug.cgi?id=141124 Georgy changed: What|Removed |Added Attachment #170610|How it looks after index|How it looks after index description|update |update (Linux) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141124] Part of TOC Index disappear after index update
https://bugs.documentfoundation.org/show_bug.cgi?id=141124 --- Comment #10 from Georgy --- (In reply to Roman Kuznetsov from comment #6) > (In reply to Georgy from comment #5) > > (In reply to Roman Kuznetsov from comment #3) > > > no repro in > > > > > > > Did you install font used in document prior to open document and update > > index? > > Yes I added some screenshots. Are my results different from yours? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140940] Formula Editor scaling of glyphs into sm nodes -- Skia font rendering broken
https://bugs.documentfoundation.org/show_bug.cgi?id=140940 Pierre C changed: What|Removed |Added Version|7.1.1.1 rc |7.2.0.0.alpha0+ Master --- Comment #9 from Pierre C --- As the bug in #140974 is solved in 7.1.2.1 (or I'm wrong) adjusting the earliest version affected to its initial value -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141124] Part of TOC Index disappear after index update
https://bugs.documentfoundation.org/show_bug.cgi?id=141124 --- Comment #9 from Georgy --- Created attachment 170613 --> https://bugs.documentfoundation.org/attachment.cgi?id=170613=edit This is how TOC should look. This is how it should be after TOC update. To fix it press enter at the end of last visible TOC item. Then other items will become visible. Removed empty paragraphs between TOC items. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141152] A basic SUM function doesn't work
https://bugs.documentfoundation.org/show_bug.cgi?id=141152 --- Comment #2 from Uwe Auer --- Created attachment 170612 --> https://bugs.documentfoundation.org/attachment.cgi?id=170612=edit Insert data from bug report into calc sheet and calculate sum No repro Version: 7.1.1.2 / LibreOffice Community Build ID: fe0b08f4af1bacafe4c7ecc87ce55bb426164676 CPU threads: 8; OS: Linux 5.3; UI render: default; VCL: kf5 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded ( =SUM(C2:C40) yields -$3,030.88 - see attached file) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141124] Part of TOC Index disappear after index update
https://bugs.documentfoundation.org/show_bug.cgi?id=141124 --- Comment #8 from Georgy --- Created attachment 170611 --> https://bugs.documentfoundation.org/attachment.cgi?id=170611=edit LO 7.2 devel on Windows. 4 last TOC items are not visible. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141152] A basic SUM function doesn't work
https://bugs.documentfoundation.org/show_bug.cgi?id=141152 --- Comment #1 from Uwe Auer --- *** Bug 141153 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141153] A basic SUM function doesn't work
https://bugs.documentfoundation.org/show_bug.cgi?id=141153 Uwe Auer changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Uwe Auer --- *** This bug has been marked as a duplicate of bug 141152 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89477] Images and objects should have an option "Anchor to page (moves with page)" to deal with page breaks
https://bugs.documentfoundation.org/show_bug.cgi?id=89477 --- Comment #19 from Mike Kaganski --- (In reply to Stanislav Horacek from comment #17) > (I think that the most intuitive mental model is "fixing image within the > page -> anchor it to the page" and "moving image with the paragraph -> > anchor it to the paragraph".) Note that you can't avoid making some kind of a link to *content* when you want your data to move *with content*. So how to call that link? We call that rather flexible link "anchoring" (anchored ship is not immovable). Note how you use term "position" yourself, when describe that the object needs to stay on the same place on page: (from comment #15) > I want to anchor an object such a way that it moves together with some > page content while it stays at the same *position* relatively to the page And we call that exactly that way: position, which is different from anchor. So it's just a learning curve - and a matter of asking a "how do I" question, before filing a bug ;-P -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141153] New: A basic SUM function doesn't work
https://bugs.documentfoundation.org/show_bug.cgi?id=141153 Bug ID: 141153 Summary: A basic SUM function doesn't work Product: LibreOffice Version: 7.0.1.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: halles...@gmail.com A basic sum function does not work. The zero number reported below is the result of the SUM function SUM -(C2:C40) If I run this spreadsheet on Google Sheets, the formula correctly reports $1716.10 Please address this basic issue. I have lost faith in the accuracy of LibreOffice tools. DateDescription Amount AccountType 2021-03-11 796229 POS CHCKING SIG 03/10 09:43 WALGREENS #6111 LAFAYETTE CO 06284676 796229 $-339.99HSA 2021-03-03 225730 POS CHCKING PIN 03/03 15:31 WALGREENS 1830 30TH BOULDER CO 02482T32 22573$-15.23 HSA 2021-03-03 202207 POS CHCKING PIN 03/03 15:18 KING SOOP 1650 30TH BOULDER CO 11006165 20220$-21.22 HSA 2021-03-03 703007 POS CHCKING PIN 03/03 10:20 WALGREENS 1600 COAL SUPERIOR CO 06467T41 7030$-4.39 HSA 2021-02-16 443543 POS CHCKING SIG 02/13 05:11 BRIOVARX 800-562-6223 IL 20040269 443543 $-5.00 HSA 2021-02-11 45227 POS CHCKING SIG 02/11 05:19 OPTUMRX 800-562-6223 CA 84821867 045227 $-136.51HSA 2021-01-27 314425 POS CHCKING SIG 01/26 04:55 COLO MEDICAL PSYCHI BOULDER CO 10100130 31442$-299.85HSA 2021-01-26 127354 POS CHCKING PIN 01/26 14:42 KING SOOP 1650 30TH BOULDER CO 11006167 12735$-11.16 HSA 2020-12-22 845846 POS CHCKING SIG 12/22 04:53 BRIOVARX 800-562-6223 IL 94833831 845846 $-5.00 HSA 2020-12-22 139291 POS CHCKING PIN 12/21 18:02 WALGREENS 1600 COAL SUPERIOR CO 06467T41 1392$-11.32 HSA 2020-11-20 396753 POS CHCKING SIG 11/20 04:39 BRIOVARX 800-562-6223 IL 18416229 396753 $-5.00 HSA 2020-11-18 44971 POS CHCKING PIN 11/17 17:01 WALGREENS 1600 COAL SUPERIOR CO 06467T41 04497$-11.32 HSA 2020-11-05 677055 POS CHCKING SIG 11/04 04:46 BOULDER EYE SURGEON 303-4443000 CO 06849800 6$-23.04 HSA 2020-10-29 942276 POS CHCKING SIG 10/29 04:48 BRIOVARX 800-562-6223 IL 78966422 942276 $-5.00 HSA 2020-10-15 881186 POS CHCKING SIG 10/14 05:12 COLO MEDICAL PSYCHI BOULDER CO 13400052 88118$-17.18 HSA 2020-10-01 135482 POS CHCKING PIN 10/01 15:24 KING SOOP 1650 30TH BOULDER CO 11006167 13548$-13.75 HSA 2020-09-29 696255 POS CHCKING SIG 09/28 01:54 PHR*COLORADORETINA 303-2611600 CO 67382042 69$-23.25 HSA 2020-09-23 760696 POS CHCKING SIG 09/23 05:25 OPTUMRX 800-562-6223 CA 80365775 760696 $-87.66 HSA 2020-09-23 683284 POS CHCKING SIG 09/23 05:37 OPTUMRX 800-562-6223 CA 80347492 683284 $-28.78 HSA 2020-09-15 74752 POS CHCKING SIG 09/14 01:30 PHR*COLORADORETINA 303-2611600 CO 19295201 074$-23.25 HSA 2020-09-15 588986 POS CHCKING SIG 09/14 05:07 COLO MEDICAL PSYCHI BOULDER CO 11200070 58898$-34.37 HSA 2020-09-14 146706 POS CHCKING SIG 09/12 04:59 BRIOVARX 800-562-6223 IL 95931843 146706 $-5.00 HSA 2020-08-20 787932 POS CHCKING SIG 08/19 04:55 COLO MEDICAL PSYCHI BOULDER CO 19600058 78793$-17.19 HSA 2020-08-20 259651 POS CHCKING PIN 08/19 16:36 KING SOOP 1650 30TH BOULDER CO 11006167 25965$-11.58 HSA 2020-08-05 117176 POS CHCKING PIN 08/05 15:47 KING SOOP 1650 30TH BOULDER CO 11006166 11717$-1.30 HSA 2020-07-23 10539 POS CHCKING PIN 07/22 18:11 KING SOOP 1650 30TH BOULDER CO 11006166 010539$-11.56 HSA 2020-07-23 648252 POS CHCKING SIG 07/22 05:04 COLO MEDICAL PSYCHI BOULDER CO 17800050 64825$-34.36 HSA 2020-07-15 896136 POS CHCKING SIG 07/14 09:56 ASSOCIATES IN FAMIL FORT COLLINS CO 98696979 $-162.54HSA 2020-07-06 89576 POS CHCKING SIG 07/05 04:03 PHR*COLORADORETINA 303-2611600 CO 73878933 089$-23.25 HSA 2020-06-23 656255 POS CHCKING SIG 06/23 04:55 OPTUMRX 800-562-6223 CA 99640363 656255 $-87.55 HSA 2020-06-22 375126 POS CHCKING SIG 06/20 04:42 OPTUMRX 800-562-6223 CA 12670827 375126 $-11.44 HSA 2020-06-17 41341 POS CHCKING PIN 06/16 18:13 WALGREENS 1600 COAL SUPERIOR CO 06467T41 04134$-12.29 HSA 2020-05-07 59695 POS CHCKING PIN 05/06 18:03 WALGREENS 1600 COAL SUPERIOR CO 06467T42 05969$-5.54 HSA 2020-05-04 256624 POS CHCKING SIG 05/02 01:51 PHR*COLORADORETINA 303-2611600 CO 91499877 25$-23.25 HSA 2020-04-09 EARNINGS ON EXCESS CONTRIBUTION 2019$-2.32 HSA 2020-04-09 335894 POS CHCKING PIN 04/08 17:45 WALGREENS 1600 COAL SUPERIOR CO 06467T41 3358$-3.21 HSA 2020-04-09 EXCESS CONTRIBUTION DISTRIBUTION 2019 $-1487.55 HSA 2020-03-25 232962 POS CHCKING
[Libreoffice-bugs] [Bug 141152] New: A basic SUM function doesn't work
https://bugs.documentfoundation.org/show_bug.cgi?id=141152 Bug ID: 141152 Summary: A basic SUM function doesn't work Product: LibreOffice Version: 7.0.1.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: halles...@gmail.com A basic sum function does not work. The zero number reported below is the result of the SUM function SUM -(C2:C40) If I run this spreadsheet on Google Sheets, the formula correctly reports $1716.10 Please address this basic issue. I have lost faith in the accuracy of LibreOffice tools. DateDescription Amount AccountType 2021-03-11 796229 POS CHCKING SIG 03/10 09:43 WALGREENS #6111 LAFAYETTE CO 06284676 796229 $-339.99HSA 2021-03-03 225730 POS CHCKING PIN 03/03 15:31 WALGREENS 1830 30TH BOULDER CO 02482T32 22573$-15.23 HSA 2021-03-03 202207 POS CHCKING PIN 03/03 15:18 KING SOOP 1650 30TH BOULDER CO 11006165 20220$-21.22 HSA 2021-03-03 703007 POS CHCKING PIN 03/03 10:20 WALGREENS 1600 COAL SUPERIOR CO 06467T41 7030$-4.39 HSA 2021-02-16 443543 POS CHCKING SIG 02/13 05:11 BRIOVARX 800-562-6223 IL 20040269 443543 $-5.00 HSA 2021-02-11 45227 POS CHCKING SIG 02/11 05:19 OPTUMRX 800-562-6223 CA 84821867 045227 $-136.51HSA 2021-01-27 314425 POS CHCKING SIG 01/26 04:55 COLO MEDICAL PSYCHI BOULDER CO 10100130 31442$-299.85HSA 2021-01-26 127354 POS CHCKING PIN 01/26 14:42 KING SOOP 1650 30TH BOULDER CO 11006167 12735$-11.16 HSA 2020-12-22 845846 POS CHCKING SIG 12/22 04:53 BRIOVARX 800-562-6223 IL 94833831 845846 $-5.00 HSA 2020-12-22 139291 POS CHCKING PIN 12/21 18:02 WALGREENS 1600 COAL SUPERIOR CO 06467T41 1392$-11.32 HSA 2020-11-20 396753 POS CHCKING SIG 11/20 04:39 BRIOVARX 800-562-6223 IL 18416229 396753 $-5.00 HSA 2020-11-18 44971 POS CHCKING PIN 11/17 17:01 WALGREENS 1600 COAL SUPERIOR CO 06467T41 04497$-11.32 HSA 2020-11-05 677055 POS CHCKING SIG 11/04 04:46 BOULDER EYE SURGEON 303-4443000 CO 06849800 6$-23.04 HSA 2020-10-29 942276 POS CHCKING SIG 10/29 04:48 BRIOVARX 800-562-6223 IL 78966422 942276 $-5.00 HSA 2020-10-15 881186 POS CHCKING SIG 10/14 05:12 COLO MEDICAL PSYCHI BOULDER CO 13400052 88118$-17.18 HSA 2020-10-01 135482 POS CHCKING PIN 10/01 15:24 KING SOOP 1650 30TH BOULDER CO 11006167 13548$-13.75 HSA 2020-09-29 696255 POS CHCKING SIG 09/28 01:54 PHR*COLORADORETINA 303-2611600 CO 67382042 69$-23.25 HSA 2020-09-23 760696 POS CHCKING SIG 09/23 05:25 OPTUMRX 800-562-6223 CA 80365775 760696 $-87.66 HSA 2020-09-23 683284 POS CHCKING SIG 09/23 05:37 OPTUMRX 800-562-6223 CA 80347492 683284 $-28.78 HSA 2020-09-15 74752 POS CHCKING SIG 09/14 01:30 PHR*COLORADORETINA 303-2611600 CO 19295201 074$-23.25 HSA 2020-09-15 588986 POS CHCKING SIG 09/14 05:07 COLO MEDICAL PSYCHI BOULDER CO 11200070 58898$-34.37 HSA 2020-09-14 146706 POS CHCKING SIG 09/12 04:59 BRIOVARX 800-562-6223 IL 95931843 146706 $-5.00 HSA 2020-08-20 787932 POS CHCKING SIG 08/19 04:55 COLO MEDICAL PSYCHI BOULDER CO 19600058 78793$-17.19 HSA 2020-08-20 259651 POS CHCKING PIN 08/19 16:36 KING SOOP 1650 30TH BOULDER CO 11006167 25965$-11.58 HSA 2020-08-05 117176 POS CHCKING PIN 08/05 15:47 KING SOOP 1650 30TH BOULDER CO 11006166 11717$-1.30 HSA 2020-07-23 10539 POS CHCKING PIN 07/22 18:11 KING SOOP 1650 30TH BOULDER CO 11006166 010539$-11.56 HSA 2020-07-23 648252 POS CHCKING SIG 07/22 05:04 COLO MEDICAL PSYCHI BOULDER CO 17800050 64825$-34.36 HSA 2020-07-15 896136 POS CHCKING SIG 07/14 09:56 ASSOCIATES IN FAMIL FORT COLLINS CO 98696979 $-162.54HSA 2020-07-06 89576 POS CHCKING SIG 07/05 04:03 PHR*COLORADORETINA 303-2611600 CO 73878933 089$-23.25 HSA 2020-06-23 656255 POS CHCKING SIG 06/23 04:55 OPTUMRX 800-562-6223 CA 99640363 656255 $-87.55 HSA 2020-06-22 375126 POS CHCKING SIG 06/20 04:42 OPTUMRX 800-562-6223 CA 12670827 375126 $-11.44 HSA 2020-06-17 41341 POS CHCKING PIN 06/16 18:13 WALGREENS 1600 COAL SUPERIOR CO 06467T41 04134$-12.29 HSA 2020-05-07 59695 POS CHCKING PIN 05/06 18:03 WALGREENS 1600 COAL SUPERIOR CO 06467T42 05969$-5.54 HSA 2020-05-04 256624 POS CHCKING SIG 05/02 01:51 PHR*COLORADORETINA 303-2611600 CO 91499877 25$-23.25 HSA 2020-04-09 EARNINGS ON EXCESS CONTRIBUTION 2019$-2.32 HSA 2020-04-09 335894 POS CHCKING PIN 04/08 17:45 WALGREENS 1600 COAL SUPERIOR CO 06467T41 3358$-3.21 HSA 2020-04-09 EXCESS CONTRIBUTION DISTRIBUTION 2019 $-1487.55 HSA 2020-03-25 232962 POS CHCKING
[Libreoffice-commits] core.git: basic/CppunitTest_basic_macros.mk basic/qa basic/source
basic/CppunitTest_basic_macros.mk |1
basic/qa/cppunit/test_global_as_new.cxx | 86
basic/source/comp/dim.cxx | 27 ++
basic/source/inc/runtime.hxx|1
basic/source/runtime/runtime.cxx| 34 ++--
5 files changed, 143 insertions(+), 6 deletions(-)
New commits:
commit b80069e133d30e80e50a792b2bc1d0c2f9a31bfa
Author: John
AuthorDate: Thu Mar 4 01:50:25 2021 -0500
Commit: Mike Kaganski
CommitDate: Sun Mar 21 21:54:11 2021 +0100
tdf#88442 SBasic: Don't double-initialize a Global ... As New ...
"As New" variables use lazy instantiation, but that should not re-apply each
time one re-enters the module. If the object is still there, don't replace
it.
Change-Id: Ic568a56b93db9bc9139d434d97a4a4deb05840df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112018
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/basic/CppunitTest_basic_macros.mk
b/basic/CppunitTest_basic_macros.mk
index 6cce94737113..c2c1eb5b7a04 100644
--- a/basic/CppunitTest_basic_macros.mk
+++ b/basic/CppunitTest_basic_macros.mk
@@ -19,6 +19,7 @@ $(eval $(call
gb_CppunitTest_add_exception_objects,basic_macros, \
basic/qa/cppunit/test_language_conditionals \
basic/qa/cppunit/test_nested_struct \
basic/qa/cppunit/test_vba \
+ basic/qa/cppunit/test_global_as_new \
))
$(eval $(call gb_CppunitTest_use_libraries,basic_macros, \
diff --git a/basic/qa/cppunit/test_global_as_new.cxx
b/basic/qa/cppunit/test_global_as_new.cxx
new file mode 100644
index ..db64a974cb0f
--- /dev/null
+++ b/basic/qa/cppunit/test_global_as_new.cxx
@@ -0,0 +1,86 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4;
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+namespace
+{
+class GlobalAsNewTest : public CppUnit::TestFixture
+{
+void testMaintainsValueAcrossCalls();
+
+CPPUNIT_TEST_SUITE(GlobalAsNewTest);
+CPPUNIT_TEST(testMaintainsValueAcrossCalls);
+CPPUNIT_TEST_SUITE_END();
+
+BasicDLL lib;
+StarBASICRef interpreter;
+
+SbModuleRef Module()
+{
+interpreter = new StarBASIC();
+auto mod = interpreter->MakeModule("GlobalAsNew", R"BAS(
+Global aDate As New "com.sun.star.util.Date"
+
+Function GetDateAsString As String
+DIM local_Date As New "com.sun.star.util.Date"
+GetDateAsString = TRIM(STR(aDate.Year)) + "-" + TRIM(STR(local_Date.Year))
+ TRIM(STR(aDate.Month)) + "-" + TRIM(STR(aDate.Day))
+End Function
+
+Function SetDate
+ aDate.Month = 6
+ aDate.Day = 30
+ aDate.Year = 2019
+ SetDate = GetDateAsString()
+End Function
+
+)BAS");
+CPPUNIT_ASSERT(mod->Compile());
+CPPUNIT_ASSERT_EQUAL(StarBASIC::GetErrBasic(), ERRCODE_NONE);
+CPPUNIT_ASSERT_EQUAL(SbxBase::GetError(), ERRCODE_NONE);
+CPPUNIT_ASSERT(mod->IsCompiled());
+return mod;
+}
+};
+
+void GlobalAsNewTest::testMaintainsValueAcrossCalls()
+{
+auto m = Module();
+auto GetDateAsString = m->FindMethod("GetDateAsString",
SbxClassType::Method);
+CPPUNIT_ASSERT_MESSAGE("Could not Find GetDateAsString in module",
GetDateAsString != nullptr);
+
+// There is no SbxMethod::call(), the basic code is exercised here in the
copy ctor
+SbxVariableRef returned = new SbxMethod{ *GetDateAsString };
+CPPUNIT_ASSERT(returned->IsString());
+//0-00-0 is the result of reading the default-initialized date
+CPPUNIT_ASSERT_EQUAL(OUString{ "0-00-0" }, returned->GetOUString());
+
+auto SetDate = m->FindMethod("SetDate", SbxClassType::Method);
+CPPUNIT_ASSERT_MESSAGE("Could not Find SetDate in module", SetDate !=
nullptr);
+returned = new SbxMethod{ *SetDate };
+CPPUNIT_ASSERT(returned->IsString());
+OUString set_val("2019-06-30");
+CPPUNIT_ASSERT_EQUAL(set_val, returned->GetOUString());
+
+returned = new SbxMethod{ *GetDateAsString };
+CPPUNIT_ASSERT(returned->IsString());
+//tdf#88442 The global should have maintained its state!
+CPPUNIT_ASSERT_EQUAL(set_val, returned->GetOUString());
+}
+
+// Put the test suite in the registry
+CPPUNIT_TEST_SUITE_REGISTRATION(GlobalAsNewTest);
+
+} // namespace
diff --git a/basic/source/comp/dim.cxx b/basic/source/comp/dim.cxx
index 20396cd729ad..cf14d1c7818c 100644
--- a/basic/source/comp/dim.cxx
+++ b/basic/source/comp/dim.cxx
@@ -446,12 +446,39 @@ void SbiParser::DefVar( SbiOpcode eOp, bool bStatic )
{
SbiExpression aExpr( this, *pDef );
aExpr.Gen();
+
+/* tdf#88442
+ * Don't initialize
[Libreoffice-bugs] [Bug 89477] Images and objects should have an option "Anchor to page (moves with page)" to deal with page breaks
https://bugs.documentfoundation.org/show_bug.cgi?id=89477 --- Comment #18 from Mike Kaganski --- (In reply to Stanislav Horacek from comment #17) > However, when such an image (anchored to the paragraph and with position > relative to the page) is moved manually, then the position is changed to > relative to the paragraph - which would be a stopper if manual adjusting of > position is needed. But this is another issue... ... to which I wholeheartedly agree - IMO, manual dragging should not change the type of positioning, just the position itself. We also need a drag mode that only moves anchor without moving object, and a mode that only moves object, without moving anchor ... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/outdev/clipping.cxx |1 +
vcl/source/outdev/curvedshapes.cxx |4
vcl/source/outdev/font.cxx |6 +-
vcl/source/outdev/hatch.cxx |1 +
vcl/source/outdev/line.cxx |2 ++
vcl/source/outdev/nativecontrols.cxx |4
vcl/source/outdev/outdev.cxx | 13 +
vcl/source/outdev/outdevstate.cxx|3 +++
vcl/source/outdev/pixel.cxx |3 +++
vcl/source/outdev/polygon.cxx|5 -
vcl/source/outdev/polyline.cxx |4
vcl/source/outdev/rect.cxx |5 +
vcl/source/outdev/text.cxx |4
vcl/source/outdev/textline.cxx |1 +
vcl/source/outdev/transparent.cxx|2 ++
vcl/source/window/window2.cxx|1 +
16 files changed, 57 insertions(+), 2 deletions(-)
New commits:
commit f2c457c99ae3f0e364830a7642b4db9e7fb4c586
Author: Caolán McNamara
AuthorDate: Sun Mar 21 15:27:09 2021 +
Commit: Caolán McNamara
CommitDate: Sun Mar 21 21:48:29 2021 +0100
cid#1473858 silence bogus Dereference after null check
Change-Id: Iec344c1194e34538bedd5aa5bb8df3e6b233dfee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112850
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/source/outdev/clipping.cxx b/vcl/source/outdev/clipping.cxx
index b1c116bb31f4..0570719a15fa 100644
--- a/vcl/source/outdev/clipping.cxx
+++ b/vcl/source/outdev/clipping.cxx
@@ -80,6 +80,7 @@ bool OutputDevice::SelectClipRegion( const vcl::Region&
rRegion, SalGraphics* pG
{
if( !mpGraphics && !AcquireGraphics() )
return false;
+assert(mpGraphics);
pGraphics = mpGraphics;
}
diff --git a/vcl/source/outdev/curvedshapes.cxx
b/vcl/source/outdev/curvedshapes.cxx
index ef2ccc72f756..de7379dd32bb 100644
--- a/vcl/source/outdev/curvedshapes.cxx
+++ b/vcl/source/outdev/curvedshapes.cxx
@@ -43,6 +43,7 @@ void OutputDevice::DrawEllipse( const tools::Rectangle& rRect
)
// we need a graphics
if ( !mpGraphics && !AcquireGraphics() )
return;
+assert(mpGraphics);
if ( mbInitClipRegion )
InitClipRegion();
@@ -88,6 +89,7 @@ void OutputDevice::DrawArc( const tools::Rectangle& rRect,
// we need a graphics
if ( !mpGraphics && !AcquireGraphics() )
return;
+assert(mpGraphics);
if ( mbInitClipRegion )
InitClipRegion();
@@ -129,6 +131,7 @@ void OutputDevice::DrawPie( const tools::Rectangle& rRect,
// we need a graphics
if ( !mpGraphics && !AcquireGraphics() )
return;
+assert(mpGraphics);
if ( mbInitClipRegion )
InitClipRegion();
@@ -177,6 +180,7 @@ void OutputDevice::DrawChord( const tools::Rectangle& rRect,
// we need a graphics
if ( !mpGraphics && !AcquireGraphics() )
return;
+assert(mpGraphics);
if ( mbInitClipRegion )
InitClipRegion();
diff --git a/vcl/source/outdev/font.cxx b/vcl/source/outdev/font.cxx
index e145d2bebbad..45a4e514e04f 100644
--- a/vcl/source/outdev/font.cxx
+++ b/vcl/source/outdev/font.cxx
@@ -141,6 +141,7 @@ bool OutputDevice::AddTempDevFont( const OUString&
rFileURL, const OUString& rFo
if( !mpGraphics && !AcquireGraphics() )
return false;
+assert(mpGraphics);
bool bRC = mpGraphics->AddTempDevFont( mxFontCollection.get(), rFileURL,
rFontName );
if( !bRC )
@@ -489,7 +490,7 @@ void OutputDevice::RefreshFontData( const bool
bNewFontLists )
void OutputDevice::ImplRefreshFontData( const bool bNewFontLists )
{
if (bNewFontLists && AcquireGraphics())
-mpGraphics->GetDevFontList( mxFontCollection.get() );
+mpGraphics->GetDevFontList( mxFontCollection.get() );
}
void OutputDevice::ImplUpdateFontData()
@@ -864,6 +865,7 @@ void OutputDevice::ImplInitFontList() const
if( !(mpGraphics || AcquireGraphics()) )
return;
+assert(mpGraphics);
SAL_INFO( "vcl.gdi", "OutputDevice::ImplInitFontList()" );
mpGraphics->GetDevFontList(mxFontCollection.get());
@@ -895,6 +897,7 @@ bool OutputDevice::InitFont() const
else if (!mbInitFont)
return true;
+assert(mpGraphics);
mpGraphics->SetFont(mpFontInstance.get(), 0);
mbInitFont = false;
return true;
@@ -929,6 +932,7 @@ bool OutputDevice::ImplNewFont() const
SAL_WARN("vcl.gdi", "OutputDevice::ImplNewFont(): no Graphics, no
Font");
return false;
}
+assert(mpGraphics);
ImplInitFontList();
diff --git a/vcl/source/outdev/hatch.cxx b/vcl/source/outdev/hatch.cxx
index 775253bbba9a..8b62fcf10375 100644
--- a/vcl/source/outdev/hatch.cxx
+++ b/vcl/source/outdev/hatch.cxx
@@ -87,6 +87,7 @@ void OutputDevice::DrawHatch( const tools::PolyPolygon&
rPolyPoly, const Hatch&
if( !mpGraphics && !AcquireGraphics() )
return;
+assert(mpGraphics);
if( mbInitClipRegion )
InitClipRegion();
diff --git
[Libreoffice-bugs] [Bug 139579] Impress does not import SVG graphic with xml and DOCTYPE tag
https://bugs.documentfoundation.org/show_bug.cgi?id=139579 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Resolution|FIXED |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114220] [META] Drag and drop bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=114220 Bug 114220 depends on bug 139579, which changed state. Bug 139579 Summary: Impress does not import SVG graphic with xml and DOCTYPE tag https://bugs.documentfoundation.org/show_bug.cgi?id=139579 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88278] [META] SVG import image filter (all modules)
https://bugs.documentfoundation.org/show_bug.cgi?id=88278 Bug 88278 depends on bug 139579, which changed state. Bug 139579 Summary: Impress does not import SVG graphic with xml and DOCTYPE tag https://bugs.documentfoundation.org/show_bug.cgi?id=139579 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139579] Impress does not import SVG graphic with xml and DOCTYPE tag
https://bugs.documentfoundation.org/show_bug.cgi?id=139579 liboffb...@fabbrain.de changed: What|Removed |Added Resolution|--- |FIXED Status|NEEDINFO|RESOLVED --- Comment #2 from liboffb...@fabbrain.de --- (Un)Fortunately I can't reproduce it any more and will mark the ticket as "resolved"/"fixed". For the sake of completeness - this is the info from the about dialog: Version: 7.0.3.1 Build ID: 00(Build:1) CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: x11 Locale: de-DE (en_US.UTF-8); UI: en-US Ubuntu package version: 1:7.0.3-0ubuntu0.20.10.1 Calc: threaded Thank you for having a look at the issue, Roman. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141143] Writer 7.0.5.2 : small table of contents splitted on 2 pages - Build ID: 64390860c6cd0aca4beafafcfd84613dd9dfb63a
https://bugs.documentfoundation.org/show_bug.cgi?id=141143 Julien Nabet changed: What|Removed |Added Version|7.0.4.2 release |7.0.5.2 release -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89477] Images and objects should have an option "Anchor to page (moves with page)" to deal with page breaks
https://bugs.documentfoundation.org/show_bug.cgi?id=89477 --- Comment #17 from Stanislav Horacek --- OK, I see your point - thanks for that! I admit I've never considered that anchoring to a floating paragraph/character could actually mean fixing the position within the page. (I think that the most intuitive mental model is "fixing image within the page -> anchor it to the page" and "moving image with the paragraph -> anchor it to the paragraph".) However, when such an image (anchored to the paragraph and with position relative to the page) is moved manually, then the position is changed to relative to the paragraph - which would be a stopper if manual adjusting of position is needed. But this is another issue... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 070650905bd133055c625888f46b35191e696278 Author: Seth Chaiklin AuthorDate: Sun Mar 21 20:53:40 2021 +0100 Commit: Gerrit Code Review CommitDate: Sun Mar 21 20:53:40 2021 +0100 Update git submodules * Update helpcontent2 from branch 'master' to b672be3b0250975f1f1879cc2ee4db3b61721838 - corrections for "access" to Position tab for lists and its description remove mention about Paragraph Style and "Chapter Numbering" because it is not possible to set Paragraph Style on this tab. add mention of "numbering symbols" in description of tab, because the descriptions in the other options use this expression. Change-Id: Ie07f91b14292f29e71b4fbea7347c9d34065d9ef Reviewed-on: https://gerrit.libreoffice.org/c/help/+/112794 Reviewed-by: Seth Chaiklin Tested-by: Jenkins diff --git a/helpcontent2 b/helpcontent2 index ccdf35c657d4..b672be3b0250 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit ccdf35c657d4d1a36f0c30db201a06a1125ada84 +Subproject commit b672be3b0250975f1f1879cc2ee4db3b61721838 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/shared/00/00040500.xhp |7 +-- source/text/shared/01/06050600.xhp |4 ++-- 2 files changed, 3 insertions(+), 8 deletions(-) New commits: commit b672be3b0250975f1f1879cc2ee4db3b61721838 Author: Seth Chaiklin AuthorDate: Sun Mar 21 20:06:56 2021 +0100 Commit: Seth Chaiklin CommitDate: Sun Mar 21 20:53:40 2021 +0100 corrections for "access" to Position tab for lists and its description remove mention about Paragraph Style and "Chapter Numbering" because it is not possible to set Paragraph Style on this tab. add mention of "numbering symbols" in description of tab, because the descriptions in the other options use this expression. Change-Id: Ie07f91b14292f29e71b4fbea7347c9d34065d9ef Reviewed-on: https://gerrit.libreoffice.org/c/help/+/112794 Reviewed-by: Seth Chaiklin Tested-by: Jenkins diff --git a/source/text/shared/00/00040500.xhp b/source/text/shared/00/00040500.xhp index 3845475be..bfdcfae7c 100644 --- a/source/text/shared/00/00040500.xhp +++ b/source/text/shared/00/00040500.xhp @@ -319,13 +319,8 @@ -Open Styles - List Styles - context menu of an entry - choose New/Modify. +Choose Format - Bullets and Numbering - Position tab. Choose View - Styles (Command+TF11) - choose List Styles - context menu of an entry - choose New/Modify - Position tab. - - -Choose Format - Bullets and Numbering - Position tab. - - Choose Styles - Manage Styles - choose List Styles - context menu of an entry - choose New/Modify - Position tab. Choose Tools - Chapter Numbering - Position tab. diff --git a/source/text/shared/01/06050600.xhp b/source/text/shared/01/06050600.xhp index 7d646f219..b27e0fcf7 100644 --- a/source/text/shared/01/06050600.xhp +++ b/source/text/shared/01/06050600.xhp @@ -31,7 +31,7 @@ Position -Sets the indent, spacing, and alignment options for the ordered or unordered list. +Set indent, spacing, and alignment options for numbering symbols, such as numbers or bullets, to ordered and unordered lists. do we have a how-to for numbering/bullets/outlines with/without styles? seems we really need one @@ -41,7 +41,7 @@ Level -Select the level(s) that you want to modify. To apply the options to all the levels, select "1-10". In Chapter Numbering, only one level can be selected, or use "1-10" to apply the options, except Paragraph style, to all the levels. +Select the level(s) that you want to modify. To apply the options to all the levels, select “1-10”. ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: connectivity/source
connectivity/source/drivers/file/FStatement.cxx |6 +++---
connectivity/source/inc/file/FStatement.hxx |2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
New commits:
commit 18e1778fb6408684abe90609703501d37a98bc41
Author: Julien Nabet
AuthorDate: Sun Mar 21 19:15:56 2021 +0100
Commit: Julien Nabet
CommitDate: Sun Mar 21 20:51:50 2021 +0100
fix typo in code: anylizeSQL->analyzeSQL
Change-Id: Ibee6322c03c6bd03a72bcb66b27077527f5529ef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112855
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/connectivity/source/drivers/file/FStatement.cxx
b/connectivity/source/drivers/file/FStatement.cxx
index 6c9367c83a78..e04e4fbe5d1b 100644
--- a/connectivity/source/drivers/file/FStatement.cxx
+++ b/connectivity/source/drivers/file/FStatement.cxx
@@ -302,9 +302,9 @@ Any SAL_CALL OStatement::queryInterface( const Type & rType
)
return aRet.hasValue() ? aRet : OStatement_BASE2::queryInterface( rType);
}
-void OStatement_Base::anylizeSQL()
+void OStatement_Base::analyzeSQL()
{
-OSL_ENSURE(m_pSQLAnalyzer,"OResultSet::anylizeSQL: Analyzer isn't set!");
+OSL_ENSURE(m_pSQLAnalyzer,"OResultSet::analyzeSQL: Analyzer isn't set!");
// start analysing the statement
m_pSQLAnalyzer->setOrigColumns(m_xColNames);
m_pSQLAnalyzer->start(m_pParseTree);
@@ -428,7 +428,7 @@ void OStatement_Base::construct(const OUString& sql)
m_pSQLAnalyzer.reset( new OSQLAnalyzer(m_pConnection.get()) );
-anylizeSQL();
+analyzeSQL();
}
void OStatement_Base::createColumnMapping()
diff --git a/connectivity/source/inc/file/FStatement.hxx
b/connectivity/source/inc/file/FStatement.hxx
index f4b6687dfc02..d793002852bf 100644
--- a/connectivity/source/inc/file/FStatement.hxx
+++ b/connectivity/source/inc/file/FStatement.hxx
@@ -96,7 +96,7 @@ namespace connectivity::file
// initialize the column index map (mapping select columns to
table columns)
void createColumnMapping();
// searches the statement for sort criteria
-void anylizeSQL();
+void analyzeSQL();
void setOrderbyColumn( connectivity::OSQLParseNode const *
pColumnRef,
connectivity::OSQLParseNode const *
pAscendingDescending);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sdext/source
sdext/source/pdfimport/pdfparse/pdfentries.cxx |1 + sdext/source/pdfimport/xpdfwrapper/pnghelper.cxx |1 + 2 files changed, 2 insertions(+) New commits: commit 23316f2ef210960f22cba225be3d74e29b3182f4 Author: Caolán McNamara AuthorDate: Sun Mar 21 15:07:22 2021 + Commit: Caolán McNamara CommitDate: Sun Mar 21 20:48:56 2021 +0100 cid#1474243 Uninitialized scalar variable and cid#1473901 Uninitialized scalar variable Change-Id: I6a1d0784865c1a77eacbe25497b97ea63cf3705c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112849 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/sdext/source/pdfimport/pdfparse/pdfentries.cxx b/sdext/source/pdfimport/pdfparse/pdfentries.cxx index 0789268372e4..1e4c861df8dc 100644 --- a/sdext/source/pdfimport/pdfparse/pdfentries.cxx +++ b/sdext/source/pdfimport/pdfparse/pdfentries.cxx @@ -727,6 +727,7 @@ static void unzipToBuffer( char* pBegin, unsigned int nLen, z_stream aZStr; aZStr.next_in = reinterpret_cast(pBegin); aZStr.avail_in = nLen; +aZStr.total_out = aZStr.total_in = 0; aZStr.zalloc= nullptr; aZStr.zfree = nullptr; aZStr.opaque= nullptr; diff --git a/sdext/source/pdfimport/xpdfwrapper/pnghelper.cxx b/sdext/source/pdfimport/xpdfwrapper/pnghelper.cxx index 39a1df6f4a76..a6390f0157e9 100644 --- a/sdext/source/pdfimport/xpdfwrapper/pnghelper.cxx +++ b/sdext/source/pdfimport/xpdfwrapper/pnghelper.cxx @@ -82,6 +82,7 @@ sal_uInt32 PngHelper::deflateBuffer( const Output_t* i_pBuf, size_t i_nLen, Outp aStream.zalloc = Z_NULL; aStream.zfree = Z_NULL; aStream.opaque = Z_NULL; +aStream.total_out = aStream.total_in = 0; if (Z_OK != deflateInit(, Z_BEST_COMPRESSION)) return 0; aStream.avail_in = uInt(i_nLen); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: ucb/source
ucb/source/ucp/ftp/ftploaderthread.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 9752a4261f0707d6767eb0647d0b9be4e3d63952
Author: Caolán McNamara
AuthorDate: Sun Mar 21 15:03:42 2021 +
Commit: Caolán McNamara
CommitDate: Sun Mar 21 20:48:38 2021 +0100
cid#1474207 silence Unchecked return value from library
Change-Id: I7c9ec1db7f0255f1063e58c0fbd92fb63d07c833
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112848
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/ucb/source/ucp/ftp/ftploaderthread.cxx
b/ucb/source/ucp/ftp/ftploaderthread.cxx
index 0b2777393873..f5ebfe36cdda 100644
--- a/ucb/source/ucp/ftp/ftploaderthread.cxx
+++ b/ucb/source/ucp/ftp/ftploaderthread.cxx
@@ -45,7 +45,7 @@ extern "C" {
{
// Otherwise response for QUIT will be sent to already destroyed
// MemoryContainer via non-dummy memory_write function.
-curl_easy_setopt(static_cast(pData),
+(void)curl_easy_setopt(static_cast(pData),
CURLOPT_HEADERFUNCTION,
memory_write_dummy);
curl_easy_cleanup(static_cast(pData));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/generic/printer/cpdmgr.cxx | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
New commits:
commit f9317e41621bb446b864ab2be2996f70e07bb61d
Author: Caolán McNamara
AuthorDate: Sun Mar 21 15:02:38 2021 +
Commit: Caolán McNamara
CommitDate: Sun Mar 21 20:48:10 2021 +0100
cid#1474140 Unchecked return value from library
Change-Id: If04e1e4e582d56432072aebb730d00472939932d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112847
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/vcl/unx/generic/printer/cpdmgr.cxx
b/vcl/unx/generic/printer/cpdmgr.cxx
index 4f375b9cc416..0a830a7e13c0 100644
--- a/vcl/unx/generic/printer/cpdmgr.cxx
+++ b/vcl/unx/generic/printer/cpdmgr.cxx
@@ -109,24 +109,24 @@ void CPDManager::printerAdded (GDBusConnection
*connection,
proxy = current->getProxy(sender_name);
if (proxy == nullptr) {
gchar* contents;
-GDBusNodeInfo *introspection_data;
// Get Interface for introspection
-g_file_get_contents
("/usr/share/dbus-1/interfaces/org.openprinting.Backend.xml", ,
nullptr, nullptr);
-introspection_data = g_dbus_node_info_new_for_xml (contents, nullptr);
-proxy = g_dbus_proxy_new_sync (connection,
-
G_DBUS_PROXY_FLAGS_DO_NOT_CONNECT_SIGNALS,
- introspection_data->interfaces[0],
- sender_name,
- object_path,
- interface_name,
- nullptr,
- nullptr);
+if (g_file_get_contents
("/usr/share/dbus-1/interfaces/org.openprinting.Backend.xml", ,
nullptr, nullptr)) {
+GDBusNodeInfo *introspection_data = g_dbus_node_info_new_for_xml
(contents, nullptr);
+proxy = g_dbus_proxy_new_sync (connection,
+
G_DBUS_PROXY_FLAGS_DO_NOT_CONNECT_SIGNALS,
+ introspection_data->interfaces[0],
+ sender_name,
+ object_path,
+ interface_name,
+ nullptr,
+ nullptr);
-g_free(contents);
-g_dbus_node_info_unref(introspection_data);
-std::pair new_backend (sender_name, proxy);
-current->addBackend(new_backend);
+g_free(contents);
+g_dbus_node_info_unref(introspection_data);
+std::pair new_backend (sender_name,
proxy);
+current->addBackend(new_backend);
+}
}
CPDPrinter *pDest = static_cast(malloc(sizeof(CPDPrinter)));
pDest->backend = proxy;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 141115] Crash in: connectivity::OSQLParseTreeIterator::getOrderTree
https://bugs.documentfoundation.org/show_bug.cgi?id=141115 Julien Nabet changed: What|Removed |Added CC|serval2...@yahoo.fr | --- Comment #9 from Julien Nabet --- If I don't click "Run SQL directly", I don't a crash but got an error: "SQL Status: HY000 Error code: 1000 The given command is not a SELECT statement. Only queries are allowed. /home/julien/lo/libreoffice/dbaccess/source/core/api/SingleSelectQueryComposer.cxx:134" SQL Status: HY000 Error code: 1000 SELECT * FROM "AAdvantage" UNION SELECT * FROM "Fidelity" /home/julien/lo/libreoffice/dbaccess/source/core/api/SingleSelectQueryComposer.cxx:133 Now I got no idea how to fix this. => uncc myself since I can't help. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: extensions/source
extensions/source/update/check/download.cxx | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
New commits:
commit 96903f858e2f0b991350598f8b8bbe1b18d7bdc3
Author: Caolán McNamara
AuthorDate: Sun Mar 21 15:00:28 2021 +
Commit: Caolán McNamara
CommitDate: Sun Mar 21 20:47:34 2021 +0100
cid#1474008 silence Unchecked return value from library
Change-Id: If09a4edb9826507d817f9b0bb425eed8f35bd9c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112846
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/extensions/source/update/check/download.cxx
b/extensions/source/update/check/download.cxx
index 3e8ad4e2c09c..1f98b7717be2 100644
--- a/extensions/source/update/check/download.cxx
+++ b/extensions/source/update/check/download.cxx
@@ -225,37 +225,37 @@ static bool curl_run(std::u16string_view rURL, OutData&
out, const OString& aPro
out.curl = pCURL;
OString aURL(OUStringToOString(rURL, RTL_TEXTENCODING_UTF8));
-curl_easy_setopt(pCURL, CURLOPT_URL, aURL.getStr());
+(void)curl_easy_setopt(pCURL, CURLOPT_URL, aURL.getStr());
// abort on http errors
-curl_easy_setopt(pCURL, CURLOPT_FAILONERROR, 1);
+(void)curl_easy_setopt(pCURL, CURLOPT_FAILONERROR, 1);
// enable redirection
-curl_easy_setopt(pCURL, CURLOPT_FOLLOWLOCATION, 1);
+(void)curl_easy_setopt(pCURL, CURLOPT_FOLLOWLOCATION, 1);
// only allow redirect to http:// and https://
-curl_easy_setopt(pCURL, CURLOPT_REDIR_PROTOCOLS, CURLPROTO_HTTP |
CURLPROTO_HTTPS);
+(void)curl_easy_setopt(pCURL, CURLOPT_REDIR_PROTOCOLS, CURLPROTO_HTTP
| CURLPROTO_HTTPS);
// write function
-curl_easy_setopt(pCURL, CURLOPT_WRITEDATA, );
-curl_easy_setopt(pCURL, CURLOPT_WRITEFUNCTION, _function);
+(void)curl_easy_setopt(pCURL, CURLOPT_WRITEDATA, );
+(void)curl_easy_setopt(pCURL, CURLOPT_WRITEFUNCTION, _function);
// progress handler - Condition::check unfortunately is not defined
const
-curl_easy_setopt(pCURL, CURLOPT_NOPROGRESS, 0);
-curl_easy_setopt(pCURL, CURLOPT_PROGRESSFUNCTION, _callback);
-curl_easy_setopt(pCURL, CURLOPT_PROGRESSDATA, );
+(void)curl_easy_setopt(pCURL, CURLOPT_NOPROGRESS, 0);
+(void)curl_easy_setopt(pCURL, CURLOPT_PROGRESSFUNCTION,
_callback);
+(void)curl_easy_setopt(pCURL, CURLOPT_PROGRESSDATA, );
// proxy
-curl_easy_setopt(pCURL, CURLOPT_PROXY, aProxyHost.getStr());
-curl_easy_setopt(pCURL, CURLOPT_PROXYTYPE, CURLPROXY_HTTP);
+(void)curl_easy_setopt(pCURL, CURLOPT_PROXY, aProxyHost.getStr());
+(void)curl_easy_setopt(pCURL, CURLOPT_PROXYTYPE, CURLPROXY_HTTP);
if( -1 != nProxyPort )
-curl_easy_setopt(pCURL, CURLOPT_PROXYPORT, nProxyPort);
+(void)curl_easy_setopt(pCURL, CURLOPT_PROXYPORT, nProxyPort);
if( out.Offset > 0 )
{
// curl_off_t offset = nOffset; libcurl seems to be compiled with
large
// file support (and we not) ..
sal_Int64 offset = static_cast(out.Offset);
-curl_easy_setopt(pCURL, CURLOPT_RESUME_FROM_LARGE, offset);
+(void)curl_easy_setopt(pCURL, CURLOPT_RESUME_FROM_LARGE, offset);
}
CURLcode cc = curl_easy_perform(pCURL);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/generic/printer/cpdmgr.cxx |8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
New commits:
commit 944c27cf195dcf928687f0a5b392c714b79ad444
Author: Caolán McNamara
AuthorDate: Sun Mar 21 14:58:50 2021 +
Commit: Caolán McNamara
CommitDate: Sun Mar 21 20:46:56 2021 +0100
cid#1473820 Unchecked return value from library
Change-Id: I61721dcfa1b38e224eb5e7cad0c2cd58f73b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112845
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/unx/generic/printer/cpdmgr.cxx
b/vcl/unx/generic/printer/cpdmgr.cxx
index 0789ae7e1ca7..4f375b9cc416 100644
--- a/vcl/unx/generic/printer/cpdmgr.cxx
+++ b/vcl/unx/generic/printer/cpdmgr.cxx
@@ -259,9 +259,11 @@ CPDManager* CPDManager::tryLoadCPD()
gchar* contents;
std::stringstream filepath;
filepath << BACKEND_DIR << '/' << filename;
-g_file_get_contents(filepath.str().c_str(), ,
nullptr, nullptr);
-std::pair new_tbackend (filename,
contents);
-pManager->addTempBackend(new_tbackend);
+if (g_file_get_contents(filepath.str().c_str(), ,
nullptr, nullptr))
+{
+std::pair new_tbackend (filename,
contents);
+pManager->addTempBackend(new_tbackend);
+}
}
g_dir_close(dir);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: ucb/source
ucb/source/ucp/ftp/ftpurl.cxx | 56 +-
1 file changed, 28 insertions(+), 28 deletions(-)
New commits:
commit da12ce76e87c271a3e0306475219992166881bce
Author: Caolán McNamara
AuthorDate: Sun Mar 21 14:54:50 2021 +
Commit: Caolán McNamara
CommitDate: Sun Mar 21 20:46:27 2021 +0100
cid#1473800 silence Unchecked return value from library
Change-Id: I677709f2b071c7f738db7fd5754ba66d1d6e1559
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112844
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/ucb/source/ucp/ftp/ftpurl.cxx b/ucb/source/ucp/ftp/ftpurl.cxx
index 74b77dec15be..da2db0eaa208 100644
--- a/ucb/source/ucp/ftp/ftpurl.cxx
+++ b/ucb/source/ucp/ftp/ftpurl.cxx
@@ -371,10 +371,10 @@ namespace ftp {
#define SET_CONTROL_CONTAINER \
MemoryContainer control; \
-curl_easy_setopt(curl,\
+(void)curl_easy_setopt(curl, \
CURLOPT_HEADERFUNCTION, \
memory_write); \
-curl_easy_setopt(curl,\
+(void)curl_easy_setopt(curl, \
CURLOPT_WRITEHEADER, \
)
@@ -384,7 +384,7 @@ static void setCurlUrl(CURL* curl, OUString const & url)
OString urlParAscii(url.getStr(),
url.getLength(),
RTL_TEXTENCODING_UTF8);
-curl_easy_setopt(curl,
+(void)curl_easy_setopt(curl,
CURLOPT_URL,
urlParAscii.getStr());
};
@@ -403,10 +403,10 @@ oslFileHandle FTPURL::open()
oslFileHandle res( nullptr );
if ( osl_createTempFile( nullptr, , nullptr ) == osl_File_E_None )
{
-curl_easy_setopt(curl,CURLOPT_WRITEFUNCTION,file_write);
-curl_easy_setopt(curl,CURLOPT_WRITEDATA,res);
+(void)curl_easy_setopt(curl,CURLOPT_WRITEFUNCTION,file_write);
+(void)curl_easy_setopt(curl,CURLOPT_WRITEDATA,res);
-curl_easy_setopt(curl,CURLOPT_POSTQUOTE,0);
+(void)curl_easy_setopt(curl,CURLOPT_POSTQUOTE,0);
CURLcode err = curl_easy_perform(curl);
if(err == CURLE_OK)
@@ -433,14 +433,14 @@ std::vector FTPURL::list(
CURL *curl = m_pFCP->handle();
SET_CONTROL_CONTAINER;
-curl_easy_setopt(curl,CURLOPT_NOBODY,false);
+(void)curl_easy_setopt(curl,CURLOPT_NOBODY,false);
MemoryContainer data;
-curl_easy_setopt(curl,CURLOPT_WRITEFUNCTION,memory_write);
-curl_easy_setopt(curl,CURLOPT_WRITEDATA,);
+(void)curl_easy_setopt(curl,CURLOPT_WRITEFUNCTION,memory_write);
+(void)curl_easy_setopt(curl,CURLOPT_WRITEDATA,);
OUString url(ident(true,true));
setCurlUrl(curl, url);
-curl_easy_setopt(curl,CURLOPT_POSTQUOTE,0);
+(void)curl_easy_setopt(curl,CURLOPT_POSTQUOTE,0);
CURLcode err = curl_easy_perform(curl);
if(err != CURLE_OK)
@@ -517,11 +517,11 @@ OUString FTPURL::net_title() const
CURL *curl = m_pFCP->handle();
SET_CONTROL_CONTAINER;
-curl_easy_setopt(curl,CURLOPT_NOBODY,true); // no data => no transfer
+(void)curl_easy_setopt(curl,CURLOPT_NOBODY,true); // no data => no
transfer
struct curl_slist *slist = nullptr;
// post request
slist = curl_slist_append(slist,"PWD");
-curl_easy_setopt(curl,CURLOPT_POSTQUOTE,slist);
+(void)curl_easy_setopt(curl,CURLOPT_POSTQUOTE,slist);
bool try_more(true);
CURLcode err;
@@ -649,18 +649,18 @@ void FTPURL::insert(bool replaceExisting,void* stream)
const
CURL *curl = m_pFCP->handle();
SET_CONTROL_CONTAINER;
-curl_easy_setopt(curl,CURLOPT_NOBODY,false);// no data => no transfer
-curl_easy_setopt(curl,CURLOPT_POSTQUOTE,0);
-curl_easy_setopt(curl,CURLOPT_QUOTE,0);
-curl_easy_setopt(curl,CURLOPT_READFUNCTION,memory_read);
-curl_easy_setopt(curl,CURLOPT_READDATA,stream);
-curl_easy_setopt(curl, CURLOPT_UPLOAD,1);
+(void)curl_easy_setopt(curl,CURLOPT_NOBODY,false);// no data => no
transfer
+(void)curl_easy_setopt(curl,CURLOPT_POSTQUOTE,0);
+(void)curl_easy_setopt(curl,CURLOPT_QUOTE,0);
+(void)curl_easy_setopt(curl,CURLOPT_READFUNCTION,memory_read);
+(void)curl_easy_setopt(curl,CURLOPT_READDATA,stream);
+(void)curl_easy_setopt(curl, CURLOPT_UPLOAD,1);
OUString url(ident(false,true));
setCurlUrl(curl, url);
CURLcode err = curl_easy_perform(curl);
-curl_easy_setopt(curl, CURLOPT_UPLOAD,false);
+(void)curl_easy_setopt(curl, CURLOPT_UPLOAD,false);
if(err != CURLE_OK)
throw curl_exception(err);
@@ -698,11 +698,11 @@ void FTPURL::mkdir(bool ReplaceExisting) const
CURL *curl = m_pFCP->handle();
SET_CONTROL_CONTAINER;
-
[Libreoffice-commits] core.git: editeng/source include/editeng
editeng/source/editeng/editobj.cxx |5 +
editeng/source/editeng/impedit5.cxx |5 +
editeng/source/uno/unoedhlp.cxx |8 ++--
include/editeng/editdata.hxx|6 ++
4 files changed, 10 insertions(+), 14 deletions(-)
New commits:
commit eb8b769f8e5ee6383e04e08cfde4aa345a24e4c1
Author: Caolán McNamara
AuthorDate: Sun Mar 21 14:50:21 2021 +
Commit: Caolán McNamara
CommitDate: Sun Mar 21 20:46:06 2021 +0100
cid#1473926 Uninitialized scalar variable
Change-Id: I794d2b58aa65f7eeb3aa32fa50e827ebf32b35ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112843
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/editeng/source/editeng/editobj.cxx
b/editeng/source/editeng/editobj.cxx
index af80e2845bd6..2cb69858510b 100644
--- a/editeng/source/editeng/editobj.cxx
+++ b/editeng/source/editeng/editobj.cxx
@@ -715,10 +715,7 @@ void EditTextObjectImpl::GetCharAttribs( sal_Int32 nPara,
std::vector&
for (const auto & i : rAttrs)
{
const EditCharAttrib& rAttr = *i;
-EECharAttrib aEEAttr;
-aEEAttr.pAttr = rAttr.GetItem();
-aEEAttr.nStart = rAttr.GetStart();
-aEEAttr.nEnd = rAttr.GetEnd();
+EECharAttrib aEEAttr(rAttr.GetStart(), rAttr.GetEnd(),
rAttr.GetItem());
rLst.push_back(aEEAttr);
}
}
diff --git a/editeng/source/uno/unoedhlp.cxx b/editeng/source/uno/unoedhlp.cxx
index 19e14fcfc50a..9b5b98fc6df2 100644
--- a/editeng/source/uno/unoedhlp.cxx
+++ b/editeng/source/uno/unoedhlp.cxx
@@ -100,9 +100,7 @@ void SvxEditSourceHelper::GetAttributeRun( sal_Int32&
nStartIndex, sal_Int32& nE
{
if (nIndex2 < aTempCharAttribs[nAttr].nStart)
{
-EECharAttrib aEEAttr;
-aEEAttr.nStart = nIndex2;
-aEEAttr.nEnd = aTempCharAttribs[nAttr].nStart;
+EECharAttrib aEEAttr(nIndex2, aTempCharAttribs[nAttr].nStart);
aCharAttribs.insert(aCharAttribs.begin() + nAttr, aEEAttr);
}
nIndex2 = aTempCharAttribs[nAttr].nEnd;
@@ -110,9 +108,7 @@ void SvxEditSourceHelper::GetAttributeRun( sal_Int32&
nStartIndex, sal_Int32& nE
}
if ( nIndex2 != nParaLen )
{
-EECharAttrib aEEAttr;
-aEEAttr.nStart = nIndex2;
-aEEAttr.nEnd = nParaLen;
+EECharAttrib aEEAttr(nIndex2, nParaLen);
aCharAttribs.push_back(aEEAttr);
}
}
diff --git a/include/editeng/editdata.hxx b/include/editeng/editdata.hxx
index 40c74cb2b8c6..5ed618fc7b80 100644
--- a/include/editeng/editdata.hxx
+++ b/include/editeng/editdata.hxx
@@ -274,6 +274,12 @@ struct EECharAttrib
sal_Int32 nStart;
sal_Int32 nEnd;
+EECharAttrib(sal_Int32 nSt, sal_Int32 nE, const SfxPoolItem* pA = nullptr)
+: pAttr(pA)
+, nStart(nSt)
+, nEnd(nE)
+{
+}
};
struct MoveParagraphsInfo
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3/gtk3gtkinst.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 5545fa0b9f88057e8b7ef4405cf15c2096d23691 Author: Caolán McNamara AuthorDate: Sun Mar 21 14:43:11 2021 + Commit: Caolán McNamara CommitDate: Sun Mar 21 20:45:38 2021 +0100 cid#1474327 move markup to previous line Change-Id: I2457ab6ea8159cc3f594042390825ae035bf9d35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112840 Tested-by: Caolán McNamara Reviewed-by: Caolán McNamara diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx index c9fe5288ae2f..ec8d970caad3 100644 --- a/vcl/unx/gtk3/gtk3gtkinst.cxx +++ b/vcl/unx/gtk3/gtk3gtkinst.cxx @@ -6135,8 +6135,8 @@ public: gtk_container_remove(GTK_CONTAINER(m_pScrolledWindow), pViewport); gtk_container_add(GTK_CONTAINER(m_pScrolledWindow), m_pOrigViewport); -g_object_unref(m_pOrigViewport); // coverity[freed_arg : FALSE] - this does not free m_pOrigViewport, it is reffed by m_pScrolledWindow +g_object_unref(m_pOrigViewport); gtk_container_add(GTK_CONTAINER(m_pOrigViewport), pChild); g_object_unref(pChild); gtk_widget_destroy(pViewport); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: libreofficekit/source
libreofficekit/source/gtk/lokdocview.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 9456a764a98daa2915f6fefac336d8bb5cff531a
Author: Caolán McNamara
AuthorDate: Sun Mar 21 14:38:36 2021 +
Commit: Caolán McNamara
CommitDate: Sun Mar 21 20:44:59 2021 +0100
cid#1474127 Unchecked return value from library
Change-Id: I6dac6f24d33ce4557ab94ff08357e597819510d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112839
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/libreofficekit/source/gtk/lokdocview.cxx
b/libreofficekit/source/gtk/lokdocview.cxx
index 832d799b1b7a..156224b57351 100644
--- a/libreofficekit/source/gtk/lokdocview.cxx
+++ b/libreofficekit/source/gtk/lokdocview.cxx
@@ -2788,10 +2788,10 @@ static gboolean lok_doc_view_initable_init (GInitable
*initable, GCancellable* /
return true;
if (priv->m_bUnipoll)
-g_setenv("SAL_LOK_OPTIONS", "unipoll", FALSE);
+(void)g_setenv("SAL_LOK_OPTIONS", "unipoll", FALSE);
static const char testingLangs[] = "de_DE en_GB en_US es_ES fr_FR it nl
pt_BR pt_PT ru";
-g_setenv("LOK_ALLOWLIST_LANGUAGES", testingLangs, FALSE);
+(void)g_setenv("LOK_ALLOWLIST_LANGUAGES", testingLangs, FALSE);
priv->m_pOffice = lok_init_2(priv->m_aLOPath.c_str(),
priv->m_aUserProfileURL.empty() ? nullptr : priv->m_aUserProfileURL.c_str());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sd/source
sd/source/ui/view/drviewse.cxx |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
New commits:
commit 7ddf28fb4de78a4419e488b9ad4780bbb2bf9844
Author: Caolán McNamara
AuthorDate: Sun Mar 21 14:36:40 2021 +
Commit: Caolán McNamara
CommitDate: Sun Mar 21 20:44:14 2021 +0100
cid#1473853 Unchecked return value
Change-Id: I869e42e1c1651c9c435449a295e41a5f8889f4dc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112838
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sd/source/ui/view/drviewse.cxx b/sd/source/ui/view/drviewse.cxx
index d537dbdbb77e..b833b1d3b719 100644
--- a/sd/source/ui/view/drviewse.cxx
+++ b/sd/source/ui/view/drviewse.cxx
@@ -986,10 +986,8 @@ void DrawViewShell::FuSupport(SfxRequest& rReq)
{
vcl::KeyCode aKCode(KEY_DELETE);
KeyEvent aKEvt( 0, aKCode);
-//pOLV->PostKeyEvent(aKEvt);
// We use SdrObjEditView to handle DEL for underflow
handling
-mpDrawView->KeyInput(aKEvt, nullptr);
-
+(void)mpDrawView->KeyInput(aKEvt, nullptr);
}
}
else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: editeng/source sc/source sd/source svl/source sw/source writerfilter/source
editeng/source/editeng/editdoc.cxx|2 +-
editeng/source/editeng/editobj.cxx|2 +-
editeng/source/outliner/outliner.cxx |2 +-
sc/source/ui/view/gridwin_dbgutil.cxx |2 +-
sd/source/core/drawdoc.cxx|2 +-
svl/source/undo/undo.cxx |2 +-
sw/source/core/doc/docfmt.cxx |2 +-
sw/source/core/text/xmldump.cxx |2 +-
writerfilter/source/dmapper/TagLogger.cxx |2 +-
9 files changed, 9 insertions(+), 9 deletions(-)
New commits:
commit f8538ec4967b205b03f8e06fba86c6f09a679bc9
Author: Caolán McNamara
AuthorDate: Sun Mar 21 14:34:47 2021 +
Commit: Caolán McNamara
CommitDate: Sun Mar 21 20:43:51 2021 +0100
cid#1473798 silence Unchecked return value from library
Change-Id: I00174b5444749f3345f5691e24eb5219d1b47059
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112837
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/editeng/source/editeng/editdoc.cxx
b/editeng/source/editeng/editdoc.cxx
index a5e28d0c6b34..d429cbe1e762 100644
--- a/editeng/source/editeng/editdoc.cxx
+++ b/editeng/source/editeng/editdoc.cxx
@@ -2695,7 +2695,7 @@ void EditDoc::dumpAsXml(xmlTextWriterPtr pWriter) const
{
pWriter = xmlNewTextWriterFilename("editdoc.xml", 0);
xmlTextWriterSetIndent(pWriter,1);
-xmlTextWriterSetIndentString(pWriter, BAD_CAST(" "));
+(void)xmlTextWriterSetIndentString(pWriter, BAD_CAST(" "));
(void)xmlTextWriterStartDocument(pWriter, nullptr, nullptr, nullptr);
bOwns = true;
}
diff --git a/editeng/source/editeng/editobj.cxx
b/editeng/source/editeng/editobj.cxx
index 05abf41a7b67..af80e2845bd6 100644
--- a/editeng/source/editeng/editobj.cxx
+++ b/editeng/source/editeng/editobj.cxx
@@ -421,7 +421,7 @@ void EditTextObject::dumpAsXml(xmlTextWriterPtr pWriter)
const
{
pWriter = xmlNewTextWriterFilename("editTextObject.xml", 0);
xmlTextWriterSetIndent(pWriter,1);
-xmlTextWriterSetIndentString(pWriter, BAD_CAST(" "));
+(void)xmlTextWriterSetIndentString(pWriter, BAD_CAST(" "));
(void)xmlTextWriterStartDocument(pWriter, nullptr, nullptr, nullptr);
bOwns = true;
}
diff --git a/editeng/source/outliner/outliner.cxx
b/editeng/source/outliner/outliner.cxx
index 7b259959ea04..34ef7f981121 100644
--- a/editeng/source/outliner/outliner.cxx
+++ b/editeng/source/outliner/outliner.cxx
@@ -2166,7 +2166,7 @@ void Outliner::dumpAsXml(xmlTextWriterPtr pWriter) const
{
pWriter = xmlNewTextWriterFilename("outliner.xml", 0);
xmlTextWriterSetIndent(pWriter,1);
-xmlTextWriterSetIndentString(pWriter, BAD_CAST(" "));
+(void)xmlTextWriterSetIndentString(pWriter, BAD_CAST(" "));
(void)xmlTextWriterStartDocument(pWriter, nullptr, nullptr, nullptr);
bOwns = true;
}
diff --git a/sc/source/ui/view/gridwin_dbgutil.cxx
b/sc/source/ui/view/gridwin_dbgutil.cxx
index bcb1da5ff695..f9c2209bda88 100644
--- a/sc/source/ui/view/gridwin_dbgutil.cxx
+++ b/sc/source/ui/view/gridwin_dbgutil.cxx
@@ -91,7 +91,7 @@ void ScGridWindow::dumpCellProperties()
xmlTextWriterPtr writer = xmlNewTextWriterFilename( "dump.xml", 0 );
xmlTextWriterSetIndent(writer,1);
-xmlTextWriterSetIndentString(writer, BAD_CAST(""));
+(void)xmlTextWriterSetIndentString(writer, BAD_CAST(""));
(void)xmlTextWriterStartDocument( writer, nullptr, nullptr, nullptr );
diff --git a/sd/source/core/drawdoc.cxx b/sd/source/core/drawdoc.cxx
index 182377c2dff7..4e7c6c5dbd88 100644
--- a/sd/source/core/drawdoc.cxx
+++ b/sd/source/core/drawdoc.cxx
@@ -1184,7 +1184,7 @@ void SdDrawDocument::dumpAsXml(xmlTextWriterPtr pWriter)
const
{
pWriter = xmlNewTextWriterFilename("model.xml", 0);
xmlTextWriterSetIndent(pWriter,1);
-xmlTextWriterSetIndentString(pWriter, BAD_CAST(" "));
+(void)xmlTextWriterSetIndentString(pWriter, BAD_CAST(" "));
(void)xmlTextWriterStartDocument(pWriter, nullptr, nullptr, nullptr);
bOwns = true;
}
diff --git a/svl/source/undo/undo.cxx b/svl/source/undo/undo.cxx
index 71d7b6f254a7..ee9af634a4ba 100644
--- a/svl/source/undo/undo.cxx
+++ b/svl/source/undo/undo.cxx
@@ -1146,7 +1146,7 @@ void SfxUndoManager::dumpAsXml(xmlTextWriterPtr pWriter)
const
{
pWriter = xmlNewTextWriterFilename("undo.xml", 0);
xmlTextWriterSetIndent(pWriter,1);
-xmlTextWriterSetIndentString(pWriter, BAD_CAST(" "));
+(void)xmlTextWriterSetIndentString(pWriter, BAD_CAST(" "));
(void)xmlTextWriterStartDocument(pWriter, nullptr, nullptr, nullptr);
bOwns = true;
}
diff --git a/sw/source/core/doc/docfmt.cxx b/sw/source/core/doc/docfmt.cxx
index ee4854e142e0..a552585df6ab 100644
--- a/sw/source/core/doc/docfmt.cxx
+++ b/sw/source/core/doc/docfmt.cxx
@@ -1935,7 +1935,7 @@ void
[Libreoffice-bugs] [Bug 141151] First Calc document takes too long to appear on screen
https://bugs.documentfoundation.org/show_bug.cgi?id=141151 --- Comment #2 from Alain --- Windows family 10, 64 vers. 20H2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141151] First Calc document takes too long to appear on screen
https://bugs.documentfoundation.org/show_bug.cgi?id=141151 Alain changed: What|Removed |Added Component|LibreOffice |Calc Alias||Ronceval --- Comment #1 from Alain --- Windows Family: 10, 64 vers. 20H2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100850] libreoffice base use too much memory
https://bugs.documentfoundation.org/show_bug.cgi?id=100850 --- Comment #17 from Terrence Enger --- A local build (--enable-dbgutil) of commit feb6fd1f (2021-00-17) built and running on debian-buster shows the following numbers from `top`: virt res shr CPU time --- -- -- to Start Center : 437264 182496 137528 0:02.70 Open File dialog: 451052 190648 140892 0:08.21 Hello.odb : 481920 217980 165588 0:12.94 display list of tables : 3098460 304912 193964 0:15.79 open table hello: 3144664 339844 206908 0:19.11 close hello : 3148016 341392 207404 0:20.34 close Hello.odb : 3156212 343856 208536 0:21.97 Comparing these numbers to comment 12, I see: - "virt" is closer to numbers from bibisect 43all version oldest - "res" and "shr" are close to numbers from daily dbgutil version 2016-07-18. I conclude that the problem--if it is a problem--persists. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141151] New: First Calc document takes too long to appear on screen
https://bugs.documentfoundation.org/show_bug.cgi?id=141151 Bug ID: 141151 Summary: First Calc document takes too long to appear on screen Product: LibreOffice Version: 7.1.1.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ronce...@vivaldi.net Description: LibreOffice vers. 7.0.6.4. or before. The first Calc document appeared on screen after 0.5 second till 2 seconds. LibreOffice vers. 7.1.1.2 The first Calc document appears on screen after 12 seconds till 15 seconds. During oppening: "time out" or "time delay out" appears. Steps to Reproduce: 1. Open Windows Files explorer 2. Set the external disc and open the file and click on the CALC document. Or click on the schortcut CALC document see on the window. 3. LibreOffice needs 12 till 15 seconds to open the file setted Actual Results: LibreOffice takes 12 seconds till 15 seconds to open the first Calc-document on C-disc or on external-disc. Expected Results: LibreOffice took 0.5 second till 2 seconds to open a Calc-document in C-disc or in external-disc. Reproducible: Always User Profile Reset: Yes Additional Info: I first opened windows-settings, Applications and clicked on LibreOffice then Repair. It did not fixed my problem. I second totaly uninstalled LibreOffice 7.1.1.2 and then re-installed it. It did not fixed my problem. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134809] [META] Speedup huge pixel graphics Cairo bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=134809 Bug 134809 depends on bug 138068, which changed state. Bug 138068 Summary: When there are a lot of pictures, typing the text is very slow (macOS/GTK3/GDI) https://bugs.documentfoundation.org/show_bug.cgi?id=138068 What|Removed |Added Status|VERIFIED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138068] When there are a lot of pictures, typing the text is very slow (macOS/GTK3/GDI)
https://bugs.documentfoundation.org/show_bug.cgi?id=138068 Alberto Salvia Novella changed: What|Removed |Added Status|VERIFIED|REOPENED Resolution|FIXED |--- --- Comment #48 from Alberto Salvia Novella --- That's my experience too, although for me performance is good. But that could be because my graphics card is just quite good. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140755] Blurred text in images
https://bugs.documentfoundation.org/show_bug.cgi?id=140755 Aron Budea changed: What|Removed |Added Status|REOPENED|NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141136] Tabbed toolbar mode keeps switching you away from the current tab to the "Home" tab each time you enter (focus) or leave a comment
https://bugs.documentfoundation.org/show_bug.cgi?id=141136 --- Comment #2 from Jean-François Fortin Tam --- Note that this happens not only in Writer, but in Calc too. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141150] New: Allow immediately resizing and positioning a comment when editing or creating/inserting it in a cell in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=141150 Bug ID: 141150 Summary: Allow immediately resizing and positioning a comment when editing or creating/inserting it in a cell in Calc Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: nekoh...@gmail.com Everytime I create a comment in a spreadsheet, I want to be able to set its size and position so that the text flows neatly and that it doesn't obscure the view of the data when shown. However, Calc makes this process very tedious, because it doesn't let me do that when initially creating the comment; the comment's border is not selectable to move or reposition it, I need to: 1. Press Esc (or click outside the comment) for it to create & save the comment 2. Right-click the cell 3. "Show comment" 4. Click the comment's edge/border 5. Finally be able to reposition and resize it! This is taking me 5 steps instead of what should be 1 step: while creating (or editing) a comment, just let me move/resize it anytime, without even having to click its border to enter "positioning/resizing mode". Just let me do it directly anytime, please. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141124] Part of TOC Index disappear after index update
https://bugs.documentfoundation.org/show_bug.cgi?id=141124 --- Comment #7 from Georgy --- Created attachment 170610 --> https://bugs.documentfoundation.org/attachment.cgi?id=170610=edit How it looks after index update -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108882] [META] Read-only bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108882 Jean-François Fortin Tam changed: What|Removed |Added Depends on||107363 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107363 [Bug 107363] Grouped buttons doesn't become properly disabled -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107363] Grouped buttons doesn't become properly disabled
https://bugs.documentfoundation.org/show_bug.cgi?id=107363 Jean-François Fortin Tam changed: What|Removed |Added Blocks||108882 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108882 [Bug 108882] [META] Read-only bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141115] Crash in: connectivity::OSQLParseTreeIterator::getOrderTree
https://bugs.documentfoundation.org/show_bug.cgi?id=141115 Julien Nabet changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Keywords||haveBacktrace -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141115] Crash in: connectivity::OSQLParseTreeIterator::getOrderTree
https://bugs.documentfoundation.org/show_bug.cgi?id=141115 --- Comment #8 from Julien Nabet --- Created attachment 170609 --> https://bugs.documentfoundation.org/attachment.cgi?id=170609=edit bt with debug symbols Thank you for your feedback. On pc Debian x86-64 with master sources updated today, I could reproduce this. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138068] When there are a lot of pictures, typing the text is very slow (macOS/GTK3/GDI)
https://bugs.documentfoundation.org/show_bug.cgi?id=138068 --- Comment #47 from chrifo...@gmail.com --- I don't understand why this is considered fixed; performance is still significantly worse than it was in 6.4.7 if images are used and the "fix" seems to have broken anti-aliasing, which may explain the slight performance improvement. Just to clarify: on Fedora 33 using a normal Writer doc where some pages have several images: version 6.4.7: performance good, image quality good version 7.0.4: performance bad, image quality good version 7.0.5: performance slightly less bad, image quality bad On version 7.0.5 the images are not anti-aliased, no matter if the option is turned on or not...in fact, this option doesn't seem to be doing anything anymore, which is probably where the slight performance improvement comes from. Personally I have reverted to 6.4.7 until this is properly fixed. PS: it's less bad on Windows 10, but still not optimal. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132061] Page Columns in Notebookbar is not disabled when document is read-only
https://bugs.documentfoundation.org/show_bug.cgi?id=132061 Jean-François Fortin Tam changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||7363 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129509] Controls in Notebookbar user interfaces don't show as disabled for read-only document.
https://bugs.documentfoundation.org/show_bug.cgi?id=129509 Jean-François Fortin Tam changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||7363 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107363] Grouped buttons doesn't become properly disabled
https://bugs.documentfoundation.org/show_bug.cgi?id=107363 Jean-François Fortin Tam changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||9509, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||2061 CC||nekoh...@gmail.com -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132061] Page Columns in Notebookbar is not disabled when document is read-only
https://bugs.documentfoundation.org/show_bug.cgi?id=132061 Jean-François Fortin Tam changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||9509 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129509] Controls in Notebookbar user interfaces don't show as disabled for read-only document.
https://bugs.documentfoundation.org/show_bug.cgi?id=129509 Jean-François Fortin Tam changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||2061 --- Comment #3 from Jean-François Fortin Tam --- I'm under the impression that the only tabs/groups that should be enabled in read-only mode are the "File" and "View" tabs... everything else (Home, Insert, Layout, Data, Image, Forms, Review, and possibly "Extensions" and "Tools") typically requires write capability. In that case, I'd suggest those tabs/groups to be hidden entirely, until the document becomes read+write; that way, it would keep the UI simpler and more contextualized for users. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140809] Column chart bugs: X-axis, ranges, editing
https://bugs.documentfoundation.org/show_bug.cgi?id=140809 Dave Nadler changed: What|Removed |Added Ever confirmed|0 |1 Status|RESOLVED|REOPENED Resolution|NOTABUG |--- --- Comment #7 from Dave Nadler --- Thanks Uwe for explaining (1) - how to get the x-axis numerical labeling sorted (). It is incredibly well hidden... Can you address the other issues, especially (2). Input a range name for one of the series data range, and you'll see it accepts the name, shows it in orange, but does not work. Thanks! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: framework/source framework/util
framework/source/services/taskcreatorsrv.cxx | 19 +--
framework/util/fwk.component |3 ++-
2 files changed, 3 insertions(+), 19 deletions(-)
New commits:
commit a95abea894d098de8338b4138c76c28efe42d056
Author: Noel Grandin
AuthorDate: Sun Mar 21 13:20:12 2021 +0200
Commit: Noel Grandin
CommitDate: Sun Mar 21 18:00:49 2021 +0100
use single-use attribute for TaskCreatorService
instead of rtl::Instance, which means it will get
cleaned up when UNO shuts down
Change-Id: I0ebf3a71c93015850eb34c8cbe9395b6d36ce3c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112832
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/framework/source/services/taskcreatorsrv.cxx
b/framework/source/services/taskcreatorsrv.cxx
index b66a9dc3ac2d..856d440230b6 100644
--- a/framework/source/services/taskcreatorsrv.cxx
+++ b/framework/source/services/taskcreatorsrv.cxx
@@ -349,22 +349,6 @@ OUString TaskCreatorService::impl_filterNames( const
OUString& sName )
return sFiltered;
}
-struct Instance {
-explicit Instance(
-css::uno::Reference const & context):
-instance(
-static_cast(new TaskCreatorService(context)))
-{
-}
-
-css::uno::Reference instance;
-};
-
-struct Singleton:
-public rtl::StaticWithArg<
-Instance, css::uno::Reference, Singleton>
-{};
-
}
extern "C" SAL_DLLPUBLIC_EXPORT css::uno::XInterface *
@@ -372,8 +356,7 @@ com_sun_star_comp_framework_TaskCreator_get_implementation(
css::uno::XComponentContext *context,
css::uno::Sequence const &)
{
-return cppu::acquire(static_cast(
-Singleton::get(context).instance.get()));
+return cppu::acquire(new TaskCreatorService(context));
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/framework/util/fwk.component b/framework/util/fwk.component
index d6434cec85dd..cc5fcfb13faa 100644
--- a/framework/util/fwk.component
+++ b/framework/util/fwk.component
@@ -144,7 +144,8 @@
+ constructor="com_sun_star_comp_framework_TaskCreator_get_implementation"
+ single-instance="true">
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 89477] Images and objects should have an option "Anchor to page (moves with page)" to deal with page breaks
https://bugs.documentfoundation.org/show_bug.cgi?id=89477 --- Comment #16 from Mike Kaganski --- (In reply to Stanislav Horacek from comment #15) Please look at comment 14. It is exactly the case of user error, using wrong feature, not knowing what to use correctly. I even wrote: > I believe that using wrong "to page" anchoring, when user > actually wants "to paragraph" anchoring + "to page" positioning, is the > reason for filing proposals like this. You immediately write: > I want to anchor an object such a way that > it moves together with some page content while it stays at the same position > relatively to the page (we can call it whatever, not "anchor to page and > move"). Isn't that exactly the same? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89477] Images and objects should have an option "Anchor to page (moves with page)" to deal with page breaks
https://bugs.documentfoundation.org/show_bug.cgi?id=89477 --- Comment #15 from Stanislav Horacek --- I don't agree with this too developer-centric approach. From user's point of view, this requirement is valid: I want to anchor an object such a way that it moves together with some page content while it stays at the same position relatively to the page (we can call it whatever, not "anchor to page and move"). Maybe now this can be achieved somehow, I was interested in it long time ago when it was not possible (and I was using my extension to workaround it). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137147] Provide a way to cancel formula calculation in Calc (e.g., by hitting ESC key)
https://bugs.documentfoundation.org/show_bug.cgi?id=137147 s5t1e3v4e3...@hotmail.com changed: What|Removed |Added CC||s5t1e3v4e3...@hotmail.com --- Comment #3 from s5t1e3v4e3...@hotmail.com --- (In reply to Kevin Suo from comment #0) > Microsoft Excel already has this functionality, at least in its MSO 2010 > version. I have no MS Excel, can you please confirm some detail I am curious about? Assume we have sat through a long formula fill of e.g. 6 rows. Then we change the formula on the top, double click the fill handle to change all already calculated cells to the new formula, but half-way through hit the designated calculation cancel button (e.g. ESC). Is the result that half the cells have changed and the other half is unchanged or is Excel doing a ROLLBACK? If this is implemented in LO, I would prefer to get a dialog asking what to do: (1)just abort the calculation and leave the mixed data (2)clear the remaining cells (3)ROLLBACK (4)continue TBH, I am not sure (2) is really useful, but it is easy to find how far it got. If I intentionally tried to cancel the calculation, I most likely realized that the formula was still not right and want the fastest way getting a responsive spreadsheet again, which probably would be (1) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: framework/source framework/util
framework/source/services/modulemanager.cxx | 18 +-
framework/util/fwk.component|3 ++-
2 files changed, 3 insertions(+), 18 deletions(-)
New commits:
commit f86e20fa4aa425fbc4e97cccdfa3080422a6584b
Author: Noel Grandin
AuthorDate: Sun Mar 21 13:27:05 2021 +0200
Commit: Noel Grandin
CommitDate: Sun Mar 21 17:30:16 2021 +0100
use single-use attribute for ModuleManager
instead of rtl::Instance, which means it will get
cleaned up when UNO shuts down
Change-Id: I80ee080d4b62065dadc9c406485a81433a38ffaa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112841
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/framework/source/services/modulemanager.cxx
b/framework/source/services/modulemanager.cxx
index ad98644bb0b7..c03bf2611ecd 100644
--- a/framework/source/services/modulemanager.cxx
+++ b/framework/source/services/modulemanager.cxx
@@ -336,21 +336,6 @@ OUString ModuleManager::implts_identify(const
css::uno::Reference< css::uno::XIn
return OUString();
}
-struct Instance {
-explicit Instance(
-css::uno::Reference const & context):
-instance(static_cast(new ModuleManager(context)))
-{
-}
-
-css::uno::Reference instance;
-};
-
-struct Singleton:
-public rtl::StaticWithArg<
-Instance, css::uno::Reference, Singleton>
-{};
-
}
extern "C" SAL_DLLPUBLIC_EXPORT css::uno::XInterface *
@@ -358,8 +343,7 @@
com_sun_star_comp_framework_ModuleManager_get_implementation(
css::uno::XComponentContext *context,
css::uno::Sequence const &)
{
-return cppu::acquire(static_cast(
-Singleton::get(context).instance.get()));
+return cppu::acquire(new ModuleManager(context));
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/framework/util/fwk.component b/framework/util/fwk.component
index 4cbf51e97228..d6434cec85dd 100644
--- a/framework/util/fwk.component
+++ b/framework/util/fwk.component
@@ -83,7 +83,8 @@
+
constructor="com_sun_star_comp_framework_ModuleManager_get_implementation"
+ single-instance="true">
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
