[Libreoffice-bugs] [Bug 89373] Strange behaviour of sum() function in linked or complex spreadsheet

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89373

b.  changed:

   What|Removed |Added

 CC||newbie...@gmx.de

--- Comment #19 from b.  ---
@Bill Babb ... and others: 'SUM' is sensitive to the order of operands,
'=SUM(1E16; -1E16; 1)' -> 1 , '=SUM(1; 1E16; -1E16)' -> 0, 
it's an effect of 'cancellation' and will truncate small operands in
subtraction to different degree (between 'nearly nothing' and 'total
extinction', 
calc and excel process ranges with different strategies, thus expect
deviations,

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 117750] Some of the image filters aren't working (like Aging or Relief)

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117750

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #10 from Julien Nabet  ---
I submitted a patch for Sepia (Aging) and Solarization here:
https://gerrit.libreoffice.org/c/core/+/113926

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141590] Crash if i insert values in the function PRONOSTICO.ETS.PI.SUM

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141590

--- Comment #4 from Julien Nabet  ---
About Debian, I personnally use Debian testing (which has LO 7.0.4).
Stable is more for servers.

Could you indicate parameters you provided to the function?

About backtrace, when you got "??", type "c" (for "continue") until there's no
"??".
Then you can type "bt" (for "backtrace")

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 97233] [META] Dialog Designer bugs and enhancements

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=97233
Bug 97233 depends on bug 141195, which changed state.

Bug 141195 Summary: Custom button text color not shown in the Basic dialogs 
with default background color
https://bugs.documentfoundation.org/show_bug.cgi?id=141195

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141195] Custom button text color not shown in the Basic dialogs with default background color

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141195

Matej Kivader  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 92821] Make Shift-F5 jump to the last four places where you edited something

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=92821

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||1586

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141586] Restoring last document position is unreliable

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141586

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=92
   ||821
 CC||vstuart.fo...@utsa.edu

--- Comment #2 from V Stuart Foote  ---
@Mike, *

Not opposed, but if we abandon the current view shell based ViewTop ViewLeft
calculations [1] on bIsOwnDocument, think we'd still like some way to use the
+ for a stack of recent cursor positions, i.e. bug 92821

Jim R. had tweaked the Navigation stack for the "Recency" mode of the
Navigator, but 115817, are those view shell cursor positions also, or something
else that could be picked up and written out to ODF? 

=-ref-=

[1]
https://opengrok.libreoffice.org/xref/core/sw/source/uibase/uiview/view.cxx?r=c0936ba2#1297

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 140205] Dragging an image frame anchored as 'as character' twice followed by undo brakes layout

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140205

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #3 from raal  ---
Can you check it? I cannot reproduce with Version: 7.2.0.0.alpha0+ /
LibreOffice Community
Build ID: c47ad11f8c2e917adebbd5d7b3a3ef6cc4b3e670
CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87506] Inconsistency in how LibreOffice Calc 4.4.0BetaDevDaily handles real numbers internally or with the MOD() function or both.

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=87506

b.  changed:

   What|Removed |Added

 CC||newbie...@gmx.de

--- Comment #3 from b.  ---
@klsu: if you select cells C1 or C2 and look at the input line you will see a
deviation, 
you may also get it visible with: '=RAWSUBTRACT(B2;E2)', 
calc does some 'tolerant compare' to cover such small imprecisions, but keeps
the odd value and uses it for downstream calculations, one can argue the hour
and the day whether well done or not, 
the source of evil is 'cancellation', and that no spreadsheet has good handling
for that so far ... :-(

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 131634] Crash in sd::View::SdrEndTextEdit(bool)

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=131634

raal  changed:

   What|Removed |Added

 CC||armin.le.gr...@me.com,
   ||r...@post.cz

--- Comment #9 from raal  ---
(In reply to Caolán McNamara from comment #7)
> This probably comes from...
> 
> commit 12a4200e8ff7f045efcc7e9d15a24b15b248c437
> Author: Armin Le Grand 
> Date:   Thu Aug 9 08:42:27 2012 +
> 

Adding CC to Armin

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141590] Crash if i insert values in the function PRONOSTICO.ETS.PI.SUM

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141590

--- Comment #3 from igor  ---
Linux 4.19.0-16-amd64 #1 SMP Debian 4.19.181-1 (2021-03-19) x86_64 GNU/Linux

Versión: 6.1.5.2
Id. de compilación: 1:6.1.5-3+deb10u7
Subprocs. CPU: 4; SO: Linux 4.19; Repres. IU: predet.; VCL: x11; 
Configuración regional: es-NI (es_NI.UTF-8); Calc: group threaded

Thread 1 "soffice.bin" received signal SIGSEGV, Segmentation fault.
0x7f984a901b57 in ?? () from /usr/lib/libreoffice/program/libsclo.so

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141608] Libre Office Calc crashed when trying to save a doc with .xlsx extension on it by changing the name to drop the .xlsx.

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141608

Harshita Nag  changed:

   What|Removed |Added

 OS|Windows (All)   |All

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135310] [META] Writer outline folding bugs and enhancements

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135310

Dieter  changed:

   What|Removed |Added

Summary|[META] Writer outline   |[META] Writer outline
   |content visibility bugs and |folding bugs and
   |enhancements|enhancements

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135310] [META] Writer outline content visibility bugs and enhancements

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135310

Dieter  changed:

   What|Removed |Added

  Alias|Writer-Outline-Content-Visi |Writer-Outline-Folding
   |bility  |

--- Comment #9 from Dieter  ---
Name of the feature is now "Outline Folding" (see bug 141102). So I changed
Alias of this meta-bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141102] The "outline content visibility" feature deserves a friendlier name.

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141102

Dieter  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #7 from Dieter  ---
VERIFIED with

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 807d059d99e7b99fe45a712428befa17ffa44858
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

Jim, thanks for fixing it!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 141102] The "outline content visibility" feature deserves a friendlier name.

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141102

Dieter  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #7 from Dieter  ---
VERIFIED with

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 807d059d99e7b99fe45a712428befa17ffa44858
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

Jim, thanks for fixing it!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 87386] Calculation inaccuracy converting calculated numbers to dates and integers.

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=87386

b.  changed:

   What|Removed |Added

 CC||newbie...@gmx.de

--- Comment #15 from b.  ---
in fp-math '=24,09 - 24' and thus '=mod(24,09;1)' unfortunately results in
8.986E-2, it's the effect of 'cancellation', and not avoidable by
successively subtracting '1', the step '=2,09 - 1' will fail too, 

and calc doesn't apply rounding on date, year, month, day, hour or minute
values but 'truncation', rounding is only performed on seconds, there violating
it's own 'wall clock concept', 

self-help for troubled users: round to meaningful amount of decimals digits,
e.g. '=Mod("value with two decimal places"; integer)' can have at most two
decimal places in the result, 'healing rounding', if you get the 'cut'
somewhere between the needed value and the fp-artifacts you are done, 

or try 'literal calculations' with the digits given in the string,
'=RIGHT(C13;2)' or '=VALUE(RIGHT(C13;2))' would make it for this case, 

idea for programmers: it is an old problem, concerning many areas /
calculations, and causes many irritations up to quarrels, whoever comes first
with a universal solution 'around the corner' will reap fame and glory, i don't
think the task is proven as 'unsolvable' ... 

would like to reopen, but would also like to 'not enrage' @Matthew Francis,
choosing the latter ... ;-) 

@k...@cox.net: 'Some people need to learn that computers and software are
supposed to work for people.' - thumbs up

besides: repro in 7.2.0.0.alpha0+

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103152] [META] Writer image bugs and enhancements

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103152

Dieter  changed:

   What|Removed |Added

 Depends on||141143


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=141143
[Bug 141143] Writer 7.0.5.2 : table of contents splitted on 2 pages - Build ID:
64390860c6cd0aca4beafafcfd84613dd9dfb63a
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141143] Writer 7.0.5.2 : table of contents splitted on 2 pages - Build ID: 64390860c6cd0aca4beafafcfd84613dd9dfb63a

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141143

Dieter  changed:

   What|Removed |Added

 Blocks||103152
 Whiteboard| QA:needsComment|
 CC||dgp-m...@gmx.de
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #3 from Dieter  ---
I confirm the problem with

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 807d059d99e7b99fe45a712428befa17ffa44858
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

But I agree, that the problem is about the image

Steps to reproduce:
1. Open attachment 170603 => TOC is splitted
2. select image on page two and drag it a litkte above, so that it is still
after the text, abut TOC is now on one page. Notive, that there are five empty
paragraphs between image and TOC
3. Save
4. Reload

Actual result:
TOC is again splitted on two pages and an extra empty paragraph is above or
below the image.

Gaido, do you get the same result?
=> NEEDINFO


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103152
[Bug 103152] [META] Writer image bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141261] EDITING Insertions in margin mode shows $2 in margin for comments

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141261

Dieter  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|
 Status|UNCONFIRMED |NEW
 CC||dgp-m...@gmx.de
 Ever confirmed|0   |1

--- Comment #3 from Dieter  ---
I confirm it with

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 807d059d99e7b99fe45a712428befa17ffa44858
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141608] Libre Office Calc crashed when trying to save a doc with .xlsx extension on it by changing the name to drop the .xlsx.

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141608

--- Comment #2 from Harshita Nag  ---
The problem also occurs in Linux.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141608] Libre Office Calc crashed when trying to save a doc with .xlsx extension on it by changing the name to drop the .xlsx.

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141608

Harshita Nag  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from Harshita Nag  ---
Hello colburnde...@hotmail.com,

 Thank you for reporting this bug. I can confirm that this bug is present in
the master branch.

 I am setting the status of this bug to NEW.

 Version: LibreOffice-7.0.5-x86_64.AppImage
 Date: Sat April 10,2021 
 Time: 21:33:15

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112702] [META] DOC (binary) header and footer-related issues

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112702
Bug 112702 depends on bug 120761, which changed state.

Bug 120761 Summary: FILEOPEN Z-order of objects in attached DOC is wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=120761

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sw/source

2021-04-10 Thread Justin Luth (via logerrit)
 sw/source/filter/ww8/ww8graf2.cxx |   10 ++
 1 file changed, 10 insertions(+)

New commits:
commit a6e271621843f454d92bc2c73a4425ad4afd1211
Author: Justin Luth 
AuthorDate: Sat Apr 10 12:00:15 2021 +0200
Commit: Justin Luth 
CommitDate: Sat Apr 10 18:04:35 2021 +0200

tdf#120761 doc import: fix z-order background logic

At first I thought I didn't need to jump
past the hell layer, but then a good night
of sleep told me I better revisit this,
and test a few a my assumptions.

Unfortunately, I don't know how to design
a test document with the specific order
I would need to test this.
So I had to settle for proving it on paper.

I did confirm that BodyText in the background
is still higher than header text in the foreground,
so indeed the header is always the lowest position.

Change-Id: I2054c8fc3ec1e1e7a211397cebe9aff145d701be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113906
Tested-by: Jenkins
Reviewed-by: Justin Luth 

diff --git a/sw/source/filter/ww8/ww8graf2.cxx 
b/sw/source/filter/ww8/ww8graf2.cxx
index 13bf81c97c9f..3e785a9093f5 100644
--- a/sw/source/filter/ww8/ww8graf2.cxx
+++ b/sw/source/filter/ww8/ww8graf2.cxx
@@ -131,6 +131,16 @@ sal_uLong wwZOrderer::GetEscherObjectPos( sal_uLong nSpId,
 ++aIter;
 }
 }
+if (!bInHellLayer)
+{
+while (aIter != aEnd)
+{
+if (!aIter->mbInHellLayer || (_bInHeaderFooter && 
!aIter->mbInHeaderFooter))
+break;
+nRet += aIter->mnNoInlines + 1;
+++aIter;
+}
+}
 while (aIter != aEnd)
 {
 // insert object in page header|footer
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - svx/source

2021-04-10 Thread Caolán McNamara (via logerrit)
 svx/source/dialog/frmsel.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit b606a278aac6ccc395a26bbb6b7a8a5eae91a809
Author: Caolán McNamara 
AuthorDate: Fri Apr 9 20:50:58 2021 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Sat Apr 10 18:01:25 2021 +0200

Resolves: tdf#139075 diagonal focus rects contain focus rects of old size

since...

commit 356f6c5d89dd4dd92b2351898e07f99b96cb34cc
Date:   Tue Jan 15 08:55:00 2013 +

teach FrameSelector to be resizable

Change-Id: I5ac4d1d12f60086349e7dbb3b78d29977f22c226
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113856
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/svx/source/dialog/frmsel.cxx b/svx/source/dialog/frmsel.cxx
index 8854f7d8272c..a7ea0ebedce7 100644
--- a/svx/source/dialog/frmsel.cxx
+++ b/svx/source/dialog/frmsel.cxx
@@ -413,6 +413,9 @@ void FrameSelectorImpl::InitBorderGeometry()
 maHor.AddFocusPolygon(tools::Rectangle( mnLine1 - mnFocusOffs, mnLine2 
- mnFocusOffs, mnLine3 + mnFocusOffs, mnLine2 + mnFocusOffs ) );
 maBottom.AddFocusPolygon( tools::Rectangle( mnLine1 - mnFocusOffs, mnLine3 
- mnFocusOffs, mnLine3 + mnFocusOffs, mnLine3 + mnFocusOffs ) );
 
+maTLBR.ClearFocusArea();
+maBLTR.ClearFocusArea();
+
 for( nCol = 0, nCols = maArray.GetColCount(); nCol < nCols; ++nCol )
 {
 for( nRow = 0, nRows = maArray.GetRowCount(); nRow < nRows; ++nRow )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sw/source

2021-04-10 Thread Caolán McNamara (via logerrit)
 sw/source/filter/ww8/ww8graf.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit a0d4955ba650ace35b7fd411a9670be1032e6982
Author: Caolán McNamara 
AuthorDate: Sat Apr 10 12:42:49 2021 +0100
Commit: Caolán McNamara 
CommitDate: Sat Apr 10 17:56:47 2021 +0200

cid#1476017 Dereference after null check

Change-Id: Icd991bb20dc3aa96041f6a432bddf1bb2775f371
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113907
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sw/source/filter/ww8/ww8graf.cxx b/sw/source/filter/ww8/ww8graf.cxx
index 07ff4d41f730..cae7553eef51 100644
--- a/sw/source/filter/ww8/ww8graf.cxx
+++ b/sw/source/filter/ww8/ww8graf.cxx
@@ -3181,9 +3181,9 @@ SwFlyFrameFormat* 
SwWW8ImplReader::ImportReplaceableDrawables( SdrObject* 
 if (!rpOurNewObject->IsInserted())
 {
 // pass information, if object is in page header|footer to method.
-m_xWWZOrder->InsertEscherObject( rpOurNewObject, pF->nSpId,
- pRecord->bDrawHell,
-   m_bIsHeader || m_bIsFooter );
+m_xWWZOrder->InsertEscherObject(rpOurNewObject, pF->nSpId,
+pRecord && pRecord->bDrawHell,
+m_bIsHeader || m_bIsFooter);
 }
 }
 return pRetFrameFormat;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 90284] SVG export misses a text object

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90284

V Stuart Foote  changed:

   What|Removed |Added

Version|4.3.5.2 release |4.1.4.2 release
 CC||vstuart.fo...@utsa.edu

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - 17 commits - basctl/source basic/source cui/source cui/uiconfig desktop/source fpicker/source framework/source include/vcl sc/sdi sc

2021-04-10 Thread mert (via logerrit)
 basctl/source/basicide/baside2.cxx|2 
 basic/source/classes/sbxmod.cxx   |2 
 basic/source/runtime/methods1.cxx |2 
 cui/source/customize/cfgutil.cxx  |   18 +
 cui/source/factory/dlgfact.cxx|7 +-
 cui/source/factory/dlgfact.hxx|5 -
 cui/source/inc/cfgutil.hxx|2 
 cui/uiconfig/ui/macroselectordialog.ui|4 -
 desktop/source/lib/init.cxx   |5 -
 fpicker/source/win32/asyncrequests.cxx|2 
 framework/source/loadenv/loadenv.cxx  |2 
 include/vcl/svapp.hxx |4 +
 include/vcl/toolkit/dialog.hxx|1 
 sc/sdi/drawsh.sdi |2 
 sc/source/core/tool/chgtrack.cxx  |4 -
 sc/source/filter/oox/workbookfragment.cxx |2 
 sc/source/ui/drawfunc/drawsh.cxx  |   17 +
 sfx2/source/appl/appserv.cxx  |   39 ++--
 sfx2/source/doc/docfile.cxx   |2 
 sfx2/source/doc/printhelper.cxx   |4 -
 svx/source/dialog/docrecovery.cxx |2 
 svx/source/svdraw/svdmrkv.cxx |   95 ++
 svx/source/svdraw/svdoedge.cxx|6 +
 sw/sdi/_viewsh.sdi|5 +
 sw/sdi/drawsh.sdi |5 +
 sw/source/uibase/dbui/dbmgr.cxx   |2 
 sw/source/uibase/shells/drawsh.cxx|   16 -
 sw/source/uibase/uiview/view2.cxx |   18 +
 sw/source/uibase/uno/unotxdoc.cxx |4 -
 vbahelper/source/vbahelper/vbahelper.cxx  |2 
 vcl/inc/salvtables.hxx|2 
 vcl/jsdialog/executor.cxx |   33 ++
 vcl/source/app/salvtables.cxx |7 ++
 vcl/source/app/svapp.cxx  |5 +
 vcl/source/control/notebookbar.cxx|3 
 vcl/source/control/prgsbar.cxx|2 
 vcl/source/window/dialog.cxx  |   10 ++-
 vcl/source/window/menufloatingwindow.cxx  |2 
 vcl/source/window/syswin.cxx  |2 
 39 files changed, 260 insertions(+), 87 deletions(-)

New commits:
commit 91b6b67cfb41fd661bc0417a0fbe9595774deddd
Author: mert 
AuthorDate: Thu Feb 25 11:41:24 2021 +0300
Commit: Michael Meeks 
CommitDate: Sat Apr 10 16:20:49 2021 +0100

Init Notebookbar for Online Draw

Signed-off-by: mert 
Change-Id: I85a25820d3968070dd8a05156b4bb4a1ebe59f99
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111517

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 153be8911426..7b455cf7b348 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -6380,6 +6380,7 @@ static int lo_initialize(LibreOfficeKit* pThis, const 
char* pAppPath, const char
 activateNotebookbar("Writer");
 activateNotebookbar("Calc");
 activateNotebookbar("Impress");
+activateNotebookbar("Draw");
 }
 
 return bInitialized;
diff --git a/vcl/source/control/notebookbar.cxx 
b/vcl/source/control/notebookbar.cxx
index 64686e1729b5..1c2a7c9d3252 100644
--- a/vcl/source/control/notebookbar.cxx
+++ b/vcl/source/control/notebookbar.cxx
@@ -71,7 +71,8 @@ NotebookBar::NotebookBar(Window* pParent, const OString& rID, 
const OUString& rU
 bool bIsWelded = comphelper::LibreOfficeKit::isActive()
 && (rUIXMLDescription == 
"modules/swriter/ui/notebookbar.ui"
 || rUIXMLDescription == "modules/scalc/ui/notebookbar.ui"
-|| rUIXMLDescription == 
"modules/simpress/ui/notebookbar.ui");
+|| rUIXMLDescription == 
"modules/simpress/ui/notebookbar.ui"
+|| rUIXMLDescription == "modules/sdraw/ui/notebookbar.ui");
 if (bIsWelded)
 {
 m_bIsWelded = true;
commit c0f897e54f70cc066a436d6b6e9aca2071b1cbcf
Author: mert 
AuthorDate: Wed Feb 24 06:22:49 2021 +0300
Commit: Michael Meeks 
CommitDate: Sat Apr 10 16:20:49 2021 +0100

Fix chart sub element rectangle and handle positions

Change-Id: I486b542ae0bb4a987c98d92c1866895eafcf620c
Signed-off-by: mert 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111440
Tested-by: Jenkins CollaboraOffice 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111516
Tested-by: Jenkins

diff --git a/svx/source/svdraw/svdmrkv.cxx b/svx/source/svdraw/svdmrkv.cxx
index 1ccb5de7e6a0..f75bb22f3dda 100644
--- a/svx/source/svdraw/svdmrkv.cxx
+++ b/svx/source/svdraw/svdmrkv.cxx
@@ -689,7 +689,7 @@ void SdrMarkView::SetMarkHandlesForLOKit(tools::Rectangle 
const & rRect, const S
 
 tools::Rectangle aSelection(rRect);
 bool bIsChart = false;
-
+Point addLogicOffset(0, 0);
 if (!rRect.IsEmpty())
 {
 sal_uInt32 nTotalPaintWindows = this->PaintWindowCount();
@@ -704,6 +704,7 @@ void SdrMarkView::SetMarkHandlesForLOKit(tools::Rectangle 
const & rRect, const S
 {
 Point aOffsetPx = 

[Libreoffice-bugs] [Bug 117750] Some of the image filters aren't working (like Aging or Relief)

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117750

--- Comment #9 from PeeWee  ---
This bug has not been fixed. LO 7.1.1.2 in all operating systems still has the
problem

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 111450] [META] SVG fileSave filter (Draw)

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=111450
Bug 111450 depends on bug 99769, which changed state.

Bug 99769 Summary: export to SVG drops some text
https://bugs.documentfoundation.org/show_bug.cgi?id=99769

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 90284] SVG export misses a text object

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90284

V Stuart Foote  changed:

   What|Removed |Added

 CC||richard-...@esplins.org

--- Comment #13 from V Stuart Foote  ---
*** Bug 99769 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 99769] export to SVG drops some text

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=99769

V Stuart Foote  changed:

   What|Removed |Added

Version|5.0.6.2 rc  |4.1.4.2 release
 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #11 from V Stuart Foote  ---


*** This bug has been marked as a duplicate of bug 90284 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 111450] [META] SVG fileSave filter (Draw)

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=111450
Bug 111450 depends on bug 92678, which changed state.

Bug 92678 Summary: FILESAVE: export from Draw to SVG does not save text on 
objects
https://bugs.documentfoundation.org/show_bug.cgi?id=92678

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 88277] [META] OBSOLETE - SVG fileOpen filter (Draw)

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88277
Bug 88277 depends on bug 92678, which changed state.

Bug 92678 Summary: FILESAVE: export from Draw to SVG does not save text on 
objects
https://bugs.documentfoundation.org/show_bug.cgi?id=92678

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 90284] SVG export misses a text object

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90284

V Stuart Foote  changed:

   What|Removed |Added

 CC||joeinbox...@hotmail.com

--- Comment #12 from V Stuart Foote  ---
*** Bug 92678 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 92678] FILESAVE: export from Draw to SVG does not save text on objects

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=92678

V Stuart Foote  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #15 from V Stuart Foote  ---


*** This bug has been marked as a duplicate of bug 90284 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 117750] Some of the image filters aren't working (like Aging or Relief)

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117750

Julien Nabet  changed:

   What|Removed |Added

 CC||psaut...@gmail.com

--- Comment #8 from Julien Nabet  ---
*** Bug 141602 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141602] Image filters have no effect on an image

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141602

Julien Nabet  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Julien Nabet  ---


*** This bug has been marked as a duplicate of bug 117750 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 130326] XLSX: Long time for file opens and using 100% of one core of CPU after opening

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=130326

Julien Nabet  changed:

   What|Removed |Added

 Attachment #171057|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Makefile.in

2021-04-10 Thread Caolán McNamara (via logerrit)
 Makefile.in |   13 -
 1 file changed, 8 insertions(+), 5 deletions(-)

New commits:
commit 1eb18361783a25e6c70a94564d55d4e2db7586dd
Author: Caolán McNamara 
AuthorDate: Wed Apr 7 15:12:39 2021 +0100
Commit: Caolán McNamara 
CommitDate: Sat Apr 10 17:14:46 2021 +0200

use systemd-detect-virt to detect building as root in container

Drop the older container detection attempts because they are not
reliable to detect being run as root in a container in github actions.

 
https://github.com/google/oss-fuzz/issues/4093#issuecomment-656290094 "It 
appears some GitHub actions are run with docker.service (where docker is in 
/proc/self/cgroup) while the zstd actions are run with containerd.service where 
/proc/self/cgroup looks like […]"
 https://github.com/google/oss-fuzz/pull/4101 → probably also just 
use systemd-detect-virt instead of the grepping ourselves...

if we're root and systemd-detect-virt doesn't exist or it claims
we're not in a container then continue to abort the build

using LIB_FUZZING_ENGINE for the oss-fuzz specific case worked fine,
but lets try something a little more generic.

Change-Id: I59711b01dfcd052b5af899ad41ae5890f849eacb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113738
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/Makefile.in b/Makefile.in
index 23b4d4f17d90..1e0d1a5d0968 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -59,11 +59,14 @@ else # MAKE_RESTARTS
 .DEFAULT_GOAL := build
 
 check-if-root:
-   @if test ! `uname` = 'Haiku' -a `id -u` = 0 && test -z 
$$LIB_FUZZING_ENGINE && test -z $$container && ! grep -q 'lxc\|docker' 
/proc/self/cgroup && ! grep -q 'libpod_parent' /proc/self/cgroup; then \
-   echo; \
-   echo 'Building LibreOffice as root is a very bad idea, use a 
regular user.'; \
-   echo; \
-   exit 1; \
+   @if test ! `uname` = 'Haiku' -a `id -u` = 0; then \
+   # if the systemd-detect-virt command doesn't exist or it 
reports we're not in a container \
+   if test ! -x "$$(command -v systemd-detect-virt)" || ! 
systemd-detect-virt -c -q; then \
+   echo; \
+   echo 'Building LibreOffice as root is a very bad idea, 
use a regular user.'; \
+   echo; \
+   exit 1; \
+   fi \
fi
 
 gb_Side ?= host
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 130326] XLSX: Long time for file opens and using 100% of one core of CPU after opening

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=130326

--- Comment #16 from Julien Nabet  ---
Created attachment 171084
  --> https://bugs.documentfoundation.org/attachment.cgi?id=171084=edit
perf flamegraph during opening

Here's a new Flamegraph with master sources updated today
(526f0fce45fb014b09057403ae37c125e5a18655)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 125580] Wrong value when adding two dates

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125580

b.  changed:

   What|Removed |Added

   Keywords|regression  |

--- Comment #14 from b.  ---
(In reply to Eike Rathke from comment #13)
> (In reply to b. from comment #12)
... 
> And that is completely unrelated and thus off-topic because this bug here is
> not about any fill series but explicit user supplied formula expressions
> accumulating an error. 

yes, SIR!, YES!, 

but with all due respect, and i politely apologize that i have to try to
clarify three things: 

1. it's less the 'user defined formula' accumulating deviations, but 'fp-math'
and how calc displays timestamps, in three steps: 
   a. the IEEE 754 double value for 5 minutes is already short by ~
2.E-19 because it's an endless fraction truncated after 53 bits, 
   b. this value looses it's last 24 bits (011100011100011100011100) accounting
for appr. 3.2337587468900253E-12 in the addition to a value in the range of
today() by crossing 24 bin ranges from -9 to +15, and that without compensation
by rounding because the chopped off string starts with a '0', 
   c. thus the really added portion accounts for only ~ 0.003472189885,
corresponding to a time value of ~00:04:59,997206 [hh:mm:ss,00] 
   d. as calc's display for date and time values doesn't round minutes the
deviation becomes visible already at very small portions and looks 'boosted' in
strings formatted to show minutes but not seconds, 

2. what the OP was talking about is not! his formula being erroneous, but he
asks for explanation why it fails in 'dragfill' (which imho is just another
interface to construct a fill series), 

3. despite this situation which would also justify other proposals ... what i'd
propose is! exactly that: a replacement for the user defined formula avoiding
accumulation of errors (exactly it is / needs two combined formulas), 
   a. despite similar could - and imho should - be realized in code it also
can! be used in user space as formula in sheet or similar implemented as a
macro, it's an exactly targetted solution for the OP problem, imho the
simpliest covering the full complexity ... 

thus sorry SIR!, imho you'd shoot fast but a little bit off, please reactivate
the suppressed comments. 

@Alexandre Rio: 'but doesn't work with only =NOW() function in first cell.'
results from 'now' mostly! not being a value with 0,0 seconds, thus there
is some 'buffer' to compensate the too small represented increment, and thus
the problem will show up later after plenty additions, but will ... despite the
buffer bridges to a range where the increment get's chopped before a 1 and will
be rounded up, then the fail will run in the other direction ... 

removing 'regression' as the change in time stamp handling is intentional,

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 130326] XLSX: Long time for file opens and using 100% of one core of CPU after opening

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=130326

--- Comment #15 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/44711d9eb53eb6247ebdb9293a3eb5e643f78059

tdf#130326 related, speed up drawing

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: include/svx svx/source

2021-04-10 Thread Noel Grandin (via logerrit)
 include/svx/sdr/contact/viewcontact.hxx |3 ++-
 svx/source/sdr/contact/viewcontact.cxx  |   30 +-
 2 files changed, 19 insertions(+), 14 deletions(-)

New commits:
commit 44711d9eb53eb6247ebdb9293a3eb5e643f78059
Author: Noel Grandin 
AuthorDate: Fri Apr 9 19:40:24 2021 +0200
Commit: Noel Grandin 
CommitDate: Sat Apr 10 16:53:59 2021 +0200

tdf#130326 related, speed up drawing

if we create the list every time we call
ViewContact::getViewIndependentPrimitive2DContainer
then caching the result is rather worthless.
So make the caching worthwhile, which means invalidating
it when something changes.

Change-Id: I081e9501255ec1c87454bfcc1e0a741109afa99f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113891
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/include/svx/sdr/contact/viewcontact.hxx 
b/include/svx/sdr/contact/viewcontact.hxx
index c5cc61883a49..d5603790ffd0 100644
--- a/include/svx/sdr/contact/viewcontact.hxx
+++ b/include/svx/sdr/contact/viewcontact.hxx
@@ -49,7 +49,8 @@ private:
 // Primitive2DContainer of the ViewContact. This contains all necessary 
information
 // for the graphical visualisation and needs to be supported by all VCs 
which
 // can be visualized.
-drawinglayer::primitive2d::Primitive2DContainer 
mxViewIndependentPrimitive2DSequence;
+mutable drawinglayer::primitive2d::Primitive2DContainer 
mxViewIndependentPrimitive2DSequence;
+mutable bool mbNeedToCreatePrimitives;
 
 // A new ViewObjectContact was created and shall be remembered.
 void AddViewObjectContact(ViewObjectContact& rVOContact);
diff --git a/svx/source/sdr/contact/viewcontact.cxx 
b/svx/source/sdr/contact/viewcontact.cxx
index 8e8d35db4406..75c40cfb2cc4 100644
--- a/svx/source/sdr/contact/viewcontact.cxx
+++ b/svx/source/sdr/contact/viewcontact.cxx
@@ -39,6 +39,7 @@ ViewObjectContact& 
ViewContact::CreateObjectSpecificViewObjectContact(ObjectCont
 ViewContact::ViewContact()
 : maViewObjectContactVector()
 , mxViewIndependentPrimitive2DSequence()
+, mbNeedToCreatePrimitives(true)
 {
 }
 
@@ -61,6 +62,7 @@ void ViewContact::deleteAllVOCs()
 
 // assert when there were new entries added during deletion
 DBG_ASSERT(maViewObjectContactVector.empty(), "Corrupted 
ViewObjectContactList in VC (!)");
+mbNeedToCreatePrimitives = true;
 }
 
 // get an Object-specific ViewObjectContact for a specific
@@ -96,6 +98,7 @@ ViewObjectContact& 
ViewContact::GetViewObjectContact(ObjectContact& rObjectConta
 void ViewContact::AddViewObjectContact(ViewObjectContact& rVOContact)
 {
 maViewObjectContactVector.push_back();
+mbNeedToCreatePrimitives = true;
 }
 
 // A ViewObjectContact was deleted and shall be forgotten.
@@ -107,6 +110,7 @@ void 
ViewContact::RemoveViewObjectContact(ViewObjectContact& rVOContact)
 if (aFindResult != maViewObjectContactVector.end())
 {
 maViewObjectContactVector.erase(aFindResult);
+mbNeedToCreatePrimitives = true;
 }
 }
 
@@ -182,6 +186,7 @@ void ViewContact::ActionChildInserted(ViewContact& rChild)
 // rectangle will be invalidated at the associated OutputDevice.
 pCandidate->ActionChildInserted(rChild);
 }
+mbNeedToCreatePrimitives = true;
 }
 
 // React on changes of the object of this ViewContact
@@ -199,6 +204,7 @@ void ViewContact::ActionChanged()
 
 pCandidate->ActionChanged();
 }
+mbNeedToCreatePrimitives = true;
 }
 
 // access to SdrObject and/or SdrPage. May return 0L like the default
@@ -229,22 +235,20 @@ ViewContact::createViewIndependentPrimitive2DSequence() 
const
 drawinglayer::primitive2d::Primitive2DContainer const&
 ViewContact::getViewIndependentPrimitive2DContainer() const
 {
-// local up-to-date checks. Create new list and compare.
-drawinglayer::primitive2d::Primitive2DContainer xNew(
-createViewIndependentPrimitive2DSequence());
-
-if (!xNew.empty())
+if (mbNeedToCreatePrimitives)
 {
-// allow evtl. embedding in object-specific infos, e.g. Name, Title, 
Description
-xNew = embedToObjectSpecificInformation(std::move(xNew));
-}
+drawinglayer::primitive2d::Primitive2DContainer xNew(
+createViewIndependentPrimitive2DSequence());
 
-if (mxViewIndependentPrimitive2DSequence != xNew)
-{
-// has changed, copy content
-const_cast(this)->mxViewIndependentPrimitive2DSequence = 
std::move(xNew);
-}
+if (!xNew.empty())
+{
+// allow evtl. embedding in object-specific infos, e.g. Name, 
Title, Description
+xNew = embedToObjectSpecificInformation(std::move(xNew));
+}
 
+mxViewIndependentPrimitive2DSequence = std::move(xNew);
+mbNeedToCreatePrimitives = false;
+}
 // return current Primitive2DContainer
 return mxViewIndependentPrimitive2DSequence;
 }
___

[Libreoffice-commits] core.git: svx/source

2021-04-10 Thread Noel Grandin (via logerrit)
 svx/source/svdraw/svdpage.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 566e43d2129dd6c70bb718296ce66353e7ff824b
Author: Noel Grandin 
AuthorDate: Sat Apr 10 13:47:00 2021 +0200
Commit: Noel Grandin 
CommitDate: Sat Apr 10 16:53:26 2021 +0200

tdf#130326 speed up XLSX load

cuts time from 35s to 25s for me.

If the model is locked, we should not be broadcasting events.

Change-Id: I4d8ca10c9d2a9862b30f88cc00e65aab1e2fad7d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113909
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/svx/source/svdraw/svdpage.cxx b/svx/source/svdraw/svdpage.cxx
index 02a891f290ff..adcbb8f713f6 100644
--- a/svx/source/svdraw/svdpage.cxx
+++ b/svx/source/svdraw/svdpage.cxx
@@ -365,7 +365,7 @@ void SdrObjList::InsertObject(SdrObject* pObj, size_t nPos)
 
 // TODO: We need a different broadcast here!
 // Repaint from object number ... (heads-up: GroupObj)
-if(pObj->getSdrPageFromSdrObject())
+if(pObj->getSdrPageFromSdrObject() && 
!pObj->getSdrModelFromSdrObject().isLocked())
 {
 SdrHint aHint(SdrHintKind::ObjectInserted, *pObj);
 pObj->getSdrModelFromSdrObject().Broadcast(aHint);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 130326] XLSX: Long time for file opens and using 100% of one core of CPU after opening

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=130326

--- Comment #14 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/566e43d2129dd6c70bb718296ce66353e7ff824b

tdf#130326 speed up XLSX load

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - 9 commits - desktop/qa editeng/source include/editeng sc/source sfx2/source sw/source tools/source uui/source

2021-04-10 Thread Henry Castro (via logerrit)
 desktop/qa/desktop_lib/test_desktop_lib.cxx |   39 +++-
 editeng/source/editeng/editview.cxx |5 +++
 editeng/source/outliner/outlvw.cxx  |5 +++
 include/editeng/editview.hxx|1 
 include/editeng/outliner.hxx|1 
 sc/source/ui/docshell/docfunc.cxx   |   29 ++--
 sfx2/source/view/lokhelper.cxx  |   12 ++--
 sw/source/uibase/docvw/AnnotationWin2.cxx   |   12 
 tools/source/misc/json_writer.cxx   |   21 +++
 uui/source/secmacrowarnings.cxx |   23 ++--
 uui/source/secmacrowarnings.hxx |2 +
 11 files changed, 123 insertions(+), 27 deletions(-)

New commits:
commit 0dda8ba9cdc7fe6806d5ebca98cc628ec3d32db3
Author: Henry Castro 
AuthorDate: Fri Mar 5 06:45:45 2021 -0400
Commit: Michael Meeks 
CommitDate: Sat Apr 10 15:49:33 2021 +0100

lok: show only the filename of the Macro Security dialog

Apply the patch for desktop case too.

Change-Id: Ia4cf6d2cefd0e02e11e48ca017f8af9f81600b16
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112003
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Jan Holesovsky 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113688
Tested-by: Jenkins
Reviewed-by: Henry Castro 

diff --git a/uui/source/secmacrowarnings.cxx b/uui/source/secmacrowarnings.cxx
index 932c4723ab21..7c853cf2f8e0 100644
--- a/uui/source/secmacrowarnings.cxx
+++ b/uui/source/secmacrowarnings.cxx
@@ -19,8 +19,6 @@
 
 #include 
 #include 
-#include 
-#include 
 #include 
 #include 
 #include 
@@ -29,8 +27,6 @@
 #include 
 #include 
 #include 
-#include 
-#include 
 
 using namespace ::com::sun::star::security;
 
@@ -92,15 +88,11 @@ IMPL_STATIC_LINK_NOARG(MacroWarning, InstallLOKNotifierHdl, 
void*, vcl::ILibreOf
 
 void MacroWarning::SetDocumentURL( const OUString& rDocURL )
 {
-OUString aAbbreviatedPath;
-if (comphelper::LibreOfficeKit::isActive())
-{
-osl::FileBase::getFileURLFromSystemPath(rDocURL, aAbbreviatedPath);
-aAbbreviatedPath = INetURLObject(aAbbreviatedPath).GetLastName();
-}
-else
-osl_abbreviateSystemPath(rDocURL.pData, , 50, 
nullptr);
-m_xDialog->set_primary_text(aAbbreviatedPath);
+OUString aPath;
+
+osl::FileBase::getFileURLFromSystemPath(rDocURL, aPath);
+aPath = INetURLObject(aPath).GetLastName();
+m_xDialog->set_primary_text(aPath);
 }
 
 IMPL_LINK_NOARG(MacroWarning, ViewSignsBtnHdl, weld::Button&, void)
commit 8640c1249b675bd6bd3489e901234ac04c37bd7d
Author: Henry Castro 
AuthorDate: Wed Mar 3 18:17:31 2021 -0400
Commit: Michael Meeks 
CommitDate: Sat Apr 10 15:49:33 2021 +0100

lok: strip directory and suffix from filenames

The Macro Warning dialog should only show the filename

Change-Id: I04f1d3a1b945d65276187ca0a284e41bd08ed298
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111941
Tested-by: Jenkins CollaboraOffice 
Tested-by: Michael Meeks 
Reviewed-by: Michael Meeks 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113687
Tested-by: Jenkins

diff --git a/uui/source/secmacrowarnings.cxx b/uui/source/secmacrowarnings.cxx
index 90d76d75e6ce..932c4723ab21 100644
--- a/uui/source/secmacrowarnings.cxx
+++ b/uui/source/secmacrowarnings.cxx
@@ -19,12 +19,18 @@
 
 #include 
 #include 
+#include 
+#include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
 #include 
+#include 
+#include 
+#include 
 
 using namespace ::com::sun::star::security;
 
@@ -87,7 +93,13 @@ IMPL_STATIC_LINK_NOARG(MacroWarning, InstallLOKNotifierHdl, 
void*, vcl::ILibreOf
 void MacroWarning::SetDocumentURL( const OUString& rDocURL )
 {
 OUString aAbbreviatedPath;
-osl_abbreviateSystemPath(rDocURL.pData, , 50, 
nullptr);
+if (comphelper::LibreOfficeKit::isActive())
+{
+osl::FileBase::getFileURLFromSystemPath(rDocURL, aAbbreviatedPath);
+aAbbreviatedPath = INetURLObject(aAbbreviatedPath).GetLastName();
+}
+else
+osl_abbreviateSystemPath(rDocURL.pData, , 50, 
nullptr);
 m_xDialog->set_primary_text(aAbbreviatedPath);
 }
 
commit acbf57b47fecc78ab31af151f6540c83ecc1d983
Author: Henry Castro 
AuthorDate: Fri Dec 25 13:36:03 2020 -0400
Commit: Michael Meeks 
CommitDate: Sat Apr 10 15:49:33 2021 +0100

lok: add global notifier to the "Macro Security Warning"

dialog.

This message dialog is especial, because it is shown before
loading the document so no way to get access to view shell
notifier when the model/view/controller were not created.

Change-Id: I5da3ca9d1009f174f2d96c1302770f4509a807cf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108291
Tested-by: Jenkins
Reviewed-by: Henry Castro 

diff --git a/uui/source/secmacrowarnings.cxx b/uui/source/secmacrowarnings.cxx
index 7a657d03ca2d..90d76d75e6ce 100644
--- 

[Libreoffice-commits] core.git: wizards/source

2021-04-10 Thread Jean-Pierre Ledure (via logerrit)
 wizards/source/scriptforge/SF_Exception.xba  |2 
 wizards/source/scriptforge/SF_PythonHelper.xba   |4 
 wizards/source/scriptforge/SF_String.xba |2 
 wizards/source/scriptforge/python/scriptforge.py |  103 ---
 wizards/source/sfdocuments/SF_FormControl.xba|   75 
 5 files changed, 118 insertions(+), 68 deletions(-)

New commits:
commit de3b720f4066c9fcf1258bf6592263a7e476cc46
Author: Jean-Pierre Ledure 
AuthorDate: Sat Apr 10 15:10:02 2021 +0200
Commit: Jean-Pierre Ledure 
CommitDate: Sat Apr 10 16:44:27 2021 +0200

ScriptForge - (scriptforge.py) FormControl class

New class to manage controls in forms and subforms
from Python, essentially thru the use of Properties

Required a review of SF_FormControl.Getproperty()
Indeed, the IDE debugger computes all the properties
of a Basic object when expanded in the watch window.
This can cause errors.
This class makes use of default values for properties
when irrelevant for the actual control type

Error were detected on date/time conversions of date/timefield
controls and corrected.

SF_String etc shortcuts have been removed (see previous commit)
because not applicable in every scenario.
The only entry point to the API from a user Python script
is via CreateScriptService().

Change-Id: Ia87c7281c3fcf39ab0c3528f00114c9b1e067bcf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113920
Tested-by: Jean-Pierre Ledure 
Tested-by: Jenkins
Reviewed-by: Jean-Pierre Ledure 

diff --git a/wizards/source/scriptforge/SF_Exception.xba 
b/wizards/source/scriptforge/SF_Exception.xba
index d2ee476c6430..650f14164a02 100644
--- a/wizards/source/scriptforge/SF_Exception.xba
+++ b/wizards/source/scriptforge/SF_Exception.xba
@@ -1173,4 +1173,4 @@ Private Function _Repr() As String
 End Function ScriptForge.SF_Exception._Repr
 
 REM  END OF 
SCRIPTFORGE.SF_EXCEPTION
-
+
\ No newline at end of file
diff --git a/wizards/source/scriptforge/SF_PythonHelper.xba 
b/wizards/source/scriptforge/SF_PythonHelper.xba
index e3d988c38aa9..328978033290 100644
--- a/wizards/source/scriptforge/SF_PythonHelper.xba
+++ b/wizards/source/scriptforge/SF_PythonHelper.xba
@@ -729,6 +729,10 @@ Try:
Case 
Controls   :   vReturn = 
vBasicObject.Controls(vArgs(0))
Case 
Subforms   :   vReturn = 
vBasicObject.Subforms(vArgs(0))
End Select
+   Case SFDocuments.FormControl
+   Select Case Script
+   Case 
Controls   :   vReturn = 
vBasicObject.Controls(vArgs(0))
+   End Select
End Select

  Methods in class modules are invoked with 
CallByName
diff --git a/wizards/source/scriptforge/SF_String.xba 
b/wizards/source/scriptforge/SF_String.xba
index 6519ac2383d3..f7c645981c8b 100644
--- a/wizards/source/scriptforge/SF_String.xba
+++ b/wizards/source/scriptforge/SF_String.xba
@@ -2309,7 +2309,7 @@ Dim bSplit As Boolean 
  New chunk found or not
 Dim i As Long
 Const cstDouble =  :   Const cstSingle 
= 
 Const cstThisSub = String.SplitNotQuoted
-Const cstSubArgs = InputStr, [Delimiter= ], 
[Occurrences=0], [QuoteChar=  cstDouble  

+Const cstSubArgs = InputStr, [Delimiter= ], 
[Occurrences=0], [QuoteChar=  cstDouble  
]
 
If SF_Utils._ErrorHandling() Then On Local Error GoTo Catch
vSplit = Array()
diff --git a/wizards/source/scriptforge/python/scriptforge.py 
b/wizards/source/scriptforge/python/scriptforge.py
index c143d196e3b7..e3d4bdfa63e6 100644
--- a/wizards/source/scriptforge/python/scriptforge.py
+++ b/wizards/source/scriptforge/python/scriptforge.py
@@ -183,7 +183,7 @@ class ScriptForge(object, metaclass = _Singleton):
 """
 servicemanager = context.ServiceManager  # 
com.sun.star.lang.XMultiComponentFactory
 masterscript = servicemanager.createInstanceWithContext(
-"com.sun.star.script.provider.MasterScriptProviderFactory", 
context)
+'com.sun.star.script.provider.MasterScriptProviderFactory', 
context)
 return masterscript.createScriptProvider("")
 
 @classmethod
@@ -201,7 +201,7 @@ class ScriptForge(object, metaclass = _Singleton):
 :return: the value returned by the invoked script, or an error if 
the script was not found
 """
 
-# The frequently called PythonDispatcher in the ScriptForge Basic 
library is buffered to privilege performance
+# The frequently called 

[Libreoffice-bugs] [Bug 141599] Libre Office 7.0.5 doesn't open

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141599

Flora  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #2 from Flora  ---
Dear Julien, I looked at QA/FirstSteps - I had the latest version, 7.0.5 and it
didn't open. 
I have Windows 10, version 20H2. 
It's updated. 
I removed Libre Office 7.0.5 and installed 6.4.7.2 (x64), and it works now.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141292] Calc should display hint "internal calculation is done without rounding".

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141292

b.  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #19 from b.  ---
it's two different problems ... 

one is the logical problem with rounding in totaling calculations, e.g the
conflict between selling two items for 1,02 bucks, each charged with 19 percent
VAT resulting in - rounded down - two times 0,19 -> 0,38, vs. calculating the
VAT for the full net amount of 2,04 bucks to - rounded up - 0,39 is a problem a
spreadsheet can't solve, the user must be aware that there are pitfalls, check
the correct way to calculate with his accountant, and take that into account
... 

(spreadsheets can be set up correctly for each schema, but not for both at the
same time)

another problem is with which values calc calculates, and how much of it is
visible / accessible to the user, that would have been quite easy for this
case, but is a real pain once you get behind 14 digits, i vote for 'enhance
this',

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 141292] Calc should display hint "internal calculation is done without rounding".

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141292

b.  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #19 from b.  ---
it's two different problems ... 

one is the logical problem with rounding in totaling calculations, e.g the
conflict between selling two items for 1,02 bucks, each charged with 19 percent
VAT resulting in - rounded down - two times 0,19 -> 0,38, vs. calculating the
VAT for the full net amount of 2,04 bucks to - rounded up - 0,39 is a problem a
spreadsheet can't solve, the user must be aware that there are pitfalls, check
the correct way to calculate with his accountant, and take that into account
... 

(spreadsheets can be set up correctly for each schema, but not for both at the
same time)

another problem is with which values calc calculates, and how much of it is
visible / accessible to the user, that would have been quite easy for this
case, but is a real pain once you get behind 14 digits, i vote for 'enhance
this',

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 117257] Exporting to SVG [or any format] makes hidden layer visible

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117257

mwtjunkm...@gmail.com changed:

   What|Removed |Added

Summary|Exporting to SVG makes  |Exporting to SVG [or any
   |hidden layer visible|format] makes hidden layer
   ||visible

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 98743] TIFF EXPORT saves weird image: in different x-y resolution and dimensions

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=98743

mwtjunkm...@gmail.com changed:

   What|Removed |Added

 CC||mwtjunkm...@gmail.com

--- Comment #14 from mwtjunkm...@gmail.com ---
(In reply to sdc.blanco from comment #13)
> (In reply to Andrea Giudiceandrea from comment #9)
> > There is no "TIFF Options" windows when exporting in TIFF format from Draw,
> > so it's impossible to set Width/Height/Resolution of the exported image.
> Workaround:  1. Export to PNG/JPG (setting values). 2. Open in image-editing
> program that can save as TIFF.

Which negates the entire point of having a TIFF export option at all in LO
draw.

This bug is similar to mine which no one's ever looked at 

https://bugs.documentfoundation.org/show_bug.cgi?id=139161

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sc/source

2021-04-10 Thread Caolán McNamara (via logerrit)
 sc/source/filter/excel/xiescher.cxx |9 +
 1 file changed, 5 insertions(+), 4 deletions(-)

New commits:
commit 32ad749a512b03e2d4588de667e397949cc51958
Author: Caolán McNamara 
AuthorDate: Fri Apr 9 21:05:15 2021 +0100
Commit: Caolán McNamara 
CommitDate: Sat Apr 10 15:53:27 2021 +0200

cid#1474380 silence Untrusted loop bound

Change-Id: Ic162a5aeed4b422a8db5ff1bdd89c4e098ffa248
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113908
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sc/source/filter/excel/xiescher.cxx 
b/sc/source/filter/excel/xiescher.cxx
index 599135666e47..1a5ce0638e60 100644
--- a/sc/source/filter/excel/xiescher.cxx
+++ b/sc/source/filter/excel/xiescher.cxx
@@ -1345,11 +1345,12 @@ void XclImpPolygonObj::ReadCoordList( XclImpStream& 
rStrm )
 if( (rStrm.GetNextRecId() == EXC_ID_COORDLIST) && rStrm.StartNextRecord() )
 {
 OSL_ENSURE( rStrm.GetRecLeft() / 4 == mnPointCount, 
"XclImpPolygonObj::ReadCoordList - wrong polygon point count" );
-while( rStrm.GetRecLeft() >= 4 )
+while (true)
 {
-sal_uInt16 nX, nY;
-nX = rStrm.ReaduInt16();
-nY = rStrm.ReaduInt16();
+if (rStrm.GetRecLeft() < 4)
+break;
+sal_uInt16 nX = rStrm.ReaduInt16();
+sal_uInt16 nY = rStrm.ReaduInt16();
 maCoords.emplace_back( nX, nY );
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 117257] Exporting to SVG makes hidden layer visible

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117257

--- Comment #6 from mwtjunkm...@gmail.com ---
Still a problem in

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 807d059d99e7b99fe45a712428befa17ffa44858
CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 136918] Style down arrow not completely visible

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136918

Buovjaga  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #8 from Buovjaga  ---
Verified, thanks

Arch Linux 64-bit
Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 3b6408988487c886adc5415f7050f9da13d2e16b
CPU threads: 8; OS: Linux 5.11; UI render: default; VCL: kf5
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 8 April 2021

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 130326] XLSX: Long time for file opens and using 100% of one core of CPU after opening

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=130326

--- Comment #13 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/526f0fce45fb014b09057403ae37c125e5a18655

tdf#130326 speed up opening XLSX

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: svx/source

2021-04-10 Thread Noel Grandin (via logerrit)
 svx/source/unodraw/unoshape.cxx |   14 --
 1 file changed, 8 insertions(+), 6 deletions(-)

New commits:
commit 526f0fce45fb014b09057403ae37c125e5a18655
Author: Noel Grandin 
AuthorDate: Fri Apr 9 12:05:16 2021 +0200
Commit: Noel Grandin 
CommitDate: Sat Apr 10 15:34:22 2021 +0200

tdf#130326 speed up opening XLSX

SvxShape::Notify is called a lot (26%) of CPU, so re-arrange it
to do the cheapest checks first.

Change-Id: I0e6c6c976ecfe7670e8d4af175606654f839aa66
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113843
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/svx/source/unodraw/unoshape.cxx b/svx/source/unodraw/unoshape.cxx
index 1e5263921fd2..de292ef43bb3 100644
--- a/svx/source/unodraw/unoshape.cxx
+++ b/svx/source/unodraw/unoshape.cxx
@@ -992,16 +992,18 @@ uno::Sequence< sal_Int8 > SAL_CALL 
SvxShape::getImplementationId()
 void SvxShape::Notify( SfxBroadcaster&, const SfxHint& rHint ) throw()
 {
 DBG_TESTSOLARMUTEX();
-if( !HasSdrObject() )
-return;
 
-// #i55919# SdrHintKind::ObjectChange is only interesting if it's for this 
object
+// do cheap checks first, this method is hot
 if (rHint.GetId() != SfxHintId::ThisIsAnSdrHint)
 return;
-SdrObject* pSdrObject(GetSdrObject());
 const SdrHint* pSdrHint = static_cast();
-if ((pSdrHint->GetKind() != SdrHintKind::ModelCleared) &&
- (pSdrHint->GetKind() != SdrHintKind::ObjectChange || 
pSdrHint->GetObject() != pSdrObject ))
+if (pSdrHint->GetKind() != SdrHintKind::ModelCleared &&
+pSdrHint->GetKind() != SdrHintKind::ObjectChange)
+return;
+
+// #i55919# SdrHintKind::ObjectChange is only interesting if it's for this 
object
+SdrObject* pSdrObject(GetSdrObject());
+if ( !pSdrObject || pSdrHint->GetObject() != pSdrObject )
 return;
 
 uno::Reference< uno::XInterface > xSelf( pSdrObject->getWeakUnoShape() );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: writerfilter/source

2021-04-10 Thread Noel Grandin (via logerrit)
 writerfilter/source/dmapper/DomainMapper_Impl.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f48ddb48720767414fee4b1dbdced85a8be27d09
Author: Noel Grandin 
AuthorDate: Sat Apr 10 10:25:43 2021 +0200
Commit: Noel Grandin 
CommitDate: Sat Apr 10 15:33:29 2021 +0200

-werror=maybe-uninitialized

Change-Id: Iaa1905d181bc6dc86988c68a145d5d8fce11cda9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113904
Tested-by: Noel Grandin 
Reviewed-by: Noel Grandin 

diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx 
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index 200cb75667be..b446190c50b6 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -2592,7 +2592,7 @@ void DomainMapper_Impl::PushPageHeaderFooter(bool 
bHeader, SectionPropertyMap::P
 // If we have *hidden* header footer
 else if (bLeft && !GetSettingsTable()->GetEvenAndOddHeaders())
 {
-bool bIsShared;
+bool bIsShared = false;
 // Turn on the headers
 xPageStyle->setPropertyValue(getPropertyName(ePropIsOn), 
uno::makeAny(true));
 // Store the state of the previous state of shared prop
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 92678] FILESAVE: export from Draw to SVG does not save text on objects

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=92678

--- Comment #14 from mwtjunkm...@gmail.com ---
Similar to bug https://bugs.documentfoundation.org/show_bug.cgi?id=99769

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141195] Custom button text color not shown in the Basic dialogs with default background color

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141195

--- Comment #9 from Commit Notification 
 ---
bykivi committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/68b225bfbf51391b517dd483181e40e4a4c3fe31

tdf#141195:fix button text color with default background color

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141195] Custom button text color not shown in the Basic dialogs with default background color

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141195

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: vcl/source

2021-04-10 Thread bykivi (via logerrit)
 vcl/source/control/button.cxx |   21 +++--
 1 file changed, 15 insertions(+), 6 deletions(-)

New commits:
commit 68b225bfbf51391b517dd483181e40e4a4c3fe31
Author: bykivi 
AuthorDate: Tue Mar 23 13:41:30 2021 +0100
Commit: Andreas Heinisch 
CommitDate: Sat Apr 10 15:21:17 2021 +0200

tdf#141195:fix button text color with default background color

Change-Id: I2f30282e5e1f5e303be2802529f693be4968620d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112989
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch 

diff --git a/vcl/source/control/button.cxx b/vcl/source/control/button.cxx
index 2d68ab5f05c9..f2c413de8478 100644
--- a/vcl/source/control/button.cxx
+++ b/vcl/source/control/button.cxx
@@ -693,7 +693,20 @@ void 
PushButton::ImplDrawPushButtonFrame(vcl::RenderContext& rRenderContext,
 AllSettings aSettings = rRenderContext.GetSettings();
 AllSettings aOldSettings = aSettings;
 StyleSettings aStyleSettings = aSettings.GetStyleSettings();
-aStyleSettings.Set3DColors(GetControlBackground());
+if (nStyle & DrawButtonFlags::Highlight)
+{
+// with the custom background, native highlight do nothing, so 
code bellow mimic
+// native highlight by changing luminance
+Color controlBackgroundColorHighlighted = GetControlBackground();
+sal_uInt8 colorLuminance = 
controlBackgroundColorHighlighted.GetLuminance();
+if (colorLuminance < 205)
+controlBackgroundColorHighlighted.IncreaseLuminance(50);
+else
+controlBackgroundColorHighlighted.DecreaseLuminance(50);
+aStyleSettings.Set3DColors(controlBackgroundColorHighlighted);
+}
+else
+aStyleSettings.Set3DColors(GetControlBackground());
 aSettings.SetStyleSettings(aStyleSettings);
 
 // Call OutputDevice::SetSettings() explicitly, as rRenderContext may
@@ -769,11 +782,7 @@ void PushButton::ImplDrawPushButtonContent(OutputDevice 
*pDev, DrawFlags nDrawFl
 if (nDrawFlags & DrawFlags::Mono)
 aColor = COL_BLACK;
 
-// Custom foreground color is reasonable on stock controls only. Stock 
controls are used if a custom background has been set
-// (and thus no native controls are able to be used) or no native controls 
are available.
-
-else if (IsControlForeground()
- && (IsControlBackground() || 
!IsNativeControlSupported(ControlType::Pushbutton, ControlPart::Entire)))
+else if (IsControlForeground())
 aColor = GetControlForeground();
 
 // Button types with possibly different text coloring are flat buttons and 
regular buttons. Regular buttons may be action
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 92678] FILESAVE: export from Draw to SVG does not save text on objects

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=92678

mwtjunkm...@gmail.com changed:

   What|Removed |Added

 CC||mwtjunkm...@gmail.com

--- Comment #13 from mwtjunkm...@gmail.com ---
Still a bug in 

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 807d059d99e7b99fe45a712428befa17ffa44858
CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141608] New: Libre Office Calc crashed when trying to save a doc with .xlsx extension on it by changing the name to drop the .xlsx.

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141608

Bug ID: 141608
   Summary: Libre Office Calc crashed when trying to save a doc
with .xlsx extension on it by changing the name to
drop the .xlsx.
   Product: LibreOffice
   Version: 7.0.4.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: colburnde...@hotmail.com

Libre Office Calc crashed when trying to save a previously created Microsoft
Excel spreadsheet to a new name by backspacing over the .xlsx so it could save
under a LibreOffice extension.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141607] FILEOPEN XLSX Cell background colour missing (patternFill)

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141607

--- Comment #1 from Buovjaga  ---
Created attachment 171083
  --> https://bugs.documentfoundation.org/attachment.cgi?id=171083=edit
PDF exported from MSO 2013

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122108] FILEOPEN XLSX, Conditional formatting missing its pattern when opened in LO

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122108

Buovjaga  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||1607

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108897] [META] XLSX (OOXML) bug tracker

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108897

Buovjaga  changed:

   What|Removed |Added

 Depends on||141607


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=141607
[Bug 141607] FILEOPEN XLSX Cell background colour missing (patternFill)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141607] New: FILEOPEN XLSX Cell background colour missing (patternFill)

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141607

Bug ID: 141607
   Summary: FILEOPEN XLSX Cell background colour missing
(patternFill)
   Product: LibreOffice
   Version: 4.1.0.4 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: filter:xlsx
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ilmari.lauhakan...@libreoffice.org
Blocks: 107332, 108897

Created attachment 171082
  --> https://bugs.documentfoundation.org/attachment.cgi?id=171082=edit
Blue invoice template

Note: the confirming of this report is reserved for triagers in training, so if
you are a veteran, please skip :)

1. Open attached XLTX template
2. Compare with the attached PDF

Notice that the gray cell backgrounds in the Item Description / Amount section
are missing.

Examining the styles.xml we see









Explanation: dxfId (Formatting Id)  Zero-based index to a dxf record in the
dxfs collection, specifying differential formatting to use with this Table or
PivotTable style element.
https://docs.microsoft.com/en-us/dotnet/api/documentformat.openxml.spreadsheet.tablestyleelement?view=openxml-2.8.1

So our gray cell style should be secondRowStripe. It points to the dxf with the
zero-based index of 4. Thus, in styles.xml we find it inside the  element as









Note: other issues in the same template are already reported. Missing borders
is bug 141588 while missing gradient background depends on bug 49177.

Arch Linux 64-bit
Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 3b6408988487c886adc5415f7050f9da13d2e16b
CPU threads: 8; OS: Linux 5.11; UI render: default; VCL: kf5
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 8 April 2021


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107332
[Bug 107332] [META] Calc cell and page styles bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108897
[Bug 108897] [META] XLSX (OOXML) bug tracker
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 107332] [META] Calc cell and page styles bugs and enhancements

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107332

Buovjaga  changed:

   What|Removed |Added

 Depends on||141607


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=141607
[Bug 141607] FILEOPEN XLSX Cell background colour missing (patternFill)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135912] PNG export of text with graphical shadow applied does not output correctly

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135912

mwtjunkm...@gmail.com changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|UNCONFIRMED |RESOLVED

--- Comment #21 from mwtjunkm...@gmail.com ---
I will document the inappropriate anti-aliasing in another bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141606] New: GTK3: holding left click opens context menu in Impress slide show

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141606

Bug ID: 141606
   Summary: GTK3: holding left click opens context menu in Impress
slide show
   Product: LibreOffice
   Version: 7.0.0.3 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bugrepor...@bchemnet.com

Description:
In an Impress slide show when the GTK3 overlay is active, holding a left click
on a slide opens the right-click context menu after a few seconds.  This is
annoying when drawing on a slide, as if I leave the pen down too long, then
move, I often trigger a random menu option (most often advance to next slide).

A secondary effect is that if I release, without triggering a menu option, but
then click somewhere else, a line is draw between the two click points.

Neither of these behaviors occurs if GTK3 is not being used, with an otherwise
entirely identical install and profile.

Obviously this could be worked around by not holding the left click so long,
but as I am usually drawing while presenting to a live audience and using the
pointer also to point to objects, I trigger this bug fairly frequently.  I only
recently worked out that it is GTK3-specific.

Steps to Reproduce:
1. For simplicity of demonstration, disable advance slide on click.
2. Start slide show.
3. Left click and hold.  See contex menu appear.
4. Turn on pen.
5. Left click and hold.  Release without trigger menu.
6. Left click briefly somewhere else.  See line appear between points.

Actual Results:
Right-click menu is opened by left click, and random lines are drawn.

Expected Results:
No context menu on left click and no random lines.


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Appears to affect all versions since introduction of GTK3 but I have not tested
extensively.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141605] Images anchored to a cell and selected with AutoFilter are not PRINTING correctly

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141605

--- Comment #4 from Graham Tapper  ---
I have installed Ver 7.1.2.2 and retested.  The bug still exists.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


New Defects reported by Coverity Scan for LibreOffice

2021-04-10 Thread scan-admin
Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found 
with Coverity Scan.

1 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent 
build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1476017:  Null pointer dereferences  (FORWARD_NULL)
/sw/source/filter/ww8/ww8graf.cxx: 3184 in 
SwWW8ImplReader::ImportReplaceableDrawables(SdrObject *&, SdrObject *&, 
SvxMSDffImportRec *, WW8_FSPA *, SfxItemSet &)()



*** CID 1476017:  Null pointer dereferences  (FORWARD_NULL)
/sw/source/filter/ww8/ww8graf.cxx: 3184 in 
SwWW8ImplReader::ImportReplaceableDrawables(SdrObject *&, SdrObject *&, 
SvxMSDffImportRec *, WW8_FSPA *, SfxItemSet &)()
3178 
3179 // The Contact-Object MUST be set in the Draw-Page, so that in
3180 // SwWW8ImplReader::LoadDoc1() the Z-Order can be defined !!!
3181 if (!rpOurNewObject->IsInserted())
3182 {
3183 // pass information, if object is in page header|footer to 
method.
>>> CID 1476017:  Null pointer dereferences  (FORWARD_NULL)
>>> Dereferencing null pointer "pRecord".
3184 m_xWWZOrder->InsertEscherObject( rpOurNewObject, pF->nSpId,
3185  pRecord->bDrawHell,
3186m_bIsHeader || m_bIsFooter 
);
3187 }
3188 }
3189 return pRetFrameFormat;



To view the defects in Coverity Scan visit, 
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3Dy11g_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJif8N2SJEHhv0bMQhpeR8UhVB2jO-2FUi76ubiA1nF2wC8c1yThMWDwCjXvwt-2BMvQAIs0IoGF-2Fslum7F-2BjbIrG87EFrGZBPunO-2BftA3OyE2wlfivS6S679DTXqUvgfTJSDmQY65W4QRpsDykHMMyoZBgfU1rrEgJ0iwn-2Bb4IEYsKb48-3D

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 141605] Images anchored to a cell and selected with AutoFilter are not PRINTING correctly

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141605

--- Comment #3 from Graham Tapper  ---
Created attachment 171081
  --> https://bugs.documentfoundation.org/attachment.cgi?id=171081=edit
Screenshot of sheet with Print invoked

This time, the images are all wrong.  Every image is shown, layered, with the
image anchored to the highest numbered row on top

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 61512] Calc ROUND() don't use default IEEE 754 method (-> statistical error).

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=61512

--- Comment #7 from Munna  ---
Get over here to download the free solutions of the NCERT book class 10 ncert
solutions. This website provides us with complete solutions of NCERT class 10th
at free cost.
https://fullncertsolutions.in/ncert-solutions-for-class-10

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141605] Images anchored to a cell and selected with AutoFilter are not PRINTING correctly

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141605

--- Comment #2 from Graham Tapper  ---
Created attachment 171080
  --> https://bugs.documentfoundation.org/attachment.cgi?id=171080=edit
Screenshot of sheet with Print Preview invoked

Again, the correct image is shown

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141605] Images anchored to a cell and selected with AutoFilter are not PRINTING correctly

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141605

Graham Tapper  changed:

   What|Removed |Added

 CC||graham.tap...@gmail.com

--- Comment #1 from Graham Tapper  ---
Created attachment 171079
  --> https://bugs.documentfoundation.org/attachment.cgi?id=171079=edit
Screenshot of sheet with AutoFilter invoked

This is what I see when I run AutoFilter.  The correct image is selected

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141605] New: Images anchored to a cell and selected with AutoFilter are not PRINTING correctly

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141605

Bug ID: 141605
   Summary: Images anchored to a cell and selected with AutoFilter
are not PRINTING correctly
   Product: LibreOffice
   Version: 7.0.3.1 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: graham.tap...@gmail.com

Description:
I have created a spreadsheet with data and images.  

The images are each anchored to a specific cell on the same row as the
AutoFilter selection data for that row.  

When I auto-filter to specific data in a column, the rows that relate appear
correctly, including the image for that selection.  When I run Print Preview
the image presented as it would print, also appears correctly. 

When I then go to actually print the image selected, the images shown are all
wrong.  Instead of the individual image shown in Print Preview, what is shown
is a composite of all of the images anchored to all of the cells, one on top of
the other. The topmost image is that anchored to the highest numbered row.

If I then go on to actually print the page, that is also what is printed.

Steps to Reproduce:
1. Define sheet with images anchored to cells and with associated selectable
data in another cell on the same row.  Do this with multiple rows and different
selectable data
2. AutoFilter to a specific item of data. The relevant image appears on the
screen
3. Click Print Preview to confirm that image and only that image appears
4. Click Print and check the print image shown - contains *all* images instead
of just one

Actual Results:
Print prints a composite of layer upon layer of all images instead of just the
selected image

Expected Results:
Expect the print image to be as shown by Print Preview, i.e. just the selected
image shown


Reproducible: Always


User Profile Reset: No



Additional Info:
As described.  I haven't reset my Profile.  This is clearly not relevant to
this bug.  I can provide screenshots to confirm my findings.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141603] Calc crashes with "Invalid child index" error on different operations, but only on certain ODS documents

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141603

--- Comment #3 from Emil Prpic  ---
Created attachment 171078
  --> https://bugs.documentfoundation.org/attachment.cgi?id=171078=edit
Document that exhibits the problem

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141603] Calc crashes with "Invalid child index" error on different operations, but only on certain ODS documents

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141603

--- Comment #2 from Emil Prpic  ---
Created attachment 171077
  --> https://bugs.documentfoundation.org/attachment.cgi?id=171077=edit
LibreOffice about window screenshot

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141603] Calc crashes with "Invalid child index" error on different operations, but only on certain ODS documents

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141603

--- Comment #1 from Emil Prpic  ---
Created attachment 171076
  --> https://bugs.documentfoundation.org/attachment.cgi?id=171076=edit
Error alert screenshot

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141604] New: Crash in: mergedlo.dll

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141604

Bug ID: 141604
   Summary: Crash in: mergedlo.dll
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: midgley@gmail.com

This bug was filed from the crash reporting server and is
br-54932b18-0192-4898-bd53-cb2bac7738f6.
=

FYI

I had just discovered hatching and turned it on and then back to 'none' when LO
crashed.
Dunno if the crashdump gave you that info

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 35217] Allow a child outline level to express the numerical value of its parent level with a different numbering style than the parent

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=35217

ipowala  changed:

   What|Removed |Added

URL||http://ipowala.in

--- Comment #21 from ipowala  ---
http://ipowala.in;>ipo watch

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141603] New: Calc crashes with "Invalid child index" error on different operations, but only on certain ODS documents

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141603

Bug ID: 141603
   Summary: Calc crashes with "Invalid child index" error on
different operations, but only on certain ODS
documents
   Product: LibreOffice
   Version: 7.0.5.2 release
  Hardware: All
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sma...@zoho.com

Description:
While EDITING or FORMATTING certain ODS documents only (also when these same
documents are in XLS or XLSX format), Calc crashes at different times and while
doing different operations, always popping up an alert 

Libre Office 7.0 - Fatal Error 
Invalid child index

The problem is present for 4-5 years now, but it doesn't happen too often (I
don't use these specific documents too often).

I can't recognize any trigger pattern. Sometimes it crashes when I directly
double-click into a cell (to edit the content of that cell) if that window
didn't have focus before double-clicking it. But not always. Sometimes it
crashes when I change font size of a cell, but not always. Sometimes it crashes
when I hit cmd+s (it crashes before saving the document), but not always. 

I'm attaching one document that has this problem. I also can't say for sure
what is it in this document that causes the problem. I thought that maybe an
original document that I created was corrupt in some way, and I always used it
as a template for the other documents later. So recently I recreated a fresh
document from scratch, but the problem is still present. So, it must be about
some specific formatting or some specific content inside.

What I can think of as being different than other spreadsheets I use, is:

- the font used is Geneva

- there is a large number of rows of great height (a lot of text in one of the
columns) - usually there are about a hundred to several hundred rows all
toghether, and maybe about 20% of them of great height

- inside cell contents, a hard line break (cmd+enter) is extensively used

- inside cell contents with a lot of text (very high rows), there is a lot of
text formatting - like using bold text and different font sizes inside the same
cell

- page header has multiple lines

Steps to Reproduce:
1. Open document
2. Try editing and formating the contents (sometimes everything works fine for
hours)
3. Calc crashes out of the blue on some usual editing or formatting operation

Actual Results:
Calc crashed, everything since last save is lost

Expected Results:
Calc not crashing, editing works fine. :-)


Reproducible: Sometimes


User Profile Reset: Yes



Additional Info:
Copy from About window doesn't work. See screenshot attached for version
information.
I alse tested the same document attached here under Libre Office Safe mode. It
crashed after 3-4 minutes of editing, when I clicked on Print Preview tool
button.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: svx/source

2021-04-10 Thread Caolán McNamara (via logerrit)
 svx/source/dialog/frmsel.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 3cf47860832707baa67833af0ae40e23a925ddc2
Author: Caolán McNamara 
AuthorDate: Fri Apr 9 20:50:58 2021 +0100
Commit: Caolán McNamara 
CommitDate: Sat Apr 10 13:31:47 2021 +0200

Resolves: tdf#139075 diagonal focus rects contain focus rects of old size

since...

commit 356f6c5d89dd4dd92b2351898e07f99b96cb34cc
Date:   Tue Jan 15 08:55:00 2013 +

teach FrameSelector to be resizable

Change-Id: I5ac4d1d12f60086349e7dbb3b78d29977f22c226
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113894
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/svx/source/dialog/frmsel.cxx b/svx/source/dialog/frmsel.cxx
index 696a05d39964..c3abf1875481 100644
--- a/svx/source/dialog/frmsel.cxx
+++ b/svx/source/dialog/frmsel.cxx
@@ -413,6 +413,9 @@ void FrameSelectorImpl::InitBorderGeometry()
 maHor.AddFocusPolygon(tools::Rectangle( mnLine1 - mnFocusOffs, mnLine2 
- mnFocusOffs, mnLine3 + mnFocusOffs, mnLine2 + mnFocusOffs ) );
 maBottom.AddFocusPolygon( tools::Rectangle( mnLine1 - mnFocusOffs, mnLine3 
- mnFocusOffs, mnLine3 + mnFocusOffs, mnLine3 + mnFocusOffs ) );
 
+maTLBR.ClearFocusArea();
+maBLTR.ClearFocusArea();
+
 for( nCol = 0, nCols = maArray.GetColCount(); nCol < nCols; ++nCol )
 {
 for( nRow = 0, nRows = maArray.GetRowCount(); nRow < nRows; ++nRow )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 141193] Add barcode support into QR code dialog

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141193

Homeboy_445  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |akshitsa...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: framework/source

2021-04-10 Thread Andrea Gelmini (via logerrit)
 framework/source/uielement/toolbarsmenucontroller.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit c68973150cfb9eccb3d399db9736e3b5792b4e34
Author: Andrea Gelmini 
AuthorDate: Fri Apr 9 16:32:00 2021 +0200
Commit: Julien Nabet 
CommitDate: Sat Apr 10 12:53:05 2021 +0200

Fix typo in code

To complete commit:
7c6605bd2c1b Typos in code with variables containing "inital"->"initial"
https://gerrit.libreoffice.org/c/core/+/113823

Change-Id: I5874af4c18d460b81f99ecee7034df2d2829bad1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113876
Reviewed-by: Julien Nabet 
Tested-by: Jenkins

diff --git a/framework/source/uielement/toolbarsmenucontroller.cxx 
b/framework/source/uielement/toolbarsmenucontroller.cxx
index 4187bd4a8ee7..1498cb1ed3e6 100644
--- a/framework/source/uielement/toolbarsmenucontroller.cxx
+++ b/framework/source/uielement/toolbarsmenucontroller.cxx
@@ -753,8 +753,8 @@ void SAL_CALL ToolbarsMenuController::setPopupMenu( const 
Reference< css::awt::X
 void SAL_CALL ToolbarsMenuController::initialize( const Sequence< Any >& 
aArguments )
 {
 osl::MutexGuard aLock( m_aMutex );
-bool bInitalized( m_bInitialized );
-if ( bInitalized )
+bool bInitialized( m_bInitialized );
+if ( bInitialized )
 return;
 
 svt::PopupMenuControllerBase::initialize(aArguments);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 141602] New: Image filters have no effect on an image

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141602

Bug ID: 141602
   Summary: Image filters have no effect on an image
   Product: LibreOffice
   Version: 7.1.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: psaut...@gmail.com

Description:
Solarization image filter — increasing the threshold value above 70% does not
have any effect on the colours of a graphic.
Aging image filter — increasing the ageing degree using the Aging dialog has no
effect on an image.

Steps to Reproduce:
1. Select an image (photograph).
2. Open Image Filter toolbar.
3. Select Solarization or Aging filter.
4. No effect detected on the image.

Actual Results:
No effect on selected image

Expected Results:
Selected image should show signs of solarization or aging.


Reproducible: Always


User Profile Reset: No



Additional Info:
This has been tested in Widows, macOS and Ubuntu operating operating systems
and on four computers.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141262] libreoffice can't generate word 2003 xml file rightliy , especial it has table in

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141262

Dieter  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|
 CC||dgp-m...@gmx.de
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #1 from Dieter  ---
Thank you for reporting the bug. As you can see for example in meta bug 112700
a ot of bugs have been reported about tables in doc-format. Have you chcheked
for duplicates? If you can't find a duplicate please give an exactly
description of your problem. The best would be to add a sample document, that
shows the problem
=> NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141265] Random characters appear as black boxes at certain zoom levels in windows 10.

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141265

Dieter  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Whiteboard| QA:needsComment|
 CC||dgp-m...@gmx.de
 Status|UNCONFIRMED |NEEDINFO

--- Comment #2 from Dieter  ---
Thank you for reporting the bug. It seems you're using an old version of
LibreOffice. Could you please try to reproduce it with the latest version of
LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ ? I
have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED'
if the bug is still present in the latest version. Change to RESOLVED
WORKSFORME, if the problem went away.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141590] Crash if i insert values in the function PRONOSTICO.ETS.PI.SUM

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141590

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr
 Status|NEW |NEEDINFO

--- Comment #2 from Julien Nabet  ---
On which Linux distrib + which version are you?
Could you give an update to a recent LO version?
Indeed, 6.1.5 is quite old, last stable ones are 7.0.5 or brand new LO 7.1.2.

If you still reproduce the crash, could you provide the values entered to
reproduce the crash?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141599] Libre Office 7.0.5 doesn't open

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141599

Julien Nabet  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||serval2...@yahoo.fr
 Status|UNCONFIRMED |NEEDINFO

--- Comment #1 from Julien Nabet  ---
Could you give a try at https://wiki.documentfoundation.org/QA/FirstSteps?
Also on which Windows version are you? Did you check updates of Windows and
graphic card?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141593] Allow showing paragraph and character styles at once in style pane

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141593

--- Comment #1 from Eyal Rozenberg  ---
Note that, in MS Word, different categories of styles (paragraph, character
etc.) are distinguished by a category icon next to the style name. This could
work for us as well in a joint view.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141593] Allow showing paragraph and character styles at once in style pane

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141593

Eyal Rozenberg  changed:

   What|Removed |Added

Summary|Show paragraph and  |Allow showing paragraph and
   |character styles at once in |character styles at once in
   |style pane  |style pane

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89974] Context menu entry (in Styles and Formatting) to select all elements with the same style

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89974

--- Comment #11 from Eyal Rozenberg  ---
(In reply to Patrick Smits from comment #9)
> P.S. note how Microsoft combines paragraph and character styles in one pane
> view, distinguishing between the two with the small paragraph and character
> symbols.

I've recently asked for this to be possible with bug 141593.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89974] Context menu entry (in Styles and Formatting) to select all elements with the same style

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89974

Eyal Rozenberg  changed:

   What|Removed |Added

 CC||eyalr...@gmx.com

--- Comment #10 from Eyal Rozenberg  ---
I was about to file a duplicate of this bug, but luckily I noticed it.

I would also very much appreciate this feature. In addition to the use cases
Patrick mentioned, this is also useful for clearing manual formatting from
multiple instances; or clearing character styles which were set on some of the
paragraphs; or just for seeing them selected.

I'm mention it would be nice for this to be implemented for all kinds of
styles: Paragraphs, character, frame, page etc; but even an implementation for
part of the styles would be useful.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141211] Bold (or Italic) icon (in Formatting toolbar) should not be active when "Strong Emphasis" (or Emphasis) character style is applied

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141211

--- Comment #11 from Mike Kaganski  ---
(In reply to sdc.blanco from comment #9)
> For example, if custom CS “theoretical concept” has italic font, then
> Formatting bar shows the italic icon toggled, but I cannot see in Formatting
> (Styles) bar that I have applied a CS.

... which is likely a flaw of a tool on Styles toolbar, rather than of DF tool,
right?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 141211] Bold (or Italic) icon (in Formatting toolbar) should not be active when "Strong Emphasis" (or Emphasis) character style is applied

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141211

--- Comment #11 from Mike Kaganski  ---
(In reply to sdc.blanco from comment #9)
> For example, if custom CS “theoretical concept” has italic font, then
> Formatting bar shows the italic icon toggled, but I cannot see in Formatting
> (Styles) bar that I have applied a CS.

... which is likely a flaw of a tool on Styles toolbar, rather than of DF tool,
right?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 141211] Bold (or Italic) icon (in Formatting toolbar) should not be active when "Strong Emphasis" (or Emphasis) character style is applied

2021-04-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141211

--- Comment #10 from Mike Kaganski  ---
(In reply to sdc.blanco from comment #9)
> (Not proposing any change here, just trying to understand the design
> intention).

Nice :-)

> > > Presumably even if it makes life more complicated for non-DF users?
> > 
> > Please explain how.
> Formatting bar shows the state of formatting, regardless of whether DF or
> applied by a style, so it is not always possible to use the toolbars to
> decide immediately whether a style or a DF is being applied.
> 
> For example, if custom CS “theoretical concept” has italic font, then
> Formatting bar shows the italic icon toggled, but I cannot see in Formatting
> (Styles) bar that I have applied a CS.

You are holding this wrong :-)

Your train of thought is like "it makes the use of DF toolbar more difficult
for style users when they decide to use that toolbar for what it is not
intended to do". So you basically start building expectations of a style user
regarding tools not directly intended for them.

This is wrong. Based on that reasoning, whenever you invent any tool for DF
users, you inevitably come to a situation when a style user *could* in theory
make use of such thing, *if* it were made differently - and so breaking the
intended ease of use for DF users. Just don't do that!

Now about the design intention.

All DF tools are created *primarily* for users who do not use styles. For those
users, the document does not consist of styled parts, it consists of characters
having some formatting. And they might not care, or might not even know, where
the formatting of a specific character comes from. Their tools must react
predictably *at their level of thinking about document*, and that means that
whenever a character is bold, the tool to control bold effect must suggest to
unbold it - which implies that it is shown "activated" (=applied).

Additionally, all DF tools work like paint: imagine a medieval painter who
might decide to update (fix something on) an older painting. Instead of trying
to remove everything from the old canvas at the changed site, they just paint
over, masking whatever is beneath the new layer of the paint. That is an easy
way for inexperienced users, and the tools designed for those users must be
convenient for that mode of thinking.

If you think that some tool on DF toolbar might be useful for style users if
modified, and that modification is harmful for DF users, you are welcome to
suggest a *new* tool e.g. on styles toolbar; it's wrong to think that not
modifying the old tool "makes life more complicated for non-DF users", when
their life is not more difficult now than it was before.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


<    1   2   3   >