[Libreoffice-bugs] [Bug 137679] Implement a Kahan summation algorithm for reduce the numerical error in the total
https://bugs.documentfoundation.org/show_bug.cgi?id=137679 --- Comment #15 from Mike Kaganski --- (In reply to b. from comment #14) I agree that order of RAWSUBTRACT is inconsistent with normal subtraction. As you wrote in bug 141752 comment 0, =1E+016 - 1 - 1E+016 gives 0, while =RAWSUBTRACT(1E+016;1;1E+016) gives -1; =1E+016 - 1E+016 - 1 gives -1, while =RAWSUBTRACT(1E+016;1E+016;1) gives 0. This is due to natural processing order of the arguments of a function in Calc, (that is *unspecified* by ODF!) and reversing it is possible here (forming a vector of arguments before performing negations), but is completely useless in view of Kahan summation algorithm (which is not complex by the way, just needs an easy hacker to handle it). Your bug was actually useful that it highlighted that RAWSUBTRACT is also a subject to the Kahan (or more precisely, improved Kahan–Babuška) algorithm implementation, so also is covered by this bug. Spending even one minute on an alternative "fix" of bug 141752 is just a waste of developers' time , and I disagree with "unduping" (but anyone is still free to suggest a patch with "alternative" fix that would make a single person in the universe happy). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141766] Document sheet protection options added in 5.4
https://bugs.documentfoundation.org/show_bug.cgi?id=141766 Buovjaga changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141766] New: Document sheet protection options added in 5.4
https://bugs.documentfoundation.org/show_bug.cgi?id=141766 Bug ID: 141766 Summary: Document sheet protection options added in 5.4 Product: LibreOffice Version: 5.4.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Documentation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ilmari.lauhakan...@libreoffice.org CC: olivier.hal...@libreoffice.org https://wiki.documentfoundation.org/ReleaseNotes/5.4#Calc A new Cell Protection toggle command was added to Edit ▸ Cell Protection to change the protection status of the cell. tdf#95885 (Gülşah Köse) Four new sheet protection options have been added to optionally allow insertions and deletions of rows and columns. The Insert rows and Insert columns options allow row and column insertions even when the sheet is protected, whereas the Delete rows and Delete columns options allow row and column deletions. Note that when row and column insertions are enabled, you can insert rows or columns even when the range to insert the new rows or columns into contains protected cells which will get shifted after the insertion. Row and column deletions, on the other hand, are only allowed on unprotected cells. tdf#43535 (Kohei Yoshida, Collabora) These need to be documented in this page: https://help.libreoffice.org/latest/en-US/text/scalc/guide/cell_protect.html?DbPAR=CALC#bm_id3146119 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139023] LO 7.0.4 cannot be terminated on win2012 in terminal server mode sometimes
https://bugs.documentfoundation.org/show_bug.cgi?id=139023 --- Comment #2 from kabilo --- Hi Makrea, I think this problem was after exporting data to LO from 3rd party applications. I can't verify this, version 6.4 has been returned to the production environment. Regards -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139722] cannot insert image in sheet with large row height
https://bugs.documentfoundation.org/show_bug.cgi?id=139722 Buovjaga changed: What|Removed |Added CC||ilmari.lauhakangas@libreoff ||ice.org --- Comment #4 from Buovjaga --- Like raal, I see the problem in older versions. 6.3 repo oldest, 7.0 repo oldest & master. Is the working state seen only on Windows? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/svx sc/source sd/source svx/sdi svx/source sw/source
include/svx/svddrag.hxx| 12
include/svx/svdoedge.hxx |2 +-
include/svx/svdview.hxx|3 ++-
sc/source/ui/drawfunc/drawsh.cxx |5 +++--
sd/source/ui/view/drviews2.cxx |6 --
svx/sdi/svx.sdi|2 +-
svx/source/svdraw/svdoedge.cxx | 22 --
svx/source/svdraw/svdview.cxx | 17 -
sw/source/uibase/shells/drawsh.cxx |5 +++--
sw/source/uibase/uiview/view2.cxx |5 +++--
10 files changed, 61 insertions(+), 18 deletions(-)
New commits:
commit b18bff18785cc194f9918f6bdf69523827ef
Author: merttumer
AuthorDate: Fri Apr 2 16:18:05 2021 +0300
Commit: Mert Tumer
CommitDate: Tue Apr 20 06:52:26 2021 +0200
lok: Pass object ord num in the uno command
When multiple objects' glue points collide the ordnum
will be used to decide which glue point to connect to
for the connectors. Without that the default logic chooses
the lowest ordered object which is searched and found in the object list
Change-Id: I64579d28bbe6cbd92bab745838fe2995585b6a3f
Signed-off-by: merttumer
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113517
Tested-by: Jenkins CollaboraOffice
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114032
Tested-by: Jenkins
diff --git a/include/svx/svddrag.hxx b/include/svx/svddrag.hxx
index 80c2406b9046..6718e5f36b5d 100644
--- a/include/svx/svddrag.hxx
+++ b/include/svx/svddrag.hxx
@@ -79,6 +79,16 @@ class SVXCORE_DLLPUBLIC SdrDragStat final
sal_Int32 GetPrevPos() const { return mvPnts.size()-(mvPnts.size()>1 ? 2 :
1); }
+// This is passed all the way through to ApplySpecialDrag of the Edge
Object
+// For LOK, we cannot really specify which glue point to select by default
+// It selects the nearest glue points after DragEnd event.
+// When multiple objects are on top of each other or somehow their glue
points
+// collide, the glue point is selected from the lowest order numbered
object
+// We can pass the ord number information inside the draginfo and choose
the correct shape
+struct {
+sal_Int32 objectOrdNum = -1;
+} mGlueOptions;
+
public:
SdrDragStat(){ Reset(); }
~SdrDragStat();
@@ -158,6 +168,8 @@ public:
// Also considering 1stPointAsCenter
void TakeCreateRect(tools::Rectangle& rRect) const;
+
+auto&GetGlueOptions() { return mGlueOptions; }
};
#endif // INCLUDED_SVX_SVDDRAG_HXX
diff --git a/include/svx/svdoedge.hxx b/include/svx/svdoedge.hxx
index fe09104dbc4e..17108ad856ec 100644
--- a/include/svx/svdoedge.hxx
+++ b/include/svx/svdoedge.hxx
@@ -177,7 +177,7 @@ protected:
XPolygon ImpCalcEdgeTrack(const Point& rPt1, tools::Long nAngle1, const
tools::Rectangle& rBoundRect1, const tools::Rectangle& rBewareRect1,
const Point& rPt2, tools::Long nAngle2, const tools::Rectangle&
rBoundRect2, const tools::Rectangle& rBewareRect2,
sal_uIntPtr* pnQuality, SdrEdgeInfoRec* pInfo) const;
-static bool ImpFindConnector(const Point& rPt, const SdrPageView& rPV,
SdrObjConnection& rCon, const SdrEdgeObj* pThis, OutputDevice* pOut=nullptr);
+static bool ImpFindConnector(const Point& rPt, const SdrPageView& rPV,
SdrObjConnection& rCon, const SdrEdgeObj* pThis, OutputDevice* pOut=nullptr,
SdrDragStat* pDragStat = nullptr);
static SdrEscapeDirection ImpCalcEscAngle(SdrObject const * pObj, const
Point& aPt2);
void ImpSetTailPoint(bool bTail1, const Point& rPt);
void ImpUndirtyEdgeTrack(); // potential recalculation of the connection
track
diff --git a/include/svx/svdview.hxx b/include/svx/svdview.hxx
index 149b17f9ece9..7020f6447b4d 100644
--- a/include/svx/svdview.hxx
+++ b/include/svx/svdview.hxx
@@ -242,7 +242,8 @@ public:
SdrPageWindow& rPageWindow,
const char* pDebugName) const;
-bool MoveShapeHandle(const sal_uInt32 handleNum, const Point& aEndPoint);
+// Interactive Move Action programmaticaly
+bool MoveShapeHandle(const sal_uInt32 handleNum, const Point& aEndPoint,
const sal_Int32 aObjectOrdNum = -1);
};
// First of all the app creates a SdrModel.
diff --git a/sc/source/ui/drawfunc/drawsh.cxx b/sc/source/ui/drawfunc/drawsh.cxx
index 90bf9f8e51cd..4a46f3d69c90 100644
--- a/sc/source/ui/drawfunc/drawsh.cxx
+++ b/sc/source/ui/drawfunc/drawsh.cxx
@@ -205,16 +205,17 @@ void ScDrawShell::ExecDrawAttr( SfxRequest& rReq )
case SID_MOVE_SHAPE_HANDLE:
{
const SfxItemSet *pArgs = rReq.GetArgs ();
-if (pArgs && pArgs->Count () == 3)
+if (pArgs && pArgs->Count () >= 3)
{
const SfxUInt32Item* handleNumItem =
rReq.GetArg(FN_PARAM_1);
const SfxUInt32Item* newPosXTwips =
rReq.GetArg(FN_PARAM_2);
const SfxUInt32Item* newPosYTwips =
rReq.GetArg(FN_PARAM_3);
+
[Libreoffice-commits] core.git: svx/source
svx/source/svdraw/svdmrkv.cxx | 62 +-
1 file changed, 38 insertions(+), 24 deletions(-)
New commits:
commit 7f26b1b47819754ed5461517300346961a5bbbe4
Author: merttumer
AuthorDate: Fri Apr 2 16:14:55 2021 +0300
Commit: Mert Tumer
CommitDate: Tue Apr 20 06:52:15 2021 +0200
Improve dumpGluePointsAsJSON
added gridoffset for the shape for calc
changed the logic, now the ordnum would be enough
Change-Id: Iebe7d29c569a4cb968fe2e5ef1692b59f0c4b2d8
Signed-off-by: merttumer
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113516
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114031
Tested-by: Jenkins
diff --git a/svx/source/svdraw/svdmrkv.cxx b/svx/source/svdraw/svdmrkv.cxx
index c0ccd27d070f..b5adf79a6b3b 100644
--- a/svx/source/svdraw/svdmrkv.cxx
+++ b/svx/source/svdraw/svdmrkv.cxx
@@ -694,37 +694,51 @@ bool
SdrMarkView::dumpGluePointsToJSON(boost::property_tree::ptree& rTree)
if (rOutDev->GetMapMode().GetMapUnit() == MapUnit::Map100thMM)
bConvertUnit = true;
const SdrObjList* pOL = mpMarkedPV->GetObjList();
+if (!pOL)
+return false;
const size_t nObjCount = pOL->GetObjCount();
boost::property_tree::ptree elements;
for (size_t nObjNum = 0; nObjNum < nObjCount; ++nObjNum)
{
-const SdrObject* pObj = pOL->GetObj(nObjNum);
+SdrObject* pObj = pOL->GetObj(nObjNum);
+if (!pObj)
+continue;
+if (pObj == GetMarkedObjectByIndex(0))
+continue;
const SdrGluePointList* pGPL = pObj->GetGluePointList();
-if (pGPL != nullptr && pGPL->GetCount())
+bool VertexObject = !(pGPL && pGPL->GetCount());
+const size_t count = !VertexObject ? pGPL->GetCount() : 4;
+boost::property_tree::ptree object;
+boost::property_tree::ptree points;
+for (size_t i = 0; i < count; ++i)
{
-boost::property_tree::ptree object;
-boost::property_tree::ptree points;
-for (size_t i = 0; i < pGPL->GetCount(); ++i)
-{
-boost::property_tree::ptree node;
-boost::property_tree::ptree point;
-const SdrGluePoint& rGP = (*pGPL)[i];
-// coordinates are relative to the OBJ snap rect
-Point rPoint = pObj->GetSnapRect().TopLeft();
-rPoint.Move(rGP.GetPos().getX(), rGP.GetPos().getY());
-if (bConvertUnit)
-rPoint = OutputDevice::LogicToLogic(rPoint,
MapMode(MapUnit::Map100thMM), MapMode(MapUnit::MapTwip));
-point.put("x", rPoint.getX());
-point.put("y", rPoint.getY());
-node.put("glueId", rGP.GetId());
-node.add_child("point", point);
-points.push_back(std::make_pair("", node));
-}
-object.put("id", reinterpret_cast(pObj));
-object.add_child("gluepoints", points);
-elements.push_back(std::make_pair("", object));
-result = true;
+boost::property_tree::ptree node;
+boost::property_tree::ptree point;
+const SdrGluePoint& rGP = !VertexObject ? (*pGPL)[i] :
pObj->GetVertexGluePoint(i);
+Point rPoint = rGP.GetAbsolutePos(*pObj);
+if (bConvertUnit)
+rPoint = OutputDevice::LogicToLogic(rPoint,
MapMode(MapUnit::Map100thMM), MapMode(MapUnit::MapTwip));
+point.put("x", rPoint.getX());
+point.put("y", rPoint.getY());
+node.add_child("point", point);
+points.push_back(std::make_pair("", node));
+}
+basegfx::B2DVector aGridOffset(0.0, 0.0);
+Point objLogicRectTopLeft = pObj->GetLogicRect().TopLeft();
+if(getPossibleGridOffsetForPosition(aGridOffset,
basegfx::B2DPoint(objLogicRectTopLeft.X(), objLogicRectTopLeft.Y()),
GetSdrPageView()))
+{
+Point p(aGridOffset.getX(), aGridOffset.getY());
+if (bConvertUnit)
+p = OutputDevice::LogicToLogic(p,
MapMode(MapUnit::Map100thMM), MapMode(MapUnit::MapTwip));
+boost::property_tree::ptree gridOffset;
+gridOffset.put("x", p.getX());
+gridOffset.put("y", p.getY());
+object.add_child("gridoffset", gridOffset);
}
+object.put("ordnum", pObj->GetOrdNum());
+object.add_child("gluepoints", points);
+elements.push_back(std::make_pair("", object));
+result = true;
}
rTree.add_child("shapes", elements);
}
___
Libreoffice-commits
[Libreoffice-bugs] [Bug 138192] Provide arm64 or x86-64/arm64 Universal Binary builds for macOS on Apple Silicon
https://bugs.documentfoundation.org/show_bug.cgi?id=138192 --- Comment #9 from jeanmarcran...@gmail.com --- Just noticed that libreoffice.org's System Requirements page [0] now states: "Intel or Apple silicon processor (via Rosetta - native Apple silicon support is being developed)" [0] https://www.libreoffice.org/get-help/system-requirements/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141501] Difference in PIVOTTABLE layout using Calc under Windows or Linux
https://bugs.documentfoundation.org/show_bug.cgi?id=141501 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138520] Toolbars and page too small with Wayland fractional scaling and Qt5 plugin
https://bugs.documentfoundation.org/show_bug.cgi?id=138520 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141382] Properties dialog not in sync with actual properties.
https://bugs.documentfoundation.org/show_bug.cgi?id=141382 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141491] No transparency when exporting selection in png with Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=141491 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141489] Inserting an image in a page with other images, sometimes other images disappear.
https://bugs.documentfoundation.org/show_bug.cgi?id=141489 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141382] Properties dialog not in sync with actual properties.
https://bugs.documentfoundation.org/show_bug.cgi?id=141382 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127528] Installing new version 6.3.1.2 stripped all headers from all spreadsheets.
https://bugs.documentfoundation.org/show_bug.cgi?id=127528 --- Comment #11 from QA Administrators --- Dear n4ark, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127528] Installing new version 6.3.1.2 stripped all headers from all spreadsheets.
https://bugs.documentfoundation.org/show_bug.cgi?id=127528 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137609] When I click any inputed cell, Calc erase the inputed characters. The occurrence of this phenomenon is random.
https://bugs.documentfoundation.org/show_bug.cgi?id=137609 --- Comment #2 from QA Administrators --- Dear MARINA-SODA, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137416] Crash in: libc-2.25.so
https://bugs.documentfoundation.org/show_bug.cgi?id=137416 --- Comment #2 from QA Administrators --- Dear evgeny.semus, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99877] [CHART] XLTX wrongly imported chart
https://bugs.documentfoundation.org/show_bug.cgi?id=99877 --- Comment #10 from QA Administrators --- Dear Dennis Roczek, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67929] Graphics lists not saved
https://bugs.documentfoundation.org/show_bug.cgi?id=67929 --- Comment #8 from QA Administrators --- Dear Olivier Hallot, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53358] FILEOPEN Certain non-keyword formula literals in curly braces (e.g., "{*}") in imported DOCX document result in errors in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=53358 --- Comment #12 from QA Administrators --- Dear Stephan van den Akker, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52543] framework: broken links under /opt/lodev-3.6/share points to no longer existing OOo websites
https://bugs.documentfoundation.org/show_bug.cgi?id=52543 --- Comment #8 from QA Administrators --- Dear Sabri Unal, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45065] Clipping issue (was: Problem with EDITING of technical pdfs)
https://bugs.documentfoundation.org/show_bug.cgi?id=45065 --- Comment #25 from QA Administrators --- Dear brian.bj.parker99, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123668] Cursor focus moves outside Quick find bar when reaching results in Notes view
https://bugs.documentfoundation.org/show_bug.cgi?id=123668 --- Comment #4 from QA Administrators --- Dear David F Smith, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123665] Inconsistent behavior of "find next" in slides and notes
https://bugs.documentfoundation.org/show_bug.cgi?id=123665 --- Comment #8 from QA Administrators --- Dear David F Smith, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105844] FILESAVE: Very slow saving with password compared to 5.2.5
https://bugs.documentfoundation.org/show_bug.cgi?id=105844 --- Comment #22 from QA Administrators --- Dear jhertel, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101958] "Find" toolbar field won't accept pasted text from the clipboard other than unformatted text after keyboard switch
https://bugs.documentfoundation.org/show_bug.cgi?id=101958 --- Comment #11 from QA Administrators --- Dear CTAC, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101368] Print selected area does not wrap text
https://bugs.documentfoundation.org/show_bug.cgi?id=101368 --- Comment #10 from QA Administrators --- Dear Houman, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/svx svx/source
include/svx/svdmrkv.hxx |1
svx/source/svdraw/svdmrkv.cxx | 59 ++
2 files changed, 60 insertions(+)
New commits:
commit 415622a523a783fc3494bc09a52ee870a6458e2c
Author: merttumer
AuthorDate: Thu Mar 11 12:16:51 2021 +0300
Commit: Mert Tumer
CommitDate: Tue Apr 20 04:33:35 2021 +0200
Get Glue Points in the selection callback
Change-Id: I0d038517710c68f80f8e35b8ebebd34f264434f3
Signed-off-by: merttumer
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112324
Tested-by: Jenkins CollaboraOffice
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114030
Tested-by: Jenkins
diff --git a/include/svx/svdmrkv.hxx b/include/svx/svdmrkv.hxx
index 17e9ad2b15f9..bbe0e8eb2446 100644
--- a/include/svx/svdmrkv.hxx
+++ b/include/svx/svdmrkv.hxx
@@ -148,6 +148,7 @@ private:
void UndirtyMrkPnt() const;
void SetMarkHandlesForLOKit(tools::Rectangle const & rRect, const
SfxViewShell* pOtherShell);
+bool dumpGluePointsToJSON(boost::property_tree::ptree& rTree);
protected:
virtual void Notify(SfxBroadcaster& rBC, const SfxHint& rHint) override;
diff --git a/svx/source/svdraw/svdmrkv.cxx b/svx/source/svdraw/svdmrkv.cxx
index f42214daf8ad..c0ccd27d070f 100644
--- a/svx/source/svdraw/svdmrkv.cxx
+++ b/svx/source/svdraw/svdmrkv.cxx
@@ -685,6 +685,52 @@ OUString lcl_getDragParameterString( const OUString& rCID )
}
} // anonymous namespace
+bool SdrMarkView::dumpGluePointsToJSON(boost::property_tree::ptree& rTree)
+{
+bool result = false;
+if (OutputDevice* rOutDev = mpMarkedPV->GetView().GetFirstOutputDevice())
+{
+bool bConvertUnit = false;
+if (rOutDev->GetMapMode().GetMapUnit() == MapUnit::Map100thMM)
+bConvertUnit = true;
+const SdrObjList* pOL = mpMarkedPV->GetObjList();
+const size_t nObjCount = pOL->GetObjCount();
+boost::property_tree::ptree elements;
+for (size_t nObjNum = 0; nObjNum < nObjCount; ++nObjNum)
+{
+const SdrObject* pObj = pOL->GetObj(nObjNum);
+const SdrGluePointList* pGPL = pObj->GetGluePointList();
+if (pGPL != nullptr && pGPL->GetCount())
+{
+boost::property_tree::ptree object;
+boost::property_tree::ptree points;
+for (size_t i = 0; i < pGPL->GetCount(); ++i)
+{
+boost::property_tree::ptree node;
+boost::property_tree::ptree point;
+const SdrGluePoint& rGP = (*pGPL)[i];
+// coordinates are relative to the OBJ snap rect
+Point rPoint = pObj->GetSnapRect().TopLeft();
+rPoint.Move(rGP.GetPos().getX(), rGP.GetPos().getY());
+if (bConvertUnit)
+rPoint = OutputDevice::LogicToLogic(rPoint,
MapMode(MapUnit::Map100thMM), MapMode(MapUnit::MapTwip));
+point.put("x", rPoint.getX());
+point.put("y", rPoint.getY());
+node.put("glueId", rGP.GetId());
+node.add_child("point", point);
+points.push_back(std::make_pair("", node));
+}
+object.put("id", reinterpret_cast(pObj));
+object.add_child("gluepoints", points);
+elements.push_back(std::make_pair("", object));
+result = true;
+}
+}
+rTree.add_child("shapes", elements);
+}
+return result;
+}
+
void SdrMarkView::SetMarkHandlesForLOKit(tools::Rectangle const & rRect, const
SfxViewShell* pOtherShell)
{
SfxViewShell* pViewShell = GetSfxViewShell();
@@ -737,13 +783,19 @@ void SdrMarkView::SetMarkHandlesForLOKit(tools::Rectangle
const & rRect, const S
OString sSelectionText;
OString sSelectionTextView;
boost::property_tree::ptree aTableJsonTree;
+boost::property_tree::ptree aGluePointsTree;
bool bTableSelection = false;
+bool bConnectorSelection = false;
if (mpMarkedObj && mpMarkedObj->GetObjIdentifier() == OBJ_TABLE)
{
auto& rTableObject =
dynamic_cast(*mpMarkedObj);
bTableSelection =
rTableObject.createTableEdgesJson(aTableJsonTree);
}
+if (mpMarkedObj && mpMarkedObj->GetObjIdentifier() == OBJ_EDGE)
+{
+bConnectorSelection = dumpGluePointsToJSON(aGluePointsTree);
+}
if (GetMarkedObjectCount())
{
SdrMark* pM = GetSdrMarkByIndex(0);
@@ -971,6 +1023,13 @@ void SdrMarkView::SetMarkHandlesForLOKit(tools::Rectangle
const & rRect, const S
boost::property_tree::write_json(aStream, responseJSON,
/*pretty=*/ false);
handleArrayStr = ", \"handles\":";
handleArrayStr = handleArrayStr + aStream.str().c_str();
+if (bConnectorSelection)
+
[Libreoffice-commits] core.git: svx/source
svx/source/svdraw/svdglue.cxx |5 +
svx/source/svdraw/svdpntv.cxx |5 +
2 files changed, 10 insertions(+)
New commits:
commit 611130065625650adad4e2e2204ca5b42b9f65c0
Author: merttumer
AuthorDate: Thu Mar 11 10:33:04 2021 +0300
Commit: Mert Tumer
CommitDate: Tue Apr 20 04:33:16 2021 +0200
lok: Don't invalidate GluePoints
Change-Id: Ie579b31e6ee2067f5b88464c62c0870b68a461a2
Signed-off-by: merttumer
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112315
Tested-by: Jenkins CollaboraOffice
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114029
Tested-by: Jenkins
diff --git a/svx/source/svdraw/svdglue.cxx b/svx/source/svdraw/svdglue.cxx
index 4cce1a58ad26..05a89173e5df 100644
--- a/svx/source/svdraw/svdglue.cxx
+++ b/svx/source/svdraw/svdglue.cxx
@@ -23,6 +23,7 @@
#include
#include
#include
+#include
const Size aGlueHalfSize(4,4);
@@ -253,6 +254,8 @@ void SdrGluePoint::Shear(const Point& rRef, double tn, bool
bVShear, const SdrOb
void SdrGluePoint::Invalidate(vcl::Window& rWin, const SdrObject* pObj) const
{
+if (comphelper::LibreOfficeKit::isActive())
+return;
bool bMapMode=rWin.IsMapModeEnabled();
Point aPt(pObj!=nullptr ? GetAbsolutePos(*pObj) : GetPos());
aPt=rWin.LogicToPixel(aPt);
@@ -324,6 +327,8 @@ sal_uInt16 SdrGluePointList::Insert(const SdrGluePoint& rGP)
void SdrGluePointList::Invalidate(vcl::Window& rWin, const SdrObject* pObj)
const
{
+if (comphelper::LibreOfficeKit::isActive())
+return;
for (auto& xGP : aList)
xGP->Invalidate(rWin,pObj);
}
diff --git a/svx/source/svdraw/svdpntv.cxx b/svx/source/svdraw/svdpntv.cxx
index 59d1a55a..9074036a3edc 100644
--- a/svx/source/svdraw/svdpntv.cxx
+++ b/svx/source/svdraw/svdpntv.cxx
@@ -780,6 +780,11 @@ bool SdrPaintView::KeyInput(const KeyEvent& /*rKEvt*/,
vcl::Window* /*pWin*/)
void SdrPaintView::GlueInvalidate() const
{
+// Do not invalidate GluePoints in Online
+// They are handled on front-end
+if (comphelper::LibreOfficeKit::isActive())
+return;
+
const sal_uInt32 nWindowCount(PaintWindowCount());
for(sal_uInt32 nWinNum(0); nWinNum < nWindowCount; nWinNum++)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - svx/source
svx/source/sdr/contact/objectcontactofpageview.cxx |3 +-
svx/source/svdraw/svdmrkv.cxx | 25 -
2 files changed, 26 insertions(+), 2 deletions(-)
New commits:
commit 836afbb007e7f34e3587de34fdf1fbb2371fd60b
Author: merttumer
AuthorDate: Thu Mar 11 09:52:00 2021 +0300
Commit: Mert Tumer
CommitDate: Tue Apr 20 04:32:58 2021 +0200
Hide GluePoints in LOK
Change-Id: Ibf6bba4cdc69bd8479ccc08b5d9695253ef81890
Signed-off-by: merttumer
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112314
Tested-by: Jenkins CollaboraOffice
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114028
Tested-by: Jenkins
diff --git a/svx/source/sdr/contact/objectcontactofpageview.cxx
b/svx/source/sdr/contact/objectcontactofpageview.cxx
index 364b0d90bfea..41717d276381 100644
--- a/svx/source/sdr/contact/objectcontactofpageview.cxx
+++ b/svx/source/sdr/contact/objectcontactofpageview.cxx
@@ -340,7 +340,8 @@ namespace sdr::contact
// Get info about the need to visualize GluePoints
bool ObjectContactOfPageView::AreGluePointsVisible() const
{
-return GetPageWindow().GetPageView().GetView().ImpIsGlueVisible();
+bool bTiledRendering = comphelper::LibreOfficeKit::isActive();
+return !bTiledRendering &&
GetPageWindow().GetPageView().GetView().ImpIsGlueVisible();
}
// check if text animation is allowed.
commit fa8991840e122303bf9fa43d36864dd29529b0d2
Author: merttumer
AuthorDate: Thu Mar 25 12:44:17 2021 +0300
Commit: Mert Tumer
CommitDate: Tue Apr 20 04:32:43 2021 +0200
lok: Send gridOffset of the shape
In core, the gridOffset is calculated based on the LogicRect's TopLeft
coordinate
In online, we have the SnapRect and we calculate it based on its TopLeft
coordinate
SnapRect's TopLeft and LogicRect's TopLeft match when there is no rotation
but the rotation is not applied to the LogicRect. Therefore,
what we calculate in online does not match in case of the rotated shape.
Here we can send the correct gridOffset in the selection callback.
whether the shape is rotated or not, we will always have the correct
gridOffset
Note that the gridOffset is always calculated from the first selected obj
Change-Id: Icc62a94879367f9b55ad05887945393452021777
Signed-off-by: merttumer
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113078
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Szymon Kłos
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114027
Tested-by: Jenkins
diff --git a/svx/source/svdraw/svdmrkv.cxx b/svx/source/svdraw/svdmrkv.cxx
index 5f1d65ef185b..f42214daf8ad 100644
--- a/svx/source/svdraw/svdmrkv.cxx
+++ b/svx/source/svdraw/svdmrkv.cxx
@@ -692,6 +692,7 @@ void SdrMarkView::SetMarkHandlesForLOKit(tools::Rectangle
const & rRect, const S
tools::Rectangle aSelection(rRect);
bool bIsChart = false;
Point addLogicOffset(0, 0);
+bool convertMapMode = false;
if (!rRect.IsEmpty())
{
sal_uInt32 nTotalPaintWindows = this->PaintWindowCount();
@@ -721,7 +722,10 @@ void SdrMarkView::SetMarkHandlesForLOKit(tools::Rectangle
const & rRect, const S
if (OutputDevice* pOutputDevice =
mpMarkedPV->GetView().GetFirstOutputDevice())
{
if (pOutputDevice->GetMapMode().GetMapUnit() ==
MapUnit::Map100thMM)
+{
aSelection = OutputDevice::LogicToLogic(aSelection,
MapMode(MapUnit::Map100thMM), MapMode(MapUnit::MapTwip));
+convertMapMode = true;
+}
}
}
@@ -757,6 +761,26 @@ void SdrMarkView::SetMarkHandlesForLOKit(tools::Rectangle
const & rRect, const S
aExtraInfo.append("\",\"type\":");
aExtraInfo.append(OString::number(pO->GetObjIdentifier()));
+// In core, the gridOffset is calculated based on the LogicRect's
TopLeft coordinate
+// In online, we have the SnapRect and we calculate it based on
its TopLeft coordinate
+// SnapRect's TopLeft and LogicRect's TopLeft match unless there
is rotation
+// but the rotation is not applied to the LogicRect. Therefore,
+// what we calculate in online does not match with the core in
case of the rotation.
+// Here we can send the correct gridOffset in the selection
callback, this way
+// whether the shape is rotated or not, we will always have the
correct gridOffset
+// Note that the gridOffset is calculated from the first selected
obj
+basegfx::B2DVector aGridOffset(0.0, 0.0);
+if(getPossibleGridOffsetForSdrObject(aGridOffset,
GetMarkedObjectByIndex(0), GetSdrPageView()))
+{
+Point p(aGridOffset.getX(), aGridOffset.getY());
+if (convertMapMode)
+p =
[Libreoffice-commits] core.git: 2 commits - sc/source sd/source svx/source sw/source
sc/source/ui/view/tabvwsh2.cxx |2 ++
sd/source/ui/view/drviewse.cxx |4
svx/source/svdraw/svddrgv.cxx| 13 +
sw/source/uibase/uiview/viewdraw.cxx |3 +++
4 files changed, 18 insertions(+), 4 deletions(-)
New commits:
commit 2a91d96591001c83cac56e924fc6748c7900f7e5
Author: merttumer
AuthorDate: Wed Mar 24 12:06:08 2021 +0300
Commit: Mert Tumer
CommitDate: Tue Apr 20 04:32:22 2021 +0200
LOK: Fix Moving drag handles calculates wrong offset
When dragging the shape handles for resizing,
the handle's grid offset must be the shapes grid
offset. In small numbered row orders, it is
not visible much since the difference is very little
but as the number gets greater, the difference becomes more visible.
Change-Id: I44d03cc67a239c8b7758206930def331ed8e5e42
Signed-off-by: merttumer
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113028
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Szymon Kłos
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114026
Tested-by: Jenkins
diff --git a/svx/source/svdraw/svddrgv.cxx b/svx/source/svdraw/svddrgv.cxx
index 9807a53bd99e..6cbba5494070 100644
--- a/svx/source/svdraw/svddrgv.cxx
+++ b/svx/source/svdraw/svddrgv.cxx
@@ -36,6 +36,7 @@
#include
#include
#include
+#include
using namespace sdr;
@@ -206,10 +207,12 @@ bool SdrDragView::BegDragObj(const Point& rPnt,
OutputDevice* pOut, SdrHdl* pHdl
// Coordinate maybe affected by GridOffset, so we may need to
// adapt to Model-coordinates here
-if(getPossibleGridOffsetForPosition(
+if((comphelper::LibreOfficeKit::isActive() && mpMarkedObj
+&& getPossibleGridOffsetForSdrObject(aGridOffset,
GetMarkedObjectByIndex(0), GetSdrPageView()))
+|| (getPossibleGridOffsetForPosition(
aGridOffset,
basegfx::B2DPoint(aPnt.X(), aPnt.Y()),
-GetSdrPageView()))
+GetSdrPageView(
{
aPnt.AdjustX(basegfx::fround(-aGridOffset.getX()));
aPnt.AdjustY(basegfx::fround(-aGridOffset.getY()));
@@ -508,10 +511,12 @@ void SdrDragView::MovDragObj(const Point& rPnt)
// Coordinate maybe affected by GridOffset, so we may need to
// adapt to Model-coordinates here
-if(getPossibleGridOffsetForPosition(
+if((comphelper::LibreOfficeKit::isActive() && mpMarkedObj
+&& getPossibleGridOffsetForSdrObject(aGridOffset,
GetMarkedObjectByIndex(0), GetSdrPageView()))
+|| (getPossibleGridOffsetForPosition(
aGridOffset,
basegfx::B2DPoint(aPnt.X(), aPnt.Y()),
-GetSdrPageView()))
+GetSdrPageView(
{
aPnt.AdjustX(basegfx::fround(-aGridOffset.getX()));
aPnt.AdjustY(basegfx::fround(-aGridOffset.getY()));
commit c853d446a7cd8a8436cb5f43bbf81a723bd86c99
Author: merttumer
AuthorDate: Fri Mar 19 12:31:42 2021 +0300
Commit: Mert Tumer
CommitDate: Tue Apr 20 04:32:00 2021 +0200
Fix Line and Connectors enable interactive drawing
We add them directly for LOK case and have no functionality
for interactive drawing.
Noticed that in Writer we didnt even add them directly
I also implemented that as well.
Change-Id: If90bfc8d2cdf84f200bc7963ae4126ef789524ff
Signed-off-by: merttumer
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112703
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Jan Holesovsky
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114025
Tested-by: Jenkins
diff --git a/sc/source/ui/view/tabvwsh2.cxx b/sc/source/ui/view/tabvwsh2.cxx
index f213c5b822ef..652482ec5d6f 100644
--- a/sc/source/ui/view/tabvwsh2.cxx
+++ b/sc/source/ui/view/tabvwsh2.cxx
@@ -231,6 +231,7 @@ void ScTabViewShell::ExecDraw(SfxRequest& rReq)
case SID_DRAW_ELLIPSE:
case SID_DRAW_MEASURELINE:
pTabView->SetDrawFuncPtr(new FuConstRectangle(*this, pWin, pView,
pDoc, aNewReq));
+bCreateDirectly = comphelper::LibreOfficeKit::isActive();
break;
case SID_DRAW_CAPTION:
@@ -332,6 +333,7 @@ void ScTabViewShell::ExecDraw(SfxRequest& rReq)
}
else
{
+GetViewFrame()->GetDispatcher()->Execute(SID_OBJECT_SELECT,
SfxCallMode::ASYNCHRON);
ScViewData& rViewData = GetViewData();
aInsertPos = rViewData.getLOKVisibleArea().Center();
if (comphelper::LibreOfficeKit::isCompatFlagSet(
diff --git a/sd/source/ui/view/drviewse.cxx b/sd/source/ui/view/drviewse.cxx
index b833b1d3b719..2247294cfaba 100644
--- a/sd/source/ui/view/drviewse.cxx
+++ b/sd/source/ui/view/drviewse.cxx
@@ -605,6 +605,10 @@ void DrawViewShell::FuPermanent(SfxRequest& rReq)
if(!(HasCurrentFunction() && ((rReq.GetModifier() & KEY_MOD1) ||
bCreateDirectly)))
return;
+// disable interactive drawing for LOK
+if (bCreateDirectly)
+
[Libreoffice-commits] core.git: svx/source
svx/source/sdr/contact/viewobjectcontact.cxx |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) New commits: commit da7dcf0037b374a8cecdbd2af27748d94a316a79 Author: merttumer AuthorDate: Wed Mar 17 09:01:45 2021 +0300 Commit: Mert Tumer CommitDate: Tue Apr 20 04:31:49 2021 +0200 LOK: Fix wrong gridOffset when shape is moved on calc Change-Id: I37501128068943cee8f67a5d91a35ec1a76fe550 Signed-off-by: merttumer Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112599 Tested-by: Jenkins CollaboraOffice Reviewed-by: Tomaž Vajngerl Reviewed-by: Jan Holesovsky Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114024 Tested-by: Jenkins diff --git a/svx/source/sdr/contact/viewobjectcontact.cxx b/svx/source/sdr/contact/viewobjectcontact.cxx index 7e214b76199e..6387c39afcbf 100644 --- a/svx/source/sdr/contact/viewobjectcontact.cxx +++ b/svx/source/sdr/contact/viewobjectcontact.cxx @@ -224,8 +224,11 @@ void ViewObjectContact::ActionChanged() // invalidate current valid range GetObjectContact().InvalidatePartOfView(maObjectRange); -// reset ObjectRange, it needs to be recalculated -maObjectRange.reset(); +// reset gridOffset, it needs to be recalculated +if (GetObjectContact().supportsGridOffsets()) +resetGridOffset(); +else +maObjectRange.reset(); } // register at OC for lazy invalidate ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 138386] WMF: LO Writer does not display .emf files properly
https://bugs.documentfoundation.org/show_bug.cgi?id=138386 --- Comment #32 from tor...@yahoo.com --- Created attachment 171297 --> https://bugs.documentfoundation.org/attachment.cgi?id=171297=edit screenshot of D3Cos.emf; compare to 171275 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134050] Crash in: sclo.dll on editing chart data range after copying and pasting from an existing chart
https://bugs.documentfoundation.org/show_bug.cgi?id=134050 susan.car...@jeffersoncounty.in.gov changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #4 from susan.car...@jeffersoncounty.in.gov --- I had to go back to Excel in order to get my work done. As I'm no longer using Libre Office you may close this bug report. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141765] Drawing Object Properties toolbar is slightly taller
https://bugs.documentfoundation.org/show_bug.cgi?id=141765 Aron Budea changed: What|Removed |Added OS|Windows (All) |Linux (All) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141765] Drawing Object Properties toolbar is slightly taller
https://bugs.documentfoundation.org/show_bug.cgi?id=141765 Aron Budea changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141765] New: Drawing Object Properties toolbar is slightly taller
https://bugs.documentfoundation.org/show_bug.cgi?id=141765 Bug ID: 141765 Summary: Drawing Object Properties toolbar is slightly taller Product: LibreOffice Version: 7.0.0.3 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Keywords: bibisected, bisected, regression Severity: minor Priority: medium Component: graphics stack Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ba...@caesar.elte.hu CC: caol...@redhat.com - Add a shape to the document. - Click on and away from the shape. => The second toolbar (normally Formatting, and Drawing Object Properties when the shape is selected) slightly expands/contracts when the shape is selected/deselected. Observed using LO 7.2.0.0.alpha0+ (5348b3946b8f2b9581cdd8b40fa774c2a9d23868) & 7.0.0.3 / Ubuntu. Fine in Windows. No such change in 6.4.0.3. => regression Bibisected to the following commit using repo bibisect-linux-64-7.0. Adding CC: to Caolán McNamara. https://cgit.freedesktop.org/libreoffice/core/commit/?id=6c01bbab45eb16356d345ae2f6bfd6a864dd59e1 author Caolán McNamara 2020-02-10 11:36:53 + committer Caolán McNamara 2020-02-11 12:28:19 +0100 weld FillControl item window -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112581] [META] Linked (non-embedded) external files bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=112581 Bug 112581 depends on bug 141244, which changed state. Bug 141244 Summary: DDE Link edit missing https://bugs.documentfoundation.org/show_bug.cgi?id=141244 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92796] [ODF] Writer does not remove unused page background image/bitmap
https://bugs.documentfoundation.org/show_bug.cgi?id=92796 Nicolas R changed: What|Removed |Added CC||fran2...@yopmail.com --- Comment #27 from Nicolas R --- Hello, Still present and annoying in version Version: 7.1.2.2 / LibreOffice Community Build ID: 10(Build:2) CPU threads: 12; OS: Linux 5.10; UI render: default; VCL: kf5 Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR 7.1.2-2 Calc: threaded Tested with background image in page style ... If you try several successive images as background ... all of them stay in Pictures subfolder inside the odt The only way to suppress them is to unzip the odt, suppress the pictures in Pictures subfolder , fiddle with styles.xml and zip the whole files to have the new .odt. It would be great to have "something" in the ui to deal with these hidden images -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141752] calc: calculate: trap in rawsubtract, wrong calculation sequence, documentation imprecise
https://bugs.documentfoundation.org/show_bug.cgi?id=141752 --- Comment #2 from b. --- @Mike Kaganski: sorry for objecting: 1. users who know enough about fp-math, know that the calculating sequence matters, and do meaningful (small to big?) operand ordering acc. the sequence minuhend - subtrahend1 - subtrahend2 - subtrahend3 ... will be trapped, will be astonished that it doesn't work as expected and documented, and turn away frustrated with the idea 'fp-math is imprecise' ... we already have too much of these people, missing for making a good program, and it's unjustified, fp-math and IEEE 754 is! precise (to some degree), calc is messing it up in some respects, this case is clearly calc bullshitting and you defending it ... and it's never ever a dupe of a kahan summation enhancement request, it might be covered with kahan, might as well have / cause problems, see comment https://bugs.documentfoundation.org/show_bug.cgi?id=137679#c14, but in it's source it's different ... suggest unduping ... else ... file one big bug 'fp-math is imprecise', mark it as 'wontfix' and any calculation bugs as dupes and you are done ... ;-) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Error when building on Windows 10 with LODE
himajin10 wrote > Hi, > > not sure, but something to do with this one? > > https://github.com/gpg/libgpg-error/commit/655ed9d83889bbb61d4b96755a2bd676622064c8#diff-3d88d5bfc418d55451e947aa2b40ddf7428f1afbe1e1215f75cecc7cb2d45232 Hello, Thank you for your feedback. I gave a try by using https://wiki.documentfoundation.org/Development/Patching_External_Libraries and reverting the one line patch indicated but I still got the same error. Julien -- Sent from: http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 137679] Implement a Kahan summation algorithm for reduce the numerical error in the total
https://bugs.documentfoundation.org/show_bug.cgi?id=137679 --- Comment #14 from b. --- (In reply to Mike Kaganski from comment #13) > *** Bug 141752 has been marked as a duplicate of this bug. *** don't think that fits, 'Kahan' if implemented might solve the other problem, but Kahan is 'not so easy' it'll take some time ... in the meantime the rawsubtract-sequence can be solved by other means, e.g. calculation sequence as the subtrahends are numbered ... think it might lead to circles if rawsubtract is used - and neccessary? - to calculate the 'kahan artefacts', and one would use kahan inside rawsubtract to avoid deviations from operand ordering ... ??? propose unduping, -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Changes to 'refs/tags/cp-6.4-36'
Tag 'cp-6.4-36' created by Andras Timar at 2021-04-19 21:24 + cp-6.4-36 Changes since cp-6.4-35-7: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] translations.git: Changes to 'refs/tags/cp-6.4-36'
Tag 'cp-6.4-36' created by Andras Timar at 2021-04-19 21:24 + cp-6.4-36 Changes since cp-6.4-23: Andras Timar (1): Translation update --- source/ar/cui/messages.po | 130 source/ar/dictionaries/da_DK.po| 24 source/ar/officecfg/registry/data/org/openoffice/Office/UI.po | 24 source/ar/svtools/messages.po | 44 source/ar/svx/messages.po | 502 - source/ar/sw/messages.po | 405 source/as/cui/messages.po | 106 source/as/dictionaries/da_DK.po| 18 source/as/officecfg/registry/data/org/openoffice/Office/UI.po | 12 source/as/svtools/messages.po | 42 source/as/svx/messages.po | 472 source/as/sw/messages.po | 385 source/ast/cui/messages.po | 108 source/ast/dictionaries/da_DK.po | 18 source/ast/officecfg/registry/data/org/openoffice/Office/UI.po | 18 source/ast/svtools/messages.po | 42 source/ast/svx/messages.po | 485 - source/ast/sw/messages.po | 387 source/bg/cui/messages.po | 106 source/bg/dictionaries/da_DK.po| 24 source/bg/officecfg/registry/data/org/openoffice/Office/UI.po | 20 source/bg/svtools/messages.po | 42 source/bg/svx/messages.po | 465 source/bg/sw/messages.po | 385 source/bn-IN/cui/messages.po | 106 source/bn-IN/dictionaries/da_DK.po | 18 source/bn-IN/officecfg/registry/data/org/openoffice/Office/UI.po | 12 source/bn-IN/svtools/messages.po | 42 source/bn-IN/svx/messages.po | 482 source/bn-IN/sw/messages.po| 386 source/br/cui/messages.po | 106 source/br/dictionaries/da_DK.po| 18 source/br/officecfg/registry/data/org/openoffice/Office/UI.po | 12 source/br/svtools/messages.po | 42 source/br/svx/messages.po | 487 - source/br/sw/messages.po | 385 source/ca-valencia/cui/messages.po | 106 source/ca-valencia/dictionaries/da_DK.po | 18 source/ca-valencia/officecfg/registry/data/org/openoffice/Office/UI.po | 12 source/ca-valencia/svtools/messages.po | 42 source/ca-valencia/svx/messages.po | 471 source/ca-valencia/sw/messages.po | 385 source/ca/cui/messages.po | 106 source/ca/dictionaries/da_DK.po| 24 source/ca/officecfg/registry/data/org/openoffice/Office/UI.po | 20 source/ca/svtools/messages.po | 42 source/ca/svx/messages.po | 471 source/ca/sw/messages.po | 385 source/cs/cui/messages.po | 106 source/cs/dictionaries/da_DK.po| 24 source/cs/officecfg/registry/data/org/openoffice/Office/UI.po | 20 source/cs/svtools/messages.po | 42 source/cs/svx/messages.po | 465 source/cs/sw/messages.po | 385 source/cy/cui/messages.po | 106 source/cy/dictionaries/da_DK.po| 24 source/cy/officecfg/registry/data/org/openoffice/Office/UI.po | 20 source/cy/svtools/messages.po | 42 source/cy/svx/messages.po | 467 source/cy/sw/messages.po | 385 source/da/cui/messages.po
[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/cp-6.4-36'
Tag 'cp-6.4-36' created by Andras Timar at 2021-04-19 21:24 + cp-6.4-36 Changes since co-6.4-20: Andras Timar (1): update Danish dictionary --- da_DK/README_da_DK.txt |4 da_DK/da_DK.aff| 3401 da_DK/da_DK.dic|288016 +++-- da_DK/description.xml |9 4 files changed, 139245 insertions(+), 152185 deletions(-) --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: Changes to 'refs/tags/cp-6.4-36'
Tag 'cp-6.4-36' created by Andras Timar at 2021-04-19 21:24 + cp-6.4-36 Changes since cp-6.4-branch-point-11: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - configure.ac
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3d919ce182571e9c3c42bd3c6d04cae7b07e96f8 Author: Andras Timar AuthorDate: Mon Apr 19 23:24:18 2021 +0200 Commit: Andras Timar CommitDate: Mon Apr 19 23:24:18 2021 +0200 Bump version to 6.4-36 Change-Id: I868db61d3855180a7b118fdd1c54a9b79cd9db48 diff --git a/configure.ac b/configure.ac index 68d119a99a6e..49e794d06aba 100644 --- a/configure.ac +++ b/configure.ac @@ -9,7 +9,7 @@ dnl in order to create a configure script. # several non-alphanumeric characters, those are split off and used only for the # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no idea. -AC_INIT([Collabora Office],[6.4.10.35],[],[],[https://collaboraoffice.com/]) +AC_INIT([Collabora Office],[6.4.10.36],[],[],[https://collaboraoffice.com/]) dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just fine if it is installed dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails hard ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 141408] Updating Ukrainian spellchecker
https://bugs.documentfoundation.org/show_bug.cgi?id=141408 Andras Timar changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141762] building from source on non-wayland linux produces binary which crashes Xorg
https://bugs.documentfoundation.org/show_bug.cgi?id=141762 Jean-Baptiste Faure changed: What|Removed |Added Ever confirmed|0 |1 CC||jbfa...@libreoffice.org Status|UNCONFIRMED |NEEDINFO --- Comment #3 from Jean-Baptiste Faure --- I build LO 7.1 and current master on Ubuntu 18.04 x86-64 and I do not have any problem to run LO in my Xorg session. Please could you attach your autogen options. Generally these options are provided in a file named autogen.input That said, you could ask for help on the developer irc channel. Status has been set to NEEDINFO, please set it back to UNCONFIRMED once requested information has been provided. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141740] Unexpected Numerical List Behavior
https://bugs.documentfoundation.org/show_bug.cgi?id=141740 Jean-Baptiste Faure changed: What|Removed |Added CC||jbfa...@libreoffice.org --- Comment #3 from Jean-Baptiste Faure --- (In reply to don.steinbarge from comment #2) > (In reply to Uwe Auer from comment #1) > > - Select you numbered list > > - Format -> Bullets and Numbering -> Tab: Position > > - Tab stop at: Increase the default value to 0.60" or some larger value > > > > From my perspective not a bug. > > So the text should not look uniform? I would think that numbered lists > should look alike all the way throughout the document Your picture shows that the dot after VII is aligned with the I of previous Item, so the Item following VII. can't be aligned. On the contrary, if the tab is big enough all the items on your screenshot will be aligned vertically. Not a bug for me. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: dictionaries
dictionaries |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 4c02cbe6b21d30f30d5f5ae923177ddecab4fc06 Author: Andras Timar AuthorDate: Mon Apr 19 22:56:53 2021 +0200 Commit: Gerrit Code Review CommitDate: Mon Apr 19 22:56:53 2021 +0200 Update git submodules * Update dictionaries from branch 'master' to 06a28cf2efe2e3fa887912989650dcaaf05f0958 - tdf#141408 updated Ukraininan dictionaries Change-Id: I56aea01cbff18871bee91118f3f0701284caf87e Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/114308 Tested-by: Andras Timar Reviewed-by: Andras Timar diff --git a/dictionaries b/dictionaries index 96ecb3d82f44..06a28cf2efe2 16 --- a/dictionaries +++ b/dictionaries @@ -1 +1 @@ -Subproject commit 96ecb3d82f441c8ba38e7f773c5941e502acaf1c +Subproject commit 06a28cf2efe2e3fa887912989650dcaaf05f0958 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 141408] Updating Ukrainian spellchecker
https://bugs.documentfoundation.org/show_bug.cgi?id=141408 --- Comment #4 from Commit Notification --- Andras Timar committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/dictionaries/commit/06a28cf2efe2e3fa887912989650dcaaf05f0958 tdf#141408 updated Ukraininan dictionaries -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141408] Updating Ukrainian spellchecker
https://bugs.documentfoundation.org/show_bug.cgi?id=141408 Commit Notification changed: What|Removed |Added Whiteboard||target:7.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109195] [META] DOCX (OOXML) Footnote and Endnote bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109195 Bug 109195 depends on bug 141548, which changed state. Bug 141548 Summary: FILEOPEN: DOCX: Text in endnote is missing https://bugs.documentfoundation.org/show_bug.cgi?id=141548 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141548] FILEOPEN: DOCX: Text in endnote is missing
https://bugs.documentfoundation.org/show_bug.cgi?id=141548 László Németh changed: What|Removed |Added Assignee|nem...@numbertext.org |libreoffice-b...@lists.free ||desktop.org Resolution|--- |FIXED Status|ASSIGNED|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa writerfilter/source
sw/qa/extras/ooxmlexport/data/tdf141548.docx |binary
sw/qa/extras/ooxmlexport/ooxmlexport14.cxx | 10 ++
writerfilter/source/dmapper/DomainMapper.cxx |4 +++-
3 files changed, 13 insertions(+), 1 deletion(-)
New commits:
commit 6fd2bb9b8967c4945550b0f7b7541aaace8020c1
Author: László Németh
AuthorDate: Mon Apr 19 17:52:17 2021 +0200
Commit: László Németh
CommitDate: Mon Apr 19 22:24:44 2021 +0200
tdf#141548 DOCX import: fix lost text after endnoteRef
First run of the endnote (footnote) can contain not
only the footnoteRef/endnoteRef, but endnote (footnote)
text, too. This text was lost as a regression from
commit 7dd8f8aace536a8e60e87e61ee1d90d61fba15eb
"tdf#120351 DOCX import: fix slow endnote import",
and in the case of the footnotes, from
commit 9b39ce0e66acfe812e1d50e530dc2ccdef3e1357
"tdf#76260 DOCX import: fix slow footnote import".
Change-Id: I9964ee47f456a7632a21ab3b0588d3cb70388011
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114300
Tested-by: Jenkins
Reviewed-by: László Németh
diff --git a/sw/qa/extras/ooxmlexport/data/tdf141548.docx
b/sw/qa/extras/ooxmlexport/data/tdf141548.docx
new file mode 100644
index ..65c4e8b90756
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf141548.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
index 7709c46afb66..06c5a16e578a 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
@@ -1178,6 +1178,16 @@ DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testTdf141172,
"tdf141172.docx")
assertXPath(pXml, "/w:endnotes/w:endnote/w:tbl", 2);
}
+DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testTdf141548, "tdf141548.docx")
+{
+xmlDocUniquePtr pXml = parseExport("word/endnotes.xml");
+CPPUNIT_ASSERT(pXml);
+// This was 0 (lost text content of the run with endnoteRef)
+assertXPath(pXml, "/w:endnotes/w:endnote[4]/w:p/w:r[2]/w:t", 2);
+assertXPathContent(pXml, "/w:endnotes/w:endnote[4]/w:p/w:r[2]/w:t[1]",
"another endnote");
+assertXPathContent(pXml, "/w:endnotes/w:endnote[4]/w:p/w:r[2]/w:t[2]",
"new line");
+}
+
DECLARE_OOXMLEXPORT_TEST(testContSectBreakHeaderFooter,
"cont-sect-break-header-footer.docx")
{
// Load a document with a continuous section break on page 2.
diff --git a/writerfilter/source/dmapper/DomainMapper.cxx
b/writerfilter/source/dmapper/DomainMapper.cxx
index 9d163f2e671e..fddbea557c6c 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -3645,7 +3645,9 @@ void DomainMapper::lcl_utext(const sal_uInt8 * data_,
size_t len)
if (pContext && pContext->GetFootnote().is())
{
pContext->GetFootnote()->setLabel( sText );
-//otherwise ignore sText
+// tdf#141548 don't lose footnote/endnote text of the run with
uFtnEdnRef
+// (i.e. when footnoteRef/endnoteRef is followed by some text
in the same run)
+m_pImpl->appendTextPortion( sText, pContext );
}
else if (m_pImpl->IsOpenFieldCommand() &&
!m_pImpl->IsForceGenericFields())
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 135832] UI: Configuring a bitmap to show on full page with custom position and size not easy to do/ user friendly
https://bugs.documentfoundation.org/show_bug.cgi?id=135832 Buovjaga changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132901] Tools > Options > LibreOffice > Online update crashes if "online update" feature is not installed
https://bugs.documentfoundation.org/show_bug.cgi?id=132901 Xisco Faulí changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |xiscofa...@libreoffice.org |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/svl include/svx svl/source svx/inc svx/source
include/svl/itemset.hxx |2 +
include/svx/sdr/properties/defaultproperties.hxx|9 +++--
include/svx/sdr/properties/properties.hxx |2 -
svl/source/items/itemset.cxx| 32
svx/inc/sdr/properties/attributeproperties.hxx |2 -
svx/inc/sdr/properties/captionproperties.hxx|2 -
svx/inc/sdr/properties/circleproperties.hxx |2 -
svx/inc/sdr/properties/connectorproperties.hxx |2 -
svx/inc/sdr/properties/customshapeproperties.hxx|2 -
svx/inc/sdr/properties/e3dproperties.hxx|2 -
svx/inc/sdr/properties/emptyproperties.hxx |6 +--
svx/inc/sdr/properties/graphicproperties.hxx|2 -
svx/inc/sdr/properties/groupproperties.hxx |2 -
svx/inc/sdr/properties/measureproperties.hxx|2 -
svx/inc/sdr/properties/pageproperties.hxx |2 -
svx/inc/sdr/properties/textproperties.hxx |2 -
svx/source/sdr/properties/attributeproperties.cxx | 30 +-
svx/source/sdr/properties/captionproperties.cxx |6 +--
svx/source/sdr/properties/circleproperties.cxx | 10 +++---
svx/source/sdr/properties/connectorproperties.cxx |4 +-
svx/source/sdr/properties/customshapeproperties.cxx |8 ++---
svx/source/sdr/properties/defaultproperties.cxx | 32 ++--
svx/source/sdr/properties/e3dcompoundproperties.cxx |6 +--
svx/source/sdr/properties/e3dproperties.cxx |4 +-
svx/source/sdr/properties/e3dsceneproperties.cxx| 20 ++--
svx/source/sdr/properties/emptyproperties.cxx | 12 +++
svx/source/sdr/properties/graphicproperties.cxx | 24 +++
svx/source/sdr/properties/groupproperties.cxx | 14
svx/source/sdr/properties/measureproperties.cxx | 16 +-
svx/source/sdr/properties/pageproperties.cxx| 16 +-
svx/source/sdr/properties/textproperties.cxx| 22 ++---
svx/source/table/cell.cxx |8 ++---
svx/source/table/svdotable.cxx |6 +--
33 files changed, 173 insertions(+), 138 deletions(-)
New commits:
commit cd073a4a945a527cec3080523a0d7ec42bc49b26
Author: Noel Grandin
AuthorDate: Mon Apr 19 17:07:50 2021 +0200
Commit: Noel Grandin
CommitDate: Mon Apr 19 21:48:06 2021 +0200
svx properties: pass SfxItemSet around by value
so we avoid heap allocation costs when loading lots of shapes
Change-Id: I0de5819acc7f845973a284e68ab709989f27d402
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114297
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/svl/itemset.hxx b/include/svl/itemset.hxx
index 94ee142a2e77..41a782d7966f 100644
--- a/include/svl/itemset.hxx
+++ b/include/svl/itemset.hxx
@@ -125,6 +125,7 @@ public:
virtual ~SfxItemSet();
virtual std::unique_ptr Clone(bool bItems = true, SfxItemPool
*pToPool = nullptr) const;
+virtual SfxItemSet CloneAsValue(bool bItems = true, SfxItemPool *pToPool =
nullptr) const;
// Get number of items
sal_uInt16 Count() const { return m_nCount; }
@@ -256,6 +257,7 @@ public:
SfxAllItemSet( const SfxAllItemSet & );
virtual std::unique_ptr Clone( bool bItems = true, SfxItemPool
*pToPool = nullptr ) const override;
+virtual SfxItemSet CloneAsValue( bool bItems = true, SfxItemPool *pToPool
= nullptr ) const override;
protected:
virtual const SfxPoolItem* PutImpl( const SfxPoolItem&, sal_uInt16
nWhich, bool bPassingOwnership ) override;
};
diff --git a/include/svx/sdr/properties/defaultproperties.hxx
b/include/svx/sdr/properties/defaultproperties.hxx
index c9c4fdc5ec59..e901278d3b3e 100644
--- a/include/svx/sdr/properties/defaultproperties.hxx
+++ b/include/svx/sdr/properties/defaultproperties.hxx
@@ -22,10 +22,11 @@
#include
-#include
+#include
#include
#include
+#include
struct _xmlTextWriter;
typedef struct _xmlTextWriter* xmlTextWriterPtr;
@@ -36,10 +37,10 @@ namespace sdr::properties
{
protected:
// the to be used ItemSet
-std::unique_ptr mpItemSet;
+mutable std::optional mxItemSet;
// create a new itemset
-virtual std::unique_ptr
CreateObjectSpecificItemSet(SfxItemPool& rPool) override;
+virtual SfxItemSet CreateObjectSpecificItemSet(SfxItemPool& rPool)
override;
// test changeability for a single item
virtual bool AllowItemChange(const sal_uInt16 nWhich, const
SfxPoolItem* pNewItem = nullptr) const override;
@@ -54,7 +55,7 @@ namespace sdr::properties
virtual void ItemSetChanged(const SfxItemSet& rSet) override;
// check if SfxItemSet exists
-bool HasSfxItemSet() const { return
[Libreoffice-bugs] [Bug 141749] Text Tearing, Font Shrinkage, and Line Shifting bug related to use of Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=141749 --- Comment #1 from ProblemSolver --- With regards to my initial bug post, which I tried to keep as concise and to the point as possible, there are a couple of things I thought went without saying but perhaps should have been explicitly stated for completeness. One, since I maintain that the three issues this bug causes are all seemingly related to the sidebar being docked to the right-hand side of the monitor screen—but not to the left-hand side, then undocking the sidebar and leaving it to float is also a “solution”. However, it is doubtful that either of those “solutions” would be something any user would do because, in the former case, there already is an apparently unmovable media sidebar located there and, in the latter case, due to the sheer size and shape of the “sidebar”, having it floating is not a viable solution as it would block too much of the workspace. Two, since having no sidebar on the right-hand side of the monitor screen is a “solution”, then changing the view from Normal to Web or Full Screen are also “solutions.” Again, it is doubtful that many users would use the Web view because the margins are, at least for me, annoyingly too close to the edges of the screen for easy reading (at least with larger font sizes) and the Full Screen view lacks title and menu bars that users might want access to (unless you happen to know all the shortcuts off the top of your head). So, the best temporary “solution” would seem to be to deselect the Sidebar option from the View drop-down menu and, if you need the functionality of the Navigator, for example, then access it via the View drop-down menu until a permanent software solution is found. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141382] Properties dialog not in sync with actual properties.
https://bugs.documentfoundation.org/show_bug.cgi?id=141382 --- Comment #2 from Andreas Säger --- But I am not the only one: https://forum.openoffice.org/en/forum/viewtopic.php?f=11=104915 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86321] EDITING, FORMATTING: diagram didn't automatic update when change variable (steps in comment 28)
https://bugs.documentfoundation.org/show_bug.cgi?id=86321 Xisco Faulí changed: What|Removed |Added Keywords||bisected --- Comment #94 from Xisco Faulí --- I've just bisected this again. Regression introduced by author Armin Le Grand 2014-02-18 21:18:13 + committer Caolán McNamara 2014-02-19 20:29:12 + commit db1d2af02861b49e4f53d726d59cd71c20cee9b1 (patch) treea4edfc1235314f5e3d03c45a52863a052ad19286 parent 2237604b6b1d08439ac37f096a787c449a046b5f (diff) Resolves: #i123539# some optimizations for 3D chart... Bisected with: bibisect-43max I might have a solution for this... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141764] Wrong image showing Weblate in Firefox.
https://bugs.documentfoundation.org/show_bug.cgi?id=141764 --- Comment #1 from lach...@gmail.com --- Created attachment 171296 --> https://bugs.documentfoundation.org/attachment.cgi?id=171296=edit How it 'works' -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141764] New: Wrong image showing Weblate in Firefox.
https://bugs.documentfoundation.org/show_bug.cgi?id=141764 Bug ID: 141764 Summary: Wrong image showing Weblate in Firefox. Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Localization Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: lach...@gmail.com Description: A long list of XML tags has the wrong ostent. See more in the attached video. Steps to Reproduce: 1. https://translations.documentfoundation.org/translate/libo_help-master/textsharedoptionen/uk/?checksum=d854ed2a8604bc42 2. 3. Actual Results: Hard to see actual results. Expected Results: WYSIWYG Reproducible: Always User Profile Reset: No Additional Info: The same results in windows and Linux. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102627] Paste Special of RTF formatted text from Writer table can change the font in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=102627
David F Smith changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|--- |WORKSFORME
--- Comment #11 from David F Smith ---
Buovjaga's Comment 10 prompted me to try again. Starting from my original text
document, I got the same (worse) results that I reported on 15-Apr. But when I
recreated the table from scratch in a new text document, then copied and pasted
that into Calc, the formatting was copied (mostly) correctly. ("Mostly" means
that the bold text turned into a super-wide bold format. I don't understand
that.)
So my original bug is now pretty much fixed, and my updated report from 15-Apr
seems to be due to sometime weird in my text document. I'm changing the status
to WORKSFORME.
Thanks.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109040] [META] RTF paste special bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109040 Bug 109040 depends on bug 102627, which changed state. Bug 102627 Summary: Paste Special of RTF formatted text from Writer table can change the font in Calc https://bugs.documentfoundation.org/show_bug.cgi?id=102627 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - svx/source
svx/source/sdr/properties/defaultproperties.cxx |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
New commits:
commit a1ecf71fd7d3a011419a110e6e85bd0d32492f75
Author: Michael Stahl
AuthorDate: Fri Apr 16 16:21:26 2021 +0200
Commit: Xisco Fauli
CommitDate: Mon Apr 19 20:37:02 2021 +0200
svx: fix crash in DefaultProperties::dumpAsXml()
mpItemSet can be null
Change-Id: I4192f84639116c550bba5303a5fc70528cb3e8c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114263
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 832b23d9376019619929764606276aacde1e329a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114273
Reviewed-by: Xisco Fauli
diff --git a/svx/source/sdr/properties/defaultproperties.cxx
b/svx/source/sdr/properties/defaultproperties.cxx
index 587e9a652454..fa5e2beba858 100644
--- a/svx/source/sdr/properties/defaultproperties.cxx
+++ b/svx/source/sdr/properties/defaultproperties.cxx
@@ -246,7 +246,10 @@ namespace sdr::properties
{
xmlTextWriterStartElement(pWriter, BAD_CAST("DefaultProperties"));
BaseProperties::dumpAsXml(pWriter);
-mpItemSet->dumpAsXml(pWriter);
+if (mpItemSet)
+{
+mpItemSet->dumpAsXml(pWriter);
+}
xmlTextWriterEndElement(pWriter);
}
} // end of namespace
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - dbaccess/source extensions/source framework/source sdext/source svx/source
dbaccess/source/ui/browser/unodatbr.cxx |9 +
extensions/source/bibliography/framectr.cxx |5 +
framework/source/fwe/helper/titlehelper.cxx |4
framework/source/helper/persistentwindowstate.cxx |4
framework/source/helper/tagwindowasmodified.cxx |3 +++
framework/source/helper/titlebarupdate.cxx|4
framework/source/uielement/resourcemenucontroller.cxx |6 ++
sdext/source/presenter/PresenterController.cxx| 12 ++--
svx/source/form/datanavi.cxx |7 ---
9 files changed, 41 insertions(+), 13 deletions(-)
New commits:
commit 697a112334f7bba510f4ca2fd3ac83670ecf06a0
Author: Henry Castro
AuthorDate: Tue Mar 30 15:00:49 2021 -0400
Commit: Andras Timar
CommitDate: Mon Apr 19 20:06:21 2021 +0200
lok: remove frame action listener when disposing
In order to prevent that the frame action listener
holds the object reference count when removed,
ensure they are removed when disposing the object.
Change-Id: If83574e31230d9c683adaf36af36485650fd2c50
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113389
Tested-by: Jenkins
Reviewed-by: Henry Castro
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113455
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Andras Timar
diff --git a/dbaccess/source/ui/browser/unodatbr.cxx
b/dbaccess/source/ui/browser/unodatbr.cxx
index c72d3a0b6e9b..f4cef5483f69 100644
--- a/dbaccess/source/ui/browser/unodatbr.cxx
+++ b/dbaccess/source/ui/browser/unodatbr.cxx
@@ -299,6 +299,11 @@ void SAL_CALL SbaTableQueryBrowser::disposing()
// remove ourself as status listener
implRemoveStatusListeners();
+// check out from all the objects we are listening
+// the frame
+if (m_xCurrentFrameParent.is())
+
m_xCurrentFrameParent->removeFrameActionListener(static_cast(this));
+
// remove the container listener from the database context
try
{
@@ -310,10 +315,6 @@ void SAL_CALL SbaTableQueryBrowser::disposing()
DBG_UNHANDLED_EXCEPTION("dbaccess");
}
-// check out from all the objects we are listening
-// the frame
-if (m_xCurrentFrameParent.is())
-
m_xCurrentFrameParent->removeFrameActionListener(static_cast(this));
SbaXDataBrowserController::disposing();
}
diff --git a/extensions/source/bibliography/framectr.cxx
b/extensions/source/bibliography/framectr.cxx
index 5bf197c3c74d..ce1e77594f42 100644
--- a/extensions/source/bibliography/framectr.cxx
+++ b/extensions/source/bibliography/framectr.cxx
@@ -224,6 +224,11 @@ void BibFrameController_Impl::dispose()
{
m_bDisposing = true;
lang::EventObject aObject;
+uno::Reference< XFrame > xFrame = getFrame();
+
+if (xFrame.is())
+xFrame->removeFrameActionListener( m_xImpl.get() );
+
aObject.Source = static_cast(this);
m_xImpl->aLC.disposeAndClear(aObject);
m_xDatMan.clear();
diff --git a/framework/source/fwe/helper/titlehelper.cxx
b/framework/source/fwe/helper/titlehelper.cxx
index a50cc4b401af..2055d45919e6 100644
--- a/framework/source/fwe/helper/titlehelper.cxx
+++ b/framework/source/fwe/helper/titlehelper.cxx
@@ -245,6 +245,10 @@ void SAL_CALL TitleHelper::disposing(const
css::lang::EventObject& aEvent)
if ( ! xOwner.is ())
return;
+css::uno::Reference< css::frame::XFrame > xFrame(xOwner,
css::uno::UNO_QUERY);
+if (xFrame.is())
+xFrame->removeFrameActionListener(this);
+
if (xOwner != aEvent.Source)
return;
diff --git a/framework/source/helper/persistentwindowstate.cxx
b/framework/source/helper/persistentwindowstate.cxx
index aad137074d98..08e33ac527ef 100644
--- a/framework/source/helper/persistentwindowstate.cxx
+++ b/framework/source/helper/persistentwindowstate.cxx
@@ -136,6 +136,10 @@ void SAL_CALL PersistentWindowState::frameAction(const
css::frame::FrameActionEv
void SAL_CALL PersistentWindowState::disposing(const css::lang::EventObject&)
{
+css::uno::Reference< css::frame::XFrame > xFrame(m_xFrame.get(),
css::uno::UNO_QUERY);
+if (xFrame.is())
+xFrame->removeFrameActionListener(this);
+
// nothing todo here - because we hold the frame as weak reference only
}
diff --git a/framework/source/helper/tagwindowasmodified.cxx
b/framework/source/helper/tagwindowasmodified.cxx
index 3c40842dd6fa..7a72929763c5 100644
--- a/framework/source/helper/tagwindowasmodified.cxx
+++ b/framework/source/helper/tagwindowasmodified.cxx
@@ -128,6 +128,9 @@ void SAL_CALL TagWindowAsModified::disposing(const
css::lang::EventObject& aEven
SolarMutexGuard g;
css::uno::Reference< css::frame::XFrame > xFrame(m_xFrame.get(),
css::uno::UNO_QUERY);
+if (xFrame.is())
+xFrame->addFrameActionListener(this);
+
if (
(xFrame.is () ) &&
(aEvent.Source == xFrame)
diff --git
[Libreoffice-bugs] [Bug 125969] Background image, previously imported by user, not visible as a bitmap thumbnail when file reopened
https://bugs.documentfoundation.org/show_bug.cgi?id=125969 Tushar Kumar Rai changed: What|Removed |Added Assignee|tusharrai...@gmail.com |libreoffice-b...@lists.free ||desktop.org Status|ASSIGNED|NEW --- Comment #11 from Tushar Kumar Rai --- > Tushar: you can discuss with LO Devs on IRC or ask on dev LO forum. Sure. I was busy working on Gsoc proposal and am working on different patch now. Will assign it to myself after finishing. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141097] LibreOffice doesn't close when opened through API on Sybase PowerBuilder
https://bugs.documentfoundation.org/show_bug.cgi?id=141097 --- Comment #16 from Makrea --- (In reply to Buovjaga from comment #15) > In bug 141513, Advantage Database is in use with API Since that code that I analysed on https://bugs.documentfoundation.org/show_bug.cgi?id=141097#c13 was made all LO opened through API breaks closing on GUI so I'm not surprised by the existence of several bugs that are reported regarding this precise issue. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141751] QR-Codes are blurry after saving to .xls
https://bugs.documentfoundation.org/show_bug.cgi?id=141751 Telesto changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Telesto --- Thanks for reporting. Known - old - bug :-( Adding it too it, more duplicates & more people in CC increases changes of a fix *** This bug has been marked as a duplicate of bug 51510 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51510] FILESAVE: Exporting documents with embedded SVG to doc or docx converts the image to low-resolution pixel graphics
https://bugs.documentfoundation.org/show_bug.cgi?id=51510 Telesto changed: What|Removed |Added CC||rien...@hotmail.com --- Comment #24 from Telesto --- *** Bug 141751 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136524] [META] Performance/hang/lag/high CPU issues
https://bugs.documentfoundation.org/show_bug.cgi?id=136524 Bug 136524 depends on bug 136680, which changed state. Bug 136680 Summary: Paste from web freezes LibreOffice https://bugs.documentfoundation.org/show_bug.cgi?id=136680 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102593] [META] Paste bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102593 Bug 102593 depends on bug 136680, which changed state. Bug 136680 Summary: Paste from web freezes LibreOffice https://bugs.documentfoundation.org/show_bug.cgi?id=136680 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136680] Paste from web freezes LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=136680 Telesto changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEEDINFO|RESOLVED --- Comment #4 from Telesto --- Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: a809b2ab2553e946431699d9d7ac3f6209cbdd6b CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141739] Highlighting applied after drag & drop (unexpected)
https://bugs.documentfoundation.org/show_bug.cgi?id=141739 --- Comment #6 from Telesto --- Created attachment 171295 --> https://bugs.documentfoundation.org/attachment.cgi?id=171295=edit Screencast (In reply to Heiko Tietze from comment #5) > (In reply to Telesto from comment #4) > > Me not totally following. What do you mean with 'section'? > > Some characters. Just continue typing after applying DF- you want the, for > example, yellow highlighting to be continued. Don't see a reason why moving > text should behave differently. This is about 'copy/paste' (drag drop) changing formatting/ Not about 'typing after DF'. Did you try the steps? Adding a screencast too :P -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 141739] Highlighting applied after drag & drop (unexpected)
https://bugs.documentfoundation.org/show_bug.cgi?id=141739 --- Comment #6 from Telesto --- Created attachment 171295 --> https://bugs.documentfoundation.org/attachment.cgi?id=171295=edit Screencast (In reply to Heiko Tietze from comment #5) > (In reply to Telesto from comment #4) > > Me not totally following. What do you mean with 'section'? > > Some characters. Just continue typing after applying DF- you want the, for > example, yellow highlighting to be continued. Don't see a reason why moving > text should behave differently. This is about 'copy/paste' (drag drop) changing formatting/ Not about 'typing after DF'. Did you try the steps? Adding a screencast too :P -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 86321] EDITING, FORMATTING: diagram didn't automatic update when change variable (steps in comment 28)
https://bugs.documentfoundation.org/show_bug.cgi?id=86321 --- Comment #93 from VLB --- (In reply to Dimitris Kallipolitis from comment #91) > I have found a solution to this problem: > Go to Tools->Options->LibreOffice→Advanced→Open Expert Configuration→ Search > for ‘cache’→ Change org.openoffice.Office.Common→Cache→Drawing Engine > (OLE_Objects) to e.g. 40 (default value 20). This value should be greater > than your maximum number of charts in any spreadsheet that you use. A lower > value causes some charts not to be updated when spreadsheet data is updated. > It's a cache issue. > > Verified with: > Version: 7.1.2.2 / LibreOffice Community > Build ID: 10(Build:2) > OS: Linux 5.8; UI render: default; VCL: gtk3 > Ubuntu package version: 1:7.1.2~rc2-0ubuntu0.20.04.1~lo3 > Calc: threaded Thanks for the feedback on the issue! I have adjusted the value as indicated to a value of 90 (in connection with a sheet with 88 graphs) and tested it. I can conclude that this solves the problem for 1 sheet. Only I also have more of these shets open with miscellaneous adjustments (so maybe more than 4 * 88 graphs) and then notice that they are no longer updated. Can this value be increased indefinitely, without causing problems elsewhere? It would also be great if this problem could be solved in the source code, as already indicated in comment 92. Version: 7.1.2.2 (x64) / LibreOffice Community Build ID: 8a45595d069ef5570103caea1b71cc9d82b2aae4 CPU threads: 16; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: nl-NL Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141719] No KeyID for Title and Content in Slide Properties
https://bugs.documentfoundation.org/show_bug.cgi?id=141719 --- Comment #11 from Julien Nabet --- (In reply to Caolán McNamara from comment #10) > (In reply to Julien Nabet from comment #7) > ... > the keyid language "qtz" isn't a true translation target with real .mo > files, but a pseudo-one implemented in unotools/source/i18n/resmgr.cxx:213, > the "if it's a key id locale, generate it here" hunk that intercepts > attempts to use the .mo file and return the keyid instead. But gtk uses the > .mo files directly to extract translations, so in keyid mode the native gtk > components continue to work on the .mos as normal. I can't think of a > practical way to the native gtk widgets to show keyid. A bit complicated but I'll put it in my personal notes and try to not forget it. > Which I suppose is an aside from the original bug which does appear to be > NAB, e.g. unzipping clippingimagestyles.pptx gives > ppt/slideLayouts/slideLayout2.xml which has in the document itself Ok so no translation possible here. Thank you for the detailed feedback! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135832] UI: Configuring a bitmap to show on full page with custom position and size not easy to do/ user friendly
https://bugs.documentfoundation.org/show_bug.cgi?id=135832 --- Comment #4 from Telesto --- (In reply to Buovjaga from comment #3) > (In reply to Heiko Tietze from comment #2) > > We have many tickets around this, bug 103223 or bug 113224 are the meta > > tickets. I suggest to resolve this report as duplicate. It's anyway a bit > > unspecific. > > Telesto: do you agree? If yes, pick a duplicate Not seeing anything similar in those meta bugs (but well only skimmed through) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135905] Drag and drop below the last position should place the caret at the end
https://bugs.documentfoundation.org/show_bug.cgi?id=135905 --- Comment #10 from Telesto --- (In reply to Heiko Tietze from comment #9) > Do you suggest that we block dropping below the end of document (which > places the dragged content at the end)? That's kind of what I'm suggesting :P. There are so much where this this works. You really need to drag it to the 'empty space'. If there is (empty) paragraph below, this doesn't work at all.. So scope already limited. And well drag 'down' to empty space to put it at the end is not a really natural experience either. This is more bad drag accident drag in my perception. But if this is 'introduced' by design, then there is likely someone somewhere actually using finding. Else it's more a 'bug' which might be seen as feature by some? I see it as a bug. Minor or trivial, but still a bug if you ask me (with my current knowledge). But well hoping there more people in UX able to give some feedback. Maybe this being useful in tables or something like that? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141398] Reduce user's work load for inserting cross-references
https://bugs.documentfoundation.org/show_bug.cgi?id=141398 --- Comment #10 from Mike Kaganski --- (In reply to Christian Lehmann from comment #9) > This is a misunderstanding. > 1) If I want to refer to the object numbered 'X', then I type 'X' in the > selection field and I only want to see that exact paragraph which is > numbered 'X', and not dozens of paragraphs which happen to contain the > expression 'X'. Heh, no. This was not a misunderstanding on *my* part, but you substitute a discussion of "what is best for most" with your personal preference. Quite valid as an enhancement request, no problem in that. > However, if you want to offer the user alternative ways of finding the > paragraph he wants to refer to, then we are not talking about Types of > reference targets (that is what the dialog field is called), but about > search strategies. You may then wish to offer: > a) Search by number [where 'number' means 'paragraph/heading/footnote etc. > number] > b) Search by content. So your proposal seems to be "allow me to search by number only, in addition to the already existing method of searching by matching in any place of paragraph text". I agree that would be a valid enhancement (though not trivial, since Writer's link provider only gives strings, not structure internally - but that's an implementation detail that user does not have to think about), unless a simple "match from the start of the paragraph text" would suffice. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141398] Reduce user's work load for inserting cross-references
https://bugs.documentfoundation.org/show_bug.cgi?id=141398 --- Comment #9 from Christian Lehmann --- (In reply to Mike Kaganski from comment #7) > If I understand correctly, Christian Lehmann wants the "Selection" input > field, where user types something to filter the results, to only take > numbers into account, not the text of the numbered paragraph? It would be > absolutely wrong for most of the users, who may want to type the text and > find the corresponding item, and only makes sense for users who somehow know > all their numbers in a heavily numbered document (well, I hardly imagine > many people who know by heart all the numbers in a document with hundreds of > numbered paragraphs, while I easily know people who may reasonably remember > some part of text in the item they need). This is a misunderstanding. 1) If I want to refer to the object numbered 'X', then I type 'X' in the selection field and I only want to see that exact paragraph which is numbered 'X', and not dozens of paragraphs which happen to contain the expression 'X'. 2) The question of how I know that it is X that I want to refer to is a different one. If it is a heading, then my method is to look at the Navigator. Searching for a word or string that is part of the heading would be inefficient since that string may occur dozens of times in numbered paragraphs of all sorts. However, if you want to offer the user alternative ways of finding the paragraph he wants to refer to, then we are not talking about Types of reference targets (that is what the dialog field is called), but about search strategies. You may then wish to offer: a) Search by number [where 'number' means 'paragraph/heading/footnote etc. number] b) Search by content. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78370] FILEOPEN: RTF - Pages being merged / overlapping
https://bugs.documentfoundation.org/show_bug.cgi?id=78370 Andrew changed: What|Removed |Added CC||travn...@gmail.com --- Comment #21 from Andrew --- Created attachment 171294 --> https://bugs.documentfoundation.org/attachment.cgi?id=171294=edit one more example with broken render Still present for LO 7.1.2 Adding another testcase. Just in case, Calligra Words 3.2.1 shows it fine. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Error when building on Windows 10 with LODE
Hi, not sure, but something to do with this one? https://github.com/gpg/libgpg-error/commit/655ed9d83889bbb61d4b96755a2bd676622064c8#diff-3d88d5bfc418d55451e947aa2b40ddf7428f1afbe1e1215f75cecc7cb2d45232 -- himajin10 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 141762] building from source on non-wayland linux produces binary which crashes Xorg
https://bugs.documentfoundation.org/show_bug.cgi?id=141762 Yury changed: What|Removed |Added Summary|building from source on |building from source on |non-wayland linux sets |non-wayland linux produces |dependency on wayland, |binary which crashes Xorg |resulting binary crashes| |Xorg| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141762] building from source on non-wayland linux sets dependency on wayland, resulting binary crashes Xorg
https://bugs.documentfoundation.org/show_bug.cgi?id=141762 --- Comment #2 from Yury --- Even gen plugin has this issue (??!!). And in all three cases once Xorg is screwed up, you can't bring it back to workable state, going to non-graphical runlevel and back to graphical doesn't help. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141762] building from source on non-wayland linux sets dependency on wayland, resulting binary crashes Xorg
https://bugs.documentfoundation.org/show_bug.cgi?id=141762 --- Comment #1 from Yury --- Almost same thing happens with qt5 vcl plugin. Only the Xorg screen doesn't blank (splash screen and empty soffice frame are showing) and you can switch away to text console. However, there's no dependency on wayland in qt5 plugin. My configure options this time were: ./configure \ --with-jdk-home=/usr/lib64/jdk-16 \ --without-junit \ --disable-debug \ \ --enable-qt5 \ --disable-gtk3 \ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: dbaccess/source desktop/source framework/source svtools/source sw/source
dbaccess/source/core/api/SingleSelectQueryComposer.cxx |2
desktop/source/deployment/gui/dp_gui_updatedialog.cxx |4 -
framework/source/fwe/classes/addonsoptions.cxx |2
svtools/source/config/optionsdrawinglayer.cxx | 54 -
svtools/source/config/slidesorterbaropt.cxx| 12 +--
sw/source/filter/ww8/wrtww8.cxx|2
6 files changed, 38 insertions(+), 38 deletions(-)
New commits:
commit 35dac3d5d51cf58c3f49e039b8a67b129055f267
Author: Noel Grandin
AuthorDate: Mon Apr 19 15:19:22 2021 +0200
Commit: Noel Grandin
CommitDate: Mon Apr 19 18:39:32 2021 +0200
convert some #define to OUStringLiteral
Change-Id: I3d2ce76d30ec4f42495d27f1913c6718d2c5078f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114293
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/dbaccess/source/core/api/SingleSelectQueryComposer.cxx
b/dbaccess/source/core/api/SingleSelectQueryComposer.cxx
index 6c19bcc204fe..879342932cc0 100644
--- a/dbaccess/source/core/api/SingleSelectQueryComposer.cxx
+++ b/dbaccess/source/core/api/SingleSelectQueryComposer.cxx
@@ -85,7 +85,7 @@ namespace BooleanComparisonMode =
::com::sun::star::sdb::BooleanComparisonMode;
#define STR_ORDER_BY" ORDER BY "
#define STR_AND " AND "
#define STR_OR " OR "
-#define STR_LIKEOUString(" LIKE ")
+constexpr OUStringLiteral STR_LIKE = u" LIKE ";
#define L_BRACKET "("
#define R_BRACKET ")"
#define COMMA ","
diff --git a/desktop/source/deployment/gui/dp_gui_updatedialog.cxx
b/desktop/source/deployment/gui/dp_gui_updatedialog.cxx
index 42f63aa2e772..f24335b6357f 100644
--- a/desktop/source/deployment/gui/dp_gui_updatedialog.cxx
+++ b/desktop/source/deployment/gui/dp_gui_updatedialog.cxx
@@ -86,7 +86,7 @@ namespace {
sal_Unicode const LF = 0x000A;
sal_Unicode const CR = 0x000D;
-#define IGNORED_UPDATES
OUString("/org.openoffice.Office.ExtensionManager/ExtensionUpdateData/IgnoredUpdates")
+constexpr OUStringLiteral IGNORED_UPDATES =
u"/org.openoffice.Office.ExtensionManager/ExtensionUpdateData/IgnoredUpdates";
#define PROPERTY_VERSION"Version"
enum Kind { ENABLED_UPDATE, DISABLED_UPDATE, SPECIFIC_ERROR };
@@ -766,7 +766,7 @@ void UpdateDialog::getIgnoredUpdates()
{
uno::Reference< lang::XMultiServiceFactory > xConfig(
configuration::theDefaultProvider::get(m_context));
-beans::NamedValue aValue( "nodepath", uno::Any( IGNORED_UPDATES ) );
+beans::NamedValue aValue( "nodepath", uno::Any( OUString(IGNORED_UPDATES)
) );
uno::Sequence< uno::Any > args(1);
args[0] <<= aValue;
diff --git a/framework/source/fwe/classes/addonsoptions.cxx
b/framework/source/fwe/classes/addonsoptions.cxx
index ec604325139c..47012261969e 100644
--- a/framework/source/fwe/classes/addonsoptions.cxx
+++ b/framework/source/fwe/classes/addonsoptions.cxx
@@ -52,7 +52,7 @@ using namespace ::com::sun::star::lang;
using namespace ::com::sun::star;
#define ROOTNODE_ADDONMENU "Office.Addons"
-#define PATHDELIMITER OUString("/"
)
+constexpr OUStringLiteral PATHDELIMITER = u"/";
#define SEPARATOR_URL "private:separator"
#define PROPERTYNAME_URL
ADDONSMENUITEM_STRING_URL
diff --git a/svtools/source/config/optionsdrawinglayer.cxx
b/svtools/source/config/optionsdrawinglayer.cxx
index f975ee9fc8af..2f78f49e0104 100644
--- a/svtools/source/config/optionsdrawinglayer.cxx
+++ b/svtools/source/config/optionsdrawinglayer.cxx
@@ -74,43 +74,43 @@ using namespace ::com::sun::star::uno ;
#define DEFAULT_TRANSPARENTSELECTIONPERCENT 75
#define DEFAULT_SELECTIONMAXIMUMLUMINANCEPERCENT70
-#define PROPERTYNAME_OVERLAYBUFFER OUString("OverlayBuffer")
-#define PROPERTYNAME_PAINTBUFFEROUString("PaintBuffer" )
-#define PROPERTYNAME_STRIPE_COLOR_A OUString("StripeColorA" )
-#define PROPERTYNAME_STRIPE_COLOR_B OUString("StripeColorB" )
-#define PROPERTYNAME_STRIPE_LENGTH OUString("StripeLength" )
+constexpr OUStringLiteral PROPERTYNAME_OVERLAYBUFFER = u"OverlayBuffer";
+constexpr OUStringLiteral PROPERTYNAME_PAINTBUFFER= u"PaintBuffer";
+constexpr OUStringLiteral PROPERTYNAME_STRIPE_COLOR_A = u"StripeColorA";
+constexpr OUStringLiteral PROPERTYNAME_STRIPE_COLOR_B = u"StripeColorB";
+constexpr OUStringLiteral PROPERTYNAME_STRIPE_LENGTH = u"StripeLength";
// #i73602#
-#define PROPERTYNAME_OVERLAYBUFFER_CALC OUString("OverlayBuffer_Calc")
-#define PROPERTYNAME_OVERLAYBUFFER_WRITER
OUString("OverlayBuffer_Writer")
-#define PROPERTYNAME_OVERLAYBUFFER_DRAWIMPRESS
OUString("OverlayBuffer_DrawImpress")
+constexpr OUStringLiteral PROPERTYNAME_OVERLAYBUFFER_CALC =
u"OverlayBuffer_Calc";
+constexpr OUStringLiteral
[Libreoffice-commits] core.git: vcl/inc vcl/win
vcl/inc/win/salbmp.h|2 +-
vcl/win/gdi/gdiimpl.cxx |2 +-
vcl/win/gdi/salbmp.cxx |9 +++--
3 files changed, 5 insertions(+), 8 deletions(-)
New commits:
commit 4bb0afe359a92df09ad5b61b66bc4cb3562aca1e
Author: Noel Grandin
AuthorDate: Mon Apr 19 14:59:23 2021 +0200
Commit: Noel Grandin
CommitDate: Mon Apr 19 18:39:00 2021 +0200
remove dead code from WinSalBitmap::Create
Change-Id: I345bfba23d6041a631664f5e1dbbe27cd8ba0290
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114271
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/vcl/inc/win/salbmp.h b/vcl/inc/win/salbmp.h
index d48203840b76..c8fe3d851011 100644
--- a/vcl/inc/win/salbmp.h
+++ b/vcl/inc/win/salbmp.h
@@ -63,7 +63,7 @@ public:
public:
-boolCreate( HANDLE hBitmap, bool bDIB, bool
bCopyHandle );
+boolCreate( HANDLE hBitmap );
virtual boolCreate( const Size& rSize, vcl::PixelFormat
ePixelFormat, const BitmapPalette& rPal ) override;
virtual boolCreate( const SalBitmap& rSalBmpImpl )
override;
virtual boolCreate( const SalBitmap& rSalBmpImpl,
SalGraphics* pGraphics ) override;
diff --git a/vcl/win/gdi/gdiimpl.cxx b/vcl/win/gdi/gdiimpl.cxx
index d67e04be765f..2c418732561b 100644
--- a/vcl/win/gdi/gdiimpl.cxx
+++ b/vcl/win/gdi/gdiimpl.cxx
@@ -820,7 +820,7 @@ std::shared_ptr WinSalGraphicsImpl::getBitmap(
tools::Long nX, tools:
{
pSalBitmap = std::make_shared();
-if( !pSalBitmap->Create( hBmpBitmap, false, false ) )
+if( !pSalBitmap->Create( hBmpBitmap ) )
{
pSalBitmap.reset();
}
diff --git a/vcl/win/gdi/salbmp.cxx b/vcl/win/gdi/salbmp.cxx
index ed35d7b6d3da..0218ca408eec 100644
--- a/vcl/win/gdi/salbmp.cxx
+++ b/vcl/win/gdi/salbmp.cxx
@@ -459,14 +459,11 @@ std::shared_ptr
WinSalBitmap::ImplCreateGdiPlusBitmap(const Win
return pRetval;
}
-bool WinSalBitmap::Create( HANDLE hBitmap, bool bDIB, bool bCopyHandle )
+bool WinSalBitmap::Create( HANDLE hBitmap )
{
bool bRet = true;
-if( bDIB )
-mhDIB = static_cast( bCopyHandle ? ImplCopyDIBOrDDB( hBitmap,
true ) : hBitmap );
-else
-mhDDB = static_cast( bCopyHandle ? ImplCopyDIBOrDDB( hBitmap,
false ) : hBitmap );
+mhDDB = static_cast( hBitmap );
if( mhDIB )
{
@@ -656,7 +653,7 @@ bool WinSalBitmap::Create( const css::uno::Reference<
css::rendering::XBitmapCan
sal_Int64 aHBmp64;
if( args[0] >>= aHBmp64 ) {
-return Create( reinterpret_cast(aHBmp64), false, false
);
+return Create( reinterpret_cast(aHBmp64) );
}
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - sfx2/uiconfig vcl/inc vcl/win
sfx2/uiconfig/ui/linkeditdialog.ui | 40 ++--
vcl/inc/win/salbmp.h |2
vcl/win/gdi/salbmp.cxx | 119 -
3 files changed, 20 insertions(+), 141 deletions(-)
New commits:
commit da3d3fad1515348b6c4f2303db83ec03594f0597
Author: Aron Budea
AuthorDate: Sun Apr 18 06:27:33 2021 +0200
Commit: Caolán McNamara
CommitDate: Mon Apr 19 18:38:46 2021 +0200
tdf#141244 Modify DDE Link dialog was empty
Regression from de01c0c1d0f80ffec3882625d77c02ab806f6c7a.
Apparently entries must precede ones in
.ui files.
Change-Id: Ie91897d126527d3b30935a46b31f0a53b2837c53
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114237
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sfx2/uiconfig/ui/linkeditdialog.ui
b/sfx2/uiconfig/ui/linkeditdialog.ui
index 36e9f3d6930f..d39c829052e4 100644
--- a/sfx2/uiconfig/ui/linkeditdialog.ui
+++ b/sfx2/uiconfig/ui/linkeditdialog.ui
@@ -3,11 +3,6 @@
-
-
-
-
-
False
6
Modify DDE Link
@@ -15,6 +10,11 @@
0
0
dialog
+
+
+
+
+
@@ -143,16 +143,16 @@
-
-
-Lists the
application that last saved the source file. %PRODUCTNAME applications have the
server name soffice.
-
-
True
True
True
True
True
+
+
+Lists the
application that last saved the source file. %PRODUCTNAME applications have the
server name soffice.
+
+
1
@@ -161,16 +161,16 @@
-
-
-Path to the
source file. Relative paths must be expressed by full URI, for example, with
file://.
-
-
True
True
True
True
True
+
+
+Path to the
source file. Relative paths must be expressed by full URI, for example, with
file://.
+
+
1
@@ -179,16 +179,16 @@
-
-
-Lists the
section or object that the link refers to in the source file. If you want, you
can enter a new section or object here.
-
-
True
True
True
True
True
+
+
+Lists the
section or object that the link refers to in the source file. If you want, you
can enter a new section or object here.
+
+
1
commit 09a801915101f1cd6b39b20288fb55d76ad24c62
Author: Noel Grandin
AuthorDate: Mon Apr 19 14:54:34 2021 +0200
Commit: Noel Grandin
CommitDate: Mon Apr 19 18:38:28 2021 +0200
nobody uses RLE display hardware anymore
Change-Id: I07aa5b24425007ac82fedb28d3c4f0ad474dca14
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114270
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/vcl/inc/win/salbmp.h b/vcl/inc/win/salbmp.h
index 5167a7e4a939..d48203840b76 100644
--- a/vcl/inc/win/salbmp.h
+++ b/vcl/inc/win/salbmp.h
@@ -55,8 +55,6 @@ public:
static HGLOBAL ImplCreateDIB( const Size& rSize, vcl::PixelFormat
ePixelFormat, const BitmapPalette& rPal );
static HANDLE ImplCopyDIBOrDDB( HANDLE hHdl, bool bDIB );
static sal_uInt16 ImplGetDIBColorCount( HGLOBAL hDIB );
-static void ImplDecodeRLEBuffer( const BYTE* pSrcBuf, BYTE*
pDstBuf,
- const Size& rSizePixel, bool
bRLE4 );
public:
diff --git a/vcl/win/gdi/salbmp.cxx b/vcl/win/gdi/salbmp.cxx
index 387a2e6e2d99..ed35d7b6d3da 100644
--- a/vcl/win/gdi/salbmp.cxx
+++ b/vcl/win/gdi/salbmp.cxx
@@ -801,32 +801,6 @@ BitmapBuffer* WinSalBitmap::AcquireBuffer(
BitmapAccessMode /*nMode*/ )
PBITMAPINFO pBI = static_cast(GlobalLock( mhDIB
));
PBITMAPINFOHEADER pBIH = >bmiHeader;
-if( ( pBIH->biCompression == BI_RLE4 ) || ( pBIH->biCompression ==
BI_RLE8 ) )
-{
-SizeaSizePix( pBIH->biWidth, pBIH->biHeight );
-
[Libreoffice-commits] core.git: sal/osl
sal/osl/w32/file_dirvol.cxx | 305
1 file changed, 145 insertions(+), 160 deletions(-)
New commits:
commit 481b3bb669c7f2322723145aaf7271f844236e5e
Author: Noel Grandin
AuthorDate: Sat Apr 17 08:50:01 2021 +0200
Commit: Noel Grandin
CommitDate: Mon Apr 19 18:38:09 2021 +0200
flatten some code
Change-Id: I1b3148b1330b3713b1f158bf15c3e247c6982928
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114269
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sal/osl/w32/file_dirvol.cxx b/sal/osl/w32/file_dirvol.cxx
index d7d03501f0e1..d150b36277f4 100644
--- a/sal/osl/w32/file_dirvol.cxx
+++ b/sal/osl/w32/file_dirvol.cxx
@@ -285,26 +285,23 @@ static HANDLE WINAPI OpenLogicalDrivesEnum()
static bool WINAPI EnumLogicalDrives(HANDLE hEnum, LPWSTR lpBuffer)
{
-boolfSuccess = false;
LPDRIVEENUM pEnum = static_cast(hEnum);
-
-if ( pEnum )
+if ( !pEnum )
{
-int nLen = wcslen( pEnum->lpCurrent );
+SetLastError( ERROR_INVALID_HANDLE );
+return false;
+}
-if ( nLen )
-{
-CopyMemory( lpBuffer, pEnum->lpCurrent, (nLen + 1) * sizeof(WCHAR)
);
-pEnum->lpCurrent += nLen + 1;
-fSuccess = true;
-}
-else
-SetLastError( ERROR_NO_MORE_FILES );
+int nLen = wcslen( pEnum->lpCurrent );
+if ( !nLen )
+{
+SetLastError( ERROR_NO_MORE_FILES );
+return false;
}
-else
-SetLastError( ERROR_INVALID_HANDLE );
-return fSuccess;
+CopyMemory( lpBuffer, pEnum->lpCurrent, (nLen + 1) * sizeof(WCHAR) );
+pEnum->lpCurrent += nLen + 1;
+return true;
}
static bool WINAPI CloseLogicalDrivesEnum(HANDLE hEnum)
@@ -335,82 +332,78 @@ typedef struct tagDIRECTORY
static HANDLE WINAPI OpenDirectory( rtl_uString* pPath)
{
-LPDIRECTORY pDirectory = nullptr;
+if ( !pPath )
+return nullptr;
-if ( pPath )
-{
-sal_uInt32 nLen = rtl_uString_getLength( pPath );
-if ( nLen )
-{
-const WCHAR* pSuffix = nullptr;
-sal_uInt32 nSuffLen = 0;
+sal_uInt32 nLen = rtl_uString_getLength( pPath );
+if ( !nLen )
+return nullptr;
-if ( pPath->buffer[nLen - 1] != L'\\' )
-{
-pSuffix = L"\\*.*";
-nSuffLen = 4;
-}
-else
-{
-pSuffix = L"*.*";
-nSuffLen = 3;
-}
+const WCHAR* pSuffix = nullptr;
+sal_uInt32 nSuffLen = 0;
+if ( pPath->buffer[nLen - 1] != L'\\' )
+{
+pSuffix = L"\\*.*";
+nSuffLen = 4;
+}
+else
+{
+pSuffix = L"*.*";
+nSuffLen = 3;
+}
-WCHAR* szFileMask = static_cast< WCHAR* >( malloc( sizeof( WCHAR )
* ( nLen + nSuffLen + 1 ) ) );
-assert(szFileMask); // Don't handle OOM conditions
-wcscpy( szFileMask, o3tl::toW(rtl_uString_getStr( pPath )) );
-wcscat( szFileMask, pSuffix );
+WCHAR* szFileMask = static_cast< WCHAR* >( malloc( sizeof( WCHAR ) * (
nLen + nSuffLen + 1 ) ) );
+assert(szFileMask); // Don't handle OOM conditions
+wcscpy( szFileMask, o3tl::toW(rtl_uString_getStr( pPath )) );
+wcscat( szFileMask, pSuffix );
-pDirectory = static_cast(HeapAlloc(GetProcessHeap(),
0, sizeof(DIRECTORY)));
-assert(pDirectory); // Don't handle OOM conditions
-pDirectory->hFind = FindFirstFileW(szFileMask,
>aFirstData);
+LPDIRECTORY pDirectory =
static_cast(HeapAlloc(GetProcessHeap(), 0, sizeof(DIRECTORY)));
+assert(pDirectory); // Don't handle OOM conditions
+pDirectory->hFind = FindFirstFileW(szFileMask, >aFirstData);
-if (!IsValidHandle(pDirectory->hFind))
-{
-if ( GetLastError() != ERROR_NO_MORE_FILES )
-{
-HeapFree(GetProcessHeap(), 0, pDirectory);
-pDirectory = nullptr;
-}
-}
-free(szFileMask);
+if (!IsValidHandle(pDirectory->hFind))
+{
+if ( GetLastError() != ERROR_NO_MORE_FILES )
+{
+HeapFree(GetProcessHeap(), 0, pDirectory);
+pDirectory = nullptr;
}
}
+free(szFileMask);
return static_cast(pDirectory);
}
static bool WINAPI EnumDirectory(HANDLE hDirectory, LPWIN32_FIND_DATAW
pFindData)
{
-boolfSuccess = false;
LPDIRECTORY pDirectory = static_cast(hDirectory);
-
-if ( pDirectory )
+if ( !pDirectory )
{
-boolfValid;
+SetLastError( ERROR_INVALID_HANDLE );
+return false;
+}
-do
+bool fSuccess = false;
+bool fValid;
+do
+{
+if ( pDirectory->aFirstData.cFileName[0] )
{
-if ( pDirectory->aFirstData.cFileName[0] )
-{
-*pFindData
[Libreoffice-bugs] [Bug 141762] building from source on non-wayland linux sets dependency on wayland, resulting binary crashes Xorg
https://bugs.documentfoundation.org/show_bug.cgi?id=141762 Yury changed: What|Removed |Added Summary|building from source for|building from source on |gtk3 sets dependency on |non-wayland linux sets |wayland, resulting binary |dependency on wayland, |crashes Xorg|resulting binary crashes ||Xorg -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141398] Reduce user's work load for inserting cross-references
https://bugs.documentfoundation.org/show_bug.cgi?id=141398 Mike Kaganski changed: What|Removed |Added Keywords||bibisectRequest --- Comment #8 from Mike Kaganski --- (In reply to Christian Lehmann from comment #5) > Select Type "Headings" and, in the Selection > field, type "2.1.2.1". This identifies a single target. In the list field, > this should automatically be highlighted (as it used to be the case in > earlier LO versions). Instead, the cursor remains in the Selection field. I confirm that in Version: 6.2.0.3 (x64) Build ID: 98c6a8a1c6c7b144ce3cc729e34964b47ce25d62 CPU threads: 12; OS: Windows 10.0; UI render: GL; VCL: win; Locale: ru-RU (ru_RU); UI-Language: en-US Calc: CL typing '2' in the Selection makes the top element on the filtered list to be selected, while starting from Version: 6.3.0.4 (x64) Build ID: 057fc023c990d676a43019934386b85b21a9ee99 CPU threads: 12; OS: Windows 10.0; UI render: GL; VCL: win; Locale: ru-RU (ru_RU); UI-Language: en-US Calc: CL typing '2' makes the resulting list to *not* have any selection. I don't know if this was intentional, or some accidental breakage from, say, welding work. Marking bibisectrequest *for this aspect only*. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141763] Create a separate page count for each document section
https://bugs.documentfoundation.org/show_bug.cgi?id=141763 lostbits changed: What|Removed |Added Summary|Create a separate page |Create a separate page |count for each page style |count for each document ||section -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141763] New: Create a separate page count for each page style
https://bugs.documentfoundation.org/show_bug.cgi?id=141763 Bug ID: 141763 Summary: Create a separate page count for each page style Product: LibreOffice Version: 7.1.1.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: enhancement Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: aschw...@acm.org Description: see https://ask.libreoffice.org/en/question/24941/separate-page-count-for-each-style/ and https://bugs.documentfoundation.org/show_bug.cgi?id=71583_from=fdo Page counts are per document and not document section. The result is that page counts are reported for the entire document. I would like to be able to reset the page count from document scoped to page style scoped. Bug 71583 and 105668. This seems to be a long standing enhancement request (2013 and 2017). Could this be worked on for the next release? Steps to Reproduce: 1.In footer/header: select Insert->Fields->Page Count or Insert->Fields->More Fields->Page Count 2.The page count is global to the document. 3. Actual Results: There is no way to reset the page count to be section-centric rather than document-centric. This results in the page count reflecting the total pages in the document and is at variance with the use of the page number, viz., setting the page number to '1' in any page style and retaining the page count for the entire document shows and incorrect number of pages for the page style where the page number has been reset. Expected Results: It would be nice to be able to specialize the page count to reflect a document section rather than the entire document. In this way, for example, appendices in a document can be renumbered and re-page counted, so that the appendix number of pages is reflected rather then the total document. Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: TextDocument [Information guessed from browser] OS: Windows (All) OS is 64bit: yes Version 7.1.1.2 (x64) / LibreOffice Community Build: fe0b08f4af1bacage4c7ecc87 Environment CPU threads 8; OS: Windows 6.1 Service Pack 1 Build 7601 User Interface: UI render Skia/Raster; VCL:win -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141762] New: building from source for gtk3 sets dependency on wayland, resulting binary crashes Xorg
https://bugs.documentfoundation.org/show_bug.cgi?id=141762 Bug ID: 141762 Summary: building from source for gtk3 sets dependency on wayland, resulting binary crashes Xorg Product: LibreOffice Version: 7.1.2.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Installation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: yury.tarasiev...@gmail.com I tried to build 7.1.2.2 from source on my non-wayland linux system. As it happens, the build includes non-optional dependency on wayland in its binaries. After build completion, I tried to run soffice, and my Xorg blanked the screen and after several mode changes (visible by display's status popups) stopped responding at all. (Same problem exists on my system with AppImage of 7.1.2.2 as downloaded from libreoffice.org). Expected result: build that doesn't hardwire wayland requirements, which is the root of the problem, by my guess. Part of ' ldd -r libvclplug_gtk3lo.so |sort ' output: libwayland-client.so.0 => /usr/lib64/libwayland-client.so.0 (0x7eff4b2f3000) libwayland-cursor.so.0 => /usr/lib64/libwayland-cursor.so.0 (0x7eff4b2e9000) libwayland-egl.so.1 => /usr/lib64/libwayland-egl.so.1 (0x7eff4b2e4000) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135839] FILEOPEN PPTX Some images do not appear
https://bugs.documentfoundation.org/show_bug.cgi?id=135839 Buovjaga changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #6 from Buovjaga --- Ah, I did a new build and this is fixed with https://git.libreoffice.org/core/commit/cbf98d15ebfdeb61d5b797b21442761c76cb5f02 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - editeng/source include/editeng svx/source
editeng/source/editeng/editview.cxx |5 ++
include/editeng/editview.hxx|1
svx/source/dialog/weldeditview.cxx | 72 ++--
3 files changed, 34 insertions(+), 44 deletions(-)
New commits:
commit c90ebaddc119759f286a65f3fcd9c89aad2e4da9
Author: Caolán McNamara
AuthorDate: Mon Apr 19 09:33:12 2021 +0100
Commit: Caolán McNamara
CommitDate: Mon Apr 19 18:18:16 2021 +0200
a11y tests show we should use GetOutputDevice for pixel/logic conversions
Change-Id: I229ffb376b03ff2479385632319661dd35a63fea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114188
Reviewed-by: Michael Stahl
Tested-by: Jenkins
diff --git a/editeng/source/editeng/editview.cxx
b/editeng/source/editeng/editview.cxx
index 8e7c62f224e6..2938633978e0 100644
--- a/editeng/source/editeng/editview.cxx
+++ b/editeng/source/editeng/editview.cxx
@@ -351,6 +351,11 @@ vcl::Window* EditView::GetWindow() const
return pImpEditView->pOutWin;
}
+OutputDevice& EditView::GetOutputDevice() const
+{
+return pImpEditView->GetOutputDevice();
+}
+
bool EditView::HasOtherViewWindow( vcl::Window* pWin )
{
OutWindowSet& rOutWindowSet = pImpEditView->aOutWindowSet;
diff --git a/include/editeng/editview.hxx b/include/editeng/editview.hxx
index e89cd356be72..96c629f2e039 100644
--- a/include/editeng/editview.hxx
+++ b/include/editeng/editview.hxx
@@ -160,6 +160,7 @@ public:
voidSetWindow( vcl::Window* pWin );
vcl::Window*GetWindow() const;
+OutputDevice& GetOutputDevice() const;
boolHasOtherViewWindow( vcl::Window* pWin );
boolAddOtherViewWindow( vcl::Window* pWin );
diff --git a/svx/source/dialog/weldeditview.cxx
b/svx/source/dialog/weldeditview.cxx
index f62a3df178dc..1a315930c332 100644
--- a/svx/source/dialog/weldeditview.cxx
+++ b/svx/source/dialog/weldeditview.cxx
@@ -730,33 +730,25 @@ bool WeldViewForwarder::IsValid() const { return
m_rEditAcc.GetEditView() != nul
Point WeldViewForwarder::LogicToPixel(const Point& rPoint, const MapMode&
rMapMode) const
{
EditView* pEditView = m_rEditAcc.GetEditView();
-OutputDevice* pOutDev = pEditView ? pEditView->GetWindow() : nullptr;
-
-if (pOutDev)
-{
-MapMode aMapMode(pOutDev->GetMapMode());
-Point aPoint(OutputDevice::LogicToLogic(rPoint, rMapMode,
MapMode(aMapMode.GetMapUnit(;
-aMapMode.SetOrigin(Point());
-return pOutDev->LogicToPixel(aPoint, aMapMode);
-}
-
-return Point();
+if (!pEditView)
+return Point();
+OutputDevice& rOutDev = pEditView->GetOutputDevice();
+MapMode aMapMode(rOutDev.GetMapMode());
+Point aPoint(OutputDevice::LogicToLogic(rPoint, rMapMode,
MapMode(aMapMode.GetMapUnit(;
+aMapMode.SetOrigin(Point());
+return rOutDev.LogicToPixel(aPoint, aMapMode);
}
Point WeldViewForwarder::PixelToLogic(const Point& rPoint, const MapMode&
rMapMode) const
{
EditView* pEditView = m_rEditAcc.GetEditView();
-OutputDevice* pOutDev = pEditView ? pEditView->GetWindow() : nullptr;
-
-if (pOutDev)
-{
-MapMode aMapMode(pOutDev->GetMapMode());
-aMapMode.SetOrigin(Point());
-Point aPoint(pOutDev->PixelToLogic(rPoint, aMapMode));
-return OutputDevice::LogicToLogic(aPoint,
MapMode(aMapMode.GetMapUnit()), rMapMode);
-}
-
-return Point();
+if (!pEditView)
+return Point();
+OutputDevice& rOutDev = pEditView->GetOutputDevice();
+MapMode aMapMode(rOutDev.GetMapMode());
+aMapMode.SetOrigin(Point());
+Point aPoint(rOutDev.PixelToLogic(rPoint, aMapMode));
+return OutputDevice::LogicToLogic(aPoint, MapMode(aMapMode.GetMapUnit()),
rMapMode);
}
WeldTextForwarder::WeldTextForwarder(WeldEditAccessible& rAcc, WeldEditSource&
rSource)
@@ -1303,33 +1295,25 @@ bool WeldEditViewForwarder::IsValid() const { return
m_rEditAcc.GetEditView() !=
Point WeldEditViewForwarder::LogicToPixel(const Point& rPoint, const MapMode&
rMapMode) const
{
EditView* pEditView = m_rEditAcc.GetEditView();
-OutputDevice* pOutDev = pEditView ? pEditView->GetWindow() : nullptr;
-
-if (pOutDev)
-{
-MapMode aMapMode(pOutDev->GetMapMode());
-Point aPoint(OutputDevice::LogicToLogic(rPoint, rMapMode,
MapMode(aMapMode.GetMapUnit(;
-aMapMode.SetOrigin(Point());
-return pOutDev->LogicToPixel(aPoint, aMapMode);
-}
-
-return Point();
+if (!pEditView)
+return Point();
+OutputDevice& rOutDev = pEditView->GetOutputDevice();
+MapMode aMapMode(rOutDev.GetMapMode());
+Point aPoint(OutputDevice::LogicToLogic(rPoint, rMapMode,
MapMode(aMapMode.GetMapUnit(;
+aMapMode.SetOrigin(Point());
+return rOutDev.LogicToPixel(aPoint, aMapMode);
}
Point WeldEditViewForwarder::PixelToLogic(const Point& rPoint, const MapMode&
rMapMode) const
{
EditView* pEditView = m_rEditAcc.GetEditView();
-OutputDevice* pOutDev
