[Libreoffice-bugs] [Bug 142487] REPLACE: Wrong replacement in long text
https://bugs.documentfoundation.org/show_bug.cgi?id=142487 Michael changed: What|Removed |Added CC||mailinglis...@kmhessler.de --- Comment #1 from Michael --- I can confirm this misbehavior using LibreOffice Version: 7.0.5.2 Build ID: 64390860c6cd0aca4beafafcfd84613dd9dfb63a CPU threads: 16; OS: Linux 5.10; UI render: default; VCL: kf5 Locale: de-DE (de_DE.UTF-8); UI: de-DE Calc: threaded on Manjaro Linux, Kernel Version: 5.10.36-2-MANJARO KDE Plasma Version: 5.21.5 KDE Frameworks Version: 5.82.0 Qt Version: 5.15.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135331] FILESAVE DOC/DOCX: No page style background color export
https://bugs.documentfoundation.org/show_bug.cgi?id=135331 Justin L changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |NOTABUG --- Comment #7 from Justin L --- Confirmed with Word 2016 - in page Properties, there is no ability to set shading for a section. It only applies to text or paragraph. Also confirmed that if I use LO to set a section colour, the colour is lost on DOC and DOCX export - which just re-confirms that those formats don't have an option for section shading. NOTABUG. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108771] [META] DOCX (OOXML) page-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=108771 Bug 108771 depends on bug 135331, which changed state. Bug 135331 Summary: FILESAVE DOC/DOCX: No page style background color export https://bugs.documentfoundation.org/show_bug.cgi?id=135331 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |NOTABUG -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68419] FORMATTING: Paragraph borders are not merged between two pages
https://bugs.documentfoundation.org/show_bug.cgi?id=68419 --- Comment #15 from Aman Jha --- garmin.com/express In this you will get latest updates on the garmin.com/express https://www.garmin.com/en-US/software/express/windows/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142490] New: Impress animations panel only partially visible
https://bugs.documentfoundation.org/show_bug.cgi?id=142490 Bug ID: 142490 Summary: Impress animations panel only partially visible Product: LibreOffice Version: 7.0.4.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tonio.ta...@gmail.com Description: LibreOffice 7.0.4.2 on KDE Neon, screen LCD 1024x768 (old). The lower part of animations panel is only partially visible, so it's impossible to select many animations or set the options. The only workaround to select animation is to undock the panel, select and dock again. The only way to set the options is to use the right button menu on the animation. Steps to Reproduce: 1.Select an object 2.Add animation 3. Actual Results: The lower part of animations panel is only partially visible, so it's impossible to select many animations or set the options. Expected Results: Animations panel would be totally visible using the scroll bar. Reproducible: Always User Profile Reset: No Additional Info: In the 6.4 version the panel was correctly displayed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142220] FILESAVE PPTX Notes and Handouts Header-Footer incorrectly saved
https://bugs.documentfoundation.org/show_bug.cgi?id=142220 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142213] FILESAVE PPTX Animation trigger roundtripped incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=142213 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142225] advice for funational enhancement/improvement to select program to open link in spreadsheets
https://bugs.documentfoundation.org/show_bug.cgi?id=142225 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142470] Crash in: mergedlo.dll
https://bugs.documentfoundation.org/show_bug.cgi?id=142470 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138737] Writer 4.4.7.2 is opening in 3 seconds (warm start) while 7.1 takes 8 seconds
https://bugs.documentfoundation.org/show_bug.cgi?id=138737 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137773] Crash if I put table string in other table, before land in navigate
https://bugs.documentfoundation.org/show_bug.cgi?id=137773 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142211] .uno:DataRanges command is missing in Chart's Customize dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=142211 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142147] [1] PLEASETEST Password protection on Writer malfunctioning
https://bugs.documentfoundation.org/show_bug.cgi?id=142147 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137669] Different headers for each page
https://bugs.documentfoundation.org/show_bug.cgi?id=137669 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103378 Bug 103378 depends on bug 133903, which changed state. Bug 133903 Summary: Slow PDF export of sheet with charts based on large dataset (Print to PDF is fast) https://bugs.documentfoundation.org/show_bug.cgi?id=133903 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137773] Crash if I put table string in other table, before land in navigate
https://bugs.documentfoundation.org/show_bug.cgi?id=137773 --- Comment #3 from QA Administrators --- Dear konstantins, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142210] Manage Names dialogue box error in help
https://bugs.documentfoundation.org/show_bug.cgi?id=142210 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137669] Different headers for each page
https://bugs.documentfoundation.org/show_bug.cgi?id=137669 --- Comment #6 from QA Administrators --- Dear Hudson, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 137669] Different headers for each page
https://bugs.documentfoundation.org/show_bug.cgi?id=137669 --- Comment #6 from QA Administrators --- Dear Hudson, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 142470] Crash in: mergedlo.dll
https://bugs.documentfoundation.org/show_bug.cgi?id=142470 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48741] [META] Writer's page header and footer issues
https://bugs.documentfoundation.org/show_bug.cgi?id=48741 Bug 48741 depends on bug 137669, which changed state. Bug 137669 Summary: Different headers for each page https://bugs.documentfoundation.org/show_bug.cgi?id=137669 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137955] Browse Mode in LibreOffice Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=137955 --- Comment #5 from QA Administrators --- Dear juergenkohler23, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 137669] Different headers for each page
https://bugs.documentfoundation.org/show_bug.cgi?id=137669 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 73903] Check grammar as you type does not work for text in frames
https://bugs.documentfoundation.org/show_bug.cgi?id=73903 --- Comment #11 from QA Administrators --- Dear tmacalp, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133903] Slow PDF export of sheet with charts based on large dataset (Print to PDF is fast)
https://bugs.documentfoundation.org/show_bug.cgi?id=133903 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133903] Slow PDF export of sheet with charts based on large dataset (Print to PDF is fast)
https://bugs.documentfoundation.org/show_bug.cgi?id=133903 --- Comment #4 from QA Administrators --- Dear Telesto, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138514] Crash in: libgobject-2.0.so.0.6400.3
https://bugs.documentfoundation.org/show_bug.cgi?id=138514 --- Comment #4 from QA Administrators --- Dear Mike Sapsard, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138493] Wrong value in Pivot for a table
https://bugs.documentfoundation.org/show_bug.cgi?id=138493 --- Comment #2 from QA Administrators --- Dear Roland.Dietz, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98598] VIEWING: Repeated background image and web layout makes scrolling multiply elements on screen temporarily
https://bugs.documentfoundation.org/show_bug.cgi?id=98598 --- Comment #9 from QA Administrators --- Dear Ben, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124203] Opening files saved as macro enabled excel
https://bugs.documentfoundation.org/show_bug.cgi?id=124203 --- Comment #4 from QA Administrators --- Dear C Buffey, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123256] ViewCursor and TextCursor returns wrong PageStyleName
https://bugs.documentfoundation.org/show_bug.cgi?id=123256 BogdanB changed: What|Removed |Added Status|RESOLVED|VERIFIED CC||buzea.bog...@libreoffice.or ||g --- Comment #5 from BogdanB --- Looks ok in Version: 7.2.0.0.alpha1+ / LibreOffice Community Build ID: 42d2b2d55a27f11153ea1713737d93540a19211d CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58845] no shortcut or toolbar button for Extension Manager
https://bugs.documentfoundation.org/show_bug.cgi?id=58845 BogdanB changed: What|Removed |Added Status|RESOLVED|VERIFIED CC||buzea.bog...@libreoffice.or ||g --- Comment #23 from BogdanB --- I tested the shortcut: Ctrl+Alt+E. It works for opening Extension Manager. Verified in Version: 7.2.0.0.alpha1+ / LibreOffice Community Build ID: 42d2b2d55a27f11153ea1713737d93540a19211d CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49697] PDF: LO asks for password opening attached file. Evince does not.
https://bugs.documentfoundation.org/show_bug.cgi?id=49697 --- Comment #23 from yury.dubin...@gmail.com --- I guess I know one reason. Let’s examine the example from this post using pdfinfo. We see: Encrypted: yes (print:yes copy:yes change:no addNotes:no algorithm:RC4) 2/3 of my financial statements received from credit card companies and banks have this encryption level and are also encrypted with blank passwords. When addNotes is no, Adobe Reader, which is the standard for all financial businesses, does not support annotations in these PDFs. Of course, it is a funny protection, but security departments need their food. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142290] UNO Object Inspector: Greyed out icons: Back and Inspect
https://bugs.documentfoundation.org/show_bug.cgi?id=142290 --- Comment #3 from Tomaz Vajngerl --- "Inspect" button enables when you select an object that can be inspected in the properties tab and "Back" button enables after you inspect, so you can go back to the initial object. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142467] Inserting series in Stock Chart Data Table crashes Writer (Fedora only?)
https://bugs.documentfoundation.org/show_bug.cgi?id=142467 Kevin Suo changed: What|Removed |Added Summary|Delete series and then |Inserting series in Stock |insert series in Stock |Chart Data Table crashes |Chart Data Table crashes|Writer (Fedora only?) |Writer (Fedora only?) | --- Comment #6 from Kevin Suo --- No need to delete the series to reproduce the crash - only inserting series is enough. So, the steps are: 1. Insert chart in Writer, change chart type to Stock Chart 1. 2. Go to Data Table. 4. Click "Insert Series" icon on the Data Table toolbar. -> Crash. And this is why the UITest test_stock_chart13_insert_series fails on my system, see https://bugs.documentfoundation.org/show_bug.cgi?id=138556#c11 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142488] spam
https://bugs.documentfoundation.org/show_bug.cgi?id=142488 Michael Warner changed: What|Removed |Added URL|https://canindustrial.com/ | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142488] spam
https://bugs.documentfoundation.org/show_bug.cgi?id=142488 Michael Warner changed: What|Removed |Added Summary|Storage Buildings Edmonton |spam Component|General |deletionRequest Product|Document Liberation Project |LibreOffice -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49697] PDF: LO asks for password opening attached file. Evince does not.
https://bugs.documentfoundation.org/show_bug.cgi?id=49697 --- Comment #22 from Michael Warner --- (In reply to yury.dubinsky from comment #21) > There are reasons, mostly relevant for Adobe products, for using empty > passwords. If you wouldn't mind, could you elucidate more what those reasons are? I can't think of any, but I don't use much Adobe products any more. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142489] Do not display "Table" toolbar by default in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=142489 Rafael Lima changed: What|Removed |Added Keywords||needsUXEval Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142489] New: Do not display "Table" toolbar by default in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=142489 Bug ID: 142489 Summary: Do not display "Table" toolbar by default in Impress Product: LibreOffice Version: 7.2.0.0.alpha0+ Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rafael.palma.l...@gmail.com Created attachment 172340 --> https://bugs.documentfoundation.org/attachment.cgi?id=172340=edit Table toolbar: move to sidebar when table selected In Impress, when the user inserts a table (or when he/she clicks on an existing table), the default behavior is to enable the "Table" toolbar at the bottom. The problem with this is that, when the toolbar is displayed, the slide is moved up, and then when the table is deselected, the slide moves back down. I don't consider this to be a smooth experience, because when the user clicks something and the slide position changes, then whatever is beneath the mouse pointer changes and the user has to move the mouse again to where he/she was actually interested. Also, when the slide requires constantly clicking a table and contents outside the table, this moving up and down becomes annoying. So, I would like to suggest simply disabling this default behavior. So, when the user inserts or selects a table, this toolbar remains hidden (unless the user manually enables it by going to View > Toolbars > Table). This won't cripple functionality, since all the buttons from the toolbar are already available in the "Table" tab (except for the "Delete Table" button, that could be added to the tab). Another possibility would be to move the commands in the Table toolbar to the sidebar, above the Table Design section (see attached image). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108320] [META] Calc cells merging and splitting bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108320 Aron Budea changed: What|Removed |Added Depends on||142440 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=142440 [Bug 142440] Merge cells with different border styles create unexpected result -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102998] [META] Mail merge bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102998 Aron Budea changed: What|Removed |Added Depends on|142440 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=142440 [Bug 142440] Merge cells with different border styles create unexpected result -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142440] Merge cells with different border styles create unexpected result
https://bugs.documentfoundation.org/show_bug.cgi?id=142440 Aron Budea changed: What|Removed |Added CC||ba...@caesar.elte.hu Blocks|102998 |108320 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102998 [Bug 102998] [META] Mail merge bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=108320 [Bug 108320] [META] Calc cells merging and splitting bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: instsetoo_native/util
instsetoo_native/util/openoffice.lst.README | 16 ++-- instsetoo_native/util/openoffice.lst.in | 16 2 files changed, 10 insertions(+), 22 deletions(-) New commits: commit d4f5299fd2806d8f5dcd467742effeaa0dee8863 Author: Christian Lohmaier AuthorDate: Tue May 25 20:36:21 2021 +0200 Commit: Christian Lohmaier CommitDate: Wed May 26 00:29:21 2021 +0200 remove obsolete/duplicated entries from openoffice.lst.in The xml configuration related stuff is no longer (since 2013, with 89ac3c4acae1f0ffe3e96933d3449749ddf86847) done in installer code, but by postprocess/CustomTarget_registry.mk openoffice.lst is only used for package generation itself, and by extension for the replacement of values used in scp2 (those are replaced by "replace_all_ziplistvariables_in_file" (for the ${NAME} style ones) in solenv/bin/modules/installer/scpzipfiles.pm and (for the style) by replace_setup_variables in solenv/bin/modules/installer/scriptitems.pm the files that would be created by scp2 in case for an installation set (e.g versionrc, bootstraprc) are created by instsetoo_native/CustomTarget_setup.mk for plain instdir Change-Id: I761ea25aa98bbdcc310836257e288322fbfc437b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116128 Tested-by: Jenkins Reviewed-by: Christian Lohmaier diff --git a/instsetoo_native/util/openoffice.lst.README b/instsetoo_native/util/openoffice.lst.README index 9049c6100d19..aa783bdbf9da 100644 --- a/instsetoo_native/util/openoffice.lst.README +++ b/instsetoo_native/util/openoffice.lst.README @@ -19,8 +19,16 @@ Some documentation for the variables specified in file openoffice.lst. -FIXME: quite a few of these variables are duplicated in -postprocess/CustomTarget_registry.mk, this needs to be consolidated +It contains values used by the creation of installation packages themselves, +and as part of that contain subsitutions for variables used in scp2 (those will +be handled by the perl installer code) + +NOTE: For instdir, the corresponding files are created by +instsetoo_native/CustomTarget_setup.mk instead. + +It used to contain variables that were replaced in the xcu configuration files, +but those are handled by postprocess/CustomTarget_registry.mk (and there's no +difference for those between an installation set and the instdir method) VARIABLE NAME USAGE --- @@ -31,10 +39,6 @@ UREPACKAGEPREFIXname prefix for the URE installation packages SOLSUREPACKAGEPREFIXname prefix for the URE installation packages for Solaris platforms -STARTCENTER_ADDFEATURE_URL URL in start center to link to extension website -STARTCENTER_INFO_URLURL in start center to link to product homepage -STARTCENTER_TEMPLREP_URLURL in start center to link to templates website - UPDATEURL URL for the application update functionality /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/instsetoo_native/util/openoffice.lst.in b/instsetoo_native/util/openoffice.lst.in index dc6d2d97861e..f08549bf733d 100644 --- a/instsetoo_native/util/openoffice.lst.in +++ b/instsetoo_native/util/openoffice.lst.in @@ -51,8 +51,6 @@ LibreOffice BUNDLEIDENTIFIER @MACOSX_BUNDLE_IDENTIFIER@ BRANDPACKAGEVERSION @LIBO_VERSION_MAJOR@.@LIBO_VERSION_MINOR@ USERDIRPRODUCTVERSION 4 -ABOUTBOXPRODUCTVERSION @LIBO_VERSION_MAJOR@.@LIBO_VERSION_MINOR@.@LIBO_VERSION_MICRO@.@LIBO_VERSION_PATCH@@LIBO_VERSION_SUFFIX@ -ABOUTBOXPRODUCTVERSIONSUFFIX @LIBO_VERSION_SUFFIX_SUFFIX@ BASEPRODUCTVERSION @LIBO_VERSION_MAJOR@.@LIBO_VERSION_MINOR@ PCPFILENAME libreoffice.pcp UPDATEURL https://update.libreoffice.org/check.php @@ -66,9 +64,6 @@ LibreOffice SPELLCHECKERFILE spellchecker_selection.txt CHANGETARGETDIR 1 PATCHCODEFILE ooo_patchcodes.txt -STARTCENTER_ADDFEATURE_URL https://extensions.libreoffice.org/ -STARTCENTER_INFO_URL https://www.libreoffice.org/ -STARTCENTER_TEMPLREP_URL https://templates.libreoffice.org/ } active 1 compression 5 @@ -95,8 +90,6 @@ LibreOfficeDev BUNDLEIDENTIFIER @MACOSX_BUNDLE_IDENTIFIER@ BRANDPACKAGEVERSION @LIBO_VERSION_MAJOR@.@LIBO_VERSION_MINOR@ USERDIRPRODUCTVERSION 4 -ABOUTBOXPRODUCTVERSION @LIBO_VERSION_MAJOR@.@LIBO_VERSION_MINOR@.@LIBO_VERSION_MICRO@.@LIBO_VERSION_PATCH@@LIBO_VERSION_SUFFIX@ -ABOUTBOXPRODUCTVERSIONSUFFIX @LIBO_VERSION_SUFFIX_SUFFIX@ BASEPRODUCTVERSION @LIBO_VERSION_MAJOR@.@LIBO_VERSION_MINOR@ DEVELOPMENTPRODUCT 1 BASISPACKAGEPREFIX lodevbasis @@ -116,9
[Libreoffice-commits] core.git: config_host.mk.in configure.ac cui/source cui/uiconfig distro-configs/Jenkins officecfg/registry postprocess/CustomTarget_registry.mk svx/source svx/uiconfig
config_host.mk.in |1 configure.ac | 19 + cui/source/options/optupdt.cxx |8 + cui/source/options/optupdt.hxx |1 cui/uiconfig/ui/optonlineupdatepage.ui | 14 + distro-configs/Jenkins/macosx_clang_dbgutil|1 distro-configs/Jenkins/windows_msc_dbgutil_32 |1 officecfg/registry/data/org/openoffice/Office/Common.xcu |3 ++ officecfg/registry/schema/org/openoffice/Office/Common.xcs |5 +++ postprocess/CustomTarget_registry.mk |1 svx/source/dialog/crashreportdlg.cxx |9 ++ svx/source/dialog/crashreportdlg.hxx |1 svx/uiconfig/ui/crashreportdlg.ui | 16 ++ 13 files changed, 79 insertions(+), 1 deletion(-) New commits: commit 15ab55c092e0b474827abe104b73c5bfab6ef28c Author: Christian Lohmaier AuthorDate: Tue May 25 13:30:38 2021 +0200 Commit: Christian Lohmaier CommitDate: Wed May 26 00:29:00 2021 +0200 add privacy URL to crashreport dialog & updatecheck tab in options Change-Id: I35cda87c35876469bf581be223bc608e29f07b09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116105 Tested-by: Jenkins Reviewed-by: Christian Lohmaier diff --git a/config_host.mk.in b/config_host.mk.in index f7fa8ca12f9f..3dee84bf4f25 100644 --- a/config_host.mk.in +++ b/config_host.mk.in @@ -495,6 +495,7 @@ export POPPLER_LIBS=$(gb_SPACE)@POPPLER_LIBS@ export POSTGRESQL_INC=@POSTGRESQL_INC@ export POSTGRESQL_LIB=@POSTGRESQL_LIB@ export PREFIXDIR=@PREFIXDIR@ +export PRIVACY_POLICY_URL=@PRIVACY_POLICY_URL@ export PRODUCTNAME=@PRODUCTNAME@ export PRODUCTNAME_WITHOUT_SPACES=@PRODUCTNAME_WITHOUT_SPACES@ export PRODUCTVERSION=@PRODUCTVERSION@ diff --git a/configure.ac b/configure.ac index 971d7ad440c5..4652067a64de 100644 --- a/configure.ac +++ b/configure.ac @@ -2576,6 +2576,17 @@ AC_ARG_WITH(vendor, [Set vendor of the build.]), ,) +AC_ARG_WITH(privacy-policy-url, + AS_HELP_STRING([--with-privacy-policy-url="https://yourdomain/privacy-policy;], +[The URL to your privacy policy (needed when + enabling online-update or crashreporting via breakpad)]), +[if test "x$with_privacy_policy_url" = "xyes"; then +AC_MSG_FAILURE([you need to specify an argument when using --with-privacy-policy-url]) + elif test "x$with_privacy_policy_url" = "xno"; then +with_privacy_policy_url="undefined" + fi] +,[with_privacy_policy_url="undefined"]) + AC_ARG_WITH(android-package-name, AS_HELP_STRING([--with-android-package-name="org.libreoffice"], [Set Android package name of the build.]), @@ -12946,6 +12957,14 @@ AC_SUBST(ENABLE_ONLINE_UPDATE) AC_SUBST(ENABLE_ONLINE_UPDATE_MAR) AC_SUBST(UPDATE_CONFIG) + +PRIVACY_POLICY_URL="$with_privacy_policy_url" +if test "$ENABLE_ONLINE_UPDATE" = TRUE -o "$ENABLE_BREAKPAD" = "TRUE"; then +if test "x$with_privacy_policy_url" = "xundefined"; then +AC_MSG_FAILURE([online update or breakpad/crashreporting are enabled, but no privacy url was provided]) +fi +fi +AC_SUBST(PRIVACY_POLICY_URL) dnl === dnl Test whether we need bzip2 dnl === diff --git a/cui/source/options/optupdt.cxx b/cui/source/options/optupdt.cxx index db1402825f7c..d89fdec0aa4f 100644 --- a/cui/source/options/optupdt.cxx +++ b/cui/source/options/optupdt.cxx @@ -37,9 +37,11 @@ #include #include #include +#include #include #include #include +#include using namespace ::css; @@ -58,6 +60,7 @@ SvxOnlineUpdateTabPage::SvxOnlineUpdateTabPage(weld::Container* pPage, weld::Dia , m_xLastChecked(m_xBuilder->weld_label("lastchecked")) , m_xExtrasCheckBox(m_xBuilder->weld_check_button("extrabits")) , m_xUserAgentLabel(m_xBuilder->weld_label("useragent")) +, m_xPrivacyPolicyButton(m_xBuilder->weld_link_button("btnPrivacyPolicy")) { m_aNeverChecked = m_xNeverChecked->get_label(); @@ -65,6 +68,11 @@ SvxOnlineUpdateTabPage::SvxOnlineUpdateTabPage(weld::Container* pPage, weld::Dia m_xExtrasCheckBox->connect_toggled( LINK( this, SvxOnlineUpdateTabPage, ExtrasCheckHdl_Impl ) ); m_xCheckNowButton->connect_clicked( LINK( this, SvxOnlineUpdateTabPage, CheckNowHdl_Impl ) ); m_xChangePathButton->connect_clicked( LINK( this, SvxOnlineUpdateTabPage, FileDialogHdl_Impl ) ); +m_xPrivacyPolicyButton->set_uri( +officecfg::Office::Common::Menus::PrivacyPolicyURL::get() ++ "?type=updatecheck=" + utl::ConfigManager::getProductVersion() ++ "=" + LanguageTag(utl::ConfigManager::getUILocale()).getBcp47()); + uno::Reference < uno::XComponentContext
[Libreoffice-commits] core.git: solenv/clang-format svx/source
solenv/clang-format/excludelist |1 - svx/source/dialog/crashreportdlg.cxx | 15 ++- 2 files changed, 6 insertions(+), 10 deletions(-) New commits: commit 4d800dd7b58291386850d69570d027192419c5a0 Author: Christian Lohmaier AuthorDate: Tue May 25 13:31:56 2021 +0200 Commit: Christian Lohmaier CommitDate: Wed May 26 00:28:45 2021 +0200 clang-format crashreportdlg Change-Id: I58031cafaa9481ba6e8d77a7106485d8274e5bc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116104 Tested-by: Jenkins Reviewed-by: Christian Lohmaier diff --git a/solenv/clang-format/excludelist b/solenv/clang-format/excludelist index b51a9d8edb0c..22cd1b275860 100644 --- a/solenv/clang-format/excludelist +++ b/solenv/clang-format/excludelist @@ -11539,7 +11539,6 @@ svx/source/dialog/connctrl.cxx svx/source/dialog/contimp.hxx svx/source/dialog/contwnd.cxx svx/source/dialog/contwnd.hxx -svx/source/dialog/crashreportdlg.cxx svx/source/dialog/crashreportui.cxx svx/source/dialog/ctredlin.cxx svx/source/dialog/databaseregistrationui.cxx diff --git a/svx/source/dialog/crashreportdlg.cxx b/svx/source/dialog/crashreportdlg.cxx index 0f56078b5d40..2845541d0b78 100644 --- a/svx/source/dialog/crashreportdlg.cxx +++ b/svx/source/dialog/crashreportdlg.cxx @@ -9,7 +9,6 @@ #include "crashreportdlg.hxx" - #include #include #include @@ -18,8 +17,7 @@ #include CrashReportDialog::CrashReportDialog(weld::Window* pParent) -: GenericDialogController(pParent, "svx/ui/crashreportdlg.ui", -"CrashReportDialog") +: GenericDialogController(pParent, "svx/ui/crashreportdlg.ui", "CrashReportDialog") , mxBtnSend(m_xBuilder->weld_button("btn_send")) , mxBtnCancel(m_xBuilder->weld_button("btn_cancel")) , mxBtnClose(m_xBuilder->weld_button("btn_close")) @@ -40,9 +38,7 @@ CrashReportDialog::CrashReportDialog(weld::Window* pParent) mxBtnClose->connect_clicked(LINK(this, CrashReportDialog, BtnHdl)); } -CrashReportDialog::~CrashReportDialog() -{ -} +CrashReportDialog::~CrashReportDialog() {} short CrashReportDialog::run() { @@ -52,8 +48,8 @@ short CrashReportDialog::run() if (mxCBSafeMode->get_active()) { sfx2::SafeMode::putFlag(); - css::task::OfficeRestartManager::get(comphelper::getProcessComponentContext())->requestRestart( -css::uno::Reference< css::task::XInteractionHandler >()); + css::task::OfficeRestartManager::get(comphelper::getProcessComponentContext()) + ->requestRestart(css::uno::Reference()); } return nRet; } @@ -69,7 +65,8 @@ IMPL_LINK(CrashReportDialog, BtnHdl, weld::Button&, rBtn, void) if (bSuccess) { -OUString aProcessedMessage = maSuccessMsg.replaceAll("%CRASHID", aCrashID.replaceAll("Crash-ID=","")); +OUString aProcessedMessage += maSuccessMsg.replaceAll("%CRASHID", aCrashID.replaceAll("Crash-ID=", "")); // vclbuilder seems to replace _ with ~ even in text mxEditPostUpload->set_text(aProcessedMessage.replaceAll("~", "_")); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 142488] Storage Buildings Edmonton
https://bugs.documentfoundation.org/show_bug.cgi?id=142488 Can Industrial changed: What|Removed |Added URL||https://canindustrial.com/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142488] New: Storage Buildings Edmonton
https://bugs.documentfoundation.org/show_bug.cgi?id=142488 Bug ID: 142488 Summary: Storage Buildings Edmonton Product: Document Liberation Project Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: General Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: denzerk...@gmail.com Storage Buildings Toronto, Ontario, Edmonton, Alberta, New York and Buffalo. Can Industrial® is a world-class leader in storage solutions. We deliver the industry’s most innovative and effective portable fabric shelters and heavy-duty fence panels. Visit https://canindustrial.com/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108479] [META] Paste special bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108479 Bug 108479 depends on bug 116413, which changed state. Bug 116413 Summary: Calc: Using Paste Special > Options > Link, but the target cell doesn't change when source is updated https://bugs.documentfoundation.org/show_bug.cgi?id=116413 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142469] SSH Keys for remote files
https://bugs.documentfoundation.org/show_bug.cgi?id=142469 --- Comment #3 from Uwe Auer --- (In reply to Steve from comment #2) > > Sometimes reminders can be useful. Duplicate status accepted. ... to create a duplicate is not the way to promote an issue. Add yourself to CC of the original bug report and/or add an additional comment. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/inc
sc/inc/column.hxx |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) New commits: commit 0563867d60ad477235bb5595c895a4f1e06a53b1 Author: scito AuthorDate: Mon May 24 22:10:18 2021 +0200 Commit: Eike Rathke CommitDate: Tue May 25 23:18:44 2021 +0200 tdf#116413 keep AttachNewFormulaCell methods together Add public block instead of moving method to a public block. This was suggested in https://gerrit.libreoffice.org/c/core/+/114641/11/sc/inc/column.hxx#724 Change-Id: I30fd8f3348cdcc047d5b0d8856920b6e4e4a0c63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116076 Tested-by: Jenkins Reviewed-by: Eike Rathke diff --git a/sc/inc/column.hxx b/sc/inc/column.hxx index 560fb1d33b96..20ae065c1613 100644 --- a/sc/inc/column.hxx +++ b/sc/inc/column.hxx @@ -719,9 +719,6 @@ public: SCSIZE GetPatternCount( SCROW nRow1, SCROW nRow2 ) const; boolReservePatternCount( SCSIZE nReserve ); -void AttachNewFormulaCells(const sc::CellStoreType::position_type& aPos, size_t nLength, - std::vector& rNewSharedRows); - private: sc::CellStoreType::iterator GetPositionToInsert( SCROW nRow, std::vector& rNewSharedRows, @@ -739,6 +736,11 @@ private: const std::vector& rNewSharedRows, bool bJoin = true, sc::StartListeningType eListenType = sc::SingleCellListening ); +public: +void AttachNewFormulaCells(const sc::CellStoreType::position_type& aPos, size_t nLength, + std::vector& rNewSharedRows); + +private: void BroadcastNewCell( SCROW nRow ); bool UpdateScriptType( sc::CellTextAttr& rAttr, SCROW nRow, sc::CellStoreType::iterator& itr ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 81757] Calculations order do not follow cell dependencies
https://bugs.documentfoundation.org/show_bug.cgi?id=81757 --- Comment #26 from Commit Notification --- Eike Rathke committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/807f3508c9319d7f94820ea1282e306594418fce Related: tdf#81757 Do not even try to re-enter ScDocShell::Do*Recalc() It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81757] Calculations order do not follow cell dependencies
https://bugs.documentfoundation.org/show_bug.cgi?id=81757 Commit Notification changed: What|Removed |Added Whiteboard||target:7.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/ui/docshell/docsh4.cxx | 10 ++ 1 file changed, 10 insertions(+) New commits: commit 807f3508c9319d7f94820ea1282e306594418fce Author: Eike Rathke AuthorDate: Tue May 25 22:33:46 2021 +0200 Commit: Eike Rathke CommitDate: Tue May 25 23:16:10 2021 +0200 Related: tdf#81757 Do not even try to re-enter ScDocShell::Do*Recalc() That happened when loading bug doc https://bugs.documentfoundation.org/attachment.cgi?id=103462 where form selection events fire asynchronous recalcul() and BASIC Main also calls recalcul. Change-Id: Ic27fb340c7b5019453723c7cabe2122905d400f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116133 Reviewed-by: Eike Rathke Tested-by: Jenkins diff --git a/sc/source/ui/docshell/docsh4.cxx b/sc/source/ui/docshell/docsh4.cxx index f716048d8399..9276a57ecfc6 100644 --- a/sc/source/ui/docshell/docsh4.cxx +++ b/sc/source/ui/docshell/docsh4.cxx @@ -1426,6 +1426,11 @@ bool ScDocShell::ExecuteChangeProtectionDialog( bool bJustQueryIfProtected ) void ScDocShell::DoRecalc( bool bApi ) { +if (m_aDocument.IsInDocShellRecalc()) +{ +SAL_WARN("sc","ScDocShell::DoRecalc tries re-entering while in Recalc; probably Forms->BASIC->Dispatcher."); +return; +} ScDocShellRecalcGuard aGuard(m_aDocument); bool bDone = false; ScTabViewShell* pSh = GetBestViewShell(); @@ -1472,6 +1477,11 @@ void ScDocShell::DoRecalc( bool bApi ) void ScDocShell::DoHardRecalc() { +if (m_aDocument.IsInDocShellRecalc()) +{ +SAL_WARN("sc","ScDocShell::DoHardRecalc tries re-entering while in Recalc; probably Forms->BASIC->Dispatcher."); +return; +} auto start = std::chrono::steady_clock::now(); ScDocShellRecalcGuard aGuard(m_aDocument); weld::WaitObject aWaitObj( GetActiveDialogParent() ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 102780] FILEOPEN: Hebrew characters in EMF renders as other symbols
https://bugs.documentfoundation.org/show_bug.cgi?id=102780 --- Comment #7 from Valek Filippov --- ExtTextOutW record with Aleph/Bet/Gimel/Dalet has ETO_GLYPH_INDEX set. As per [MS-EMF] spec: "This bit indicates that the codes for characters in an output text string are indexes of the character glyphs in a TrueType font. Glyph indexes are font-specific, so to display the correct characters on playback, the font that is used MUST be identical to the font used to generate the indexes." That could be probably supported by using HarfBuzz' hb_font_glyph_to_string() or FreeType's FT_Get_Glyph_Name() to "convert encoding". (Kudos to Behdad for pointing to the right APIs). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Feature request] Convert spreadsheets to SQL queries
Hello devs, users, and lurkers I frequently find myself copying data from old spreadsheets to SQL. Would it be possible to convert spreadsheets to SQL queries? -- Chintan Mishra ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 136893] Basic-IDE - [File][Save] vs [File][Export Basic] - some characters replaced by ? [Export Basic]
https://bugs.documentfoundation.org/show_bug.cgi?id=136893 Andreas Heinisch changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #9 from Andreas Heinisch --- *** This bug has been marked as a duplicate of bug 139196 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: basctl/Library_basctl.mk basctl/source
basctl/Library_basctl.mk |7 ++- basctl/source/basicide/baside2.cxx | 22 ++ 2 files changed, 28 insertions(+), 1 deletion(-) New commits: commit 178adcd8459af63ddb48927207baa5b4efbfda12 Author: Andreas Heinisch AuthorDate: Sat May 22 21:10:49 2021 +0200 Commit: Andreas Heinisch CommitDate: Tue May 25 22:20:10 2021 +0200 tdf#139196 - Import/export macros using utf-8 including BOM In addition, try to detect the charset during the import of a *.bas file. Change-Id: I0dfe7f1b5349db409d90ed92b2e19c9946ae50cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116004 Tested-by: Jenkins Reviewed-by: Andreas Heinisch diff --git a/basctl/Library_basctl.mk b/basctl/Library_basctl.mk index f874dfe9cc54..d38a776312e9 100644 --- a/basctl/Library_basctl.mk +++ b/basctl/Library_basctl.mk @@ -29,7 +29,12 @@ $(eval $(call gb_Library_set_include,basctl,\ -I$(WORKDIR)/SdiTarget/basctl/sdi \ )) -$(eval $(call gb_Library_use_external,basctl,boost_headers)) +$(eval $(call gb_Library_use_externals,basctl,\ + boost_headers \ + icui18n \ + icuuc \ + icu_headers \ +)) $(eval $(call gb_Library_use_custom_headers,basctl,\ officecfg/registry \ diff --git a/basctl/source/basicide/baside2.cxx b/basctl/source/basicide/baside2.cxx index bebbe643874c..1b5cfce918bf 100644 --- a/basctl/source/basicide/baside2.cxx +++ b/basctl/source/basicide/baside2.cxx @@ -42,6 +42,7 @@ #include #include #include +#include #include #include #include @@ -436,6 +437,24 @@ void ModulWindow::LoadBasic() // nLines*4: ReadText/Formatting/Highlighting/Formatting GetEditorWindow().CreateProgress( IDEResId(RID_STR_GENERATESOURCE), nLines*4 ); GetEditEngine()->SetUpdateMode( false ); +// tdf#139196 - import macros using either default or utf-8 text encoding +constexpr size_t buffsize = 1024 * 1024; +sal_Int8 bytes[buffsize] = { 0 }; +sal_Int32 nRead = pStream->ReadBytes(bytes, buffsize); +UErrorCode uerr = U_ZERO_ERROR; +UCharsetDetector* ucd = ucsdet_open(); +ucsdet_setText(ucd, reinterpret_cast(bytes), nRead, ); +if (const UCharsetMatch* match = ucsdet_detect(ucd, )) +{ +const char* pEncodingName = ucsdet_getName(match, ); + +if (U_SUCCESS(uerr) && !strcmp("UTF-8", pEncodingName)) +{ +pStream->SetStreamCharSet(RTL_TEXTENCODING_UTF8); +} +} +ucsdet_close(ucd); +pStream->Seek(0); GetEditView()->Read( *pStream ); GetEditEngine()->SetUpdateMode( true ); GetEditorWindow().PaintImmediately(); @@ -483,6 +502,9 @@ void ModulWindow::SaveBasicSource() { EnterWait(); AssertValidEditEngine(); +// tdf#139196 - export macros using utf-8 including BOM +pStream->SetStreamCharSet(RTL_TEXTENCODING_UTF8); +pStream->WriteUChar(0xEF).WriteUChar(0xBB).WriteUChar(0xBF); GetEditEngine()->Write( *pStream ); aMedium.Commit(); LeaveWait(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 142470] Crash in: mergedlo.dll
https://bugs.documentfoundation.org/show_bug.cgi?id=142470 --- Comment #3 from Andreas Sittinger --- cannot always be reproduced, but managed to sporadically crash 5 times yesterday and today -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142470] Crash in: mergedlo.dll
https://bugs.documentfoundation.org/show_bug.cgi?id=142470 --- Comment #2 from Andreas Sittinger --- Created attachment 172339 --> https://bugs.documentfoundation.org/attachment.cgi?id=172339=edit sequence to reproduce: open some existing drawing insert new poplzlinew make it 6 pt thick make it blue change line end to circle, triange or something => maz crash -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81757] Calculations order do not follow cell dependencies
https://bugs.documentfoundation.org/show_bug.cgi?id=81757 --- Comment #25 from Eike Rathke --- Fwiw, having the form listbox selection events call recalcul() and also the recalcul call in Main may lead to them being executed simultaneously nested upon loading the document as form events are fired asynchronously, which makes things even worse. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142467] Delete series and then insert series in Stock Chart Data Table crashes Writer (Fedora only?)
https://bugs.documentfoundation.org/show_bug.cgi?id=142467 --- Comment #5 from Aritz Erkiaga --- I can't reproduce it with builds from libreoffice.org, only with the ones from Fedora repos, so I'd say this is Fedora-specific. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81757] Calculations order do not follow cell dependencies
https://bugs.documentfoundation.org/show_bug.cgi?id=81757 --- Comment #24 from b. --- will try to 'go through' and understand later, for the moment 'thank you very much @erAck', from such analysis and lessons people can learn! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81757] Calculations order do not follow cell dependencies
https://bugs.documentfoundation.org/show_bug.cgi?id=81757 --- Comment #23 from Eike Rathke --- The moment you observed Err:522 you should had gotten suspicious.. the culprit is the macro that while it has a CalculateHard running that calculates BENDALLOWANCE() that modifies the cell content of J12, which for the current view area triggers a find for changed values and calculates formula cells that are set "dirty" (i.e. to be recalculated), which then for F8 wants to obtain the result of F7 that currently is already running, hence the circular reference. 0. best do not try such dirty tricks as modifying cell content in a formula cell's macro function. It may work or may not and may have side effects you aren't aware of. As seen. 1. take such Err:522 circular reference error serious if you do such thing and not expect it (i.e. the formula cells and the cell references they use are not circular); just switching on iterations to workaround and suppress it may just hide the cause and fool you with an unexpected result. As seen. 2. if you feel brave and want to do such nasty things anyway then switch off all updates while the recalc executes to not have the "update the screen from dirty values and thus recalculate" triggered, i.e. in your sub recalcul lock and unlock the controllers with dim component as object component = ThisComponent component.lockControllers() ... CalculateHard ... component.unlockControllers() which in this case works. However, the better solution would be to not have the macro functions fiddle with cell content at all but rather calculate J12 properly with another function. Also, it would be better to not have the listboxes trigger a CalculateHard on selection, but rather write the selection to a cell (or use Data Validity instead of a form listbox) and use that cell as parameter to functions. You wouldn't need any manual recalc then. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135801] There is no way to copy a path from Options / Paths.
https://bugs.documentfoundation.org/show_bug.cgi?id=135801 --- Comment #6 from Ed Stauff --- >Why do you need to copy the path? There is no way to paste it back within the >program. I want to paste it into a different program. If the paths were very short, or there were only a few of them, I might not have bothered reporting this as a bug, but the paths are long (around 60 characters each on my Windows system), and the dialog on my system currently shows 15 of them. That's a lot to have to type by hand, not to mention the risk of typos. (Actually, there *should* be a way to paste a path in; if I already have the path in my clipboard, I shouldn't have to retype it. But that would be a different issue.) > I don't see much need to fiddle around with templates per file manager. Not merely the file manager, but other programs. You may not have ever had such a need, but I have. > additional features just clutter the UI I don't see how supporting +C clutters the UI. Having it copy the path to the clipboard is fully consistent with long-established UI conventions. Right now, that key combination does nothing, so why not have it do something obvious and useful instead? This functionality actually belongs in the listbox control in the GUI library; it's a generic feature that's easily implemented. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 135801] There is no way to copy a path from Options / Paths.
https://bugs.documentfoundation.org/show_bug.cgi?id=135801 --- Comment #6 from Ed Stauff --- >Why do you need to copy the path? There is no way to paste it back within the >program. I want to paste it into a different program. If the paths were very short, or there were only a few of them, I might not have bothered reporting this as a bug, but the paths are long (around 60 characters each on my Windows system), and the dialog on my system currently shows 15 of them. That's a lot to have to type by hand, not to mention the risk of typos. (Actually, there *should* be a way to paste a path in; if I already have the path in my clipboard, I shouldn't have to retype it. But that would be a different issue.) > I don't see much need to fiddle around with templates per file manager. Not merely the file manager, but other programs. You may not have ever had such a need, but I have. > additional features just clutter the UI I don't see how supporting +C clutters the UI. Having it copy the path to the clipboard is fully consistent with long-established UI conventions. Right now, that key combination does nothing, so why not have it do something obvious and useful instead? This functionality actually belongs in the listbox control in the GUI library; it's a generic feature that's easily implemented. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: vcl/workben
vcl/workben/epsfuzzer.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit 60d216ed1a5ad74a93edfb288206ce9ae20380a4 Author: Caolán McNamara AuthorDate: Tue May 25 20:06:39 2021 +0100 Commit: Caolán McNamara CommitDate: Tue May 25 21:08:01 2021 +0200 ofz#34602 missing a component Change-Id: Id069c3718a632046fa9df59ee145e0c904aaf718 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116129 Tested-by: Caolán McNamara Reviewed-by: Caolán McNamara diff --git a/vcl/workben/epsfuzzer.cxx b/vcl/workben/epsfuzzer.cxx index 1de2c63afe7c..b2d007cb6734 100644 --- a/vcl/workben/epsfuzzer.cxx +++ b/vcl/workben/epsfuzzer.cxx @@ -19,6 +19,7 @@ extern "C" { void * com_sun_star_i18n_LocaleDataImpl_get_implementation( void *, void * ); void * com_sun_star_i18n_BreakIterator_Unicode_get_implementation( void *, void * ); void * com_sun_star_i18n_BreakIterator_get_implementation( void *, void * ); +void * com_sun_star_i18n_NativeNumberSupplier_get_implementation( void *, void * ); } const lib_to_factory_mapping * @@ -38,6 +39,7 @@ lo_get_constructor_map(void) { "com_sun_star_i18n_LocaleDataImpl_get_implementation", com_sun_star_i18n_LocaleDataImpl_get_implementation }, { "com_sun_star_i18n_BreakIterator_Unicode_get_implementation", com_sun_star_i18n_BreakIterator_Unicode_get_implementation }, { "com_sun_star_i18n_BreakIterator_get_implementation", com_sun_star_i18n_BreakIterator_get_implementation }, +{ "com_sun_star_i18n_NativeNumberSupplier_get_implementation", com_sun_star_i18n_NativeNumberSupplier_get_implementation }, { 0, 0 } }; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 142487] REPLACE: Wrong replacement in long text
https://bugs.documentfoundation.org/show_bug.cgi?id=142487 Robert Großkopf changed: What|Removed |Added Keywords||regression -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142487] New: REPLACE: Wrong replacement in long text
https://bugs.documentfoundation.org/show_bug.cgi?id=142487 Bug ID: 142487 Summary: REPLACE: Wrong replacement in long text Product: LibreOffice Version: 7.0.5.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: BASIC Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rob...@familiegrosskopf.de Created attachment 172338 --> https://bugs.documentfoundation.org/attachment.cgi?id=172338=edit Extract the *.zip-file. Contains database an example text. Download the attached package. Contains a database-file and a text-file. Allow executing macros for this. Open the database. Open the form and have a look at the text. There are two positions marked in English with "→ have a look …" Same text you could see above. The macro should replace the "German" quotation marks. Now press the button. Quotation marks at the top of the text will be removed right. Quotation marks at the bottom will be removed wrong. There will be removed the following characters instead of the quotation marks. This bug appears here with LO 7.0.5.2, also with LO 7.1.3.2. It won't appear with LO 6.4.7.2 on the same machine. Tested with OpenSUSE 15.2 64bit rpm Linux. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: svx/source
svx/source/svdraw/svdobj.cxx | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) New commits: commit 0eecca25109472586ae0380f9290bec7503460e6 Author: Caolán McNamara AuthorDate: Tue May 25 15:53:10 2021 +0100 Commit: Caolán McNamara CommitDate: Tue May 25 20:51:13 2021 +0200 ofz#34601 teardown crash under oss-fuzz Change-Id: Icbb1500a85f956c8100878d6a0bef30b98440c32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116114 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/svx/source/svdraw/svdobj.cxx b/svx/source/svdraw/svdobj.cxx index df38cf4a6d7a..15b9cc6dcfcf 100644 --- a/svx/source/svdraw/svdobj.cxx +++ b/svx/source/svdraw/svdobj.cxx @@ -579,9 +579,14 @@ SdrItemPool& SdrObject::GetGlobalDrawObjectItemPool() mpGlobalItemPool->SetSecondaryPool(pGlobalOutlPool.get()); mpGlobalItemPool->SetDefaultMetric(SdrEngineDefaults::GetMapUnit()); mpGlobalItemPool->FreezeIdRanges(); -uno::Reference< frame::XDesktop2 > xDesktop = frame::Desktop::create(comphelper::getProcessComponentContext()); -uno::Reference< frame::XTerminateListener > xListener( new TerminateListener ); -xDesktop->addTerminateListener( xListener ); +if (utl::ConfigManager::IsFuzzing()) +mpGlobalItemPool->acquire(); +else +{ +uno::Reference< frame::XDesktop2 > xDesktop = frame::Desktop::create(comphelper::getProcessComponentContext()); +uno::Reference< frame::XTerminateListener > xListener( new TerminateListener ); +xDesktop->addTerminateListener( xListener ); +} } return *mpGlobalItemPool; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - sc/qa
sc/qa/unit/tiledrendering/tiledrendering.cxx | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) New commits: commit ad22776f5eb7c0ee313122bab1f43962d303a06c Author: Dennis Francis AuthorDate: Mon May 10 20:51:12 2021 +0530 Commit: Dennis Francis CommitDate: Tue May 25 20:41:19 2021 +0200 tdf#142214: unittest:test autocomplete through numeric block Change-Id: I4a44fb85dfdfdd9aa5f18801e4e2b215ee188e45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115346 Tested-by: Jenkins CollaboraOffice Reviewed-by: Dennis Francis Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115551 Tested-by: Jenkins (cherry picked from commit 17d4221c047eac47e26465ddc72d13fb89284f57) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116086 diff --git a/sc/qa/unit/tiledrendering/tiledrendering.cxx b/sc/qa/unit/tiledrendering/tiledrendering.cxx index 7b7e480ec6b2..80e0f7b2e2f0 100644 --- a/sc/qa/unit/tiledrendering/tiledrendering.cxx +++ b/sc/qa/unit/tiledrendering/tiledrendering.cxx @@ -2469,23 +2469,24 @@ void ScTiledRenderingTest::testAutoInputStringBlock() ScFieldEditEngine& rEE = pDoc->GetEditEngine(); rEE.SetText("XYZ"); pDoc->SetEditText(ScAddress(0, 5, 0), rEE.CreateTextObject()); // A6 -pDoc->SetString(ScAddress(0, 6, 0), "ZZZ"); // A7 +pDoc->SetValue(ScAddress(0, 6, 0), 123); +pDoc->SetString(ScAddress(0, 7, 0), "ZZZ"); // A8 ScAddress aA1(0, 0, 0); lcl_typeCharsInCell("X", aA1.Col(), aA1.Row(), pView, pModelObj); // Type 'X' in A1 CPPUNIT_ASSERT_EQUAL_MESSAGE("A1 should not autocomplete", OUString("X"), pDoc->GetString(aA1)); -ScAddress aA3(0, 2, 0); // Adjacent to the string "superblock" A4:A7 +ScAddress aA3(0, 2, 0); // Adjacent to the string "superblock" A4:A8 lcl_typeCharsInCell("X", aA3.Col(), aA3.Row(), pView, pModelObj); // Type 'X' in A3 CPPUNIT_ASSERT_EQUAL_MESSAGE("A3 should autocomplete", OUString("XYZ"), pDoc->GetString(aA3)); -ScAddress aA7(0, 6, 0); // Adjacent to the string "superblock" A4:A7 -lcl_typeCharsInCell("X", aA7.Col(), aA7.Row(), pView, pModelObj); // Type 'X' in A7 -CPPUNIT_ASSERT_EQUAL_MESSAGE("A7 should autocomplete", OUString("XYZ"), pDoc->GetString(aA7)); +ScAddress aA9(0, 8, 0); // Adjacent to the string "superblock" A4:A8 +lcl_typeCharsInCell("X", aA9.Col(), aA9.Row(), pView, pModelObj); // Type 'X' in A9 +CPPUNIT_ASSERT_EQUAL_MESSAGE("A9 should autocomplete", OUString("XYZ"), pDoc->GetString(aA9)); -ScAddress aA10(0, 9, 0); -lcl_typeCharsInCell("X", aA10.Col(), aA10.Row(), pView, pModelObj); // Type 'X' in A10 -CPPUNIT_ASSERT_EQUAL_MESSAGE("A10 should not autocomplete", OUString("X"), pDoc->GetString(aA10)); +ScAddress aA11(0, 10, 0); +lcl_typeCharsInCell("X", aA11.Col(), aA11.Row(), pView, pModelObj); // Type 'X' in A11 +CPPUNIT_ASSERT_EQUAL_MESSAGE("A11 should not autocomplete", OUString("X"), pDoc->GetString(aA11)); } void ScTiledRenderingTest::testAutoInputExactMatch() ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - sc/inc sc/source
sc/inc/column.hxx|2 - sc/inc/document.hxx |2 - sc/inc/table.hxx |2 - sc/source/core/data/column3.cxx | 54 --- sc/source/core/data/documen3.cxx |8 ++--- sc/source/core/data/table3.cxx |4 +- sc/source/ui/app/inputhdl.cxx|2 - sc/source/ui/view/gridwin.cxx|2 - 8 files changed, 28 insertions(+), 48 deletions(-) New commits: commit 34a459791a734cd4a551ed7fcfd4e40dfd6b8508 Author: Dennis Francis AuthorDate: Mon May 10 17:56:34 2021 +0530 Commit: Dennis Francis CommitDate: Tue May 25 20:40:53 2021 +0200 tdf#142214: autoinput: remove search/entry count limits Change-Id: Ib41f7c04b9a3802982105cbbfef3ae638bdb286f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115345 Tested-by: Jenkins CollaboraOffice Reviewed-by: Dennis Francis Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115545 Tested-by: Jenkins (cherry picked from commit ebff4e5181b102e5184277f57fda32fcce60431f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116085 diff --git a/sc/inc/column.hxx b/sc/inc/column.hxx index 3adca3745ec0..d369f84de36c 100644 --- a/sc/inc/column.hxx +++ b/sc/inc/column.hxx @@ -537,7 +537,7 @@ public: sc::ColumnBlockConstPosition& rBlockPos, SCROW nStartRow, SCROW nEndRow, ScFilterEntries& rFilterEntries ); -bool GetDataEntries( SCROW nRow, std::set& rStrings, bool bLimit ) const; +bool GetDataEntries( SCROW nRow, std::set& rStrings) const; void UpdateInsertTabAbs(SCTAB nNewPos); boolTestTabRefAbs(SCTAB nTable) const; diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx index 02f0aa163f3b..210811968e97 100644 --- a/sc/inc/document.hxx +++ b/sc/inc/document.hxx @@ -2080,7 +2080,7 @@ public: ScFilterEntries& rFilterEntries ); void GetDataEntries( SCCOL nCol, SCROW nRow, SCTAB nTab, - std::vector& rStrings, bool bLimit = false ); + std::vector& rStrings, bool bValidation = false ); void GetFormulaEntries( ScTypedCaseStrSet& rStrings ); bool HasAutoFilter( SCCOL nCol, SCROW nRow, SCTAB nTab ); diff --git a/sc/inc/table.hxx b/sc/inc/table.hxx index 309d49d4f140..09e71f139466 100644 --- a/sc/inc/table.hxx +++ b/sc/inc/table.hxx @@ -952,7 +952,7 @@ public: void GetFilterEntries(SCCOL nCol, SCROW nRow1, SCROW nRow2, ScFilterEntries& rFilterEntries ); void GetFilteredFilterEntries(SCCOL nCol, SCROW nRow1, SCROW nRow2, const ScQueryParam& rParam, ScFilterEntries& rFilterEntries ); [[nodiscard]] -bool GetDataEntries(SCCOL nCol, SCROW nRow, std::set& rStrings, bool bLimit); +bool GetDataEntries(SCCOL nCol, SCROW nRow, std::set& rStrings); boolHasColHeader( SCCOL nStartCol, SCROW nStartRow, SCCOL nEndCol, SCROW nEndRow ) const; boolHasRowHeader( SCCOL nStartCol, SCROW nStartRow, SCCOL nEndCol, SCROW nEndRow ) const; diff --git a/sc/source/core/data/column3.cxx b/sc/source/core/data/column3.cxx index 42acb311312c..41ae6a3d1931 100644 --- a/sc/source/core/data/column3.cxx +++ b/sc/source/core/data/column3.cxx @@ -2674,14 +2674,8 @@ public: } // GetDataEntries - Strings from continuous Section around nRow - -// DATENT_MAX - max. number of entries in list for auto entry -// DATENT_SEARCH - max. number of cells that get transparent - new: only count Strings -#define DATENT_MAX 200 -#define DATENT_SEARCH 2000 - bool ScColumn::GetDataEntries( -SCROW nStartRow, std::set& rStrings, bool bLimit ) const +SCROW nStartRow, std::set& rStrings) const { // Start at the specified row position, and collect all string values // going upward and downward directions in parallel. The start position @@ -2699,44 +2693,30 @@ bool ScColumn::GetDataEntries( bMoveDown = aItrDown.next(); // Find the next string cell position. bool bFound = false; -size_t nCellsSearched = 0; -while (bMoveUp || bMoveDown) +while (bMoveUp) { -if (bMoveUp) +// Get the current string and move up. +OUString aStr = aItrUp.get(); +if (!aStr.isEmpty()) { -// Get the current string and move up. -OUString aStr = aItrUp.get(); -if (!aStr.isEmpty()) -{ -bool bInserted = rStrings.insert(ScTypedStrData(aStr)).second; -if (bInserted && bLimit && rStrings.size() >= DATENT_MAX) -return true; // Maximum reached +if (rStrings.insert(ScTypedStrData(aStr)).second) bFound = true; -} - -if (bLimit && ++nCellsSearched >= DATENT_SEARCH) -return bFound; // max search cell count reached. - -bMoveUp = aItrUp.prev(); } -if
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - sc/qa
sc/qa/unit/tiledrendering/tiledrendering.cxx | 101 +++ 1 file changed, 101 insertions(+) New commits: commit 66833a391bf0b48d71d57ad884454d052c500732 Author: Dennis Francis AuthorDate: Wed May 5 15:30:32 2021 +0530 Commit: Dennis Francis CommitDate: Tue May 25 20:40:31 2021 +0200 tdf#142214: unit-tests for new behaviour of auto-complete Conflicts: sc/qa/unit/tiledrendering/tiledrendering.cxx Change-Id: I1255c50c33f4001a7d9932e0178b6539653eb61d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115133 Tested-by: Jenkins CollaboraOffice Reviewed-by: Luboš Luňák Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115467 Tested-by: Jenkins Reviewed-by: Dennis Francis (cherry picked from commit 06c360d4d27ab0dadfdcd5f9d4f0c87288d3cb75) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116084 diff --git a/sc/qa/unit/tiledrendering/tiledrendering.cxx b/sc/qa/unit/tiledrendering/tiledrendering.cxx index 8e32f6e57b97..7b7e480ec6b2 100644 --- a/sc/qa/unit/tiledrendering/tiledrendering.cxx +++ b/sc/qa/unit/tiledrendering/tiledrendering.cxx @@ -51,6 +51,7 @@ #include #include #include +#include using namespace css; @@ -117,6 +118,8 @@ public: void testSpellOnlineRenderParameter(); void testPasteIntoWrapTextCell(); void testSortAscendingDescending(); +void testAutoInputStringBlock(); +void testAutoInputExactMatch(); CPPUNIT_TEST_SUITE(ScTiledRenderingTest); @@ -166,6 +169,8 @@ public: CPPUNIT_TEST(testSpellOnlineRenderParameter); CPPUNIT_TEST(testPasteIntoWrapTextCell); CPPUNIT_TEST(testSortAscendingDescending); +CPPUNIT_TEST(testAutoInputStringBlock); +CPPUNIT_TEST(testAutoInputExactMatch); CPPUNIT_TEST_SUITE_END(); private: @@ -2435,6 +2440,102 @@ void ScTiledRenderingTest::testSortAscendingDescending() CPPUNIT_ASSERT_EQUAL(OString("rows"), aView.m_sInvalidateSheetGeometry); } +void lcl_typeCharsInCell(const std::string& aStr, SCCOL nCol, SCROW nRow, ScTabViewShell* pView, ScModelObj* pModelObj) +{ +pView->SetCursor(nCol, nRow); +for (const char& cChar : aStr) +{ +pModelObj->postKeyEvent(LOK_KEYEVENT_KEYINPUT, cChar, 0); +pModelObj->postKeyEvent(LOK_KEYEVENT_KEYUP, cChar, 0); +Scheduler::ProcessEventsToIdle(); +} +pModelObj->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, awt::Key::RETURN); +pModelObj->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, awt::Key::RETURN); +Scheduler::ProcessEventsToIdle(); +} + +void ScTiledRenderingTest::testAutoInputStringBlock() +{ +comphelper::LibreOfficeKit::setActive(); + +ScModelObj* pModelObj = createDoc("empty.ods"); +CPPUNIT_ASSERT(pModelObj); +ScTabViewShell* pView = dynamic_cast(SfxViewShell::Current()); +CPPUNIT_ASSERT(pView); +ScDocument* pDoc = pModelObj->GetDocument(); + +pDoc->SetString(ScAddress(0, 3, 0), "ABC"); // A4 +pDoc->SetString(ScAddress(0, 4, 0), "BAC"); // A5 +ScFieldEditEngine& rEE = pDoc->GetEditEngine(); +rEE.SetText("XYZ"); +pDoc->SetEditText(ScAddress(0, 5, 0), rEE.CreateTextObject()); // A6 +pDoc->SetString(ScAddress(0, 6, 0), "ZZZ"); // A7 + +ScAddress aA1(0, 0, 0); +lcl_typeCharsInCell("X", aA1.Col(), aA1.Row(), pView, pModelObj); // Type 'X' in A1 +CPPUNIT_ASSERT_EQUAL_MESSAGE("A1 should not autocomplete", OUString("X"), pDoc->GetString(aA1)); + +ScAddress aA3(0, 2, 0); // Adjacent to the string "superblock" A4:A7 +lcl_typeCharsInCell("X", aA3.Col(), aA3.Row(), pView, pModelObj); // Type 'X' in A3 +CPPUNIT_ASSERT_EQUAL_MESSAGE("A3 should autocomplete", OUString("XYZ"), pDoc->GetString(aA3)); + +ScAddress aA7(0, 6, 0); // Adjacent to the string "superblock" A4:A7 +lcl_typeCharsInCell("X", aA7.Col(), aA7.Row(), pView, pModelObj); // Type 'X' in A7 +CPPUNIT_ASSERT_EQUAL_MESSAGE("A7 should autocomplete", OUString("XYZ"), pDoc->GetString(aA7)); + +ScAddress aA10(0, 9, 0); +lcl_typeCharsInCell("X", aA10.Col(), aA10.Row(), pView, pModelObj); // Type 'X' in A10 +CPPUNIT_ASSERT_EQUAL_MESSAGE("A10 should not autocomplete", OUString("X"), pDoc->GetString(aA10)); +} + +void ScTiledRenderingTest::testAutoInputExactMatch() +{ +comphelper::LibreOfficeKit::setActive(); + +ScModelObj* pModelObj = createDoc("empty.ods"); +CPPUNIT_ASSERT(pModelObj); +ScTabViewShell* pView = dynamic_cast(SfxViewShell::Current()); +CPPUNIT_ASSERT(pView); +ScDocument* pDoc = pModelObj->GetDocument(); + +pDoc->SetString(ScAddress(0, 1, 0), "Simple"); // A2 +pDoc->SetString(ScAddress(0, 2, 0), "Simple"); // A3 +pDoc->SetString(ScAddress(0, 3, 0), "Sing"); // A4 +ScFieldEditEngine& rEE = pDoc->GetEditEngine(); +rEE.SetText("Case"); +pDoc->SetEditText(ScAddress(0, 4, 0), rEE.CreateTextObject()); // A5 +pDoc->SetString(ScAddress(0, 5, 0), "Time"); // A6 +pDoc->SetString(ScAddress(0, 6, 0), "Castle");
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - sc/qa sc/source
sc/qa/unit/ucalc.cxx| 19 --- sc/source/core/data/column3.cxx | 28 2 files changed, 36 insertions(+), 11 deletions(-) New commits: commit 7f36c9acc83d5e14a2db053839e0cb9f3968dcb2 Author: Dennis Francis AuthorDate: Fri May 7 16:32:52 2021 +0530 Commit: Dennis Francis CommitDate: Tue May 25 20:39:54 2021 +0200 tdf#142214: autocomplete: do not search across empty blocks Change-Id: Ia5b0be1eed2bf645fa1e53d71abc7b2e67dfaa0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115458 Tested-by: Jenkins Reviewed-by: Dennis Francis (cherry picked from commit ca2ec443893731093970914feb750b31ea13e47f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116083 Tested-by: Jenkins CollaboraOffice diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx index 5b339eba8f67..097f15acfad3 100644 --- a/sc/qa/unit/ucalc.cxx +++ b/sc/qa/unit/ucalc.cxx @@ -576,14 +576,22 @@ void Test::testDataEntries() m_pDoc->SetString(ScAddress(0,5,0), "Andy"); m_pDoc->SetString(ScAddress(0,6,0), "Bruce"); m_pDoc->SetString(ScAddress(0,7,0), "Charlie"); +m_pDoc->SetValue(ScAddress(0,8,0), 100); +m_pDoc->SetValue(ScAddress(0,9,0), 200); m_pDoc->SetString(ScAddress(0,10,0), "Andy"); +m_pDoc->SetValue(ScAddress(0,11,0), 1000); std::vector aEntries; -m_pDoc->GetDataEntries(0, 0, 0, aEntries); // Try at the very top. +m_pDoc->GetDataEntries(0, 0, 0, aEntries); // Try at the top. +std::vector::const_iterator it = aEntries.begin(); +CPPUNIT_ASSERT_MESSAGE("The entries should be empty.", bool(it == aEntries.end())); + +aEntries.clear(); +m_pDoc->GetDataEntries(0, 4, 0, aEntries); // Try at A5. // Entries are supposed to be sorted in ascending order, and are all unique. CPPUNIT_ASSERT_EQUAL(static_cast(3), aEntries.size()); -std::vector::const_iterator it = aEntries.begin(); +it = aEntries.begin(); CPPUNIT_ASSERT_EQUAL(OUString("Andy"), it->GetString()); ++it; CPPUNIT_ASSERT_EQUAL(OUString("Bruce"), it->GetString()); @@ -593,7 +601,7 @@ void Test::testDataEntries() CPPUNIT_ASSERT_MESSAGE("The entries should have ended here.", bool(it == aEntries.end())); aEntries.clear(); -m_pDoc->GetDataEntries(0, MAXROW, 0, aEntries); // Try at the very bottom. +m_pDoc->GetDataEntries(0, 12, 0, aEntries); // Try at A13. CPPUNIT_ASSERT_EQUAL(static_cast(3), aEntries.size()); // Make sure we get the same set of suggestions. @@ -606,6 +614,11 @@ void Test::testDataEntries() ++it; CPPUNIT_ASSERT_MESSAGE("The entries should have ended here.", bool(it == aEntries.end())); +aEntries.clear(); +m_pDoc->GetDataEntries(0, MAXROW, 0, aEntries); // Try at the bottom. +it = aEntries.begin(); +CPPUNIT_ASSERT_MESSAGE("The entries should be empty.", bool(it == aEntries.end())); + m_pDoc->DeleteTab(0); } diff --git a/sc/source/core/data/column3.cxx b/sc/source/core/data/column3.cxx index 69213b7fedbc..42acb311312c 100644 --- a/sc/source/core/data/column3.cxx +++ b/sc/source/core/data/column3.cxx @@ -2562,6 +2562,11 @@ public: return (maPos.first->type == sc::element_type_string || maPos.first->type == sc::element_type_edittext); } +bool isEmpty() const +{ +return maPos.first->type == sc::element_type_empty; +} + bool prev() { if (!has()) @@ -2569,7 +2574,7 @@ public: // Not in a string block. Move back until we hit a string block. while (!has()) { -if (maPos.first == miBeg) +if (isEmpty() || maPos.first == miBeg) return false; --maPos.first; // move to the preceding block. @@ -2595,6 +2600,10 @@ public: // Move to the last cell of the previous block. --maPos.first; maPos.second = maPos.first->size - 1; + +if (isEmpty()) +return false; + if (has()) break; } @@ -2609,6 +2618,9 @@ public: // Not in a string block. Move forward until we hit a string block. while (!has()) { +if (isEmpty()) +return false; + ++maPos.first; if (maPos.first == miEnd) return false; @@ -2630,6 +2642,10 @@ public: return false; maPos.second = 0; + +if (isEmpty()) +return false; + if (has()) break; } @@ -2671,16 +2687,12 @@ bool ScColumn::GetDataEntries( // going upward and downward directions in parallel. The start position // cell must be skipped. -StrCellIterator aItrUp(maCells, nStartRow, ()); +StrCellIterator aItrUp(maCells, nStartRow-1, ());
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - sc/source
sc/source/ui/app/inputhdl.cxx |1 + sc/source/ui/unoobj/docuno.cxx |5 - 2 files changed, 1 insertion(+), 5 deletions(-) New commits: commit f4635b01d0c1dbfca5031a73fe23bad0859671ca Author: Dennis Francis AuthorDate: Mon Apr 26 14:40:11 2021 +0530 Commit: Dennis Francis CommitDate: Tue May 25 20:39:10 2021 +0200 lok: Enable the "AutoInput" again. This partly reverts commit 65990058f041c3f1d280a69d411eb4ceacf5a721. Change-Id: I494e3ffa3c9824fd6668b1c7322b9cf08accac21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115456 Tested-by: Jenkins Reviewed-by: Dennis Francis (cherry picked from commit e2f771ffe8e82ba5a5001a71601abf3c45c56192) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116081 Tested-by: Jenkins CollaboraOffice diff --git a/sc/source/ui/app/inputhdl.cxx b/sc/source/ui/app/inputhdl.cxx index 1223999698c6..53065ba49f15 100644 --- a/sc/source/ui/app/inputhdl.cxx +++ b/sc/source/ui/app/inputhdl.cxx @@ -801,6 +801,7 @@ ScInputHandler::ScInputHandler() if (comphelper::LibreOfficeKit::isActive()) { ScInputHandler::bOptLoaded = true;// Evaluate App options +ScInputHandler::bAutoComplete = true; // Is set in KeyInput } } diff --git a/sc/source/ui/unoobj/docuno.cxx b/sc/source/ui/unoobj/docuno.cxx index c2250243b344..e0de184bfcea 100644 --- a/sc/source/ui/unoobj/docuno.cxx +++ b/sc/source/ui/unoobj/docuno.cxx @@ -1187,11 +1187,6 @@ void ScModelObj::initializeForTiledRendering(const css::uno::SequenceGetAppOptions() ); -aAppOptions.SetAutoComplete(false); -SC_MOD()->SetAppOptions(aAppOptions); - for (const beans::PropertyValue& rValue : rArguments) { if (rValue.Name == ".uno:SpellOnline" && rValue.Value.has()) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - sc/source
sc/source/ui/app/inputhdl.cxx | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) New commits: commit a386f785560f97469b94c3e2800e3eb79df05154 Author: Dennis Francis AuthorDate: Tue May 4 13:28:41 2021 +0530 Commit: Dennis Francis CommitDate: Tue May 25 20:39:32 2021 +0200 tdf#142214: show autocompletion only if there is... ...exactly one match Picking one from many matches by any logic requires the user to pay attention to the auto completed match and see if it the one they wanted. Instead show autocomplete only when there is exactly one match with what the user has already typed. Change-Id: If8f7e59fe905d3d472a5a5795f96374ec2d1a6e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115457 Tested-by: Jenkins Reviewed-by: Dennis Francis (cherry picked from commit f8039c6d645acb015a6c4e45000bbfd1311bfea3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116082 Tested-by: Jenkins CollaboraOffice diff --git a/sc/source/ui/app/inputhdl.cxx b/sc/source/ui/app/inputhdl.cxx index 53065ba49f15..e2d0da10537e 100644 --- a/sc/source/ui/app/inputhdl.cxx +++ b/sc/source/ui/app/inputhdl.cxx @@ -163,10 +163,13 @@ OUString getExactMatch(const ScTypedCaseStrSet& rDataSet, const OUString& rStrin ScTypedCaseStrSet::const_iterator findTextAll( const ScTypedCaseStrSet& rDataSet, ScTypedCaseStrSet::const_iterator const & itPos, -const OUString& rStart, ::std::vector< OUString > , bool bBack) +const OUString& rStart, ::std::vector< OUString > , bool bBack, size_t nMax = 0) { rResultVec.clear(); // clear contents +if (!rDataSet.size()) +return rDataSet.end(); + size_t nCount = 0; ScTypedCaseStrSet::const_iterator retit; if ( bBack ) // Backwards @@ -217,6 +220,8 @@ ScTypedCaseStrSet::const_iterator findTextAll( std::advance(retit, nPos); } ++nCount; +if (nMax > 0 && nCount >= nMax) +break; } } else // Forwards @@ -249,6 +254,8 @@ ScTypedCaseStrSet::const_iterator findTextAll( if ( nCount == 0 ) retit = it; // remember first match iterator ++nCount; +if (nMax > 0 && nCount >= nMax) +break; } } @@ -1965,12 +1972,16 @@ void ScInputHandler::UseColData() // When typing if (aText.isEmpty()) return; +std::vector< OUString > aResultVec; OUString aNew; miAutoPosColumn = pColumnData->end(); -miAutoPosColumn = findText(*pColumnData, miAutoPosColumn, aText, aNew, false); -if (miAutoPosColumn == pColumnData->end()) +miAutoPosColumn = findTextAll(*pColumnData, miAutoPosColumn, aText, aResultVec, false, 2); +bool bShowCompletion = (aResultVec.size() == 1); +if (!bShowCompletion) return; +assert(miAutoPosColumn != pColumnData->end()); +aNew = aResultVec[0]; // Strings can contain line endings (e.g. due to dBase import), // which would result in multiple paragraphs here, which is not desirable. //! Then GetExactMatch doesn't work either ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: i18npool/source
i18npool/source/textconversion/textconversion_ko.cxx | 23 --- 1 file changed, 10 insertions(+), 13 deletions(-) New commits: commit 62be589df821687b36188e977b163fd58599c9ff Author: Jan-Marek Glogowski AuthorDate: Mon May 17 16:53:31 2021 +0200 Commit: Jan-Marek Glogowski CommitDate: Tue May 25 20:05:19 2021 +0200 Don't ignore GCC warnings for static builds Instead simply (and correctly) test the function pointers in the static build case. Change-Id: I01b3397f40671464b1d2cb472447d8530b996d21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116117 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski diff --git a/i18npool/source/textconversion/textconversion_ko.cxx b/i18npool/source/textconversion/textconversion_ko.cxx index d57495a546f1..e03286b772d7 100644 --- a/i18npool/source/textconversion/textconversion_ko.cxx +++ b/i18npool/source/textconversion/textconversion_ko.cxx @@ -105,7 +105,6 @@ static sal_Int16 checkScriptType(sal_Unicode c) } #ifdef DISABLE_DYNLOADING - extern "C" { const sal_Unicode* getHangul2HanjaData(); @@ -115,7 +114,6 @@ const sal_uInt16* getHanja2HangulIndex(); const sal_Unicode* getHanja2HangulData(); } - #endif Sequence< OUString > @@ -129,15 +127,12 @@ TextConversion_ko::getCharConversions(const OUString& aText, sal_Int32 nStartPos sal_Int16 (*getHangul2HanjaIndexCount)() = reinterpret_cast(getFunctionBySymbol("getHangul2HanjaIndexCount")); const sal_uInt16* (*getHanja2HangulIndex)() = reinterpret_cast(getFunctionBySymbol("getHanja2HangulIndex")); const sal_Unicode* (*getHanja2HangulData)() = reinterpret_cast(getFunctionBySymbol("getHanja2HangulData")); + +if (toHanja && getHangul2HanjaIndex && getHangul2HanjaIndexCount && getHangul2HanjaData) #else -#pragma GCC diagnostic push -#ifdef __clang__ -#pragma GCC diagnostic warning "-Wbool-conversions" -#else -#pragma GCC diagnostic warning "-Waddress" -#endif +if (toHanja) #endif -if (toHanja && getHangul2HanjaIndex && getHangul2HanjaIndexCount && getHangul2HanjaData) { +{ ch = aText[nStartPos]; const Hangul_Index *Hangul_ko = getHangul2HanjaIndex(); sal_Int16 top = getHangul2HanjaIndexCount(); @@ -160,7 +155,12 @@ TextConversion_ko::getCharConversions(const OUString& aText, sal_Int32 nStartPos break; } } -} else if (! toHanja && getHanja2HangulIndex && getHanja2HangulData) +} +#ifndef DISABLE_DYNLOADING +else if (!toHanja && getHanja2HangulIndex && getHanja2HangulData) +#else +else if (!toHanja) +#endif { std::unique_ptr newStr(new sal_Unicode[nLength+1]); sal_Int32 count = 0; @@ -182,9 +182,6 @@ TextConversion_ko::getCharConversions(const OUString& aText, sal_Int32 nStartPos output[0] = OUString(newStr.get(), count); } } -#if defined(DISABLE_DYNLOADING) -#pragma GCC diagnostic pop -#endif return output; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Makefile.in
Makefile.in | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) New commits: commit 70e4c65058a76131235cd04b64231c403cbe74f3 Author: Jan-Marek Glogowski AuthorDate: Thu May 20 15:51:21 2021 +0200 Commit: Jan-Marek Glogowski CommitDate: Tue May 25 20:04:54 2021 +0200 Install GDB pretty printers into cross-toolset Change-Id: Id42dd694514e104d03c649a19788b5c192ec35a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116116 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski diff --git a/Makefile.in b/Makefile.in index 8e56cd47b28b..b75d07bd137b 100644 --- a/Makefile.in +++ b/Makefile.in @@ -280,9 +280,8 @@ bootstrap: check-if-root compilerplugins # Note: this will pipe through all gbuild targets to ... gbuild # with some translations like "check"->"unitcheck subsequentcheck uicheck" for historic reasons # -build: bootstrap fetch $(if $(CROSS_COMPILING),cross-toolset) \ -$(if $(filter check,$(MAKECMDGOALS)),$(if $(COMPILER_PLUGINS),$(if $(LODE_HOME),clang-format-check))) \ -install-gdb-printers +build: bootstrap fetch $(if $(CROSS_COMPILING),cross-toolset,install-gdb-printers) \ +$(if $(filter check,$(MAKECMDGOALS)),$(if $(COMPILER_PLUGINS),$(if $(LODE_HOME),clang-format-check))) $(MAKE) $(PARALLELISM_OPTION) $(IWYU_OPTION) $(GMAKE_OPTIONS) -f $(SRCDIR)/Makefile.gbuild $(build_goal) ifeq ($(OS),iOS) $(MAKE) $(PARALLELISM_OPTION) $(GMAKE_OPTIONS) ios @@ -293,7 +292,7 @@ build-non-l10n-only build-l10n-only build-nocheck check debugrun translations pa help showmodules gbuildtojson: $(MAKE) $(PARALLELISM_OPTION) $(GMAKE_OPTIONS) -f $(SRCDIR)/Makefile.gbuild $@ -cross-toolset: bootstrap fetch +cross-toolset: bootstrap fetch install-gdb-printers # fetch again in case there are externals only needed on build platform ifneq ($(OS),iOS) $(MAKE) gb_Side=build $(PARALLELISM_OPTION) $(GMAKE_OPTIONS) -f $(BUILDDIR)/Makefile fetch @@ -302,6 +301,10 @@ endif install-gdb-printers: ifneq ($(filter-out WNT MACOSX iOS,$(OS)),) +ifneq ($(INSTDIR_FOR_BUILD),$(INSTDIR)) + mkdir -p $(INSTDIR_FOR_BUILD) + $(SRCDIR)/solenv/bin/install-gdb-printers -a $(INSTDIR_FOR_BUILD) -c +endif mkdir -p $(INSTDIR) $(SRCDIR)/solenv/bin/install-gdb-printers -a $(INSTDIR) -c endif ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: desktop/CppunitTest_desktop_lib.mk desktop/qa
desktop/CppunitTest_desktop_lib.mk |6 ++ desktop/qa/desktop_lib/test_desktop_lib.cxx | 13 + 2 files changed, 19 insertions(+) New commits: commit a2a98f62182561444d7841f0908d7423ab595675 Author: Noel Grandin AuthorDate: Tue May 25 13:31:32 2021 +0200 Commit: Noel Grandin CommitDate: Tue May 25 19:56:32 2021 +0200 fix some crypto leaks Change-Id: I8f0eddd5ec82200dca374c2191ed5ac28c66089a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116100 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/desktop/CppunitTest_desktop_lib.mk b/desktop/CppunitTest_desktop_lib.mk index 68a7ca8f2aed..4e5ff292102b 100644 --- a/desktop/CppunitTest_desktop_lib.mk +++ b/desktop/CppunitTest_desktop_lib.mk @@ -38,6 +38,12 @@ $(eval $(call gb_CppunitTest_use_externals,desktop_lib, \ boost_headers \ cairo \ )) +ifeq ($(TLS),NSS) +$(eval $(call gb_CppunitTest_use_externals,desktop_lib,\ + plc4 \ + nss3 \ +)) +endif $(eval $(call gb_CppunitTest_set_include,desktop_lib,\ -I$(SRCDIR)/desktop/inc \ diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx b/desktop/qa/desktop_lib/test_desktop_lib.cxx index 13370261a0fc..2a26b04dcfa0 100644 --- a/desktop/qa/desktop_lib/test_desktop_lib.cxx +++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx @@ -7,6 +7,7 @@ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ +#include #include #include @@ -59,6 +60,10 @@ #include +#if USE_TLS_NSS +#include +#endif + using namespace com::sun::star; using namespace desktop; @@ -95,6 +100,7 @@ public: m_nTrackChanges(0) { } +~DesktopLOKTest(); void readFileIntoByteVector( std::u16string_view sFilename, std::vector & rByteVector); @@ -290,6 +296,13 @@ public: std::unique_ptr m_pDocument; }; +DesktopLOKTest::~DesktopLOKTest() +{ +#if USE_TLS_NSS +NSS_Shutdown(); +#endif +} + static Control* GetFocusControl(vcl::Window const * pParent) { sal_uInt16 nChildren = pParent->GetChildCount(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 113339] [META] Updates bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=113339 V Stuart Foote changed: What|Removed |Added Depends on||142485 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=142485 [Bug 142485] Check for Updates Not Packager-Aware -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142485] Check for Updates Not Packager-Aware
https://bugs.documentfoundation.org/show_bug.cgi?id=142485 V Stuart Foote changed: What|Removed |Added Blocks||113339 Assignee|michael.warner.ut+libreoffi |libreoffice-b...@lists.free |c...@gmail.com|desktop.org Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=113339 [Bug 113339] [META] Updates bug tracker -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142478] [CRASH] searching on slide notes will crash Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=142478 --- Comment #7 from Julien Nabet --- Created attachment 172337 --> https://bugs.documentfoundation.org/attachment.cgi?id=172337=edit Valgrind trace -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118637] EXPORT: XHTML: text missing after formula
https://bugs.documentfoundation.org/show_bug.cgi?id=118637 BogdanB changed: What|Removed |Added Status|RESOLVED|VERIFIED CC||buzea.bog...@libreoffice.or ||g --- Comment #11 from BogdanB --- The text is inline in Version: 7.2.0.0.alpha1+ / LibreOffice Community Build ID: 42d2b2d55a27f11153ea1713737d93540a19211d CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142486] FILEOPEN DOCX margin wrong in wrap 'Square' if shadow present
https://bugs.documentfoundation.org/show_bug.cgi?id=142486 --- Comment #1 from Regina Henschel --- Created attachment 172336 --> https://bugs.documentfoundation.org/attachment.cgi?id=172336=edit Compare LO and Word -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142486] New: FILEOPEN DOCX margin wrong in wrap 'Square' if shadow present
https://bugs.documentfoundation.org/show_bug.cgi?id=142486 Bug ID: 142486 Summary: FILEOPEN DOCX margin wrong in wrap 'Square' if shadow present Product: LibreOffice Version: 5.1.0.3 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rb.hensc...@t-online.de Created attachment 172335 --> https://bugs.documentfoundation.org/attachment.cgi?id=172335=edit Document with shadow in several distancies Open attached document. It has shapes with wrap "Square" and there a left wrap distance to text of 36px. The shapes have shadow enabled which goes to the left (180° in UI of Word). The shadow distance varies, 0pt, 8pt, 21pt and 54pt. The white part of the wrap area should be the same in all four examples, because they all have the same distance to text. But the white area increases with the shadow distance. It looks as if the shadow distance is applied twice. >From versions on my PC, I see the error first in Version: 5.1.0.1.0+ Build-ID: 928a7a3e92e085a880ecf0d3ad5e40d41b7779bf CPU Threads: 8; OS Version: Windows 6.2; UI Render: default; TinderBox: Win-x86@62-merge-TDF, Branch:libreoffice-5-1, Time: 2016-01-13_00:08:26 Gebietsschema: de-DE (en_US) The rendering is OK in Version: 4.4.7.2 Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600 Locale: en_US -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141651] INDEX: Table of figures Hyperlink points to caption, should point to parent frame
https://bugs.documentfoundation.org/show_bug.cgi?id=141651 --- Comment #12 from Dieter --- (In reply to demo4 from comment #11) > > So it should be possible to get the same result with an index entry > How it is possible? Sorry, perhaps my comment was not correct enough. "It should be possible to get the same result" = It should be possible for a developer to change behaviour of link from Table of Figure that it behaves like link from a cross reference -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 141651] INDEX: Table of figures Hyperlink points to caption, should point to parent frame
https://bugs.documentfoundation.org/show_bug.cgi?id=141651 --- Comment #12 from Dieter --- (In reply to demo4 from comment #11) > > So it should be possible to get the same result with an index entry > How it is possible? Sorry, perhaps my comment was not correct enough. "It should be possible to get the same result" = It should be possible for a developer to change behaviour of link from Table of Figure that it behaves like link from a cross reference -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 142469] SSH Keys for remote files
https://bugs.documentfoundation.org/show_bug.cgi?id=142469 --- Comment #2 from Steve --- (In reply to Uwe Auer from comment #1) > (In reply to Steve from comment #0) > > Description: > > I did a search to make sure this hadn't been posted yet, and it has, but > > back in October of 2018 (May 2021 as of this posting): > > https://bugs.documentfoundation.org/show_bug.cgi?id=119582#c1 > > > > ... and that's why this bug report is a duplicate of tdf#119582. > > *** This bug has been marked as a duplicate of bug 119582 *** Sometimes reminders can be useful. Duplicate status accepted. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/wasm' - config_host.mk.in cui/Library_cui.mk cui/source RepositoryExternal.mk solenv/gbuild writerperfect/Library_wpftwriter.mk writerperfect/source
RepositoryExternal.mk |2 config_host.mk.in |1 cui/Library_cui.mk |2 cui/source/factory/dlgfact.cxx |2 cui/source/factory/dlgfact.hxx |2 solenv/gbuild/gbuild.mk|1 writerperfect/Library_wpftwriter.mk| 11 ++ writerperfect/source/writer/wpftwriter.component | 30 --- writerperfect/source/writer/wpftwriter.extended2.component | 51 + 9 files changed, 67 insertions(+), 35 deletions(-) New commits: commit bfee2970a79e10c72978598b53e032719cccdb07 Author: Armin Le Grand (Allotropia) AuthorDate: Tue May 25 18:47:54 2021 +0200 Commit: Armin Le Grand (Allotropia) CommitDate: Tue May 25 18:47:54 2021 +0200 Wasm strip some SW exports & corrections Change-Id: I4dae3fc978d082215e780a371e0442d6f3687237 diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk index 7fe8b624d4ef..9750e4026b45 100644 --- a/RepositoryExternal.mk +++ b/RepositoryExternal.mk @@ -577,7 +577,7 @@ $(call gb_ExternalProject_use_external_project,$(1),hunspell) endef -endif # ENABLE_WASM_STRIP_EXTRA +endif # ENABLE_WASM_STRIP_HUNSPELL endif # SYSTEM_HUNSPELL diff --git a/config_host.mk.in b/config_host.mk.in index 5a17772744d4..a885166aa226 100644 --- a/config_host.mk.in +++ b/config_host.mk.in @@ -217,6 +217,7 @@ export ENABLE_WASM_STRIP_LOCALES=@ENABLE_WASM_STRIP@ export ENABLE_WASM_STRIP_GUESSLANG=@ENABLE_WASM_STRIP@ export ENABLE_WASM_STRIP_HUNSPELL=@ENABLE_WASM_STRIP@ export ENABLE_WASM_STRIP_PREMULTIPLY=@ENABLE_WASM_STRIP@ +export ENABLE_WASM_STRIP_SWEXPORTS=@ENABLE_WASM_STRIP@ export ENABLE_WERROR=@ENABLE_WERROR@ export ENDIANNESS=@ENDIANNESS@ export EPM=@EPM@ diff --git a/cui/Library_cui.mk b/cui/Library_cui.mk index dda524c97c41..5c7a68051439 100644 --- a/cui/Library_cui.mk +++ b/cui/Library_cui.mk @@ -99,7 +99,7 @@ $(eval $(call gb_Library_add_exception_objects,cui,\ )) endif -ifneq ($(ENABLE_WASM_STRIP_EXTRA),TRUE) +ifneq ($(ENABLE_WASM_STRIP_HUNSPELL),TRUE) $(eval $(call gb_Library_add_exception_objects,cui,\ cui/source/dialogs/hyphen \ )) diff --git a/cui/source/factory/dlgfact.cxx b/cui/source/factory/dlgfact.cxx index 7c1dce6e2e35..eb697277b936 100644 --- a/cui/source/factory/dlgfact.cxx +++ b/cui/source/factory/dlgfact.cxx @@ -1081,7 +1081,7 @@ VclPtr AbstractDialogFactory_Impl::CreateThesaurusDialo return VclPtr::Create(std::make_shared(pParent, xThesaurus, rWord, nLanguage)); } -#ifndef ENABLE_WASM_STRIP_EXTRA +#ifndef ENABLE_WASM_STRIP_HUNSPELL VclPtr AbstractDialogFactory_Impl::CreateHyphenWordDialog(weld::Widget* pParent, const OUString , LanguageType nLang, css::uno::Reference< css::linguistic2::XHyphenator > , diff --git a/cui/source/factory/dlgfact.hxx b/cui/source/factory/dlgfact.hxx index 9e1475b74fce..102c1b9d8fd3 100644 --- a/cui/source/factory/dlgfact.hxx +++ b/cui/source/factory/dlgfact.hxx @@ -798,7 +798,7 @@ public: css::uno::Reference xThesaurus, const OUString , LanguageType nLanguage) override; -#ifndef ENABLE_WASM_STRIP_EXTRA +#ifndef ENABLE_WASM_STRIP_HUNSPELL virtual VclPtr CreateHyphenWordDialog(weld::Widget*, const OUString , LanguageType nLang, css::uno::Reference< css::linguistic2::XHyphenator > , diff --git a/solenv/gbuild/gbuild.mk b/solenv/gbuild/gbuild.mk index 2acbc0e73d07..e96168f52cc4 100644 --- a/solenv/gbuild/gbuild.mk +++ b/solenv/gbuild/gbuild.mk @@ -238,6 +238,7 @@ gb_GLOBALDEFS += -DENABLE_WASM_STRIP_LOCALES gb_GLOBALDEFS += -DENABLE_WASM_STRIP_GUESSLANG gb_GLOBALDEFS += -DENABLE_WASM_STRIP_HUNSPELL gb_GLOBALDEFS += -DENABLE_WASM_STRIP_PREMULTIPLY +gb_GLOBALDEFS += -DENABLE_WASM_STRIP_SWEXPORTS endif ifeq ($(gb_ENABLE_DBGUTIL),$(true)) diff --git a/writerperfect/Library_wpftwriter.mk b/writerperfect/Library_wpftwriter.mk index 516e96770c3c..90ffa4b5cd56 100644 --- a/writerperfect/Library_wpftwriter.mk +++ b/writerperfect/Library_wpftwriter.mk @@ -30,6 +30,10 @@ ifneq ($(ENABLE_WASM_STRIP_EPUB),TRUE) $(eval $(call gb_Library_set_componentfile,wpftwriter,writerperfect/source/writer/wpftwriter.extended)) endif +ifneq ($(ENABLE_WASM_STRIP_SWEXPORTS),TRUE) +$(eval $(call gb_Library_set_componentfile,wpftwriter,writerperfect/source/writer/wpftwriter.extended2)) +endif + $(eval $(call gb_Library_use_sdk_api,wpftwriter)) $(eval $(call gb_Library_use_common_precompiled_header,wpftwriter)) @@ -89,14 +93,19 @@ $(eval $(call gb_Library_add_exception_objects,wpftwriter,\ )) endif +ifneq
[Libreoffice-commits] core.git: configure.ac
configure.ac | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) New commits: commit 3ed71a09af4de19ac00b3b944b8db667e6613c92 Author: Jan-Marek Glogowski AuthorDate: Thu May 20 15:42:30 2021 +0200 Commit: Jan-Marek Glogowski CommitDate: Tue May 25 18:47:18 2021 +0200 configure: Replace tabs with spaces Change-Id: I417c734484481223f1779e0c555b4f3e16e10b23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116112 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski diff --git a/configure.ac b/configure.ac index 7d841bc63e0d..971d7ad440c5 100644 --- a/configure.ac +++ b/configure.ac @@ -1291,7 +1291,7 @@ if test "$_os" = "Emscripten"; then EMSCRIPTEN_ERROR=1 fi if test -z "$EMMAKEN_JUST_CONFIGURE"; then - AC_MSG_WARN(["\$EMMAKEN_JUST_CONFIGURE wasn't set by emconfigure. Prefix configure or use autogen.sh]) +AC_MSG_WARN(["\$EMMAKEN_JUST_CONFIGURE wasn't set by emconfigure. Prefix configure or use autogen.sh]) EMSCRIPTEN_ERROR=1 fi if test $EMSCRIPTEN_ERROR -ne 0; then @@ -2374,11 +2374,11 @@ AC_ARG_WITH(help, AC_ARG_WITH(omindex, AS_HELP_STRING([--with-omindex], - [Enable the support of xapian-omega index for online help.]) +[Enable the support of xapian-omega index for online help.]) [ Usage: --with-omindex=server prepare the pages for omindex - but let xapian-omega be built in server. - --with-omindex=noxap do not prepare online pages +but let xapian-omega be built in server. +--with-omindex=noxap do not prepare online pages for xapian-omega ], ,) @@ -10989,17 +10989,17 @@ if test "$with_system_box2d" = "yes"; then AC_CHECK_HEADER(box2d/box2d.h, [BOX2D_H_FOUND='TRUE'], [BOX2D_H_FOUND='FALSE']) if test "$BOX2D_H_FOUND" = "TRUE"; then # 2.4.0+ - _BOX2D_LIB=box2d - AC_DEFINE(BOX2D_HEADER,) +_BOX2D_LIB=box2d +AC_DEFINE(BOX2D_HEADER,) else - # fail this. there's no other alternative to check when we are here. - AC_CHECK_HEADER([Box2D/Box2D.h], [], - [AC_MSG_ERROR(box2d headers not found.)]) - _BOX2D_LIB=Box2D - AC_DEFINE(BOX2D_HEADER,) +# fail this. there's no other alternative to check when we are here. +AC_CHECK_HEADER([Box2D/Box2D.h], [], +[AC_MSG_ERROR(box2d headers not found.)]) +_BOX2D_LIB=Box2D +AC_DEFINE(BOX2D_HEADER,) fi AC_CHECK_LIB([$_BOX2D_LIB], [main], [:], - [ AC_MSG_ERROR(box2d library not found.) ], []) +[ AC_MSG_ERROR(box2d library not found.) ], []) BOX2D_LIBS=-l$_BOX2D_LIB AC_LANG_POP([C++]) BOX2D_CFLAGS=$(printf '%s' "$BOX2D_CFLAGS" | sed -e "s/-I/${ISYSTEM?}/g") @@ -12654,7 +12654,7 @@ then if test ! -f "$QT5_PLATFORMS_SRCDIR"/wasm_shell.html ; then QT5_PLATFORMS_SRCDIR="${QT5_PLATFORMS_SRCDIR/plugins/src\/plugins}/wasm" fi - if test ! -f "${qt5_platformsdir}"/libqwasm.a -o ! -f "$QT5_PLATFORMS_SRCDIR"/wasm_shell.html; then +if test ! -f "${qt5_platformsdir}"/libqwasm.a -o ! -f "$QT5_PLATFORMS_SRCDIR"/wasm_shell.html; then AC_MSG_ERROR([No Qt5 WASM QPA plugin found in ${qt5_platformsdir} or ${QT5_PLATFORMS_SRCDIR}]) fi fi ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: io/Executable_io-testconnection.mk
io/Executable_io-testconnection.mk | 36 1 file changed, 36 insertions(+) New commits: commit 81fdfa4dbfaaae322da5c3896f1f46aa6606ce14 Author: Stephan Bergmann AuthorDate: Tue May 25 16:19:43 2021 +0200 Commit: Stephan Bergmann CommitDate: Tue May 25 18:45:50 2021 +0200 Add forgotten io/Executable_io-testconnection.mk ...missing from ef88aa5e7400769c0a17c28e66b1ee957c2f667e "Resurrect io testconnection executable" Change-Id: I4a41088f1c27cfbc1275a9c00f8c59ec60898ec2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116106 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/io/Executable_io-testconnection.mk b/io/Executable_io-testconnection.mk new file mode 100644 index ..8abfcd3ddeee --- /dev/null +++ b/io/Executable_io-testconnection.mk @@ -0,0 +1,36 @@ +# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t; fill-column: 100 -*- +# +# This file is part of the LibreOffice project. +# +# This Source Code Form is subject to the terms of the Mozilla Public +# License, v. 2.0. If a copy of the MPL was not distributed with this +# file, You can obtain one at http://mozilla.org/MPL/2.0/. +# +# This file incorporates work covered by the following license notice: +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed +# with this work for additional information regarding copyright +# ownership. The ASF licenses this file to you under the Apache +# License, Version 2.0 (the "License"); you may not use this file +# except in compliance with the License. You may obtain a copy of +# the License at http://www.apache.org/licenses/LICENSE-2.0 . +# + +$(eval $(call gb_Executable_Executable,io-testconnection)) + +$(eval $(call gb_Executable_add_exception_objects,io-testconnection, \ +io/test/testconnection \ +)) + +$(eval $(call gb_Executable_use_api,io-testconnection, \ +udkapi \ +)) + +$(eval $(call gb_Executable_use_libraries,io-testconnection, \ +cppu \ +cppuhelper \ +sal \ +)) + +# vim: set noet sw=4 ts=4: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 40871] [FORMATTING] Impress and Draw should support character styles (and maybe more paragraph styles?)
https://bugs.documentfoundation.org/show_bug.cgi?id=40871 --- Comment #17 from Regina Henschel --- Created attachment 172334 --> https://bugs.documentfoundation.org/attachment.cgi?id=172334=edit Screenshot from PowerPoint -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 40871] [FORMATTING] Impress and Draw should support character styles (and maybe more paragraph styles?)
https://bugs.documentfoundation.org/show_bug.cgi?id=40871 --- Comment #17 from Regina Henschel --- Created attachment 172334 --> https://bugs.documentfoundation.org/attachment.cgi?id=172334=edit Screenshot from PowerPoint -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: configure.ac
configure.ac | 42 +- 1 file changed, 25 insertions(+), 17 deletions(-) New commits: commit 42a99a175581936b45d1c8d752b853c9ffa6da9b Author: Jan-Marek Glogowski AuthorDate: Mon May 17 17:58:00 2021 +0200 Commit: Jan-Marek Glogowski CommitDate: Tue May 25 18:40:02 2021 +0200 configure: Add gen to VCLplugs output And move all the output handling into a single place. Change-Id: Ia75440fc12a435b92239d7ec144be3d58e45d7d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116110 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski diff --git a/configure.ac b/configure.ac index faa4d810e8da..7d841bc63e0d 100644 --- a/configure.ac +++ b/configure.ac @@ -11406,7 +11406,7 @@ dnl AC_MSG_RESULT([sal_Int32]) dnl fi dnl === -dnl Test which vclplugs have to be built. +dnl Show which vclplugs will be built. dnl === R="" if test "$USING_X11" != TRUE; then @@ -11453,6 +11453,30 @@ if test "x$enable_kf5" = "xyes"; then fi AC_SUBST(ENABLE_KF5) +if test "x$USING_X11" = "xyes"; then +R="$R gen" +fi + +if test "$_os" = "WINNT"; then +R="$R win" +elif test "$_os" = "Darwin"; then +R="$R osx" +elif test "$_os" = "iOS"; then +R="ios (builtin)" +fi + +build_vcl_plugins="$R" +if test -z "$build_vcl_plugins"; then +build_vcl_plugins=" none" +fi +AC_MSG_NOTICE([VCLplugs to be built:${build_vcl_plugins}]) +VCL_PLUGIN_INFO=$R +AC_SUBST([VCL_PLUGIN_INFO]) + +dnl === +dnl Check for GTK libraries +dnl === + GTK3_CFLAGS="" GTK3_LIBS="" if test "x$enable_gtk3" = "xyes" -o "x$enable_gtk3_kde5" = "xyes"; then @@ -11507,22 +11531,6 @@ if test "$enable_introspection" = yes; then fi fi -if test "$_os" = "WINNT"; then -R="$R win" -elif test "$_os" = "Darwin"; then -R="$R osx" -elif test "$_os" = "iOS"; then -R="ios (builtin)" -fi - -build_vcl_plugins="$R" -if test -z "$build_vcl_plugins"; then -build_vcl_plugins="none" -fi -AC_MSG_NOTICE([VCLplugs to be built: $build_vcl_plugins]) -VCL_PLUGIN_INFO=$R -AC_SUBST([VCL_PLUGIN_INFO]) - dnl === dnl check for dbus support dnl === ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 142403] Differences in the 'sidebar settings' icon design
https://bugs.documentfoundation.org/show_bug.cgi?id=142403 --- Comment #8 from Adolfo Jayme --- I agree with NAB too; just wanted to highlight Jun’s point that having wildly different motifs/metaphors across icon themes has implications for documentation writing; one has to be careful to refer to icons by their position and not their shape, which may or may not represent a complication. So let’s be judicious in that aspect, while not erring in the side of monoculture (which is why I hate things like the stupid, user-hostile “Don’t theme my app” over at GNOME). -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 142403] Differences in the 'sidebar settings' icon design
https://bugs.documentfoundation.org/show_bug.cgi?id=142403 --- Comment #8 from Adolfo Jayme --- I agree with NAB too; just wanted to highlight Jun’s point that having wildly different motifs/metaphors across icon themes has implications for documentation writing; one has to be careful to refer to icons by their position and not their shape, which may or may not represent a complication. So let’s be judicious in that aspect, while not erring in the side of monoculture (which is why I hate things like the stupid, user-hostile “Don’t theme my app” over at GNOME). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 40871] [FORMATTING] Impress and Draw should support character styles (and maybe more paragraph styles?)
https://bugs.documentfoundation.org/show_bug.cgi?id=40871 --- Comment #16 from Regina Henschel --- (In reply to Heiko Tietze from comment #15) > Don't get any character formatting. Please attach a screenshot too. As I said, "not implemented in LibreOffice". Open it in PowerPoint. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 40871] [FORMATTING] Impress and Draw should support character styles (and maybe more paragraph styles?)
https://bugs.documentfoundation.org/show_bug.cgi?id=40871 --- Comment #16 from Regina Henschel --- (In reply to Heiko Tietze from comment #15) > Don't get any character formatting. Please attach a screenshot too. As I said, "not implemented in LibreOffice". Open it in PowerPoint. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 40871] [FORMATTING] Impress and Draw should support character styles (and maybe more paragraph styles?)
https://bugs.documentfoundation.org/show_bug.cgi?id=40871 --- Comment #15 from Heiko Tietze --- (In reply to Regina Henschel from comment #14) > It has a custom character style for yellow background color and one for > bold, and a custom paragraph style for first line indent. Don't get any character formatting. Please attach a screenshot too. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 40871] [FORMATTING] Impress and Draw should support character styles (and maybe more paragraph styles?)
https://bugs.documentfoundation.org/show_bug.cgi?id=40871 --- Comment #15 from Heiko Tietze --- (In reply to Regina Henschel from comment #14) > It has a custom character style for yellow background color and one for > bold, and a custom paragraph style for first line indent. Don't get any character formatting. Please attach a screenshot too. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise