[Libreoffice-commits] core.git: vcl/unx
vcl/unx/generic/print/bitmap_gfx.cxx | 69 +++
1 file changed, 23 insertions(+), 46 deletions(-)
New commits:
commit f1d68d82ae5a2de18708bf71a93e4d4a42dfa45b
Author: Noel Grandin
AuthorDate: Thu May 27 13:45:14 2021 +0200
Commit: Noel Grandin
CommitDate: Fri May 28 07:53:40 2021 +0200
no need to allocate these on the heap
and remove ByteEncoder because loplugin:unreffun
complains about ByteEncoder::EncodeByte
Change-Id: Iebc531fb7748cb9c6a83a8b4a574167a5aac58b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116257
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/vcl/unx/generic/print/bitmap_gfx.cxx
b/vcl/unx/generic/print/bitmap_gfx.cxx
index 830561b9677f..2d8649706060 100644
--- a/vcl/unx/generic/print/bitmap_gfx.cxx
+++ b/vcl/unx/generic/print/bitmap_gfx.cxx
@@ -38,31 +38,11 @@ PrinterBmp::~PrinterBmp()
{
}
-/* virtual base class */
-
-namespace {
-
-class ByteEncoder
-{
-private:
-
-public:
-
-virtual voidEncodeByte (sal_uInt8 nByte) = 0;
-virtual ~ByteEncoder () = 0;
-};
-
-}
-
-ByteEncoder::~ByteEncoder()
-{
-}
-
/* HexEncoder */
namespace {
-class HexEncoder : public ByteEncoder
+class HexEncoder
{
private:
@@ -74,9 +54,9 @@ private:
public:
explicitHexEncoder (osl::File* pFile);
-virtual ~HexEncoder () override;
+ ~HexEncoder ();
voidWriteAscii (sal_uInt8 nByte);
-virtual voidEncodeByte (sal_uInt8 nByte) override;
+voidEncodeByte (sal_uInt8 nByte);
voidFlushLine ();
};
@@ -132,7 +112,7 @@ HexEncoder::FlushLine ()
namespace {
-class Ascii85Encoder : public ByteEncoder
+class Ascii85Encoder
{
private:
@@ -152,8 +132,8 @@ private:
public:
explicitAscii85Encoder (osl::File* pFile);
-virtual ~Ascii85Encoder () override;
-virtual voidEncodeByte (sal_uInt8 nByte) override;
+virtual ~Ascii85Encoder ();
+virtual voidEncodeByte (sal_uInt8 nByte);
voidWriteAscii (sal_uInt8 nByte);
};
@@ -510,19 +490,17 @@ PrinterGfx::DrawPS1GrayImage (const PrinterBmp& rBitmap,
const tools::Rectangle&
WritePS (mpPageBody, pGrayImage.makeStringAndClear());
// image body
-std::unique_ptr xEncoder(new HexEncoder (mpPageBody));
+HexEncoder aEncoder(mpPageBody);
for (tools::Long nRow = rArea.Top(); nRow <= rArea.Bottom(); nRow++)
{
for (tools::Long nColumn = rArea.Left(); nColumn <= rArea.Right();
nColumn++)
{
unsigned char nByte = rBitmap.GetPixelGray (nRow, nColumn);
-xEncoder->EncodeByte (nByte);
+aEncoder.EncodeByte (nByte);
}
}
-xEncoder.reset();
-
WritePS (mpPageBody, "\n");
}
@@ -587,16 +565,15 @@ PrinterGfx::writePS2Colorspace(const PrinterBmp& rBitmap,
psp::ImageType nType)
psp::appendStr ("\npsp_lzwstring\n", pImage);
WritePS (mpPageBody, pImage.makeStringAndClear());
-std::unique_ptr xEncoder(new LZWEncoder(mpPageBody));
+LZWEncoder aEncoder(mpPageBody);
for (sal_uInt32 i = 0; i < nSize; i++)
{
PrinterColor aColor = rBitmap.GetPaletteColor(i);
-xEncoder->EncodeByte (aColor.GetRed());
-xEncoder->EncodeByte (aColor.GetGreen());
-xEncoder->EncodeByte (aColor.GetBlue());
+aEncoder.EncodeByte (aColor.GetRed());
+aEncoder.EncodeByte (aColor.GetGreen());
+aEncoder.EncodeByte (aColor.GetBlue());
}
-xEncoder.reset();
WritePS (mpPageBody, "pop ] setcolorspace\n");
}
@@ -611,14 +588,14 @@ PrinterGfx::DrawPS2GrayImage (const PrinterBmp& rBitmap,
const tools::Rectangle&
writePS2Colorspace(rBitmap, psp::ImageType::GrayScaleImage);
writePS2ImageHeader(rArea, psp::ImageType::GrayScaleImage);
-std::unique_ptr xEncoder(new LZWEncoder(mpPageBody));
+LZWEncoder aEncoder(mpPageBody);
for (tools::Long nRow = rArea.Top(); nRow <= rArea.Bottom(); nRow++)
{
for (tools::Long nColumn = rArea.Left(); nColumn <= rArea.Right();
nColumn++)
{
unsigned char nByte = rBitmap.GetPixelGray (nRow, nColumn);
-xEncoder->EncodeByte (nByte);
+aEncoder.EncodeByte (nByte);
}
}
}
@@ -629,7 +606,7 @@ PrinterGfx::DrawPS2MonoImage (const PrinterBmp& rBitmap,
const tools::Rectangle&
writePS2Colorspace(rBitmap, psp::ImageType::MonochromeImage);
writePS2ImageHeader(rArea, psp::ImageType::MonochromeImage);
-std::unique_ptr xEncoder(new LZWEncoder(mpPageBody));
+LZWEncoder aEncoder(mpPageBody);
for (tools::Long nRow = rArea.Top(); nRow <= rArea.Bottom(); nRow++)
{
@@ -643,14 +620,14 @@ PrinterGfx::DrawPS2MonoImage (const PrinterBmp& rBitmap,
const
[Libreoffice-bugs] [Bug 117836] Missing colours in colour palette tonal in preview
https://bugs.documentfoundation.org/show_bug.cgi?id=117836 --- Comment #5 from Thomas Hackert --- (In reply to QA Administrators from comment #4) > Dear Thomas Hackert, > > To make sure we're focusing on the bugs that affect our users today, > LibreOffice QA is asking bug reporters and confirmers to retest open, > confirmed bugs which have not been touched for over a year. > > There have been thousands of bug fixes and commits since anyone checked on > this bug report. During that time, it's possible that the bug has been > fixed, or the details of the problem have changed. We'd really appreciate > your help in getting confirmation that the bug is still present. > > If you have time, please do the following: > > Test to see if the bug is still present with the latest version of > LibreOffice from https://www.libreoffice.org/download/ > > If the bug is present, please leave a comment that includes the information > from Help - About LibreOffice. > > If the bug is NOT present, please set the bug's Status field to > RESOLVED-WORKSFORME and leave a comment that includes the information from > Help - About LibreOffice. > > Please DO NOT > > Update the version field > Reply via email (please reply directly on the bug tracker) > Set the bug's Status field to RESOLVED - FIXED (this status has a particular > meaning that is not > appropriate in this case) > > > If you want to do more to help you can test to see if your issue is a > REGRESSION. To do so: > 1. Download and install oldest version of LibreOffice (usually 3.3 unless > your bug pertains to a feature added after 3.3) from > https://downloadarchive.documentfoundation.org/libreoffice/old/ > > 2. Test your bug > 3. Leave a comment with your results. > 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; > 4b. If the bug was not present in 3.3 - add 'regression' to keyword > > > Feel free to come ask questions or to say hello in our QA chat: > https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa > > Thank you for helping us make LibreOffice even better for everyone! > > Warm Regards, > QA Team > > MassPing-UntouchedBug Hello @ll, still reproducible with Version: 7.1.3.2 / LibreOffice Community Build ID: 10(Build:2) CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: kf5 Locale: de-DE (de_DE.UTF-8); UI: de-DE Ubuntu package version: 1:7.1.3-0ubuntu0.21.04.1 Calc: threaded Version: 7.1.4.1 / LibreOffice Community Build ID: f67b1ddedeb24fca1c5938e7cebfab73d708b35b CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: kf5 Locale: de-DE (de_DE.UTF-8); UI: de-DE Calc: threaded and Version: 7.2.0.0.alpha1 / LibreOffice Community Build ID: 94c1521be4ef12f195d08413d5e2134e07a49f85 CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: kf5 (cairo+xcb) Locale: de-DE (de_DE.UTF-8); UI: de-DE Calc: threaded sorry ... :( Have a nice day Thomas. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142266] HUD search does not match parent menu name
https://bugs.documentfoundation.org/show_bug.cgi?id=142266 --- Comment #5 from Mike Kaganski --- It is questionable if we need to match the *current menu position* - an element could even not be in a menu, and still be wanted in the results; or it could be under several menus (like showing tracked changes). No objections to using the menu position though - but in addition, it would be nice to have a cloud of "tags" associated with all UNO commands, which would be considered when matching user input, in addition to the name. This way, all relevant commands could get an "insert" tag attached, and be matched when user types that - and also that could allow adding tags that can't be achieved by any other means, like mentioning entries inside the dialogs which are opened by respective UNO command. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91874] A Search by function or keyword over main menu-- similar to SpotLight, Tell Me, or Ubuntu's HUD but native for LO GUI
https://bugs.documentfoundation.org/show_bug.cgi?id=91874 stragu changed: What|Removed |Added Depends on||142267 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=142267 [Bug 142267] HUD menu. Allow open files from Recent files -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142267] HUD menu. Allow open files from Recent files
https://bugs.documentfoundation.org/show_bug.cgi?id=142267 stragu changed: What|Removed |Added Blocks||91874 CC||stephane.guil...@member.fsf ||.org --- Comment #2 from stragu --- Reproducible in: Version: 7.2.0.0.alpha1+ / LibreOffice Community Build ID: a02d9e8de07de4ab9f586f82aed7a2e0413520cd CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-05-25_05:42:18 Calc: threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=91874 [Bug 91874] A Search by function or keyword over main menu-- similar to SpotLight, Tell Me, or Ubuntu's HUD but native for LO GUI -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142266] HUD search does not match parent menu name
https://bugs.documentfoundation.org/show_bug.cgi?id=142266 stragu changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||2532 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142532] Command Popup (HUD) search should return all items containing searched word regardless of its position
https://bugs.documentfoundation.org/show_bug.cgi?id=142532 stragu changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||2266 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91874] A Search by function or keyword over main menu-- similar to SpotLight, Tell Me, or Ubuntu's HUD but native for LO GUI
https://bugs.documentfoundation.org/show_bug.cgi?id=91874 stragu changed: What|Removed |Added Depends on||142266 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=142266 [Bug 142266] HUD search does not match parent menu name -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142266] HUD search does not match parent menu name
https://bugs.documentfoundation.org/show_bug.cgi?id=142266 stragu changed: What|Removed |Added Summary|HUD menu > Insert / Image |HUD search does not match ||parent menu name CC||stephane.guil...@member.fsf ||.org Blocks||91874 --- Comment #4 from stragu --- I guess the issue here is that the parent menu (in this case "Insert") is not matched. Only the last item in the "String / of / menu / breadcrumbs" is picked up. For example, searching for "insert" will not return everything under the "Insert /" menu. It will only return the functions that have a name that start with "Insert", for example "Insert / Insert Fontwork". A related issue is that the function is not matched if you don't start writing the name from the beginning, which is what Stuart alludes to in Comment 3. I have reported it in Bug 142532. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=91874 [Bug 91874] A Search by function or keyword over main menu-- similar to SpotLight, Tell Me, or Ubuntu's HUD but native for LO GUI -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91874] A Search by function or keyword over main menu-- similar to SpotLight, Tell Me, or Ubuntu's HUD but native for LO GUI
https://bugs.documentfoundation.org/show_bug.cgi?id=91874 stragu changed: What|Removed |Added Depends on||142532 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=142532 [Bug 142532] Command Popup (HUD) search should return all items containing searched word regardless of its position -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142532] Command Popup (HUD) search should return all items containing searched word regardless of its position
https://bugs.documentfoundation.org/show_bug.cgi?id=142532 stragu changed: What|Removed |Added CC||stephane.guil...@member.fsf ||.org Blocks||91874 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=91874 [Bug 91874] A Search by function or keyword over main menu-- similar to SpotLight, Tell Me, or Ubuntu's HUD but native for LO GUI -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142532] New: Command Popup (HUD) search should return all items containing searched word regardless of its position
https://bugs.documentfoundation.org/show_bug.cgi?id=142532 Bug ID: 142532 Summary: Command Popup (HUD) search should return all items containing searched word regardless of its position Product: LibreOffice Version: 7.2.0.0 alpha1+ Master Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: stephane.guil...@member.fsf.org Description: Currently, the HUD only returns the items that have a name starting with the search term. Steps to Reproduce: 1. Open Writer 2. Open the Command Popup (HUD) with the shortcut Ctrl + F1 3. Type "list" Actual Results: Only "List box" is returned. Expected Results: Other list items should be returned, including "Unordered list" and "Ordered list". Reproducible: Always User Profile Reset: No Additional Info: This is the case for any LO module that has the HUD: when searching, only the items that start with the search term show up, missing many relevant results. It results in a search experience that gives the user the impression that the HUD does not give access to many functions. Tested in: Version: 7.2.0.0.alpha1+ / LibreOffice Community Build ID: a02d9e8de07de4ab9f586f82aed7a2e0413520cd CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-05-25_05:42:18 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/sallayout.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 8a65d3e9ceb268f785c5b2b77e126bd62af567a3
Author: Mark Hung
AuthorDate: Thu May 13 23:57:31 2021 +0800
Commit: Mark Hung
CommitDate: Fri May 28 07:03:53 2021 +0200
vcl: handle fallback glyph offset for vertical writing.
When GenericSalLayout::MoveGlyph() is called from
MultiSalLayout::AdjustLayout(), new position is calculatd
by adding glyph advances ( i.e. glyph items' m_nNewWidth ).
To move the glyph, the moving offset should be calculated
based on the corresponding position, i.e. m_nXOffset v.s.
m_LinearPos.X().
Change-Id: I912d499f49f69f68d8388bc8677e6b47bfb6f066
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115926
Tested-by: Jenkins
Reviewed-by: Mark Hung
diff --git a/vcl/source/gdi/sallayout.cxx b/vcl/source/gdi/sallayout.cxx
index cde5cac31730..9f4757148b36 100644
--- a/vcl/source/gdi/sallayout.cxx
+++ b/vcl/source/gdi/sallayout.cxx
@@ -949,7 +949,7 @@ void GenericSalLayout::MoveGlyph( int nStart, tools::Long
nNewXPos )
if( pGlyphIter->IsRTLGlyph() )
nNewXPos += pGlyphIter->m_nNewWidth - pGlyphIter->origWidth();
// calculate the x-offset to the old position
-tools::Long nXDelta = nNewXPos - pGlyphIter->m_aLinearPos.getX();
+tools::Long nXDelta = nNewXPos - pGlyphIter->m_aLinearPos.getX() +
pGlyphIter->xOffset();
// adjust all following glyph positions if needed
if( nXDelta != 0 )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 140360] Provide option to turn off sidebar's minimum width
https://bugs.documentfoundation.org/show_bug.cgi?id=140360 --- Comment #9 from andis.lazd...@gmail.com --- If there is any progress with this? In 7.2 alpha sidebar still hopelessly takes 1/3 of screen. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142265] Missing Menue-Entries for hiding paragraphs.
https://bugs.documentfoundation.org/show_bug.cgi?id=142265 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142256] set the size the ordinary number suffixes in LibreOffice Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=142256 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142251] CALC URL link Button disappears when grouped columns are concealed
https://bugs.documentfoundation.org/show_bug.cgi?id=142251 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142250] [EDITING] Frozen Rows/Columns reset when unfolding an outline-group causes the border outside of window
https://bugs.documentfoundation.org/show_bug.cgi?id=142250 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137963] Envelope printing issues after Libre Office update
https://bugs.documentfoundation.org/show_bug.cgi?id=137963 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137963] Envelope printing issues after Libre Office update
https://bugs.documentfoundation.org/show_bug.cgi?id=137963 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138511] El menú de corrección automática tarda mucho en abrir
https://bugs.documentfoundation.org/show_bug.cgi?id=138511 --- Comment #2 from QA Administrators --- Dear Richard, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119628] EDITING: Firebird Embedded: error message when resetting auto increment a second time
https://bugs.documentfoundation.org/show_bug.cgi?id=119628 --- Comment #9 from QA Administrators --- Dear kam3don, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81397] FORMATTING: When Default cell style is modified, new sheets do not show correct row height since LO 4.2 change in row height
https://bugs.documentfoundation.org/show_bug.cgi?id=81397 --- Comment #13 from QA Administrators --- Dear garbagesafe, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53074] Index entry duplicated by copy and paste within source text of entry
https://bugs.documentfoundation.org/show_bug.cgi?id=53074 --- Comment #19 from QA Administrators --- Dear mike.hall, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52527] Background Colour for Fields is Used Incorrectly for Dotted Lines Tables of Contents
https://bugs.documentfoundation.org/show_bug.cgi?id=52527 --- Comment #13 from QA Administrators --- Dear Harald Koester, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125489] Slow start with AD users
https://bugs.documentfoundation.org/show_bug.cgi?id=125489 --- Comment #16 from QA Administrators --- Dear Vincent, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117836] Missing colours in colour palette tonal in preview
https://bugs.documentfoundation.org/show_bug.cgi?id=117836 --- Comment #4 from QA Administrators --- Dear Thomas Hackert, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103959] Merged cell contents do not overflow cell boundaries, but still affect print range calculations
https://bugs.documentfoundation.org/show_bug.cgi?id=103959 --- Comment #4 from QA Administrators --- Dear tmacalp, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142531] Online Help: include the css files for each individual language
https://bugs.documentfoundation.org/show_bug.cgi?id=142531 Kevin Suo changed: What|Removed |Added Summary|Online Help: Enable include |Online Help: include the |the css file for individual |css files for each |language|individual language -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142531] New: Online Help: Enable include the css file for individual language
https://bugs.documentfoundation.org/show_bug.cgi?id=142531 Bug ID: 142531 Summary: Online Help: Enable include the css file for individual language Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Documentation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: suokunl...@126.com CC: olivier.hal...@libreoffice.org The submodule "helpcontent2" contains specialized css files for each language. For instance, for Simplified Chinese language the css file is located at: helpcontent2/source/auxiliary/zh-CN/default.css. However, this language-specific css file is not used at all in the generated html files at build time, thus the generated help content only uses the css file in helpcontent2/help3xsl/default.css, as defined by the makefile helpcontent2/Package_html_static.mk. This makes the display of other languages (e.g. Simplified Chinese) ugly in the browser. To include language-specific css files, the language independent default css shouls still be reserved, thus in index.html it should be: whereas the css styles defined in the 2nd one (/default.css) can override those in the 1st one, which makes it possible for different languages to modify the css to make the pages of their language appear better. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 36447] FORMATTING HTML formatting problems with spacing and font size
https://bugs.documentfoundation.org/show_bug.cgi?id=36447 --- Comment #15 from stragu --- reproduced with: Version: 7.2.0.0.alpha1+ / LibreOffice Community Build ID: 4a9eef7849a75ba91806886ea9c96d114c8d56f9 CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-05-22_06:45:25 Calc: threaded On top of the three issues described, the border disappears because of duplicated style attributes, but I believe the issue might already be covered by Bug 132739. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142513] Wrong zoom directing within Calc's print preview
https://bugs.documentfoundation.org/show_bug.cgi?id=142513 --- Comment #5 from Jim Raykowski --- Looks like I got the zoom in/out reversed. Here is a fix for both print preview and calc canvas zooming: https://gerrit.libreoffice.org/c/core/+/116287 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137924] [KF5] UI not scaled correctly on HIDPI Wayland/KDE screens
https://bugs.documentfoundation.org/show_bug.cgi?id=137924 Nate Graham changed: What|Removed |Added CC||n...@kde.org --- Comment #4 from Nate Graham --- @Michael I have a true HiDPI screen and DE setup in KDE Plasma where everything generally works fine on Wayland (barring bugs like this, of course :) ), so I can track down for you which issues are only in seen in LO and which issues are quirks of a handmade testing setup. Gimmie a day or two... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137924] [KF5] UI not scaled correctly on HIDPI Wayland/KDE screens
https://bugs.documentfoundation.org/show_bug.cgi?id=137924 --- Comment #3 from mkleins...@gmail.com --- I am affected too. on HiDPI 4k screen wayland on laptop HP Spectre X360 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142524] Minor aesthetic change: Command search results should use triangle (▸) to indicate sequence
https://bugs.documentfoundation.org/show_bug.cgi?id=142524 Ming Hua changed: What|Removed |Added CC||ming.v@qq.com --- Comment #3 from Ming Hua --- (In reply to Heiko Tietze from comment #1) > Are you sure this character is defined in all fonts? FWIW, we are already using this character extensively in tip-of-the-day dialog. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142530] FILEOPEN PPTX: Bullet item animation don't work
https://bugs.documentfoundation.org/show_bug.cgi?id=142530 Ming Hua changed: What|Removed |Added CC||ming.v@qq.com Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 Summary|SLIDESHOW |FILEOPEN PPTX: Bullet item ||animation don't work --- Comment #1 from Ming Hua --- Can not reproduce with 7.0.6 on Windows 10: Version: 7.0.6.2 (x64) Build ID: 144abb84a525d8e30c9dbbefa69cbbf2d8d4ae3b CPU threads: 2; OS: Windows 10.0 Build 19041; UI render: default; VCL: win Locale: zh-CN (zh_CN); UI: en-US Calc: threaded Each bullet item show up when mouse is clicked. @Mike: Would you please provide more information about your system and LibreOffice installation? Paste the version information from "Help > About LibreOffice" dialog, and maybe also some information about your video card driver if it's not a common one. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142103] Japanese full-width characters: Should be cropped, if they are the first character
https://bugs.documentfoundation.org/show_bug.cgi?id=142103 --- Comment #8 from Ming Hua --- (In reply to Ming Hua from comment #7) > Again to the best of my knowledge, all current widely used (meaning the open > source ones, and the ones come with Windows or macOS operating system) > Chinese and Japanese fonts are "broken" in this regard. (In reply to DarkTrick from comment #3) > If you have a font installed, that does not reserve space for those certain > characters (like IPAPGothic ), you can manually set the first character to > that font. I've never used fonts by IPA before, only heard of their name. If this "proportional" IPAPGothic font suits you need, by all means set it as the default Asian font on your system. But my guess is that it also make those punctuation marks narrower even if they are not at the start of a line. And many users would find that undesirable. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142530] New: SLIDESHOW
https://bugs.documentfoundation.org/show_bug.cgi?id=142530 Bug ID: 142530 Summary: SLIDESHOW Product: LibreOffice Version: unspecified Hardware: Other OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: adsl9...@tpg.com.au Created attachment 172396 --> https://bugs.documentfoundation.org/attachment.cgi?id=172396=edit Single page with bullets On an Asus VivoBook laptop, PowerPoint file opens OK in Impress and goes into slideshow mode when F5 is pressed, but does not display result of mouse-clicks in slideshow, although it exits when end of bullets reached. The same file responds OK in PowerPoint. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106513] [Feature request] Optical margin alignment
https://bugs.documentfoundation.org/show_bug.cgi?id=106513 Ming Hua changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||2103 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142103] Japanese full-width characters: Should be cropped, if they are the first character
https://bugs.documentfoundation.org/show_bug.cgi?id=142103 Ming Hua changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||6513 --- Comment #7 from Ming Hua --- (In reply to DarkTrick from comment #6) > Thank you for your comment on this matter! > > From what you wrote and further "investigation", I guess I agree with your > statement. Don't get me wrong, I agree it's a valid concern and enhancement request, I just don't feel LibreOffice is the right place on the technology/software stack to solve this issue. FWIW, English/Latin-based text has more-or-less the same issue, usually called "hanging punctuation" or "optical margin alignment", see bug 106513. > That being said: Maybe there is some indirect way to prevent the problem ( I > don't know about technical details here, so I might go off on an impossible > tangent). As I said, I'm by no means an expert, so I'll just drop my 2 cents here, as a (somewhat) experienced Chinese user: > 1) > How does LibreOffice decide which fonts are used as standard? > Perhaps changing standard fonts to something, that works "as expected" in > each language is possible? LibreOffice is a bit different from most other word processing software here, in that it specify three different fonts for its text -- Western font, Asian (CJK, i.e. Chinese, Japanese, and Korean) font, and CTL (complex text layout, think Arabic, Hindi, etc.). See the Tools > Options > Language Settings > Languages dialog. To the best of my knowledge, there is no "default" CJK font defined in the default template, therefore no such "used as standard" font for Japanese text. There is a list of preferred font to fallback on for each language, but it depends on whether each of the fonts in that list is installed on your system, and therefore not reliable. > 2) > > and don't have proper metadata (kerning?) > Maybe let the user know, if the font is "broken", so they understand, that > some things might not work as expected? Again to the best of my knowledge, all current widely used (meaning the open source ones, and the ones come with Windows or macOS operating system) Chinese and Japanese fonts are "broken" in this regard. I guess most native Chinese and Japanese users just don't consider this issue a big deal (I personally don't, either). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104449] [META] DOCX (OOXML) textbox-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104449 Bug 104449 depends on bug 139571, which changed state. Bug 139571 Summary: Frame an content mismatch. Image goes to top page 1. Frame to page 2 (DOCX) https://bugs.documentfoundation.org/show_bug.cgi?id=139571 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139571] Frame an content mismatch. Image goes to top page 1. Frame to page 2 (DOCX)
https://bugs.documentfoundation.org/show_bug.cgi?id=139571 Gabor Kelemen changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED Blocks||104449 CC||arato.dan...@nisz.hu, ||kelem...@ubuntu.com, ||libreoff...@nisz.hu --- Comment #5 from Gabor Kelemen --- I can no longer reproduce this one in 7.1, since: https://git.libreoffice.org/core/+/c9eb53f200225f2ee6ca695e1326843a487aee51 author Daniel Arato (NISZ) Wed Oct 14 15:46:23 2020 +0200 committer László NémethTue Oct 27 13:27:55 2020 +0100 tdf#135198 sw editing: text box fell out of its shape *** This bug has been marked as a duplicate of bug 135198 *** Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104449 [Bug 104449] [META] DOCX (OOXML) textbox-related issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104449] [META] DOCX (OOXML) textbox-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104449 Gabor Kelemen changed: What|Removed |Added Depends on||139571 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=139571 [Bug 139571] Frame an content mismatch. Image goes to top page 1. Frame to page 2 (DOCX) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142528] TexMaths allow resize with selected text
https://bugs.documentfoundation.org/show_bug.cgi?id=142528 V Stuart Foote changed: What|Removed |Added URL|https://sourceforge.net/p/t | |exmaths/bugs| Resolution|--- |NOTOURBUG Status|UNCONFIRMED |RESOLVED --- Comment #2 from V Stuart Foote --- TexMaths feature requests are here: https://sourceforge.net/p/texmaths/feature-requests/ bug reports are here: https://sourceforge.net/p/texmaths/bugs -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142344] Navigator jumps to table while navigating over headings
https://bugs.documentfoundation.org/show_bug.cgi?id=142344 --- Comment #4 from Jim Raykowski --- Thanks Marina for bibisecting the change of behaviour to the enhancement done for bug 95378 Writer Navigator document content tracking. This patch adds document content tracking for tables, frames, images, OLE objects and drawing objects. Since the heading is in a table the Navigator tracks to the table. I will look at how to make the Navigator track the heading instead of the table in this case. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104522] [META] DOCX (OOXML) header & footer-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104522 Bug 104522 depends on bug 133706, which changed state. Bug 133706 Summary: FILESAVE DOCX: Header footer text gone after export https://bugs.documentfoundation.org/show_bug.cgi?id=133706 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133706] FILESAVE DOCX: Header footer text gone after export
https://bugs.documentfoundation.org/show_bug.cgi?id=133706 Gabor Kelemen changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED CC||jl...@mail.com, ||kelem...@ubuntu.com See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=98 ||000 --- Comment #7 from Gabor Kelemen --- This seems to be exported fine in 7.1 since: https://git.libreoffice.org/core/+/140e8861566afcd1c51ede4bafd9ac2c6192cd68 author Justin Luth Tue Jul 21 21:02:44 2020 +0300 committer Miklos Vajna Wed Jul 22 09:37:48 2020 +0200 tdf#98000 docx export: blank paragraphs don't affect page breaks Thanks Justin for making this work too :) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142501] Libre Office 7.1.3 portable version is crashed when open a docx file in Windows 7
https://bugs.documentfoundation.org/show_bug.cgi?id=142501 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #2 from m.a.riosv --- Please test with a clean profile, Menu/Help/Restart in Safe Mode -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142529] Minimal row height not working for tables in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=142529 --- Comment #1 from Rafael Lima --- This commit may be related to this issue: https://gerrit.libreoffice.org/c/core/+/105422 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142529] New: Minimal row height not working for tables in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=142529 Bug ID: 142529 Summary: Minimal row height not working for tables in Impress Product: LibreOffice Version: 7.1.3.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rafael.palma.l...@gmail.com Created attachment 172395 --> https://bugs.documentfoundation.org/attachment.cgi?id=172395=edit Sample File In Impress, the Optimize > Minimal Row Height does not work even for very simple tables. Instead of adjusting row height based on table contents, I am getting no practical result from this functionality. Steps to reproduce (see attached file) 1) Insert a 4 x 2 table into the slide 2) Fill it in with contents 3) Center contents and align them vertically at the middle 4) Select the whole table 5) Right click: Size > Minimal Row Height 6) Note that nothing will happen This should compress the table based on the text that it contains, but nothing happens. It should be noted that the "Optimal Row Height" also behaves weirdly. Consider the second slide of the attached file. If you apply "Optimal Row Height" to it, it will increase the height of all rows. System Information Version: 7.1.3.2 / LibreOffice Community Build ID: 10(Build:2) CPU threads: 16; OS: Linux 5.11; UI render: default; VCL: kf5 Locale: pt-BR (pt_BR.UTF-8); UI: en-US Ubuntu package version: 1:7.1.3-0ubuntu0.21.04.1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Request for information about LibreOffice for university project
Dear Alberto, please, try to post here on the ML a list of questions you would ask regarding our development process so that (different) devs and contributors can try to answer as best as we can. Nice project, indeed (is it a thesis?) All the best, Marco Marinello Il 27/05/21 21:04, Alberto ha scritto: > > Greetings, > > > My name is Alberto Dorizza and I’m writing for a group of Software > Engineering students at University of Padova (Italy) conducting > research that involves the analysis of the development process of a > software of our choosing. > > Therefore we would like to conduct this research on LibreOffice, on > which we thought you might be able to enlighten us. > > Our research is based on a few points, that is the focus and purpose > of this software, the development strategies and models applied, the > software requirements, the update commit frequency and if possible a > history of such updates. > > We want to enforce the purely informative purpose of this research. > > We are very much open to fix an appointment with yourself, or with > whom this might be of concern, to discuss in more details our > requests, if needed. > > Should our project meet your interest, we would respectfully ask of > you a rather quick response so that we might close in well on our > strict deadline. > > I give you our utmost thanks for your helpfulness. > > > Sincerely, > > Alberto Dorizza > > > > ___ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 142150] Application crashes when EDITING line end styles (arrows)
https://bugs.documentfoundation.org/show_bug.cgi?id=142150 Caolán McNamara changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | Status|NEW |ASSIGNED --- Comment #11 from Caolán McNamara --- can finally reproduce on my terribly slow mac -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: ucb/source
ucb/source/sorter/sortdynres.cxx | 24
ucb/source/sorter/sortresult.cxx | 12 ++--
ucb/source/sorter/sortresult.hxx |6 +++---
3 files changed, 21 insertions(+), 21 deletions(-)
New commits:
commit 187136265d26c014e842550c2f1fc5997736e4fa
Author: Noel Grandin
AuthorDate: Thu May 27 15:49:15 2021 +0200
Commit: Noel Grandin
CommitDate: Thu May 27 21:25:58 2021 +0200
flatten EventList data a little
no need to allocate the ListAction objects separately
Change-Id: I02a591265c0da64d94a118b29bd0c4960d19a763
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116264
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/ucb/source/sorter/sortdynres.cxx b/ucb/source/sorter/sortdynres.cxx
index 5dc7694e107e..100dfa73ccbd 100644
--- a/ucb/source/sorter/sortdynres.cxx
+++ b/ucb/source/sorter/sortdynres.cxx
@@ -306,13 +306,13 @@ void SortedDynamicResultSet::impl_notify( const
ListEvent& Changes )
aWelcome.Old = mxTwo.get();
aWelcome.New = mxOne.get();
-std::unique_ptr pWelcomeAction(new
ListAction);
-pWelcomeAction->ActionInfo <<= aWelcome;
-pWelcomeAction->Position = 0;
-pWelcomeAction->Count = 0;
-pWelcomeAction->ListActionType =
ListActionType::WELCOME;
+ListAction aWelcomeAction;
+aWelcomeAction.ActionInfo <<= aWelcome;
+aWelcomeAction.Position = 0;
+aWelcomeAction.Count = 0;
+aWelcomeAction.ListActionType =
ListActionType::WELCOME;
-maActions.Insert( std::move(pWelcomeAction) );
+maActions.Insert( aWelcomeAction );
}
else
{
@@ -388,7 +388,7 @@ void SortedDynamicResultSet::SendNotify()
for ( sal_Int32 i=0; i pAction(new ListAction);
-pAction->Position = nPos;
-pAction->Count = 1;
-pAction->ListActionType = nType;
+ListAction aAction;
+aAction.Position = nPos;
+aAction.Count = 1;
+aAction.ListActionType = nType;
-Insert( std::move(pAction) );
+Insert( aAction );
}
// SortedDynamicResultSetListener
diff --git a/ucb/source/sorter/sortresult.cxx b/ucb/source/sorter/sortresult.cxx
index 4a4e5956e2d8..b32844368c38 100644
--- a/ucb/source/sorter/sortresult.cxx
+++ b/ucb/source/sorter/sortresult.cxx
@@ -1619,12 +1619,12 @@ void SortedResultSet::ResortModified( EventList* pList )
m_O2S[pData->mnCurPos] = nNewPos;
-std::unique_ptr pAction(new ListAction);
-pAction->Position = nCurPos;
-pAction->Count = 1;
-pAction->ListActionType = ListActionType::MOVED;
-pAction->ActionInfo <<= nNewPos-nCurPos;
-pList->Insert( std::move(pAction) );
+ListAction aAction;
+aAction.Position = nCurPos;
+aAction.Count = 1;
+aAction.ListActionType = ListActionType::MOVED;
+aAction.ActionInfo <<= nNewPos-nCurPos;
+pList->Insert( aAction );
}
pList->AddEvent( ListActionType::PROPERTIES_CHANGED, nNewPos );
}
diff --git a/ucb/source/sorter/sortresult.hxx b/ucb/source/sorter/sortresult.hxx
index 12ea3b78bdf1..bbef157df5d0 100644
--- a/ucb/source/sorter/sortresult.hxx
+++ b/ucb/source/sorter/sortresult.hxx
@@ -69,7 +69,7 @@ public:
class EventList
{
-std::deque < std::unique_ptr > maData;
+std::deque maData;
public:
EventList(){}
@@ -77,9 +77,9 @@ public:
sal_uInt32 Count() { return static_cast(maData.size()); }
voidAddEvent( sal_IntPtr nType, sal_Int32 nPos );
-voidInsert( std::unique_ptr pAction ) {
maData.push_back( std::move(pAction) ); }
+voidInsert( const css::ucb::ListAction& rAction ) {
maData.push_back( rAction ); }
voidClear();
-css::ucb::ListAction* GetAction( sal_Int32 nIndex ) { return maData[
nIndex ].get(); }
+css::ucb::ListAction& GetAction( sal_Int32 nIndex ) { return maData[
nIndex ]; }
};
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/inc vcl/unx
vcl/inc/unx/fontmanager.hxx | 33 ++-
vcl/unx/generic/fontmanager/fontconfig.cxx | 12 -
vcl/unx/generic/fontmanager/fontmanager.cxx | 233 +---
3 files changed, 139 insertions(+), 139 deletions(-)
New commits:
commit 7c1dbb665a3eb7859164dbf83c245b7f450c9028
Author: Noel Grandin
AuthorDate: Thu May 27 14:01:20 2021 +0200
Commit: Noel Grandin
CommitDate: Thu May 27 21:21:50 2021 +0200
no need to allocate PrintFont separately
Change-Id: I8bc213e096ad6ae83d88c548ff8685a872c5ea91
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116258
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/vcl/inc/unx/fontmanager.hxx b/vcl/inc/unx/fontmanager.hxx
index 0f5a85d61153..0e2fa772183f 100644
--- a/vcl/inc/unx/fontmanager.hxx
+++ b/vcl/inc/unx/fontmanager.hxx
@@ -136,7 +136,7 @@ class VCL_PLUGIN_PUBLIC PrintFontManager
};
fontID m_nNextFontID;
-std::unordered_map< fontID, std::unique_ptr >m_aFonts;
+std::unordered_map< fontID, PrintFont > m_aFonts;
// for speeding up findFontFileID
std::unordered_map< OString, std::set< fontID > >
m_aFontFileToFontID;
@@ -146,12 +146,12 @@ class VCL_PLUGIN_PUBLIC PrintFontManager
std::unordered_map< int, OString > m_aAtomToDir;
int m_nNextDirAtom;
-OString getFontFile(const PrintFont* pFont) const;
+OString getFontFile(const PrintFont& rFont) const;
-std::vector> analyzeFontFile(int nDirID, const
OString& rFileName, const char *pFormat=nullptr) const;
+std::vector analyzeFontFile(int nDirID, const OString&
rFileName, const char *pFormat=nullptr) const;
static OUString convertSfntName( void* pNameRecord ); // actually a
NameRecord* format font subsetting code
static void analyzeSfntFamilyName( void const * pTTFont, std::vector<
OUString >& rnames ); // actually a TrueTypeFont* from font subsetting code
-bool analyzeSfntFile(PrintFont* pFont) const;
+bool analyzeSfntFile(PrintFont& rFont) const;
// finds the font id for the nFaceIndex face in this font file
// There may be multiple font ids for font collections
fontID findFontFileID(int nDirID, const OString& rFile, int nFaceIndex,
int nVariationIndex) const;
@@ -161,13 +161,18 @@ class VCL_PLUGIN_PUBLIC PrintFontManager
static FontFamily matchFamilyName( std::u16string_view rFamily );
-PrintFont* getFont( fontID nID ) const
+const PrintFont* getFont( fontID nID ) const
{
auto it = m_aFonts.find( nID );
-return it == m_aFonts.end() ? nullptr : it->second.get();
+return it == m_aFonts.end() ? nullptr : >second;
}
-static void fillPrintFontInfo(PrintFont* pFont, FastPrintFontInfo& rInfo);
-void fillPrintFontInfo( PrintFont* pFont, PrintFontInfo& rInfo ) const;
+PrintFont* getFont( fontID nID )
+{
+auto it = m_aFonts.find( nID );
+return it == m_aFonts.end() ? nullptr : >second;
+}
+static void fillPrintFontInfo(const PrintFont& rFont, FastPrintFontInfo&
rInfo);
+void fillPrintFontInfo( PrintFont& rFont, PrintFontInfo& rInfo ) const;
OString getDirectory( int nAtom ) const;
int getDirectoryAtom( const OString& rDirectory );
@@ -217,26 +222,26 @@ public:
// routines to get font info in small pieces
// get a specific fonts PSName name
-OUString getPSName( fontID nFontID ) const;
+OUString getPSName( fontID nFontID );
// get a specific fonts italic type
FontItalic getFontItalic( fontID nFontID ) const
{
-PrintFont* pFont = getFont( nFontID );
+const PrintFont* pFont = getFont( nFontID );
return pFont ? pFont->m_eItalic : ITALIC_DONTKNOW;
}
// get a specific fonts weight type
FontWeight getFontWeight( fontID nFontID ) const
{
-PrintFont* pFont = getFont( nFontID );
+const PrintFont* pFont = getFont( nFontID );
return pFont ? pFont->m_eWeight : WEIGHT_DONTKNOW;
}
// get a specific fonts system dependent filename
OString getFontFileSysPath( fontID nFontID ) const
{
-return getFontFile( getFont( nFontID ) );
+return getFontFile( *getFont( nFontID ) );
}
// get the ttc face number
@@ -246,10 +251,10 @@ public:
int getFontFaceVariation( fontID nFontID ) const;
// get a specific fonts ascend
-int getFontAscend( fontID nFontID ) const;
+int getFontAscend( fontID nFontID );
// get a specific fonts descent
-int getFontDescend( fontID nFontID ) const;
+int getFontDescend( fontID nFontID );
// get a fonts glyph bounding box
void getFontBoundingBox( fontID nFont, int& xMin, int& yMin, int& xMax,
int& yMax );
diff --git a/vcl/unx/generic/fontmanager/fontconfig.cxx
b/vcl/unx/generic/fontmanager/fontconfig.cxx
index
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3/gtkinst.cxx | 34 +++---
1 file changed, 23 insertions(+), 11 deletions(-)
New commits:
commit 98a8d8bc15018576e1312493425d7bb3725be735
Author: Caolán McNamara
AuthorDate: Thu May 27 16:59:23 2021 +0100
Commit: Caolán McNamara
CommitDate: Thu May 27 21:10:05 2021 +0200
gtk4: reenable EntryTreeView
Change-Id: If1b953f231199fe132783dafb0e26641b7b14d45
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116268
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index 6ba181f8564f..862c9db31c9a 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -18003,8 +18003,6 @@ void
custom_cell_renderer_surface_render(GtkCellRenderer* cell,
}
#endif
-#if !GTK_CHECK_VERSION(4, 0, 0)
-
namespace {
class GtkInstanceEntryTreeView : public GtkInstanceContainer, public virtual
weld::EntryTreeView
@@ -18012,12 +18010,15 @@ class GtkInstanceEntryTreeView : public
GtkInstanceContainer, public virtual wel
private:
GtkInstanceEntry* m_pEntry;
GtkInstanceTreeView* m_pTreeView;
+#if !GTK_CHECK_VERSION(4, 0, 0)
gulong m_nKeyPressSignalId;
+#endif
gulong m_nEntryInsertTextSignalId;
guint m_nAutoCompleteIdleId;
bool m_bAutoCompleteCaseSensitive;
bool m_bTreeChange;
+#if !GTK_CHECK_VERSION(4, 0, 0)
bool signal_key_press(GdkEventKey* pEvent)
{
if (GtkSalFrame::GetMouseModCode(pEvent->state)) // only with no
modifiers held
@@ -18057,6 +18058,7 @@ private:
GtkInstanceEntryTreeView* pThis =
static_cast(widget);
return pThis->signal_key_press(pEvent);
}
+#endif
static gboolean idleAutoComplete(gpointer widget)
{
@@ -18139,8 +18141,13 @@ private:
public:
+#if GTK_CHECK_VERSION(4, 0, 0)
+GtkInstanceEntryTreeView(GtkWidget* pContainer, GtkInstanceBuilder*
pBuilder, bool bTakeOwnership,
+ std::unique_ptr xEntry,
std::unique_ptr xTreeView)
+#else
GtkInstanceEntryTreeView(GtkContainer* pContainer, GtkInstanceBuilder*
pBuilder, bool bTakeOwnership,
std::unique_ptr xEntry,
std::unique_ptr xTreeView)
+#endif
: EntryTreeView(std::move(xEntry), std::move(xTreeView))
, GtkInstanceContainer(pContainer, pBuilder, bTakeOwnership)
, m_pEntry(dynamic_cast(m_xEntry.get()))
@@ -18151,7 +18158,9 @@ public:
{
assert(m_pEntry);
GtkWidget* pWidget = m_pEntry->getWidget();
+#if !GTK_CHECK_VERSION(4, 0, 0)
m_nKeyPressSignalId = g_signal_connect(pWidget, "key-press-event",
G_CALLBACK(signalKeyPress), this);
+#endif
m_nEntryInsertTextSignalId = g_signal_connect(pWidget, "insert-text",
G_CALLBACK(signalEntryInsertText), this);
}
@@ -18225,7 +18234,9 @@ public:
{
GtkWidget* pWidget = m_pEntry->getWidget();
g_signal_handler_block(pWidget, m_nEntryInsertTextSignalId);
+#if !GTK_CHECK_VERSION(4, 0, 0)
g_signal_handler_block(pWidget, m_nKeyPressSignalId);
+#endif
m_pTreeView->disable_notify_events();
GtkInstanceContainer::disable_notify_events();
}
@@ -18233,7 +18244,9 @@ public:
virtual void enable_notify_events() override
{
GtkWidget* pWidget = m_pEntry->getWidget();
+#if !GTK_CHECK_VERSION(4, 0, 0)
g_signal_handler_unblock(pWidget, m_nKeyPressSignalId);
+#endif
g_signal_handler_unblock(pWidget, m_nEntryInsertTextSignalId);
m_pTreeView->enable_notify_events();
GtkInstanceContainer::disable_notify_events();
@@ -18292,15 +18305,15 @@ public:
if (m_nAutoCompleteIdleId)
g_source_remove(m_nAutoCompleteIdleId);
GtkWidget* pWidget = m_pEntry->getWidget();
+#if !GTK_CHECK_VERSION(4, 0, 0)
g_signal_handler_disconnect(pWidget, m_nKeyPressSignalId);
+#endif
g_signal_handler_disconnect(pWidget, m_nEntryInsertTextSignalId);
}
};
}
-#endif
-
namespace {
class GtkInstanceExpander : public GtkInstanceWidget, public virtual
weld::Expander
@@ -19932,20 +19945,17 @@ public:
virtual std::unique_ptr weld_entry_tree_view(const
OString& containerid, const OString& entryid, const OString& treeviewid)
override
{
-#if !GTK_CHECK_VERSION(4, 0, 0)
+#if GTK_CHECK_VERSION(4, 0, 0)
+GtkWidget* pContainer = GTK_WIDGET(gtk_builder_get_object(m_pBuilder,
containerid.getStr()));
+#else
GtkContainer* pContainer =
GTK_CONTAINER(gtk_builder_get_object(m_pBuilder, containerid.getStr()));
+#endif
if (!pContainer)
return nullptr;
auto_add_parentless_widgets_to_container(GTK_WIDGET(pContainer));
return std::make_unique(pContainer, this,
false,
weld_entry(entryid),
weld_tree_view(treeviewid));
-#else
-(void)containerid;
-
[Libreoffice-commits] core.git: compilerplugins/clang vcl/unx
compilerplugins/clang/reservedid.cxx |2
vcl/unx/gtk3/gtkinst.cxx | 125 ++-
2 files changed, 98 insertions(+), 29 deletions(-)
New commits:
commit d132982667d0e8112e7cf9f5cc39323ec7be5068
Author: Caolán McNamara
AuthorDate: Thu May 27 16:20:12 2021 +0100
Commit: Caolán McNamara
CommitDate: Thu May 27 21:09:46 2021 +0200
gtk4: continue to provide Paintable via cairo surface
instead of squeezing through a GdkTexture and losing hidpi surfaces
Change-Id: I1ee75ff804d1d769273e2f80335bfdf528ae8039
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116267
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/compilerplugins/clang/reservedid.cxx
b/compilerplugins/clang/reservedid.cxx
index 3f019a10d830..169942f9c392 100644
--- a/compilerplugins/clang/reservedid.cxx
+++ b/compilerplugins/clang/reservedid.cxx
@@ -207,6 +207,8 @@ bool ReservedId::VisitNamedDecl(NamedDecl const * decl) {
&& s != "_GstVideoOverlay"
// avmedia/source/gstreamer/gstplayer.hxx
&& s != "_Module" // extensions/source/activex/StdAfx2.h,
CComModule
+&& s != "_SurfacePaintable" // vcl/unx/gtk3/gtkinst.cxx
+&& s != "_SurfacePaintableClass" // vcl/unx/gtk3/gtkinst.cxx
&& s != "_XRegion" // vcl/unx/generic/gdi/x11cairotextrender.cxx
&& s != "_XTrap") // vcl/unx/generic/gdi/xrender_peer.hxx
{
diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index 4fd5e509fa1f..6ba181f8564f 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -3981,48 +3981,115 @@ namespace
#endif
return pixbuf;
}
+}
#if GTK_CHECK_VERSION(4, 0, 0)
-GdkTexture* texture_new_from_virtual_device(const VirtualDevice&
rImageSurface)
+
+G_BEGIN_DECLS
+
+G_DECLARE_FINAL_TYPE(SurfacePaintable, surface_paintable, SURFACE, PAINTABLE,
GObject)
+
+struct _SurfacePaintable
+{
+GObject parent_instance;
+int width;
+int height;
+cairo_surface_t* surface;
+};
+
+struct _SurfacePaintableClass
+{
+GObjectClass parent_class;
+};
+
+static void surface_paintable_snapshot(GdkPaintable *paintable, GdkSnapshot
*snapshot,
+ double width, double height)
+{
+graphene_rect_t rect = GRAPHENE_RECT_INIT(0.0f, 0.0f,
+ static_cast(width),
+ static_cast(height));
+SurfacePaintable *self = SURFACE_PAINTABLE(paintable);
+cairo_t* cr = gtk_snapshot_append_cairo(GTK_SNAPSHOT(snapshot), );
+cairo_set_source_surface(cr, self->surface, 0, 0);
+cairo_paint(cr);
+cairo_destroy(cr);
+}
+
+static int surface_paintable_get_intrinsic_width(GdkPaintable *paintable)
+{
+SurfacePaintable *self = SURFACE_PAINTABLE(paintable);
+return self->width;
+}
+
+static int surface_paintable_get_intrinsic_height(GdkPaintable *paintable)
+{
+SurfacePaintable *self = SURFACE_PAINTABLE(paintable);
+return self->height;
+}
+
+static void surface_paintable_init_interface(GdkPaintableInterface *iface)
+{
+iface->snapshot = surface_paintable_snapshot;
+iface->get_intrinsic_width = surface_paintable_get_intrinsic_width;
+iface->get_intrinsic_height = surface_paintable_get_intrinsic_height;
+}
+
+G_DEFINE_TYPE_WITH_CODE(SurfacePaintable, surface_paintable, G_TYPE_OBJECT,
+G_IMPLEMENT_INTERFACE(GDK_TYPE_PAINTABLE,
+
surface_paintable_init_interface));
+
+static void surface_paintable_init(SurfacePaintable *self)
+{
+self->width = 0;
+self->height = 0;
+self->surface = nullptr;
+}
+
+static void surface_paintable_dispose(GObject *object)
+{
+SurfacePaintable* self = SURFACE_PAINTABLE(object);
+cairo_surface_destroy(self->surface);
+G_OBJECT_CLASS(surface_paintable_parent_class)->dispose(object);
+}
+
+static void surface_paintable_class_init(SurfacePaintableClass *klass)
+{
+GObjectClass *object_class = G_OBJECT_CLASS(klass);
+object_class->dispose = surface_paintable_dispose;
+}
+
+G_END_DECLS
+
+#endif
+
+namespace
+{
+#if GTK_CHECK_VERSION(4, 0, 0)
+SurfacePaintable* paintable_new_from_virtual_device(const VirtualDevice&
rImageSurface)
{
cairo_surface_t* surface = get_underlying_cairo_surface(rImageSurface);
Size aSize(rImageSurface.GetOutputSizePixel());
-
-// seems unfortunately to lose the potentially hidpi image here
-cairo_surface_t* target = cairo_surface_create_similar_image(surface,
-
CAIRO_FORMAT_ARGB32,
-
aSize.Width(),
-
aSize.Height());
-
+cairo_surface_t* target = cairo_surface_create_similar(surface,
+
Request for information about LibreOffice for university project
Greetings, My name is Alberto Dorizza and I’m writing for a group of Software Engineering students at University of Padova (Italy) conducting research that involves the analysis of the development process of a software of our choosing. Therefore we would like to conduct this research on LibreOffice, on which we thought you might be able to enlighten us. Our research is based on a few points, that is the focus and purpose of this software, the development strategies and models applied, the software requirements, the update commit frequency and if possible a history of such updates. We want to enforce the purely informative purpose of this research. We are very much open to fix an appointment with yourself, or with whom this might be of concern, to discuss in more details our requests, if needed. Should our project meet your interest, we would respectfully ask of you a rather quick response so that we might close in well on our strict deadline. I give you our utmost thanks for your helpfulness. Sincerely, Alberto Dorizza ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 113380] UI: Media Player Dialog: Buttons overlapping
https://bugs.documentfoundation.org/show_bug.cgi?id=113380 --- Comment #7 from JhonSmith --- https://gameinstants.com;>gameinstants.com / https://keepthetech.com;>keepthetech.com -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/control/calendar.cxx | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
New commits:
commit 0fd545eed33e85544065a383e3beace5401e870e
Author: Noel Grandin
AuthorDate: Thu May 27 15:45:58 2021 +0200
Commit: Noel Grandin
CommitDate: Thu May 27 20:47:42 2021 +0200
no need to allocate these on the heap
Change-Id: I6933260f589c67f463ee60572a31c52c6be7eb66
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116262
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/vcl/source/control/calendar.cxx b/vcl/source/control/calendar.cxx
index c03740f3063c..ba69a780b6ea 100644
--- a/vcl/source/control/calendar.cxx
+++ b/vcl/source/control/calendar.cxx
@@ -808,7 +808,7 @@ void Calendar::ImplUpdateSelection( IntDateSet* pOld )
void Calendar::ImplMouseSelect( const Date& rDate, sal_uInt16 nHitTest )
{
-std::unique_ptr pOldSel(new IntDateSet( *mpSelectTable ));
+IntDateSet aOldSel( *mpSelectTable );
DateaOldDate = maCurDate;
DateaTempDate = rDate;
@@ -824,13 +824,13 @@ void Calendar::ImplMouseSelect( const Date& rDate,
sal_uInt16 nHitTest )
ImplCalendarSelectDate( mpSelectTable.get(), maCurDate, true );
}
-bool bNewSel = *pOldSel != *mpSelectTable;
+bool bNewSel = aOldSel != *mpSelectTable;
if ( (maCurDate != aOldDate) || bNewSel )
{
HideFocus();
if ( bNewSel )
-ImplUpdateSelection( pOldSel.get() );
-if ( !bNewSel || pOldSel->find( aOldDate.GetDate() ) == pOldSel->end()
)
+ImplUpdateSelection( );
+if ( !bNewSel || aOldSel.find( aOldDate.GetDate() ) == aOldSel.end() )
ImplUpdateDate( aOldDate );
// assure focus rectangle is displayed again
if ( HasFocus() || !bNewSel
@@ -961,13 +961,13 @@ void Calendar::ImplEndTracking( bool bCancel )
if ( !bSpinDown )
{
-std::unique_ptr pOldSel(new IntDateSet( *mpSelectTable
));
+IntDateSet aOldSel( *mpSelectTable );
DateaOldDate = maCurDate;
maCurDate = maOldCurDate;
*mpSelectTable = *mpOldSelectTable;
HideFocus();
-ImplUpdateSelection( pOldSel.get() );
-if ( pOldSel->find( aOldDate.GetDate() ) == pOldSel->end() )
+ImplUpdateSelection( );
+if ( aOldSel.find( aOldDate.GetDate() ) == aOldSel.end() )
ImplUpdateDate( aOldDate );
// assure focus rectangle is displayed again
if ( HasFocus() || mpSelectTable->find( maCurDate.GetDate() ) ==
mpSelectTable->end() )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/source
vcl/source/edit/textdat2.hxx | 21 ++---
vcl/source/edit/textdata.cxx | 30 +++
vcl/source/edit/texteng.cxx | 162 +--
vcl/source/edit/textview.cxx |6 -
4 files changed, 109 insertions(+), 110 deletions(-)
New commits:
commit 211b13725152d3af49f28a88b3dc260c923377aa
Author: Noel Grandin
AuthorDate: Thu May 27 15:35:43 2021 +0200
Commit: Noel Grandin
CommitDate: Thu May 27 20:46:13 2021 +0200
TETextPortion can be allocated inside the vector
Change-Id: Ib54b94f5dcb2a9cf422ef30db99926f200b749c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116261
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/vcl/source/edit/textdat2.hxx b/vcl/source/edit/textdat2.hxx
index c92ce1974e40..1f9d2428d9f2 100644
--- a/vcl/source/edit/textdat2.hxx
+++ b/vcl/source/edit/textdat2.hxx
@@ -63,6 +63,7 @@ public:
{}
sal_Int32& GetLen(){ return nLen; }
+sal_Int32 GetLen() const { return nLen; }
tools::Long& GetWidth() { return nWidth; }
sal_uInt8& GetKind() { return nKind; }
voidSetRightToLeft(bool b) { bRightToLeft = b; }
@@ -72,7 +73,7 @@ public:
class TETextPortionList
{
private:
-std::vector> maPortions;
+std::vector maPortions;
public:
static constexpr auto npos = std::numeric_limits::max();
@@ -80,17 +81,17 @@ public:
TETextPortionList();
~TETextPortionList();
-TETextPortion* operator[]( std::size_t nPos );
-std::vector>::iterator begin();
-std::vector>::const_iterator begin() const;
-std::vector>::iterator end();
-std::vector>::const_iterator end() const;
+TETextPortion& operator[]( std::size_t nPos );
+std::vector::iterator begin();
+std::vector::const_iterator begin() const;
+std::vector::iterator end();
+std::vector::const_iterator end() const;
bool empty() const;
std::size_t size() const;
-std::vector>::iterator erase( const
std::vector>::iterator& aIter );
-std::vector>::iterator insert( const
std::vector>::iterator& aIter,
-
std::unique_ptr pTP );
-void push_back( std::unique_ptr pTP );
+std::vector::iterator erase( const
std::vector::iterator& aIter );
+std::vector::iterator insert( const
std::vector::iterator& aIter,
+ const TETextPortion& rTP );
+void push_back( const TETextPortion & aTP );
voidReset();
std::size_t FindPortion( sal_Int32 nCharPos, sal_Int32& rPortionStart,
bool bPreferStartingPortion = false );
diff --git a/vcl/source/edit/textdata.cxx b/vcl/source/edit/textdata.cxx
index 5c00cd5ebf0f..d9d4452ae0d9 100644
--- a/vcl/source/edit/textdata.cxx
+++ b/vcl/source/edit/textdata.cxx
@@ -61,27 +61,27 @@ TETextPortionList::~TETextPortionList()
Reset();
}
-TETextPortion* TETextPortionList::operator[]( std::size_t nPos )
+TETextPortion& TETextPortionList::operator[]( std::size_t nPos )
{
-return maPortions[ nPos ].get();
+return maPortions[ nPos ];
}
-std::vector>::iterator
TETextPortionList::begin()
+std::vector::iterator TETextPortionList::begin()
{
return maPortions.begin();
}
-std::vector>::const_iterator
TETextPortionList::begin() const
+std::vector::const_iterator TETextPortionList::begin() const
{
return maPortions.begin();
}
-std::vector>::iterator TETextPortionList::end()
+std::vector::iterator TETextPortionList::end()
{
return maPortions.end();
}
-std::vector>::const_iterator
TETextPortionList::end() const
+std::vector::const_iterator TETextPortionList::end() const
{
return maPortions.end();
}
@@ -96,20 +96,20 @@ std::size_t TETextPortionList::size() const
return maPortions.size();
}
-std::vector>::iterator
TETextPortionList::erase( const
std::vector>::iterator& aIter )
+std::vector::iterator TETextPortionList::erase( const
std::vector::iterator& aIter )
{
return maPortions.erase( aIter );
}
-std::vector>::iterator
TETextPortionList::insert( const
std::vector>::iterator& aIter,
-
std::unique_ptr pTP )
+std::vector::iterator TETextPortionList::insert( const
std::vector::iterator& aIter,
+ const
TETextPortion& rTP )
{
-return maPortions.insert( aIter, std::move(pTP) );
+return maPortions.insert( aIter, rTP );
}
-void TETextPortionList::push_back( std::unique_ptr pTP )
+void TETextPortionList::push_back( const TETextPortion& rTP )
{
-maPortions.push_back( std::move(pTP) );
+maPortions.push_back( rTP );
}
void TETextPortionList::Reset()
@@ -129,14 +129,14 @@ std::size_t TETextPortionList::FindPortion( sal_Int32
nCharPos, sal_Int32& nPort
sal_Int32 nTmpPos = 0;
for ( std::size_t nPortion =
[Libreoffice-commits] core.git: ucb/source
ucb/source/ucp/file/bc.cxx |4 ++--
ucb/source/ucp/file/filnot.cxx |8
ucb/source/ucp/file/filnot.hxx |4 ++--
3 files changed, 8 insertions(+), 8 deletions(-)
New commits:
commit cd023b8f8383aae3fbb053c40949843c8a50514b
Author: Noel Grandin
AuthorDate: Thu May 27 15:46:20 2021 +0200
Commit: Noel Grandin
CommitDate: Thu May 27 20:45:54 2021 +0200
no need to allocate ListenerMap on the heap
it is a movable type
Change-Id: I2b5c8524115016b53ec5cb28312ff4d749e27368
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116263
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/ucb/source/ucp/file/bc.cxx b/ucb/source/ucp/file/bc.cxx
index d85a214063ba..e79d5ba2b0b9 100644
--- a/ucb/source/ucp/file/bc.cxx
+++ b/ucb/source/ucp/file/bc.cxx
@@ -1187,13 +1187,13 @@ BaseContent::cPCL()
if( seqNames.hasElements() )
{
-std::unique_ptr listener(new ListenerMap);
+ListenerMap listener;
for( const auto& rName : seqNames )
{
cppu::OInterfaceContainerHelper* pContainer =
m_pPropertyListener->getContainer(rName);
if (!pContainer)
continue;
-(*listener)[rName] = pContainer->getElements();
+listener[rName] = pContainer->getElements();
}
p.reset( new PropertyChangeNotifier( this, std::move(listener) ) );
diff --git a/ucb/source/ucp/file/filnot.cxx b/ucb/source/ucp/file/filnot.cxx
index 19a9d2e0b141..d1f1b830bf95 100644
--- a/ucb/source/ucp/file/filnot.cxx
+++ b/ucb/source/ucp/file/filnot.cxx
@@ -192,9 +192,9 @@ PropertySetInfoChangeNotifier::notifyPropertyRemoved( const
OUString & aProperty
PropertyChangeNotifier::PropertyChangeNotifier(
const css::uno::Reference< XContent >& xCreatorContent,
-std::unique_ptr pListeners )
+ListenerMap&& pListeners )
: m_xCreatorContent( xCreatorContent ),
- m_pListeners( std::move(pListeners) )
+ m_aListeners( std::move(pListeners) )
{
}
@@ -214,7 +214,7 @@ void PropertyChangeNotifier::notifyPropertyChanged(
// notify listeners for all Events
-uno::Sequence< uno::Reference< uno::XInterface > > seqList =
(*m_pListeners)[ OUString() ];
+uno::Sequence< uno::Reference< uno::XInterface > > seqList = m_aListeners[
OUString() ];
for( const auto& rListener : std::as_const(seqList) )
{
uno::Reference< beans::XPropertiesChangeListener > aListener(
rListener,uno::UNO_QUERY );
@@ -228,7 +228,7 @@ void PropertyChangeNotifier::notifyPropertyChanged(
for( const auto& rChange : std::as_const(Changes) )
{
seq[0] = rChange;
-seqList = (*m_pListeners)[ rChange.PropertyName ];
+seqList = m_aListeners[ rChange.PropertyName ];
for( const auto& rListener : std::as_const(seqList) )
{
diff --git a/ucb/source/ucp/file/filnot.hxx b/ucb/source/ucp/file/filnot.hxx
index 95bcc8328a48..76730c1ddcfa 100644
--- a/ucb/source/ucp/file/filnot.hxx
+++ b/ucb/source/ucp/file/filnot.hxx
@@ -83,11 +83,11 @@ namespace fileaccess {
{
private:
css::uno::Reference< css::ucb::XContent > m_xCreatorContent;
-std::unique_ptr m_pListeners;
+ListenerMap m_aListeners;
public:
PropertyChangeNotifier(
const css::uno::Reference< css::ucb::XContent >& xCreatorContent,
-std::unique_ptr pListeners );
+ListenerMap&& pListeners );
~PropertyChangeNotifier();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 141769] Crash in: cppu::OInterfaceContainerHelper::disposeAndClear(com::sun::star::lang::EventObject const &)
https://bugs.documentfoundation.org/show_bug.cgi?id=141769 --- Comment #21 from Laurence 'GreenReaper' Parry --- I have: Oracle Corporation version 1.8.0_291 under Program Files (x86). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106179] [META] Writer comment bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=106179 --- Comment #21 from Ravi Sharma --- https://prabhubhakti.in/product/narmadeshwar-shivling-online/ "> Narmadeshwar Shivling is a very holy Shivling, which brings good luck by worshiping it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/impanmvw.cxx |8 ++--
vcl/source/treelist/transfer.cxx | 16
2 files changed, 14 insertions(+), 10 deletions(-)
New commits:
commit fd7787b6f0f082db320ebe7b29fc5333587b5d2e
Author: Noel Grandin
AuthorDate: Thu May 27 15:21:58 2021 +0200
Commit: Noel Grandin
CommitDate: Thu May 27 20:02:00 2021 +0200
no need to allocate these on the heap
Change-Id: I0740f7194c589d6949a816f365cd54403be72118
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116260
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/vcl/source/gdi/impanmvw.cxx b/vcl/source/gdi/impanmvw.cxx
index b7329c073ef1..5757d3d36e5c 100644
--- a/vcl/source/gdi/impanmvw.cxx
+++ b/vcl/source/gdi/impanmvw.cxx
@@ -151,7 +151,9 @@ void ImplAnimView::drawToPos( sal_uLong nPos )
}
ScopedVclPtrInstance aVDev;
-std::unique_ptr xOldClip(!maClip.IsNull() ? new vcl::Region(
pRenderContext->GetClipRegion() ) : nullptr);
+std::optional xOldClip;
+if (!maClip.IsNull())
+xOldClip = pRenderContext->GetClipRegion();
aVDev->SetOutputSizePixel( maSzPix, false );
nPos = std::min( nPos, static_cast(mpParent->Count()) - 1 );
@@ -270,7 +272,9 @@ void ImplAnimView::draw( sal_uLong nPos, VirtualDevice*
pVDev )
if( !pVDev )
{
-std::unique_ptr xOldClip(!maClip.IsNull() ? new
vcl::Region( pRenderContext->GetClipRegion() ) : nullptr);
+std::optional xOldClip;
+if (!maClip.IsNull())
+xOldClip = pRenderContext->GetClipRegion();
if (xOldClip)
pRenderContext->SetClipRegion( maClip );
diff --git a/vcl/source/treelist/transfer.cxx b/vcl/source/treelist/transfer.cxx
index 5f57a7ff07b6..a917973e1122 100644
--- a/vcl/source/treelist/transfer.cxx
+++ b/vcl/source/treelist/transfer.cxx
@@ -332,11 +332,11 @@ Any SAL_CALL TransferableHelper::getTransferData2( const
DataFlavor& rFlavor, co
if( maAny >>= aSeq )
{
-std::unique_ptr pSrcStm(new
SvMemoryStream( aSeq.getArray(), aSeq.getLength(), StreamMode::WRITE |
StreamMode::TRUNC ));
GDIMetaFile aMtf;
-
-ReadGDIMetaFile( *pSrcStm, aMtf );
-pSrcStm.reset();
+{
+SvMemoryStream aSrcStm( aSeq.getArray(),
aSeq.getLength(), StreamMode::WRITE | StreamMode::TRUNC );
+ReadGDIMetaFile( aSrcStm, aMtf );
+}
Graphic aGraphic( aMtf );
SvMemoryStream aDstStm( 65535, 65535 );
@@ -362,11 +362,11 @@ Any SAL_CALL TransferableHelper::getTransferData2( const
DataFlavor& rFlavor, co
if( maAny >>= aSeq )
{
-std::unique_ptr pSrcStm(new
SvMemoryStream( aSeq.getArray(), aSeq.getLength(), StreamMode::WRITE |
StreamMode::TRUNC ));
GDIMetaFile aMtf;
-
-ReadGDIMetaFile( *pSrcStm, aMtf );
-pSrcStm.reset();
+{
+SvMemoryStream aSrcStm( aSeq.getArray(),
aSeq.getLength(), StreamMode::WRITE | StreamMode::TRUNC );
+ReadGDIMetaFile( aSrcStm, aMtf );
+}
SvMemoryStream aDstStm( 65535, 65535 );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/ui/app/inputhdl.cxx|2 +-
sc/source/ui/vba/vbaeventshelper.cxx |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 832f04d1f78e54bb84c641c11cf90aa2f953fc17
Author: Noel Grandin
AuthorDate: Wed May 26 11:00:26 2021 +0200
Commit: Noel Grandin
CommitDate: Thu May 27 19:45:43 2021 +0200
IsDisposed->isDisposed in sc
Change-Id: Ie08509df7481a9128c865f19d2b45694b19d9f38
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116179
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sc/source/ui/app/inputhdl.cxx b/sc/source/ui/app/inputhdl.cxx
index 2ef4df79dc4e..ab68cdac40c2 100644
--- a/sc/source/ui/app/inputhdl.cxx
+++ b/sc/source/ui/app/inputhdl.cxx
@@ -2236,7 +2236,7 @@ void ScInputHandler::SetInputWindow( ScInputWindow* pNew
)
void ScInputHandler::StopInputWinEngine( bool bAll )
{
-if (pInputWin && !pInputWin->IsDisposed())
+if (pInputWin && !pInputWin->isDisposed())
pInputWin->StopEditEngine( bAll );
pTopView = nullptr; // invalid now
diff --git a/sc/source/ui/vba/vbaeventshelper.cxx
b/sc/source/ui/vba/vbaeventshelper.cxx
index 4fd2fab73f80..760d1002c868 100644
--- a/sc/source/ui/vba/vbaeventshelper.cxx
+++ b/sc/source/ui/vba/vbaeventshelper.cxx
@@ -491,7 +491,7 @@ IMPL_LINK( ScVbaEventListener, processWindowResizeEvent,
void*, p, void )
This is handled via the disposing() function which removes the window
pointer from the member maControllers. Thus, checking whether
maControllers contains pWindow ensures that the window is still alive.
*/
-if( !mbDisposed && pWindow && !pWindow->IsDisposed() &&
(maControllers.count(pWindow) > 0) )
+if( !mbDisposed && pWindow && !pWindow->isDisposed() &&
(maControllers.count(pWindow) > 0) )
{
// do not fire event unless all mouse buttons have been released
vcl::Window::PointerState aPointerState = pWindow->GetPointerState();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: dbaccess/source
dbaccess/source/ui/querydesign/TableWindowAccess.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit f682ff1b5502fc3c5f8003d57466795bf795d524
Author: Noel Grandin
AuthorDate: Wed May 26 11:01:08 2021 +0200
Commit: Noel Grandin
CommitDate: Thu May 27 19:45:23 2021 +0200
IsDisposed->isDisposed in dbaccess
Change-Id: I7a113dc01f76d53126b414cf132404ed8ef8db4a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116180
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/dbaccess/source/ui/querydesign/TableWindowAccess.cxx
b/dbaccess/source/ui/querydesign/TableWindowAccess.cxx
index 1dc69e763d5d..f49b97c7787c 100644
--- a/dbaccess/source/ui/querydesign/TableWindowAccess.cxx
+++ b/dbaccess/source/ui/querydesign/TableWindowAccess.cxx
@@ -90,7 +90,7 @@ namespace dbaui
{
::osl::MutexGuard aGuard( m_aMutex );
Reference< XAccessible > aRet;
-if (m_pTable && !m_pTable->IsDisposed())
+if (m_pTable && !m_pTable->isDisposed())
{
switch(i)
{
@@ -149,7 +149,7 @@ namespace dbaui
{
::osl::MutexGuard aGuard( m_aMutex );
Reference< XAccessible > aRet;
-if(m_pTable && !m_pTable->IsDisposed())
+if(m_pTable && !m_pTable->isDisposed())
{
Point aPoint(_aPoint.X,_aPoint.Y);
tools::Rectangle aRect(m_pTable->GetDesktopRectPixel());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 142517] Feature to disable autolayouts on Impress master slides
https://bugs.documentfoundation.org/show_bug.cgi?id=142517 --- Comment #9 from Thorsten Wagner --- I totally agree. Master slide handling is one of the reasons for most users I got feedback from to use PowerPoint. A better and consistent concept would increase user acceptance a lot. But in the meantime copying master sildes and the ability to remove master elements in master editing mode would be sufficient. My current workflow (workaround) to create new presentation templates is as follows: (1) Create a new presentation with a single master silde customized according to the requirements (fonts, spacing, indents, bullets etc.) for all master elements (2) Copy presenation to another one (3) Open copied presentation and edit master to create another master slides with the same text attributes, but for title or other slides (4) Copy slide form the copied presentation based on the modified master to the first presentation and rename the master of the copied slide (5) Repeat steps 2 to 4 as often as additional master slides are required Strange, isn't it? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'private/jmux/wasm_for_master_catchall' - cppu/source shell/Module_shell.mk solenv/gbuild
cppu/source/uno/lbenv.cxx |6 ++
cppu/source/uno/lbmap.cxx |2 ++
shell/Module_shell.mk |6 +++---
solenv/gbuild/platform/EMSCRIPTEN_INTEL_GCC.mk |5 -
4 files changed, 15 insertions(+), 4 deletions(-)
New commits:
commit 2f8696805ee9554f4385659c8f44594247954027
Author: Jan-Marek Glogowski
AuthorDate: Thu May 27 19:26:19 2021 +0200
Commit: Jan-Marek Glogowski
CommitDate: Thu May 27 19:26:19 2021 +0200
Prevent WASM rewriting by wasm-emscripten-finalize
Change-Id: I03c3383d3026e258f8db39996af569c508d3189b
diff --git a/cppu/source/uno/lbenv.cxx b/cppu/source/uno/lbenv.cxx
index 03dbc99eafcc..b24a81bf5ac9 100644
--- a/cppu/source/uno/lbenv.cxx
+++ b/cppu/source/uno/lbenv.cxx
@@ -1012,6 +1012,7 @@ void EnvironmentsData::getRegisteredEnvironments(
bool loadEnv(OUString const & cLibStem,
uno_Environment * pEnv)
{
+#ifndef __EMSCRIPTEN__
#ifdef DISABLE_DYNLOADING
uno_initEnvironmentFunc fpInit;
@@ -1051,6 +1052,11 @@ bool loadEnv(OUString const & cLibStem,
(*fpInit)( pEnv ); // init of environment
return true;
+#else
+(void)cLibStem;
+(void)pEnv;
+return false;
+#endif
}
}
diff --git a/cppu/source/uno/lbmap.cxx b/cppu/source/uno/lbmap.cxx
index 685bf6d4a2a8..03ab13ae7e0d 100644
--- a/cppu/source/uno/lbmap.cxx
+++ b/cppu/source/uno/lbmap.cxx
@@ -328,8 +328,10 @@ static void setNegativeBridge( const OUString &
rBridgeName )
static uno_ext_getMappingFunc selectMapFunc( const OUString & rBridgeName )
{
+#ifndef EMSCRIPTEN
if (rBridgeName.equalsAscii( CPPU_CURRENT_LANGUAGE_BINDING_NAME "_uno" ))
return CPPU_ENV_uno_ext_getMapping;
+#endif
#if HAVE_FEATURE_JAVA
if (rBridgeName.equalsAscii( "java" "_uno" ))
return java_uno_ext_getMapping;
diff --git a/shell/Module_shell.mk b/shell/Module_shell.mk
index 193c46f3d75d..cb373f99982a 100644
--- a/shell/Module_shell.mk
+++ b/shell/Module_shell.mk
@@ -104,6 +104,7 @@ $(eval $(call gb_Module_add_targets,shell,\
))
endif
+ifeq (,$(filter EMSCRIPTEN,$(OS)))
ifeq ($(filter DESKTOP,$(BUILD_TYPE)),DESKTOP)
$(eval $(call gb_Module_add_targets,shell,\
@@ -111,17 +112,16 @@ $(eval $(call gb_Module_add_targets,shell,\
))
ifneq ($(OS),WNT)
-
$(eval $(call gb_Module_add_targets,shell,\
StaticLibrary_xmlparser \
Executable_uri_encode \
Library_cmdmail \
$(if $(ENABLE_MACOSX_SANDBOX),,Package_senddoc) \
))
-
endif
-endif
+endif # DESKTOP
+endif # !EMSCRIPTEN
$(eval $(call gb_Module_add_l10n_targets,shell,\
AllLangMoTarget_shell \
diff --git a/solenv/gbuild/platform/EMSCRIPTEN_INTEL_GCC.mk
b/solenv/gbuild/platform/EMSCRIPTEN_INTEL_GCC.mk
index 12f63fe78c62..0c4c33bd6241 100644
--- a/solenv/gbuild/platform/EMSCRIPTEN_INTEL_GCC.mk
+++ b/solenv/gbuild/platform/EMSCRIPTEN_INTEL_GCC.mk
@@ -14,7 +14,10 @@ include $(GBUILDDIR)/platform/unxgcc.mk
gb_RUN_CONFIGURE := $(SRCDIR)/solenv/bin/run-configure
# avoid -s SAFE_HEAP=1 - c.f. gh#8584 this breaks source maps
gb_EMSCRIPTEN_CPPFLAGS := -pthread -s TOTAL_MEMORY=1GB -s USE_PTHREADS=1 -s
PTHREAD_POOL_SIZE=4
-gb_EMSCRIPTEN_LDFLAGS := $(gb_EMSCRIPTEN_CPPFLAGS) --bind -s
ERROR_ON_UNDEFINED_SYMBOLS=1 -s FETCH=1 -s ASSERTIONS=2 -s EXIT_RUNTIME=0 -s
EXTRA_EXPORTED_RUNTIME_METHODS=["UTF16ToString","stringToUTF16"]
+# To keep the link time (and memory) down, prevent all rewriting options from
wasm-emscripten-finalize
+# See emscrypten.py, finalize_wasm, modify_wasm = True
+# So we need WASM_BIGINT=1 and ASSERTIONS=1 (2 implies STACK_OVERFLOW_CHECK)
+gb_EMSCRIPTEN_LDFLAGS := $(gb_EMSCRIPTEN_CPPFLAGS) --bind -s WASM_BIGINT=1 -s
ERROR_ON_UNDEFINED_SYMBOLS=1 -s FETCH=1 -s ASSERTIONS=1 -s EXIT_RUNTIME=0 -s
EXTRA_EXPORTED_RUNTIME_METHODS=["UTF16ToString","stringToUTF16"]
gb_EMSCRIPTEN_QTDEFS := -DQT_NO_LINKED_LIST -DQT_NO_JAVA_STYLE_ITERATORS
-DQT_NO_EXCEPTIONS -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -DQT_NO_DEBUG
-DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_CORE_LIB
gb_Executable_EXT := .html
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: solenv/bin
solenv/bin/modules/installer/remover.pm|8 -
solenv/bin/modules/par2script/converter.pm | 64 -
solenv/bin/modules/par2script/parameter.pm |1
solenv/bin/modules/par2script/remover.pm | 24 ---
solenv/bin/modules/par2script/systemactions.pm | 170 -
solenv/bin/modules/pre2par/files.pm| 10 -
solenv/bin/modules/pre2par/parameter.pm| 14 +-
solenv/bin/modules/pre2par/remover.pm | 24 ---
solenv/bin/modules/pre2par/systemactions.pm| 111
solenv/bin/modules/pre2par/work.pm | 39 -
solenv/bin/pre2par.pl |6
11 files changed, 11 insertions(+), 460 deletions(-)
New commits:
commit a04bb13513ea64fef867365d6eb0264970d58182
Author: Christian Lohmaier
AuthorDate: Thu May 27 15:40:41 2021 +0200
Commit: Christian Lohmaier
CommitDate: Thu May 27 19:10:19 2021 +0200
installer-code: remove some unused or pointless subs
of course just the very tip of the iceberg, but you gotta start
somewhere…
Change-Id: I24ef6a51ec70c70418368da54595637283055d84
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116255
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier
diff --git a/solenv/bin/modules/installer/remover.pm
b/solenv/bin/modules/installer/remover.pm
index 1e088a63e0a1..426056eef37f 100644
--- a/solenv/bin/modules/installer/remover.pm
+++ b/solenv/bin/modules/installer/remover.pm
@@ -40,14 +40,6 @@ sub remove_leading_and_ending_quotationmarks
$$stringref =~ s/\"\s*$//;
}
-sub remove_leading_and_ending_slashes
-{
-my ( $stringref ) = @_;
-
-$$stringref =~ s/^\s*\///g;
-$$stringref =~ s/\/\s*$//g;
-}
-
sub remove_ending_pathseparator
{
my ( $stringref ) = @_;
diff --git a/solenv/bin/modules/par2script/converter.pm
b/solenv/bin/modules/par2script/converter.pm
index d8323f40dc37..43c3a751f14a 100644
--- a/solenv/bin/modules/par2script/converter.pm
+++ b/solenv/bin/modules/par2script/converter.pm
@@ -25,29 +25,6 @@ use par2script::remover;
# Converter
#
-sub convert_array_to_hash
-{
-my ($arrayref) = @_;
-
-my ($line, $key, $value);
-
-my %newhash = ();
-
-for ( my $i = 0; $i <= $#{$arrayref}; $i++ )
-{
-$line = ${$arrayref}[$i];
-
-if ( $line =~ /^\s*(\w+?)\s+(.*?)\s*$/ )
-{
-$key = $1;
-$value = $2;
-$newhash{$key} = $value;
-}
-}
-
-return \%newhash;
-}
-
sub convert_stringlist_into_array_2
{
my ( $input, $separator ) = @_;
@@ -72,45 +49,4 @@ sub convert_stringlist_into_array_2
return \@newarray;
}
-sub convert_stringlist_into_array
-{
-my ( $includestringref, $separator ) = @_;
-
-my @newarray = ();
-my ($first, $last);
-
-$last = ${$includestringref};
-
-while ( $last =~ /^\s*(.+?)\s*\Q$separator\E\s*(.+)\s*$/) # "$" for
minimal matching
-{
-$first = $1;
-$last = $2;
-par2script::remover::remove_leading_and_ending_whitespaces(\$first);
-push(@newarray, $first);
-}
-
-par2script::remover::remove_leading_and_ending_whitespaces(\$last);
-push(@newarray, $last);
-
-return \@newarray;
-}
-
-#
-# The file name contains for some files "/". If this programs runs on
-# a windows platform, this has to be converted to "\".
-#
-
-sub convert_slash_to_backslash
-{
-my ($filesarrayref) = @_;
-
-my ($onefile, $filename);
-
-for ( my $i = 0; $i <= $#{$filesarrayref}; $i++ )
-{
-$onefile = ${$filesarrayref}[$i];
-$onefile->{'Name'} =~ s/\//\\/g;
-}
-}
-
1;
diff --git a/solenv/bin/modules/par2script/parameter.pm
b/solenv/bin/modules/par2script/parameter.pm
index 645b28255686..86416cd9e265 100644
--- a/solenv/bin/modules/par2script/parameter.pm
+++ b/solenv/bin/modules/par2script/parameter.pm
@@ -22,7 +22,6 @@ package par2script::parameter;
use Cwd;
use par2script::files;
use par2script::globals;
-use par2script::systemactions;
# Parameter Operations
diff --git a/solenv/bin/modules/par2script/remover.pm
b/solenv/bin/modules/par2script/remover.pm
index 4625bf0b0405..8b40a8ff46f7 100644
--- a/solenv/bin/modules/par2script/remover.pm
+++ b/solenv/bin/modules/par2script/remover.pm
@@ -39,28 +39,4 @@ sub remove_leading_and_ending_comma
$$stringref =~ s/\,\s*$//g;
}
-sub remove_leading_and_ending_quotationmarks
-{
-my ( $stringref ) = @_;
-
-$$stringref =~ s/^\s*\"//g;
-$$stringref =~ s/\"\s*$//g;
-}
-
-sub remove_leading_and_ending_slashes
-{
-my ( $stringref ) = @_;
-
-$$stringref =~ s/^\s*\///g;
-$$stringref =~ s/\/\s*$//g;
-}
-
-sub remove_leading_and_ending_backslashes
-{
-my ( $stringref ) = @_;
-
-
[Libreoffice-commits] core.git: connectivity/source
connectivity/source/drivers/mysqlc/mysqlc_preparedstatement.cxx | 58
+-
1 file changed, 29 insertions(+), 29 deletions(-)
New commits:
commit cb7bf2ce168bc262d324e62888934cdf4113170d
Author: Noel Grandin
AuthorDate: Thu May 27 15:12:39 2021 +0200
Commit: Noel Grandin
CommitDate: Thu May 27 18:52:04 2021 +0200
VisualStudio 16.10 doesn't like this construction
Change-Id: Idfef618b43735c48c9132d2fb932bc3bcb2ffe9c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116250
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/connectivity/source/drivers/mysqlc/mysqlc_preparedstatement.cxx
b/connectivity/source/drivers/mysqlc/mysqlc_preparedstatement.cxx
index c65b8365d35b..a50b14bbb3b4 100644
--- a/connectivity/source/drivers/mysqlc/mysqlc_preparedstatement.cxx
+++ b/connectivity/source/drivers/mysqlc/mysqlc_preparedstatement.cxx
@@ -95,7 +95,7 @@ Sequence SAL_CALL OPreparedStatement::getTypes()
Reference SAL_CALL OPreparedStatement::getMetaData()
{
MutexGuard aGuard(m_aMutex);
-checkDisposed(OPreparedStatement::rBHelper.bDisposed);
+checkDisposed(rBHelper.bDisposed);
if (!m_xMetaData.is())
{
@@ -109,7 +109,7 @@ Reference SAL_CALL
OPreparedStatement::getMetaData()
void SAL_CALL OPreparedStatement::close()
{
MutexGuard aGuard(m_aMutex);
-checkDisposed(OPreparedStatement::rBHelper.bDisposed);
+checkDisposed(rBHelper.bDisposed);
if (mysql_stmt_close(m_pStmt))
{
@@ -124,7 +124,7 @@ void SAL_CALL OPreparedStatement::close()
sal_Bool SAL_CALL OPreparedStatement::execute()
{
MutexGuard aGuard(m_aMutex);
-checkDisposed(OPreparedStatement::rBHelper.bDisposed);
+checkDisposed(rBHelper.bDisposed);
if (!m_binds.empty() && mysql_stmt_bind_param(m_pStmt, m_binds.data()))
{
@@ -149,7 +149,7 @@ sal_Bool SAL_CALL OPreparedStatement::execute()
sal_Int32 SAL_CALL OPreparedStatement::executeUpdate()
{
MutexGuard aGuard(m_aMutex);
-checkDisposed(OPreparedStatement::rBHelper.bDisposed);
+checkDisposed(rBHelper.bDisposed);
if (!m_binds.empty() && mysql_stmt_bind_param(m_pStmt, m_binds.data()))
{
@@ -176,7 +176,7 @@ sal_Int32 SAL_CALL OPreparedStatement::executeUpdate()
void SAL_CALL OPreparedStatement::setString(sal_Int32 parameter, const
OUString& x)
{
MutexGuard aGuard(m_aMutex);
-checkDisposed(OPreparedStatement::rBHelper.bDisposed);
+checkDisposed(rBHelper.bDisposed);
checkParameterIndex(parameter);
OString stringie(OUStringToOString(x,
m_xConnection->getConnectionEncoding()));
@@ -191,7 +191,7 @@ void SAL_CALL OPreparedStatement::setString(sal_Int32
parameter, const OUString&
Reference SAL_CALL OPreparedStatement::getConnection()
{
MutexGuard aGuard(m_aMutex);
-checkDisposed(OPreparedStatement::rBHelper.bDisposed);
+checkDisposed(rBHelper.bDisposed);
return m_xConnection;
}
@@ -199,7 +199,7 @@ Reference SAL_CALL
OPreparedStatement::getConnection()
Reference SAL_CALL OPreparedStatement::executeQuery()
{
MutexGuard aGuard(m_aMutex);
-checkDisposed(OPreparedStatement::rBHelper.bDisposed);
+checkDisposed(rBHelper.bDisposed);
if (!m_binds.empty() && mysql_stmt_bind_param(m_pStmt, m_binds.data()))
{
@@ -226,7 +226,7 @@ Reference SAL_CALL
OPreparedStatement::executeQuery()
void SAL_CALL OPreparedStatement::setBoolean(sal_Int32 parameter, sal_Bool x)
{
MutexGuard aGuard(m_aMutex);
-checkDisposed(OPreparedStatement::rBHelper.bDisposed);
+checkDisposed(rBHelper.bDisposed);
checkParameterIndex(parameter);
const sal_Int32 nIndex = parameter - 1;
@@ -238,7 +238,7 @@ void SAL_CALL OPreparedStatement::setBoolean(sal_Int32
parameter, sal_Bool x)
void SAL_CALL OPreparedStatement::setByte(sal_Int32 parameter, sal_Int8 x)
{
MutexGuard aGuard(m_aMutex);
-checkDisposed(OPreparedStatement::rBHelper.bDisposed);
+checkDisposed(rBHelper.bDisposed);
checkParameterIndex(parameter);
const sal_Int32 nIndex = parameter - 1;
@@ -250,7 +250,7 @@ void SAL_CALL OPreparedStatement::setByte(sal_Int32
parameter, sal_Int8 x)
void SAL_CALL OPreparedStatement::setDate(sal_Int32 parameter, const Date&
aData)
{
MutexGuard aGuard(m_aMutex);
-checkDisposed(OPreparedStatement::rBHelper.bDisposed);
+checkDisposed(rBHelper.bDisposed);
checkParameterIndex(parameter);
MYSQL_TIME my_time = {};
@@ -268,7 +268,7 @@ void SAL_CALL OPreparedStatement::setDate(sal_Int32
parameter, const Date& aData
void SAL_CALL OPreparedStatement::setTime(sal_Int32 parameter, const Time&
aVal)
{
MutexGuard aGuard(m_aMutex);
-checkDisposed(OPreparedStatement::rBHelper.bDisposed);
+checkDisposed(rBHelper.bDisposed);
checkParameterIndex(parameter);
MYSQL_TIME my_time = {};
@@ -286,7 +286,7 @@ void SAL_CALL OPreparedStatement::setTime(sal_Int32
parameter, const Time& aVal)
void SAL_CALL OPreparedStatement::setTimestamp(sal_Int32 parameter, const
[Libreoffice-bugs] [Bug 142528] TexMaths allow resize with selected text
https://bugs.documentfoundation.org/show_bug.cgi?id=142528 V Stuart Foote changed: What|Removed |Added CC||dante19031...@gmail.com, ||rolan...@free.fr, ||vstuart.fo...@utsa.edu Component|Writer |Extensions URL||https://sourceforge.net/p/t ||exmaths/bugs --- Comment #1 from V Stuart Foote --- @Roland, for you... and by the way, thanks for a great OOo extension! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139537] Image drops out of frame when moving image & caption frame to certain spot
https://bugs.documentfoundation.org/show_bug.cgi?id=139537 Gabor Kelemen changed: What|Removed |Added CC||kelem...@ubuntu.com --- Comment #15 from Gabor Kelemen --- Strange... I can't reproduce this in the latest bibisect-7.2 master. https://git.libreoffice.org/core/+/c96c386c5db45dc4d5e358915caad7474e373068 tdf#136516 add positioning to SwTextBoxHelper::syncProperty() seemed to be the first to fix this problem in February, but then it was somehow broken again per comment #14. Now it seems to be fixed again since: https://git.libreoffice.org/core/+/5812fb81013cc124a9b6a0b9912a34cc715fc495 tdf#138782 DOCX import: fix frame positions of old docs which would be somewhat unrelated by nature. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114734] Comment direction lost on saving-then-reloading a .docx
https://bugs.documentfoundation.org/show_bug.cgi?id=114734 Gabor Kelemen changed: What|Removed |Added CC||unami2...@gmail.com --- Comment #7 from Gabor Kelemen --- *** Bug 142518 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142518] Inserting comment with RTL is not applied with DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=142518 Gabor Kelemen changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Gabor Kelemen --- *** This bug has been marked as a duplicate of bug 114734 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/htmlexport/htmlexport.cxx| 13 +
sw/source/filter/html/htmlflywriter.cxx |2
sw/source/filter/html/htmlreqifreader.cxx | 67 --
sw/source/filter/html/htmlreqifreader.hxx |4 -
4 files changed, 79 insertions(+), 7 deletions(-)
New commits:
commit ff1f80e025a7c235e3960affe1b9db844c89c214
Author: Miklos Vajna
AuthorDate: Thu May 27 16:54:59 2021 +0200
Commit: Miklos Vajna
CommitDate: Thu May 27 18:20:43 2021 +0200
sw XHTML / reqif export, RTF markup of images: write objdata
The native data is BMP, presentation data is not yet done.
Change-Id: I30ef9f0c3b4dc7801e600ac751c32179372d5e4e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116266
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/sw/qa/extras/htmlexport/htmlexport.cxx
b/sw/qa/extras/htmlexport/htmlexport.cxx
index 1fba03321840..9ff771a7d43c 100644
--- a/sw/qa/extras/htmlexport/htmlexport.cxx
+++ b/sw/qa/extras/htmlexport/htmlexport.cxx
@@ -149,6 +149,7 @@ OLE1Reader::OLE1Reader(SvStream& rStream)
{
// Skip ObjectHeader, see [MS-OLEDS] 2.2.4.
rStream.Seek(0);
+CPPUNIT_ASSERT(rStream.remainingSize());
sal_uInt32 nData;
rStream.ReadUInt32(nData); // OLEVersion
rStream.ReadUInt32(nData); // FormatID
@@ -162,6 +163,11 @@ OLE1Reader::OLE1Reader(SvStream& rStream)
rStream.ReadUInt32(m_nNativeDataSize);
rStream.SeekRel(m_nNativeDataSize);
+if (!rStream.remainingSize())
+{
+return;
+}
+
rStream.ReadUInt32(nData); // OLEVersion for presentation data
CPPUNIT_ASSERT(rStream.good());
rStream.ReadUInt32(nData); // FormatID
@@ -1477,6 +1483,13 @@ CPPUNIT_TEST_FIXTURE(SwHtmlDomExportTest,
testReqifImageToOle)
// - Actual : 0
// i.e. the image was exported as PNG, not as WMF (with a version).
CPPUNIT_ASSERT_EQUAL(8, xReader->getWmetafile());
+
+// Make sure that the native data byte array is not empty.
+SvMemoryStream aOle1;
+CPPUNIT_ASSERT(xReader->WriteObjectData(aOle1));
+// Without the accompanying fix in place, this test would have failed, as
aOle1 was empty.
+OLE1Reader aOle1Reader(aOle1);
+CPPUNIT_ASSERT(aOle1Reader.m_nNativeDataSize);
}
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sw/source/filter/html/htmlflywriter.cxx
b/sw/source/filter/html/htmlflywriter.cxx
index 725ec85f8393..d2ab65efc7dc 100644
--- a/sw/source/filter/html/htmlflywriter.cxx
+++ b/sw/source/filter/html/htmlflywriter.cxx
@@ -1878,7 +1878,7 @@ static Writer& OutHTML_FrameFormatGrfNode( Writer& rWrt,
const SwFrameFormat& rF
aFileName = aURL.GetMainURL(INetURLObject::DecodeMechanism::NONE);
SvFileStream aOutStream(aFileName, StreamMode::WRITE);
-if (!SwReqIfReader::WrapGraphicInRtf(aGraphic, pGrfNd->GetTwipSize(),
aOutStream))
+if (!SwReqIfReader::WrapGraphicInRtf(aGraphic, rFrameFormat,
aOutStream))
SAL_WARN("sw.html", "SwReqIfReader::WrapGraphicInRtf() failed");
// Refer to this data.
diff --git a/sw/source/filter/html/htmlreqifreader.cxx
b/sw/source/filter/html/htmlreqifreader.cxx
index 8dd62d25d831..81f980b8ca37 100644
--- a/sw/source/filter/html/htmlreqifreader.cxx
+++ b/sw/source/filter/html/htmlreqifreader.cxx
@@ -496,12 +496,73 @@ bool WrapOleInRtf(SvStream& rOle2, SvStream& rRtf,
SwOLENode& rOLENode,
return true;
}
-bool WrapGraphicInRtf(const Graphic& rGraphic, const Size& rLogicSize,
SvStream& rRtf)
+bool WrapGraphicInRtf(const Graphic& rGraphic, const SwFrameFormat& rFormat,
SvStream& rRtf)
{
// Start object.
rRtf.WriteCharPtr("{" OOO_STRING_SVTOOLS_RTF_OBJECT);
rRtf.WriteCharPtr(OOO_STRING_SVTOOLS_RTF_OBJEMB);
+// Object size: as used in the document model (not pixel size)
+Size aSize = rFormat.GetFrameSize().GetSize();
+sal_uInt32 nWidth = aSize.getWidth();
+sal_uInt32 nHeight = aSize.getHeight();
+rRtf.WriteCharPtr(OOO_STRING_SVTOOLS_RTF_OBJW);
+rRtf.WriteOString(OString::number(nWidth));
+rRtf.WriteCharPtr(OOO_STRING_SVTOOLS_RTF_OBJH);
+rRtf.WriteOString(OString::number(nHeight));
+rRtf.WriteOString(SAL_NEWLINE_STRING);
+
+// Start objclass.
+rRtf.WriteCharPtr("{" OOO_STRING_SVTOOLS_RTF_IGNORE
OOO_STRING_SVTOOLS_RTF_OBJCLASS " ");
+OString aClassName("PBrush");
+rRtf.WriteOString(aClassName);
+// End objclass.
+rRtf.WriteCharPtr("}");
+rRtf.WriteOString(SAL_NEWLINE_STRING);
+
+// Start objdata.
+rRtf.WriteCharPtr("{" OOO_STRING_SVTOOLS_RTF_IGNORE
OOO_STRING_SVTOOLS_RTF_OBJDATA " ");
+
+SvMemoryStream aOle1;
+// Write ObjectHeader, see [MS-OLEDS] 2.2.4.
+// OLEVersion.
+aOle1.WriteUInt32(0x0501);
+
+// FormatID is EmbeddedObject.
+aOle1.WriteUInt32(0x0002);
+
+// ClassName
+aOle1.WriteUInt32(aClassName.getLength() + 1);
+aOle1.WriteOString(aClassName);
+// Null terminated pascal string.
+aOle1.WriteChar(0);
+
+//
[Libreoffice-bugs] [Bug 142524] Minor aesthetic change: Command search results should use triangle (▸) to indicate sequence
https://bugs.documentfoundation.org/show_bug.cgi?id=142524 Adolfo Jayme changed: What|Removed |Added Priority|medium |lowest -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142524] Minor aesthetic change: Command search results should use triangle (▸) to indicate sequence
https://bugs.documentfoundation.org/show_bug.cgi?id=142524 --- Comment #2 from Adolfo Jayme --- It exists in DejaVu (which we ship and can fallback on), as well as in SF Pro (macOS), Source, and other Windows system fonts (although not yet in Segoe UI Variable from Windows Dev build 21376… but Windows displays OK, ATM; I’ve tested LO in my Insider install). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3/gtkinst.cxx | 91 ---
1 file changed, 78 insertions(+), 13 deletions(-)
New commits:
commit 0344ee3f72fe6d155933b609d2963cf3f4bf4d7e
Author: Caolán McNamara
AuthorDate: Thu May 27 14:39:00 2021 +0100
Commit: Caolán McNamara
CommitDate: Thu May 27 18:06:11 2021 +0200
gtk4: old GtkImage can be new GtkImage or GtkPicture
change to GtkPicture under some circumstances. GtkImage will
force a square image so try and use GtkPicture for the non-icon
case.
The About dialog shows the need to use unscaled image if using
GdkTexture.
Change-Id: Iceb1e7dee5b53c93ceb432618fdda5650863029f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116256
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index bf417426914a..4fd5e509fa1f 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -3989,13 +3989,11 @@ namespace
Size aSize(rImageSurface.GetOutputSizePixel());
-double x_scale(1.0), y_scale(1.0);
-cairo_surface_get_device_scale(surface, _scale, _scale);
+// seems unfortunately to lose the potentially hidpi image here
cairo_surface_t* target = cairo_surface_create_similar_image(surface,
CAIRO_FORMAT_ARGB32,
-
aSize.Width() * x_scale,
-
aSize.Height() * y_scale);
-cairo_surface_set_device_scale(target, x_scale, y_scale);
+
aSize.Width(),
+
aSize.Height());
cairo_t* cr = cairo_create(target);
cairo_set_source_surface(cr, surface, 0, 0);
@@ -10467,6 +10465,47 @@ public:
}
};
+#if GTK_CHECK_VERSION(4, 0, 0)
+class GtkInstancePicture: public GtkInstanceWidget, public virtual weld::Image
+{
+private:
+GtkPicture* m_pPicture;
+
+public:
+GtkInstancePicture(GtkPicture* pPicture, GtkInstanceBuilder* pBuilder,
bool bTakeOwnership)
+: GtkInstanceWidget(GTK_WIDGET(pPicture), pBuilder, bTakeOwnership)
+, m_pPicture(pPicture)
+{
+gtk_picture_set_can_shrink(m_pPicture, true);
+}
+
+virtual void set_from_icon_name(const OUString& rIconName) override
+{
+GdkPixbuf* pixbuf = load_icon_by_name(rIconName);
+if (!pixbuf)
+return;
+gtk_picture_set_pixbuf(m_pPicture, pixbuf);
+g_object_unref(pixbuf);
+}
+
+virtual void set_image(VirtualDevice* pDevice) override
+{
+if (!pDevice)
+gtk_picture_set_paintable(m_pPicture, nullptr);
+else
+gtk_picture_set_paintable(m_pPicture,
GDK_PAINTABLE(texture_new_from_virtual_device(*pDevice)));
+}
+
+virtual void set_image(const css::uno::Reference&
rPicture) override
+{
+GdkPixbuf* pixbuf = getPixbuf(rPicture);
+gtk_picture_set_pixbuf(m_pPicture, pixbuf);
+if (pixbuf)
+g_object_unref(pixbuf);
+}
+};
+#endif
+
class GtkInstanceCalendar : public GtkInstanceWidget, public virtual
weld::Calendar
{
private:
@@ -18570,10 +18609,14 @@ struct ConvertResult
{
bool m_bChildCanFocus;
bool m_bChildIsDefaultInvisible;
+bool m_bHasIconName;
-ConvertResult(bool bChildCanFocus, bool bChildIsDefaultInvisible)
+ConvertResult(bool bChildCanFocus,
+ bool bChildIsDefaultInvisible,
+ bool bHasIconName)
: m_bChildCanFocus(bChildCanFocus)
, m_bChildIsDefaultInvisible(bChildIsDefaultInvisible)
+, m_bHasIconName(bHasIconName)
{
}
};
@@ -18582,13 +18625,14 @@ ConvertResult Convert3To4(const
Reference& xNode)
{
css::uno::Reference xNodeList =
xNode->getChildNodes();
if (!xNodeList.is())
-return ConvertResult(false, false);
+return ConvertResult(false, false, false);
std::vector> xRemoveList;
OUString sBorderWidth;
bool bChildCanFocus = false;
bool bChildIsDefaultInvisible = true;
+bool bHasIconName = false;
css::uno::Reference xCantFocus;
css::uno::Reference xChild = xNode->getFirstChild();
@@ -18657,6 +18701,9 @@ ConvertResult Convert3To4(const
Reference& xNode)
if (sName == "visible")
bChildIsDefaultInvisible = false;
+if (sName == "icon-name")
+bHasIconName = true;
+
if (sName == "activates-default")
{
if (GetParentObjectType(xChild) == "GtkSpinButton")
@@ -18894,6 +18941,7 @@ ConvertResult Convert3To4(const
Reference& xNode)
auto xNextChild = xChild->getNextSibling();
+bool bChildHasIconName = false;
if
[Libreoffice-commits] core.git: Branch 'private/jmux/wasm_for_master_catchall' - external/libnumbertext Repository.mk RepositoryModule_host.mk solenv/gbuild wasm-qt/Module_wasm-qt.mk
Repository.mk |1 + RepositoryModule_host.mk|1 + external/libnumbertext/ExternalProject_libnumbertext.mk |2 +- solenv/gbuild/platform/EMSCRIPTEN_INTEL_GCC.mk |8 +--- wasm-qt/Module_wasm-qt.mk |4 5 files changed, 8 insertions(+), 8 deletions(-) New commits: commit c458a071e9c02fa4c6a0f7fe6be5cead518b9f59 Author: Jan-Marek Glogowski AuthorDate: Thu May 27 18:01:35 2021 +0200 Commit: Jan-Marek Glogowski CommitDate: Thu May 27 18:01:35 2021 +0200 Fix qt example and numbertext link Change-Id: I49670d2de880a3034f074b7d338dee6f803f3f04 diff --git a/Repository.mk b/Repository.mk index b234ae7ed69c..8917c46b92c2 100644 --- a/Repository.mk +++ b/Repository.mk @@ -82,6 +82,7 @@ $(eval $(call gb_Helper_register_executables,NONE, \ mtfdemo \ visualbackendtest \ $(if $(and $(ENABLE_GTK3), $(filter LINUX %BSD SOLARIS,$(OS))), gtktiledviewer) \ +$(if $(filter EMSCRIPTEN,$(OS)),wasm-qt5-mandelbrot) \ )) $(eval $(call gb_Helper_register_executables_for_install,SDK,sdk, \ diff --git a/RepositoryModule_host.mk b/RepositoryModule_host.mk index 9aaedfd66ee8..b26979a4b225 100644 --- a/RepositoryModule_host.mk +++ b/RepositoryModule_host.mk @@ -184,6 +184,7 @@ $(eval $(call gb_Module_add_moduledirs,libreoffice,\ uui \ vbahelper \ vcl \ +$(if $(filter EMSCRIPTEN,$(OS)),wasm-qt) \ wizards \ writerfilter \ writerperfect \ diff --git a/external/libnumbertext/ExternalProject_libnumbertext.mk b/external/libnumbertext/ExternalProject_libnumbertext.mk index 3094351aebf2..eae3f34dc412 100644 --- a/external/libnumbertext/ExternalProject_libnumbertext.mk +++ b/external/libnumbertext/ExternalProject_libnumbertext.mk @@ -16,7 +16,7 @@ $(eval $(call gb_ExternalProject_register_targets,libnumbertext,\ build \ )) -libnumbertext_CXXFLAGS=$(CXXFLAGS) $(CXXFLAGS_CXX11) +libnumbertext_CXXFLAGS=$(CXXFLAGS) $(CXXFLAGS_CXX11) $(gb_EMSCRIPTEN_CPPFLAGS) ifneq (,$(filter ANDROID DRAGONFLY FREEBSD iOS LINUX NETBSD OPENBSD,$(OS))) ifneq (,$(gb_ENABLE_DBGUTIL)) diff --git a/solenv/gbuild/platform/EMSCRIPTEN_INTEL_GCC.mk b/solenv/gbuild/platform/EMSCRIPTEN_INTEL_GCC.mk index 3a7441454f0d..12f63fe78c62 100644 --- a/solenv/gbuild/platform/EMSCRIPTEN_INTEL_GCC.mk +++ b/solenv/gbuild/platform/EMSCRIPTEN_INTEL_GCC.mk @@ -14,7 +14,7 @@ include $(GBUILDDIR)/platform/unxgcc.mk gb_RUN_CONFIGURE := $(SRCDIR)/solenv/bin/run-configure # avoid -s SAFE_HEAP=1 - c.f. gh#8584 this breaks source maps gb_EMSCRIPTEN_CPPFLAGS := -pthread -s TOTAL_MEMORY=1GB -s USE_PTHREADS=1 -s PTHREAD_POOL_SIZE=4 -gb_EMSCRIPTEN_LDFLAGS := $(gb_EMSCRIPTEN_CPPFLAGS) --bind -s ERROR_ON_UNDEFINED_SYMBOLS=1 -s FETCH=1 -s ASSERTIONS=2 -s EXIT_RUNTIME=1 -s EXTRA_EXPORTED_RUNTIME_METHODS=["UTF16ToString","stringToUTF16"] +gb_EMSCRIPTEN_LDFLAGS := $(gb_EMSCRIPTEN_CPPFLAGS) --bind -s ERROR_ON_UNDEFINED_SYMBOLS=1 -s FETCH=1 -s ASSERTIONS=2 -s EXIT_RUNTIME=0 -s EXTRA_EXPORTED_RUNTIME_METHODS=["UTF16ToString","stringToUTF16"] gb_EMSCRIPTEN_QTDEFS := -DQT_NO_LINKED_LIST -DQT_NO_JAVA_STYLE_ITERATORS -DQT_NO_EXCEPTIONS -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_CORE_LIB gb_Executable_EXT := .html @@ -27,8 +27,10 @@ gb_LinkTarget_LDFLAGS += $(gb_EMSCRIPTEN_LDFLAGS) $(gb_EMSCRIPTEN_CPPFLAGS) $(gb # Linker and compiler optimize + debug flags are handled in LinkTarget.mk gb_LINKEROPTFLAGS := gb_LINKERSTRIPDEBUGFLAGS := -# This maps to g4, AKA source maps. The LO default would otherwise be g2! -gb_DEBUGINFO_FLAGS = -g +# This maps to g3, no source maps, but DWARF with current emscripten! +# https://developer.chrome.com/blog/wasm-debugging-2020/ +gb_DEBUGINFO_FLAGS = -g3 +#gb_DEBUGINFO_FLAGS = -gsource-map --source-map-base=file://$(WORKDIR)/LinkTarget/Executable # We need at least code elimination, otherwise linking OOMs even with 64GB. # So we "fake" -Og support to mean -O1 for Emscripten and always enable it for debug in configure. gb_COMPILERDEBUGOPTFLAGS := -O1 diff --git a/wasm-qt/Module_wasm-qt.mk b/wasm-qt/Module_wasm-qt.mk index 8e86df4e8baa..72da667363aa 100644 --- a/wasm-qt/Module_wasm-qt.mk +++ b/wasm-qt/Module_wasm-qt.mk @@ -8,13 +8,9 @@ $(eval $(call gb_Module_Module,wasm-qt)) -ifeq ($(OS),EMSCRIPTEN) - $(eval $(call gb_Module_add_targets,wasm-qt,\ CustomTarget_wasm-qt5-mandelbrot_moc \ Executable_wasm-qt5-mandelbrot \ )) -endif - # vim: set noet sw=4 ts=4: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: configure.ac
configure.ac | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
New commits:
commit 816a181086e75506bca34797429057fca5f2b0d5
Author: Jan-Marek Glogowski
AuthorDate: Tue May 25 15:25:30 2021 +0200
Commit: Jan-Marek Glogowski
CommitDate: Thu May 27 17:55:01 2021 +0200
configure: drop --disable-neon
Use --with-webdav instead, which supports neon, serf or no and is
available since commit dcae0509135c2067635ae3cf84b05dc9fb3d2d02
("Build webdav based on serf if neon is disabled.") from 2014.
Change-Id: I4b329b9c1d28e88961e86272a5554bfa4481f01e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116142
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
diff --git a/configure.ac b/configure.ac
index 4df7fd83d1c0..c4dc0c5545fe 100644
--- a/configure.ac
+++ b/configure.ac
@@ -815,6 +815,7 @@ test_cairo=no
test_gdb_index=no
test_split_debug=no
test_openldap=yes
+test_webdav=yes
# Default values, as such probably valid just for Linux, set
# differently below just for Mac OSX, but at least better than
@@ -968,6 +969,7 @@ ios*) # iOS
test_fontconfig=no
test_dbus=no
test_openldap=no
+test_webdav=no
if test -n "$LODE_HOME" ; then
mac_sanitize_path
AC_MSG_NOTICE([sanitized the PATH to $PATH])
@@ -1088,6 +1090,7 @@ linux-android*)
test_gtk3_kde5=no
test_openldap=no
test_randr=no
+test_webdav=no
test_xrender=no
_os=Android
@@ -1124,6 +1127,7 @@ emscripten)
test_freetype=no
test_gtk=no
test_randr=no
+test_webdav=no
test_xrender=no
enable_postgresql_sdbc=no
enable_firebird_sdbc=no
@@ -1647,11 +1651,6 @@ libo_FUZZ_ARG_ENABLE(gstreamer-1-0,
[Disable building with the gstreamer 1.0 avmedia backend.]),
,test "${enable_gstreamer_1_0+set}" = set || enable_gstreamer_1_0=yes)
-libo_FUZZ_ARG_ENABLE(neon,
-AS_HELP_STRING([--disable-neon],
-[Disable neon and the compilation of webdav binding.]),
-,)
-
libo_FUZZ_ARG_ENABLE([eot],
[AS_HELP_STRING([--enable-eot],
[Enable support for Embedded OpenType fonts.])],
@@ -2339,9 +2338,7 @@ AC_ARG_WITH(webdav,
AS_HELP_STRING([--with-webdav],
[Specify which library to use for webdav implementation.
Possible values: "neon", "serf", "no". The default value is "neon".
- Example: --with-webdav="serf"]),
-WITH_WEBDAV=$withval,
-WITH_WEBDAV="neon")
+ Example: --with-webdav="serf"]))
AC_ARG_WITH(linker-hash-style,
AS_HELP_STRING([--with-linker-hash-style],
@@ -10721,14 +10718,17 @@ AC_SUBST(XRANDR_CFLAGS)
AC_SUBST(XRANDR_LIBS)
AC_SUBST(ENABLE_RANDR)
-if test "$enable_neon" = "no" -o "$enable_mpl_subset" = "yes"; then
-if test -z "$WITH_WEBDAV"; then
-WITH_WEBDAV="serf"
+if test "$test_webdav" = yes; then
+if test -z "$with_webdav"; then
+WITH_WEBDAV=neon
+if test "$enable_mpl_subset" = yes; then
+WITH_WEBDAV=serf
+fi
+else
+WITH_WEBDAV="$with_webdav"
fi
fi
-if test $_os = iOS -o $_os = Android; then
-WITH_WEBDAV="no"
-fi
+
AC_MSG_CHECKING([for webdav library])
case "$WITH_WEBDAV" in
serf)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 142477] improve resizing column behavior: currently lacking preview and minimal width
https://bugs.documentfoundation.org/show_bug.cgi?id=142477 steve changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|DUPLICATE |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142517] Feature to disable autolayouts on Impress master slides
https://bugs.documentfoundation.org/show_bug.cgi?id=142517 --- Comment #8 from Regina Henschel --- (In reply to Heiko Tietze from comment #4) > Regina, what's your take here? You can delete footer area, date/time and slide number without problems. But the fact, that they do not exist any longer is not reflected in the "Header and Footer" dialog of menu Insert. You can use item 'Master Elements' in menu Slide to insert footer, date/time or number at individual slides, although they are not available in the associated master. There is a large mess around these elements. There had already been discussions about them some time ago, without result. Footer area, date/time and slide number do not have individual styles, but they are covered by presentation style 'Background objects'. You can currently not delete title or content, because that area is used for setting their text format. Direct formatting of the text is transferred to the according style. Each of them has a associated presentation style. Changing the style when not in master slide mode, changes the currently used master slide. There exists no area for subtitle, bug 102318. The relevant parts of ODF are: presentation:class, presentation:placeholder and presentation:footer-decl, presentation:header-decl, presentation:date/time-decl. @Thorsten: A hierarchical tree of master pages is currently not possible in ODF, because the needed attribute style:parent-style-name does not exist for master pages. There exist a similar request for Writer, bug 41316 and duplicates. But it would be possible to use a style:default-style element and make it accessible to the user. "new from example" would be immediately possible without having a true link to a parent. >From point of users, the whole area of "master slide" is confusing. I think, that a general new concept is needed. Is there already a META bug about master pages/slides? We need a proposal from design team and a general discussion outside of individual bugs. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141769] Crash in: cppu::OInterfaceContainerHelper::disposeAndClear(com::sun::star::lang::EventObject const &)
https://bugs.documentfoundation.org/show_bug.cgi?id=141769 --- Comment #20 from Xisco Faulí --- Question for those reporting this issue, which is your java version in Tools - Options - Advanced, if any ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141769] Crash in: cppu::OInterfaceContainerHelper::disposeAndClear(com::sun::star::lang::EventObject const &)
https://bugs.documentfoundation.org/show_bug.cgi?id=141769 --- Comment #19 from Xisco Faulí --- *** Bug 142022 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142022] Invalid pointer crash on closing Calc in VclBuilder::disposeBuilder
https://bugs.documentfoundation.org/show_bug.cgi?id=142022 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #41 from Xisco Faulí --- This looks like a dupe of bug 141769 *** This bug has been marked as a duplicate of bug 141769 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
ESC meeting minutes: 2021-05-27
* Present: + Hossein, Stephan, Eike, Olivier, Caolan, Cloph, Sophie, Guilhem, Xisco, Heiko, Miklos, Gabriel, Thorsten * Completed Action Items: + ESC bug stats, chart ranges don’t show data past 2019-08-13 (Xisco) * Pending Action Items: + None * Release Engineering update (Cloph) + 7.2: will not have alpha 2, beta 1 is in 2 weeks + no late feature requests yet + 7.1 status: 7.1.4 rc2 will be tagged next week + Remotes: Android, iOS + Android viewer * Documentation (Olivier) + New Help (No news) + Helpcontents2 + New pages for ScriptForge (LibreOfficiant, R. Lima) + Update on some Calc functions (S. Fanning, Ohallot, R Lima) + Update on NatNum (Eike) + Guides + Published Calc Guide 7.1 * UX Update (Heiko) + Bugzilla (topicUI) statistics 250(250) (topicUI) bugs open, 188(188) (needsUXEval) needs to be evaluated by the UXteam + Updates: BZ changes 1 week1 month 3 months 12 months added 4(3) 9(-3)27(-1) 89(-6) commented 117(94) 320(52) 928(80)3755(27) removed 3(0) 7(2) 14(3) 33(3) resolved 18(8) 54(2)133(8) 508(9) + top 10 contributors: Heiko Tietze made 279 changes in 1 month, and 2391 changes in 1 year Foote, V Stuart made 52 changes in 1 month, and 603 changes in 1 year Dieter made 44 changes in 1 month, and 415 changes in 1 year Xisco Fauli made 37 changes in 1 month, and 232 changes in 1 year Telesto made 27 changes in 1 month, and 854 changes in 1 year Ilmari Lauhakangas made 21 changes in 1 month, and 373 changes in 1 year Kaganski, Mike made 21 changes in 1 month, and 191 changes in 1 year Eyal Rozenberg made 20 changes in 1 month, and 77 changes in 1 year Timur made 20 changes in 1 month, and 160 changes in 1 year BogdanB made 19 changes in 1 month, and 160 changes in 1 year + 9 new tickets with needsUXEval May/20-27 -> [Bug 142514] Inconsistent use and non-antialiased graphical representation and of rotation wheels + removal the rotation wheel? + -45 degree, what will the effect? (Heiko) + perhaps remove it only from the sidebar? [Bug 142499] new 'fat cross' cursor motif for bug 104169, default cell selection cursor should be selectable [Bug 142489] Do not display "Table" toolbar by default in Impress [Bug 142441] UI: Table properties borders doesn't show top border if row selected -> [Bug 142440] Merge cells with different border styles create unexpected result (Writer) + seems the right / bottom borders are missing for merged cells + would move towards Word’s render result with this + sounds good (Miklos) [Bug 142423] Adjust the default LibO heading sizes to avoid rounding/up down on DOCX export (causing layout shifts) => in discussion/new [Bug 142403] Differences in the 'sidebar settings' icon design [Bug 139768] The "no fill" checkbox in Highlight Color dialog does not show its actual status => NAB [Bug 142450] LibreOffice Writer Configuration + View menu + Normal or Web view + Remember .uno:Show/HideWhiteSpace across sessions => easyhack + new mouse cursor in Calc + didn’t see it live yet (Eike) + could a user configure it? (Xisco) + the os theme provides it usually (Heiko) + will file a ticket to be more configurable + prefer not reverting * Crash Testing (Caolan) + 23(+6) import failure, 11(+3) export failures + two keynote import asserts, probably should be warns + some new calc issues have appeared, commented on changeset where one of them began: https://gerrit.libreoffice.org/c/core/+/115789 Samuel? + 1 coverity issues + 19 ossfuzz issues + slight improvement * Crash Reporting (Xisco) + https://crashreport.libreoffice.org/stats/version/7.0.5.2 + (-345) 1996 2341 2234 2258 2072 1926 1878 1425 1392 1100 358 0 + https://crashreport.libreoffice.org/stats/version/7.0.6.2 + (+341) 234 0 + https://crashreport.libreoffice.org/stats/version/7.1.2.2 + (-1387) 4696 6083 7140 8516 7429 5495 3968 2046 0 + https://crashreport.libreoffice.org/stats/version/7.1.3.2 + (+1748) 5427 3679 1730 0 - https://crashreport.libreoffice.org/stats/signature/cppu::OInterfaceContainerHelper::disposeAndClear(com::sun::star::lang::EventObject%20const%20&)https://crashreport.libreoffice.org/stats/signature/cppu::OInterfaceContainerHelper::disposeAndClear(com::sun::star::lang::EventObject%20const%20&) - https://bugs.documentfoundation.org/show_bug.cgi?id=141769 - the steps are easy: after closing
[Libreoffice-qa] ESC meeting minutes: 2021-05-27
* Present: + Hossein, Stephan, Eike, Olivier, Caolan, Cloph, Sophie, Guilhem, Xisco, Heiko, Miklos, Gabriel, Thorsten * Completed Action Items: + ESC bug stats, chart ranges don’t show data past 2019-08-13 (Xisco) * Pending Action Items: + None * Release Engineering update (Cloph) + 7.2: will not have alpha 2, beta 1 is in 2 weeks + no late feature requests yet + 7.1 status: 7.1.4 rc2 will be tagged next week + Remotes: Android, iOS + Android viewer * Documentation (Olivier) + New Help (No news) + Helpcontents2 + New pages for ScriptForge (LibreOfficiant, R. Lima) + Update on some Calc functions (S. Fanning, Ohallot, R Lima) + Update on NatNum (Eike) + Guides + Published Calc Guide 7.1 * UX Update (Heiko) + Bugzilla (topicUI) statistics 250(250) (topicUI) bugs open, 188(188) (needsUXEval) needs to be evaluated by the UXteam + Updates: BZ changes 1 week1 month 3 months 12 months added 4(3) 9(-3)27(-1) 89(-6) commented 117(94) 320(52) 928(80)3755(27) removed 3(0) 7(2) 14(3) 33(3) resolved 18(8) 54(2)133(8) 508(9) + top 10 contributors: Heiko Tietze made 279 changes in 1 month, and 2391 changes in 1 year Foote, V Stuart made 52 changes in 1 month, and 603 changes in 1 year Dieter made 44 changes in 1 month, and 415 changes in 1 year Xisco Fauli made 37 changes in 1 month, and 232 changes in 1 year Telesto made 27 changes in 1 month, and 854 changes in 1 year Ilmari Lauhakangas made 21 changes in 1 month, and 373 changes in 1 year Kaganski, Mike made 21 changes in 1 month, and 191 changes in 1 year Eyal Rozenberg made 20 changes in 1 month, and 77 changes in 1 year Timur made 20 changes in 1 month, and 160 changes in 1 year BogdanB made 19 changes in 1 month, and 160 changes in 1 year + 9 new tickets with needsUXEval May/20-27 -> [Bug 142514] Inconsistent use and non-antialiased graphical representation and of rotation wheels + removal the rotation wheel? + -45 degree, what will the effect? (Heiko) + perhaps remove it only from the sidebar? [Bug 142499] new 'fat cross' cursor motif for bug 104169, default cell selection cursor should be selectable [Bug 142489] Do not display "Table" toolbar by default in Impress [Bug 142441] UI: Table properties borders doesn't show top border if row selected -> [Bug 142440] Merge cells with different border styles create unexpected result (Writer) + seems the right / bottom borders are missing for merged cells + would move towards Word’s render result with this + sounds good (Miklos) [Bug 142423] Adjust the default LibO heading sizes to avoid rounding/up down on DOCX export (causing layout shifts) => in discussion/new [Bug 142403] Differences in the 'sidebar settings' icon design [Bug 139768] The "no fill" checkbox in Highlight Color dialog does not show its actual status => NAB [Bug 142450] LibreOffice Writer Configuration + View menu + Normal or Web view + Remember .uno:Show/HideWhiteSpace across sessions => easyhack + new mouse cursor in Calc + didn’t see it live yet (Eike) + could a user configure it? (Xisco) + the os theme provides it usually (Heiko) + will file a ticket to be more configurable + prefer not reverting * Crash Testing (Caolan) + 23(+6) import failure, 11(+3) export failures + two keynote import asserts, probably should be warns + some new calc issues have appeared, commented on changeset where one of them began: https://gerrit.libreoffice.org/c/core/+/115789 Samuel? + 1 coverity issues + 19 ossfuzz issues + slight improvement * Crash Reporting (Xisco) + https://crashreport.libreoffice.org/stats/version/7.0.5.2 + (-345) 1996 2341 2234 2258 2072 1926 1878 1425 1392 1100 358 0 + https://crashreport.libreoffice.org/stats/version/7.0.6.2 + (+341) 234 0 + https://crashreport.libreoffice.org/stats/version/7.1.2.2 + (-1387) 4696 6083 7140 8516 7429 5495 3968 2046 0 + https://crashreport.libreoffice.org/stats/version/7.1.3.2 + (+1748) 5427 3679 1730 0 - https://crashreport.libreoffice.org/stats/signature/cppu::OInterfaceContainerHelper::disposeAndClear(com::sun::star::lang::EventObject%20const%20&)https://crashreport.libreoffice.org/stats/signature/cppu::OInterfaceContainerHelper::disposeAndClear(com::sun::star::lang::EventObject%20const%20&) - https://bugs.documentfoundation.org/show_bug.cgi?id=141769 - the steps are easy: after closing
[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - sfx2/classification
sfx2/classification/example_sl-SI.xml |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3766e78348d52b9491179c32e9062e25e58250f7 Author: Caolán McNamara AuthorDate: Thu May 27 11:13:29 2021 +0100 Commit: Adolfo Jayme Barrientos CommitDate: Thu May 27 16:45:13 2021 +0200 add missing xmlns:loext to example_sl-SI.xml added to example.xml by commit 71ee09947d5a71105d64fd225bb3672dfa7ce834 Date: Tue Sep 19 15:37:04 2017 +0200 TSCP: add advanced classification dialog but not to example_sl-SI.xml Change-Id: I8aa46554867db8c51bd118b6cc87e649b922cdfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116157 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/sfx2/classification/example_sl-SI.xml b/sfx2/classification/example_sl-SI.xml index 99e04a7aab71..13a4bcfdf29a 100644 --- a/sfx2/classification/example_sl-SI.xml +++ b/sfx2/classification/example_sl-SI.xml @@ -1,5 +1,5 @@ - + Avtoriteta primera politike TSCP Primer politike TSCP ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 126540] EDITING The document remains in not modified state after we switch the View Grid Lines
https://bugs.documentfoundation.org/show_bug.cgi?id=126540 Attila Szűcs changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |szucs.atti...@nisz.hu |desktop.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112752] [META] XLSX (OOXML) sheet-level bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=112752 Bug 112752 depends on bug 126541, which changed state. Bug 126541 Summary: FILEOPEN XLSX Grid lines do not appear after changing View Grid Lines if the document was saved with hidden grid lines https://bugs.documentfoundation.org/show_bug.cgi?id=126541 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126541] FILEOPEN XLSX Grid lines do not appear after changing View Grid Lines if the document was saved with hidden grid lines
https://bugs.documentfoundation.org/show_bug.cgi?id=126541 Attila Szűcs changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |szucs.atti...@nisz.hu |desktop.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80430] [META] Documentation gap for new features
https://bugs.documentfoundation.org/show_bug.cgi?id=80430 Olivier Hallot changed: What|Removed |Added Depends on||142417 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=142417 [Bug 142417] Online Help: "File Conversion Filter Names" page should contain an "API Name" column -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142417] Online Help: "File Conversion Filter Names" page should contain an "API Name" column
https://bugs.documentfoundation.org/show_bug.cgi?id=142417 Olivier Hallot changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Blocks||80430 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=80430 [Bug 80430] [META] Documentation gap for new features -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125502] Changing database through "exchange database" creates *.odb-files for unusable fileformats
https://bugs.documentfoundation.org/show_bug.cgi?id=125502 --- Comment #6 from Robert Großkopf --- Bug is still the same in LO 7.1.3.2 on OpenSUSE 15.2 64bit rpm Linux. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56266] FILESAVE: "Track/record changes": interdependentant revision marks not correctly saved to ODT file
https://bugs.documentfoundation.org/show_bug.cgi?id=56266 Xisco Faulí changed: What|Removed |Added Severity|major |normal CC||xiscofa...@libreoffice.org Priority|high|medium --- Comment #10 from Xisco Faulí --- Hi Timur, why was it set to High/Highest ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142150] Application crashes when EDITING line end styles (arrows)
https://bugs.documentfoundation.org/show_bug.cgi?id=142150 Xisco Faulí changed: What|Removed |Added Priority|highest |high Severity|critical|major -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142147] Password protection on Writer malfunctioning
https://bugs.documentfoundation.org/show_bug.cgi?id=142147 Timur changed: What|Removed |Added Priority|medium |low --- Comment #7 from Timur --- I see. That's why I asked reporter to confirm. Doesn't look like a bug to me. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142517] Feature to disable autolayouts on Impress master slides
https://bugs.documentfoundation.org/show_bug.cgi?id=142517 --- Comment #7 from Thorsten Wagner --- And what to do if position and size of the different areas is different depending on kind of slide? Example: Title slide with large title area in the middle, mabe with an additional subtitle and content slide with small title area on top Furthermore text attributes are lost without copying. All attributes are reset to default and have to be adjusted again. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/ui/miscdlgs/datatableview.cxx | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
New commits:
commit 0643e5a3accc01e0ee7a2359ec283ced8d0cf0ab
Author: tushar
AuthorDate: Sat May 15 12:04:13 2021 +0530
Commit: Mike Kaganski
CommitDate: Thu May 27 15:47:39 2021 +0200
tdf#135332 Return MAXROW/MAXCOL for rows/columns out of range.
*Also change the number of rows to MAXROW in Row Header Control.
Change-Id: Ie34361442a0944f62abbc9bb273a9efe72773c57
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115642
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sc/source/ui/miscdlgs/datatableview.cxx
b/sc/source/ui/miscdlgs/datatableview.cxx
index 2541688a6677..3c88ac65b290 100644
--- a/sc/source/ui/miscdlgs/datatableview.cxx
+++ b/sc/source/ui/miscdlgs/datatableview.cxx
@@ -90,7 +90,7 @@ void ScDataTableColView::HideEntries(SCCOLROW nPos, SCCOLROW
nEndPos)
ScDataTableRowView::ScDataTableRowView(vcl::Window* pParent, SelectionEngine*
pSelectionEngine):
-ScHeaderControl(pParent, pSelectionEngine, 1024, true, nullptr),
+ScHeaderControl(pParent, pSelectionEngine, 1048576, true, nullptr),
mpDoc(nullptr),
mnRow(0)
{
@@ -218,7 +218,7 @@ SCCOL findColFromPos(sal_uInt16 nPixelPos, const
ScDocument* pDoc, SCCOL nStartC
}
SAL_WARN("sc", "Could not find the corresponding column");
-return -1;
+return MAXCOL;
}
SCROW findRowFromPos(sal_uInt16 nPixelPos, const ScDocument* pDoc, SCROW
nStartRow = 0)
@@ -238,7 +238,7 @@ SCROW findRowFromPos(sal_uInt16 nPixelPos, const
ScDocument* pDoc, SCROW nStartR
}
SAL_WARN("sc", "Could not find the corresponding row");
-return -1;
+return MAXROW;
}
}
@@ -321,13 +321,13 @@ IMPL_LINK(ScDataTableView, ScrollHdl, ScrollBar*,
pScrollBar, void)
if (pScrollBar == mpVScroll.get())
{
mnFirstVisibleRow = pScrollBar->GetThumbPos();
-pScrollBar->SetRangeMax(mnFirstVisibleRow + 100);
+pScrollBar->SetRangeMax(std::min(
MAXROW,static_cast(mnFirstVisibleRow + 100 )));
mpRowView->SetPos(mnFirstVisibleRow);
}
else
{
mnFirstVisibleCol = pScrollBar->GetThumbPos();
-pScrollBar->SetRangeMax(mnFirstVisibleCol + 50);
+pScrollBar->SetRangeMax(std::min(
MAXCOL,static_cast(mnFirstVisibleCol + 50 )));
mpColView->SetPos(mnFirstVisibleCol);
}
Invalidate();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3/gtkinst.cxx | 120 +++
1 file changed, 111 insertions(+), 9 deletions(-)
New commits:
commit 8596312d8f298cfddb6dda11a25669fb78372d4f
Author: Caolán McNamara
AuthorDate: Thu May 27 09:41:42 2021 +0100
Commit: Caolán McNamara
CommitDate: Thu May 27 15:43:28 2021 +0200
gtk4: reenable menubutton
not really expected to work yet
Change-Id: I27fe5ecd8f78017dd669aeba0c1d8db797e91e3e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116237
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index 3261cec30275..bf417426914a 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -8588,7 +8588,13 @@ GtkPositionType show_menu(GtkWidget* pMenuButton,
GtkWindow* pMenu)
return ePosUsed;
}
+#endif
+
+#if !GTK_CHECK_VERSION(4, 0, 0)
class GtkInstanceMenuButton : public GtkInstanceToggleButton, public
MenuHelper, public virtual weld::MenuButton
+#else
+class GtkInstanceMenuButton : public GtkInstanceToggleButton, public virtual
weld::MenuButton
+#endif
{
protected:
GtkMenuButton* m_pMenuButton;
@@ -8612,6 +8618,7 @@ private:
void toggle_menu()
{
+#if !GTK_CHECK_VERSION(4, 0, 0)
if (!m_pMenuHack)
return;
if (!get_active())
@@ -8653,8 +8660,10 @@ private:
// tdf#132540 keep the placeholder popover on this same side as
the replacement menu
gtk_popover_set_position(gtk_menu_button_get_popover(m_pMenuButton), ePosUsed);
}
+#endif
}
+#if !GTK_CHECK_VERSION(4, 0, 0)
static void signalGrabBroken(GtkWidget*, GdkEventGrabBroken *pEvent,
gpointer widget)
{
GtkInstanceMenuButton* pThis =
static_cast(widget);
@@ -8724,33 +8733,65 @@ private:
}
return false;
}
+#endif
void ensure_image_widget()
{
if (!m_pImage)
{
m_pImage = GTK_IMAGE(gtk_image_new());
+#if !GTK_CHECK_VERSION(4, 0, 0)
gtk_box_pack_start(m_pBox, GTK_WIDGET(m_pImage), false, false, 0);
gtk_box_reorder_child(m_pBox, GTK_WIDGET(m_pImage), 0);
+#else
+gtk_box_prepend(m_pBox, GTK_WIDGET(m_pImage));
+#endif
gtk_widget_show(GTK_WIDGET(m_pImage));
}
}
+#if GTK_CHECK_VERSION(4, 0, 0)
+static GtkWidget* find_image_widget(GtkWidget* pContainer)
+{
+GtkWidget* pImage = nullptr;
+for (GtkWidget* pChild = gtk_widget_get_first_child(pContainer);
+ pChild; pChild = gtk_widget_get_next_sibling(pChild))
+{
+if (GTK_IS_IMAGE(pChild))
+{
+pImage = pChild;
+break;
+}
+else
+{
+pImage = find_image_widget(pChild);
+if (pImage)
+break;
+}
+}
+return pImage;
+}
+#endif
+
static void find_image(GtkWidget *pWidget, gpointer user_data)
{
+GtkImage **ppImage = static_cast(user_data);
if (GTK_IS_IMAGE(pWidget))
-{
-GtkImage **ppImage = static_cast(user_data);
*ppImage = GTK_IMAGE(pWidget);
-}
-else if (GTK_IS_CONTAINER(pWidget))
+#if GTK_CHECK_VERSION(4, 0, 0)
+*ppImage = GTK_IMAGE(find_image_widget(pWidget));
+#else
+if (GTK_IS_CONTAINER(pWidget))
gtk_container_forall(GTK_CONTAINER(pWidget), find_image,
user_data);
+#endif
}
public:
GtkInstanceMenuButton(GtkMenuButton* pMenuButton, GtkWidget* pMenuAlign,
GtkInstanceBuilder* pBuilder, bool bTakeOwnership)
: GtkInstanceToggleButton(GTK_TOGGLE_BUTTON(pMenuButton), pBuilder,
bTakeOwnership)
+#if !GTK_CHECK_VERSION(4, 0, 0)
, MenuHelper(gtk_menu_button_get_popup(pMenuButton), false)
+#endif
, m_pMenuButton(pMenuButton)
, m_pImage(nullptr)
, m_pMenuHack(nullptr)
@@ -8758,7 +8799,11 @@ public:
, m_pPopover(nullptr)
, m_nSignalId(0)
{
+#if !GTK_CHECK_VERSION(4, 0, 0)
m_pLabel = gtk_bin_get_child(GTK_BIN(m_pMenuButton));
+#else
+m_pLabel = find_label_widget(GTK_WIDGET(m_pMenuButton));
+#endif
find_image(GTK_WIDGET(m_pMenuButton), _pImage);
m_pBox = formatMenuButton(m_pLabel);
}
@@ -8803,69 +8848,98 @@ public:
virtual void insert_item(int pos, const OUString& rId, const OUString&
rStr,
const OUString* pIconName, VirtualDevice*
pImageSurface, TriState eCheckRadioFalse) override
{
+#if !GTK_CHECK_VERSION(4, 0, 0)
MenuHelper::insert_item(pos, rId, rStr, pIconName, pImageSurface,
eCheckRadioFalse);
+#endif
}
virtual void insert_separator(int pos, const OUString& rId) override
{
+#if !GTK_CHECK_VERSION(4, 0, 0)
MenuHelper::insert_separator(pos, rId);
+#endif
}
virtual void remove_item(const
