[Libreoffice-bugs] [Bug 143206] Libreoffice on plasma works really bad

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143206

--- Comment #17 from giors...@yahoo.it ---
(In reply to Henrique SantAnna from comment #14)
> (In reply to giors_00 from comment #11)
> > (In reply to Buovjaga from comment #10)
> > > (In reply to giors_00 from comment #9)
> > > > > 
> > > > > Maybe you could try adding it to /etc/profile.d/libreoffice-fresh.sh 
> > > > > as
> > > > > explained in https://wiki.archlinux.org/title/LibreOffice#Theme 
> > > > 
> > > > Don't know why but it doesn't work. Really does nothing
> > > 
> > > Can you copy and paste here the contents of the .sh file with your edits?
> > 
> > # to force a certain look'n feel
> > 
> > #export SAL_USE_VCLPLUGIN=gen
> > #export SAL_USE_VCLPLUGIN=gtk3_kde5
> > #export SAL_USE_VCLPLUGIN=kf5
> > #export SAL_USE_VCLPLUGIN=qt5
> > #export SAL_USE_VCLPLUGIN=gtk3
> > export QT_QPA_PLATFORM=xcb
> 
> DON'T DO THAT !!!
> 
> You should not add 'export QT_QPA_PLATFORM=xcb' to /etc/profile.d/
> 
> This will affect ALL SOFTWARE based on Qt (e.g. ALL KDE SOFTWARE), causing
> it to run on a undesired way.

Thanks! Already commented
> 
> There are plenty ways of setting a variable to affect only LibreOffice, and
> you should not do that inside /etc/profile.d/


Can you suggest one, please?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 143206] Libreoffice on plasma works really bad

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143206

--- Comment #16 from giors...@yahoo.it ---
(In reply to Buovjaga from comment #13)
> Now I tested with Arch Linux + KDE Plasma + Wayland and I can not reproduce
> any of the problems mentioned in the original description. I am not using
> QT_QPA_PLATFORM=xcb
> 
> Arch Linux 64-bit
> Version: 7.1.4.2 / LibreOffice Community
> Build ID: 10(Build:2)
> CPU threads: 8; OS: Linux 5.12; UI render: default; VCL: kf5
> Locale: en-US (C); UI: en-US
> 7.1.4-1
> Calc: threaded

Can you confirm at least that double mouse click select text?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: vcl/qt5

2021-07-20 Thread Michael Weghorn (via logerrit)
 vcl/qt5/Qt5AccessibleWidget.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit add4f7732840d362cb703ee3a894edfe2fd0eac3
Author: Michael Weghorn 
AuthorDate: Wed Jul 21 05:54:44 2021 +0200
Commit: Michael Weghorn 
CommitDate: Wed Jul 21 07:43:22 2021 +0200

qt5 a11y: Handle AccessibleStateType::MULTI_LINE

This addresses warnings like

warn:vcl.qt5:53343:53343:vcl/qt5/Qt5AccessibleWidget.cxx:639: Unmapped 
state: 17

seen e.g. when navigating to a Writer paragraph in Accerciser when
using LO with the kf5 VCL plugin.

With this in place, the "multi line" state is correctly shown in
Accerciser.

Change-Id: Ib38a7374d9c81f2d5c361809583f711f4eadccba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119295
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/vcl/qt5/Qt5AccessibleWidget.cxx b/vcl/qt5/Qt5AccessibleWidget.cxx
index fdce6e41fc87..ee93bc6a21de 100644
--- a/vcl/qt5/Qt5AccessibleWidget.cxx
+++ b/vcl/qt5/Qt5AccessibleWidget.cxx
@@ -590,6 +590,9 @@ void lcl_addState(QAccessible::State* state, sal_Int16 
nState)
 case AccessibleStateType::MOVEABLE:
 state->movable = true;
 break;
+case AccessibleStateType::MULTI_LINE:
+state->multiLine = true;
+break;
 case AccessibleStateType::OPAQUE:
 // No match
 break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 139451] Open Template dialog does not display full file name

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139451

--- Comment #3 from Dale Eltoft  ---
This problem has been resolved by changes in the recent 7.1.4.2 version or
earlier.

Can be closed WFM

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 143206] Libreoffice on plasma works really bad

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143206

--- Comment #15 from Buovjaga  ---
(In reply to Henrique SantAnna from comment #14)
> (In reply to giors_00 from comment #11)
> > (In reply to Buovjaga from comment #10)
> > > (In reply to giors_00 from comment #9)
> > > > > 
> > > > > Maybe you could try adding it to /etc/profile.d/libreoffice-fresh.sh 
> > > > > as
> > > > > explained in https://wiki.archlinux.org/title/LibreOffice#Theme 
> > > > 
> > > > Don't know why but it doesn't work. Really does nothing
> > > 
> > > Can you copy and paste here the contents of the .sh file with your edits?
> > 
> > # to force a certain look'n feel
> > 
> > #export SAL_USE_VCLPLUGIN=gen
> > #export SAL_USE_VCLPLUGIN=gtk3_kde5
> > #export SAL_USE_VCLPLUGIN=kf5
> > #export SAL_USE_VCLPLUGIN=qt5
> > #export SAL_USE_VCLPLUGIN=gtk3
> > export QT_QPA_PLATFORM=xcb
> 
> DON'T DO THAT !!!
> 
> You should not add 'export QT_QPA_PLATFORM=xcb' to /etc/profile.d/
> 
> This will affect ALL SOFTWARE based on Qt (e.g. ALL KDE SOFTWARE), causing
> it to run on a undesired way.
> 
> There are plenty ways of setting a variable to affect only LibreOffice, and
> you should not do that inside /etc/profile.d/
> 
> Suggesting that someone do this is irresponsible and is not based on any
> official documentation.

Thanks for explaining and sorry for being irresponsible. I didn't know how
profile.d works, that all the scripts are executed by the shell and that it's
not tied to the application.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 143221] Menu/Toolbar entry to show hidden character

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143221

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 139130] EDITING : Unability to select text zone without 4 or five click

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139130

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 139130] EDITING : Unability to select text zone without 4 or five click

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139130

--- Comment #4 from QA Administrators  ---
Dear Eric Menonville,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 139451] Open Template dialog does not display full file name

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139451

--- Comment #2 from QA Administrators  ---
Dear Dale Eltoft,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 88930] QUERY column type thought to be TEXT when coming from subquery

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88930

--- Comment #12 from QA Administrators  ---
Dear Lionel Elie Mamane,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 126457] FILEOPEN XLSX VBA macro to switch between active documents does not work

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126457

--- Comment #6 from QA Administrators  ---
Dear NISZ LibreOffice Team,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 116994] Undo isn't working for a comment which was shown at the moment adding a new sheet

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116994

--- Comment #7 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: vcl/qt5

2021-07-20 Thread Michael Weghorn (via logerrit)
 vcl/qt5/Qt5AccessibleWidget.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 7be0f62de07aa3a046f0996eeb673d9a4d7c9672
Author: Michael Weghorn 
AuthorDate: Tue Jul 20 13:29:32 2021 +0200
Commit: Michael Weghorn 
CommitDate: Wed Jul 21 04:08:27 2021 +0200

qt5 a11y: Handle AccessibleStateType::MOVEABLE

This addresses warnings like

warn:vcl.qt5:151782:151782:vcl/qt5/Qt5AccessibleWidget.cxx:636: 
Unmapped state: 31

which I started seeing when running LO with kf5 VCL plugin and Orca
enabled after

commit ddbc111555607e62b94b74aacadd6a964b9fe4a5
Author: Michael Weghorn 
Date:   Mon Jul 19 17:13:04 2021 +0200

qt5 a11y: Set proper a11y states

had fixed handling of a11y states.

Change-Id: I00b8f2f75954fbd7d9e5f0807b51e5632d1a8035
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119248
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/vcl/qt5/Qt5AccessibleWidget.cxx b/vcl/qt5/Qt5AccessibleWidget.cxx
index 6e104a43d6e0..fdce6e41fc87 100644
--- a/vcl/qt5/Qt5AccessibleWidget.cxx
+++ b/vcl/qt5/Qt5AccessibleWidget.cxx
@@ -587,6 +587,9 @@ void lcl_addState(QAccessible::State* state, sal_Int16 
nState)
 case AccessibleStateType::MODAL:
 state->modal = true;
 break;
+case AccessibleStateType::MOVEABLE:
+state->movable = true;
+break;
 case AccessibleStateType::OPAQUE:
 // No match
 break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: 2 commits - vcl/qt5

2021-07-20 Thread Michael Weghorn (via logerrit)
 vcl/qt5/Qt5AccessibleWidget.cxx |   22 +-
 1 file changed, 13 insertions(+), 9 deletions(-)

New commits:
commit 6c88244908409e1d5a4ffe5fffbad35f9892b9fa
Author: Michael Weghorn 
AuthorDate: Tue Jul 20 12:47:38 2021 +0200
Commit: Michael Weghorn 
CommitDate: Wed Jul 21 04:08:10 2021 +0200

qt5 a11y: Skip attributes without value

Skip attributes with empty string value in
'Qt5AccessibleWidget::attributes'.

Besides not being a useful value, I also
got a crash using Accerciser to navigate in Calc's
"Format Cells" dialog -> "Font Effects" -> "Text Decoration"
-> "Overlining" -> "Overlining".

'Qt5AccessibleWidget::attributes' had returned
"font-family:;font-size:0pt;font-weight:normal;"
and 'AtSpiAdaptor::getAttributes' (from the Qt library)
aborts, since it splits the "font-family:" part at the colon,
then expects two substrings: one for the attribute name, one
for the value - but there was no value set:

QString joined = interface->textInterface()->attributes(offset, 
, );
const QStringList attributes = joined.split (QLatin1Char(';'), 
Qt::SkipEmptyParts, Qt::CaseSensitive);
for (const QString  : attributes) {
QStringList items;
items = attr.split(QLatin1Char(':'), Qt::SkipEmptyParts, 
Qt::CaseSensitive);
->  AtSpiAttribute attribute = atspiTextAttribute(items[0], items[1]);
if (!attribute.isNull())
set[attribute.name] = attribute.value;
}

The IAccessible2 spec for the "background-color" text attribute [1]
doesn't specify any default value to be used.

Backtrace:

Thread 1 received signal SIGABRT, Aborted.
__GI_raise (sig=sig@entry=6) at 
../sysdeps/unix/sysv/linux/raise.c:50
50  ../sysdeps/unix/sysv/linux/raise.c: No such file or 
directory.
(rr) bt
#0  __GI_raise (sig=sig@entry=6) at 
../sysdeps/unix/sysv/linux/raise.c:50
#1  0x7f4dcd0bd537 in __GI_abort () at abort.c:79
#2  0x7f4dba7fd810 in qt_message_fatal(QtMsgType, 
QMessageLogContext const&, QString const&) (context=..., message=...) at 
global/qlogging.cpp:1914
#3  0x7f4dba7f9d48 in QMessageLogger::fatal(char const*, ...) const 
(this=0x7ffc30a4a6b0, msg=0x7f4dbab9ebb0 "ASSERT failure in %s: \"%s\", file 
%s, line %d") at global/qlogging.cpp:893
#4  0x7f4dba7f1484 in qt_assert_x(char const*, char const*, char 
const*, int) (where=0x7f4db778eb36 "QList::operator[]", what=0x7f4db778eac8 
"index out of range", file=0x7f4db778ea90 
"../../../include/QtCore/../../src/corelib/tools/qlist.h", line=579)
at global/qglobal.cpp:3366
#5  0x7f4db7736a65 in QList::operator[](int) 
(this=0x7ffc30a4a730, i=1) at 
../../../include/QtCore/../../src/corelib/tools/qlist.h:579
#6  0x7f4db773017e in 
AtSpiAdaptor::getAttributes(QAccessibleInterface*, int, bool) const 
(this=0x557748f27800, interface=0x7f4d8c07cc30, offset=9, includeDefaults=true) 
at atspiadaptor.cpp:2059
#7  0x7f4db772cd74 in 
AtSpiAdaptor::textInterface(QAccessibleInterface*, QString const&, QDBusMessage 
const&, QDBusConnection const&) (this=0x557748f27800, interface=0x7f4d8c07cc30, 
function=..., message=..., connection=...) at atspiadaptor.cpp:1802
#8  0x7f4db77274f8 in AtSpiAdaptor::handleMessage(QDBusMessage 
const&, QDBusConnection const&) (this=0x557748f27800, message=..., 
connection=...) at atspiadaptor.cpp:1286
#9  0x7f4db7fe4d04 in 
QDBusConnectionPrivate::activateObject(QDBusConnectionPrivate::ObjectTreeNode&, 
QDBusMessage const&, int) (this=0x7f4d8c014b00, node=..., msg=..., 
pathStartPos=27) at qdbusintegrator.cpp:1458
#10 0x7f4db7fe58ca in 
QDBusActivateObjectEvent::placeMetaCall(QObject*) (this=0x557753615310) at 
qdbusintegrator.cpp:1617
#11 0x7f4dbaab3c66 in QObject::event(QEvent*) (this=0x557748f27800, 
e=0x557753615310) at kernel/qobject.cpp:1314
#12 0x7f4db96be845 in QApplicationPrivate::notify_helper(QObject*, 
QEvent*) (this=0x557747e30970, receiver=0x557748f27800, e=0x557753615310) at 
kernel/qapplication.cpp:3632
#13 0x7f4db96bbcfb in QApplication::notify(QObject*, QEvent*) 
(this=0x557747f1d8b0, receiver=0x557748f27800, e=0x557753615310) at 
kernel/qapplication.cpp:2972
#14 0x7f4dbaa70aba in QCoreApplication::notifyInternal2(QObject*, 
QEvent*) (receiver=0x557748f27800, event=0x557753615310) at 
kernel/qcoreapplication.cpp:1064
#15 0x7f4dbaa71452 in QCoreApplication::sendEvent(QObject*, 
QEvent*) (receiver=0x557748f27800, event=0x557753615310) at 
kernel/qcoreapplication.cpp:1462
#16 0x7f4dbaa7213a in 
QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) 
(receiver=0x0, event_type=0, data=0x557747eff460) at 
kernel/qcoreapplication.cpp:1821
#17 0x7f4dbaa71acc in 

[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - vcl/qt5

2021-07-20 Thread Jan-Marek Glogowski (via logerrit)
 vcl/qt5/Qt5Frame.cxx  |2 +-
 vcl/qt5/Qt5Widget.cxx |   12 ++--
 2 files changed, 11 insertions(+), 3 deletions(-)

New commits:
commit 7e6fee830116823b9cd8e46d6962df4ea2bc1ea6
Author: Jan-Marek Glogowski 
AuthorDate: Mon Jul 19 22:13:21 2021 +0200
Commit: Michael Weghorn 
CommitDate: Wed Jul 21 04:06:52 2021 +0200

Qt5 fix Qt::Popup window handling

I guess to get popup windows somehow working, they were matched
to Qt::ToolTip. Fixing that by removing SalFrameStyleFlags::FLOAT
from the tooltip check, resulted in rather bizarre bahviour. The
Qt::Popup window is modal, as documented, but wouldn't close when
clicked outside, like normal popups. And I neither got any mouse
button or focus events, just some leave or enter. The only way
to interact with anything again, was by clicking somewhere on the
popup where it can't take focus... and it has nothing to do with
the transition setting either.

In the end it turned out that Qt::StrongFocus prevented the mouse
events to happen. Even without it the widget accepts mouse and
keyboard focus, so nothing seems lost by omitting that for the
Qt::Popup case; hopefully...

Change-Id: Icda7bbe87268293a400fe0da551d2804675d4c2d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119236
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 
(cherry picked from commit 63f92f185b78db5a575da58efac3f94a8cb5a5f6)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119252
Reviewed-by: Michael Weghorn 

diff --git a/vcl/qt5/Qt5Frame.cxx b/vcl/qt5/Qt5Frame.cxx
index 322f293828cd..02032d149d29 100644
--- a/vcl/qt5/Qt5Frame.cxx
+++ b/vcl/qt5/Qt5Frame.cxx
@@ -144,7 +144,7 @@ Qt5Frame::Qt5Frame(Qt5Frame* pParent, SalFrameStyleFlags 
nStyle, bool bUseCairo)
 else if ((nStyle & SalFrameStyleFlags::FLOAT)
  && (nStyle & SalFrameStyleFlags::OWNERDRAWDECORATION))
 aWinFlags |= Qt::Tool | Qt::FramelessWindowHint;
-else if (nStyle & (SalFrameStyleFlags::FLOAT | 
SalFrameStyleFlags::TOOLTIP))
+else if (nStyle & SalFrameStyleFlags::TOOLTIP)
 aWinFlags |= Qt::ToolTip;
 else if ((nStyle & SalFrameStyleFlags::FLOAT)
  && !(nStyle & SalFrameStyleFlags::OWNERDRAWDECORATION))
diff --git a/vcl/qt5/Qt5Widget.cxx b/vcl/qt5/Qt5Widget.cxx
index 2e97132f5e75..93da76ecad76 100644
--- a/vcl/qt5/Qt5Widget.cxx
+++ b/vcl/qt5/Qt5Widget.cxx
@@ -177,7 +177,14 @@ void Qt5Widget::handleMouseButtonEvent(const Qt5Frame& 
rFrame, const QMouseEvent
 rFrame.CallCallback(nEventType, );
 }
 
-void Qt5Widget::mousePressEvent(QMouseEvent* pEvent) { 
handleMousePressEvent(m_rFrame, pEvent); }
+void Qt5Widget::mousePressEvent(QMouseEvent* pEvent)
+{
+if ((windowFlags() & Qt::Popup)
+&& !geometry().translated(geometry().topLeft() * 
-1).contains(pEvent->pos()))
+close();
+else
+handleMousePressEvent(m_rFrame, pEvent);
+}
 
 void Qt5Widget::mouseReleaseEvent(QMouseEvent* pEvent)
 {
@@ -601,7 +608,8 @@ Qt5Widget::Qt5Widget(Qt5Frame& rFrame, Qt::WindowFlags f)
 {
 create();
 setMouseTracking(true);
-setFocusPolicy(Qt::StrongFocus);
+if (!(f & Qt::Popup))
+setFocusPolicy(Qt::StrongFocus);
 }
 
 static ExtTextInputAttr lcl_MapUndrelineStyle(QTextCharFormat::UnderlineStyle 
us)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 143298] Writer: CTRL-TAB to cycle through suggestions for word completion does not work

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143298

--- Comment #16 from Commit Notification 
 ---
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/289ed73a2359f6221ca36c61cf96e4f4b72f61cc

tdf#143298 Qt5 send SalEvent::KeyModChange events

It will be available in 7.2.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 143298] Writer: CTRL-TAB to cycle through suggestions for word completion does not work

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143298

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.3.0|target:7.3.0 target:7.2.0.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - vcl/inc vcl/qt5

2021-07-20 Thread Jan-Marek Glogowski (via logerrit)
 vcl/inc/qt5/Qt5Frame.hxx |1 
 vcl/qt5/Qt5Frame.cxx |3 +
 vcl/qt5/Qt5Widget.cxx|   81 +++
 3 files changed, 85 insertions(+)

New commits:
commit 289ed73a2359f6221ca36c61cf96e4f4b72f61cc
Author: Jan-Marek Glogowski 
AuthorDate: Mon Jul 19 15:17:53 2021 +0200
Commit: Michael Weghorn 
CommitDate: Wed Jul 21 04:06:02 2021 +0200

tdf#143298 Qt5 send SalEvent::KeyModChange events

I originally omitted this in the Qt implementation, as I couldn't
find any non-working use case.

The implementation got a bit hacky, because Qt doesn't have a non-
native way to identify different L/R modifier keys, so we must
process the X11/xkb keycode ourself, which obviously won't work on
Wayland... but most times this is not relevant, so the default
modifier notification may be good enough.

P.S. it's basically the same code then X11 and Gtk...

Change-Id: I37fbfde4a33a966b6017f3e0c280e2c7ea91e4db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119235
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 
Reviewed-by: Jan-Marek Glogowski 
(cherry picked from commit 862fdb98ca271b60a831cd5420fd16d5f9c1c747)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119191

diff --git a/vcl/inc/qt5/Qt5Frame.hxx b/vcl/inc/qt5/Qt5Frame.hxx
index f90936528399..ed82c2a7a8fb 100644
--- a/vcl/inc/qt5/Qt5Frame.hxx
+++ b/vcl/inc/qt5/Qt5Frame.hxx
@@ -102,6 +102,7 @@ class VCLPLUG_QT5_PUBLIC Qt5Frame : public QObject, public 
SalFrame
 
 #if QT5_USING_X11
 ScreenSaverInhibitor m_ScreenSaverInhibitor;
+ModKeyFlags m_nKeyModifiers;
 #endif
 
 LanguageType m_nInputLanguage;
diff --git a/vcl/qt5/Qt5Frame.cxx b/vcl/qt5/Qt5Frame.cxx
index 6dc54d9408e3..322f293828cd 100644
--- a/vcl/qt5/Qt5Frame.cxx
+++ b/vcl/qt5/Qt5Frame.cxx
@@ -113,6 +113,9 @@ Qt5Frame::Qt5Frame(Qt5Frame* pParent, SalFrameStyleFlags 
nStyle, bool bUseCairo)
 , m_bDefaultPos(true)
 , m_bFullScreen(false)
 , m_bFullScreenSpanAll(false)
+#if QT5_USING_X11
+, m_nKeyModifiers(ModKeyFlags::NONE)
+#endif
 , m_nInputLanguage(LANGUAGE_DONTKNOW)
 {
 Qt5Instance* pInst = static_cast(GetSalData()->m_pInstance);
diff --git a/vcl/qt5/Qt5Widget.cxx b/vcl/qt5/Qt5Widget.cxx
index a2bf8fe6472d..2e97132f5e75 100644
--- a/vcl/qt5/Qt5Widget.cxx
+++ b/vcl/qt5/Qt5Widget.cxx
@@ -52,6 +52,11 @@
 #include 
 #include 
 
+#if QT5_USING_X11
+#define XK_MISCELLANY
+#include 
+#endif
+
 using namespace com::sun::star;
 
 void Qt5Widget::paintEvent(QPaintEvent* pEvent)
@@ -444,6 +449,82 @@ bool Qt5Widget::handleKeyEvent(Qt5Frame& rFrame, const 
QWidget& rWidget, QKeyEve
 return true;
 }
 
+if (nCode == 0)
+{
+sal_uInt16 nModCode = GetKeyModCode(pEvent->modifiers());
+SalKeyModEvent aModEvt;
+aModEvt.mbDown = eState == ButtonKeyState::Pressed;
+aModEvt.mnModKeyCode = ModKeyFlags::NONE;
+
+#if QT5_USING_X11
+if (QGuiApplication::platformName() == "xcb")
+{
+// pressing just the ctrl key leads to a keysym of XK_Control but
+// the event state does not contain ControlMask. In the release
+// event it's the other way round: it does contain the Control 
mask.
+// The modifier mode therefore has to be adapted manually.
+ModKeyFlags nExtModMask = ModKeyFlags::NONE;
+sal_uInt16 nModMask = 0;
+switch (pEvent->nativeVirtualKey())
+{
+case XK_Control_L:
+nExtModMask = ModKeyFlags::LeftMod1;
+nModMask = KEY_MOD1;
+break;
+case XK_Control_R:
+nExtModMask = ModKeyFlags::RightMod1;
+nModMask = KEY_MOD1;
+break;
+case XK_Alt_L:
+nExtModMask = ModKeyFlags::LeftMod2;
+nModMask = KEY_MOD2;
+break;
+case XK_Alt_R:
+nExtModMask = ModKeyFlags::RightMod2;
+nModMask = KEY_MOD2;
+break;
+case XK_Shift_L:
+nExtModMask = ModKeyFlags::LeftShift;
+nModMask = KEY_SHIFT;
+break;
+case XK_Shift_R:
+nExtModMask = ModKeyFlags::RightShift;
+nModMask = KEY_SHIFT;
+break;
+// Map Meta/Super keys to MOD3 modifier on all Unix systems
+// except macOS
+case XK_Meta_L:
+case XK_Super_L:
+nExtModMask = ModKeyFlags::LeftMod3;
+nModMask = KEY_MOD3;
+break;
+case XK_Meta_R:
+case XK_Super_R:
+nExtModMask = ModKeyFlags::RightMod3;
+nModMask = KEY_MOD3;
+break;
+ 

[Libreoffice-bugs] [Bug 143334] qt5/kf5: Broken rendering e.g. after using Calc's Borders toolbar item

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143334

--- Comment #6 from Commit Notification 
 ---
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/83f91ec066614c3c40282913898083d317edd072

tdf#143334 Qt5 don't reset buffer on style change

It will be available in 7.2.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 143334] qt5/kf5: Broken rendering e.g. after using Calc's Borders toolbar item

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143334

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.3.0|target:7.3.0 target:7.2.0.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - vcl/inc vcl/qt5

2021-07-20 Thread Jan-Marek Glogowski (via logerrit)
 vcl/inc/qt5/Qt5Frame.hxx |1 -
 vcl/qt5/Qt5Frame.cxx |8 ++--
 2 files changed, 2 insertions(+), 7 deletions(-)

New commits:
commit 83f91ec066614c3c40282913898083d317edd072
Author: Jan-Marek Glogowski 
AuthorDate: Mon Jul 19 23:28:47 2021 +0200
Commit: Michael Weghorn 
CommitDate: Wed Jul 21 04:05:09 2021 +0200

tdf#143334 Qt5 don't reset buffer on style change

This bug was "unveiled" by commit
963f252cd1ea9c268a6ced68a3454b10cbee1a89 ("Qt5/KF5 get rid
of unneeded own grahics handling"). I'm not sure why I ever came
up with that code. Eventually we would need a paint event, but at
least changing the theme correctly updated LO UI, so that seems
to be handled correctly.

Change-Id: I528b551180be184427eb2977e2b7da073ce6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119237
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 
(cherry picked from commit ec77a2ed0283cb3446f6e352fc329afd3dfb785c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119190

diff --git a/vcl/inc/qt5/Qt5Frame.hxx b/vcl/inc/qt5/Qt5Frame.hxx
index 62877e15e89a..f90936528399 100644
--- a/vcl/inc/qt5/Qt5Frame.hxx
+++ b/vcl/inc/qt5/Qt5Frame.hxx
@@ -83,7 +83,6 @@ class VCLPLUG_QT5_PUBLIC Qt5Frame : public QObject, public 
SalFrame
 bool m_bNullRegion;
 
 bool m_bGraphicsInUse;
-bool m_bGraphicsInvalid;
 SalFrameStyleFlags m_nStyle;
 Qt5Frame* m_pParent;
 PointerStyle m_ePointerStyle;
diff --git a/vcl/qt5/Qt5Frame.cxx b/vcl/qt5/Qt5Frame.cxx
index 36ce1222cb5e..6dc54d9408e3 100644
--- a/vcl/qt5/Qt5Frame.cxx
+++ b/vcl/qt5/Qt5Frame.cxx
@@ -105,7 +105,6 @@ Qt5Frame::Qt5Frame(Qt5Frame* pParent, SalFrameStyleFlags 
nStyle, bool bUseCairo)
 , m_bUseCairo(bUseCairo)
 , m_bNullRegion(true)
 , m_bGraphicsInUse(false)
-, m_bGraphicsInvalid(false)
 , m_ePointerStyle(PointerStyle::Arrow)
 , m_pDragSource(nullptr)
 , m_pDropTarget(nullptr)
@@ -296,7 +295,7 @@ SalGraphics* Qt5Frame::AcquireGraphics()
 
 if (m_bUseCairo)
 {
-if (!m_pSvpGraphics || m_bGraphicsInvalid)
+if (!m_pSvpGraphics)
 {
 QSize aSize = m_pQWidget->size() * devicePixelRatioF();
 m_pSvpGraphics.reset(new Qt5SvpGraphics(this));
@@ -306,20 +305,18 @@ SalGraphics* Qt5Frame::AcquireGraphics()
basegfx::B2IVector(aSize.width(), 
aSize.height()));
 cairo_surface_set_user_data(m_pSurface.get(), 
Qt5SvpGraphics::getDamageKey(),
 _aDamageHandler, nullptr);
-m_bGraphicsInvalid = false;
 }
 return m_pSvpGraphics.get();
 }
 else
 {
-if (!m_pQt5Graphics || m_bGraphicsInvalid)
+if (!m_pQt5Graphics)
 {
 m_pQt5Graphics.reset(new Qt5Graphics(this));
 m_pQImage.reset(
 new QImage(m_pQWidget->size() * devicePixelRatioF(), 
Qt5_DefaultFormat32));
 m_pQImage->fill(Qt::transparent);
 m_pQt5Graphics->ChangeQImage(m_pQImage.get());
-m_bGraphicsInvalid = false;
 }
 return m_pQt5Graphics.get();
 }
@@ -1153,7 +1150,6 @@ void Qt5Frame::UpdateSettings(AllSettings& rSettings)
 style.SetShadowColor(toColor(pal.color(QPalette::Disabled, 
QPalette::WindowText)));
 style.SetDarkShadowColor(toColor(pal.color(QPalette::Inactive, 
QPalette::WindowText)));
 
-m_bGraphicsInvalid = true;
 rSettings.SetStyleSettings(style);
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 143206] Libreoffice on plasma works really bad

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143206

--- Comment #14 from Henrique SantAnna  ---
(In reply to giors_00 from comment #11)
> (In reply to Buovjaga from comment #10)
> > (In reply to giors_00 from comment #9)
> > > > 
> > > > Maybe you could try adding it to /etc/profile.d/libreoffice-fresh.sh as
> > > > explained in https://wiki.archlinux.org/title/LibreOffice#Theme 
> > > 
> > > Don't know why but it doesn't work. Really does nothing
> > 
> > Can you copy and paste here the contents of the .sh file with your edits?
> 
> # to force a certain look'n feel
> 
> #export SAL_USE_VCLPLUGIN=gen
> #export SAL_USE_VCLPLUGIN=gtk3_kde5
> #export SAL_USE_VCLPLUGIN=kf5
> #export SAL_USE_VCLPLUGIN=qt5
> #export SAL_USE_VCLPLUGIN=gtk3
> export QT_QPA_PLATFORM=xcb

DON'T DO THAT !!!

You should not add 'export QT_QPA_PLATFORM=xcb' to /etc/profile.d/

This will affect ALL SOFTWARE based on Qt (e.g. ALL KDE SOFTWARE), causing it
to run on a undesired way.

There are plenty ways of setting a variable to affect only LibreOffice, and you
should not do that inside /etc/profile.d/

Suggesting that someone do this is irresponsible and is not based on any
official documentation.

SAL_USE_VCLPLUGIN variable can be set inside /etc/profile.d/ only because this
variable is used exclusively by LibreOffice.

But QT_QPA_PLATFORM variable is used by every Qt software and never should be
set inside /etc/profile.d/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 143440] Calc - Formula is not shown in formula line. show in second line when expand

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143440

Anat  changed:

   What|Removed |Added

  Component|Calc|Localization

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 143440] Calc - Formula is not shown in formula line. show in second line when expand

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143440

Anat  changed:

   What|Removed |Added

Summary|Formula is not shown in |Calc - Formula is not shown
   |formula line. show in   |in formula line. show in
   |second line when expand |second line when expand

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Build error with freebl: prtypes.h:556:38: error: size of array ‘arg’ is negative

2021-07-20 Thread Paul Menzel

Dear LibreOffice folks,


Building current master on Ubuntu 21.04 (ppc64le) fails:

```
$ gcc --version
gcc (Ubuntu 10.3.0-1ubuntu1) 10.3.0
[…]
$ git describe --dirty
libreoffice-7-2-branch-point-1293-g1738f106bd73
$ make
[…]
In file included from ../../../dist/out/include/prerror.h:9,
 from drbg.c:9:
drbg.c: In function ‘RNG_RandomUpdate’:
../../../dist/out/include/prtypes.h:556:38: error: size of array ‘arg’ 
is negative

  556 | extern void pr_static_assert(int arg[(condition) ? 1 : -1])
  |  ^~~
drbg.c:609:5: note: in expansion of macro ‘PR_STATIC_ASSERT’
  609 | PR_STATIC_ASSERT(sizeof(size_t) <= 4);
  | ^~~~
make[7]: *** [../../coreconf/rules.mk:279: 
out/Linux_SINGLE_SHLIB/drbg.o] Error 1

make[6]: *** [Makefile:680: freebl_FREEBL_BUILD_SINGLE_SHLIB] Error 2
make[5]: *** [../coreconf/rules.mk:37: freebl] Error 2
[…]
```


Kind regards,

Paul
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 45540] Changing between Documents not Possible if Dialog Boxes are Displayed

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=45540

--- Comment #14 from Thomas Lendo  ---
Not reproducible in Ubuntu 20.04 with LibreOfficeDev 7.3.
Reproducible in Windows 10 with LibreOfficeDev 7.3.
NO chance to test under MacOS.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135762] Export all sheets as CSV

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135762

--- Comment #15 from Commit Notification 
 ---
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0cda081c9aa3b3dcb363f97bac60c845ce9a13e0

Related: tdf#135762 Suppress cout if not command line

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: desktop/source sc/source

2021-07-20 Thread Eike Rathke (via logerrit)
 desktop/source/app/dispatchwatcher.cxx |   19 +++--
 sc/source/ui/docshell/docsh.cxx|   48 +++--
 2 files changed, 45 insertions(+), 22 deletions(-)

New commits:
commit 0cda081c9aa3b3dcb363f97bac60c845ce9a13e0
Author: Eike Rathke 
AuthorDate: Tue Jul 20 23:09:59 2021 +0200
Commit: Eike Rathke 
CommitDate: Wed Jul 21 01:26:15 2021 +0200

Related: tdf#135762 Suppress cout if not command line

Change-Id: I9431221aadf97739bb197871f25fa151ef4c391c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119294
Reviewed-by: Eike Rathke 
Tested-by: Jenkins

diff --git a/desktop/source/app/dispatchwatcher.cxx 
b/desktop/source/app/dispatchwatcher.cxx
index 1c4d878614c5..0e39415d8fab 100644
--- a/desktop/source/app/dispatchwatcher.cxx
+++ b/desktop/source/app/dispatchwatcher.cxx
@@ -608,15 +608,17 @@ bool DispatchWatcher::executeDispatchRequests( const 
std::vector conversionProperties( 
nProps );
-conversionProperties[0].Name = "Overwrite";
-conversionProperties[0].Value <<= true;
+conversionProperties[0].Name = 
"ConversionRequestOrigin";
+conversionProperties[0].Value <<= 
OUString("CommandLine");
+conversionProperties[1].Name = "Overwrite";
+conversionProperties[1].Value <<= true;
 
-conversionProperties[1].Name = "FilterName";
+conversionProperties[2].Name = "FilterName";
 if( 0 < nFilterOptionsIndex )
 {
 OUString sFilterName = aFilter.copy(0, 
nFilterOptionsIndex);
@@ -641,18 +643,19 @@ bool DispatchWatcher::executeDispatchRequests( const 
std::vector & rArgs = 
rMed.GetArgs();
+const auto pProp = std::find_if( rArgs.begin(), rArgs.end(),
+[](const css::beans::PropertyValue& rProp) { return 
rProp.Name == "ConversionRequestOrigin"; });
+if (pProp != rArgs.end())
+{
+OUString aOrigin;
+pProp->Value >>= aOrigin;
+bVerbose = (aOrigin == "CommandLine");
+}
+
 SCTAB nStartTab;
 SCTAB nCount = m_aDocument.GetTableCount();
 if (aOptions.nSheetToExport == -1)
@@ -2433,11 +2446,14 @@ bool ScDocShell::ConvertTo( SfxMedium  )
 else
 {
 // Usage error, no export but log.
-if (aOptions.nSheetToExport < 0)
-std::cout << "Bad sheet number string given." << std::endl;
-else
-std::cout << "No sheet number " << 
OString::number(aOptions.nSheetToExport)
-<< ", number of sheets is 
" << nCount << std::endl;
+if (bVerbose)
+{
+if (aOptions.nSheetToExport < 0)
+std::cout << "Bad sheet number string given." << 
std::endl;
+else
+std::cout << "No sheet number " << 
aOptions.nSheetToExport
+<< ", number of sheets is " << nCount << std::endl;
+}
 nStartTab = 0;
 nCount = 0;
 SetError(SCERR_EXPORT_DATA);
@@ -2462,15 +2478,19 @@ bool ScDocShell::ConvertTo( SfxMedium  )
 
 // log similar to DispatchWatcher::executeDispatchRequests
 OUString aOutFile = 
aSheetURLObject.GetMainURL(INetURLObject::DecodeMechanism::NONE);
-OUString aDisplayedName;
-if (osl::FileBase::E_None != 
osl::FileBase::getSystemPathFromFileURL(aOutFile, aDisplayedName))
-aDisplayedName = aOutFile;
-std::cout << "Writing sheet " << OUStringToOString(sTabName, 
osl_getThreadTextEncoding()) << " -> "
-  << 
OUStringToOString(aDisplayedName, osl_getThreadTextEncoding())
-  << std::endl;
-
-if (FStatHelper::IsDocument(aOutFile))
-std::cout << "Overwriting: " << 
OUStringToOString(aDisplayedName, osl_getThreadTextEncoding()) << std::endl ;
+if (bVerbose)
+{
+OUString aDisplayedName;
+if (osl::FileBase::E_None != 
osl::FileBase::getSystemPathFromFileURL(aOutFile, aDisplayedName))
+aDisplayedName = aOutFile;
+std::cout << "Writing sheet " << 
OUStringToOString(sTabName, osl_getThreadTextEncoding()) << " -> "
+  << 
OUStringToOString(aDisplayedName, osl_getThreadTextEncoding())
+  << std::endl;
+
+

[Libreoffice-bugs] [Bug 101684] Character styles used in a numbering style are not listed in "used styles" tab of Styles And Formatting and can be deleted without warning

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=101684

--- Comment #13 from Thomas Lendo  ---
Still reproducible in
Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 113d308155e4b6a67a8510098a7db5f4a6632bdc
CPU threads: 2; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: de-AT (de_AT.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2021-07-16_21:27:22

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 143466] Missing translation in two strings of the path: "Formato">"Ajuste" in LO Writer 7.2 RC1, Spanish version.

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143466

--- Comment #2 from Albert Acer  ---
Created attachment 173722
  --> https://bugs.documentfoundation.org/attachment.cgi?id=173722=edit
Missing translation in two strings of the path: "Formato">"Ajuste" in LO Writer
7.2 RC1, Spanish version.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 143466] New: Missing translation in two strings of the path: "Formato">"Ajuste" in LO Writer 7.2 RC1, Spanish version.

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143466

Bug ID: 143466
   Summary: Missing translation in two strings of the path:
"Formato">"Ajuste" in LO Writer 7.2 RC1, Spanish
version.
   Product: LibreOffice
   Version: 7.2.0.1 rc
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: albac...@gmail.com

Description:
When I am testing LO Writer 7.2 RC1 in Spanish, I find two strings, under the
“Formato” Menu, in the “Ajuste” submenú, without translating to the Spanish
language. 

LO 7.1  in Spanish is also affected by this same error.

Steps to Reproduce:
1. Open LO Writer 7.2 RC1, Spanish Version.
2. Explore the “Formato” menu.
3. Find the “Ajuste” submenu.


Actual Results:
Two stings appear in English instead of being displayed in Spanish as it should
be.
These chains are: ”Parallel”  and  “Through”.

Expected Results:
Weblate should set a Spanish translation equal or very similar to the one
already set in LO Writer 7.0.6 in Spanish, that is to say, Weblate should set
"Ajuste a la Página" or “Ajuste de Página” instead of "Parallel", and,
“Continuo” instead of “Through”.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
[Information automatically included from LibreOffice]
Locale: es
Module: TextDocument
[Information guessed from browser]
OS: Windows (All)
OS is 64bit: no

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 143466] Missing translation in two strings of the path: "Formato">"Ajuste" in LO Writer 7.2 RC1, Spanish version.

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143466

--- Comment #1 from Albert Acer  ---
In the screenshot which I have attached today July-20-2021, we can see where
and how the translation errors are reproduced.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115717] UI: Chart type window too small

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115717

Thomas Lendo  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEEDINFO|RESOLVED

--- Comment #5 from Thomas Lendo  ---
Seems to work.
Closing as Worksforme.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113833] UI: List boxes for column and row are too high in Navigator

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113833

--- Comment #4 from Thomas Lendo  ---
Still reproducible in
Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 113d308155e4b6a67a8510098a7db5f4a6632bdc
CPU threads: 2; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: de-AT (de_AT.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2021-07-16_21:27:22
and on Win10

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113999] Page format preview corrupted when height is getting smaller than width

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113999

--- Comment #6 from Thomas Lendo  ---
Still reproducible in
Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 113d308155e4b6a67a8510098a7db5f4a6632bdc
CPU threads: 2; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: de-AT (de_AT.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2021-07-16_21:27:22

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 106502] VIEWING: Zooming in Page Preview goes to the first page, not where cursor is

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=106502

--- Comment #7 from Thomas Lendo  ---
Still reproducible in
Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 113d308155e4b6a67a8510098a7db5f4a6632bdc
CPU threads: 2; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: de-AT (de_AT.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2021-07-16_21:27:22

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113108] [META] Dialog UI/UX bugs and enhancements

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113108
Bug 113108 depends on bug 115717, which changed state.

Bug 115717 Summary: UI: Chart type window too small
https://bugs.documentfoundation.org/show_bug.cgi?id=115717

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 107334] [META] Chart wizard dialog issues

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107334
Bug 107334 depends on bug 115717, which changed state.

Bug 115717 Summary: UI: Chart type window too small
https://bugs.documentfoundation.org/show_bug.cgi?id=115717

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 76595] Microsoft Offfice

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=76595

--- Comment #16 from iver newton  ---
If we talk about printers first name comes in our head is Canon and Brother
Printers, for latest and updated Drivers for Canon and Brother go to the
Following Sites.

http://printercontrolcenter.com/
https://ij-start-canon-setup.com/
https://installprint.com/canon-com-ijsetup/
http://allinonexpert.com/printers/canon-com-ijsetup-some-brief/
http://thehelpingguide.com/printers/canon-com-ijsetup-install-canon-printer/
http://canon-com-ijsetup.com/
http://geeksready.com/solutions-brother-com-windows/
https://brother.printers-setup.com/solutions-brother-com-windows/
https://marktick.blogspot.com/
http://asinghblog.com/solutions-brother-com-windows-setup/
http://support-brother-windows.globalguideforall.com/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122003] Color split and group buttons in toolbar loose their settings when window is smaller than toolbar

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122003

--- Comment #5 from Thomas Lendo  ---
Still reproducible in
Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 113d308155e4b6a67a8510098a7db5f4a6632bdc
CPU threads: 2; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: de-AT (de_AT.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2021-07-16_21:27:22
Calc: CL

If the windows size is made bigger again, then the custom setting is shown
correctly in the toolbar group button.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120741] Personalization Themes: Make it more obvious which preinstalled theme is activated and selected

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120741

--- Comment #6 from Thomas Lendo  ---
Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 113d308155e4b6a67a8510098a7db5f4a6632bdc
CPU threads: 2; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: de-AT (de_AT.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2021-07-16_21:27:22

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120741] Personalization Themes: Make it more obvious which preinstalled theme is activated and selected

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120741

--- Comment #5 from Thomas Lendo  ---
Activated (used) theme is still not visible in the Personalization section of
the Options dialog.

An icon overlay is a possible solution.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120405] EDITING: Clicking at 'Open' in the concordance file button in the ToC dialog vanishes the 'Edit...' command

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120405

--- Comment #3 from Thomas Lendo  ---
Still reproducible in
Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 113d308155e4b6a67a8510098a7db5f4a6632bdc
CPU threads: 2; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: de-AT (de_AT.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2021-07-16_21:27:22
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 116782] Document colors palette not working in Impress and Draw

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116782

--- Comment #5 from Thomas Lendo  ---
Still reproducible in
Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 113d308155e4b6a67a8510098a7db5f4a6632bdc
CPU threads: 2; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: de-AT (de_AT.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2021-07-16_21:27:22
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115350] Tools > Options > Math should be visible when editing an embedded formula

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115350

--- Comment #6 from Thomas Lendo  ---
Still reproducible in
Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 113d308155e4b6a67a8510098a7db5f4a6632bdc
CPU threads: 2; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: de-AT (de_AT.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2021-07-16_21:27:22
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115021] Modifying the same shortcut in multiple modules in the same session can causes conflicts

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115021

--- Comment #7 from Thomas Lendo  ---
Still reproducible.
Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 113d308155e4b6a67a8510098a7db5f4a6632bdc
CPU threads: 2; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: de-AT (de_AT.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2021-07-16_21:27:22
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 86349] [META] Context menu bugs and enhancements

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=86349
Bug 86349 depends on bug 117029, which changed state.

Bug 117029 Summary: Styles that are not available via Style sidebar should be 
greyed out in menus
https://bugs.documentfoundation.org/show_bug.cgi?id=117029

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112473] [META] Styles menu bugs and enhancements

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112473
Bug 112473 depends on bug 117029, which changed state.

Bug 117029 Summary: Styles that are not available via Style sidebar should be 
greyed out in menus
https://bugs.documentfoundation.org/show_bug.cgi?id=117029

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 117029] Styles that are not available via Style sidebar should be greyed out in menus

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117029

Thomas Lendo  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #5 from Thomas Lendo  ---
Working with 7.3 and 6.4. New styles also can be used in old files.

Maybe it was a profile issue as Heiko seid.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113824] EDITING: Sheet is freezing after editing a shown comment and switching between sheets (until ESC pressed)

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113824

--- Comment #5 from Thomas Lendo  ---
Still reproducible with
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 949658028e722e5d2657b503eb20e16e41dbd8cf
CPU threads: 12; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win
Locale: de-AT (de_AT); UI: de-DE
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 143452] Two buttons in the date form control became untranslatable

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143452

Julien Nabet  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr
   |desktop.org |
 CC||serval2...@yahoo.fr
 OS|Windows (All)   |All
 Status|NEW |ASSIGNED

--- Comment #2 from Julien Nabet  ---
Here's the patch:
https://gerrit.libreoffice.org/c/core/+/119293

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: dbaccess/source include/editeng sc/source sd/source starmath/source svx/source

2021-07-20 Thread Mike Kaganski (via logerrit)
 dbaccess/source/ui/control/sqledit.cxx  |1 +
 include/editeng/editeng.hxx |1 +
 include/editeng/editobj.hxx |3 ++-
 sc/source/core/data/attrib.cxx  |1 +
 sd/source/core/sdpage.cxx   |1 +
 sd/source/ui/view/viewshel.cxx  |1 +
 starmath/source/smediteng.cxx   |1 +
 svx/source/dialog/ClassificationEditView.cxx|1 +
 svx/source/dialog/weldeditview.cxx  |1 +
 svx/source/sidebar/textcolumns/TextColumnsPropertyPanel.cxx |1 +
 svx/source/svdraw/svdotxat.cxx  |1 +
 11 files changed, 12 insertions(+), 1 deletion(-)

New commits:
commit 07bd6ccf98e2062739beed84e64345918546c64a
Author: Mike Kaganski 
AuthorDate: Tue Jul 20 23:23:11 2021 +0300
Commit: Mike Kaganski 
CommitDate: Tue Jul 20 23:06:29 2021 +0200

Use some forward declarations in 

Change-Id: Ic6c36d4e0da53324ada9ff8a91e715d52ac24394
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119292
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/dbaccess/source/ui/control/sqledit.cxx 
b/dbaccess/source/ui/control/sqledit.cxx
index c53f684dab4a..a3a8626acc21 100644
--- a/dbaccess/source/ui/control/sqledit.cxx
+++ b/dbaccess/source/ui/control/sqledit.cxx
@@ -33,6 +33,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
diff --git a/include/editeng/editeng.hxx b/include/editeng/editeng.hxx
index 53543cf178d2..630cbc50dbeb 100644
--- a/include/editeng/editeng.hxx
+++ b/include/editeng/editeng.hxx
@@ -38,6 +38,7 @@
 
 #include 
 #include 
+#include 
 
 #include 
 #include 
diff --git a/include/editeng/editobj.hxx b/include/editeng/editobj.hxx
index 530601082cc1..fdc0db57d09f 100644
--- a/include/editeng/editobj.hxx
+++ b/include/editeng/editobj.hxx
@@ -21,7 +21,6 @@
 #define INCLUDED_EDITENG_EDITOBJ_HXX
 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -31,11 +30,13 @@
 #include 
 #include 
 
+class SfxItemPool;
 class SfxItemSet;
 class SvxFieldItem;
 class SvxFieldData;
 enum class OutlinerMode;
 struct EECharAttrib;
+typedef struct _xmlTextWriter* xmlTextWriterPtr;
 
 namespace editeng {
 
diff --git a/sc/source/core/data/attrib.cxx b/sc/source/core/data/attrib.cxx
index fc83491845bb..324c2c59c322 100644
--- a/sc/source/core/data/attrib.cxx
+++ b/sc/source/core/data/attrib.cxx
@@ -26,6 +26,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 
diff --git a/sd/source/core/sdpage.cxx b/sd/source/core/sdpage.cxx
index 9d8f13df75db..ddd5fdbb037c 100644
--- a/sd/source/core/sdpage.cxx
+++ b/sd/source/core/sdpage.cxx
@@ -63,6 +63,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 #include 
diff --git a/sd/source/ui/view/viewshel.cxx b/sd/source/ui/view/viewshel.cxx
index ac7a5d3489ac..3a23edd1bb35 100644
--- a/sd/source/ui/view/viewshel.cxx
+++ b/sd/source/ui/view/viewshel.cxx
@@ -82,6 +82,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
diff --git a/starmath/source/smediteng.cxx b/starmath/source/smediteng.cxx
index b782d5abc77b..7379c705f190 100644
--- a/starmath/source/smediteng.cxx
+++ b/starmath/source/smediteng.cxx
@@ -15,6 +15,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 SmEditEngine::SmEditEngine(SfxItemPool* pItemPool)
diff --git a/svx/source/dialog/ClassificationEditView.cxx 
b/svx/source/dialog/ClassificationEditView.cxx
index 2381762ee411..0b6ef370570f 100644
--- a/svx/source/dialog/ClassificationEditView.cxx
+++ b/svx/source/dialog/ClassificationEditView.cxx
@@ -10,6 +10,7 @@
 
 #include 
 
+#include 
 #include 
 #include 
 #include 
diff --git a/svx/source/dialog/weldeditview.cxx 
b/svx/source/dialog/weldeditview.cxx
index 7dd58d31275f..04f4ce390ca2 100644
--- a/svx/source/dialog/weldeditview.cxx
+++ b/svx/source/dialog/weldeditview.cxx
@@ -37,6 +37,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
diff --git a/svx/source/sidebar/textcolumns/TextColumnsPropertyPanel.cxx 
b/svx/source/sidebar/textcolumns/TextColumnsPropertyPanel.cxx
index c1614bed24e2..79b9ab7ee081 100644
--- a/svx/source/sidebar/textcolumns/TextColumnsPropertyPanel.cxx
+++ b/svx/source/sidebar/textcolumns/TextColumnsPropertyPanel.cxx
@@ -15,6 +15,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
diff --git a/svx/source/svdraw/svdotxat.cxx b/svx/source/svdraw/svdotxat.cxx
index d9f5c6833779..539dc4a26bd0 100644
--- a/svx/source/svdraw/svdotxat.cxx
+++ b/svx/source/svdraw/svdotxat.cxx
@@ -18,6 +18,7 @@
  */
 
 #include 
+#include 
 #include 
 #include 
 #include 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 113752] SIDEBAR: Switching Styles sidebar tabs when going to print preview and back

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113752

--- Comment #6 from Thomas Lendo  ---
Still reproducible.

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 113d308155e4b6a67a8510098a7db5f4a6632bdc
CPU threads: 2; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: de-AT (de_AT.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2021-07-16_21:27:22
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123804] Can not select AREA Fill / Style PATTERN for objects / shapes in WRITER TOOLBAR

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123804

Katarina Behrens  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #5 from Katarina Behrens  ---


*** This bug has been marked as a duplicate of bug 128612 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108816] [META] Writer toolbar bugs and enhancements

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108816
Bug 108816 depends on bug 123804, which changed state.

Bug 123804 Summary: Can not select AREA Fill / Style PATTERN for objects / 
shapes in WRITER TOOLBAR
https://bugs.documentfoundation.org/show_bug.cgi?id=123804

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108741] [META] Shapes bugs and enhancements

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108741
Bug 108741 depends on bug 123804, which changed state.

Bug 123804 Summary: Can not select AREA Fill / Style PATTERN for objects / 
shapes in WRITER TOOLBAR
https://bugs.documentfoundation.org/show_bug.cgi?id=123804

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 143465] 3D-models of Shape3DLatheObject cannot be positioned in a 3D-scene

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143465

--- Comment #2 from Kadet  ---
In addition. After introducing an object of the Shape3DLatheObject type into
the scenes, the entire scene stops turning, although it was spinning perfectly
before.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 143465] 3D-models of Shape3DLatheObject cannot be positioned in a 3D-scene

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143465

--- Comment #1 from Kadet  ---
Created attachment 173721
  --> https://bugs.documentfoundation.org/attachment.cgi?id=173721=edit
Creating a wireframe

After downloading the file, click (in the upper-left corner of the page)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 143465] New: 3D-models of Shape3DLatheObject cannot be positioned in a 3D-scene

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143465

Bug ID: 143465
   Summary: 3D-models of Shape3DLatheObject cannot be positioned
in a 3D-scene
   Product: LibreOffice
   Version: 7.1.4.1 rc
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: BASIC
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kade...@ya.ru

Description:
3D models of Shape3DLatheObject cannot be positioned in a 3D scene. The Shape
3D Cube Object and Shape3DSphereObject models have methods for positioning
D3DPosition and D3DSize and they are easily positioned inside the 3D scene. And
objects of the Polygonal type do not have these methods. Attempts to place an
object of the Shape3DLatheObject type inside the scene in a certain place do
not lead to success. The array of Z coordinates in the D3DPolyPolygon3D method
is always 0 and does not change. And changes to the X or Y arrays make the
model wider/narrower or higher/lower, but do not shift the model inside the
scene. The axis of rotation is always Y and always at the origin of the scene -
(0,0,0).

Steps to Reproduce:
1.Open the attached file
2.Press the button
3.

Actual Results:
A 3D scene created by a set of nested objects of the Shape 3D Cube Object type
will be drawn on the page, and a gray ring will appear in the middle. The ring
is an object of the Shape3DLatheObject type, which, according to the idea,
should be located in the lower right corner of the scene, and have a small
size. Instead, it is located in the center of the scene and is only expanded by
the amount of the necessary shift in X.

Expected Results:
An object of the Shape3DLatheObject type-should look like a cylinder and be
located under the right front corner pillar of the depicted structure.


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
I didn't find a description or help on this issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'feature/wasm' - solenv/gbuild

2021-07-20 Thread Thorsten Behrens (via logerrit)
 solenv/gbuild/platform/EMSCRIPTEN_INTEL_GCC.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 2da19a3f9dd6c74532567823d3caca73f205fd1c
Author: Thorsten Behrens 
AuthorDate: Tue Jul 20 22:25:28 2021 +0200
Commit: Thorsten Behrens 
CommitDate: Tue Jul 20 22:25:28 2021 +0200

Use proper absolute paths on linker lines

Change-Id: Ic09d2074144ebc58142f55a105d22540561628df

diff --git a/solenv/gbuild/platform/EMSCRIPTEN_INTEL_GCC.mk 
b/solenv/gbuild/platform/EMSCRIPTEN_INTEL_GCC.mk
index e8b090516633..2eb8e6be197a 100644
--- a/solenv/gbuild/platform/EMSCRIPTEN_INTEL_GCC.mk
+++ b/solenv/gbuild/platform/EMSCRIPTEN_INTEL_GCC.mk
@@ -17,7 +17,7 @@ gb_EMSCRIPTEN_CPPFLAGS := -pthread -s TOTAL_MEMORY=1GB -s 
USE_PTHREADS=1 -s PTHR
 # To keep the link time (and memory) down, prevent all rewriting options from 
wasm-emscripten-finalize
 # See emscrypten.py, finalize_wasm, modify_wasm = True
 # So we need WASM_BIGINT=1 and ASSERTIONS=1 (2 implies STACK_OVERFLOW_CHECK)
-gb_EMSCRIPTEN_LDFLAGS := $(gb_EMSCRIPTEN_CPPFLAGS) --bind -s 
FORCE_FILESYSTEM=1 -s WASM_BIGINT=1 -s ERROR_ON_UNDEFINED_SYMBOLS=1 -s FETCH=1 
-s ASSERTIONS=1 -s EXIT_RUNTIME=0 -s 
EXTRA_EXPORTED_RUNTIME_METHODS=["UTF16ToString","stringToUTF16"] --pre-js 
instdir/program/soffice.data.js --pre-js static/debug.js
+gb_EMSCRIPTEN_LDFLAGS := $(gb_EMSCRIPTEN_CPPFLAGS) --bind -s 
FORCE_FILESYSTEM=1 -s WASM_BIGINT=1 -s ERROR_ON_UNDEFINED_SYMBOLS=1 -s FETCH=1 
-s ASSERTIONS=1 -s EXIT_RUNTIME=0 -s 
EXTRA_EXPORTED_RUNTIME_METHODS=["UTF16ToString","stringToUTF16"] --pre-js 
$(INSTDIR)/program/soffice.data.js --pre-js $(SRCDIR)/static/debug.js
 gb_EMSCRIPTEN_QTDEFS := -DQT_NO_LINKED_LIST -DQT_NO_JAVA_STYLE_ITERATORS 
-DQT_NO_EXCEPTIONS -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -DQT_NO_DEBUG 
-DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_CORE_LIB
 
 gb_Executable_EXT := .html
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 103223] [META] Area fill tab bugs and enhancements

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103223
Bug 103223 depends on bug 128612, which changed state.

Bug 128612 Summary: Toolbars show wrong area type for pattern and do not work 
correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=128612

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 143464] New: Summary: SmartTag XStringKeyMaps not filled in lcl_FillRecognizerData

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143464

Bug ID: 143464
   Summary: Summary: SmartTag XStringKeyMaps not filled in
lcl_FillRecognizerData
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: anta...@gmail.com

Created attachment 173720
  --> https://bugs.documentfoundation.org/attachment.cgi?id=173720=edit
use NULL for missing XStringKeyMap entries

While trying to use SmartTags, the development version (commit
f81871ccbbe118b4ac93325a29f7c6b26765cb6e)
(but not Version: 6.4.7.2 Build ID: 1:6.4.7-0ubuntu0.20.04.1)
reports 

soffice.bin: file:libo/include/com/sun/star/uno/Sequence.hxx::190

const E& com::sun::star::uno::Sequence< 
>::operator[](sal_Int32) const 
[with E =
com::sun::star::uno::Reference;
sal_Int32 = int]:
Assertion `nIndex >= 0 && static_cast(nIndex) <
static_cast(getLength())' failed.

Stack trace (partial)

#3  0x77a59f36 in __GI___assert_fail
(assertion=0x73fc4920 "nIndex >= 0 && static_cast(nIndex) <
static_cast(getLength())", file=0x73fc48c8
"libo/include/com/sun/star/uno/Sequence.hxx", line=190, function=0x73fc4800
"const E& com::sun::star::uno::Sequence< 
>::operator[](sal_Int32) const [with E =
com::sun::star::uno::Reference;
sal_Int32 = int]") at assert.c:101
#4  0x73d6a443 in
com::sun::star::uno::Sequence
>::operator[](int) const (this=0x5b01adb0, nIndex=0)
at libo/include/com/sun/star/uno/Sequence.hxx:190
#5  0x73d67990 in (anonymous
namespace)::SmartTagMenuController::FillMenu() (this=0x5bdc1400) at
libo/svx/source/mnuctrls/smarttagmenu.cxx:128
#6  0x73d675f3 in (anonymous
namespace)::SmartTagMenuController::statusChanged(com::sun::star::frame::FeatureStateEvent
const&) (this=0x5bdc1400, rEvent=...)
at libo/svx/source/mnuctrls/smarttagmenu.cxx:103

I believe this arises because  lcl_FillRecognizerData at
https://docs.libreoffice.org/sw/html/crsrsh_8cxx_source.html#l03692 

file:libo/sw/source/core/crsr/crsrsh.cxx::3663

does not fill aStringKeyMaps, yielding an empty rStringKeyMaps

---

How to reproduce

- install a smarttags extension
- control-click on marked smart tag

---

The attached patch avoids the failure by using NULL for missing XStringKeyMap
entries.
It results in passing NULL to xAction->getActionCount(),
xAction->getActionCaptionFromID()
and InvokeAction aEntry( xAction, xSmartTagProperties, nActionID );

This seems to match earlier behaviour.
It would be nice to be able to pass some info in XStringKeyMap.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: editeng/source

2021-07-20 Thread Mike Kaganski (via logerrit)
 editeng/source/editeng/editobj.cxx |   33 +++--
 1 file changed, 7 insertions(+), 26 deletions(-)

New commits:
commit a85dfb250ec983b5e325ccd0e0dbef27a75f47ce
Author: Mike Kaganski 
AuthorDate: Tue Jul 20 15:10:40 2021 +0200
Commit: Mike Kaganski 
CommitDate: Tue Jul 20 21:50:21 2021 +0200

Use standard algorithm here

It also compares sizes, so no need for duplicating check.

Change-Id: Ica08af55da2ec8acfbeca333d32fe03929ee2cac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119189
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/editeng/source/editeng/editobj.cxx 
b/editeng/source/editeng/editobj.cxx
index cf4e474df6b6..b04f05313b3d 100644
--- a/editeng/source/editeng/editobj.cxx
+++ b/editeng/source/editeng/editobj.cxx
@@ -790,8 +790,7 @@ bool EditTextObjectImpl::Equals( const EditTextObjectImpl& 
rCompare, bool bCompa
 if( this ==  )
 return true;
 
-if( ( aContents.size() != rCompare.aContents.size() ) ||
-( bComparePool && pPool != rCompare.pPool ) ||
+if( ( bComparePool && pPool != rCompare.pPool ) ||
 ( nMetric != rCompare.nMetric ) ||
 ( nUserType!= rCompare.nUserType ) ||
 ( nScriptType != rCompare.nScriptType ) ||
@@ -799,36 +798,18 @@ bool EditTextObjectImpl::Equals( const 
EditTextObjectImpl& rCompare, bool bCompa
 ( mnRotation != rCompare.mnRotation ) )
 return false;
 
-for (size_t i = 0, n = aContents.size(); i < n; ++i)
-{
-if (!(aContents[i]->Equals( *(rCompare.aContents[i]), bComparePool)))
-return false;
-}
-
-return true;
+return std::equal(
+aContents.begin(), aContents.end(), rCompare.aContents.begin(), 
rCompare.aContents.end(),
+[bComparePool](const auto& c1, const auto& c2) { return 
c1->Equals(*c2, bComparePool); });
 }
 
 // #i102062#
 bool EditTextObjectImpl::isWrongListEqual(const EditTextObject& rComp) const
 {
 const EditTextObjectImpl& rCompare = static_cast(rComp);
-if (aContents.size() != rCompare.aContents.size())
-{
-return false;
-}
-
-for (size_t i = 0, n = aContents.size(); i < n; ++i)
-{
-const ContentInfo& rCandA = *aContents[i];
-const ContentInfo& rCandB = *rCompare.aContents[i];
-
-if(!rCandA.isWrongListEqual(rCandB))
-{
-return false;
-}
-}
-
-return true;
+return std::equal(
+aContents.begin(), aContents.end(), rCompare.aContents.begin(), 
rCompare.aContents.end(),
+[](const auto& c1, const auto& c2) { return c1->isWrongListEqual(*c2); 
});
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: Are there ideas for client-server model.

2021-07-20 Thread Wols Lists
On 18/07/21 10:58, Stef Bon wrote:
> 
> 
> Op za 17 jul. 2021 om 15:54 schreef Marc  >:
> 
> >
> > I'm willing to work on this, but since Collabora has already
> written an
> > online server, is it possible to port that code to libreoffice?
> >
> 
> 
> I very much would like to see that the 'collabora' code returns back
> to a libre office repository. I think that lots of committers there
> are would prefer working on the libre office repo, instead of the
> collabra. I think it is even weird that collabra people are posting
> video's on youtube and calling them libre office online. 
> 
> 
> I agree. It looks more like a fork to me they created. And actually
> creating a breach/distance with the original libreoffice code and community.
> This is not done as I see it. But I have to be frank: I haven't studied
> the code of LibreOffice and the code written by Colabora yet.
> 
And correct me if I'm wrong, but I think you'll find a LARGE minority of
the code contributed to LibreOffice, and GoOO before it, was written by
people who now work for Collabora.

You're right saying it's a fork, and it was done to create a distance
from the LibreOffice code. But it's a bit difficult to create a breach
with the community, seeing as Collabora are - and have been since before
even LibreOffice existed - a very big part of the LibreOffice community.

It's unfortunately the age-old problem - how are the contributors to
Open Source supposed to eat, if they don't find some way of monetising
their contributions ... (and if they don't eat, LibreOffice will die for
lack of contributors!!!)

Cheers,
Wol
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 100156] [META] Wayland-related bugs

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=100156

Jan-Marek Glogowski  changed:

   What|Removed |Added

 Depends on||142943


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=142943
[Bug 142943] Can't change paragraph styles by double-clicking a style on
sidebar
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 142943] Can't change paragraph styles by double-clicking a style on sidebar

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142943

Jan-Marek Glogowski  changed:

   What|Removed |Added

 Blocks||100156


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=100156
[Bug 100156] [META] Wayland-related bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 143463] Impress extremely slow response time when view pptx files.

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143463

--- Comment #1 from Richard  ---
Created attachment 173719
  --> https://bugs.documentfoundation.org/attachment.cgi?id=173719=edit
Created with Powerpoint, attempt to show on Impress

No additional comments

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 143463] New: Impress extremely slow response time when view pptx files.

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143463

Bug ID: 143463
   Summary: Impress extremely slow response time when view pptx
files.
   Product: LibreOffice
   Version: 7.1.4.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: reverendric...@gmail.com

Description:
Members of our group used Powerpoint to create presentations and when I attempt
to display them using Impress on my computer, the response time is extremely
slow and generates a program not responding message. I can supply a sample of
the pptx file for debugging.

Steps to Reproduce:
1.Load the file.pptx
2. Press F5 to start the presentation
3. Press Spacebar to advance slide

Actual Results:
Extremely slow response time and will generate Program not responding message.

Expected Results:
Would expect a much quicker response time.


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
None

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: editeng/source include/editeng sc/source sw/qa

2021-07-20 Thread Mike Kaganski (via logerrit)
 editeng/source/editeng/editobj.cxx  |  208 ++--
 editeng/source/editeng/editobj2.hxx |   82 ++--
 editeng/source/editeng/fieldupdater.cxx |4 
 editeng/source/editeng/impedit4.cxx |   29 ++--
 include/editeng/editobj.hxx |   87 +
 include/editeng/fieldupdater.hxx|2 
 sc/source/core/data/column.cxx  |8 -
 sw/qa/extras/layout/layout.cxx  |2 
 8 files changed, 116 insertions(+), 306 deletions(-)

New commits:
commit 8e8d3f4db94e0069a1d84378d295268f5037b016
Author: Mike Kaganski 
AuthorDate: Tue Jul 20 12:31:57 2021 +0300
Commit: Mike Kaganski 
CommitDate: Tue Jul 20 21:32:26 2021 +0200

EditTextObject: use virtual interface instead of pimpl

Makes it simpler, and avoids extra allocations

Change-Id: I301f628a2898f6421242808cbf8ce36c5acf9b0b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119241
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/editeng/source/editeng/editobj.cxx 
b/editeng/source/editeng/editobj.cxx
index 7dd9bdd2459d..cf4e474df6b6 100644
--- a/editeng/source/editeng/editobj.cxx
+++ b/editeng/source/editeng/editobj.cxx
@@ -206,197 +206,20 @@ bool ContentInfo::Equals(const ContentInfo& rCompare, 
bool bComparePool) const
&& maCharAttribs == rCompare.maCharAttribs;
 }
 
-EditTextObject::EditTextObject( SfxItemPool* pPool ) :
-mpImpl(new EditTextObjectImpl(this, pPool))
-{
-}
-
-EditTextObject::EditTextObject( const EditTextObject& r ) :
-mpImpl(new EditTextObjectImpl(this, *r.mpImpl))
-{
-}
-
-EditTextObject::~EditTextObject()
-{
-}
-
-sal_Int32 EditTextObject::GetParagraphCount() const
-{
-return mpImpl->GetParagraphCount();
-}
-
-OUString EditTextObject::GetText(sal_Int32 nPara) const
-{
-return mpImpl->GetText(nPara);
-}
-
-void EditTextObject::ClearPortionInfo()
-{
-mpImpl->ClearPortionInfo();
-}
-
-bool EditTextObject::HasOnlineSpellErrors() const
-{
-return mpImpl->HasOnlineSpellErrors();
-}
-
-void EditTextObject::GetCharAttribs( sal_Int32 nPara, 
std::vector& rLst ) const
-{
-mpImpl->GetCharAttribs(nPara, rLst);
-}
-
-bool EditTextObject::IsFieldObject() const
-{
-return mpImpl->IsFieldObject();
-}
-
-const SvxFieldItem* EditTextObject::GetField() const
-{
-return mpImpl->GetField();
-}
-
-const SvxFieldData* EditTextObject::GetFieldData(sal_Int32 nPara, size_t nPos, 
sal_Int32 nType) const
-{
-return mpImpl->GetFieldData(nPara, nPos, nType);
-}
-
-bool EditTextObject::HasField( sal_Int32 nType ) const
-{
-return mpImpl->HasField(nType);
-}
-
-const SfxItemSet& EditTextObject::GetParaAttribs(sal_Int32 nPara) const
-{
-return mpImpl->GetParaAttribs(nPara);
-}
-
-bool EditTextObject::RemoveCharAttribs( sal_uInt16 nWhich )
-{
-return mpImpl->RemoveCharAttribs(nWhich);
-}
-
-void EditTextObject::GetAllSections( std::vector& rAttrs ) 
const
-{
-mpImpl->GetAllSections(rAttrs);
-}
-
-void EditTextObject::GetStyleSheet(sal_Int32 nPara, OUString& rName, 
SfxStyleFamily& eFamily) const
-{
-mpImpl->GetStyleSheet(nPara, rName, eFamily);
-}
-
-void EditTextObject::SetStyleSheet(sal_Int32 nPara, const OUString& rName, 
const SfxStyleFamily& eFamily)
-{
-mpImpl->SetStyleSheet(nPara, rName, eFamily);
-}
-
-bool EditTextObject::ChangeStyleSheets(
-std::u16string_view rOldName, SfxStyleFamily eOldFamily, const OUString& 
rNewName, SfxStyleFamily eNewFamily)
-{
-return mpImpl->ChangeStyleSheets(rOldName, eOldFamily, rNewName, 
eNewFamily);
-}
-
-void EditTextObject::ChangeStyleSheetName(
-SfxStyleFamily eFamily, std::u16string_view rOldName, const OUString& 
rNewName)
-{
-mpImpl->ChangeStyleSheetName(eFamily, rOldName, rNewName);
-}
-
-editeng::FieldUpdater EditTextObject::GetFieldUpdater() const
-{
-return mpImpl->GetFieldUpdater();
-}
-
-void EditTextObject::NormalizeString( svl::SharedStringPool& rPool )
-{
-mpImpl->NormalizeString(rPool);
-}
-
-std::vector EditTextObject::GetSharedStrings() const
-{
-return mpImpl->GetSharedStrings();
-}
-
-const SfxItemPool* EditTextObject::GetPool() const
-{
-return mpImpl->GetPool();
-}
-
-OutlinerMode EditTextObject::GetUserType() const
-{
-return mpImpl->GetUserType();
-}
-
-void EditTextObject::SetUserType( OutlinerMode n )
-{
-mpImpl->SetUserType(n);
-}
-
-bool EditTextObject::IsVertical() const
-{
-return mpImpl->IsVertical();
-}
-
-bool EditTextObject::GetDirectVertical() const
-{
-return mpImpl->GetDirectVertical();
-}
-
-bool EditTextObject::IsTopToBottom() const
-{
-return mpImpl->IsTopToBottom();
-}
-
-void EditTextObject::SetVertical( bool bVertical )
-{
-return mpImpl->SetVertical(bVertical);
-}
-
-void EditTextObject::SetRotation( TextRotation nRotation )
-{
-mpImpl->SetRotation(nRotation);
-}
-
-TextRotation EditTextObject::GetRotation() const
-{
-return mpImpl->GetRotation();
-}
+EditTextObject::~EditTextObject() = default;
 
-SvtScriptType 

[Libreoffice-bugs] [Bug 143459] Page numbers total gets corrupted in docx

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143459

--- Comment #3 from Marco A.G.Pinto  ---
(In reply to BogdanB from comment #2)
> if you activate to view field shading (Ctrl+F8) you can see that "/7" is
> simple text, is not an automatic counter of page. Please check.

But why does it appear with a red triangle?

It is strange and confusing.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135762] Export all sheets as CSV

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135762

--- Comment #14 from Eike Rathke  ---
Yes, you are missing that the implementation is only for the command line
conversion (and the filter options string that can be used in macros).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 143087] Toolbar does not always dim during saving

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143087

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g

--- Comment #5 from BogdanB  ---
Inconistent for me. 
Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: c6695a4aabeaae99174b7658f2b813788ecff7f0
CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 143459] Page numbers total gets corrupted in docx

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143459

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g

--- Comment #2 from BogdanB  ---
if you activate to view field shading (Ctrl+F8) you can see that "/7" is simple
text, is not an automatic counter of page. Please check.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 143462] Basic IDE Dark Mode: Row numbers are black with dark background

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143462

--- Comment #1 from Rafael Lima  ---
Heiko, maybe you can provide a code pointer for this?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: svx/source

2021-07-20 Thread Noel Grandin (via logerrit)
 svx/source/accessibility/AccessibleTextHelper.cxx |   10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

New commits:
commit a11a06d38e145139a2a1c7d51510b4fcc3e1
Author: Noel Grandin 
AuthorDate: Mon Jul 19 19:03:05 2021 +0200
Commit: Noel Grandin 
CommitDate: Tue Jul 20 21:04:29 2021 +0200

osl::Mutex->std::mutex in AccessibleTextHelper_Impl

Change-Id: I263295c817a188d1d499a8c92eb7f6f7be64ea79
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119284
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/svx/source/accessibility/AccessibleTextHelper.cxx 
b/svx/source/accessibility/AccessibleTextHelper.cxx
index 9fbd897ea519..f1753226aa71 100644
--- a/svx/source/accessibility/AccessibleTextHelper.cxx
+++ b/svx/source/accessibility/AccessibleTextHelper.cxx
@@ -21,9 +21,9 @@
 
 #include 
 #include 
+#include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -109,7 +109,7 @@ namespace accessibility
 void SetOffset( const Point& );
 Point GetOffset() const
 {
-::osl::MutexGuard aGuard( maMutex ); Point aPoint( maOffset );
+std::lock_guard aGuard( maMutex ); Point aPoint( maOffset );
 return aPoint;
 }
 
@@ -216,7 +216,7 @@ namespace accessibility
 // whether we (this object) has the focus set (guarded by solar mutex)
 bool mbThisHasFocus;
 
-mutable ::osl::Mutex maMutex;
+mutable std::mutex maMutex;
 
 /// our current offset to the containing shape/cell (guarded by 
maMutex)
 Point maOffset;
@@ -732,7 +732,7 @@ namespace accessibility
 {
 // guard against non-atomic access to maOffset data structure
 {
-::osl::MutexGuard aGuard( maMutex );
+std::lock_guard aGuard( maMutex );
 maOffset = rPoint;
 }
 
@@ -1383,7 +1383,7 @@ namespace accessibility
 // -- object locked --
 AccessibleEventObject aEvent;
 {
-osl::MutexGuard aGuard(maMutex);
+std::lock_guard aGuard(maMutex);
 
 DBG_ASSERT(mxFrontEnd.is(), "AccessibleTextHelper::FireEvent: no 
event source set");
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 143462] Basic IDE Dark Mode: Row numbers are black with dark background

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143462

Rafael Lima  changed:

   What|Removed |Added

 CC||heiko.tietze@documentfounda
   ||tion.org
   Keywords||needsUXEval

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: vcl/inc vcl/source

2021-07-20 Thread Noel Grandin (via logerrit)
 vcl/inc/displayconnectiondispatch.hxx   |4 ++--
 vcl/source/helper/displayconnectiondispatch.cxx |8 
 2 files changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 5dcdfa148f6def1cdee628e6f7f1ec2421f45e82
Author: Noel Grandin 
AuthorDate: Mon Jul 19 17:51:26 2021 +0200
Commit: Noel Grandin 
CommitDate: Tue Jul 20 21:04:02 2021 +0200

osl::Mutex->std::mutex in DisplayConnectionDispatch

Change-Id: I590595adbd89fa3d4833de2743b71168448d4c2c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119283
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/vcl/inc/displayconnectiondispatch.hxx 
b/vcl/inc/displayconnectiondispatch.hxx
index e988ee62f378..a763ccd469c3 100644
--- a/vcl/inc/displayconnectiondispatch.hxx
+++ b/vcl/inc/displayconnectiondispatch.hxx
@@ -23,8 +23,8 @@
 #include 
 #include 
 #include 
-#include 
 #include 
+#include 
 #include 
 
 namespace vcl {
@@ -32,7 +32,7 @@ namespace vcl {
 class DisplayConnectionDispatch final :
 public cppu::WeakImplHelper< css::awt::XDisplayConnection >
 {
-::osl::Mutexm_aMutex;
+std::mutex  m_aMutex;
 ::std::vector< css::uno::Reference< css::awt::XEventHandler > >
 m_aHandlers;
 OUStringm_ConnectionIdentifier;
diff --git a/vcl/source/helper/displayconnectiondispatch.cxx 
b/vcl/source/helper/displayconnectiondispatch.cxx
index 85c4e8cdee01..72c3a435a57c 100644
--- a/vcl/source/helper/displayconnectiondispatch.cxx
+++ b/vcl/source/helper/displayconnectiondispatch.cxx
@@ -56,7 +56,7 @@ void DisplayConnectionDispatch::terminate()
 
 SolarMutexReleaser aRel;
 
-MutexGuard aGuard( m_aMutex );
+std::lock_guard aGuard( m_aMutex );
 Any aEvent;
 std::vector< css::uno::Reference< XEventHandler > > aLocalList( 
m_aHandlers );
 for (auto const& elem : aLocalList)
@@ -65,14 +65,14 @@ void DisplayConnectionDispatch::terminate()
 
 void SAL_CALL DisplayConnectionDispatch::addEventHandler( const Any& 
/*window*/, const css::uno::Reference< XEventHandler >& handler, sal_Int32 
/*eventMask*/ )
 {
-MutexGuard aGuard( m_aMutex );
+std::lock_guard aGuard( m_aMutex );
 
 m_aHandlers.push_back( handler );
 }
 
 void SAL_CALL DisplayConnectionDispatch::removeEventHandler( const Any& 
/*window*/, const css::uno::Reference< XEventHandler >& handler )
 {
-MutexGuard aGuard( m_aMutex );
+std::lock_guard aGuard( m_aMutex );
 
 m_aHandlers.erase( std::remove(m_aHandlers.begin(), m_aHandlers.end(), 
handler), m_aHandlers.end() );
 }
@@ -99,7 +99,7 @@ bool DisplayConnectionDispatch::dispatchEvent( void const * 
pData, int nBytes )
 aEvent <<= aSeq;
 ::std::vector< css::uno::Reference< XEventHandler > > handlers;
 {
-MutexGuard aGuard( m_aMutex );
+std::lock_guard aGuard( m_aMutex );
 handlers = m_aHandlers;
 }
 for (auto const& handle : handlers)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: package/source

2021-07-20 Thread Noel Grandin (via logerrit)
 package/source/zipapi/sha1context.cxx |4 ++--
 package/source/zipapi/sha1context.hxx |3 +--
 2 files changed, 3 insertions(+), 4 deletions(-)

New commits:
commit 0f580560e917f37df94ed2e7ddff59661ae93d79
Author: Noel Grandin 
AuthorDate: Sun Jul 18 19:13:32 2021 +0200
Commit: Noel Grandin 
CommitDate: Tue Jul 20 21:03:38 2021 +0200

osl::Mutex->std::mutex in StarOfficeSHA1DigestContext

Change-Id: I924796823230151a3edde2ead875cfc5bc5072d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119282
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/package/source/zipapi/sha1context.cxx 
b/package/source/zipapi/sha1context.cxx
index d13441462a3f..0da0648ea206 100644
--- a/package/source/zipapi/sha1context.cxx
+++ b/package/source/zipapi/sha1context.cxx
@@ -49,7 +49,7 @@ StarOfficeSHA1DigestContext::~StarOfficeSHA1DigestContext()
 
 void SAL_CALL StarOfficeSHA1DigestContext::updateDigest(const 
uno::Sequence<::sal_Int8>& aData)
 {
-::osl::MutexGuard aGuard( m_aMutex );
+std::lock_guard aGuard( m_aMutex );
 if ( !m_pDigest )
 throw lang::DisposedException();
 
@@ -64,7 +64,7 @@ void SAL_CALL StarOfficeSHA1DigestContext::updateDigest(const 
uno::Sequence<::sa
 
 uno::Sequence<::sal_Int8> SAL_CALL 
StarOfficeSHA1DigestContext::finalizeDigestAndDispose()
 {
-::osl::MutexGuard aGuard( m_aMutex );
+std::lock_guard aGuard( m_aMutex );
 if ( !m_pDigest )
 throw lang::DisposedException();
 
diff --git a/package/source/zipapi/sha1context.hxx 
b/package/source/zipapi/sha1context.hxx
index 3e61cf17e681..6cc09da01bb3 100644
--- a/package/source/zipapi/sha1context.hxx
+++ b/package/source/zipapi/sha1context.hxx
@@ -23,13 +23,12 @@
 
 #include 
 #include 
-#include 
 #include 
 
 class StarOfficeSHA1DigestContext
 : public cppu::WeakImplHelper
 {
-::osl::Mutex m_aMutex;
+std::mutex m_aMutex;
 void* m_pDigest;
 
 StarOfficeSHA1DigestContext()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: package/source

2021-07-20 Thread Noel Grandin (via logerrit)
 package/source/zipapi/sha1context.cxx |4 ++--
 package/source/zipapi/sha1context.hxx |3 ++-
 2 files changed, 4 insertions(+), 3 deletions(-)

New commits:
commit 0c14226903804065bf6d6f52a05c2907b8c5a973
Author: Noel Grandin 
AuthorDate: Sun Jul 18 19:11:25 2021 +0200
Commit: Noel Grandin 
CommitDate: Tue Jul 20 21:03:16 2021 +0200

osl::Mutex->std::mutex in CorrectSHA1DigestContext

Change-Id: Ia81e8edd84080a2cb750e2dce7b2e8879b66498e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119281
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/package/source/zipapi/sha1context.cxx 
b/package/source/zipapi/sha1context.cxx
index ab6327234f10..d13441462a3f 100644
--- a/package/source/zipapi/sha1context.cxx
+++ b/package/source/zipapi/sha1context.cxx
@@ -98,7 +98,7 @@ CorrectSHA1DigestContext::~CorrectSHA1DigestContext()
 
 void SAL_CALL CorrectSHA1DigestContext::updateDigest(const 
uno::Sequence<::sal_Int8>& rData)
 {
-::osl::MutexGuard aGuard(m_Mutex);
+std::lock_guard aGuard(m_Mutex);
 if (m_bDisposed)
 throw lang::DisposedException();
 
@@ -107,7 +107,7 @@ void SAL_CALL CorrectSHA1DigestContext::updateDigest(const 
uno::Sequence<::sal_I
 
 uno::Sequence<::sal_Int8> SAL_CALL 
CorrectSHA1DigestContext::finalizeDigestAndDispose()
 {
-::osl::MutexGuard aGuard(m_Mutex);
+std::lock_guard aGuard(m_Mutex);
 if (m_bDisposed)
 throw lang::DisposedException();
 
diff --git a/package/source/zipapi/sha1context.hxx 
b/package/source/zipapi/sha1context.hxx
index 55e61ee561cb..3e61cf17e681 100644
--- a/package/source/zipapi/sha1context.hxx
+++ b/package/source/zipapi/sha1context.hxx
@@ -24,6 +24,7 @@
 #include 
 #include 
 #include 
+#include 
 
 class StarOfficeSHA1DigestContext
 : public cppu::WeakImplHelper
@@ -49,7 +50,7 @@ public:
 class CorrectSHA1DigestContext
 : public cppu::WeakImplHelper
 {
-::osl::Mutex m_Mutex;
+std::mutex m_Mutex;
 ::comphelper::Hash m_Hash{::comphelper::HashType::SHA1};
 bool m_bDisposed{false};
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: package/source

2021-07-20 Thread Noel Grandin (via logerrit)
 package/source/zipapi/sha1context.cxx |   23 +++
 package/source/zipapi/sha1context.hxx |6 --
 2 files changed, 11 insertions(+), 18 deletions(-)

New commits:
commit 9bae1f1ad6be4d942c73cfbdd7b3ba55eb3fb983
Author: Noel Grandin 
AuthorDate: Sun Jul 18 19:06:06 2021 +0200
Commit: Noel Grandin 
CommitDate: Tue Jul 20 21:02:52 2021 +0200

no need to use a pImpl in CorrectSHA1DigestContext

Change-Id: If7404f63833373c5ac2954c4aac129c52582989c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119280
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/package/source/zipapi/sha1context.cxx 
b/package/source/zipapi/sha1context.cxx
index c036041a2d76..ab6327234f10 100644
--- a/package/source/zipapi/sha1context.cxx
+++ b/package/source/zipapi/sha1context.cxx
@@ -19,7 +19,6 @@
 
 #include 
 
-#include 
 #include 
 #include 
 #include 
@@ -89,15 +88,7 @@ uno::Reference 
CorrectSHA1DigestContext::Create()
 return new CorrectSHA1DigestContext();
 }
 
-struct CorrectSHA1DigestContext::Impl
-{
-::osl::Mutex m_Mutex;
-::comphelper::Hash m_Hash{::comphelper::HashType::SHA1};
-bool m_bDisposed{false};
-};
-
 CorrectSHA1DigestContext::CorrectSHA1DigestContext()
-: m_pImpl(new Impl)
 {
 }
 
@@ -107,21 +98,21 @@ CorrectSHA1DigestContext::~CorrectSHA1DigestContext()
 
 void SAL_CALL CorrectSHA1DigestContext::updateDigest(const 
uno::Sequence<::sal_Int8>& rData)
 {
-::osl::MutexGuard aGuard(m_pImpl->m_Mutex);
-if (m_pImpl->m_bDisposed)
+::osl::MutexGuard aGuard(m_Mutex);
+if (m_bDisposed)
 throw lang::DisposedException();
 
-m_pImpl->m_Hash.update(reinterpret_cast(rData.getConstArray()), rData.getLength());
+m_Hash.update(reinterpret_cast(rData.getConstArray()), rData.getLength());
 }
 
 uno::Sequence<::sal_Int8> SAL_CALL 
CorrectSHA1DigestContext::finalizeDigestAndDispose()
 {
-::osl::MutexGuard aGuard(m_pImpl->m_Mutex);
-if (m_pImpl->m_bDisposed)
+::osl::MutexGuard aGuard(m_Mutex);
+if (m_bDisposed)
 throw lang::DisposedException();
 
-m_pImpl->m_bDisposed = true;
-std::vector const sha1(m_pImpl->m_Hash.finalize());
+m_bDisposed = true;
+std::vector const sha1(m_Hash.finalize());
 return uno::Sequence(reinterpret_cast(sha1.data()), sha1.size());
 }
 
diff --git a/package/source/zipapi/sha1context.hxx 
b/package/source/zipapi/sha1context.hxx
index 436dfcccbf7c..55e61ee561cb 100644
--- a/package/source/zipapi/sha1context.hxx
+++ b/package/source/zipapi/sha1context.hxx
@@ -21,6 +21,7 @@
 
 #include 
 
+#include 
 #include 
 #include 
 
@@ -48,8 +49,9 @@ public:
 class CorrectSHA1DigestContext
 : public cppu::WeakImplHelper
 {
-struct Impl;
-std::unique_ptr m_pImpl;
+::osl::Mutex m_Mutex;
+::comphelper::Hash m_Hash{::comphelper::HashType::SHA1};
+bool m_bDisposed{false};
 
 CorrectSHA1DigestContext();
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 143462] New: Basic IDE Dark Mode: Row numbers are black with dark background

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143462

Bug ID: 143462
   Summary: Basic IDE Dark Mode: Row numbers are black with dark
background
   Product: LibreOffice
   Version: 7.2.0.0.beta1+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: BASIC
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rafael.palma.l...@gmail.com

Created attachment 173718
  --> https://bugs.documentfoundation.org/attachment.cgi?id=173718=edit
Image showing the problem

This is a follow-up to Bug 141566. Dark mode in the Basic Editor is working
alright in LO 7.2 beta 1.

However, the row numbers that appear to the left side of the editor are still
black with a dark background (see attached ODG image).

I suggest using the color #62666B - rgb(98, 102, 107).

If someone can provide a code pointer, I can try to fix it.

System Info:
Version: 7.2.0.1 / LibreOffice Community
Build ID: 32efc3b7f3a71cfa6a7fa3f6c208333df48656cc
CPU threads: 16; OS: Linux 5.11; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: include/svx svx/source

2021-07-20 Thread Noel Grandin (via logerrit)
 include/svx/sdr/table/tablecontroller.hxx |4 ++--
 svx/source/table/tablecontroller.cxx  |2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 42f5b019dd508be71545c54e00b860f3a2b6c7fb
Author: Noel Grandin 
AuthorDate: Tue Jul 20 16:16:57 2021 +0200
Commit: Noel Grandin 
CommitDate: Tue Jul 20 21:01:56 2021 +0200

no need to allocate the selectionOverlay separately in SvxTableController

Change-Id: Ifa4696991c79c9fa56aa4ccbb264c7c34110b85e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119289
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/include/svx/sdr/table/tablecontroller.hxx 
b/include/svx/sdr/table/tablecontroller.hxx
index e4b406b1f77a..0c4e701f1f4a 100644
--- a/include/svx/sdr/table/tablecontroller.hxx
+++ b/include/svx/sdr/table/tablecontroller.hxx
@@ -27,7 +27,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 
 struct ImplSVEvent;
 class SdrView;
@@ -182,7 +182,7 @@ private:
 bool mbHasJustMerged;
 CellPos maMouseDownPos;
 bool mbLeftButtonDown;
-std::unique_ptr  mpSelectionOverlay;
+std::optional  mpSelectionOverlay;
 SdrView& mrView;
 tools::WeakReference mxTableObj;
 css::uno::Reference< css::util::XModifyListener > mxModifyListener;
diff --git a/svx/source/table/tablecontroller.cxx 
b/svx/source/table/tablecontroller.cxx
index 83561dcc9550..e12d5fb1d68b 100644
--- a/svx/source/table/tablecontroller.cxx
+++ b/svx/source/table/tablecontroller.cxx
@@ -2357,7 +2357,7 @@ void SvxTableController::updateSelectionOverlay()
 std::unique_ptr pOverlay(new 
sdr::overlay::OverlayObjectCell( aHighlight, aRanges ));
 
 xOverlayManager->add(*pOverlay);
-mpSelectionOverlay.reset(new sdr::overlay::OverlayObjectList);
+mpSelectionOverlay.emplace();
 mpSelectionOverlay->append(std::move(pOverlay));
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: include/svl svl/source

2021-07-20 Thread Noel Grandin (via logerrit)
 include/svl/currencytable.hxx|4 ++--
 include/svl/zforlist.hxx |5 +
 svl/source/numbers/currencytable.cxx |6 +++---
 svl/source/numbers/zforlist.cxx  |   16 
 4 files changed, 14 insertions(+), 17 deletions(-)

New commits:
commit b285ea8606b99e2b85125ddf84af0e5e634bdd86
Author: Noel Grandin 
AuthorDate: Tue Jul 20 16:16:34 2021 +0200
Commit: Noel Grandin 
CommitDate: Tue Jul 20 21:01:10 2021 +0200

flatten the vector in NfCurrencyTable

Change-Id: I4a024e2d8c9743374e58836f95aa1fcbdc406b5b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119288
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/include/svl/currencytable.hxx b/include/svl/currencytable.hxx
index 2214b1903a6a..f7573f48b80b 100644
--- a/include/svl/currencytable.hxx
+++ b/include/svl/currencytable.hxx
@@ -18,7 +18,7 @@
 
 class SVL_DLLPUBLIC NfCurrencyTable
 {
-typedef std::vector> DataType;
+typedef std::vector DataType;
 DataType maData;
 
 NfCurrencyTable(NfCurrencyTable const&) = delete;
@@ -36,7 +36,7 @@ public:
 
 size_t size() const;
 
-void insert(const iterator& it, std::unique_ptr p);
+void insert(const iterator& it, NfCurrencyEntry p);
 };
 
 #endif
diff --git a/include/svl/zforlist.hxx b/include/svl/zforlist.hxx
index c3d82d7b109a..b929e6255277 100644
--- a/include/svl/zforlist.hxx
+++ b/include/svl/zforlist.hxx
@@ -302,7 +302,7 @@ typedef ::std::set< LanguageType > NfInstalledLocales;
 
 /** Language/country dependent currency entries
  */
-class UNLESS_MERGELIBS(SVL_DLLPUBLIC) NfCurrencyEntry
+class UNLESS_MERGELIBS(SVL_DLLPUBLIC) NfCurrencyEntry final
 {
 OUStringaSymbol;/// currency symbol
 OUStringaBankSymbol;/// currency abbreviation
@@ -312,9 +312,6 @@ class UNLESS_MERGELIBS(SVL_DLLPUBLIC) NfCurrencyEntry
 sal_uInt16  nDigits;/// count of decimal digits
 sal_Unicode cZeroChar;  /// which character is used for zeros 
as last decimal digits
 
-NfCurrencyEntry( const NfCurrencyEntry& ) = delete;
-NfCurrencyEntry&operator=( const NfCurrencyEntry& ) = delete;
-
 private:
 
 // nDecimalFormat := 0, 1, 2
diff --git a/svl/source/numbers/currencytable.cxx 
b/svl/source/numbers/currencytable.cxx
index feef71b43b94..d5fd2efd4d93 100644
--- a/svl/source/numbers/currencytable.cxx
+++ b/svl/source/numbers/currencytable.cxx
@@ -17,12 +17,12 @@ NfCurrencyTable::iterator NfCurrencyTable::begin()
 
 NfCurrencyEntry& NfCurrencyTable::operator[] ( size_t i )
 {
-return *maData[i];
+return maData[i];
 }
 
 const NfCurrencyEntry& NfCurrencyTable::operator[] ( size_t i ) const
 {
-return *maData[i];
+return maData[i];
 }
 
 size_t NfCurrencyTable::size() const
@@ -30,7 +30,7 @@ size_t NfCurrencyTable::size() const
 return maData.size();
 }
 
-void NfCurrencyTable::insert(const iterator& it, 
std::unique_ptr p)
+void NfCurrencyTable::insert(const iterator& it, NfCurrencyEntry p)
 {
 maData.insert(it, std::move(p));
 }
diff --git a/svl/source/numbers/zforlist.cxx b/svl/source/numbers/zforlist.cxx
index 0a2f699f81ec..f61dd50e901a 100644
--- a/svl/source/numbers/zforlist.cxx
+++ b/svl/source/numbers/zforlist.cxx
@@ -4087,7 +4087,7 @@ void SvNumberFormatter::ImpInitCurrencyTable()
 // First entry is SYSTEM:
 theCurrencyTable::get().insert(
 theCurrencyTable::get().begin(),
-std::make_unique(*pLocaleData, LANGUAGE_SYSTEM));
+NfCurrencyEntry(*pLocaleData, LANGUAGE_SYSTEM));
 sal_uInt16 nCurrencyPos = 1;
 
 const css::uno::Sequence< css::lang::Locale > xLoc = 
LocaleDataWrapper::getInstalledLocaleNames();
@@ -4115,14 +4115,14 @@ void SvNumberFormatter::ImpInitCurrencyTable()
 if ( pCurrencies[nDefault].Default )
 break;
 }
-std::unique_ptr pEntry;
+std::optional pEntry;
 if ( nDefault < nCurrencyCount )
 {
-pEntry.reset(new NfCurrencyEntry(pCurrencies[nDefault], 
*pLocaleData, eLang));
+pEntry.emplace(pCurrencies[nDefault], *pLocaleData, eLang);
 }
 else
 {   // first or ShellsAndPebbles
-pEntry.reset(new NfCurrencyEntry(*pLocaleData, eLang));
+pEntry.emplace(*pLocaleData, eLang);
 }
 if (LocaleDataWrapper::areChecksEnabled())
 {
@@ -4140,7 +4140,7 @@ void SvNumberFormatter::ImpInitCurrencyTable()
 nMatchingSystemCurrencyPosition = nCurrencyPos;
 }
 rCurrencyTable.insert(
-rCurrencyTable.begin() + nCurrencyPos++, std::move(pEntry));
+rCurrencyTable.begin() + nCurrencyPos++, std::move(*pEntry));
 // all remaining currencies for each locale
 if ( nCurrencyCount > 1 )
 {
@@ -4151,12 +4151,12 @@ void SvNumberFormatter::ImpInitCurrencyTable()
 {
 

[Libreoffice-bugs] [Bug 143461] Spanish language translation missing in LO Impress 7.2 RC1, path Formato>"Distribuir Selección".

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143461

--- Comment #2 from Albert Acer  ---
Created attachment 173717
  --> https://bugs.documentfoundation.org/attachment.cgi?id=173717=edit
Missing translation in LO Impress 7.2 RC1, Spanish version.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 143461] Spanish language translation missing in LO Impress 7.2 RC1, path Formato>"Distribuir Selección".

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143461

--- Comment #1 from Albert Acer  ---
In the screenshot which I have attached today July-20-2021, we can see where
and how the translation errors are reproduced.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 143461] New: Spanish language translation missing in LO Impress 7.2 RC1, path Formato>"Distribuir Selección".

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143461

Bug ID: 143461
   Summary: Spanish language translation missing in LO Impress 7.2
RC1, path Formato>"Distribuir Selección".
   Product: LibreOffice
   Version: 7.2.0.1 rc
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: albac...@gmail.com

Description:
When I am testing LO Impress 7.2 RC1 in Spanish, I find several strings, under
the “Formato” Menu, without translating to the Spanish language. These strings
also affect LO Draw 7.2 RC1 under the “Forma” Menu and the “Distribuir
Selección” Submenu.

LO 7.1  in Spanish is also affected by this same error.

Steps to Reproduce:
1. Open LO Impress 7.2 RC1, Spanish Version.
2. Explore the Format menu (“Formato” in Spanish).
3. Find the “Distribute Selection” submenu (“Distribuir Selección” in Spanish).


Actual Results:
Those stings appear in English instead of being displayed in Spanish as it
should be.

Expected Results:
Show all those strings in Spanish with the most accurate translation.

I propose the following translation for the strings of the Distribute Selection
submenu ("Distribuir Selección"), under the Format Menu ("Formato"), in LO
Impress 7.2 and LO 7.1.5 Spanish Version.


"Distribuir Selección",  instead of  Distribute Selection.

"Horizontalmente a la Izquierda",  instead of  Horizontally Left.

"Horizontalmente Centrado",  instead of  Horizontally Center.

"Horizontalmente Justificado",  instead of  Horizontally Spacing.

"Horizontalmente a la Derecha",  instead of  Horizontally Right.

"Verticalmente Arriba",  instead of  Vertically Top.

"Verticalmente Centrado",  instead of  Vertically Center.

"Verticalmente Justificado",  instead of  Vertically Spacing.

"Verticalmente Abajo",  instead of  Vertically Bottom.



Reproducible: Always


User Profile Reset: Yes



Additional Info:
[Information automatically included from LibreOffice]
Locale: es
Module: PresentationDocument
[Information guessed from browser]
OS: Windows (All)
OS is 64bit: no

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 143460] New: GPO upgrade error

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143460

Bug ID: 143460
   Summary: GPO upgrade error
   Product: LibreOffice
   Version: 7.1.4.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Installation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: d.fal...@live.de

Description:
Unable to update libreoffice via gpo, 'cause regedit entries are missed to
removed by installer

Steps to Reproduce:
Dear all, after long time I will provide a common issue of libreoffice here.

Handling to install libreoffice over Windows GPO Deployment works well.
If the machine is fresh installed or you manually clean the regedit.

Ways to reproduce

- First patching local code from fresh downloaded libreoffice with orca or
insted

- Put patched file to your deploy shared folder
- Check permissions
- Assing to gpo with update older one.

The common issue here is by updating, that update libreoffice will first remove
the older libreoffice version but don't delete important entries from regedit:

like this:

Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Classes\Installer\Products\A5D06EB74445D4E4B9EAA6B5AE222CAA



reg delete
"HKEY_LOCAL_MACHINE\SOFTWARE\Classes\Installer\Products\A5D06EB74445D4E4B9EAA6B5AE222CAA"
/f

reg delete
"HKEY_LOCAL_MACHINE\SOFTWARE\Classes\Installer\Products\EC69789BDA0BE894184E89F63ABB029B"
/f

So after an gpupdate the older libreoffice will be removed but never version is
not seen. 

'cause that the removing process by updating over gpo left the entries on
regedit libreoffice think it was successfully installed.

Only solution here if we want to update libreoffice via gpo is to delete
manually on all clients the keys from libreoffice.

after his with an gpupdate libreoffice will be installed fine.



Actual Results:
No workaround found , only to remove manually this regedit entries.

Expected Results:
It works


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Would be nice for some help here

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 143458] large tables can't be resized easily

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143458

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval

--- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> ---
Try use menu Paste Special -> Paste Special, select HTML variant, press OK
button

But in general I agree with the problem. MS Word in the same case shows a
horizontal ruler wider than page width and if we set up the text cursor into
the table then we'll see table border on the ruler out of the page and we'll
can move it as we need

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 143458] large tables can't be resized easily

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143458

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval

--- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> ---
Try use menu Paste Special -> Paste Special, select HTML variant, press OK
button

But in general I agree with the problem. MS Word in the same case shows a
horizontal ruler wider than page width and if we set up the text cursor into
the table then we'll see table border on the ruler out of the page and we'll
can move it as we need

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 143412] The texmaths extension makes LibO 7.2RC1 crash

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143412

--- Comment #8 from Julien Nabet  ---
(In reply to Roland Baudin from comment #7)
> Hi,
> 
> I am the author of the TexMaths extension. I was able to isolate the line
> that crashes LO 7.2:
> 
> oDispatcher.executeDispatch( oDrawDocCtrl.Frame, ".uno:ChangeBezier", "", 0,
> Array() )
> 
> This line 189 of the attached file ImportGraphicIntoTexMaths.bas.
> 
> Please note that this line worked in LO 7.1.x.

I dond't know if it's the same pb as Serge's one but I copied pasted the code
in a brand new file, brand new macro.
Then I runned the macro and had:
at line 21 "cURL_ = cURL" this error message box:
"BASIC runtime error.
Argument is not optional."

Would it be possible you attach a minimum example file so when just running the
macro we can reproduce the crash?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 143459] Page numbers total gets corrupted in docx

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143459

--- Comment #1 from Marco A.G.Pinto  ---
Created attachment 173716
  --> https://bugs.documentfoundation.org/attachment.cgi?id=173716=edit
screenshot of docx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 143459] New: Page numbers total gets corrupted in docx

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143459

Bug ID: 143459
   Summary: Page numbers total gets corrupted in docx
   Product: LibreOffice
   Version: 7.2.0.1 rc
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: marcoagpi...@sapo.pt

Created attachment 173715
  --> https://bugs.documentfoundation.org/attachment.cgi?id=173715=edit
docx

Hello!

When I open my Europass in LO 7.2.0.1 the total of page numbers gets corrupted.

Check the attached .docx plus screenshot.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 143412] The texmaths extension makes LibO 7.2RC1 crash

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143412

--- Comment #7 from Roland Baudin  ---
Hi,

I am the author of the TexMaths extension. I was able to isolate the line that
crashes LO 7.2:

oDispatcher.executeDispatch( oDrawDocCtrl.Frame, ".uno:ChangeBezier", "", 0,
Array() )

This line 189 of the attached file ImportGraphicIntoTexMaths.bas.

Please note that this line worked in LO 7.1.x.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 143412] The texmaths extension makes LibO 7.2RC1 crash

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143412

Roland Baudin  changed:

   What|Removed |Added

 CC||rolan...@free.fr

--- Comment #6 from Roland Baudin  ---
Created attachment 173714
  --> https://bugs.documentfoundation.org/attachment.cgi?id=173714=edit
Basic code for function in TexMaths that crashes LO 7.2 (at line 189)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 143439] Translate to hebrew of "Add rows above" is wrong

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143439

Julien Nabet  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||so...@libreoffice.org
 Resolution|--- |FIXED

--- Comment #9 from Julien Nabet  ---
(In reply to Anat from comment #8)
> (In reply to Anat from comment #7)
> > ...
> > Ming is right.
> > He shows exactly where the wrong translation.
> > maybe, you can copy the right translation from the other place, that you
> > mantion before.
> 
> should be "הוספת שורות מ~על"

Done. You can take a look at the same url as quoted by Ming:
https://translations.documentfoundation.org/translate/libo_ui-master/officecfgregistrydataorgopenofficeofficeui/he/?checksum=3597d02cbe119771

Sophie: I suppose 7.1 branch won't have the fix but any idea if it'll be
available for 7.2.0 or rather from 7.2.1 ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87720] Default insert image anchor, wrapping, and spacing (see comment #43 for summary at 2020-04-15)

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=87720

--- Comment #63 from Adalbert Hanßen  ---
Created attachment 173713
  --> https://bugs.documentfoundation.org/attachment.cgi?id=173713=edit
Screenshots how I followed the hint to set the default anchoring of pictures
which does not work.

I tried the hint from
https://bugs.documentfoundation.org/show_bug.cgi?id=87720#c60 but it does not
work, as can be seen in the attached document with screenshots of what I did
and what I experienced.

After the fact, I anchored the two pictures in this document at paragraphs, as
I always do.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: package/source

2021-07-20 Thread Noel Grandin (via logerrit)
 package/source/zipapi/blowfishcontext.cxx |4 ++--
 package/source/zipapi/blowfishcontext.hxx |4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 966ae2345ce09b73c2d8ea47abb983030cc580bf
Author: Noel Grandin 
AuthorDate: Sun Jul 18 19:03:42 2021 +0200
Commit: Noel Grandin 
CommitDate: Tue Jul 20 19:36:59 2021 +0200

osl::Mutex->std::mutex in BlowfishCFB8CipherContext

Change-Id: Id70ec156ab9e06a48a5a2571fc0186bd63b280a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119279
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/package/source/zipapi/blowfishcontext.cxx 
b/package/source/zipapi/blowfishcontext.cxx
index 506c6267aa28..d11a9f0d3c01 100644
--- a/package/source/zipapi/blowfishcontext.cxx
+++ b/package/source/zipapi/blowfishcontext.cxx
@@ -62,7 +62,7 @@ BlowfishCFB8CipherContext::~BlowfishCFB8CipherContext()
 
 uno::Sequence< sal_Int8 > SAL_CALL 
BlowfishCFB8CipherContext::convertWithCipherContext( const uno::Sequence< 
::sal_Int8 >& aData )
 {
-::osl::MutexGuard aGuard( m_aMutex );
+std::lock_guard aGuard( m_aMutex );
 if ( !m_pCipher )
 throw lang::DisposedException();
 
@@ -96,7 +96,7 @@ uno::Sequence< sal_Int8 > SAL_CALL 
BlowfishCFB8CipherContext::convertWithCipherC
 
 uno::Sequence< ::sal_Int8 > SAL_CALL 
BlowfishCFB8CipherContext::finalizeCipherContextAndDispose()
 {
-::osl::MutexGuard aGuard( m_aMutex );
+std::lock_guard aGuard( m_aMutex );
 if ( !m_pCipher )
 throw lang::DisposedException();
 
diff --git a/package/source/zipapi/blowfishcontext.hxx 
b/package/source/zipapi/blowfishcontext.hxx
index 11f44eed10ba..c0b603c15298 100644
--- a/package/source/zipapi/blowfishcontext.hxx
+++ b/package/source/zipapi/blowfishcontext.hxx
@@ -22,11 +22,11 @@
 #include 
 
 #include 
-#include 
+#include 
 
 class BlowfishCFB8CipherContext : public cppu::WeakImplHelper< 
css::xml::crypto::XCipherContext >
 {
-::osl::Mutex m_aMutex;
+std::mutex m_aMutex;
 void* m_pCipher;
 bool m_bEncrypt;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 139426] Update of Contents is freezing LibreOffice

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139426

--- Comment #12 from Armin Le Grand  ---
Argh - error in CppunitTest_sw_mailmerge. That's exactly what the original fix
fixed - AFAIR. Thus, need to check deeper.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112793] [META] DOC (binary) shape-related issues

2021-07-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112793
Bug 112793 depends on bug 123321, which changed state.

Bug 123321 Summary: FILEOPEN | DOC, missing longer line when saved in LO 
(shorter line remains)
https://bugs.documentfoundation.org/show_bug.cgi?id=123321

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: package/source

2021-07-20 Thread Noel Grandin (via logerrit)
 package/source/xstor/switchpersistencestream.cxx |   28 +++
 package/source/xstor/switchpersistencestream.hxx |4 +--
 2 files changed, 16 insertions(+), 16 deletions(-)

New commits:
commit d9f92805f15cf71f53a6a93f81805e088daca3d2
Author: Noel Grandin 
AuthorDate: Sun Jul 18 18:54:51 2021 +0200
Commit: Noel Grandin 
CommitDate: Tue Jul 20 19:24:14 2021 +0200

osl::Mutex->std::mutex in SwitchablePersistenceStream

Change-Id: I4f34f9df3f760f112244845688b34663e5febb79
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119278
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/package/source/xstor/switchpersistencestream.cxx 
b/package/source/xstor/switchpersistencestream.cxx
index 459f498fb98b..e646a3f06245 100644
--- a/package/source/xstor/switchpersistencestream.cxx
+++ b/package/source/xstor/switchpersistencestream.cxx
@@ -200,7 +200,7 @@ void SwitchablePersistenceStream::CloseAll_Impl()
 // css::io::XStream
 uno::Reference< io::XInputStream > SAL_CALL 
SwitchablePersistenceStream::getInputStream(  )
 {
-::osl::MutexGuard aGuard( m_aMutex );
+std::lock_guard aGuard( m_aMutex );
 
 if ( m_pStreamData )
 m_pStreamData->m_bInOpen = true;
@@ -209,7 +209,7 @@ uno::Reference< io::XInputStream > SAL_CALL 
SwitchablePersistenceStream::getInpu
 
 uno::Reference< io::XOutputStream > SAL_CALL 
SwitchablePersistenceStream::getOutputStream(  )
 {
-::osl::MutexGuard aGuard( m_aMutex );
+std::lock_guard aGuard( m_aMutex );
 
 if ( m_pStreamData )
 m_pStreamData->m_bOutOpen = true;
@@ -219,7 +219,7 @@ uno::Reference< io::XOutputStream > SAL_CALL 
SwitchablePersistenceStream::getOut
 // css::io::XInputStream
 ::sal_Int32 SAL_CALL SwitchablePersistenceStream::readBytes( uno::Sequence< 
::sal_Int8 >& aData, ::sal_Int32 nBytesToRead )
 {
-::osl::MutexGuard aGuard( m_aMutex );
+std::lock_guard aGuard( m_aMutex );
 
 if ( !m_pStreamData )
 throw io::NotConnectedException();
@@ -233,7 +233,7 @@ uno::Reference< io::XOutputStream > SAL_CALL 
SwitchablePersistenceStream::getOut
 
 ::sal_Int32 SAL_CALL SwitchablePersistenceStream::readSomeBytes( 
uno::Sequence< ::sal_Int8 >& aData, ::sal_Int32 nMaxBytesToRead )
 {
-::osl::MutexGuard aGuard( m_aMutex );
+std::lock_guard aGuard( m_aMutex );
 
 if ( !m_pStreamData )
 throw io::NotConnectedException();
@@ -247,7 +247,7 @@ uno::Reference< io::XOutputStream > SAL_CALL 
SwitchablePersistenceStream::getOut
 
 void SAL_CALL SwitchablePersistenceStream::skipBytes( ::sal_Int32 nBytesToSkip 
)
 {
-::osl::MutexGuard aGuard( m_aMutex );
+std::lock_guard aGuard( m_aMutex );
 
 if ( !m_pStreamData )
 throw io::NotConnectedException();
@@ -261,7 +261,7 @@ void SAL_CALL SwitchablePersistenceStream::skipBytes( 
::sal_Int32 nBytesToSkip )
 
 ::sal_Int32 SAL_CALL SwitchablePersistenceStream::available(  )
 {
-::osl::MutexGuard aGuard( m_aMutex );
+std::lock_guard aGuard( m_aMutex );
 
 if ( !m_pStreamData )
 throw io::NotConnectedException();
@@ -275,7 +275,7 @@ void SAL_CALL SwitchablePersistenceStream::skipBytes( 
::sal_Int32 nBytesToSkip )
 
 void SAL_CALL SwitchablePersistenceStream::closeInput()
 {
-::osl::MutexGuard aGuard( m_aMutex );
+std::lock_guard aGuard( m_aMutex );
 
 if ( !m_pStreamData )
 throw io::NotConnectedException();
@@ -288,7 +288,7 @@ void SAL_CALL SwitchablePersistenceStream::closeInput()
 // css::io::XOutputStream
 void SAL_CALL SwitchablePersistenceStream::writeBytes( const uno::Sequence< 
::sal_Int8 >& aData )
 {
-::osl::MutexGuard aGuard( m_aMutex );
+std::lock_guard aGuard( m_aMutex );
 
 if ( !m_pStreamData )
 throw io::NotConnectedException();
@@ -305,7 +305,7 @@ void SAL_CALL SwitchablePersistenceStream::writeBytes( 
const uno::Sequence< ::sa
 
 void SAL_CALL SwitchablePersistenceStream::flush(  )
 {
-::osl::MutexGuard aGuard( m_aMutex );
+std::lock_guard aGuard( m_aMutex );
 
 if ( !m_pStreamData || m_pStreamData->m_bInStreamBased )
 {
@@ -325,7 +325,7 @@ void SAL_CALL SwitchablePersistenceStream::flush(  )
 
 void SAL_CALL SwitchablePersistenceStream::closeOutput(  )
 {
-::osl::MutexGuard aGuard( m_aMutex );
+std::lock_guard aGuard( m_aMutex );
 
 if ( !m_pStreamData )
 throw io::NotConnectedException();
@@ -338,7 +338,7 @@ void SAL_CALL SwitchablePersistenceStream::closeOutput(  )
 // css::io::XTruncate
 void SAL_CALL SwitchablePersistenceStream::truncate(  )
 {
-::osl::MutexGuard aGuard( m_aMutex );
+std::lock_guard aGuard( m_aMutex );
 
 if ( !m_pStreamData )
 throw io::NotConnectedException();
@@ -356,7 +356,7 @@ void SAL_CALL SwitchablePersistenceStream::truncate(  )
 // css::io::XSeekable
 void SAL_CALL SwitchablePersistenceStream::seek( ::sal_Int64 location )
 {
-::osl::MutexGuard aGuard( m_aMutex );
+std::lock_guard aGuard( m_aMutex );
 
 if ( !m_pStreamData )
 

  1   2   3   4   >