[Libreoffice-bugs] [Bug 119745] Scrolling with a laptop touchpad in Libreoffice way too fast

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119745

Buovjaga  changed:

   What|Removed |Added

Version|7.1.4.2 release |6.0.6.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138960] UI: The file could not be loaded! dialog appears when pressing enter in sidebar/navigatgor with a shape selected

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138960

--- Comment #3 from Jim Raykowski  ---
I repro with gen vcl backend but not with gtk3.

Here is a link to one way to fix:
https://gerrit.libreoffice.org/c/core/+/120129

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143719] Writer hangs with some documents (edited previously with Word)

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143719

Marcos F  changed:

   What|Removed |Added

 Resolution|--- |NOTOURBUG
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Marcos F  ---
Sorry.
After starting in safe-mode, it was OK.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143497] SLIDESHOW: Much slower going to previous slide than to next slide

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143497

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143485] Slide image export: master slide image objects display inconsistent across export file formats

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143485

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143480] Writer: In Navigator, promotion or demotion of a level should change heading level in document

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143480

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141793] Insert of 3 images via smb share in writer crashes the desktop environment

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141793

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143520] Drawing glitch. Gray space separating pages shows content (disappears after scrolling)

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143520

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143513] Menus opened in cascade not to close as soon as an option is selected

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143513

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143512] Insert-hyperlink tool resets before I am done

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143512

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143752] DeckLayouter.cxx:489: OSL_ASSERT: nRemainingHeightToDistribute==0

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143752

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143752] DeckLayouter.cxx:489: OSL_ASSERT: nRemainingHeightToDistribute==0

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143752

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143485] Slide image export: master slide image objects display inconsistent across export file formats

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143485

--- Comment #4 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143485] Slide image export: master slide image objects display inconsistent across export file formats

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143485

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143019] Issue with the [Text Language] section of the status bar

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143019

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143019] Issue with the [Text Language] section of the status bar

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143019

--- Comment #7 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139458] broken dependancy in libreoffice7.04 package

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139458

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139458] broken dependancy in libreoffice7.04 package

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139458

--- Comment #3 from QA Administrators  ---
Dear rgarand,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 134728] Saving into single files inside Mail Merge is ignoring hidden paragraphs

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134728

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 134728] Saving into single files inside Mail Merge is ignoring hidden paragraphs

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134728

--- Comment #5 from QA Administrators  ---
Dear michael,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 55969] BASIC: API methods for select-protected-cells

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=55969

--- Comment #11 from QA Administrators  ---
Dear pierre-yves samyn,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 126629] Writer reads some n-dashes as words - Editing

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126629

--- Comment #3 from QA Administrators  ---
Dear stephen.sottong,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 121459] UI - Tabbed Notebook bar activation removes LibreOffice main app menu

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121459

--- Comment #10 from QA Administrators  ---
Dear Alex Thurgood,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 114973] Ctrl+A and Select all don't work when a style is hidden

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114973

--- Comment #16 from QA Administrators  ---
Dear Lafricain,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 100414] incorrect usage of "maj" instead of "shift" on Locale: nl-BE (nl_BE).

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=100414

--- Comment #11 from QA Administrators  ---
Dear Roeland,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 119745] Scrolling with a laptop touchpad in Libreoffice way too fast

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119745

George Theodoridis  changed:

   What|Removed |Added

Version|6.0.6.2 release |7.1.4.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 119745] Scrolling with a laptop touchpad in Libreoffice way too fast

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119745

--- Comment #29 from George Theodoridis  ---
Also have this problem. Unusably fast touchpad for Writer and Calc (at least).
One of a few deal breakers getting a team to adopt libreoffice.
Lenovo Legion 5 Win 10 64

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 119745] Scrolling with a laptop touchpad in Libreoffice way too fast

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119745

George Theodoridis  changed:

   What|Removed |Added

 CC||busin...@lawarchitects.com.
   ||au

--- Comment #28 from George Theodoridis  ---
Also have this problem. Unusably fast touchpad for Writer and Calc (at least).
One of a few deal breakers getting a team to adopt libreoffice.
Lenovo Legion 5 Win 10 64

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 136361] [META] DOCX Canvas shape related issues

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136361

Aron Budea  changed:

   What|Removed |Added

Version|7.1.0.0.alpha0+ |unspecified

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103182
Bug 103182 depends on bug 121679, which changed state.

Bug 121679 Summary: Ctrl+Shift+J does not fully maximize the workspace on 
Ubuntu 18.10
https://bugs.documentfoundation.org/show_bug.cgi?id=121679

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 121679] Ctrl+Shift+J does not fully maximize the workspace on Ubuntu 18.10

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121679

Miloš Jovanović  changed:

   What|Removed |Added

Version|6.1.2.1 release |6.0.4.2 release
  Component|Calc|LibreOffice
 Resolution|WORKSFORME  |---
 Status|RESOLVED|REOPENED

--- Comment #21 from Miloš Jovanović  ---
This shouldn't have been marked as RESOLVED (I'm assuming because of the
automated message?). Issue is not exclusive to Calc or Ubuntu. I'm on Debian
Bullseye and have the same issue in multiple components (including both Writer
and Calc). 

Libreoffice does not correctly enter full screen (only works as windows full
screen mode). This isn't expected behavior. Full screen works as expected in
other apps (Firefox, video players, PDF readers, etc).

Software versions:

Gnome 3.38.5, running an X11 session
Libreoffice 7.0.4-4.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143759] Inaccurate results when searching for empty cells with regex ^$

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143759

stragu  changed:

   What|Removed |Added

Version|6.2.5.2 release |5.2.0.4 release

--- Comment #4 from stragu  ---
Thanks Eike.
About the range outside of the data area: that makes sense that it is not
currently searched currently.
It is even commented about in the code:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=69ac605191860aceee09f1147a5234222d1b3300
But wondering if ScTable::SearchAndReplaceEmptyCells could be improved by
adding an extra step:
1. remove the range outside the data area before searching (current behaviour);
2. search inside the data area (current behaviour);
3. add the outside selection back into returned selection (added step).
That wouldn't add unnecessary overhead, but would result in a more expected
behaviour, in my opinion.

In any case, the most important issue is obviously the second part about
returning selected cells that weren't originally part of the selection.

Reproduced in 5.2.0 as well, so assuming the behaviour started with the commit
linked above.

Version: 5.2.0.0.alpha1
Build ID: 902b28a39528b6c92602e9b521a1d0861be1caf9
CPU Threads: 4; OS Version: Linux 5.4; UI Render: default; 
Locale: en-AU (en_AU.UTF-8)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - sw/source sw/uiconfig

2021-08-06 Thread Caolán McNamara (via logerrit)
 sw/source/ui/index/cnttab.cxx|5 +++--
 sw/uiconfig/swriter/ui/assignstylesdialog.ui |1 +
 2 files changed, 4 insertions(+), 2 deletions(-)

New commits:
commit 9cf27e924aaea4d45c059edec07be1429cbb16d4
Author: Caolán McNamara 
AuthorDate: Thu Aug 5 11:18:45 2021 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Sat Aug 7 01:34:35 2021 +0200

Resolves: tdf#143720 treeview not resizing to fill available space

Change-Id: I041c3a743b8624f49bfe57e8a4469535e334e5dc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119987
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/sw/source/ui/index/cnttab.cxx b/sw/source/ui/index/cnttab.cxx
index 30c9407064d3..c23a3b7adc9d 100644
--- a/sw/source/ui/index/cnttab.cxx
+++ b/sw/source/ui/index/cnttab.cxx
@@ -513,7 +513,8 @@ SwAddStylesDlg_Impl::SwAddStylesDlg_Impl(weld::Window* 
pParent,
 aWidths.push_back(m_xHeaderTree->get_pixel_size(sTitle).Width() + 
nPadding);
 }
 m_xHeaderTree->set_column_fixed_widths(aWidths);
-auto nWidth = std::accumulate(aWidths.begin(), aWidths.end(), 0);
+auto nWidth = std::accumulate(aWidths.begin(), aWidths.end(),
+  
Application::GetSettings().GetStyleSettings().GetScrollBarSize());
 m_xHeaderTree->set_size_request(nWidth, 
m_xHeaderTree->get_height_rows(15));
 
 int nRow(0);
@@ -576,7 +577,7 @@ SwAddStylesDlg_Impl::SwAddStylesDlg_Impl(weld::Window* 
pParent,
 
 IMPL_LINK(SwAddStylesDlg_Impl, TreeSizeAllocHdl, const Size&, rSize, void)
 {
-auto nWidth = rSize.Width();
+auto nWidth = rSize.Width() - 
Application::GetSettings().GetStyleSettings().GetScrollBarSize();
 
 std::vector aWidths;
 aWidths.push_back(0);
diff --git a/sw/uiconfig/swriter/ui/assignstylesdialog.ui 
b/sw/uiconfig/swriter/ui/assignstylesdialog.ui
index 81f8444b56da..83d150e5bd09 100644
--- a/sw/uiconfig/swriter/ui/assignstylesdialog.ui
+++ b/sw/uiconfig/swriter/ui/assignstylesdialog.ui
@@ -180,6 +180,7 @@
 True
 False
 start
+True
 12
 
   


[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - sw/source sw/uiconfig

2021-08-06 Thread Caolán McNamara (via logerrit)
 sw/source/ui/index/cnttab.cxx|5 +++--
 sw/uiconfig/swriter/ui/assignstylesdialog.ui |1 +
 2 files changed, 4 insertions(+), 2 deletions(-)

New commits:
commit 660a8eae3c5d92f08bf72342f41fd97249099ab5
Author: Caolán McNamara 
AuthorDate: Thu Aug 5 11:18:45 2021 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Sat Aug 7 01:34:17 2021 +0200

Resolves: tdf#143720 treeview not resizing to fill available space

Change-Id: I041c3a743b8624f49bfe57e8a4469535e334e5dc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120068
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/sw/source/ui/index/cnttab.cxx b/sw/source/ui/index/cnttab.cxx
index bcabdc6aabbb..23b14d20e410 100644
--- a/sw/source/ui/index/cnttab.cxx
+++ b/sw/source/ui/index/cnttab.cxx
@@ -513,7 +513,8 @@ SwAddStylesDlg_Impl::SwAddStylesDlg_Impl(weld::Window* 
pParent,
 aWidths.push_back(m_xHeaderTree->get_pixel_size(sTitle).Width() + 
nPadding);
 }
 m_xHeaderTree->set_column_fixed_widths(aWidths);
-auto nWidth = std::accumulate(aWidths.begin(), aWidths.end(), 0);
+auto nWidth = std::accumulate(aWidths.begin(), aWidths.end(),
+  
Application::GetSettings().GetStyleSettings().GetScrollBarSize());
 m_xHeaderTree->set_size_request(nWidth, 
m_xHeaderTree->get_height_rows(15));
 
 int nRow(0);
@@ -576,7 +577,7 @@ SwAddStylesDlg_Impl::SwAddStylesDlg_Impl(weld::Window* 
pParent,
 
 IMPL_LINK(SwAddStylesDlg_Impl, TreeSizeAllocHdl, const Size&, rSize, void)
 {
-auto nWidth = rSize.Width();
+auto nWidth = rSize.Width() - 
Application::GetSettings().GetStyleSettings().GetScrollBarSize();
 
 std::vector aWidths;
 aWidths.push_back(0);
diff --git a/sw/uiconfig/swriter/ui/assignstylesdialog.ui 
b/sw/uiconfig/swriter/ui/assignstylesdialog.ui
index 33902bf15a0e..51c846eb27c5 100644
--- a/sw/uiconfig/swriter/ui/assignstylesdialog.ui
+++ b/sw/uiconfig/swriter/ui/assignstylesdialog.ui
@@ -186,6 +186,7 @@
 True
 False
 start
+True
 12
 
   


[Libreoffice-commits] core.git: include/vcl vcl/backendtest vcl/inc vcl/qa

2021-08-06 Thread homeboy445 (via logerrit)
 include/vcl/test/GraphicsRenderTests.hxx  |4 
 vcl/backendtest/GraphicsRenderTests.cxx   |   86 ++
 vcl/backendtest/outputdevice/common.cxx   |  138 ++
 vcl/backendtest/outputdevice/polygon.cxx  |   24 +
 vcl/backendtest/outputdevice/polyline.cxx |   27 +
 vcl/inc/test/outputdevice.hxx |7 +
 vcl/qa/cppunit/BackendTest.cxx|   46 ++
 7 files changed, 332 insertions(+)

New commits:
commit 3c2cf76892890051e27e0e0798b7a06fc3acccd8
Author: homeboy445 
AuthorDate: Thu Jul 1 17:47:48 2021 +0530
Commit: Tomaž Vajngerl 
CommitDate: Sat Aug 7 01:10:51 2021 +0200

backendtest: drop like shape test for polygon / polyline

Add a test for drawing a drop like shape using polygon and polyline
drawing code-paths.


Change-Id: Ifee7b978009d66af01ccbfc92b36d1423084ed48
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118278
Tested-by: Tomaž Vajngerl 
Reviewed-by: Tomaž Vajngerl 

diff --git a/include/vcl/test/GraphicsRenderTests.hxx 
b/include/vcl/test/GraphicsRenderTests.hxx
index dd39cc16d815..b8307b97ab25 100644
--- a/include/vcl/test/GraphicsRenderTests.hxx
+++ b/include/vcl/test/GraphicsRenderTests.hxx
@@ -75,8 +75,12 @@ class VCL_PLUGIN_PUBLIC GraphicsRenderTests
 void testDrawInvertWithRectangle();
 void testDrawInvertN50WithRectangle();
 void testDrawInvertTrackFrameWithRectangle();
+void testDrawDropShapeWithPolyline();
+void testDrawDropShapeAAWithPolyline();
 void testDrawBezierWithPolylineB2D();
 void testDrawBezierAAWithPolylineB2D();
+void testDrawDropShapeWithPolygon();
+void testDrawDropShapeAAWithPolygon();
 void testDrawBitmap();
 void testDrawTransformedBitmap();
 void testDrawBitmapExWithAlpha();
diff --git a/vcl/backendtest/GraphicsRenderTests.cxx 
b/vcl/backendtest/GraphicsRenderTests.cxx
index cd19d4255902..eae05149840b 100644
--- a/vcl/backendtest/GraphicsRenderTests.cxx
+++ b/vcl/backendtest/GraphicsRenderTests.cxx
@@ -636,6 +636,47 @@ void 
GraphicsRenderTests::testDrawInvertTrackFrameWithRectangle()
 }
 }
 
+void GraphicsRenderTests::testDrawDropShapeWithPolyline()
+{
+vcl::test::OutputDeviceTestPolyLine aOutDevTest;
+Bitmap aBitmap = aOutDevTest.setupDropShape();
+OUString atestName = "testDrawDropShapeWithPolyline";
+if (!SHOULD_ASSERT)
+{
+appendTestResult(atestName, "SKIPPED");
+return;
+}
+vcl::test::TestResult eResult = 
vcl::test::OutputDeviceTestCommon::checkDropShape(aBitmap);
+appendTestResult(atestName, returnTestStatus(eResult),
+ (m_aStoreResultantBitmap ? aBitmap : Bitmap()));
+if (m_aStoreResultantBitmap)
+{
+BitmapEx aBitmapEx(aBitmap);
+exportBitmapExToImage(m_aUserInstallPath + atestName + ".png", 
aBitmapEx);
+}
+}
+
+void GraphicsRenderTests::testDrawDropShapeAAWithPolyline()
+{
+vcl::test::OutputDeviceTestPolyLine aOutDevTest;
+Bitmap aBitmap = aOutDevTest.setupAADropShape();
+OUString atestName = "testDrawDropShapeAAWithPolyline";
+if (!SHOULD_ASSERT)
+{
+appendTestResult(atestName, "SKIPPED");
+return;
+}
+vcl::test::TestResult eResult
+= vcl::test::OutputDeviceTestCommon::checkDropShape(aBitmap, true);
+appendTestResult(atestName, returnTestStatus(eResult),
+ (m_aStoreResultantBitmap ? aBitmap : Bitmap()));
+if (m_aStoreResultantBitmap)
+{
+BitmapEx aBitmapEx(aBitmap);
+exportBitmapExToImage(m_aUserInstallPath + atestName + ".png", 
aBitmapEx);
+}
+}
+
 void GraphicsRenderTests::testDrawBezierWithPolylineB2D()
 {
 vcl::test::OutputDeviceTestPolyLineB2D aOutDevTest;
@@ -676,6 +717,47 @@ void GraphicsRenderTests::testDrawBezierAAWithPolylineB2D()
 }
 }
 
+void GraphicsRenderTests::testDrawDropShapeWithPolygon()
+{
+vcl::test::OutputDeviceTestPolygon aOutDevTest;
+Bitmap aBitmap = aOutDevTest.setupDropShape();
+OUString atestName = "testDrawDropShapeWithPolygon";
+if (!SHOULD_ASSERT)
+{
+appendTestResult(atestName, "SKIPPED");
+return;
+}
+vcl::test::TestResult eResult = 
vcl::test::OutputDeviceTestCommon::checkDropShape(aBitmap);
+appendTestResult(atestName, returnTestStatus(eResult),
+ (m_aStoreResultantBitmap ? aBitmap : Bitmap()));
+if (m_aStoreResultantBitmap)
+{
+BitmapEx aBitmapEx(aBitmap);
+exportBitmapExToImage(m_aUserInstallPath + atestName + ".png", 
aBitmapEx);
+}
+}
+
+void GraphicsRenderTests::testDrawDropShapeAAWithPolygon()
+{
+vcl::test::OutputDeviceTestPolygon aOutDevTest;
+Bitmap aBitmap = aOutDevTest.setupAADropShape();
+OUString atestName = "testDrawDropShapeAAWithPolygon";
+if (!SHOULD_ASSERT)
+{
+appendTestResult(atestName, "SKIPPED");
+return;
+}
+vcl::test::TestResult eResult
+= 

[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - drawinglayer/source svx/qa svx/source

2021-08-06 Thread Miklos Vajna (via logerrit)
 drawinglayer/source/tools/primitive2dxmldump.cxx   |4 ++-
 svx/qa/unit/data/slide-background.odp  |binary
 svx/qa/unit/data/slide-background.png  |binary
 svx/qa/unit/sdr.cxx|   24 +
 svx/source/sdr/primitive2d/sdrattributecreator.cxx |8 +++
 5 files changed, 35 insertions(+), 1 deletion(-)

New commits:
commit b68472285854ace9a1d667c166c623b98bebf846
Author: Miklos Vajna 
AuthorDate: Tue Aug 3 13:39:20 2021 +0200
Commit: Tomaž Vajngerl 
CommitDate: Sat Aug 7 01:02:35 2021 +0200

tdf#142436 svx: fix handling of linked background images

Regression from commit 9fb7aaf570c03c8a26d763f1205fb8c890e8211a (Make
linked graphic register into LinkedManager again, 2018-04-13), the
problem was that now SvXMLImport::loadGraphicByURL() produces a Graphic
that has its type set to GraphicType::Default, but when
drawinglayer::primitive2d::createNewSdrFillGraphicAttribute() consumes
this graphic, it expects that the type is either a bitmap or a metafile.

Fix the problem by explicitly loading the image when the default-type,
origin-url-set case happens: this is rendering, so no problem to load
the URL and that will give us the expected graphic type.

This is also meant to keep the original problem fixed, since the Graphic
that is part of the doc model is unchanged.

(cherry picked from commit c88ff9298b25132fc34102230cef0263f045a523)

Conflicts:
drawinglayer/source/tools/primitive2dxmldump.cxx

Change-Id: If5bba09faa23ef35f99152d4b5d30cd9cf67ace8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120097
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/drawinglayer/source/tools/primitive2dxmldump.cxx 
b/drawinglayer/source/tools/primitive2dxmldump.cxx
index 4b0c47f41da0..7c5e5771d9bc 100644
--- a/drawinglayer/source/tools/primitive2dxmldump.cxx
+++ b/drawinglayer/source/tools/primitive2dxmldump.cxx
@@ -396,7 +396,9 @@ void Primitive2dXmlDump::decomposeAndWrite(
 }
 rWriter.attribute("x", aTranslate.getX());
 rWriter.attribute("y", aTranslate.getY());
-rWriter.attribute("text", 
rTextSimplePortionPrimitive2D.getText());
+OUString aText = rTextSimplePortionPrimitive2D.getText();
+// TODO share code with 
sax_fastparser::FastSaxSerializer::write().
+rWriter.attribute("text", aText.replaceAll("", ""));
 rWriter.attribute("fontcolor", 
convertColorToString(rTextSimplePortionPrimitive2D.getFontColor()));
 
 const drawinglayer::attribute::FontAttribute& aFontAttribute = 
rTextSimplePortionPrimitive2D.getFontAttribute();
diff --git a/svx/qa/unit/data/slide-background.odp 
b/svx/qa/unit/data/slide-background.odp
new file mode 100644
index ..ea62bd63903b
Binary files /dev/null and b/svx/qa/unit/data/slide-background.odp differ
diff --git a/svx/qa/unit/data/slide-background.png 
b/svx/qa/unit/data/slide-background.png
new file mode 100644
index ..3a8c5ceb4262
Binary files /dev/null and b/svx/qa/unit/data/slide-background.png differ
diff --git a/svx/qa/unit/sdr.cxx b/svx/qa/unit/sdr.cxx
index 10f9901a0d60..e6ca7f7a87ad 100644
--- a/svx/qa/unit/sdr.cxx
+++ b/svx/qa/unit/sdr.cxx
@@ -118,6 +118,30 @@ CPPUNIT_TEST_FIXTURE(SdrTest, testZeroWidthTextWrap)
 // i.e. the text on the only shape on the slide had 12 lines, not a single 
one.
 assertXPath(pDocument, "//textsimpleportion", 1);
 }
+
+CPPUNIT_TEST_FIXTURE(SdrTest, testSlideBackground)
+{
+// Given a document with a slide what has a linked background image:
+test::Directories aDirectories;
+OUString aURL = 
aDirectories.getURLFromSrc(u"svx/qa/unit/data/slide-background.odp");
+getComponent() = loadFromDesktop(aURL);
+uno::Reference 
xDrawPagesSupplier(getComponent(), uno::UNO_QUERY);
+uno::Reference 
xDrawPage(xDrawPagesSupplier->getDrawPages()->getByIndex(0),
+ uno::UNO_QUERY);
+
+// When rendering that document:
+drawinglayer::primitive2d::Primitive2DContainer xPrimitiveSequence
+= renderPageToPrimitives(xDrawPage);
+
+// Then make sure that the background has a bitmap:
+drawinglayer::Primitive2dXmlDump aDumper;
+xmlDocUniquePtr pDocument = aDumper.dumpAndParse(xPrimitiveSequence);
+// Without the accompanying fix in place, this test would have failed with:
+// - Expected: 1
+// - Actual  : 0
+// i.e. the rendering did not find the bitmap.
+assertXPath(pDocument, "//bitmap", 1);
+}
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/svx/source/sdr/primitive2d/sdrattributecreator.cxx 
b/svx/source/sdr/primitive2d/sdrattributecreator.cxx
index 8b2fa387a836..855bc0daf573 100644
--- a/svx/source/sdr/primitive2d/sdrattributecreator.cxx
+++ 

[Libreoffice-commits] core.git: include/vcl vcl/source

2021-08-06 Thread panoskorovesis (via logerrit)
 include/vcl/filter/SvmWriter.hxx|1 +
 vcl/source/filter/svm/SvmWriter.cxx |   14 ++
 2 files changed, 15 insertions(+)

New commits:
commit dded839196aa8ed20253025dd8200fb2ee50bcea
Author: panoskorovesis 
AuthorDate: Wed Aug 4 13:18:08 2021 +0300
Commit: Tomaž Vajngerl 
CommitDate: Sat Aug 7 01:00:51 2021 +0200

Add Handler for TextLanguage Write

The handler separates MetaTextLanguageAction::Write from metaact.hxx
Write implementation is now in SvmWriter.hxx

Change-Id: I1671a299e84f5575359474e0fc4f9128c738b1e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120111
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/include/vcl/filter/SvmWriter.hxx b/include/vcl/filter/SvmWriter.hxx
index 9162dc1af0e8..93d907a36522 100644
--- a/include/vcl/filter/SvmWriter.hxx
+++ b/include/vcl/filter/SvmWriter.hxx
@@ -69,4 +69,5 @@ public:
 void RefPointHandler(MetaRefPointAction* pAction);
 void CommentHandler(MetaCommentAction* pAction);
 void LayoutModeHandler(MetaLayoutModeAction* pAction);
+void TextLanguageHandler(MetaTextLanguageAction* pAction);
 };
\ No newline at end of file
diff --git a/vcl/source/filter/svm/SvmWriter.cxx 
b/vcl/source/filter/svm/SvmWriter.cxx
index 3cddbd48edb5..c9f4ad52ec97 100644
--- a/vcl/source/filter/svm/SvmWriter.cxx
+++ b/vcl/source/filter/svm/SvmWriter.cxx
@@ -290,6 +290,13 @@ void SvmWriter::MetaActionHandler(MetaAction* pAction, 
ImplMetaWriteData* pData)
 }
 break;
 
+case MetaActionType::TEXTLANGUAGE:
+{
+auto* pMetaAction = static_cast(pAction);
+TextLanguageHandler(pMetaAction);
+}
+break;
+
 /* default case prevents test failure and will be
 removed once all the handlers are completed */
 default:
@@ -672,4 +679,11 @@ void SvmWriter::LayoutModeHandler(MetaLayoutModeAction* 
pAction)
 VersionCompatWrite aCompat(mrStream, 1);
 mrStream.WriteUInt32(static_cast(pAction->GetLayoutMode()));
 }
+
+void SvmWriter::TextLanguageHandler(MetaTextLanguageAction* pAction)
+{
+mrStream.WriteUInt16(static_cast(pAction->GetType()));
+VersionCompatWrite aCompat(mrStream, 1);
+mrStream.WriteUInt16(static_cast(pAction->GetTextLanguage()));
+}
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */


[Libreoffice-commits] core.git: include/vcl vcl/source

2021-08-06 Thread panoskorovesis (via logerrit)
 include/vcl/filter/SvmWriter.hxx|1 +
 vcl/source/filter/svm/SvmWriter.cxx |   14 ++
 2 files changed, 15 insertions(+)

New commits:
commit 0eb1b82dbc2dbaeefa06f42f4fc376b54d99bd1c
Author: panoskorovesis 
AuthorDate: Wed Aug 4 13:06:15 2021 +0300
Commit: Tomaž Vajngerl 
CommitDate: Sat Aug 7 01:00:32 2021 +0200

Add Handler for LayoutMode Write

The handler separates MetaLayoutModeAction::Write from metaact.hxx
Write implementation is now in SvmWriter.hxx

Change-Id: I63b045cb9bdb40e1b6c961d30df8bcfbe1b8129b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120110
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/include/vcl/filter/SvmWriter.hxx b/include/vcl/filter/SvmWriter.hxx
index d1466c60a334..9162dc1af0e8 100644
--- a/include/vcl/filter/SvmWriter.hxx
+++ b/include/vcl/filter/SvmWriter.hxx
@@ -68,4 +68,5 @@ public:
 void EPSHandler(MetaEPSAction* pAction);
 void RefPointHandler(MetaRefPointAction* pAction);
 void CommentHandler(MetaCommentAction* pAction);
+void LayoutModeHandler(MetaLayoutModeAction* pAction);
 };
\ No newline at end of file
diff --git a/vcl/source/filter/svm/SvmWriter.cxx 
b/vcl/source/filter/svm/SvmWriter.cxx
index afddcf80bb67..3cddbd48edb5 100644
--- a/vcl/source/filter/svm/SvmWriter.cxx
+++ b/vcl/source/filter/svm/SvmWriter.cxx
@@ -283,6 +283,13 @@ void SvmWriter::MetaActionHandler(MetaAction* pAction, 
ImplMetaWriteData* pData)
 }
 break;
 
+case MetaActionType::LAYOUTMODE:
+{
+auto* pMetaAction = static_cast(pAction);
+LayoutModeHandler(pMetaAction);
+}
+break;
+
 /* default case prevents test failure and will be
 removed once all the handlers are completed */
 default:
@@ -658,4 +665,11 @@ void SvmWriter::CommentHandler(MetaCommentAction* pAction)
 if (pAction->GetDataSize())
 mrStream.WriteBytes(pAction->GetData(), pAction->GetDataSize());
 }
+
+void SvmWriter::LayoutModeHandler(MetaLayoutModeAction* pAction)
+{
+mrStream.WriteUInt16(static_cast(pAction->GetType()));
+VersionCompatWrite aCompat(mrStream, 1);
+mrStream.WriteUInt32(static_cast(pAction->GetLayoutMode()));
+}
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */


[Libreoffice-commits] core.git: include/vcl vcl/source

2021-08-06 Thread panoskorovesis (via logerrit)
 include/vcl/filter/SvmWriter.hxx|1 +
 vcl/source/filter/svm/SvmWriter.cxx |   18 ++
 2 files changed, 19 insertions(+)

New commits:
commit f41a03960933fba0e3177ea0463c5c9ec361bc96
Author: panoskorovesis 
AuthorDate: Wed Aug 4 13:02:37 2021 +0300
Commit: Tomaž Vajngerl 
CommitDate: Sat Aug 7 01:00:05 2021 +0200

Add Handler for Comment Write

The handler separates MetaCommentAction::Write from metaact.hxx
Write implementation is now in SvmWriter.hxx

Change-Id: I2967b1f66c2467b622980ba3b65199ff8045d1b5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120109
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/include/vcl/filter/SvmWriter.hxx b/include/vcl/filter/SvmWriter.hxx
index ae2a690079c4..d1466c60a334 100644
--- a/include/vcl/filter/SvmWriter.hxx
+++ b/include/vcl/filter/SvmWriter.hxx
@@ -67,4 +67,5 @@ public:
 void FloatTransparentHandler(MetaFloatTransparentAction* pAction);
 void EPSHandler(MetaEPSAction* pAction);
 void RefPointHandler(MetaRefPointAction* pAction);
+void CommentHandler(MetaCommentAction* pAction);
 };
\ No newline at end of file
diff --git a/vcl/source/filter/svm/SvmWriter.cxx 
b/vcl/source/filter/svm/SvmWriter.cxx
index eb2ea4835282..afddcf80bb67 100644
--- a/vcl/source/filter/svm/SvmWriter.cxx
+++ b/vcl/source/filter/svm/SvmWriter.cxx
@@ -276,6 +276,13 @@ void SvmWriter::MetaActionHandler(MetaAction* pAction, 
ImplMetaWriteData* pData)
 }
 break;
 
+case MetaActionType::COMMENT:
+{
+auto* pMetaAction = static_cast(pAction);
+CommentHandler(pMetaAction);
+}
+break;
+
 /* default case prevents test failure and will be
 removed once all the handlers are completed */
 default:
@@ -640,4 +647,15 @@ void SvmWriter::RefPointHandler(MetaRefPointAction* 
pAction)
 aSerializer.writePoint(pAction->GetRefPoint());
 mrStream.WriteBool(pAction->IsSetting());
 }
+
+void SvmWriter::CommentHandler(MetaCommentAction* pAction)
+{
+mrStream.WriteUInt16(static_cast(pAction->GetType()));
+VersionCompatWrite aCompat(mrStream, 1);
+write_uInt16_lenPrefixed_uInt8s_FromOString(mrStream, 
pAction->GetComment());
+
mrStream.WriteInt32(pAction->GetValue()).WriteUInt32(pAction->GetDataSize());
+
+if (pAction->GetDataSize())
+mrStream.WriteBytes(pAction->GetData(), pAction->GetDataSize());
+}
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */


[Libreoffice-commits] core.git: include/vcl vcl/source

2021-08-06 Thread panoskorovesis (via logerrit)
 include/vcl/filter/SvmWriter.hxx|1 +
 vcl/source/filter/svm/SvmWriter.cxx |   17 +
 2 files changed, 18 insertions(+)

New commits:
commit 1a04ee2643ba970ededf1259918dea0122b9166c
Author: panoskorovesis 
AuthorDate: Wed Aug 4 12:56:49 2021 +0300
Commit: Tomaž Vajngerl 
CommitDate: Sat Aug 7 00:59:38 2021 +0200

Add Handler for RefPoint Write

The handler separates MetaRefPointAction::Write from metaact.hxx
Write implementation is now in SvmWriter.hxx

Change-Id: I04e666748ff75a145af8e3c1e44ae4f119cc1b1b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120108
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/include/vcl/filter/SvmWriter.hxx b/include/vcl/filter/SvmWriter.hxx
index 014b59afbec5..ae2a690079c4 100644
--- a/include/vcl/filter/SvmWriter.hxx
+++ b/include/vcl/filter/SvmWriter.hxx
@@ -66,4 +66,5 @@ public:
 void TransparentHandler(MetaTransparentAction* pAction);
 void FloatTransparentHandler(MetaFloatTransparentAction* pAction);
 void EPSHandler(MetaEPSAction* pAction);
+void RefPointHandler(MetaRefPointAction* pAction);
 };
\ No newline at end of file
diff --git a/vcl/source/filter/svm/SvmWriter.cxx 
b/vcl/source/filter/svm/SvmWriter.cxx
index 057a5e7c1bc0..eb2ea4835282 100644
--- a/vcl/source/filter/svm/SvmWriter.cxx
+++ b/vcl/source/filter/svm/SvmWriter.cxx
@@ -269,6 +269,13 @@ void SvmWriter::MetaActionHandler(MetaAction* pAction, 
ImplMetaWriteData* pData)
 }
 break;
 
+case MetaActionType::REFPOINT:
+{
+auto* pMetaAction = static_cast(pAction);
+RefPointHandler(pMetaAction);
+}
+break;
+
 /* default case prevents test failure and will be
 removed once all the handlers are completed */
 default:
@@ -623,4 +630,14 @@ void SvmWriter::EPSHandler(MetaEPSAction* pAction)
 GDIMetaFile aMtf = pAction->GetSubstitute();
 aWriter.Write(aMtf);
 }
+
+void SvmWriter::RefPointHandler(MetaRefPointAction* pAction)
+{
+mrStream.WriteUInt16(static_cast(pAction->GetType()));
+VersionCompatWrite aCompat(mrStream, 1);
+
+TypeSerializer aSerializer(mrStream);
+aSerializer.writePoint(pAction->GetRefPoint());
+mrStream.WriteBool(pAction->IsSetting());
+}
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */


[Libreoffice-commits] core.git: vcl/workben

2021-08-06 Thread panoskorovesis (via logerrit)
 vcl/workben/fftester.cxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 3d1a4caf4062b906aaeab38f0b841dcacdc22c50
Author: panoskorovesis 
AuthorDate: Wed Aug 4 11:38:04 2021 +0300
Commit: Tomaž Vajngerl 
CommitDate: Sat Aug 7 00:59:08 2021 +0200

Replace ReadGDIMetaFile with Svmreader::Read in fftester.cxx

Use the new read functionality in vcl/workben/fftester.cxx

Change-Id: I8ece06ba143f5ae86fae05d43e3e3b325e20ddb4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120107
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/vcl/workben/fftester.cxx b/vcl/workben/fftester.cxx
index e0696977a89c..4359452f39ac 100644
--- a/vcl/workben/fftester.cxx
+++ b/vcl/workben/fftester.cxx
@@ -46,6 +46,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -183,7 +184,8 @@ SAL_IMPLEMENT_MAIN_WITH_ARGS(argc, argv)
 {
 GDIMetaFile aGDIMetaFile;
 SvFileStream aFileStream(out, StreamMode::READ);
-ReadGDIMetaFile(aFileStream, aGDIMetaFile);
+SvmReader aReader(aFileStream);
+aReader.Read(aGDIMetaFile);
 }
 else if (strcmp(argv[2], "pcd") == 0)
 {


[Libreoffice-commits] core.git: vcl/workben

2021-08-06 Thread panoskorovesis (via logerrit)
 vcl/workben/svmfuzzer.cxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit ad982bc87f96c31af6fa3e81d33af29b991199ce
Author: panoskorovesis 
AuthorDate: Wed Aug 4 11:24:31 2021 +0300
Commit: Tomaž Vajngerl 
CommitDate: Sat Aug 7 00:58:53 2021 +0200

Replace ReadGDIMetaFile with SvmReader::Read in svmfuzzer.cxx

Use the new read functionality in vcl/workben/svmfuzzer.cxx

Change-Id: Id8cc57bda70109f2ddbf81354f8d37d187f0f8d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120106
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/vcl/workben/svmfuzzer.cxx b/vcl/workben/svmfuzzer.cxx
index 5ef7366c1889..890946eecd41 100644
--- a/vcl/workben/svmfuzzer.cxx
+++ b/vcl/workben/svmfuzzer.cxx
@@ -9,6 +9,7 @@
 
 #include 
 #include 
+#include 
 #include "commonfuzzer.hxx"
 
 #include 
@@ -49,7 +50,8 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, 
size_t size)
 {
 SvMemoryStream aStream(const_cast(data), size, StreamMode::READ);
 GDIMetaFile aGDIMetaFile;
-ReadGDIMetaFile(aStream, aGDIMetaFile);
+SvmReader aReader(aStream);
+aReader.Read(aGDIMetaFile);
 return 0;
 }
 


[Libreoffice-bugs] [Bug 143754] No Help page for Tools>Options…>Language settings>English Sentence Checking in 7.2.0.2.

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143754

Olivier Hallot  changed:

   What|Removed |Added

 Blocks||80430


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=80430
[Bug 80430] [META] Documentation gap for new features
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 80430] [META] Documentation gap for new features

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=80430

Olivier Hallot  changed:

   What|Removed |Added

 Depends on||143754


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=143754
[Bug 143754] No Help page for Tools>Options…>Language settings>English Sentence
Checking in 7.2.0.2.
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: i18nlangtag/qa i18nlangtag/source include/i18nlangtag svtools/inc

2021-08-06 Thread Eike Rathke (via logerrit)
 i18nlangtag/qa/cppunit/test_languagetag.cxx|   10 ++--
 i18nlangtag/source/isolang/isolang.cxx |   54 +
 i18nlangtag/source/isolang/mslangid.cxx|4 +
 i18nlangtag/source/languagetag/languagetag.cxx |2 
 include/i18nlangtag/lang.h |   22 +-
 svtools/inc/langtab.hrc|2 
 6 files changed, 52 insertions(+), 42 deletions(-)

New commits:
commit 46131c5f8238bc3dca9a8d4eb097ad07f2d46fe0
Author: Eike Rathke 
AuthorDate: Fri Aug 6 21:29:48 2021 +0200
Commit: Eike Rathke 
CommitDate: Fri Aug 6 23:44:49 2021 +0200

Adapt LCIDs and language tags to [MS-LCID] rev.15

See

https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-lcid/70feba9f-294e-491e-b6eb-56532684c37f

https://winprotocoldoc.blob.core.windows.net/productionwindowsarchives/MS-LCID/%5bMS-LCID%5d-210625.pdf

and

commit 402dab839b2e451dec81bfb83dadbe0d5a231db2
CommitDate: Wed Aug 4 21:21:51 2021 +0200

update list of [MS-LCID] from 6/25/2021 15.0 rev.

Change-Id: I44db2bfaf894ead119c7014e3770fc44be537148
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120128
Reviewed-by: Eike Rathke 
Tested-by: Jenkins

diff --git a/i18nlangtag/qa/cppunit/test_languagetag.cxx 
b/i18nlangtag/qa/cppunit/test_languagetag.cxx
index 4fcc05785f2e..c3dfb151e14e 100644
--- a/i18nlangtag/qa/cppunit/test_languagetag.cxx
+++ b/i18nlangtag/qa/cppunit/test_languagetag.cxx
@@ -683,7 +683,8 @@ void TestLanguageTag::testAllTags()
 
 bool checkMapping( std::u16string_view rStr1, std::u16string_view rStr2 )
 {
-if (rStr1 == u"la-Latn" ) return rStr2 == u"la";
+if (rStr1 == u"la"  ) return rStr2 == u"la-VA";
+if (rStr1 == u"la-Latn" ) return rStr2 == u"la-VA";
 if (rStr1 == u"tzm-Latn-DZ" ) return rStr2 == u"kab-DZ";
 if (rStr1 == u"bs-Latn-BA"  ) return rStr2 == u"bs-BA";
 if (rStr1 == u"bs-Latn" ) return rStr2 == u"bs";
@@ -705,7 +706,8 @@ bool checkMapping( std::u16string_view rStr1, 
std::u16string_view rStr2 )
 if (rStr1 == u"ven-ZA"  ) return rStr2 == u"ve-ZA";
 if (rStr1 == u"qu-EC"   ) return rStr2 == u"quz-EC";
 if (rStr1 == u"qu-PE"   ) return rStr2 == u"quz-PE";
-if (rStr1 == u"ff-NG"   ) return rStr2 == u"fuv-NG";
+if (rStr1 == u"ff-Latn-NG"  ) return rStr2 == u"ff-NG";
+if (rStr1 == u"fuv-NG"  ) return rStr2 == u"ff-NG";
 if (rStr1 == u"ji-IL"   ) return rStr2 == u"yi-IL";
 if (rStr1 == u"iu-CA"   ) return rStr2 == u"iu-Latn-CA";
 if (rStr1 == u"iu"  ) return rStr2 == u"iu-Latn";
@@ -716,6 +718,7 @@ bool checkMapping( std::u16string_view rStr1, 
std::u16string_view rStr2 )
 if (rStr1 == u"mg-MG"   ) return rStr2 == u"plt-MG";
 if (rStr1 == u"pli" ) return rStr2 == u"pi-Latn";
 if (rStr1 == u"ks"  ) return rStr2 == u"ks-Arab";
+if (rStr1 == u"ks-IN"   ) return rStr2 == u"ks-Deva-IN";
 if (rStr1 == u"chr-US"  ) return rStr2 == u"chr-Cher-US";
 if (rStr1 == u"sd-PK"   ) return rStr2 == u"sd-Arab-PK";
 if (rStr1 == u"sr-Cyrl-RS"  ) return rStr2 == u"sr-RS";
@@ -760,8 +763,7 @@ void TestLanguageTag::testAllIsoLangEntries()
 LanguageTag aTagID( elem.mnLang);
 if (!checkMapping( elem.maBcp47, aTagString.getBcp47()))
 {
-OString aMessage( OUStringToOString( elem.maBcp47, 
RTL_TEXTENCODING_ASCII_US) + " -> " + OUStringToOString( aTagString.getBcp47(), 
RTL_TEXTENCODING_ASCII_US) );
-CPPUNIT_ASSERT_EQUAL_MESSAGE( aMessage.getStr(), 
aTagString.getBcp47(), elem.maBcp47 );
+CPPUNIT_ASSERT_EQUAL_MESSAGE( "defined elem to tag", elem.maBcp47, 
aTagString.getBcp47() );
 }
 if (elem.maBcp47 != aTagID.getBcp47())
 {
diff --git a/i18nlangtag/source/isolang/isolang.cxx 
b/i18nlangtag/source/isolang/isolang.cxx
index 941a73b25766..cb1d5956d6ea 100644
--- a/i18nlangtag/source/isolang/isolang.cxx
+++ b/i18nlangtag/source/isolang/isolang.cxx
@@ -251,7 +251,7 @@ IsoLanguageCountryEntry const aImplIsoLangEntries[] =
 { LANGUAGE_ENGLISH_BELIZE,  "en", "BZ", k0},
 { LANGUAGE_ENGLISH_TRINIDAD,"en", "TT", k0},
 { LANGUAGE_ENGLISH_ZIMBABWE,"en", "ZW", k0},
-{ LANGUAGE_ENGLISH_INDONESIA,   "en", "ID", k0},
+{ LANGUAGE_ENGLISH_INDONESIA,   "en", "ID", k0},// MS 
reserved
 { LANGUAGE_ESTONIAN,"et", "EE", k0},
 { LANGUAGE_FAEROESE,"fo", "FO", k0},
 { LANGUAGE_FARSI,   "fa", "IR", k0},
@@ -344,10 +344,10 @@ IsoLanguageCountryEntry const aImplIsoLangEntries[] =
 { LANGUAGE_GUJARATI,"gu", "IN", k0},
 { LANGUAGE_KANNADA, "kn", "IN", k0},
 { LANGUAGE_ASSAMESE,"as", "IN", k0},
-{ 

[Libreoffice-bugs] [Bug 143694] Icons are not rendered as expected (depending on screen resolution ?)

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143694

--- Comment #9 from EL1962  ---
(In reply to V Stuart Foote from comment #8)
> The LibreOffice UI does respond to UI Scaling on Windows. However, the icon
> sets are provided in small 16px and large 24px and extra large 32px
> sizes--clearly too small for use with a 4K HiDPI laptop.
> 
> Instead, use the Tools -> Options -> View and select the 'Colibre (SVG)'
> icon style (or one of the other SVG icon themes).  The SVG based icons will
> be scaled to a size more appropriate for the UI scale in use and written out
> to PNG images held in LO user cache.
> 
> Eventually for bug 115439 we'll be defaulting to SVG icon themes, possibly
> no longer rasterizing them to bitmap.
> 
> Also, Windows UI scaling with the default Display Settings -> Scale and
> Layout listbox seems more troublesome than Windows 'Advanced scaling
> settings' and setting a 'Custom scaling' value between 100% - 500%, set
> something about 225% and logout/login of Windows--then relaunch LibreOffice
> with 'Colibre (SVG)' icon theme in use.
> 
> Should get better icon rendering from resampled SVG for use on Toolbars,
> Menus, Sidebar and Notebook Bar or in the displayed icon customize dialog.

I've tried switching to one of SVG theme, but this doesn't change anything :
both in the dialog panel and the toolbar it self my selected icon is not
correctly rendered. I don't understand why icons already assigned to actions in
toolbars are displayed with a right size, and why toolbars customized icons are
not.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143485] Slide image export: master slide image objects display inconsistent across export file formats

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143485

--- Comment #3 from R. Bingham  ---
(In reply to Екатерина from comment #2)
> Hello. It is not clear what the error is. And it is not clear in steps how
> to get this error

Version: 7.1.5.2 (x64) / LibreOffice Community
Build ID: 85f04e9f809797b8199d13c421bd8a2b025d52b5
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

Steps to reproduce in more detail:

1) In LO, select File->New->Presentation. A new document with name "Untitled 1"
or such should be created.

2) Cancel "Select a Template" if that pop-up appears.

3) Select View->Slide Pane then View->Master Slide.  Likely only a single
master slide format will show consisting of a "Click to edit" top-of-slide
Title Area and a "Click to edit" body area containing a bullet outline
heirarchy.

4) Select Slide->New Master.  A second slide master template should appear in
the Slides side pane.  It should have name of "Default 1".

5) With the new master selected, Insert->Image then enter (using as readily
accessible PNG image)
https://ask.libreoffice.org/uploads/asklibo/original/1X/1eec1ce28d4605f25e751aea59dbef2bc0782151.png
in the file navigator widget image pathname area then Open. If the image file
download is successful than that PNG image should show in the center of the
"Default 1" master slide.

6) View->Normal then Slide->New Slide. Slide #2 should appear in the Slide Pane
and main edit window. Select the cursor in the slide title are an insert some
identifying title such as "Slide 2 title text" to demo its appearance in
exported slide.

7) Slide->Change Slide Master. In the "Select a Slide Design" popup, select the
master with the LO logo graphic showing then OK. The LO logo graphic should
show but be non-selectable as it is a master layer object, not a layer of an
individual slide.

8) File->Export then select in the File format droplist any of EMF, EPS, GIF,
PNG, SVG or WMF, then select a destination directory and File name of your
choice then select Export...

9) A popup may appear with options for the particular export file format
selected in (8). Take the defaults then OK.

10)
For export formats EMF, EPS, GIF, SVG or WMF view the export with your favorite
image file apps.  The result is an image file containing a slide with the
expected title text but no master slide background image. The master slide
background image silently disappears.

For export format PNG the result is Warning popup "Image filter not found."
then 
 Error popup "Error saving the document Untitled 1: General Error. General
input/output error.".

11) PNG PARTIAL WORKAROUND: The master slide image chosen here (
https://ask.libreoffice.org/uploads/asklibo/original/1X/1eec1ce28d4605f25e751aea59dbef2bc0782151.png
) contains transparency.  The bug list concerning LO dealing with transparency
in general is long and I'm not going to list it here. If during the export of a
slide containing a PNG image with transparency, the PNG option for Drawing
Object->Save transparency is UNCHECKED, then the export not only succeeds but
results in the expected exported slide image containing the LO logo master
slide image.

Regards.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143659] FORMATTING: Cells formatted as shrink to Cell Size won't show the whole content.

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143659

raal  changed:

   What|Removed |Added

 CC||l.lu...@collabora.com,
   ||r...@post.cz
   Keywords|bibisectRequest |bibisected, bisected

--- Comment #2 from raal  ---
The text is missing in gtk3. This seems to have begun at the below commit.
Adding Cc: to Luboš Luňák ; Could you possibly take a look at this one?
Thanks
linux-64-7.2$ 
856217b04de9b5dc5b0b6758f6eb0f4dd728c941 is the first bad commit
commit 856217b04de9b5dc5b0b6758f6eb0f4dd728c941
Author: Jenkins Build User 
Date:   Thu Jan 21 18:23:08 2021 +0100

source sha:d62ad3efe3c8778cfda00799f1cd7bb3349e0b75

https://git.libreoffice.org/core/+/d62ad3efe3c8778cfda00799f1cd7bb3349e0b75
  cache SalLayoutGlyphs in ScOutputData::LayoutStrings()

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143764] New: bump scroll too fast

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143764

Bug ID: 143764
   Summary: bump scroll too fast
   Product: LibreOffice
   Version: 7.1.5.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: j...@jmbaai.com

Description:
Using latest windows and LibreOffice (7.1.5.2). Click on doc and drag to select
a large section past the bottom. The doc bump/auto scrolls way too fast.

Steps to Reproduce:
1.Described above.
2.
3.

Actual Results:
Scrolls way too fast

Expected Results:
Scrolls at a reasonable and useful speed, slow at first and progressively
faster as the drag increases in distance.


Reproducible: Always


User Profile Reset: No



Additional Info:
[Information automatically included from LibreOffice]
Locale: en-US
Module: TextDocument
[Information guessed from browser]
OS: Windows (All)
OS is 64bit: no

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: basic/source

2021-08-06 Thread Mike Kaganski (via logerrit)
 basic/source/classes/image.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 56be83fbb9ac5bb1407f763588a04a6239e0bcd4
Author: Mike Kaganski 
AuthorDate: Fri Aug 6 21:54:25 2021 +0200
Commit: Mike Kaganski 
CommitDate: Fri Aug 6 23:04:14 2021 +0200

Move variable definition to usage site

Change-Id: I3d95551cb72b867e19a1a2bf75c73d1c3422a984
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120132
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/basic/source/classes/image.cxx b/basic/source/classes/image.cxx
index 52aee6636c79..69e30bb11954 100644
--- a/basic/source/classes/image.cxx
+++ b/basic/source/classes/image.cxx
@@ -108,7 +108,7 @@ bool SbiImage::Load( SvStream& r, sal_uInt32& nVersion )
 {
 
 sal_uInt16 nSign, nCount;
-sal_uInt32 nLen, nOff;
+sal_uInt32 nLen;
 
 Clear();
 // Read Master-Record
@@ -219,6 +219,7 @@ bool SbiImage::Load( SvStream& r, sal_uInt32& nVersion )
 MakeStrings( nCount );
 for( size_t i = 0; i < mvStringOffsets.size() && SbiGood( r ); 
i++ )
 {
+sal_uInt32 nOff;
 r.ReadUInt32( nOff );
 mvStringOffsets[ i ] = static_cast(nOff);
 }


[Libreoffice-bugs] [Bug 143763] Aragonese (an_ES) spellchecking dictionary has extra unneeded slashes

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143763

Dimitrij Mijoski  changed:

   What|Removed |Added

Summary|Aragonese (an_ES)   |Aragonese (an_ES)
   |spellchecking dictionary|spellchecking dictionary
   |has extra unneeded slashed  |has extra unneeded slashes

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: io/Library_io.mk io/source

2021-08-06 Thread Noel Grandin (via logerrit)
 io/Library_io.mk|1 +
 io/source/stm/opump.cxx |   12 ++--
 2 files changed, 7 insertions(+), 6 deletions(-)

New commits:
commit 6af2e7d21ce050758ad07fbb951a38b2da2b6c4c
Author: Noel Grandin 
AuthorDate: Fri Aug 6 19:50:14 2021 +0200
Commit: Noel Grandin 
CommitDate: Fri Aug 6 22:26:13 2021 +0200

use more comphelper::OInterfaceContainerHelper2

Change-Id: I255133e1823fd63620f27421b69cd23d75ebb6fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120127
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/io/Library_io.mk b/io/Library_io.mk
index b961b437cd46..6512cfac8122 100644
--- a/io/Library_io.mk
+++ b/io/Library_io.mk
@@ -14,6 +14,7 @@ $(eval $(call gb_Library_use_external,io,boost_headers))
 $(eval $(call gb_Library_use_udk_api,io))
 
 $(eval $(call gb_Library_use_libraries,io,\
+comphelper \
 cppu \
 cppuhelper \
 sal \
diff --git a/io/source/stm/opump.cxx b/io/source/stm/opump.cxx
index 7ba8752d8dfb..bef9aa2d3f1c 100644
--- a/io/source/stm/opump.cxx
+++ b/io/source/stm/opump.cxx
@@ -28,7 +28,7 @@
 #include 
 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
@@ -55,7 +55,7 @@ namespace io_stm {
 Reference< XConnectable >   m_xSucc;
 Reference< XInputStream >   m_xInput;
 Reference< XOutputStream >  m_xOutput;
-OInterfaceContainerHelper   m_cnt;
+comphelper::OInterfaceContainerHelper2  m_cnt;
 boolm_closeFired;
 
 void run();
@@ -117,7 +117,7 @@ Pump::~Pump()
 
 void Pump::fireError( const  Any & exception )
 {
-OInterfaceIteratorHelper iter( m_cnt );
+comphelper::OInterfaceIteratorHelper2 iter( m_cnt );
 while( iter.hasMoreElements() )
 {
 try
@@ -146,7 +146,7 @@ void Pump::fireClose()
 if( !bFire )
 return;
 
-OInterfaceIteratorHelper iter( m_cnt );
+comphelper::OInterfaceIteratorHelper2 iter( m_cnt );
 while( iter.hasMoreElements() )
 {
 try
@@ -162,7 +162,7 @@ void Pump::fireClose()
 
 void Pump::fireStarted()
 {
-OInterfaceIteratorHelper iter( m_cnt );
+comphelper::OInterfaceIteratorHelper2 iter( m_cnt );
 while( iter.hasMoreElements() )
 {
 try
@@ -178,7 +178,7 @@ void Pump::fireStarted()
 
 void Pump::fireTerminated()
 {
-OInterfaceIteratorHelper iter( m_cnt );
+comphelper::OInterfaceIteratorHelper2 iter( m_cnt );
 while( iter.hasMoreElements() )
 {
 try


[Libreoffice-bugs] [Bug 128916] FORMATTING: Several issues regarding indents in numbered chapter headings in a Table of Contents (TOC)

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128916

sanyabajaj  changed:

   What|Removed |Added

URL||https://gethugg.com/blog/ka
   ||lmegh/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143763] New: Aragonese (an_ES) spellchecking dictionary has extra unneeded slashed

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143763

Bug ID: 143763
   Summary: Aragonese (an_ES) spellchecking dictionary has extra
unneeded slashed
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Localization
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: dm...@hotmail.com

Description:
Here is the dictionary
https://cgit.freedesktop.org/libreoffice/dictionaries/tree/an_ES/an_ES.dic

If we do run:

grep -P '/\s*$' an_ES.dic

we can find the problematic lines. There are 2315 problematic lines. A short
example:

doi/
voi/
vas/
va/
vamos/
vatz/
van/
iba/
ibas/
ibanos/

Those slashes should be removed. That will reduce the files size and speedup
the loading of the dictionary. The fix can be done with sed to replace the
slashes and then with uniq to remove some adjacent duplicate lines.

This bug should be fixed here as this dictionary has no author's upstream, this
is its best upstream. 

Steps to Reproduce:
1. cd to this directory
https://cgit.freedesktop.org/libreoffice/dictionaries/tree/an_ES
2. run grep -P '/\s*$' an_ES.dic

Actual Results:
Grep returns 2315 lines.

Expected Results:
Grep should return nothing.


Reproducible: Always


User Profile Reset: No



Additional Info:
No other information.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143489] Galician (gl_ES) dictionary has new upstream repository and new version

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143489

Dimitrij Mijoski  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105575

Telesto  changed:

   What|Removed |Added

   Severity|normal  |trivial
   Priority|medium  |lowest

--- Comment #17 from Telesto  ---
(In reply to Jan-Marek Glogowski from comment #16)
> The event loop will always be very system specific. But the LO scheduler and
> the processing of LO internal events (AKA UserEvent) is definitely a good
> idea to further unify (OTOH every time I touched this low level stuff, I
> broke things, so I'm not really eager; nobody else even wants to touch it). 

No surprise, here ;-). It's good enough, is perfectly fine 


> > Not saying that economics theory being the only perspective.. The challenge
> > or fun might maybe a reason for looking into this..
> 
> I failed to parse this. 

Well in economics all is about distributing resources most efficiently. However
LibreOffice is also promoted as 'fun-project for developers'. Defeating market
logic (economics). So someone might jump into it out of curiosity/challenge [in
some utopia ...] and spend weeks on this unpaid.. [sarcasm] 

>This is nothing I will / can do in my free time, if
> that's what "economics" refer to. The city of Munich "sponsored" a lot of
> this, so even if it didn't directly help any particular of their problem, I
> could work on it to tackle some underlying problems instead of somehow
> working around them.

Is Munich still 'sponsoring' development? They are moving back to MSO, right?

> It also didn't help, that the VCL plugins did stuff
> completely or slightly different without any explanation... "Why?" is the
> most common thought when reading LO code (next to wtf, obviously), not what;
> at least for me.

Code is to me a kind of abracadabra (and coding a black art). Assessing code
quality is kind out of scope for me. Aware of lots of bug tracker references
pointing to nowhere these days.. 

Anyhow, I was more or less surprised by the analysis at comment 13 (interesting
to read though).

---
Changing priority ..

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: chart2/CppunitTest_chart2_dump.mk chart2/CppunitTest_chart2_geometry.mk chart2/CppunitTest_chart2_pivot_chart_test.mk chart2/CppunitTest_chart2_trendcalculators.mk char

2021-08-06 Thread Caolán McNamara (via logerrit)
 chart2/CppunitTest_chart2_dump.mk |3 ++-
 chart2/CppunitTest_chart2_geometry.mk |3 ++-
 chart2/CppunitTest_chart2_pivot_chart_test.mk |3 ++-
 chart2/CppunitTest_chart2_trendcalculators.mk |3 ++-
 chart2/CppunitTest_chart2_xshape.mk   |3 ++-
 chart2/export_setup.mk|3 ++-
 chart2/import_setup.mk|3 ++-
 sc/CppunitTest_sc_anchor_test.mk  |3 ++-
 sc/CppunitTest_sc_bugfix_test.mk  |3 ++-
 sc/CppunitTest_sc_cache_test.mk   |3 ++-
 sc/CppunitTest_sc_chart2dataprovider.mk   |3 ++-
 sc/CppunitTest_sc_chart_regression_test.mk|3 ++-
 sc/CppunitTest_sc_cond_format_merge.mk|3 ++-
 sc/CppunitTest_sc_copypaste.mk|3 ++-
 sc/CppunitTest_sc_datapilotitemobj.mk |3 ++-
 sc/CppunitTest_sc_datapilottablesobj.mk   |3 ++-
 sc/CppunitTest_sc_dataprovider.mk |3 ++-
 sc/CppunitTest_sc_datatransformation.mk   |3 ++-
 sc/CppunitTest_sc_macros_test.mk  |3 ++-
 sc/CppunitTest_sc_mark_test.mk|3 ++-
 sc/CppunitTest_sc_namedrangeobj.mk|3 ++-
 sc/CppunitTest_sc_new_cond_format_api.mk  |3 ++-
 sc/CppunitTest_sc_parallelism.mk  |3 ++-
 sc/CppunitTest_sc_perfobj.mk  |3 ++-
 sc/CppunitTest_sc_range_test.mk   |3 ++-
 sc/CppunitTest_sc_rangelst_test.mk|3 ++-
 sc/CppunitTest_sc_tiledrendering.mk   |3 ++-
 sc/ucalc_setup.mk |3 ++-
 sccomp/CppunitTest_sccomp_swarmsolvertest.mk  |3 ++-
 sw/CppunitTest_sw_apitests.mk |3 ++-
 sw/CppunitTest_sw_macros_test.mk  |3 ++-
 sw/CppunitTest_sw_uwriter.mk  |3 ++-
 sw/Library_vbaswobj.mk|3 ++-
 vcl/commonfuzzer.mk   |   17 +++--
 34 files changed, 77 insertions(+), 39 deletions(-)

New commits:
commit 26cfb57abfc037752bc02dae043f08ac7b2bc711
Author: Caolán McNamara 
AuthorDate: Fri Aug 6 16:59:37 2021 +0100
Commit: Caolán McNamara 
CommitDate: Fri Aug 6 21:16:43 2021 +0200

use Helper_optional SCRIPTING for libs that don't exist if 
--disable-scripting

Change-Id: Iec65d6395b903e13f788fe8322b60aac5b974cd4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120125
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/chart2/CppunitTest_chart2_dump.mk 
b/chart2/CppunitTest_chart2_dump.mk
index 4bf7d692c1c6..90c12ff039a8 100644
--- a/chart2/CppunitTest_chart2_dump.mk
+++ b/chart2/CppunitTest_chart2_dump.mk
@@ -52,7 +52,8 @@ $(eval $(call gb_CppunitTest_use_libraries,chart2_dump, \
 ucbhelper \
 unotest \
 utl \
-vbahelper \
+$(call gb_Helper_optional,SCRIPTING, \
+vbahelper) \
 xo \
 sw \
 ))
diff --git a/chart2/CppunitTest_chart2_geometry.mk 
b/chart2/CppunitTest_chart2_geometry.mk
index 457d7ffd3036..f2467594abc3 100644
--- a/chart2/CppunitTest_chart2_geometry.mk
+++ b/chart2/CppunitTest_chart2_geometry.mk
@@ -52,7 +52,8 @@ $(eval $(call gb_CppunitTest_use_libraries,chart2_geometry, \
 ucbhelper \
 unotest \
 utl \
-vbahelper \
+$(call gb_Helper_optional,SCRIPTING, \
+vbahelper) \
 vcl \
 xo \
 ))
diff --git a/chart2/CppunitTest_chart2_pivot_chart_test.mk 
b/chart2/CppunitTest_chart2_pivot_chart_test.mk
index af49c8a0b02f..4dc7dca420cb 100644
--- a/chart2/CppunitTest_chart2_pivot_chart_test.mk
+++ b/chart2/CppunitTest_chart2_pivot_chart_test.mk
@@ -52,7 +52,8 @@ $(eval $(call 
gb_CppunitTest_use_libraries,chart2_pivot_chart_test, \
 ucbhelper \
 unotest \
 utl \
-vbahelper \
+$(call gb_Helper_optional,SCRIPTING, \
+vbahelper) \
 xo \
 sw \
 ))
diff --git a/chart2/CppunitTest_chart2_trendcalculators.mk 
b/chart2/CppunitTest_chart2_trendcalculators.mk
index f8c14bfba120..2ef23fc9bf90 100644
--- a/chart2/CppunitTest_chart2_trendcalculators.mk
+++ b/chart2/CppunitTest_chart2_trendcalculators.mk
@@ -52,7 +52,8 @@ $(eval $(call 
gb_CppunitTest_use_libraries,chart2_trendcalculators, \
 ucbhelper \
 unotest \
 utl \
-vbahelper \
+$(call gb_Helper_optional,SCRIPTING, \
+vbahelper) \
 xo \
 sw \
 ))
diff --git a/chart2/CppunitTest_chart2_xshape.mk 
b/chart2/CppunitTest_chart2_xshape.mk
index 08d43565d107..7f4c65f415dc 100644
--- a/chart2/CppunitTest_chart2_xshape.mk
+++ b/chart2/CppunitTest_chart2_xshape.mk
@@ -52,7 +52,8 @@ $(eval $(call gb_CppunitTest_use_libraries,chart2_xshape, \
 ucbhelper \
 unotest \
 utl \
-vbahelper \
+$(call gb_Helper_optional,SCRIPTING, \
+vbahelper) \
 xo \
 sw \
 ))
diff --git a/chart2/export_setup.mk b/chart2/export_setup.mk
index 59bd27ef3938..359973634dbd 100644
--- a/chart2/export_setup.mk
+++ b/chart2/export_setup.mk
@@ -55,7 +55,8 @@ $(eval 

[Libreoffice-commits] core.git: distro-configs/LibreOfficeOssFuzz.conf

2021-08-06 Thread Caolán McNamara (via logerrit)
 distro-configs/LibreOfficeOssFuzz.conf |   29 +
 1 file changed, 17 insertions(+), 12 deletions(-)

New commits:
commit 245d73fa13bcb2b453308c304b215b9de4ae2602
Author: Caolán McNamara 
AuthorDate: Fri Aug 6 16:13:20 2021 +0100
Commit: Caolán McNamara 
CommitDate: Fri Aug 6 21:16:22 2021 +0200

disable a few more things when fuzzing

Change-Id: Ia2180b532c6c6cf2d6a735f3a8607c200ca786f0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120124
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/distro-configs/LibreOfficeOssFuzz.conf 
b/distro-configs/LibreOfficeOssFuzz.conf
index 8b7039786584..dac2aa73f7c3 100644
--- a/distro-configs/LibreOfficeOssFuzz.conf
+++ b/distro-configs/LibreOfficeOssFuzz.conf
@@ -3,23 +3,28 @@
 --disable-dynamic-loading
 --disable-runtime-optimizations
 --disable-database-connectivity
---disable-gui
---disable-gtk3
---disable-pdfium
---disable-pdfimport
---disable-skia
---disable-postgresql-sdbc
---disable-firebird-sdbc
+--disable-cairo-canvas
+--disable-cmis
 --disable-coinmp
---disable-lpsolve
---disable-gio
---disable-dconf
---disable-dbus
 --disable-cups
+--disable-curl
+--disable-dbus
+--disable-dconf
+--disable-firebird-sdbc
+--disable-gio
+--disable-gtk3
+--disable-gui
+--disable-librelogo
+--disable-lpsolve
 --disable-odk
+--disable-pdfimport
+--disable-pdfium
+--disable-postgresql-sdbc
 --disable-sdremote
+--disable-skia
 --disable-xmlhelp
 --disable-zxing
+--with-locales=en
 --without-fonts
 --without-java
---with-locales=en
+--without-webdav


[Libreoffice-commits] core.git: avmedia/source

2021-08-06 Thread Caolán McNamara (via logerrit)
 avmedia/source/avmediadummy.cxx |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit bd0c058811538a646196b479a8ce8d94a64763aa
Author: Caolán McNamara 
AuthorDate: Fri Aug 6 14:33:02 2021 +0100
Commit: Caolán McNamara 
CommitDate: Fri Aug 6 21:15:48 2021 +0200

fix --disable-avmedia clang-plugins warnings

abandoned getting this to work because not sure what this should
look like, seems caught between two stools as to what it wants to do

Change-Id: Ica0d1e25f2a19dfee0fe40d3e106d05e1f861c2b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120119
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/avmedia/source/avmediadummy.cxx b/avmedia/source/avmediadummy.cxx
index 6c6ada0163e9..823cc6ec9f80 100644
--- a/avmedia/source/avmediadummy.cxx
+++ b/avmedia/source/avmediadummy.cxx
@@ -61,6 +61,7 @@ bool MediaItem::PutValue( const css::uno::Any&, sal_uInt8 )
 
 AVMediaSetMask MediaItem::getMaskSet() const
 {
+(void) this;// Silence loplugin:staticmethods
 return AVMediaSetMask::NONE;
 }
 
@@ -83,10 +84,10 @@ bool MediaItem::operator==( const SfxPoolItem& rItem ) const
 
 } // namespace avmedia
 
-extern "C" SAL_DLLPUBLIC_EXPORT css::uno::XInterface* SAL_CALL
+extern "C" SAL_DLLPUBLIC_EXPORT css::uno::XInterface*
 
com_sun_star_comp_framework_SoundHandler_get_implementation(css::uno::XComponentContext*,
 
css::uno::Sequence const &)
 {
-return NULL;
+return nullptr;
 }
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */


[Libreoffice-commits] core.git: basic/source sc/source sd/source svx/source unotest/source

2021-08-06 Thread Caolán McNamara (via logerrit)
 basic/source/inc/sbintern.hxx   |5 +++--
 basic/source/runtime/methods.cxx|8 +---
 sc/source/ui/docshell/docsh.cxx |3 ++-
 sc/source/ui/unoobj/servuno.cxx |3 +++
 sd/source/ui/func/fuexecuteinteraction.cxx  |3 +++
 sd/source/ui/slideshow/slideshowimpl.cxx|2 ++
 svx/source/form/fmscriptingenv.cxx  |3 ++-
 unotest/source/cpp/bootstrapfixturebase.cxx |8 +++-
 8 files changed, 27 insertions(+), 8 deletions(-)

New commits:
commit cc21480a25f1a289c7dd1bc536699fcae1457fc8
Author: Caolán McNamara 
AuthorDate: Fri Aug 6 16:04:39 2021 +0100
Commit: Caolán McNamara 
CommitDate: Fri Aug 6 21:15:31 2021 +0200

make --disable-scripting compile

Change-Id: Ie2be232e062389b74408dd9f001b1cf4db7db7d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120123
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/basic/source/inc/sbintern.hxx b/basic/source/inc/sbintern.hxx
index d4bed5bf845e..bf0439724c4f 100644
--- a/basic/source/inc/sbintern.hxx
+++ b/basic/source/inc/sbintern.hxx
@@ -23,6 +23,7 @@
 #include 
 #include 
 #include 
+#include 
 
 namespace utl
 {
@@ -99,8 +100,6 @@ public:
 virtual SbxObjectRef CreateObject( const OUString& ) override;
 };
 
-
-
 struct SbiGlobals
 {
 static SbiGlobals* pGlobals;
@@ -129,7 +128,9 @@ struct SbiGlobals
 OUStringaErrMsg;// buffer for GetErrorText()
 std::unique_ptr<::utl::TransliterationWrapper> pTransliterationWrapper;
// For StrComp
 boolbBlockCompilerError;
+#if HAVE_FEATURE_SCRIPTING
 std::unique_ptr   pAppBasMgr;
+#endif
 StarBASIC*  pMSOMacroRuntimLib; // Lib containing MSO Macro Runtime 
API entry symbols
 
 SbiGlobals();
diff --git a/basic/source/runtime/methods.cxx b/basic/source/runtime/methods.cxx
index 27da5fdac33d..77e1d26e4fe5 100644
--- a/basic/source/runtime/methods.cxx
+++ b/basic/source/runtime/methods.cxx
@@ -4741,11 +4741,13 @@ bool implDateSerial( sal_Int16 nYear, sal_Int16 nMonth, 
sal_Int16 nDay,
 else
 #endif
 {
-if ( 0 <= nYear && nYear < 100 && (bUseTwoDigitYear
+if ( 0 <= nYear && nYear < 100 &&
 #if HAVE_FEATURE_SCRIPTING
-|| SbiRuntime::isVBAEnabled()
+  (bUseTwoDigitYear || 
SbiRuntime::isVBAEnabled())
+#else
+  bUseTwoDigitYear
 #endif
-) )
+   )
 {
 nYear += 1900;
 }
diff --git a/sc/source/ui/docshell/docsh.cxx b/sc/source/ui/docshell/docsh.cxx
index 7a5732e0a154..5801636d3cc2 100644
--- a/sc/source/ui/docshell/docsh.cxx
+++ b/sc/source/ui/docshell/docsh.cxx
@@ -435,7 +435,7 @@ public:
 void hide_ask() const { m_xWarningOnBox->set_visible(false); };
 };
 
-
+#if HAVE_FEATURE_SCRIPTING
 class VBAScriptListener : public ::cppu::WeakImplHelper< 
css::script::vba::XVBAScriptListener >
 {
 private:
@@ -460,6 +460,7 @@ public:
 {
 }
 };
+#endif
 
 }
 
diff --git a/sc/source/ui/unoobj/servuno.cxx b/sc/source/ui/unoobj/servuno.cxx
index ac3e93771cb1..a66050487a34 100644
--- a/sc/source/ui/unoobj/servuno.cxx
+++ b/sc/source/ui/unoobj/servuno.cxx
@@ -83,6 +83,7 @@ static bool isInVBAMode( ScDocShell& rDocSh )
 
 namespace {
 
+#if HAVE_FEATURE_SCRIPTING
 class ScVbaObjectForCodeNameProvider : public ::cppu::WeakImplHelper< 
container::XNameAccess >
 {
 uno::Any maWorkbook;
@@ -242,6 +243,8 @@ public:
 }
 };
 
+#endif
+
 using Type = ScServiceProvider::Type;
 
 struct ProvNamesId_Type
diff --git a/sd/source/ui/func/fuexecuteinteraction.cxx 
b/sd/source/ui/func/fuexecuteinteraction.cxx
index 8b037c41bed5..981fc8bac024 100644
--- a/sd/source/ui/func/fuexecuteinteraction.cxx
+++ b/sd/source/ui/func/fuexecuteinteraction.cxx
@@ -20,6 +20,7 @@
 #include 
 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -195,6 +196,7 @@ void FuExecuteInteraction::DoExecute(SfxRequest&)
 }
 break;
 
+#if HAVE_FEATURE_SCRIPTING
 case presentation::ClickAction_MACRO:
 {
 // Execute macro
@@ -223,6 +225,7 @@ void FuExecuteInteraction::DoExecute(SfxRequest&)
 }
 }
 break;
+#endif
 
 default:
 break;
diff --git a/sd/source/ui/slideshow/slideshowimpl.cxx 
b/sd/source/ui/slideshow/slideshowimpl.cxx
index dc3b3bef239a..6e4e30ad7183 100644
--- a/sd/source/ui/slideshow/slideshowimpl.cxx
+++ b/sd/source/ui/slideshow/slideshowimpl.cxx
@@ -1509,6 +1509,7 @@ void SlideshowImpl::click( const Reference< XShape >& 
xShape )
 }
 break;
 
+#if HAVE_FEATURE_SCRIPTING
 case presentation::ClickAction_MACRO:
 {
 const OUString aMacro( pEvent->maStrBookmark );
@@ -1537,6 +1538,7 @@ void SlideshowImpl::click( const Reference< XShape >& 
xShape )
 }
 }
 break;
+#endif
 
 case ClickAction_VERB:
 {
diff --git a/svx/source/form/fmscriptingenv.cxx 

[Libreoffice-bugs] [Bug 143752] DeckLayouter.cxx:489: OSL_ASSERT: nRemainingHeightToDistribute==0

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143752

--- Comment #2 from Telesto  ---
(In reply to Roman Kuznetsov from comment #1)
> Telesto, where can we see that message about DeckLayouter.cxx:489:
> OSL_ASSERT: nRemainingHeightToDistribute==0 and why it's wrong?

Asserts are mostly not good. Noticed in Debugger. However not sure how a true
debug build handles it.. downloading one right now..

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103238] [META] Customize dialog bugs and enhancements

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103238
Bug 103238 depends on bug 143694, which changed state.

Bug 143694 Summary: Icons are not rendered as expected (depending on screen 
resolution ?)
https://bugs.documentfoundation.org/show_bug.cgi?id=143694

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 90796] [META] HiDPI / Retina bugs

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90796
Bug 90796 depends on bug 143694, which changed state.

Bug 143694 Summary: Icons are not rendered as expected (depending on screen 
resolution ?)
https://bugs.documentfoundation.org/show_bug.cgi?id=143694

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143694] Icons are not rendered as expected (depending on screen resolution ?)

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143694

V Stuart Foote  changed:

   What|Removed |Added

 OS|All |Windows (All)
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG
 CC||vstuart.fo...@utsa.edu

--- Comment #8 from V Stuart Foote  ---
The LibreOffice UI does respond to UI Scaling on Windows. However, the icon
sets are provided in small 16px and large 24px and extra large 32px
sizes--clearly too small for use with a 4K HiDPI laptop.

Instead, use the Tools -> Options -> View and select the 'Colibre (SVG)' icon
style (or one of the other SVG icon themes).  The SVG based icons will be
scaled to a size more appropriate for the UI scale in use and written out to
PNG images held in LO user cache.

Eventually for bug 115439 we'll be defaulting to SVG icon themes, possibly no
longer rasterizing them to bitmap.

Also, Windows UI scaling with the default Display Settings -> Scale and Layout
listbox seems more troublesome than Windows 'Advanced scaling settings' and
setting a 'Custom scaling' value between 100% - 500%, set something about 225%
and logout/login of Windows--then relaunch LibreOffice with 'Colibre (SVG)'
icon theme in use.

Should get better icon rendering from resampled SVG for use on Toolbars, Menus,
Sidebar and Notebook Bar or in the displayed icon customize dialog.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 124098] LibreCalc6.2: Opening a Calc with some formulas: It writes "adapt Row Height" which is taking ages to load!

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124098

--- Comment #36 from Eike Rathke  ---
I didn't wrap my head around, neither any possibly underlying problems nor the
proposed solution, but the procedure described in
https://bugs.documentfoundation.org/show_bug.cgi?id=62268#c12 and mentioned
again in https://bugs.documentfoundation.org/show_bug.cgi?id=62268#c47 sounds
reasonable to me on first sight.

Citing here for completeness:

a) if there is no height attribute and the "use_optimal-row-height" attribute
is set then calculate the row height

b) if there is no height attribute and the "use_optimal-row-height" attribute
is not set then use the default value

c) if there is a height attribute just use it

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143485] Slide image export: master slide image objects display inconsistent across export file formats

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143485

Екатерина  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||katyalukkar...@gmail.com
 Ever confirmed|0   |1

--- Comment #2 from Екатерина  ---
Hello. It is not clear what the error is. And it is not clear in steps how to
get this error

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143694] Icons are not rendered as expected (depending on screen resolution ?)

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143694

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

  Component|Calc|UI

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103238] [META] Customize dialog bugs and enhancements

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103238

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||143694


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=143694
[Bug 143694] Icons are not rendered as expected (depending on screen resolution
?)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 90796] [META] HiDPI / Retina bugs

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90796

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||143694


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=143694
[Bug 143694] Icons are not rendered as expected (depending on screen resolution
?)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143694] Icons are not rendered as expected (depending on screen resolution ?)

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143694

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||90796, 103238


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=90796
[Bug 90796] [META] HiDPI / Retina bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103238
[Bug 103238] [META] Customize dialog bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 81234] [META] RTF filter issues

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=81234

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||143727


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=143727
[Bug 143727] Distorted formatting of .rtf document in LO writer 7.2.0.2
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143727] Distorted formatting of .rtf document in LO writer 7.2.0.2

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143727

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||81234


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=81234
[Bug 81234] [META] RTF filter issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143727] Distorted formatting of .rtf document in LO writer 7.2.0.2

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143727

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru
Version|7.2.0.2 rc  |5.3.7.2 release
 Status|UNCONFIRMED |NEW
   Keywords||filter:rtf
 Ever confirmed|0   |1

--- Comment #3 from Roman Kuznetsov <79045_79...@mail.ru> ---
confirm in

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 4677345e3695bac158bb04048b4d5c608ed764b4
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: default;
VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL

and in

Версия: 5.3.7.2
ID сборки: 6b8ed514a9f8b44d37a1b96673cbbdd077e24059
Потоков ЦП: 4; Версия ОС: Windows 6.1; Отрисовка ИП: GL; Способ разметки:
новый; 
Локаль: ru-RU (ru_RU); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143752] DeckLayouter.cxx:489: OSL_ASSERT: nRemainingHeightToDistribute==0

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143752

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||79045_79...@mail.ru
 Status|UNCONFIRMED |NEEDINFO

--- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> ---
Telesto, where can we see that message about DeckLayouter.cxx:489: OSL_ASSERT:
nRemainingHeightToDistribute==0 and why it's wrong?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143754] No Help page for Tools>Options…>Language settings>English Sentence Checking in 7.2.0.2.

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143754

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

  Component|Writer  |Documentation
 Status|UNCONFIRMED |NEW
 CC||79045_79...@mail.ru,
   ||olivier.hallot@libreoffice.
   ||org
 Ever confirmed|0   |1

--- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> ---
Confirm for current master 7.3

Olivier, is this one for Documentation team?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143762] Enhancement: Ability to set the color of a hatch separately from the hatch pattern in Sidebar

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143762

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

   Keywords||needsUXEval
   Severity|normal  |enhancement
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
Summary|Enhancement: Ability to set |Enhancement: Ability to set
   |the color of a hatch|the color of a hatch
   |separately from the hatch   |separately from the hatch
   |pattern |pattern in Sidebar
 Blocks||107580

--- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> ---
You can select a line color and a background color for any hatching if you use
Area dialog for selected shape from its context menu.

But we can ask a design team about addition Sidebar options for that


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107580
[Bug 107580] [META] Area content panel of the Properties deck/tab of the
sidebar
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107580] [META] Area content panel of the Properties deck/tab of the sidebar

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107580

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||143762


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=143762
[Bug 143762] Enhancement: Ability to set the color of a hatch separately from
the hatch pattern in Sidebar
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 143762] Enhancement: Ability to set the color of a hatch separately from the hatch pattern in Sidebar

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143762

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

   Keywords||needsUXEval
   Severity|normal  |enhancement
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
Summary|Enhancement: Ability to set |Enhancement: Ability to set
   |the color of a hatch|the color of a hatch
   |separately from the hatch   |separately from the hatch
   |pattern |pattern in Sidebar
 Blocks||107580

--- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> ---
You can select a line color and a background color for any hatching if you use
Area dialog for selected shape from its context menu.

But we can ask a design team about addition Sidebar options for that


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107580
[Bug 107580] [META] Area content panel of the Properties deck/tab of the
sidebar
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 143527] Impress slide transition sounds do not loop (64-bit Win only)

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143527

--- Comment #8 from Aron Budea  ---
(In reply to Timur from comment #7)
> As for importance, 2 reasons:
> - this is a general LO feature, which doesn't work for any user (and all are
> on 64-bit now), not a problem with single document, so may be considered
> major, and more important:
> - this is a regression, and all regressions should have one step higher
> importance, i.e. high and not medium.
Thanks for giving a reasoning, I agree with having one step higher priority for
regressions in general, at the same time the importance should probably be
unaffected by this. I'd also think looping the sound is a minor extension of
being able to play sounds, which works (there's probably a reason why the
regression was first reported 5 years after it was introduced). However, if
there's consensus the priority should be higher here, please don't mind me, and
go ahead.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143020] Selection mode status bar indicator does not change

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143020

Buovjaga  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143014] Issue with Icon Sizing

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143014

--- Comment #4 from Tracey  ---
It appears the issue has been corrected in version 7.1.4.2
Thanks, Tracey

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143020] Selection mode status bar indicator does not change

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143020

--- Comment #3 from Tracey  ---
Yes, LibreOfficeDev 7.3 does correct the problem.
Thanks, Tracey

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143019] Issue with the [Text Language] section of the status bar

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143019

--- Comment #6 from Tracey  ---
Created attachment 174118
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174118=edit
French English Mexican Text# 

I can't see which attachments are there (should be 1 thru 3)
Any two will show the difference:

When I select text identifying the language for spell checking purposes, I seem
to get other (unwarranted) languages randomly poping up (see the 3 attached
examples: French English Mexican Text1 Frisian.png, French English Mexican
Text2 Kinyarwanda.png, French English Mexican Text3 Catalan.png).

I only want to see the applicable languages in the document.
The random pop-up is very problematic with working with multi-lingual
documents.

Thanks, Tracey
BTW, FWIW:
I also get English (UK) and English (USA) both appearing: I only need/want the
applicable one at a time.
I also get Spanish (Spain) and Spanish (Mexico) both appearing: I only
need/want the applicable one at a time.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143019] Issue with the [Text Language] section of the status bar

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143019

--- Comment #5 from Tracey  ---
Created attachment 174117
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174117=edit
French English Mexican Text# 

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143019] Issue with the [Text Language] section of the status bar

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143019

--- Comment #4 from Tracey  ---
Created attachment 174116
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174116=edit
French English Mexican Text# 

I am trying to add 3 files, but I think I discovered I can only add one at a
time 8-(

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143019] Issue with the [Text Language] section of the status bar

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143019

--- Comment #3 from Tracey  ---
Comment on attachment 174115
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174115
French English Mexican Text# 

[Libreoffice-bugs] [Bug 143019] Issue with the [Text Language] section of the status bar

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143019

--- Comment #2 from Tracey  ---
Created attachment 174115
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174115=edit
French English Mexican Text# 

[Libreoffice-bugs] [Bug 79332] self-contained pivot table. Implement pivot cache.

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=79332

Buovjaga  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||3186

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143186] pivotcaches - BASIC runtime error 423

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143186

Buovjaga  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=79
   ||332

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143225] EDITING: External references to cells in other files disappear when copying sheet to another workbook, even when directly importing the relevant sheet into the other wo

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143225

Buovjaga  changed:

   What|Removed |Added

Version|7.1.3.2 release |3.5.0 release

--- Comment #7 from Buovjaga  ---
Repro with files also in Linux 6.3 and 43all bibisect repos

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: oox/qa oox/source

2021-08-06 Thread Miklos Vajna (via logerrit)
 oox/qa/unit/data/smartart-groupshape.pptx |binary
 oox/qa/unit/drawingml.cxx |   19 +++
 oox/source/drawingml/shape.cxx|   17 -
 3 files changed, 35 insertions(+), 1 deletion(-)

New commits:
commit 030cdbc7f8782eb196f09661bc2f116d790de9be
Author: Miklos Vajna 
AuthorDate: Fri Aug 6 16:56:30 2021 +0200
Commit: Miklos Vajna 
CommitDate: Fri Aug 6 17:46:43 2021 +0200

tdf#132696 PPTX import: fix missing SmartArt when it's part of a group shape

Regression from commit e9986153e44d7ec6ca9c5f1373971de74dcbacda (PPTX
import: import SmartArt drawing into single GroupShape, 2019-03-14), the
problem was that oox::ppt::PPTShape::addShape() and
oox::drawingml::Shape::addShape() were not in sync.

PPTShape unconditionally maps SmartArt to shapes, while the shared Shape
class defaults to converting it to a non-editable metafile. The above
commit changed the handling of in-groupshape SmartArts to go via
Shape::addShape() instead of PPTShape::addShape(), which exposed the
underlying problem that the convert-to-metafile mechanism is currently
only working in the DOCX case.

Fix the problem by again ignoring the convert-to-metafile flag for the
PPTX import case.

This also exposed a previously hidden problem:

make -C oox -sr CppunitTest_oox_drawingml 
CPPUNIT_TEST_NAME="testGroupShapeSmartArt testTdf131082"

started to make testTdf131082 fail. The tweak in
Shape::createAndInsert() fixes the testcase failure, but likely there is
a deeper problem there, unrelated to the regression.

Change-Id: I4e1e9645eaa266d0d7560767c3c59ba9549ccdb4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120122
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/oox/qa/unit/data/smartart-groupshape.pptx 
b/oox/qa/unit/data/smartart-groupshape.pptx
new file mode 100644
index ..81dcee1e52a3
Binary files /dev/null and b/oox/qa/unit/data/smartart-groupshape.pptx differ
diff --git a/oox/qa/unit/drawingml.cxx b/oox/qa/unit/drawingml.cxx
index 92d08b5f0c8a..c8dc0d9cc1fb 100644
--- a/oox/qa/unit/drawingml.cxx
+++ b/oox/qa/unit/drawingml.cxx
@@ -326,6 +326,25 @@ CPPUNIT_TEST_FIXTURE(OoxDrawingmlTest, testTableShadow)
 verify(getComponent());
 }
 
+CPPUNIT_TEST_FIXTURE(OoxDrawingmlTest, testGroupShapeSmartArt)
+{
+// Given a file with a smartart inside a group shape:
+OUString aURL = m_directories.getURLFromSrc(DATA_DIRECTORY) + 
"smartart-groupshape.pptx";
+
+// When loading that file:
+load(aURL);
+
+// Then make sure that the smartart is not just an empty group shape:
+uno::Reference 
xDrawPagesSupplier(getComponent(), uno::UNO_QUERY);
+uno::Reference 
xDrawPage(xDrawPagesSupplier->getDrawPages()->getByIndex(0),
+ uno::UNO_QUERY);
+uno::Reference xGroup(xDrawPage->getByIndex(0), 
uno::UNO_QUERY);
+uno::Reference xSmartArt(xGroup->getByIndex(0), 
uno::UNO_QUERY);
+// Without the accompanying fix in place, this test would have failed, 
because we lost all
+// children of the group shape representing the smartart.
+CPPUNIT_ASSERT_GREATER(static_cast(0), xSmartArt->getCount());
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/oox/source/drawingml/shape.cxx b/oox/source/drawingml/shape.cxx
index 64878fc772f4..89555c9da637 100644
--- a/oox/source/drawingml/shape.cxx
+++ b/oox/source/drawingml/shape.cxx
@@ -296,7 +296,12 @@ void Shape::addShape(
 if( meFrameType == FRAMETYPE_DIAGRAM )
 {
 keepDiagramCompatibilityInfo();
-if( !SvtFilterOptions::Get().IsSmartArt2Shape() )
+
+// Check if this is the PPTX import, so far converting 
SmartArt to a non-editable
+// metafile is only imlemented for DOCX.
+bool bPowerPoint = 
dynamic_cast() != nullptr;
+
+if (!SvtFilterOptions::Get().IsSmartArt2Shape() && 
!bPowerPoint)
 convertSmartArtToMetafile( rFilterBase );
 }
 
@@ -973,7 +978,17 @@ Reference< XShape > const & Shape::createAndInsert(
 
 Reference< lang::XMultiServiceFactory > xServiceFact( 
rFilterBase.getModel(), UNO_QUERY_THROW );
 if ( !mxShape.is() )
+{
 mxShape.set( xServiceFact->createInstance( aServiceName ), 
UNO_QUERY_THROW );
+if (aServiceName == "com.sun.star.drawing.GroupShape")
+{
+// TODO why is this necessary? A newly created group shape should 
have an empty
+// grab-bag.
+uno::Reference xPropertySet(mxShape, 
uno::UNO_QUERY);
+beans::PropertyValues aVals;
+xPropertySet->setPropertyValue("InteropGrabBag", 
uno::makeAny(aVals));
+}
+}
 
 Reference< XPropertySet > xSet( mxShape, UNO_QUERY );
 if (xSet.is())


[Libreoffice-bugs] [Bug 143673] LibreOffice logo / banner bad display in Start Center in GNOME dark mode

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143673

--- Comment #5 from Buovjaga  ---
Weird: now the 7.3 repo was updated, but I still don't see the issue!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105575

--- Comment #16 from Jan-Marek Glogowski  ---
(In reply to Telesto from comment #15)
> (In reply to Jan-Marek Glogowski from comment #13)
> > So this should have been just a quick look and turned into some hours
> > analysis with multiple problems unveiled...
> 
> Thanks for the 'quick' look (and insights). Me wondering how often logo
> being truly c.q. how much engineering time should be spent on this. It's
> kind of a trivial feature to me (personal opinion).
> 
> Or is there some overall benefit, bigger compared to logo (like harmonizing
> system loops cross platform)

There is no real problem with LibreLogo AFAIK, except that it's kind of a
non-feature which even caused security problems due its Python implementation
(I have no idea how someone thought this might be a sensible feature for
LO...). But this is a good and easy test, which is hard to find for the whole
system event loop integration, let alone unit tests.

The event loop will always be very system specific. But the LO scheduler and
the processing of LO internal events (AKA UserEvent) is definitely a good idea
to further unify (OTOH every time I touched this low level stuff, I broke
things, so I'm not really eager; nobody else even wants to touch it). 

> Not saying that economics theory being the only perspective.. The challenge
> or fun might maybe a reason for looking into this..

I failed to parse this. This is nothing I will / can do in my free time, if
that's what "economics" refer to. The city of Munich "sponsored" a lot of this,
so even if it didn't directly help any particular of their problem, I could
work on it to tackle some underlying problems instead of somehow working around
them. It also didn't help, that the VCL plugins did stuff completely or
slightly different without any explanation... "Why?" is the most common thought
when reading LO code (next to wtf, obviously), not what; at least for me.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143759] Inaccurate results when searching for empty cells with regex ^$

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143759

Eike Rathke  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #3 from Eike Rathke  ---
Only the marked range from D6 down is an error.
Empty cells outside of the actual rectangular data area (i.e. no occupied cell
at all in an empty column) are *never* searched (because you certainly don't
want to search a billion empty cells for an unnecessarily large selection). In
the sample file the actual data area is B2:E5. You can observe the intended
behaviour when hitting Find Next repeatedly.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143691] UI: Changing draw scale on a specific file completely locks up LibreOffice Draw

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143691

mwtjunkm...@gmail.com changed:

   What|Removed |Added

 CC||mwtjunkm...@gmail.com

--- Comment #3 from mwtjunkm...@gmail.com ---
no repro in

Version: 7.1.5.2 (x64) / LibreOffice Community
Build ID: 85f04e9f809797b8199d13c421bd8a2b025d52b5
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143762] Enhancement: Ability to set the color of a hatch separately from the hatch pattern

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143762

mwtjunkm...@gmail.com changed:

   What|Removed |Added

 CC||mwtjunkm...@gmail.com

--- Comment #1 from mwtjunkm...@gmail.com ---
Created attachment 174114
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174114=edit
screenshot

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143762] New: Enhancement: Ability to set the color of a hatch separately from the hatch pattern

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143762

Bug ID: 143762
   Summary: Enhancement: Ability to set the color of a hatch
separately from the hatch pattern
   Product: LibreOffice
   Version: 7.3.0.0 alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mwtjunkm...@gmail.com

Description:
Why can't I create a purple hatch? Or an orange one? Not only I'm I stuck with
an index of colors per hatch pattern, the colors per hatch pattern don't match
(see attachment).  Can't create the same hatch pattern across the supplied
colors. 

Separate the color from the hatch so we can choose the color for ourselves.

Steps to Reproduce:
1. Launch Windows LO draw
2. Draw a basic shape
3. Select Hatching for the fill type
4. Try to select a purple hatch

Actual Results:
Locked into a pre-programmed index of color+hatch

Expected Results:
I should be able to select any color I want for any given hatch.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: e642179f466c899365fc9539a8aca66b39fea39a
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sfx2/uiconfig

2021-08-06 Thread Caolán McNamara (via logerrit)
 sfx2/uiconfig/ui/templatedlg.ui |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 0ec10cff008eb2d8b2c4f5b5fa35b25162081e9e
Author: Caolán McNamara 
AuthorDate: Fri Aug 6 14:20:55 2021 +0100
Commit: Caolán McNamara 
CommitDate: Fri Aug 6 16:31:45 2021 +0200

template dialog starts in thumbnail view without thumbnail shown toggled

and only toggled thumbnail toggle to on if it wasn't already in that
mode, so default it toggled on in the .ui so it matches the initial
setting

Change-Id: I8c64014880d6f7ca4d6043bfef32b90040745dbb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120117
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sfx2/uiconfig/ui/templatedlg.ui b/sfx2/uiconfig/ui/templatedlg.ui
index 51846213a9eb..45ab9791bfb3 100644
--- a/sfx2/uiconfig/ui/templatedlg.ui
+++ b/sfx2/uiconfig/ui/templatedlg.ui
@@ -467,6 +467,7 @@
 image8
 none
 True
+True
   
   
 False


[Libreoffice-bugs] [Bug 143761] Enhancement: PLEASE revert location of RGB controls in Draw

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143761

mwtjunkm...@gmail.com changed:

   What|Removed |Added

 CC||mwtjunkm...@gmail.com

--- Comment #1 from mwtjunkm...@gmail.com ---
Created attachment 174113
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174113=edit
screenshot

Screenshot showing the gymnastics to find the RGB controls.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143761] New: Enhancement: PLEASE revert location of RGB controls in Draw

2021-08-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143761

Bug ID: 143761
   Summary: Enhancement: PLEASE revert location of RGB controls in
Draw
   Product: LibreOffice
   Version: 7.3.0.0 alpha0+ Master
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mwtjunkm...@gmail.com

Description:
I shouldn't have to spend half a morning looking for the RGB controls for an
image.  FINALLY found them consolidated under a non-descript icon under a
toolbar too big to fit on the main toolbar.

Please return the RGB color values to where they were previously with the rest
of the image properties on the sidebar.

Steps to Reproduce:
1. Open Windows LO Draw
2. Insert any bitmap image
3. Good luck finding the RGB controls

Actual Results:
Had to hunt for the RGB Controls

Expected Results:
Should find the RGB controls easily with everything else with the image sidebar
properties.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: e642179f466c899365fc9539a8aca66b39fea39a
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

  1   2   >