[Libreoffice-commits] core.git: accessibility/source
accessibility/source/standard/accessiblemenuitemcomponent.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit d383a70c46e0dcbe74d6765cd5a394428c198917 Author: Baran Aytas AuthorDate: Wed Sep 1 01:09:17 2021 +0300 Commit: Michael Weghorn CommitDate: Mon Sep 6 07:48:16 2021 +0200 tdf#114441: Convert use of sal_uLong to better integer types Change-Id: I15dac18e25d9a0c49a3c1e7c08407d1d2b23467a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121410 Tested-by: Jenkins Reviewed-by: Michael Weghorn diff --git a/accessibility/source/standard/accessiblemenuitemcomponent.cxx b/accessibility/source/standard/accessiblemenuitemcomponent.cxx index 4b0707291eff..e61c7452e9ec 100644 --- a/accessibility/source/standard/accessiblemenuitemcomponent.cxx +++ b/accessibility/source/standard/accessiblemenuitemcomponent.cxx @@ -131,7 +131,7 @@ void OAccessibleMenuItemComponent::Click() // that the popup menus are executed synchronously. AllSettings aSettings = pWindow->GetSettings(); MouseSettings aMouseSettings = aSettings.GetMouseSettings(); -sal_uLong nDelay = aMouseSettings.GetMenuDelay(); +sal_Int32 nDelay = aMouseSettings.GetMenuDelay(); aMouseSettings.SetMenuDelay( 0 ); aSettings.SetMouseSettings( aMouseSettings ); pWindow->SetSettings( aSettings );
[Libreoffice-bugs] [Bug 114441] Convert use of sal_uLong to better integer types
https://bugs.documentfoundation.org/show_bug.cgi?id=114441 --- Comment #42 from Commit Notification --- Baran Aytas committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d383a70c46e0dcbe74d6765cd5a394428c198917 tdf#114441: Convert use of sal_uLong to better integer types It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143920] make an icon for the logo toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=143920 Adolfo Jayme changed: What|Removed |Added Blocks||122247 CC||fit...@ubuntu.com Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=122247 [Bug 122247] [META] Icon requests -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 122247] [META] Icon requests
https://bugs.documentfoundation.org/show_bug.cgi?id=122247 Adolfo Jayme changed: What|Removed |Added Depends on||143920 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143920 [Bug 143920] make an icon for the logo toolbar -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144289] OpenGL transitions not working with GTK3 VCL plugin
https://bugs.documentfoundation.org/show_bug.cgi?id=144289 --- Comment #3 from Commit Notification --- Jan-Marek Glogowski committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/824433168363b7e969c9adca6b636e016a66edb2 tdf#144289 invert / disable default OpenGL support It will be available in 7.2.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144289] OpenGL transitions not working with GTK3 VCL plugin
https://bugs.documentfoundation.org/show_bug.cgi?id=144289 Commit Notification changed: What|Removed |Added Whiteboard|target:7.3.0|target:7.3.0 target:7.2.2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - vcl/headless vcl/inc vcl/osx vcl/qt5 vcl/unx vcl/win
vcl/headless/svpinst.cxx|2 --
vcl/inc/salinst.hxx |3 ++-
vcl/osx/salinst.cxx |1 +
vcl/qt5/Qt5Instance.cxx |4 ++--
vcl/unx/generic/app/salinst.cxx |1 +
vcl/unx/gtk3/gtkinst.cxx|1 +
vcl/win/app/salinst.cxx |1 +
7 files changed, 8 insertions(+), 5 deletions(-)
New commits:
commit 824433168363b7e969c9adca6b636e016a66edb2
Author: Jan-Marek Glogowski
AuthorDate: Sat Sep 4 12:25:09 2021 +0200
Commit: Michael Weghorn
CommitDate: Mon Sep 6 07:33:06 2021 +0200
tdf#144289 invert / disable default OpenGL support
... and as a result drop setting a default in SalSvpInstance.
This is also more consistent: now you must explicitly implement
CreateOpenGLContext() and set "m_bSupportsOpenGL = true".
Change-Id: I591580bf134907213b8308e0843c278d2f470ed3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121632
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
(cherry picked from commit 50238bddf0e95169007cb90479cca86849a19007)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121635
Reviewed-by: Michael Weghorn
diff --git a/vcl/headless/svpinst.cxx b/vcl/headless/svpinst.cxx
index 71efed967af3..b9e93d6782c7 100644
--- a/vcl/headless/svpinst.cxx
+++ b/vcl/headless/svpinst.cxx
@@ -86,8 +86,6 @@ SvpSalInstance::SvpSalInstance(
std::unique_ptr pMutex )
#if !defined(ANDROID) && !defined(IOS)
pthread_atfork(nullptr, nullptr, atfork_child);
#endif
-
-m_bSupportsOpenGL = false;
}
SvpSalInstance::~SvpSalInstance()
diff --git a/vcl/inc/salinst.hxx b/vcl/inc/salinst.hxx
index 1c61dc029cc6..9694d30f4939 100644
--- a/vcl/inc/salinst.hxx
+++ b/vcl/inc/salinst.hxx
@@ -80,7 +80,7 @@ private:
protected:
bool m_bSupportsBitmap32 = false;
-bool m_bSupportsOpenGL = true;
+bool m_bSupportsOpenGL = false;
public:
SalInstance(std::unique_ptr pMutex);
@@ -158,6 +158,7 @@ public:
// may return NULL to disable session management, only used by X11 backend
virtual std::unique_ptr CreateSalSession();
+// also needs to set m_bSupportsOpenGL = true in your SalInstance
implementation!
virtual OpenGLContext* CreateOpenGLContext();
virtual weld::Builder* CreateBuilder(weld::Widget* pParent, const
OUString& rUIRoot, const OUString& rUIFile);
diff --git a/vcl/osx/salinst.cxx b/vcl/osx/salinst.cxx
index 75aea4d5415a..10306ac4c6c3 100644
--- a/vcl/osx/salinst.cxx
+++ b/vcl/osx/salinst.cxx
@@ -350,6 +350,7 @@ AquaSalInstance::AquaSalInstance()
ImplSVData* pSVData = ImplGetSVData();
pSVData->maAppData.mxToolkitName = OUString("osx");
+m_bSupportsOpenGL = true;
}
AquaSalInstance::~AquaSalInstance()
diff --git a/vcl/qt5/Qt5Instance.cxx b/vcl/qt5/Qt5Instance.cxx
index f1e34d2761b1..c1e82aa6a0d9 100644
--- a/vcl/qt5/Qt5Instance.cxx
+++ b/vcl/qt5/Qt5Instance.cxx
@@ -246,8 +246,8 @@ Qt5Instance::Qt5Instance(std::unique_ptr&
pQApp, bool bUseCairo)
connect(QGuiApplication::inputMethod(), ::localeChanged, this,
::localeChanged);
-#ifdef EMSCRIPTEN
-m_bSupportsOpenGL = false;
+#ifndef EMSCRIPTEN
+m_bSupportsOpenGL = true;
#endif
}
diff --git a/vcl/unx/generic/app/salinst.cxx b/vcl/unx/generic/app/salinst.cxx
index ad81916a5894..0df3b9b5c0e5 100644
--- a/vcl/unx/generic/app/salinst.cxx
+++ b/vcl/unx/generic/app/salinst.cxx
@@ -72,6 +72,7 @@ X11SalInstance::X11SalInstance(std::unique_ptr
pMutex)
{
ImplSVData* pSVData = ImplGetSVData();
pSVData->maAppData.mxToolkitName = OUString("x11");
+m_bSupportsOpenGL = true;
#if HAVE_FEATURE_SKIA
X11SkiaSalGraphicsImpl::prepareSkia();
#if SKIA_USE_BITMAP32
diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index c4a516ca5d41..9fccb99779b6 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -211,6 +211,7 @@ GtkInstance::GtkInstance( std::unique_ptr
pMutex )
, bNeedsInit(true)
, m_pLastCairoFontOptions(nullptr)
{
+m_bSupportsOpenGL = true;
}
//We want to defer initializing gtk until we are after uno has been
diff --git a/vcl/win/app/salinst.cxx b/vcl/win/app/salinst.cxx
index f2981bbd9d1c..dd35317040d4 100644
--- a/vcl/win/app/salinst.cxx
+++ b/vcl/win/app/salinst.cxx
@@ -384,6 +384,7 @@ WinSalInstance::WinSalInstance()
{
ImplSVData* pSVData = ImplGetSVData();
pSVData->maAppData.mxToolkitName = OUString("win");
+m_bSupportsOpenGL = true;
#if HAVE_FEATURE_SKIA
WinSkiaSalGraphicsImpl::prepareSkia();
#if SKIA_USE_BITMAP32
[Libreoffice-bugs] [Bug 144016] Using redo that deletes textbox while textbox is active crashes Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=144016 Aron Budea changed: What|Removed |Added CC||ba...@caesar.elte.hu Keywords||bibisected, bisected, ||regression Version|5.2 all versions|4.2.0.4 release --- Comment #5 from Aron Budea --- This regressed from the same commit Caolán identified in bug 131634 comment 7. https://cgit.freedesktop.org/libreoffice/core/commit/?id=12a4200e8ff7f045efcc7e9d15a24b15b248c437 author Armin Le Grand 2012-08-09 08:42:27 + committer Caolán McNamara 2013-05-28 15:55:23 +0100 Related: #i120498# Enhanced Undo/Redo and user experience... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137457] When opening a csv file with Calc, the decimal point is removed, changing the value of the cell
https://bugs.documentfoundation.org/show_bug.cgi?id=137457 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137457] When opening a csv file with Calc, the decimal point is removed, changing the value of the cell
https://bugs.documentfoundation.org/show_bug.cgi?id=137457 --- Comment #5 from QA Administrators --- Dear Carlos Brys, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140563] outline tracking for tables
https://bugs.documentfoundation.org/show_bug.cgi?id=140563 --- Comment #4 from QA Administrators --- Dear Ulrich Windl, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140145] Calc stops responding to keyboard
https://bugs.documentfoundation.org/show_bug.cgi?id=140145 --- Comment #10 from QA Administrators --- Dear clearstar, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 89365] Impress: Change from Bullets to Numbering to Bullets does not set bullet, needs another click
https://bugs.documentfoundation.org/show_bug.cgi?id=89365 --- Comment #5 from QA Administrators --- Dear A (Andy), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 80181] FILEOPEN: bad display of .pptx background theme color from slide master
https://bugs.documentfoundation.org/show_bug.cgi?id=80181 --- Comment #15 from QA Administrators --- Dear Yan Pas, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 55762] CALC: "SCENARIOS" - First and Last Scenario holds the same values
https://bugs.documentfoundation.org/show_bug.cgi?id=55762 --- Comment #13 from QA Administrators --- Dear KSN, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 119455] can't change cellstyles properties (soft format) if a sheet is protected
https://bugs.documentfoundation.org/show_bug.cgi?id=119455 --- Comment #4 from QA Administrators --- Dear Oliver Brinzing, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144319] Cannot load an odt file with LibreOffice 7.2.0
https://bugs.documentfoundation.org/show_bug.cgi?id=144319 anda...@vivaldi.net changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144319] Cannot load an odt file with LibreOffice 7.2.0
https://bugs.documentfoundation.org/show_bug.cgi?id=144319 anda...@vivaldi.net changed: What|Removed |Added Attachment #174800|odf file|odt file description|| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144319] Cannot load an odt file with LibreOffice 7.2.0
https://bugs.documentfoundation.org/show_bug.cgi?id=144319 --- Comment #1 from anda...@vivaldi.net --- Created attachment 174800 --> https://bugs.documentfoundation.org/attachment.cgi?id=174800=edit odf file -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144319] New: Cannot load an odt file with LibreOffice 7.2.0
https://bugs.documentfoundation.org/show_bug.cgi?id=144319 Bug ID: 144319 Summary: Cannot load an odt file with LibreOffice 7.2.0 Product: LibreOffice Version: 7.2.0.4 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: anda...@vivaldi.net Description: With a previous version of LibreOffice, namely 6.x, I could open the attached odt file without any problem, but with the 7.2.0 version I get a picture thing over three equations! Steps to Reproduce: 1. Simply load the attached odt file with the last release of LibreOffice 2. Then you see the picture thing covering the equations Actual Results: I get a picture covering the equations contained in the file. Expected Results: It should show the equations like it did with a previous release, 6.x Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.2.0.4 (x64) / LibreOffice Community Build ID: 9a9c6381e3f7a62afc1329bd359cc48accb6435b CPU threads: 4; OS: Windows 10.0 Build 21390; UI render: Skia/Raster; VCL: win Locale: es-PE (es_PE); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 116718] Autocorrect--Capitalize first letter of every sentence--missing .) or ." as end of sentence
https://bugs.documentfoundation.org/show_bug.cgi?id=116718 --- Comment #10 from V Stuart Foote --- duping bug 49187 ot here as this is getting a hard look... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 96000] [META] Spelling and grammar checking bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=96000 Bug 96000 depends on bug 49187, which changed state. Bug 49187 Summary: Selecting "Sentence case" doesn't correct every sentence in the text (exclamation and question marks work, full stop doesn't) https://bugs.documentfoundation.org/show_bug.cgi?id=49187 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 116718] Autocorrect--Capitalize first letter of every sentence--missing .) or ." as end of sentence
https://bugs.documentfoundation.org/show_bug.cgi?id=116718 V Stuart Foote changed: What|Removed |Added CC||bitig...@me.com --- Comment #9 from V Stuart Foote --- *** Bug 49187 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 49187] Selecting "Sentence case" doesn't correct every sentence in the text (exclamation and question marks work, full stop doesn't)
https://bugs.documentfoundation.org/show_bug.cgi?id=49187 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #11 from V Stuart Foote --- *** This bug has been marked as a duplicate of bug 116718 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144269] Mouse hover border is disabled if an element is focused
https://bugs.documentfoundation.org/show_bug.cgi?id=144269 Ezinne changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Ezinne --- Reproducible in: Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: 1bfcb00aeb23efddf500e6623d36c0f816f4d2e1 CPU threads: 8; OS: Linux 5.11; UI render: default; VCL: x11 Locale: en-US (en_US.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-09-03_20:19:19 Calc: threaded The issue is reproducible with gen, but not with gtk3 VCL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 116718] Autocorrect--Capitalize first letter of every sentence--missing .) or ." as end of sentence
https://bugs.documentfoundation.org/show_bug.cgi?id=116718 --- Comment #8 from Michael Warner --- Looks like what I described in Comment 5 is already filed in Bug 49187, which is technically slightly different from this one as described, but they probably have the same root cause. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 49187] Selecting "Sentence case" doesn't correct every sentence in the text (exclamation and question marks work, full stop doesn't)
https://bugs.documentfoundation.org/show_bug.cgi?id=49187 Michael Warner changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||6718 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 116718] Autocorrect--Capitalize first letter of every sentence--missing .) or ." as end of sentence
https://bugs.documentfoundation.org/show_bug.cgi?id=116718 Michael Warner changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=49 ||187 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 116718] Autocorrect--Capitalize first letter of every sentence--missing .) or ." as end of sentence
https://bugs.documentfoundation.org/show_bug.cgi?id=116718 --- Comment #7 from Michael Warner --- Also, I have noticed that the help page does not describe several of the Format commands for changing the case of text. https://help.libreoffice.org/7.1/en-US/text/swriter/guide/text_capital.html?DbPAR=WRITER -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 116718] Autocorrect--Capitalize first letter of every sentence--missing .) or ." as end of sentence
https://bugs.documentfoundation.org/show_bug.cgi?id=116718 --- Comment #6 from Michael Warner --- Created attachment 174799 --> https://bugs.documentfoundation.org/attachment.cgi?id=174799=edit Sentence case won't capitalize second sentence. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 116718] Autocorrect--Capitalize first letter of every sentence--missing .) or ." as end of sentence
https://bugs.documentfoundation.org/show_bug.cgi?id=116718 --- Comment #5 from Michael Warner --- In my testing, a sentence break is not recognized when the next sentence begins with a lower-case character. For example, in the attached file, if you apply sentence case to the second sentence (whether there is a selection active or not), it won't capitalize the first character. I have traced through the code path into BreakIterator_Unicode::endOfSentence in breakiterator_unicode.cxx, and found that the start position returned by sentence.mpValue->mpBreakIterator->following(nStartPos); is wrong. My supposition is that the true error lies in loadICUBreakIterator, but I haven't been able to follow that logic well enough to find it. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107838] [META] Character-level bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107838 Bug 107838 depends on bug 63889, which changed state. Bug 63889 Summary: FORMATTING: Decapitalize sentence works on all sentence not on selection https://bugs.documentfoundation.org/show_bug.cgi?id=63889 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 63889] FORMATTING: Decapitalize sentence works on all sentence not on selection
https://bugs.documentfoundation.org/show_bug.cgi?id=63889 Michael Warner changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #11 from Michael Warner --- *** This bug has been marked as a duplicate of bug 49033 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - icon-themes/sukapura icon-themes/sukapura_svg
icon-themes/sukapura/cmd/sc_alignbottom.png |binary icon-themes/sukapura/cmd/sc_aligntop.png|binary icon-themes/sukapura/cmd/sc_alignverticalcenter.png |binary icon-themes/sukapura_svg/cmd/sc_alignbottom.svg |2 +- icon-themes/sukapura_svg/cmd/sc_aligntop.svg|2 +- icon-themes/sukapura_svg/cmd/sc_alignverticalcenter.svg |2 +- 6 files changed, 3 insertions(+), 3 deletions(-) New commits: commit 602a6bb1ca2c009f6b504ad29d02c23ce9c79a20 Author: Rizal Muttaqin AuthorDate: Sat Sep 4 13:51:57 2021 +0700 Commit: Adolfo Jayme Barrientos CommitDate: Sun Sep 5 23:43:02 2021 +0200 Sukapura: update cell alignment icons Change-Id: I25a05a2d11e22ac1df1dcce496277ac0c872931a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121625 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin (cherry picked from commit 033b4183b33eb83fc8cd0176e6072e6805c96efc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121566 Reviewed-by: Adolfo Jayme Barrientos diff --git a/icon-themes/sukapura/cmd/sc_alignbottom.png b/icon-themes/sukapura/cmd/sc_alignbottom.png index 62ae80214589..f41aa4253336 100644 Binary files a/icon-themes/sukapura/cmd/sc_alignbottom.png and b/icon-themes/sukapura/cmd/sc_alignbottom.png differ diff --git a/icon-themes/sukapura/cmd/sc_aligntop.png b/icon-themes/sukapura/cmd/sc_aligntop.png index 96b15a31a001..385670bc1987 100644 Binary files a/icon-themes/sukapura/cmd/sc_aligntop.png and b/icon-themes/sukapura/cmd/sc_aligntop.png differ diff --git a/icon-themes/sukapura/cmd/sc_alignverticalcenter.png b/icon-themes/sukapura/cmd/sc_alignverticalcenter.png index 9278834b808b..479452b9e268 100644 Binary files a/icon-themes/sukapura/cmd/sc_alignverticalcenter.png and b/icon-themes/sukapura/cmd/sc_alignverticalcenter.png differ diff --git a/icon-themes/sukapura_svg/cmd/sc_alignbottom.svg b/icon-themes/sukapura_svg/cmd/sc_alignbottom.svg index 9820c808622c..c4417b28e6df 100644 --- a/icon-themes/sukapura_svg/cmd/sc_alignbottom.svg +++ b/icon-themes/sukapura_svg/cmd/sc_alignbottom.svg @@ -1 +1 @@ -http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file +http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file diff --git a/icon-themes/sukapura_svg/cmd/sc_aligntop.svg b/icon-themes/sukapura_svg/cmd/sc_aligntop.svg index 0036f9ce6ca4..d2dddc62be1a 100644 --- a/icon-themes/sukapura_svg/cmd/sc_aligntop.svg +++ b/icon-themes/sukapura_svg/cmd/sc_aligntop.svg @@ -1 +1 @@ -http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file +http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file diff --git a/icon-themes/sukapura_svg/cmd/sc_alignverticalcenter.svg b/icon-themes/sukapura_svg/cmd/sc_alignverticalcenter.svg index 6bd4e0ce0406..09da9a7c908c 100644 --- a/icon-themes/sukapura_svg/cmd/sc_alignverticalcenter.svg +++ b/icon-themes/sukapura_svg/cmd/sc_alignverticalcenter.svg @@ -1 +1 @@ -http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file +http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;>y="9"/>fill="url(#a)" stroke-linecap="round" stroke-linejoin="round" >transform="translate(4)"> fill="url(#c)"/>fill="url(#d)"/> \ No newline at end of file
Firebird driver
Hello. I would like to know more about connecting to firebird databases. Could someone tell me which driver (the firebird one, not the libreoffice one) and where to get information about it? Regards -- *Juan C. Sanz*
[Libreoffice-bugs] [Bug 144318] New: open by remote_files tries login with invalid users I do not specify
https://bugs.documentfoundation.org/show_bug.cgi?id=144318 Bug ID: 144318 Summary: open by remote_files tries login with invalid users I do not specify Product: LibreOffice Version: 6.0.7.3 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: framework Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tzvi.edel...@gmail.com Description: When I open via remote_files using ssh, regardless of the remote user I specify in the "Remote Files" => "File Services" => Type=SSH pop-up, the open attempts to login first as the user I am logged in as on the local host, and then another user name that I tried earlier and then deleted from the remote_files service. Examining the remote /var/log/auth.log shows that the libreoffice client does not get to try the valid user. Steps to Reproduce: Example: - local user: bill_local - valid remote user: bill_good - invalid remote user: bill_bad 1. Setup remote_files ssh service with user bill_bad. Attempt open, which will fail. Delete remote_files ssh service with user bill_bad. 2. Setup remote_files ssh service with user bill_good. Attempt open, which will fail. Actual Results: error popup: Nonexistent file Examine remote:/var/log/auth.log - see invalid login attempts from bill_local and bill_bad, even after deleting the bill_bad service. - see "Too many authentication failures" Sep 5 17:05:38 remote sshd[3916459]: Disconnecting invalid user bill_bad xxx.xxx.xxx.xxx port x: Too many authentication failures [preauth] - don't see login attempt for bill_good Expected Results: file menu of remote directory Reproducible: Always User Profile Reset: No Additional Info: Version: 6.0.7.3 Build ID: 1:6.0.7-0ubuntu0.18.04.10 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); Calc: group -- You are receiving this mail because: You are the assignee for the bug.
Help with connection wizard
Hello. I am working on a firebird connection patch that allows remote connection to a firebird server. Now I need to create a page in the database connection wizard to use that connection, but I have no idea where to start. Can anyone give me any hints? Regards -- *Juan C. Sanz*
[Libreoffice-bugs] [Bug 143996] In LO Writer the “Check true minus sign” function does NOT seem to work.
https://bugs.documentfoundation.org/show_bug.cgi?id=143996 Dieter changed: What|Removed |Added Summary|In LO Writer the “Check |In LO Writer the “Check |true multiplication sign” |true minus sign” function |function does NOT seem to |does NOT seem to work. |work. | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143996] In LO Writer the “Check true multiplication sign” function does NOT seem to work.
https://bugs.documentfoundation.org/show_bug.cgi?id=143996 --- Comment #2 from Eek! A Bug. Kill it! --- (In reply to Dieter from comment #1) > Thank you for reporting the bug.I assume, we are talking about "Minus Sign" > option in the dialog and not multiplication sign, correct. > > I confirm your description, but I'm not sure about the expected behaviour. I > would expect, that there is a keyboard combination with a true minus symbol > as result, but I won't expect that whenever I type the hyphen key, I get a > minus symbol - because perhaps I still want to use hyphens in a document. Oops! Originally, I thought there was an issue with both the multiplication and minus sign functions, so I wrote up a bug report combining both into one report. I then discovered that there was no problem with the multiplication function after all, as it was simply that I had not Toggle Automatic Spell Checking to on. So, I did a quick, albeit flawed, edit before filing the report. Unfortunately, during all this, there was someone in the library who suffered a seizure and the library was swarming with the Emergency Medical Team, Firefighters, and Police just a few meters away from me trying to save this man's life. Not an excuse; but a reason (lack of concentration) for the bad edit. There does not seem to be a way to go back and edit the description of the bug report title, or delete the report entirely and resubmit it, so I guess it will unfortunately have to stay the way it is--but, you are correct. The issue is with the minus sign function. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144317] New: minimize column width dont work on tables exceeding page limits in normal view
https://bugs.documentfoundation.org/show_bug.cgi?id=144317 Bug ID: 144317 Summary: minimize column width dont work on tables exceeding page limits in normal view Product: LibreOffice Version: 7.3.0.0 alpha0+ Master Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: elias__0...@yahoo.com Created attachment 174798 --> https://bugs.documentfoundation.org/attachment.cgi?id=174798=edit minimize column width dont work on tables exceeding page limits in normal view Minimize column width in dont work on tables exceeding page limits in normal view Try to minimize the size of the table using "minimize column width". The table cannot be fixed, instead it is expanded to outer space of our world See attachment. Steps to reproduce: 1) put cursor inside the table 2) Right click, choose "Size" 3) then Choose "minimize column width" 4) Expansion to outer space of (In all previous Libre editions that I Had thsi happened). Expected results to shorten columns INSIDE the document. Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: d5ade739771ddf06cc7ee6d4af15672bfcf09ed6 CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: kf5 (cairo+xcb) Locale: el-GR (el_GR.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-09-01_02:56:07 Calc: threaded Jumbo -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144307] Crash in libQt5Core.so.5 when inserting a special character in a text area
https://bugs.documentfoundation.org/show_bug.cgi?id=144307 --- Comment #12 from Julien Nabet --- You can also declare LO ppa repository in /etc/apt/sources.lst, apt update, then install LO from it -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144307] Crash in libQt5Core.so.5 when inserting a special character in a text area
https://bugs.documentfoundation.org/show_bug.cgi?id=144307 --- Comment #11 from Patrick Charlot --- OK, I will think about that. I know I should have upgraded kubuntu to 20.04, but I did not and now I have to wait a bit, cause I'm too busy. I used to install LO from the distrib, but once I had a problem and some one adviced me to use DEB instead. For the moment I will continue to use 7.1.5 which is OK. and I will upgrade kubuntu some time. Thanks for you help -- You are receiving this mail because: You are the assignee for the bug.
Footnote in a frame
Hi, Is there a reason why it is not possible to insert a footnote in a frame ? When the cursor is in the frame, submenu of Insert > Footnote and Endnote is grayed out. Best regards. JBF -- Seuls des formats ouverts peuvent assurer la pérennité de vos documents.
[Libreoffice-bugs] [Bug 89606] [META] Table of Contents and Indexes bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=89606 Bug 89606 depends on bug 65463, which changed state. Bug 65463 Summary: Writer: Index entry in ToC should be clickable https://bugs.documentfoundation.org/show_bug.cgi?id=65463 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 65463] Writer: Index entry in ToC should be clickable
https://bugs.documentfoundation.org/show_bug.cgi?id=65463 Mike Kaganski changed: What|Removed |Added CC||michael.st...@allotropia.de Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #24 from Mike Kaganski --- Fixed in 7.2 by https://git.libreoffice.org/core/+/7685c0746cf0db6f51c6a7a488f4a960f8eab3c9 - thanks Michael! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/inc sc/source
sc/inc/dpresfilter.hxx |7 +--
sc/source/core/data/dpresfilter.cxx | 30 --
2 files changed, 13 insertions(+), 24 deletions(-)
New commits:
commit 4cd3ce9848aa039b8d443a1257d1298231680b01
Author: Noel Grandin
AuthorDate: Sat Sep 4 21:02:31 2021 +0200
Commit: Noel Grandin
CommitDate: Sun Sep 5 22:11:38 2021 +0200
no need to allocate DimensionNode with unique_ptr
Change-Id: Ia832d2098b72a9e88e7a708d205c49bd3e9c82a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121652
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sc/inc/dpresfilter.hxx b/sc/inc/dpresfilter.hxx
index fcc41a296042..379989788559 100644
--- a/sc/inc/dpresfilter.hxx
+++ b/sc/inc/dpresfilter.hxx
@@ -66,11 +66,6 @@ private:
MembersType maChildMembersValueNames;
MembersType maChildMembersValues;
-DimensionNode();
-DimensionNode(const DimensionNode&) = delete;
-const DimensionNode& operator=(const DimensionNode&) = delete;
-~DimensionNode();
-
#if DEBUG_PIVOT_TABLE
void dump(int nLevel) const;
#endif
@@ -79,7 +74,7 @@ private:
struct MemberNode
{
ValuesType maValues;
-std::map> maChildDimensions;
+std::map maChildDimensions;
MemberNode();
MemberNode(const MemberNode&) = delete;
diff --git a/sc/source/core/data/dpresfilter.cxx
b/sc/source/core/data/dpresfilter.cxx
index 9c6c25413cf2..529abae7dd2e 100644
--- a/sc/source/core/data/dpresfilter.cxx
+++ b/sc/source/core/data/dpresfilter.cxx
@@ -36,12 +36,6 @@ size_t ScDPResultTree::NamePairHash::operator() (const
NamePairType& rPair) cons
return seed;
}
-ScDPResultTree::DimensionNode::DimensionNode() {}
-
-ScDPResultTree::DimensionNode::~DimensionNode()
-{
-}
-
#if DEBUG_PIVOT_TABLE
void ScDPResultTree::DimensionNode::dump(int nLevel) const
{
@@ -110,7 +104,7 @@ void ScDPResultTree::add(
if (itDim == rDims.end())
{
// New dimension. Insert it.
-auto r = rDims.emplace(aUpperName,
std::make_unique());
+auto r = rDims.emplace(aUpperName, DimensionNode());
assert(r.second);
itDim = r.first;
}
@@ -118,8 +112,8 @@ void ScDPResultTree::add(
pDimName = >first;
// Now, see if this dimension member exists.
-DimensionNode* pDim = itDim->second.get();
-MembersType& rMembersValueNames = pDim->maChildMembersValueNames;
+DimensionNode& rDim = itDim->second;
+MembersType& rMembersValueNames = rDim.maChildMembersValueNames;
aUpperName =
ScGlobal::getCharClassPtr()->uppercase(filter.maValueName);
MembersType::iterator itMem = rMembersValueNames.find(aUpperName);
if (itMem == rMembersValueNames.end())
@@ -139,7 +133,7 @@ void ScDPResultTree::add(
// makes no sense to add it to the separate mapping.
if (!filter.maValue.isEmpty() && filter.maValue !=
filter.maValueName)
{
-MembersType& rMembersValues = pDim->maChildMembersValues;
+MembersType& rMembersValues = rDim.maChildMembersValues;
aUpperName =
ScGlobal::getCharClassPtr()->uppercase(filter.maValue);
MembersType::iterator itMemVal =
rMembersValues.find(aUpperName);
if (itMemVal == rMembersValues.end())
@@ -210,16 +204,16 @@ const ScDPResultTree::ValuesType*
ScDPResultTree::getResults(
// Specified dimension not found.
return nullptr;
-const DimensionNode* pDim = itDim->second.get();
-MembersType::const_iterator itMem( pDim->maChildMembersValueNames.find(
+const DimensionNode& rDim = itDim->second;
+MembersType::const_iterator itMem( rDim.maChildMembersValueNames.find(
ScGlobal::getCharClassPtr()->uppercase(
rFilter.MatchValueName)));
-if (itMem == pDim->maChildMembersValueNames.end())
+if (itMem == rDim.maChildMembersValueNames.end())
{
// Specified member name not found, try locale independent value.
-itMem = pDim->maChildMembersValues.find(
ScGlobal::getCharClassPtr()->uppercase( rFilter.MatchValue));
+itMem = rDim.maChildMembersValues.find(
ScGlobal::getCharClassPtr()->uppercase( rFilter.MatchValue));
-if (itMem == pDim->maChildMembersValues.end())
+if (itMem == rDim.maChildMembersValues.end())
// Specified member not found.
return nullptr;
}
@@ -236,10 +230,10 @@ const ScDPResultTree::ValuesType*
ScDPResultTree::getResults(
while (pFieldMember->maChildDimensions.size() == 1)
{
auto itDim( pFieldMember->maChildDimensions.begin());
-const DimensionNode* pDim = itDim->second.get();
-if (pDim->maChildMembersValueNames.size() != 1)
+const DimensionNode& rDim =
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - icon-themes/sukapura icon-themes/sukapura_svg
icon-themes/sukapura/cmd/32/resetattributes.png |binary icon-themes/sukapura/cmd/32/subscript.png |binary icon-themes/sukapura/cmd/32/superscript.png |binary icon-themes/sukapura/cmd/lc_color.png |binary icon-themes/sukapura/cmd/lc_resetattributes.png |binary icon-themes/sukapura/cmd/lc_subscript.png |binary icon-themes/sukapura/cmd/lc_superscript.png |binary icon-themes/sukapura/cmd/sc_subscript.png |binary icon-themes/sukapura/cmd/sc_superscript.png |binary icon-themes/sukapura_svg/cmd/32/resetattributes.svg |2 +- icon-themes/sukapura_svg/cmd/32/subscript.svg |2 +- icon-themes/sukapura_svg/cmd/32/superscript.svg |2 +- icon-themes/sukapura_svg/cmd/lc_color.svg |2 +- icon-themes/sukapura_svg/cmd/lc_resetattributes.svg |2 +- icon-themes/sukapura_svg/cmd/lc_subscript.svg |2 +- icon-themes/sukapura_svg/cmd/lc_superscript.svg |2 +- icon-themes/sukapura_svg/cmd/sc_subscript.svg |2 +- icon-themes/sukapura_svg/cmd/sc_superscript.svg |2 +- 18 files changed, 9 insertions(+), 9 deletions(-) New commits: commit fbab773081a75f41302f676399af7d81304a8593 Author: Rizal Muttaqin AuthorDate: Sat Sep 4 14:40:38 2021 +0700 Commit: Adolfo Jayme Barrientos CommitDate: Sun Sep 5 22:00:02 2021 +0200 Sukapura:^ Superscript, Subscript, Clear Direct Formatting, Font Color Change-Id: Id2fb746dd33eb7de24539c7931221c331e47c087 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121628 Tested-by: Adolfo Jayme Barrientos Reviewed-by: Adolfo Jayme Barrientos (cherry picked from commit bcd823d31f7a2c670db81988e527d5c9682fe177) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121565 Tested-by: Jenkins diff --git a/icon-themes/sukapura/cmd/32/resetattributes.png b/icon-themes/sukapura/cmd/32/resetattributes.png index d048b72cbcb1..b3e7b3d5e726 100644 Binary files a/icon-themes/sukapura/cmd/32/resetattributes.png and b/icon-themes/sukapura/cmd/32/resetattributes.png differ diff --git a/icon-themes/sukapura/cmd/32/subscript.png b/icon-themes/sukapura/cmd/32/subscript.png index 98164334343a..a5183b8d4189 100644 Binary files a/icon-themes/sukapura/cmd/32/subscript.png and b/icon-themes/sukapura/cmd/32/subscript.png differ diff --git a/icon-themes/sukapura/cmd/32/superscript.png b/icon-themes/sukapura/cmd/32/superscript.png index a37bc6659f18..d1a8f2debb3b 100644 Binary files a/icon-themes/sukapura/cmd/32/superscript.png and b/icon-themes/sukapura/cmd/32/superscript.png differ diff --git a/icon-themes/sukapura/cmd/lc_color.png b/icon-themes/sukapura/cmd/lc_color.png index 31b792767fab..57930e666e73 100644 Binary files a/icon-themes/sukapura/cmd/lc_color.png and b/icon-themes/sukapura/cmd/lc_color.png differ diff --git a/icon-themes/sukapura/cmd/lc_resetattributes.png b/icon-themes/sukapura/cmd/lc_resetattributes.png index 6b42c75ab584..b1b041286cee 100644 Binary files a/icon-themes/sukapura/cmd/lc_resetattributes.png and b/icon-themes/sukapura/cmd/lc_resetattributes.png differ diff --git a/icon-themes/sukapura/cmd/lc_subscript.png b/icon-themes/sukapura/cmd/lc_subscript.png index 898992183000..19ba3b2d5686 100644 Binary files a/icon-themes/sukapura/cmd/lc_subscript.png and b/icon-themes/sukapura/cmd/lc_subscript.png differ diff --git a/icon-themes/sukapura/cmd/lc_superscript.png b/icon-themes/sukapura/cmd/lc_superscript.png index 27a0faf2994e..a3dab64d9579 100644 Binary files a/icon-themes/sukapura/cmd/lc_superscript.png and b/icon-themes/sukapura/cmd/lc_superscript.png differ diff --git a/icon-themes/sukapura/cmd/sc_subscript.png b/icon-themes/sukapura/cmd/sc_subscript.png index 23632329d012..9535320e1044 100644 Binary files a/icon-themes/sukapura/cmd/sc_subscript.png and b/icon-themes/sukapura/cmd/sc_subscript.png differ diff --git a/icon-themes/sukapura/cmd/sc_superscript.png b/icon-themes/sukapura/cmd/sc_superscript.png index 23e88767eee3..35212256286b 100644 Binary files a/icon-themes/sukapura/cmd/sc_superscript.png and b/icon-themes/sukapura/cmd/sc_superscript.png differ diff --git a/icon-themes/sukapura_svg/cmd/32/resetattributes.svg b/icon-themes/sukapura_svg/cmd/32/resetattributes.svg index d6ebca589639..3e5d7b265185 100644 --- a/icon-themes/sukapura_svg/cmd/32/resetattributes.svg +++ b/icon-themes/sukapura_svg/cmd/32/resetattributes.svg @@ -1 +1 @@ -http://www.w3.org/2000/svg;> \ No newline at end of file +http://www.w3.org/2000/svg;> \ No newline at end of file diff --git a/icon-themes/sukapura_svg/cmd/32/subscript.svg b/icon-themes/sukapura_svg/cmd/32/subscript.svg index 655f6e340a79..b5c36c5abaf9 100644 --- a/icon-themes/sukapura_svg/cmd/32/subscript.svg +++ b/icon-themes/sukapura_svg/cmd/32/subscript.svg @@ -1 +1 @@ -http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file +http://www.w3.org/2000/svg;
[Libreoffice-commits] core.git: icon-themes/colibre icon-themes/colibre_svg
icon-themes/colibre/vcl/res/fatcross.png |binary icon-themes/colibre_svg/vcl/res/fatcross.svg |2 +- 2 files changed, 1 insertion(+), 1 deletion(-) New commits: commit ee8146d431b17d6a3e3be81400c539a2347aa0f9 Author: Rizal Muttaqin AuthorDate: Sat Sep 4 17:35:10 2021 +0700 Commit: Adolfo Jayme Barrientos CommitDate: Sun Sep 5 21:59:08 2021 +0200 Colibre: tdf#104169 revise FatCross cursor to make it sharper Change-Id: Ia5966c204f8001f1e7b6f5956f8541c4ecbc2901 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121633 Tested-by: Adolfo Jayme Barrientos Reviewed-by: Adolfo Jayme Barrientos diff --git a/icon-themes/colibre/vcl/res/fatcross.png b/icon-themes/colibre/vcl/res/fatcross.png index bf13fd80b06c..b3503d2cdb0a 100644 Binary files a/icon-themes/colibre/vcl/res/fatcross.png and b/icon-themes/colibre/vcl/res/fatcross.png differ diff --git a/icon-themes/colibre_svg/vcl/res/fatcross.svg b/icon-themes/colibre_svg/vcl/res/fatcross.svg index e2bed8d22b3e..b1a47813bc5c 100644 --- a/icon-themes/colibre_svg/vcl/res/fatcross.svg +++ b/icon-themes/colibre_svg/vcl/res/fatcross.svg @@ -1 +1 @@ -http://www.w3.org/2000/svg;> +http://www.w3.org/2000/svg;> \ No newline at end of file
[Libreoffice-bugs] [Bug 139708] Improve "Delete Category" dialog handling in Template Manager
https://bugs.documentfoundation.org/show_bug.cgi?id=139708 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org Whiteboard| QA:needsComment| --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- UX-team, we need your PoV here -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 139708] Improve "Delete Category" dialog handling in Template Manager
https://bugs.documentfoundation.org/show_bug.cgi?id=139708 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org Whiteboard| QA:needsComment| --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- UX-team, we need your PoV here -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 144302] New 'FatCursor' for Calc is not theme-able except under GTK3 environment
https://bugs.documentfoundation.org/show_bug.cgi?id=144302 --- Comment #3 from Caolán McNamara --- Reading the getCursor implementations I would expect that the theme is usable for osx as well which also has the option for fancy cursors loaded from fairly arbitrary external data, while the gen/kf5 cursors are limited to the built-in xbm fallbacks (and win limited to equivalent built-in .cur ones). I imagine it could be possible for at least the kf5 backend to change MAKE_CURSOR in vcl/qt5/Qt5Data.cxx away from using the built-in xbms to loading the theme icon instead. QCursor seems to take a QPixmap argument and QPixmap has a loadFromData member which I imagine could be used similarly to how in the gtk3 version the theme icon can be loaded to a GdkPixmap via load_icon_by_name and that passed to gdk_cursor_new_from_pixbuf. So there could be a medium level easy hack there to change kf5 to load the cursors from icon-theme and not keep using the old-school built-in xbms. Changing gen to do anything except handle xbms is probably futile, and I don't know what options exist under windows. This isn't really a bug in the sense of something broken, just a consequence that the "built-in" icons are the original/default way to implement icons but those old apis and formats are archaic in gtk and osx so another way had to be found there and the simplest thing to do was to load cursors from the usual place icons come from which then has the side effect of making them themeable (though not the hot-spot of the cursor which remains hardcoded in all cases). FWIW it's not (currently) expected that all backends can use cursors from the icon-theme, or even from our built-in old-school xbms/curs. Many of the cursors are explicitly mapped to built-in cursors provided by the host operating system or toolkit so a gtk PointerStyle::Help icon will always use the gtk3 built-in GDK_QUESTION_ARROW cursor. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141420] [META] UNO Object Inspector - Development tools
https://bugs.documentfoundation.org/show_bug.cgi?id=141420 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||143963 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143963 [Bug 143963] UNO Object Inspector: Cannot inspect selected object (e.g. paragraph) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143963] UNO Object Inspector: Cannot inspect selected object (e.g. paragraph)
https://bugs.documentfoundation.org/show_bug.cgi?id=143963 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||141420 Whiteboard| QA:needsComment| Ever confirmed|0 |1 Status|UNCONFIRMED |NEW CC||79045_79...@mail.ru --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Confirm in Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 4debb7e8cc12563f46d1aaa58afdcb831f21cc83 CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: CL Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=141420 [Bug 141420] [META] UNO Object Inspector - Development tools -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144297] View: Images do not appear in Base forms for version 7.2.0.4 for Ubuntu 20.04
https://bugs.documentfoundation.org/show_bug.cgi?id=144297 Robert Großkopf changed: What|Removed |Added CC||rob...@familiegrosskopf.de --- Comment #2 from Robert Großkopf --- Have tested this with LO Version: 7.2.0.4 / LibreOffice Community Build ID: 9a9c6381e3f7a62afc1329bd359cc48accb6435b CPU threads: 6; OS: Linux 5.3; UI render: default; VCL: kf5 (cairo+xcb) Locale: de-DE (de_DE.UTF-8); UI: de-DE Calc: threaded Works here as expected: Image will be shown in a form with field type LONGVARBINARY and internal HSQLDB. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139794] Version 6.4.6 of Math works weel with STIX font (version 1), but version 6.4.7 doesn't
https://bugs.documentfoundation.org/show_bug.cgi?id=139794 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139794] Version 6.4.6 of Math works weel with STIX font (version 1), but version 6.4.7 doesn't
https://bugs.documentfoundation.org/show_bug.cgi?id=139794 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 CC||79045_79...@mail.ru --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- I don't think font is matter. Please try newer LibreOffice version like 7.1.5 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144307] Crash in libQt5Core.so.5 when inserting a special character in a text area
https://bugs.documentfoundation.org/show_bug.cgi?id=144307 --- Comment #10 from Julien Nabet --- I understand then. Deb and rpm packages are more for maintainers of repositories. Indeed, they deal with all necessary dependencies. You should completely uninstall LO and install the last version from LO ppa if you want recent LO versions. It could also be interesting you upgrade Ubuntu, 20.04 one if you want absolutely stick to an LTS. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140604] Some DDE Fields won't load - Multiple empty fields on large/frequently updated dde links.
https://bugs.documentfoundation.org/show_bug.cgi?id=140604 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Whiteboard| QA:needsComment| Ever confirmed|0 |1 --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Can you try it in LibreOffice 7.0.6? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138531] Dynamic Data Exchange is not operable
https://bugs.documentfoundation.org/show_bug.cgi?id=138531 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||0604 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140604] Some DDE Fields won't load - Multiple empty fields on large/frequently updated dde links.
https://bugs.documentfoundation.org/show_bug.cgi?id=140604 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||8531 CC||79045_79...@mail.ru -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/source
vcl/source/filter/imet/ios2met.cxx |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 148d2ffe35cae2fe758a3eb68ffd3ed81e2a8dd1
Author: Caolán McNamara
AuthorDate: Sun Sep 5 15:07:23 2021 +0100
Commit: Caolán McNamara
CommitDate: Sun Sep 5 20:48:58 2021 +0200
ofz: MemorySanitizer: use-of-uninitialized-value
Change-Id: I3de2dd1032f0b43f484b67be0ba470ae08395e91
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121694
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/source/filter/imet/ios2met.cxx
b/vcl/source/filter/imet/ios2met.cxx
index e767047b..edf0bb95293f 100644
--- a/vcl/source/filter/imet/ios2met.cxx
+++ b/vcl/source/filter/imet/ios2met.cxx
@@ -1009,7 +1009,7 @@ void OS2METReader::ReadBitBlt()
void OS2METReader::ReadChrStr(bool bGivenPos, bool bMove, bool bExtra,
sal_uInt16 nOrderLen)
{
Point aP0;
-sal_uInt16 i, nLen;
+sal_uInt16 nLen;
OSFont * pF;
vcl::Font aFont;
Size aSize;
@@ -1043,10 +1043,10 @@ void OS2METReader::ReadChrStr(bool bGivenPos, bool
bMove, bool bExtra, sal_uInt1
else
nLen = nOrderLen-4;
}
-if (nLen > pOS2MET->remainingSize())
+if (!pOS2MET->good() || nLen > pOS2MET->remainingSize())
throw css::uno::Exception("attempt to read past end of input",
nullptr);
std::unique_ptr pChr(new char[nLen+1]);
-for (i=0; iReadChar( pChr[i] );
pChr[nLen] = 0;
OUString aStr( pChr.get(), strlen(pChr.get()), osl_getThreadTextEncoding()
);
[Libreoffice-bugs] [Bug 144307] Crash in libQt5Core.so.5 when inserting a special character in a text area
https://bugs.documentfoundation.org/show_bug.cgi?id=144307 --- Comment #9 from Patrick Charlot --- I installed LO from debs, not from ppa. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144314] Slowness opening documents
https://bugs.documentfoundation.org/show_bug.cgi?id=144314 --- Comment #2 from Julien Nabet --- You indicated 7.0.0.1, could you uninstall this version then download and install 7.1.5 or last version 7.2.0 from https://fr.libreoffice.org/download/telecharger-libreoffice/ ? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144307] Crash in libQt5Core.so.5 when inserting a special character in a text area
https://bugs.documentfoundation.org/show_bug.cgi?id=144307 --- Comment #8 from Julien Nabet --- How did you install LibreOffice 7.1 and 7.2? I mean Ubuntu 18.04 is not the last LTS so did you install from LO ppa (https://launchpad.net/~libreoffice/+archive/ubuntu/ppa) or did you install from .debs? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: solenv/flatpak-manifest.in
solenv/flatpak-manifest.in | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
New commits:
commit 996a259ce73d04686fe893f62480f59a641e2a5d
Author: Stephan Bergmann
AuthorDate: Fri Sep 3 11:47:14 2021 +0200
Commit: Adolfo Jayme Barrientos
CommitDate: Sun Sep 5 20:28:23 2021 +0200
Adapt solenv/flatpak-manifest.in to recent download.lst changes
Change-Id: I88ff67fc9922adc7e6c751c76425c68701512481
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121599
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/solenv/flatpak-manifest.in b/solenv/flatpak-manifest.in
index 6f623a7ce3c5..79ad81783359 100644
--- a/solenv/flatpak-manifest.in
+++ b/solenv/flatpak-manifest.in
@@ -285,11 +285,11 @@
"dest-filename": "libfreehand-0.1.2.tar.xz"
},
{
-"url":
"https://dev-www.libreoffice.org/src/language-subtag-registry-2021-03-05.tar.bz2;,
-"sha256":
"ce80e8face06bf2ada363e0c159e3f990c4116fdae9232ca43e6369aa82bf16a",
+"url":
"https://dev-www.libreoffice.org/src/language-subtag-registry-2021-08-06.tar.bz2;,
+"sha256":
"08452d3997c78e21f2d81e31409dc46557707be6dc1df3129674019659e5ff9b",
"type": "file",
"dest": "external/tarballs",
-"dest-filename":
"language-subtag-registry-2021-03-05.tar.bz2"
+"dest-filename":
"language-subtag-registry-2021-08-06.tar.bz2"
},
{
"url":
"https://dev-www.libreoffice.org/src/liblangtag-0.6.2.tar.bz2;,
@@ -656,11 +656,11 @@
"dest-filename": "libatomic_ops-7.6.8.tar.gz"
},
{
-"url":
"https://dev-www.libreoffice.org/src/skia-m90-45c57e116ee0ce214bdf78405a4762722e4507d9.tar.xz;,
-"sha256":
"abe0b94d54edb717c58d74263f4ed3d27824d2ce9e9f2ce85a21ab38d993f94d",
+"url":
"https://dev-www.libreoffice.org/src/skia-m94-975fcdd755dfc5d57cddbb25857e0c4ac29abe98.tar.xz;,
+"sha256":
"f69f9164ee982a8254722e1100aa7d31f78a5cd5e084418a3e202b55104fc3e2",
"type": "file",
"dest": "external/tarballs",
-"dest-filename":
"skia-m90-45c57e116ee0ce214bdf78405a4762722e4507d9.tar.xz"
+"dest-filename":
"skia-m94-975fcdd755dfc5d57cddbb25857e0c4ac29abe98.tar.xz"
},
{
"url":
"https://dev-www.libreoffice.org/src/dtoa-20180411.tgz;,
[Libreoffice-bugs] [Bug 144315] (spam)
https://bugs.documentfoundation.org/show_bug.cgi?id=144315 Ming Hua changed: What|Removed |Added Component|Impress |deletionRequest Resolution|FIXED |INVALID Summary|dialog and click the|(spam) |'Options' | Version|3.4.0 release |unspecified -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144307] Crash in libQt5Core.so.5 when inserting a special character in a text area
https://bugs.documentfoundation.org/show_bug.cgi?id=144307 --- Comment #7 from Patrick Charlot --- I have separated the profiles to have one for each version (7.1 and 7.2 called respectively 71 and 72, copied from "4" folder) Then I deleted the "72/user" folder and made a try. - Open new document, - open the window to insert special character within the document, (not in textbox) - just press "cancel" et BOUM, crash ! So I don't think that it is due to the profile. I retry with generic backend, there is no crash at all. So it might be due to kubuntu 18.04. don't you think ? BUT when inserting a special character from a specific font (symbola for instance) the character is inserted, but not with this font, with the default font (Times New Roman) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144314] Slowness opening documents
https://bugs.documentfoundation.org/show_bug.cgi?id=144314 Buovjaga changed: What|Removed |Added Hardware|PowerPC |x86-64 (AMD64) Summary|bug |Slowness opening documents Status|UNCONFIRMED |NEEDINFO Component|LibreOffice |Writer CC||ilmari.lauhakangas@libreoff ||ice.org Ever confirmed|0 |1 --- Comment #1 from Buovjaga --- I guess you are talking about Writer. Does this happen with new, empty documents as well? Please copy and paste here the contents of your Help - About by clicking the copy button. This allows us to know more about your system. Set to NEEDINFO. Change back to UNCONFIRMED after you have provided the information. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144316] New: When opening ODS files that have hidden columns/rows, the columns/rows randomly un-hide and need to be hidden again.
https://bugs.documentfoundation.org/show_bug.cgi?id=144316 Bug ID: 144316 Summary: When opening ODS files that have hidden columns/rows, the columns/rows randomly un-hide and need to be hidden again. Product: LibreOffice Version: 7.1.5.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kainyusan...@gmail.com Description: Pretty much exactly what the summary says; when opening (FILEOPEN for key words) an ODS file in LibreOffice Calc that has hidden columns/rows saved as hidden, they randomly decide to un-hide, but chooses a sheet at random to do this. It won't happen while you have the document open for any length of time, only on re-opening it after closing, for whatever reason. I like my spreadsheets to be nice and orderly, presenting only the information I have entered and thus being easy to scroll around within the bounds of, so this is rather irritating. Happens regardless of being in Safe Mode or not (had it actively happen when launching in Safe Mode as a test). Unsure if OpenGL is in use, as the OpenGL documentation on wiki indicates a checkbox that doesn't seem to exist as of version 7.1.5.2; the OpenCL setting just a bit further down is checked, but that says that it's merely "available for use", so unsure if that's the same. Steps to Reproduce: 1.Create an ODS file in Calc. 2.Enter information into the sheet on multiple tabs, and then hide all extra rows/columns. 3.Save and quit, then re-open. Actual Results: Sometimes, works as expected; no issue. Sometimes, works as described; hidden rows/columns break out of hiding on various sheets, and need to be re-hidden. Expected Results: It to never randomly un-hide columns/rows on opening a saved file that has them hidden. Reproducible: Sometimes User Profile Reset: Yes Additional Info: Version: 7.1.5.2 (x64) / LibreOffice Community Build ID: 85f04e9f809797b8199d13c421bd8a2b025d52b5 CPU threads: 8; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win Locale: en-CA (en_CA); UI: en-GB Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144315] dialog and click the 'Options'
https://bugs.documentfoundation.org/show_bug.cgi?id=144315 Igbokwe Vincent changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #1 from Igbokwe Vincent --- dialog and click the 'Options' https://fzmovies.skipogist.com/money-heist-s05-complete-tv-series/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144315] New: dialog and click the 'Options'
https://bugs.documentfoundation.org/show_bug.cgi?id=144315 Bug ID: 144315 Summary: dialog and click the 'Options' Product: LibreOffice Version: 3.4.0 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: trustco...@gmail.com Description: Thanks so much for the information best blog ever ❤ https://skipogist.com/; title="Awesome"> And https://99loads.com/; title="99loads"> Actual Results: dialog and click the 'Options' Expected Results: dialog and click the 'Options' Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: Though am still having small doubt about this https://skipogist.com/; title="Awesome"> Skipogist Though this also said same thing here https://99loads.com/; title="99loads">99loads -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 75159] List indent shifts paragraph tab stop to the right
https://bugs.documentfoundation.org/show_bug.cgi?id=75159 --- Comment #19 from Per Persson --- The bug is also present in Apache OpenOffice 4.1.10 (AOO4110m2(Build:9807) - Rev. b1cdbd2c1b 2021-04-19 19:30), although a bit different. The tab mark in the ruler does not move, but the position of the text that should be at the tab stop is moved to the right (i.e. is not positioned under the tab stop). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144314] New: bug
https://bugs.documentfoundation.org/show_bug.cgi?id=144314 Bug ID: 144314 Summary: bug Product: LibreOffice Version: 7.0.0.1 rc Hardware: PowerPC OS: other Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jd...@orange.fr bonjour depuis que j'ai installer libreoffice draw sur mon pc Windows 10 famili j'ai un temps très long pour que mon logiciel s'ouvre puis un temps très très très long pour que la moindre page puisse enfin s'ouvrir. cela peu duré 10 bonne minutes avant que mon document s'affiche, de même quand je veux mettre le moindre document en page. ca peut me prendre plus d'une heure pour que mon courrier soit fini!!! malgré la mise à jour... Pourriez vous me donner quelques astuces merci salutaitons -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144313] New: Landscape page format
https://bugs.documentfoundation.org/show_bug.cgi?id=144313 Bug ID: 144313 Summary: Landscape page format Product: LibreOffice Version: unspecified Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: educato...@gmail.com When printing in Landscape page format the page remains formatted as Portrait especially on the right side of the page. This leaves a large portion of the page unused. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/source
sc/source/core/tool/sharedformula.cxx | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
New commits:
commit 045765d8b3cd9b00a76e58dfaaffc83422f5fb28
Author: Caolán McNamara
AuthorDate: Sun Sep 5 15:11:04 2021 +0100
Commit: Caolán McNamara
CommitDate: Sun Sep 5 18:25:51 2021 +0200
cid#1491055 Explicit null dereferenced
this always dereferenced pCode so it already assumes pCode cannot be null
Change-Id: I19b601d7f2e089eb2037532590f727c5cd276dd7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121695
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sc/source/core/tool/sharedformula.cxx
b/sc/source/core/tool/sharedformula.cxx
index 167bd951e226..fa617df53c7a 100644
--- a/sc/source/core/tool/sharedformula.cxx
+++ b/sc/source/core/tool/sharedformula.cxx
@@ -392,17 +392,17 @@ void SharedFormulaUtil::startListeningAsGroup(
sc::StartListeningContext& rCxt,
rDoc.SetDetectiveDirty(true);
ScFormulaCellGroupRef xGroup = rTopCell.GetCellGroup();
-const ScTokenArray* pCode = xGroup->mpCode ? &*xGroup->mpCode : nullptr;
-assert(pCode == rTopCell.GetCode());
-if (pCode->IsRecalcModeAlways())
+const ScTokenArray& rCode = *xGroup->mpCode;
+assert( == rTopCell.GetCode());
+if (rCode.IsRecalcModeAlways())
{
rDoc.StartListeningArea(
BCA_LISTEN_ALWAYS, false,
xGroup->getAreaListener(ppSharedTop, BCA_LISTEN_ALWAYS, true,
true));
}
-formula::FormulaToken** p = pCode->GetCode();
-formula::FormulaToken** pEnd = p + pCode->GetCodeLen();
+formula::FormulaToken** p = rCode.GetCode();
+formula::FormulaToken** pEnd = p + rCode.GetCodeLen();
for (; p != pEnd; ++p)
{
const formula::FormulaToken* t = *p;
[Libreoffice-commits] core.git: lotuswordpro/source
lotuswordpro/source/filter/lwpsilverbullet.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit f37ef60c19d1608f0b597d37d025e401d6c99171 Author: Caolán McNamara AuthorDate: Sun Sep 5 15:15:42 2021 +0100 Commit: Caolán McNamara CommitDate: Sun Sep 5 18:25:30 2021 +0200 cid#1490901 silence Out-of-bounds read Change-Id: I9a2c1fe10fc696d5392cd6c95cff11124b5fdb01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121696 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/lotuswordpro/source/filter/lwpsilverbullet.cxx b/lotuswordpro/source/filter/lwpsilverbullet.cxx index e2fa4112d243..629b5affcfb5 100644 --- a/lotuswordpro/source/filter/lwpsilverbullet.cxx +++ b/lotuswordpro/source/filter/lwpsilverbullet.cxx @@ -98,7 +98,8 @@ void LwpSilverBullet::Read() for (sal_uInt16 nC = 0; nC < nNumPos; nC++) m_pResetPositionFlags[nC] = m_pObjStrm->QuickReaduInt8(); -std::fill(m_pResetPositionFlags + nNumPos, m_pResetPositionFlags + SAL_N_ELEMENTS(m_pResetPositionFlags), 0); +if (nNumPos < SAL_N_ELEMENTS(m_pResetPositionFlags)) +std::fill(m_pResetPositionFlags + nNumPos, m_pResetPositionFlags + SAL_N_ELEMENTS(m_pResetPositionFlags), 0); m_nUseCount = m_pObjStrm->QuickReaduInt32();
[Libreoffice-bugs] [Bug 136083] New document from .ott file doesn't work (Windows-only)
https://bugs.documentfoundation.org/show_bug.cgi?id=136083 --- Comment #12 from Julien Nabet --- On Win10 (20H2, 19042.1165) with master sources updated some days ago, I could open the file (File Open) or File/Edit Template, no problem. However, I can't test double click on a file since it's not an installation per se, I just launch LO from command line on Cygwin. I tested another way, I imported the template then I used File/New/Templates... then selected the template, it opens a file named "Untitled 1" with the content of the template. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135887] "Email Document" in Writer on Windows 10 produces an error
https://bugs.documentfoundation.org/show_bug.cgi?id=135887 Julien Nabet changed: What|Removed |Added Ever confirmed|0 |1 CC||serval2...@yahoo.fr Status|UNCONFIRMED |NEEDINFO --- Comment #6 from Julien Nabet --- On Win10 (20H2 19042.1165) with master sources updated some days ago, I don't reproduce this. Could you give a try to 7.1.5 or brand new 7.2.0? Also, could you please apply https://wiki.documentfoundation.org/QA/FirstSteps#Corrupted_user_profile ? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144307] Crash in libQt5Core.so.5 when inserting a special character in a text area
https://bugs.documentfoundation.org/show_bug.cgi?id=144307 --- Comment #6 from Julien Nabet --- To try to pinpoint the pb, you can try the brand new profile but with the file registrymodifications.xcu from the old profile. If you reproduce the crash, it means it's something in this file and so you may attach it here so we can try to reproduce the crash. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144307] Crash in libQt5Core.so.5 when inserting a special character in a text area
https://bugs.documentfoundation.org/show_bug.cgi?id=144307 --- Comment #5 from Patrick Charlot --- Remarks : 1) when using a generic backend there isn't any problem. So as my OS is based en KDE, it might be a problem within KDE ? 2) There is'nt also any problem with a new profile. The same profile is used for both versions 7.1 ans 7.2 ! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 45048] Inconsistent document field names: Use names of column 'Select' instead of 'Type' (e.g. use Pages instead of Statistics)
https://bugs.documentfoundation.org/show_bug.cgi?id=45048 --- Comment #18 from Mike Kaganski --- (In reply to Thomas Lendo from comment #13) > All fields from the type 'Statistics' are called this way when activating > View > Field names and not only 'Page count'. > > Seems a bug for most document fields because the following document field > types are displayed correctly: > - Page (e.g. Page > Page number is called 'Page number') > - Date > - Time And then compare the behavior when *editing* such fields. Editing a Statistics filed, one may still change the type of the statistics, seeing the same list of variants in the middle listbox. But editing a Page Number field, the "Page number", which initially was in the middle box on insertion, goes to the left box (where initially "Page" was). So there is a bug/inconsistency between the insertion dialog's categories. The middle list must have the choices of the *subtype*, editable even after insertion, and not the main types of the fields - "Page" pseudo-type should be fixed in insert field dialog. Basically this tdf#45048 is technically NOTABUG - if the field *types* (not content of "select" middle box) is consistently shown as the field name. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 45048] Inconsistent document field names: Use names of column 'Select' instead of 'Type' (e.g. use Pages instead of Statistics)
https://bugs.documentfoundation.org/show_bug.cgi?id=45048 --- Comment #18 from Mike Kaganski --- (In reply to Thomas Lendo from comment #13) > All fields from the type 'Statistics' are called this way when activating > View > Field names and not only 'Page count'. > > Seems a bug for most document fields because the following document field > types are displayed correctly: > - Page (e.g. Page > Page number is called 'Page number') > - Date > - Time And then compare the behavior when *editing* such fields. Editing a Statistics filed, one may still change the type of the statistics, seeing the same list of variants in the middle listbox. But editing a Page Number field, the "Page number", which initially was in the middle box on insertion, goes to the left box (where initially "Page" was). So there is a bug/inconsistency between the insertion dialog's categories. The middle list must have the choices of the *subtype*, editable even after insertion, and not the main types of the fields - "Page" pseudo-type should be fixed in insert field dialog. Basically this tdf#45048 is technically NOTABUG - if the field *types* (not content of "select" middle box) is consistently shown as the field name. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 144285] LibreOffice 7.2.0.4 crash on macOS always after launching and work
https://bugs.documentfoundation.org/show_bug.cgi?id=144285 --- Comment #10 from steve --- There are two macOS Mojave updates you are missing on your system. You could try if anything changes after installing them. But I doubt they will. On the other hand computers are mystic machines so who knows... Thanks for the crash log - hope that someone more knowledgeable will be able to take a look next week. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144312] Scrolling not possible in LibreOffice options screen
https://bugs.documentfoundation.org/show_bug.cgi?id=144312 nw1...@outlook.com changed: What|Removed |Added Hardware|All |x86-64 (AMD64) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144312] New: Scrolling not possible in LibreOffice options screen
https://bugs.documentfoundation.org/show_bug.cgi?id=144312 Bug ID: 144312 Summary: Scrolling not possible in LibreOffice options screen Product: LibreOffice Version: 7.1.5.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: nw1...@outlook.com Description: Whenever an options page with content that is longer than the window it has been fit into, it will cut off the content at the end, showing no scrolling facility. Steps to Reproduce: 1. Open LibreOffice (any application) 2. Enter Options screen (Tools-Options or Alt-F12) 3. Open any options screen that has longer content (for example LibreOffice-General) 4. Observe that in the default window size on Windows10 the box for the last option (LibreOffice File Associations) is cut off Actual Results: Sections of option page are cut off without ability to scroll down to show more content Expected Results: Scroll bar appears at side of window allowing user to scroll down Reproducible: Always User Profile Reset: No Additional Info: Version: 7.1.5.2 (x64) / LibreOffice Community Build ID: 85f04e9f809797b8199d13c421bd8a2b025d52b5 CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win Locale: en-GB (en_GB); UI: en-GB Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1491055: Null pointer dereferences (FORWARD_NULL)
*** CID 1491055: Null pointer dereferences (FORWARD_NULL)
/sc/source/core/tool/sharedformula.cxx: 397 in
sc::SharedFormulaUtil::startListeningAsGroup(sc::StartListeningContext &,
ScFormulaCell **)()
391 ScDocument& rDoc = rCxt.getDoc();
392 rDoc.SetDetectiveDirty(true);
393
394 ScFormulaCellGroupRef xGroup = rTopCell.GetCellGroup();
395 const ScTokenArray* pCode = xGroup->mpCode ? &*xGroup->mpCode :
nullptr;
396 assert(pCode == rTopCell.GetCode());
>>> CID 1491055: Null pointer dereferences (FORWARD_NULL)
>>> Passing null pointer "pCode" to "IsRecalcModeAlways", which
>>> dereferences it.
397 if (pCode->IsRecalcModeAlways())
398 {
399 rDoc.StartListeningArea(
400 BCA_LISTEN_ALWAYS, false,
401 xGroup->getAreaListener(ppSharedTop, BCA_LISTEN_ALWAYS,
true, true));
402 }
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DLpm7_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi66xvYucuMo-2F-2Fb-2BKii0ofqoRVqb6poMJ9Gjx6zTrrRVtcuW2T14qS2Dn-2BPTIOiLXqcsHztgWQdEj4gAS6e6g-2BHmpll8-2FmzvG2J7ZP7Gc6J6r3SOiMV-2FiXUQmTwZcpptZ4u7k21Xb643km-2FKQSnFe7wxvBj0EOIZfip-2BZ110I-2Brpc-3D
[Libreoffice-bugs] [Bug 144308] Changing the DoAutoComplete attribute of the GlobalSheetSettings interface does not affect automatic completion of text in a cell is used.
https://bugs.documentfoundation.org/show_bug.cgi?id=144308 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||2145 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 132145] "com.sun.star.sheet.GlobalSheetSettings" properties, "org.openoffice.Office.Math" and "org.openoffice.Office.Calc/Input/" entries are not synchronized
https://bugs.documentfoundation.org/show_bug.cgi?id=132145 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||4308 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/workben
vcl/workben/commonfuzzer.hxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit 094117fc686e7b5cf05191079f2195155fc3513e
Author: Caolán McNamara
AuthorDate: Sun Sep 5 10:50:58 2021 +0100
Commit: Caolán McNamara
CommitDate: Sun Sep 5 15:54:18 2021 +0200
ofz: fods timeout, set SAX_DISABLE_THREADS
sax/source/fastparser/fastparser.cxx:857 rEntity.maConsumeResume.wait()
seen in timeout backtrace
Change-Id: Ic1ab15e06dc5ac776101715026a334957bb8e868
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121686
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/workben/commonfuzzer.hxx b/vcl/workben/commonfuzzer.hxx
index 977fb7cb501c..c9afd65552fe 100644
--- a/vcl/workben/commonfuzzer.hxx
+++ b/vcl/workben/commonfuzzer.hxx
@@ -95,6 +95,7 @@ void CommonInitialize(int *argc, char ***argv)
setenv("SAL_DISABLE_PRINTERLIST", "1", 1);
setenv("SAL_DISABLE_DEFAULTPRINTER", "1", 1);
setenv("SAL_NO_FONT_LOOKUP", "1", 1);
+setenv("SAX_DISABLE_THREADS", "1", 1);
//allow bubbling of max input len to fuzzer targets
int nMaxLen = 0;
[Libreoffice-bugs] [Bug 50916] Allow more than 1024 columns in calc
https://bugs.documentfoundation.org/show_bug.cgi?id=50916 --- Comment #184 from elias estatistics --- Bug 144300 created by me same with this. If i use experimental features and find bugs, i reported back here or not at all? --- Comment #185 from elias estatistics --- Bug 144300 created by me same with this. If i use experimental features and find bugs, i reported back here or not at all? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 50916] Allow more than 1024 columns in calc
https://bugs.documentfoundation.org/show_bug.cgi?id=50916 --- Comment #184 from elias estatistics --- Bug 144300 created by me same with this. If i use experimental features and find bugs, i reported back here or not at all? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144300] Transpose above ~940 rows do not transpose
https://bugs.documentfoundation.org/show_bug.cgi?id=144300 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Resolution|--- |NOTABUG Status|NEEDINFO|RESOLVED --- Comment #8 from Roman Kuznetsov <79045_79...@mail.ru> --- (In reply to elias estatistics from comment #7) > Here, it says that libreoffice has experimental feature of > "with 16k columns and 2m rows in upcoming version 7.0." > > Is it true? Yes, today you can activate that feature, but it's still unstable and it's still in experimental status. You can try: 1. Enable experimental features in Tools-Options-LibreOffice-Advances 2. Restart LibreOffice and open Calc 3. Enable very large spreadsheet option in Tools-Options-LibreOffice Calc-Defaults 4. Restart Calc and try enjoy but you shouldn't have any surprises if Calc will work unstable > You may put "solved", however it must be an option "upgrade" or "Enhancement I think we should close this one as NOTABUG because you know where you was wrong in your case now. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144300] Transpose above ~940 rows do not transpose
https://bugs.documentfoundation.org/show_bug.cgi?id=144300 --- Comment #7 from elias estatistics --- You are right! This was! However, I find 1024 column limit very limited for a such application. Here, it says that libreoffice has experimental feature of "with 16k columns and 2m rows in upcoming version 7.0." Is it true? I wil search it. You may put "solved", however it must be an option "upgrade" or "Enhancement -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141179] Create a 'Tip of the Day' help page
https://bugs.documentfoundation.org/show_bug.cgi?id=141179 Olivier Hallot changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |olivier.hallot@libreoffice. |desktop.org |org -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/inc sc/source
sc/inc/columnspanset.hxx|4 +++-
sc/source/core/data/bcaslot.cxx | 13 +
sc/source/core/inc/bcaslot.hxx |2 +-
3 files changed, 9 insertions(+), 10 deletions(-)
New commits:
commit dbae39115963f63be1befe407ff9ed8c1c4a9b62
Author: Noel Grandin
AuthorDate: Sat Sep 4 20:55:29 2021 +0200
Commit: Noel Grandin
CommitDate: Sun Sep 5 14:56:21 2021 +0200
no need to allocate ColumnSpanSet with unique_ptr
Change-Id: If3aaa2a4bc556dad41f56054890dc07f96d42dda
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121651
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sc/inc/columnspanset.hxx b/sc/inc/columnspanset.hxx
index a5fed2d3f25a..926f0520e8a1 100644
--- a/sc/inc/columnspanset.hxx
+++ b/sc/inc/columnspanset.hxx
@@ -85,7 +85,9 @@ public:
ColumnSpanSet();
ColumnSpanSet(const ColumnSpanSet&) = delete;
-const ColumnSpanSet& operator=(const ColumnSpanSet&) = delete;
+ColumnSpanSet& operator=(const ColumnSpanSet&) = delete;
+ColumnSpanSet(ColumnSpanSet&&) = default;
+ColumnSpanSet& operator=(ColumnSpanSet&&) = default;
~ColumnSpanSet();
void set(const ScDocument& rDoc, SCTAB nTab, SCCOL nCol, SCROW nRow, bool
bVal);
diff --git a/sc/source/core/data/bcaslot.cxx b/sc/source/core/data/bcaslot.cxx
index bbca9dda93ae..9a9940445b7a 100644
--- a/sc/source/core/data/bcaslot.cxx
+++ b/sc/source/core/data/bcaslot.cxx
@@ -1077,12 +1077,11 @@ void ScBroadcastAreaSlotMachine::InsertBulkGroupArea(
ScBroadcastArea* pArea, co
if (it == m_BulkGroupAreas.end() || m_BulkGroupAreas.key_comp()(pArea,
it->first))
{
// Insert a new one.
-it = m_BulkGroupAreas.insert(it, std::make_pair(pArea,
std::make_unique()));
+it = m_BulkGroupAreas.insert(it, std::make_pair(pArea,
sc::ColumnSpanSet()));
}
-sc::ColumnSpanSet *const pSet = it->second.get();
-assert(pSet);
-pSet->set(*pDoc, rRange, true);
+sc::ColumnSpanSet& rSet = it->second;
+rSet.set(*pDoc, rRange, true);
}
bool ScBroadcastAreaSlotMachine::BulkBroadcastGroupAreas( SfxHintId nHintId )
@@ -1093,7 +1092,7 @@ bool ScBroadcastAreaSlotMachine::BulkBroadcastGroupAreas(
SfxHintId nHintId )
sc::BulkDataHint aHint( *pDoc, nHintId);
bool bBroadcasted = false;
-for (const auto& [pArea, rxSpans] : m_BulkGroupAreas)
+for (const auto& [pArea, rSpans] : m_BulkGroupAreas)
{
assert(pArea);
SvtBroadcaster& rBC = pArea->GetBroadcaster();
@@ -1105,9 +1104,7 @@ bool ScBroadcastAreaSlotMachine::BulkBroadcastGroupAreas(
SfxHintId nHintId )
}
else
{
-const sc::ColumnSpanSet *const pSpans = rxSpans.get();
-assert(pSpans);
-aHint.setSpans(pSpans);
+aHint.setSpans();
rBC.Broadcast(aHint);
bBroadcasted = true;
}
diff --git a/sc/source/core/inc/bcaslot.hxx b/sc/source/core/inc/bcaslot.hxx
index 2c85229b1feb..56d49e698835 100644
--- a/sc/source/core/inc/bcaslot.hxx
+++ b/sc/source/core/inc/bcaslot.hxx
@@ -245,7 +245,7 @@ public:
class ScBroadcastAreaSlotMachine
{
private:
-typedef std::map>
BulkGroupAreasType;
+typedef std::map BulkGroupAreasType;
/**
Slot offset arrangement of columns and rows, once per sheet.
[Libreoffice-commits] core.git: editeng/source
editeng/source/editeng/editeng.cxx |2 +-
editeng/source/editeng/impedit.hxx |2 +-
editeng/source/editeng/impedit3.cxx |6 +++---
3 files changed, 5 insertions(+), 5 deletions(-)
New commits:
commit 8a60780dddf4a2d043b7152514f251d480f3be7e
Author: Noel Grandin
AuthorDate: Sun Sep 5 09:10:46 2021 +0200
Commit: Noel Grandin
CommitDate: Sun Sep 5 14:56:01 2021 +0200
no need to pass EditSelection around with unique_ptr
Change-Id: I4c55bfd68f35fb0a559d6a3ba3d860445fc7242f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121664
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/editeng/source/editeng/editeng.cxx
b/editeng/source/editeng/editeng.cxx
index b5b3c543354a..e9f19cbd3194 100644
--- a/editeng/source/editeng/editeng.cxx
+++ b/editeng/source/editeng/editeng.cxx
@@ -1735,7 +1735,7 @@ void EditEngine::InsertParagraph(sal_Int32 nPara, const
OUString& rTxt)
void EditEngine::SetText(sal_Int32 nPara, const OUString& rTxt)
{
-std::unique_ptr pSel = pImpEditEngine->SelectParagraph(
nPara );
+std::optional pSel = pImpEditEngine->SelectParagraph( nPara
);
if ( pSel )
{
pImpEditEngine->UndoActionStart( EDITUNDO_INSERT );
diff --git a/editeng/source/editeng/impedit.hxx
b/editeng/source/editeng/impedit.hxx
index b3ca1e284671..b894bd2153e6 100644
--- a/editeng/source/editeng/impedit.hxx
+++ b/editeng/source/editeng/impedit.hxx
@@ -947,7 +947,7 @@ public:
// OV-Special
voidInvalidateFromParagraph( sal_Int32 nFirstInvPara );
EditPaM InsertParagraph( sal_Int32 nPara );
-std::unique_ptr SelectParagraph( sal_Int32 nPara );
+std::optional SelectParagraph( sal_Int32 nPara );
voidSetStatusEventHdl( const Link& rLink )
{ aStatusHdlLink = rLink; }
const Link& GetStatusEventHdl() const {
return aStatusHdlLink; }
diff --git a/editeng/source/editeng/impedit3.cxx
b/editeng/source/editeng/impedit3.cxx
index 441a3ef65aad..7b4a96412181 100644
--- a/editeng/source/editeng/impedit3.cxx
+++ b/editeng/source/editeng/impedit3.cxx
@@ -4160,13 +4160,13 @@ EditPaM ImpEditEngine::InsertParagraph( sal_Int32 nPara
)
return ImpInsertParaBreak( aPaM );
}
-std::unique_ptr ImpEditEngine::SelectParagraph( sal_Int32 nPara
)
+std::optional ImpEditEngine::SelectParagraph( sal_Int32 nPara )
{
-std::unique_ptr pSel;
+std::optional pSel;
ContentNode* pNode = GetEditDoc().GetObject( nPara );
SAL_WARN_IF( !pNode, "editeng", "Paragraph does not exist:
SelectParagraph" );
if ( pNode )
-pSel.reset(new EditSelection( EditPaM( pNode, 0 ), EditPaM( pNode,
pNode->Len() ) ));
+pSel.emplace( EditPaM( pNode, 0 ), EditPaM( pNode, pNode->Len() ) );
return pSel;
}
[Libreoffice-commits] core.git: sd/source
sd/source/filter/ppt/pptinanimations.cxx | 48 +++
1 file changed, 24 insertions(+), 24 deletions(-)
New commits:
commit 24edba599a71da5cec504bdeb595ee1edfd9a4da
Author: Caolán McNamara
AuthorDate: Sun Sep 5 09:43:45 2021 +0100
Commit: Caolán McNamara
CommitDate: Sun Sep 5 14:33:17 2021 +0200
ofz: MemorySanitizer: use-of-uninitialized-value
Change-Id: Idb3fdf49deb35d99284a25957892df0c761ed515
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121670
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sd/source/filter/ppt/pptinanimations.cxx
b/sd/source/filter/ppt/pptinanimations.cxx
index cff1e2d898dd..b6f40b20356e 100644
--- a/sd/source/filter/ppt/pptinanimations.cxx
+++ b/sd/source/filter/ppt/pptinanimations.cxx
@@ -936,8 +936,8 @@ int AnimationImporter::importTimeContainer( const Atom*
pAtom, const Reference<
{
if( pChildAtom->seekToContent() )
{
-float fInterval;
-sal_Int32 nTextUnitEffect, nU1, nU2, nU3;
+float fInterval(0.0);
+sal_Int32 nTextUnitEffect(0), nU1(0), nU2(0), nU3(0);
mrStCtrl.ReadFloat( fInterval ).ReadInt32(
nTextUnitEffect ).ReadInt32( nU1 ).ReadInt32( nU2 ).ReadInt32( nU3 );
@@ -1091,7 +1091,7 @@ void AnimationImporter::importAnimateFilterContainer(
const Atom* pAtom, const R
{
case DFF_msofbtAnimateFilterData:
{
-sal_uInt32 transition;
+sal_uInt32 transition(0);
mrStCtrl.ReadUInt32( nBits );
mrStCtrl.ReadUInt32( transition );
@@ -1190,10 +1190,10 @@ void
AnimationImporter::importAnimateAttributeTargetContainer( const Atom* pAtom
{
if( xAnimate.is() )
{
-sal_uInt32 nBits;
-sal_uInt32 nAdditive;
-sal_uInt32 nAccumulate;
-sal_uInt32 nTransformType;
+sal_uInt32 nBits(0);
+sal_uInt32 nAdditive(0);
+sal_uInt32 nAccumulate(0);
+sal_uInt32 nTransformType(0);
mrStCtrl.ReadUInt32( nBits ).ReadUInt32( nAdditive
).ReadUInt32( nAccumulate ).ReadUInt32( nTransformType );
@@ -1502,7 +1502,7 @@ void AnimationImporter::importAnimateContainer( const
Atom* pAtom, const Referen
{
case DFF_msofbtAnimateData:
{
-sal_uInt32 nCalcmode, nBits, nValueType;
+sal_uInt32 nCalcmode(0), nBits(0), nValueType(0);
mrStCtrl.ReadUInt32( nCalcmode ).ReadUInt32( nBits ).ReadUInt32(
nValueType );
if( nBits & 0x08 )
@@ -1855,8 +1855,8 @@ void AnimationImporter::importAnimateScaleContainer(
const Atom* pAtom, const Re
{
case DFF_msofbtAnimateScaleData:
{
-sal_uInt32 nBits, nZoomContents;
-float fByX, fByY, fFromX, fFromY, fToX, fToY;
+sal_uInt32 nBits(0), nZoomContents(0);
+float fByX(0.0), fByY(0.0), fFromX(0.0), fFromY(0.0), fToX(0.0),
fToY(0.0);
// nBits %001: by, %010: from, %100: to, %1000: zoomContents(bool)
mrStCtrl.ReadUInt32( nBits ).ReadFloat( fByX ).ReadFloat( fByY
).ReadFloat( fFromX ).ReadFloat( fFromY ).ReadFloat( fToX ).ReadFloat( fToY
).ReadUInt32( nZoomContents );
@@ -1953,8 +1953,8 @@ void AnimationImporter::importAnimateRotationContainer(
const Atom* pAtom, const
{
case DFF_msofbtAnimateRotationData:
{
-sal_uInt32 nBits, nU1;
-float fBy, fFrom, fTo;
+sal_uInt32 nBits(0), nU1(0);
+float fBy(0.0), fFrom(0.0), fTo(0.0);
// nBits %001: by, %010: from, %100: to, %1000: zoomContents(bool)
mrStCtrl.ReadUInt32( nBits ).ReadFloat( fBy ).ReadFloat( fFrom
).ReadFloat( fTo ).ReadUInt32( nU1 );
@@ -2043,13 +2043,13 @@ void AnimationImporter::importAnimationValues( const
Atom* pAtom, const Referenc
while( pValueAtom && pValueAtom->seekToContent() )
{
-sal_uInt32 nType;
+sal_uInt32 nType(0);
mrStCtrl.ReadUInt32( nType );
switch( nType )
{
case 0:
{
-float fRepeat;
+float fRepeat(0.0);
mrStCtrl.ReadFloat( fRepeat );
xNode->setRepeatCount( (fRepeat <
(float(3.40282346638528860e+38))) ? makeAny( static_cast(fRepeat) ) :
makeAny( Timing_INDEFINITE ) );
@@ -2068,7 +2068,7 @@ void AnimationImporter::importAnimationValues( const
Atom* pAtom, const Referenc
case 3:
{
-float faccelerate;
+float faccelerate(0.0);
mrStCtrl.ReadFloat( faccelerate );
xNode->setAcceleration( faccelerate );
dump( " accelerate=\"%g\"", static_cast(faccelerate) );
@@ -2077,7 +2077,7 @@
[Libreoffice-commits] core.git: vcl/source
vcl/source/filter/ipict/ipict.cxx | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
New commits:
commit 052afc10c565940fa947e56c49e132aeb94ae03c
Author: Caolán McNamara
AuthorDate: Sun Sep 5 09:33:47 2021 +0100
Commit: Caolán McNamara
CommitDate: Sun Sep 5 14:32:59 2021 +0200
ofz: MemorySanitizer: use-of-uninitialized-value
Change-Id: Ib63d500480a78a144b127c4230542507132d0a5b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121669
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/source/filter/ipict/ipict.cxx
b/vcl/source/filter/ipict/ipict.cxx
index 8c9494c36448..d434763dd4be 100644
--- a/vcl/source/filter/ipict/ipict.cxx
+++ b/vcl/source/filter/ipict/ipict.cxx
@@ -1602,8 +1602,6 @@ sal_uInt64 PictReader::ReadData(sal_uInt16 nOpcode)
break;
case 0x002c: { // fontName
-charsFName[ 256 ], nByteLen;
-sal_uInt16 nLen;
pPict->ReadUInt16( nUSHORT ); nDataSize=nUSHORT+2;
pPict->ReadUInt16( nUSHORT );
if (nUSHORT <=1) aActFont.SetFamily(FAMILY_SWISS);
@@ -1614,9 +1612,11 @@ sal_uInt64 PictReader::ReadData(sal_uInt16 nOpcode)
else if (nUSHORT <= 1023) aActFont.SetFamily(FAMILY_SWISS);
else aActFont.SetFamily(FAMILY_ROMAN);
aActFont.SetCharSet(GetTextEncoding(nUSHORT));
-pPict->ReadChar( nByteLen );
nLen=static_cast(nByteLen)&0x00ff;
-pPict->ReadBytes(, nLen);
-sFName[ nLen ] = 0;
+char nByteLen(0);
+pPict->ReadChar( nByteLen );
+sal_uInt16 nLen = static_cast(nByteLen)&0x00ff;
+char sFName[ 256 ];
+sFName[pPict->ReadBytes(sFName, nLen)] = 0;
OUString aString( sFName, strlen(sFName), osl_getThreadTextEncoding()
);
aActFont.SetFamilyName( aString );
eActMethod = PictDrawingMethod::UNDEFINED;
[Libreoffice-commits] core.git: vcl/source
vcl/source/filter/imet/ios2met.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 08665e27e1d66cde90bac978eed4cee998b1d5d5
Author: Caolán McNamara
AuthorDate: Sun Sep 5 09:22:31 2021 +0100
Commit: Caolán McNamara
CommitDate: Sun Sep 5 14:32:39 2021 +0200
ofz: MemorySanitizer: use-of-uninitialized-value
Change-Id: Iad99d728cea33e8a3b81ccd654258bddd3f96a13
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121668
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/source/filter/imet/ios2met.cxx
b/vcl/source/filter/imet/ios2met.cxx
index cf1694ca04a5..e767047b 100644
--- a/vcl/source/filter/imet/ios2met.cxx
+++ b/vcl/source/filter/imet/ios2met.cxx
@@ -1731,7 +1731,7 @@ void OS2METReader::ReadOrder(sal_uInt16 nOrderID,
sal_uInt16 nOrderLen)
case GOrdPIvAtr: PushAttr(nOrderID);
[[fallthrough]];
case GOrdSIvAtr: {
-sal_uInt8 nA, nP, nFlags;
+sal_uInt8 nA(0), nP(0), nFlags(0);
Color aCol;
RasterOp eROP;
pOS2MET->ReadUChar( nA ).ReadUChar( nP ).ReadUChar( nFlags );
@@ -1780,7 +1780,7 @@ void OS2METReader::ReadOrder(sal_uInt16 nOrderID,
sal_uInt16 nOrderLen)
}
}
else {
-sal_uInt8 nMix;
+sal_uInt8 nMix(0);
pOS2MET->ReadUChar( nMix );
if (nMix==0) {
switch (nP) {
[Libreoffice-commits] core.git: sc/source
sc/source/filter/lotus/lotread.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit ce0229a9a5cb9c375c64dc4bc2bfafb5446f57c4
Author: Caolán McNamara
AuthorDate: Sun Sep 5 09:20:42 2021 +0100
Commit: Caolán McNamara
CommitDate: Sun Sep 5 14:32:18 2021 +0200
ofz: MemorySanitizer: use-of-uninitialized-value
Change-Id: Icbb4187ecc3cbb371fa7c2e6003b920be287ec6f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121667
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sc/source/filter/lotus/lotread.cxx
b/sc/source/filter/lotus/lotread.cxx
index f28a783849fb..240ac323cebb 100644
--- a/sc/source/filter/lotus/lotread.cxx
+++ b/sc/source/filter/lotus/lotread.cxx
@@ -41,7 +41,6 @@ ErrCode ImportLotus::parse()
};
sal_uInt16 nOp;
-sal_uInt16 nSubType;
sal_uInt16 nRecLen;
sal_uInt32 nNextRec = 0;
ErrCodeeRet = ERRCODE_NONE;
@@ -158,6 +157,7 @@ ErrCode ImportLotus::parse()
case 0x001b:// extended attributes
if (nRecLen > 2)
{
+sal_uInt16 nSubType(0);
Read( nSubType );
nRecLen -= 2;
switch( nSubType )
