[Libreoffice-bugs] [Bug 144429] New: checking for update failed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144429

Bug ID: 144429
   Summary: checking for update failed
   Product: LibreOffice
   Version: 7.2.0.4 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: cban...@yahoo.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: ESC meeting minutes: 2021-09-09

[Stephan Bergmann]

On 9/10/21 11:27 AM, Luboš Luňák wrote:

On Thursday 09 of September 2021, Miklos Vajna wrote:

* tb86 (m1 mac mini) build failures with Illegal Instruction
 https://gerrit.libreoffice.org/c/core/+/115675 “Upgrade SSE2 sum to
AVX512 sum with Neumaier 1"


  That doesn't make sense. M1 Mac Mini should be ARM64, but build logs for tb86
claim it's "x86_64-apple-darwin20.6.0". And I have M1 Mac Mini here and those
tests pass fine. I also reviewed that gerrit change and AFAICT the extra CPU
code is properly separated and run only when the support is available. Are
tb86 builds running in some kind of x86_64 virtualization?


Those builds are apparently meant to generate x86-64 binaries, see 
 
"add host/build flags to autogen job when building on macos-arm64", 
though it beats me how that actually works, given that no traces of the


  --host=x86_64-apple-macos --build=x86_64-apple-macos

from that commit's bin/macosx_clang_dbgutil.env show up in tb86 build 
logs like .

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - sw/qa sw/source

[Tomaž Vajngerl (via logerrit)]

 sw/qa/extras/indexing/SearchResultLocatorTest.cxx |   33 ++-
 sw/source/core/inc/SearchResultLocator.hxx|   15 ++-
 sw/source/core/model/SearchResultLocator.cxx  |   98 +++---
 3 files changed, 109 insertions(+), 37 deletions(-)

New commits:
commit d41643593ad4c9557704ee629ef05ee0c0aecede
Author: Tomaž Vajngerl 
AuthorDate: Mon Sep 6 14:17:01 2021 +0900
Commit: Tomaž Vajngerl 
CommitDate: Fri Sep 10 12:50:22 2021 +0200

indexing: support JSON and XML as input for SearchResultLocator

JSON is much easier to deal with when using REST and javascript,
so support both.

Change-Id: I61035452d9a7ba889ac355a42201d79b9fafec6f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121742
Tested-by: Tomaž Vajngerl 
Reviewed-by: Tomaž Vajngerl 
(cherry picked from commit eac288d02cafc49c5a14fa27bb449c33eb4b1803)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121815
Tested-by: Jenkins CollaboraOffice 

diff --git a/sw/qa/extras/indexing/SearchResultLocatorTest.cxx 
b/sw/qa/extras/indexing/SearchResultLocatorTest.cxx
index 71460f408d9a..199e67710aa0 100644
--- a/sw/qa/extras/indexing/SearchResultLocatorTest.cxx
+++ b/sw/qa/extras/indexing/SearchResultLocatorTest.cxx
@@ -27,12 +27,14 @@ private:
 
 public:
 void testSearchResultLocator();
-void testSearchResultLocatorUsingPayload();
+void testSearchResultLocatorUsingXmlPayload();
+void testSearchResultLocatorUsingJsonPayload();
 void testSearchResultLocatorForSdrObjects();
 
 CPPUNIT_TEST_SUITE(SearchResultLocatorTest);
 CPPUNIT_TEST(testSearchResultLocator);
-CPPUNIT_TEST(testSearchResultLocatorUsingPayload);
+CPPUNIT_TEST(testSearchResultLocatorUsingXmlPayload);
+CPPUNIT_TEST(testSearchResultLocatorUsingJsonPayload);
 CPPUNIT_TEST(testSearchResultLocatorForSdrObjects);
 CPPUNIT_TEST_SUITE_END();
 };
@@ -73,7 +75,7 @@ void SearchResultLocatorTest::testSearchResultLocator()
 #endif
 }
 
-void SearchResultLocatorTest::testSearchResultLocatorUsingPayload()
+void SearchResultLocatorTest::testSearchResultLocatorUsingXmlPayload()
 {
 SwDoc* pDoc = createDoc("IndexingExport_VariousParagraphs.odt");
 CPPUNIT_ASSERT(pDoc);
@@ -98,6 +100,31 @@ void 
SearchResultLocatorTest::testSearchResultLocatorUsingPayload()
 #endif
 }
 
+void SearchResultLocatorTest::testSearchResultLocatorUsingJsonPayload()
+{
+SwDoc* pDoc = createDoc("IndexingExport_VariousParagraphs.odt");
+CPPUNIT_ASSERT(pDoc);
+
+sw::search::SearchResultLocator aLocator(pDoc);
+OString payload = "["
+  "{ \"type\" : 1, \"index\" : 14 }"
+  "]";
+
+sw::search::LocationResult aResult = 
aLocator.findForPayload(payload.getStr());
+CPPUNIT_ASSERT_EQUAL(size_t(1), aResult.maRectangles.size());
+
+// skip asserting exact values for macOS and Windows because of
+// inconsistent results
+#if !defined(_WIN32) && !defined(MACOSX)
+auto aRectangle = aResult.maRectangles[0];
+CPPUNIT_ASSERT_DOUBLES_EQUAL(1418.0, aRectangle.getMinX(), 1e-4);
+CPPUNIT_ASSERT_DOUBLES_EQUAL(.0, aRectangle.getMinY(), 1e-4);
+
+CPPUNIT_ASSERT_DOUBLES_EQUAL(9638.0, aRectangle.getWidth(), 1e-4);
+CPPUNIT_ASSERT_DOUBLES_EQUAL(276.0, aRectangle.getHeight(), 1e-4);
+#endif
+}
+
 void SearchResultLocatorTest::testSearchResultLocatorForSdrObjects()
 {
 SwDoc* pDoc = createDoc("IndexingExport_Shapes.odt");
diff --git a/sw/source/core/inc/SearchResultLocator.hxx 
b/sw/source/core/inc/SearchResultLocator.hxx
index 7dac632ae58f..fb46c85253eb 100644
--- a/sw/source/core/inc/SearchResultLocator.hxx
+++ b/sw/source/core/inc/SearchResultLocator.hxx
@@ -18,20 +18,20 @@ namespace sw::search
 {
 enum class NodeType
 {
-Undefined,
-WriterNode,
-SdrObject
+Undefined = 0,
+WriterNode = 1,
+SdrObject = 2
 };
 
 struct SearchIndexData
 {
 NodeType meType = NodeType::Undefined;
-sal_uInt32 mnNodeIndex = 0;
+sal_Int32 mnNodeIndex = 0;
 OUString maObjectName;
 
 SearchIndexData() {}
 
-SearchIndexData(NodeType eType, sal_uInt32 nNodeIndex, OUString const& 
aObjectName = OUString())
+SearchIndexData(NodeType eType, sal_Int32 nNodeIndex, OUString const& 
aObjectName = OUString())
 : meType(eType)
 , mnNodeIndex(nNodeIndex)
 , maObjectName(aObjectName)
@@ -50,6 +50,10 @@ class SW_DLLPUBLIC SearchResultLocator
 SwDoc* mpDocument;
 
 void findOne(LocationResult& rResult, SearchIndexData const& 
rSearchIndexData);
+static bool tryParseJSON(const char* pPayload,
+ std::vector& 
rDataVector);
+static bool tryParseXML(const char* pPayload,
+std::vector& 
rDataVector);
 
 public:
 SearchResultLocator(SwDoc* pDoc)
@@ -58,7 +62,6 @@ public:
 }
 
 LocationResult find(std::vector const& 
rSearchIndexDataVector);
-
 LocationResult findForPayload(const char* pPayload);
 };
 
diff --git 

[Libreoffice-bugs] [Bug 90299] External links don't saved as relative in xls

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90299

Mike Kaganski  changed:

   What|Removed |Added

   Keywords||difficultyBeginner,
   ||easyHack, skillCpp

--- Comment #18 from Mike Kaganski  ---
Code pointer:

The path is saved in XclExpSupbook::WriteBody, using maUrlEncoded.

The encoding of the URL for storing to BIFF happens in lclEncodeDosUrl
(sc/source/filter/excel/xehelper.cxx).

The latter *unconditionally* tries to store *drive* relative to base, but *does
not* try to save directory path relatively.

There is XclImpUrlHelper::DecodeUrl in sc/source/filter/excel/xihelper.cxx,
that does the opposite cf. to lclEncodeDosUrl.

Basically the task of the easy hack is: check with an Excel-generated XLS
containing a relative reference, what arrives to XclImpUrlHelper::DecodeUrl;
then implement passing the value of XclExpRoot::IsRelUrl() down to
lclEncodeDosUrl; and then in the latter, implement proper generation of
relative address depending on the passed IsRelUrl value.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144412] Qt5/KF5 flips writing direction on Ctrl+Shift+p

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144412

--- Comment #7 from Jan-Marek Glogowski  ---
Thanks for your comments!

I now fixed my patch reading the gtk3 code w.r.t. pThis->m_nKeyModifiers
handling again and added the missed reset on normal key input, which seems to
fix it.

And I added some (correct?) comments explaining the feature and implementation
to the qt5 code.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143777] Toolbars-Mail Merge->Exclude recipient is every times grey and without function

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143777

NISZ LibreOffice Team  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
   Keywords||bibisected, bisected,
   ||regression
Version|7.1.5.2 release |7.0.0.3 release
 CC||caol...@redhat.com,
   ||libreoff...@nisz.hu

--- Comment #7 from NISZ LibreOffice Team  ---
Confirming in 
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: c7b5e6566d9b24a0a996c739a945004d9aadee2f
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL

Seems to have started in 7.0 with:

https://git.libreoffice.org/core/+/83c0b9940057eb734a247a5f44386452a6a1a9e9

author  Caolán McNamara Sun Feb 16 16:28:33 2020 +
committer   Caolán McNamara Sun Feb 16 20:17:26
2020 +0100

weld ExcludeCheckBox Item Window

Adding CC to: Caolán McNamara

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144176] Cannot see last line of inserted comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144176

Tales Tomaz  changed:

   What|Removed |Added

 OS|Linux (All) |Windows (All)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: xmloff/source

[Michael Stahl (via logerrit)]

 xmloff/source/draw/shapeexport.cxx |5 +
 1 file changed, 5 insertions(+)

New commits:
commit a0d28d03ff40a77a2c88704a7b2bedb68e68563f
Author: Michael Stahl 
AuthorDate: Thu Sep 9 18:52:49 2021 +0200
Commit: Michael Stahl 
CommitDate: Fri Sep 10 12:44:58 2021 +0200

xmloff: ODF export: avoid mysterious crash while sorting shapes

Apparently the draw page contains a null XShape.  That sounds like a bug
but OTOH this sorting feature from commit
9bc6160e0acbc78be998129ea55ed7e4529959faa isn't that important so let's
sweep the problem under the rug.

0   swlo.dll
sw::GetZOrderLayer::operator()(com::sun::star::uno::Reference
 const &) 
C:\cygwin64\home\buildslave\source\libo-core\sw\source\filter\xml\zorder.hxx:37
1   mergedlo.dll
xmloff::FixZOrder(com::sun::star::uno::Reference
 const &,std::function const &)
C:\cygwin64\home\buildslave\source\libo-core\xmloff\source\draw\shapeexport.cxx:1003
2   swlo.dll
SwXMLWriter::Write_(com::sun::star::uno::Reference
 const &,rtl::OUString const &)   
C:\cygwin64\home\buildslave\source\libo-core\sw\source\filter\xml\wrtxml.cxx:190


https://crashreport.libreoffice.org/stats/crash_details/045adea4-c577-4164-9e69-bde5f892bd17

Change-Id: I1e67dc1c354cb14717cf9667314d6752e1b4c295
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121860
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/xmloff/source/draw/shapeexport.cxx 
b/xmloff/source/draw/shapeexport.cxx
index 455ca3b4e024..8c7ba1727a84 100644
--- a/xmloff/source/draw/shapeexport.cxx
+++ b/xmloff/source/draw/shapeexport.cxx
@@ -1024,6 +1024,11 @@ void FixZOrder(uno::Reference const& 
xShapes,
 for (sal_Int32 i = 0; i < nCount; ++i)
 {
 uno::Reference const 
xShape(xShapes->getByIndex(i), uno::UNO_QUERY);
+if (!xShape.is())
+{
+SAL_WARN("xmloff", "FixZOrder: null shape, cannot sort");
+return;
+}
 unsigned int const nLayer(rGetLayer(xShape));
 if (layers.size() <= nLayer)
 {

[Libreoffice-bugs] [Bug 144176] Cannot see last line of inserted comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144176

Tales Tomaz  changed:

   What|Removed |Added

 OS|Windows (All)   |Linux (All)

--- Comment #4 from Tales Tomaz  ---
Partially reproduce

Bottom half of the last line of the comment hidden behind author and date info
in LO 7.2.0.4.

Info:
Version: 7.2.0.4 / LibreOffice Community
Build ID: 20(Build:4)
CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-GB (en_GB.UTF-8); UI: en-GB
7.2.0-2
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/qa

[Xisco Fauli (via logerrit)]

 sw/qa/extras/rtfexport/rtfexport5.cxx |6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

New commits:
commit ef3329a520b11782c441ee6c2805bed622047407
Author: Xisco Fauli 
AuthorDate: Fri Sep 10 11:02:48 2021 +0200
Commit: Xisco Fauli 
CommitDate: Fri Sep 10 12:41:52 2021 +0200

CppunitTest_sw_rtfexport5: simplify asserts

Directly get the properties as Color
Follow-up of 7b3a681a867eeb2d68abd4ce33b07cabfff224ef
< tdf#141908: replace usage of sal_Int32 with colors >

Change-Id: I23da21b88dad7758856c719ebebaef9ed6fe7ca9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121868
Tested-by: Xisco Fauli 
Reviewed-by: Xisco Fauli 

diff --git a/sw/qa/extras/rtfexport/rtfexport5.cxx 
b/sw/qa/extras/rtfexport/rtfexport5.cxx
index 44b969c9a6ff..b1d11df3a0f8 100644
--- a/sw/qa/extras/rtfexport/rtfexport5.cxx
+++ b/sw/qa/extras/rtfexport/rtfexport5.cxx
@@ -392,14 +392,12 @@ DECLARE_RTFEXPORT_TEST(testNestedTable, "rhbz1065629.rtf")
 table::BorderLine2 halfPtSolid(sal_Int32(COL_BLACK), 0, 18, 0, 
table::BorderLineStyle::SOLID,
18);
 CPPUNIT_ASSERT_BORDER_EQUAL(halfPtSolid, 
getProperty(xCell, "LeftBorder"));
-CPPUNIT_ASSERT_EQUAL(COL_TRANSPARENT,
- Color(ColorTransparency, 
getProperty(xCell, "BackColor")));
+CPPUNIT_ASSERT_EQUAL(COL_TRANSPARENT, getProperty(xCell, 
"BackColor"));
 xCell.set(xTable->getCellByName("B2"), uno::UNO_QUERY);
 CPPUNIT_ASSERT(xCell.is());
 CPPUNIT_ASSERT_BORDER_EQUAL(halfPtSolid, 
getProperty(xCell, "LeftBorder"));
 CPPUNIT_ASSERT_BORDER_EQUAL(halfPtSolid, 
getProperty(xCell, "RightBorder"));
-CPPUNIT_ASSERT_EQUAL(COL_TRANSPARENT,
- Color(ColorTransparency, 
getProperty(xCell, "BackColor")));
+CPPUNIT_ASSERT_EQUAL(COL_TRANSPARENT, getProperty(xCell, 
"BackColor"));
 
 // \sect at the end resulted in spurious page break
 CPPUNIT_ASSERT_EQUAL(1, getPages());

[Libreoffice-bugs] [Bug 144402] FILESAVE DOCX: some images are duplicated after saving and reopening file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144402

--- Comment #3 from Timur  ---
No need to change anything, enough to run soffice --convert-to docx.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: oox/source sw/qa

[Vasily Melenchuk (via logerrit)]

 oox/source/drawingml/textbodycontext.cxx |   11 +++
 oox/source/drawingml/textrun.cxx |8 -
 sw/qa/extras/ooxmlimport/data/tdf126426.docx |binary
 sw/qa/extras/ooxmlimport/ooxmlimport2.cxx|   38 +++
 4 files changed, 56 insertions(+), 1 deletion(-)

New commits:
commit 14d299f8f1e19b39dfa81e143762c6b277c1ae9a
Author: Vasily Melenchuk 
AuthorDate: Fri Aug 27 18:10:15 2021 +0300
Commit: Thorsten Behrens 
CommitDate: Fri Sep 10 12:27:14 2021 +0200

tdf#126426: support for hyperlinks in TextParagraphContext

Usually hyperlinks are processed by TextBodyContext, but
for grouped shape we accidentaly gone into TextParagraphContext
It has almost all possibilities to process txbxContent,
but not hyperlinks.

Additionally some hyperlink char attributes (color and underline)
can expand to follow up ordinal text. Additional small hack applied
to avoid this.

Unfortunately this is not a final solution: such document fails
roundtrip and hyperlinks are lost after saving to DOCX.

Change-Id: Ie954f53696bd872cb1f59cb586fb55f6cd7c73bc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121172
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/oox/source/drawingml/textbodycontext.cxx 
b/oox/source/drawingml/textbodycontext.cxx
index 0492ac22e44a..b1e5241aa19a 100644
--- a/oox/source/drawingml/textbodycontext.cxx
+++ b/oox/source/drawingml/textbodycontext.cxx
@@ -29,6 +29,7 @@
 #include 
 #include 
 #include 
+#include "hyperlinkcontext.hxx"
 
 #include 
 
@@ -104,6 +105,16 @@ ContextHandlerRef TextParagraphContext::onCreateContext( 
sal_Int32 aElementToken
 return this;
 case OOX_TOKEN(a14, m):
 return CreateLazyMathBufferingContext(*this, mrParagraph);
+case W_TOKEN( hyperlink ):
+{
+TextRunPtr pRun = std::make_shared();
+mrParagraph.addRun(pRun);
+// parse hyperlink attributes: use HyperLinkContext for that
+rtl::Reference pContext(new HyperLinkContext(
+*this, rAttribs, 
pRun->getTextCharacterProperties().maHyperlinkPropertyMap));
+// but create text run context because HyperLinkContext can't 
process internal w:r, w:t, etc
+return new RegularTextRunContext(*this, pRun);
+}
 default:
 SAL_WARN("oox", "TextParagraphContext::onCreateContext: unhandled 
element: " << getBaseToken(aElementToken));
 }
diff --git a/oox/source/drawingml/textrun.cxx b/oox/source/drawingml/textrun.cxx
index ab87fb732141..e3bcecb745d5 100644
--- a/oox/source/drawingml/textrun.cxx
+++ b/oox/source/drawingml/textrun.cxx
@@ -69,7 +69,13 @@ sal_Int32 TextRun::insertAt(
 Any aOldFontFamily = xState->getPropertyDefault("CharFontFamily");
 
 TextCharacterProperties aTextCharacterProps( rTextCharacterStyle );
-aTextCharacterProps.assignUsed( maTextCharacterProperties );
+
+// If no text color specified lets anyway initialize it as default:
+// this will help to recover after hyperlink
+if (!aTextCharacterProps.maFillProperties.maFillColor.isUsed())
+aTextCharacterProps.maFillProperties.moFillType = XML_solidFill;
+
+aTextCharacterProps.assignUsed(maTextCharacterProperties);
 if ( aTextCharacterProps.moHeight.has() )
 nCharHeight = aTextCharacterProps.moHeight.get();
 else
diff --git a/sw/qa/extras/ooxmlimport/data/tdf126426.docx 
b/sw/qa/extras/ooxmlimport/data/tdf126426.docx
new file mode 100644
index ..d77051365ca2
Binary files /dev/null and b/sw/qa/extras/ooxmlimport/data/tdf126426.docx differ
diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx 
b/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx
index e132befdd09f..03f6b21d8c9f 100644
--- a/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx
+++ b/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx
@@ -23,6 +23,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 
@@ -903,6 +904,43 @@ CPPUNIT_TEST_FIXTURE(Test, testTdf129912)
 }
 }
 
+CPPUNIT_TEST_FIXTURE(Test, testTdf126426)
+{
+load(mpTestDocumentPath, "tdf126426.docx");
+
+uno::Reference xGroup(getShape(1), 
uno::UNO_QUERY_THROW);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(2), xGroup->getCount());
+
+// get second shape in group
+uno::Reference 
xParaEnumAccess(xGroup->getByIndex(1),
+  
uno::UNO_QUERY_THROW);
+uno::Reference xParaEnum = 
xParaEnumAccess->createEnumeration();
+
+uno::Reference xPara(xParaEnum->nextElement(), 
uno::UNO_QUERY_THROW);
+uno::Reference xRunEnumAccess(xPara, 
uno::UNO_QUERY_THROW);
+
+uno::Reference xRunEnum = 
xRunEnumAccess->createEnumeration();
+{
+// Text before: was before this bugfix
+uno::Reference xRun(xRunEnum->nextElement(), 
uno::UNO_QUERY_THROW);
+CPPUNIT_ASSERT_EQUAL(OUString("Some text 

[Libreoffice-commits] core.git: configure.ac

[Caolán McNamara (via logerrit)]

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3c02fe5ca8e12dc52531367a1ac1c0802518d133
Author: Caolán McNamara 
AuthorDate: Fri Sep 10 08:50:07 2021 +0100
Commit: René Engelhard 
CommitDate: Fri Sep 10 12:20:34 2021 +0200

--without-system-cuckoo to override --with-system-headers didn't work

Change-Id: I7a516fb0b7449dd33f95724f311b63387cc42f34
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121869
Tested-by: René Engelhard 
Reviewed-by: René Engelhard 

diff --git a/configure.ac b/configure.ac
index 5f34231750af..45d19327d19d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -10358,7 +10358,7 @@ dnl 
===
 dnl Check for system cuckoo
 dnl ===
 AC_MSG_CHECKING([which cuckoo to use])
-if test "$with_system_cuckoo" = "yes" -o "$with_system_headers" = "yes"; then
+if test "$with_system_cuckoo" = "yes"; then
 AC_MSG_RESULT([external])
 SYSTEM_CUCKOO=TRUE
 AC_LANG_PUSH([C++])

[Libreoffice-bugs] [Bug 144422] Sheet, "Link To External Data", directly import csv FILEOPEN, FILEIMPORT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144422

Eike Rathke  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144422] Sheet, "Link To External Data", directly import csv FILEOPEN, FILEIMPORT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144422

Eike Rathke  changed:

   What|Removed |Added

 Status|CLOSED  |RESOLVED
 Resolution|FIXED   |DUPLICATE

--- Comment #2 from Eike Rathke  ---


*** This bug has been marked as a duplicate of bug 114995 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144422] Sheet, "Link To External Data", directly import csv FILEOPEN, FILEIMPORT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144422

Eike Rathke  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144422] Sheet, "Link To External Data", directly import csv FILEOPEN, FILEIMPORT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144422

Eike Rathke  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Eike Rathke  ---
Your version 6.0.7.3 is too old. CSV can be used as external linked data since
6.1 already see
https://wiki.documentfoundation.org/ReleaseNotes/6.1#Link_to_External_Data_supports_CSV

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144205] Calc: Delete Column and further Insert and Delete never instant but considerably slower from LO 7.2 (12 seconds)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144205

--- Comment #8 from David Lynch  ---
There are still performance issues with the latest revision (see bug 144155).
The following tests are on attachment 174675 [details]:

Hide row > instantaneous
Show row > instantaneous
Select cell > instantaneous
Enter data in cell > instantaneous
Enter simple formula (=AO1) in cell > instantaneous
Insert column > 10 secs
Fill down BH2:BH3 > 11 secs
Delete data from (a single) cell > 20 secs
Delete simple formula (=AO1) in cell > 10 secs
Select row > 10 secs


Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 96d1240adf946c443fb2c369a1c84e31e259c7a8
CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: en-GB (en_GB); UI: en-GB
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 130795] FILEOPEN: Spreadsheet takes long to open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130795

--- Comment #20 from Xisco Faulí  ---
it takes

real0m17,823s
user0m26,524s
sys 0m1,320s

with the commit from comment 18, while it takes

real0m28,101s
user0m38,720s
sys 0m7,812s

without it. Nice improvement

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 115547] Firebird: Link is formed to an external file with file:///C: (three slash)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115547

--- Comment #26 from Mike Kaganski  ---
(In reply to avsharapov from comment #0)
> And correctly two file://C:

(In reply to Julien Nabet from comment #11)
> Indeed, there are 3 slashes but it opens.
> I agree, that seeing 3 "/" is a bit weird.

Just FTR.

The *correct* form for local file URL is using *three* forward slashes. The
first two start "authority" part of file hierarchy; and the third coming
immediately means "empty authority part, i.e. local system", and starts
absolute path.

Ref: RFC8089, which shows correct examples for URLs both on Unix-like, as well
as Windows, paths. They indeed have three slashes. Two slashes and an absolute
path without an "authority" (usually host) is invalid, although widely accepted
as a commonly met variant.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144408] UI: New Document doesn't inherit size from 'source' window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144408

--- Comment #5 from Telesto  ---
(In reply to Heiko Tietze from comment #4)
> Pretty sure that all new Window open with the same size after you restart
> the application. 

It looks this way at first sight, but is sadly not the case if you start
fiddling around :-( The whole behaviour feels pretty logical except I'm lacking
some a piece of the puzzle...

Step 13. Shutdown LibreOffice
Step 14. Launch start center
Step 15. Click Calc from start center (same size as Start Center; fine)
Step 16. CTRL+N -> Same size as previous window (fine)
Step 17. Resize the window of the New Document 2 (make it different from the
square)
Step 18. Close the smaller document (square)
Step 19. Focus the Document 2 and press CTRL+N -> New document with small
square size appears
Step 20. Close new square windowed document
Step 21. Focus Document 2 again, click the new document drop down and select
Writer. -> Now writer opens in full screen
Step 22. Drag it from full screen to 'windowed' mode. Notice it uses Start
Screen dimensions
Step 22. Open new Calc document from Writer, now it will be Square windowed

It seems to me that two windows sizes to be stored. One for the first document
and one for the second. Maybe one from the modules itself and one relate to
start center which is pushed to the 'Module' and the one stored at the module
itself (say in case of directly opening Writer without Start Center)

-- 
You are receiving this mail because:
You are the assignee for the bug.

Some questions about Libreoffice Android and CollaboraOnline Android compilation

[Canoe Cat]

Hello!

I'm a big fan of Libreoffice!
I have successfully compiled online's Android application through this branch 
of Core "distro/collabora/cp-6.4" and CollaboraOnline "distro/collabora/co-6-4"
However, I installed the compiled APK on some phones and the document opened 
blank. On some phones , the document opened normally.
In order to verify whether there is any problem with the source code compiled 
by APK, I downloaded the installation package released by your company in 
Google Mall and installed it on the phones showing blank documents. Then your 
company released the installation package and opened the documents normally
So, I would like to ask if there are other problems with pulling the latest 
source code to compile the complete package, and if there is a need for a 
stable release branch to compile it?
Looking forward to your reply!

Re: ESC meeting minutes: 2021-09-09

[Luboš Luňák]

On Thursday 09 of September 2021, Miklos Vajna wrote:
> * tb86 (m1 mac mini) build failures with Illegal Instruction
> https://gerrit.libreoffice.org/c/core/+/115675 “Upgrade SSE2 sum to
> AVX512 sum with Neumaier 1"

 That doesn't make sense. M1 Mac Mini should be ARM64, but build logs for tb86 
claim it's "x86_64-apple-darwin20.6.0". And I have M1 Mac Mini here and those 
tests pass fine. I also reviewed that gerrit change and AFAICT the extra CPU 
code is properly separated and run only when the support is available. Are 
tb86 builds running in some kind of x86_64 virtualization?

-- 
 Luboš Luňák
 l.lu...@collabora.com

[Libreoffice-bugs] [Bug 119901] [META] Bugs related to maximized window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=119901

Heiko Tietze  changed:

   What|Removed |Added

 Depends on||125543


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=125543
[Bug 125543] Calc window width and height resize to zero when unmaximizing
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 113209] [META] UI bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113209

Heiko Tietze  changed:

   What|Removed |Added

 Depends on|125543  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=125543
[Bug 125543] Calc window width and height resize to zero when unmaximizing
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 75644] Better options to control LibO window resize of the Start Screen and last used window size of each document module (summary in comment 10)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=75644

Heiko Tietze  changed:

   What|Removed |Added

 Depends on|125543  |
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||5543


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=125543
[Bug 125543] Calc window width and height resize to zero when unmaximizing
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 125543] Calc window width and height resize to zero when unmaximizing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125543

Heiko Tietze  changed:

   What|Removed |Added

 Blocks|113209, 75644   |119901
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=75
   ||644


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=75644
[Bug 75644] Better options to control LibO window resize of the Start Screen
and last used window size of each document module (summary in comment 10)
https://bugs.documentfoundation.org/show_bug.cgi?id=113209
[Bug 113209] [META] UI bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=119901
[Bug 119901] [META] Bugs related to maximized window
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 75644] Better options to control LibO window resize of the Start Screen and last used window size of each document module (summary in comment 10)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=75644

Heiko Tietze  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||4408

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 119901] [META] Bugs related to maximized window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=119901

Heiko Tietze  changed:

   What|Removed |Added

 Depends on||144408


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=144408
[Bug 144408] UI: New Document doesn't inherit size from 'source' window
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 113209] [META] UI bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113209

Heiko Tietze  changed:

   What|Removed |Added

 Depends on||144408


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=144408
[Bug 144408] UI: New Document doesn't inherit size from 'source' window
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 61914] [META] Start Center bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=61914

Heiko Tietze  changed:

   What|Removed |Added

 Depends on||144408


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=144408
[Bug 144408] UI: New Document doesn't inherit size from 'source' window
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144408] UI: New Document doesn't inherit size from 'source' window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144408

Heiko Tietze  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org,
   ||vstuart.fo...@utsa.edu
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=75
   ||644
   Keywords|needsUXEval |
 Blocks||61914, 113209, 119901

--- Comment #4 from Heiko Tietze  ---
Pretty sure that all new Window open with the same size after you restart the
application. For some reason (maybe explained in bug 75644 comment 10) the
decision was made to follow the start center - and go full screen otherwise.
The better - no: the only reasonable approach is to take the OS/DE default.
Another issue with the non-default, maximized window is reported in bug 125543.
See also bug 49665.

Back to topic: new documents do inherit the start screen size but you have to
give it a chance to store the value first. =>NAB 

(And I wouldn't touch these function; it becomes rather worse and module window
change unintentionally every time you resize the start center.)


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=61914
[Bug 61914] [META] Start Center bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113209
[Bug 113209] [META] UI bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=119901
[Bug 119901] [META] Bugs related to maximized window
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 144408] UI: New Document doesn't inherit size from 'source' window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144408

Heiko Tietze  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org,
   ||vstuart.fo...@utsa.edu
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=75
   ||644
   Keywords|needsUXEval |
 Blocks||61914, 113209, 119901

--- Comment #4 from Heiko Tietze  ---
Pretty sure that all new Window open with the same size after you restart the
application. For some reason (maybe explained in bug 75644 comment 10) the
decision was made to follow the start center - and go full screen otherwise.
The better - no: the only reasonable approach is to take the OS/DE default.
Another issue with the non-default, maximized window is reported in bug 125543.
See also bug 49665.

Back to topic: new documents do inherit the start screen size but you have to
give it a chance to store the value first. =>NAB 

(And I wouldn't touch these function; it becomes rather worse and module window
change unintentionally every time you resize the start center.)


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=61914
[Bug 61914] [META] Start Center bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113209
[Bug 113209] [META] UI bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=119901
[Bug 119901] [META] Bugs related to maximized window
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 119901] [META] Bugs related to maximized window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=119901
Bug 119901 depends on bug 39863, which changed state.

Bug 39863 Summary: Writer is not maximized on the first start
https://bugs.documentfoundation.org/show_bug.cgi?id=39863

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 39863] Writer is not maximized on the first start

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=39863

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144155] CALC Row operations over 100 times slower in 7.2 compared to 7.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144155

--- Comment #12 from Timur  ---
Columns are in bug 144205, no point in writing here now it's closed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144215] MAILMERGE: if saved as individual documents - filenames should start from 1 (one), not 0 (zero), also for Print

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144215

NISZ LibreOffice Team  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||libreoff...@nisz.hu
 Status|UNCONFIRMED |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144215] MAILMERGE: if saved as individual documents - filenames should start from 1 (one), not 0 (zero), also for Print

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144215

--- Comment #1 from NISZ LibreOffice Team  ---
Created attachment 174948
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174948=edit
The example document and the result of a former generation in the Save dialog

Confirming with:

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: c7b5e6566d9b24a0a996c739a945004d9aadee2f
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL

Leaving the Generate name from database option turned off asks for a custom
file name, which gets numbered starting from 0 and no underscore between the
entered name and the number.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144416] Default formatting bar not showing on entering textbox in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144416

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #2 from Heiko Tietze  ---
TB was hidden for bug 87676 but should remain context sensitive and show up
when a text box is selected (user complain about jumping UI for example in bug
98434, bug 105723, and likely more). There was no further change to this part
after the mentioned patch. And I don't recall a discussion to not show the text
formatting at all.

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: ca512f301faf42b7d23675ca251b20e0ad67db1b
CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144269] Mouse hover border is disabled if an element is focused

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144269

Henrik Palomäki  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||7552
   Keywords|bibisectRequest |bibisected, bisected
 CC||fit...@ubuntu.com,
   ||henrik.palom...@yandex.com

--- Comment #3 from Henrik Palomäki  ---
I bibisected the bug using the win64-6.4 repo and found:

https://git.libreoffice.org/core/commit/a42bc2e56f935bb3caa22bd3f6ff27720939cb29
Adding Cc: to Adolfo Jayme Barrientos

However, according to the notes in the commit: 
 " *do not highlight when focus is in a different toolbox",
this behaviour may act as intended.

A search found the bug 127552, where this commit appeared the first time.

Currently, I am not sure if this is a bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 127552] Moving the mouse pointer over a button in a toolbar that has keyboard focus on a button causes loss of keyboard focus

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127552

Henrik Palomäki  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||4269

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144249] Deleting 10.000 rows column in a spreadsheet: 15 sec with 4.1| 10 sec up to 300+ sec with 6.2| 130 sec with 7.3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144249

Luboš Luňák  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144249] Deleting 10.000 rows column in a spreadsheet: 15 sec with 4.1| 10 sec up to 300+ sec with 6.2| 130 sec with 7.3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144249

--- Comment #6 from Commit Notification 
 ---
Luboš Luňák committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b4c1bb2f91e9ae47820c289e2c08f640a958cf05

cache FormulaError::NoRef error string (tdf#144249)

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144249] Deleting 10.000 rows column in a spreadsheet: 15 sec with 4.1| 10 sec up to 300+ sec with 6.2| 130 sec with 7.3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144249

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: 2 commits - sc/inc sc/source

[Luboš Luňák (via logerrit)]

 sc/inc/global.hxx  |1 +
 sc/source/core/data/global.cxx |6 --
 sc/source/core/data/table3.cxx |4 ++--
 3 files changed, 7 insertions(+), 4 deletions(-)

New commits:
commit b4c1bb2f91e9ae47820c289e2c08f640a958cf05
Author: Luboš Luňák 
AuthorDate: Thu Sep 9 16:34:08 2021 +0200
Commit: Luboš Luňák 
CommitDate: Fri Sep 10 10:49:58 2021 +0200

cache FormulaError::NoRef error string (tdf#144249)

Those COUNTIF() may call it a huge number of times, and the translation
of the string each time then actually is a noticeable impact. And
ScGlobal already does one-time intialization of objects based
on the locale, so one-time initializing a string there should be fine
too.

Change-Id: I0daeb50ccb43f780d99cf3838cfd1bf790c5f6cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121856
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/sc/inc/global.hxx b/sc/inc/global.hxx
index 50041b37b323..d66801a9e205 100644
--- a/sc/inc/global.hxx
+++ b/sc/inc/global.hxx
@@ -509,6 +509,7 @@ class ScGlobal
 static std::unique_ptr xUserList;
 static SC_DLLPUBLIC const OUString aEmptyOUString;
 static OUString aStrClipDocName;
+static OUString aStrErrorStringNoRef;
 static std::unique_ptr xEmptyBrushItem;
 static std::unique_ptr xButtonBrushItem;
 
diff --git a/sc/source/core/data/global.cxx b/sc/source/core/data/global.cxx
index 3286794b2b88..f1e1ccf6e3f3 100644
--- a/sc/source/core/data/global.cxx
+++ b/sc/source/core/data/global.cxx
@@ -89,6 +89,7 @@ std::atomic<::utl::TransliterationWrapper*> 
ScGlobal::pCaseTransliteration(nullp
 css::uno::Reference< css::i18n::XOrdinalSuffix> ScGlobal::xOrdinalSuffix;
 const OUString  ScGlobal::aEmptyOUString;
 OUStringScGlobal::aStrClipDocName;
+OUStringScGlobal::aStrErrorStringNoRef;
 
 std::unique_ptr ScGlobal::xEmptyBrushItem;
 std::unique_ptr ScGlobal::xButtonBrushItem;
@@ -305,8 +306,8 @@ OUString ScGlobal::GetErrorString(FormulaError nErr)
 switch (nErr)
 {
 case FormulaError::NoRef:
-pErrNumber = STR_NO_REF_TABLE;
-break;
+// tdf#144249 This may get called very extensively, so cached.
+return aStrErrorStringNoRef;
 case FormulaError::NoAddin:
 pErrNumber = STR_NO_ADDIN;
 break;
@@ -452,6 +453,7 @@ void ScGlobal::Init()
 InitAddIns();
 
 aStrClipDocName = ScResId( SCSTR_NONAME ) + "1";
+aStrErrorStringNoRef = ScResId( STR_NO_REF_TABLE );
 
 //  ScDocumentPool::InitVersionMaps() has been called earlier already
 }
commit d0316985db22efd6708dffa173eaabb430f6b9a8
Author: Luboš Luňák 
AuthorDate: Thu Sep 9 16:18:02 2021 +0200
Commit: Luboš Luňák 
CommitDate: Fri Sep 10 10:49:44 2021 +0200

do not intern a temporary cell error string

Interning is way more work than a simple text comparison done once.

Change-Id: If18c478fc62d1fb09ce2141fdb77b46a6bc46c08
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121855
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/sc/source/core/data/table3.cxx b/sc/source/core/data/table3.cxx
index 97d761f2479b..406284e17765 100644
--- a/sc/source/core/data/table3.cxx
+++ b/sc/source/core/data/table3.cxx
@@ -2435,8 +2435,8 @@ public:
 if (rCell.meType == CELLTYPE_FORMULA && 
rCell.mpFormula->GetErrCode() != FormulaError::NONE)
 {
 // Error cell is evaluated as string (for now).
-const svl::SharedString aCellStr = 
mrStrPool.intern(ScGlobal::GetErrorString(rCell.mpFormula->GetErrCode()));
-return compareByStringComparator(rEntry, rItem, , 
nullptr);
+const OUString aCellStr = 
ScGlobal::GetErrorString(rCell.mpFormula->GetErrCode());
+return compareByStringComparator(rEntry, rItem, nullptr, 
);
 }
 else if (rCell.meType == CELLTYPE_STRING)
 {

[Libreoffice-ux-advise] [Bug 144415] Formatting: Indentations or Tab Stops of Outline Levels

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144415

Heiko Tietze  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 144415] Formatting: Indentations or Tab Stops of Outline Levels

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144415

Heiko Tietze  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 144415] Formatting: Indentations or Tab Stops of Outline Levels

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144415

--- Comment #1 from Heiko Tietze  ---
Created attachment 174947
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174947=edit
Screenshot with inconsistent tab position

Cannot open your attached zip file (and prefer images as it can be opened
directly in the browser). From reading the text it's not clear what you expect.
Is it a consistent position of text after the tab from chapter numbers? The
screenshot example shows left the current situation and right a larger tab
stop.

Se also
https://help.libreoffice.org/latest/en-US/text/shared/01/05030300.html?DbPAR=SHARED#bm_id3156027

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 144415] Formatting: Indentations or Tab Stops of Outline Levels

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144415

--- Comment #1 from Heiko Tietze  ---
Created attachment 174947
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174947=edit
Screenshot with inconsistent tab position

Cannot open your attached zip file (and prefer images as it can be opened
directly in the browser). From reading the text it's not clear what you expect.
Is it a consistent position of text after the tab from chapter numbers? The
screenshot example shows left the current situation and right a larger tab
stop.

Se also
https://help.libreoffice.org/latest/en-US/text/shared/01/05030300.html?DbPAR=SHARED#bm_id3156027

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144428] New: The keyboard shortcut + opens the context menu.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144428

Bug ID: 144428
   Summary: The keyboard shortcut  +  opens the
context menu.
   Product: LibreOffice
   Version: 7.2.0.4 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: danila.ikryanni...@gmail.com

Description:
Why it's wrong: The  +  combination can be used in Linux to switch
to a second keyboard layout.
Expected Behavior:  opens a context menu,  +  (if
configured) selects an alternate keyboard layout.
Actual behavior:  opens a context menu,  +  (if configured)
selects an alternate keyboard layout AND the application opens a context menu. 

Steps to Reproduce:
press  +  while editing a document or table (to switch to the
second keyboard layout)

Actual Results:
a context menu appeared 

Expected Results:
a context menu does not open 


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
Version: 7.2.0.4 / LibreOffice Community
Build ID: 9a9c6381e3f7a62afc1329bd359cc48accb6435b
CPU threads: 12; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: ru-RU (ru_RU.UTF-8); UI: ru-RU
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144155] CALC Row operations over 100 times slower in 7.2 compared to 7.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144155

--- Comment #11 from David Lynch  ---
The issue with "Hide row" seems resolved. But there are still performance
issues. The following tests are on attachment 174675 to bug 114205:

Hide row > instantaneous
Show row > instantaneous
Select cell > instantaneous
Enter data in cell > instantaneous
Enter simple formula (=AO1) in cell > instantaneous
Insert column > 10 secs
Fill down BH2:BH3 > 11 secs
Delete data from (a single) cell > 20 secs
Delete simple formula (=AO1) in cell > 10 secs
Select row > 10 secs


Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 96d1240adf946c443fb2c369a1c84e31e259c7a8
CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: en-GB (en_GB); UI: en-GB
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144427] MAILMERGE Save all documents no longer generates all documents if custom From-To values were set

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144427

--- Comment #1 from NISZ LibreOffice Team  ---
Created attachment 174946
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174946=edit
Screenshot of the resulting two instead of three output files of a former run
in the Save dialog

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 102998] [META] Mail merge bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102998

NISZ LibreOffice Team  changed:

   What|Removed |Added

 Depends on||144427


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=144427
[Bug 144427] MAILMERGE Save all documents no longer generates all documents if
custom From-To values were set
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144427] New: MAILMERGE Save all documents no longer generates all documents if custom From-To values were set

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144427

Bug ID: 144427
   Summary: MAILMERGE Save all documents no longer generates all
documents if custom From-To values were set
   Product: LibreOffice
   Version: 7.2.0.4 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: bibisected, bisected, regression
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: libreoff...@nisz.hu
CC: nem...@numbertext.org, varga.bala...@nisz.hu
Blocks: 102998

Created attachment 174945
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174945=edit
Screenshot of the dialog in Writer after setting From and changing back

When creating mail merges it is possible to set the merged document ranges with
the From – To fields.
If you change the values there, then change your mind and select to
save/print/email all documents, the previously set range is still used instead
of generating all documents.

Steps to reproduce:
1. Set up a mail merge document with the attachment 174941 and attachment
174942
2. In the Mail Merge toolbar press the Save Merged Documents button, but it
also happens with the Print merged documents and Send Email Messages buttons
too
3. Under Save As Options, select the From option and set 2
4. Change it back to Save as individual documents
5. Press Save Documents
6. Enter a name in the file save dialog.

Actual results:
Only two documents – contentwise the second and third – are saved, as set under
the From option.

Expected results:
All three documents should be saved.

LibreOffice details:
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: c7b5e6566d9b24a0a996c739a945004d9aadee2f
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL

Additional Information:
This started with:
https://git.libreoffice.org/core/+/ec44f87d5b99a3299322d0b79abc4c6808877865%5E%21

author  Balazs Varga Mon Mar 22 13:34:37
2021 +0100
committer   László NémethWed Mar 31 12:24:22
2021 +0200

tdf#117212 sw mailmerge: merge only the selected range


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102998
[Bug 102998] [META] Mail merge bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144412] Qt5/KF5 flips writing direction on Ctrl+Shift+p

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144412

--- Comment #6 from Caolán McNamara  ---
FWIW there's some older discussion of the ctrl+shift rtl/ltr feature at
https://bugs.documentfoundation.org/show_bug.cgi?id=103158

And the MSOffice equivalent docs of
https://docs.microsoft.com/en-us/archive/blogs/office_global_experience/useful-tricks-and-shortcuts-for-users-around-the-world
also has "Ctrl + the right Shift key changes Text direction to Right-to-Left.
Ctrl + the left Shift key changes Text direction back to Left-to-Right."

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144426] New: Background updates

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144426

Bug ID: 144426
   Summary: Background updates
   Product: LibreOffice
   Version: 7.1.6.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jos...@disroot.org

Description:
Hi all, I don't know if this upgrade has already been requested, I can't find
in the bugs list.

I think that Libreoffice should implement the background updates, and that the
user don't go to the web to download the next version of Libreoffice.

Actually, I find much installations of Libreoffice without update because the
user see the warning but after don't go to download web.

This can lead to security problems, compatibility problems and new features
don't see of the Libreoffice users.

Steps to Reproduce:
1. Install Libreoffice, for example, 7.0.4 version
2. Go to, "search updates" or wait to the update warning.
3. Libreoffice will go to the official web, and the user should download
manually the new version.

Actual Results:
Actually, Libreoffice go to the official web, and the user should download
manually the new version

Expected Results:
If the user see the warning, but don't go to the web to download the last
version, Libreoffice will isn't updated.


Reproducible: Always


User Profile Reset: No



Additional Info:
Libreoffice should download the new version automatically and proceed to update
the previous version installed on the computer.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-4+backports' - sw/source

[Samuel Mehrbrodt (via logerrit)]

 sw/source/uibase/shells/drwbassh.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit c7df28f23d7a6717b525dd2fdd87e3381107e2f1
Author: Samuel Mehrbrodt 
AuthorDate: Wed Aug 25 14:14:51 2021 +0200
Commit: Thorsten Behrens 
CommitDate: Fri Sep 10 10:33:23 2021 +0200

Fix crash when drawing shape

Fallout from 75cd2b0fa71c73ae815b80d8e42328024ea63555

Change-Id: I455519126d11bee1b809f9fd9476b2fdd0f1a524
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121034
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt 
(cherry picked from commit 2694a666b62701a8c0e546151c41f9c30aba00da)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121053
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/sw/source/uibase/shells/drwbassh.cxx 
b/sw/source/uibase/shells/drwbassh.cxx
index 924877a876a5..6f73e76ec91c 100644
--- a/sw/source/uibase/shells/drwbassh.cxx
+++ b/sw/source/uibase/shells/drwbassh.cxx
@@ -798,7 +798,10 @@ void SwDrawBaseShell::GetState(SfxItemSet& rSet)
 case SID_COPY_HYPERLINK_LOCATION:
 {
 if (pSdrView->GetMarkedObjectCount() != 1)
+{
 rSet.DisableItem(nWhich);
+break;
+}
 
 const SdrMarkList& rMarkList = pSdrView->GetMarkedObjectList();
 SdrObject* pObj = rMarkList.GetMark(0)->GetMarkedSdrObj();

[Libreoffice-bugs] [Bug 144352] "Email merged document" dialog has overlapping elements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144352

NISZ LibreOffice Team  changed:

   What|Removed |Added

 CC||libreoff...@nisz.hu,
   ||nem...@numbertext.org,
   ||varga.bala...@nisz.hu
Version|7.2.1.1 rc  |7.1.0.3 release

--- Comment #4 from NISZ LibreOffice Team  ---
The bibisected commit went into 7.1, changing version.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144402] FILESAVE DOCX: some images are duplicated after saving and reopening file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144402

Timur  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
 OS|Windows (All)   |All
 CC||michael.st...@allotropia.de

--- Comment #2 from Timur  ---
commit 28edff60383ec64b100b3f9cec31c9e7fad10855
Date:   Fri Mar 12 2021 
source sha:e79c637f291d552bfe8f32ccfc23300c67f51fcc
pre sha:db05fd646fce8f41a1056761ccf6bc716cda3b77

author  Michael Stahl  2021-03-10 11:26:07
+0100
committer   Caolán McNamara 2021-03-12 16:14:09
+0100
sw: DOCX export: put fly before fieldmark start into its own run

CC: Michael. Please see.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144425] UI In Email merged document dialog it’s possible to select 0 as range

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144425

--- Comment #4 from Commit Notification 
 ---
Gabor Kelemen committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e85aaaecb5479660aa0cf600564ee3caa470aa3d

tdf#144425 Set sane lower bounds (1) for MM e-mail output ranges

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144425] UI In Email merged document dialog it’s possible to select 0 as range

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144425

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/uiconfig

[Gabor Kelemen (via logerrit)]

 sw/uiconfig/swriter/ui/mmresultemaildialog.ui |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit e85aaaecb5479660aa0cf600564ee3caa470aa3d
Author: Gabor Kelemen 
AuthorDate: Thu Sep 9 22:29:53 2021 +0200
Commit: László Németh 
CommitDate: Fri Sep 10 10:14:59 2021 +0200

tdf#144425 Set sane lower bounds (1) for MM e-mail output ranges

Lower bounds were forgotten to be set in weld commit
f1ca64800074530d95e507f93c764a687310b9eb
for the new GtkAdjustments of the GtkSpinButtons

This caused no visible differences until commit
d9fa826769cd570814f3556d53493a78d2869873
when new default values (0) were added for VCL FormattedFields

This made it possible to email MM results on non-GTK vclpugs starting
from 0th mail if custom range is chosen, which causes an instant hang
in the sending process since there is no -1st generated result.
The default Send all option has still worked after this.

Then commit ec44f87d5b99a3299322d0b79abc4c6808877865
started to use the default GtkSpinButton values for default
range of result generation, breaking the Send all option as well.

Change-Id: I2a9f2b0954045700f947f342e5928ef75ce23aed
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121865
Reviewed-by: László Németh 
Tested-by: László Németh 

diff --git a/sw/uiconfig/swriter/ui/mmresultemaildialog.ui 
b/sw/uiconfig/swriter/ui/mmresultemaildialog.ui
index 1f71ebcbd975..7074ca79860d 100644
--- a/sw/uiconfig/swriter/ui/mmresultemaildialog.ui
+++ b/sw/uiconfig/swriter/ui/mmresultemaildialog.ui
@@ -3,11 +3,13 @@
 
   
   
+1
 16000
 1
 10
   
   
+1
 16000
 1
 10

[Libreoffice-bugs] [Bug 144425] UI In Email merged document dialog it’s possible to select 0 as range

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144425

Michael Weghorn  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||9072

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139072] Mailmerge to email: content mismatched with email address after first email

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139072

Michael Weghorn  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||4425

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/qa vcl/source

[Chris Sherlock (via logerrit)]

 vcl/qa/cppunit/outdev.cxx |   21 +
 vcl/source/outdev/outdevstate.cxx |   11 ---
 vcl/source/outdev/text.cxx|   11 +++
 3 files changed, 32 insertions(+), 11 deletions(-)

New commits:
commit ecb7289fc3091fbbb8a65f43fc649e57a9870ac9
Author: Chris Sherlock 
AuthorDate: Wed Aug 25 18:45:50 2021 +1000
Commit: Noel Grandin 
CommitDate: Fri Sep 10 10:07:33 2021 +0200

vcl: move OutputDevice::SetDigitLanguage() to text.cxx

Ultimately I hope to reduce outdevstate.cxx to only have push(), pop()
and clearstack(), then rename outdevstate.cxx to stack.cxx. Eventually,
the plan is to separate metafile processing from rendering.

Add unit test for SetDigitLanguage() and GetDigitLanguage().

Change-Id: I138d08c7d79c66d296b4c96eff644a40a379c6be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121023
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/vcl/qa/cppunit/outdev.cxx b/vcl/qa/cppunit/outdev.cxx
index 40559ef09172..ddf3344244bf 100644
--- a/vcl/qa/cppunit/outdev.cxx
+++ b/vcl/qa/cppunit/outdev.cxx
@@ -61,6 +61,7 @@ public:
 void testAntialias();
 void testDrawMode();
 void testLayoutMode();
+void testDigitLanguage();
 void testSystemTextColor();
 void testShouldDrawWavePixelAsRect();
 void testGetWaveLineSize();
@@ -98,6 +99,7 @@ public:
 CPPUNIT_TEST(testAntialias);
 CPPUNIT_TEST(testDrawMode);
 CPPUNIT_TEST(testLayoutMode);
+CPPUNIT_TEST(testDigitLanguage);
 CPPUNIT_TEST(testSystemTextColor);
 CPPUNIT_TEST(testShouldDrawWavePixelAsRect);
 CPPUNIT_TEST(testGetWaveLineSize);
@@ -848,6 +850,25 @@ void VclOutdevTest::testLayoutMode()
 CPPUNIT_ASSERT_EQUAL(ComplexTextLayoutFlags::BiDiRtl, 
pLayoutModeAction->GetLayoutMode());
 }
 
+void VclOutdevTest::testDigitLanguage()
+{
+ScopedVclPtrInstance pVDev;
+
+GDIMetaFile aMtf;
+aMtf.Record(pVDev.get());
+
+CPPUNIT_ASSERT_EQUAL(LANGUAGE_SYSTEM, pVDev->GetDigitLanguage());
+
+pVDev->SetDigitLanguage(LANGUAGE_GERMAN);
+
+CPPUNIT_ASSERT_EQUAL(LANGUAGE_GERMAN, pVDev->GetDigitLanguage());
+
+MetaAction* pAction = aMtf.GetAction(0);
+CPPUNIT_ASSERT_EQUAL(MetaActionType::TEXTLANGUAGE, pAction->GetType());
+auto pTextLanguageAction = static_cast(pAction);
+CPPUNIT_ASSERT_EQUAL(LANGUAGE_GERMAN, 
pTextLanguageAction->GetTextLanguage());
+}
+
 void VclOutdevTest::testSystemTextColor()
 {
 {
diff --git a/vcl/source/outdev/outdevstate.cxx 
b/vcl/source/outdev/outdevstate.cxx
index 13062ca91685..ee8eddf07fb1 100644
--- a/vcl/source/outdev/outdevstate.cxx
+++ b/vcl/source/outdev/outdevstate.cxx
@@ -198,15 +198,4 @@ void OutputDevice::ClearStack()
 Pop();
 }
 
-void OutputDevice::SetDigitLanguage( LanguageType eTextLanguage )
-{
-if( mpMetaFile )
-mpMetaFile->AddAction( new MetaTextLanguageAction( eTextLanguage ) );
-
-meTextLanguage = eTextLanguage;
-
-if( mpAlphaVDev )
-mpAlphaVDev->SetDigitLanguage( eTextLanguage );
-}
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/source/outdev/text.cxx b/vcl/source/outdev/text.cxx
index 1d8164da09be..f1aa776629eb 100644
--- a/vcl/source/outdev/text.cxx
+++ b/vcl/source/outdev/text.cxx
@@ -63,6 +63,17 @@ void OutputDevice::SetLayoutMode( ComplexTextLayoutFlags 
nTextLayoutMode )
 mpAlphaVDev->SetLayoutMode( nTextLayoutMode );
 }
 
+void OutputDevice::SetDigitLanguage( LanguageType eTextLanguage )
+{
+if( mpMetaFile )
+mpMetaFile->AddAction( new MetaTextLanguageAction( eTextLanguage ) );
+
+meTextLanguage = eTextLanguage;
+
+if( mpAlphaVDev )
+mpAlphaVDev->SetDigitLanguage( eTextLanguage );
+}
+
 ImplMultiTextLineInfo::ImplMultiTextLineInfo()
 {
 }

[Libreoffice-commits] core.git: include/vcl vcl/qa vcl/source

[Chris Sherlock (via logerrit)]

 include/vcl/outdev.hxx|2 +-
 vcl/qa/cppunit/outdev.cxx |   25 +++--
 vcl/source/outdev/outdevstate.cxx |   11 ---
 vcl/source/outdev/text.cxx|   11 +++
 4 files changed, 35 insertions(+), 14 deletions(-)

New commits:
commit 4d1d485544ea947b71534fd96ba520cd6e1c721b
Author: Chris Sherlock 
AuthorDate: Wed Aug 25 18:29:48 2021 +1000
Commit: Noel Grandin 
CommitDate: Fri Sep 10 10:06:36 2021 +0200

vcl: move SetLayoutMode() to text.cxx

Ultimately I hope to reduce outdevstate.cxx to only have push(), pop()
and clearstack(), then rename outdevstate.cxx to stack.cxx. Eventually,
the plan is to separate metafile processing from rendering.

Also add a unit test for SetLayoutMode() and GetLayoutMode()

Change-Id: I92cada7bf3d57ca8b84e04308c74428a1a19e775
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121022
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx
index 8fa546b20b60..2839e5c98da5 100644
--- a/include/vcl/outdev.hxx
+++ b/include/vcl/outdev.hxx
@@ -483,7 +483,7 @@ public:
 DrawModeFlags   GetDrawMode() const { return mnDrawMode; }
 
 voidSetLayoutMode( ComplexTextLayoutFlags 
nTextLayoutMode );
-ComplexTextLayoutFlags   GetLayoutMode() const { return 
mnTextLayoutMode; }
+ComplexTextLayoutFlags  GetLayoutMode() const { return 
mnTextLayoutMode; }
 
 voidSetDigitLanguage( LanguageType );
 LanguageTypeGetDigitLanguage() const { return 
meTextLanguage; }
diff --git a/vcl/qa/cppunit/outdev.cxx b/vcl/qa/cppunit/outdev.cxx
index f7a50b3bb5d2..40559ef09172 100644
--- a/vcl/qa/cppunit/outdev.cxx
+++ b/vcl/qa/cppunit/outdev.cxx
@@ -58,8 +58,9 @@ public:
 void testRefPoint();
 void testRasterOp();
 void testOutputFlag();
-void testDrawMode();
 void testAntialias();
+void testDrawMode();
+void testLayoutMode();
 void testSystemTextColor();
 void testShouldDrawWavePixelAsRect();
 void testGetWaveLineSize();
@@ -93,9 +94,10 @@ public:
 CPPUNIT_TEST(testDefaultRefPoint);
 CPPUNIT_TEST(testRefPoint);
 CPPUNIT_TEST(testRasterOp);
+CPPUNIT_TEST(testOutputFlag);
 CPPUNIT_TEST(testAntialias);
 CPPUNIT_TEST(testDrawMode);
-CPPUNIT_TEST(testOutputFlag);
+CPPUNIT_TEST(testLayoutMode);
 CPPUNIT_TEST(testSystemTextColor);
 CPPUNIT_TEST(testShouldDrawWavePixelAsRect);
 CPPUNIT_TEST(testGetWaveLineSize);
@@ -827,6 +829,25 @@ void VclOutdevTest::testDrawMode()
 CPPUNIT_ASSERT_EQUAL(DrawModeFlags::BlackLine, pVDev->GetDrawMode());
 }
 
+void VclOutdevTest::testLayoutMode()
+{
+ScopedVclPtrInstance pVDev;
+
+GDIMetaFile aMtf;
+aMtf.Record(pVDev.get());
+
+CPPUNIT_ASSERT_EQUAL(ComplexTextLayoutFlags::Default, 
pVDev->GetLayoutMode());
+
+pVDev->SetLayoutMode(ComplexTextLayoutFlags::BiDiRtl);
+
+CPPUNIT_ASSERT_EQUAL(ComplexTextLayoutFlags::BiDiRtl, 
pVDev->GetLayoutMode());
+
+MetaAction* pAction = aMtf.GetAction(0);
+CPPUNIT_ASSERT_EQUAL(MetaActionType::LAYOUTMODE, pAction->GetType());
+auto pLayoutModeAction = static_cast(pAction);
+CPPUNIT_ASSERT_EQUAL(ComplexTextLayoutFlags::BiDiRtl, 
pLayoutModeAction->GetLayoutMode());
+}
+
 void VclOutdevTest::testSystemTextColor()
 {
 {
diff --git a/vcl/source/outdev/outdevstate.cxx 
b/vcl/source/outdev/outdevstate.cxx
index 3d788019854c..13062ca91685 100644
--- a/vcl/source/outdev/outdevstate.cxx
+++ b/vcl/source/outdev/outdevstate.cxx
@@ -198,17 +198,6 @@ void OutputDevice::ClearStack()
 Pop();
 }
 
-void OutputDevice::SetLayoutMode( ComplexTextLayoutFlags nTextLayoutMode )
-{
-if( mpMetaFile )
-mpMetaFile->AddAction( new MetaLayoutModeAction( nTextLayoutMode ) );
-
-mnTextLayoutMode = nTextLayoutMode;
-
-if( mpAlphaVDev )
-mpAlphaVDev->SetLayoutMode( nTextLayoutMode );
-}
-
 void OutputDevice::SetDigitLanguage( LanguageType eTextLanguage )
 {
 if( mpMetaFile )
diff --git a/vcl/source/outdev/text.cxx b/vcl/source/outdev/text.cxx
index 801615401fcd..1d8164da09be 100644
--- a/vcl/source/outdev/text.cxx
+++ b/vcl/source/outdev/text.cxx
@@ -52,6 +52,17 @@
 
 #define TEXT_DRAW_ELLIPSIS  (DrawTextFlags::EndEllipsis | 
DrawTextFlags::PathEllipsis | DrawTextFlags::NewsEllipsis)
 
+void OutputDevice::SetLayoutMode( ComplexTextLayoutFlags nTextLayoutMode )
+{
+if( mpMetaFile )
+mpMetaFile->AddAction( new MetaLayoutModeAction( nTextLayoutMode ) );
+
+mnTextLayoutMode = nTextLayoutMode;
+
+if( mpAlphaVDev )
+mpAlphaVDev->SetLayoutMode( nTextLayoutMode );
+}
+
 ImplMultiTextLineInfo::ImplMultiTextLineInfo()
 {
 }

[Libreoffice-commits] core.git: Branch 'distro/vector/vector-7.0' - editeng/source include/editeng sw/source xmloff/qa

[Miklos Vajna (via logerrit)]

 editeng/source/items/textitem.cxx |   48 ++
 include/editeng/fontitem.hxx  |1 
 sw/source/filter/xml/xmlfonte.cxx |   18 
 xmloff/qa/unit/style.cxx  |   53 +-
 4 files changed, 108 insertions(+), 12 deletions(-)

New commits:
commit 610374f668e2239234f11766fb272b242df1a2ab
Author: Miklos Vajna 
AuthorDate: Thu Sep 9 13:04:01 2021 +0200
Commit: Miklos Vajna 
CommitDate: Fri Sep 10 10:02:30 2021 +0200

ODT export: order  elements inside 

This builds on top of commit 92471550b8c43d8ff0cef8b414884d697edf9e63
(ODF export: sort  elements based on the style:name
attribute, 2021-03-11), the additional problem was that the style:name
attribute already has number suffixes to have unique names for fonts
where the style name would match.

This means that even if we sort the container right before writing the
elements, which font gets the number suffix depends on the insert order.

Fix this by additionally sorting the font items before insertion, given
that a single call-site does all the insertion, at least for Writer
documents. This is required as SfxItemPool::GetItemSurrogates() exposes
a container which is based on SfxPoolItemArray_Impl, which uses an
o3tl::sorted_vector<> of pointers, so effectively unsorted, the order
depends on the pointer address of the font items.

(cherry picked from commit 7a8bb65e1b8dc7fdd7f89c8c546e71e4208da574)

Change-Id: I46569b40796243f7f95b92870504c2023b2ce943

diff --git a/editeng/source/items/textitem.cxx 
b/editeng/source/items/textitem.cxx
index 2e2cf4fe7604..e6817adb9a8d 100644
--- a/editeng/source/items/textitem.cxx
+++ b/editeng/source/items/textitem.cxx
@@ -153,6 +153,24 @@ bool SvxFontListItem::GetPresentation
 
 // class SvxFontItem -
 
+namespace
+{
+sal_Int32 CompareTo(sal_Int32 nA, sal_Int32 nB)
+{
+if (nA < nB)
+{
+return -1;
+}
+
+if (nA > nB)
+{
+return 1;
+}
+
+return 0;
+}
+}
+
 SvxFontItem::SvxFontItem( const sal_uInt16 nId ) :
 SfxPoolItem( nId )
 {
@@ -290,6 +308,36 @@ bool SvxFontItem::operator==( const SfxPoolItem& rAttr ) 
const
 return bRet;
 }
 
+bool SvxFontItem::operator<(const SfxPoolItem& rCmp) const
+{
+const auto& rOther = static_cast(rCmp);
+sal_Int32 nRet = GetFamilyName().compareTo(rOther.GetFamilyName());
+if (nRet != 0)
+{
+return nRet < 0;
+}
+
+nRet = GetStyleName().compareTo(rOther.GetStyleName());
+if (nRet != 0)
+{
+return nRet < 0;
+}
+
+nRet = CompareTo(GetFamily(), rOther.GetFamily());
+if (nRet != 0)
+{
+return nRet < 0;
+}
+
+nRet = CompareTo(GetPitch(), rOther.GetPitch());
+if (nRet != 0)
+{
+return nRet < 0;
+}
+
+return GetCharSet() < rOther.GetCharSet();
+}
+
 SvxFontItem* SvxFontItem::Clone( SfxItemPool * ) const
 {
 return new SvxFontItem( *this );
diff --git a/include/editeng/fontitem.hxx b/include/editeng/fontitem.hxx
index 9a73a051f79e..2ccaade20121 100644
--- a/include/editeng/fontitem.hxx
+++ b/include/editeng/fontitem.hxx
@@ -46,6 +46,7 @@ public:
 
 // "pure virtual Methods" from SfxPoolItem
 virtual bool operator==(const SfxPoolItem& rItem) const override;
+bool operator<(const SfxPoolItem& rCmp) const override;
 virtual SvxFontItem* Clone(SfxItemPool *pPool = nullptr) const override;
 virtual bool QueryValue(css::uno::Any& rVal, sal_uInt8 nMemberId = 0) 
const override;
 virtual bool PutValue(const css::uno::Any& rVal, sal_uInt8 nMemberId) 
override;
diff --git a/sw/source/filter/xml/xmlfonte.cxx 
b/sw/source/filter/xml/xmlfonte.cxx
index 9b90f94fd419..79207700c204 100644
--- a/sw/source/filter/xml/xmlfonte.cxx
+++ b/sw/source/filter/xml/xmlfonte.cxx
@@ -46,21 +46,27 @@ 
SwXMLFontAutoStylePool_Impl::SwXMLFontAutoStylePool_Impl(SwXMLExport& _rExport,
   RES_CHRATR_CTL_FONT };
 
 const SfxItemPool& rPool = _rExport.getDoc()->GetAttrPool();
+std::vector aFonts;
 for(sal_uInt16 nWhichId : aWhichIds)
 {
 const SvxFontItem& rFont =
 static_cast(rPool.GetDefaultItem( nWhichId ));
-Add( rFont.GetFamilyName(), rFont.GetStyleName(),
- rFont.GetFamily(), rFont.GetPitch(),
- rFont.GetCharSet() );
+aFonts.push_back();
 for (const SfxPoolItem* pItem : rPool.GetItemSurrogates(nWhichId))
 {
 auto pFont = static_cast(pItem);
-Add( pFont->GetFamilyName(), pFont->GetStyleName(),
- pFont->GetFamily(), pFont->GetPitch(),
- pFont->GetCharSet() );
+aFonts.push_back(pFont);
 }
 }
+
+std::sort(aFonts.begin(), aFonts.end(),
+  [](const SvxFontItem* pA, const SvxFontItem* pB) -> bool { 
return *pA < *pB; });
+   

[Libreoffice-bugs] [Bug 144425] UI In Email merged document dialog it’s possible to select 0 as range

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144425

--- Comment #3 from NISZ LibreOffice Team  ---
Created attachment 174944
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174944=edit
Screenshot of the hanging send process in Writer.

Note that it tries to send 4 mails with only 3 records in the data source.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144425] UI In Email merged document dialog it’s possible to select 0 as range

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144425

--- Comment #2 from NISZ LibreOffice Team  ---
Created attachment 174943
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174943=edit
Screenshot of the problematic minimum value in Writer

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 144415] Formatting: Indentations or Tab Stops of Outline Levels

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144415

Timur  changed:

   What|Removed |Added

   Priority|medium  |low
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||6690
   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 126690] Bad default settings for nested/outline numbering indentations

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126690

Timur  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||4415

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144415] Formatting: Indentations or Tab Stops of Outline Levels

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144415

Timur  changed:

   What|Removed |Added

   Priority|medium  |low
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||6690
   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144425] UI In Email merged document dialog it’s possible to select 0 as range

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144425

--- Comment #1 from NISZ LibreOffice Team  ---
Created attachment 174942
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174942=edit
Example data source from Calc

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 102998] [META] Mail merge bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102998

NISZ LibreOffice Team  changed:

   What|Removed |Added

 Depends on||144425


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=144425
[Bug 144425] UI In Email merged document dialog it’s possible to select 0 as
range
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144425] New: UI In Email merged document dialog it’s possible to select 0 as range

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144425

Bug ID: 144425
   Summary: UI In Email merged document dialog it’s possible to
select 0 as range
   Product: LibreOffice
   Version: 7.2.0.4 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: bibisected, bisected, regression
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: libreoff...@nisz.hu
CC: nem...@numbertext.org, varga.bala...@nisz.hu
Blocks: 102998

Created attachment 174941
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174941=edit
Example mail merge document from Writer 7.3 master

In the Email merged document dialog it is possible to set the mails to be sent
as From or to 0th record, which causes a hang during the send process.

Steps to reproduce:
1. Set up a mail merge document with the attached files
2. In the Mail Merge toolbar press the Send Email Messages button
3. In the Email merged document dialog observe that the default value of
the From field is 0 and the To field can be set to 0 as well

Actual results:
If you try to send the merged mails with the Send all documents option or with
the From option having 0 value, the send process will hang with sending mail 0
from 4. The documents (3 for the 3 records) are merged for sending correctly.

Expected results:
The mails should be sent correctly.

LibreOffice details:
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: c7b5e6566d9b24a0a996c739a945004d9aadee2f
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL


Additional Information:
This regressed into unusability in several steps:
In 7.2 the default Send all documents option started to cause this hang after 

commit  ec44f87d5b99a3299322d0b79abc4c6808877865[log]
author  Balazs Varga Mon Mar 22 13:34:37
2021 +0100
committer   László NémethWed Mar 31 12:24:22
2021 +0200

tdf#117212 sw mailmerge: merge only the selected range

In 7.1 the default value of the From field became 0 instead of 1 on non-GTK3
vclplugs with:

author  Caolán McNamara 2020-05-26 19:43:12 +0100
committer   Caolán McNamara 2020-05-27 17:42:19
+0200
commit  d9fa826769cd570814f3556d53493a78d2869873 (patch)

tdf#133396 FormattedField comes with differrent defaults than GtkSpinButton

Before that in 6.2 the From and to boxes became spinboxes, thus making it a bit
easier to set 0, but it was possible to enter 0 in 6.1 and before too.
Note: the other two dialogs, Print merged document and Save merged document do
not allow setting 0 in the From and To spinboxes since they got welded in 6.2.

author  Caolán McNamara 2018-10-18 09:52:28 +0100
committer   Caolán McNamara 2018-10-18 15:09:12
+0200
commit  f1ca64800074530d95e507f93c764a687310b9eb (patch)

weld SwMMResultEmailDialog


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102998
[Bug 102998] [META] Mail merge bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144412] Qt5/KF5 flips writing direction on Ctrl+Shift+p

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144412

--- Comment #5 from Michael Weghorn  ---
FWIW, some notes on trying to understand what's happening (without saying
whether or not it should stay that way...):

The relevant code in SwEditWin::Command responsible for changing writing
direction was added in commit

commit cf308f6beb1ca7d7d5e209bfc25d3094a7acd836
Author: Oliver Specht 
Date:   Wed Nov 27 08:12:37 2002 +

#105224# support COMMAND_MODKEYCHANGE to change writing direction


Unfortunately, #105224# refers to the StarDivision bug tracker.

However, looking at that commit, it looks a bit like it may be supposed to be a
feature to switch to RTL by pressing Ctrl+Right_Shift and to LTR by pressing
Ctrl+Left_Shift, at least when no other keys are pressed in addition?

For gtk3, I actually only get the switch when not pressing another key in
addition (i.e. the Ctrl+Shift_Right+P case described here does not trigger the
change in writing direction), while it's different for kf5.

With the change from comment 2, switching between RTL and LTR also no longer
happens for kf5 when no other key is pressed in addition.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103864] macOS: high CPU when scrolling around

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103864

--- Comment #12 from steve  ---
macOS 11.5.2
LO 7.2.0.4

1. open calc
2. scroll up / down or left / right continuously with trackpad
3. CPU goes to 96%

Fans do not spin up, but CPU usage at that level probably not expected.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 42905] Wizard table: Remove autovalue from step2 which doesn't work since there's already autovalue in step3 which works.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=42905

Alex Thurgood  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||8057

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108057] Primary key should default to AutoValue=Yes when type is integer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108057

Alex Thurgood  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=42
   ||905

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: include/vcl vcl/qa vcl/source

[Chris Sherlock (via logerrit)]

 include/vcl/outdev.hxx|2 +-
 vcl/qa/cppunit/outdev.cxx |   13 +
 vcl/source/outdev/outdev.cxx  |8 
 vcl/source/outdev/outdevstate.cxx |   10 --
 4 files changed, 22 insertions(+), 11 deletions(-)

New commits:
commit 9db1e85a8da3952cefef552853753342d7147b98
Author: Chris Sherlock 
AuthorDate: Wed Aug 25 18:16:38 2021 +1000
Commit: Mike Kaganski 
CommitDate: Fri Sep 10 09:52:21 2021 +0200

vcl: move OutputDevice drawmode functions to outdev.cxx

Ultimately I hope to reduce outdevstate.cxx to only have push(), pop()
and clearstack(), then rename outdevstate.cxx to stack.cxx. Eventually,
the plan is to separate metafile processing from rendering.

Add unit test for GetDrawMode() and SetDrawMode().

Change-Id: I63948e7e4c332c786487c18c52faa60893f672a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121021
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx
index a80b49c2239b..8fa546b20b60 100644
--- a/include/vcl/outdev.hxx
+++ b/include/vcl/outdev.hxx
@@ -480,7 +480,7 @@ public:
 AntialiasingFlags   GetAntialiasing() const { return 
mnAntialiasing; }
 
 voidSetDrawMode( DrawModeFlags nDrawMode );
-DrawModeFlags   GetDrawMode() const;
+DrawModeFlags   GetDrawMode() const { return mnDrawMode; }
 
 voidSetLayoutMode( ComplexTextLayoutFlags 
nTextLayoutMode );
 ComplexTextLayoutFlags   GetLayoutMode() const { return 
mnTextLayoutMode; }
diff --git a/vcl/qa/cppunit/outdev.cxx b/vcl/qa/cppunit/outdev.cxx
index ee1dc6a37b8d..f7a50b3bb5d2 100644
--- a/vcl/qa/cppunit/outdev.cxx
+++ b/vcl/qa/cppunit/outdev.cxx
@@ -58,6 +58,7 @@ public:
 void testRefPoint();
 void testRasterOp();
 void testOutputFlag();
+void testDrawMode();
 void testAntialias();
 void testSystemTextColor();
 void testShouldDrawWavePixelAsRect();
@@ -93,6 +94,7 @@ public:
 CPPUNIT_TEST(testRefPoint);
 CPPUNIT_TEST(testRasterOp);
 CPPUNIT_TEST(testAntialias);
+CPPUNIT_TEST(testDrawMode);
 CPPUNIT_TEST(testOutputFlag);
 CPPUNIT_TEST(testSystemTextColor);
 CPPUNIT_TEST(testShouldDrawWavePixelAsRect);
@@ -814,6 +816,17 @@ void VclOutdevTest::testAntialias()
 CPPUNIT_ASSERT_EQUAL(AntialiasingFlags::Enable, pVDev->GetAntialiasing());
 }
 
+void VclOutdevTest::testDrawMode()
+{
+ScopedVclPtrInstance pVDev;
+
+CPPUNIT_ASSERT_EQUAL(DrawModeFlags::Default, pVDev->GetDrawMode());
+
+pVDev->SetDrawMode(DrawModeFlags::BlackLine);
+
+CPPUNIT_ASSERT_EQUAL(DrawModeFlags::BlackLine, pVDev->GetDrawMode());
+}
+
 void VclOutdevTest::testSystemTextColor()
 {
 {
diff --git a/vcl/source/outdev/outdev.cxx b/vcl/source/outdev/outdev.cxx
index 8d1f9504609f..f3d9c48b752d 100644
--- a/vcl/source/outdev/outdev.cxx
+++ b/vcl/source/outdev/outdev.cxx
@@ -356,6 +356,14 @@ void OutputDevice::SetAntialiasing( AntialiasingFlags 
nMode )
 mpAlphaVDev->SetAntialiasing( nMode );
 }
 
+void OutputDevice::SetDrawMode(DrawModeFlags nDrawMode)
+{
+mnDrawMode = nDrawMode;
+
+if (mpAlphaVDev)
+mpAlphaVDev->SetDrawMode(nDrawMode);
+}
+
 sal_uInt16 OutputDevice::GetBitCount() const
 {
 // we need a graphics instance
diff --git a/vcl/source/outdev/outdevstate.cxx 
b/vcl/source/outdev/outdevstate.cxx
index 8832c09e0f9a..3d788019854c 100644
--- a/vcl/source/outdev/outdevstate.cxx
+++ b/vcl/source/outdev/outdevstate.cxx
@@ -198,16 +198,6 @@ void OutputDevice::ClearStack()
 Pop();
 }
 
-DrawModeFlags OutputDevice::GetDrawMode() const { return mnDrawMode; }
-
-void OutputDevice::SetDrawMode(DrawModeFlags nDrawMode)
-{
-mnDrawMode = nDrawMode;
-
-if (mpAlphaVDev)
-mpAlphaVDev->SetDrawMode(nDrawMode);
-}
-
 void OutputDevice::SetLayoutMode( ComplexTextLayoutFlags nTextLayoutMode )
 {
 if( mpMetaFile )

[Libreoffice-bugs] [Bug 144402] FILESAVE DOCX: some images are duplicated after saving and reopening file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144402

Timur  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
   Keywords||bibisectRequest, regression

--- Comment #1 from Timur  ---
DOCX is LO created, but that shouldn't be a root of the problem. MSO saves it
fine.
No repro 7.0, repro 7.3+. So regression in 7.1.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: connectivity/source

[Mike Kaganski (via logerrit)]

 connectivity/source/drivers/firebird/Clob.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit af78873e2000e604c9de78280cbcfbfcf4c7e99b
Author: Mike Kaganski 
AuthorDate: Fri Sep 10 08:29:21 2021 +0200
Commit: Mike Kaganski 
CommitDate: Fri Sep 10 09:50:56 2021 +0200

A copy-paste message text error

Change-Id: I3d6f7a968fc5fca112087212ab7730f654534dfc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121876
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/connectivity/source/drivers/firebird/Clob.cxx 
b/connectivity/source/drivers/firebird/Clob.cxx
index 47e3e9dc9b3b..5825a5f2c871 100644
--- a/connectivity/source/drivers/firebird/Clob.cxx
+++ b/connectivity/source/drivers/firebird/Clob.cxx
@@ -140,7 +140,7 @@ sal_Int64 SAL_CALL Clob::position(const OUString& 
/*rPattern*/,
 sal_Int64 SAL_CALL Clob::positionOfClob(const Reference & /*rPattern*/,
  sal_Int64 /*aStart*/)
 {
-::dbtools::throwFeatureNotImplementedSQLException("Blob::positionOfBlob", 
*this);
+::dbtools::throwFeatureNotImplementedSQLException("Clob::positionOfClob", 
*this);
 return 0;
 }
 

[Libreoffice-bugs] [Bug 144382] LO BASE - table automatic ID not working

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144382

Alex Thurgood  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #1 from Alex Thurgood  ---
@Pierlu : please indicate which type of database you are using (embedded
Hsqldb, embedded Firebird) or some other DB engine backend ?

You don't say how you are creating your table:
- via the Table creation wizard ?
- via the LO Table creation UI ?

For what it is worth, what you are reporting sounds like a DUPLICATE of bug
42905

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - connectivity/source

[Mike Kaganski (via logerrit)]

 connectivity/source/drivers/firebird/Blob.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit e7e38c23d0a91e80535893ee88e3f0062b7d522c
Author: Mike Kaganski 
AuthorDate: Fri Sep 10 00:49:49 2021 +0200
Commit: Xisco Fauli 
CommitDate: Fri Sep 10 09:49:05 2021 +0200

tdf#120129: don't forget to update buffer size to actual length

Otherwise extra bytes get written to the resulting string from the
too long buffer.

Change-Id: Iccde16b8002f214df6f86f484f288ec464c6b674
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121872
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 
(cherry picked from commit 541ddf4580cac8c3f9590be26a487f5fc8e2553c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121875
Reviewed-by: Xisco Fauli 

diff --git a/connectivity/source/drivers/firebird/Blob.cxx 
b/connectivity/source/drivers/firebird/Blob.cxx
index 8ed9fc4a8ac7..854db5bb0df0 100644
--- a/connectivity/source/drivers/firebird/Blob.cxx
+++ b/connectivity/source/drivers/firebird/Blob.cxx
@@ -144,6 +144,9 @@ bool Blob::readOneSegment(uno::Sequence< sal_Int8 >& 
rDataOut)
 OUString sError(StatusVectorToString(m_statusVector, 
"isc_get_segment"));
 throw IOException(sError, *this);
 }
+
+if (rDataOut.getLength() > nActualSize)
+rDataOut.realloc(nActualSize);
 m_nBlobPosition += nActualSize;
 return aRet == isc_segstr_eof;  // last segment read
 }

[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - connectivity/source

[Mike Kaganski (via logerrit)]

 connectivity/source/drivers/firebird/Blob.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit c3cdc29900574fefe4dc8b90e2941f2d3371d89c
Author: Mike Kaganski 
AuthorDate: Fri Sep 10 00:49:49 2021 +0200
Commit: Xisco Fauli 
CommitDate: Fri Sep 10 09:48:23 2021 +0200

tdf#120129: don't forget to update buffer size to actual length

Otherwise extra bytes get written to the resulting string from the
too long buffer.

Change-Id: Iccde16b8002f214df6f86f484f288ec464c6b674
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121872
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 
(cherry picked from commit 541ddf4580cac8c3f9590be26a487f5fc8e2553c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121874
Reviewed-by: Xisco Fauli 

diff --git a/connectivity/source/drivers/firebird/Blob.cxx 
b/connectivity/source/drivers/firebird/Blob.cxx
index d254ba49431a..edcc0d233989 100644
--- a/connectivity/source/drivers/firebird/Blob.cxx
+++ b/connectivity/source/drivers/firebird/Blob.cxx
@@ -144,6 +144,9 @@ bool Blob::readOneSegment(uno::Sequence< sal_Int8 >& 
rDataOut)
 OUString sError(StatusVectorToString(m_statusVector, 
u"isc_get_segment"));
 throw IOException(sError, *this);
 }
+
+if (rDataOut.getLength() > nActualSize)
+rDataOut.realloc(nActualSize);
 m_nBlobPosition += nActualSize;
 return aRet == isc_segstr_eof;  // last segment read
 }

[Libreoffice-bugs] [Bug 144361] Image filter not found

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144361

--- Comment #3 from hollnagel.e...@gmail.com ---
Actually, it is not. Even trying to insert small jpg file in a document gives
the same error message.
I have given up and reinstalled LibreOffice 7.1.5, so I cannot reproduce the
error any longer.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140676] Editing a text after first save introduces unwanted information into the file.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140676

--- Comment #12 from fmoeb...@gmx.de ---
Created attachment 174940
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174940=edit
Text from TestFile as c/p-ed into another file, AFTER saving TestFile. BUG
SHOWS UP.

This is the text from the edited TestFile, c/p-ed into another LO file, after
saving, closing and re-opening the Test file.

The bug shows up very clearly. 

The words I edited in retain their Courier New font attribute. And if you look
very closely, you can see that the new paragraph converted well... this is so
weird.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140676] Editing a text after first save introduces unwanted information into the file.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140676

--- Comment #11 from fmoeb...@gmx.de ---
Created attachment 174939
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174939=edit
TestFile after editing.

This is the Test file after I edited it. As you can see, I added a few words,
deleted others and even added a new paragraph.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140676] Editing a text after first save introduces unwanted information into the file.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140676

--- Comment #10 from fmoeb...@gmx.de ---
Created attachment 174938
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174938=edit
TestFile c/p before editing.

This is the text from the TestFile, c/p-ed to a new file BEFORE any editing. 

Everything converts well to the other font.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/qa sw/source

[Miklos Vajna (via logerrit)]

 sw/qa/extras/layout/layout.cxx  |4 ++--
 sw/source/core/text/porlay.cxx  |7 +++
 sw/source/core/text/porlay.hxx  |4 
 sw/source/core/text/xmldump.cxx |6 ++
 4 files changed, 19 insertions(+), 2 deletions(-)

New commits:
commit 1c75df810439c71e975b166a66087c3d5a9ecdf3
Author: Miklos Vajna 
AuthorDate: Thu Sep 9 20:30:01 2021 +0200
Commit: Miklos Vajna 
CommitDate: Fri Sep 10 09:22:11 2021 +0200

sw layout xml dump: show SwParaPortion

Towards showing details of multi-portions, which are invisible to
XmlPortionDumper, which uses SwPortionHandler, which was introduced for
SwAccessiblePortionData, and is currently misused for debugging.

Change-Id: Ib62df8c9338855b6f03b24ca2d83b4d0e4408761
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121861
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/sw/qa/extras/layout/layout.cxx b/sw/qa/extras/layout/layout.cxx
index 2f6f827b81a0..bb5a860cab07 100644
--- a/sw/qa/extras/layout/layout.cxx
+++ b/sw/qa/extras/layout/layout.cxx
@@ -2750,8 +2750,8 @@ CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testTdf123898)
 Scheduler::ProcessEventsToIdle();
 
 xmlDocUniquePtr pXmlDoc = parseLayoutDump();
-// Make sure that the arrow on the left is not there (there are 43 
children if it's there)
-assertXPathChildren(pXmlDoc, "/root/page/body/txt/anchored/fly/txt", 42);
+// Make sure that the arrow on the left is not there (there are 44 
children if it's there)
+assertXPathChildren(pXmlDoc, "/root/page/body/txt/anchored/fly/txt", 43);
 }
 
 CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testTdf123651)
diff --git a/sw/source/core/text/porlay.cxx b/sw/source/core/text/porlay.cxx
index 2aeced43f463..1af44ae369e3 100644
--- a/sw/source/core/text/porlay.cxx
+++ b/sw/source/core/text/porlay.cxx
@@ -2505,6 +2505,13 @@ const SwDropPortion *SwParaPortion::FindDropPortion() 
const
 return nullptr;
 }
 
+void SwParaPortion::dumpAsXml(xmlTextWriterPtr pWriter) const
+{
+(void)xmlTextWriterStartElement(pWriter, BAD_CAST("SwParaPortion"));
+(void)xmlTextWriterWriteFormatAttribute(pWriter, BAD_CAST("ptr"), "%p", 
this);
+(void)xmlTextWriterEndElement(pWriter);
+}
+
 void SwLineLayout::Init( SwLinePortion* pNextPortion )
 {
 Height( 0, false );
diff --git a/sw/source/core/text/porlay.hxx b/sw/source/core/text/porlay.hxx
index 5234a537fa4c..3a3d458f2cf8 100644
--- a/sw/source/core/text/porlay.hxx
+++ b/sw/source/core/text/porlay.hxx
@@ -18,6 +18,8 @@
  */
 #pragma once
 
+#include 
+
 #include 
 
 #include 
@@ -321,6 +323,8 @@ public:
 void SetErgoSumNum( const OUString  );
 
 const SwDropPortion *FindDropPortion() const;
+
+void dumpAsXml(xmlTextWriterPtr pWriter) const;
 };
 
 inline void SwParaPortion::ResetPreps()
diff --git a/sw/source/core/text/xmldump.cxx b/sw/source/core/text/xmldump.cxx
index 03cf10e86b80..d188a0698373 100644
--- a/sw/source/core/text/xmldump.cxx
+++ b/sw/source/core/text/xmldump.cxx
@@ -28,6 +28,8 @@
 #include 
 #include 
 
+#include "porlay.hxx"
+
 namespace {
 
 class XmlPortionDumper:public SwPortionHandler
@@ -481,6 +483,10 @@ void SwFrame::dumpAsXml( xmlTextWriterPtr writer ) const
   reinterpret_cast(aText8.getStr(  )) );
 XmlPortionDumper pdumper( writer, aText );
 pTextFrame->VisitPortions( pdumper );
+if (const SwParaPortion* pPara = pTextFrame->GetPara())
+{
+pPara->dumpAsXml(writer);
+}
 
 }
 else

[Libreoffice-bugs] [Bug 140676] Editing a text after first save introduces unwanted information into the file.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140676

--- Comment #9 from fmoeb...@gmx.de ---
Created attachment 174937
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174937=edit
TestFile before any editing.

I create a new test file to reproduce the bug. This is written in New Courier,
the file has not been saved.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144385] Error "Image filter not found" when trying to insert JPG

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144385

Manuel YGUEL  changed:

   What|Removed |Added

 CC||manuel.yg...@gmail.com

--- Comment #3 from Manuel YGUEL  ---
I have the same problem on ubuntu 20.04

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144412] Qt5/KF5 flips writing direction on Ctrl+Shift+p

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144412

Michael Weghorn  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
 CC||m.wegh...@posteo.de

--- Comment #4 from Michael Weghorn  ---
Reproduced with

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 5b6fcbf4a754a2699b3b865256848238f93113a2
CPU threads: 12; OS: Linux 5.10; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-GB (en_GB.UTF-8); UI: en-US
Calc: threaded

Note that the Shift key on the right-hand side has to be used, otherwise this
does not happen. (It doesn't matter which Ctrl key is used.)

Easier way to get the same behaviour for both, kf5 and gtk3: Just press
Ctrl+Shift (right-hand side Shift key) and paragraph is switched to RTL.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140676] Editing a text after first save introduces unwanted information into the file.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140676

fmoeb...@gmx.de changed:

   What|Removed |Added

 CC||fmoeb...@gmx.de

--- Comment #8 from fmoeb...@gmx.de ---
Created attachment 174936
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174936=edit
This is the same text, I did a simple copy/paste into a new file. As you can
see, the edited spots retain the Courier New font.

I can make a new file and then get more screenshots if you need it, but they
will look exactly like this. Or would you like a video? (Not sure I can upload
one here, but I can record my steps.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140676] Editing a text after first save introduces unwanted information into the file.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140676

--- Comment #7 from fmoeb...@gmx.de ---
Created attachment 174935
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174935=edit
This is text as it looks in the file - after editing. Sorry, I don't have a
before pic. As you can see, you see nothing strange.

This the the file as it is now. It contains edited spots - where I replaced
some words with other words. (dual-sport Yamaha, i.e.) As you can see, you see
nothing unusual.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140676] Editing a text after first save introduces unwanted information into the file.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140676

fmoeb...@gmx.de changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #6 from fmoeb...@gmx.de ---
@Dieter:

Editing is as simple as deleting a few letters and writing others in the LO
Writer file. I can try to give you a screenshot, but that's rather pointless if
you ask me, there is nothing to see there. The bug only shows up AFTER I start
the formatting process of the file. Or after I copy/past the text into another
LO file. See attachment.

Editing steps: 
1) Delete a word.
2) Write another word.

Do you need a screenshot of that?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144424] UI: Textbox in Impress doesn't show in navigator

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144424

Telesto  changed:

   What|Removed |Added

 CC||rayk...@gmail.com

--- Comment #1 from Telesto  ---
@Jim,
You're the navigator specialist. It's (possibly)an easyHack candidate; however
you have the required expertise to asses that assumption

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144424] New: UI: Textbox in Impress doesn't show in navigator

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144424

Bug ID: 144424
   Summary: UI: Textbox in Impress doesn't show in navigator
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
UI: Textbox in Impress doesn't show in navigator

Steps to Reproduce:
1. Open attachment 174934
2. Sidebar -> Navigator

Actual Results:
One entry

Expected Results:
Two entry's


Reproducible: Always


User Profile Reset: No



Additional Info:
Found in
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 05ff3d67d0e2e436406786c949eb7cfca107ba33
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

and in
3.0.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144423] UI: Text frame/shape doesn't show a contour border line when selected

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144423

--- Comment #1 from Telesto  ---
Created attachment 174934
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174934=edit
Example file

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144423] New: UI: Text frame/shape doesn't show a contour border line when selected

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144423

Bug ID: 144423
   Summary: UI: Text frame/shape doesn't show a contour border
line when selected
   Product: LibreOffice
   Version: 4.4.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
UI: Text frame/shape doesn't show a contour border line when selected

Steps to Reproduce:
1. Open the attached file
2. Click at the border of the 'textbox' with numbering. Corner dots (and middle
dots appear without contour line
3. Now click at the border of the textbox containing hello (notice the contour
while dragging

Source for the frame not behaving: attachment 174478 (source appears to be
Google Docs; based on navigator)


Actual Results:
No contour when selected

Expected Results:
Same behaviour as textbox


Reproducible: Always


User Profile Reset: No



Additional Info:
Found in
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 05ff3d67d0e2e436406786c949eb7cfca107ba33
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

and in
4.4.7.2

-- 
You are receiving this mail because:
You are the assignee for the bug.