[Libreoffice-commits] core.git: sc/source

[Samuel Mehrbrodt (via logerrit)]

 sc/source/ui/view/gridwin.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit e752ce56b51c832dbea1e7f20e3b6671d99df990
Author: Samuel Mehrbrodt 
AuthorDate: Tue Sep 21 16:28:30 2021 +0200
Commit: Samuel Mehrbrodt 
CommitDate: Thu Sep 23 07:53:38 2021 +0200

Fix color filter popup position

popup was wrongly placed when dropdown was not in the first column

Change-Id: Id7170df233148564cba2fe2d498194b9e2b0161f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122396
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt 

diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 250b1152f114..16ce773a287b 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -956,7 +956,8 @@ void ScGridWindow::UpdateAutoFilterFromMenu(AutoFilterMode 
eMode)
 }
 i++;
 }
-Point pos(mpAutoFilterPopup->GetSizePixel().getWidth(), 150);
+Point pos(mpAutoFilterPopup->GetPosPixel());
+pos.Move(150, 0);
 sal_uInt16 nSelected = pColorMenu->Execute(this, pos);
 pColorMenu.disposeAndClear();
 rControl.terminateAllPopupMenus();

[Libreoffice-commits] core.git: icon-themes/colibre icon-themes/colibre_svg

[Rizal Muttaqin (via logerrit)]

 icon-themes/colibre/cmd/32/executereport.png |binary
 icon-themes/colibre/cmd/32/sbaexecutesql.png |binary
 icon-themes/colibre/cmd/32/sbanativesql.png  |binary
 icon-themes/colibre/cmd/lc_executereport.png |binary
 icon-themes/colibre/cmd/lc_sbaexecutesql.png |binary
 icon-themes/colibre/cmd/lc_sbanativesql.png  |binary
 icon-themes/colibre/cmd/sc_executereport.png |binary
 icon-themes/colibre/cmd/sc_sbaexecutesql.png |binary
 icon-themes/colibre/cmd/sc_sbanativesql.png  |binary
 icon-themes/colibre_svg/cmd/32/executereport.svg |2 +-
 icon-themes/colibre_svg/cmd/32/sbaexecutesql.svg |2 +-
 icon-themes/colibre_svg/cmd/32/sbanativesql.svg  |2 +-
 icon-themes/colibre_svg/cmd/lc_executereport.svg |2 +-
 icon-themes/colibre_svg/cmd/lc_sbaexecutesql.svg |2 +-
 icon-themes/colibre_svg/cmd/lc_sbanativesql.svg  |2 +-
 icon-themes/colibre_svg/cmd/sc_executereport.svg |3 ++-
 icon-themes/colibre_svg/cmd/sc_sbaexecutesql.svg |2 +-
 icon-themes/colibre_svg/cmd/sc_sbanativesql.svg  |7 ---
 18 files changed, 13 insertions(+), 11 deletions(-)

New commits:
commit 0b810cc0f04241e644c82ba8bdad6a075b964118
Author: Rizal Muttaqin 
AuthorDate: Thu Sep 23 11:33:23 2021 +0700
Commit: Rizal Muttaqin 
CommitDate: Thu Sep 23 07:43:45 2021 +0200

tdf#144631 Colibre: sync up query/sql/report execution icons

Change-Id: I52cfa4aa52f0bc03accb1030d463893ee871cdab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122504
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin 

diff --git a/icon-themes/colibre/cmd/32/executereport.png 
b/icon-themes/colibre/cmd/32/executereport.png
index 53d70d529ac0..e23f494cead9 100644
Binary files a/icon-themes/colibre/cmd/32/executereport.png and 
b/icon-themes/colibre/cmd/32/executereport.png differ
diff --git a/icon-themes/colibre/cmd/32/sbaexecutesql.png 
b/icon-themes/colibre/cmd/32/sbaexecutesql.png
index 6217c3651e29..1039ac6caddc 100644
Binary files a/icon-themes/colibre/cmd/32/sbaexecutesql.png and 
b/icon-themes/colibre/cmd/32/sbaexecutesql.png differ
diff --git a/icon-themes/colibre/cmd/32/sbanativesql.png 
b/icon-themes/colibre/cmd/32/sbanativesql.png
index dff8e9399bbe..4f794d5b38c5 100644
Binary files a/icon-themes/colibre/cmd/32/sbanativesql.png and 
b/icon-themes/colibre/cmd/32/sbanativesql.png differ
diff --git a/icon-themes/colibre/cmd/lc_executereport.png 
b/icon-themes/colibre/cmd/lc_executereport.png
index 9b3fbb57288f..c3e10e77d025 100644
Binary files a/icon-themes/colibre/cmd/lc_executereport.png and 
b/icon-themes/colibre/cmd/lc_executereport.png differ
diff --git a/icon-themes/colibre/cmd/lc_sbaexecutesql.png 
b/icon-themes/colibre/cmd/lc_sbaexecutesql.png
index a71eb9784e56..0f6c62c3ede0 100644
Binary files a/icon-themes/colibre/cmd/lc_sbaexecutesql.png and 
b/icon-themes/colibre/cmd/lc_sbaexecutesql.png differ
diff --git a/icon-themes/colibre/cmd/lc_sbanativesql.png 
b/icon-themes/colibre/cmd/lc_sbanativesql.png
index f7e32b0584dd..56df87b72581 100644
Binary files a/icon-themes/colibre/cmd/lc_sbanativesql.png and 
b/icon-themes/colibre/cmd/lc_sbanativesql.png differ
diff --git a/icon-themes/colibre/cmd/sc_executereport.png 
b/icon-themes/colibre/cmd/sc_executereport.png
index 76a664c3bdc0..548a827e0ed3 100644
Binary files a/icon-themes/colibre/cmd/sc_executereport.png and 
b/icon-themes/colibre/cmd/sc_executereport.png differ
diff --git a/icon-themes/colibre/cmd/sc_sbaexecutesql.png 
b/icon-themes/colibre/cmd/sc_sbaexecutesql.png
index 469c5a720cdb..37866388ea9e 100644
Binary files a/icon-themes/colibre/cmd/sc_sbaexecutesql.png and 
b/icon-themes/colibre/cmd/sc_sbaexecutesql.png differ
diff --git a/icon-themes/colibre/cmd/sc_sbanativesql.png 
b/icon-themes/colibre/cmd/sc_sbanativesql.png
index 634987be26cb..9127a87ee8fd 100644
Binary files a/icon-themes/colibre/cmd/sc_sbanativesql.png and 
b/icon-themes/colibre/cmd/sc_sbanativesql.png differ
diff --git a/icon-themes/colibre_svg/cmd/32/executereport.svg 
b/icon-themes/colibre_svg/cmd/32/executereport.svg
index 315e7dff4851..460adcad1da1 100644
--- a/icon-themes/colibre_svg/cmd/32/executereport.svg
+++ b/icon-themes/colibre_svg/cmd/32/executereport.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg;>
\ No newline at end of file
+http://www.w3.org/2000/svg;>
\ No newline at end of file
diff --git a/icon-themes/colibre_svg/cmd/32/sbaexecutesql.svg 
b/icon-themes/colibre_svg/cmd/32/sbaexecutesql.svg
index 909912d17e46..f2f0cf08fc59 100644
--- a/icon-themes/colibre_svg/cmd/32/sbaexecutesql.svg
+++ b/icon-themes/colibre_svg/cmd/32/sbaexecutesql.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
\ No newline at end of file
+http://www.w3.org/2000/svg; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
\ No newline at end of file
diff --git a/icon-themes/colibre_svg/cmd/32/sbanativesql.svg 
b/icon-themes/colibre_svg/cmd/32/sbanativesql.svg
index 9db5056f61d2..3f922c6170f2 100644
--- 

[Libreoffice-commits] core.git: idlc/inc idlc/source

[Stephan Bergmann (via logerrit)]

 idlc/inc/idlc.hxx   |2 +-
 idlc/source/astscope.cxx|6 --
 idlc/source/idlccompile.cxx |5 +++--
 3 files changed, 8 insertions(+), 5 deletions(-)

New commits:
commit 4706eb93350b2613b1fe6b98afa1243415c40577
Author: Stephan Bergmann 
AuthorDate: Wed Sep 22 22:19:43 2021 +0200
Commit: Stephan Bergmann 
CommitDate: Thu Sep 23 07:27:14 2021 +0200

Extend loplugin:stringviewparam to starts/endsWith: idlc

Change-Id: Ib9c97576746b6acfddeacec658a2ae994aa28516
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122497
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/idlc/inc/idlc.hxx b/idlc/inc/idlc.hxx
index 8995ead72de4..1be11b1457da 100644
--- a/idlc/inc/idlc.hxx
+++ b/idlc/inc/idlc.hxx
@@ -147,7 +147,7 @@ void removeIfExists(std::string_view pathname);
 bool copyFile(const OString* source, const OString& target);
 // a null source means stdin
 
-bool isFileUrl(const OString& fileName);
+bool isFileUrl(std::string_view fileName);
 OString convertToAbsoluteSystemPath(const OString& fileName);
 OString convertToFileUrl(const OString& fileName);
 
diff --git a/idlc/source/astscope.cxx b/idlc/source/astscope.cxx
index d4c0f954367c..ca6214129c87 100644
--- a/idlc/source/astscope.cxx
+++ b/idlc/source/astscope.cxx
@@ -20,17 +20,19 @@
 #include 
 
 #include 
+#include 
 
 #include 
 #include 
 #include 
 #include 
+#include 
 #include 
 
 
-static bool isGlobal(const OString& scopedName)
+static bool isGlobal(std::string_view scopedName)
 {
-return scopedName.isEmpty() || scopedName.startsWith(":");
+return scopedName.empty() || o3tl::starts_with(scopedName, ":");
 }
 
 AstScope::AstScope(NodeType nodeType)
diff --git a/idlc/source/idlccompile.cxx b/idlc/source/idlccompile.cxx
index 1902d63e0cad..6db9a615d316 100644
--- a/idlc/source/idlccompile.cxx
+++ b/idlc/source/idlccompile.cxx
@@ -22,6 +22,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -52,9 +53,9 @@ extern int yydebug;
 
 static char tmpFilePattern[512];
 
-bool isFileUrl(const OString& fileName)
+bool isFileUrl(std::string_view fileName)
 {
-return fileName.startsWith("file://");
+return o3tl::starts_with(fileName, "file://");
 }
 
 OString convertToAbsoluteSystemPath(const OString& fileName)

[Libreoffice-commits] core.git: extensions/source

[Stephan Bergmann (via logerrit)]

 extensions/source/update/check/download.cxx |9 +
 extensions/source/update/check/download.hxx |6 +-
 2 files changed, 10 insertions(+), 5 deletions(-)

New commits:
commit 310d43b9a27efc36f2c9e6737a0b5ac3f211bda0
Author: Stephan Bergmann 
AuthorDate: Wed Sep 22 23:25:49 2021 +0200
Commit: Stephan Bergmann 
CommitDate: Thu Sep 23 07:26:38 2021 +0200

Extend loplugin:stringviewparam to starts/endsWith: extensions

Change-Id: I29c3a09628f213d8b229a981d62421390385c54e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122499
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/extensions/source/update/check/download.cxx 
b/extensions/source/update/check/download.cxx
index 1f98b7717be2..905d16e99a7f 100644
--- a/extensions/source/update/check/download.cxx
+++ b/extensions/source/update/check/download.cxx
@@ -23,6 +23,7 @@
 
 #include 
 
+#include 
 #include 
 #include 
 #include 
@@ -168,7 +169,7 @@ progress_callback( void *clientp, double dltotal, double 
dlnow, SAL_UNUSED_PARAM
 
 
 void
-Download::getProxyForURL(const OUString& rURL, OString& rHost, sal_Int32& 
rPort) const
+Download::getProxyForURL(std::u16string_view rURL, OString& rHost, sal_Int32& 
rPort) const
 {
 uno::Reference< lang::XMultiServiceFactory > xConfigProvider(
 css::configuration::theDefaultProvider::get( m_xContext ) );
@@ -191,17 +192,17 @@ Download::getProxyForURL(const OUString& rURL, OString& 
rHost, sal_Int32& rPort)
 sal_Int32 nProxyType = aValue.get< sal_Int32 >();
 if( 0 != nProxyType ) // type 0 means "direct connection to the internet
 {
-if( rURL.startsWith("http:") )
+if( o3tl::starts_with(rURL, u"http:") )
 {
 rHost = getStringValue(xNameAccess, "ooInetHTTPProxyName");
 rPort = getInt32Value(xNameAccess, "ooInetHTTPProxyPort");
 }
-else if( rURL.startsWith("https:") )
+else if( o3tl::starts_with(rURL, u"https:") )
 {
 rHost = getStringValue(xNameAccess, "ooInetHTTPSProxyName");
 rPort = getInt32Value(xNameAccess, "ooInetHTTPSProxyPort");
 }
-else if( rURL.startsWith("ftp:") )
+else if( o3tl::starts_with(rURL, u"ftp:") )
 {
 rHost = getStringValue(xNameAccess, "ooInetFTPProxyName");
 rPort = getInt32Value(xNameAccess, "ooInetFTPProxyPort");
diff --git a/extensions/source/update/check/download.hxx 
b/extensions/source/update/check/download.hxx
index 2440ce4cec85..12a11ddde091 100644
--- a/extensions/source/update/check/download.hxx
+++ b/extensions/source/update/check/download.hxx
@@ -19,6 +19,10 @@
 
 #pragma once
 
+#include 
+
+#include 
+
 #include 
 
 #include 
@@ -65,7 +69,7 @@ public:
 
 protected:
 // Determines the appropriate proxy settings for the given URL. Returns 
true if a proxy should be used
-void getProxyForURL(const OUString& rURL, OString& rHost, sal_Int32& 
rPort) const;
+void getProxyForURL(std::u16string_view rURL, OString& rHost, sal_Int32& 
rPort) const;
 
 private:
 osl::Condition m_aCondition;

[Libreoffice-commits] core.git: l10ntools/source

[Stephan Bergmann (via logerrit)]

 l10ntools/source/localize.cxx |9 +
 1 file changed, 5 insertions(+), 4 deletions(-)

New commits:
commit 047a983314b560e0f64280ae2ac7d696d90d539b
Author: Stephan Bergmann 
AuthorDate: Wed Sep 22 22:06:37 2021 +0200
Commit: Stephan Bergmann 
CommitDate: Thu Sep 23 07:26:09 2021 +0200

Extend loplugin:stringviewparam to starts/endsWith: l10ntools

Change-Id: I2c8c8e0fb034f79bb844a1d09defc3227324e686
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122494
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/l10ntools/source/localize.cxx b/l10ntools/source/localize.cxx
index 38e9c21f3cac..cede7837bdd3 100644
--- a/l10ntools/source/localize.cxx
+++ b/l10ntools/source/localize.cxx
@@ -29,6 +29,7 @@
 #include 
 #include 
 
+#include 
 #include 
 #include 
 #include 
@@ -49,17 +50,17 @@ using namespace std;
 namespace {
 
 bool matchList(
-const OUString& rUrl, const std::u16string_view* pList, size_t nLength)
+std::u16string_view rUrl, const std::u16string_view* pList, size_t nLength)
 {
 for (size_t i = 0; i != nLength; ++i) {
-if (rUrl.endsWith(pList[i])) {
+if (o3tl::ends_with(rUrl, pList[i])) {
 return true;
 }
 }
 return false;
 }
 
-bool passesNegativeList(const OUString& rUrl) {
+bool passesNegativeList(std::u16string_view rUrl) {
 static const std::u16string_view list[] = {
 u"/desktop/test/deployment/passive/help/en/help.tree",
 u"/desktop/test/deployment/passive/help/en/main.xhp",
@@ -77,7 +78,7 @@ bool passesNegativeList(const OUString& rUrl) {
 return !matchList(rUrl, list, SAL_N_ELEMENTS(list));
 }
 
-bool passesPositiveList(const OUString& rUrl) {
+bool passesPositiveList(std::u16string_view rUrl) {
 static const std::u16string_view list[] = {
 u"/description.xml"
 };

[Libreoffice-commits] core.git: framework/inc framework/source

[Stephan Bergmann (via logerrit)]

 framework/inc/protocols.h   |   43 
 framework/source/layoutmanager/toolbarlayoutmanager.cxx |5 +
 framework/source/layoutmanager/toolbarlayoutmanager.hxx |3 -
 3 files changed, 29 insertions(+), 22 deletions(-)

New commits:
commit cb3058aa4e3155d97d47d1444b808da7297b5794
Author: Stephan Bergmann 
AuthorDate: Wed Sep 22 23:25:16 2021 +0200
Commit: Stephan Bergmann 
CommitDate: Thu Sep 23 07:25:40 2021 +0200

Extend loplugin:stringviewparam to starts/endsWith: framework

Change-Id: Idc92058e7d2ff63d55e97e6b2fee83314fc0334c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122498
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/framework/inc/protocols.h b/framework/inc/protocols.h
index f9dfffd85a3d..30d87cc59336 100644
--- a/framework/inc/protocols.h
+++ b/framework/inc/protocols.h
@@ -21,6 +21,11 @@
 
 #pragma once
 
+#include 
+
+#include 
+
+#include 
 #include 
 
 namespace framework{
@@ -34,23 +39,23 @@ namespace framework{
 // indicates a loadable content in general!
 #define SPECIALPROTOCOL_PRIVATE   "private:"
 // indicates loading of components using a model directly
-#define SPECIALPROTOCOL_PRIVATE_OBJECT"private:object"
+#define SPECIALPROTOCOL_PRIVATE_OBJECTu"private:object"
 // indicates loading of components using a stream only
-#define SPECIALPROTOCOL_PRIVATE_STREAM"private:stream"
+#define SPECIALPROTOCOL_PRIVATE_STREAMu"private:stream"
 // indicates creation of empty documents
-#define SPECIALPROTOCOL_PRIVATE_FACTORY   "private:factory"
+#define SPECIALPROTOCOL_PRIVATE_FACTORY   u"private:factory"
 // internal protocol of the sfx project for generic dispatch functionality
-#define SPECIALPROTOCOL_SLOT  "slot:"
+#define SPECIALPROTOCOL_SLOT  u"slot:"
 // external representation of the slot protocol using names instead of id's
-#define SPECIALPROTOCOL_UNO   ".uno:"
+#define SPECIALPROTOCOL_UNO   u".uno:"
 // special sfx protocol to execute macros
-#define SPECIALPROTOCOL_MACRO "macro:"
+#define SPECIALPROTOCOL_MACRO u"macro:"
 // generic way to start uno services during dispatch
-#define SPECIALPROTOCOL_SERVICE   "service:"
+#define SPECIALPROTOCOL_SERVICE   u"service:"
 // for sending mails
-#define SPECIALPROTOCOL_MAILTO"mailto:;
+#define SPECIALPROTOCOL_MAILTOu"mailto:;
 // for sending news
-#define SPECIALPROTOCOL_NEWS  "news:;
+#define SPECIALPROTOCOL_NEWS  u"news:;
 
 /** well known protocols */
 enum class EProtocol
@@ -75,37 +80,37 @@ class ProtocolCheck
 It should be used instead of specifyProtocol() if only this question
 is interesting to perform the code. We must not check for all possible 
protocols here...
  */
-static bool isProtocol( const OUString& sURL, EProtocol eRequired )
+static bool isProtocol( std::u16string_view sURL, EProtocol eRequired )
 {
 bool bRet = false;
 switch(eRequired)
 {
 case EProtocol::PrivateObject:
-bRet = sURL.startsWith(SPECIALPROTOCOL_PRIVATE_OBJECT);
+bRet = o3tl::starts_with(sURL, SPECIALPROTOCOL_PRIVATE_OBJECT);
 break;
 case EProtocol::PrivateStream:
-bRet = sURL.startsWith(SPECIALPROTOCOL_PRIVATE_STREAM);
+bRet = o3tl::starts_with(sURL, SPECIALPROTOCOL_PRIVATE_STREAM);
 break;
 case EProtocol::PrivateFactory:
-bRet = sURL.startsWith(SPECIALPROTOCOL_PRIVATE_FACTORY);
+bRet = o3tl::starts_with(sURL, 
SPECIALPROTOCOL_PRIVATE_FACTORY);
 break;
 case EProtocol::Slot:
-bRet = sURL.startsWith(SPECIALPROTOCOL_SLOT);
+bRet = o3tl::starts_with(sURL, SPECIALPROTOCOL_SLOT);
 break;
 case EProtocol::Uno:
-bRet = sURL.startsWith(SPECIALPROTOCOL_UNO);
+bRet = o3tl::starts_with(sURL, SPECIALPROTOCOL_UNO);
 break;
 case EProtocol::Macro:
-bRet = sURL.startsWith(SPECIALPROTOCOL_MACRO);
+bRet = o3tl::starts_with(sURL, SPECIALPROTOCOL_MACRO);
 break;
 case EProtocol::Service:
-bRet = sURL.startsWith(SPECIALPROTOCOL_SERVICE);
+bRet = o3tl::starts_with(sURL, SPECIALPROTOCOL_SERVICE);
 break;
 case EProtocol::MailTo:
-bRet = sURL.startsWith(SPECIALPROTOCOL_MAILTO);
+bRet = o3tl::starts_with(sURL, SPECIALPROTOCOL_MAILTO);
 break;
 case EProtocol::News:
-bRet = sURL.startsWith(SPECIALPROTOCOL_NEWS);
+bRet = o3tl::starts_with(sURL, SPECIALPROTOCOL_NEWS);
 break;
 default:
 bRet = false;
diff --git 

[Libreoffice-bugs] [Bug 144647] Fileopen DOCX: 3 pages instead of 2

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144647

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #2 from raal  ---
No repro with Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 55adeb1c3fbcf32c7c44a3f0c310b56298f551f9
CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded Jumbo

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144672] New: Index entries in Navigator are grayed out

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144672

Bug ID: 144672
   Summary: Index entries in Navigator are grayed out
   Product: LibreOffice
   Version: 7.3.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rayk...@gmail.com

Created attachment 175203
  --> https://bugs.documentfoundation.org/attachment.cgi?id=175203=edit
index entries test document

I noticed that all entries listed under the Index category in the Navigator are
grayed, meaning hidden, even when the corresponding Index entry in the document
is visible.

Steps to repro:

1) Open the attached Writer document.

2) Open the Navigator (Menu->View->Navigator or Menu->View->Sidebar and click
on the Navigator tab button in the sidebar tab bar)

3) If needed, expand the Indexes category by clicking the expand button to the
left of the Indexes entry in the Navigator content tree.

Results: 
Entries listed under Indexes category are shown grayed out, meaning hidden.

Expected results: 
Entries are not grayed out.

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: ba0851926a9def7577dcf7b29919de0632ac31a9
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: x11
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117497] [META] Colibre icons

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117497

Rizal Muttaqin  changed:

   What|Removed |Added

 Depends on||144631


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=144631
[Bug 144631] Inconsistent LibreOffice Base Query Design Run Sql Command
Directly Toolbar Button Tick Colour across icon themes
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144631] Inconsistent LibreOffice Base Query Design Run Sql Command Directly Toolbar Button Tick Colour across icon themes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144631

Rizal Muttaqin  changed:

   What|Removed |Added

 Blocks||117497
   Assignee|libreoffice-b...@lists.free |riz...@libreoffice.org
   |desktop.org |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=117497
[Bug 117497] [META] Colibre icons
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144366] LO crashes when text in search field is entered

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144366

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144387] Numering schema don't work for not headings fonts from second level.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144387

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144375] [ACCESSIBILITY] Copy object caption contents to object name, alt and description

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144375

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144391] Calc: link to files management.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144391

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144392] Current point after "close path" command Z is the initial point of the closed path

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144392

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144380] Experimental Features - Forever loop for Deleting all columns

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144380

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144390] Marker (arrow head) on enhanced-path in custom shape is wrong

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144390

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144328] BASE document preview pane section: different form backgrounds do overlay

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144328

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144336] RTF-TABLE: Formula with bookmark changes to zero

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144336

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139257] Crash of LibreOffice deletes non saved work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139257

--- Comment #6 from QA Administrators  ---
Dear sirihuet,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144492] LibreOffice version 7.1.6.2 - Documents don't open; they do open in version 7.1.5.2 and 7.2.0.4

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144492

QA Administrators  changed:

   What|Removed |Added

 Resolution|NOTABUG |---
 Status|RESOLVED|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139257] Crash of LibreOffice deletes non saved work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139257

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144492] LibreOffice version 7.1.6.2 - Documents don't open; they do open in version 7.1.5.2 and 7.2.0.4

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144492

--- Comment #12 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 127593] [META] Python Macro bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127593
Bug 127593 depends on bug 132196, which changed state.

Bug 132196 Summary: Rewrite of mailmerge.py
https://bugs.documentfoundation.org/show_bug.cgi?id=132196

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 132196] Rewrite of mailmerge.py

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132196

--- Comment #11 from QA Administrators  ---
Dear prrvchr,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 132196] Rewrite of mailmerge.py

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132196

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141270] Wide vertical spacing when using a custom font.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141270

--- Comment #2 from QA Administrators  ---
Dear noel,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141208] Editing a LibreOffice Calc spreadsheet and was trying to find the Freeze Rows/Columns command. Calc crashed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141208

--- Comment #4 from QA Administrators  ---
Dear clearlyseen,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140948] Undo doesn't restore original layout

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140948

--- Comment #8 from QA Administrators  ---
Dear Telesto,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140842] Styles & Formatting Character Style: font weight resets to Regular every time document is closed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140842

--- Comment #3 from QA Administrators  ---
Dear Violet,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140713] Error if I do a Time query in LibreOffice Base [Critical]

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140713

--- Comment #4 from QA Administrators  ---
Dear Faizan Rizwan,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 98311] FILESAVE ODP to PPT: automatic text color saved as white

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98311

--- Comment #10 from QA Administrators  ---
Dear Stéphane Aulery,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 96382] Edit character style - background color and border shadow are applied unwantedly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96382

--- Comment #16 from QA Administrators  ---
Dear Oliver Specht (CIB),

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 91666] PDF: Broken import of non-BMP characters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91666

--- Comment #10 from QA Administrators  ---
Dear neomix,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 77764] FILEOPEN XML Content goes outside page area on Linux

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=77764

--- Comment #8 from QA Administrators  ---
Dear shaman,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 57361] Can't resize wide columns; mouse scrolling is also broken

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57361

--- Comment #12 from QA Administrators  ---
Dear Tristan Miller,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 50090] FILESAVE: Missing tags in [Content_Types].xml make OOXML not compatible with Windows Phone (see comment 31)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=50090

--- Comment #35 from QA Administrators  ---
Dear gader,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 47564] Rotated text not overlapping to cells on top and below and wrong alignment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=47564

--- Comment #18 from QA Administrators  ---
Dear daniel.schaaaf,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 114462] Slow scrolling and high CPU utilization in the expert configuration with specific content (for example histories)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114462

--- Comment #6 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 113797] Label field's property name mismatch in dialog editor and macro code

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113797

--- Comment #7 from QA Administrators  ---
Dear Mátyás Jani,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 106622] PIVOT TABLE: wrong selected fields of Page Fields after updating table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106622

--- Comment #9 from QA Administrators  ---
Dear f.rr,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: desktop/qa sw/source

[Andrea Gelmini (via logerrit)]

 desktop/qa/desktop_lib/test_desktop_lib.cxx |2 +-
 sw/source/uibase/utlui/content.cxx  |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 84e61754bfe2f07de412c24513774900702a48a2
Author: Andrea Gelmini 
AuthorDate: Wed Sep 22 22:10:23 2021 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Thu Sep 23 05:29:21 2021 +0200

Fix typos

Change-Id: I01c46b864e296d4094f0a1579fdc64066eacc386
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122496
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx 
b/desktop/qa/desktop_lib/test_desktop_lib.cxx
index 680e48228d10..d827124a4e52 100644
--- a/desktop/qa/desktop_lib/test_desktop_lib.cxx
+++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx
@@ -3299,7 +3299,7 @@ void DesktopLOKTest::testMultiViewTableSelection()
 Scheduler::ProcessEventsToIdle();
 // View1 should not get any table selection messages.
 CPPUNIT_ASSERT_EQUAL(0, aView1.m_nTableSelectionCount);
-// View2 will first get table selection of Table1, then emty selection, 
and finally on 7th down arrow keypress,
+// View2 will first get table selection of Table1, then empty selection, 
and finally on 7th down arrow keypress,
 // it will get table-selection of Table2. So in total it should get 3 
table selections.
 CPPUNIT_ASSERT_EQUAL(3, aView2.m_nTableSelectionCount);
 CPPUNIT_ASSERT(!aView2.m_bEmptyTableSelection);
diff --git a/sw/source/uibase/utlui/content.cxx 
b/sw/source/uibase/utlui/content.cxx
index fb8667ead94a..ff17d753e13e 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -3406,7 +3406,7 @@ void SwContentTree::UpdateTracking()
 m_pActiveShell->GetContentAtPos(m_pActiveShell->GetCursorDocPos(), 
aContentAtPos) &&
 !(m_bIsRoot && m_nRootType != ContentTypeId::URLFIELD))
 {
-// Because hyperlink item names do not need to be unique, finding the 
corrosponding item
+// Because hyperlink item names do not need to be unique, finding the 
corresponding item
 // in the tree by name may result in incorrect selection. Find the 
item in the tree by
 // comparing the SwTextINetFormat pointer at the document cursor 
position to that stored
 // in the item SwURLFieldContent.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - vcl/unx

[Caolán McNamara (via logerrit)]

 vcl/unx/gtk3/gtkinst.cxx |   12 
 1 file changed, 12 insertions(+)

New commits:
commit e163000fdb525b93d639aa9886365745439b2132
Author: Caolán McNamara 
AuthorDate: Wed Sep 22 16:26:00 2021 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Thu Sep 23 05:26:03 2021 +0200

Resolves: tdf#142704 %PRODUCTNAME shown in gtk3 extended tips

Change-Id: I61d8b83ce326816c498f54e3cfc053270d82c1a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122433
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index 7034386c35f3..53ab57ae32dd 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -21395,6 +21395,18 @@ private:
 gtk_widget_hide(pWidget);
 }
 
+#if !GTK_CHECK_VERSION(4, 0, 0)
+// tdf#142704 %PRODUCTNAME shown in extended tips
+AtkObject* pAtkObject = gtk_widget_get_accessible(pWidget);
+const char* pDesc = pAtkObject ? 
atk_object_get_description(pAtkObject) : nullptr;
+if (pDesc && pDesc[0])
+{
+OUString aDesc(pDesc, strlen(pDesc), RTL_TEXTENCODING_UTF8);
+aDesc = (*m_pStringReplace)(aDesc);
+atk_object_set_description(pAtkObject, OUStringToOString(aDesc, 
RTL_TEXTENCODING_UTF8).getStr());
+}
+#endif
+
 // expand placeholder and collect potentially missing mnemonics
 if (GTK_IS_BUTTON(pWidget))
 {

[Libreoffice-bugs] [Bug 144668] Customized number format lost on save and re-open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144668

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #2 from Regina Henschel  ---
Please attach a working document from version 6.3.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 126008] TABLES STYLES: If you insert a row or column (with cursor in a cell), the formatting of the whole table changes (steps in comment 5)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126008

xaviermdq  changed:

   What|Removed |Added

 CC||xavier...@yahoo.com.ar

--- Comment #42 from xaviermdq  ---
Confirmed with:

Version: 7.2.1.2 (x64) / LibreOffice Community
Build ID: 87b77fad49947c1441b67c559c339af8f3517e22
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win
Locale: es-AR (es_AR); UI: es-ES
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - desktop/inc desktop/source

[Noel Grandin (via logerrit)]

 desktop/inc/lib/init.hxx|   23 ++---
 desktop/source/lib/init.cxx |  192 +---
 2 files changed, 123 insertions(+), 92 deletions(-)

New commits:
commit 475d6528a5ae1781c5b09cbcd3fd305c4180c168
Author: Noel Grandin 
AuthorDate: Wed Aug 4 13:01:22 2021 +0200
Commit: Luboš Luňák 
CommitDate: Thu Sep 23 00:09:00 2021 +0200

speed up scanning the LOK queue

we frequently scan the queue to caolesce events.
Most of the time we are scanning based on the event type.
So split the queue data into a compact queue that only contains the
type, and another queue for the rest of the data.
That makes the scanning __much__ more cache-friendly.

Change-Id: I92d0b95611cd139cac8532f9297eaabda71d5fe9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119996
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Noel Grandin 
(cherry picked from commit acf9cf33d53e4bf598ddbdab102bfbd6bb14f8a3)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121558
Tested-by: Jenkins
(cherry picked from commit 3b3e4ee97af23f210fa39f1af3ddf1de63291371)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122434
Reviewed-by: Luboš Luňák 

diff --git a/desktop/inc/lib/init.hxx b/desktop/inc/lib/init.hxx
index 3d95d4f602b4..ed35ebc2fa13 100644
--- a/desktop/inc/lib/init.hxx
+++ b/desktop/inc/lib/init.hxx
@@ -92,9 +92,8 @@ namespace desktop {
 
 struct CallbackData
 {
-CallbackData(int type, const std::string& payload)
-: Type(type)
-, PayloadString(payload)
+CallbackData(const std::string& payload)
+: PayloadString(payload)
 {
 }
 
@@ -117,7 +116,6 @@ namespace desktop {
 /// Returns true iff there is cached data.
 bool isCached() const { return PayloadObject.which() != 0; }
 
-int Type;
 std::string PayloadString;
 
 private:
@@ -125,14 +123,19 @@ namespace desktop {
 boost::variant PayloadObject;
 };
 
-typedef std::vector queue_type;
+typedef std::vector queue_type1;
+typedef std::vector queue_type2;
 
 private:
-bool removeAll(const std::function& rTestFunc);
-bool processInvalidateTilesEvent(CallbackData& aCallbackData);
-bool processWindowEvent(CallbackData& aCallbackData);
-
-queue_type m_queue;
+bool removeAll(const std::function& 
rTestFunc);
+bool processInvalidateTilesEvent(int type, CallbackData& 
aCallbackData);
+bool processWindowEvent(int type, CallbackData& aCallbackData);
+queue_type2::reverse_iterator toQueue2(queue_type1::reverse_iterator);
+
+/** we frequently want to scan the queue, and mostly when we do so, we 
only care about the element type
+so we split the queue in 2 to make the scanning cache friendly. */
+queue_type1 m_queue1;
+queue_type2 m_queue2;
 std::map m_states;
 std::unordered_map> 
m_viewStates;
 LibreOfficeKitDocument* m_pDocument;
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index c95de6ed4082..86c468df402f 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -1438,13 +1438,19 @@ void CallbackFlushHandler::callback(const int type, 
const char* payload, void* d
 }
 }
 
+CallbackFlushHandler::queue_type2::reverse_iterator 
CallbackFlushHandler::toQueue2(CallbackFlushHandler::queue_type1::reverse_iterator
 pos)
+{
+int delta = std::distance(m_queue1.rbegin(), pos);
+return m_queue2.rbegin() + delta;
+}
+
 void CallbackFlushHandler::queue(const int type, const char* data)
 {
 comphelper::ProfileZone aZone("CallbackFlushHandler::queue");
 
-CallbackData aCallbackData(type, (data ? data : "(nil)"));
+CallbackData aCallbackData(data ? data : "(nil)");
 const std::string& payload = aCallbackData.PayloadString;
-SAL_INFO("lok", "Queue: [" << type << "]: [" << payload << "] on " << 
m_queue.size() << " entries.");
+SAL_INFO("lok", "Queue: [" << type << "]: [" << payload << "] on " << 
m_queue1.size() << " entries.");
 
 bool bIsChartActive = false;
 if (type == LOK_CALLBACK_GRAPHIC_SELECTION)
@@ -1523,10 +1529,10 @@ void CallbackFlushHandler::queue(const int type, const 
char* data)
 case LOK_CALLBACK_CALC_FUNCTION_LIST:
 case LOK_CALLBACK_INVALIDATE_SHEET_GEOMETRY:
 {
-const auto& pos = std::find_if(m_queue.rbegin(), m_queue.rend(),
-[type] (const queue_type::value_type& elem) { return 
(elem.Type == type); });
-
-if (pos != m_queue.rend() && pos->PayloadString == payload)
+const auto& pos = std::find_if(m_queue1.rbegin(), m_queue1.rend(),
+[type] (int elemType) { return (elemType == type); });
+auto pos2 = toQueue2(pos);
+if (pos != 

[Libreoffice-commits] core.git: 2 commits - include/vcl sw/CppunitTest_sw_uwriter.mk sw/inc sw/qa sw/source

[Luboš Luňák (via logerrit)]

 include/vcl/region.hxx |6 +-
 sw/CppunitTest_sw_uwriter.mk   |1 
 sw/inc/swregion.hxx|3 -
 sw/qa/core/test_region.cxx |  108 +
 sw/source/core/bastyp/swregion.cxx |   32 +++---
 sw/source/core/view/viewsh.cxx |4 -
 6 files changed, 127 insertions(+), 27 deletions(-)

New commits:
commit 362d2271721dd19de7a7f6f2271a349272ce51d8
Author: Luboš Luňák 
AuthorDate: Wed Sep 22 16:41:45 2021 +0200
Commit: Luboš Luňák 
CommitDate: Thu Sep 23 00:08:41 2021 +0200

add some unittests for SwRegionRects

And fix two small bugs in SwRegionRects::Compress().

Change-Id: I8df7cc2e9d4d6ca78e3af711639e3fbae2e471ae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122462
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/sw/CppunitTest_sw_uwriter.mk b/sw/CppunitTest_sw_uwriter.mk
index ef9951ca1f80..7626039ca23e 100644
--- a/sw/CppunitTest_sw_uwriter.mk
+++ b/sw/CppunitTest_sw_uwriter.mk
@@ -20,6 +20,7 @@ $(eval $(call 
gb_CppunitTest_add_exception_objects,sw_uwriter, \
 sw/qa/core/test_ToxLinkProcessor \
 sw/qa/core/test_ToxTextGenerator \
 sw/qa/core/test_ToxMiscTest \
+sw/qa/core/test_region \
 ))
 
 $(eval $(call gb_CppunitTest_use_library_objects,sw_uwriter,sw))
diff --git a/sw/inc/swregion.hxx b/sw/inc/swregion.hxx
index 1aa190712a8f..338a30649c7a 100644
--- a/sw/inc/swregion.hxx
+++ b/sw/inc/swregion.hxx
@@ -55,8 +55,9 @@ public:
 // Ensures all rectangles are within the origin area.
 void LimitToOrigin();
 
+enum CompressType { CompressExact, CompressFuzzy };
 // Combine adjacent rectangles.
-void Compress();
+void Compress( CompressType type );
 
 const SwRect () const { return m_aOrigin; }
 void ChangeOrigin( const SwRect  ) { m_aOrigin = rRect; }
diff --git a/sw/qa/core/test_region.cxx b/sw/qa/core/test_region.cxx
new file mode 100644
index ..15fa398c7e4a
--- /dev/null
+++ b/sw/qa/core/test_region.cxx
@@ -0,0 +1,108 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ */
+
+#include 
+#include 
+#include 
+
+#include 
+#include 
+
+class RegionUnittest : public CppUnit::TestFixture
+{
+public:
+void testCompress();
+void testInvert();
+
+CPPUNIT_TEST_SUITE(RegionUnittest);
+CPPUNIT_TEST(testCompress);
+CPPUNIT_TEST(testInvert);
+CPPUNIT_TEST_SUITE_END();
+};
+
+void RegionUnittest::testCompress()
+{
+SwRegionRects region;
+
+// All inside each other, check it'll compress them to the largest one.
+region = SwRegionRects();
+region += SwRect(Point(10, 10), Size(10, 10));
+region += SwRect(Point(10, 10), Size(20, 20));
+region += SwRect(Point(10, 10), Size(100, 100));
+region += SwRect(Point(10, 10), Size(50, 50));
+region.Compress(SwRegionRects::CompressExact);
+CPPUNIT_ASSERT_EQUAL(size_t(1), region.size());
+CPPUNIT_ASSERT_EQUAL(SwRect(Point(10, 10), Size(100, 100)), region[0]);
+
+// Check merging of adjacent rectangles. This will merge first two groups
+// and then those two merged rects only in the next iteration.
+region = SwRegionRects();
+region += SwRect(Point(10, 10), Size(1, 1));
+region += SwRect(Point(10010, 10), Size(1, 1));
+region += SwRect(Point(10, 10010), Size(1, 1));
+region += SwRect(Point(10010, 10010), Size(1, 1));
+region.Compress(SwRegionRects::CompressExact);
+CPPUNIT_ASSERT_EQUAL(size_t(1), region.size());
+CPPUNIT_ASSERT_EQUAL(SwRect(Point(10, 10), Size(2, 2)), region[0]);
+
+// Check fuzzy compress, two almost aligned rects will be compressed to 
one.
+region = SwRegionRects();
+region += SwRect(Point(10, 10), Size(100, 100));
+region += SwRect(Point(110, 10), Size(100, 90));
+region.Compress(SwRegionRects::CompressExact);
+CPPUNIT_ASSERT_EQUAL(size_t(2), region.size());
+region.Compress(SwRegionRects::CompressFuzzy);
+CPPUNIT_ASSERT_EQUAL(size_t(1), region.size());
+CPPUNIT_ASSERT_EQUAL(SwRect(Point(10, 10), Size(200, 100)), region[0]);
+
+// Check it doesn't crash because of empty size.
+region = SwRegionRects();
+region += SwRect(Point(0, 0), Size(0, 0));
+region += SwRect(Point(10, 10), Size(0, 0));
+region += SwRect(Point(100, 100), Size(0, 0));
+region.Compress(SwRegionRects::CompressExact);
+region.Compress(SwRegionRects::CompressFuzzy);
+}
+
+void RegionUnittest::testInvert()
+{
+// Check that punching holes and inverting has the same result as adding 
up rects.
+const SwRect fullRect(Point(100, 100), Size(1000, 1000));
+const SwRect rects[]
+= { { 

[Libreoffice-commits] core.git: sw/source

[Jim Raykowski (via logerrit)]

 sw/source/uibase/utlui/content.cxx |   10 ++
 1 file changed, 10 insertions(+)

New commits:
commit 8644a3114d412e8de6cc6712c2f2bcad436906c9
Author: Jim Raykowski 
AuthorDate: Tue Sep 21 18:24:38 2021 -0800
Commit: Jim Raykowski 
CommitDate: Wed Sep 22 23:25:35 2021 +0200

tdf#95378 Writer Navigator: Track references

Resolves reference tracking part of the enhancement request.
Makes the Navigator content tree highlight the corresponding
reference item of the reference field at the current cursor
position in the document if there is one.

Change-Id: If10d0cffbf03fcc9a61e573e967e854c428f9b5f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122414
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 

diff --git a/sw/source/uibase/utlui/content.cxx 
b/sw/source/uibase/utlui/content.cxx
index 4a0eea209990..fb8667ead94a 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -3391,6 +3391,16 @@ void SwContentTree::UpdateTracking()
 return;
 }
 
+// references
+if (SwContentAtPos aContentAtPos(IsAttrAtPos::RefMark);
+m_pActiveShell->GetContentAtPos(m_pActiveShell->GetCursorDocPos(), 
aContentAtPos) &&
+!(m_bIsRoot && m_nRootType != ContentTypeId::REFERENCE))
+{
+const SwFormatRefMark& rRefMark = 
aContentAtPos.pFndTextAttr->GetRefMark();
+lcl_SelectByContentTypeAndName(this, *m_xTreeView, 
SwResId(STR_CONTENT_TYPE_REFERENCE),
+   rRefMark.GetRefName());
+return;
+}
 // hyperlinks
 if (SwContentAtPos aContentAtPos(IsAttrAtPos::InetAttr);
 m_pActiveShell->GetContentAtPos(m_pActiveShell->GetCursorDocPos(), 
aContentAtPos) &&

[Libreoffice-commits] core.git: sc/inc sc/source

[Stephan Bergmann (via logerrit)]

 sc/inc/dputil.hxx  |6 +-
 sc/source/core/data/dputil.cxx |5 +++--
 sc/source/core/tool/stylehelper.cxx|9 +++--
 sc/source/ui/dataprovider/dataprovider.cxx |5 +++--
 sc/source/ui/inc/dataprovider.hxx  |3 ++-
 sc/source/ui/vba/vbaworkbooks.cxx  |   11 ++-
 sc/source/ui/vba/vbaworkbooks.hxx  |6 +-
 7 files changed, 31 insertions(+), 14 deletions(-)

New commits:
commit 3b6dd54994ab1e624729cb007a8e3dc2b5f3b891
Author: Stephan Bergmann 
AuthorDate: Wed Sep 22 21:15:20 2021 +0200
Commit: Stephan Bergmann 
CommitDate: Wed Sep 22 23:23:35 2021 +0200

Extend loplugin:stringviewparam to starts/endsWith: sc

Change-Id: Ibda7acf66bd8382de25fae9b4385d655be6ab409
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122490
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/sc/inc/dputil.hxx b/sc/inc/dputil.hxx
index 70fa54e1aa3c..5081c758ab77 100644
--- a/sc/inc/dputil.hxx
+++ b/sc/inc/dputil.hxx
@@ -9,6 +9,10 @@
 
 #pragma once
 
+#include 
+
+#include 
+
 #include 
 #include "scdllapi.h"
 #include "global.hxx"
@@ -20,7 +24,7 @@ enum class ScGeneralFunction;
 class ScDPUtil
 {
 public:
-static bool isDuplicateDimension(const OUString& rName);
+static bool isDuplicateDimension(std::u16string_view rName);
 
 SC_DLLPUBLIC static OUString getSourceDimensionName(std::u16string_view 
rName);
 
diff --git a/sc/source/core/data/dputil.cxx b/sc/source/core/data/dputil.cxx
index b589d4e80156..0f5083f810df 100644
--- a/sc/source/core/data/dputil.cxx
+++ b/sc/source/core/data/dputil.cxx
@@ -20,6 +20,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 #include 
@@ -57,9 +58,9 @@ OUString getSpecialDateName(double fValue, bool bFirst, 
SvNumberFormatter* pForm
 
 }
 
-bool ScDPUtil::isDuplicateDimension(const OUString& rName)
+bool ScDPUtil::isDuplicateDimension(std::u16string_view rName)
 {
-return rName.endsWith("*");
+return o3tl::ends_with(rName, u"*");
 }
 
 OUString ScDPUtil::getSourceDimensionName(std::u16string_view rName)
diff --git a/sc/source/core/tool/stylehelper.cxx 
b/sc/source/core/tool/stylehelper.cxx
index 076e968265ff..7caab7580dec 100644
--- a/sc/source/core/tool/stylehelper.cxx
+++ b/sc/source/core/tool/stylehelper.cxx
@@ -17,7 +17,12 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
+#include 
+
+#include 
+
 #include 
+#include 
 #include 
 
 #include 
@@ -120,9 +125,9 @@ static const ScDisplayNameMap* lcl_GetStyleNameMap( 
SfxStyleFamily nType )
 
 constexpr OUStringLiteral SC_SUFFIX_USER = u" (user)";
 
-static bool lcl_EndsWithUser( const OUString& rString )
+static bool lcl_EndsWithUser( std::u16string_view rString )
 {
-return rString.endsWith(SC_SUFFIX_USER);
+return o3tl::ends_with(rString, SC_SUFFIX_USER);
 }
 
 OUString ScStyleNameConversion::DisplayToProgrammaticName( const OUString& 
rDispName, SfxStyleFamily nType )
diff --git a/sc/source/ui/dataprovider/dataprovider.cxx 
b/sc/source/ui/dataprovider/dataprovider.cxx
index ff0ee8626fef..72f674a7b99d 100644
--- a/sc/source/ui/dataprovider/dataprovider.cxx
+++ b/sc/source/ui/dataprovider/dataprovider.cxx
@@ -11,6 +11,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -266,9 +267,9 @@ ScDBData* ScDBDataManager::getDBData()
 return pDBData;
 }
 
-bool DataProviderFactory::isInternalDataProvider(const OUString& rProvider)
+bool DataProviderFactory::isInternalDataProvider(std::u16string_view rProvider)
 {
-return rProvider.startsWith("org.libreoffice.calc");
+return o3tl::starts_with(rProvider, u"org.libreoffice.calc");
 }
 
 std::shared_ptr DataProviderFactory::getDataProvider(ScDocument* 
pDoc,
diff --git a/sc/source/ui/inc/dataprovider.hxx 
b/sc/source/ui/inc/dataprovider.hxx
index 87022fc34a7e..9f7b2b2e3a50 100644
--- a/sc/source/ui/inc/dataprovider.hxx
+++ b/sc/source/ui/inc/dataprovider.hxx
@@ -10,6 +10,7 @@
 #pragma once
 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -134,7 +135,7 @@ class DataProviderFactory
 {
 private:
 
-static bool isInternalDataProvider(const OUString& rProvider);
+static bool isInternalDataProvider(std::u16string_view rProvider);
 
 public:
 
diff --git a/sc/source/ui/vba/vbaworkbooks.cxx 
b/sc/source/ui/vba/vbaworkbooks.cxx
index 0b8316824033..facfc89fe23c 100644
--- a/sc/source/ui/vba/vbaworkbooks.cxx
+++ b/sc/source/ui/vba/vbaworkbooks.cxx
@@ -30,6 +30,7 @@
 #include "vbaworkbooks.hxx"
 #include 
 
+#include 
 #include 
 #include 
 
@@ -164,13 +165,13 @@ ScVbaWorkbooks::isTextFile( std::u16string_view sType )
 }
 
 bool
-ScVbaWorkbooks::isSpreadSheetFile( const OUString& sType )
+ScVbaWorkbooks::isSpreadSheetFile( std::u16string_view sType )
 {
 // include calc_QPro etc. ? ( not for the moment anyway )
-return sType.startsWith( "calc_MS" )
-  || sType.startsWith( "MS Excel" )
-  || sType.startsWith( "calc8" )
-  || 

[Libreoffice-commits] core.git: include/oox oox/source

[Stephan Bergmann (via logerrit)]

 include/oox/export/shapes.hxx  |3 ++-
 oox/source/drawingml/textfield.cxx |   19 ---
 oox/source/export/shapes.cxx   |   33 +
 3 files changed, 31 insertions(+), 24 deletions(-)

New commits:
commit fcdfdc21b197bb9af1a75348ce912c5d1d47dfba
Author: Stephan Bergmann 
AuthorDate: Wed Sep 22 21:16:12 2021 +0200
Commit: Stephan Bergmann 
CommitDate: Wed Sep 22 23:23:14 2021 +0200

Extend loplugin:stringviewparam to starts/endsWith: oox

Change-Id: I02b4352f02fe32f40c4fe0ab198d8ac094381c7a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122491
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/include/oox/export/shapes.hxx b/include/oox/export/shapes.hxx
index 0f4e264fb1b6..646d462e827b 100644
--- a/include/oox/export/shapes.hxx
+++ b/include/oox/export/shapes.hxx
@@ -22,6 +22,7 @@
 
 #include 
 #include 
+#include 
 #include 
 
 #include 
@@ -67,7 +68,7 @@ namespace oox {
 OOX_DLLPUBLIC css::uno::Reference GetOLEObjectStream(
 css::uno::Reference const& xContext,
 css::uno::Reference const& xObj,
-OUString const& i_rProgID,
+std::u16string_view i_rProgID,
 OUString & o_rMediaType,
 OUString & o_rRelationType,
 OUString & o_rSuffix,
diff --git a/oox/source/drawingml/textfield.cxx 
b/oox/source/drawingml/textfield.cxx
index 0d33da71266d..405a874d8e57 100644
--- a/oox/source/drawingml/textfield.cxx
+++ b/oox/source/drawingml/textfield.cxx
@@ -17,6 +17,10 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
+#include 
+
+#include 
+
 #include 
 
 #include 
@@ -26,6 +30,7 @@
 #include 
 #include 
 
+#include 
 #include 
 #include 
 #include 
@@ -56,11 +61,11 @@ namespace {
  * @param sType the OpenXML field type.
  */
 void lclCreateTextFields( std::vector< Reference< XTextField > > & aFields,
-const Reference< 
XModel > & xModel, const OUString & sType )
+const Reference< 
XModel > & xModel, std::u16string_view sType )
 {
 Reference< XInterface > xIface;
 Reference< XMultiServiceFactory > xFactory( xModel, UNO_QUERY_THROW );
-if( sType.startsWith("datetime"))
+if( o3tl::starts_with(sType, u"datetime"))
 {
 OString s = OUStringToOString( sType, RTL_TEXTENCODING_UTF8);
 OString p( s.pData->buffer + 8 );
@@ -100,22 +105,22 @@ void lclCreateTextFields( std::vector< Reference< 
XTextField > > & aFields,
 TOOLS_WARN_EXCEPTION("oox", "");
 }
 }
-else if ( sType == "slidenum" )
+else if ( sType == u"slidenum" )
 {
 xIface = xFactory->createInstance( 
"com.sun.star.text.TextField.PageNumber" );
 aFields.emplace_back( xIface, UNO_QUERY );
 }
-else if ( sType == "slidecount" )
+else if ( sType == u"slidecount" )
 {
 xIface = xFactory->createInstance( 
"com.sun.star.text.TextField.PageCount" );
 aFields.emplace_back( xIface, UNO_QUERY );
 }
-else if ( sType == "slidename" )
+else if ( sType == u"slidename" )
 {
 xIface = xFactory->createInstance( 
"com.sun.star.text.TextField.PageName" );
 aFields.emplace_back( xIface, uno::UNO_QUERY );
 }
-else if ( sType.startsWith("file") )
+else if ( o3tl::starts_with(sType, u"file") )
 {
 OString s = OUStringToOString( sType, RTL_TEXTENCODING_UTF8);
 OString p( s.pData->buffer + 4 );
@@ -139,7 +144,7 @@ void lclCreateTextFields( std::vector< Reference< 
XTextField > > & aFields,
 xProps->setPropertyValue("FileFormat", makeAny(0));
 }
 }
-else if( sType == "author" )
+else if( sType == u"author" )
 {
 xIface = xFactory->createInstance( 
"com.sun.star.text.TextField.Author" );
 aFields.emplace_back( xIface, UNO_QUERY );
diff --git a/oox/source/export/shapes.cxx b/oox/source/export/shapes.cxx
index 5fc037029456..bc120abe1627 100644
--- a/oox/source/export/shapes.cxx
+++ b/oox/source/export/shapes.cxx
@@ -21,6 +21,7 @@
 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -95,88 +96,88 @@ using ::sax_fastparser::FSHelperPtr;
 
 namespace oox {
 
-static void lcl_ConvertProgID(OUString const& rProgID,
+static void lcl_ConvertProgID(std::u16string_view rProgID,
 OUString & o_rMediaType, OUString & o_rRelationType, OUString & 
o_rFileExtension)
 {
-if (rProgID == "Excel.Sheet.12")
+if (rProgID == u"Excel.Sheet.12")
 {
 o_rMediaType = 
"application/vnd.openxmlformats-officedocument.spreadsheetml.sheet";
 o_rRelationType = oox::getRelationship(Relationship::PACKAGE);
 o_rFileExtension = "xlsx";
 }
-else if (rProgID.startsWith("Excel.SheetBinaryMacroEnabled.12") )
+else if (o3tl::starts_with(rProgID, u"Excel.SheetBinaryMacroEnabled.12") )
 {
 o_rMediaType = 

[Libreoffice-commits] core.git: lotuswordpro/inc lotuswordpro/source

[Stephan Bergmann (via logerrit)]

 lotuswordpro/inc/lwptools.hxx   |3 ++-
 lotuswordpro/source/filter/lwptools.cxx |5 +++--
 2 files changed, 5 insertions(+), 3 deletions(-)

New commits:
commit f8b6d1a2f48ce259ba2e75d41777293dfe23ab11
Author: Stephan Bergmann 
AuthorDate: Wed Sep 22 21:24:51 2021 +0200
Commit: Stephan Bergmann 
CommitDate: Wed Sep 22 23:22:54 2021 +0200

Extend loplugin:stringviewparam to starts/endsWith: lotuswordpro

Change-Id: Ia58c031d1157af271c664948946fa5d8d17a2323
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122493
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/lotuswordpro/inc/lwptools.hxx b/lotuswordpro/inc/lwptools.hxx
index 3ac63055b740..753a9bacdd06 100644
--- a/lotuswordpro/inc/lwptools.hxx
+++ b/lotuswordpro/inc/lwptools.hxx
@@ -69,6 +69,7 @@
 #include "xfilter/xftimestyle.hxx"
 #include 
 #include 
+#include 
 
 // 01/19/2005
 const sal_uInt32 UNITS_PER_INCH = 65536L * 72L;
@@ -97,7 +98,7 @@ public:
 inline static bool IsOddNumber(sal_uInt16 nNumber);
 inline static bool IsEvenNumber(sal_uInt16 nNumber);
 
-static bool isFileUrl(const OString& fileName);
+static bool isFileUrl(std::string_view fileName);
 static OUString convertToFileUrl(const OString& fileName);
 static OUStringDateTimeToOUString(const LtTm& dt);
 
diff --git a/lotuswordpro/source/filter/lwptools.cxx 
b/lotuswordpro/source/filter/lwptools.cxx
index 254d7fc7f6eb..9af6d1b4ffb3 100644
--- a/lotuswordpro/source/filter/lwptools.cxx
+++ b/lotuswordpro/source/filter/lwptools.cxx
@@ -60,6 +60,7 @@
 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -195,9 +196,9 @@ bool LwpTools::IsUnicodePacked(LwpObjectStream* pObjStrm, 
sal_uInt16 len)
 return false;
 }
 
-bool LwpTools::isFileUrl(const OString )
+bool LwpTools::isFileUrl(std::string_view fileName)
 {
-return fileName.startsWith("file://");
+return o3tl::starts_with(fileName, "file://");
 }
 
 OUString LwpTools::convertToFileUrl(const OString )

[Libreoffice-commits] core.git: editeng/source include/editeng

[Stephan Bergmann (via logerrit)]

 editeng/source/uno/unofield.cxx |   35 ---
 include/editeng/unofield.hxx|3 ++-
 2 files changed, 22 insertions(+), 16 deletions(-)

New commits:
commit 59646d3fa4fab037ccedc7ebe765de11d5016f3f
Author: Stephan Bergmann 
AuthorDate: Wed Sep 22 20:28:09 2021 +0200
Commit: Stephan Bergmann 
CommitDate: Wed Sep 22 23:22:26 2021 +0200

Extend loplugin:stringviewparam to starts/endsWith: editeng

Change-Id: Ic275bbd167e69060f6442ceed6c4dd88733d5e1b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122486
Tested-by: Stephan Bergmann 
Reviewed-by: Stephan Bergmann 

diff --git a/editeng/source/uno/unofield.cxx b/editeng/source/uno/unofield.cxx
index 0e1dab6db253..765a40349075 100644
--- a/editeng/source/uno/unofield.cxx
+++ b/editeng/source/uno/unofield.cxx
@@ -17,8 +17,13 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
+#include 
+
+#include 
+
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -893,57 +898,57 @@ sal_Bool SAL_CALL SvxUnoTextField::supportsService( const 
OUString& ServiceName
 return cppu::supportsService( this, ServiceName );
 }
 
-uno::Reference< uno::XInterface > SvxUnoTextCreateTextField( const OUString& 
ServiceSpecifier )
+uno::Reference< uno::XInterface > SvxUnoTextCreateTextField( 
std::u16string_view ServiceSpecifier )
 {
 uno::Reference< uno::XInterface > xRet;
 
 // #i93308# up to OOo 3.2 we used this wrong namespace name with the 
capital T & F. This is
 // fixed since OOo 3.2 but for compatibility we will still provide support 
for the wrong notation.
 
-OUString aFieldType;
-if( (ServiceSpecifier.startsWith( "com.sun.star.text.textfield.", 
 )) ||
-(ServiceSpecifier.startsWith( "com.sun.star.text.TextField.", 
 )) )
+std::u16string_view aFieldType;
+if( (o3tl::starts_with( ServiceSpecifier, u"com.sun.star.text.textfield.", 
 )) ||
+(o3tl::starts_with( ServiceSpecifier, u"com.sun.star.text.TextField.", 
 )) )
 {
 sal_Int32 nId = text::textfield::Type::UNSPECIFIED;
 
-if ( aFieldType == "DateTime" )
+if ( aFieldType == u"DateTime" )
 {
 nId = text::textfield::Type::DATE;
 }
-else if ( aFieldType == "URL" )
+else if ( aFieldType == u"URL" )
 {
 nId = text::textfield::Type::URL;
 }
-else if ( aFieldType == "PageNumber" )
+else if ( aFieldType == u"PageNumber" )
 {
 nId = text::textfield::Type::PAGE;
 }
-else if ( aFieldType == "PageCount" )
+else if ( aFieldType == u"PageCount" )
 {
 nId = text::textfield::Type::PAGES;
 }
-else if ( aFieldType == "SheetName" )
+else if ( aFieldType == u"SheetName" )
 {
 nId = text::textfield::Type::TABLE;
 }
-else if ( aFieldType == "FileName" )
+else if ( aFieldType == u"FileName" )
 {
 nId = text::textfield::Type::EXTENDED_FILE;
 }
-else if (aFieldType == "docinfo.Title" ||
- aFieldType == "DocInfo.Title" )
+else if (aFieldType == u"docinfo.Title" ||
+ aFieldType == u"DocInfo.Title" )
 {
 nId = text::textfield::Type::DOCINFO_TITLE;
 }
-else if ( aFieldType == "Author" )
+else if ( aFieldType == u"Author" )
 {
 nId = text::textfield::Type::AUTHOR;
 }
-else if ( aFieldType == "Measure" )
+else if ( aFieldType == u"Measure" )
 {
 nId = text::textfield::Type::MEASURE;
 }
-else if (aFieldType == "DocInfo.Custom")
+else if (aFieldType == u"DocInfo.Custom")
 {
 nId = text::textfield::Type::DOCINFO_CUSTOM;
 }
diff --git a/include/editeng/unofield.hxx b/include/editeng/unofield.hxx
index 3c0d1650f6cc..fe68cd95c060 100644
--- a/include/editeng/unofield.hxx
+++ b/include/editeng/unofield.hxx
@@ -29,6 +29,7 @@
 
 #include 
 #include 
+#include 
 
 namespace com::sun::star::beans { class XPropertySetInfo; }
 
@@ -39,7 +40,7 @@ class SvxFieldData;
 /// @throws css::uno::Exception
 /// @throws css::uno::RuntimeException
 css::uno::Reference< css::uno::XInterface > EDITENG_DLLPUBLIC 
SvxUnoTextCreateTextField(
-const OUString& ServiceSpecifier );
+std::u16string_view ServiceSpecifier );
 
 class EDITENG_DLLPUBLIC SvxUnoTextField final : public cppu::BaseMutex,
 public ::cppu::OComponentHelper,

[Libreoffice-commits] core.git: sc/qa

[Xisco Fauli (via logerrit)]

 sc/qa/uitest/autofilter/colorfilter.py |   37 +
 sc/qa/uitest/data/autofilter/tdf142579_cond_format.ods |binary
 2 files changed, 37 insertions(+)

New commits:
commit 2dd6c7e5d59126e28bf478439c25f9f4cbc3422c
Author: Xisco Fauli 
AuthorDate: Wed Sep 22 17:04:28 2021 +0200
Commit: Xisco Fauli 
CommitDate: Wed Sep 22 23:20:58 2021 +0200

tdf#142579: sc: Add UItest for cond. format background colors

Change-Id: I81845c062783d59f1e3b9c612da938de42f2a50a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122463
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sc/qa/uitest/autofilter/colorfilter.py 
b/sc/qa/uitest/autofilter/colorfilter.py
index 65a4ca5a483c..0e4fe939c4d6 100644
--- a/sc/qa/uitest/autofilter/colorfilter.py
+++ b/sc/qa/uitest/autofilter/colorfilter.py
@@ -100,4 +100,41 @@ class ColorFilterTest(UITestCase):
 self.assertTrue(is_row_hidden(doc, 6))
 self.assertFalse(is_row_hidden(doc, 7))
 
+def test_tdf142579_conditional_format(self):
+with 
self.ui_test.load_file(get_url_for_data_file("tdf142579_cond_format.ods")) as 
doc:
+
+xGridWin = self.xUITest.getTopFocusWindow().getChild("grid_window")
+xGridWin.executeAction("SELECT", mkPropertyValues({"RANGE": 
"A1:A9"}))
+
+for i in range(8):
+self.assertFalse(is_row_hidden(doc, i))
+
+with 
self.ui_test.execute_modeless_dialog_through_command(".uno:DataFilterStandardFilter")
 as xDialog:
+xField1 = xDialog.getChild("field1")
+xCond1 = xDialog.getChild("cond1")
+
+self.assertEqual("Another", 
get_state_as_dict(xField1)['DisplayText'])
+
+props = {"TEXT": "Background color"}
+actionProps = mkPropertyValues(props)
+xCond1.executeAction("SELECT", actionProps)
+self.assertEqual("Background color", 
get_state_as_dict(xCond1)['DisplayText'])
+
+xColor1 = xDialog.getChild("color1")
+
+# tdf#142579: Without the fix in place, this test would have 
failed with
+# AssertionError: '2' != '1'
+self.assertEqual('2', get_state_as_dict(xColor1)["EntryCount"])
+
+select_pos(xColor1, "0")
+
+self.assertFalse(is_row_hidden(doc, 0))
+self.assertFalse(is_row_hidden(doc, 1))
+self.assertTrue(is_row_hidden(doc, 2))
+self.assertFalse(is_row_hidden(doc, 3))
+self.assertTrue(is_row_hidden(doc, 4))
+self.assertTrue(is_row_hidden(doc, 5))
+self.assertFalse(is_row_hidden(doc, 6))
+self.assertFalse(is_row_hidden(doc, 7))
+
 # vim: set shiftwidth=4 softtabstop=4 expandtab:
diff --git a/sc/qa/uitest/data/autofilter/tdf142579_cond_format.ods 
b/sc/qa/uitest/data/autofilter/tdf142579_cond_format.ods
new file mode 100644
index ..04b5f3f30066
Binary files /dev/null and 
b/sc/qa/uitest/data/autofilter/tdf142579_cond_format.ods differ

[Libreoffice-bugs] [Bug 144671] New: LibreOffice 7.2.1.2 - Writer crashes upon autosave

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144671

Bug ID: 144671
   Summary: LibreOffice 7.2.1.2 - Writer crashes upon autosave
   Product: LibreOffice
   Version: 7.2.1.1 rc
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: max1234...@gmail.com

Using LO v. 7.2.1.2 .

I'm using Writer to edit a 60-page document that contains a number of pictures
and formatted text.

>From time to time (but not all the times), I see Auto-Save taking place (green
progress bar advancing in the bottom of the window) and suddenly the program
crashes.

Fortunately, when I restart Writer, auto-recovery starts and most of the times
I can get my document back (apart from the edits made after the last successful
autosave). That's anoying, however...

Seen in both my laptop and desktop PC, under Windows 10-64bit.

Regards,
Max - Italy

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135310] [META] Writer outline folding bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=135310
Bug 135310 depends on bug 143813, which changed state.

Bug 143813 Summary: Outline folding: copy, cut and paste do not work anymore
https://bugs.documentfoundation.org/show_bug.cgi?id=143813

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 137909] FILESAVE Hang on Save As...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137909

--- Comment #11 from b...@whiteflamegreen.net ---
This is still hapenning in 7.2.0.4 and nothing remotely similar happens in any
other application.

I've uploaded a process sample.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 137909] FILESAVE Hang on Save As...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137909

--- Comment #10 from b...@whiteflamegreen.net ---
Created attachment 175202
  --> https://bugs.documentfoundation.org/attachment.cgi?id=175202=edit
Process sample of hanging app

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sd/source

[Stephan Bergmann (via logerrit)]

 sd/source/core/stlsheet.cxx |   11 ++-
 1 file changed, 6 insertions(+), 5 deletions(-)

New commits:
commit 0a4c883a7e0dd3ba66d8cc86c6f77bd3578a0a92
Author: Stephan Bergmann 
AuthorDate: Wed Sep 22 20:02:06 2021 +0200
Commit: Stephan Bergmann 
CommitDate: Wed Sep 22 22:19:07 2021 +0200

Extend loplugin:stringviewparam to starts/endsWith: sd

Change-Id: Ie7ddfbc7984bfbff22c8c34e30f3ca690da80e7b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122483
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/sd/source/core/stlsheet.cxx b/sd/source/core/stlsheet.cxx
index 533a9846557f..d0ea45f4c640 100644
--- a/sd/source/core/stlsheet.cxx
+++ b/sd/source/core/stlsheet.cxx
@@ -25,6 +25,7 @@
 #include 
 #include 
 
+#include 
 #include 
 #include 
 #include 
@@ -627,14 +628,14 @@ OUString GetApiNameForHelpId(sal_uLong nId)
 return OUString();
 }
 
-sal_uInt32 GetHelpIdForApiName(const OUString& sName)
+sal_uInt32 GetHelpIdForApiName(std::u16string_view sName)
 {
-OUString sRest;
-if (sName.startsWith("outline", ))
+std::u16string_view sRest;
+if (o3tl::starts_with(sName, u"outline", ))
 {
-if (sRest.getLength() == 1)
+if (sRest.length() == 1)
 {
-sal_Unicode ch = sRest.toChar();
+sal_Unicode ch = sRest.front();
 if ('1' <= ch && ch <= '9')
 return HID_PSEUDOSHEET_OUTLINE1 + ch - '1';
 }

[Libreoffice-bugs] [Bug 144602] Calc dropdown lists are unclickable (disappear)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144602

--- Comment #6 from Mehmet Rıza Saraç  ---
Removing libreoffice-kf5 also removes libreoffice-kde, but without kde
integration left click is working normally. I hope the issue will be solved, i
got use to use with integration. But without left click, you can not use color
palette either

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: include/svx svx/source

[Stephan Bergmann (via logerrit)]

 include/svx/unomod.hxx   |6 
 svx/source/customshapes/EnhancedCustomShape2d.cxx|  243 +++
 svx/source/form/datanavi.cxx |5 
 svx/source/inc/datanavi.hxx  |2 
 svx/source/svdraw/presetooxhandleadjustmentrelations.cxx |   15 
 svx/source/svdraw/presetooxhandleadjustmentrelations.hxx |7 
 svx/source/unodraw/unomod.cxx|2 
 7 files changed, 149 insertions(+), 131 deletions(-)

New commits:
commit 51c9d41ca97955dd986cd5fec1aed6fbc6ec1374
Author: Stephan Bergmann 
AuthorDate: Wed Sep 22 19:04:28 2021 +0200
Commit: Stephan Bergmann 
CommitDate: Wed Sep 22 22:06:04 2021 +0200

xtend loplugin:stringviewparam to starts/endsWith: svx

Change-Id: I998b5e7ba3580aabfc454ce3354bffd3d0cb7d61
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122479
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/include/svx/unomod.hxx b/include/svx/unomod.hxx
index dcdbfa8358d5..d786824ebbab 100644
--- a/include/svx/unomod.hxx
+++ b/include/svx/unomod.hxx
@@ -20,6 +20,10 @@
 #ifndef INCLUDED_SVX_UNOMOD_HXX
 #define INCLUDED_SVX_UNOMOD_HXX
 
+#include 
+
+#include 
+
 #include 
 #include 
 #include 
@@ -49,7 +53,7 @@ public:
 
 /// @throws css::uno::Exception
 /// @throws css::uno::RuntimeException
-static css::uno::Reference< css::uno::XInterface > createTextField( const 
OUString& aServiceSpecifier );
+static css::uno::Reference< css::uno::XInterface > createTextField( 
std::u16string_view aServiceSpecifier );
 
 /** fills the given EventObject from the given SdrHint.
 @returns
diff --git a/svx/source/customshapes/EnhancedCustomShape2d.cxx 
b/svx/source/customshapes/EnhancedCustomShape2d.cxx
index 154f2df08c9e..aa67d543c1a0 100644
--- a/svx/source/customshapes/EnhancedCustomShape2d.cxx
+++ b/svx/source/customshapes/EnhancedCustomShape2d.cxx
@@ -19,6 +19,7 @@
 
 #include 
 
+#include 
 #include 
 #include 
 #include 
@@ -58,6 +59,7 @@
 
 #include 
 #include 
+#include 
 #include 
 
 using namespace ::com::sun::star;
@@ -1188,7 +1190,7 @@ bool EnhancedCustomShape2d::GetHandlePosition( const 
sal_uInt32 nIndex, Point& r
 return bRetValue;
 }
 
-static double lcl_getXAdjustmentValue(const OUString& rShapeType, const 
sal_uInt32 nHandleIndex,
+static double lcl_getXAdjustmentValue(std::u16string_view rShapeType, const 
sal_uInt32 nHandleIndex,
   const double fX, const double fW, const 
double fH)
 {
 // degenerated shapes are not worth to calculate special case for each 
shape type
@@ -1196,106 +1198,107 @@ static double lcl_getXAdjustmentValue(const OUString& 
rShapeType, const sal_uInt
 return 5;
 
 // pattern (w - x) / ss * 10 or (r - x) / ss * 10
-if ((rShapeType == "ooxml-bentArrow" && nHandleIndex == 2) || (rShapeType 
== "ooxml-chevron")
-|| (rShapeType == "ooxml-curvedRightArrow") || (rShapeType == 
"ooxml-foldedCorner")
-|| (rShapeType == "ooxml-homePlate") || (rShapeType == 
"ooxml-notchedRightArrow")
-|| (rShapeType == "ooxml-nonIsoscelesTrapezoid" && nHandleIndex == 1)
-|| (rShapeType == "ooxml-rightArrow")
-|| (rShapeType == "ooxml-rightArrowCallout" && nHandleIndex == 2)
-|| (rShapeType == "ooxml-round1Rect")
-|| (rShapeType == "ooxml-round2DiagRect" && nHandleIndex == 1)
-|| (rShapeType == "ooxml-round2SameRect" && nHandleIndex == 0)
-|| (rShapeType == "ooxml-snip1Rect")
-|| (rShapeType == "ooxml-snip2DiagRect" && nHandleIndex == 1)
-|| (rShapeType == "ooxml-snip2SameRect" && nHandleIndex == 0)
-|| (rShapeType == "ooxml-snipRoundRect" && nHandleIndex == 1)
-|| (rShapeType == "ooxml-swooshArrow") || (rShapeType == 
"ooxml-stripedRightArrow"))
+if ((rShapeType == u"ooxml-bentArrow" && nHandleIndex == 2) || (rShapeType 
== u"ooxml-chevron")
+|| (rShapeType == u"ooxml-curvedRightArrow") || (rShapeType == 
u"ooxml-foldedCorner")
+|| (rShapeType == u"ooxml-homePlate") || (rShapeType == 
u"ooxml-notchedRightArrow")
+|| (rShapeType == u"ooxml-nonIsoscelesTrapezoid" && nHandleIndex == 1)
+|| (rShapeType == u"ooxml-rightArrow")
+|| (rShapeType == u"ooxml-rightArrowCallout" && nHandleIndex == 2)
+|| (rShapeType == u"ooxml-round1Rect")
+|| (rShapeType == u"ooxml-round2DiagRect" && nHandleIndex == 1)
+|| (rShapeType == u"ooxml-round2SameRect" && nHandleIndex == 0)
+|| (rShapeType == u"ooxml-snip1Rect")
+|| (rShapeType == u"ooxml-snip2DiagRect" && nHandleIndex == 1)
+|| (rShapeType == u"ooxml-snip2SameRect" && nHandleIndex == 0)
+|| (rShapeType == u"ooxml-snipRoundRect" && nHandleIndex == 1)
+|| (rShapeType == u"ooxml-swooshArrow") || (rShapeType == 
u"ooxml-stripedRightArrow"))
 return (fW - fX) / std::min(fW, fH) * 

[Libreoffice-bugs] [Bug 133009] LibreOffice unusable (nearby freeze) after undo caused by another image being placed on first anchored to the second page

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=133009

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru

--- Comment #8 from Roman Kuznetsov <79045_79...@mail.ru> ---
still rerpo in

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: a9cc066a86c6bd3423c5802c5a4eded55a50c754
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render:
Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 132900] Delay when opening Customize dialog the first time (Windows-only)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132900

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru

--- Comment #22 from Roman Kuznetsov <79045_79...@mail.ru> ---
instantly from Start Center and with 2 sec delay in Writer in

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: a9cc066a86c6bd3423c5802c5a4eded55a50c754
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render:
Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 116280] [META] Regressions introduced by the image handling refactoring

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116280
Bug 116280 depends on bug 131493, which changed state.

Bug 131493 Summary: Performance regression opening presentation with shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=131493

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 131493] Performance regression opening presentation with shapes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131493

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru
 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #4 from Roman Kuznetsov <79045_79...@mail.ru> ---
It takes 4 sec in

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: a9cc066a86c6bd3423c5802c5a4eded55a50c754
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render:
Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: threaded

Xisco please retest it

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 130822] 819-pages ODT continuously slower to open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130822

--- Comment #20 from Roman Kuznetsov <79045_79...@mail.ru> ---
18 sec in

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: a9cc066a86c6bd3423c5802c5a4eded55a50c754
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render:
Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: threaded

I don't think it can be better for a 820-pages document, may be it's time for
closing of this report?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144664] Online Help links contain cyrillic characters mixed with English language text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144664

Julien Nabet  changed:

   What|Removed |Added

   Keywords||topicWeb
 CC||cl...@documentfoundation.or
   ||g, serval2...@yahoo.fr

--- Comment #4 from Julien Nabet  ---
Christian: Following Rafael's comment, perhaps website team may help? I put
"topicWeb", I don't know if it's sufficient.

Searching about pb of localized websites retrieved with a non expected
localization, I found this:
-
https://stackoverflow.com/questions/4417923/html-meta-tag-for-content-language
-
https://developers.google.com/search/docs/advanced/crawling/localized-versions

For the rest, I suppose we may indeed consider this one as NOTABUG.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 84837] Make show/hide comments UNO command work in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=84837

--- Comment #243 from Blaze  ---
Thanks For mAking this page. I learn a lot of information about bugs...!!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: scaddins/source

[Stephan Bergmann (via logerrit)]

 scaddins/source/pricing/pricing.cxx |   26 ++
 1 file changed, 14 insertions(+), 12 deletions(-)

New commits:
commit 3ead1e624514466811d451325d02acd50862c80a
Author: Stephan Bergmann 
AuthorDate: Wed Sep 22 20:02:29 2021 +0200
Commit: Stephan Bergmann 
CommitDate: Wed Sep 22 21:24:21 2021 +0200

Extend loplugin:stringviewparam to starts/endsWith: scaddins

Change-Id: I4e6d9d8f429e9a9133a494790522217638ad18e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122484
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/scaddins/source/pricing/pricing.cxx 
b/scaddins/source/pricing/pricing.cxx
index 83cacff87fc8..3961603bc04b 100644
--- a/scaddins/source/pricing/pricing.cxx
+++ b/scaddins/source/pricing/pricing.cxx
@@ -32,8 +32,10 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
+#include 
 
 using namespace ::com::sun::star;
 using namespace sca::pricing;
@@ -309,10 +311,10 @@ uno::Sequence< sheet::LocalizedName > SAL_CALL 
ScaPricingAddIn::getCompatibility
 // auxiliary input handling functions
 namespace {
 
-bool getinput_putcall(bs::types::PutCall& pc, const OUString& str) {
-if(str.startsWith("c")) {
+bool getinput_putcall(bs::types::PutCall& pc, std::u16string_view str) {
+if(o3tl::starts_with(str, u"c")) {
 pc=bs::types::Call;
-} else if(str.startsWith("p")) {
+} else if(o3tl::starts_with(str, u"p")) {
 pc=bs::types::Put;
 } else {
 return false;
@@ -343,10 +345,10 @@ bool getinput_strike(double& strike, const uno::Any& 
anyval) {
 return true;
 }
 
-bool getinput_inout(bs::types::BarrierKIO& kio, const OUString& str) {
-if(str.startsWith("i")) {
+bool getinput_inout(bs::types::BarrierKIO& kio, std::u16string_view str) {
+if(o3tl::starts_with(str, u"i")) {
 kio=bs::types::KnockIn;
-} else if(str.startsWith("o")) {
+} else if(o3tl::starts_with(str, u"o")) {
 kio=bs::types::KnockOut;
 } else {
 return false;
@@ -354,10 +356,10 @@ bool getinput_inout(bs::types::BarrierKIO& kio, const 
OUString& str) {
 return true;
 }
 
-bool getinput_barrier(bs::types::BarrierActive& cont, const OUString& str) {
-if(str.startsWith("c")) {
+bool getinput_barrier(bs::types::BarrierActive& cont, std::u16string_view str) 
{
+if(o3tl::starts_with(str, u"c")) {
 cont=bs::types::Continuous;
-} else if(str.startsWith("e")) {
+} else if(o3tl::starts_with(str, u"e")) {
 cont=bs::types::Maturity;
 } else {
 return false;
@@ -365,10 +367,10 @@ bool getinput_barrier(bs::types::BarrierActive& cont, 
const OUString& str) {
 return true;
 }
 
-bool getinput_fordom(bs::types::ForDom& fd, const OUString& str) {
-if(str.startsWith("f")) {
+bool getinput_fordom(bs::types::ForDom& fd, std::u16string_view str) {
+if(o3tl::starts_with(str, u"f")) {
 fd=bs::types::Foreign;
-} else if(str.startsWith("d")) {
+} else if(o3tl::starts_with(str, u"d")) {
 fd=bs::types::Domestic;
 } else {
 return false;

[Libreoffice-bugs] [Bug 144666] LO crashes when trying to print any document in Ubuntu 16

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144666

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr
   Keywords||wantBacktrace

--- Comment #3 from Julien Nabet  ---
2 things you can try:
- upgrade to last Ubuntu version 21.04 or at least last LTS (20.04)
- try to retrieve a backtrace (see
https://wiki.documentfoundation.org/QA/BugReport/Debug_Information#GNU.2FLinux:_How_to_get_a_backtrace)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144664] Online Help links contain cyrillic characters mixed with English language text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144664

--- Comment #3 from Rafael Lima  ---
My analysis is that this is NAB. However...

This issue happens very often when we are searching about LibreOffice on
Google. For example, searching for "libreoffice odbc connection" on my PC the
first hit I get is:

https://help.libreoffice.org/latest/he/text/shared/explorer/database/dabawiz02odbc.html

Which is the page in hebrew. But I'm from Brazil and I'm getting a page from a
language that has nothing to do with may location.

Maybe for a similar reason the user that reported this bug ended up finding a
page in Tadjiki and thought it was a bug.

Most users will not figure out that the "tg" part in the URL means the language
of the Help page... they'll will rather conclude that it is a bug.

I wouldn't know how to fix this, but Google indexing has not been good for
LibreOffice. I often find help pages linking to very old versions of LO, or to
pages in other languages. Isn't there anything we could do about that?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: include/sfx2 sfx2/source

[Stephan Bergmann (via logerrit)]

 include/sfx2/classificationhelper.hxx |   26 +-
 include/sfx2/sfxhelp.hxx  |6 +-
 sfx2/source/appl/sfxhelp.cxx  |   13 -
 sfx2/source/doc/graphhelp.cxx |   13 +++--
 sfx2/source/doc/graphhelp.hxx |3 ++-
 sfx2/source/view/classificationhelper.cxx |7 ---
 6 files changed, 43 insertions(+), 25 deletions(-)

New commits:
commit ea29e9936a3e628f95ca4ae1d5816adfce87318f
Author: Stephan Bergmann 
AuthorDate: Wed Sep 22 20:01:38 2021 +0200
Commit: Stephan Bergmann 
CommitDate: Wed Sep 22 21:14:15 2021 +0200

Extend loplugin:stringviewparam to starts/endsWith: sfx2

Change-Id: Icac2c5877059208ed348aa824071803e415f374f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122482
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/include/sfx2/classificationhelper.hxx 
b/include/sfx2/classificationhelper.hxx
index ca9ffc386b5d..5a4fa6b1eeab 100644
--- a/include/sfx2/classificationhelper.hxx
+++ b/include/sfx2/classificationhelper.hxx
@@ -11,8 +11,10 @@
 #define INCLUDED_SFX2_CLASSIFICATIONHELPER_HXX
 
 #include 
+#include 
 #include 
 
+#include 
 #include 
 #include 
 #include 
@@ -100,7 +102,7 @@ public:
 std::vector const& GetIntellectualPropertyPartNumbers() const;
 
 /// Does a best-effort conversion of rType to SfxClassificationPolicyType.
-static SfxClassificationPolicyType stringToPolicyType(const OUString& 
rType);
+static SfxClassificationPolicyType stringToPolicyType(std::u16string_view 
rType);
 /// Returns the string representation of a SfxClassificationPolicyType 
element.
 static const OUString& policyTypeToString(SfxClassificationPolicyType 
eType);
 
@@ -154,16 +156,19 @@ public:
 return makeTextKey() + ":n" + OUString::number(m_nTextNumber++);
 }
 
-bool isMarkingTextKey(OUString const& aKey) const { return 
aKey.startsWith(makeTextKey()); }
+bool isMarkingTextKey(std::u16string_view aKey) const
+{
+return o3tl::starts_with(aKey, makeTextKey());
+}
 
 OUString makeCategoryNameKey() const
 {
 return getPolicyKey() + "BusinessAuthorizationCategory:Name";
 }
 
-bool isCategoryNameKey(OUString const& aKey) const
+bool isCategoryNameKey(std::u16string_view aKey) const
 {
-return aKey.startsWith(makeCategoryNameKey());
+return o3tl::starts_with(aKey, makeCategoryNameKey());
 }
 
 OUString makeCategoryIdentifierKey() const
@@ -171,9 +176,9 @@ public:
 return getPolicyKey() + "BusinessAuthorizationCategory:Identifier";
 }
 
-bool isCategoryIdentifierKey(OUString const& aKey) const
+bool isCategoryIdentifierKey(std::u16string_view aKey) const
 {
-return aKey.startsWith(makeCategoryIdentifierKey());
+return o3tl::starts_with(aKey, makeCategoryIdentifierKey());
 }
 
 OUString makeMarkingKey() const { return getPolicyKey() + 
"Custom:Marking"; }
@@ -183,7 +188,10 @@ public:
 return makeMarkingKey() + ":n" + OUString::number(m_nMarkingNumber++);
 }
 
-bool isMarkingKey(OUString const& aKey) const { return 
aKey.startsWith(makeMarkingKey()); }
+bool isMarkingKey(std::u16string_view aKey) const
+{
+return o3tl::starts_with(aKey, makeMarkingKey());
+}
 
 OUString makeIntellectualPropertyPartKey() const
 {
@@ -195,9 +203,9 @@ public:
 return makeIntellectualPropertyPartKey() + ":n" + 
OUString::number(m_nIPPartNumber++);
 }
 
-bool isIntellectualPropertyPartKey(OUString const& aKey) const
+bool isIntellectualPropertyPartKey(std::u16string_view aKey) const
 {
-return aKey.startsWith(makeIntellectualPropertyPartKey());
+return o3tl::starts_with(aKey, makeIntellectualPropertyPartKey());
 }
 
 OUString makeFullTextualRepresentationKey() const
diff --git a/include/sfx2/sfxhelp.hxx b/include/sfx2/sfxhelp.hxx
index b0f3ff00657f..a8f725d067a6 100644
--- a/include/sfx2/sfxhelp.hxx
+++ b/include/sfx2/sfxhelp.hxx
@@ -19,6 +19,10 @@
 #ifndef INCLUDED_SFX2_SFXHELP_HXX
 #define INCLUDED_SFX2_SFXHELP_HXX
 
+#include 
+
+#include 
+
 #include 
 #include 
 #include 
@@ -34,7 +38,7 @@ private:
 SAL_DLLPRIVATE static bool Start_Impl(const OUString& rURL, weld::Widget* 
pWidget, const OUString& rKeyword);
 SAL_DLLPRIVATE virtual void SearchKeyword( const OUString& rKeyWord ) 
override;
 SAL_DLLPRIVATE virtual bool Start(const OUString& rURL, weld::Widget* 
pWidget = nullptr) override;
-SAL_DLLPRIVATE static OUString GetHelpModuleName_Impl(const OUString 
);
+SAL_DLLPRIVATE static OUString GetHelpModuleName_Impl(std::u16string_view 
rHelpId);
 SAL_DLLPRIVATE static OUString CreateHelpURL_Impl( const OUString& 
aCommandURL, const OUString& rModuleName );
 
 SAL_DLLPRIVATE static bool Start_Impl( const OUString& rURL, const 
vcl::Window* pWindow );
diff --git a/sfx2/source/appl/sfxhelp.cxx 

[Libreoffice-commits] core.git: svgio/inc svgio/source

[Stephan Bergmann (via logerrit)]

 svgio/inc/svgnode.hxx  |3 +-
 svgio/source/svgreader/svgnode.cxx |   41 ++---
 2 files changed, 23 insertions(+), 21 deletions(-)

New commits:
commit 8f2f2a8d131eef60164c0586fb73b69fd950f15d
Author: Stephan Bergmann 
AuthorDate: Wed Sep 22 20:01:06 2021 +0200
Commit: Stephan Bergmann 
CommitDate: Wed Sep 22 21:13:42 2021 +0200

Extend loplugin:stringviewparam to starts/endsWith: svgio

Change-Id: Ia48465b86e6b2e5362b95a2b228414bfc6ac6490
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122481
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/svgio/inc/svgnode.hxx b/svgio/inc/svgnode.hxx
index 93c303fa2df7..63c6b2318406 100644
--- a/svgio/inc/svgnode.hxx
+++ b/svgio/inc/svgnode.hxx
@@ -24,6 +24,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 
@@ -72,7 +73,7 @@ namespace svgio::svgreader
 // helper to convert a string associated with a token of type 
SVGTokenDisplay
 // to the enum Display. Empty strings return the default 
'Display_inline' with
 // which members should be initialized
-Display getDisplayFromContent(const OUString& aContent);
+Display getDisplayFromContent(std::u16string_view aContent);
 
   class Visitor;
 
diff --git a/svgio/source/svgreader/svgnode.cxx 
b/svgio/source/svgreader/svgnode.cxx
index c01539ba389a..3bc3fb76baca 100644
--- a/svgio/source/svgreader/svgnode.cxx
+++ b/svgio/source/svgreader/svgnode.cxx
@@ -21,6 +21,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 
@@ -333,79 +334,79 @@ namespace svgio::svgreader
 }
 }
 
-Display getDisplayFromContent(const OUString& aContent)
+Display getDisplayFromContent(std::u16string_view aContent)
 {
-if(!aContent.isEmpty())
+if(!aContent.empty())
 {
-if(aContent.startsWith("inline"))
+if(o3tl::starts_with(aContent, u"inline"))
 {
 return Display::Inline;
 }
-else if(aContent.startsWith("none"))
+else if(o3tl::starts_with(aContent, u"none"))
 {
 return Display::None;
 }
-else if(aContent.startsWith("inherit"))
+else if(o3tl::starts_with(aContent, u"inherit"))
 {
 return Display::Inherit;
 }
-else if(aContent.startsWith("block"))
+else if(o3tl::starts_with(aContent, u"block"))
 {
 return Display::Block;
 }
-else if(aContent.startsWith("list-item"))
+else if(o3tl::starts_with(aContent, u"list-item"))
 {
 return Display::ListItem;
 }
-else if(aContent.startsWith("run-in"))
+else if(o3tl::starts_with(aContent, u"run-in"))
 {
 return Display::RunIn;
 }
-else if(aContent.startsWith("compact"))
+else if(o3tl::starts_with(aContent, u"compact"))
 {
 return Display::Compact;
 }
-else if(aContent.startsWith("marker"))
+else if(o3tl::starts_with(aContent, u"marker"))
 {
 return Display::Marker;
 }
-else if(aContent.startsWith("table"))
+else if(o3tl::starts_with(aContent, u"table"))
 {
 return Display::Table;
 }
-else if(aContent.startsWith("inline-table"))
+else if(o3tl::starts_with(aContent, u"inline-table"))
 {
 return Display::InlineTable;
 }
-else if(aContent.startsWith("table-row-group"))
+else if(o3tl::starts_with(aContent, u"table-row-group"))
 {
 return Display::TableRowGroup;
 }
-else if(aContent.startsWith("table-header-group"))
+else if(o3tl::starts_with(aContent, u"table-header-group"))
 {
 return Display::TableHeaderGroup;
 }
-else if(aContent.startsWith("table-footer-group"))
+else if(o3tl::starts_with(aContent, u"table-footer-group"))
 {
 return Display::TableFooterGroup;
 }
-else if(aContent.startsWith("table-row"))
+else if(o3tl::starts_with(aContent, u"table-row"))
 {
 return Display::TableRow;
 }
-else if(aContent.startsWith("table-column-group"))
+else if(o3tl::starts_with(aContent, 

[Libreoffice-bugs] [Bug 144215] MAILMERGE: if saved as individual documents - filenames should start from 1 (one), not 0 (zero), also for Print

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144215

Justin L  changed:

   What|Removed |Added

 CC||jl...@mail.com
   Assignee|libreoffice-b...@lists.free |jl...@mail.com
   |desktop.org |

--- Comment #3 from Justin L  ---
Another easier option would be to always set _bStartWithZero to false.

In this case it would export
file.odt
file1.odt
file2.odt
...

But I don't think that would be terribly helpful because then 1 is actually the
second record. Yeah - that really isn't different from the zero case except
that we don't have an explicit zero. So bad idea.

P.S. CppunitTest_sw_mailmerge fails if starting m_value(1) instead of zero.

proposed fix http://gerrit.libreoffice.org/c/core/+/122489 tdf#144215
mailmerge: start individual document at 1, not 0

Adding the _ can be added separately.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144607] Bibliography database option does not open when selected

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144607

Julien Nabet  changed:

   What|Removed |Added

 CC||heiko.tietze@documentfounda
   ||tion.org

--- Comment #19 from Julien Nabet  ---
Heiko/Xisco: in brief, I suppose we need an else case here:

162 if (officecfg::Office::Common::PackageKit::EnableBaseInstallation::get())
163 {
164 try
165 {
166 using namespace org::freedesktop::PackageKit;
167 using namespace svtools;
168 Reference< XSyncDbusSessionHelper >
xSyncDbusSessionHelper(SyncDbusSessionHelper::create(comphelper::getProcessComponentContext()));
169 Sequence< OUString > vPackages { "libreoffice-base" };
170 xSyncDbusSessionHelper->InstallPackageNames(vPackages, OUString());
171 // I'll be back (hopefully)!
172 SolarMutexGuard aGuard;
173 executeRestartDialog(comphelper::getProcessComponentContext(),
nullptr, RESTART_REASON_BIBLIOGRAPHY_INSTALL);
174 }
175 catch (const Exception &)
176 {
177 TOOLS_INFO_EXCEPTION("sfx.appl", "trying to install LibreOffice
Base");
178 }
179 }
180 return;

(See
https://opengrok.libreoffice.org/xref/core/sfx2/source/appl/appserv.cxx?r=e1138605#162)

The else case would contain a dialog indicating something like:
"You need to install Base part to use bibliography."
What do you think?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144670] clipboard problem in LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144670

--- Comment #4 from j22...@gmail.com ---
When downgraded to a previous version, the clipboard works just fine:

Version: 6.4.7.2
Build ID: 1:6.4.7-0ubuntu0.20.04.1
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 130868] Writer hangs when trying to convert specific ODT with footnotes to PDF

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130868

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru

--- Comment #9 from Roman Kuznetsov <79045_79...@mail.ru> ---
Still repro in

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: a9cc066a86c6bd3423c5802c5a4eded55a50c754
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render:
Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: include/svtools svtools/source

[Stephan Bergmann (via logerrit)]

 include/svtools/imageresourceaccess.hxx |3 ++-
 svtools/source/misc/imageresourceaccess.cxx |   11 ++-
 2 files changed, 8 insertions(+), 6 deletions(-)

New commits:
commit 49cee95eb4efddefde9caab33d0a639e83f05202
Author: Stephan Bergmann 
AuthorDate: Wed Sep 22 19:05:10 2021 +0200
Commit: Stephan Bergmann 
CommitDate: Wed Sep 22 20:44:36 2021 +0200

xtend loplugin:stringviewparam to starts/endsWith: svtools

Change-Id: I5364107766dd77963a9a34468754c4cbcc34c8d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122480
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/include/svtools/imageresourceaccess.hxx 
b/include/svtools/imageresourceaccess.hxx
index ccb5b6b69bce..ca76c0909f17 100644
--- a/include/svtools/imageresourceaccess.hxx
+++ b/include/svtools/imageresourceaccess.hxx
@@ -22,6 +22,7 @@
 #include 
 
 #include 
+#include 
 
 #include 
 #include 
@@ -41,7 +42,7 @@ namespace svt::GraphicAccess
 */
 
 /** determines whether the given URL denotes an image within a resource */
-UNLESS_MERGELIBS(SVT_DLLPUBLIC) bool isSupportedURL(OUString const & rURL);
+UNLESS_MERGELIBS(SVT_DLLPUBLIC) bool isSupportedURL(std::u16string_view rURL);
 
 /** for a given URL of an image within a resource, this method retrieves an
 SvStream for this image.
diff --git a/svtools/source/misc/imageresourceaccess.cxx 
b/svtools/source/misc/imageresourceaccess.cxx
index 24db4ae50ac3..fc12981a3460 100644
--- a/svtools/source/misc/imageresourceaccess.cxx
+++ b/svtools/source/misc/imageresourceaccess.cxx
@@ -25,6 +25,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -106,12 +107,12 @@ sal_Int64 SAL_CALL StreamSupplier::getLength()
 return m_xSeekable->getLength();
 }
 
-bool isSupportedURL(OUString const & rURL)
+bool isSupportedURL(std::u16string_view rURL)
 {
-return rURL.startsWith("private:resource/")
-|| rURL.startsWith("private:graphicrepository/")
-|| rURL.startsWith("private:standardimage/")
-|| rURL.startsWith("vnd.sun.star.extension://");
+return o3tl::starts_with(rURL, u"private:resource/")
+|| o3tl::starts_with(rURL, u"private:graphicrepository/")
+|| o3tl::starts_with(rURL, u"private:standardimage/")
+|| o3tl::starts_with(rURL, u"vnd.sun.star.extension://");
 }
 
 std::unique_ptr 
getImageStream(uno::Reference const & rxContext, 
OUString const & rImageResourceURL)

[Libreoffice-bugs] [Bug 144577] MACRO RUN in Calc 6.4.7.2 but doesn't run in 7.1.5.2

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144577

Juan P.  changed:

   What|Removed |Added

 Resolution|--- |NOTABUG
 Status|UNCONFIRMED |RESOLVED

--- Comment #5 from Juan P.  ---
Hello,

I uninstalled my version of LibreOffice (7.1.5.2 installed automatically with
Kubuntu 21.04) and installed this version of LibreOffice from the web, with
Spanish compatibility:

Version: 7.2.1.2 / LibreOffice Community
Build ID: 87b77fad49947c1441b67c559c339af8f3517e22
CPU threads: 2; OS: Linux 5.11; UI Processing - Default; VCL: kf5 (cairo + xcb)
Regional settings: es-CO (es_CO.UTF-8); UI: en-US
Calc: threaded

And my MACRO works perfectly. I think the problem was the compatibility of
regional setting of my older version, specifically in the date (dd/mm/).

Thank you very much for your attention. Sorry for this bogus bug report.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: compilerplugins/clang

[Stephan Bergmann (via logerrit)]

 compilerplugins/clang/test/consttobool.cxx |2 +-
 compilerplugins/clang/test/cppunitassertequals.cxx |2 +-
 compilerplugins/clang/test/redundantcast.cxx   |2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 27f3618a66e59d6b45e22f0eb46457172a52
Author: Stephan Bergmann 
AuthorDate: Wed Sep 22 16:05:17 2021 +0200
Commit: Stephan Bergmann 
CommitDate: Wed Sep 22 20:24:14 2021 +0200

Adapt to Clang 14 trunk change in diagnostics



"Print nullptr_t namespace qualified within std::"

Change-Id: Idb3ebceadfa5a831429b8c3239de426e599eb9c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122459
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/compilerplugins/clang/test/consttobool.cxx 
b/compilerplugins/clang/test/consttobool.cxx
index 3d880cb4d5d1..4fe41a8140f2 100644
--- a/compilerplugins/clang/test/consttobool.cxx
+++ b/compilerplugins/clang/test/consttobool.cxx
@@ -28,7 +28,7 @@ constexpr int c2 = 2;
 struct S
 {
 S()
-// expected-error-re@+1 {{implicit conversion of constant {{nullptr|0}} of 
type 'nullptr_t' to 'bool'; use 'false' instead [loplugin:consttobool]}}
+// expected-error-re@+1 {{implicit conversion of constant {{nullptr|0}} of 
type '{{(std::)?}}nullptr_t' to 'bool'; use 'false' instead 
[loplugin:consttobool]}}
 : b(nullptr)
 {
 }
diff --git a/compilerplugins/clang/test/cppunitassertequals.cxx 
b/compilerplugins/clang/test/cppunitassertequals.cxx
index 9fe35cfc6919..48bea83f6088 100644
--- a/compilerplugins/clang/test/cppunitassertequals.cxx
+++ b/compilerplugins/clang/test/cppunitassertequals.cxx
@@ -55,7 +55,7 @@ void test(
 // very meaningful, so let it use CPPUNIT_ASSERT (but stick to 
CPPUNIT_ASSERT_EQUAL for
 // consistency in the unlikely case that P is of type std::nullptr_t):
 CPPUNIT_ASSERT(p == nullptr);
-CPPUNIT_ASSERT(n == nullptr); // expected-error {{rather call 
CPPUNIT_ASSERT_EQUAL when comparing 'std::nullptr_t' (aka 'nullptr_t') and 
'nullptr_t' (or rewrite as an explicit operator == call when the operator 
itself is the topic) [loplugin:cppunitassertequals]}}
+CPPUNIT_ASSERT(n == nullptr); // expected-error-re {{rather call 
CPPUNIT_ASSERT_EQUAL when comparing 'std::nullptr_t'{{( \(aka 'nullptr_t'\))?}} 
and '{{(std::)?}}nullptr_t' (or rewrite as an explicit operator == call when 
the operator itself is the topic) [loplugin:cppunitassertequals]}}
 
 // There might even be good reasons(?) not to warn inside explicit casts:
 CPPUNIT_ASSERT(bool(b1 && b2));
diff --git a/compilerplugins/clang/test/redundantcast.cxx 
b/compilerplugins/clang/test/redundantcast.cxx
index 2a3721bb0c2e..319365d3676b 100644
--- a/compilerplugins/clang/test/redundantcast.cxx
+++ b/compilerplugins/clang/test/redundantcast.cxx
@@ -42,7 +42,7 @@ void testConstCast() {
 
 void * vp = nullptr;
 (void) const_cast(static_cast(vp)); // 
expected-error {{redundant static_cast/const_cast combination from 'void *' via 
'const char *' to 'char *' [loplugin:redundantcast]}}
-(void) const_cast(static_cast(nullptr)); // 
expected-error {{redundant static_cast/const_cast combination from 'nullptr_t' 
via 'const char *' to 'char *' [loplugin:redundantcast]}}
+(void) const_cast(static_cast(nullptr)); // 
expected-error-re {{redundant static_cast/const_cast combination from 
'{{(std::)?}}nullptr_t' via 'const char *' to 'char *' 
[loplugin:redundantcast]}}
 (void) const_cast(static_cast(D{})); // expected-error 
{{redundant static_cast/const_cast combination from 'D' via 'const S &' to 'S 
&' [loplugin:redundantcast]}}
 
 S const s{};

[Libreoffice-bugs] [Bug 144668] Customized number format lost on save and re-open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144668

--- Comment #1 from John  ---
I returned to a document saved in 6.4.7.2 an opened with 6.3.3.2 and noted
under customize the before and after are there but they are reversed.  Before
shows [ and After shows 000]

They are not perfectly reversed but there is data in the fields.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103182
Bug 103182 depends on bug 142704, which changed state.

Bug 142704 Summary: %PRODUCTNAME shown in extended tips
https://bugs.documentfoundation.org/show_bug.cgi?id=142704

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 121601] [NEWHELP] Sort content and result of index search in Online Help

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121601

Rafael Lima  changed:

   What|Removed |Added

 CC||rafael.palma.l...@gmail.com

--- Comment #4 from Rafael Lima  ---
(In reply to Buovjaga from comment #3)
> Btw. I'd like to switch from fuzzysearch to
> https://github.com/nextapps-de/flexsearch/ at some point. I already use it
> in the libreoffice.org prototype.

The search mechanism is only part of the problem. I believe there is some
issues with how bookmarks are grouped.

Recently there was a patch that tried to fix grouping:
https://gerrit.libreoffice.org/c/help/+/122312

But it revealed some other issues. See bug 123506 comment #6 for a discussion
on this topic.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/unx

[Caolán McNamara (via logerrit)]

 vcl/unx/gtk3/gtkinst.cxx |   12 
 1 file changed, 12 insertions(+)

New commits:
commit c9b19f69e658f1114f1b8fc0ae62b6edd6d33e3f
Author: Caolán McNamara 
AuthorDate: Wed Sep 22 16:26:00 2021 +0100
Commit: Caolán McNamara 
CommitDate: Wed Sep 22 20:20:09 2021 +0200

Resolves: tdf#142704 %PRODUCTNAME shown in gtk3 extended tips

Change-Id: I61d8b83ce326816c498f54e3cfc053270d82c1a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122475
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index 2131dbabb24a..babd59e3403f 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -21788,6 +21788,18 @@ private:
 gtk_widget_hide(pWidget);
 }
 
+#if !GTK_CHECK_VERSION(4, 0, 0)
+// tdf#142704 %PRODUCTNAME shown in extended tips
+AtkObject* pAtkObject = gtk_widget_get_accessible(pWidget);
+const char* pDesc = pAtkObject ? 
atk_object_get_description(pAtkObject) : nullptr;
+if (pDesc && pDesc[0])
+{
+OUString aDesc(pDesc, strlen(pDesc), RTL_TEXTENCODING_UTF8);
+aDesc = (*m_pStringReplace)(aDesc);
+atk_object_set_description(pAtkObject, OUStringToOString(aDesc, 
RTL_TEXTENCODING_UTF8).getStr());
+}
+#endif
+
 // expand placeholder and collect potentially missing mnemonics
 if (GTK_IS_BUTTON(pWidget))
 {

[Libreoffice-bugs] [Bug 144666] LO crashes when trying to print any document in Ubuntu 16

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144666

--- Comment #2 from Len Testa  ---
The bug does not occur when using LO 7.1.6.2.  However, I must run the
following command in order to get that version of LO to run:

export SAL_USE_VCLPLUGIN=gen

If I don't issue that command or I use 'kf5' instead of 'gen' then LO crashes
after displaying the startup screen.



Version info:
Version: 7.1.6.2 / LibreOffice Community
Build ID: 0e133318fcee89abacd6a7d077e292f1145735c3
CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: x11
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144670] clipboard problem in LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144670

--- Comment #3 from j22...@gmail.com ---
Funnily enough, it actually works when I copy/paste the information from the 
Help -> "About LibreOffice" 
dialog (?)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144670] clipboard problem in LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144670

--- Comment #2 from j22...@gmail.com ---
Created attachment 175200
  --> https://bugs.documentfoundation.org/attachment.cgi?id=175200=edit
video showing the issue

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144670] clipboard problem in LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144670

--- Comment #1 from j22...@gmail.com ---
(note, I put '7.2.1.1 rc' in the description because the drop-down list did not
include the 7.2.1.2 version

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: ucb/source

[Stephan Bergmann (via logerrit)]

 ucb/source/ucp/hierarchy/hierarchydatasource.cxx |9 +
 ucb/source/ucp/hierarchy/hierarchydatasource.hxx |3 ++-
 ucb/source/ucp/tdoc/tdoc_content.cxx |   11 ++-
 ucb/source/ucp/tdoc/tdoc_content.hxx |   10 +++---
 ucb/source/ucp/tdoc/tdoc_provider.cxx|4 ++--
 ucb/source/ucp/tdoc/tdoc_provider.hxx|8 ++--
 ucb/source/ucp/webdav-neon/DAVProperties.cxx |   16 
 ucb/source/ucp/webdav-neon/DAVProperties.hxx |6 +-
 8 files changed, 41 insertions(+), 26 deletions(-)

New commits:
commit 7885c1cb80568930270e55b3ae450eccc66aca94
Author: Stephan Bergmann 
AuthorDate: Wed Sep 22 17:17:16 2021 +0200
Commit: Stephan Bergmann 
CommitDate: Wed Sep 22 20:00:17 2021 +0200

Extend loplugin:stringviewparam to starts/endsWith: ucb

Change-Id: I086d02ec4a2ea6d4b439ec34665d8271a67c63dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122472
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/ucb/source/ucp/hierarchy/hierarchydatasource.cxx 
b/ucb/source/ucp/hierarchy/hierarchydatasource.cxx
index a74524e70f35..8e77576134bb 100644
--- a/ucb/source/ucp/hierarchy/hierarchydatasource.cxx
+++ b/ucb/source/ucp/hierarchy/hierarchydatasource.cxx
@@ -39,6 +39,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 
@@ -443,18 +444,18 @@ HierarchyDataSource::getConfigProvider()
 
 
 bool HierarchyDataSource::createConfigPath(
-const OUString & rInPath, OUString & rOutPath )
+std::u16string_view rInPath, OUString & rOutPath )
 {
-if ( !rInPath.isEmpty() )
+if ( !rInPath.empty() )
 {
-if ( rInPath.startsWith( "/" ) )
+if ( o3tl::starts_with( rInPath, u"/" ) )
 {
 OSL_FAIL( "HierarchyDataSource::createConfigPath - "
 "Leading slash in node path!" );
 return false;
 }
 
-if ( rInPath.endsWith( "/" ) )
+if ( o3tl::ends_with( rInPath, u"/" ) )
 {
 OSL_FAIL( "HierarchyDataSource::createConfigPath - "
 "Trailing slash in node path!" );
diff --git a/ucb/source/ucp/hierarchy/hierarchydatasource.hxx 
b/ucb/source/ucp/hierarchy/hierarchydatasource.hxx
index 9806f98f8036..24b3a18491d6 100644
--- a/ucb/source/ucp/hierarchy/hierarchydatasource.hxx
+++ b/ucb/source/ucp/hierarchy/hierarchydatasource.hxx
@@ -27,6 +27,7 @@
 #include 
 #include 
 #include 
+#include 
 
 namespace comphelper { class OInterfaceContainerHelper2; }
 
@@ -75,7 +76,7 @@ private:
 
 css::uno::Reference< css::lang::XMultiServiceFactory > getConfigProvider();
 
-static bool createConfigPath( const OUString & rInPath, OUString & 
rOutPath );
+static bool createConfigPath( std::u16string_view rInPath, OUString & 
rOutPath );
 };
 
 } // namespace hierarchy_ucp
diff --git a/ucb/source/ucp/tdoc/tdoc_content.cxx 
b/ucb/source/ucp/tdoc/tdoc_content.cxx
index dcb800ee91c8..5a1335e1efc9 100644
--- a/ucb/source/ucp/tdoc/tdoc_content.cxx
+++ b/ucb/source/ucp/tdoc/tdoc_content.cxx
@@ -28,6 +28,7 @@
 
 #include 
 
+#include 
 #include 
 #include 
 #include 
@@ -1709,7 +1710,7 @@ void Content::notifyDocumentClosed()
 
 
 uno::Reference< ucb::XContent >
-Content::queryChildContent( const OUString & rRelativeChildUri )
+Content::queryChildContent( std::u16string_view rRelativeChildUri )
 {
 osl::Guard< osl::Mutex > aGuard( m_aMutex );
 
@@ -1717,10 +1718,10 @@ Content::queryChildContent( const OUString & 
rRelativeChildUri )
 OUStringBuffer aBuf( aMyId );
 if ( !aMyId.endsWith("/") )
 aBuf.append( "/" );
-if ( !rRelativeChildUri.startsWith("/") )
+if ( !o3tl::starts_with(rRelativeChildUri, u"/") )
 aBuf.append( rRelativeChildUri );
 else
-aBuf.append( rRelativeChildUri.subView(1) );
+aBuf.append( rRelativeChildUri.substr(1) );
 
 uno::Reference< ucb::XContentIdentifier > xChildId
 = new ::ucbhelper::ContentIdentifier( aBuf.makeStringAndClear() );
@@ -1741,7 +1742,7 @@ Content::queryChildContent( const OUString & 
rRelativeChildUri )
 }
 
 
-void Content::notifyChildRemoved( const OUString & rRelativeChildUri )
+void Content::notifyChildRemoved( std::u16string_view rRelativeChildUri )
 {
 osl::ClearableGuard< osl::Mutex > aGuard( m_aMutex );
 
@@ -1765,7 +1766,7 @@ void Content::notifyChildRemoved( const OUString & 
rRelativeChildUri )
 }
 
 
-void Content::notifyChildInserted( const OUString & rRelativeChildUri )
+void Content::notifyChildInserted( std::u16string_view rRelativeChildUri )
 {
 osl::ClearableGuard< osl::Mutex > aGuard( m_aMutex );
 
diff --git a/ucb/source/ucp/tdoc/tdoc_content.hxx 
b/ucb/source/ucp/tdoc/tdoc_content.hxx
index 56117b1b0853..9a920c1bb376 100644
--- a/ucb/source/ucp/tdoc/tdoc_content.hxx
+++ b/ucb/source/ucp/tdoc/tdoc_content.hxx
@@ -19,6 +19,10 @@
 
 #pragma once
 
+#include 
+
+#include 
+
 #include 
 #include 
 

[Libreoffice-commits] core.git: sw/inc sw/source

[Stephan Bergmann (via logerrit)]

 sw/inc/iodetect.hxx  |6 ++-
 sw/source/core/tox/tox.cxx   |6 ++-
 sw/source/core/unocore/unostyle.cxx  |8 ++--
 sw/source/filter/ww8/docxattributeoutput.cxx |   51 ++-
 sw/source/filter/ww8/docxattributeoutput.hxx |4 +-
 sw/source/filter/ww8/rtfexport.cxx   |   11 -
 sw/source/filter/ww8/ww8par5.cxx |6 ++-
 sw/source/ui/envelp/envfmt.cxx   |7 ++-
 sw/source/ui/envelp/envfmt.hxx   |6 ++-
 sw/source/uibase/inc/unotools.hxx|6 ++-
 sw/source/uibase/utlui/unotools.cxx  |   14 +--
 11 files changed, 78 insertions(+), 47 deletions(-)

New commits:
commit d1e14030e81ff2bbe4bcb3706a9f21672a368074
Author: Stephan Bergmann 
AuthorDate: Wed Sep 22 17:18:06 2021 +0200
Commit: Stephan Bergmann 
CommitDate: Wed Sep 22 19:59:56 2021 +0200

Extend loplugin:stringviewparam to starts/endsWith: sw

Change-Id: I7271bba6c61a56be15335c81d8950a29a07eb6d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122473
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/sw/inc/iodetect.hxx b/sw/inc/iodetect.hxx
index 1d5713aaccab..9069b01ffda0 100644
--- a/sw/inc/iodetect.hxx
+++ b/sw/inc/iodetect.hxx
@@ -21,6 +21,8 @@
 #define INCLUDED_SW_INC_IODETECT_HXX
 
 #include 
+#include 
+#include 
 #include 
 #include 
 #include 
@@ -59,9 +61,9 @@ struct SwIoDetect
 {
 }
 
-bool IsFilter( const OUString& rNm ) const
+bool IsFilter( std::u16string_view rNm ) const
 {
-return rNm.startsWith(sName);
+return o3tl::starts_with(rNm, sName);
 }
 };
 
diff --git a/sw/source/core/tox/tox.cxx b/sw/source/core/tox/tox.cxx
index f24cfdaab814..65462bf44f80 100644
--- a/sw/source/core/tox/tox.cxx
+++ b/sw/source/core/tox/tox.cxx
@@ -35,9 +35,11 @@
 
 #include 
 #include 
+#include 
 #include 
 
 #include 
+#include 
 
 
 using namespace std;
@@ -756,7 +758,7 @@ OUString SwFormToken::GetString() const
 
@return the type of the token
 */
-static FormTokenType lcl_GetTokenType(const OUString & sToken,
+static FormTokenType lcl_GetTokenType(std::u16string_view sToken,
   sal_Int32 & rTokenLen)
 {
 static struct
@@ -779,7 +781,7 @@ static FormTokenType lcl_GetTokenType(const OUString & 
sToken,
 
 for(const auto & i : aTokenArr)
 {
-if( sToken.startsWith( i.sTokenStart ) )
+if( o3tl::starts_with( sToken, i.sTokenStart ) )
 {
 rTokenLen = i.nTokenLength;
 return i.eTokenType;
diff --git a/sw/source/core/unocore/unostyle.cxx 
b/sw/source/core/unocore/unostyle.cxx
index 0a93658920a1..48510356b54c 100644
--- a/sw/source/core/unocore/unostyle.cxx
+++ b/sw/source/core/unocore/unostyle.cxx
@@ -20,6 +20,7 @@
 #include 
 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -115,6 +116,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 using namespace css;
@@ -2468,12 +2470,12 @@ beans::PropertyState SwXStyle::getPropertyState(const 
OUString& rPropertyName)
 
 // allow to retarget the SfxItemSet working on, default correctly. Only
 // use pSourceSet below this point (except in header/footer processing)
-static const SfxItemSet* lcl_GetItemsetForProperty(const SfxItemSet& rSet, 
SfxStyleFamily eFamily, const OUString& rPropertyName)
+static const SfxItemSet* lcl_GetItemsetForProperty(const SfxItemSet& rSet, 
SfxStyleFamily eFamily, std::u16string_view rPropertyName)
 {
 if(eFamily != SfxStyleFamily::Page)
 return 
-const bool isFooter = rPropertyName.startsWith("Footer");
-if(!isFooter && !rPropertyName.startsWith("Header") && rPropertyName != 
UNO_NAME_FIRST_IS_SHARED)
+const bool isFooter = o3tl::starts_with(rPropertyName, u"Footer");
+if(!isFooter && !o3tl::starts_with(rPropertyName, u"Header") && 
rPropertyName != u"" UNO_NAME_FIRST_IS_SHARED)
 return 
 const SvxSetItem* pSetItem;
 if(!lcl_GetHeaderFooterItem(rSet, rPropertyName, isFooter, pSetItem))
diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx 
b/sw/source/filter/ww8/docxattributeoutput.cxx
index f764fe980c0c..a78211445782 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -138,6 +138,7 @@
 #include 
 #include 
 
+#include 
 #include 
 #include 
 #include 
@@ -152,6 +153,7 @@
 #include 
 
 #include 
+#include 
 #include 
 #include 
 
@@ -1787,33 +1789,34 @@ void 
DocxAttributeOutput::DoWriteBookmarksEnd(std::vector& rEnds)
 // - "permission-for-user::"
 // - "permission-for-group::"
 //
-void DocxAttributeOutput::DoWritePermissionTagStart(const OUString & 
permission)
+void DocxAttributeOutput::DoWritePermissionTagStart(std::u16string_view 
permission)
 {
-OUString permissionIdAndName;
+std::u16string_view permissionIdAndName;
 
-if (permission.startsWith("permission-for-group:", ))
+if 

[Libreoffice-bugs] [Bug 144670] New: clipboard problem in LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144670

Bug ID: 144670
   Summary: clipboard problem in LO
   Product: LibreOffice
   Version: 7.2.1.1 rc
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: j22...@gmail.com

Description:
I can't copy/paste within LibreOffice Writer (it works fine outside LO).


Steps to Reproduce:
1. open a Writer file and write something (eg "something")
2. copy any text using CRTL+C (or Edit->Copy)
3. try to past it (CTRL+V or Edit->Paste)


Actual Results:
What is pasted is anything that was in the clipboard before (eg not "something"
but anything else). 

Expected Results:
The word "something" should have been pasted.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
The problem is between LO and my clipboard. In order to investigate a bit more,
I installed a clipboard manager (qlipper) and apparently the text does get
copied into the clipboard (at least I see it as an entry in qlipper) but it is
not inserted when the "paste" command is issue. 
Outside LO there is not problem, ie normal behavior or copy/paste. This leaves
out "OS problem". But maybe it is the combination of OS+LO?


Version: 7.2.1.2 / LibreOffice Community
Build ID: 20(Build:2)
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Ubuntu package version: 1:7.2.1~rc2-0ubuntu0.20.04.1~lo3
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: unodevtools/inc unodevtools/source

[Stephan Bergmann (via logerrit)]

 unodevtools/inc/options.hxx|4 +++-
 unodevtools/source/unodevtools/options.cxx |7 ---
 2 files changed, 7 insertions(+), 4 deletions(-)

New commits:
commit 743e6aa211ccd631c811fb57e2050a5b4e8ffbba
Author: Stephan Bergmann 
AuthorDate: Wed Sep 22 17:16:30 2021 +0200
Commit: Stephan Bergmann 
CommitDate: Wed Sep 22 19:59:35 2021 +0200

Extend loplugin:stringviewparam to starts/endsWith: unodevtools

Change-Id: I89e559d3956bb0b4b59314d55a3ca57d087b8146
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122471
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/unodevtools/inc/options.hxx b/unodevtools/inc/options.hxx
index d9b557d06a28..5094a11ef5e1 100644
--- a/unodevtools/inc/options.hxx
+++ b/unodevtools/inc/options.hxx
@@ -21,6 +21,8 @@
 
 #include 
 
+#include 
+
 #include 
 
 namespace unodevtools {
@@ -32,7 +34,7 @@ bool readOption( OUString * pValue, const char * pOpt,
 
 
 bool readOption( const char * pOpt,
- sal_uInt32 * pnIndex, const OUString & aArg);
+ sal_uInt32 * pnIndex, std::u16string_view aArg);
 
 } // end of namespace unodevtools
 
diff --git a/unodevtools/source/unodevtools/options.cxx 
b/unodevtools/source/unodevtools/options.cxx
index eb34e723c38a..8cd2b652f8b0 100644
--- a/unodevtools/source/unodevtools/options.cxx
+++ b/unodevtools/source/unodevtools/options.cxx
@@ -20,6 +20,7 @@
 #include 
 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -66,12 +67,12 @@ bool readOption( OUString * pValue, const char * pOpt,
 
 
 bool readOption( const char * pOpt,
- sal_uInt32 * pnIndex, const OUString & aArg)
+ sal_uInt32 * pnIndex, std::u16string_view aArg)
 {
 OUString aOpt = OUString::createFromAscii(pOpt);
 
-if((aArg.startsWith("-") && aOpt.equalsIgnoreAsciiCase(aArg.subView(1))) ||
-   (aArg.startsWith("--") && aOpt.equalsIgnoreAsciiCase(aArg.subView(2))) )
+if((o3tl::starts_with(aArg, u"-") && 
aOpt.equalsIgnoreAsciiCase(aArg.substr(1))) ||
+   (o3tl::starts_with(aArg, u"--") && 
aOpt.equalsIgnoreAsciiCase(aArg.substr(2))) )
 {
 ++(*pnIndex);
 SAL_INFO("unodevtools", "identified option --" << pOpt);

[Libreoffice-commits] core.git: xmlsecurity/source

[Stephan Bergmann (via logerrit)]

 xmlsecurity/source/helper/ooxmlsecexporter.cxx |   12 +++-
 1 file changed, 7 insertions(+), 5 deletions(-)

New commits:
commit 924e0774a8201651a762394d51a964a4f8a0c566
Author: Stephan Bergmann 
AuthorDate: Wed Sep 22 17:13:59 2021 +0200
Commit: Stephan Bergmann 
CommitDate: Wed Sep 22 19:58:55 2021 +0200

Extend loplugin:stringviewparam to starts/endsWith: xmlsecurity

Change-Id: I8a08b0382121355c70284c2e85375ba6c3671553
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122468
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/xmlsecurity/source/helper/ooxmlsecexporter.cxx 
b/xmlsecurity/source/helper/ooxmlsecexporter.cxx
index 324657a96ee0..a202cda19cef 100644
--- a/xmlsecurity/source/helper/ooxmlsecexporter.cxx
+++ b/xmlsecurity/source/helper/ooxmlsecexporter.cxx
@@ -20,6 +20,7 @@
 #include 
 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -55,7 +56,7 @@ public:
 }
 
 /// Should we intentionally not sign this stream?
-static bool isOOXMLDenylist(const OUString& rStreamName);
+static bool isOOXMLDenylist(std::u16string_view rStreamName);
 /// Should we intentionally not sign this relation type?
 static bool isOOXMLRelationDenylist(const OUString& rRelationName);
 
@@ -85,16 +86,17 @@ public:
 void writeSignatureLineImages();
 };
 
-bool OOXMLSecExporter::Impl::isOOXMLDenylist(const OUString& rStreamName)
+bool OOXMLSecExporter::Impl::isOOXMLDenylist(std::u16string_view rStreamName)
 {
 static const std::initializer_list vDenylist
 = { u"/%5BContent_Types%5D.xml", u"/docProps/app.xml", 
u"/docProps/core.xml",
 // Don't attempt to sign other signatures for now.
 u"/_xmlsignatures" };
 // Just check the prefix, as we don't care about the content type part of 
the stream name.
-return std::any_of(
-vDenylist.begin(), vDenylist.end(),
-[&](const std::u16string_view& rLiteral) { return 
rStreamName.startsWith(rLiteral); });
+return std::any_of(vDenylist.begin(), vDenylist.end(),
+   [&](const std::u16string_view& rLiteral) {
+   return o3tl::starts_with(rStreamName, rLiteral);
+   });
 }
 
 bool OOXMLSecExporter::Impl::isOOXMLRelationDenylist(const OUString& 
rRelationName)

[Libreoffice-bugs] [Bug 143358] EDITING Inserting a new row to a table is not recorded as tracked change

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143358

László Németh  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
   Assignee|nem...@numbertext.org   |libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143002] [META] Tracked Changes of tables

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143002
Bug 143002 depends on bug 143358, which changed state.

Bug 143358 Summary: EDITING Inserting a new row to a table is not recorded as 
tracked change
https://bugs.documentfoundation.org/show_bug.cgi?id=143358

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/qa sw/source

[László Németh (via logerrit)]

 sw/qa/extras/uiwriter/uiwriter2.cxx |   45 
 sw/source/core/doc/tblrwcl.cxx  |   23 --
 2 files changed, 65 insertions(+), 3 deletions(-)

New commits:
commit dbc82c02eb24ec1c97c6ee32069771d8deb394f9
Author: László Németh 
AuthorDate: Wed Sep 22 16:26:18 2021 +0200
Commit: László Németh 
CommitDate: Wed Sep 22 19:56:47 2021 +0200

tdf#143358 sw: track insertion of empty table rows

Insertion of empty table rows wasn't tracked, and
inserting also text in the new rows and rejecting
everything didn't reject the row insertion.

Follow-up to commit 99059a1ececa3621c2fe46fabdd79eed9d626c42
"tdf#143359 sw: track deletion of empty table rows".

Note: as a workaround for tracking of the empty rows,
i.e. rows without text content, add a redline with
invisible text CH_TXT_TRACKED_DUMMY_CHAR in the first
cell of the empty row.

See also commit a483a44ca00f43a64ae51d62b8fbb4129a413f6d
"tdf#143215 DOCX import: fix tracked empty row insertion/deletion",
commit b50d386dfa70f7c1d4eb1a49091ec9dd782b767b
"tdf#142701 track changes: fix layout regression of image deletion"
and commit 05366b8e6683363688de8708a3d88cf144c7a2bf
"tdf#60382 sw offapi: add change tracking of table/row deletion".

Change-Id: I237d566a468f61f31fa19dd1d6d9bb559be99158
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122460
Tested-by: László Németh 
Reviewed-by: László Németh 

diff --git a/sw/qa/extras/uiwriter/uiwriter2.cxx 
b/sw/qa/extras/uiwriter/uiwriter2.cxx
index 50c9f008eb34..1a9cbdc7d84f 100644
--- a/sw/qa/extras/uiwriter/uiwriter2.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter2.cxx
@@ -4611,6 +4611,51 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, 
testRedlineTableRowDeletionWithReject)
 assertXPath(pXmlDoc, "//page[1]//body/tab", 0);
 }
 
+CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testRedlineTableRowInsertionWithReject)
+{
+// load a 1-row table, and insert a row with enabled change tracking
+SwDoc* pDoc = createSwDoc(DATA_DIRECTORY, "tdf118311.fodt");
+
+// turn on red-lining and show changes
+pDoc->getIDocumentRedlineAccess().SetRedlineFlags(RedlineFlags::On | 
RedlineFlags::ShowDelete
+  | 
RedlineFlags::ShowInsert);
+CPPUNIT_ASSERT_MESSAGE("redlining should be on",
+   pDoc->getIDocumentRedlineAccess().IsRedlineOn());
+CPPUNIT_ASSERT_MESSAGE(
+"redlines should be visible",
+
IDocumentRedlineAccess::IsShowChanges(pDoc->getIDocumentRedlineAccess().GetRedlineFlags()));
+
+// check table and its single row
+xmlDocUniquePtr pXmlDoc = parseLayoutDump();
+assertXPath(pXmlDoc, "//page[1]//body/tab");
+assertXPath(pXmlDoc, "//page[1]//body/tab/row", 1);
+
+// insert rows before and after with enabled change tracking
+// (HasTextChangesOnly property of the row will be false, and
+// add dummy characters CH_TXT_TRACKED_DUMMY_CHAR)
+dispatchCommand(mxComponent, ".uno:InsertRowsBefore", {});
+dispatchCommand(mxComponent, ".uno:InsertRowsAfter", {});
+
+SwEditShell* const pEditShell(pDoc->GetEditShell());
+// This was 0 (not tracked row insertion)
+CPPUNIT_ASSERT_EQUAL(static_cast(2), 
pEditShell->GetRedlineCount());
+
+discardDumpedLayout();
+pXmlDoc = parseLayoutDump();
+assertXPath(pXmlDoc, "//page[1]//body/tab");
+assertXPath(pXmlDoc, "//page[1]//body/tab/row", 3);
+
+// reject redlines
+pEditShell->RejectRedline(0);
+pEditShell->RejectRedline(0);
+
+discardDumpedLayout();
+pXmlDoc = parseLayoutDump();
+assertXPath(pXmlDoc, "//page[1]//body/tab");
+// This was 3 (not rejected row insertion)
+assertXPath(pXmlDoc, "//page[1]//body/tab/row", 1);
+}
+
 CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testTdf128603)
 {
 // Load the bugdoc, which has 3 textboxes.
diff --git a/sw/source/core/doc/tblrwcl.cxx b/sw/source/core/doc/tblrwcl.cxx
index f529742e429c..2273ec51c12f 100644
--- a/sw/source/core/doc/tblrwcl.cxx
+++ b/sw/source/core/doc/tblrwcl.cxx
@@ -244,7 +244,7 @@ struct CpyPara
 
 }
 
-static void lcl_CopyRow(FndLine_ & rFndLine, CpyPara *const pCpyPara);
+static SwTableLine* lcl_CopyRow(FndLine_ & rFndLine, CpyPara *const pCpyPara);
 
 static void lcl_CopyCol( FndBox_ & rFndBox, CpyPara *const pCpyPara)
 {
@@ -379,7 +379,7 @@ static void lcl_CopyCol( FndBox_ & rFndBox, CpyPara *const 
pCpyPara)
 }
 }
 
-static void lcl_CopyRow(FndLine_& rFndLine, CpyPara *const pCpyPara)
+static SwTableLine* lcl_CopyRow(FndLine_& rFndLine, CpyPara *const pCpyPara)
 {
 SwTableLine* pNewLine = new SwTableLine(
 
static_cast(rFndLine.GetLine()->GetFrameFormat()),
@@ -402,6 +402,8 @@ static void lcl_CopyRow(FndLine_& rFndLine, CpyPara *const 
pCpyPara)
 }
 
 pCpyPara->nDelBorderFlag &= 0xf8;
+
+return pNewLine;
 }
 
 static void lcl_InsCol( FndLine_* pFndLn, 

[Libreoffice-bugs] [Bug 144646] LO ne démarre qu'en mode sans echec

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144646

--- Comment #4 from Julien Nabet  ---
Please try to respond in English so people may read it.

I don't think there's a possibility to enable a trace mode.

Did you try to apply advice from
https://wiki.documentfoundation.org/QA/FirstSteps
?
Did the pb appear after some upgrade or was it a first install?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108694] [META] PDF export options dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108694

Michael Warner  changed:

   What|Removed |Added

 Depends on||144653


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=144653
[Bug 144653] The command ".uno:ExportToPDF" ignore all given options in
FilterData argument.
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103378

Michael Warner  changed:

   What|Removed |Added

 Depends on||144653


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=144653
[Bug 144653] The command ".uno:ExportToPDF" ignore all given options in
FilterData argument.
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144653] The command ".uno:ExportToPDF" ignore all given options in FilterData argument.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144653

Michael Warner  changed:

   What|Removed |Added

 Blocks||108694, 103378


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103378
[Bug 103378] [META] PDF export bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108694
[Bug 108694] [META] PDF export options dialog bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117710] [META] UNO API issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117710

Michael Warner  changed:

   What|Removed |Added

 Depends on||144653


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=144653
[Bug 144653] The command ".uno:ExportToPDF" ignore all given options in
FilterData argument.
-- 
You are receiving this mail because:
You are the assignee for the bug.