[Libreoffice-bugs] [Bug 133651] FORMATTING not saved on FILESAVE in columns 65+ when cells in column only have formatting and no content
https://bugs.documentfoundation.org/show_bug.cgi?id=133651 graphit...@yahoo.com changed: What|Removed |Added Resolution|--- |FIXED Status|NEEDINFO|RESOLVED --- Comment #3 from graphit...@yahoo.com --- Not able to reproduce in 6.4.7.2, 7.1 or 7.2. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140750] FORMATTING in Writer - TABLES - Paragraph - All Selected Cells are not Formatted when Using Paragraph Formatting - Line Spacing - Fixed
https://bugs.documentfoundation.org/show_bug.cgi?id=140750 Dieter changed: What|Removed |Added Resolution|FIXED |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143978] Calc: shrink to fit makes font size unnecessary small compared to cell width
https://bugs.documentfoundation.org/show_bug.cgi?id=143978 Tamo changed: What|Removed |Added CC||ttakah+...@gmail.com --- Comment #15 from Tamo --- Created attachment 175788 --> https://bugs.documentfoundation.org/attachment.cgi?id=175788=edit If the cell is aligned top and the width is just a little smaller Moreover, if the cell is top-aligned and the width is just a little smaller for the text, the content will overflow a half. See the screenshot (version 7.2.2.2). B2 is affected by both Bug 143659 and Bug 143978. C2 is sticking out of the top. D2 is Ok. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144548] Could not find Help page
https://bugs.documentfoundation.org/show_bug.cgi?id=144548 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144880] Image doesn't jump to next page or stops moving when pressing arrow down, but disappears behind the next page (DOCX only)
https://bugs.documentfoundation.org/show_bug.cgi?id=144880 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144878] Space character replaced with negative space after a digit as the first character RTL line
https://bugs.documentfoundation.org/show_bug.cgi?id=144878 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144866] Almost no contrast in hovered menu item's text on Windows 11
https://bugs.documentfoundation.org/show_bug.cgi?id=144866 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144869] Feature Request for export format Similar to SVG
https://bugs.documentfoundation.org/show_bug.cgi?id=144869 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144865] Writer is unable to custom line height for specific DOCX file
https://bugs.documentfoundation.org/show_bug.cgi?id=144865 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144863] Input components created in dark mode in Ubuntu retain dark mode properties when exported to PDF as a fillable form.
https://bugs.documentfoundation.org/show_bug.cgi?id=144863 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145167] Send Create Master Document Fails When Saving Document
https://bugs.documentfoundation.org/show_bug.cgi?id=145167 --- Comment #7 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145148] Crash in: libstdc++.so.6
https://bugs.documentfoundation.org/show_bug.cgi?id=145148 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145167] Send Create Master Document Fails When Saving Document
https://bugs.documentfoundation.org/show_bug.cgi?id=145167 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145148] Crash in: libstdc++.so.6
https://bugs.documentfoundation.org/show_bug.cgi?id=145148 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140804] LibreOffice Writer shows a box / border around embedded images
https://bugs.documentfoundation.org/show_bug.cgi?id=140804 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140804] LibreOffice Writer shows a box / border around embedded images
https://bugs.documentfoundation.org/show_bug.cgi?id=140804 --- Comment #3 from QA Administrators --- Dear terrafrost, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141757] Bug d'affichage en mode contraste élevé
https://bugs.documentfoundation.org/show_bug.cgi?id=141757 --- Comment #3 from QA Administrators --- Dear titubasorciere, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141750] LibreOffice 7.1.2.2 Hangs
https://bugs.documentfoundation.org/show_bug.cgi?id=141750 --- Comment #2 from QA Administrators --- Dear flieger, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136285] In LO7, the macro inspector started working incorrectly.
https://bugs.documentfoundation.org/show_bug.cgi?id=136285 --- Comment #7 from QA Administrators --- Dear Kadet, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136052] Exporting multiple objects as selection to bitmap in Draw exports only one of them
https://bugs.documentfoundation.org/show_bug.cgi?id=136052 --- Comment #2 from QA Administrators --- Dear Maciej Lewandowski, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135820] bad pivot table sheet relative reference auto-correction
https://bugs.documentfoundation.org/show_bug.cgi?id=135820 --- Comment #2 from QA Administrators --- Dear Lyndon Brown, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133651] FORMATTING not saved on FILESAVE in columns 65+ when cells in column only have formatting and no content
https://bugs.documentfoundation.org/show_bug.cgi?id=133651 --- Comment #2 from QA Administrators --- Dear graphite37, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 132652] Export an image at any resolution without affecting the size
https://bugs.documentfoundation.org/show_bug.cgi?id=132652 --- Comment #3 from QA Administrators --- Dear Telesto, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 99778] UI : Click on sheet name to activate it scroll the tabs whereas it's not necessary (specific file)
https://bugs.documentfoundation.org/show_bug.cgi?id=99778 --- Comment #9 from QA Administrators --- Dear eric.coutier, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 95336] FILESAVE Saving a Document with "#" in name (libreoffice dialogs)
https://bugs.documentfoundation.org/show_bug.cgi?id=95336 --- Comment #11 from QA Administrators --- Dear Lukas, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 78035] No clear distinction in grid settings, saved/loaded with document, and set in the options
https://bugs.documentfoundation.org/show_bug.cgi?id=78035 --- Comment #11 from QA Administrators --- Dear Miroslav Fitz, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 45488] Impress FILEOPEN: fontart object incorrect in pptx presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=45488 --- Comment #12 from QA Administrators --- Dear sasha.libreoffice, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120586] A Track-Changes editing of a number can split it into two lines
https://bugs.documentfoundation.org/show_bug.cgi?id=120586 --- Comment #7 from QA Administrators --- Dear Eyal Rozenberg, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120311] Pivot table filter locked empty when zero rows returned
https://bugs.documentfoundation.org/show_bug.cgi?id=120311 --- Comment #10 from QA Administrators --- Dear besancon4me, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 119986] FILESAVE DOCX The MatchEntry property of the list box ActiveX control is incorrectly saved
https://bugs.documentfoundation.org/show_bug.cgi?id=119986 --- Comment #5 from QA Administrators --- Dear Gabor Kelemen, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 119984] FILESAVE DOCX The Enabled property of ActiveX controls is incorrectly saved
https://bugs.documentfoundation.org/show_bug.cgi?id=119984 --- Comment #3 from QA Administrators --- Dear Gabor Kelemen, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 119982] FILEOPEN DOCX The BackColor property of ActiveX controls are incorrectly imported, when the BackStyle property: 0 – fmBackStyleTransparent
https://bugs.documentfoundation.org/show_bug.cgi?id=119982 --- Comment #5 from QA Administrators --- Dear Gabor Kelemen, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118300] Information related to a character is not according to the displayed character in a particular case.
https://bugs.documentfoundation.org/show_bug.cgi?id=118300 --- Comment #11 from QA Administrators --- Dear ricky.tigg, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112558] Single line spacing of Calibri and Times New Roman no longer calculated correctly in Calc compared to Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=112558 --- Comment #26 from QA Administrators --- Dear Yousuf Philips (jay) (retired), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140750] FORMATTING in Writer - TABLES - Paragraph - All Selected Cells are not Formatted when Using Paragraph Formatting - Line Spacing - Fixed
https://bugs.documentfoundation.org/show_bug.cgi?id=140750 je...@iname.com changed: What|Removed |Added Resolution|INSUFFICIENTDATA|FIXED --- Comment #4 from je...@iname.com --- Tried in Version 7.1.6.2 for Linux - Bug Fixed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113506] EDITING: X axis editing problem in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=113506 --- Comment #20 from Ross Johnson --- Created attachment 175787 --> https://bugs.documentfoundation.org/attachment.cgi?id=175787=edit Line chart with x integer values The attachment, following Regina's [comment 6], shows the result choosing the "Date" category but then choosing "Day" resolution and maximum major tick interval of 100. This is not intended as a suggested workaround, just an exercise to see how close it is possible to get to a satisfying representation using the Line Chart style. It is still not a general solution but IMO proves there is no fundamental reason to prevent Line Charts representing any regular sequence of values, especially integers, preferably a new category altogether. Line Charts and Area Charts share the same underlying limitations and, while an X-Y Scatter Chart may offer a workaround for simple line chart X-axis formatting, it doesn't provide one for Area charts, which have the same limitations. An Area chart (2D and 3D) with regular interval values is a common chart presentation style that is not available in LO. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145168] Closing a document newly created from a template crashes LO (but no crash dump)
https://bugs.documentfoundation.org/show_bug.cgi?id=145168 --- Comment #2 from Jon R Kibler --- Note: I suspect that bugs 145167 https://bugs.documentfoundation.org/show_bug.cgi?id=145167 and 145168 https://bugs.documentfoundation.org/show_bug.cgi?id=145168 are related. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145167] Send Create Master Document Fails When Saving Document
https://bugs.documentfoundation.org/show_bug.cgi?id=145167 --- Comment #6 from Jon R Kibler --- Note: I suspect that bugs 145167 https://bugs.documentfoundation.org/show_bug.cgi?id=145167 and 145168 https://bugs.documentfoundation.org/show_bug.cgi?id=145168 are related. Comment on previous post about reproducibility... I forgot that after creating a new master document, you have to save it before applying a template, else it may randomly crash. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145167] Send Create Master Document Fails When Saving Document
https://bugs.documentfoundation.org/show_bug.cgi?id=145167 --- Comment #5 from Jon R Kibler --- I tried replying to the email requesting additional information, but bugzilla said I wasn't an authorized participant to this thread. So, here is what I tried to email: Hi, LO definitely has full access to the mac. The login used to document the bug owns the data directory's root file system and its entire directory hierarchy, and the LO installation is owned by that user, too. Additionally, I have other users on this mac and it fails similarly for all users. Finally, I create a master document successfully by: File-->New-->Master Document Styles-->Load Styles From Template Save And it works using the same template and saves to the same directory as I used in the bug example. That is my workaround, which adds an additional step. But, it still would be best if the actual bug was fixed. Question: Why don't I get a crash dump when LO crashes? What can I do to enable one? I don't even see a place in Advanced settings (but could have missed it). Thanks! Please let me know if I can supply any additional information. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145148] Crash in: libstdc++.so.6
https://bugs.documentfoundation.org/show_bug.cgi?id=145148 --- Comment #2 from Kurt --- (In reply to Julien Nabet from comment #1) > I see accessibility part with gtk in bt. > > Could you test this: > - open a terminal/console > - export SAL_USE_VCLPLUGIN=gen > - launch LO > - try to reproduce the pb > > BTW, I think you should stick to LO packages provided by your distribution. > Indeed, rpm and deb packages are more for distrib maintainers who deal with > all dependencies issues. > > You can also try LO from ppa (see > https://launchpad.net/~libreoffice/+archive/ubuntu/ppa) > > Finally you can take a look at > https://wiki.documentfoundation.org/QA/FirstSteps, it may help. Julian, Thank you, you can close this. it's no longer crashing. I believe a system update that arrived on the 15th fixed the problem. See below. I have been suffering with Base just shutting down at random when editing forms since I started trying to make a database on September 23 ( Kept losing my work ). The version with Mint was 6.4.7. So I moved to 7.1 then 7.2.2.2 hoping to fix the problem. The system update that arrived later on the fifteenth contained. 2021-10-15 14:04:01 upgrade distro-info-data:all 0.43ubuntu1.8 0.43ubuntu1.9 2021-10-15 14:04:01 upgrade xapps-common:all 2.2.3+uma 2.2.4+uma 2021-10-15 14:04:02 upgrade libxapp1:amd64 2.2.3+uma 2.2.4+uma 2021-10-15 14:04:02 upgrade gir1.2-xapp-1.0:amd64 2.2.3+uma 2.2.4+uma 2021-10-15 14:04:02 upgrade bulky:all 1.7 1.8 2021-10-15 14:04:02 upgrade libcjs-dbg:amd64 5.0.0+uma 5.0.1+uma 2021-10-15 14:04:03 upgrade libcjs0f:amd64 5.0.0+uma 5.0.1+uma 2021-10-15 14:04:03 upgrade muffin-dbg:amd64 5.0.1+uma 5.0.2+uma 2021-10-15 14:04:03 upgrade muffin:amd64 5.0.1+uma 5.0.2+uma 2021-10-15 14:04:03 upgrade libmuffin0:amd64 5.0.1+uma 5.0.2+uma 2021-10-15 14:04:03 upgrade muffin-common:all 5.0.1+uma 5.0.2+uma 2021-10-15 14:04:03 upgrade nemo-dbg:amd64 5.0.3+uma 5.0.4+uma 2021-10-15 14:04:04 upgrade nemo:amd64 5.0.3+uma 5.0.4+uma 2021-10-15 14:04:04 upgrade libnemo-extension1:amd64 5.0.3+uma 5.0.4+uma 2021-10-15 14:04:04 upgrade nemo-data:all 5.0.3+uma 5.0.4+uma 2021-10-15 14:04:04 upgrade cinnamon-dbg:amd64 5.0.5+uma 5.0.6+uma 2021-10-15 14:04:04 upgrade gir1.2-meta-muffin-0.0:amd64 5.0.1+uma 5.0.2+uma 2021-10-15 14:04:04 upgrade cinnamon-common:all 5.0.5+uma 5.0.6+uma 2021-10-15 14:04:04 upgrade cinnamon-screensaver:amd64 5.0.6+uma 5.0.7+uma 2021-10-15 14:04:05 upgrade libcscreensaver0:amd64 5.0.6+uma 5.0.7+uma 2021-10-15 14:04:05 upgrade cjs:amd64 5.0.0+uma 5.0.1+uma 2021-10-15 14:04:05 upgrade cinnamon:amd64 5.0.5+uma 5.0.6+uma 2021-10-15 14:04:05 upgrade gir1.2-nemo-3.0:amd64 5.0.3+uma 5.0.4+uma 2021-10-15 14:04:05 upgrade mintreport:all 1.2.5 1.2.5.1 its now stable for me now, no crashes. I Actually finished the forms. Thank you, sorry to bother you. Kurt -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: ucb/source
ucb/source/ucp/cmis/cmis_content.cxx |6 ++
ucb/source/ucp/webdav-neon/NeonSession.cxx |4 +---
ucb/source/ucp/webdav-neon/webdavcontent.cxx |9 ++---
ucb/source/ucp/webdav/SerfSession.cxx|4 +---
ucb/source/ucp/webdav/webdavcontent.cxx |9 ++---
5 files changed, 8 insertions(+), 24 deletions(-)
New commits:
commit 6cce3821ff14b41b704e279034680ce81d2b14ca
Author: Julien Nabet
AuthorDate: Sat Oct 16 22:46:14 2021 +0200
Commit: Julien Nabet
CommitDate: Sat Oct 16 23:42:16 2021 +0200
Simplify vector initialization in ucb
Change-Id: I4b03ab81a17efc125bc5e3b159cf212198c43d22
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123707
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/ucb/source/ucp/cmis/cmis_content.cxx
b/ucb/source/ucp/cmis/cmis_content.cxx
index 202e0a07b169..7ba1a129ebf5 100644
--- a/ucb/source/ucp/cmis/cmis_content.cxx
+++ b/ucb/source/ucp/cmis/cmis_content.cxx
@@ -2080,8 +2080,6 @@ namespace cmis
return;
std::map< std::string, libcmis::PropertyPtr >::iterator propIt =
m_pObjectProps.find(rName);
-std::vector< std::string > values;
-values.push_back(rValue);
if ( propIt == m_pObjectProps.end( ) && getObjectType( xEnv ).get( ) )
{
@@ -2091,13 +2089,13 @@ namespace cmis
if ( typeIt != propsTypes.end( ) )
{
libcmis::PropertyTypePtr propType = typeIt->second;
-libcmis::PropertyPtr property( new libcmis::Property(
propType, values ) );
+libcmis::PropertyPtr property( new libcmis::Property(
propType, { rValue }) );
m_pObjectProps.insert(std::pair< std::string,
libcmis::PropertyPtr >(rName, property));
}
}
else if ( propIt != m_pObjectProps.end( ) )
{
-propIt->second->setValues( values );
+propIt->second->setValues( { rValue } );
}
}
}
diff --git a/ucb/source/ucp/webdav-neon/NeonSession.cxx
b/ucb/source/ucp/webdav-neon/NeonSession.cxx
index 979537a52e28..246b42fb7fb7 100644
--- a/ucb/source/ucp/webdav-neon/NeonSession.cxx
+++ b/ucb/source/ucp/webdav-neon/NeonSession.cxx
@@ -1776,10 +1776,8 @@ bool NeonSession::removeExpiredLocktoken( const OUString
& inURL,
// @@@ Alternative: use ne_lock_discover() => less overhead
std::vector< DAVResource > aResources;
-std::vector< OUString > aPropNames;
-aPropNames.push_back( DAVProperties::LOCKDISCOVERY );
-PROPFIND( rEnv.m_aRequestURI, DAVZERO, aPropNames, aResources, rEnv );
+PROPFIND( rEnv.m_aRequestURI, DAVZERO, { DAVProperties::LOCKDISCOVERY
}, aResources, rEnv );
if ( aResources.empty() )
return false;
diff --git a/ucb/source/ucp/webdav-neon/webdavcontent.cxx
b/ucb/source/ucp/webdav-neon/webdavcontent.cxx
index 45907b8a53d3..a40d4e1dcf1a 100644
--- a/ucb/source/ucp/webdav-neon/webdavcontent.cxx
+++ b/ucb/source/ucp/webdav-neon/webdavcontent.cxx
@@ -867,9 +867,6 @@ void Content::addProperty( const
ucb::PropertyCommandArgument& aCmdArg,
ProppatchValue aValue(
PROPSET, aCmdArg.Property.Name, aCmdArg.DefaultValue );
-std::vector< ProppatchValue > aProppatchValues;
-aProppatchValues.push_back( aValue );
-
try
{
// Set property value at server.
@@ -882,7 +879,7 @@ void Content::addProperty( const
ucb::PropertyCommandArgument& aCmdArg,
// clean cached value of PROPFIND property names
// PROPPATCH can change them
removeCachedPropertyNames( xResAccess->getURL() );
-xResAccess->PROPPATCH( aProppatchValues, xEnv );
+xResAccess->PROPPATCH( { aValue }, xEnv );
{
osl::Guard< osl::Mutex > aGuard( m_aMutex );
m_xResAccess.reset(new DAVResourceAccess(*xResAccess));
@@ -958,9 +955,7 @@ void Content::removeProperty( const OUString& Name,
try
{
-std::vector< ProppatchValue > aProppatchValues;
ProppatchValue aValue( PROPREMOVE, Name, uno::Any() );
-aProppatchValues.push_back( aValue );
// Remove property value from server.
std::unique_ptr< DAVResourceAccess > xResAccess;
@@ -972,7 +967,7 @@ void Content::removeProperty( const OUString& Name,
// clean cached value of PROPFIND property names
// PROPPATCH can change them
removeCachedPropertyNames( xResAccess->getURL() );
-xResAccess->PROPPATCH( aProppatchValues, xEnv );
+xResAccess->PROPPATCH( { aValue }, xEnv );
{
osl::Guard< osl::Mutex > aGuard( m_aMutex );
m_xResAccess.reset(new DAVResourceAccess(*xResAccess));
diff --git a/ucb/source/ucp/webdav/SerfSession.cxx
b/ucb/source/ucp/webdav/SerfSession.cxx
index 2f1b4d2626c9..a4aba7726931 100644
--- a/ucb/source/ucp/webdav/SerfSession.cxx
+++ b/ucb/source/ucp/webdav/SerfSession.cxx
@@ -1175,10 +1175,8 @@ bool
[Libreoffice-bugs] [Bug 125637] names ending in underscore characters are allowed, but incorrectly handled at the end of a command line
https://bugs.documentfoundation.org/show_bug.cgi?id=125637 --- Comment #3 from Andreas Heinisch --- The problem lies in [1], because LO makes two rounds in order to parse and generate the underlying code for the macro. It could be solved in the easy way (just add a whitespace in the code after the underscore) or the hard and clean way (check where the line does not terminate if an underscore follows) [1] https://opengrok.libreoffice.org/xref/core/basic/source/comp/scanner.cxx?r=ef38b9af#300 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145157] Soft Edges effect distorting entire image in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=145157 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||79045_79...@mail.ru --- Comment #4 from Roman Kuznetsov <79045_79...@mail.ru> --- Please add a simpler example, I don't see the problem in your files anyway -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102495 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||145163 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=145163 [Bug 145163] master document crashes when repositioning inserted document -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145163] master document crashes when repositioning inserted document
https://bugs.documentfoundation.org/show_bug.cgi?id=145163 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||102495 CC||79045_79...@mail.ru --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- No repro in Windows Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: b1488cd6f008049a9aaff7350deeb73cbbd535b6 CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102495 [Bug 102495] [META] KDE VCL backend bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/source
sc/source/ui/docshell/externalrefmgr.cxx |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
New commits:
commit e7d99ed15a33de67e436f23096fd2de2ab2e400f
Author: Caolán McNamara
AuthorDate: Sat Oct 16 21:02:45 2021 +0100
Commit: Caolán McNamara
CommitDate: Sat Oct 16 23:02:10 2021 +0200
cid#1492880 make Improper use of negative value explicit
Change-Id: Ie55748f2037a320812fdf6288dd1671a39fe018b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123706
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/sc/source/ui/docshell/externalrefmgr.cxx
b/sc/source/ui/docshell/externalrefmgr.cxx
index 0da26f43b63f..f715da330b78 100644
--- a/sc/source/ui/docshell/externalrefmgr.cxx
+++ b/sc/source/ui/docshell/externalrefmgr.cxx
@@ -1768,7 +1768,8 @@ void
ScExternalRefManager::storeRangeNameTokens(sal_uInt16 nFileId, const OUStri
case svSingleRef:
{
const ScSingleRefData& rRef = *pToken->GetSingleRef();
-OUString aTabName = maRefCache.getTableName(nFileId,
rRef.Tab());
+size_t nCacheId = rRef.Tab();
+OUString aTabName = maRefCache.getTableName(nFileId,
nCacheId);
ScExternalSingleRefToken aNewToken(nFileId,
svl::SharedString(aTabName), // string not interned
*pToken->GetSingleRef());
pNewArray->AddToken(aNewToken);
@@ -1778,7 +1779,8 @@ void
ScExternalRefManager::storeRangeNameTokens(sal_uInt16 nFileId, const OUStri
case svDoubleRef:
{
const ScSingleRefData& rRef = *pToken->GetSingleRef();
-OUString aTabName = maRefCache.getTableName(nFileId,
rRef.Tab());
+size_t nCacheId = rRef.Tab();
+OUString aTabName = maRefCache.getTableName(nFileId,
nCacheId);
ScExternalDoubleRefToken aNewToken(nFileId,
svl::SharedString(aTabName), // string not interned
*pToken->GetDoubleRef());
pNewArray->AddToken(aNewToken);
[Libreoffice-bugs] [Bug 47295] Default paragraph style should be "Text body" and not "Default"
https://bugs.documentfoundation.org/show_bug.cgi?id=47295 --- Comment #37 from Gustavo --- (In reply to rscra...@gmail.com from comment #36) > LO version 7.2.1.2 > > Note: this comment uses “DPS” to mean “Default Paragraph Style”. > > In the default template (and the “Modern” template, which I think came > bundled with LO on install), none of the 2nd-level paragraph styles (one > level below the DPS or inheriting directly from DPS) has DPS set as the > “Next style”. However, the Headings style (and the Text Body style) is set > by default to have Text Body as the next style. For people who use the > template as-is, this means that the order of composition of a document will > often determine its styling: > > 1. Users who start by writing a title or heading will likely have Text Body > styled paragraphs for the rest of the document. This outcome is probably > desired. > > 2. Users who start by writing a few paragraphs and then a heading and then > another paragraph will have a few paragraphs of DPS style and a few of Text > Body style. This outcome is not desired and may cause confusion. > > > Some principles I think most people would agree with: > > A. The default template should not be designed with the assumption that > users will understand the details of style inheritance > > B. The order of composition of a document should not determine its styling > > C. If the most-commonly-used paragraph styles are set to be followed by Text > Body, the template is pushing Text Body as the main style to use for most > paragraphs > > D. Most users who *do* understand the difference between DPS and Text Body > prefer to use Text Body for most text > > E. Users who do *not* understand the difference do not care much what style > they use and just want a consistent experience > > > All of this points to the conclusion that Text Body should be the default > style selected when the Default template and Modern template are used. (A > related issue is that the name “Default Paragraph Style” may confuse users, > who will wonder why LO keeps changing the style after Headings to Text Body. > Perhaps this should be renamed to something like “Master Paragraph Style”.) Well pointed. However, this issue is here since 2012... For some reason, developers don't take this serious because is still in LO 7.2.2, among with other issues related specially to academic work (what you relate will occurs usually). I have to say, sadly, that I have to work with MS Office and to advise everyone to do the same. Thought this issue is child of a parent issue that is not taking serious the academic text production. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143392] Title on Base-Window doesn't show the name of the database.
https://bugs.documentfoundation.org/show_bug.cgi?id=143392 m.a.riosv changed: What|Removed |Added CC||jcgeff...@free.fr --- Comment #4 from m.a.riosv --- *** Bug 145177 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145177] LO7.2 BASE : The windows doesn't show the titles of the Files
https://bugs.documentfoundation.org/show_bug.cgi?id=145177 m.a.riosv changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||miguelangelrv@libreoffice.o ||rg Resolution|--- |DUPLICATE --- Comment #1 from m.a.riosv --- *** This bug has been marked as a duplicate of bug 143392 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145167] Send Create Master Document Fails When Saving Document
https://bugs.documentfoundation.org/show_bug.cgi?id=145167 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru Ever confirmed|0 |1 OS|All |Mac OS X (All) Status|UNCONFIRMED |NEEDINFO --- Comment #4 from Roman Kuznetsov <79045_79...@mail.ru> --- no problem Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: b1488cd6f008049a9aaff7350deeb73cbbd535b6 CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: threaded Are you sure LibreOffice has a full access to hard drive in your mac OS? Please check Security options in your macOS -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145173] Unrecognized locale en_IL
https://bugs.documentfoundation.org/show_bug.cgi?id=145173 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru, ||er...@redhat.com --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Eike, you know all about locales inside LibreOffice, could you please look at it? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145177] New: LO7.2 BASE : The windows doesn't show the titles of the Files
https://bugs.documentfoundation.org/show_bug.cgi?id=145177 Bug ID: 145177 Summary: LO7.2 BASE : The windows doesn't show the titles of the Files Product: LibreOffice Version: 7.2.2.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jcgeff...@free.fr Description: When I open a BASE file with LO7.2, the upper part of the windows shows "LibreOffice Base" only. In version LO7.1 and older versions the names of the files appeared, e.g. "MyFile - LibreOffice" Steps to Reproduce: Open à BASE file Actual Results: The opened windows shows "LibreOffice Base" (upper left part) Expected Results: "MyFile - LibreOffice" in he upper left part of the window Reproducible: Always User Profile Reset: Yes Additional Info: Other applications of LO7.2 show the file title in the upper part of the window. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: svl/source
svl/source/fsstor/ostreamcontainer.cxx |8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
New commits:
commit 68314bdba8d91a7e30c0c061fd3e31847c6a8187
Author: Julien Nabet
AuthorDate: Sat Oct 16 13:43:41 2021 +0200
Commit: Julien Nabet
CommitDate: Sat Oct 16 20:58:09 2021 +0200
Simplify vector initialization in svl
Change-Id: I8ff1eb008f3173791c7c1020db08d29451998f42
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123699
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/svl/source/fsstor/ostreamcontainer.cxx
b/svl/source/fsstor/ostreamcontainer.cxx
index 99b8afb1e9c0..bfa6962ee9c4 100644
--- a/svl/source/fsstor/ostreamcontainer.cxx
+++ b/svl/source/fsstor/ostreamcontainer.cxx
@@ -141,9 +141,11 @@ uno::Sequence< uno::Type > SAL_CALL
OFSStreamContainer::getTypes()
if ( !m_aTypes.hasElements() )
{
-std::vector tmp;
-tmp.push_back(cppu::UnoType::get());
-tmp.push_back(cppu::UnoType::get());
+std::vector tmp
+{
+cppu::UnoType::get(),
+cppu::UnoType::get()
+};
if ( m_xSeekable.is() )
tmp.push_back(cppu::UnoType::get());
[Libreoffice-commits] core.git: embeddedobj/source
embeddedobj/source/msole/oleembed.cxx |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
New commits:
commit 8133aa39939bd65c7c4078ff002ab88675e84ccc
Author: Mike Kaganski
AuthorDate: Sat Oct 16 19:33:20 2021 +0300
Commit: Mike Kaganski
CommitDate: Sat Oct 16 20:51:17 2021 +0200
Fix a forgotten return of the value
... ever since its introduction in commit
5ea5c0afebd272d5f44e6524c0f67b5317639919
Change-Id: Ic2f082db43c961185921137c6b64b2e1abef28e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123704
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/embeddedobj/source/msole/oleembed.cxx
b/embeddedobj/source/msole/oleembed.cxx
index ba678d4dfb87..01cf44b9fcaa 100644
--- a/embeddedobj/source/msole/oleembed.cxx
+++ b/embeddedobj/source/msole/oleembed.cxx
@@ -110,8 +110,7 @@ uno::Sequence< sal_Int32 >
OleEmbeddedObject::GetIntermediateVerbsSequence_Impl(
// actually there will be only one verb
if ( m_nObjectState == embed::EmbedStates::RUNNING && nNewState ==
embed::EmbedStates::ACTIVE )
{
-uno::Sequence< sal_Int32 > aVerbs( 1 );
-aVerbs[0] = embed::EmbedVerbs::MS_OLEVERB_OPEN;
+return { embed::EmbedVerbs::MS_OLEVERB_OPEN };
}
return uno::Sequence< sal_Int32 >();
[Libreoffice-bugs] [Bug 138071] "Save remote" fails with "This operation is not supported on this operating system"
https://bugs.documentfoundation.org/show_bug.cgi?id=138071 --- Comment #4 from Justin L --- Adding Ssh to urlobj does wonders in a few areas (like edit account and clicking on the breadcrumb path), but it doesn't seem to help very much with this particular issue. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: lotuswordpro/source
lotuswordpro/source/filter/lwppagelayout.cxx |7 +++
1 file changed, 7 insertions(+)
New commits:
commit 7422ef83a1304d34cd303a7160efd4e76cc44a49
Author: Caolán McNamara
AuthorDate: Sat Oct 16 14:04:35 2021 +0100
Commit: Caolán McNamara
CommitDate: Sat Oct 16 20:36:40 2021 +0200
ofz#40004 Timeout
Change-Id: I261f6acec53936e4a644bb4b38bbc41fa9ad120c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123702
Tested-by: Jenkins
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/lotuswordpro/source/filter/lwppagelayout.cxx
b/lotuswordpro/source/filter/lwppagelayout.cxx
index 0a72db8f7d30..735a0791c2e2 100644
--- a/lotuswordpro/source/filter/lwppagelayout.cxx
+++ b/lotuswordpro/source/filter/lwppagelayout.cxx
@@ -607,8 +607,11 @@ sal_Int32 LwpPageLayout::GetPageNumber(sal_uInt16
nLayoutNumber)
//get first pagehint
LwpPageHint* pPageHint =
dynamic_cast(pHeadTail->GetHead().obj().get());
+o3tl::sorted_vector aSeen;
while (pPageHint)
{
+aSeen.insert(pPageHint);
+
if (GetObjectID() == pPageHint->GetPageLayoutID())
{
sal_uInt16 nNumber = pPageHint->GetPageNumber();
@@ -635,7 +638,11 @@ sal_Int32 LwpPageLayout::GetPageNumber(sal_uInt16
nLayoutNumber)
break;
}
}
+
pPageHint =
dynamic_cast(pPageHint->GetNext().obj().get());
+
+if (aSeen.find(pPageHint) != aSeen.end())
+throw std::runtime_error("loop in conversion");
}
if (nPageNumber >= 0)
{
[Libreoffice-bugs] [Bug 145169] Remote Save: uses "seen in directory" filename instead of existing filename
https://bugs.documentfoundation.org/show_bug.cgi?id=145169 Caolán McNamara changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |ASSIGNED Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | --- Comment #2 from Caolán McNamara --- the "non-remote" built-in libreoffice file dialog. (tools, options, general, use LibreOffice dialog) is a similar creation, but without the initially described problem, there the difference is the focus is given to the edit box by default, which unselects the entry in the treeview. So currently its acting a little as if the user had explicitly clicked the first entry in the treeview. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - sc/source
sc/source/core/data/formulacell.cxx |7 +++
sc/source/core/tool/interpr5.cxx| 19 +++
2 files changed, 26 insertions(+)
New commits:
commit 54a9b7c1db72459f95ed334de34a0e2289329bd2
Author: Eike Rathke
AuthorDate: Fri Oct 15 21:56:34 2021 +0200
Commit: Caolán McNamara
CommitDate: Sat Oct 16 20:12:15 2021 +0200
Resolves: tdf#145085 HYPERLINK() do not force a 2nd row URL cell in array
mode
... but fake a 1-row result dimension instead.
However, keep the behaviour that if a 2-rows array was entered the
2nd row displays the URL and not the repeated cell text.
Change-Id: I4800715a4028c647b763c6d729759ff4c099748f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123680
Reviewed-by: Eike Rathke
Tested-by: Jenkins
(cherry picked from commit 459f9de8a87373c826eadab142850cc3fa578fca)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123635
Reviewed-by: Caolán McNamara
diff --git a/sc/source/core/data/formulacell.cxx
b/sc/source/core/data/formulacell.cxx
index 0b8dfd9c6f9d..5250e5e9c59a 100644
--- a/sc/source/core/data/formulacell.cxx
+++ b/sc/source/core/data/formulacell.cxx
@@ -1101,6 +1101,13 @@ void ScFormulaCell::GetResultDimensions( SCSIZE& rCols,
SCSIZE& rRows )
if (pMat)
{
pMat->GetDimensions( rCols, rRows );
+if (pCode->IsHyperLink())
+{
+// Row 2 element is the URL that is not to be displayed and the
+// result dimension not to be extended.
+assert(rRows == 2);
+rRows = 1;
+}
return;
}
}
diff --git a/sc/source/core/tool/interpr5.cxx b/sc/source/core/tool/interpr5.cxx
index 1e16518ae8da..2c79e14a6a95 100644
--- a/sc/source/core/tool/interpr5.cxx
+++ b/sc/source/core/tool/interpr5.cxx
@@ -3239,6 +3239,25 @@ void ScInterpreter::ScMatRef()
pMat->GetDimensions( nCols, nRows );
SCSIZE nC = static_cast(aPos.Col() - aAdr.Col());
SCSIZE nR = static_cast(aPos.Row() - aAdr.Row());
+#if 0
+// XXX: this could be an additional change for tdf#145085 to not
+// display the URL in a voluntary entered 2-rows array context.
+// However, that might as well be used on purpose to implement a check
+// on the URL, which existing documents may have done, the more that
+// before the accompanying change of
+// ScFormulaCell::GetResultDimensions() the cell array was forced to
+// two rows. Do not change without compelling reason. Note that this
+// repeating top cell is what Excel implements, but it has no
+// additional value so probably isn't used there. Exporting to and
+// using in Excel though will lose this capability.
+if (aCell.mpFormula->GetCode()->IsHyperLink())
+{
+// Row 2 element is the URL that is not to be displayed, fake a
+// 1-row cell-text-only matrix that is repeated.
+assert(nRows == 2);
+nR = 0;
+}
+#endif
if ((nCols <= nC && nCols != 1) || (nRows <= nR && nRows != 1))
PushNA();
else
[Libreoffice-commits] core.git: sc/qa sc/source
sc/qa/unit/data/qpro/pass/ofz40008-1.wb2 |binary sc/source/core/data/table5.cxx |3 ++- 2 files changed, 2 insertions(+), 1 deletion(-) New commits: commit 7528bb3c5098a67f32523c028d83dfbc79a7c6a0 Author: Caolán McNamara AuthorDate: Sat Oct 16 14:12:03 2021 +0100 Commit: Caolán McNamara CommitDate: Sat Oct 16 20:10:59 2021 +0200 ofz#40008 check if column exists before EndListening attempt Change-Id: Iad6a7f215aa36fb6f8bb35e14aa5b882bf9773f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123703 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/sc/qa/unit/data/qpro/pass/ofz40008-1.wb2 b/sc/qa/unit/data/qpro/pass/ofz40008-1.wb2 new file mode 100644 index ..d4adc7d484c9 Binary files /dev/null and b/sc/qa/unit/data/qpro/pass/ofz40008-1.wb2 differ diff --git a/sc/source/core/data/table5.cxx b/sc/source/core/data/table5.cxx index 646984b7c699..e885f4c704bd 100644 --- a/sc/source/core/data/table5.cxx +++ b/sc/source/core/data/table5.cxx @@ -1148,7 +1148,8 @@ void ScTable::EndListening(sc::EndListeningContext& rCxt, const ScAddress& rAddr if (!ValidCol(rAddress.Col())) return; -aCol[rAddress.Col()].EndListening(rCxt, rAddress, rListener); +if (rAddress.Col() < aCol.size()) +aCol[rAddress.Col()].EndListening(rCxt, rAddress, rListener); } void ScTable::SetPageStyle(const OUString& rName)
[Libreoffice-bugs] [Bug 143472] FILEOPEN: pdf fails to open in draw
https://bugs.documentfoundation.org/show_bug.cgi?id=143472 --- Comment #6 from himajin100...@gmail.com --- 504 0 obj << /Filter /Standard /V 4 /R 4 /Length 128 /StrF /StdCF /StmF /StdCF /CF << /StdCF << /AuthEvent /DocOpen /Length 16 /CFM /AESV2 >> >> (snip) << /Size 505 /Root 199 0 R /Info 200 0 R /ID [ ] /DocChecksum /F5A9B059D948568B44B739E345CFE935 /Encrypt 504 0 R >> https://opengrok.libreoffice.org/xref/core/sdext/source/pdfimport/pdfparse/pdfentries.cxx?r=776a1b9b#1311 https://opengrok.libreoffice.org/xref/core/sdext/source/pdfimport/pdfparse/pdfentries.cxx?r=776a1b9b#1212 I'm not so familiar with PDF stuffs, and I don't know whether LibreOffice is doing things correctly. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144777] countifs() in Calc is slower than Excel's countifs()
https://bugs.documentfoundation.org/show_bug.cgi?id=144777 --- Comment #17 from adnanbal...@gmail.com --- The daily build shows some improvement, with total calculation time for 10,000 rows reduced from 238 seconds to 203 seconds. I have noticed that in some calculations, when the string "Adapt row height" appears, a green colored progress bar is shown. But with countifs, the green progress bar does not appear. Can this be fixed? Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 459f9de8a87373c826eadab142850cc3fa578fca CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: en-AE (en_AE); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 Mike Kaganski changed: What|Removed |Added CC||johnsmithbeat...@gmail.com --- Comment #26 from Mike Kaganski --- *** Bug 144638 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144638] Writer unexpectedly and silently applies direct formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=144638 Mike Kaganski changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #16 from Mike Kaganski --- *** This bug has been marked as a duplicate of bug 134426 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 Mike Kaganski changed: What|Removed |Added CC||norb...@gmail.com --- Comment #25 from Mike Kaganski --- *** Bug 145176 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145176] Overtyping selection creates unintended direct formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=145176 Mike Kaganski changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #1 from Mike Kaganski --- *** This bug has been marked as a duplicate of bug 134426 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/qa sc/source
sc/qa/unit/pivottable_filters_test.cxx|7 ++-
sc/qa/unit/ucalc_sharedformula.cxx|8 ++--
sc/source/core/data/column4.cxx |6 ++
sc/source/core/data/dpfilteredcache.cxx |4 +---
sc/source/core/data/formulacell.cxx |3 +--
sc/source/core/data/table3.cxx| 18 ++
sc/source/core/tool/interpr8.cxx |3 +--
sc/source/filter/excel/xlroot.cxx |3 +--
sc/source/ui/app/inputhdl.cxx |3 +--
sc/source/ui/cctrl/checklistmenu.cxx |7 +--
sc/source/ui/condformat/condformatmgr.cxx |7 +--
sc/source/ui/dialogs/searchresults.cxx|9 ++---
sc/source/ui/docshell/docfunc.cxx |3 +--
sc/source/ui/miscdlgs/conflictsdlg.cxx|9 ++---
sc/source/ui/miscdlgs/sharedocdlg.cxx | 13 +
sc/source/ui/namedlg/namemgrtable.cxx |6 +++---
sc/source/ui/vba/excelvbahelper.cxx |3 +--
sc/source/ui/vba/vbawindow.cxx|3 +--
sc/source/ui/view/tabvwshf.cxx|3 +--
19 files changed, 59 insertions(+), 59 deletions(-)
New commits:
commit f6a5efc7cde6e7d723e05b866bc6de1bb56913b0
Author: Julien Nabet
AuthorDate: Sat Oct 16 10:16:37 2021 +0200
Commit: Julien Nabet
CommitDate: Sat Oct 16 19:05:05 2021 +0200
Simplify vector initialization in sc
Change-Id: If5b7632cfbc81f89d68ce8fbce1fac265e8354fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123692
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/sc/qa/unit/pivottable_filters_test.cxx
b/sc/qa/unit/pivottable_filters_test.cxx
index cfca0c29cadf..8ad8fbffee81 100644
--- a/sc/qa/unit/pivottable_filters_test.cxx
+++ b/sc/qa/unit/pivottable_filters_test.cxx
@@ -432,11 +432,8 @@ void
ScPivotTableFiltersTest::testPivotTableSharedCacheGroupODS()
}
std::sort(aGrpValues.begin(), aGrpValues.end());
-std::vector aChecks;
-aChecks.push_back(ScDPItemData::DateFirst);
-aChecks.push_back(2012);
-aChecks.push_back(2013);
-aChecks.push_back(ScDPItemData::DateLast);
+std::vector aChecks{ ScDPItemData::DateFirst, 2012,
2013,
+ScDPItemData::DateLast };
CPPUNIT_ASSERT_MESSAGE("Unexpected group values for the year
group.",
bool(aGrpValues == aChecks));
}
diff --git a/sc/qa/unit/ucalc_sharedformula.cxx
b/sc/qa/unit/ucalc_sharedformula.cxx
index 1f7bc50ed2f5..3e96ed80ce57 100644
--- a/sc/qa/unit/ucalc_sharedformula.cxx
+++ b/sc/qa/unit/ucalc_sharedformula.cxx
@@ -1550,10 +1550,7 @@ void TestSharedFormula::testSharedFormulaMoveBlock()
clearFormulaCellChangedFlag(*m_pDoc, aFormulaRange);
// Make sure these formula cells in B1:B3 have correct positions even
after the move.
-std::vector aRows;
-aRows.push_back(0);
-aRows.push_back(1);
-aRows.push_back(2);
+std::vector aRows { 0, 1, 2 };
bool bRes = checkFormulaPositions(*m_pDoc, 0, 1, aRows.data(),
aRows.size());
CPPUNIT_ASSERT(bRes);
@@ -1928,8 +1925,7 @@ void
TestSharedFormula::testSharedFormulaUnshareAreaListeners()
// Set formula cell vector.
{
ScFormulaCell* pCell = new ScFormulaCell( *m_pDoc, aPos,
"=B4");
-std::vector aCells;
-aCells.push_back(pCell);
+std::vector aCells { pCell };
m_pDoc->SetFormulaCells( aPos, aCells);
}
break;
diff --git a/sc/source/core/data/column4.cxx b/sc/source/core/data/column4.cxx
index f7f7d2a294da..b4491b869966 100644
--- a/sc/source/core/data/column4.cxx
+++ b/sc/source/core/data/column4.cxx
@@ -435,8 +435,7 @@ void ScColumn::ConvertFormulaToValue(
if (!GetDoc().ValidRow(nRow1) || !GetDoc().ValidRow(nRow2) || nRow1 >
nRow2)
return;
-std::vector aBounds;
-aBounds.push_back(nRow1);
+std::vector aBounds { nRow1 };
if (nRow2 < GetDoc().MaxRow()-1)
aBounds.push_back(nRow2+1);
@@ -496,8 +495,7 @@ void ScColumn::SwapNonEmpty(
sc::TableValues& rValues, sc::StartListeningContext& rStartCxt,
sc::EndListeningContext& rEndCxt )
{
const ScRange& rRange = rValues.getRange();
-std::vector aBounds;
-aBounds.push_back(rRange.aStart.Row());
+std::vector aBounds { rRange.aStart.Row() };
if (rRange.aEnd.Row() < GetDoc().MaxRow()-1)
aBounds.push_back(rRange.aEnd.Row()+1);
diff --git a/sc/source/core/data/dpfilteredcache.cxx
b/sc/source/core/data/dpfilteredcache.cxx
index 16e11c183b83..19b1782076c2 100644
--- a/sc/source/core/data/dpfilteredcache.cxx
+++ b/sc/source/core/data/dpfilteredcache.cxx
@@ -41,9 +41,7 @@ bool ScDPFilteredCache::SingleFilter::match(const
ScDPItemData& rCellData) const
std::vector
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/control/listview.cxx | 13 +++--
sfx2/source/dialog/versdlg.cxx |5 +
sfx2/source/doc/autoredactdialog.cxx |7 +--
3 files changed, 9 insertions(+), 16 deletions(-)
New commits:
commit 62078c534f96e859d4e8c0ead6337a876344e4ab
Author: Julien Nabet
AuthorDate: Sat Oct 16 13:43:31 2021 +0200
Commit: Julien Nabet
CommitDate: Sat Oct 16 19:02:18 2021 +0200
Simplify vector initialization in sfx2
Change-Id: Ibff7203a86b42c58738d8b4836a61bf1c5806962
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123698
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/sfx2/source/control/listview.cxx b/sfx2/source/control/listview.cxx
index 5b53ee5b67f9..0aa1781c8f13 100644
--- a/sfx2/source/control/listview.cxx
+++ b/sfx2/source/control/listview.cxx
@@ -49,12 +49,13 @@ ListView::ListView(std::unique_ptr
xTreeView)
, mnSortColumn(-2)
{
auto nDigitWidth = mxTreeView->get_approximate_digit_width();
-std::vector aWidths;
-aWidths.push_back(static_cast(nDigitWidth * 5)); /* Icon Column */
-aWidths.push_back(static_cast(nDigitWidth * 24)); /* Name Column */
-aWidths.push_back(static_cast(nDigitWidth * 22)); /* Category Column
*/
-aWidths.push_back(static_cast(nDigitWidth * 15)); /* Application
Column */
-aWidths.push_back(static_cast(nDigitWidth * 18)); /* Modify Column */
+std::vector aWidths{
+static_cast(nDigitWidth * 5), /* Icon Column */
+static_cast(nDigitWidth * 24), /* Name Column */
+static_cast(nDigitWidth * 22), /* Category Column */
+static_cast(nDigitWidth * 15), /* Application Column */
+static_cast(nDigitWidth * 18) /* Modify Column */
+};
mxTreeView->set_column_fixed_widths(aWidths);
mxTreeView->set_selection_mode(SelectionMode::Multiple);
diff --git a/sfx2/source/dialog/versdlg.cxx b/sfx2/source/dialog/versdlg.cxx
index 1c11e5fd422f..6de0d866c30b 100644
--- a/sfx2/source/dialog/versdlg.cxx
+++ b/sfx2/source/dialog/versdlg.cxx
@@ -140,10 +140,7 @@ namespace
}
}
-std::vector aWidths;
-aWidths.push_back(nMax);
-aWidths.push_back(nMaxAuthorWidth);
-rVersionBox.set_column_fixed_widths(aWidths);
+rVersionBox.set_column_fixed_widths({ nMax, nMaxAuthorWidth });
}
}
diff --git a/sfx2/source/doc/autoredactdialog.cxx
b/sfx2/source/doc/autoredactdialog.cxx
index 2e47a702d2f9..a951217fe665 100644
--- a/sfx2/source/doc/autoredactdialog.cxx
+++ b/sfx2/source/doc/autoredactdialog.cxx
@@ -43,12 +43,7 @@ TargetsTable::TargetsTable(std::unique_ptr
xControl)
: m_xControl(std::move(xControl))
{
m_xControl->set_size_request(555, 250);
-std::vector aWidths;
-aWidths.push_back(100);
-aWidths.push_back(50);
-aWidths.push_back(200);
-aWidths.push_back(105);
-aWidths.push_back(105);
+std::vector aWidths{ 100, 50, 200, 105, 105 };
m_xControl->set_column_fixed_widths(aWidths);
m_xControl->set_selection_mode(SelectionMode::Multiple);
}
[Libreoffice-bugs] [Bug 145176] New: Overtyping selection creates unintended direct formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=145176 Bug ID: 145176 Summary: Overtyping selection creates unintended direct formatting Product: LibreOffice Version: 7.1.1.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: norb...@gmail.com Description: When selecting some text and then typing a replacement text the replacement text will receive direct formatting with the same font and font size as the underlying paragraph. However, selecting the text, pressing DEL and then inserting the replacement text will behave correctly and not create the direct formatting. Steps to Reproduce: 1. Create an empty document 2. Add some text by keyboard 3. Format the text Arial bold 10 pt 4. Create a new paragraph style from that paragraph, name it ProblemStyle 5. Select a word from your paragraph text by double clicking it 6. Type some other word to replace the selection 7. Open the style inspector and see that the replacement text is now formatted with direct formatting with the same font and size as before 8. Change the font size of the ProblemStyle paragraph style to 6 pt 9. Notice that the entire paragraph changes into 6pt, except for the replacement text (which is to be expected since it received a direct formatting, which is the actual but. This step is only mentioned to demonstrate how dangerous this bug is.) Actual Results: The replacement text received direct formatting with the same font and size. Thus, this bug is really hard to see on first sight! If someone wants to change the paragraph style later, all the places where such replacements have been done will not follow the new style! This can create huge problems for book authors! Expected Results: Instead, the replacement text should have been inserted without receiving direct formatting. Interesting enough, this is what happens if one carries out the same operation in a two-step manner: first delete the original text, then insert the replacement text. Thus, the problem seems to be connected with overtyping a selection. Reproducible: Always User Profile Reset: No Additional Info: The behavior could only be observed when working with a styled paragraph different from the default style and different from the default Body text style. Therefore steps 3 and 4 in the above reproduction list are important. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145171] Use of questionable polygon optimization on startup
https://bugs.documentfoundation.org/show_bug.cgi?id=145171 Eyal Rozenberg changed: What|Removed |Added Summary|Repeated complaints about |Use of questionable polygon |"Optimizing could fail with |optimization on startup |beziers"| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145175] ConfigManager is not empty when quitting LO Writer (and LO)
https://bugs.documentfoundation.org/show_bug.cgi?id=145175 --- Comment #1 from Eyal Rozenberg --- Build info: Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: c998691e22ceda15c89d55cf7005201f0392dadb CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: en-US (en_IL); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-10-14_11:54:20 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145174] Attempt to dlopen() a missing libgcc3_java.so + searching for an .so by dlopen()'s
https://bugs.documentfoundation.org/show_bug.cgi?id=145174 --- Comment #1 from Eyal Rozenberg --- Build info: Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: c998691e22ceda15c89d55cf7005201f0392dadb CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: en-US (en_IL); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-10-14_11:54:20 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145175] New: ConfigManager is not empty when quitting LO Writer (and LO)
https://bugs.documentfoundation.org/show_bug.cgi?id=145175 Bug ID: 145175 Summary: ConfigManager is not empty when quitting LO Writer (and LO) Product: LibreOffice Version: 7.3.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: eyalr...@gmx.com Blocks: 140879 If you run a recent daily build of LO (see build info below), create a new LO writer document, then quite, you get a console message saying: warn:unotools.config:4895:4895:unotools/source/config/configmgr.cxx:153: ConfigManager not empty Now, either it's a problem that the ConfigManager is not empty, in which case it should be properly emptied; or it's not a problem in which case the warning needs to be removed as console noise. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=140879 [Bug 140879] [META] Console noise -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140879] [META] Console noise
https://bugs.documentfoundation.org/show_bug.cgi?id=140879 Eyal Rozenberg changed: What|Removed |Added Depends on||145175 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=145175 [Bug 145175] ConfigManager is not empty when quitting LO Writer (and LO) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140879] [META] Console noise
https://bugs.documentfoundation.org/show_bug.cgi?id=140879 Bug 140879 depends on bug 140883, which changed state. Bug 140883 Summary: textcvt.cxx is "Missing rtl_TextToUnicodeConverter" on startup https://bugs.documentfoundation.org/show_bug.cgi?id=140883 What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|NOTABUG |--- -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140883] textcvt.cxx is "Missing rtl_TextToUnicodeConverter" on startup
https://bugs.documentfoundation.org/show_bug.cgi?id=140883 Eyal Rozenberg changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|NOTABUG |--- --- Comment #5 from Eyal Rozenberg --- (In reply to Xisco Faulí from comment #4) > Closing as RESOLVED NOTABUG based on comment 3 Xisco, I explained why it is a bug in my opening comment. To reiterate in light of comment 3: Yes, it's ok to print warnings when something is wrong/missing. But - something being wrong/missing is a bug, by definition. And if the "unicode converter" isn't really missing, then the warning is just console noise and should be avoided. So the only question is which kind of bug this is, not whether it's a bug. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145174] New: Attempt to dlopen() a missing libgcc3_java.so + searching for an .so by dlopen()'s
https://bugs.documentfoundation.org/show_bug.cgi?id=145174 Bug ID: 145174 Summary: Attempt to dlopen() a missing libgcc3_java.so + searching for an .so by dlopen()'s Product: LibreOffice Version: 7.3.0.0 alpha0+ Master Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: eyalr...@gmx.com Blocks: 140879 When I run a daily build and create a new Writer document, I get, along with other console noise, two lines about failed attempts to open a Java-related shared object: warn:sal.osl:4895:4895:sal/osl/unx/module.cxx:155: dlopen(/opt/libreofficedev7.3/program/libjava_gcc3.so, 257): /opt/libreofficedev7.3/program/libjava_gcc3.so: cannot open shared object file: No such file or directory warn:sal.osl:4895:4895:sal/osl/unx/module.cxx:155: dlopen(/opt/libreofficedev7.3/program/libgcc3_java.so, 257): /opt/libreofficedev7.3/program/libgcc3_java.so: cannot open shared object file: No such file or directory dlopen should not be attempted on a non-existent file. Even if the file was expected to exist (which it shouldn't - everything under /opt/libreofficedev7.3/ was installed with LO 7.3's DEBs, so the contents of that directory should be known apriori) - there should still be an attempt to locate the file, then finally a dlopen() once the so has been found. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=140879 [Bug 140879] [META] Console noise -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140879] [META] Console noise
https://bugs.documentfoundation.org/show_bug.cgi?id=140879 Eyal Rozenberg changed: What|Removed |Added Depends on||145174 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=145174 [Bug 145174] Attempt to dlopen() a missing libgcc3_java.so + searching for an .so by dlopen()'s -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140879] [META] Console noise
https://bugs.documentfoundation.org/show_bug.cgi?id=140879 Eyal Rozenberg changed: What|Removed |Added Depends on||145173 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=145173 [Bug 145173] Unrecognized locale en_IL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145173] New: Unrecognized locale en_IL
https://bugs.documentfoundation.org/show_bug.cgi?id=145173
Bug ID: 145173
Summary: Unrecognized locale en_IL
Product: LibreOffice
Version: 7.3.0.0 alpha0+ Master
Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
Severity: minor
Priority: medium
Component: LibreOffice
Assignee: libreoffice-bugs@lists.freedesktop.org
Reporter: eyalr...@gmx.com
Blocks: 140879
When I start LO (using a daily build, see below) and create a new writer
document, the following is printed to the console about 13 times or so:
warn:svtools.misc:2814:2814:svtools/source/misc/langtab.cxx:239: Language: 0x9
with unknown name, so returning lang-tag of: English {en}
I'm not quite sure why that is; perhaps it has something to do with my locale,
en_IL (see build info below). I also don't know whether this is purely console
noise or whether it might be causing other problems.
Build info:
Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: c998691e22ceda15c89d55cf7005201f0392dadb
CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-US (en_IL); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2021-10-14_11:54:20
Calc: threaded
PS - en_IL is a "legit" locale; see
https://www.localeplanet.com/icu/en-IL/index.html
Referenced Bugs:
https://bugs.documentfoundation.org/show_bug.cgi?id=140879
[Bug 140879] [META] Console noise
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145172] New: URL not recognised when "autocorrection > detect url" is ON (both modes) and autocorrection is on
https://bugs.documentfoundation.org/show_bug.cgi?id=145172 Bug ID: 145172 Summary: URL not recognised when "autocorrection > detect url" is ON (both modes) and autocorrection is on Product: LibreOffice Version: 7.2.1.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: nicolas.mic...@telecom-paris.fr Description: Every URLs i enter are not recognised (transformed to URL objects like Ctrl+k) when : - "autocorrection > detect url" is ON (both modes) - autocorrection is on (while typing) and also i tested "autocorrection > apply" URL DETECTION WORKS WHEN "ENTER" or "TAB", but not if i press "SPACE" Steps to Reproduce: 1. type an URL, then SPACE Actual Results: nothing Expected Results: url converts to url object (like if i have pressed Ctrl+K) Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.2.1.2 / LibreOffice Community Build ID: 2c9f9a7aa7c967a1b7ec3448959cff87b32f6580 CPU threads: 8; OS: Linux 5.11; UI render: default; VCL: gtk3 Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR Calc: threaded it worked on libreoffice writer 6 : i just updated to v7 few days ago, then it doesnt work anymore. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145171] Repeated complaints about "Optimizing could fail with beziers"
https://bugs.documentfoundation.org/show_bug.cgi?id=145171 --- Comment #1 from Eyal Rozenberg --- Build info: Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: c998691e22ceda15c89d55cf7005201f0392dadb CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: en-US (en_IL); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-10-14_11:54:20 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145171] New: Repeated complaints about "Optimizing could fail with beziers"
https://bugs.documentfoundation.org/show_bug.cgi?id=145171 Bug ID: 145171 Summary: Repeated complaints about "Optimizing could fail with beziers" Product: LibreOffice Version: 7.3.0.0 alpha0+ Master Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: eyalr...@gmx.com Blocks: 140879 What running a daily build (via the libreofficedev7.3 binary), I get - within some other console noise - this message, repeated 7 times: warn:legacy.tools:2814:2814:tools/source/generic/poly.cxx:1033: Optimizing could fail with beziers! Obviously this should not happen. I assume some polygons are being drawn - as part of the LO UI, not a document of mine. So, if LO is using some failure-prone polygon drawing routine - it should be fixed, or not used. And if it's not really failure-prone in this context, this should be determined and no warning issued. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=140879 [Bug 140879] [META] Console noise -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140879] [META] Console noise
https://bugs.documentfoundation.org/show_bug.cgi?id=140879 Eyal Rozenberg changed: What|Removed |Added Depends on||145171 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=145171 [Bug 145171] Repeated complaints about "Optimizing could fail with beziers" -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/core/uwriter.cxx | 14 ++-
sw/source/core/docnode/node.cxx |8 +-
sw/source/core/table/swtable.cxx|3 --
sw/source/core/txtnode/ndtxt.cxx|4 ---
sw/source/filter/ww8/docxexport.cxx |7 +
sw/source/filter/ww8/rtfattributeoutput.cxx | 18 ++
sw/source/filter/ww8/rtfexport.cxx | 15
sw/source/filter/ww8/ww8par2.cxx| 34 ++--
sw/source/ui/chrdlg/swuiccoll.cxx |7 -
sw/source/ui/dbui/addresslistdialog.cxx |7 -
sw/source/ui/dbui/mmoutputtypepage.cxx |8 --
sw/source/ui/dbui/selectdbtabledialog.cxx |4 +--
sw/source/ui/index/cnttab.cxx |9 ---
sw/source/ui/misc/bookmark.cxx |7 -
sw/source/ui/misc/glosbib.cxx |4 ---
sw/source/uibase/uiview/pview.cxx | 16 -
sw/source/uibase/uiview/view2.cxx |8 --
17 files changed, 84 insertions(+), 89 deletions(-)
New commits:
commit 8ec8bbcd4b1af73527859255d84af9f5990426bb
Author: Julien Nabet
AuthorDate: Sat Oct 16 14:18:43 2021 +0200
Commit: Julien Nabet
CommitDate: Sat Oct 16 18:13:33 2021 +0200
Simplify vector initialization in sw
Change-Id: Ibded138d113e56b78b12c96c7ecd8258564627ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123701
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/sw/qa/core/uwriter.cxx b/sw/qa/core/uwriter.cxx
index 02f384f6c414..4c839d061f0f 100644
--- a/sw/qa/core/uwriter.cxx
+++ b/sw/qa/core/uwriter.cxx
@@ -1564,12 +1564,14 @@ namespace
void SwDocTest::testIntrusiveRing()
{
TestRing aRing1, aRing2, aRing3, aRing4, aRing5;
-std::vector vRings;
-vRings.push_back();
-vRings.push_back();
-vRings.push_back();
-vRings.push_back();
-vRings.push_back();
+std::vector vRings
+{
+,
+,
+,
+,
+
+};
CPPUNIT_ASSERT_EQUAL(static_cast(1),
aRing1.GetRingContainer().size());
CPPUNIT_ASSERT(aRing1.lonely());
CPPUNIT_ASSERT(aRing2.lonely());
diff --git a/sw/source/core/docnode/node.cxx b/sw/source/core/docnode/node.cxx
index 7c0403239130..e2598a1a53bd 100644
--- a/sw/source/core/docnode/node.cxx
+++ b/sw/source/core/docnode/node.cxx
@@ -1668,9 +1668,7 @@ bool SwContentNode::ResetAttr( sal_uInt16 nWhich1,
sal_uInt16 nWhich2 )
sal_uInt16 nDel = 0;
if ( !nWhich2 || nWhich2 < nWhich1 )
{
-std::vector aClearWhichIds;
-aClearWhichIds.push_back( nWhich1 );
-nDel = ClearItemsFromAttrSet( aClearWhichIds );
+nDel = ClearItemsFromAttrSet( { nWhich1 } );
}
else
nDel = AttrSetHandleHelper::ClearItem_BC( mpAttrSet, *this,
nWhich1, nWhich2, nullptr, nullptr );
@@ -1736,9 +1734,7 @@ sal_uInt16 SwContentNode::ResetAllAttr()
// If Modify is locked, do not send out any Modifys
if( IsModifyLocked() )
{
-std::vector aClearWhichIds;
-aClearWhichIds.push_back(0);
-sal_uInt16 nDel = ClearItemsFromAttrSet( aClearWhichIds );
+sal_uInt16 nDel = ClearItemsFromAttrSet( { 0 } );
if( !GetpSwAttrSet()->Count() ) // Empty? Delete
mpAttrSet.reset();
return nDel;
diff --git a/sw/source/core/table/swtable.cxx b/sw/source/core/table/swtable.cxx
index ff85241e1cdf..c3b508493667 100644
--- a/sw/source/core/table/swtable.cxx
+++ b/sw/source/core/table/swtable.cxx
@@ -1045,9 +1045,8 @@ static void lcl_CalcNewWidths( std::vector
, ChangeList& rC
return;
}
std::vector aNewSpanPos;
-ChangeList aNewChanges;
ChangeList::iterator pCurr = rChanges.begin();
-aNewChanges.push_back( *pCurr ); // Nullposition
+ChangeList aNewChanges { *pCurr }; // Nullposition
std::vector::iterator pSpan = rSpanPos.begin();
sal_uInt16 nCurr = 0;
SwTwips nOrgSum = 0;
diff --git a/sw/source/core/txtnode/ndtxt.cxx b/sw/source/core/txtnode/ndtxt.cxx
index 6ca45bf97a7d..8179e4139f46 100644
--- a/sw/source/core/txtnode/ndtxt.cxx
+++ b/sw/source/core/txtnode/ndtxt.cxx
@@ -2972,9 +2972,7 @@ SwTextNode* SwTextNode::MakeNewTextNode( const
SwNodeIndex& rPos, bool bNext,
// #i75353#
if ( bClearHardSetNumRuleWhenFormatCollChanges )
{
-std::vector aClearWhichIds;
-aClearWhichIds.push_back( RES_PARATR_NUMRULE );
-if ( ClearItemsFromAttrSet( aClearWhichIds ) != 0 )
+if ( ClearItemsFromAttrSet( { RES_PARATR_NUMRULE } ) != 0 )
{
InvalidateInSwCache(RES_ATTRSET_CHG);
}
diff --git a/sw/source/filter/ww8/docxexport.cxx
b/sw/source/filter/ww8/docxexport.cxx
index b610adf30f7d..b90fc8c74a02 100644
--- a/sw/source/filter/ww8/docxexport.cxx
+++ b/sw/source/filter/ww8/docxexport.cxx
@@ -177,11 +177,8 @@ void
[Libreoffice-commits] core.git: svx/qa svx/source
svx/qa/unit/svdraw/test_SdrTextObject.cxx |7
---
svx/source/dialog/ctredlin.cxx| 23
++
svx/source/dialog/docrecovery.cxx | 11
+++-
svx/source/form/datanavi.cxx |7
++-
svx/source/sdr/primitive2d/sdrdecompositiontools.cxx |5 --
svx/source/sidebar/inspector/InspectorTextPanel.cxx |4 -
svx/source/tbxctrls/PaletteManager.cxx|7
+--
svx/source/unodialogs/textconversiondlgs/chinese_dictionarydialog.cxx |9
++-
8 files changed, 41 insertions(+), 32 deletions(-)
New commits:
commit 9d98fadd5e943f4c3f87d0c269815c7a0feee217
Author: Julien Nabet
AuthorDate: Sat Oct 16 13:43:59 2021 +0200
Commit: Julien Nabet
CommitDate: Sat Oct 16 18:13:21 2021 +0200
Simplify vector initialization in svx
Change-Id: I139776f74fb93f90dae787eeae18e4a2a2ed7351
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123700
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/svx/qa/unit/svdraw/test_SdrTextObject.cxx
b/svx/qa/unit/svdraw/test_SdrTextObject.cxx
index 93b06272fd3d..218db2a52f0e 100644
--- a/svx/qa/unit/svdraw/test_SdrTextObject.cxx
+++ b/svx/qa/unit/svdraw/test_SdrTextObject.cxx
@@ -27,11 +27,8 @@ public:
void SdrTextObjTest::AllFamiliesCanBeRestoredFromSavedString()
{
-std::vector allFamilies;
-allFamilies.push_back(SfxStyleFamily::Char);
-allFamilies.push_back(SfxStyleFamily::Para);
-allFamilies.push_back(SfxStyleFamily::Page);
-allFamilies.push_back(SfxStyleFamily::Pseudo);
+std::vector allFamilies{ SfxStyleFamily::Char,
SfxStyleFamily::Para,
+ SfxStyleFamily::Page,
SfxStyleFamily::Pseudo };
for (SfxStyleFamily family : allFamilies)
{
diff --git a/svx/source/dialog/ctredlin.cxx b/svx/source/dialog/ctredlin.cxx
index 3797df20d398..78b9974ec05d 100644
--- a/svx/source/dialog/ctredlin.cxx
+++ b/svx/source/dialog/ctredlin.cxx
@@ -20,6 +20,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -358,10 +359,12 @@ void SvxRedlinTable::SetWriterView()
pTreeView = xWriterTreeView.get();
auto nDigitWidth = pTreeView->get_approximate_digit_width();
-std::vector aWidths;
-aWidths.push_back(nDigitWidth * 10);
-aWidths.push_back(nDigitWidth * 20);
-aWidths.push_back(nDigitWidth * 20);
+std::vector aWidths
+{
+o3tl::narrowing(nDigitWidth * 10),
+o3tl::narrowing(nDigitWidth * 20),
+o3tl::narrowing(nDigitWidth * 20)
+};
pTreeView->set_column_fixed_widths(aWidths);
}
@@ -374,11 +377,13 @@ void SvxRedlinTable::SetCalcView()
pTreeView = xCalcTreeView.get();
auto nDigitWidth = pTreeView->get_approximate_digit_width();
-std::vector aWidths;
-aWidths.push_back(nDigitWidth * 20);
-aWidths.push_back(nDigitWidth * 20);
-aWidths.push_back(nDigitWidth * 20);
-aWidths.push_back(nDigitWidth * 20);
+std::vector aWidths
+{
+o3tl::narrowing(nDigitWidth * 20),
+o3tl::narrowing(nDigitWidth * 20),
+o3tl::narrowing(nDigitWidth * 20),
+o3tl::narrowing(nDigitWidth * 20)
+};
pTreeView->set_column_fixed_widths(aWidths);
}
diff --git a/svx/source/dialog/docrecovery.cxx
b/svx/source/dialog/docrecovery.cxx
index 1c86f078042f..94130ae491e7 100644
--- a/svx/source/dialog/docrecovery.cxx
+++ b/svx/source/dialog/docrecovery.cxx
@@ -24,6 +24,7 @@
#include
#include
+#include
#include
#include
#include
@@ -657,10 +658,12 @@ RecoveryDialog::RecoveryDialog(weld::Window* pParent,
RecoveryCore* pCore)
m_xProgressBar->set_size_request(m_xProgressBar->get_approximate_digit_width()
* 50, -1);
m_xProgress = new PluginProgress(m_xProgressBar.get());
-std::vector aWidths;
-aWidths.push_back(m_xFileListLB->get_checkbox_column_width());
-aWidths.push_back(60 * nWidth / 100);
-aWidths.push_back(m_xFileListLB->get_checkbox_column_width());
+std::vector aWidths
+{
+o3tl::narrowing(m_xFileListLB->get_checkbox_column_width()),
+o3tl::narrowing(60 * nWidth / 100),
+o3tl::narrowing(m_xFileListLB->get_checkbox_column_width())
+};
m_xFileListLB->set_column_fixed_widths(aWidths);
m_xNextBtn->set_sensitive(true);
diff --git a/svx/source/form/datanavi.cxx b/svx/source/form/datanavi.cxx
index 45d7f8ab284e..4d5ac51af1d3 100644
--- a/svx/source/form/datanavi.cxx
+++ b/svx/source/form/datanavi.cxx
@@ -27,6 +27,7 @@
#include
#include
+#include
#include
#include
#include
@@ -2636,8 +2637,10 @@ namespace svxform
m_xNamespacesList->set_size_request(m_xNamespacesList->get_approximate_digit_width()
* 80,
m_xNamespacesList->get_height_rows(8));
-std::vector aWidths;
-
[Libreoffice-commits] core.git: 2 commits - filter/source reportdesign/source
filter/source/msfilter/escherex.cxx | 18 --
filter/source/pdf/impdialog.cxx | 15 ---
reportdesign/source/filter/xml/xmlExport.cxx | 17 +++--
3 files changed, 31 insertions(+), 19 deletions(-)
New commits:
commit edf82470de0f7796992666a0c2b5c56dc66c94fd
Author: Julien Nabet
AuthorDate: Sat Oct 16 10:15:30 2021 +0200
Commit: Julien Nabet
CommitDate: Sat Oct 16 18:13:05 2021 +0200
Simplify vector initialization in filter
Change-Id: I78653b32a5418e44733e3d2740a9a7dd784f17ae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123686
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/filter/source/msfilter/escherex.cxx
b/filter/source/msfilter/escherex.cxx
index fecb2fa45291..5ab075d6050a 100644
--- a/filter/source/msfilter/escherex.cxx
+++ b/filter/source/msfilter/escherex.cxx
@@ -1907,14 +1907,20 @@ bool EscherPropertyContainer::CreatePolygonProperties(
const sal_uInt16 nPolyCount(aPolyPolygon.Count());
sal_uInt32 nTotalPoints(0);
-std::vector< sal_uInt8 > aVertices(4, 0);
-std::vector< sal_uInt8 > aSegments(4, 0);
-aVertices.push_back(static_cast(0xf0));
-aVertices.push_back(static_cast(0xff));
+std::vector< sal_uInt8 > aVertices
+{
+0, 0, 0, 0,
+static_cast(0xf0),
+static_cast(0xff)
+};
-aSegments.push_back(static_cast(2));
-aSegments.push_back(static_cast(0));
+std::vector< sal_uInt8 > aSegments
+{
+0, 0, 0, 0,
+static_cast(2),
+static_cast(0)
+};
for(sal_uInt16 j(0); j < nPolyCount; ++j)
{
diff --git a/filter/source/pdf/impdialog.cxx b/filter/source/pdf/impdialog.cxx
index e15d8a4c9bdd..c1a3c94d5a85 100644
--- a/filter/source/pdf/impdialog.cxx
+++ b/filter/source/pdf/impdialog.cxx
@@ -449,13 +449,14 @@ Sequence< PropertyValue > ImpPDFTabDialog::GetFilterData()
maConfigItem.WriteBool( "EnableCopyingOfContent", mbCanCopyOrExtract );
maConfigItem.WriteBool( "EnableTextAccessForAccessibilityTools",
mbCanExtractForAccessibility );
-std::vector aRet;
-
-aRet.push_back(comphelper::makePropertyValue("Watermark",
maWatermarkText));
-aRet.push_back(comphelper::makePropertyValue("EncryptFile", mbEncrypt));
-aRet.push_back(comphelper::makePropertyValue("PreparedPasswords",
mxPreparedPasswords));
-aRet.push_back(comphelper::makePropertyValue("RestrictPermissions",
mbRestrictPermissions));
-aRet.push_back(comphelper::makePropertyValue("PreparedPermissionPassword",
maPreparedOwnerPassword));
+std::vector aRet
+{
+comphelper::makePropertyValue("Watermark", maWatermarkText),
+comphelper::makePropertyValue("EncryptFile", mbEncrypt),
+comphelper::makePropertyValue("PreparedPasswords",
mxPreparedPasswords),
+comphelper::makePropertyValue("RestrictPermissions",
mbRestrictPermissions),
+comphelper::makePropertyValue("PreparedPermissionPassword",
maPreparedOwnerPassword)
+};
if( mbIsRangeChecked )
aRet.push_back(comphelper::makePropertyValue("PageRange",
msPageRange));
else if( mbSelectionIsChecked )
commit ac10792ed4ca8d92f60c95ab4acd5b911e42cec7
Author: Julien Nabet
AuthorDate: Sat Oct 16 10:16:17 2021 +0200
Commit: Julien Nabet
CommitDate: Sat Oct 16 18:12:49 2021 +0200
Simplify vector initialization in reportdesign
Change-Id: Ic1927155b23f056fc1117b7726ab4b2eff8a6da3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123690
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/reportdesign/source/filter/xml/xmlExport.cxx
b/reportdesign/source/filter/xml/xmlExport.cxx
index d9a673e81250..df89720fe7c5 100644
--- a/reportdesign/source/filter/xml/xmlExport.cxx
+++ b/reportdesign/source/filter/xml/xmlExport.cxx
@@ -18,6 +18,7 @@
*/
#include
+#include
#include "xmlExport.hxx"
#include "xmlAutoStyle.hxx"
#include
@@ -497,15 +498,19 @@ void ORptExport::exportSectionAutoStyle(const
Reference& _xProp)
const sal_Int32 nOffset =
rptui::getStyleProperty(xReport,PROPERTY_LEFTMARGIN);
const sal_Int32 nCount = _xProp->getCount();
-::std::vector aColumnPos;
+::std::vector aColumnPos
+{
+nOffset,
+aSize.Width -
rptui::getStyleProperty(xReport,PROPERTY_RIGHTMARGIN)
+};
aColumnPos.reserve(2*(nCount + 1));
-aColumnPos.push_back(nOffset);
-aColumnPos.push_back(aSize.Width -
rptui::getStyleProperty(xReport,PROPERTY_RIGHTMARGIN));
-::std::vector aRowPos;
+::std::vector aRowPos
+{
+0,
+o3tl::narrowing(_xProp->getHeight())
+};
aRowPos.reserve(2*(nCount + 1));
-aRowPos.push_back(0);
-aRowPos.push_back(_xProp->getHeight());
::std::vector aRowPosAutoGrow;
[Libreoffice-commits] core.git: sal/osl sal/qa
sal/osl/unx/backtraceapi.cxx |8 +---
sal/qa/osl/process/osl_process.cxx | 10 ++
2 files changed, 11 insertions(+), 7 deletions(-)
New commits:
commit 8546cdb2ad25b03ac152615357cab0006340d92f
Author: Julien Nabet
AuthorDate: Sat Oct 16 10:16:25 2021 +0200
Commit: Julien Nabet
CommitDate: Sat Oct 16 18:12:29 2021 +0200
Simplify vector initialization in sal
Change-Id: Ia3e4dd8cad79b156d44eb03f1ae3d308204df2e9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123691
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/sal/osl/unx/backtraceapi.cxx b/sal/osl/unx/backtraceapi.cxx
index e98d8d663f39..b372a500f7f0 100644
--- a/sal/osl/unx/backtraceapi.cxx
+++ b/sal/osl/unx/backtraceapi.cxx
@@ -79,10 +79,12 @@ void process_file_addr2line( const char* file,
std::vector& frameData
OUString arg1("-Cfe");
OUString arg2 = OUString::fromUtf8(file);
std::vector addrs;
-std::vector args;
+std::vector args
+{
+arg1.pData,
+arg2.pData
+};
args.reserve(frameData.size() + 2);
-args.push_back( arg1.pData );
-args.push_back( arg2.pData );
for( FrameData& frame : frameData )
{
if( frame.file != nullptr && strcmp( file, frame.file ) == 0 )
diff --git a/sal/qa/osl/process/osl_process.cxx
b/sal/qa/osl/process/osl_process.cxx
index 58510e3a1e08..c396a06b5782 100644
--- a/sal/qa/osl/process/osl_process.cxx
+++ b/sal/qa/osl/process/osl_process.cxx
@@ -382,10 +382,12 @@ public:
osl_freeProcessHandle(process);
-std::vector different_child_env_vars;
-different_child_env_vars.push_back(ENV1);
-different_child_env_vars.push_back(ENV2);
-different_child_env_vars.push_back(ENV4);
+std::vector different_child_env_vars
+{
+ENV1,
+ENV2,
+ENV4
+};
CPPUNIT_ASSERT_MESSAGE
(
[Libreoffice-commits] core.git: oox/source
oox/source/drawingml/shape.cxx | 22 ++
1 file changed, 14 insertions(+), 8 deletions(-)
New commits:
commit e44fc2be0d9b0ed7b8983aca42471303e1fca55f
Author: Julien Nabet
AuthorDate: Sat Oct 16 10:16:06 2021 +0200
Commit: Julien Nabet
CommitDate: Sat Oct 16 18:12:11 2021 +0200
Simplify vector initialization in oox
Change-Id: I1d7cfd157d56a501be4497e6f4e94f3f33429139
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123689
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/oox/source/drawingml/shape.cxx b/oox/source/drawingml/shape.cxx
index 50a3c6ae5528..6821dffc9f34 100644
--- a/oox/source/drawingml/shape.cxx
+++ b/oox/source/drawingml/shape.cxx
@@ -1349,10 +1349,12 @@ Reference< XShape > const & Shape::createAndInsert(
}
// Store original fill and line colors of the shape and the theme
color name to InteropGrabBag
-std::vector aProperties;
-
aProperties.push_back(comphelper::makePropertyValue("EmuLineWidth",
aLineProperties.moLineWidth.get(0)));
-
aProperties.push_back(comphelper::makePropertyValue("OriginalSolidFillClr",
aShapeProps.getProperty(PROP_FillColor)));
-
aProperties.push_back(comphelper::makePropertyValue("OriginalLnSolidFillClr",
aShapeProps.getProperty(PROP_LineColor)));
+std::vector aProperties
+{
+comphelper::makePropertyValue("EmuLineWidth",
aLineProperties.moLineWidth.get(0)),
+comphelper::makePropertyValue("OriginalSolidFillClr",
aShapeProps.getProperty(PROP_FillColor)),
+comphelper::makePropertyValue("OriginalLnSolidFillClr",
aShapeProps.getProperty(PROP_LineColor))
+};
OUString sColorFillScheme =
aFillProperties.maFillColor.getSchemeName();
if( !aFillProperties.maFillColor.isPlaceHolder() &&
!sColorFillScheme.isEmpty() )
{
@@ -1380,8 +1382,10 @@ Reference< XShape > const & Shape::createAndInsert(
{ // for each stop in the gradient definition:
// save position
-std::vector aGradientStop;
-
aGradientStop.push_back(comphelper::makePropertyValue("Pos", rPos));
+std::vector aGradientStop
+{
+comphelper::makePropertyValue("Pos", rPos)
+};
OUString sStopColorScheme = rColor.getSchemeName();
if( sStopColorScheme.isEmpty() )
@@ -1422,8 +1426,10 @@ Reference< XShape > const & Shape::createAndInsert(
PropertyValue aEffect = it->getEffect();
if( !aEffect.Name.isEmpty() )
{
-std::vector aEffectsGrabBag;
-
aEffectsGrabBag.push_back(comphelper::makePropertyValue("Attribs",
aEffect.Value));
+std::vector aEffectsGrabBag
+{
+comphelper::makePropertyValue("Attribs",
aEffect.Value)
+};
Color& aColor( it->moColor );
OUString sColorScheme = aColor.getSchemeName();
[Libreoffice-commits] core.git: 2 commits - drawinglayer/qa drawinglayer/source helpcompiler/source
drawinglayer/qa/unit/border.cxx | 35 +-
drawinglayer/source/primitive3d/sdrpolypolygonprimitive3d.cxx |3
helpcompiler/source/HelpLinker.cxx| 10 +-
3 files changed, 25 insertions(+), 23 deletions(-)
New commits:
commit 881329a30612fb822d6c770efabc249bbefeb126
Author: Julien Nabet
AuthorDate: Sat Oct 16 10:14:56 2021 +0200
Commit: Julien Nabet
CommitDate: Sat Oct 16 18:11:52 2021 +0200
Simplify vector initialization in drawinglayer
Change-Id: Iee9c13149d3614ecd9f812cfbb85e4534c33c1be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123684
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/drawinglayer/qa/unit/border.cxx b/drawinglayer/qa/unit/border.cxx
index fdb3cc71a3a8..53bd420ee726 100644
--- a/drawinglayer/qa/unit/border.cxx
+++ b/drawinglayer/qa/unit/border.cxx
@@ -49,17 +49,18 @@ CPPUNIT_TEST_FIXTURE(DrawinglayerBorderTest,
testDoubleDecompositionSolid)
basegfx::BColor aColorLeft;
std::vector
aDashing(svtools::GetLineDashing(SvxBorderLineStyle::DOUBLE, 10.0));
const drawinglayer::attribute::StrokeAttribute
aStrokeAttribute(std::move(aDashing));
-std::vector aBorderlines;
+std::vector aBorderlines{
-aBorderlines.push_back(drawinglayer::primitive2d::BorderLine(
-drawinglayer::attribute::LineAttribute(aColorLeft, fLeftWidth),
fExtendLeftStart,
-fExtendLeftStart, fExtendLeftEnd, fExtendLeftEnd));
+drawinglayer::primitive2d::BorderLine(
+drawinglayer::attribute::LineAttribute(aColorLeft, fLeftWidth),
fExtendLeftStart,
+fExtendLeftStart, fExtendLeftEnd, fExtendLeftEnd),
-aBorderlines.push_back(drawinglayer::primitive2d::BorderLine(fDistance));
+drawinglayer::primitive2d::BorderLine(fDistance),
-aBorderlines.push_back(drawinglayer::primitive2d::BorderLine(
-drawinglayer::attribute::LineAttribute(aColorRight, fRightWidth),
fExtendRightStart,
-fExtendRightStart, fExtendRightEnd, fExtendRightEnd));
+drawinglayer::primitive2d::BorderLine(
+drawinglayer::attribute::LineAttribute(aColorRight, fRightWidth),
fExtendRightStart,
+fExtendRightStart, fExtendRightEnd, fExtendRightEnd)
+};
rtl::Reference aBorder(
new drawinglayer::primitive2d::BorderLinePrimitive2D(aStart, aEnd,
std::move(aBorderlines),
@@ -113,17 +114,17 @@ CPPUNIT_TEST_FIXTURE(DrawinglayerBorderTest,
testDoublePixelProcessing)
basegfx::BColor aColorLeft;
std::vector
aDashing(svtools::GetLineDashing(SvxBorderLineStyle::DOUBLE, 10.0));
const drawinglayer::attribute::StrokeAttribute
aStrokeAttribute(std::move(aDashing));
-std::vector aBorderlines;
+std::vector aBorderlines{
+drawinglayer::primitive2d::BorderLine(
+drawinglayer::attribute::LineAttribute(aColorLeft, fLeftWidth),
fExtendLeftStart,
+fExtendLeftStart, fExtendLeftEnd, fExtendLeftEnd),
-aBorderlines.push_back(drawinglayer::primitive2d::BorderLine(
-drawinglayer::attribute::LineAttribute(aColorLeft, fLeftWidth),
fExtendLeftStart,
-fExtendLeftStart, fExtendLeftEnd, fExtendLeftEnd));
+drawinglayer::primitive2d::BorderLine(fDistance),
-aBorderlines.push_back(drawinglayer::primitive2d::BorderLine(fDistance));
-
-aBorderlines.push_back(drawinglayer::primitive2d::BorderLine(
-drawinglayer::attribute::LineAttribute(aColorRight, fRightWidth),
fExtendRightStart,
-fExtendRightStart, fExtendRightEnd, fExtendRightEnd));
+drawinglayer::primitive2d::BorderLine(
+drawinglayer::attribute::LineAttribute(aColorRight, fRightWidth),
fExtendRightStart,
+fExtendRightStart, fExtendRightEnd, fExtendRightEnd)
+};
rtl::Reference aBorder(
new drawinglayer::primitive2d::BorderLinePrimitive2D(aStart, aEnd,
std::move(aBorderlines),
diff --git a/drawinglayer/source/primitive3d/sdrpolypolygonprimitive3d.cxx
b/drawinglayer/source/primitive3d/sdrpolypolygonprimitive3d.cxx
index 4887802e17a4..010083b42291 100644
--- a/drawinglayer/source/primitive3d/sdrpolypolygonprimitive3d.cxx
+++ b/drawinglayer/source/primitive3d/sdrpolypolygonprimitive3d.cxx
@@ -37,8 +37,7 @@ namespace drawinglayer::primitive3d
if(getPolyPolygon3D().count())
{
-std::vector< basegfx::B3DPolyPolygon > aFill;
-aFill.push_back(getPolyPolygon3D());
+std::vector< basegfx::B3DPolyPolygon > aFill {
getPolyPolygon3D() };
// get full range
const basegfx::B3DRange aRange(getRangeFrom3DGeometry(aFill));
commit cd5ee8c7d3f06fe78e6b3993845a3c2abc7cb72a
Author: Julien Nabet
AuthorDate: Sat Oct 16 10:15:56 2021 +0200
Commit: Julien Nabet
CommitDate: Sat Oct 16 18:11:39 2021 +0200
Simplify vector initialization in helpcompiler
Change-Id:
[Libreoffice-commits] core.git: 2 commits - extensions/source sdext/source
extensions/source/propctrlr/formcomponenthandler.cxx | 49 +-
sdext/source/minimizer/optimizerdialogcontrols.cxx| 86 ++
sdext/source/presenter/PresenterCanvasHelper.cxx |7 -
sdext/source/presenter/PresenterPaneBorderPainter.cxx |8 +
sdext/source/presenter/PresenterToolBar.cxx | 14 +-
sdext/source/presenter/PresenterWindowManager.cxx |6 -
6 files changed, 94 insertions(+), 76 deletions(-)
New commits:
commit 741658c57c9653d58bd9abbe630f469ca7f64a6b
Author: Julien Nabet
AuthorDate: Sat Oct 16 10:15:13 2021 +0200
Commit: Julien Nabet
CommitDate: Sat Oct 16 18:11:26 2021 +0200
Simplify vector initialization in extensions
Change-Id: Ia83209304a7ed889cdd643c8034420c032ccad6e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123685
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/extensions/source/propctrlr/formcomponenthandler.cxx
b/extensions/source/propctrlr/formcomponenthandler.cxx
index bf3feb4acb1a..a783f1e49bd0 100644
--- a/extensions/source/propctrlr/formcomponenthandler.cxx
+++ b/extensions/source/propctrlr/formcomponenthandler.cxx
@@ -878,30 +878,31 @@ namespace pcr
Sequence< OUString > SAL_CALL
FormComponentPropertyHandler::getActuatingProperties( )
{
::osl::MutexGuard aGuard( m_aMutex );
-std::vector< OUString > aInterestingProperties;
-aInterestingProperties.push_back( PROPERTY_DATASOURCE );
-aInterestingProperties.push_back( PROPERTY_COMMAND );
-aInterestingProperties.push_back( PROPERTY_COMMANDTYPE );
-aInterestingProperties.push_back( PROPERTY_LISTSOURCE );
-aInterestingProperties.push_back( PROPERTY_LISTSOURCETYPE );
-aInterestingProperties.push_back( PROPERTY_SUBMIT_ENCODING );
-aInterestingProperties.push_back( PROPERTY_REPEAT );
-aInterestingProperties.push_back( PROPERTY_TABSTOP );
-aInterestingProperties.push_back( PROPERTY_BORDER );
-aInterestingProperties.push_back( PROPERTY_CONTROLSOURCE );
-aInterestingProperties.push_back( PROPERTY_DROPDOWN );
-aInterestingProperties.push_back( PROPERTY_IMAGE_URL );
-aInterestingProperties.push_back( PROPERTY_TARGET_URL );
-aInterestingProperties.push_back( PROPERTY_STRINGITEMLIST );
-aInterestingProperties.push_back( PROPERTY_BUTTONTYPE );
-aInterestingProperties.push_back( PROPERTY_ESCAPE_PROCESSING );
-aInterestingProperties.push_back( PROPERTY_TRISTATE );
-aInterestingProperties.push_back( PROPERTY_DECIMAL_ACCURACY );
-aInterestingProperties.push_back( PROPERTY_SHOWTHOUSANDSEP );
-aInterestingProperties.push_back( PROPERTY_FORMATKEY );
-aInterestingProperties.push_back( PROPERTY_EMPTY_IS_NULL );
-aInterestingProperties.push_back( PROPERTY_TOGGLE );
-return comphelper::containerToSequence(aInterestingProperties);
+return
+{
+PROPERTY_DATASOURCE,
+PROPERTY_COMMAND,
+PROPERTY_COMMANDTYPE,
+PROPERTY_LISTSOURCE,
+PROPERTY_LISTSOURCETYPE,
+PROPERTY_SUBMIT_ENCODING,
+PROPERTY_REPEAT,
+PROPERTY_TABSTOP,
+PROPERTY_BORDER,
+PROPERTY_CONTROLSOURCE,
+PROPERTY_DROPDOWN,
+PROPERTY_IMAGE_URL,
+PROPERTY_TARGET_URL,
+PROPERTY_STRINGITEMLIST,
+PROPERTY_BUTTONTYPE,
+PROPERTY_ESCAPE_PROCESSING,
+PROPERTY_TRISTATE,
+PROPERTY_DECIMAL_ACCURACY,
+PROPERTY_SHOWTHOUSANDSEP,
+PROPERTY_FORMATKEY,
+PROPERTY_EMPTY_IS_NULL,
+PROPERTY_TOGGLE
+};
}
LineDescriptor SAL_CALL
FormComponentPropertyHandler::describePropertyLine( const OUString&
_rPropertyName,
commit d64a6e2245169e5e4a3f8bc5388b4fff4984e5f4
Author: Julien Nabet
AuthorDate: Sat Oct 16 12:46:10 2021 +0200
Commit: Julien Nabet
CommitDate: Sat Oct 16 18:11:13 2021 +0200
Simplify vector initialization in sdext
Change-Id: If3cebeadff5496ae214614b49116060d24b6082f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123696
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/sdext/source/minimizer/optimizerdialogcontrols.cxx
b/sdext/source/minimizer/optimizerdialogcontrols.cxx
index 79832c36fb2f..23011e50716b 100644
--- a/sdext/source/minimizer/optimizerdialogcontrols.cxx
+++ b/sdext/source/minimizer/optimizerdialogcontrols.cxx
@@ -419,13 +419,15 @@ void OptimizerDialog::UpdateControlStatesPage0()
void OptimizerDialog::InitPage0()
{
Sequence< OUString > aItemList;
-std::vector< OUString > aControlList;
-aControlList.push_back( InsertFixedText( *this, "FixedText0Pg0",
getString( STR_INTRODUCTION ), PAGE_POS_X, PAGE_POS_Y, PAGE_WIDTH, 8, false,
true, mnTabIndex++ ) );
-aControlList.push_back( InsertFixedText( *this,
[Libreoffice-commits] core.git: sd/source
sd/source/core/pglink.cxx|3 -
sd/source/ui/dlg/headerfooterdlg.cxx |8 +--
sd/source/ui/slidesorter/controller/SlsClipboard.cxx |3 -
sd/source/ui/unoidl/unopage.cxx | 50 ++-
sd/source/ui/view/sdview.cxx |5 -
5 files changed, 35 insertions(+), 34 deletions(-)
New commits:
commit 5393f9a53eb8b33537aedd03b7c9efc5222748d6
Author: Julien Nabet
AuthorDate: Sat Oct 16 13:16:55 2021 +0200
Commit: Julien Nabet
CommitDate: Sat Oct 16 18:10:54 2021 +0200
Simplify vector initialization in sd
Change-Id: I5f56919efeea66ce6e644f2cb123fd264edbcb73
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123697
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/sd/source/core/pglink.cxx b/sd/source/core/pglink.cxx
index 6762dcdd9bfa..358012df94f3 100644
--- a/sd/source/core/pglink.cxx
+++ b/sd/source/core/pglink.cxx
@@ -88,8 +88,7 @@ SdPageLink::~SdPageLink()
pPage->SetBookmarkName(aBookmarkName);
}
-std::vector aBookmarkList;
-aBookmarkList.push_back(aBookmarkName);
+std::vector aBookmarkList { aBookmarkName };
sal_uInt16 nInsertPos = pPage->GetPageNum();
bool bNoDialogs = false;
bool bCopy = false;
diff --git a/sd/source/ui/dlg/headerfooterdlg.cxx
b/sd/source/ui/dlg/headerfooterdlg.cxx
index ddc769551d5a..703f2f59809f 100644
--- a/sd/source/ui/dlg/headerfooterdlg.cxx
+++ b/sd/source/ui/dlg/headerfooterdlg.cxx
@@ -671,10 +671,12 @@ void PresLayoutPreview::Paint(vcl::RenderContext&
rRenderContext, SdrTextObj con
// apply line pattern if wanted
if (bDotted)
{
-std::vector aPattern;
static const double fFactor(1.0);
-aPattern.push_back(3.0 * fFactor);
-aPattern.push_back(1.0 * fFactor);
+std::vector aPattern
+{
+3.0 * fFactor,
+1.0 * fFactor
+};
basegfx::B2DPolyPolygon aDashed;
basegfx::utils::applyLineDashing(aGeometry, aPattern, );
diff --git a/sd/source/ui/slidesorter/controller/SlsClipboard.cxx
b/sd/source/ui/slidesorter/controller/SlsClipboard.cxx
index a902383c42e2..d4f52838c859 100644
--- a/sd/source/ui/slidesorter/controller/SlsClipboard.cxx
+++ b/sd/source/ui/slidesorter/controller/SlsClipboard.cxx
@@ -545,8 +545,7 @@ std::shared_ptr
Clipboard::CreateTransferableUserData
//pTransferable->SetView(());
// Set page bookmark list.
-std::vector aPageBookmarks;
-aPageBookmarks.push_back(sBookmark);
+std::vector aPageBookmarks { sBookmark };
pTransferable->SetPageBookmarks(std::move(aPageBookmarks), false);
// Replace the view referenced by the transferable with the
diff --git a/sd/source/ui/unoidl/unopage.cxx b/sd/source/ui/unoidl/unopage.cxx
index 984b5fd0df2c..a9ecb7f5906c 100644
--- a/sd/source/ui/unoidl/unopage.cxx
+++ b/sd/source/ui/unoidl/unopage.cxx
@@ -2061,19 +2061,21 @@ Sequence< uno::Type > SAL_CALL SdDrawPage::getTypes()
bool bPresPage = IsImpressDocument() && ePageKind != PageKind::Handout;
// Collect the types of this class.
-::std::vector aTypes;
+::std::vector aTypes
+{
+cppu::UnoType::get(),
+cppu::UnoType::get(),
+cppu::UnoType::get(),
+cppu::UnoType::get(),
+cppu::UnoType::get(),
+cppu::UnoType::get(),
+cppu::UnoType::get(),
+cppu::UnoType::get(),
+cppu::UnoType::get(),
+cppu::UnoType::get(),
+cppu::UnoType::get()
+};
aTypes.reserve(13);
-aTypes.push_back(cppu::UnoType::get());
-aTypes.push_back(cppu::UnoType::get());
-aTypes.push_back(cppu::UnoType::get());
-aTypes.push_back(cppu::UnoType::get());
-aTypes.push_back(cppu::UnoType::get());
-aTypes.push_back(cppu::UnoType::get());
-aTypes.push_back(cppu::UnoType::get());
-aTypes.push_back(cppu::UnoType::get());
-aTypes.push_back(cppu::UnoType::get());
-aTypes.push_back(cppu::UnoType::get());
-aTypes.push_back(cppu::UnoType::get());
if( bPresPage )
aTypes.push_back(cppu::UnoType::get());
if( bPresPage && ePageKind == PageKind::Standard )
@@ -2664,18 +2666,20 @@ Sequence< uno::Type > SAL_CALL SdMasterPage::getTypes()
bool bPresPage = IsImpressDocument() && SvxFmDrawPage::mpPage &&
ePageKind != PageKind::Handout;
// Collect the types of this class.
-::std::vector aTypes;
+::std::vector aTypes
+{
+cppu::UnoType::get(),
+cppu::UnoType::get(),
+cppu::UnoType::get(),
+cppu::UnoType::get(),
+cppu::UnoType::get(),
+cppu::UnoType::get(),
+cppu::UnoType::get(),
+
[Libreoffice-bugs] [Bug 124807] Cell formatting and calculations of Sexagesimal (base 60) angular measurement, aka DMS
https://bugs.documentfoundation.org/show_bug.cgi?id=124807 Wolfgang Jäger changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||1870 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141870] Fractional formatting: Sequence of preferred denominators (Base 2 mainly); also Writer TextFields
https://bugs.documentfoundation.org/show_bug.cgi?id=141870 Wolfgang Jäger changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||4807 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 124807] Cell formatting and calculations of Sexagesimal (base 60) angular measurement, aka DMS
https://bugs.documentfoundation.org/show_bug.cgi?id=124807 --- Comment #5 from Wolfgang Jäger --- See tdf#141870 A sufficiently general implementation of the feature I requested there would include the enhancement requested here as a use-case. This way we wouldn't need a new formatting feature here and, one there, and probably... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140881] LO fails opening some WOFF and TTF files
https://bugs.documentfoundation.org/show_bug.cgi?id=140881 --- Comment #7 from Eyal Rozenberg --- With a newer build, I get a sequence of such warnings twice: ``` warn:vcl.fonts:2797:2797:vcl/unx/generic/fontmanager/fontmanager.cxx:429: Unimplemented mac encoding 18432 to unicode conversion for fontname Kammer warn:vcl.fonts:2797:2797:vcl/unx/generic/fontmanager/fontmanager.cxx:665: Could not OpenTTFont "/usr/local/share/fonts/freefonts.co.il/OS-Aran-Free-V2.00/OS-Aran-FFC-Webfonts/os_aran_400ffc-webfont.woff": 6 warn:vcl.fonts:2797:2797:vcl/unx/generic/fontmanager/fontmanager.cxx:665: Could not OpenTTFont "/usr/local/share/fonts/freefonts.co.il/OS-Aran-Free-V2.00/OS-Aran-FFC-Webfonts/os_aran_400ffc-webfont.woff2": 6 warn:vcl.fonts:2797:2797:vcl/unx/generic/fontmanager/fontmanager.cxx:665: Could not OpenTTFont "/usr/local/share/fonts/freefonts.co.il/OS-Aran-Free-V2.00/OS-Aran-FFC-Webfonts/os_aran_r_600ffc-webfont.woff": 6 warn:vcl.fonts:2797:2797:vcl/unx/generic/fontmanager/fontmanager.cxx:665: Could not OpenTTFont "/usr/local/share/fonts/freefonts.co.il/OS-Aran-Free-V2.00/OS-Aran-FFC-Webfonts/os_aran_r_600ffc-webfont.woff2": 6 warn:vcl.fonts:2797:2797:vcl/unx/generic/fontmanager/fontmanager.cxx:665: Could not OpenTTFont "/usr/local/share/fonts/freefonts.co.il/OS-Aran-Free-V2.00/OS-Aran-FFC-Webfonts/os_aran_w_500ffc-webfont.woff": 6 warn:vcl.fonts:2797:2797:vcl/unx/generic/fontmanager/fontmanager.cxx:665: Could not OpenTTFont "/usr/local/share/fonts/freefonts.co.il/OS-Aran-Free-V2.00/OS-Aran-FFC-Webfonts/os_aran_w_500ffc-webfont.woff2": 6 warn:sal.textenc:2797:2797:sal/textenc/textcvt.cxx:187: Missing rtl_TextToUnicodeConverter warn:vcl.fonts:2797:2797:vcl/unx/generic/fontmanager/fontmanager.cxx:429: Unimplemented mac encoding 18432 to unicode conversion for fontname YoavKtav Black warn:vcl.fonts:2797:2797:vcl/unx/generic/fontmanager/fontmanager.cxx:665: Could not OpenTTFont "/usr/local/share/fonts/windows/ITC Zapf Dingbats.ttf": 6 warn:vcl.gdi:2814:2814:vcl/source/font/fontcharmap.cxx:223: Format 4 char should not be 0x warn:sal.textenc:2814:2814:sal/textenc/textcvt.cxx:187: Missing rtl_TextToUnicodeConverter warn:sal.textenc:2814:2814:sal/textenc/textcvt.cxx:187: Missing rtl_TextToUnicodeConverter warn:vcl.fonts:2814:2814:vcl/unx/generic/fontmanager/fontmanager.cxx:429: Unimplemented mac encoding 18432 to unicode conversion for fontname Kammer warn:vcl.fonts:2814:2814:vcl/unx/generic/fontmanager/fontmanager.cxx:665: Could not OpenTTFont "/usr/local/share/fonts/freefonts.co.il/OS-Aran-Free-V2.00/OS-Aran-FFC-Webfonts/os_aran_400ffc-webfont.woff": 6 warn:vcl.fonts:2814:2814:vcl/unx/generic/fontmanager/fontmanager.cxx:665: Could not OpenTTFont "/usr/local/share/fonts/freefonts.co.il/OS-Aran-Free-V2.00/OS-Aran-FFC-Webfonts/os_aran_400ffc-webfont.woff2": 6 warn:vcl.fonts:2814:2814:vcl/unx/generic/fontmanager/fontmanager.cxx:665: Could not OpenTTFont "/usr/local/share/fonts/freefonts.co.il/OS-Aran-Free-V2.00/OS-Aran-FFC-Webfonts/os_aran_r_600ffc-webfont.woff": 6 warn:vcl.fonts:2814:2814:vcl/unx/generic/fontmanager/fontmanager.cxx:665: Could not OpenTTFont "/usr/local/share/fonts/freefonts.co.il/OS-Aran-Free-V2.00/OS-Aran-FFC-Webfonts/os_aran_r_600ffc-webfont.woff2": 6 warn:vcl.fonts:2814:2814:vcl/unx/generic/fontmanager/fontmanager.cxx:665: Could not OpenTTFont "/usr/local/share/fonts/freefonts.co.il/OS-Aran-Free-V2.00/OS-Aran-FFC-Webfonts/os_aran_w_500ffc-webfont.woff": 6 warn:vcl.fonts:2814:2814:vcl/unx/generic/fontmanager/fontmanager.cxx:665: Could not OpenTTFont "/usr/local/share/fonts/freefonts.co.il/OS-Aran-Free-V2.00/OS-Aran-FFC-Webfonts/os_aran_w_500ffc-webfont.woff2": 6 warn:sal.textenc:2814:2814:sal/textenc/textcvt.cxx:187: Missing rtl_TextToUnicodeConverter warn:vcl.fonts:2814:2814:vcl/unx/generic/fontmanager/fontmanager.cxx:429: Unimplemented mac encoding 18432 to unicode conversion for fontname YoavKtav Black warn:vcl.fonts:2814:2814:vcl/unx/generic/fontmanager/fontmanager.cxx:665: Could not OpenTTFont "/usr/local/share/fonts/windows/ITC Zapf Dingbats.ttf": 6 ``` -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140879] [META] Console noise
https://bugs.documentfoundation.org/show_bug.cgi?id=140879 Bug 140879 depends on bug 140878, which changed state. Bug 140878 Summary: Config manager fails to parse registrymodifications.xcu https://bugs.documentfoundation.org/show_bug.cgi?id=140878 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140878] Config manager fails to parse registrymodifications.xcu
https://bugs.documentfoundation.org/show_bug.cgi?id=140878 Eyal Rozenberg changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEEDINFO|RESOLVED --- Comment #2 from Eyal Rozenberg --- Can no longer reproduce (with master build 2021-10-14_11.54.20), so resolving. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145169] Remote Save: uses "seen in directory" filename instead of existing filename
https://bugs.documentfoundation.org/show_bug.cgi?id=145169 --- Comment #1 from Justin L --- IMPL_LINK_NOARG ( RemoteFilesDialog, OkHdl, weld::Button&, void ) bSelected is pretty much always true. But it should be irrelevant, because the filename box is tied to it if a real file is selected. (For example, just browsing through the folders also ends up with strange results when a folder is automatically "selected".) It looks like this dialog is used for other things? Opening for one, and PATH-ONLY dialog somehow? Perhaps it needs to be: if( !bSelected || (m_eMode == REMOTEDLG_MODE_SAVE && m_eType == REMOTEDLG_TYPE_FILEDLG) ) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: embeddedobj/source include/systools
embeddedobj/source/msole/olecomponent.cxx | 206 +-
include/systools/win32/comtools.hxx | 52 ---
2 files changed, 67 insertions(+), 191 deletions(-)
New commits:
commit a8a07cea28fd79e240c3abb084b88f4e23674fd6
Author: Mike Kaganski
AuthorDate: Sat Oct 16 13:04:02 2021 +0300
Commit: Mike Kaganski
CommitDate: Sat Oct 16 17:24:08 2021 +0200
Use sal::systools::COMReference and drop ComSmart
Change-Id: Ic6e0c87f607264629cdec1fdcd0c3144d8fbf8e6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123695
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/embeddedobj/source/msole/olecomponent.cxx
b/embeddedobj/source/msole/olecomponent.cxx
index f57d0f1d85b8..4c44d36636fc 100644
--- a/embeddedobj/source/msole/olecomponent.cxx
+++ b/embeddedobj/source/msole/olecomponent.cxx
@@ -40,6 +40,7 @@
#include
#include
#include
+#include
#include
#include "graphconvert.hxx"
@@ -57,123 +58,6 @@ using namespace ::comphelper;
#define MAX_ENUM_ELE 20
#define FORMATS_NUM 3
-// class ComSmart =
-namespace {
-
-template< class T > class ComSmart
-{
-T* m_pInterface;
-
-void OwnRelease()
-{
-if ( m_pInterface )
-{
-T* pInterface = m_pInterface;
-m_pInterface = nullptr;
-pInterface->Release();
-}
-}
-
-public:
-ComSmart()
-: m_pInterface( nullptr )
-{}
-
-ComSmart( const ComSmart& rObj )
-: m_pInterface( rObj.m_pInterface )
-{
-if ( m_pInterface != NULL )
-m_pInterface->AddRef();
-}
-
-ComSmart( T* pInterface )
-: m_pInterface( pInterface )
-{
- if ( m_pInterface != NULL )
-m_pInterface->AddRef();
-}
-
-~ComSmart()
-{
-OwnRelease();
-}
-
-ComSmart& operator=( const ComSmart& rObj )
-{
-if(this == )
-return *this;
-
-OwnRelease();
-
-m_pInterface = rObj.m_pInterface;
-
-if ( m_pInterface != NULL )
-m_pInterface->AddRef();
-
-return *this;
-}
-
-ComSmart& operator=( T* pInterface )
-{
-OwnRelease();
-
-m_pInterface = pInterface;
-
-if ( m_pInterface != NULL )
-m_pInterface->AddRef();
-
-return *this;
-}
-
-operator T*() const
-{
-return m_pInterface;
-}
-
-T& operator*() const
-{
-return *m_pInterface;
-}
-
-T** operator&()
-{
-OwnRelease();
-
-m_pInterface = nullptr;
-
-return _pInterface;
-}
-
-T* operator->() const
-{
-return m_pInterface;
-}
-
-bool operator==( const ComSmart& rObj ) const
-{
-return ( m_pInterface == rObj.m_pInterface );
-}
-
-bool operator!=( const ComSmart& rObj ) const
-{
-return ( m_pInterface != rObj.m_pInterface );
-}
-
-bool operator==( const T* pInterface ) const
-{
-return ( m_pInterface == pInterface );
-}
-
-bool operator!=( const T* pInterface ) const
-{
-return ( m_pInterface != pInterface );
-}
-};
-
-}
-
-// class ComSmart =
-
typedef std::vector< FORMATETC* > FormatEtcList;
FORMATETC const pFormatTemplates[FORMATS_NUM] = {
@@ -183,10 +67,10 @@ FORMATETC const pFormatTemplates[FORMATS_NUM] = {
struct OleComponentNative_Impl {
-ComSmart< IUnknown > m_pObj;
-ComSmart< IOleObject > m_pOleObject;
-ComSmart< IViewObject2 > m_pViewObject2;
-ComSmart< IStorage > m_pIStorage;
+sal::systools::COMReference< IUnknown > m_pObj;
+sal::systools::COMReference< IOleObject > m_pOleObject;
+sal::systools::COMReference< IViewObject2 > m_pViewObject2;
+sal::systools::COMReference< IStorage > m_pIStorage;
FormatEtcList m_aFormatsList;
uno::Sequence< datatransfer::DataFlavor > m_aSupportedGraphFormats;
@@ -599,12 +483,11 @@ void OleComponent::RetrieveObjectDataFlavors_Impl()
if ( !m_aDataFlavors.getLength() )
{
-ComSmart< IDataObject > pDataObject;
-HRESULT hr = m_pNativeImpl->m_pObj->QueryInterface( IID_IDataObject,
reinterpret_cast() );
-if ( SUCCEEDED( hr ) && pDataObject )
+sal::systools::COMReference< IDataObject >
pDataObject(m_pNativeImpl->m_pObj, sal::systools::COM_QUERY);
+if ( pDataObject )
{
-ComSmart< IEnumFORMATETC > pFormatEnum;
-hr = pDataObject->EnumFormatEtc( DATADIR_GET, );
+sal::systools::COMReference< IEnumFORMATETC > pFormatEnum;
+HRESULT hr = pDataObject->EnumFormatEtc( DATADIR_GET,
);
if ( SUCCEEDED( hr ) && pFormatEnum )
{
FORMATETC pElem[ MAX_ENUM_ELE ];
@@ -651,20 +534,15 @@ bool OleComponent::InitializeObject_Impl()
return false;
// the linked object will be detected here
-ComSmart< IOleLink > pOleLink;
[Libreoffice-bugs] [Bug 145170] Anomalous Behaviour Concerning Mixing Ctrl+F5 Keyboard Shortcut and Hide/Show Panel Button
https://bugs.documentfoundation.org/show_bug.cgi?id=145170 Radish changed: What|Removed |Added CC||babelfish0...@hotmail.com --- Comment #1 from Radish --- I should add that I'm a relatively new user of LibreOffice and that I really don't know if LibreOffice 7.2.1.2 is the earliest version which is affected by this behaviour. (Apologies.) -- You are receiving this mail because: You are the assignee for the bug.
