[Libreoffice-bugs] [Bug 127466] Allow style-dependent hyphenation
https://bugs.documentfoundation.org/show_bug.cgi?id=127466 Timur changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: writerperfect/inc writerperfect/qa writerperfect/source
writerperfect/inc/ImportFilter.hxx |4 +-- writerperfect/qa/unit/WpftLoader.cxx| 19 writerperfect/source/impress/KeynoteImportFilter.cxx| 17 +++--- writerperfect/source/writer/WordPerfectImportFilter.cxx |4 +-- 4 files changed, 23 insertions(+), 21 deletions(-) New commits: commit 34d0dd41e1e7bb69d6c4f817b39da26bcd33831f Author: Mike Kaganski AuthorDate: Fri Oct 29 10:27:18 2021 +0300 Commit: Mike Kaganski CommitDate: Mon Nov 1 06:39:25 2021 +0100 Prepare for removal of non-const operator[] from Sequence in writerperfect Change-Id: Ifaa868e8e68be474c1e8b961b325ce2a7382650e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124414 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/writerperfect/inc/ImportFilter.hxx b/writerperfect/inc/ImportFilter.hxx index 69b0e77631e0..4f69d160419f 100644 --- a/writerperfect/inc/ImportFilter.hxx +++ b/writerperfect/inc/ImportFilter.hxx @@ -139,10 +139,10 @@ public: if (location == nLength) { Descriptor.realloc(nLength + 1); -Descriptor[location].Name = "TypeName"; +Descriptor.getArray()[location].Name = "TypeName"; } -Descriptor[location].Value <<= sTypeName; +Descriptor.getArray()[location].Value <<= sTypeName; } return sTypeName; diff --git a/writerperfect/qa/unit/WpftLoader.cxx b/writerperfect/qa/unit/WpftLoader.cxx index c5e7b7b60700..d0809b909918 100644 --- a/writerperfect/qa/unit/WpftLoader.cxx +++ b/writerperfect/qa/unit/WpftLoader.cxx @@ -123,21 +123,22 @@ bool WpftLoader::impl_load() xImporter->setTargetDocument(m_xDoc); uno::Sequence aDescriptor(3); -aDescriptor[0].Name = "URL"; -aDescriptor[0].Value <<= m_aURL; +auto pDescriptor = aDescriptor.getArray(); +pDescriptor[0].Name = "URL"; +pDescriptor[0].Value <<= m_aURL; if (m_xInputStream.is()) { -aDescriptor[1].Name = "InputStream"; -aDescriptor[1].Value <<= m_xInputStream; +pDescriptor[1].Name = "InputStream"; +pDescriptor[1].Value <<= m_xInputStream; } else { ucbhelper::Content aContent(m_aURL, uno::Reference(), m_xContext); -aDescriptor[1].Name = "InputStream"; -aDescriptor[1].Value <<= aContent.openStream(); -aDescriptor[2].Name = "UCBContent"; -aDescriptor[2].Value <<= aContent.get(); +pDescriptor[1].Name = "InputStream"; +pDescriptor[1].Value <<= aContent.openStream(); +pDescriptor[2].Name = "UCBContent"; +pDescriptor[2].Value <<= aContent.get(); } const uno::Reference xDetector(m_xFilter, @@ -194,7 +195,7 @@ void WpftLoader::impl_detectFilterName(uno::Sequence& rDes { const sal_Int32 nDescriptorLen = rDescriptor.getLength(); rDescriptor.realloc(nDescriptorLen + 1); -auto& el = rDescriptor[nDescriptorLen]; +auto& el = rDescriptor.getArray()[nDescriptorLen]; el.Name = "FilterName"; el.Value <<= aFilterName; return; diff --git a/writerperfect/source/impress/KeynoteImportFilter.cxx b/writerperfect/source/impress/KeynoteImportFilter.cxx index 900555be6e0b..ccd93e3d2aaa 100644 --- a/writerperfect/source/impress/KeynoteImportFilter.cxx +++ b/writerperfect/source/impress/KeynoteImportFilter.cxx @@ -170,19 +170,20 @@ KeynoteImportFilter::detect(css::uno::Sequence& Descr if (nNewLength > nLength) Descriptor.realloc(nNewLength); +auto pDescriptor = Descriptor.getArray(); if (nTypeNameLocation == -1) { assert(nLength < nNewLength); nTypeNameLocation = nLength++; -Descriptor[nTypeNameLocation].Name = "TypeName"; +pDescriptor[nTypeNameLocation].Name = "TypeName"; } if (bIsPackage && (nComponentDataLocation == -1)) { assert(nLength < nNewLength); nComponentDataLocation = nLength++; -Descriptor[nComponentDataLocation].Name = "ComponentData"; +pDescriptor[nComponentDataLocation].Name = "ComponentData"; } if (bIsPackage) @@ -194,8 +195,8 @@ KeynoteImportFilter::detect(css::uno::Sequence& Descr beans::NamedValue aValue; aValue.Name = "IsPackage"; aValue.Value <<= true; -lComponentDataNV[nCDSize] = aValue; -Descriptor[nComponentDataLocation].Value <<= lComponentDataNV; +lComponentDataNV.getArray()[nCDSize] = aValue; +pDescriptor[nComponentDataLocation].Value <<= lComponentDataNV; } else { @@ -206,16 +207,16 @@ KeynoteImportFilter::detect(css::uno::Sequence& Descr
[Libreoffice-bugs] [Bug 145482] LibreOffice Calc: enable partial column/row notation
https://bugs.documentfoundation.org/show_bug.cgi?id=145482 --- Comment #1 from Mike Kaganski --- (In reply to jackyguo579 from comment #0) > Google Sheets and Excel also support partial columns and rows. Example: B2:B > means every cell in column B at or below B2, E5:5 means every cell in row 5 > at or to the right of E5. At least not Excel. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: writerfilter/source
writerfilter/source/dmapper/DomainMapperTableHandler.cxx | 48 --- writerfilter/source/dmapper/DomainMapper_Impl.cxx| 39 ++-- writerfilter/source/dmapper/GraphicImport.cxx|7 -- writerfilter/source/dmapper/NumberingManager.cxx | 17 +++-- writerfilter/source/dmapper/SettingsTable.cxx| 25 --- writerfilter/source/dmapper/StyleSheetTable.cxx |8 +- writerfilter/source/dmapper/WrapPolygonHandler.cxx |5 - writerfilter/source/dmapper/WriteProtection.cxx | 15 +--- writerfilter/source/ooxml/OOXMLDocumentImpl.cxx |9 -- writerfilter/source/ooxml/OOXMLFastContextHandler.cxx|6 - writerfilter/source/ooxml/factoryimpl.py |3 writerfilter/source/rtftok/rtfsdrimport.cxx |5 - 12 files changed, 83 insertions(+), 104 deletions(-) New commits: commit 2b9bd1031cc4f627f83b62288a57b27e6cb9bc3e Author: Mike Kaganski AuthorDate: Fri Oct 29 10:26:30 2021 +0300 Commit: Mike Kaganski CommitDate: Mon Nov 1 06:22:35 2021 +0100 Prepare for removal of non-const operator[] from Sequence in writerfilter Change-Id: I4002bc1ca227726bf1c36ecdb657175a42c2d9be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124413 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/writerfilter/source/dmapper/DomainMapperTableHandler.cxx b/writerfilter/source/dmapper/DomainMapperTableHandler.cxx index 5278206552f8..916ff5b5828d 100644 --- a/writerfilter/source/dmapper/DomainMapperTableHandler.cxx +++ b/writerfilter/source/dmapper/DomainMapperTableHandler.cxx @@ -363,37 +363,18 @@ TableStyleSheetEntry * DomainMapperTableHandler::endTableGetTableStyle(TableInfo { TablePositionHandler *pTablePositions = m_rDMapper_Impl.getTableManager().getCurrentTableRealPosition(); -uno::Sequence< beans::PropertyValue > aGrabBagTS( 10 ); - -aGrabBagTS[0].Name = "bottomFromText"; -aGrabBagTS[0].Value <<= pTablePositions->getBottomFromText(); - -aGrabBagTS[1].Name = "horzAnchor"; -aGrabBagTS[1].Value <<= pTablePositions->getHorzAnchor(); - -aGrabBagTS[2].Name = "leftFromText"; -aGrabBagTS[2].Value <<= pTablePositions->getLeftFromText(); - -aGrabBagTS[3].Name = "rightFromText"; -aGrabBagTS[3].Value <<= pTablePositions->getRightFromText(); - -aGrabBagTS[4].Name = "tblpX"; -aGrabBagTS[4].Value <<= pTablePositions->getX(); - -aGrabBagTS[5].Name = "tblpXSpec"; -aGrabBagTS[5].Value <<= pTablePositions->getXSpec(); - -aGrabBagTS[6].Name = "tblpY"; -aGrabBagTS[6].Value <<= pTablePositions->getY(); - -aGrabBagTS[7].Name = "tblpYSpec"; -aGrabBagTS[7].Value <<= pTablePositions->getYSpec(); - -aGrabBagTS[8].Name = "topFromText"; -aGrabBagTS[8].Value <<= pTablePositions->getTopFromText(); - -aGrabBagTS[9].Name = "vertAnchor"; -aGrabBagTS[9].Value <<= pTablePositions->getVertAnchor(); +uno::Sequence< beans::PropertyValue > aGrabBagTS{ +comphelper::makePropertyValue("bottomFromText", pTablePositions->getBottomFromText()), +comphelper::makePropertyValue("horzAnchor", pTablePositions->getHorzAnchor()), +comphelper::makePropertyValue("leftFromText", pTablePositions->getLeftFromText()), +comphelper::makePropertyValue("rightFromText", pTablePositions->getRightFromText()), +comphelper::makePropertyValue("tblpX", pTablePositions->getX()), +comphelper::makePropertyValue("tblpXSpec", pTablePositions->getXSpec()), +comphelper::makePropertyValue("tblpY", pTablePositions->getY()), +comphelper::makePropertyValue("tblpYSpec", pTablePositions->getYSpec()), +comphelper::makePropertyValue("topFromText", pTablePositions->getTopFromText()), +comphelper::makePropertyValue("vertAnchor", pTablePositions->getVertAnchor()) +}; aGrabBag["TablePosition"] <<= aGrabBagTS; } @@ -1066,6 +1047,7 @@ css::uno::Sequence DomainMapperTableHandler::endTabl #endif css::uno::Sequence aRowProperties( m_aRowProperties.size() ); +auto aRowPropertiesRange = asNonConstRange(aRowProperties); sal_Int32 nRow = 0; for( const auto& rRow : m_aRowProperties ) { @@ -1086,7 +1068,7 @@ css::uno::Sequence DomainMapperTableHandler::endTabl rRow->Insert(PROP_SIZE_TYPE, uno::makeAny(text::SizeType::FIX)); } -aRowProperties[nRow] = rRow->GetPropertyValues(); +aRowPropertiesRange[nRow] = rRow->GetPropertyValues(); #ifdef DBG_UTIL rRow->dumpXml(); lcl_DumpPropertyValues(aRowProperties[nRow]); @@ -1477,7 +1459,7 @@ void
[Libreoffice-bugs] [Bug 138475] Default Asian font-size in Calc Heading styles are not the same as Western fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=138475 --- Comment #10 from Kevin Suo --- Ok I see: https://opengrok.libreoffice.org/xref/core/sc/source/filter/orcus/interface.cxx?r=20f064c1#1359 Here the ATTR_CJK_* and ATTR_CTL_* attributes should also be applied to the itemset. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139205] Translated Calc styles lose hirearchical structure
https://bugs.documentfoundation.org/show_bug.cgi?id=139205 --- Comment #8 from Kevin Suo --- https://opengrok.libreoffice.org/xref/core/sc/source/filter/orcus/interface.cxx?r=20f064c1#2161 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: winaccessibility/source
winaccessibility/source/UAccCOM/AccEditableText.cxx | 16 +--- winaccessibility/source/UAccCOM/AccTextBase.cxx |2 +- 2 files changed, 10 insertions(+), 8 deletions(-) New commits: commit ac31338c19c1d4843ffb66bac41feaad97d6e988 Author: Mike Kaganski AuthorDate: Fri Oct 29 10:25:38 2021 +0300 Commit: Mike Kaganski CommitDate: Mon Nov 1 06:07:00 2021 +0100 Prepare for removal of non-const operator[] from Sequence in winaccessibility Change-Id: Ib689146520a99bbdaa7020583a4f34603c26ca19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124412 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/winaccessibility/source/UAccCOM/AccEditableText.cxx b/winaccessibility/source/UAccCOM/AccEditableText.cxx index 6c2962074e37..a953eacf1334 100644 --- a/winaccessibility/source/UAccCOM/AccEditableText.cxx +++ b/winaccessibility/source/UAccCOM/AccEditableText.cxx @@ -232,6 +232,7 @@ COM_DECLSPEC_NOTHROW STDMETHODIMP CAccEditableText::setAttributes(long startOffs vecAttr.push_back(ouStr.getToken(0, ';', nIndex)); Sequence< PropertyValue > beanSeq(vecAttr.size()); +auto beanSeqRange = asNonConstRange(beanSeq); for(std::vector::size_type i = 0; i < vecAttr.size(); i ++) { OUString attr = vecAttr[i]; @@ -240,8 +241,8 @@ COM_DECLSPEC_NOTHROW STDMETHODIMP CAccEditableText::setAttributes(long startOffs { OUString attrName = attr.copy(0, nPos); OUString attrValue = attr.copy(nPos + 1); -beanSeq[i].Name = attrName; -get_AnyFromOLECHAR(attrName, attrValue, beanSeq[i].Value); +beanSeqRange[i].Name = attrName; +get_AnyFromOLECHAR(attrName, attrValue, beanSeqRange[i].Value); } } @@ -398,22 +399,23 @@ void CAccEditableText::get_AnyFromOLECHAR(std::u16string_view ouName, const OUSt // Dump into Sequence. int iSeqLen = (vecTabStop.size() == 0) ? 1 : vecTabStop.size(); Sequence< css::style::TabStop > seqTabStop(iSeqLen); +auto pseqTabStop = seqTabStop.getArray(); if(vecTabStop.size() != 0) { // Dump every element. for(int i = 0; i < iSeqLen; i ++) { -seqTabStop[i] = vecTabStop[i]; +pseqTabStop[i] = vecTabStop[i]; } } else { // Create default value. -seqTabStop[0].Position = 0; -seqTabStop[0].Alignment = css::style::TabAlign_DEFAULT; -seqTabStop[0].DecimalChar = '.'; -seqTabStop[0].FillChar = ' '; +pseqTabStop[0].Position = 0; +pseqTabStop[0].Alignment = css::style::TabAlign_DEFAULT; +pseqTabStop[0].DecimalChar = '.'; +pseqTabStop[0].FillChar = ' '; } // Assign to Any object. diff --git a/winaccessibility/source/UAccCOM/AccTextBase.cxx b/winaccessibility/source/UAccCOM/AccTextBase.cxx index 5fb59edb494d..47225cb46f25 100644 --- a/winaccessibility/source/UAccCOM/AccTextBase.cxx +++ b/winaccessibility/source/UAccCOM/AccTextBase.cxx @@ -157,7 +157,7 @@ COM_DECLSPEC_NOTHROW STDMETHODIMP CAccTextBase::get_attributes(long offset, long for(int i =0; i
[Libreoffice-bugs] [Bug 90796] [META] HiDPI / Retina bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=90796 Bug 90796 depends on bug 142061, which changed state. Bug 142061 Summary: macOS: Calc UI: Display anomalies when resizing columns https://bugs.documentfoundation.org/show_bug.cgi?id=142061 What|Removed |Added Status|VERIFIED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: 2 commits - vbahelper/source vcl/osx vcl/qa vcl/qt5 vcl/source vcl/unx vcl/win vcl/workben
vbahelper/source/msforms/vbacontrol.cxx |4 vbahelper/source/msforms/vbacontrols.cxx |5 - vbahelper/source/msforms/vbalistbox.cxx |8 - vbahelper/source/msforms/vbalistcontrolhelper.cxx|7 - vbahelper/source/vbahelper/vbaapplicationbase.cxx|6 - vbahelper/source/vbahelper/vbacommandbarcontrols.cxx | 52 -- vbahelper/source/vbahelper/vbadocumentbase.cxx |5 - vbahelper/source/vbahelper/vbadocumentsbase.cxx | 10 +- vbahelper/source/vbahelper/vbaeventshelperbase.cxx |2 vbahelper/source/vbahelper/vbahelper.cxx |5 - vcl/osx/DataFlavorMapping.cxx|2 vcl/qa/cppunit/canvasbitmaptest.cxx |7 - vcl/qa/cppunit/graphicfilter/filters-test.cxx| 13 +- vcl/qt5/QtFilePicker.cxx |6 - vcl/qt5/QtTransferable.cxx |5 - vcl/source/filter/FilterConfigCache.cxx |3 vcl/source/filter/FilterConfigItem.cxx | 15 +-- vcl/source/filter/GraphicNativeTransform.cxx | 13 +- vcl/source/filter/graphicfilter.cxx | 15 +-- vcl/source/filter/wmf/wmfexternal.cxx| 17 +-- vcl/source/gdi/embeddedfontshelper.cxx |3 vcl/source/gdi/oldprintadaptor.cxx | 15 +-- vcl/source/gdi/pdfwriter_impl2.cxx | 27 ++--- vcl/source/gdi/print3.cxx| 65 ++--- vcl/source/helper/canvasbitmap.cxx | 92 +++ vcl/source/outdev/outdev.cxx | 13 +- vcl/source/treelist/transfer.cxx |5 - vcl/source/treelist/transfer2.cxx|3 vcl/source/uitest/uno/uiobject_uno.cxx | 19 +-- vcl/source/window/mouse.cxx | 18 ++- vcl/source/window/window.cxx | 16 +-- vcl/unx/generic/dtrans/X11_service.cxx |3 vcl/unx/generic/gdi/salgdi.cxx |9 + vcl/unx/gtk3/a11y/atktextattributes.cxx |7 - vcl/unx/gtk3/fpicker/SalGtkFilePicker.cxx|8 + vcl/unx/gtk3/gtkinst.cxx |6 - vcl/win/dtrans/DOTransferable.cxx|2 vcl/workben/fftester.cxx |3 38 files changed, 236 insertions(+), 278 deletions(-) New commits: commit 951c4ceb2e86c52cb6549afadbe4d3148e1c808c Author: Mike Kaganski AuthorDate: Fri Oct 29 10:24:13 2021 +0300 Commit: Mike Kaganski CommitDate: Mon Nov 1 05:26:16 2021 +0100 Prepare for removal of non-const operator[] from Sequence in vbahelper Change-Id: I2450faf4b3e093b2046034e2a5e5657ff5144d98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124410 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/vbahelper/source/msforms/vbacontrol.cxx b/vbahelper/source/msforms/vbacontrol.cxx index 1c70be2c987d..b0b33543e059 100644 --- a/vbahelper/source/msforms/vbacontrol.cxx +++ b/vbahelper/source/msforms/vbacontrol.cxx @@ -532,7 +532,7 @@ void SAL_CALL ScVbaControl::fireEvent( const script::ScriptEvent& rEvt ) evt.ScriptCode = xNameQuery->getCodeNameForObject( xIf ); // handle if we passed in our own arguments if ( !rEvt.Arguments.hasElements() ) -evt.Arguments[ 0 ] <<= aEvt; +evt.Arguments.getArray()[ 0 ] <<= aEvt; xScriptListener->firing( evt ); } else @@ -546,7 +546,7 @@ void SAL_CALL ScVbaControl::fireEvent( const script::ScriptEvent& rEvt ) evt.Source = xThisControl; aEvt.Source = xControl; evt.ScriptCode = m_sLibraryAndCodeName; -evt.Arguments[ 0 ] <<= aEvt; +evt.Arguments.getArray()[ 0 ] <<= aEvt; xScriptListener->firing( evt ); } } diff --git a/vbahelper/source/msforms/vbacontrols.cxx b/vbahelper/source/msforms/vbacontrols.cxx index 2b7c92374fcf..6f36280aa26f 100644 --- a/vbahelper/source/msforms/vbacontrols.cxx +++ b/vbahelper/source/msforms/vbacontrols.cxx @@ -61,7 +61,7 @@ private: if ( nIndex >= msNames.getLength() ) msNames.realloc( nIndex ); -msNames[ nIndex ] = getControlName( xCtrl ); +msNames.getArray()[ nIndex ] = getControlName( xCtrl ); mControls.push_back( xCtrl ); mIndices[ msNames[ nIndex ] ] = nIndex; } @@ -382,8 +382,7 @@ uno::Any SAL_CALL ScVbaControls::Add( const uno::Any& Object, const uno::Any& St { uno::Reference< script::XInvocation > xControlInvoke( xNewControl, uno::UNO_QUERY_THROW ); -uno::Sequence< uno::Any > aArgs( 1 ); -aArgs[0] <<= aComServiceName; +uno::Sequence<
[Libreoffice-commits] core.git: unotools/source
unotools/source/config/compatibility.cxx |8 --- unotools/source/config/configitem.cxx | 29 +- unotools/source/config/configmgr.cxx | 12 -- unotools/source/config/dynamicmenuoptions.cxx |9 unotools/source/config/eventcfg.cxx | 22 ++- unotools/source/config/lingucfg.cxx |3 -- unotools/source/config/moduleoptions.cxx | 11 + unotools/source/config/optionsdlg.cxx |9 ++-- unotools/source/config/securityoptions.cxx| 24 +++-- unotools/source/i18n/localedatawrapper.cxx| 14 ++-- unotools/source/misc/ZipPackageHelper.cxx | 13 --- 11 files changed, 81 insertions(+), 73 deletions(-) New commits: commit 1be268f3ec7661be232b8f5dc18546d1410dfd52 Author: Mike Kaganski AuthorDate: Fri Oct 29 10:22:09 2021 +0300 Commit: Mike Kaganski CommitDate: Mon Nov 1 05:25:36 2021 +0100 Prepare for removal of non-const operator[] from Sequence in unotools Change-Id: I720d1c1e4a8d32e8a7c7ac62ab9cf988bac31d01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124406 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/unotools/source/config/compatibility.cxx b/unotools/source/config/compatibility.cxx index 9c11393d0408..46d50889f6bc 100644 --- a/unotools/source/config/compatibility.cxx +++ b/unotools/source/config/compatibility.cxx @@ -250,6 +250,7 @@ void SvtCompatibilityOptions_Impl::ImplCommit() ClearNodeSet( SETNODE_ALLFILEFORMATS ); Sequence< PropertyValue > lPropertyValues( SvtCompatibilityEntry::getElementCount() - 1 ); +auto lPropertyValuesRange = asNonConstRange(lPropertyValues); sal_uInt32 nNewCount = m_aOptions.size(); for ( sal_uInt32 nItem = 0; nItem < nNewCount; ++nItem ) { @@ -258,8 +259,8 @@ void SvtCompatibilityOptions_Impl::ImplCommit() for ( int i = static_cast(SvtCompatibilityEntry::Index::Module); i < static_cast(SvtCompatibilityEntry::Index::INVALID); ++i ) { -lPropertyValues[ i - 1 ].Name = sNode + SvtCompatibilityEntry::getName( SvtCompatibilityEntry::Index(i) ); -lPropertyValues[ i - 1 ].Value = aItem.getValue( SvtCompatibilityEntry::Index(i) ); +lPropertyValuesRange[ i - 1 ].Name = sNode + SvtCompatibilityEntry::getName( SvtCompatibilityEntry::Index(i) ); +lPropertyValuesRange[ i - 1 ].Value = aItem.getValue( SvtCompatibilityEntry::Index(i) ); } SetSetProperties( SETNODE_ALLFILEFORMATS, lPropertyValues ); @@ -273,6 +274,7 @@ Sequence< OUString > SvtCompatibilityOptions_Impl::impl_GetPropertyNames( Sequen // expand list to result list ... Sequence< OUString > lProperties( rItems.getLength() * ( SvtCompatibilityEntry::getElementCount() - 1 ) ); +auto lPropertiesRange = asNonConstRange(lProperties); sal_Int32 nDestStep= 0; // Copy entries to destination and expand every item with 2 supported sub properties. @@ -281,7 +283,7 @@ Sequence< OUString > SvtCompatibilityOptions_Impl::impl_GetPropertyNames( Sequen OUString sFixPath = SETNODE_ALLFILEFORMATS PATHDELIMITER + rItem + PATHDELIMITER; for ( int i = static_cast(SvtCompatibilityEntry::Index::Module); i < static_cast(SvtCompatibilityEntry::Index::INVALID); ++i ) { -lProperties[ nDestStep ] = sFixPath + SvtCompatibilityEntry::getName( SvtCompatibilityEntry::Index(i) ); +lPropertiesRange[ nDestStep ] = sFixPath + SvtCompatibilityEntry::getName( SvtCompatibilityEntry::Index(i) ); nDestStep++; } } diff --git a/unotools/source/config/configitem.cxx b/unotools/source/config/configitem.cxx index 37a5cd4d8cb0..dd8c567e639f 100644 --- a/unotools/source/config/configitem.cxx +++ b/unotools/source/config/configitem.cxx @@ -193,6 +193,7 @@ void ConfigItem::impl_packLocalizedProperties( const Sequence< OUString >& // The result list we pack into the return any. We never change size of lists! nSourceSize = lInNames.getLength(); lOutValues.realloc( nSourceSize ); +auto plOutValues = lOutValues.getArray(); // Algorithm: // Copy all names and values from in to out lists. @@ -213,22 +214,23 @@ void ConfigItem::impl_packLocalizedProperties( const Sequence< OUString >& lPropertyNames = xSetAccess->getElementNames(); nPropertiesSize = lPropertyNames.getLength(); lProperties.realloc( nPropertiesSize ); +auto plProperties = lProperties.getArray(); for( nPropertyCounter=0; nPropertyCountergetByName( lPropertyNames[nPropertyCounter] ) >>= sLocaleValue; -lProperties[nPropertyCounter].Value <<= sLocaleValue; +plProperties[nPropertyCounter].Value <<= sLocaleValue; } -
[Libreoffice-bugs] [Bug 145172] URL not recognised when "autocorrection > detect url" is ON (both modes) and autocorrection is on
https://bugs.documentfoundation.org/show_bug.cgi?id=145172 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145189] Crash doing a SaveAll of 21 documents
https://bugs.documentfoundation.org/show_bug.cgi?id=145189 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145184] Custom number on numbered list
https://bugs.documentfoundation.org/show_bug.cgi?id=145184 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145182] RESIZE of Navigator does not work as it should
https://bugs.documentfoundation.org/show_bug.cgi?id=145182 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145178] Custom formats for Footnotes/Endnotes inside a section are not read from saved files
https://bugs.documentfoundation.org/show_bug.cgi?id=145178 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145301] Emojis cause major performance issues
https://bugs.documentfoundation.org/show_bug.cgi?id=145301 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145301] Emojis cause major performance issues
https://bugs.documentfoundation.org/show_bug.cgi?id=145301 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144994] libreoffice crashes with kf5-wayland
https://bugs.documentfoundation.org/show_bug.cgi?id=144994 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144994] libreoffice crashes with kf5-wayland
https://bugs.documentfoundation.org/show_bug.cgi?id=144994 --- Comment #5 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142069] Pulldown not able to see all if text size is 125% on windows 10
https://bugs.documentfoundation.org/show_bug.cgi?id=142069 --- Comment #2 from QA Administrators --- Dear Mark Mclean, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142062] LibreOffice Impress 7.0.5.2 does not play videos, UI unless you open the slide with the video first in the Normal View
https://bugs.documentfoundation.org/show_bug.cgi?id=142062 --- Comment #3 from QA Administrators --- Dear Christian Kleijn, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142044] problem with slide transition effects
https://bugs.documentfoundation.org/show_bug.cgi?id=142044 --- Comment #5 from QA Administrators --- Dear Mowafag, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141923] My expenses1.ods file will not open and I keep getting the Read Format error in my summary.
https://bugs.documentfoundation.org/show_bug.cgi?id=141923 --- Comment #5 from QA Administrators --- Dear Suzanne, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 128029] Writer: cannot paste RTF more than once if content copied from Internet Explorer (per Comment 2) - other formats paste
https://bugs.documentfoundation.org/show_bug.cgi?id=128029 --- Comment #14 from QA Administrators --- Dear hasmid, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 127466] Allow style-dependent hyphenation
https://bugs.documentfoundation.org/show_bug.cgi?id=127466 --- Comment #8 from QA Administrators --- Dear Ulrich Windl, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104142] Hard to pick a line with an image in its background because of "grab hand" cursor
https://bugs.documentfoundation.org/show_bug.cgi?id=104142 --- Comment #14 from QA Administrators --- Dear s.p.helma, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138475] Default Asian font-size in Calc Heading styles are not the same as Western fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=138475 Kevin Suo changed: What|Removed |Added CC||jvsg1...@gmail.com --- Comment #9 from Kevin Suo --- Jaskaran Singh: I see you have worked on commit 2aea6d519ff7e487af0b2a39d78e00c0227799af. Would you please advice whether this bug is due to the missing handling of the asian and complex style attributes in Orcus? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138475] Default Asian font-size in Calc Heading styles are not the same as Western fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=138475 --- Comment #8 from Kevin Suo --- I guess this is due to orcus's handling of the styles: https://gitlab.com/orcus/orcus/-/blob/master/src/liborcus/odf_styles_context.cpp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145483] New: Options causes LibreOffice to stop responding
https://bugs.documentfoundation.org/show_bug.cgi?id=145483 Bug ID: 145483 Summary: Options causes LibreOffice to stop responding Product: LibreOffice Version: 7.2.2.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: p...@bwt.com.de Whenever I select Tools -> Options or press ALT + F12, the LibreOffice UI stops responding. The window can be resized but the contents are no longer re-drawn. Most odd is that this problem only occurs in my main profile. A fresh Linux account does not exhibit this problem. I've tried every safe mode option and removed ~/.config/libreoffice in the problem profile (the main one) to no avail. LibreOffice says nothing in the terminal before ceasing to respond. (Except for not being able to find a JRE, which I've already played with and didn't make a difference if one was present and found or not present.) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145482] New: LibreOffice Calc: enable partial column/row notation
https://bugs.documentfoundation.org/show_bug.cgi?id=145482 Bug ID: 145482 Summary: LibreOffice Calc: enable partial column/row notation Product: LibreOffice Version: 7.2.2.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jackyguo...@gmail.com Description: LibreOffice Calc already supports full column notation like this: E:E 12:12 Google Sheets and Excel also support partial columns and rows. Example: B2:B means every cell in column B at or below B2, E5:5 means every cell in row 5 at or to the right of E5. I'd like to see this added into LibreOffice. Steps to Reproduce: N/A Actual Results: N/A Expected Results: N/A Reproducible: Always User Profile Reset: No Additional Info: N/A -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138475] Default Asian font-size in Calc Heading styles are not the same as Western fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=138475 --- Comment #7 from Kevin Suo --- Adding those attributes in source and rebuild does not work either. Need some coding. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144793] EDITING: LO Base Absence of scrollbar in the SQL query modification window
https://bugs.documentfoundation.org/show_bug.cgi?id=144793 Aron Budea changed: What|Removed |Added CC||ba...@caesar.elte.hu, ||caol...@redhat.com Keywords|bibisectRequest |bibisected, bisected --- Comment #2 from Aron Budea --- Bibisected to the following commit using repo bibisect-linux-64-7.1. Adding CC: to Caolán McNamara. https://cgit.freedesktop.org/libreoffice/core/commit/?id=44f7674ffda49257dcc1709256dfc4676d12165c author Caolán McNamara 2020-08-18 12:02:45 +0100 committer Caolán McNamara 2020-08-19 10:11:30 +0200 weld OQueryTextView -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 60616] Chapter info doesn't support more than one appearance in an Alphabetical index entry and only the last chapter
https://bugs.documentfoundation.org/show_bug.cgi?id=60616 --- Comment #20 from Lee <92ma...@gmail.com> --- The bug is still present in version 7.2.2.2 It is still and issue that needs to be resolved. Latest example: The index entry "Backup" should reference pages 1-1 3-14, 4-6, 4-7 That index entry reads 1-1, 14, 6, 7 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108800] [META] Print related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=108800 Aron Budea changed: What|Removed |Added Depends on||145001 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=145001 [Bug 145001] Image shrinks and positioned differently when actually printing (OK in print Preview; OK with PDF export) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145001] Image shrinks and positioned differently when actually printing (OK in print Preview; OK with PDF export)
https://bugs.documentfoundation.org/show_bug.cgi?id=145001 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||2195 Keywords|bibisectRequest |bibisected, bisected Blocks||108800 CC||ba...@caesar.elte.hu, ||nem...@numbertext.org --- Comment #5 from Aron Budea --- Bibisected to the following commit using repo bibisect-win32-6.3. Adding CC: to László Németh. https://cgit.freedesktop.org/libreoffice/core/commit/?id=f006b6339e20af6a3fbd60d97d21590d4ebf5021 author László Németh2018-11-23 21:55:54 +0100 committer László Németh2018-11-27 14:44:59 +0100 tdf#112195 Writer: page background covers whole page Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108800 [Bug 108800] [META] Print related issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'feature/themesupport2' - chart2/source cui/source dbaccess/source editeng/source extensions/source filter/source include/editeng include/sfx2 include/svx report
chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx | 18 +-- cui/source/dialogs/SpellDialog.cxx |2 cui/source/tabpages/backgrnd.cxx |8 - cui/source/tabpages/chardlg.cxx |2 dbaccess/source/ui/control/sqledit.cxx |4 editeng/source/editeng/editeng.cxx |4 editeng/source/items/textitem.cxx| 61 +++ editeng/source/rtf/rtfitem.cxx |5 extensions/source/propctrlr/fontdialog.cxx |2 filter/source/msfilter/svdfppt.cxx |6 - include/editeng/colritem.hxx | 15 +- include/editeng/editeng.hxx |3 include/sfx2/ColorSets.hxx | 14 +- include/svx/svx3ditems.hxx | 44 +++ reportdesign/source/ui/misc/UITools.cxx |2 sc/qa/unit/subsequent_export-test.cxx|4 sc/source/filter/excel/xistyle.cxx |2 sc/source/filter/html/htmlpars.cxx |2 sc/source/filter/oox/stylesbuffer.cxx|2 sc/source/filter/orcus/interface.cxx |2 sc/source/ui/app/inputhdl.cxx|4 sc/source/ui/view/editsh.cxx |2 sc/source/ui/view/formatsh.cxx |8 - sc/source/ui/view/output2.cxx|2 sc/source/ui/view/tabvwshf.cxx |2 sd/qa/unit/dialogs-test.cxx |2 sd/source/core/drawdoc4.cxx | 20 +-- sd/source/core/stlpool.cxx | 16 +- sd/source/ui/func/fuchar.cxx |2 sd/source/ui/func/fuoaprms.cxx |4 sd/source/ui/func/futempl.cxx|2 sd/source/ui/view/drtxtob1.cxx |4 sfx2/source/styles/ColorSets.cxx | 13 ++ svx/source/customshapes/EnhancedCustomShape3d.cxx| 10 - svx/source/engine3d/float3d.cxx | 38 +++--- svx/source/svdraw/svdfmtf.cxx|2 svx/source/svdraw/svdpdf.cxx |3 svx/source/toolbars/extrusionbar.cxx |2 sw/source/core/doc/DocumentStylePoolManager.cxx |6 - sw/source/core/table/swtable.cxx |2 sw/source/filter/html/htmldrawreader.cxx |2 sw/source/filter/html/htmlforw.cxx |2 sw/source/filter/html/svxcss1.cxx|2 sw/source/filter/html/swhtml.cxx |2 sw/source/uibase/app/docshini.cxx|2 sw/source/uibase/app/swmodul1.cxx|2 sw/source/uibase/shells/basesh.cxx |2 sw/source/uibase/shells/drwtxtex.cxx |4 sw/source/uibase/shells/frmsh.cxx|2 sw/source/uibase/shells/tabsh.cxx|2 sw/source/uibase/shells/textsh1.cxx |4 51 files changed, 184 insertions(+), 188 deletions(-) New commits: commit 7adc1fa124a334578657466e32dbbbaad3439350 Author: Sarper Akdemir AuthorDate: Mon Nov 1 01:23:31 2021 +0300 Commit: Sarper Akdemir CommitDate: Mon Nov 1 03:25:47 2021 +0300 WIP: refactor SfxObjectShell out of SvxColorItem Change-Id: Ib6be30a543b3ecac117260e7b0d4a4a5cb3e2411 diff --git a/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx b/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx index c4b28162d08c..c9bda82dda39 100644 --- a/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx +++ b/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx @@ -470,44 +470,44 @@ void ThreeD_SceneIllumination_TabPage::updatePreview() LightSourceInfo* pInfo = _pLightSourceInfoList[0]; // AmbientColor - aItemSet.Put(makeSvx3DAmbientcolorItem(m_xLB_AmbientLight->GetSelectEntryColor())); + aItemSet.Put(makeSvx3DAmbientcolorItem(m_xLB_AmbientLight->GetSelectEntryColor(), aItemSet)); -aItemSet.Put(makeSvx3DLightcolor1Item(pInfo->aLightSource.nDiffuseColor)); +aItemSet.Put(makeSvx3DLightcolor1Item(pInfo->aLightSource.nDiffuseColor, aItemSet)); aItemSet.Put(makeSvx3DLightOnOff1Item(pInfo->aLightSource.bIsEnabled));
[Libreoffice-bugs] [Bug 145314] mouse click doesn't change properties
https://bugs.documentfoundation.org/show_bug.cgi?id=145314 --- Comment #1 from krumple_sodium --- I tried it with Impress 7.2.2.2 and I am able to change the outline color of the rectangle. Looks like this bug is fixed. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 144978] Decimal point - Should not be dependent of language
https://bugs.documentfoundation.org/show_bug.cgi?id=144978 --- Comment #15 from S.Zosgornik --- (In reply to Mike Kaganski from comment #13) > When a UK citizen wants to "write an offering" (whatever that might mean) > for someone who uses a different locale, they would need two *different* > things to happen: > > 1. The author's input be correctly *interpreted* as number; > 2. The number be *displayed* using correct locale's settings. > > These two things are totally separate. The OP and me both speak about input and the very same thing. What is your problem? Don't you understand English or are you just a troll? -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 144978] Decimal point - Should not be dependent of language
https://bugs.documentfoundation.org/show_bug.cgi?id=144978 --- Comment #15 from S.Zosgornik --- (In reply to Mike Kaganski from comment #13) > When a UK citizen wants to "write an offering" (whatever that might mean) > for someone who uses a different locale, they would need two *different* > things to happen: > > 1. The author's input be correctly *interpreted* as number; > 2. The number be *displayed* using correct locale's settings. > > These two things are totally separate. The OP and me both speak about input and the very same thing. What is your problem? Don't you understand English or are you just a troll? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145281] [COLLABORA ONLINE] Error in writing sub-document content.xml
https://bugs.documentfoundation.org/show_bug.cgi?id=145281 Jan Bebendorf changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #1 from Jan Bebendorf --- Collabora seems to build their docker images with a pretty old version of LibreOffice (6.4). Switching to manual builds with the up 2 date version of LibreOffice solved this issue. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145481] New: To set font size of a character style in percentage relative to current paragraph style
https://bugs.documentfoundation.org/show_bug.cgi?id=145481 Bug ID: 145481 Summary: To set font size of a character style in percentage relative to current paragraph style Product: LibreOffice Version: 7.1.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: johnsmithbeat...@gmail.com Description: I have a document where the first paragraph is styled with the paragraph style Foo (font size is 12 pt) and the second paragraph is styled with the paragraph style Bar (font size is 10 pt). I also have the Xyz character style, in which the font size is set to 80%. When I apply the Xyz to the first word in the first paragraph, the font size of the word is changed to 9.6. ``` 12 * 80% = 9.6 fine ``` But when I apply it the first word in the second paragraph, the font size is changed to 9.6, while I expect 8. ``` 10 * 80% = 8 ``` Actual Results: - Expected Results: - Reproducible: Always User Profile Reset: No Additional Info: - -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144772] Basic Macro oEvent.Source execution in a form, started in a Text [VARCHAR] field
https://bugs.documentfoundation.org/show_bug.cgi?id=144772 Aron Budea changed: What|Removed |Added Keywords|bibisectRequest |bibisected, bisected Resolution|--- |DUPLICATE CC||ba...@caesar.elte.hu Status|NEW |RESOLVED Hardware|x86-64 (AMD64) |All --- Comment #5 from Aron Budea --- Reverse-bibisected the fixing commit, determining it to be a dupe of bug 142415. *** This bug has been marked as a duplicate of bug 142415 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145480] New: Find & Replace -> Footnotes/Endnotes
https://bugs.documentfoundation.org/show_bug.cgi?id=145480 Bug ID: 145480 Summary: Find & Replace -> Footnotes/Endnotes Product: LibreOffice Version: 7.1.6.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: aineoreg...@gmail.com There is no Feature that can find a list of numbers (eg: [1],[2],[3]...) and replace them with a footnote or Endnotes anchor. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145279] ByRef argument modified in called Sub is returned incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=145279 Andreas Heinisch changed: What|Removed |Added Assignee|andreas.heini...@yahoo.de |libreoffice-b...@lists.free ||desktop.org Status|ASSIGNED|NEW --- Comment #7 from Andreas Heinisch --- Investigated the error and imho it is not trivial, because every parameter is considered by reference if not explicitly set. Then the runtime decides if the parameter will be handled either by value or by reference. For instance, if a parameter is not fixed and not of type variant the parameter will be by value. I tried to remove the fixed part, but it breaks some tests. Maybe someone else finds a solution to this problem. The test can be taken from the proposed patch. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: i18npool/source
i18npool/source/registerservices/registerservices.cxx | 32 ++ 1 file changed, 32 insertions(+) New commits: commit b8d17d754830ab57099dcdfa72a96bfad404ab1a Author: Jan-Marek Glogowski AuthorDate: Thu Oct 28 12:48:19 2021 +0200 Commit: Jan-Marek Glogowski CommitDate: Sun Oct 31 22:36:29 2021 +0100 Prevent many -Wunused-function in i18npool service ... registration. Change-Id: Ice406aa6e8817b4281cc3905d2ba2703ce482c18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124440 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski diff --git a/i18npool/source/registerservices/registerservices.cxx b/i18npool/source/registerservices/registerservices.cxx index 878fc3c3de50..f382caadd038 100644 --- a/i18npool/source/registerservices/registerservices.cxx +++ b/i18npool/source/registerservices/registerservices.cxx @@ -157,11 +157,14 @@ IMPL_CREATEINSTANCE( Transliteration_l2u ) IMPL_CREATEINSTANCE( Transliteration_sentencecase ) IMPL_CREATEINSTANCE( Transliteration_titlecase ) IMPL_CREATEINSTANCE( Transliteration_togglecase ) +#if WITH_LOCALE_ALL || WITH_LOCALE_ja IMPL_CREATEINSTANCE( hiraganaToKatakana ) IMPL_CREATEINSTANCE( katakanaToHiragana ) IMPL_CREATEINSTANCE( fullwidthToHalfwidth ) IMPL_CREATEINSTANCE( halfwidthToFullwidth ) +#endif +#if WITH_LOCALE_ALL || WITH_LOCALE_ja IMPL_CREATEINSTANCE( smallToLarge_ja_JP) IMPL_CREATEINSTANCE( largeToSmall_ja_JP) IMPL_CREATEINSTANCE( ignoreTraditionalKanji_ja_JP) @@ -180,27 +183,40 @@ IMPL_CREATEINSTANCE( ignoreSize_ja_JP) IMPL_CREATEINSTANCE( ignoreProlongedSoundMark_ja_JP) IMPL_CREATEINSTANCE( ignoreMiddleDot_ja_JP) IMPL_CREATEINSTANCE( ignoreSpace_ja_JP) +#endif IMPL_CREATEINSTANCE( ignoreDiacritics_CTL) IMPL_CREATEINSTANCE( ignoreKashida_CTL) +#if WITH_LOCALE_ALL || WITH_LOCALE_zh IMPL_CREATEINSTANCE( TextToChuyin_zh_TW ) IMPL_CREATEINSTANCE( TextToPinyin_zh_CN ) +#endif +#if WITH_LOCALE_ALL || WITH_LOCALE_zh IMPL_CREATEINSTANCE( NumToCharLower_zh_CN ) IMPL_CREATEINSTANCE( NumToCharUpper_zh_CN ) IMPL_CREATEINSTANCE( NumToCharLower_zh_TW ) IMPL_CREATEINSTANCE( NumToCharUpper_zh_TW ) +#endif +#if WITH_LOCALE_ALL || WITH_LOCALE_ja IMPL_CREATEINSTANCE( NumToCharHalfwidth ) IMPL_CREATEINSTANCE( NumToCharFullwidth ) IMPL_CREATEINSTANCE( NumToCharKanjiShort_ja_JP ) IMPL_CREATEINSTANCE( NumToCharKanjiTraditional_ja_JP ) +#endif +#if WITH_LOCALE_ALL || WITH_LOCALE_ko IMPL_CREATEINSTANCE( NumToCharHangul_ko ) IMPL_CREATEINSTANCE( NumToCharLower_ko ) IMPL_CREATEINSTANCE( NumToCharUpper_ko ) +#endif IMPL_CREATEINSTANCE( NumToCharIndic_ar ) IMPL_UNO_CONSTRUCTOR( NumToCharEastIndic_ar ) +#if WITH_LOCALE_ALL || WITH_LOCALE_hi IMPL_CREATEINSTANCE( NumToCharIndic_hi ) +#endif +#if WITH_LOCALE_ALL || WITH_LOCALE_th IMPL_CREATEINSTANCE( NumToChar_th ) +#endif #if WITH_LOCALE_ALL || WITH_LOCALE_zh IMPL_UNO_CONSTRUCTOR (CharToNumUpper_zh_CN) @@ -235,12 +251,18 @@ IMPL_UNO_CONSTRUCTOR( NumToTextUpper_zh_TW ) IMPL_UNO_CONSTRUCTOR( NumToTextFullwidth_zh_CN ) IMPL_UNO_CONSTRUCTOR( NumToTextFullwidth_zh_TW ) #endif +#if WITH_LOCALE_ALL || WITH_LOCALE_ja IMPL_CREATEINSTANCE( NumToTextFullwidth_ja_JP ) +#endif +#if WITH_LOCALE_ALL || WITH_LOCALE_ko IMPL_CREATEINSTANCE( NumToTextFullwidth_ko ) +#endif +#if WITH_LOCALE_ALL || WITH_LOCALE_ja IMPL_CREATEINSTANCE( NumToTextKanjiLongModern_ja_JP ) IMPL_CREATEINSTANCE( NumToTextKanjiLongTraditional_ja_JP ) IMPL_CREATEINSTANCE( NumToTextKanjiShortModern_ja_JP ) IMPL_CREATEINSTANCE( NumToTextKanjiShortTraditional_ja_JP ) +#endif #if WITH_LOCALE_ALL || WITH_LOCALE_ko IMPL_UNO_CONSTRUCTOR (NumToTextInformalHangul_ko) IMPL_UNO_CONSTRUCTOR (NumToTextInformalLower_ko) @@ -250,20 +272,28 @@ IMPL_UNO_CONSTRUCTOR (NumToTextFormalLower_ko) IMPL_UNO_CONSTRUCTOR (NumToTextFormalUpper_ko) #endif +#if WITH_LOCALE_ALL || WITH_LOCALE_zh IMPL_CREATEINSTANCE( TextToNumLower_zh_CN ) IMPL_CREATEINSTANCE( TextToNumUpper_zh_CN ) IMPL_CREATEINSTANCE( TextToNumLower_zh_TW ) IMPL_CREATEINSTANCE( TextToNumUpper_zh_TW ) +#endif +#if WITH_LOCALE_ALL || WITH_LOCALE_ja IMPL_CREATEINSTANCE( TextToNumKanjiLongModern_ja_JP ) IMPL_CREATEINSTANCE( TextToNumKanjiLongTraditional_ja_JP ) +#endif +#if WITH_LOCALE_ALL || WITH_LOCALE_ko IMPL_CREATEINSTANCE( TextToNumFormalHangul_ko ) IMPL_CREATEINSTANCE( TextToNumFormalLower_ko ) IMPL_CREATEINSTANCE( TextToNumFormalUpper_ko ) IMPL_CREATEINSTANCE( TextToNumInformalHangul_ko ) IMPL_CREATEINSTANCE( TextToNumInformalUpper_ko ) IMPL_CREATEINSTANCE( TextToNumInformalLower_ko ) +#endif +#if WITH_LOCALE_ALL || WITH_LOCALE_zh IMPL_CREATEINSTANCE( NumToTextDate_zh ) +#endif #if WITH_LOCALE_ALL || WITH_LOCALE_ja IMPL_UNO_CONSTRUCTOR (NumToTextAIUFullWidth_ja_JP) IMPL_UNO_CONSTRUCTOR (NumToTextAIUHalfWidth_ja_JP) @@ -277,8 +307,10 @@ IMPL_UNO_CONSTRUCTOR (NumToTextHangulSyllable_ko) IMPL_UNO_CONSTRUCTOR (NumToTextHangulCircledJamo_ko) IMPL_UNO_CONSTRUCTOR (NumToTextHangulCircledSyllable_ko) #endif +#if
[Libreoffice-bugs] [Bug 145369] lines and spaces occasionally inserted -- (doesn't happen in Writer 7)
https://bugs.documentfoundation.org/show_bug.cgi?id=145369 --- Comment #6 from peter josvai --- (In reply to Michael Warner from comment #5) > Happy to help, have a nice day :-) thank you!! :) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145391] Segfault importing Basic macros
https://bugs.documentfoundation.org/show_bug.cgi?id=145391 Caolán McNamara changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: configure.ac
configure.ac |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) New commits: commit c0c937d1ff2a47c55b597e10c0f0055e5bfda7e0 Author: Jan-Marek Glogowski AuthorDate: Thu Oct 28 11:56:16 2021 +0200 Commit: Jan-Marek Glogowski CommitDate: Sun Oct 31 22:05:16 2021 +0100 Echo cross-toolset configure options ... just like autogen.sh does. Change-Id: I30ee6b4043c138d7c1e8de154b33fbc7528c34dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124439 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski diff --git a/configure.ac b/configure.ac index f2062daf62ac..cecc4993641f 100644 --- a/configure.ac +++ b/configure.ac @@ -5507,10 +5507,9 @@ if test "$cross_compiling" = "yes"; then test -n "$with_help" -a "$with_help" != "no" && sub_conf_opts="$sub_conf_opts --with-help=$with_help" test "$enable_extensions" = yes || sub_conf_opts="$sub_conf_opts --disable-extensions" test "$enable_wasm_strip" = "yes" && sub_conf_opts="$sub_conf_opts --enable-wasm-strip" -sub_conf_opts="$sub_conf_opts $with_build_platform_configure_options" # Don't bother having configure look for stuff not needed for the build platform anyway -./configure \ +sub_conf_defaults=" \ --build="$build_alias" \ --disable-cairo-canvas \ --disable-cups \ @@ -5532,7 +5531,12 @@ if test "$cross_compiling" = "yes"; then --with-parallelism="$with_parallelism" \ --with-theme="$with_theme" \ --with-tls=openssl \ +" +echo "Running CONF-FOR-BUILD/configure" $sub_conf_defaults $sub_conf_opts $with_build_platform_configure_options --srcdir=$srcdir +./configure \ +$sub_conf_defaults \ $sub_conf_opts \ +$with_build_platform_configure_options \ --srcdir=$srcdir \ 2>&1 | sed -e 's/^//' if test [${PIPESTATUS[0]}] -ne 0; then
[Libreoffice-bugs] [Bug 145464] Crash when opening Digital signatures dialog from infobar (GTK3)
https://bugs.documentfoundation.org/show_bug.cgi?id=145464 Caolán McNamara changed: What|Removed |Added Ever confirmed|0 |1 Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | Status|UNCONFIRMED |ASSIGNED --- Comment #2 from Caolán McNamara --- I think this is a focus thing. For me to reproduce reliably, load the first document, press alt to active visible focus. Click the "show signatures" and then "close". The focus is visible in the "show signatures" button. Now load the other document. Then switch back to the first document and the "show signatures" button has visible focus. Click it and crash with null dispatcher. I think the dispatcher is assigned when focus is given to the frame, but because focus is restored to the button the frame doesn't know it was given focus so the dispatcher remains null and then we get that crash -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 101631] VBA function parameter is passed by reference by default
https://bugs.documentfoundation.org/show_bug.cgi?id=101631 Andreas Heinisch changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||5279 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131683] Missing elements for fast parsing when loading file from tdf#126715
https://bugs.documentfoundation.org/show_bug.cgi?id=131683 Julien Nabet changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #2 from Julien Nabet --- On pc Debian x86-64 with master sources updated today, I don't reproduce this anymore. Let's close this one then. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145479] New: Please State the Full Version Number at the Download Web Page
https://bugs.documentfoundation.org/show_bug.cgi?id=145479 Bug ID: 145479 Summary: Please State the Full Version Number at the Download Web Page Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Installation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: babelfish0...@hotmail.com I refer to this download page: https://www.libreoffice.org/download/download/ On that page the current 'fresh' version of LibreOffice that is offered for download is 7.2.2 On that page the current 'still' version of LibreOffice that is offered for download is 7.1.6 However, if I download 7.2.2 what I actually get is 7.2.2.2 -- but I can't know that until such times as I initiate an install of LibreOffice. If I download 7.1.6 what I actually get is 7.1.6.2 -- but I can't know that until such times as I initiate an install of LibreOffice. I think the full version number of a download should be shown clearly and unambiguously at the download page. Doing so shows respect for your users. I have tried to think of one single positive reason for not showing a full version number at the download page and I can't come up with one. Why the mystery? Does it serve a single useful purpose for users? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: unoxml/qa unoxml/source
unoxml/qa/unit/domtest.cxx | 15 --- unoxml/source/rdf/librdf_repository.cxx |6 -- 2 files changed, 12 insertions(+), 9 deletions(-) New commits: commit 359a17d0215d36a441688ac3261af04f20a03c6c Author: Mike Kaganski AuthorDate: Fri Oct 29 10:22:53 2021 +0300 Commit: Mike Kaganski CommitDate: Sun Oct 31 21:36:50 2021 +0100 Prepare for removal of non-const operator[] from Sequence in unoxml Change-Id: Ie7738eb599ac2ae98618e258786b2a0d956cb9dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124408 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/unoxml/qa/unit/domtest.cxx b/unoxml/qa/unit/domtest.cxx index c6501547183c..3a715a9ed314 100644 --- a/unoxml/qa/unit/domtest.cxx +++ b/unoxml/qa/unit/domtest.cxx @@ -293,13 +293,14 @@ struct SerializerTest : public test::BootstrapFixture mxHandler.set( new DocumentHandler ); mxTokHandler.set( new TokenHandler ); -maRegisteredNamespaces.realloc(2); -maRegisteredNamespaces[0] = beans::make_Pair( -OUString( "urn:oasis:names:tc:opendocument:xmlns:office:1.0" ), -xml::sax::FastToken::NAMESPACE); -maRegisteredNamespaces[1] = beans::make_Pair( -OUString( "http://www.w3.org/1999/xlink; ), -2*xml::sax::FastToken::NAMESPACE); +maRegisteredNamespaces = { +beans::make_Pair( +OUString( "urn:oasis:names:tc:opendocument:xmlns:office:1.0" ), +xml::sax::FastToken::NAMESPACE), +beans::make_Pair( +OUString( "http://www.w3.org/1999/xlink; ), +2*xml::sax::FastToken::NAMESPACE) +}; } void serializerTest () diff --git a/unoxml/source/rdf/librdf_repository.cxx b/unoxml/source/rdf/librdf_repository.cxx index f9e918aff168..176a871fa872 100644 --- a/unoxml/source/rdf/librdf_repository.cxx +++ b/unoxml/source/rdf/librdf_repository.cxx @@ -670,8 +670,9 @@ librdf_QuerySelectResult::nextElement() uno::makeAny(e)); } uno::Sequence< uno::Reference< rdf::XNode > > ret(count); +auto retRange = asNonConstRange(ret); for (int i = 0; i < count; ++i) { -ret[i] = m_xRep->getTypeConverter().convertToXNode(aNodes[i]); +retRange[i] = m_xRep->getTypeConverter().convertToXNode(aNodes[i]); } // NB: this will invalidate current item. librdf_query_results_next(m_pQueryResult.get()); @@ -1403,6 +1404,7 @@ librdf_Repository::querySelect(const OUString & i_rQuery) "librdf_query_results_get_bindings_count failed", *this); } uno::Sequence< OUString > names(count); +auto namesRange = asNonConstRange(names); for (int i = 0; i < count; ++i) { const char* name( librdf_query_results_get_binding_name( pResults.get(), i) ); @@ -1411,7 +1413,7 @@ librdf_Repository::querySelect(const OUString & i_rQuery) "librdf_Repository::querySelect: binding is null", *this); } -names[i] = OUString::createFromAscii(name); +namesRange[i] = OUString::createFromAscii(name); } return new librdf_QuerySelectResult(this, m_aMutex,
[Libreoffice-commits] core.git: uui/source
uui/source/iahndl-authentication.cxx |5 +++-- uui/source/iahndl-ssl.cxx|6 +++--- 2 files changed, 6 insertions(+), 5 deletions(-) New commits: commit db149ba9801f57c2e737dec893965f880fa04700 Author: Mike Kaganski AuthorDate: Fri Oct 29 10:23:35 2021 +0300 Commit: Mike Kaganski CommitDate: Sun Oct 31 21:32:36 2021 +0100 Prepare for removal of non-const operator[] from Sequence in uui Change-Id: I3b4ddb7c371c5a01c561e4b45f3c181b5d9e2a11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124409 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/uui/source/iahndl-authentication.cxx b/uui/source/iahndl-authentication.cxx index ad975d3f9ae7..4ec2f734be6b 100644 --- a/uui/source/iahndl-authentication.cxx +++ b/uui/source/iahndl-authentication.cxx @@ -344,9 +344,10 @@ handleAuthenticationRequest_( { uno::Sequence< OUString > aPassList(aInfo.GetAccount().isEmpty() ? 1 : 2); - aPassList[0] = aInfo.GetPassword(); + auto pPassList = aPassList.getArray(); + pPassList[0] = aInfo.GetPassword(); if (!aInfo.GetAccount().isEmpty()) - aPassList[1] = aInfo.GetAccount(); + pPassList[1] = aInfo.GetAccount(); if (aInfo.GetIsRememberPassword()) { diff --git a/uui/source/iahndl-ssl.cxx b/uui/source/iahndl-ssl.cxx index bf4e8811f949..fa1b2a6a16e4 100644 --- a/uui/source/iahndl-ssl.cxx +++ b/uui/source/iahndl-ssl.cxx @@ -274,14 +274,14 @@ handleCertificateValidationRequest_( OUString certHostName = getContentPart( rRequest.Certificate->getSubjectName() ); uno::Sequence< OUString > certHostNames(altNames.size() + 1); - -certHostNames[0] = certHostName; +auto pcertHostNames = certHostNames.getArray(); +pcertHostNames[0] = certHostName; for (size_t n = 0; n < altNames.size(); ++n) { if (altNames[n].Type == security::ExtAltNameType_DNS_NAME) { - altNames[n].Value >>= certHostNames[n+1]; + altNames[n].Value >>= pcertHostNames[n+1]; } }
[Libreoffice-commits] core.git: ucbhelper/source
ucbhelper/source/client/proxydecider.cxx |4 - ucbhelper/source/provider/authenticationfallback.cxx |7 --- ucbhelper/source/provider/cancelcommandexecution.cxx |7 --- ucbhelper/source/provider/simpleauthenticationrequest.cxx| 21 +++--- ucbhelper/source/provider/simplecertificatevalidationrequest.cxx |7 --- ucbhelper/source/provider/simpleioerrorrequest.cxx |6 -- ucbhelper/source/provider/simplenameclashresolverequest.cxx |9 7 files changed, 14 insertions(+), 47 deletions(-) New commits: commit 51b75b2eae36272289230bd63b546d527c18df19 Author: Mike Kaganski AuthorDate: Fri Oct 29 10:21:30 2021 +0300 Commit: Mike Kaganski CommitDate: Sun Oct 31 21:28:26 2021 +0100 Prepare for removal of non-const operator[] from Sequence in ucbhelper Change-Id: I06b04e3eed46aba8aac528b2c394d60e733533a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124405 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/ucbhelper/source/client/proxydecider.cxx b/ucbhelper/source/client/proxydecider.cxx index 7a363a0962f7..211711b556d1 100644 --- a/ucbhelper/source/client/proxydecider.cxx +++ b/ucbhelper/source/client/proxydecider.cxx @@ -301,9 +301,7 @@ InternetProxyDecider_Impl::InternetProxyDecider_Impl( uno::Reference< lang::XMultiServiceFactory > xConfigProv = configuration::theDefaultProvider::get( rxContext ); -uno::Sequence< uno::Any > aArguments( 1 ); -aArguments[ 0 ] <<= OUString( CONFIG_ROOT_KEY ); - +uno::Sequence< uno::Any > aArguments{ uno::Any(OUString( CONFIG_ROOT_KEY )) }; uno::Reference< uno::XInterface > xInterface( xConfigProv->createInstanceWithArguments( "com.sun.star.configuration.ConfigurationAccess", diff --git a/ucbhelper/source/provider/authenticationfallback.cxx b/ucbhelper/source/provider/authenticationfallback.cxx index eee4b04b39e7..70fd0ecbf6b5 100644 --- a/ucbhelper/source/provider/authenticationfallback.cxx +++ b/ucbhelper/source/provider/authenticationfallback.cxx @@ -25,12 +25,7 @@ AuthenticationFallbackRequest::AuthenticationFallbackRequest( setRequest( uno::makeAny( aRequest ) ); m_xAuthFallback = new InteractionAuthFallback( this ); -uno::Sequence< -uno::Reference< task::XInteractionContinuation > > aContinuations( 2 ); -aContinuations[ 0 ] = new InteractionAbort( this ); -aContinuations[ 1 ] = m_xAuthFallback.get( ); - -setContinuations( aContinuations ); +setContinuations({ new InteractionAbort(this), m_xAuthFallback }); } /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/ucbhelper/source/provider/cancelcommandexecution.cxx b/ucbhelper/source/provider/cancelcommandexecution.cxx index 8aac85c240aa..89245ca78492 100644 --- a/ucbhelper/source/provider/cancelcommandexecution.cxx +++ b/ucbhelper/source/provider/cancelcommandexecution.cxx @@ -51,12 +51,7 @@ void cancelCommandExecution( const uno::Any & rException, rtl::Reference< ucbhelper::InteractionRequest > xRequest = new ucbhelper::InteractionRequest( rException ); -uno::Sequence< uno::Reference< task::XInteractionContinuation > > -aContinuations( 1 ); -aContinuations[ 0 ] -= new ucbhelper::InteractionAbort( xRequest.get() ); - -xRequest->setContinuations( aContinuations ); +xRequest->setContinuations({ new ucbhelper::InteractionAbort(xRequest.get()) }); xIH->handle( xRequest ); diff --git a/ucbhelper/source/provider/simpleauthenticationrequest.cxx b/ucbhelper/source/provider/simpleauthenticationrequest.cxx index 96608c784c9b..c6eee708bbd3 100644 --- a/ucbhelper/source/provider/simpleauthenticationrequest.cxx +++ b/ucbhelper/source/provider/simpleauthenticationrequest.cxx @@ -112,21 +112,19 @@ void SimpleAuthenticationRequest::initialize( setRequest( uno::makeAny( rRequest ) ); // Fill continuations... -unsigned int nSize = 1; -unsigned int nPos = 0; +unsigned int nSize = 2; if( bAllowSessionStoring ) nSize++; -nSize++; - uno::Sequence< ucb::RememberAuthentication > aRememberModes( nSize ); -aRememberModes[ nPos++ ] = ucb::RememberAuthentication_NO; +auto it = aRememberModes.getArray(); +*it++ = ucb::RememberAuthentication_NO; if( bAllowSessionStoring ) -aRememberModes[ nPos++ ] = ucb::RememberAuthentication_SESSION; +*it++ = ucb::RememberAuthentication_SESSION; -aRememberModes[ nPos++ ] = ucb::RememberAuthentication_PERSISTENT; +*it = ucb::RememberAuthentication_PERSISTENT; m_xAuthSupplier = new InteractionSupplyAuthentication( @@ -142,13 +140,8 @@ void SimpleAuthenticationRequest::initialize( bAllowUseSystemCredentials // bCanUseSystemCredentials,
[Libreoffice-bugs] [Bug 145478] New: Libreoffice 7.2.2.2_1, FreeBSD 13.0, from ports, fails to start on dual-head host with XINERAMA missing
https://bugs.documentfoundation.org/show_bug.cgi?id=145478 Bug ID: 145478 Summary: Libreoffice 7.2.2.2_1, FreeBSD 13.0, from ports, fails to start on dual-head host with XINERAMA missing Product: LibreOffice Version: 7.2.2.2 release Hardware: x86-64 (AMD64) OS: FreeBSD Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: libreoff...@opsec.eu Description: If libreoffice is started on a dual-head box, this fails with: Xlib: extension "XINERAMA" missing on display ":0". LibreOffice 7.2 - Fatal Error: The application cannot be started. User installation could not be completed. Steps to Reproduce: 1. startx which opens, among other things, some xterm 2. libreoffice Actual Results: see above Expected Results: libreoffice should start Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: >From glxinfo: OpenGL vendor string: X.Org OpenGL renderer string: AMD CEDAR (DRM 2.50.0 / 13.0-RELEASE-p4, LLVM 12.0.1) OpenGL core profile version string: 3.3 (Core Profile) Mesa 21.1.8 from xrandr: Screen 0: minimum 320 x 200, current 3200 x 1200, maximum 8192 x 8192 HDMI-1 connected primary 1600x1200+0+0 (normal left inverted right x axis y axis) 367mm x 275mm [...] DVI-D-1 connected 1600x1200+1600+0 (normal left inverted right x axis y axis) 367mm x 275mm -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 67521] FILESAVE: Invalid svg file exported by LO Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=67521 --- Comment #9 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/82047d042e9d5d24b334eba63fd7e4c5022e crashtesting: assert on conversion of fdo67521-1.odg to pdf It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 67521] FILESAVE: Invalid svg file exported by LO Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=67521 Commit Notification changed: What|Removed |Added Whiteboard||target:7.3.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: chart2/source
chart2/source/tools/InternalData.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit 82047d042e9d5d24b334eba63fd7e4c5022e Author: Caolán McNamara AuthorDate: Sun Oct 31 15:10:28 2021 + Commit: Caolán McNamara CommitDate: Sun Oct 31 21:07:55 2021 +0100 crashtesting: assert on conversion of fdo67521-1.odg to pdf #4 0x7fffcb03c5d9 in std::__replacement_assert(char const*, int, char const*, char const*) (__file=0x7fffcb4fbb03 "/usr/bin/../lib/gcc/x86_64-redhat-linux/11/../../../../include/c++/11/valarray", __line=586, __function=0x7fffcb4fbd8c "const _Tp ::valarray::operator[](std::size_t) const [_Tp = double]", __condition=0x7fffcb4fbb95 "__i < this->size()") at /usr/bin/../lib/gcc/x86_64-redhat-linux/11/../../../../include/c++/11/x86_64-redhat-linux/bits/c++config.h:2660 #5 0x7fffcb3b4b54 in std::valarray::operator[](unsigned long) const (this=0x7ffefea8, __i=0) at /usr/bin/../lib/gcc/x86_64-redhat-linux/11/../../../../include/c++/11/valarray:586 #6 0x7fffcb3b4a79 in std::begin(std::valarray const&) (__va=...) at /usr/bin/../lib/gcc/x86_64-redhat-linux/11/../../../../include/c++/11/valarray:1225 #7 0x7fffcb3b49ac in comphelper::containerToSequence >(std::valarray const&) (i_Container=...) at include/comphelper/sequence.hxx:192 #8 0x7fffcb3b4963 in comphelper::containerToSequence >(std::valarray const&) (i_Container=...) at include/comphelper/sequence.hxx:200 #9 0x7fffcb3aaa83 in chart::(anonymous namespace)::lcl_ValarrayToSequence(std::valarray const&) (rValarray=...) at chart2/source/tools/InternalData.cxx:72 where begin() is implemented with return std::__addressof(__va[0]) and that operator[] (for arg __i) then has __glibcxx_requires_subscript(__i) which asserts if there is no index __i which is the case for 0 when the valarray is empty Change-Id: Idc2c185cbfb3806764c3071ecee302dc823b4660 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124529 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/chart2/source/tools/InternalData.cxx b/chart2/source/tools/InternalData.cxx index 3249231a6fec..2cd8d309d6cd 100644 --- a/chart2/source/tools/InternalData.cxx +++ b/chart2/source/tools/InternalData.cxx @@ -69,6 +69,9 @@ private: template< typename T > Sequence< T > lcl_ValarrayToSequence( const std::valarray< T > & rValarray ) { +if (!size(rValarray)) +return Sequence(); + return comphelper::containerToSequence(rValarray); }
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/dialog/filedlghelper.cxx | 35 ++- sfx2/source/dialog/filedlgimpl.hxx |3 ++- 2 files changed, 24 insertions(+), 14 deletions(-) New commits: commit c08d8be8f96a69c5ca3d768789d7c0aa594619c0 Author: Jan-Marek Glogowski AuthorDate: Sun Oct 31 11:59:12 2021 +0100 Commit: Jan-Marek Glogowski CommitDate: Sun Oct 31 21:06:51 2021 +0100 Support system async file pickers Query XAsynchronousExecutableDialog and don't depend on the "com.sun.star.ui.dialogs.SystemFilePicker" service for the decision. Change-Id: I199ab55a40afaeca7870513829105e47d258420d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124511 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski diff --git a/sfx2/source/dialog/filedlghelper.cxx b/sfx2/source/dialog/filedlghelper.cxx index 23c2b097a23c..918b9c1869b7 100644 --- a/sfx2/source/dialog/filedlghelper.cxx +++ b/sfx2/source/dialog/filedlghelper.cxx @@ -807,6 +807,19 @@ static bool lcl_isSystemFilePicker( const uno::Reference< XExecutableDialog >& _ namespace { +bool lcl_isAsyncFilePicker( const uno::Reference< XExecutableDialog >& _rxFP ) +{ +try +{ +uno::Reference xSI(_rxFP, UNO_QUERY); +return xSI.is(); +} +catch( const Exception& ) +{ +} +return false; +} + enum open_or_save_t {OPEN, SAVE, UNDEFINED}; } @@ -917,6 +930,7 @@ FileDialogHelper_Impl::FileDialogHelper_Impl( // create the picker component mxFileDlg.set(xFactory->createInstance( aService ), css::uno::UNO_QUERY); mbSystemPicker = lcl_isSystemFilePicker( mxFileDlg ); +mbAsyncPicker = lcl_isAsyncFilePicker(mxFileDlg); uno::Reference< XInitialization > xInit( mxFileDlg, UNO_QUERY ); @@ -1328,23 +1342,18 @@ void FileDialogHelper_Impl::implStartExecute() { DBG_ASSERT( mxFileDlg.is(), "invalid file dialog" ); +assert(mbAsyncPicker); preExecute(); -if ( mbSystemPicker ) +try { +uno::Reference< XAsynchronousExecutableDialog > xAsyncDlg( mxFileDlg, UNO_QUERY ); +if ( xAsyncDlg.is() ) +xAsyncDlg->startExecuteModal( this ); } -else +catch( const Exception& ) { -try -{ -uno::Reference< XAsynchronousExecutableDialog > xAsyncDlg( mxFileDlg, UNO_QUERY ); -if ( xAsyncDlg.is() ) -xAsyncDlg->startExecuteModal( this ); -} -catch( const Exception& ) -{ -TOOLS_WARN_EXCEPTION( "sfx.dialog", "FileDialogHelper_Impl::implDoExecute" ); -} +TOOLS_WARN_EXCEPTION( "sfx.dialog", "FileDialogHelper_Impl::implDoExecute" ); } } @@ -2592,7 +2601,7 @@ void FileDialogHelper::StartExecuteModal( const Link& rE { m_aDialogClosedLink = rEndDialogHdl; m_nError = ERRCODE_NONE; -if ( mpImpl->isSystemFilePicker() ) +if (!mpImpl->isAsyncFilePicker()) Application::PostUserEvent( LINK( this, FileDialogHelper, ExecuteSystemFilePicker ) ); else mpImpl->implStartExecute(); diff --git a/sfx2/source/dialog/filedlgimpl.hxx b/sfx2/source/dialog/filedlgimpl.hxx index 15fc3b2decbb..01411f23e9e4 100644 --- a/sfx2/source/dialog/filedlgimpl.hxx +++ b/sfx2/source/dialog/filedlgimpl.hxx @@ -87,6 +87,7 @@ namespace sfx2 boolmbDeleteMatcher : 1; boolmbInsert: 1; boolmbSystemPicker : 1; +boolmbAsyncPicker : 1; boolmbPwdCheckBoxState : 1; boolmbSelection : 1; boolmbSelectionEnabled : 1; @@ -206,7 +207,7 @@ namespace sfx2 voidSetContext( FileDialogHelper::Context _eNewContext ); OUStringgetInitPath( const OUString& _rFallback, const sal_Int32 _nFallbackToken ); -bool isSystemFilePicker() const { return mbSystemPicker; } +bool isAsyncFilePicker() const { return mbAsyncPicker; } bool isPasswordEnabled() const { return mbIsPwdEnabled; } css::uno::Reference GetFrameInterface();
[Libreoffice-bugs] [Bug 145363] KDE Plasma: Enters loop when editing bullet style
https://bugs.documentfoundation.org/show_bug.cgi?id=145363 --- Comment #7 from Commit Notification --- Jan-Marek Glogowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b00a68a8e19370e106cd76258a3c1825f43613ee tdf#145363 Qt reparent modal dialogs on show It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/inc vcl/qt5
vcl/inc/qt5/QtFrame.hxx |1 vcl/qt5/QtFrame.cxx | 80 ++-- vcl/qt5/QtWidget.cxx|6 +++ 3 files changed, 77 insertions(+), 10 deletions(-) New commits: commit b00a68a8e19370e106cd76258a3c1825f43613ee Author: Jan-Marek Glogowski AuthorDate: Sun Oct 31 02:33:46 2021 +0200 Commit: Jan-Marek Glogowski CommitDate: Sun Oct 31 21:04:33 2021 +0100 tdf#145363 Qt reparent modal dialogs on show Simply said, one can't have two modal dialogs open at the same parent in Qt. All modal windows must open as a stack, each parented to the previous one. This is kind of logical. Unexpectedly Qt totally breaks, if you open two modal dialogs on the same window. This happens, because the existing paragraph style dialog and the "sub" "list style" dialog are both children of their Writer window. I'm not sure the additionally introduced QWidget-based parent handling is strictly needed. It seems Ok. So for every visibility and modality change, we reparent the Qt widget, either on top of the modal stack or restore the original LO-based parent. The LO hierachy is never changed! Change-Id: Id209c9aa67774440089dc50a6648ac293950087a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124500 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski diff --git a/vcl/inc/qt5/QtFrame.hxx b/vcl/inc/qt5/QtFrame.hxx index 23c92d7e1da3..a338b106eaeb 100644 --- a/vcl/inc/qt5/QtFrame.hxx +++ b/vcl/inc/qt5/QtFrame.hxx @@ -132,6 +132,7 @@ class VCLPLUG_QT_PUBLIC QtFrame : public QObject, public SalFrame void SetWindowStateImpl(Qt::WindowStates eState); void fixICCCMwindowGroup(); +void modalReparent(bool bVisible); public: QtFrame(QtFrame* pParent, SalFrameStyleFlags nSalFrameStyle, bool bUseCairo); diff --git a/vcl/qt5/QtFrame.cxx b/vcl/qt5/QtFrame.cxx index 73bdad874552..1ae4016d589d 100644 --- a/vcl/qt5/QtFrame.cxx +++ b/vcl/qt5/QtFrame.cxx @@ -417,24 +417,71 @@ void QtFrame::DrawMenuBar() { /* not needed */} void QtFrame::SetExtendedFrameStyle(SalExtStyle /*nExtStyle*/) { /* not needed */} +void QtFrame::modalReparent(bool bVisible) +{ +#ifndef NDEBUG +auto* pSalInst(static_cast(GetSalData()->m_pInstance)); +assert(pSalInst); +assert(pSalInst->IsMainThread()); +assert(!asChild()->isVisible()); +assert(asChild()->isModal()); +#endif + +if (!bVisible) +{ +m_pQWidget->setParent(m_pParent ? m_pParent->asChild() : nullptr, + m_pQWidget->windowFlags()); +return; +} + +if (!QGuiApplication::modalWindow()) +return; + +QtInstance* pInst = static_cast(GetSalData()->m_pInstance); +for (auto* pFrame : pInst->getFrames()) +{ +QWidget* pQWidget = static_cast(pFrame)->asChild(); +if (pQWidget->windowHandle() == QGuiApplication::modalWindow()) +{ +m_pQWidget->setParent(pQWidget, m_pQWidget->windowFlags()); +break; +} +} +} + void QtFrame::Show(bool bVisible, bool bNoActivate) { assert(m_pQWidget); if (bVisible == asChild()->isVisible()) return; +auto* pSalInst(static_cast(GetSalData()->m_pInstance)); +assert(pSalInst); + +if (!bVisible) // hide +{ +pSalInst->RunInMainThread([this]() { +asChild()->hide(); +if (m_pQWidget->isModal()) +modalReparent(false); +}); +return; +} + +// show SetDefaultSize(); SetDefaultPos(); -auto* pSalInst(static_cast(GetSalData()->m_pInstance)); -assert(pSalInst); -pSalInst->RunInMainThread([this, bVisible, bNoActivate]() { -asChild()->setVisible(bVisible); -asChild()->raise(); +pSalInst->RunInMainThread([this, bNoActivate]() { +QWidget* const pChild = asChild(); +if (m_pQWidget->isModal()) +modalReparent(true); +pChild->show(); +pChild->raise(); if (!bNoActivate && !isPopup()) { -asChild()->activateWindow(); -asChild()->setFocus(); +pChild->activateWindow(); +pChild->setFocus(); } }); } @@ -610,7 +657,7 @@ SalFrame* QtFrame::GetParent() const { return m_pParent; } void QtFrame::SetModal(bool bModal) { -if (!isWindow()) +if (!isWindow() || asChild()->isModal() == bModal) return; auto* pSalInst(static_cast(GetSalData()->m_pInstance)); @@ -622,12 +669,20 @@ void QtFrame::SetModal(bool bModal) // modality change is only effective if the window is hidden if (bWasVisible) +{ pChild->hide(); +if (!bModal) +modalReparent(false); +} pChild->setWindowModality(bModal ? Qt::WindowModal : Qt::NonModal); if (bWasVisible) +{ +if (bModal) +modalReparent(true);
[Libreoffice-bugs] [Bug 145363] KDE Plasma: Enters loop when editing bullet style
https://bugs.documentfoundation.org/show_bug.cgi?id=145363 --- Comment #6 from Commit Notification --- Jan-Marek Glogowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e4abf879f4a24258bcc560eb58ca78b147768d46 tdf#145363 Qt popups actually are windows It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/qt5
vcl/qt5/QtFrame.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit e4abf879f4a24258bcc560eb58ca78b147768d46 Author: Jan-Marek Glogowski AuthorDate: Sun Oct 31 13:41:20 2021 +0100 Commit: Jan-Marek Glogowski CommitDate: Sun Oct 31 21:03:39 2021 +0100 tdf#145363 Qt popups actually are windows An other patch in the whole Qt popup handling saga. At this point it mainly exists as a prerequisite for the real tdf#145363 fix. I just wanted to keep it separate. Maybe it also helps Qt Wayland. Change-Id: Ib76e9919398bdd5fa7d6239ddb126859f0c0edbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124525 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski diff --git a/vcl/qt5/QtFrame.cxx b/vcl/qt5/QtFrame.cxx index 1fc9930ae83f..73bdad874552 100644 --- a/vcl/qt5/QtFrame.cxx +++ b/vcl/qt5/QtFrame.cxx @@ -138,7 +138,7 @@ QtFrame::QtFrame(QtFrame* pParent, SalFrameStyleFlags nStyle, bool bUseCairo) m_pParent = pParent; Qt::WindowFlags aWinFlags(Qt::Widget); -if (!(nStyle & SalFrameStyleFlags::SYSTEMCHILD)) +if (!(nStyle & SalFrameStyleFlags::SYSTEMCHILD) && (nStyle != SalFrameStyleFlags::NONE)) { if (nStyle & SalFrameStyleFlags::INTRO) aWinFlags = Qt::SplashScreen; @@ -153,7 +153,7 @@ QtFrame::QtFrame(QtFrame* pParent, SalFrameStyleFlags nStyle, bool bUseCairo) // a focus-out event, reaching the combo box. This used to map to // Qt::ToolTip, which doesn't feel that correct... else if (isPopup()) -aWinFlags = Qt::Widget | Qt::FramelessWindowHint | Qt::BypassWindowManagerHint; +aWinFlags = Qt::Window | Qt::FramelessWindowHint | Qt::BypassWindowManagerHint; else if (nStyle & SalFrameStyleFlags::TOOLWINDOW) aWinFlags = Qt::Tool; // top level windows can't be transient in Qt, so make them dialogs, if they have a parent. At least
[Libreoffice-bugs] [Bug 145363] KDE Plasma: Enters loop when editing bullet style
https://bugs.documentfoundation.org/show_bug.cgi?id=145363 Commit Notification changed: What|Removed |Added Whiteboard||target:7.3.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 128891] FILEOPEN: Level 2 chapter enumeration doesn't reset counter
https://bugs.documentfoundation.org/show_bug.cgi?id=128891 Björn Michaelsen changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #7 from Björn Michaelsen --- The subchapter style is not a renames "Heading 2", but a custom style. Why should this even work? If anything, the bug is that those headers are "2.1" and "3.1" in the first place ... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144969] EDIT: no dead keys in comments
https://bugs.documentfoundation.org/show_bug.cgi?id=144969 Hans Deragon changed: What|Removed |Added CC||h...@deragon.biz --- Comment #4 from Hans Deragon --- Copying the comment I have done on bug #71437, which are maybe, maybe not related. Confirming still having this problem with: Version: 7.2.2.2 / LibreOffice Community Build ID: 20(Build:2) CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3 Locale: en-CA (en_CA.utf8); UI: en-US Ubuntu package version: 1:7.2.2~rc2-0ubuntu0.20.04.1~lo1 Calc: threaded OS: Linux Ubuntu 20.04 LTS. However, in the main windows the dead keys are working. It is on some side widgets they are not. For instance: - In writer, dead keys work when typing in the main text area. However, they do not work in comment boxes. - In Calc, dead keys work when typing in the cell. If typing in the upper formula bar, they do not work. Tried 'unset XMODIFIERS' to no vail. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 71437] Dead keys not working
https://bugs.documentfoundation.org/show_bug.cgi?id=71437 --- Comment #35 from Hans Deragon --- Confirming still having this problem with: Version: 7.2.2.2 / LibreOffice Community Build ID: 20(Build:2) CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3 Locale: en-CA (en_CA.utf8); UI: en-US Ubuntu package version: 1:7.2.2~rc2-0ubuntu0.20.04.1~lo1 Calc: threaded OS: Linux Ubuntu 20.04 LTS. However, in the main windows the dead keys are working. It is on some side widgets they are not. For instance: - In writer, dead keys work when typing in the main text area. However, they do not work in comment boxes. - In Calc, dead keys work when typing in the cell. If typing in the upper formula bar, they do not work. Tried 'unset XMODIFIERS' to no vail. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145477] New: Crash with View > User Interface... just after "Select your Preferred Interface" appears
https://bugs.documentfoundation.org/show_bug.cgi?id=145477 Bug ID: 145477 Summary: Crash with View > User Interface... just after "Select your Preferred Interface" appears Product: LibreOffice Version: 7.1.6.2 release Hardware: x86 (IA32) OS: macOS (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: cmil...@hampshire.edu Description: Crash in LibreOffice 7.1.6.2 just after opening the UserInterface... window with View, User Interface The "Select Your Preferred Interface" window appears for about 1 second then disappears, then "Document Recovery" window appears with message "Due to an error, LibreOffice crashed, All the files you were working on will now be saved...". This is easily repeatable on this same machine after recovery, by picking View > User Interface I am using Version 7.1.6.2 with MacOS 10.15.7 Note that I just upgraded mo MacOS from 10.13 one day ago, and just installed LibreOffice 7.1.16 after using LibreOffice 4.x. Steps to Reproduce: 1.Open any text or spreadsheet document. 2.mouse click View menu 3.mouse click User Interface... submenu (or if the tips window allows you to go directly to the "Selecto your Preferred Interface" window. Actual Results: The "Select Your Preferred Interface" window appears for about 1 second then disappears, then "Document Recovery" window appears with message "Due to an error, LibreOffice crashed, All the files you were working on will now be saved...". This happens repeatedly. It also happened when I entered safe mode, and tried again. Expected Results: I will be able to select a different user interface, without any crashing. Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.1.6.2 / LibreOffice Community Build ID: 0e133318fcee89abacd6a7d077e292f1145735c3 CPU threads: 8; OS: Mac OS X 10.15.7; UI render: default; VCL: osx Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: test/source
test/source/chart/xchartdata.cxx |5 +- test/source/sheet/globalsheetsettings.cxx | 16 test/source/sheet/sheetcell.cxx|6 +-- test/source/sheet/sheetcellrange.cxx |6 +-- test/source/sheet/sheetcellranges.cxx |6 +-- test/source/sheet/xcellrangedata.cxx | 11 +++-- test/source/sheet/xcellrangeformula.cxx|2 - test/source/sheet/xconsolidationdescriptor.cxx |3 - test/source/sheet/xdatapilottable2.cxx |2 - test/source/sheet/xdocumentauditing.cxx|8 +--- test/source/sheet/xmultiformulatokens.cxx |3 - test/source/sheet/xrecentfunctions.cxx |3 + test/source/sheet/xscenarios.cxx |5 +- test/source/sheet/xsheetcellrangecontainer.cxx | 11 +++-- test/source/sheet/xsheetfilterable.cxx | 48 ++--- test/source/sheet/xsubtotalcalculatable.cxx| 12 ++ test/source/sheet/xsubtotaldescriptor.cxx |6 +-- test/source/sheet/xsubtotalfield.cxx |6 +-- test/source/style/xstyleloader.cxx |2 - test/source/table/xtablechart.cxx |2 - test/source/table/xtablecharts.cxx |3 - 21 files changed, 82 insertions(+), 84 deletions(-) New commits: commit eafa99c6c4904bce9bf692eca97562af92cd633e Author: Mike Kaganski AuthorDate: Fri Oct 29 10:15:13 2021 +0300 Commit: Mike Kaganski CommitDate: Sun Oct 31 20:27:57 2021 +0100 Prepare for removal of non-const operator[] from Sequence in test Change-Id: I9f2c0deda676b10377b0a4572d26422cb0d8b807 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124399 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/test/source/chart/xchartdata.cxx b/test/source/chart/xchartdata.cxx index 68a9b82f191e..5d0dcb48f13f 100644 --- a/test/source/chart/xchartdata.cxx +++ b/test/source/chart/xchartdata.cxx @@ -75,7 +75,8 @@ void XChartData::testChartDataChangeEventListener() uno::Reference xCDD(xCD, uno::UNO_QUERY_THROW); uno::Sequence> aData = xCDD->getData(); -aData[0][0] += 1.0; +auto& rFirstCell = aData.getArray()[0].getArray()[0]; +rFirstCell += 1.0; xCDD->setData(aData); CPPUNIT_ASSERT(pListener0->m_bListenerCalled); CPPUNIT_ASSERT(pListener1->m_bListenerCalled); @@ -85,7 +86,7 @@ void XChartData::testChartDataChangeEventListener() xCD->removeChartDataChangeEventListener( uno::Reference(pListener1)); -aData[0][0] += 1.0; +rFirstCell += 1.0; xCDD->setData(aData); CPPUNIT_ASSERT(pListener0->m_bListenerCalled); CPPUNIT_ASSERT(!pListener1->m_bListenerCalled); diff --git a/test/source/sheet/globalsheetsettings.cxx b/test/source/sheet/globalsheetsettings.cxx index 5018120ae3f5..78b6d88009dc 100644 --- a/test/source/sheet/globalsheetsettings.cxx +++ b/test/source/sheet/globalsheetsettings.cxx @@ -151,14 +151,14 @@ void GlobalSheetSettings::testGlobalSheetSettingsProperties() aStatusBarFunction); propName = "UserLists"; -uno::Sequence aSeq(6); -aSeq[0] = "Sun,Mon,Tue,Wed,Thu,Fri,Sat"; -aSeq[1] = "Sunday,Monday,Tuesday,Wednesday,Thursday,Friday,Saturday"; -aSeq[2] = "Jan,Feb,Mar,Apr,May,Jun,Jul,Aug,Sep,Oct,Nov,Dec"; -aSeq[3] -= "January,February,March,April,May,June,July,August,September,October,November,December"; -aSeq[4] = "Sunday,Monday,Tuesday,Wednesday,Thursday,Friday,Shabbat"; -aSeq[5] = "Nissan,Iyar,Sivan,Tammuz,Av,Elul,Tishri,Heshvan,Kislev,Tevet,Shevat,Adar,Adar B"; +uno::Sequence aSeq{ +"Sun,Mon,Tue,Wed,Thu,Fri,Sat", +"Sunday,Monday,Tuesday,Wednesday,Thursday,Friday,Saturday", +"Jan,Feb,Mar,Apr,May,Jun,Jul,Aug,Sep,Oct,Nov,Dec", + "January,February,March,April,May,June,July,August,September,October,November,December", +"Sunday,Monday,Tuesday,Wednesday,Thursday,Friday,Shabbat", + "Nissan,Iyar,Sivan,Tammuz,Av,Elul,Tishri,Heshvan,Kislev,Tevet,Shevat,Adar,Adar B" +}; uno::Sequence aUserLists; CPPUNIT_ASSERT(xGlobalSheetSettings->getPropertyValue(propName) >>= aUserLists); diff --git a/test/source/sheet/sheetcell.cxx b/test/source/sheet/sheetcell.cxx index e30847367b7d..d0a2c6c032bd 100644 --- a/test/source/sheet/sheetcell.cxx +++ b/test/source/sheet/sheetcell.cxx @@ -21,6 +21,7 @@ #include #include +#include #include using namespace com::sun::star; @@ -104,9 +105,8 @@ void SheetCell::testSheetCellProperties() CPPUNIT_ASSERT_EQUAL_MESSAGE("Able to set PropertyValue FormulaResultType2", aFormulaResultType2Get, aFormulaResultType2Set); -uno::Sequence aPropValue(1); -aPropValue[0].Name = "StyleName"; -aPropValue[0].Value <<= OUString("Result2"); +uno::Sequence aPropValue{ comphelper::makePropertyValue( +"StyleName", OUString("Result2")) }; propName = "ConditionalFormat";
[Libreoffice-bugs] [Bug 145320] I can't find the most recent version of the development for Linux any longer
https://bugs.documentfoundation.org/show_bug.cgi?id=145320 --- Comment #6 from Adalbert Hanßen --- Thank you. I did so with the version of 2021-10-31. However the version of the installed program does no longer show the compilation date. I just got Version: 7.3.0.0.alpha1+ / LibreOffice Community Build ID: c6af59b234e8eb8182dc7f686290524feafd6ed6 CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: de-DE (de_DE.UTF-8); UI: de-DE Calc: threaded The date always gave me a good indication of the age, because up to now I have used a developer version for about 2 weeks and reported all errors that I noticed. With much older this has less purpose. I miss this clarity now. The team might think about telling the make date of the version under test again under Help>About LibreOffice. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: solenv/gbuild
solenv/gbuild/platform/com_MSC_class.mk |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) New commits: commit bc39f6b0e62b0a54500bf3986f971a43fe8f843d Author: Luboš Luňák AuthorDate: Sun Oct 31 13:53:28 2021 + Commit: Luboš Luňák CommitDate: Sun Oct 31 20:13:28 2021 +0100 fix usage of MSVC's -debug:fastlink Using /link while only compiling does nothing (and MSVC apparently doesn't bother to warn). Fix gbuild to pass -debug:fastlink when linking, and limit it to dbgutil builds, since pdb files cannot be moved elsewhere if the option is used. Change-Id: I0325c55ddea1ce881b60b1373c81019d154ef672 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124526 Tested-by: Jenkins Reviewed-by: Luboš Luňák diff --git a/solenv/gbuild/platform/com_MSC_class.mk b/solenv/gbuild/platform/com_MSC_class.mk index 0fff6a2caf20..1dffddb2599a 100644 --- a/solenv/gbuild/platform/com_MSC_class.mk +++ b/solenv/gbuild/platform/com_MSC_class.mk @@ -83,7 +83,7 @@ $(call gb_Helper_abbreviate_dirs,\ $(INCLUDE) \ -Fd$(PDBFILE) \ -c $(3) \ - -Fo$(1)) $(if $(filter $(true),$(6)),/link /DEBUG:FASTLINK) \ + -Fo$(1)) \ $(if $(COMPILER_TEST),,$(call gb_create_deps,$(4),$(1),$(3))) endef @@ -301,7 +301,12 @@ gb_Windows_PE_TARGETTYPEFLAGS := \ -manifest # link.exe in -LIB mode doesn't understand -debug, use it only for EXEs and DLLs +ifeq ($(gb_ENABLE_DBGUTIL),$(true)) +# fastlink is faster but pdb files reference .obj files +gb_Windows_PE_TARGETTYPEFLAGS_DEBUGINFO := -debug:fastlink +else gb_Windows_PE_TARGETTYPEFLAGS_DEBUGINFO := -debug +endif ifeq ($(ENABLE_LTO),TRUE) gb_Windows_PE_TARGETTYPEFLAGS += -LTCG
[Libreoffice-bugs] [Bug 145335] Les flèches des formes de type légende n’apparaissaient plus dès la page 71
https://bugs.documentfoundation.org/show_bug.cgi?id=145335 Julien Nabet changed: What|Removed |Added Version|unspecified |7.1.6.2 release Status|NEEDINFO|NEW CC|serval2...@yahoo.fr | OS|Windows (All) |All --- Comment #4 from Julien Nabet --- Thank you for your feedback. On pc Debian x86-64 with master sources updated today, I could reproduce this. I can't help here so uncc myself. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145104] Accessibility: Paragraph Style "Index" has no language set
https://bugs.documentfoundation.org/show_bug.cgi?id=145104 Aron Budea changed: What|Removed |Added Hardware|x86-64 (AMD64) |All -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145104] Accessibility: Paragraph Style "Index" has no language set
https://bugs.documentfoundation.org/show_bug.cgi?id=145104 Aron Budea changed: What|Removed |Added CC||ba...@caesar.elte.hu, ||heiko.tietze@documentfounda ||tion.org Version|7.2.1.2 release |7.2.0.2 rc Keywords|bibisectRequest |bibisected, bisected See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||3066 --- Comment #2 from Aron Budea --- Bibisected to the 7.2 backport of the following commit using repo bibisect-linux-64-7.2. Adding CC: to Heiko Tietze. https://cgit.freedesktop.org/libreoffice/core/commit/?id=137a1d5380e310a43d36932c643e1331a94fd70d author Heiko Tietze2021-07-19 16:40:50 +0200 committer Heiko Tietze 2021-07-20 07:02:54 +0200 Resolves tdf#143066 - Language set to None for indices -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145231] URL Recognition option not working
https://bugs.documentfoundation.org/show_bug.cgi?id=145231 --- Comment #10 from Ken C --- I uploaded an attachment video to show how the bug may be reproduced on my system. But, I made a mistake in the video. In the video I typed in an error in the Bug number. It should read: I reported Bug# 145231 Attachment is mp4 file format. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144994] libreoffice crashes with kf5-wayland
https://bugs.documentfoundation.org/show_bug.cgi?id=144994 --- Comment #4 from giors...@yahoo.it --- (In reply to Michael Weghorn from comment #2) > Can't reproduce with current master on current Debian testing > (plasma-desktop 4:5.21.5-2) > > What's your Linux distro and Plasma version? Can you possibly retest with a > current daily build? > > Version: 7.3.0.0.alpha0+ / LibreOffice Community > Build ID: 5041b1491a183366ca44380bd0f5dfb7c0acc5fb > CPU threads: 12; OS: Linux 5.14; UI render: default; VCL: kf5 (cairo+wayland) > Locale: en-GB (en_GB.UTF-8); UI: en-US > Calc: threaded Sorry for being back late. The bug is still there. Libreoffice crashes constantly Operating System: Arch Linux KDE Plasma Version: 5.23.2 KDE Frameworks Version: 5.87.0 Qt Version: 5.15.2 Kernel Version: 5.14.14-arch1-1 (64-bit) Graphics Platform: Wayland Processors: 4 × Intel® Core™ i5-7500 CPU @ 3.40GHz Memory: 7.6 GiB of RAM Graphics Processor: Mesa Intel® HD Graphics 630 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144994] libreoffice crashes with kf5-wayland
https://bugs.documentfoundation.org/show_bug.cgi?id=144994 --- Comment #3 from giors...@yahoo.it --- (In reply to Michael Weghorn from comment #2) > Can't reproduce with current master on current Debian testing > (plasma-desktop 4:5.21.5-2) > > What's your Linux distro and Plasma version? Can you possibly retest with a > current daily build? > > Version: 7.3.0.0.alpha0+ / LibreOffice Community > Build ID: 5041b1491a183366ca44380bd0f5dfb7c0acc5fb > CPU threads: 12; OS: Linux 5.14; UI render: default; VCL: kf5 (cairo+wayland) > Locale: en-GB (en_GB.UTF-8); UI: en-US > Calc: threaded Sorry for being back late. I am on arch linux with Kde Plasma 5.23.2, kde frameworks 5.87.0 and QT 5.15.2. And the bug is still there (libreoffice constantly crashes). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145231] URL Recognition option not working
https://bugs.documentfoundation.org/show_bug.cgi?id=145231 --- Comment #9 from Ken C --- I read Bug# 145172 and re-opened this bug to update with new information to reproduce the bug. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145231] URL Recognition option not working
https://bugs.documentfoundation.org/show_bug.cgi?id=145231 --- Comment #8 from Ken C --- Created attachment 176046 --> https://bugs.documentfoundation.org/attachment.cgi?id=176046=edit Keystrokes used to reproduce linkification bug #145231 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145231] URL Recognition option not working
https://bugs.documentfoundation.org/show_bug.cgi?id=145231 Ken C changed: What|Removed |Added Resolution|WORKSFORME |--- Status|RESOLVED|REOPENED Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: include/vcl vcl/backendtest vcl/inc vcl/qa
include/vcl/test/GraphicsRenderTests.hxx |5 + vcl/backendtest/GraphicsRenderTests.cxx | 105 +++ vcl/backendtest/outputdevice/common.cxx | 69 +++ vcl/backendtest/outputdevice/polygon.cxx | 13 ++ vcl/backendtest/outputdevice/polyline.cxx| 15 +++ vcl/backendtest/outputdevice/polyline_b2d.cxx| 13 ++ vcl/backendtest/outputdevice/polypolygon.cxx | 17 +++ vcl/backendtest/outputdevice/polypolygon_b2d.cxx | 16 +++ vcl/inc/test/outputdevice.hxx|7 + vcl/qa/cppunit/BackendTest.cxx | 56 10 files changed, 316 insertions(+) New commits: commit 3eeb77ece8db11e6c57864c507af5d24253a6276 Author: homeboy445 AuthorDate: Fri Aug 6 20:44:39 2021 +0530 Commit: Tomaž Vajngerl CommitDate: Sun Oct 31 18:47:39 2021 +0100 backendtest: Drawing Open Polygon test Change-Id: I57af3232ad5e83b649fdfac719dc2359e1bbb412 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120171 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl diff --git a/include/vcl/test/GraphicsRenderTests.hxx b/include/vcl/test/GraphicsRenderTests.hxx index 7d44b538a948..718674b1cc5e 100644 --- a/include/vcl/test/GraphicsRenderTests.hxx +++ b/include/vcl/test/GraphicsRenderTests.hxx @@ -143,6 +143,11 @@ class VCL_PLUGIN_PUBLIC GraphicsRenderTests void testDrawRectangleOnSize4096WithPolyPolygon(); void testDrawRectangleOnSize1028WithPolyPolygonB2D(); void testDrawRectangleOnSize4096WithPolygonPolygonB2D(); +void testDrawOpenPolygonWithPolyLine(); +void testDrawOpenPolygonWithPolyLineB2D(); +void testDrawOpenPolygonWithPolygon(); +void testDrawOpenPolygonWithPolyPolygon(); +void testDrawOpenPolygonWithPolyPolygonB2D(); static OUString returnTestStatus(vcl::test::TestResult const result); void runALLTests(); void appendTestResult(OUString aTestName, OUString aTestStatus, Bitmap aTestBitmap = Bitmap()); diff --git a/vcl/backendtest/GraphicsRenderTests.cxx b/vcl/backendtest/GraphicsRenderTests.cxx index bf3932ffa2b1..0f360f2ae9c0 100644 --- a/vcl/backendtest/GraphicsRenderTests.cxx +++ b/vcl/backendtest/GraphicsRenderTests.cxx @@ -2015,6 +2015,106 @@ void GraphicsRenderTests::testDrawRectangleOnSize4096WithPolygonPolygonB2D() } } +void GraphicsRenderTests::testDrawOpenPolygonWithPolyLine() +{ +vcl::test::OutputDeviceTestPolyLine aOutDevTest; +Bitmap aBitmap = aOutDevTest.setupOpenPolygon(); +OUString aTestName = "testDrawOpenPolygonWithPolyLine"; +if (!SHOULD_ASSERT) +{ +appendTestResult(aTestName, "SKIPPED"); +return; +} +vcl::test::TestResult eResult = vcl::test::OutputDeviceTestCommon::checkOpenPolygon(aBitmap); +appendTestResult(aTestName, returnTestStatus(eResult), + (m_aStoreResultantBitmap ? aBitmap : Bitmap())); +if (m_aStoreResultantBitmap) +{ +BitmapEx aBitmapEx(aBitmap); +exportBitmapExToImage(m_aUserInstallPath + aTestName + ".png", aBitmapEx); +} +} + +void GraphicsRenderTests::testDrawOpenPolygonWithPolyLineB2D() +{ +vcl::test::OutputDeviceTestPolyLineB2D aOutDevTest; +Bitmap aBitmap = aOutDevTest.setupOpenPolygon(); +OUString aTestName = "testDrawOpenPolygonWithPolyLineB2D"; +if (!SHOULD_ASSERT) +{ +appendTestResult(aTestName, "SKIPPED"); +return; +} +vcl::test::TestResult eResult = vcl::test::OutputDeviceTestCommon::checkOpenPolygon(aBitmap); +appendTestResult(aTestName, returnTestStatus(eResult), + (m_aStoreResultantBitmap ? aBitmap : Bitmap())); +if (m_aStoreResultantBitmap) +{ +BitmapEx aBitmapEx(aBitmap); +exportBitmapExToImage(m_aUserInstallPath + aTestName + ".png", aBitmapEx); +} +} + +void GraphicsRenderTests::testDrawOpenPolygonWithPolygon() +{ +vcl::test::OutputDeviceTestPolygon aOutDevTest; +Bitmap aBitmap = aOutDevTest.setupOpenPolygon(); +OUString aTestName = "testDrawOpenPolygonWithPolygon"; +if (!SHOULD_ASSERT) +{ +appendTestResult(aTestName, "SKIPPED"); +return; +} +vcl::test::TestResult eResult = vcl::test::OutputDeviceTestCommon::checkOpenPolygon(aBitmap); +appendTestResult(aTestName, returnTestStatus(eResult), + (m_aStoreResultantBitmap ? aBitmap : Bitmap())); +if (m_aStoreResultantBitmap) +{ +BitmapEx aBitmapEx(aBitmap); +exportBitmapExToImage(m_aUserInstallPath + aTestName + ".png", aBitmapEx); +} +} + +void GraphicsRenderTests::testDrawOpenPolygonWithPolyPolygon() +{ +vcl::test::OutputDeviceTestPolyPolygon aOutDevTest; +Bitmap aBitmap = aOutDevTest.setupOpenPolygon(); +OUString aTestName = "testDrawOpenPolygonWithPolyPolygon"; +if (!SHOULD_ASSERT) +{ +appendTestResult(aTestName, "SKIPPED"); +return; +} +vcl::test::TestResult eResult =
[Libreoffice-commits] core.git: toolkit/source
toolkit/source/awt/vclxfont.cxx |9 ++-- toolkit/source/controls/animatedimages.cxx|2 - toolkit/source/controls/controlmodelcontainerbase.cxx |2 - toolkit/source/controls/dialogcontrol.cxx | 35 -- toolkit/source/controls/formattedcontrol.cxx | 20 +- toolkit/source/controls/grid/gridcontrol.hxx |4 +- toolkit/source/controls/roadmapcontrol.cxx| 10 +++-- toolkit/source/controls/stdtabcontroller.cxx |3 + toolkit/source/controls/tabpagecontainer.cxx |7 +-- toolkit/source/controls/tabpagemodel.cxx | 18 ++--- toolkit/source/controls/tkscrollbar.cxx | 10 +++-- toolkit/source/controls/tree/treecontrol.hxx |2 - toolkit/source/controls/tree/treecontrolpeer.cxx |6 +-- toolkit/source/controls/unocontrolcontainer.cxx |7 ++- toolkit/source/controls/unocontrolcontainermodel.cxx |5 +- toolkit/source/controls/unocontrols.cxx |6 +-- 16 files changed, 68 insertions(+), 78 deletions(-) New commits: commit a8bf972230545cd0c0e5dcacb73f5fff804d22de Author: Mike Kaganski AuthorDate: Fri Oct 29 10:18:33 2021 +0300 Commit: Mike Kaganski CommitDate: Sun Oct 31 18:42:08 2021 +0100 Prepare for removal of non-const operator[] from Sequence in toolkit Change-Id: I10b3f696fdb0bff1781fb22ec560e1c6dfc10b9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124401 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/toolkit/source/awt/vclxfont.cxx b/toolkit/source/awt/vclxfont.cxx index 2ae914cca2a7..66e5ba2bdc40 100644 --- a/toolkit/source/awt/vclxfont.cxx +++ b/toolkit/source/awt/vclxfont.cxx @@ -20,6 +20,8 @@ #include #include + +#include #include #include #include @@ -158,11 +160,8 @@ sal_Int32 VCLXFont::getStringWidthArray( const OUString& str, css::uno::Sequence pOutDev->SetFont( maFont ); std::vector aDXA; nRet = pOutDev->GetTextArray( str, ); -rDXArray = css::uno::Sequence( str.getLength() ); -for(int i = 0; i < str.getLength(); i++) -{ -rDXArray[i] = aDXA[i]; -} +// I don't know if size of aDXA is guaranteed same as length of str, so use arrayToSequence +rDXArray = comphelper::arrayToSequence(aDXA.data(), str.getLength()); pOutDev->SetFont( aOldFont ); } return nRet; diff --git a/toolkit/source/controls/animatedimages.cxx b/toolkit/source/controls/animatedimages.cxx index e70fd1ec0cc8..3e335a1a661f 100644 --- a/toolkit/source/controls/animatedimages.cxx +++ b/toolkit/source/controls/animatedimages.cxx @@ -126,7 +126,7 @@ public: { Sequence< OUString > aServices( AnimatedImagesControl_Base::getSupportedServiceNames() ); aServices.realloc( aServices.getLength() + 1 ); -aServices[ aServices.getLength() - 1 ] = "com.sun.star.awt.AnimatedImagesControl"; +aServices.getArray()[ aServices.getLength() - 1 ] = "com.sun.star.awt.AnimatedImagesControl"; return aServices; } diff --git a/toolkit/source/controls/controlmodelcontainerbase.cxx b/toolkit/source/controls/controlmodelcontainerbase.cxx index 96599f3089bb..1172ac5c99a8 100644 --- a/toolkit/source/controls/controlmodelcontainerbase.cxx +++ b/toolkit/source/controls/controlmodelcontainerbase.cxx @@ -867,7 +867,7 @@ void ControlModelContainerBase::implNotifyTabModelChange( const OUString& _rAcce aEvent.Source = *this; aEvent.Base <<= aEvent.Source; // the "base of the changes root" is also ourself aEvent.Changes.realloc( 1 );// exactly one change -aEvent.Changes[ 0 ].Accessor <<= _rAccessor; +aEvent.Changes.getArray()[ 0 ].Accessor <<= _rAccessor; std::vector< Reference< XInterface > > aChangeListeners( maChangeListeners.getElements() ); diff --git a/toolkit/source/controls/dialogcontrol.cxx b/toolkit/source/controls/dialogcontrol.cxx index 5c5df64850f8..cb5446e7a8ce 100644 --- a/toolkit/source/controls/dialogcontrol.cxx +++ b/toolkit/source/controls/dialogcontrol.cxx @@ -160,8 +160,9 @@ public: { auto s(ControlModelContainerBase::getSupportedServiceNames()); s.realloc(s.getLength() + 2); -s[s.getLength() - 2] = "com.sun.star.awt.UnoControlDialogModel"; -s[s.getLength() - 1] = "stardiv.vcl.controlmodel.Dialog"; +auto ps = s.getArray(); +ps[s.getLength() - 2] = "com.sun.star.awt.UnoControlDialogModel"; +ps[s.getLength() - 1] = "stardiv.vcl.controlmodel.Dialog"; return s; } }; @@ -509,15 +510,14 @@ void SAL_CALL UnoDialogControl::windowResized( const css::awt::WindowEvent& e ) // Remember that changes have been done by listener. No need to // update the position because of property change event. mbSizeModified = true; -Sequence< OUString > aProps( 2 ); -Sequence< Any >
[Libreoffice-commits] core.git: tools/source
tools/source/ref/globname.cxx | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) New commits: commit 20354bce87305a274c046cca39ffe8f16add2322 Author: Mike Kaganski AuthorDate: Fri Oct 29 10:19:16 2021 +0300 Commit: Mike Kaganski CommitDate: Sun Oct 31 18:41:42 2021 +0100 Prepare for removal of non-const operator[] from Sequence in tools Change-Id: Ifff56df8da9b0b9e4d4e96d6b09f490807e96f52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124402 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/tools/source/ref/globname.cxx b/tools/source/ref/globname.cxx index b38bda02ab9c..fda6fafab53c 100644 --- a/tools/source/ref/globname.cxx +++ b/tools/source/ref/globname.cxx @@ -256,24 +256,24 @@ css::uno::Sequence < sal_Int8 > SvGlobalName::GetByteSequence() const { // platform independent representation of a "GlobalName" // maybe transported remotely -css::uno::Sequence< sal_Int8 > aResult( 16 ); - -aResult[ 0] = static_cast(pImp->szData.Data1 >> 24); -aResult[ 1] = static_cast((pImp->szData.Data1 << 8 ) >> 24); -aResult[ 2] = static_cast((pImp->szData.Data1 << 16 ) >> 24); -aResult[ 3] = static_cast((pImp->szData.Data1 << 24 ) >> 24); -aResult[ 4] = static_cast(pImp->szData.Data2 >> 8); -aResult[ 5] = static_cast((pImp->szData.Data2 << 8 ) >> 8); -aResult[ 6] = static_cast(pImp->szData.Data3 >> 8); -aResult[ 7] = static_cast((pImp->szData.Data3 << 8 ) >> 8); -aResult[ 8] = pImp->szData.Data4[ 0 ]; -aResult[ 9] = pImp->szData.Data4[ 1 ]; -aResult[10] = pImp->szData.Data4[ 2 ]; -aResult[11] = pImp->szData.Data4[ 3 ]; -aResult[12] = pImp->szData.Data4[ 4 ]; -aResult[13] = pImp->szData.Data4[ 5 ]; -aResult[14] = pImp->szData.Data4[ 6 ]; -aResult[15] = pImp->szData.Data4[ 7 ]; +css::uno::Sequence< sal_Int8 > aResult{ +/* [ 0] */ static_cast(pImp->szData.Data1 >> 24), +/* [ 1] */ static_cast((pImp->szData.Data1 << 8 ) >> 24), +/* [ 2] */ static_cast((pImp->szData.Data1 << 16 ) >> 24), +/* [ 3] */ static_cast((pImp->szData.Data1 << 24 ) >> 24), +/* [ 4] */ static_cast(pImp->szData.Data2 >> 8), +/* [ 5] */ static_cast((pImp->szData.Data2 << 8 ) >> 8), +/* [ 6] */ static_cast(pImp->szData.Data3 >> 8), +/* [ 7] */ static_cast((pImp->szData.Data3 << 8 ) >> 8), +/* [ 8] */ static_cast(pImp->szData.Data4[ 0 ]), +/* [ 9] */ static_cast(pImp->szData.Data4[ 1 ]), +/* [10] */ static_cast(pImp->szData.Data4[ 2 ]), +/* [11] */ static_cast(pImp->szData.Data4[ 3 ]), +/* [12] */ static_cast(pImp->szData.Data4[ 4 ]), +/* [13] */ static_cast(pImp->szData.Data4[ 5 ]), +/* [14] */ static_cast(pImp->szData.Data4[ 6 ]), +/* [15] */ static_cast(pImp->szData.Data4[ 7 ]) +}; return aResult; }
[Libreoffice-bugs] [Bug 145393] Calc becomes unresponsive after a search, turning off "show this dialog" and doing a second search
https://bugs.documentfoundation.org/show_bug.cgi?id=145393 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTOURBUG --- Comment #7 from Roman Kuznetsov <79045_79...@mail.ru> --- So let's close this one, I think it's a Mint's LO build problem only -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145391] Segfault importing Basic macros
https://bugs.documentfoundation.org/show_bug.cgi?id=145391 --- Comment #6 from Julien Nabet --- With this patch: diff --git a/basctl/source/basicide/moduldl2.cxx b/basctl/source/basicide/moduldl2.cxx index 42bcccebd67b..8c3cf5028d94 100644 --- a/basctl/source/basicide/moduldl2.cxx +++ b/basctl/source/basicide/moduldl2.cxx @@ -638,10 +638,9 @@ void LibPage::InsertLib() ( xDlgLibContImport.is() && xDlgLibContImport->hasByName( aLibName ) && xDlgLibContImport->isLibraryLink( aLibName ) ) ) ) { weld::TreeView& rView = xLibDlg->GetLibBox(); -rView.append(); +rView.append_text(aLibName); const int nRow = rView.n_children() - 1; rView.set_toggle(nRow, TRISTATE_TRUE); -rView.set_text(nRow, aLibName, 0); rView.set_cursor(rView.find_text(aLibName)); } } I don't reproduce the crash and all the checkboxes are present and enabled on gtk3. But with gen rendering, only the last checkbox is present and enabled. I must recognize I don't know why. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145393] Calc becomes unresponsive after a search, turning off "show this dialog" and doing a second search
https://bugs.documentfoundation.org/show_bug.cgi?id=145393 --- Comment #6 from Frank --- Installed from Flatpak. Now running 7.2.2.2. Bug's gone.. Thank you. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: wizards/source
wizards/source/scriptforge/python/scriptforge.py | 12 wizards/source/sfdocuments/SF_Calc.xba | 343 ++- 2 files changed, 343 insertions(+), 12 deletions(-) New commits: commit 020967fde86d77c362658e49e256add265806292 Author: Jean-Pierre Ledure AuthorDate: Sun Oct 31 16:12:49 2021 +0100 Commit: Jean-Pierre Ledure CommitDate: Sun Oct 31 18:16:42 2021 +0100 ScriptForge - (SF_Calc) new ShiftDown, ShiftLeft, ShiftRight, ShiftUp methods ShiftRight()/ShiftDown() insert empty cells at the left/on the top of a given range and move all cells at the right/bottom of the range accordingly. They are similar to the Insert Cells ... menu commands ShiftLeft()/ShiftUp() delete cells at the left/top of a given range and move all cells at the right/below the range accordingly. They are similar to the Delete Cells ... menu commands The insertion/deletion may be done for a whole column/row. The number of columns/rows to insert/delete may be chosen. All methods are available in Basic and Python user scripts. Change-Id: I14555a3966c26054925dd71b0696f3dfc773fc21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124530 Tested-by: Jean-Pierre Ledure Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure diff --git a/wizards/source/scriptforge/python/scriptforge.py b/wizards/source/scriptforge/python/scriptforge.py index 9972660de0d3..4643ade07229 100644 --- a/wizards/source/scriptforge/python/scriptforge.py +++ b/wizards/source/scriptforge/python/scriptforge.py @@ -2019,6 +2019,18 @@ class SFDocuments: def SetValue(self, targetrange, value): return self.ExecMethod(self.vbMethod + self.flgArrayArg, 'SetValue', targetrange, value) +def ShiftDown(self, range, wholerow = False, rows = 0): +return self.ExecMethod(self.vbMethod, 'ShiftDown', range, wholerow, rows) + +def ShiftLeft(self, range, wholecolumn = False, columns = 0): +return self.ExecMethod(self.vbMethod, 'ShiftLeft', range, wholecolumn, columns) + +def ShiftRight(self, range, wholecolumn = False, columns = 0): +return self.ExecMethod(self.vbMethod, 'ShiftRight', range, wholecolumn, columns) + +def ShiftUp(self, range, wholerow = False, rows = 0): +return self.ExecMethod(self.vbMethod, 'ShiftUp', range, wholerow, rows) + def SortRange(self, range, sortkeys, sortorder = 'ASC', destinationcell = ScriptForge.cstSymEmpty, containsheader = False, casesensitive = False, sortcolumns = False): return self.ExecMethod(self.vbMethod, 'SortRange', range, sortkeys, sortorder, destinationcell, diff --git a/wizards/source/sfdocuments/SF_Calc.xba b/wizards/source/sfdocuments/SF_Calc.xba index a816b96920a0..75642598fa66 100644 --- a/wizards/source/sfdocuments/SF_Calc.xba +++ b/wizards/source/sfdocuments/SF_Calc.xba @@ -1599,6 +1599,7 @@ Public Function Methods() As Variant Methods = Array( _ A1Style _ , Activate _ + , Charts _ , ClearAll _ , ClearFormats _ , ClearValues _ @@ -1607,6 +1608,7 @@ Public Function Methods() As Variant , CopySheetFromFile _ , CopyToCell _ , CopyToRange _ + , CreateChart _ , DAvg _ , DCount _ , DMax _ @@ -1634,6 +1636,10 @@ Public Function Methods() As Variant , SetFormula _ , SetPrinter _ , SetValue _ + , ShiftDown _ + , ShiftLeft _ + , ShiftRight _ + , ShiftUp _ , SortRange _ ) @@ -2270,6 +2276,330 @@ Catch: GoTo Finally End Function SF_Documents.SF_Calc.SetValue +REM - +Public Function ShiftDown(Optional ByVal Range As Variant _ + , Optional ByVal WholeRow As Variant _ + , Optional ByVal Rows As Variant _ + ) As String + Move a specified range and all cells below in the same columns downwards by inserting empty cells +
[Libreoffice-bugs] [Bug 145475] Variable k is defined but cannot used in whole loop
https://bugs.documentfoundation.org/show_bug.cgi?id=145475 Michael Warner changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145475] Variable k is defined but cannot used in whole loop
https://bugs.documentfoundation.org/show_bug.cgi?id=145475 Michael Warner changed: What|Removed |Added Component|General |deletionRequest Status|UNCONFIRMED |RESOLVED Product|cppunit |LibreOffice Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145467] variable is not defined
https://bugs.documentfoundation.org/show_bug.cgi?id=145467 Michael Warner changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145468] function not defined correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=145468 Michael Warner changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145469] function does not have a return type
https://bugs.documentfoundation.org/show_bug.cgi?id=145469 Michael Warner changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145470] variable defined but not used
https://bugs.documentfoundation.org/show_bug.cgi?id=145470 Michael Warner changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145471] variable is not defined
https://bugs.documentfoundation.org/show_bug.cgi?id=145471 Michael Warner changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145470] variable defined but not used
https://bugs.documentfoundation.org/show_bug.cgi?id=145470 Michael Warner changed: What|Removed |Added Component|General |deletionRequest Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID Product|cppunit |LibreOffice -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145469] function does not have a return type
https://bugs.documentfoundation.org/show_bug.cgi?id=145469 Michael Warner changed: What|Removed |Added Component|General |deletionRequest Resolution|--- |INVALID Product|cppunit |LibreOffice Status|UNCONFIRMED |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145468] function not defined correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=145468 Michael Warner changed: What|Removed |Added Resolution|--- |INVALID Status|UNCONFIRMED |RESOLVED Component|General |deletionRequest Product|cppunit |LibreOffice -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145467] variable is not defined
https://bugs.documentfoundation.org/show_bug.cgi?id=145467 Michael Warner changed: What|Removed |Added Product|cppunit |LibreOffice Component|General |deletionRequest Resolution|--- |INVALID Status|UNCONFIRMED |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145471] variable is not defined
https://bugs.documentfoundation.org/show_bug.cgi?id=145471 Michael Warner changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Product|cppunit |LibreOffice Component|General |deletionRequest Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug.