[Libreoffice-bugs] [Bug 103164] [META] Footnote and Endnote bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103164 Dieter changed: What|Removed |Added Depends on||145936 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=145936 [Bug 145936] FORMATTING: Changing text page size changes the page style for endnotes, and hides part of the endnotes -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108576] [META] Writer page style bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108576 Dieter changed: What|Removed |Added Depends on||145936 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=145936 [Bug 145936] FORMATTING: Changing text page size changes the page style for endnotes, and hides part of the endnotes -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145936] FORMATTING: Changing text page size changes the page style for endnotes, and hides part of the endnotes
https://bugs.documentfoundation.org/show_bug.cgi?id=145936 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de, ||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval Blocks||103164, 108576 Whiteboard| QA:needsComment| --- Comment #2 from Dieter --- (In reply to LeroyG from comment #0) > After step 3: > The page orientation for the endnotes change to landscape. I confirm it with Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 2934472ab888ebfe64a153984af2902fac63a7a0 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL As there is the basic rule "One bug report for each problem" let's focus this report to the landscape problem. Feel free to open additional reports for the other problems. Further testings Height of default page style 22 cm => Endnote page is still in portrait Height of default page style 21 cm => Endnote page is still in portrait Height of default page style 20 cm => Orientation of default page style changes to landscape and also endnote page style changes to landscape So there seems to be the rule "Orientation of endnote page style follows orientation of default page style" I don't know, if this is the expected behaviour or a bug. Let's ask design team cc: Design-Team Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103164 [Bug 103164] [META] Footnote and Endnote bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=108576 [Bug 108576] [META] Writer page style bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 145936] FORMATTING: Changing text page size changes the page style for endnotes, and hides part of the endnotes
https://bugs.documentfoundation.org/show_bug.cgi?id=145936 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de, ||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval Blocks||103164, 108576 Whiteboard| QA:needsComment| --- Comment #2 from Dieter --- (In reply to LeroyG from comment #0) > After step 3: > The page orientation for the endnotes change to landscape. I confirm it with Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 2934472ab888ebfe64a153984af2902fac63a7a0 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL As there is the basic rule "One bug report for each problem" let's focus this report to the landscape problem. Feel free to open additional reports for the other problems. Further testings Height of default page style 22 cm => Endnote page is still in portrait Height of default page style 21 cm => Endnote page is still in portrait Height of default page style 20 cm => Orientation of default page style changes to landscape and also endnote page style changes to landscape So there seems to be the rule "Orientation of endnote page style follows orientation of default page style" I don't know, if this is the expected behaviour or a bug. Let's ask design team cc: Design-Team Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103164 [Bug 103164] [META] Footnote and Endnote bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=108576 [Bug 108576] [META] Writer page style bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 130318] Use the actual cursor position to create ToC "for chapter" beginning at the current level (impacts odm master documents)
https://bugs.documentfoundation.org/show_bug.cgi?id=130318 --- Comment #32 from Emanuele Gissi --- Created attachment 176936 --> https://bugs.documentfoundation.org/attachment.cgi?id=176936=edit Updated test case for the proposed patch (generated PDF) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 130318] Use the actual cursor position to create ToC "for chapter" beginning at the current level (impacts odm master documents)
https://bugs.documentfoundation.org/show_bug.cgi?id=130318 --- Comment #31 from Emanuele Gissi --- Created attachment 176935 --> https://bugs.documentfoundation.org/attachment.cgi?id=176935=edit Updated test case for the proposed patch -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 130318] Use the actual cursor position to create ToC "for chapter" beginning at the current level (impacts odm master documents)
https://bugs.documentfoundation.org/show_bug.cgi?id=130318 --- Comment #30 from Emanuele Gissi --- I applied your patch and recompiled LO. All ToCs and indexes are created correctly. No regression appears when ToCs and indexes are generated on the entire document, or first outline level. Only problem left is that the "List of Figures" created per "Chapter" does not correctly select the figures contained by the cursor heading, and display all the figures of the document. I attach the updated test case, with updated comments in it. See the yellow inline comments for issues. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144969] EDIT: no dead keys in comments
https://bugs.documentfoundation.org/show_bug.cgi?id=144969 --- Comment #5 from Christian Lehmann --- I finally got around to testing the bug on different systems. The results for dead keys in LO Writer comments are: For LO versions 6.1, 7.0.4.2 and 7.2.4.1, they work on Windows 10. For LO versions 7.0 and 7.2.4.1, they do not work on OpenSuse Leap 15.2. For LO version 6.4, they work on Lubuntu 14.4. I recognize that this test is not wholly systematic (my resources are limited). Nevertheless, it does seem that the bug is 1) new in LO version 7 and 2) limited to Linux. Needless to say, dead keys do work in all other application environments on Linux systems. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - sw/source
sw/source/core/doc/DocumentContentOperationsManager.cxx |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit 7b672a6d89581885c305068a714a72b5352de12f
Author: Michael Stahl
AuthorDate: Tue Dec 14 19:34:36 2021 +0100
Commit: Thorsten Behrens
CommitDate: Wed Dec 15 08:41:13 2021 +0100
tdf#141175 sw_redlinehide: fix crash in lcl_DeleteRedlines()
The GetNext() returns itself if it's alone in the Ring.
(regression from 27aa4b16bf704d0246595750daf57b57ff2577b3)
Change-Id: Idf92ce5362c4a4acf1582f463fe7bafc8553b400
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126844
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 19f2054c6063177d08c818c5b7eeba7ab9178249)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126824
Reviewed-by: Thorsten Behrens
diff --git a/sw/source/core/doc/DocumentContentOperationsManager.cxx
b/sw/source/core/doc/DocumentContentOperationsManager.cxx
index 457e5aa61555..363484191849 100644
--- a/sw/source/core/doc/DocumentContentOperationsManager.cxx
+++ b/sw/source/core/doc/DocumentContentOperationsManager.cxx
@@ -408,7 +408,8 @@ namespace
*pDelPam->GetPoint(), nDelCount );
}
-if (pDelPam->GetNext() && *pDelPam->GetNext()->End()
== *pDelPam->Start())
+if (pDelPam->GetNext() != pDelPam.get()
+&& *pDelPam->GetNext()->End() == *pDelPam->Start())
{
*pDelPam->GetNext()->End() = *pDelPam->End();
pDelPam.reset(pDelPam->GetNext());
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - sw/source
sw/source/core/doc/DocumentContentOperationsManager.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 6af4500fffe0d0db03b4d4a7e77cf627124aefc1 Author: Michael Stahl AuthorDate: Tue Dec 14 17:32:28 2021 +0100 Commit: Thorsten Behrens CommitDate: Wed Dec 15 08:40:47 2021 +0100 tdf#136855 sw: fix ReplaceRangeImpl() restoring of rPam This broke in CWS swrefactormarks2 (commit df6d312ca537402463e4eb0530f22b956600fc02) but for spell-checking the ReplaceRange() wasn't used until commit e1629c210ad78310e3d48c0756723134a27b89df. Change-Id: I4a6256b65b89e21e9e87ff45d0c5e6c4577a5846 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126842 Tested-by: Jenkins Reviewed-by: Michael Stahl (cherry picked from commit d16c5f47600d236e911ae50d0e58a3f2256f5a61) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126822 Reviewed-by: Thorsten Behrens diff --git a/sw/source/core/doc/DocumentContentOperationsManager.cxx b/sw/source/core/doc/DocumentContentOperationsManager.cxx index 4d0891a725fe..457e5aa61555 100644 --- a/sw/source/core/doc/DocumentContentOperationsManager.cxx +++ b/sw/source/core/doc/DocumentContentOperationsManager.cxx @@ -4477,8 +4477,8 @@ bool DocumentContentOperationsManager::ReplaceRangeImpl( SwPaM& rPam, const OUSt m_rDoc.getIDocumentRedlineAccess().SetRedlineFlags( eOld ); *rPam.GetPoint() = pBkmk->GetMarkPos(); -if(pBkmk->IsExpanded()) -*rPam.GetMark() = pBkmk->GetOtherMarkPos(); +*rPam.GetMark() = pBkmk->IsExpanded() ? pBkmk->GetOtherMarkPos() : pBkmk->GetMarkPos(); + m_rDoc.getIDocumentMarkAccess()->deleteMark(pBkmk); } bJoinText = false;
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sw/source
sw/source/core/doc/DocumentContentOperationsManager.cxx |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit d29f057ff03fcbccb81ccbac8d2ae2954ca3daef
Author: Michael Stahl
AuthorDate: Tue Dec 14 19:34:36 2021 +0100
Commit: Thorsten Behrens
CommitDate: Wed Dec 15 08:39:39 2021 +0100
tdf#141175 sw_redlinehide: fix crash in lcl_DeleteRedlines()
The GetNext() returns itself if it's alone in the Ring.
(regression from 27aa4b16bf704d0246595750daf57b57ff2577b3)
Change-Id: Idf92ce5362c4a4acf1582f463fe7bafc8553b400
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126844
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 19f2054c6063177d08c818c5b7eeba7ab9178249)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126823
Reviewed-by: Thorsten Behrens
diff --git a/sw/source/core/doc/DocumentContentOperationsManager.cxx
b/sw/source/core/doc/DocumentContentOperationsManager.cxx
index 8bff2555224a..304f44c77116 100644
--- a/sw/source/core/doc/DocumentContentOperationsManager.cxx
+++ b/sw/source/core/doc/DocumentContentOperationsManager.cxx
@@ -408,7 +408,8 @@ namespace
*pDelPam->GetPoint(), nDelCount );
}
-if (pDelPam->GetNext() && *pDelPam->GetNext()->End()
== *pDelPam->Start())
+if (pDelPam->GetNext() != pDelPam.get()
+&& *pDelPam->GetNext()->End() == *pDelPam->Start())
{
*pDelPam->GetNext()->End() = *pDelPam->End();
pDelPam.reset(pDelPam->GetNext());
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sw/source
sw/source/core/doc/DocumentContentOperationsManager.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit a5d4f32e6512acdec6402bd18ff958f07c9d327a Author: Michael Stahl AuthorDate: Tue Dec 14 17:32:28 2021 +0100 Commit: Thorsten Behrens CommitDate: Wed Dec 15 08:39:17 2021 +0100 tdf#136855 sw: fix ReplaceRangeImpl() restoring of rPam This broke in CWS swrefactormarks2 (commit df6d312ca537402463e4eb0530f22b956600fc02) but for spell-checking the ReplaceRange() wasn't used until commit e1629c210ad78310e3d48c0756723134a27b89df. Change-Id: I4a6256b65b89e21e9e87ff45d0c5e6c4577a5846 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126842 Tested-by: Jenkins Reviewed-by: Michael Stahl (cherry picked from commit d16c5f47600d236e911ae50d0e58a3f2256f5a61) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126821 Reviewed-by: Thorsten Behrens diff --git a/sw/source/core/doc/DocumentContentOperationsManager.cxx b/sw/source/core/doc/DocumentContentOperationsManager.cxx index 5311bfb5e3b8..8bff2555224a 100644 --- a/sw/source/core/doc/DocumentContentOperationsManager.cxx +++ b/sw/source/core/doc/DocumentContentOperationsManager.cxx @@ -4581,8 +4581,8 @@ bool DocumentContentOperationsManager::ReplaceRangeImpl( SwPaM& rPam, const OUSt m_rDoc.getIDocumentRedlineAccess().SetRedlineFlags( eOld ); *rPam.GetPoint() = pBkmk->GetMarkPos(); -if(pBkmk->IsExpanded()) -*rPam.GetMark() = pBkmk->GetOtherMarkPos(); +*rPam.GetMark() = pBkmk->IsExpanded() ? pBkmk->GetOtherMarkPos() : pBkmk->GetMarkPos(); + m_rDoc.getIDocumentMarkAccess()->deleteMark(pBkmk); } bJoinText = false;
[Libreoffice-bugs] [Bug 146233] Wiggling letter when typing certain letter on certain spot. Independent of sidebar. Zoom matters
https://bugs.documentfoundation.org/show_bug.cgi?id=146233 --- Comment #2 from Telesto --- Created attachment 176934 --> https://bugs.documentfoundation.org/attachment.cgi?id=176934=edit Example -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146233] Wiggling letter when typing certain letter on certain spot. Independent of sidebar. Zoom matters
https://bugs.documentfoundation.org/show_bug.cgi?id=146233 --- Comment #1 from Telesto --- Also in (for certain scenario's, not exact match with 7.4) Versie: 4.4.7.2 Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600 Locale: nl_NL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146233] New: Wiggling letter when typing certain letter on certain spot. Independent of sidebar. Zoom matters
https://bugs.documentfoundation.org/show_bug.cgi?id=146233 Bug ID: 146233 Summary: Wiggling letter when typing certain letter on certain spot. Independent of sidebar. Zoom matters Product: LibreOffice Version: 4.4.7.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Wiggling letter when typing certain letter on certain spot. Independent of sidebar. Zoom matters Steps to Reproduce: 1. Open the attached file 2. Zoom to 100%/ 140% 3. Press say 'd' or 'p' or 'x' (without quotes) before 'o' of the second 'World' Actual Results: Wiggling Expected Results: No wiggling Reproducible: Always User Profile Reset: No Additional Info: Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 7e5af164b7d293dd410710bed411e1ca64bbecf7 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: filter/source svx/qa svx/source
filter/source/msfilter/escherex.cxx |5
filter/source/msfilter/msdffimp.cxx |5
svx/qa/unit/customshapes.cxx | 54 +++
svx/qa/unit/data/tdf145904_center_Y0dot25.doc |binary
svx/qa/unit/data/tdf145904_center_Y0dot25.odt |binary
svx/source/customshapes/EnhancedCustomShape3d.cxx | 310 ++
svx/source/customshapes/EnhancedCustomShape3d.hxx | 31 --
7 files changed, 201 insertions(+), 204 deletions(-)
New commits:
commit 453c5b6214654b440fe1d3e926cddfb695e17f10
Author: Regina Henschel
AuthorDate: Sun Dec 12 14:18:23 2021 +0100
Commit: Miklos Vajna
CommitDate: Wed Dec 15 08:23:10 2021 +0100
tdf#145904,tdf#145956 improve extrusion of custom shapes
The patch addressed these errors:
The property Origin is relative to the bounding rectangle of the shape
not to the snap rectangle. That error is visible e.g. for a block arc.
Rotation center x- and y- values are relative to the snap rectangle and
not absolute.
Rotation center z-value is in Hmm and needs conversion to Twips in
Writer.
Rotation is around rotation center, which might be different from shape
center. That has been ignored.
I have moved calculation of the 2D logic rectangle of the scene to
main method to be able to reuse the transformation and other values.
I consider using a special local class as unneeded overhead.
I have reordered some parts to bring geometry relevant parts together.
Change-Id: I35ad0721091b365ae99cd3d7b2afb0ad7efe47fd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126847
Tested-by: Jenkins
Reviewed-by: Miklos Vajna
diff --git a/filter/source/msfilter/escherex.cxx
b/filter/source/msfilter/escherex.cxx
index bfdbdd72853a..c85c51e41c95 100644
--- a/filter/source/msfilter/escherex.cxx
+++ b/filter/source/msfilter/escherex.cxx
@@ -2849,8 +2849,9 @@ void
EscherPropertyContainer::CreateCustomShapeProperties( const MSO_SPT eShapeT
drawing::Direction3D aExtrusionRotationCenter;
if ( rrProp.Value >>= aExtrusionRotationCenter )
{
-AddOpt( DFF_Prop_c3DRotationCenterX,
static_cast( aExtrusionRotationCenter.DirectionX * 360.0 ) );
-AddOpt( DFF_Prop_c3DRotationCenterY,
static_cast( aExtrusionRotationCenter.DirectionY * 360.0 ) );
+// tdf#145904 X- and Y-component is fraction,
Z-component in EMU
+AddOpt( DFF_Prop_c3DRotationCenterX,
static_cast( aExtrusionRotationCenter.DirectionX * 65536.0 ) );
+AddOpt( DFF_Prop_c3DRotationCenterY,
static_cast( aExtrusionRotationCenter.DirectionY * 65536.0 ) );
AddOpt( DFF_Prop_c3DRotationCenterZ,
static_cast( aExtrusionRotationCenter.DirectionZ * 360.0 ) );
nFillHarshFlags &=~8; // don't use
AutoRotationCenter;
}
diff --git a/filter/source/msfilter/msdffimp.cxx
b/filter/source/msfilter/msdffimp.cxx
index 8de295d6b897..44c9f10402e3 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -1808,9 +1808,10 @@ void
DffPropertyReader::ApplyCustomShapeGeometryAttributes( SvStream& rIn, SfxIt
// "RotationCenter"
if ( IsProperty( DFF_Prop_c3DRotationCenterX ) || IsProperty(
DFF_Prop_c3DRotationCenterY ) || IsProperty( DFF_Prop_c3DRotationCenterZ ) )
{
+// tdf#145904 X- and Y-component is fraction, Z-component in
EMU
css::drawing::Direction3D aRotationCenter(
-
static_cast(static_cast(GetPropertyValue(
DFF_Prop_c3DRotationCenterX, 0 ))) / 360.0,
-
static_cast(static_cast(GetPropertyValue(
DFF_Prop_c3DRotationCenterY, 0 ))) / 360.0,
+
static_cast(static_cast(GetPropertyValue(
DFF_Prop_c3DRotationCenterX, 0 ))) / 65536.0,
+
static_cast(static_cast(GetPropertyValue(
DFF_Prop_c3DRotationCenterY, 0 ))) / 65536.0,
static_cast(static_cast(GetPropertyValue(
DFF_Prop_c3DRotationCenterZ, 0 ))) / 360.0 );
aProp.Name = "RotationCenter";
diff --git a/svx/qa/unit/customshapes.cxx b/svx/qa/unit/customshapes.cxx
index 92fbfc9fa62e..84a18fc77b4d 100644
--- a/svx/qa/unit/customshapes.cxx
+++ b/svx/qa/unit/customshapes.cxx
@@ -127,6 +127,58 @@ void lcl_AssertRectEqualWithTolerance(std::string_view
sInfo, const tools::Recta
std::abs(rExpected.GetHeight() -
rActual.GetHeight()) <= nTolerance);
}
+CPPUNIT_TEST_FIXTURE(CustomshapesTest, testTdf145904_Extrusion_CenterY_odt)
+{
+// The X- and Y-component of the extrusion rotation center specify the
position as fraction of
+// shape size. Error was, that the relative fraction was handled as
absolute value in Hmm.
+
+
[Libreoffice-bugs] [Bug 61914] [META] Start Center bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=61914 Bug 61914 depends on bug 131850, which changed state. Bug 131850 Summary: LibreOffice hangs if recent files are not accessible (e.g. remove samba, webdav, or nextcloud files) https://bugs.documentfoundation.org/show_bug.cgi?id=131850 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/rtfexport/rtfexport.cxx | 32 +++-
1 file changed, 15 insertions(+), 17 deletions(-)
New commits:
commit 85c5feaf8aa889906ad3a20a1d6e5cbffd446921
Author: Miklos Vajna
AuthorDate: Tue Dec 14 20:35:16 2021 +0100
Commit: Miklos Vajna
CommitDate: Wed Dec 15 08:20:45 2021 +0100
CppunitTest_sw_rtfexport: rework to simplify mustTestImportOf()
See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
(CppunitTest_sw_rtfimport: convert one testcase to use
CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
Change-Id: I21b08893f726f13a09a905f28f354f74b1b423ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126845
Tested-by: Jenkins
Reviewed-by: Miklos Vajna
diff --git a/sw/qa/extras/rtfexport/rtfexport.cxx
b/sw/qa/extras/rtfexport/rtfexport.cxx
index a3f83ce44201..c20a46900e17 100644
--- a/sw/qa/extras/rtfexport/rtfexport.cxx
+++ b/sw/qa/extras/rtfexport/rtfexport.cxx
@@ -54,17 +54,8 @@ public:
bool mustTestImportOf(const char* filename) const override
{
-// Don't test the first import of these, for some reason those tests
fail
-const char* aDenylist[] = {
-"math-escaping.rtf", "math-lim.rtf", "math-mso2007.rtf",
-"math-nary.rtf", "math-rad.rtf", "math-vertical-stacks.rtf",
-"math-runs.rtf",
-};
-std::vector vDenylist(aDenylist, aDenylist +
SAL_N_ELEMENTS(aDenylist));
-
// If the testcase is stored in some other format, it's pointless to
test.
-return (OString(filename).endsWith(".rtf")
-&& std::find(vDenylist.begin(), vDenylist.end(), filename) ==
vDenylist.end());
+return OString(filename).endsWith(".rtf");
}
};
@@ -229,14 +220,16 @@ DECLARE_RTFEXPORT_TEST(testMathD, "math-d.rtf")
aActual);
}
-DECLARE_RTFEXPORT_TEST(testMathEscaping, "math-escaping.rtf")
+CPPUNIT_TEST_FIXTURE(Test, testMathEscaping)
{
+loadAndReload("math-escaping.rtf");
OUString aActual = getFormula(getRun(getParagraph(1), 1));
CPPUNIT_ASSERT_EQUAL(OUString(u"\u00E1 \\{"), aActual);
}
-DECLARE_RTFEXPORT_TEST(testMathLim, "math-lim.rtf")
+CPPUNIT_TEST_FIXTURE(Test, testMathLim)
{
+loadAndReload("math-lim.rtf");
OUString aActual = getFormula(getRun(getParagraph(1), 1));
CPPUNIT_ASSERT_EQUAL(OUString(u"lim from {x \u2192 1} {x}"), aActual);
}
@@ -253,8 +246,9 @@ DECLARE_RTFEXPORT_TEST(testMathBox, "math-mbox.rtf")
CPPUNIT_ASSERT_EQUAL(OUString("a"), aActual);
}
-DECLARE_RTFEXPORT_TEST(testMathMso2007, "math-mso2007.rtf")
+CPPUNIT_TEST_FIXTURE(Test, testMathMso2007)
{
+loadAndReload("math-mso2007.rtf");
OUString aActual = getFormula(getRun(getParagraph(1), 1));
OUString aExpected(u"A = \u03C0 {r} ^ {2}");
CPPUNIT_ASSERT_EQUAL(aExpected, aActual);
@@ -299,8 +293,9 @@ DECLARE_RTFEXPORT_TEST(testMathMso2007, "math-mso2007.rtf")
CPPUNIT_ASSERT_EQUAL(aExpected, aActual);
}
-DECLARE_RTFEXPORT_TEST(testMathNary, "math-nary.rtf")
+CPPUNIT_TEST_FIXTURE(Test, testMathNary)
{
+loadAndReload("math-nary.rtf");
OUString aActual = getFormula(getRun(getParagraph(1), 1));
CPPUNIT_ASSERT_EQUAL(
OUString("lllint from {1} to {2} {x + 1} prod from {a} {b} sum to {2}
{x}"), aActual);
@@ -327,8 +322,9 @@ DECLARE_RTFEXPORT_TEST(testMathPlaceholders,
"math-placeholders.rtf")
CPPUNIT_ASSERT_EQUAL(OUString("sum from to "), aActual);
}
-DECLARE_RTFEXPORT_TEST(testMathRad, "math-rad.rtf")
+CPPUNIT_TEST_FIXTURE(Test, testMathRad)
{
+loadAndReload("math-rad.rtf");
OUString aActual = getFormula(getRun(getParagraph(1), 1));
CPPUNIT_ASSERT_EQUAL(OUString("sqrt {4} nroot {3} {x + 1}"), aActual);
}
@@ -349,8 +345,9 @@ DECLARE_RTFEXPORT_TEST(testMathSubscripts,
"math-subscripts.rtf")
aActual);
}
-DECLARE_RTFEXPORT_TEST(testMathVerticalstacks, "math-vertical-stacks.rtf")
+CPPUNIT_TEST_FIXTURE(Test, testMathVerticalstacks)
{
+loadAndReload("math-vertical-stacks.rtf");
CPPUNIT_ASSERT_EQUAL(OUString("{a} over {b}"),
getFormula(getRun(getParagraph(1), 1)));
CPPUNIT_ASSERT_EQUAL(OUString("{a} / {b}"),
getFormula(getRun(getParagraph(2), 1)));
CPPUNIT_ASSERT_EQUAL(OUString("stack { a # b }"),
getFormula(getRun(getParagraph(3), 1)));
@@ -382,8 +379,9 @@ DECLARE_RTFEXPORT_TEST(testTdf49073, "tdf49073.rtf")
getProperty(getParagraph(7)->getStart(),
"RubyPosition"));
}
-DECLARE_RTFEXPORT_TEST(testMathRuns, "math-runs.rtf")
+CPPUNIT_TEST_FIXTURE(Test, testMathRuns)
{
+loadAndReload("math-runs.rtf");
// was [](){}, i.e. first curly bracket had an incorrect position
CPPUNIT_ASSERT_EQUAL(OUString("\\{ left [ right ] left ( right ) \\}"),
getFormula(getRun(getParagraph(1), 1)));
[Libreoffice-commits] core.git: sfx2/inc sfx2/source
sfx2/inc/recentdocsview.hxx|2 +-
sfx2/source/control/recentdocsview.cxx |8 +---
2 files changed, 6 insertions(+), 4 deletions(-)
New commits:
commit 2f848eb5dc6f6f9344f250ac9860065130aaf436
Author: Mike Kaganski
AuthorDate: Wed Dec 15 09:22:13 2021 +0300
Commit: Mike Kaganski
CommitDate: Wed Dec 15 08:17:25 2021 +0100
tdf#131850: avoid encryption check for recent docs overlay
Change-Id: I673de978c39492bf9be78945ece95ade2a943ffc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126849
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sfx2/inc/recentdocsview.hxx b/sfx2/inc/recentdocsview.hxx
index b87a0cce679c..b347fc25029a 100644
--- a/sfx2/inc/recentdocsview.hxx
+++ b/sfx2/inc/recentdocsview.hxx
@@ -65,7 +65,7 @@ public:
void insertItem(const OUString , const OUString , const
BitmapEx , sal_uInt16 nId);
static bool typeMatchesExtension(ApplicationType type, std::u16string_view
rExt);
-static BitmapEx getDefaultThumbnail(const OUString );
+static BitmapEx getDefaultThumbnail(const OUString , bool
bCheckEncrypted = true);
ApplicationType mnFileTypes;
diff --git a/sfx2/source/control/recentdocsview.cxx
b/sfx2/source/control/recentdocsview.cxx
index f942b1ffbb15..0957cabbdc6f 100644
--- a/sfx2/source/control/recentdocsview.cxx
+++ b/sfx2/source/control/recentdocsview.cxx
@@ -206,13 +206,15 @@ bool RecentDocsView::isAcceptedFile(const OUString )
const
(mnFileTypes & ApplicationType::TYPE_OTHER&&
typeMatchesExtension(ApplicationType::TYPE_OTHER, aExt));
}
-BitmapEx RecentDocsView::getDefaultThumbnail(const OUString )
+BitmapEx RecentDocsView::getDefaultThumbnail(const OUString , bool
bCheckEncrypted)
{
BitmapEx aImg;
INetURLObject aUrl(rURL);
OUString aExt = aUrl.getExtension();
-const std::map& rWhichMap = IsDocEncrypted(
rURL) ?
+// tdf#131850: avoid reading the file to check if it's encrypted,
+// if we only need its generic "module" thumbnail
+const std::map& rWhichMap = bCheckEncrypted &&
IsDocEncrypted(rURL) ?
EncryptedBitmapForExtension : BitmapForExtension;
std::map::const_iterator mIt =
@@ -269,7 +271,7 @@ void RecentDocsView::Reload()
}
}
-aModule = getDefaultThumbnail(aURL);
+aModule = getDefaultThumbnail(aURL, false); // We don't need an
"encrypted" icon here
if (!aModule.IsEmpty() && !aThumbnail.IsEmpty()) {
ScopedVclPtr
m_pVirDev(VclPtr::Create());
Size aSize(aThumbnail.GetSizePixel());
[Libreoffice-bugs] [Bug 139605] The content of some math formulas disappear while writing at other location in Writer document
https://bugs.documentfoundation.org/show_bug.cgi?id=139605 --- Comment #5 from MarkGuptil --- I needed this information when my friend asked me for his assignment but I didn't get much information at that time so I researched for Dissertation help the UK and found "PhdDissertation" ( https://www.phddissertation.co.uk/ )they have 14 years of experience as writers and research team so we took service from them and got great marks but after a long time, I saw some similar information over here so it reminds me that days. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146232] New: Poor look of lock overlay on encrypted files in Start Center with Colibre
https://bugs.documentfoundation.org/show_bug.cgi?id=146232 Bug ID: 146232 Summary: Poor look of lock overlay on encrypted files in Start Center with Colibre Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Keywords: topicUI Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mikekagan...@hotmail.com CC: kain...@gmail.com, riz...@libreoffice.org Created attachment 176933 --> https://bugs.documentfoundation.org/attachment.cgi?id=176933=edit Thumbnail with lock overlay Lock overlay icons used for password-protected files on Start Center (BMP_128X128_WRITER_DOC, BMP_128X128_CALC_DOC, BMP_128X128_IMPRESS_DOC, BMP_128X128_DRAW_DOC, BMP_128X128_MATH_DOC) seem to be using transparent pixels around the lock in Colibre theme. That looks poor on the start center, where the "shadow" around the lock seem to make the lock "patched" atop of the thumbnail. The "shadow" should be either removed, or made non-transparent, to not create an "alien" impression of the lock. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 101302] Deleted files visible as recent documents in menu and start center
https://bugs.documentfoundation.org/show_bug.cgi?id=101302 Mike Kaganski changed: What|Removed |Added Blocks|131850 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=131850 [Bug 131850] LibreOffice hangs if recent files are not accessible (e.g. remove samba, webdav, or nextcloud files) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131850] LibreOffice hangs if recent files are not accessible (e.g. remove samba, webdav, or nextcloud files)
https://bugs.documentfoundation.org/show_bug.cgi?id=131850 Mike Kaganski changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com |desktop.org | Status|NEW |ASSIGNED --- Comment #15 from Mike Kaganski --- https://gerrit.libreoffice.org/c/core/+/126849 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131850] LibreOffice hangs if recent files are not accessible (e.g. remove samba, webdav, or nextcloud files)
https://bugs.documentfoundation.org/show_bug.cgi?id=131850 --- Comment #14 from Kevin Suo --- (In reply to Eyal Rozenberg from comment #13) I reproduce the issue regarding remove files on Nextcloud (webdav), but I do not reproduce the hang with a local file deleted. So if it is slow or hangs with deleted local file, then it should not be a duplicate. > If it's the former, than my dupe is not a dupe But which bug are you referring to? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143793] ODT: Wrap for shape in header was disabled (USE_FORMER_TEXT_WRAPPING), but now should probably be re-enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=143793 --- Comment #10 from Justin L --- (In reply to Justin L from comment #8) > https://gerrit.libreoffice.org/c/core/+/124932 The problem with ANY fix is that this will mean different layout logic is applied in headers/footers and footnotes/endnotes, and both of these easily lead to layout loops that will freeze LO. Sure, those are existing bugs that will simply be exposed, but that means that someone also needs to fix them in a timely fashion. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145752] CompatibilityMode Basic function documentation is incomplete
https://bugs.documentfoundation.org/show_bug.cgi?id=145752 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145979] Öffnen einer angeblich passwortgeschützten docx-Datei möglich! Aufforderung in LibreOffice Writer die Dateisperre zu ignorieren
https://bugs.documentfoundation.org/show_bug.cgi?id=145979 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145975] LibreOffice write, paste from another document overwrites destination's formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=145975 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145973] Keyboard shortcut personalization not working and impossible to assign empty shortcuts
https://bugs.documentfoundation.org/show_bug.cgi?id=145973 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145969] divide common settings from object-specific settings in 'Position And Size' dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=145969 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142329] FILESAVE Draw Keeps Crashing with lot of gradients shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=142329 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142329] FILESAVE Draw Keeps Crashing with lot of gradients shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=142329 --- Comment #9 from QA Administrators --- Dear lucode, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145965] PPTM inserted as OLE object is too wide and produces UI artifacts when scrolling
https://bugs.documentfoundation.org/show_bug.cgi?id=145965 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145961] selection problem in the Arabic text
https://bugs.documentfoundation.org/show_bug.cgi?id=145961 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 109324] [META] Calculate bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109324 Bug 109324 depends on bug 140706, which changed state. Bug 140706 Summary: Calc formulas stop functioning correctly when new data is entered into a cell https://bugs.documentfoundation.org/show_bug.cgi?id=140706 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140706] Calc formulas stop functioning correctly when new data is entered into a cell
https://bugs.documentfoundation.org/show_bug.cgi?id=140706 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140706] Calc formulas stop functioning correctly when new data is entered into a cell
https://bugs.documentfoundation.org/show_bug.cgi?id=140706 --- Comment #7 from QA Administrators --- Dear Brandi, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142502] Crash when opening file
https://bugs.documentfoundation.org/show_bug.cgi?id=142502 --- Comment #3 from QA Administrators --- Dear Vinícius M. Serbeto, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142501] Libre Office 7.1.3 portable version is crashed when open a docx file in Windows 7
https://bugs.documentfoundation.org/show_bug.cgi?id=142501 --- Comment #3 from QA Administrators --- Dear elf01b, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 94503] Options dialog's extended tips are wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=94503 --- Comment #5 from QA Administrators --- Dear Andras Timar, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 69098] FILEOPEN Imported MS-word document (.doc) does not show correct Unicode PUA character (checkbox)
https://bugs.documentfoundation.org/show_bug.cgi?id=69098 --- Comment #18 from QA Administrators --- Dear Kees van den Broek, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 46441] FILESAVE: frame and it's content lost after saving to .doc of specific .odt
https://bugs.documentfoundation.org/show_bug.cgi?id=46441 --- Comment #14 from QA Administrators --- Dear Kobus, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 129401] gtk2: OK button disabled in bullets and numbering dialogue when selecting "None"
https://bugs.documentfoundation.org/show_bug.cgi?id=129401 --- Comment #4 from QA Administrators --- Dear Heinrich Schuchardt, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 100974] If different CTL font is selected, font preview shows sample text in different alphabet than the default language's
https://bugs.documentfoundation.org/show_bug.cgi?id=100974 --- Comment #5 from QA Administrators --- Dear akash96j, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - desktop/inc desktop/qa include/tools
desktop/inc/lib/init.hxx| 12 +---
desktop/qa/desktop_lib/test_desktop_lib.cxx | 16 +++-
include/tools/gen.hxx | 15 +++
3 files changed, 31 insertions(+), 12 deletions(-)
New commits:
commit 46aef6ae1a450c218b80b7e5bfe31b710217245d
Author: Luboš Luňák
AuthorDate: Fri Dec 10 18:15:17 2021 +0100
Commit: Michael Meeks
CommitDate: Wed Dec 15 04:46:31 2021 +0100
fix handling of the "EMPTY" LOK tile invalidation
The LOK_CALLBACK_INVALIDATE_TILES documentation says that
invalidate-all message should say "EMPTY", which wasn't converted
properly from the MaxTwips rectangle representation. Doing that
now needs also changing the testTileInvalidationCompression() test,
but that should be a fix of the test, and conceptually it should
be the same.
Change-Id: I58fcc56ee56d9f6fcdb9298938e8aa7e3609d6db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126650
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Michael Meeks
diff --git a/desktop/inc/lib/init.hxx b/desktop/inc/lib/init.hxx
index 4499914839a0..5e1e23b2cdb5 100644
--- a/desktop/inc/lib/init.hxx
+++ b/desktop/inc/lib/init.hxx
@@ -41,13 +41,18 @@ namespace desktop {
tools::Rectangle m_aRectangle;
int m_nPart;
+// This is the "EMPTY" rectangle, which somewhat confusingly actually
means
+// to drop all rectangles (see LOK_CALLBACK_INVALIDATE_TILES
documentation),
+// and so it is actually an infinite rectangle and not an empty one.
+constexpr static tools::Rectangle emptyAllRectangle = {0, 0,
SfxLokHelper::MaxTwips, SfxLokHelper::MaxTwips};
+
RectangleAndPart()
: m_nPart(INT_MIN) // -1 is reserved to mean "all parts".
{
}
RectangleAndPart(const tools::Rectangle* pRect, int nPart)
-: m_aRectangle( pRect ? *pRect : tools::Rectangle(0, 0,
SfxLokHelper::MaxTwips, SfxLokHelper::MaxTwips))
+: m_aRectangle( pRect ? *pRect : emptyAllRectangle)
, m_nPart(nPart)
{
}
@@ -55,9 +60,10 @@ namespace desktop {
OString toString() const
{
if (m_nPart >= -1)
-return m_aRectangle.toString() + ", " +
OString::number(m_nPart);
+return (isInfinite() ? "EMPTY" : m_aRectangle.toString())
++ ", " + OString::number(m_nPart);
else
-return m_aRectangle.toString();
+return (isInfinite() ? "EMPTY" : m_aRectangle.toString());
}
/// Infinite Rectangle is both sides are
diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx
b/desktop/qa/desktop_lib/test_desktop_lib.cxx
index 6eb1f73bfcc7..bee2c2aab765 100644
--- a/desktop/qa/desktop_lib/test_desktop_lib.cxx
+++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx
@@ -1852,7 +1852,7 @@ void DesktopLOKTest::testTileInvalidationCompression()
size_t i = 0;
CPPUNIT_ASSERT_EQUAL(int(LOK_CALLBACK_INVALIDATE_TILES),
std::get<0>(notifs[i]));
-CPPUNIT_ASSERT_EQUAL(std::string("0, 0, 10, 10, 0"),
std::get<1>(notifs[i++]));
+CPPUNIT_ASSERT_EQUAL(std::string("EMPTY, 0"),
std::get<1>(notifs[i++]));
}
}
@@ -1970,6 +1970,20 @@ void DesktopLOKTest::testBinaryCallback()
CPPUNIT_ASSERT_EQUAL(int(LOK_CALLBACK_INVALIDATE_TILES),
std::get<0>(notifs[0]));
CPPUNIT_ASSERT_EQUAL(rect1String, std::get<1>(notifs[0]));
}
+// Very that the "EMPTY" invalidation gets converted properly.
+{
+std::vector> notifs;
+std::unique_ptr handler(new
CallbackFlushHandler(pDocument, callbackBinaryCallbackTest, ));
+handler->setViewId(SfxLokHelper::getView());
+
+handler->libreOfficeKitViewInvalidateTilesCallback(nullptr, INT_MIN);
+
+Scheduler::ProcessEventsToIdle();
+
+CPPUNIT_ASSERT_EQUAL(static_cast(1), notifs.size());
+CPPUNIT_ASSERT_EQUAL(int(LOK_CALLBACK_INVALIDATE_TILES),
std::get<0>(notifs[0]));
+CPPUNIT_ASSERT_EQUAL(std::string("EMPTY"), std::get<1>(notifs[0]));
+}
}
void DesktopLOKTest::testDialogInput()
diff --git a/include/tools/gen.hxx b/include/tools/gen.hxx
index 13372a916d76..7087bc3ffc18 100644
--- a/include/tools/gen.hxx
+++ b/include/tools/gen.hxx
@@ -382,7 +382,7 @@ class SAL_WARN_UNUSED TOOLS_DLLPUBLIC Rectangle final
public:
Rectangle();
Rectangle( const Point& rLT, const Point& rRB );
-Rectangle( tools::Long nLeft, tools::Long nTop,
+constexpr Rectangle( tools::Long nLeft, tools::Long nTop,
tools::Long nRight, tools::Long nBottom );
/// Constructs an empty Rectangle, with top/left at the specified params
Rectangle( tools::Long nLeft, tools::Long nTop );
@@ -504,14 +504,13 @@ inline
[Libreoffice-bugs] [Bug 106278] Worksheet Comment Parent is Nothing, expecting a Range object of associated cell
https://bugs.documentfoundation.org/show_bug.cgi?id=106278 --- Comment #8 from Leslie --- I can confirm this bug with this version Version: 7.2.3.2 (x64) / LibreOffice Community Build ID: d166454616c1632304285822f9c83ce2e660fd92 CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 106278] Worksheet Comment Parent is Nothing, expecting a Range object of associated cell
https://bugs.documentfoundation.org/show_bug.cgi?id=106278 --- Comment #7 from Leslie --- Created attachment 176932 --> https://bugs.documentfoundation.org/attachment.cgi?id=176932=edit spreadsheet showing bug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/qa vcl/source
vcl/qa/cppunit/physicalfontcollection.cxx | 14 ++
vcl/source/font/PhysicalFontCollection.cxx | 24 +---
2 files changed, 31 insertions(+), 7 deletions(-)
New commits:
commit ddd675c5a79b26d23da8d4affeeb888ac3664635
Author: Hossein
AuthorDate: Wed Dec 15 02:15:52 2021 +0100
Commit: Hossein
CommitDate: Wed Dec 15 03:17:56 2021 +0100
tdf#144961 vcl: fix CJK matching in FindFontFamilyByAttributes
Whilst testing CJK matching, I uncovered an issue. The matching
algorithm detects that the font is a CJK font if there are any CJK
characters in the font name. However, if you searched for a CJK font
against a font that was not a CJK font (i.e. the family name had no
CJK characters) then it would still match against this font family.
We now check if the font being matched against was a CJK font family
or not, if not then I reduced the testMatch value by CJK_MATCH_VALUE.
The fix can be tested with:
make CPPUNIT_TEST_NAME=testShouldNotFindCJKFamily -sr \
CppunitTest_vcl_font
Without the fix in place, the test fails with:
Test name: VclPhysicalFontCollectionTest::testShouldNotFindCJKFamily
assertion failed
- Expression: !aFontCollection.FindFontFamilyByAttributes(
ImplFontAttrs::CJK, WEIGHT_NORMAL, WIDTH_NORMAL, ITALIC_NONE, "")
- family found
Change-Id: I18b246f151b2174dc4ae0f5507630a4e8e4bb442
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123309
Tested-by: Jenkins
Reviewed-by: Hossein
diff --git a/vcl/qa/cppunit/physicalfontcollection.cxx
b/vcl/qa/cppunit/physicalfontcollection.cxx
index a147fb1dea4f..7df20ce76b66 100644
--- a/vcl/qa/cppunit/physicalfontcollection.cxx
+++ b/vcl/qa/cppunit/physicalfontcollection.cxx
@@ -35,6 +35,7 @@ public:
void testShouldFindFontFamilyByTokenNames();
void testShouldFindNoFamilyWithWorthlessAttributes();
void testShouldFindCJKFamily();
+void testShouldNotFindCJKFamily();
void testShouldFindStarsymbolFamily();
void testShouldFindOpensymbolFamilyWithMultipleSymbolFamilies();
void testShouldFindSymboltypeFamily();
@@ -65,6 +66,7 @@ public:
CPPUNIT_TEST(testShouldFindFontFamilyByTokenNames);
CPPUNIT_TEST(testShouldFindNoFamilyWithWorthlessAttributes);
CPPUNIT_TEST(testShouldFindCJKFamily);
+CPPUNIT_TEST(testShouldNotFindCJKFamily);
CPPUNIT_TEST(testShouldFindStarsymbolFamily);
CPPUNIT_TEST(testShouldFindOpensymbolFamilyWithMultipleSymbolFamilies);
CPPUNIT_TEST(testShouldFindSymboltypeFamily);
@@ -186,6 +188,18 @@ void
VclPhysicalFontCollectionTest::testShouldFindCJKFamily()
pCJKFamily->GetSearchName());
}
+void VclPhysicalFontCollectionTest::testShouldNotFindCJKFamily()
+{
+vcl::font::PhysicalFontCollection aFontCollection;
+vcl::font::PhysicalFontFamily* pFontFamily
+= aFontCollection.FindOrCreateFontFamily(GetEnglishSearchFontName(u"No
CJK characters"));
+AddNormalFontFace(pFontFamily, "No CJK characters");
+
+CPPUNIT_ASSERT_MESSAGE("family found",
+ !aFontCollection.FindFontFamilyByAttributes(
+ ImplFontAttrs::CJK, WEIGHT_NORMAL,
WIDTH_NORMAL, ITALIC_NONE, ""));
+}
+
void VclPhysicalFontCollectionTest::testShouldFindStarsymbolFamily()
{
vcl::font::PhysicalFontCollection aFontCollection;
diff --git a/vcl/source/font/PhysicalFontCollection.cxx
b/vcl/source/font/PhysicalFontCollection.cxx
index 0cb503a7df54..211e4e65bd57 100644
--- a/vcl/source/font/PhysicalFontCollection.cxx
+++ b/vcl/source/font/PhysicalFontCollection.cxx
@@ -445,13 +445,23 @@ PhysicalFontFamily*
PhysicalFontCollection::FindFontFamilyByAttributes(ImplFontA
// test CJK script attributes
if ( nSearchType & ImplFontAttrs::CJK )
{
-// Matching language
-if( ImplFontAttrs::None == ((nSearchType ^ nMatchType) &
ImplFontAttrs::CJK_AllLang) )
-nTestMatch += 1000*3;
-if( nMatchType & ImplFontAttrs::CJK )
-nTestMatch += 1000*2;
-if( nMatchType & ImplFontAttrs::Full )
-nTestMatch += 1000;
+// if the matching font doesn't support any CJK languages, then
+// it is not appropriate
+if ( !(nMatchType & ImplFontAttrs::CJK_AllLang) )
+{
+nTestMatch -= 1000;
+}
+else
+{
+// Matching language
+if ( (nSearchType & ImplFontAttrs::CJK_AllLang)
+&& (nMatchType & ImplFontAttrs::CJK_AllLang) )
+nTestMatch += 1000*3;
+if ( nMatchType & ImplFontAttrs::CJK )
+nTestMatch += 1000*2;
+if ( nMatchType & ImplFontAttrs::Full )
+nTestMatch += 1000;
+}
}
else
Need a help
Hi everyone, I have a doubt. when we import ppt in LibreOffice. It extracts and parses all the xml files to layout. then it goes ahead and redner that on the screen. Can anyone please tell me If it uses any temp storage to store the extracted xml files or it stores everything in RAM. I wanted to understand the LibreOffice design perspective. What it does. looking into the code It looks like it stores everything in RAM and parses that input stream . Just wanted to confirm. Thanks, Rajeev
[Libreoffice-bugs] [Bug 146228] i18langtag warns about converting locale en-IL:en
https://bugs.documentfoundation.org/show_bug.cgi?id=146228 Eike Rathke changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Ever confirmed|0 |1 Version|7.4.0.0 alpha0+ Master |Inherited From OOo Assignee|libreoffice-b...@lists.free |er...@redhat.com |desktop.org | Component|Writer |framework --- Comment #4 from Eike Rathke --- Ahaa.. the LANGUAGE variable. Humya, that may indeed be a colon separated list. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: chart2/source hwpfilter/source
chart2/source/view/main/PolarLabelPositionHelper.cxx | 15 ---
hwpfilter/source/hwpreader.cxx | 39 +--
2 files changed, 5 insertions(+), 49 deletions(-)
New commits:
commit 25ac6754d144a258d39cd9251677f3e35f4b3ee6
Author: Dhiraj Holden
AuthorDate: Tue Nov 30 15:44:00 2021 -0500
Commit: Hossein
CommitDate: Wed Dec 15 01:32:43 2021 +0100
tdf#145630 Changed atan to atan2 where appropriate
The extra checks are superfluous with atan2, and thus removed. More
information can be found here:
https://dev.blog.documentfoundation.org/2021/11/17/use-atan2-function-instead-of-atan-easyhack/
Change-Id: I1de97562ce3f7180ce846629870915f789a7bedf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126212
Tested-by: Jenkins
Reviewed-by: Hossein
diff --git a/chart2/source/view/main/PolarLabelPositionHelper.cxx
b/chart2/source/view/main/PolarLabelPositionHelper.cxx
index 8ebe9ca4c4cc..b64de3970196 100644
--- a/chart2/source/view/main/PolarLabelPositionHelper.cxx
+++ b/chart2/source/view/main/PolarLabelPositionHelper.cxx
@@ -104,19 +104,8 @@ awt::Point
PolarLabelPositionHelper::getLabelScreenPositionAndAlignmentForUnitCi
double fDX = aRet.X-aP0.X;
double fDY = aRet.Y-aP0.Y;
fDY*=-1.0;//drawing layer has inverse y values
-if( fDX != 0.0 )
-{
-fAngleDegree = basegfx::rad2deg(atan(fDY/fDX));
-if(fDX<0.0)
-fAngleDegree+=180.0;
-}
-else
-{
-if(fDY>0.0)
-fAngleDegree = 90.0;
-else
-fAngleDegree = 270.0;
-}
+
+fAngleDegree = basegfx::rad2deg(atan2(fDY,fDX));
}
//set LabelAlignment
if( !bCenter )
diff --git a/hwpfilter/source/hwpreader.cxx b/hwpfilter/source/hwpreader.cxx
index 32d9b08c6d25..e26cbb26143a 100644
--- a/hwpfilter/source/hwpreader.cxx
+++ b/hwpfilter/source/hwpreader.cxx
@@ -4046,16 +4046,7 @@ void HwpReader::makePictureDRAW(HWPDrawingObject
*drawobj, Picture * hbox)
double rotate, skewX ;
/* 2 - rotation angle calculation */
-if( pt[1].x == pt[0].x ){
- if( pt[1].y > pt[0].y )
- rotate = M_PI_2;
- else
- rotate = -M_PI_2;
-}
-else
-rotate = atan(static_cast( pt[1].y - pt[0].y
)/(pt[1].x - pt[0].x ));
-if( pt[1].x < pt[0].x )
-rotate += M_PI;
+rotate = atan2( pt[1].y - pt[0].y, pt[1].x - pt[0].x );
for( i = 0 ; i < 3 ; i++){
r_pt[i].x = static_cast(pt[i].x * cos(-rotate) -
pt[i].y * sin(-rotate));
@@ -4261,33 +4252,9 @@ void HwpReader::makePictureDRAW(HWPDrawingObject
*drawobj, Picture * hbox)
double start_angle, end_angle;
ZZParall *pal = >property.parall;
-if( pal->pt[1].x == pal->pt[0].x ){
-if( pal->pt[0].y < pal->pt[1].y )
-start_angle = 3 * M_PI_2;
-else
-start_angle = M_PI_2;
-}
-else{
- start_angle = atan(static_cast(
pal->pt[0].y - pal->pt[1].y )/( pal->pt[1].x - pal->pt[0].x ));
- if( pal->pt[1].x < pal->pt[0].x )
- start_angle += M_PI;
-}
-if( pal->pt[1].x == pal->pt[2].x ){
-if( pal->pt[2].y < pal->pt[1].y )
-end_angle = 3 * M_PI_2;
-else
-end_angle = M_PI_2;
-}
-else{
- end_angle = atan(static_cast(
pal->pt[2].y - pal->pt[1].y )/( pal->pt[1].x - pal->pt[2].x ));
- if( pal->pt[1].x < pal->pt[2].x )
- end_angle += M_PI;
-}
+start_angle = atan2(pal->pt[0].y -
pal->pt[1].y,pal->pt[1].x - pal->pt[0].x );
+end_angle = atan2(pal->pt[2].y - pal->pt[1].y,
pal->pt[1].x - pal->pt[2].x);
-if( start_angle >= 2 * M_PI )
-start_angle -= 2 * M_PI;
-if( end_angle >= 2 * M_PI )
-end_angle -= 2 * M_PI;
if( ( start_angle > end_angle ) &&
(start_angle -
[ANN] mdds updated to 2.0.1
Hi there, This is a bit of a delayed announcement, but I've updated mdds to 2.0.1 on the master branch as of yesterday, and I believe this has already been backported to the libreoffice-7-3 branch as well. 2.0.1 is a bug fix release, and is safe to update from 2.0.0. Please see the release notes here (https://gitlab.com/mdds/mdds/-/releases/2.0.1) for details. Best, Kohei
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sc/source
sc/source/ui/view/tabvwsh3.cxx | 20
1 file changed, 12 insertions(+), 8 deletions(-)
New commits:
commit 364c807cf22de7898e918a9cd1fa7e5392ca7577
Author: Eike Rathke
AuthorDate: Wed Dec 8 00:26:06 2021 +0100
Commit: Eike Rathke
CommitDate: Tue Dec 14 23:10:18 2021 +0100
Related: tdf#132466 Relative address parsing needs current position
For the bug doc example the #C target lead to always column 1
(A,0) being selected. Instead, the column of the current cell
cursor position should be selected as C is the short notation for
C[0] in R1C1 address syntax.
This does not "fix" the alleged bug but would yield the desired
behaviour if there was no sheet C where the intention was to jump
to.
Change-Id: Ibaed0250b9fb2cbc7f15a4b22404c48b39d41ff8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126496
Reviewed-by: Eike Rathke
Tested-by: Jenkins
(cherry picked from commit 155024040de888270bf90bdd200799cea7d73e4e)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126825
diff --git a/sc/source/ui/view/tabvwsh3.cxx b/sc/source/ui/view/tabvwsh3.cxx
index 2fa44e4233b4..d8c65f902a83 100644
--- a/sc/source/ui/view/tabvwsh3.cxx
+++ b/sc/source/ui/view/tabvwsh3.cxx
@@ -86,22 +86,24 @@ namespace
};
ScRefFlagsAndType lcl_ParseRangeOrAddress(ScRange& rScRange, ScAddress&
rScAddress,
- const OUString& aAddress, const
ScDocument& rDoc)
+ const OUString& aAddress, const
ScDocument& rDoc,
+ SCCOL nCurCol, SCROW nCurRow)
{
ScRefFlagsAndType aRet;
-formula::FormulaGrammar::AddressConvention eConv;
+// Relative address parsing needs current position.
+// row,col parameters, not col,row!
+ScAddress::Details aDetails( rDoc.GetAddressConvention(), nCurRow,
nCurCol);
// start with the address convention set in the document
-eConv = rDoc.GetAddressConvention();
-aRet.nResult = rScRange.Parse(aAddress, rDoc, eConv);
+aRet.nResult = rScRange.Parse(aAddress, rDoc, aDetails);
if (aRet.nResult & ScRefFlags::VALID)
{
aRet.eDetected = DetectFlags::RANGE;
return aRet;
}
-aRet.nResult = rScAddress.Parse(aAddress, rDoc, eConv);
+aRet.nResult = rScAddress.Parse(aAddress, rDoc, aDetails);
if (aRet.nResult & ScRefFlags::VALID)
{
aRet.eDetected = DetectFlags::ADDRESS;
@@ -140,14 +142,15 @@ namespace
}
// try Excel R1C1 address convention
-aRet.nResult = rScRange.Parse(aAddress, rDoc,
formula::FormulaGrammar::CONV_XL_R1C1);
+aDetails.eConv = formula::FormulaGrammar::CONV_XL_R1C1;
+aRet.nResult = rScRange.Parse(aAddress, rDoc, aDetails);
if (aRet.nResult & ScRefFlags::VALID)
{
aRet.eDetected = DetectFlags::RANGE;
return aRet;
}
-aRet.nResult = rScAddress.Parse(aAddress, rDoc,
formula::FormulaGrammar::CONV_XL_R1C1);
+aRet.nResult = rScAddress.Parse(aAddress, rDoc, aDetails);
if (aRet.nResult & ScRefFlags::VALID)
{
aRet.eDetected = DetectFlags::ADDRESS;
@@ -330,7 +333,8 @@ void ScTabViewShell::Execute( SfxRequest& rReq )
ScMarkData& rMark = rViewData.GetMarkData();
ScRange aScRange;
ScAddress aScAddress;
-ScRefFlagsAndType aResult = lcl_ParseRangeOrAddress(aScRange,
aScAddress, aAddress, rDoc);
+ScRefFlagsAndType aResult = lcl_ParseRangeOrAddress(aScRange,
aScAddress, aAddress, rDoc,
+rViewData.GetCurX(), rViewData.GetCurY());
ScRefFlags nResult = aResult.nResult;
SCTAB nTab = rViewData.GetTabNo();
boolbMark = true;
[Libreoffice-bugs] [Bug 129062] [META] Skia library bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=129062 Bug 129062 depends on bug 146036, which changed state. Bug 146036 Summary: Images rendered incomplete with Skia enabled https://bugs.documentfoundation.org/show_bug.cgi?id=146036 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145988] macOS skia: colors not displayed correctly for all document previews e.g. start center or impress templates
https://bugs.documentfoundation.org/show_bug.cgi?id=145988 Thorsten Wagner changed: What|Removed |Added CC||thorsten.wagne...@gmail.com --- Comment #16 from Thorsten Wagner --- *** Bug 146036 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa
sw/qa/uitest/data/tdf136855.odt |binary
sw/qa/uitest/writer_tests4/spellDialog.py | 17 +
2 files changed, 17 insertions(+)
New commits:
commit cfe7dc2ef91ea119ea54b56e207ef7a77291a9d7
Author: Xisco Fauli
AuthorDate: Tue Dec 14 19:02:03 2021 +0100
Commit: Xisco Fauli
CommitDate: Tue Dec 14 22:22:43 2021 +0100
tdf#136855: sw: Add UItest
Change-Id: I2626f56d59456f0e4c0942f4783c6b5270534260
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126843
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sw/qa/uitest/data/tdf136855.odt b/sw/qa/uitest/data/tdf136855.odt
new file mode 100644
index ..10d951dcf618
Binary files /dev/null and b/sw/qa/uitest/data/tdf136855.odt differ
diff --git a/sw/qa/uitest/writer_tests4/spellDialog.py
b/sw/qa/uitest/writer_tests4/spellDialog.py
index 20a69f52e380..4a319790d0b0 100644
--- a/sw/qa/uitest/writer_tests4/spellDialog.py
+++ b/sw/qa/uitest/writer_tests4/spellDialog.py
@@ -96,6 +96,23 @@ frog, dogg, catt"""
output_text = document.Text.getString().replace('\r\n', '\n')
self.assertTrue(re.match(self.TDF46852_REGEX, output_text))
+def test_tdf136855(self):
+supported_locale = self.is_supported_locale("en", "US")
+if not supported_locale:
+self.skipTest("no dictionary support for en_US available")
+
+with self.ui_test.load_file(get_url_for_data_file("tdf136855.odt")) as
writer_doc:
+
+with
self.ui_test.execute_modeless_dialog_through_command(".uno:SpellingAndGrammarDialog",
close_button="close") as xDialog:
+
+xChangeBtn = xDialog.getChild('change')
+for i in range(6):
+# Without the fix in place, this test would have crashed
here
+xChangeBtn.executeAction("CLICK", ())
+
+output_text = writer_doc.Text.getString().replace('\n', '')
+self.assertTrue(output_text.startswith("xx xx xx xxix
xxviii"))
+
def test_tdf66043(self):
supported_locale = self.is_supported_locale("en", "US")
if not supported_locale:
[Libreoffice-bugs] [Bug 146036] Images rendered incomplete with Skia enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=146036 Thorsten Wagner changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #11 from Thorsten Wagner --- It seems to be a duplicate. *** This bug has been marked as a duplicate of bug 145988 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145843] Incidental Crash on macOS with skia raster
https://bugs.documentfoundation.org/show_bug.cgi?id=145843 --- Comment #15 from Telesto --- (In reply to Luboš Luňák from comment #14) > (In reply to Telesto from comment #12) > > Only for my informaton: You're testing on own build or against the > > pre-published? [Not sure if the build bot is running some different version > > of Xcode or something like that] > > And which macOS version? > > My own developer build on Mac Mini M1: > Version: 7.4.0.0.alpha0+ / LibreOffice Community > Build ID: 7e5af164b7d293dd410710bed411e1ca64bbecf7 > CPU threads: 8; OS: Mac OS X 11.5.1; UI render: Skia/Metal; VCL: osx > Locale: en-US (en_US.UTF-8); UI: en-US > Calc: threaded Double checking, as comment 0 isn't mentioning Skia Raster as explicit requirement (it is) and the about here showing Vulkan.. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146036] Images rendered incomplete with Skia enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=146036 --- Comment #10 from Luboš Luňák --- This seems at least related to bug #145988 (if not a duplicate). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146228] i18langtag warns about converting locale en-IL:en
https://bugs.documentfoundation.org/show_bug.cgi?id=146228 Eyal Rozenberg changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145988] macOS skia: colors not displayed correctly for all document previews e.g. start center or impress templates
https://bugs.documentfoundation.org/show_bug.cgi?id=145988 --- Comment #15 from Luboš Luňák --- (In reply to steve from comment #14) > High: this will affect all macOS users if I am not mistaken (or all HiDPI, > which is all macs currently sold) Given that I cannot reproduce, it's probably not all users. > Major: although functionality itself is not broken, having all previews > (start center, impress, ...) in unreadable state impacts usability Can somebody check if it's the displaying of the previews that is broken or if the documents themselves already contain broken thumbnails? ODT/ODS/ODP documents are technically .zip files that can be unpacked and there is a thumbnail PNG somewhere in it. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146200] Formatting issue with Libre Office wRITER
https://bugs.documentfoundation.org/show_bug.cgi?id=146200 Coolman changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146228] i18langtag warns about converting locale en-IL:en
https://bugs.documentfoundation.org/show_bug.cgi?id=146228 --- Comment #3 from Eyal Rozenberg --- (In reply to Eike Rathke from comment #2) > What does your locale environment in a shell commandline using the 'locale' > command say? $ locale LANG=en_IL LANGUAGE=en_IL:en LC_CTYPE="en_IL" LC_NUMERIC="en_IL" LC_TIME="en_IL" LC_COLLATE="en_IL" LC_MONETARY="en_IL" LC_MESSAGES="en_IL" LC_PAPER="en_IL" LC_NAME="en_IL" LC_ADDRESS="en_IL" LC_TELEPHONE="en_IL" LC_MEASUREMENT="en_IL" LC_IDENTIFICATION="en_IL" LC_ALL= I have no idea who sets it that way... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146200] Formatting issue with Libre Office wRITER
https://bugs.documentfoundation.org/show_bug.cgi?id=146200 --- Comment #5 from Coolman --- That was easy, but I, as a Writer user, could not have thought of such a simple solution. Thank you. I'll close, if that's OK. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145811] Painting glitches when scrolling around entered OLE object on macOS in Skia Raster mode
https://bugs.documentfoundation.org/show_bug.cgi?id=145811 --- Comment #9 from Luboš Luňák --- (In reply to steve from comment #8) > @Luboš: What do you think about the remaining problem? Is that expected or > should that have been addressed in your patch? The scrollbar? That's unrelated and has nothing to do with Skia. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145843] Incidental Crash on macOS with skia raster
https://bugs.documentfoundation.org/show_bug.cgi?id=145843 --- Comment #14 from Luboš Luňák --- (In reply to Telesto from comment #12) > Only for my informaton: You're testing on own build or against the > pre-published? [Not sure if the build bot is running some different version > of Xcode or something like that] > And which macOS version? My own developer build on Mac Mini M1: Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 7e5af164b7d293dd410710bed411e1ca64bbecf7 CPU threads: 8; OS: Mac OS X 11.5.1; UI render: Skia/Metal; VCL: osx Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136409] Writer crashes with large file (comment 5 is another bug)
https://bugs.documentfoundation.org/show_bug.cgi?id=136409 --- Comment #11 from Michael Stahl (allotropia) --- everything copied to bug 139843 i can't mark the 2 attachments as obsolete. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133092] [META] Crash bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=133092 Michael Stahl (allotropia) changed: What|Removed |Added Depends on||139843 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=139843 [Bug 139843] Crash swlo!SwNumRule::MakeNumString -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138327] [META] sw_redlinehide regressions (track changes)
https://bugs.documentfoundation.org/show_bug.cgi?id=138327 Michael Stahl (allotropia) changed: What|Removed |Added Depends on||139843 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=139843 [Bug 139843] Crash swlo!SwNumRule::MakeNumString -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102593] [META] Paste bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102593 Michael Stahl (allotropia) changed: What|Removed |Added Depends on||139843 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=139843 [Bug 139843] Crash swlo!SwNumRule::MakeNumString -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139843] Crash swlo!SwNumRule::MakeNumString
https://bugs.documentfoundation.org/show_bug.cgi?id=139843
Michael Stahl (allotropia) changed:
What|Removed |Added
Keywords|bibisectRequest |bibisected, bisected,
||haveBacktrace
Blocks||102593, 133092, 138327
--- Comment #9 from Michael Stahl (allotropia) ---
copying comments from bug 136409:
[tag] [reply] [−] Comment 6 Telesto 2020-09-03 20:04:10 CEST
Crash with
6.3
No crash on paste with
6.2
[tag] [reply] [−] Comment 7 Terrence Enger 2020-09-23 19:30:36 CEST
Created attachment 165798 [details]
bibisect-linux-64-6.3, tail of terminal output
Working in bibisect-linux-64-6.3 repository on debian-buster, I find
the bug started:
commits-h date
---
good 717ce60f 43a7231c 2018-11-15 14:10:06
bad f7287b31 ae246b44 2018-11-15 14:10:06
for which the commit message is
commit ae246b44da1708417aaaefe4f9186cfbbb9a9137
Author: Michael Stahl
AuthorDate: Wed Nov 7 14:16:28 2018 +0100
Commit: Michael Stahl
CommitDate: Thu Nov 15 15:10:06 2018 +0100
sw_redlinehide_3: add second result to SwGetRefField
... and init it in SwGetRefField::UpdateField().
Change-Id: I69af00678e84214d4a122d8b2d940fcdda5f4ccf
I waited for CPU usage to return to 0% before each operation. This
introduces considerable delay, especially between first rendering of
the document and +A.
When I probed the "good" versions, after LibreOffice correctly
responded to +V, I continued with
5. CTRL+Q ALT+D
the +D being a reponse to the question about saving the document
before quitting.) In the probes of versions closest the first bad
version, LibreOffice promptly closed the Writer window and then
finished normally after about 3 more minutes with 100% CPU. However,
two probes of the earliest versions in the repository, upon +Q
+D, crashed with a Signal 6. A backtrace from this crash looks
quite different from the backtrace from a crash upon +V.
I am removing keyword bibisectRequest and adding bibisected, bisected.
[tag] [reply] [−] Comment 8 Terrence Enger 2020-09-23 19:40:16 CEST
Created attachment 165799 [details]
backtrace from master
This backtrace is from a local build of commit b42d5557, 2020-09-10, built and
running on debian-buster, configured:
--with-vendor=Terrence Enger
--with-jdk-home=/usr/lib/jvm/default-java
--enable-split-debug
--enable-gdb-index
--enable-ld=gold
--enable-option-checking=fatal
#--enable-dbgutil
--enable-debug
--without-system-postgresql
--without-myspell-dicts
--with-extra-buildid
--without-doxygen
--with-external-tar=/home/terry/lo_hacking/git/src
--without-package-format
I am removing keyword wantBacktrace and adding haveBacktrace.
Referenced Bugs:
https://bugs.documentfoundation.org/show_bug.cgi?id=102593
[Bug 102593] [META] Paste bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=133092
[Bug 133092] [META] Crash bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=138327
[Bug 138327] [META] sw_redlinehide regressions (track changes)
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131487] Words whose characters span multiple languages should not undergo spell checking
https://bugs.documentfoundation.org/show_bug.cgi?id=131487 --- Comment #21 from Mike Kaganski --- (In reply to Callegar from comment #20) > No, really it wouldn't. No, really it will. :D > We are talking of words that are "mixed-language". We are talking about *sequences of characters* that *may* represent some "valid" uses of words, but at the same time, may be simply a user error: a user could type "Inter" using Italian system input language (and the text will get Italian language on Windows), and then switch to English and finish "rnational". The end resul will be "Interrnational", with two "r" in the middle. If we disable spell checking on these words, it may go unnoticed (false negative). In current state, it will be marked - and even if such signal will be false-positive, generally false-positives are less harmful than false-negatives (the latter may result in released material being of inappropriate quality; the former are just unnecessarily drawing attention of the author). And no matter how hard will you try to create a smart heuristics, you will always have a potential to write two words with a dot, or dash, or slash, or apostrophe, ... without spaces, and your suggestion will disable spell check on them with possible false negatives. > This means that > there are currently two ways of preventing false positive spell-check errors > on these words and both are hackish and causing more problem than they solve > really introducing a danger of unnoticed spelling errors. The real way to fix such problem is making what you don't need highlighted as "None" language, explicitly disabling spell check. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139843] Crash swlo!SwNumRule::MakeNumString
https://bugs.documentfoundation.org/show_bug.cgi?id=139843 Michael Stahl (allotropia) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||6409 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138327] [META] sw_redlinehide regressions (track changes)
https://bugs.documentfoundation.org/show_bug.cgi?id=138327 Michael Stahl (allotropia) changed: What|Removed |Added Depends on|136409 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=136409 [Bug 136409] Writer crashes with large file (comment 5 is another bug) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136409] Writer crashes with large file (comment 5 is another bug)
https://bugs.documentfoundation.org/show_bug.cgi?id=136409 Michael Stahl (allotropia) changed: What|Removed |Added Keywords|bibisected, bisected, | |haveBacktrace, regression | Blocks|102593, 133092, 138327 | Status|NEW |UNCONFIRMED Summary|Writer crashes with large |Writer crashes with large |file (comment 5)|file (comment 5 is another ||bug) Ever confirmed|1 |0 See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||9843 --- Comment #10 from Michael Stahl (allotropia) --- the scenario of comment #5 and all the subsequent comments relating to it was separately filed as bug 139843 the freeze in the description sounds different, as if there's no specific steps known to cause the freeze. so i'll clean up the issue status here to make it less confusing and set this back to UNCONFIRMED. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102593 [Bug 102593] [META] Paste bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=133092 [Bug 133092] [META] Crash bugs https://bugs.documentfoundation.org/show_bug.cgi?id=138327 [Bug 138327] [META] sw_redlinehide regressions (track changes) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133092] [META] Crash bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=133092 Michael Stahl (allotropia) changed: What|Removed |Added Depends on|136409 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=136409 [Bug 136409] Writer crashes with large file (comment 5 is another bug) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102593] [META] Paste bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102593 Michael Stahl (allotropia) changed: What|Removed |Added Depends on|136409 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=136409 [Bug 136409] Writer crashes with large file (comment 5 is another bug) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145963] Slow typing in Writer with version 7.1 or above on Windows 11
https://bugs.documentfoundation.org/show_bug.cgi?id=145963 --- Comment #14 from Luboš Luňák --- (In reply to Telesto from comment #13) > Will try, but does it give enough information with an ordinary daily build? I think it would need (debug) symbols, which I don't know if are included with dailies. But if there's a VM then I can test it myself. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 130318] Use the actual cursor position to create ToC "for chapter" beginning at the current level (impacts odm master documents)
https://bugs.documentfoundation.org/show_bug.cgi?id=130318 --- Comment #29 from Andreas Heinisch --- WIP-Patch: https://gerrit.libreoffice.org/c/core/+/125727 Comments are highly appreciated :) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146228] i18langtag warns about converting locale en-IL:en
https://bugs.documentfoundation.org/show_bug.cgi?id=146228 Eike Rathke changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146228] i18langtag warns about converting locale en-IL:en
https://bugs.documentfoundation.org/show_bug.cgi?id=146228 --- Comment #2 from Eike Rathke --- (In reply to Eyal Rozenberg from comment #0) > with bAllowOnTheFlyID invalid 'en-IL:en' > > en-IL is a legitimate locale Yes, but en-IL:en is not, so where does it get that from? What does your locale environment in a shell commandline using the 'locale' command say? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146231] LO update tries and fails to load libnsspem.so
https://bugs.documentfoundation.org/show_bug.cgi?id=146231 --- Comment #1 from Eyal Rozenberg --- Created attachment 176931 --> https://bugs.documentfoundation.org/attachment.cgi?id=176931=edit Console output of LO update process -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131850] LibreOffice hangs if recent files are not accessible (e.g. remove samba, webdav, or nextcloud files)
https://bugs.documentfoundation.org/show_bug.cgi?id=131850 --- Comment #13 from Eyal Rozenberg --- Is this bug supposed to be about remote files only, or also about local files which have become inaccessible? If it's the former, than my dupe is not a dupe; and if it's the latter, then the title is a bit misleading. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sc/inc sc/qa sc/source
sc/inc/queryevaluator.hxx |3 +
sc/qa/unit/ucalc.cxx | 56 +
sc/source/core/data/dociter.cxx|3 +
sc/source/core/data/queryevaluator.cxx | 27 +++
4 files changed, 73 insertions(+), 16 deletions(-)
New commits:
commit 1ef08c9f140ca8bb77c865d772905c8fa19a9edf
Author: Luboš Luňák
AuthorDate: Mon Dec 13 21:35:01 2021 +0100
Commit: Eike Rathke
CommitDate: Tue Dec 14 20:52:23 2021 +0100
make sure text operations are not queried by (numeric) value
E.g. SC_CONTAINS is, according to isPartialTextMatchOp(), a text-only
operation, so query it as such and not as a numeric value. This
fixes/allows e.g. substring queries on dates.
Change-Id: I6c612d9934193828b7a7eabed92f2bfeb385e5a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126767
Tested-by: Jenkins
Reviewed-by: Eike Rathke
(cherry picked from commit 0d1971a8dc1f7ce24f67abcab4d6af9cf2b7b823)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126816
diff --git a/sc/inc/queryevaluator.hxx b/sc/inc/queryevaluator.hxx
index 44bf52ec3685..a1fd20111071 100644
--- a/sc/inc/queryevaluator.hxx
+++ b/sc/inc/queryevaluator.hxx
@@ -79,7 +79,8 @@ class ScQueryEvaluator
bool isRealWildOrRegExp(const ScQueryEntry& rEntry) const;
bool isTestWildOrRegExp(const ScQueryEntry& rEntry) const;
-static bool isQueryByValue(const ScQueryEntry::Item& rItem, const
ScRefCellValue& rCell);
+static bool isQueryByValue(const ScQueryEntry& rEntry, const
ScQueryEntry::Item& rItem,
+ const ScRefCellValue& rCell);
static bool isQueryByValueForCell(const ScRefCellValue& rCell);
static bool isQueryByString(const ScQueryEntry& rEntry, const
ScQueryEntry::Item& rItem,
const ScRefCellValue& rCell);
diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 9a80a42ad4b1..9cfe59ac27d3 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -176,6 +176,7 @@ public:
void testTdf137063();
void testTdf126342();
void testAdvancedFilter();
+void testDateFilterContains();
void testTdf98642();
void testMergedCells();
void testUpdateReference();
@@ -301,6 +302,7 @@ public:
CPPUNIT_TEST(testTdf137063);
CPPUNIT_TEST(testTdf126342);
CPPUNIT_TEST(testAdvancedFilter);
+CPPUNIT_TEST(testDateFilterContains);
CPPUNIT_TEST(testTdf98642);
CPPUNIT_TEST(testMergedCells);
CPPUNIT_TEST(testUpdateReference);
@@ -3902,6 +3904,60 @@ void Test::testAdvancedFilter()
m_pDoc->DeleteTab(0);
}
+void Test::testDateFilterContains()
+{
+m_pDoc->InsertTab(0, "Test");
+
+constexpr SCCOL nCols = 1;
+constexpr SCROW nRows = 5;
+m_pDoc->SetString(0, 0, 0, "Date");
+m_pDoc->SetString(0, 1, 0, "1/2/2021");
+m_pDoc->SetString(0, 2, 0, "2/1/1999");
+m_pDoc->SetString(0, 3, 0, "2/1/1997");
+m_pDoc->SetString(0, 4, 0, "3/3/2001");
+m_pDoc->SetString(0, 5, 0, "3/3/1996");
+
+// Set the fields as dates.
+SvNumberFormatter* pFormatter = m_pDoc->GetFormatTable();
+sal_uInt32 nFormat = pFormatter->GetFormatIndex(NF_DATE_DIN_YYMMDD,
LANGUAGE_ENGLISH_US);
+ScPatternAttr aNewAttrs(m_pDoc->GetPool());
+SfxItemSet& rSet = aNewAttrs.GetItemSet();
+rSet.Put(SfxUInt32Item(ATTR_VALUE_FORMAT, nFormat));
+m_pDoc->ApplyPatternAreaTab(0, 1, 0, 5, 0, aNewAttrs); // apply it to A1:A6
+
+ScDBData* pDBData = new ScDBData("NONAME", 0, 0, 0, nCols, nRows);
+m_pDoc->SetAnonymousDBData(0, std::unique_ptr(pDBData));
+
+pDBData->SetAutoFilter(true);
+ScRange aRange;
+pDBData->GetArea(aRange);
+m_pDoc->ApplyFlagsTab( aRange.aStart.Col(), aRange.aStart.Row(),
+ aRange.aEnd.Col(), aRange.aStart.Row(),
+ aRange.aStart.Tab(), ScMF::Auto);
+
+//create the query param
+ScQueryParam aParam;
+pDBData->GetQueryParam(aParam);
+ScQueryEntry& rEntry = aParam.GetEntry(0);
+rEntry.bDoQuery = true;
+rEntry.nField = 0;
+rEntry.eOp = SC_CONTAINS;
+rEntry.GetQueryItem().maString = m_pDoc->GetSharedStringPool().intern("2");
+pDBData->SetQueryParam(aParam);
+
+// perform the query.
+m_pDoc->Query(0, aParam, true);
+
+// Dates in rows 2-4 contain '2', row 5 shows 2001 only as 01, and row 6
doesn't contain it at all.
+CPPUNIT_ASSERT_MESSAGE("row 2 should be visible", !m_pDoc->RowHidden(1,
0));
+CPPUNIT_ASSERT_MESSAGE("row 3 should be visible", !m_pDoc->RowHidden(2,
0));
+CPPUNIT_ASSERT_MESSAGE("row 4 should be visible", !m_pDoc->RowHidden(3,
0));
+CPPUNIT_ASSERT_MESSAGE("row 5 should be hidden", m_pDoc->RowHidden(4, 0));
+CPPUNIT_ASSERT_MESSAGE("row 6 should be hidden", m_pDoc->RowHidden(5, 0));
+
+m_pDoc->DeleteTab(0);
+}
+
void Test::testTdf98642()
{
m_pDoc->InsertTab(0, "Sheet1");
diff --git a/sc/source/core/data/dociter.cxx
[Libreoffice-bugs] [Bug 138327] [META] sw_redlinehide regressions (track changes)
https://bugs.documentfoundation.org/show_bug.cgi?id=138327 Bug 138327 depends on bug 141175, which changed state. Bug 141175 Summary: CRASH: cutting content with redlines https://bugs.documentfoundation.org/show_bug.cgi?id=141175 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141175] CRASH: cutting content with redlines
https://bugs.documentfoundation.org/show_bug.cgi?id=141175 Michael Stahl (allotropia) changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED Assignee|libreoffice-b...@lists.free |michael.st...@allotropia.de |desktop.org | --- Comment #4 from Michael Stahl (allotropia) --- fixed on master -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136855] Crash correcting with spell checker with track & changes enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=136855 Michael Stahl (allotropia) changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED Assignee|libreoffice-b...@lists.free |michael.st...@allotropia.de |desktop.org | --- Comment #9 from Michael Stahl (allotropia) --- fixed on master -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146231] New: LO update tries and fails to load libnsspem.so
https://bugs.documentfoundation.org/show_bug.cgi?id=146231 Bug ID: 146231 Summary: LO update tries and fails to load libnsspem.so Product: LibreOffice Version: 7.4.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: eyalr...@gmx.com Blocks: 140879 A while after starting LO Writer, I get the contents of the attached text file on my console. I don't understand why multiple connections are made for checking for updates, but irrespective of that, there are several warnings saying: * WARNING: failed to load NSS PEM library libnsspem.so. Using OpenSSL PEM certificates will not work. Well: 1. It doesn't say _how_ it failed. Version mismatch? Missing file? Something else? 2. I'm assuming it's important to load this PEM library (otherwise there wouldn't be a warning). But - it doesn't even exist on my system. So why wasn't it installed with the LO packages? Or why is this not a package dependency of the LO .deb files? Anyway, after reading this, I installed the nss-plugin-pem Debian package. Perhaps that's what LO DEBs should depend on? Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=140879 [Bug 140879] [META] Console noise -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140879] [META] Console noise
https://bugs.documentfoundation.org/show_bug.cgi?id=140879 Eyal Rozenberg changed: What|Removed |Added Depends on||146231 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=146231 [Bug 146231] LO update tries and fails to load libnsspem.so -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141175] CRASH: cutting content with redlines
https://bugs.documentfoundation.org/show_bug.cgi?id=141175 --- Comment #3 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/19f2054c6063177d08c818c5b7eeba7ab9178249 tdf#141175 sw_redlinehide: fix crash in lcl_DeleteRedlines() It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141175] CRASH: cutting content with redlines
https://bugs.documentfoundation.org/show_bug.cgi?id=141175 Commit Notification changed: What|Removed |Added Whiteboard||target:7.4.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136855] Crash correcting with spell checker with track & changes enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=136855 --- Comment #8 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d16c5f47600d236e911ae50d0e58a3f2256f5a61 tdf#136855 sw: fix ReplaceRangeImpl() restoring of rPam It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136855] Crash correcting with spell checker with track & changes enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=136855 Commit Notification changed: What|Removed |Added Whiteboard||target:7.4.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: 2 commits - sw/source
sw/source/core/doc/DocumentContentOperationsManager.cxx |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
New commits:
commit 19f2054c6063177d08c818c5b7eeba7ab9178249
Author: Michael Stahl
AuthorDate: Tue Dec 14 19:34:36 2021 +0100
Commit: Michael Stahl
CommitDate: Tue Dec 14 20:43:35 2021 +0100
tdf#141175 sw_redlinehide: fix crash in lcl_DeleteRedlines()
The GetNext() returns itself if it's alone in the Ring.
(regression from 27aa4b16bf704d0246595750daf57b57ff2577b3)
Change-Id: Idf92ce5362c4a4acf1582f463fe7bafc8553b400
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126844
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/sw/source/core/doc/DocumentContentOperationsManager.cxx
b/sw/source/core/doc/DocumentContentOperationsManager.cxx
index 75a365908d53..3ddcf13c698e 100644
--- a/sw/source/core/doc/DocumentContentOperationsManager.cxx
+++ b/sw/source/core/doc/DocumentContentOperationsManager.cxx
@@ -408,7 +408,8 @@ namespace
*pDelPam->GetPoint(), nDelCount );
}
-if (pDelPam->GetNext() && *pDelPam->GetNext()->End()
== *pDelPam->Start())
+if (pDelPam->GetNext() != pDelPam.get()
+&& *pDelPam->GetNext()->End() == *pDelPam->Start())
{
*pDelPam->GetNext()->End() = *pDelPam->End();
pDelPam.reset(pDelPam->GetNext());
commit d16c5f47600d236e911ae50d0e58a3f2256f5a61
Author: Michael Stahl
AuthorDate: Tue Dec 14 17:32:28 2021 +0100
Commit: Michael Stahl
CommitDate: Tue Dec 14 20:43:25 2021 +0100
tdf#136855 sw: fix ReplaceRangeImpl() restoring of rPam
This broke in CWS swrefactormarks2 (commit
df6d312ca537402463e4eb0530f22b956600fc02) but for spell-checking the
ReplaceRange() wasn't used until commit
e1629c210ad78310e3d48c0756723134a27b89df.
Change-Id: I4a6256b65b89e21e9e87ff45d0c5e6c4577a5846
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126842
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/sw/source/core/doc/DocumentContentOperationsManager.cxx
b/sw/source/core/doc/DocumentContentOperationsManager.cxx
index ab3bd4ca9cd8..75a365908d53 100644
--- a/sw/source/core/doc/DocumentContentOperationsManager.cxx
+++ b/sw/source/core/doc/DocumentContentOperationsManager.cxx
@@ -4595,8 +4595,8 @@ bool DocumentContentOperationsManager::ReplaceRangeImpl(
SwPaM& rPam, const OUSt
m_rDoc.getIDocumentRedlineAccess().SetRedlineFlags( eOld );
*rPam.GetPoint() = pBkmk->GetMarkPos();
-if(pBkmk->IsExpanded())
-*rPam.GetMark() = pBkmk->GetOtherMarkPos();
+*rPam.GetMark() = pBkmk->IsExpanded() ?
pBkmk->GetOtherMarkPos() : pBkmk->GetMarkPos();
+
m_rDoc.getIDocumentMarkAccess()->deleteMark(pBkmk);
}
bJoinText = false;
[Libreoffice-bugs] [Bug 146230] New: OSL warns about no remaining height to distribute
https://bugs.documentfoundation.org/show_bug.cgi?id=146230 Bug ID: 146230 Summary: OSL warns about no remaining height to distribute Product: LibreOffice Version: 7.4.0.0 alpha0+ Master Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: eyalr...@gmx.com Blocks: 140879 When I start LO writer, I get the following console message: warn:legacy.osl:4695:4695:sfx2/source/sidebar/DeckLayouter.cxx:489: OSL_ASSERT: nRemainingHeightToDistribute==0 warn:legacy.osl:4695:4695:sfx2/source/sidebar/DeckLayouter.cxx:489: OSL_ASSERT: nRemainingHeightToDistribute==0 (yes, I get it twice) I don't know what height it's distributing, but - either it shouldn't distribute it or it should "have remaining height to distribute". Build info: Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 250e4886d85a7e131da76f181b3fa7be02d1a76d CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: en-IL (en_IL); UI: en-US Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=140879 [Bug 140879] [META] Console noise -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140879] [META] Console noise
https://bugs.documentfoundation.org/show_bug.cgi?id=140879 Eyal Rozenberg changed: What|Removed |Added Depends on||146230 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=146230 [Bug 146230] OSL warns about no remaining height to distribute -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140881] LO fails opening some WOFF and TTF files
https://bugs.documentfoundation.org/show_bug.cgi?id=140881 --- Comment #8 from Eyal Rozenberg --- Bug still manifests with: Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 250e4886d85a7e131da76f181b3fa7be02d1a76d CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: en-IL (en_IL); UI: en-US and the same errors. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146228] i18langtag warns about converting locale en-IL:en
https://bugs.documentfoundation.org/show_bug.cgi?id=146228 --- Comment #1 from Eyal Rozenberg --- Build info: Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 250e4886d85a7e131da76f181b3fa7be02d1a76d CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: en-IL (en_IL); UI: en-US -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146229] GDI gets a "4-char format" of 0xFFFF which it shouldn't
https://bugs.documentfoundation.org/show_bug.cgi?id=146229 --- Comment #1 from Eyal Rozenberg --- Build info: Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 250e4886d85a7e131da76f181b3fa7be02d1a76d CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: en-IL (en_IL); UI: en-US -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140879] [META] Console noise
https://bugs.documentfoundation.org/show_bug.cgi?id=140879 Eyal Rozenberg changed: What|Removed |Added Depends on||146229 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=146229 [Bug 146229] GDI gets a "4-char format" of 0x which it shouldn't -- You are receiving this mail because: You are the assignee for the bug.
