[Libreoffice-commits] core.git: sw/qa

[Stephan Bergmann (via logerrit)]

 dev/null|binary
 sw/qa/uitest/writer_tests2/ComplexGroupShapeTest.py |  127 
 2 files changed, 127 deletions(-)

New commits:
commit 793d4596d0facf5fc361fe2170bb73e01c60c9c7
Author: Stephan Bergmann 
AuthorDate: Thu Dec 16 22:35:40 2021 +0100
Commit: Stephan Bergmann 
CommitDate: Fri Dec 17 08:51:04 2021 +0100

Revert brittle UITest for now

UITest_writer_tests2

UITEST_TEST_NAME=ComplexGroupShapeTest.ComplexGroupShapeTest.test_ComplexGroupShape,
introduced with e5650de86072b9db586a4532b5239acda77598c4 "tdf#143574 sw:
textboxes in group shapes - part 3 take 2", is apparently brittle and often
fails with

> ERROR: test_ComplexGroupShape 
(ComplexGroupShapeTest.ComplexGroupShapeTest)
> --
> Traceback (most recent call last):
>   File 
"/home/tdf/lode/jenkins/workspace/lo_ubsan/sw/qa/uitest/writer_tests2/ComplexGroupShapeTest.py",
 line 96, in test_ComplexGroupShape
> 
self.assertEqual(True,document.getCurrentSelection().getByIndex(0).TextBox)
> AttributeError: TextBox

in (slow) ASan+UBSan builds like 

as well as in (fast) Flatpak `make check` test builds like
.

There is work going on at 
"[WIP]Sw: Replace PyUITests with CPPUnit ones" to fix that, so remove the 
test
for now until that fix is ready, to get the various failing builds unstuck.

Change-Id: I3579cedce35e1373c04f976a1a57ac98f1f33448
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126990
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/sw/qa/uitest/data/ComplexGroupShapeTest.odt 
b/sw/qa/uitest/data/ComplexGroupShapeTest.odt
deleted file mode 100644
index 8fe093203690..
Binary files a/sw/qa/uitest/data/ComplexGroupShapeTest.odt and /dev/null differ
diff --git a/sw/qa/uitest/writer_tests2/ComplexGroupShapeTest.py 
b/sw/qa/uitest/writer_tests2/ComplexGroupShapeTest.py
deleted file mode 100644
index 7e219d8d7976..
--- a/sw/qa/uitest/writer_tests2/ComplexGroupShapeTest.py
+++ /dev/null
@@ -1,127 +0,0 @@
-# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
-#
-# This file is part of the LibreOffice project.
-#
-# This Source Code Form is subject to the terms of the Mozilla Public
-# License, v. 2.0. If a copy of the MPL was not distributed with this
-# file, You can obtain one at http://mozilla.org/MPL/2.0/.
-#
-
-from uitest.framework import UITestCase
-from uitest.uihelper.common import get_state_as_dict
-from uitest.uihelper.common import select_pos
-from uitest.uihelper.common import get_url_for_data_file
-from libreoffice.uno.propertyvalue import mkPropertyValues
-import time
-
-class ComplexGroupShapeTest(UITestCase):
-def test_ComplexGroupShape(self):
-with 
self.ui_test.load_file(get_url_for_data_file("ComplexGroupShapeTest.odt")):
-xWriterDoc = self.xUITest.getTopFocusWindow()
-xWriterEdit = xWriterDoc.getChild("writer_edit")
-document = self.ui_test.get_component()
-
-# check the shape type
-self.assertEqual("com.sun.star.drawing.GroupShape", 
document.DrawPage.getByIndex(1).ShapeType)
-
-# select the shape
-self.xUITest.executeCommand(".uno:JumpToNextFrame")
-self.ui_test.wait_until_child_is_available('metricfield')
-
-# go inside the group
-self.xUITest.executeCommand(".uno:EnterGroup")
-
-# select a shape in the group
-xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE": 
"TAB"}))
-
-# add a textbox to this subshape
-self.xUITest.executeCommand(".uno:AddTextBox")
-
-# select the next shape in the group
-xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE": 
"TAB"}))
-
-# add a textbox to this subshape
-self.xUITest.executeCommand(".uno:AddTextBox")
-
-# leave the groupshape
-self.xUITest.executeCommand(".uno:LeaveGroup")
-
-# select the other shape
-self.xUITest.executeCommand(".uno:JumpToNextFrame")
-self.ui_test.wait_until_child_is_available('metricfield')
-
-# get the current selection
-ShapeCollection = document.getCurrentSelection()
-
-# extend the selection with the grouped shape
-ShapeCollection.add(document.DrawPage.getByIndex(0))
-ShapeCollection.add(document.DrawPage.getByIndex(1))
-
-# select these shapes
-document.getCurrentController().select(ShapeCollection)
-
-# do ungroup
-self.xUITest.executeCommand(".uno:FormatGroup")
-
-# deselect
-

[Libreoffice-commits] core.git: cppuhelper/source include/comphelper include/cppuhelper include/uno

[Miklos Vajna (via logerrit)]

 cppuhelper/source/weak.cxx  |2 --
 include/comphelper/interfacecontainer2.hxx  |1 -
 include/comphelper/interfacecontainer3.hxx  |1 -
 include/comphelper/interfacecontainer4.hxx  |1 -
 include/comphelper/multicontainer2.hxx  |1 -
 include/comphelper/multiinterfacecontainer3.hxx |1 -
 include/cppuhelper/interfacecontainer.h |1 -
 include/uno/environment.hxx |4 
 8 files changed, 12 deletions(-)

New commits:
commit f6e6255022ac796ea1a2f81f0d949d04c24a7f9d
Author: Miklos Vajna 
AuthorDate: Thu Dec 16 20:36:45 2021 +0100
Commit: Miklos Vajna 
CommitDate: Fri Dec 17 08:28:45 2021 +0100

Remove empty docpp doxygen comments around namespaces

I assume this was originally added to work around some broken doc
generator, but we don't enforce comments for namespaces today, so this
is no longer needed.

Change-Id: Ia2311658516be84b26ae69e09362af560d793a7f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126963
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/cppuhelper/source/weak.cxx b/cppuhelper/source/weak.cxx
index 657bf5d0c7da..0119123aed74 100644
--- a/cppuhelper/source/weak.cxx
+++ b/cppuhelper/source/weak.cxx
@@ -34,7 +34,6 @@
 using namespace osl;
 using namespace com::sun::star::uno;
 
-/** */ //for docpp
 namespace cppu
 {
 
@@ -332,7 +331,6 @@ void OWeakAggObject::setDelegator( const 
Reference & rDelegator )
 
 }
 
-/** */ //for docpp
 namespace com::sun::star::uno
 {
 
diff --git a/include/comphelper/interfacecontainer2.hxx 
b/include/comphelper/interfacecontainer2.hxx
index 286a5f2cb876..3df7c71d49d8 100644
--- a/include/comphelper/interfacecontainer2.hxx
+++ b/include/comphelper/interfacecontainer2.hxx
@@ -31,7 +31,6 @@
 namespace com::sun::star::uno { class XInterface; }
 namespace osl { class Mutex; }
 
-/** */ //for docpp
 namespace comphelper
 {
 
diff --git a/include/comphelper/interfacecontainer3.hxx 
b/include/comphelper/interfacecontainer3.hxx
index 5dc5fb66aa6d..27008f064e8c 100644
--- a/include/comphelper/interfacecontainer3.hxx
+++ b/include/comphelper/interfacecontainer3.hxx
@@ -34,7 +34,6 @@ namespace osl
 class Mutex;
 }
 
-/** */ //for docpp
 namespace comphelper
 {
 template  class OInterfaceContainerHelper3;
diff --git a/include/comphelper/interfacecontainer4.hxx 
b/include/comphelper/interfacecontainer4.hxx
index c81aa6b3afbd..04fafeadc0fd 100644
--- a/include/comphelper/interfacecontainer4.hxx
+++ b/include/comphelper/interfacecontainer4.hxx
@@ -31,7 +31,6 @@ namespace com::sun::star::uno
 class XInterface;
 }
 
-/** */ //for docpp
 namespace comphelper
 {
 template  class OInterfaceContainerHelper4;
diff --git a/include/comphelper/multicontainer2.hxx 
b/include/comphelper/multicontainer2.hxx
index d0963fa1d89c..91875b6689f3 100644
--- a/include/comphelper/multicontainer2.hxx
+++ b/include/comphelper/multicontainer2.hxx
@@ -34,7 +34,6 @@ namespace com::sun::star::uno
 class XInterface;
 }
 
-/** */ //for docpp
 namespace comphelper
 {
 /** This is a copy of cppu::OMultiTypeInterfaceContainerHelper2 in 
include/cppuhelper/interfacecontainer.h,
diff --git a/include/comphelper/multiinterfacecontainer3.hxx 
b/include/comphelper/multiinterfacecontainer3.hxx
index d11684f417f7..87199885e71e 100644
--- a/include/comphelper/multiinterfacecontainer3.hxx
+++ b/include/comphelper/multiinterfacecontainer3.hxx
@@ -30,7 +30,6 @@ namespace osl
 class Mutex;
 }
 
-/** */ //for docpp
 namespace comphelper
 {
 /**
diff --git a/include/cppuhelper/interfacecontainer.h 
b/include/cppuhelper/interfacecontainer.h
index 520998d4cd92..d901b2db3ccc 100644
--- a/include/cppuhelper/interfacecontainer.h
+++ b/include/cppuhelper/interfacecontainer.h
@@ -41,7 +41,6 @@
 
 namespace com { namespace sun { namespace star { namespace uno { class 
XInterface; } } } }
 
-/** */ //for docpp
 namespace cppu
 {
 
diff --git a/include/uno/environment.hxx b/include/uno/environment.hxx
index b7a31e991c8c..8a26e268d64d 100644
--- a/include/uno/environment.hxx
+++ b/include/uno/environment.hxx
@@ -33,16 +33,12 @@
 
 #include "uno/lbnames.h"
 
-/** */ //for docpp
 namespace com
 {
-/** */ //for docpp
 namespace sun
 {
-/** */ //for docpp
 namespace star
 {
-/** */ //for docpp
 namespace uno
 {
 

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - include/oox oox/qa oox/source

[Miklos Vajna (via logerrit)]

 include/oox/vml/vmlshape.hxx   |6 ++
 oox/qa/unit/data/watermark.docx|binary
 oox/qa/unit/vml.cxx|   22 ++
 oox/source/vml/vmlshape.cxx|7 +++
 oox/source/vml/vmlshapecontext.cxx |   28 
 5 files changed, 63 insertions(+)

New commits:
commit e13f25f22e2ae6094d3fb3fdd27c2256fe7acf89
Author: Miklos Vajna 
AuthorDate: Thu Dec 16 10:16:02 2021 +0100
Commit: Miklos Vajna 
CommitDate: Fri Dec 17 08:28:26 2021 +0100

VML import: handle 

Map it to (the UNO API of) GraphicDrawMode::Watermark, similar to what
the binary import does in SvxMSDffManager::ImportGraphic() and how the
drawingML import does it in
oox::drawingml::GraphicProperties::pushToPropMap().

On export, the drawingML export is used, and that already maps
GraphicDrawMode::Watermark to .

Change-Id: I33986a03bf3d3863da5c5b1f0a2e0da0fa595c9e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126908
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins
(cherry picked from commit 90556b6df0f6378fb60d7dee18b2f5d275ece530)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126942

diff --git a/include/oox/vml/vmlshape.hxx b/include/oox/vml/vmlshape.hxx
index 19c82384efcd..7a17bda51ccd 100644
--- a/include/oox/vml/vmlshape.hxx
+++ b/include/oox/vml/vmlshape.hxx
@@ -113,6 +113,12 @@ struct ShapeTypeModel
 OptValue moCropTop; ///< Specifies how much to crop the image 
from the top down as a fraction of picture size.
 OUString maLayoutFlowAlt; ///< Specifies the alternate layout flow for 
text in textboxes.
 
+/// An adjustment for the intensity of all colors, i.e. contrast, on a 
0..0x1 scale.
+sal_Int32 mnGain = 0x1;
+
+/// The image brightness, on a 0..0x1 scale.
+sal_Int16 mnBlacklevel = 0;
+
 explicitShapeTypeModel();
 
 voidassignUsed( const ShapeTypeModel& rSource );
diff --git a/oox/qa/unit/data/watermark.docx b/oox/qa/unit/data/watermark.docx
new file mode 100644
index ..c9eacff9a643
Binary files /dev/null and b/oox/qa/unit/data/watermark.docx differ
diff --git a/oox/qa/unit/vml.cxx b/oox/qa/unit/vml.cxx
index 6d8a5cf93912..9dcaaef83cc4 100644
--- a/oox/qa/unit/vml.cxx
+++ b/oox/qa/unit/vml.cxx
@@ -23,6 +23,7 @@
 #include 
 #include 
 #include 
+#include 
 
 using namespace ::com::sun::star;
 
@@ -214,6 +215,27 @@ CPPUNIT_TEST_FIXTURE(OoxVmlTest, testGraphicStroke)
 CPPUNIT_ASSERT_EQUAL(drawing::LineStyle_SOLID, eLineStyle);
 }
 
+CPPUNIT_TEST_FIXTURE(OoxVmlTest, testWatermark)
+{
+// Given a document with a picture watermark, and the "washout" checkbox 
is ticked on the Word
+// UI:
+// When loading that document:
+load(u"watermark.docx");
+
+// Then make sure the watermark effect is not lost on import:
+uno::Reference 
xDrawPagesSupplier(getComponent(), uno::UNO_QUERY);
+uno::Reference 
xDrawPage(xDrawPagesSupplier->getDrawPages()->getByIndex(0),
+ uno::UNO_QUERY);
+uno::Reference xShape(xDrawPage->getByIndex(0), 
uno::UNO_QUERY);
+drawing::ColorMode eMode{};
+xShape->getPropertyValue("GraphicColorMode") >>= eMode;
+// Without the accompanying fix in place, this test would have failed with:
+// - Expected: 3
+// - Actual  : 0
+// i.e. the color mode was STANDARD, not WATERMARK.
+CPPUNIT_ASSERT_EQUAL(drawing::ColorMode_WATERMARK, eMode);
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/oox/source/vml/vmlshape.cxx b/oox/source/vml/vmlshape.cxx
index 81abe64e5322..38b632be843b 100644
--- a/oox/source/vml/vmlshape.cxx
+++ b/oox/source/vml/vmlshape.cxx
@@ -47,6 +47,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -991,6 +992,12 @@ Reference< XShape > SimpleShape::createPictureObject(const 
Reference< XShapes >&
 
 aPropSet.setProperty(PROP_GraphicCrop, aGraphicCrop);
 }
+
+if (maTypeModel.mnGain == -70 && maTypeModel.mnBlacklevel == 70)
+{
+// Map MSO 'washout' to our watermark colormode.
+aPropSet.setProperty(PROP_GraphicColorMode, 
uno::makeAny(drawing::ColorMode_WATERMARK));
+}
 }
 return xShape;
 }
diff --git a/oox/source/vml/vmlshapecontext.cxx 
b/oox/source/vml/vmlshapecontext.cxx
index e9284747774b..4ed3f83fd076 100644
--- a/oox/source/vml/vmlshapecontext.cxx
+++ b/oox/source/vml/vmlshapecontext.cxx
@@ -395,6 +395,34 @@ ContextHandlerRef ShapeTypeContext::onCreateContext( 
sal_Int32 nElement, const A
 mrTypeModel.moCropLeft = rAttribs.getString(XML_cropleft);
 mrTypeModel.moCropRight = rAttribs.getString(XML_cropright);
 mrTypeModel.moCropTop = rAttribs.getString(XML_croptop);
+
+// Gain / contrast.
+OptValue oGain = rAttribs.getString(XML_gain);
+sal_Int32 

[Libreoffice-bugs] [Bug 145773] Section endnotes not collected at end of section

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145773

--- Comment #4 from David  ---
@szucs.attila3, xiscofauli
Section endnotes collected at end of section in newly created files are still
not fixed by https://gerrit.libreoffice.org/c/core/+/125442.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146275] FORMATTING: Applying paragraph style to a table cell, changes the style of the last paragraph in the upper cell

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146275

Rainer Bielefeld Retired  changed:

   What|Removed |Added

 CC||LibreOffice@bielefeldundbus
   ||s.de

--- Comment #1 from Rainer Bielefeld Retired  
---
NOT reproducible with  Installation of Version 7.2.4.1 (x64) / LibreOffice 
Build  27d75539669ac387bb498e35313b970b7fe9c4f9
CPU threads: 12; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL:
win; Locale: de-DE (de_DE); UI: de-DE; Calc: threaded;  Elementary Theme; My
normal User Profile. My STR

1. Open reporter's sample document
2. Click into cell B2 left from "ddd"
3. Menu ˋFormat → Paragraph → Outline & List → Apply List Style 'Bullet' →
[ok]ˊ 
   » Expected: only ddd-line gets bullet list style
 Actual:as expected 

Solved for 7.2? 
Different STR required to reproduce?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146278] How To Get My Money Back From The Cash App To Your Wallet?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146278

himajin100...@gmail.com changed:

   What|Removed |Added

  Component|LibreOffice |deletionRequest

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146278] How To Get My Money Back From The Cash App To Your Wallet?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146278

himajin100...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID
  Component|Android Viewer  |LibreOffice
Version|3.3.0 release   |unspecified

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: include/toolkit toolkit/source

[Noel Grandin (via logerrit)]

 include/toolkit/awt/vclxmenu.hxx |5 --
 toolkit/source/awt/vclxmenu.cxx  |   92 +++
 2 files changed, 48 insertions(+), 49 deletions(-)

New commits:
commit b37f9fbf05e16eb58eae40c6d900a4b9da2972db
Author: Noel Grandin 
AuthorDate: Thu Dec 16 19:24:42 2021 +0200
Commit: Noel Grandin 
CommitDate: Fri Dec 17 07:27:19 2021 +0100

osl::Mutex->std::mutex in VCLXMenu

Change-Id: I93883f5cd8f5f83f33eded87d995f95dbfd7989b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126989
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/include/toolkit/awt/vclxmenu.hxx b/include/toolkit/awt/vclxmenu.hxx
index b77c4d65124e..5c848975d837 100644
--- a/include/toolkit/awt/vclxmenu.hxx
+++ b/include/toolkit/awt/vclxmenu.hxx
@@ -32,7 +32,7 @@
 
 #include 
 #include 
-#include 
+#include 
 
 #include 
 #include 
@@ -59,14 +59,13 @@ class TOOLKIT_DLLPUBLIC VCLXMenu :  public 
css::awt::XMenuBar,
 public ::cppu::OWeakObject
 {
 private:
-::osl::MutexmaMutex;
+std::mutex  maMutex;
 VclPtrmpMenu;
 MenuListenerMultiplexer maMenuListeners;
 PopupMenuRefListmaPopupMenuRefs;
 sal_Int16   mnDefaultItem;
 
 protected:
-::osl::Mutex&   GetMutex() { return maMutex; }
 
 DECL_DLLPRIVATE_LINK( MenuEventListener, VclMenuEvent&, void );
 
diff --git a/toolkit/source/awt/vclxmenu.cxx b/toolkit/source/awt/vclxmenu.cxx
index 56b0bb49a6ca..01e275aacf82 100644
--- a/toolkit/source/awt/vclxmenu.cxx
+++ b/toolkit/source/awt/vclxmenu.cxx
@@ -167,9 +167,9 @@ IMPL_LINK( VCLXMenu, MenuEventListener, VclMenuEvent&, 
rMenuEvent, void )
 
 OUString SAL_CALL VCLXMenu::getImplementationName(  )
 {
-::osl::ResettableGuard < ::osl::Mutex > aGuard( GetMutex() );
+std::unique_lock aGuard( maMutex );
 const bool bIsPopupMenu = IsPopupMenu();
-aGuard.clear();
+aGuard.unlock();
 
 OUString implName( "stardiv.Toolkit." );
 if ( bIsPopupMenu )
@@ -182,9 +182,9 @@ OUString SAL_CALL VCLXMenu::getImplementationName(  )
 
 css::uno::Sequence< OUString > SAL_CALL VCLXMenu::getSupportedServiceNames(  )
 {
-::osl::ResettableGuard < ::osl::Mutex > aGuard( GetMutex() );
+std::unique_lock aGuard( maMutex );
 const bool bIsPopupMenu = IsPopupMenu();
-aGuard.clear();
+aGuard.unlock();
 
 if ( bIsPopupMenu )
 return css::uno::Sequence{
@@ -204,9 +204,9 @@ sal_Bool SAL_CALL VCLXMenu::supportsService(const OUString& 
rServiceName )
 css::uno::Any VCLXMenu::queryInterface(
 const css::uno::Type & rType )
 {
-::osl::ResettableGuard < ::osl::Mutex > aGuard( GetMutex() );
+std::unique_lock aGuard( maMutex );
 const bool bIsPopupMenu = IsPopupMenu();
-aGuard.clear();
+aGuard.unlock();
 
 css::uno::Any aRet;
 
@@ -233,9 +233,9 @@ UNO3_GETIMPLEMENTATION_IMPL( VCLXMenu );
 
 css::uno::Sequence< css::uno::Type > VCLXMenu::getTypes()
 {
-::osl::ResettableGuard < ::osl::Mutex > aGuard( GetMutex() );
+std::unique_lock aGuard( maMutex );
 const bool bIsPopupMenu = IsPopupMenu();
-aGuard.clear();
+aGuard.unlock();
 
 if ( bIsPopupMenu )
 {
@@ -264,7 +264,7 @@ css::uno::Sequence< sal_Int8 > 
VCLXMenu::getImplementationId()
 void VCLXMenu::addMenuListener(
 const css::uno::Reference< css::awt::XMenuListener >& rxListener )
 {
-::osl::Guard< ::osl::Mutex > aGuard( GetMutex() );
+std::unique_lock aGuard( maMutex );
 
 maMenuListeners.addInterface( rxListener );
 }
@@ -272,7 +272,7 @@ void VCLXMenu::addMenuListener(
 void VCLXMenu::removeMenuListener(
 const css::uno::Reference< css::awt::XMenuListener >& rxListener )
 {
-::osl::Guard< ::osl::Mutex > aGuard( GetMutex() );
+std::unique_lock aGuard( maMutex );
 
 maMenuListeners.removeInterface( rxListener );
 }
@@ -284,7 +284,7 @@ void VCLXMenu::insertItem(
 sal_Int16 nPos )
 {
 SolarMutexGuard aSolarGuard;
-::osl::Guard< ::osl::Mutex > aGuard( GetMutex() );
+std::unique_lock aGuard( maMutex );
 
 if ( mpMenu )
 mpMenu->InsertItem(nItemId, aText, 
static_cast(nItemStyle), OString(), nPos);
@@ -295,7 +295,7 @@ void VCLXMenu::removeItem(
 sal_Int16 nCount )
 {
 SolarMutexGuard aSolarGuard;
-::osl::Guard< ::osl::Mutex > aGuard( GetMutex() );
+std::unique_lock aGuard( maMutex );
 
 if (!mpMenu)
 return;
@@ -313,7 +313,7 @@ void VCLXMenu::removeItem(
 sal_Int16 VCLXMenu::getItemCount(  )
 {
 SolarMutexGuard aSolarGuard;
-::osl::Guard< ::osl::Mutex > aGuard( GetMutex() );
+std::unique_lock aGuard( maMutex );
 
 return mpMenu ? mpMenu->GetItemCount() : 0;
 }
@@ -322,7 +322,7 @@ sal_Int16 VCLXMenu::getItemId(
 sal_Int16 nPos )
 {
 SolarMutexGuard aSolarGuard;
-::osl::Guard< ::osl::Mutex > aGuard( GetMutex() );
+std::unique_lock aGuard( maMutex );
 
 return mpMenu ? mpMenu->GetItemId( nPos ) : 0;
 }
@@ -331,7 

[Libreoffice-commits] core.git: 2 commits - chart2/source include/toolkit toolkit/source

[Noel Grandin (via logerrit)]

 chart2/source/controller/main/CommandDispatch.cxx |8 +++-
 chart2/source/controller/main/CommandDispatch.hxx |4 ++--
 include/toolkit/awt/vclxfont.hxx  |5 ++---
 toolkit/source/awt/vclxfont.cxx   |   14 +++---
 4 files changed, 14 insertions(+), 17 deletions(-)

New commits:
commit 9564433292aa6a5a79c6c619a05434973bd4b7b3
Author: Noel Grandin 
AuthorDate: Thu Dec 16 19:14:14 2021 +0200
Commit: Noel Grandin 
CommitDate: Fri Dec 17 07:27:02 2021 +0100

osl::Mutex->std::mutex in VCLXFont

Change-Id: I01fbf0c94996412129101a47171aa9f3a6a78ffc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126988
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/include/toolkit/awt/vclxfont.hxx b/include/toolkit/awt/vclxfont.hxx
index ea7c3556c47a..efad4b590da7 100644
--- a/include/toolkit/awt/vclxfont.hxx
+++ b/include/toolkit/awt/vclxfont.hxx
@@ -26,7 +26,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
 
 namespace com::sun::star::awt { class XDevice; }
@@ -41,14 +41,13 @@ class TOOLKIT_DLLPUBLIC VCLXFont final :
 css::awt::XFont2,
 css::lang::XUnoTunnel>
 {
-::osl::MutexmaMutex;
+std::mutexmaMutex;
 css::uno::Reference< css::awt::XDevice> mxDevice;
 vcl::Font   maFont;
 std::unique_ptr
 mpFontMetric;
 
 boolImplAssertValidFontMetric();
-::osl::Mutex&   GetMutex() { return maMutex; }
 
 public:
 VCLXFont();
diff --git a/toolkit/source/awt/vclxfont.cxx b/toolkit/source/awt/vclxfont.cxx
index 66e5ba2bdc40..b524de4d1a5d 100644
--- a/toolkit/source/awt/vclxfont.cxx
+++ b/toolkit/source/awt/vclxfont.cxx
@@ -72,7 +72,7 @@ UNO3_GETIMPLEMENTATION_IMPL( VCLXFont );
 
 css::awt::FontDescriptor VCLXFont::getFontDescriptor(  )
 {
-::osl::Guard< ::osl::Mutex > aGuard( GetMutex() );
+std::unique_lock aGuard( maMutex );
 
 return VCLUnoHelper::CreateFontDescriptor( maFont );
 
@@ -80,7 +80,7 @@ css::awt::FontDescriptor VCLXFont::getFontDescriptor(  )
 
 css::awt::SimpleFontMetric VCLXFont::getFontMetric(  )
 {
-::osl::Guard< ::osl::Mutex > aGuard( GetMutex() );
+std::unique_lock aGuard( maMutex );
 
 css::awt::SimpleFontMetric aFM;
 if ( ImplAssertValidFontMetric() )
@@ -90,7 +90,7 @@ css::awt::SimpleFontMetric VCLXFont::getFontMetric(  )
 
 sal_Int16 VCLXFont::getCharWidth( sal_Unicode c )
 {
-::osl::Guard< ::osl::Mutex > aGuard( GetMutex() );
+std::unique_lock aGuard( maMutex );
 
 sal_Int16 nRet = -1;
 OutputDevice* pOutDev = VCLUnoHelper::GetOutputDevice( mxDevice );
@@ -109,7 +109,7 @@ sal_Int16 VCLXFont::getCharWidth( sal_Unicode c )
 
 css::uno::Sequence< sal_Int16 > VCLXFont::getCharWidths( sal_Unicode nFirst, 
sal_Unicode nLast )
 {
-::osl::Guard< ::osl::Mutex > aGuard( GetMutex() );
+std::unique_lock aGuard( maMutex );
 
 css::uno::Sequence aSeq;
 OutputDevice* pOutDev = VCLUnoHelper::GetOutputDevice( mxDevice );
@@ -134,7 +134,7 @@ css::uno::Sequence< sal_Int16 > VCLXFont::getCharWidths( 
sal_Unicode nFirst, sal
 
 sal_Int32 VCLXFont::getStringWidth( const OUString& str )
 {
-::osl::Guard< ::osl::Mutex > aGuard( GetMutex() );
+std::unique_lock aGuard( maMutex );
 
 sal_Int32 nRet = -1;
 OutputDevice* pOutDev = VCLUnoHelper::GetOutputDevice( mxDevice );
@@ -150,7 +150,7 @@ sal_Int32 VCLXFont::getStringWidth( const OUString& str )
 
 sal_Int32 VCLXFont::getStringWidthArray( const OUString& str, 
css::uno::Sequence< sal_Int32 >& rDXArray )
 {
-::osl::Guard< ::osl::Mutex > aGuard( GetMutex() );
+std::unique_lock aGuard( maMutex );
 
 sal_Int32 nRet = -1;
 OutputDevice* pOutDev = VCLUnoHelper::GetOutputDevice( mxDevice );
@@ -175,7 +175,7 @@ void VCLXFont::getKernPairs( css::uno::Sequence< 
sal_Unicode >& /*rnChars1*/, cs
 // css::awt::XFont2
 sal_Bool VCLXFont::hasGlyphs( const OUString& aText )
 {
-::osl::Guard< ::osl::Mutex > aGuard( GetMutex() );
+std::unique_lock aGuard( maMutex );
 SolarMutexGuard aSolarGuard;
 
 OutputDevice* pOutDev = VCLUnoHelper::GetOutputDevice( mxDevice );
commit bcab8f876746434979e5b4538c268ae700aba278
Author: Noel Grandin 
AuthorDate: Thu Dec 16 17:55:31 2021 +0200
Commit: Noel Grandin 
CommitDate: Fri Dec 17 07:26:43 2021 +0100

use OInterfaceContainerHelper3 in CommandDispatch

Change-Id: Ib193947279c4fe1862559d681278a3a73c8e8249
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126987
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/chart2/source/controller/main/CommandDispatch.cxx 
b/chart2/source/controller/main/CommandDispatch.cxx
index ed6370a5228b..9a16fbb73b8b 100644
--- a/chart2/source/controller/main/CommandDispatch.cxx
+++ b/chart2/source/controller/main/CommandDispatch.cxx
@@ -69,7 +69,7 @@ void SAL_CALL CommandDispatch::addStatusListener( const 
Reference< 

[Libreoffice-commits] core.git: comphelper/source dbaccess/source forms/source linguistic/source svx/source sw/source ucbhelper/source ucb/source

[Noel Grandin (via logerrit)]

 comphelper/source/eventattachermgr/eventattachermgr.cxx |4 -
 dbaccess/source/core/dataaccess/ContentHelper.cxx   |9 --
 dbaccess/source/core/dataaccess/bookmarkcontainer.cxx   |   12 ---
 dbaccess/source/ui/browser/brwctrlr.cxx |8 --
 dbaccess/source/ui/browser/exsrcbrw.cxx |4 -
 dbaccess/source/ui/browser/formadapter.cxx  |   26 ++-
 dbaccess/source/ui/browser/sbagrid.cxx  |4 -
 dbaccess/source/ui/browser/sbamultiplex.cxx |   56 
 forms/source/component/DatabaseForm.cxx |   10 --
 forms/source/component/errorbroadcaster.cxx |7 --
 linguistic/source/lngopt.cxx|8 --
 svx/source/fmcomp/gridcell.cxx  |9 --
 sw/source/core/unocore/unochart.cxx |4 -
 sw/source/uibase/dochdl/swdtflvr.cxx|5 -
 sw/source/uibase/uno/unomailmerge.cxx   |6 -
 ucb/source/cacher/contentresultsetwrapper.cxx   |   24 +-
 ucb/source/core/ucbstore.cxx|   21 --
 ucb/source/sorter/sortresult.cxx|   16 
 ucbhelper/source/provider/contenthelper.cxx |8 --
 19 files changed, 50 insertions(+), 191 deletions(-)

New commits:
commit 7994791e0a3681d46d8b257f09422b04deeae41c
Author: Noel Grandin 
AuthorDate: Thu Dec 16 16:08:48 2021 +0200
Commit: Noel Grandin 
CommitDate: Fri Dec 17 07:26:25 2021 +0100

use more OInterfaceContainer3::notifyEach

Change-Id: I0dd6e9f1514792e73a31e81896d09c27c1912318
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126966
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/comphelper/source/eventattachermgr/eventattachermgr.cxx 
b/comphelper/source/eventattachermgr/eventattachermgr.cxx
index 35e90a8379b0..4c7be22c2bb1 100644
--- a/comphelper/source/eventattachermgr/eventattachermgr.cxx
+++ b/comphelper/source/eventattachermgr/eventattachermgr.cxx
@@ -179,9 +179,7 @@ void SAL_CALL AttacherAllListener_Impl::firing(const 
AllEventObject& Event)
 aScriptEvent.ScriptCode = aScriptCode;
 
 // Iterate over all listeners and pass events.
-OInterfaceIteratorHelper3 aIt( mxManager->aScriptListeners );
-while( aIt.hasMoreElements() )
-aIt.next()->firing( aScriptEvent );
+mxManager->aScriptListeners.notifyEach( ::firing, 
aScriptEvent );
 }
 
 
diff --git a/dbaccess/source/core/dataaccess/ContentHelper.cxx 
b/dbaccess/source/core/dataaccess/ContentHelper.cxx
index beb75c3d40dd..cefc2443d2c2 100644
--- a/dbaccess/source/core/dataaccess/ContentHelper.cxx
+++ b/dbaccess/source/core/dataaccess/ContentHelper.cxx
@@ -505,14 +505,7 @@ void OContentHelper::notifyPropertiesChange( const 
Sequence< PropertyChangeEvent
 // First, notify listeners interested in changes of every property.
 comphelper::OInterfaceContainerHelper3* 
pAllPropsContainer = m_aPropertyChangeListeners.getContainer( OUString() );
 if ( pAllPropsContainer )
-{
-comphelper::OInterfaceIteratorHelper3 aIter( *pAllPropsContainer );
-while ( aIter.hasMoreElements() )
-{
-// Propagate event.
-aIter.next()->propertiesChange( evt );
-}
-}
+pAllPropsContainer->notifyEach( 
::propertiesChange, evt );
 
 typedef std::map< XPropertiesChangeListener*, Sequence< 
PropertyChangeEvent > > PropertiesEventListenerMap;
 PropertiesEventListenerMap aListeners;
diff --git a/dbaccess/source/core/dataaccess/bookmarkcontainer.cxx 
b/dbaccess/source/core/dataaccess/bookmarkcontainer.cxx
index bee7a0cbb7b9..24feb1371ed0 100644
--- a/dbaccess/source/core/dataaccess/bookmarkcontainer.cxx
+++ b/dbaccess/source/core/dataaccess/bookmarkcontainer.cxx
@@ -97,9 +97,7 @@ void SAL_CALL OBookmarkContainer::insertByName( const 
OUString& _rName, const An
 if (m_aContainerListeners.getLength())
 {
 ContainerEvent aEvent(*this, makeAny(_rName), makeAny(sNewLink), 
Any());
-OInterfaceIteratorHelper3 aListenerIterator(m_aContainerListeners);
-while (aListenerIterator.hasMoreElements())
-aListenerIterator.next()->elementInserted(aEvent);
+m_aContainerListeners.notifyEach( 
::elementInserted, aEvent );
 }
 }
 
@@ -127,9 +125,7 @@ void SAL_CALL OBookmarkContainer::removeByName( const 
OUString& _rName )
 if (m_aContainerListeners.getLength())
 {
 ContainerEvent aEvent(*this, makeAny(_rName), makeAny(sOldBookmark), 
Any());
-OInterfaceIteratorHelper3 aListenerIterator(m_aContainerListeners);
-while (aListenerIterator.hasMoreElements())
-aListenerIterator.next()->elementRemoved(aEvent);
+m_aContainerListeners.notifyEach( ::elementRemoved, 
aEvent );
 }
 }
 
@@ -162,9 +158,7 @@ void SAL_CALL OBookmarkContainer::replaceByName( const 
OUString& _rName, const A
 if 

[Libreoffice-commits] core.git: svx/source

[Noel Grandin (via logerrit)]

 svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx |   33 ++-
 1 file changed, 15 insertions(+), 18 deletions(-)

New commits:
commit 134425eb98147d197833cb4ef7bb4d8c3d7fd2bc
Author: Noel Grandin 
AuthorDate: Thu Dec 16 15:16:46 2021 +0200
Commit: Noel Grandin 
CommitDate: Fri Dec 17 07:26:05 2021 +0100

simplify ViewObjectContactOfUnoControl_Impl::getUnoObject

Change-Id: I7dd9758180c629fc0de4e59ffef7d33e62d43dcb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126965
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx 
b/svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx
index 4c0f54d93b1f..5ca5a32d2f34 100644
--- a/svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx
+++ b/svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx
@@ -551,7 +551,7 @@ namespace sdr::contact {
 @precond
 We're not disposed.
 */
-boolgetUnoObject( SdrUnoObj*& _out_rpObject ) const;
+SdrUnoObj*getUnoObject() const;
 
 /** ensures that we have an ->XControl
 
@@ -904,18 +904,15 @@ namespace sdr::contact {
 }
 
 
-bool ViewObjectContactOfUnoControl_Impl::getUnoObject( SdrUnoObj*& 
_out_rpObject ) const
+SdrUnoObj* ViewObjectContactOfUnoControl_Impl::getUnoObject() const
 {
 OSL_PRECOND( !impl_isDisposed_nofail(), 
"ViewObjectContactOfUnoControl_Impl::getUnoObject: already disposed()" );
 if ( impl_isDisposed_nofail() )
-_out_rpObject = nullptr;
-else
-{
-_out_rpObject = dynamic_cast< SdrUnoObj* >( 
m_pAntiImpl->GetViewContact().TryToGetSdrObject() );
-DBG_ASSERT( _out_rpObject || 
!m_pAntiImpl->GetViewContact().TryToGetSdrObject(),
-"ViewObjectContactOfUnoControl_Impl::getUnoObject: invalid 
SdrObject!" );
-}
-return ( _out_rpObject != nullptr );
+return nullptr;
+auto pRet = dynamic_cast< SdrUnoObj* >( 
m_pAntiImpl->GetViewContact().TryToGetSdrObject() );
+DBG_ASSERT( pRet || !m_pAntiImpl->GetViewContact().TryToGetSdrObject(),
+"ViewObjectContactOfUnoControl_Impl::getUnoObject: invalid 
SdrObject!" );
+return pRet;
 }
 
 
@@ -927,8 +924,8 @@ namespace sdr::contact {
 
 try
 {
-SdrUnoObj* pUnoObject( nullptr );
-if ( getUnoObject( pUnoObject ) )
+SdrUnoObj* pUnoObject = getUnoObject();
+if ( pUnoObject )
 {
 const tools::Rectangle aRect( pUnoObject->GetLogicRect() );
 UnoControlContactHelper::adjustControlGeometry_throw( 
m_aControl, aRect, _rViewTransformation, m_aZoomLevelNormalization );
@@ -1033,8 +1030,8 @@ namespace sdr::contact {
 UnoControlContactHelper::disposeAndClearControl_nothrow( 
m_aControl );
 }
 
-SdrUnoObj* pUnoObject( nullptr );
-if ( !getUnoObject( pUnoObject ) )
+SdrUnoObj* pUnoObject = getUnoObject();
+if ( !pUnoObject )
 return false;
 
 ControlHolder aControl;
@@ -1159,8 +1156,8 @@ namespace sdr::contact {
 if ( !impl_getPageView_nothrow( pPageView ) )
 return;
 
-SdrUnoObj* pUnoObject( nullptr );
-if ( !getUnoObject( pUnoObject ) )
+SdrUnoObj* pUnoObject = getUnoObject();
+if ( !pUnoObject )
 return;
 
 SdrPageViewAccess aPVAccess( *pPageView );
@@ -1273,8 +1270,8 @@ namespace sdr::contact {
 
 bool ViewObjectContactOfUnoControl_Impl::isPrintableControl() const
 {
-SdrUnoObj* pUnoObject( nullptr );
-if ( !getUnoObject( pUnoObject ) )
+SdrUnoObj* pUnoObject = getUnoObject();
+if ( !pUnoObject )
 return false;
 
 bool bIsPrintable = false;

[Libreoffice-bugs] [Bug 146250] [Character Set] combobox in [HTML Compatibility] is not set to the saved value when reopened.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146250

--- Comment #3 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d505940a7fff8674ff4d22eaa04972a56bea516e

tdf#146250 fix SvxHtmlOptions::IsDefaultTextEncoding

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146250] [Character Set] combobox in [HTML Compatibility] is not set to the saved value when reopened.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146250

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: svtools/source

[Noel Grandin (via logerrit)]

 svtools/source/config/htmlcfg.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit d505940a7fff8674ff4d22eaa04972a56bea516e
Author: Noel Grandin 
AuthorDate: Thu Dec 16 08:58:38 2021 +0200
Commit: Noel Grandin 
CommitDate: Fri Dec 17 07:25:50 2021 +0100

tdf#146250 fix SvxHtmlOptions::IsDefaultTextEncoding

regression from
commit da9bba7cc3c243e936daea689fea64ecaf110f35
Author: Noel Grandin 
Date:   Mon Jul 26 10:10:17 2021 +0200
use officecfg for SvxHtmlOptions

spotted by himajin10

Change-Id: Id237f7c4d6d816539141de97a19add0a993d92ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126902
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/svtools/source/config/htmlcfg.cxx 
b/svtools/source/config/htmlcfg.cxx
index 8835b132bf05..b871881e0997 100644
--- a/svtools/source/config/htmlcfg.cxx
+++ b/svtools/source/config/htmlcfg.cxx
@@ -90,7 +90,8 @@ bool IsPrintLayoutExtension()
 bool IsDefaultTextEncoding()
 {
 std::optional x = 
officecfg::Office::Common::Filter::HTML::Export::Encoding::get();
-return bool(x);
+// if we have a value, then the text encoding is not default
+return !bool(x);
 }
 rtl_TextEncoding GetTextEncoding()
 {

[Libreoffice-bugs] [Bug 146278] New: How To Get My Money Back From The Cash App To Your Wallet?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146278

Bug ID: 146278
   Summary: How To Get My Money Back From The Cash App To Your
Wallet?
   Product: LibreOffice
   Version: 3.3.0 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Android Viewer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ryanharris.harr...@gmail.com

Description:
To Get My Money Back From The Cash App, you have to apply for a refund as
quickly as possible. However, you can try approaching the troubleshooting
professionals who will provide you with the right guidance to receive your
funds back to your Cash App account wallet with ease.
https://www.emailsupport-contact.com/blog/get-my-money-back-from-cash-app/

Actual Results:
Awaiting

Expected Results:
Awaiting


Reproducible: Always


User Profile Reset: No



Additional Info:
Nope

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 35092] Inking functionality: Ink drawings / annotations with Stylus, Pen or Finger on Touchscreen or Tablet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=35092

--- Comment #140 from cfchrisp...@gmail.com ---
This is a great post. I like this topic.This site has lots of advantage.I found
many interesting things from this site. It helps me in many ways.Thanks for
posting this again.
https://blossomnailspa.net/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 35092] Inking functionality: Ink drawings / annotations with Stylus, Pen or Finger on Touchscreen or Tablet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=35092

cfchrisp...@gmail.com changed:

   What|Removed |Added

URL||https://blossomnailspa.net/

--- Comment #139 from cfchrisp...@gmail.com ---
This is a great post and very helpful. Hope there's more in the future.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145197] Remote open/save services always show unnecessary "share" field (only on Windows)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145197

Justin L  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 144121] Writer: Table can be moved to new page, but not back

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144121

Justin L  changed:

   What|Removed |Added

Version|7.1.4.2 release |unspecified

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 144121] Writer: Table can be moved to new page, but not back

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144121

Justin L  changed:

   What|Removed |Added

Version|7.1.4.2 release |unspecified

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143518] FILESAVE: DOC -> DOCX: Numbers in numbering list change their size after RT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143518

Justin L  changed:

   What|Removed |Added

Summary|FILESAVE: DOCX: Numbers in  |FILESAVE: DOC -> DOCX:
   |numbering list change their |Numbers in numbering list
   |size after RT   |change their size after RT

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146269] No thumbnail preview of document in start center

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146269

Kevin Suo  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #2 from Kevin Suo  ---
This seems to be a FILESAVE issue. There is no such problem when I generate a
docx file from scratch.

Unzip the file and there is no Terminal output is:

warn:sfx:23897:23897:sfx2/source/control/thumbnailview.cxx:93: caught exception
while trying to access Thumbnail/thumbnail.png of
file:///home/suokunlong/%E4%B8%8B%E8%BD%BD/Sampleshort%20(1).docx
com.sun.star.packages.zip.ZipIOException message: Bad Zip File, IOException:
Could not parse manifest.xml
/home/suokunlong/lo/bibisect-master-source/package/source/zippackage/ZipPackage.cxx:375
/home/suokunlong/lo/bibisect-master-source/package/source/zippackage/ZipPackage.cxx:794

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146007] FilePicker dialog execute method hangs LibreOffice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146007

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146002] munderover/munder render both argument above if both of them has style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146002

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146262] FILESAVE blank popup when attempting to save a file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146262

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146262] FILESAVE blank popup when attempting to save a file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146262

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146245] LO Writer: list of fields in the Navigator

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146245

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146245] LO Writer: list of fields in the Navigator

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146245

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145855] Grammar check doesn't work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145855

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145855] Grammar check doesn't work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145855

--- Comment #8 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144261] Bad cursor positioning with Chinese input

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144261

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144261] Bad cursor positioning with Chinese input

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144261

--- Comment #4 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138318] Text boxes moved and cannot be resized or moved back to their original places

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138318

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138318] Text boxes moved and cannot be resized or moved back to their original places

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138318

--- Comment #5 from QA Administrators  ---
Dear Paul,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142930] [Regression] Pasting unformatted text is still formatted as numbers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142930

--- Comment #9 from QA Administrators  ---
Dear Dagur,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142939] File opens full of hashtags instead of my documented text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142939

--- Comment #2 from QA Administrators  ---
Dear Zala Gr,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 129445] Customize dialog: LTR/RTL options should be disabled if Complex text layout is disabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129445

--- Comment #4 from QA Administrators  ---
Dear ridha.skhiri,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 121299] LO Impress: there is no information about amount of replaced words

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121299

--- Comment #7 from QA Administrators  ---
Dear Vera Blagoveschenskaya,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146269] No thumbnail preview of document in start center

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146269

Kevin Suo  changed:

   What|Removed |Added

 CC||suokunl...@126.com

--- Comment #1 from Kevin Suo  ---
Resaving the document to ODT and then resave to docx (based on the odt) will
show the thumbnail. I suppose there is missing thumbnail information in the
docx file in attachment 176550?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 141986] Improve current LO Application Colors theme handling to support a LibreOffice "dark" color scheme mode

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141986

--- Comment #17 from StashStash  ---
LibreOffice 7.2.0.3 doesn't seem to have dark look shown by the image in the
[LibreOffice Release Notes GUI
section](https://wiki.documentfoundation.org/ReleaseNotes/7.2#GUI) -- after
enabling LibreOffice Dark (Tools > Options > LibreOffice > Application Colors).

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 146277] New: Python -m pip fails: AttributeError: module 'asyncio.base_futures' has no attribute 'InvalidStateError'

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146277

Bug ID: 146277
   Summary: Python -m pip fails: AttributeError: module
'asyncio.base_futures' has no attribute
'InvalidStateError'
   Product: LibreOffice
   Version: 7.0.5.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: frederica.n...@mail.com

Description:
Everyone who uses Python needs to install a package eventually.  pip (AFAIK)
comes pre-installed with Python, which is why I am using pip to install a
package. The above-mentioned format for pip should produce the help
information.

Environment:
LO Python: 3.7.10 (default, Mar  2 2021, 22:35:41) [MSC v.1928 64 bit (AMD64)]
on win32
Version: 7.0.5.2 (x64)
Build ID: 64390860c6cd0aca4beafafcfd84613dd9dfb63a
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: en-AU (en_AU); UI: en-GB
Calc: threaded

Steps to Reproduce:
1. cd C:\c:\Program Files\LibreOffice\program
2. python -m pip


Actual Results:
Traceback (most recent call last):
  File "c:\Program Files\LibreOffice\program\python-core-3.7.10\lib\runpy.py",
line 193, in _run_module_as_main
"__main__", mod_spec)
  File "c:\Program Files\LibreOffice\program\python-core-3.7.10\lib\runpy.py",
line 85, in _run_code
exec(code, run_globals)
  File "C:\Python\Python39\lib\site-packages\pip\__main__.py", line 29, in

from pip._internal.cli.main import main as _main
  File "C:\Python\Python39\lib\site-packages\pip\_internal\cli\main.py", line
9, in 
from pip._internal.cli.autocompletion import autocomplete
  File
"C:\Python\Python39\lib\site-packages\pip\_internal\cli\autocompletion.py",
line 10, in 
from pip._internal.cli.main_parser import create_main_parser
  File "C:\Python\Python39\lib\site-packages\pip\_internal\cli\main_parser.py",
line 8, in 
from pip._internal.cli import cmdoptions
  File "C:\Python\Python39\lib\site-packages\pip\_internal\cli\cmdoptions.py",
line 23, in 
from pip._internal.cli.parser import ConfigOptionParser
  File "C:\Python\Python39\lib\site-packages\pip\_internal\cli\parser.py", line
12, in 
from pip._internal.configuration import Configuration, ConfigurationError
  File "C:\Python\Python39\lib\site-packages\pip\_internal\configuration.py",
line 27, in 
from pip._internal.utils.misc import ensure_dir, enum
  File "C:\Python\Python39\lib\site-packages\pip\_internal\utils\misc.py", line
38, in 
from pip._vendor.tenacity import retry, stop_after_delay, wait_fixed
  File "C:\Python\Python39\lib\site-packages\pip\_vendor\tenacity\__init__.py",
line 520, in 
from pip._vendor.tenacity._asyncio import AsyncRetrying
  File "C:\Python\Python39\lib\site-packages\pip\_vendor\tenacity\_asyncio.py",
line 19, in 
from asyncio import sleep
  File "C:\Python\Python39\lib\asyncio\__init__.py", line 8, in 
from .base_events import *
  File "C:\Python\Python39\lib\asyncio\base_events.py", line 40, in 
from . import events
  File "C:\Python\Python39\lib\asyncio\events.py", line 786, in 
from _asyncio import (_get_running_loop, _set_running_loop,
AttributeError: module 'asyncio.base_futures' has no attribute
'InvalidStateError'

Expected Results:
I have not supplied any (valid) pip arguments so I expect the help details to
be displayed.

This is LO pip unit testing 101


Reproducible: Always


User Profile Reset: No



Additional Info:
Ultimately, I want to use sqlite3 in LO.  Preferably, I want to the the sqlite3
that I have already installed outside of LO.  But LO cannot find the already
installed sqlite3 so PLAN B: install sqlite3 locally into the LO Python
instance (sort of like a venv).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 96000] [META] Spelling and grammar checking bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96000
Bug 96000 depends on bug 142043, which changed state.

Bug 142043 Summary: Correct spelling wrongly flagged
https://bugs.documentfoundation.org/show_bug.cgi?id=142043

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142043] Correct spelling wrongly flagged

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142043

Stephen  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142043] Correct spelling wrongly flagged

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142043

--- Comment #3 from Stephen  ---
This bug is no longer showing. Thanks for your reply and I'd like to close this
ticket

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 61914] [META] Start Center bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=61914
Bug 61914 depends on bug 146219, which changed state.

Bug 146219 Summary: UCB: Startup, creating new files, or Exit of the 
application is very slow or "annoying" when the "Recent Document" list contains 
remote files (e.g. Webdav/Nextcloud or SFTP files mounted via File Manager)
https://bugs.documentfoundation.org/show_bug.cgi?id=146219

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146136] Calc: ^k is assigned to Insert>hyperlink AND to insertRowsAvove

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146136

tor...@yahoo.com changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #3 from tor...@yahoo.com ---
This problem is absent from ver.7.2.4.1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 53864] Export ignores layer options 'printable' and 'visible'

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=53864

Regina Henschel  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||7257

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117257] Exporting to SVG [or any format] makes hidden layer visible

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117257

Regina Henschel  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=53
   ||864

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 53864] Export ignores layer options 'printable' and 'visible'

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=53864

Regina Henschel  changed:

   What|Removed |Added

 CC||martyskel...@gmail.com

--- Comment #16 from Regina Henschel  ---
*** Bug 146268 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146268] FILESAVE - Exporting a page as a .png image includes layers which are currently set to be both not visible and not printable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146268

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Regina Henschel  ---
Yes, that is an old, still unsolved problem.

*** This bug has been marked as a duplicate of bug 53864 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: svx/qa

[Regina Henschel (via logerrit)]

 svx/qa/unit/customshapes.cxx |   48 +++
 svx/qa/unit/data/tdf145904_center_Zminus2000.odt |binary
 svx/qa/unit/data/tdf145956_Origin.odp|binary
 3 files changed, 48 insertions(+)

New commits:
commit b9c159361abd79862b30412c433fb355d63299e2
Author: Regina Henschel 
AuthorDate: Thu Dec 16 19:47:05 2021 +0100
Commit: Regina Henschel 
CommitDate: Fri Dec 17 01:32:38 2021 +0100

tdf#145904,tdf#145956 unit test extrusion of shapes

These tests belongs to commit 453c5b6,
improve extrusion of custom shapes.

Change-Id: I3b89a887d72b6814540a659dfa088f1550a1d47b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126962
Tested-by: Jenkins
Reviewed-by: Regina Henschel 

diff --git a/svx/qa/unit/customshapes.cxx b/svx/qa/unit/customshapes.cxx
index 84a18fc77b4d..ca6ece320afa 100644
--- a/svx/qa/unit/customshapes.cxx
+++ b/svx/qa/unit/customshapes.cxx
@@ -127,6 +127,54 @@ void lcl_AssertRectEqualWithTolerance(std::string_view 
sInfo, const tools::Recta
std::abs(rExpected.GetHeight() - 
rActual.GetHeight()) <= nTolerance);
 }
 
+CPPUNIT_TEST_FIXTURE(CustomshapesTest, testTdf145956_Origin_Relative_BoundRect)
+{
+// The ViewPoint is relative to point Origin. The coordinates of point 
Origin are fractions of
+// the actual (2D) bounding rectangle of the shape, including rotation 
around z-axis and flip.
+// Error (among others) was, that the unrotated snap rectangle was used.
+
+// Load document
+OUString aURL = m_directories.getURLFromSrc(sDataDirectory) + 
"tdf145956_Origin.odp";
+mxComponent = loadFromDesktop(aURL, 
"com.sun.star.presentation.PresentationDocument");
+
+// The shape is extruded with 10cm. viewpoint="(0cm 0cm 25cm)", origin="0 
0".
+uno::Reference xShape(getShape(0));
+uno::Reference xPropSet(xShape, uno::UNO_QUERY);
+CPPUNIT_ASSERT_MESSAGE("Could not get the properties", xPropSet.is());
+awt::Rectangle aBoundRect;
+xPropSet->getPropertyValue(UNO_NAME_MISC_OBJ_BOUNDRECT) >>= aBoundRect;
+sal_Int32 nActualTop = aBoundRect.Y;
+
+// Without the fix it would have failed with top = 9462.
+// The tolerance 10 is estimated and can be adjusted if required for HiDPI.
+CPPUNIT_ASSERT_DOUBLES_EQUAL_MESSAGE("top", 10448, nActualTop, 10);
+}
+
+CPPUNIT_TEST_FIXTURE(CustomshapesTest, testTdf145904_Extrusion_CenterZ_odt)
+{
+// The Z-component of the extrusion rotation center specifies the position 
in Hmm.
+// Error (among others) was, that the value was interpreted as Twips.
+
+// Load document
+OUString aURL = m_directories.getURLFromSrc(sDataDirectory) + 
"tdf145904_center_Zminus2000.odt";
+mxComponent = loadFromDesktop(aURL, "com.sun.star.text.TextDocument");
+
+// The shape is extruded and tilt left 60deg. The rotation center is at 
-2000Hmm on the z-axis.
+// That is a position behind the back face of the extruded shape.
+uno::Reference xShape(getShape(0));
+uno::Reference xPropSet(xShape, uno::UNO_QUERY);
+CPPUNIT_ASSERT_MESSAGE("Could not get the properties", xPropSet.is());
+awt::Rectangle aBoundRect;
+xPropSet->getPropertyValue(UNO_NAME_MISC_OBJ_BOUNDRECT) >>= aBoundRect;
+awt::Point aAnchorPosition;
+xPropSet->getPropertyValue("AnchorPosition") >>= aAnchorPosition;
+sal_Int32 nActualLeft = aBoundRect.X - aAnchorPosition.X;
+
+// Without the fix it would have failed with left = 7731.
+// The tolerance 10 is estimated and can be adjusted if required for HiDPI.
+CPPUNIT_ASSERT_DOUBLES_EQUAL_MESSAGE("left", 3501, nActualLeft, 10);
+}
+
 CPPUNIT_TEST_FIXTURE(CustomshapesTest, testTdf145904_Extrusion_CenterY_odt)
 {
 // The X- and Y-component of the extrusion rotation center specify the 
position as fraction of
diff --git a/svx/qa/unit/data/tdf145904_center_Zminus2000.odt 
b/svx/qa/unit/data/tdf145904_center_Zminus2000.odt
new file mode 100644
index ..9a19f4cbdd6a
Binary files /dev/null and b/svx/qa/unit/data/tdf145904_center_Zminus2000.odt 
differ
diff --git a/svx/qa/unit/data/tdf145956_Origin.odp 
b/svx/qa/unit/data/tdf145956_Origin.odp
new file mode 100644
index ..7bba1dadd8e7
Binary files /dev/null and b/svx/qa/unit/data/tdf145956_Origin.odp differ

[Libreoffice-bugs] [Bug 146276] Installation windows almost out of screen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146276

--- Comment #2 from omic...@vivaldi.net ---
Created attachment 176976
  --> https://bugs.documentfoundation.org/attachment.cgi?id=176976=edit
Open GL screen capture

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146276] Installation windows almost out of screen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146276

--- Comment #1 from omic...@vivaldi.net ---
Created attachment 176975
  --> https://bugs.documentfoundation.org/attachment.cgi?id=176975=edit
Screen capture

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146276] New: Installation windows almost out of screen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146276

Bug ID: 146276
   Summary: Installation windows almost out of screen
   Product: LibreOffice
   Version: 7.1.8.1 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: trivial
  Priority: medium
 Component: Installation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: omic...@vivaldi.net

Description:
A couple of installation windows are almost out of screen.

Steps to Reproduce:
1.Install Libreoffice on Windows 7 system
2.
3.

Actual Results:
windows almost out of screen

Expected Results:
Windows centered correctly


Reproducible: Didn't try


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
Version: 7.1.8.1 (x64) / LibreOffice Community
Build ID: e1f30c802c3269a1d052614453f260e49458c82c
CPU threads: 2; OS: Windows 6.1 Service Pack 1 Build 7601; UI render:
Skia/Raster; VCL: win
Locale: it-IT (it_IT); UI: it-IT
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146270] Empty image frames after scrolling down a document. Disabling show changes & scrolling up

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146270

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #3 from Regina Henschel  ---
There is something wrong on import. The import produces the wrong structure
with a . Scrolling to the end of the document crashes.

Tested with Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 2dc2188c40282e85ecf9eb62321320251357f760
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: default; VCL: win
Locale: de-DE (en_US); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145855] Grammar check doesn't work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145855

--- Comment #7 from Dennis Rice  ---
Just looked at Tools -> Spelling,  Option is set to English.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/source

[Jim Raykowski (via logerrit)]

 sw/source/uibase/utlui/content.cxx |   13 -
 1 file changed, 12 insertions(+), 1 deletion(-)

New commits:
commit dc54785f153a7fe8fecc1e21b0ef7c6549e2d0d0
Author: Jim Raykowski 
AuthorDate: Mon Dec 13 21:41:47 2021 -0900
Commit: Jim Raykowski 
CommitDate: Fri Dec 17 00:17:33 2021 +0100

SwNavigator: fill content member lists when toggling from root view

Other content type member data could have changed while in root content
view. Fill the content member lists when toggling from root, excluding
the toggled from root content which should already have the most recent
data.

Change-Id: I7a014affa72c05f0a89df29acfbabcaf59fe711a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126796
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 

diff --git a/sw/source/uibase/utlui/content.cxx 
b/sw/source/uibase/utlui/content.cxx
index 1a8db68e9baa..2022dd00b792 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -2772,9 +2772,20 @@ void SwContentTree::ToggleToRoot()
 else
 {
 m_xTreeView->set_selection_mode(SelectionMode::Single);
+m_nLastSelType = m_nRootType;
 m_nRootType = ContentTypeId::UNKNOWN;
 m_bIsRoot = false;
-FindActiveTypeAndRemoveUserData();
+// Other content type member data could have changed while in root 
view. Fill the content
+// member lists excluding the toggled from root content which should 
already have the most
+// recent data.
+if (State::HIDDEN != m_eState)
+{
+for (ContentTypeId i : o3tl::enumrange())
+{
+if (i != m_nLastSelType)
+m_aActiveContentArr[i]->FillMemberList();
+}
+}
 Display(State::HIDDEN != m_eState);
 }
 m_pConfig->SetRootType( m_nRootType );

[Libreoffice-bugs] [Bug 146272] Empty image frame on file open/cut/paste frame will restore visibility

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146272

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #3 from Regina Henschel  ---
Isn't this the same as your report bug 146267?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146267] Image only partly visible

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146267

--- Comment #5 from Regina Henschel  ---
"ooxml-rect"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145855] Grammar check doesn't work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145855

--- Comment #6 from Dennis Rice  ---
Have upgraded to 7.2.4.1
Response:
2.  Lightproof Grammar Checker  is checked.
3.  Check grammar as You Type   is checked
4.  Selected language   is Languages → Interface English
5.  Typing sentence:
I can understanding English.
Nothing is underlined.
He do his homework.
Nothing is underlined.
6.  SpellingLanguages → Hunspell Spellchecker is
checked
Not sure if this is the correct requirement, but spell
checking is working
(I’m especially poor at that too and very glad that it
works!)
Did note that under Language Settings, English Sentence Checking,
Grammar Checking, Possible mistakes was not checked


Noted that under Language Settings, English Sentence Checking, Grammar
Checking, 
Possible mistakes option was not checked.
I check the option but when checking “Apply” and “OK”, did not see the above
grammar issues underlined (I’m making all of my notes while in LO).

In noting that after pasting the above notes into this web page response
comment page that "Gammarly" underlines the above suggested "errored"
sentences.  I did close LO and then restart and found that the issue with the
underlining of the "error" sentences did not show up as such.

I do not understand what I am doing wrong.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146267] Image only partly visible

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146267

Regina Henschel  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 CC||rb.hensc...@t-online.de

--- Comment #4 from Regina Henschel  ---
I can confirm, that the image is not visible.

The example file has a structure, that is not supported by current LibreOffice.






Do you know, how the file was created and from what source?
The  has type "ooxml-rectangle". That likely means, that MS
Office is involved.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146201] Improper formatting of "frac" in Formula object ignores brackets

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146201

LeroyG  changed:

   What|Removed |Added

Version|7.2.3.2 release |7.1.8.1 release

--- Comment #1 from LeroyG  ---
"frac" is not documented in Unary/Binary Operators help page
(https://help.libreoffice.org/7.2/en-US/text/smath/01/03090100.html)

Except with "=", replacing "+" with other operators (-, /, *, times, div,
oplus, etc.) gives the same result.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Adding item to ReleaseNotes

[Regina Henschel]

Hi all,

I have added an item to https://wiki.documentfoundation.org/ReleaseNotes/7.3

But that is a multilingua page and I don't know what to do now.

Kind regards,
Regina

[Libreoffice-bugs] [Bug 140805] FIND TOOLBAR: Incremental/Type-ahead search in Writer should be supported

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140805

--- Comment #6 from Dominique  ---
This kind of feature, ie. giving an instant visual feedback on the searched
string while typing is already available in Microsoft Word at least since the
version 2010, and there, it gives you both an highlighted background on the
matching text and when less than 100 occurrences were found, a list of text
blocks around the matched text pointing out the context.

I simply really missed it once I switched to Writer.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146275] FORMATTING: Applying paragraph style to a table cell, changes the style of the last paragraph in the upper cell

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146275

LeroyG  changed:

   What|Removed |Added

Summary|[FORMATTING] Applying   |FORMATTING: Applying
   |paragraph style to a table  |paragraph style to a table
   |cell, changes the style of  |cell, changes the style of
   |the last paragraph in the   |the last paragraph in the
   |upper cell  |upper cell

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146275] New: [FORMATTING] Applying paragraph style to a table cell, changes the style of the last paragraph in the upper cell

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146275

Bug ID: 146275
   Summary: [FORMATTING] Applying paragraph style to a table cell,
changes the style of the last paragraph in the upper
cell
   Product: LibreOffice
   Version: 7.1.8.1 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: iavs.le...@gmail.com

Created attachment 176974
  --> https://bugs.documentfoundation.org/attachment.cgi?id=176974=edit
A table with two columns and two rows and some text

Applying paragraph style to a table cell, changes the style of the last
paragraph in the upper cell.

Steps to Reproduce:
1. Create a table with a least two columns and two rows, and add some text in
each cell (see attached sample file).
2.a. Select a lower cell and apply some paragraph style.
2.b. Select the lower cells and apply some paragraph style.

Actual Results:
After step 2.a., last paragraph of upper cell also gets the new paragraph
style.
After step 2.b., as expected.

Expected Results:
After step 2.a., last paragraph of upper cell remains without changes.

Version: 7.1.8.1 / LibreOffice Community
Build ID: e1f30c802c3269a1d052614453f260e49458c82c
CPU threads: 1; OS: Linux 4.12; UI render: default; VCL: x11
Locale: es-MX (es_AR.UTF-8); UI: en-US
Calc: threaded

Also tested with OS: Windows 6.1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: .vscode/vs-code-template.code-workspace.in

[Mike Kaganski (via logerrit)]

 .vscode/vs-code-template.code-workspace.in |   63 +
 1 file changed, 47 insertions(+), 16 deletions(-)

New commits:
commit 986e946d0cf3a6f61873efc09bab8c5e07c04f80
Author: Mike Kaganski 
AuthorDate: Wed Dec 15 14:19:31 2021 +0100
Commit: Mike Kaganski 
CommitDate: Thu Dec 16 22:34:31 2021 +0100

VSCode IDE integration: add safe path for pretty printers

Change-Id: I900ea4aef58fddb21f8bf3cb8264d9c8d9169a9c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126873
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/.vscode/vs-code-template.code-workspace.in 
b/.vscode/vs-code-template.code-workspace.in
index 4f5d25cc3899..fe20726afaeb 100644
--- a/.vscode/vs-code-template.code-workspace.in
+++ b/.vscode/vs-code-template.code-workspace.in
@@ -13,9 +13,20 @@
"path": "@SRC_ROOT@"
},
{
+   // BUILDDIR may be configured separate from SRCDIR
"name": "builddir",
"path": "@BUILDDIR@"
-   }
+   },
+   {
+   // This is BUILDDIR/workdir
+   "name": "workdir",
+   "path": "@WORKDIR@"
+   },
+   {
+   // This is BUILDDIR/instdir
+   "name": "instdir",
+   "path": "@INSTROOT@"
+   },
],
"settings": {
"search.exclude": {
@@ -39,7 +50,7 @@
// only used if the file doesn't match anything in the 
compile_commands.json - aka externals
// libxml includes just added as example/for reference
"C_Cpp.default.includePath": [
-   "@WORKDIR@/UnpackedTarball/**",
+   "${workspaceFolder:workdir}/UnpackedTarball/**",
"/usr/include/libxml2/"
],
"C_Cpp.default.browse.limitSymbolsToIncludedHeaders": true,
@@ -71,7 +82,7 @@
"isDefault": true
},
"options": {
-   "cwd": "@BUILDDIR@"
+   "cwd": "${workspaceFolder:builddir}"
}
},
{
@@ -90,7 +101,7 @@
"full make"
],
"options": {
-   "cwd": "@BUILDDIR@"
+   "cwd": "${workspaceFolder:builddir}"
},
"problemMatcher": [] // don't ask when manually 
running the task
},
@@ -101,14 +112,14 @@
"command": "rm",
"args": [
"-rf",
-   
"@WORKDIR@/vs-code-temporary-user-profile"
+   
"${workspaceFolder:workdir}/vs-code-temporary-user-profile"
],
"group": "none",
"dependsOn": [
"full make"
],
"options": {
-   "cwd": "@BUILDDIR@"
+   "cwd": "${workspaceFolder:builddir}"
},
"problemMatcher": []
}
@@ -120,10 +131,10 @@
"name": "run in debugger after make",
"type": "cppdbg",
"request": "launch",
-   "program": "@INSTROOT@/program/soffice.bin",
+   "program": 
"${workspaceFolder:instdir}/program/soffice.bin",
"args": [],
"stopAtEntry": false,
-   "cwd": "@BUILDDIR@",
+   "cwd": "${workspaceFolder:builddir}",
"environment": [
{
// added in disabled form for 
convenience/as an example
@@ -137,16 +148,26 @@
"MIMode": "gdb",
"setupCommands": [
{
-   "description": "Enable 
prett-printing for gdb",
+   "description": "Enable 
pretty-printing for gdb",
"text": 
"-enable-pretty-printing",
 

[Libreoffice-commits] core.git: solenv/flatpak-manifest.in

[Stephan Bergmann (via logerrit)]

 solenv/flatpak-manifest.in |7 ---
 1 file changed, 7 deletions(-)

New commits:
commit 5a7eb9cb97ce58d212348d46fad3a1755b54db64
Author: Stephan Bergmann 
AuthorDate: Thu Dec 16 19:49:55 2021 +0100
Commit: Stephan Bergmann 
CommitDate: Thu Dec 16 22:33:13 2021 +0100

NEON_{SHA256SUM,TARBALL} are gone from download.lst

...since 023ebf17898db4bca63129f079fd90b5cf76c1a9 "ucb: remove
--with-webdav=neon"

Change-Id: I6744cc853d5c12bf29751bb6c1815d5de507d0fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126961
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/solenv/flatpak-manifest.in b/solenv/flatpak-manifest.in
index b5626b80..43dcbf331746 100644
--- a/solenv/flatpak-manifest.in
+++ b/solenv/flatpak-manifest.in
@@ -403,13 +403,6 @@
 "dest": "external/tarballs",
 "dest-filename": "@MDDS_TARBALL@"
 },
-{
-"url": 
"https://dev-www.libreoffice.org/src/@NEON_TARBALL@;,
-"sha256": "@NEON_SHA256SUM@",
-"type": "file",
-"dest": "external/tarballs",
-"dest-filename": "@NEON_TARBALL@"
-},
 {
 "url": 
"https://dev-www.libreoffice.org/src/@FONT_NOTO_TARBALL@;,
 "sha256": "@FONT_NOTO_SHA256SUM@",

[Libreoffice-bugs] [Bug 129796] Edit Field of a Input Field Variable with a User Field variable does not give the proper Reference value

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129796

--- Comment #6 from Commit Notification 
 ---
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/045665d7760f14b36f9971f8b736d5dee6189b0a

tdf#129796: sw: Add UItest

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 129796] Edit Field of a Input Field Variable with a User Field variable does not give the proper Reference value

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129796

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.0.0 target:6.4.3   |target:7.0.0 target:6.4.3
   ||target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/qa sw/source

[Xisco Fauli (via logerrit)]

 sw/qa/uitest/writer_tests/tdf129796.py |   76 +
 sw/source/ui/fldui/flddb.cxx   |1 
 sw/source/ui/fldui/flddinf.cxx |1 
 sw/source/ui/fldui/flddok.cxx  |3 +
 sw/source/ui/fldui/fldfunc.cxx |2 
 sw/source/ui/fldui/fldref.cxx  |3 +
 sw/source/ui/fldui/fldvar.cxx  |4 +
 sw/source/uibase/inc/condedit.hxx  |3 +
 sw/source/uibase/inc/numfmtlb.hxx  |4 +
 9 files changed, 97 insertions(+)

New commits:
commit 045665d7760f14b36f9971f8b736d5dee6189b0a
Author: Xisco Fauli 
AuthorDate: Thu Dec 16 19:33:44 2021 +0100
Commit: Xisco Fauli 
CommitDate: Thu Dec 16 22:27:11 2021 +0100

tdf#129796: sw: Add UItest

Change-Id: I0eb3aa6a5550b1c49e88b0aa3195d3aae5d6396b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126960
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sw/qa/uitest/writer_tests/tdf129796.py 
b/sw/qa/uitest/writer_tests/tdf129796.py
new file mode 100644
index ..fb764f7aec79
--- /dev/null
+++ b/sw/qa/uitest/writer_tests/tdf129796.py
@@ -0,0 +1,76 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+from uitest.framework import UITestCase
+from libreoffice.uno.propertyvalue import mkPropertyValues
+from uitest.uihelper.common import get_state_as_dict
+from uitest.uihelper.common import select_pos
+
+class Tdf129796(UITestCase):
+
+def test_tdf129796(self):
+
+with self.ui_test.create_doc_in_start_center("writer") as writer_doc:
+
+with 
self.ui_test.execute_modeless_dialog_through_command(".uno:InsertField", 
close_button="cancel") as xDialog:
+xTab = xDialog.getChild("tabcontrol")
+select_pos(xTab, "4")
+
+xType = xDialog.getChild("type-var")
+xType.getChild('8').executeAction("SELECT", tuple())
+self.assertEqual("User Field", 
get_state_as_dict(xType)['SelectEntryText'])
+
+xNumFormat = xDialog.getChild("numformat-var")
+xNumFormat.getChild('0').executeAction("SELECT", tuple())
+self.assertEqual("Text", 
get_state_as_dict(xNumFormat)['SelectEntryText'])
+
+xName = xDialog.getChild("name-var")
+xName.executeAction("TYPE", mkPropertyValues({"TEXT": 
"MyField"}))
+
+xValue = xDialog.getChild("value-var")
+xValue.executeAction("TYPE", mkPropertyValues({"TEXT": "abc"}))
+
+xApplyBtn = xDialog.getChild("apply")
+xApplyBtn.executeAction("CLICK", ())
+
+xType.getChild('4').executeAction("SELECT", tuple())
+self.assertEqual("Input field", 
get_state_as_dict(xType)['SelectEntryText'])
+
+self.assertEqual("MyField", 
get_state_as_dict(xDialog.getChild("select-var"))["SelectEntryText"])
+
+xValue.executeAction("TYPE", mkPropertyValues({"TEXT": "ref"}))
+
+xOkBtn = xDialog.getChild("ok")
+with 
self.ui_test.execute_blocking_action(xOkBtn.executeAction, args=('CLICK', ())) 
as xFieldDialog:
+xName = xFieldDialog.getChild("name")
+self.assertEqual("ref", get_state_as_dict(xName)['Text'])
+xText = xFieldDialog.getChild("text")
+self.assertEqual("abc", get_state_as_dict(xText)['Text'])
+
+textfields = writer_doc.getTextFields()
+textfield = textfields.createEnumeration().nextElement()
+self.assertEqual('MyField', textfield.Content)
+
self.assertTrue(textfield.supportsService("com.sun.star.text.TextField.InputUser"))
+
+# Move the cursor to the field
+self.xUITest.executeCommand(".uno:GoLeft")
+
+with 
self.ui_test.execute_dialog_through_command(".uno:FieldDialog") as xDialog:
+xType = xDialog.getChild("type-var")
+xNumFormat = xDialog.getChild("numformat-var")
+xValue = xDialog.getChild("value-var")
+xName = xDialog.getChild("name-var")
+
+# Without the fix in place, this test would have crashed here
+self.assertEqual("ref", get_state_as_dict(xValue)['Text'])
+self.assertEqual("Input field", 
get_state_as_dict(xType)['SelectEntryText'])
+self.assertEqual("General", 
get_state_as_dict(xNumFormat)['SelectEntryText'])
+self.assertEqual("MyField", get_state_as_dict(xName)['Text'])
+
+# vim: set shiftwidth=4 softtabstop=4 expandtab:
diff --git a/sw/source/ui/fldui/flddb.cxx b/sw/source/ui/fldui/flddb.cxx
index 5bc1c8d77645..f65abe0bdf7a 

[Libreoffice-bugs] [Bug 146274] Undo after search-and-replace is br0ken

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146274

Mike Kaganski  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||regression
 CC||michael.st...@allotropia.de
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #2 from Mike Kaganski  ---
Also seen with Version: 7.0.0.3 (x64)
Build ID: 8061b3e9204bef6b321a21033174034a5e2ea88e
CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL

But not with Version: 6.4.0.3 (x64)
Build ID: b0a288ab3d2d4774cb44b62f04d5d28733ac6df8
CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: GL; VCL: win; 
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: threaded

Regression after
https://git.libreoffice.org/core/+/e1629c210ad78310e3d48c0756723134a27b89df

  tdf#131912 sw: fix spell check correct deleting flys

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146255] Text shift vertically when setting highlighting to no fill (appears to be zoom-related)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146255

--- Comment #4 from LeroyG  ---
Just with putting the cursor in the "Le recyclage et la fin de vie  " line
makes it to move a bit. This don't bothers me.

But I don't have Verdana in this PC.

Version: 7.1.8.1 / LibreOffice Community
Build ID: e1f30c802c3269a1d052614453f260e49458c82c
CPU threads: 1; OS: Linux 4.12; UI render: default; VCL: x11
Locale: es-MX (es_AR.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146273] inconsistencies in navigator page "go to" and page dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146273

LeroyG  changed:

   What|Removed |Added

Version|7.2.4.1 release |7.1.8.1 release

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146273] inconsistencies in navigator page "go to" and page dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146273

--- Comment #1 from LeroyG  ---
"$" in the Go to Page field and Enter, makes the cursor jump to the start
(upper left) of the last page; but if do you do "$" Enter again, the cursor
jumps to the start (upper left) of the first page.

And instead of "$": "·", "%", "ç", uppercase characters, """, etc.
With lowercase characters it behaves a bit erratically.

Version: 7.1.8.1 / LibreOffice Community
Build ID: e1f30c802c3269a1d052614453f260e49458c82c
CPU threads: 1; OS: Linux 4.12; UI render: default; VCL: x11
Locale: es-MX (es_AR.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: filter/source include/xmloff sal/qa svl/source svx/source sw/inc sw/qa sw/source

[Andrea Gelmini (via logerrit)]

 filter/source/msfilter/svdfppt.cxx|2 +-
 include/xmloff/prstylei.hxx   |2 +-
 sal/qa/osl/file/osl_File.cxx  |2 +-
 svl/source/misc/urihelper.cxx |2 +-
 svx/source/customshapes/EnhancedCustomShape3d.cxx |8 
 sw/inc/textboxhelper.hxx  |2 +-
 sw/qa/extras/layout/layout2.cxx   |2 +-
 sw/source/filter/ww8/ww8atr.cxx   |4 ++--
 sw/source/filter/ww8/ww8par2.cxx  |2 +-
 sw/source/filter/ww8/ww8scan.cxx  |2 +-
 10 files changed, 14 insertions(+), 14 deletions(-)

New commits:
commit 63f2350fa3f91fcc310f85a59f1becdfee2784af
Author: Andrea Gelmini 
AuthorDate: Thu Dec 16 18:35:08 2021 +0100
Commit: Julien Nabet 
CommitDate: Thu Dec 16 21:52:43 2021 +0100

Fix typos

Change-Id: I66feced8bed05c7859e36a6d2f746a7faf30c7a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126915
Reviewed-by: Julien Nabet 
Tested-by: Jenkins

diff --git a/filter/source/msfilter/svdfppt.cxx 
b/filter/source/msfilter/svdfppt.cxx
index 21df91f595b6..9828b287bda5 100644
--- a/filter/source/msfilter/svdfppt.cxx
+++ b/filter/source/msfilter/svdfppt.cxx
@@ -2381,7 +2381,7 @@ SdrObject* SdrPowerPointImport::ApplyTextObj( PPTTextObj* 
pTextObj, SdrTextObj*
 bool SdrPowerPointImport::SeekToDocument( DffRecordHeader* pRecHd ) const
 {
 bool bRet;
-sal_uInt64 nOldFPos = rStCtrl.Tell(); // remember FilePos for restoring it 
should the situation arise
+sal_uInt64 nOldFPos = rStCtrl.Tell(); // remember FilePos for restoring 
it, if the situation should happen
 rStCtrl.Seek( m_nDocStreamPos );
 DffRecordHeader aDocHd;
 ReadDffRecordHeader( rStCtrl, aDocHd );
diff --git a/include/xmloff/prstylei.hxx b/include/xmloff/prstylei.hxx
index c2766f76fa0c..98df0c4ead52 100644
--- a/include/xmloff/prstylei.hxx
+++ b/include/xmloff/prstylei.hxx
@@ -58,7 +58,7 @@ protected:
 
 // Helper which will deactivate all old fill definitions (identified by
 // the given OldFillStyleDefinitionSet) in the local maProperties. 
Deactivation
-// is done setting theindex to -1. It returns true when actually old fill
+// is done setting the index to -1. It returns true when actually old fill
 // definitions existed and were deactivated
 void deactivateOldFillStyleDefinitions(
 const OldFillStyleDefinitionSet& rHashSetOfTags);
diff --git a/sal/qa/osl/file/osl_File.cxx b/sal/qa/osl/file/osl_File.cxx
index ebab41eb17bf..2eac7d1688af 100644
--- a/sal/qa/osl/file/osl_File.cxx
+++ b/sal/qa/osl/file/osl_File.cxx
@@ -789,7 +789,7 @@ namespace osl_FileBase
 the second only on windows based systems
 the first parameter are a file URL where we want to get the system 
path of,
 the second parameter is the assumed error of the 
osl_getSystemPathFromFileURL() function,
-the third parameter is the assumed result string, the string will only 
test, if its length is greater 0
+the third parameter is the assumed result string, the string will only 
test, if its length is greater than 0
 */
 
 void SystemPath_FileURL::getSystemPathFromFileURL_001_1()
diff --git a/svl/source/misc/urihelper.cxx b/svl/source/misc/urihelper.cxx
index 068aea281312..af92a9d41fe2 100644
--- a/svl/source/misc/urihelper.cxx
+++ b/svl/source/misc/urihelper.cxx
@@ -347,7 +347,7 @@ bool isBoundary2(CharClass const & rCharClass, OUString 
const & rStr,
 }
 }
 
-// tdf#145381 Added MatchingBracketDepth counter o detect maching closing
+// tdf#145381 Added MatchingBracketDepth counter to detect matching closing
 // brackets that are part of the uri
 bool checkWChar(CharClass const & rCharClass, OUString const & rStr,
 sal_Int32 * pPos, sal_Int32 * pEnd,
diff --git a/svx/source/customshapes/EnhancedCustomShape3d.cxx 
b/svx/source/customshapes/EnhancedCustomShape3d.cxx
index d378a0d1ff85..c967261cfd22 100644
--- a/svx/source/customshapes/EnhancedCustomShape3d.cxx
+++ b/svx/source/customshapes/EnhancedCustomShape3d.cxx
@@ -611,7 +611,7 @@ SdrObject* EnhancedCustomShape3d::Create3DObject(
 aBoundAfter2DTransform.SetRight(aTotalPolyPolyRange.getMaxX());
 
aBoundAfter2DTransform.SetBottom(aTotalPolyPolyRange.getMaxY());
 
-// Property "Origin" in API is relativ to bounding box of 
shape after 2D
+// Property "Origin" in API is relative to bounding box of 
shape after 2D
 // transformations. Range is [-0.5;0.5] with center of 
bounding box as 0.
 // Resolve "Origin" fractions to length
 GetOrigin( rGeometryItem, fOriginX, fOriginY );
@@ -625,7 +625,7 @@ SdrObject* EnhancedCustomShape3d::Create3DObject(
 // Translate point "Origin" too.
 fOriginX -= aCenter.X();
 fOriginY -= -aCenter.Y();
-// API 

[Libreoffice-bugs] [Bug 146274] Undo after search-and-replace is br0ken

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146274

LeroyG  changed:

   What|Removed |Added

Version|7.4.0.0 alpha0+ Master  |7.1.8.1 release

--- Comment #1 from LeroyG  ---
Seen with: Version: 7.1.8.1 / LibreOffice Community
Build ID: e1f30c802c3269a1d052614453f260e49458c82c
CPU threads: 1; OS: Linux 4.12; UI render: default; VCL: x11
Locale: es-MX (es_AR.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 118616] PDF export of a form's scrollable memo field shows fewer lines than on the original form

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=118616

--- Comment #10 from Alan Wheeler  ---
Still present in LibreOffice 7.2.4.1

Version: 7.2.4.1 (x64) / LibreOffice Community
Build ID: 27d75539669ac387bb498e35313b970b7fe9c4f9
CPU threads: 4; OS: Windows 10.0 Build 22000; UI render: default; VCL: win
Locale: en-GB (en_GB); UI: en-GB
Calc: CL

There appears to be 2 problems :-
1) The font and font size used in the form are not completely specified or
embedded when exporting, so the PDF reader chooses a reasonable base 14 font.
Different PDF readers make different choices, so appearance differs when
displaying the exported file and rarely exactly matches the appearance on the
original form.
2) The position within the text box is slightly lower when displaying the
exported file than it was in the text box on the original form.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: connectivity/source

[Julien Nabet (via logerrit)]

 connectivity/source/drivers/evoab2/NResultSet.cxx |   14 +-
 connectivity/source/drivers/evoab2/NResultSetMetaData.cxx |   10 +-
 connectivity/source/drivers/evoab2/NStatement.cxx |   14 +++---
 3 files changed, 17 insertions(+), 21 deletions(-)

New commits:
commit ab864bd178a44208c98a2fd1b1248df5f1db1fc9
Author: Julien Nabet 
AuthorDate: Sun Dec 12 11:59:53 2021 +0100
Commit: Julien Nabet 
CommitDate: Thu Dec 16 21:32:26 2021 +0100

tdf#38235: fix sort failure for Evolution

Several issues to deal with:
1) The initial pb:
"Error setting the source criteria. The column  XXX must be visible as a 
column. SQL status: 01000, Error code 1000."
=>
OEvoabResultSetMetaData::getColumnLabel was returning the nickname of the 
column with g_param_spec_get_nick
we just want the column name to display and to use

2) SQL parsing in OCommonStatement::orderByAnalysis
2 "sub-issues":
  a) ENSURE_OR_THROW was testing SQL_ISRULE( pAscDesc, opt_asc_desc )
opt_asc_desc is defined in connectivity/source/parse/sqlbison.y with:
opt_asc_desc:
{$$ = SQL_NEW_RULE;}
|   SQL_TOKEN_ASC
|   SQL_TOKEN_DESC
;
not sure if it should be kept but for DESC I had to use this:
SQL_ISTOKEN(pAscDesc, DESC)

  b) Retrieve of ascending
By default ascending is at true but then we tested the node with:
if  ( ( pAscDesc->count() == 1 ) &&  SQL_ISTOKEN( pAscDesc->getChild( 0 ), 
DESC )
But when we use DESC, it's directly a TOKEN so just this should suffice:
bool bAscending = !SQL_ISTOKEN(pAscDesc, DESC);

3) CompareContacts wasn't taking into account bAscending
since we use comparison function for g_slist_sort_with_data, I only used
int nOrder = 1;
// if descending sort, reverse order
if (!sortCol.bAscending)
nOrder = -1;
and multiply the result with this to have the ad hoc order

Change-Id: I3c360a5ef9cf0dc737a7ce4a138d2d2586abdca9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126698
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/connectivity/source/drivers/evoab2/NResultSet.cxx 
b/connectivity/source/drivers/evoab2/NResultSet.cxx
index 6df2d806ab3c..e6a43dab7687 100644
--- a/connectivity/source/drivers/evoab2/NResultSet.cxx
+++ b/connectivity/source/drivers/evoab2/NResultSet.cxx
@@ -308,6 +308,10 @@ static int CompareContacts( gconstpointer _lhs, 
gconstpointer _rhs, gpointer _us
 for ( const auto& sortCol : rCompData.rSortOrder )
 {
 sal_Int32 nField = sortCol.nField;
+int nOrder = 1;
+// if descending sort, reverse order
+if (!sortCol.bAscending)
+nOrder = -1;
 GType eFieldType = evoab::getGFieldType( nField );
 
 bool success =  getValue( lhs, nField, eFieldType, , 
bLhsNull )
@@ -317,9 +321,9 @@ static int CompareContacts( gconstpointer _lhs, 
gconstpointer _rhs, gpointer _us
 return 0;
 
 if ( bLhsNull && !bRhsNull )
-return -1;
+return -1 * nOrder;
 if ( !bLhsNull && bRhsNull )
-return 1;
+return 1 * nOrder;
 if ( bLhsNull && bRhsNull )
 continue;
 
@@ -329,16 +333,16 @@ static int CompareContacts( gconstpointer _lhs, 
gconstpointer _rhs, gpointer _us
 sRhs = valueToOUString( aRhsValue );
 sal_Int32 nCompResult = 
rCompData.aIntlWrapper.getCaseCollator()->compareString( sLhs, sRhs );
 if ( nCompResult != 0 )
-return nCompResult;
+return nCompResult * nOrder;
 continue;
 }
 
 bLhs = valueToBool( aLhsValue );
 bRhs = valueToBool( aRhsValue );
 if ( bLhs && !bRhs )
-return -1;
+return -1 * nOrder;
 if ( !bLhs && bRhs )
-return 1;
+return 1 * nOrder;
 continue;
 }
 
diff --git a/connectivity/source/drivers/evoab2/NResultSetMetaData.cxx 
b/connectivity/source/drivers/evoab2/NResultSetMetaData.cxx
index a980c2067041..a2ce922ff193 100644
--- a/connectivity/source/drivers/evoab2/NResultSetMetaData.cxx
+++ b/connectivity/source/drivers/evoab2/NResultSetMetaData.cxx
@@ -101,15 +101,7 @@ OUString SAL_CALL 
OEvoabResultSetMetaData::getColumnTypeName( sal_Int32 nColumnN
 
 OUString SAL_CALL OEvoabResultSetMetaData::getColumnLabel( sal_Int32 
nColumnNum )
 {
-sal_uInt32 nField = m_aEvoabFields[nColumnNum - 1];
-const ColumnProperty *pSpecs = getField(nField);
-GParamSpec *pSpec = pSpecs->pField;
-OUString aLabel;
-
-if( pSpec )
-aLabel = OStringToOUString( g_param_spec_get_nick( pSpec ),
- RTL_TEXTENCODING_UTF8 );
-return aLabel;
+return getColumnName(nColumnNum);
 }
 
 OUString SAL_CALL 

[Libreoffice-commits] core.git: configure.ac

[Tor Lillqvist (via logerrit)]

 configure.ac |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 00ba09e5675fd30032d0fba38212dcad1a696e73
Author: Tor Lillqvist 
AuthorDate: Thu Dec 16 19:29:07 2021 +0200
Commit: Tor Lillqvist 
CommitDate: Thu Dec 16 21:30:32 2021 +0100

Accept iOS SDK 15.2

Change-Id: I42182f86673586ce48905bdda3281ef4499263a8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126958
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist 

diff --git a/configure.ac b/configure.ac
index 91905c22a74a..22f53a7c2b2c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3539,8 +3539,8 @@ dnl 
===
 
 if test $_os = iOS; then
 AC_MSG_CHECKING([what iOS SDK to use])
-current_sdk_ver=15.0
-older_sdk_vers="14.5"
+current_sdk_ver=15.2
+older_sdk_vers="15.0 14.5"
 if test "$enable_ios_simulator" = "yes"; then
 platform=iPhoneSimulator
 versionmin=-mios-simulator-version-min=13.6

[Libreoffice-commits] core.git: vcl/ios vcl/source

[Tor Lillqvist (via logerrit)]

 vcl/ios/DataFlavorMapping.cxx|2 +-
 vcl/source/treelist/transfer.cxx |4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit e84dcee44aa7cdd340ee22d528afe14abebba994
Author: Tor Lillqvist 
AuthorDate: Thu Dec 16 19:24:20 2021 +0200
Commit: Tor Lillqvist 
CommitDate: Thu Dec 16 21:30:15 2021 +0100

Fix iOS compilation after recent changes to Sequence

Change-Id: I73c519174029766a3a2f61f9ad93fd63589b8184
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126957
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist 

diff --git a/vcl/ios/DataFlavorMapping.cxx b/vcl/ios/DataFlavorMapping.cxx
index 6a3815cf7eb3..05abf2b8a6f9 100644
--- a/vcl/ios/DataFlavorMapping.cxx
+++ b/vcl/ios/DataFlavorMapping.cxx
@@ -559,7 +559,7 @@ DataFlavorMapper::typesArrayToFlavorSequence(NSArray* 
types) const
 if (isValidFlavor(oOOFlavor))
 {
 flavors.realloc(flavors.getLength() + 1);
-flavors[flavors.getLength() - 1] = oOOFlavor;
+flavors.getArray()[flavors.getLength() - 1] = oOOFlavor;
 SAL_INFO("vcl.ios.clipboard",
  "Mapped " << [sysFormat UTF8String] << " to " << 
oOOFlavor.MimeType);
 }
diff --git a/vcl/source/treelist/transfer.cxx b/vcl/source/treelist/transfer.cxx
index 260e3ba65613..23a865a0a3f0 100644
--- a/vcl/source/treelist/transfer.cxx
+++ b/vcl/source/treelist/transfer.cxx
@@ -668,7 +668,7 @@ bool TransferableHelper::SetBitmapEx( const BitmapEx& 
rBitmapEx, const DataFlavo
 #ifdef IOS
 // Use faster compression on slow devices
 aFilterData.realloc(aFilterData.getLength() + 1);
-aFilterData[aFilterData.getLength() - 1].Name = "Compression";
+aFilterData.getArray()[aFilterData.getLength() - 1].Name = 
"Compression";
 
 // We "know" that this gets passed to zlib's deflateInit2_(). 1 
means best speed. For a
 // typical 15 megapixel image from a DSLR, we are talking about a 
difference of 17 s for
@@ -677,7 +677,7 @@ bool TransferableHelper::SetBitmapEx( const BitmapEx& 
rBitmapEx, const DataFlavo
 // Sure, the best would be to not have to re-encode the image at 
all, but have access to
 // the original JPEG or PNG when there is a such.
 
-aFilterData[aFilterData.getLength() - 1].Value <<= 1;
+aFilterData.getArray()[aFilterData.getLength() - 1].Value <<= 1;
 #endif
 vcl::PNGWriter aPNGWriter(rBitmapEx, );
 

[Libreoffice-bugs] [Bug 145921] Crash in: SfxItemSet::Get(unsigned short, bool) - EDITING

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145921

Julien Nabet  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #6 from Julien Nabet  ---
Yes EOL is for "End Of Life" and "repro" for "reproduce".
Meanwhile, there have been 7.1.8 and 7.2.4 because of an CVE ("Common
Vulnerabilities and Exposures").
Would it be possible you find a step by step process to reproduce the crash
with 7.1.8 or 7.2.4?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145998] Page styles in Writer document revert to previous settings after reopening the document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145998

--- Comment #4 from Gregory Amato  ---
(In reply to Ezinne from comment #1)
> Please, can you attach the sample file for testing?

The file is attached. I am uncertain if I need to do anything else. I have
changed the bug status back to UNCONFIRMED.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: framework/source

[Mike Kaganski (via logerrit)]

 framework/source/uielement/recentfilesmenucontroller.cxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 866b569b58a13dab2da247aef70822933353663c
Author: Mike Kaganski 
AuthorDate: Thu Dec 16 16:51:12 2021 +0100
Commit: Mike Kaganski 
CommitDate: Thu Dec 16 21:28:09 2021 +0100

tdf#146219: don't try to detect if a recent file is a directory

This avoids accessing (possibly unavailable) remote URLs,
when we already know that MRU items are files.

Change-Id: I97e07f007d4129b93b4939311c67cf95de6ff836
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126943
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/framework/source/uielement/recentfilesmenucontroller.cxx 
b/framework/source/uielement/recentfilesmenucontroller.cxx
index 897e3f55a916..f96621ece94b 100644
--- a/framework/source/uielement/recentfilesmenucontroller.cxx
+++ b/framework/source/uielement/recentfilesmenucontroller.cxx
@@ -210,7 +210,9 @@ void RecentFilesMenuController::fillPopupMenu( Reference< 
css::awt::XPopupMenu >
 rPopupMenu->insertItem(sal_uInt16( i+1 ), 
aMenuShortCut.makeStringAndClear(), 0, -1);
 
 if ( bIsIconsAllowed ) {
-BitmapEx aThumbnail(SvFileInformationManager::GetImageId(aURL, 
false));
+// tdf#146219: don't use SvFileInformationManager::GetImageId,
+// which needs to access the URL to detect if it's a directory
+BitmapEx 
aThumbnail(SvFileInformationManager::GetFileImageId(aURL));
 rPopupMenu->setItemImage(sal_uInt16(i + 1), 
Graphic(aThumbnail).GetXGraphic(), false);
 }
 

[Libreoffice-bugs] [Bug 145929] Crash swlo!sw::MetaFieldManager::getDocumentProperties+0x886c (like related to SwFntCache)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145929

Julien Nabet  changed:

   What|Removed |Added

 Attachment #176551|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145929] Crash swlo!sw::MetaFieldManager::getDocumentProperties+0x886c (like related to SwFntCache)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145929

Julien Nabet  changed:

   What|Removed |Added

 CC||nem...@numbertext.org

--- Comment #8 from Julien Nabet  ---
László: thought you might be interested in this one. (see last bt retrieved).
(build with 42448f48bb48a13d6618a181b12840db6d85c574)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145929] Crash swlo!sw::MetaFieldManager::getDocumentProperties+0x886c (like related to SwFntCache)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145929

--- Comment #7 from Julien Nabet  ---
Created attachment 176973
  --> https://bugs.documentfoundation.org/attachment.cgi?id=176973=edit
bt with debug symbols

On pc Debian x86-64 with master sources updated today, I got an assertion.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146274] New: Undo after search-and-replace is br0ken

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146274

Bug ID: 146274
   Summary: Undo after search-and-replace is br0ken
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mikekagan...@hotmail.com

In a new Writer document, create this text:

1
2
3
4
5
6
7

- i.e., 7 paragraphs, one character each.
Select all, Ctrl+H, In selection, Regular expressions, Diacritic-sensitive,
Find $, replace , (single comma character), Replace All.

The text changes to expected

1,2,3,4,5,6,7

Undo

The text changes to unexpected

1234567
(and 6 empty paragraphs below)

Redo

The text changes to

1,,

Undo two times, then redo

!!br0ken!! appears.

Seen with Version: 7.2.4.1 (x64) / LibreOffice Community
Build ID: 27d75539669ac387bb498e35313b970b7fe9c4f9
CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: CL

and with Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 57ad86fec9e5b4981332392bdb5c5a1f5e468bfe
CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL

(the latter DBGUTIL build shows failing assertion on some step).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140805] FIND TOOLBAR: Incremental/Type-ahead search in Writer should be supported

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140805

--- Comment #5 from hgkamath  ---

I want to document a negative aspect about this feature that am implementation
should safeguard against, if LibreOffice contributors were to implement it.

As of today, google-docs does not have a way of toggling-off
incremental-search/find. So while incremental-search/find is very useful when
it is quick, it can be frustrating if it makes the user wait on account of
searching with the typing of every character.  

One and two-letter prefix-strings happen more often in a document than longer
prefix-strings. Hence, when a user types only '1' or '2' characters, the
incremental search/find races ahead and searches through the document finding
all occurrences of the prefix typed so far, highlights them, and positions the
cursor at the first-next-found-item. This can be **very slow** if the length of
the document is very large i.e. has a a huge word count. Consider for example
if one the user was searching for 'antelope', and typed the letters 'a' 'n' 't'
'e' in the search-dialog, it would give rise to searches 'a, 'an', 'ant',
'ante' with the typing of each character. Each additional character eliminates
from the set of all found strings. On the other hand, pressing backspace
increases the number of found strings. The amount of processing will freeze the
browser tab. 

The problem is caused not by the textual-search through the in-memory text
representation, but by the GUI rich-text-background-renderings which need to
updated with any change in the search-field.

Hence, the following user controls are also required for this feature
- in preferences: boolean: checkbox: a way to toggle it off by default
- in preferences: integer: number of characters: specify number of characters a
user has to enter before incremental search kicks in.
- in preferences: integer: time delay in seconds: specify number of seconds
that should pass after the last typed-character before incremental search kicks
in.
- in find/replace dialog: boolean: checkbox: a way to toggle it on/off, which
is initially set to the default as set in the preferences.

Other smarts that need to be built in. 
- the search should detect when it is being cancelled and be quickly
cancel-able, or highlight only as much of the text as could be found in the
time provided.
- parallelization: the incremental search should not make the user wait to type
the next character


Heiko Tietze in Comment 4, may have confused incremental-search with google's
instant-search. 
  Google-s instant-search is an AJAX technology based online query, which in
addition to executing a partial search for updating the shown google results,
it also provides in a drop-down box, suggested auto-completions. These
suggestion are generated using probabilistic methods of predicting text based
on existing text and past searches, and may even provide spelling correction.
It does not have to be exhaustive, It only just has to be a short list of most
likely completions to populate the drop-drown box. 

  In contrast, simple editor based find-dialog incremental-search, does not
have to do make predictions for autocomplete or provide search-suggestions. It
does not have to do spelling corrections, but it has to be exhaustive as
possible not missing any occurrence. Implementation of incremental-search is
much simpler. It is just a immediately executed prefix-search through the text.
The found-results are visually cued to the author by changing the background of
the found text strings. The author is thus enabled to quickly see/spot the
surrounding occurrences, both before and after the cursor location, boosting
productivity.

Suppose the user's current system color theme is of blue shading. The
background current found string will have dark blue background. Other nearby
occurrences of the string will have light-blue background. So when the user
presses next/prev in the find/search dialog box, the cursor is moved to the
next occurrence of the string, and the text-backgrounds of the found-strings
are accordingly updated.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146248] Crash at undo header swlo!sw::XTextRangeToSwPaM+0x5f9:

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146248

László Németh  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |nem...@numbertext.org
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 113546] [META] Paragraph indent bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113546
Bug 113546 depends on bug 101534, which changed state.

Bug 101534 Summary: EDITING: paragraph in specific document (content from 
external source?) changes indent when copying and pasting from and to same 
paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=101534

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 102593] [META] Paste bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102593
Bug 102593 depends on bug 101534, which changed state.

Bug 101534 Summary: EDITING: paragraph in specific document (content from 
external source?) changes indent when copying and pasting from and to same 
paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=101534

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142043] Correct spelling wrongly flagged

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142043

Justin L  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146245] LO Writer: list of fields in the Navigator

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146245

--- Comment #2 from Christian Lehmann  ---
I am afraid I don't understand the instruction. Anyway, the URL of the
attachment is:
https://bugs.documentfoundation.org/attachment.cgi?id=165096=edit

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/qa

[Stephan Bergmann (via logerrit)]

 sc/qa/unit/data/functions/statistical/fods/forecast.ets.mult.fods |8 

 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 57ad86fec9e5b4981332392bdb5c5a1f5e468bfe
Author: Stephan Bergmann 
AuthorDate: Thu Dec 16 15:39:16 2021 +0100
Commit: Stephan Bergmann 
CommitDate: Thu Dec 16 19:23:51 2021 +0100

Allow for some variance in results of some more Calc function calls

...similar to 04215f03492f6fce83d6bc64491749bf803c389a "Allow for presumably
more precices results of some more Calc function calls", this time with
gcc-c++-11.2.1-7.fc35.aarch64 and -O2:

* row 74: actual 236.965090983394 vs. expected 236.965090983393
* row 75: actual 232.103818773718 vs. expected 232.103818773717
* row 84: actual 226.508770412418 vs. expected 226.508770412417
* row 85: actual 238.902033404946 vs. expected 238.902033404945

Change-Id: I348623fdd5c4c851cd002f1d62c5a8867b32e325
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126950
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/sc/qa/unit/data/functions/statistical/fods/forecast.ets.mult.fods 
b/sc/qa/unit/data/functions/statistical/fods/forecast.ets.mult.fods
index 9654571a2828..7ff8956673f6 100644
--- a/sc/qa/unit/data/functions/statistical/fods/forecast.ets.mult.fods
+++ b/sc/qa/unit/data/functions/statistical/fods/forecast.ets.mult.fods
@@ -8884,7 +8884,7 @@
  
   236.965091
  
- 
+ 
   TRUE
  
  
@@ -8912,7 +8912,7 @@
  
   232.103819
  
- 
+ 
   TRUE
  
  
@@ -9150,7 +9150,7 @@
  
   226.508770412417
  
- 
+ 
   TRUE
  
  
@@ -9176,7 +9176,7 @@
  
   238.902033404945
  
- 
+ 
   TRUE
  
  

[Libreoffice-bugs] [Bug 113546] [META] Paragraph indent bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113546
Bug 113546 depends on bug 101534, which changed state.

Bug 101534 Summary: EDITING: paragraph in specific document (content from 
external source?) changes indent when copying and pasting from and to same 
paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=101534

   What|Removed |Added

 Status|VERIFIED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 102593] [META] Paste bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102593
Bug 102593 depends on bug 101534, which changed state.

Bug 101534 Summary: EDITING: paragraph in specific document (content from 
external source?) changes indent when copying and pasting from and to same 
paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=101534

   What|Removed |Added

 Status|VERIFIED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 137756] Words stress are added incorrectly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137756

Justin L  changed:

   What|Removed |Added

Version|7.0.2.2 release |unspecified

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 90806] CALC: Borders should be automatically added when border style or color are set

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90806

Justin L  changed:

   What|Removed |Added

 CC||jl...@mail.com

--- Comment #6 from Justin L  ---
Code pointer: http://gerrit.libreoffice.org/c/core/+/126959

This patch is acting very inconsistently for me.
The first time I use it, most intermediate rows will
also have the horizontal border set. But on subsequent
selections (or an undo / re-apply) then only the
outside borders are affected. I don't know why.

So I'm just throwing this out there are a code
pointer. Calc is too weird.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146248] Crash at undo header swlo!sw::XTextRangeToSwPaM+0x5f9:

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146248

Julien Nabet  changed:

   What|Removed |Added

   Keywords|wantBacktrace   |haveBacktrace

-- 
You are receiving this mail because:
You are the assignee for the bug.