[Libreoffice-bugs] [Bug 146332] "Format > Conditional Formatting > Condition > New Style" dialogue disappears and Calc hangs after switching to Writer window
https://bugs.documentfoundation.org/show_bug.cgi?id=146332 Kevin Suo changed: What|Removed |Added Version|7.4.0.0 alpha0+ Master |7.2.4.1 release -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146332] New: "Format > Conditional Formatting > Condition > New Style" dialogue disappears and Calc hangs after switching to Writer window
https://bugs.documentfoundation.org/show_bug.cgi?id=146332 Bug ID: 146332 Summary: "Format > Conditional Formatting > Condition > New Style" dialogue disappears and Calc hangs after switching to Writer window Product: LibreOffice Version: 7.4.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: major Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: suokunl...@126.com Steps to Reproduce: 1. New Calc, then New Writer. 2. In Calc window, click "Format > Conditional Formatting > Condition". The conditional formatting dialogue appears. 3. On this conditinal formatting dialogue, click the dropdown list of "Use style", then select "New Style". 4. Switch to the Writer window. Then switch back to the Calc window. --> The conditional formatting dialogue disappears, and Calc hangs (the hang may be because it is waiting for the conditional formatting dialog to close). Now it is possible to close the Writer window, but you are not able to close the Calc window. The only way to make it back to normal is to kill the soffice process. During testing you may sometimes encounter a crash when you switching the window back and forth in step 4, but I do not find the clear steps to make it crash. Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 29145df0977baa866e7da94d1d385b772ae1e6ce CPU threads: 8; OS: Linux 5.14; UI render: default; VCL: gtk3 Locale: zh-CN (zh_CN.UTF-8); UI: zh-CN Build Platform: Fedora34@X64, Branch:master, bibisect-linux-64-7.4-CN Calc: threaded Also in: Version: 7.2.4.1 / LibreOffice Community Build ID: 27d75539669ac387bb498e35313b970b7fe9c4f9 CPU threads: 8; OS: Linux 5.14; UI render: default; VCL: gtk3 Locale: zh-CN (zh_CN.UTF-8); UI: zh-CN Calc: threaded Fedora 34 x64, gtk3, Wayland. Someone else has also reproduced this on Windows. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 130788] Impress: Adding a New Column to a Table Formats as Bulletted Text Some Cells If Row Had Text
https://bugs.documentfoundation.org/show_bug.cgi?id=130788 --- Comment #15 from raal --- *** Bug 146127 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 100366] [META] Impress/Draw table bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=100366 Bug 100366 depends on bug 146127, which changed state. Bug 146127 Summary: Inserting new row in table loses text and paragraph formatting in the first column of new row https://bugs.documentfoundation.org/show_bug.cgi?id=146127 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146127] Inserting new row in table loses text and paragraph formatting in the first column of new row
https://bugs.documentfoundation.org/show_bug.cgi?id=146127 raal changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #7 from raal --- *** This bug has been marked as a duplicate of bug 130788 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146127] Inserting new row in table loses text and paragraph formatting in the first column of new row
https://bugs.documentfoundation.org/show_bug.cgi?id=146127 raal changed: What|Removed |Added Keywords|bibisectRequest |bibisected, bisected CC||armin.le.gr...@me.com, ||r...@post.cz --- Comment #6 from raal --- (In reply to Rainer Bielefeld Retired from comment #5) > I wonder whether this also started with > https://bugs.documentfoundation.org/show_bug.cgi?id=130788#c6 Yes, add Armin to CC author Armin Le Grand 2018-03-01 15:54:32 +0100 committer Armin Le Grand 2018-04-06 22:29:02 +0200 commit 6c14c27c75a03e2363f2b363ddf0a6f2f46cfa91 (patch) treee66f50adb222dbc1490b4df2d3c63541dad999ac parent e1b247a843c5eb850fe0079819239d9883412d38 (diff) SOSAW080: Added first bunch of basic changes to helpers -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: chart2/source cui/qa cui/source include/svx reportdesign/source svx/source
chart2/source/controller/sidebar/ChartColorWrapper.cxx |4 -
chart2/source/controller/sidebar/ChartColorWrapper.hxx |2
cui/qa/uitest/dialogs/chardlg.py | 66 +
cui/source/tabpages/chardlg.cxx| 22 -
cui/source/tabpages/themepage.cxx | 14 +++
include/svx/Palette.hxx| 20 -
include/svx/PaletteManager.hxx |4 -
include/svx/colorbox.hxx | 11 +-
include/svx/tbcontrl.hxx |2
reportdesign/source/ui/dlg/Condition.cxx |4 -
reportdesign/source/ui/dlg/Condition.hxx |2
svx/source/tbxctrls/Palette.cxx| 13 +++
svx/source/tbxctrls/PaletteManager.cxx | 36 +
svx/source/tbxctrls/tbcontrl.cxx | 33
14 files changed, 183 insertions(+), 50 deletions(-)
New commits:
commit 7d5984d7aed2bafcb599882b66bb0dde2d22ff3f
Author: Miklos Vajna
AuthorDate: Mon Dec 20 08:46:40 2021 +0100
Commit: Miklos Vajna
CommitDate: Mon Dec 20 11:31:53 2021 +0100
sd theme: allow setting the color's theme index in the chardlg
This routes not only the rgb color and a name, but also a theme index
from the color picker to the chardlg (only there as a start).
That way the picked color will be updated if the master page theme
changes.
Change-Id: I7a45d7cf63c7c36013e4656c66d9b2dbc3aa0b88
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127135
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/chart2/source/controller/sidebar/ChartColorWrapper.cxx
b/chart2/source/controller/sidebar/ChartColorWrapper.cxx
index 9340ed1c2028..08fbcdb1b6a9 100644
--- a/chart2/source/controller/sidebar/ChartColorWrapper.cxx
+++ b/chart2/source/controller/sidebar/ChartColorWrapper.cxx
@@ -85,7 +85,7 @@ ChartColorWrapper::ChartColorWrapper(
{
}
-void ChartColorWrapper::operator()([[maybe_unused]] const OUString& , const
NamedColor& rColor)
+void ChartColorWrapper::operator()([[maybe_unused]] const OUString& , const
svx::NamedThemedColor& rColor)
{
css::uno::Reference xPropSet =
getPropSet(mxModel);
@@ -95,7 +95,7 @@ void ChartColorWrapper::operator()([[maybe_unused]] const
OUString& , const Name
return;
}
-xPropSet->setPropertyValue(maPropertyName,
css::uno::makeAny(rColor.first));
+xPropSet->setPropertyValue(maPropertyName,
css::uno::makeAny(rColor.m_aColor));
}
void ChartColorWrapper::updateModel(const
css::uno::Reference& xModel)
diff --git a/chart2/source/controller/sidebar/ChartColorWrapper.hxx
b/chart2/source/controller/sidebar/ChartColorWrapper.hxx
index 66c880ae3ca2..694c5a9f7786 100644
--- a/chart2/source/controller/sidebar/ChartColorWrapper.hxx
+++ b/chart2/source/controller/sidebar/ChartColorWrapper.hxx
@@ -26,7 +26,7 @@ public:
SvxColorToolBoxControl* pControl,
const OUString& rPropertyName);
-void operator()(const OUString& rCommand, const NamedColor& rColor);
+void operator()(const OUString& rCommand, const svx::NamedThemedColor&
rColor);
// ColorSelectFunction signature
void updateModel(const css::uno::Reference& xModel);
diff --git a/cui/qa/uitest/dialogs/chardlg.py b/cui/qa/uitest/dialogs/chardlg.py
index 49adfe6d9980..c49c08dbc687 100644
--- a/cui/qa/uitest/dialogs/chardlg.py
+++ b/cui/qa/uitest/dialogs/chardlg.py
@@ -8,6 +8,7 @@ from libreoffice.uno.propertyvalue import mkPropertyValues
from uitest.framework import UITestCase
from uitest.uihelper.common import select_pos
from uitest.uihelper.common import get_state_as_dict
+from uitest.uihelper.common import select_by_text
# Test for cui/source/tabpages/chardlg.cxx.
class Test(UITestCase):
@@ -43,6 +44,71 @@ class Test(UITestCase):
# COL_AUTO.
self.assertEqual(shape.CharTransparence, 5)
+def testSvxCharEffectsPageTheme(self):
+# Given a document with a document theme:
+# Start Impress.
+with self.ui_test.create_doc_in_start_center("impress") as component:
+template = self.xUITest.getTopFocusWindow()
+
self.ui_test.close_dialog_through_button(template.getChild("close"))
+doc = self.xUITest.getTopFocusWindow()
+editWin = doc.getChild("impress_win")
+
+# Set theme colors.
+drawPage = component.getDrawPages().getByIndex(0)
+master = drawPage.MasterPage
+theme = mkPropertyValues({
+"Name": "nameA",
+"ColorSchemeName": "colorSetA",
+"ColorScheme": tuple([
+0x00, # dk1
+0x00, # lt1
+0x00, # dk2
+0x00, # lt2
+0x00, # accent1
+0x00, #
[Libreoffice-bugs] [Bug 146286] Crash/hang calling context menu
https://bugs.documentfoundation.org/show_bug.cgi?id=146286 Julien Nabet changed: What|Removed |Added CC||raindrops.from...@gmail.com --- Comment #12 from Julien Nabet --- *** Bug 146324 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146324] when Writer detects a spelling mistake, it does not allow us to right-click on the misspelled word
https://bugs.documentfoundation.org/show_bug.cgi?id=146324 Julien Nabet changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE CC||serval2...@yahoo.fr --- Comment #1 from Julien Nabet --- I suppose it's a dup of tdf#146286 If you still reproduce this with a build which includes 54b80473f4a4b8ac3dfc1936b2214733474a3485, don't hesitate to reopen this tracker. *** This bug has been marked as a duplicate of bug 146286 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146331] Writer: Enumerated Lists start from "1" again after switching to Symbols for Subitems
https://bugs.documentfoundation.org/show_bug.cgi?id=146331 hawk17 changed: What|Removed |Added Keywords||filter:odt -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146331] New: Writer: Enumerated Lists start from "1" again after switching to Symbols for Subitems
https://bugs.documentfoundation.org/show_bug.cgi?id=146331 Bug ID: 146331 Summary: Writer: Enumerated Lists start from "1" again after switching to Symbols for Subitems Product: LibreOffice Version: 7.2.4.1 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: amanita+bugzi...@mailbox.org Description: When creating a List like this: 1. Libre 2. Office 3. is - really 1. awesome! and switching from "F12" (enumerated) to "Shift+F12" (Symbols), and after the Subitem switching back, the Enumeration starts again, instead of going on. When changing the in that case "4" to a symbol and having already inserted the point "5", the "5" changes to a "4" as it should, like this: 1. Test1. Test 2. Test > 2. Test 3. a - a 4. b 3. b Steps to Reproduce: 1. Make an enumerated List 2. after one number, change to a symbol 3. change back to number, it starts by "1" again Actual Results: A change to "symbol" enumeration resets the number to 1 again Expected Results: It should do nothing and the enumeration should continue Reproducible: Always User Profile Reset: No Additional Info: Libreoffice Flatpak version newest -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140820] Should there be a "Default Frame Style", which each builtin Frame Style "Inherits from"?
https://bugs.documentfoundation.org/show_bug.cgi?id=140820 --- Comment #10 from Mike Kaganski --- (In reply to Heiko Tietze from comment #8) Why would it not apply to frames? Frames support inheritance, so user has an option to create own hierarchy. Also the reset button works even when there's no parent - it resets to global defaults. It *could* be reasonable to change the title dynamically - either to mention parent, or defaults... but IMO the better would be to revert the recent rename, and instead provide good tooltip explaining what it does depending on inheritance. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 140820] Should there be a "Default Frame Style", which each builtin Frame Style "Inherits from"?
https://bugs.documentfoundation.org/show_bug.cgi?id=140820 --- Comment #10 from Mike Kaganski --- (In reply to Heiko Tietze from comment #8) Why would it not apply to frames? Frames support inheritance, so user has an option to create own hierarchy. Also the reset button works even when there's no parent - it resets to global defaults. It *could* be reasonable to change the title dynamically - either to mention parent, or defaults... but IMO the better would be to revert the recent rename, and instead provide good tooltip explaining what it does depending on inheritance. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-ux-advise] [Bug 140820] Should there be a "Default Frame Style", which each builtin Frame Style "Inherits from"?
https://bugs.documentfoundation.org/show_bug.cgi?id=140820 --- Comment #9 from Heiko Tietze --- (In reply to Mike Kaganski from comment #7) > I would propose to rename (again) "No Character Style" to "Paragraph > Properties", and make it grey in list. Sounds good to me, perhaps "Follow Paragraph Properties". But why "again"? Haven't read this idea before. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 140820] Should there be a "Default Frame Style", which each builtin Frame Style "Inherits from"?
https://bugs.documentfoundation.org/show_bug.cgi?id=140820 --- Comment #9 from Heiko Tietze --- (In reply to Mike Kaganski from comment #7) > I would propose to rename (again) "No Character Style" to "Paragraph > Properties", and make it grey in list. Sounds good to me, perhaps "Follow Paragraph Properties". But why "again"? Haven't read this idea before. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146215] Wizard to quickly insert interactive check boxes
https://bugs.documentfoundation.org/show_bug.cgi?id=146215 Cor Nouws changed: What|Removed |Added CC||c...@nouenoff.nl --- Comment #6 from Cor Nouws --- Andreas: I think I understand your idea. Heiko: The section here https://docs.github.com/en/issues/tracking-your-work-with-issues/about-task-lists#creating-task-lists shows how it is used. Andreas: for having the 'check' boxes, you can create your own autoCorrect entries of course. But then, that does not allow any TOC of check boxes of course. I think it makes fun - but wonder how many would use it ;) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 140820] Should there be a "Default Frame Style", which each builtin Frame Style "Inherits from"?
https://bugs.documentfoundation.org/show_bug.cgi?id=140820 --- Comment #8 from Heiko Tietze --- So how about disabling the Standard button in case of frames (and where ever it also wont apply), Seth? -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 140820] Should there be a "Default Frame Style", which each builtin Frame Style "Inherits from"?
https://bugs.documentfoundation.org/show_bug.cgi?id=140820 --- Comment #8 from Heiko Tietze --- So how about disabling the Standard button in case of frames (and where ever it also wont apply), Seth? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: i18npool/source
i18npool/source/localedata/localedata.cxx | 44 ++
1 file changed, 16 insertions(+), 28 deletions(-)
New commits:
commit 24ea26f55ee4e8a3c69b6dc9911a8c42e56f1eb2
Author: Noel Grandin
AuthorDate: Sat Dec 18 20:38:04 2021 +0200
Commit: Noel Grandin
CommitDate: Mon Dec 20 11:00:27 2021 +0100
pass by ref in lcl_LookupTableStatic
rather than passing by pointer and then asserting that the
pointer is not null
Change-Id: I8df464ca2ae770ab343417fe1b15c378c88110d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127111
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/i18npool/source/localedata/localedata.cxx
b/i18npool/source/localedata/localedata.cxx
index 6b02040efc0a..666858fcb3cf 100644
--- a/i18npool/source/localedata/localedata.cxx
+++ b/i18npool/source/localedata/localedata.cxx
@@ -488,7 +488,7 @@ public:
oslGenericFunction getFunctionSymbolByName(
const OUString& localeName, const char* pFunction,
-std::unique_ptr* pOutCachedItem );
+std::unique_ptr& rOutCachedItem );
private:
::osl::Mutex maMutex;
@@ -519,7 +519,7 @@ lcl_LookupTableHelper::~lcl_LookupTableHelper()
oslGenericFunction lcl_LookupTableHelper::getFunctionSymbolByName(
const OUString& localeName, const char* pFunction,
-std::unique_ptr* pOutCachedItem )
+std::unique_ptr& rOutCachedItem )
{
OUString aFallback;
bool bFallback = (localeName.indexOf( cUnder) < 0);
@@ -546,18 +546,12 @@ oslGenericFunction
lcl_LookupTableHelper::getFunctionSymbolByName(
{
if (rCurrent.dllName == i.pLib)
{
-OSL_ASSERT( pOutCachedItem );
-if( pOutCachedItem )
-{
-(*pOutCachedItem).reset(new
LocaleDataLookupTableItem( rCurrent ));
-(*pOutCachedItem)->localeName = i.pLocale;
-OString sSymbolName = OString::Concat(pFunction) +
"_" +
-(*pOutCachedItem)->localeName;
-return
(*pOutCachedItem)->module->getFunctionSymbol(
-sSymbolName.getStr());
-}
-else
-return nullptr;
+rOutCachedItem.reset(new LocaleDataLookupTableItem(
rCurrent ));
+rOutCachedItem->localeName = i.pLocale;
+OString sSymbolName = OString::Concat(pFunction) + "_"
+
+rOutCachedItem->localeName;
+return rOutCachedItem->module->getFunctionSymbol(
+sSymbolName.getStr());
}
}
}
@@ -575,20 +569,14 @@ oslGenericFunction
lcl_LookupTableHelper::getFunctionSymbolByName(
::osl::MutexGuard aGuard( maMutex );
auto pTmpModule = module.get();
maLookupTable.emplace_back(i.pLib, module.release(),
i.pLocale);
-OSL_ASSERT( pOutCachedItem );
-if( pOutCachedItem )
-{
-pOutCachedItem->reset(new LocaleDataLookupTableItem(
maLookupTable.back() ));
-OString sSymbolName = OString::Concat(pFunction) + "_" +
(*pOutCachedItem)->localeName;
-return pTmpModule->getFunctionSymbol(sSymbolName.getStr());
-}
-else
-return nullptr;
+rOutCachedItem.reset(new LocaleDataLookupTableItem(
maLookupTable.back() ));
+OString sSymbolName = OString::Concat(pFunction) + "_" +
rOutCachedItem->localeName;
+return pTmpModule->getFunctionSymbol(sSymbolName.getStr());
}
else
module.reset();
#else
-(void) pOutCachedItem;
+(void) rOutCachedItem;
if( strcmp(pFunction, "getAllCalendars") == 0 )
return i.getAllCalendars;
@@ -1452,13 +1440,13 @@ oslGenericFunction LocaleDataImpl::getFunctionSymbol(
const Locale& rLocale, con
// Load function with name __ or _ and
// fallbacks.
pSymbol = rLookupTable.getFunctionSymbolByName(
LocaleDataImpl::getFirstLocaleServiceName( rLocale),
-pFunction, );
+pFunction, pCachedItem);
if (!pSymbol)
{
::std::vector< OUString > aFallbacks(
LocaleDataImpl::getFallbackLocaleServiceNames( rLocale));
for (const auto& rFallback : aFallbacks)
{
-pSymbol = rLookupTable.getFunctionSymbolByName(rFallback,
pFunction, );
+pSymbol = rLookupTable.getFunctionSymbolByName(rFallback,
pFunction, pCachedItem);
if (pSymbol)
break;
}
@@ -1466,7 +1454,7 @@ oslGenericFunction
[Libreoffice-bugs] [Bug 140820] Should there be a "Default Frame Style", which each builtin Frame Style "Inherits from"?
https://bugs.documentfoundation.org/show_bug.cgi?id=140820 --- Comment #7 from Mike Kaganski --- (In reply to Mike Kaganski from comment #6) By the way, *mostly* unrelated, but which IMO would make the distinction clear: I would propose to rename (again) "No Character Style" to "Paragraph Properties", and make it grey in list. That would show the unique nature and real purpose of this pseudo-style, and also allow to see why this metaphor doesn't fit in case of other styles. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 140820] Should there be a "Default Frame Style", which each builtin Frame Style "Inherits from"?
https://bugs.documentfoundation.org/show_bug.cgi?id=140820 --- Comment #7 from Mike Kaganski --- (In reply to Mike Kaganski from comment #6) By the way, *mostly* unrelated, but which IMO would make the distinction clear: I would propose to rename (again) "No Character Style" to "Paragraph Properties", and make it grey in list. That would show the unique nature and real purpose of this pseudo-style, and also allow to see why this metaphor doesn't fit in case of other styles. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 146330] Image becomes empty frame when moving up
https://bugs.documentfoundation.org/show_bug.cgi?id=146330 --- Comment #1 from Telesto --- Created attachment 177028 --> https://bugs.documentfoundation.org/attachment.cgi?id=177028=edit Example file -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146330] New: Image becomes empty frame when moving up
https://bugs.documentfoundation.org/show_bug.cgi?id=146330 Bug ID: 146330 Summary: Image becomes empty frame when moving up Product: LibreOffice Version: 7.4.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Image becomes empty frame when moving up Steps to Reproduce: 1. Open the attached file 2. Select blue square 3. Press and hold arrow up until stops moving Actual Results: Full square visible Expected Results: Partly Reproducible: Always User Profile Reset: No Additional Info: Found in Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: b9c159361abd79862b30412c433fb355d63299e2 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL still OK with Version: 7.3.0.0.alpha1+ (x64) / LibreOffice Community Build ID: 7b0aabe71d2455f6f643553a07f1056935cf190f CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 92380] Style preview rendering problems in the dialog, toolbar and sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=92380 --- Comment #45 from Heiko Tietze --- What do you expect from 5% font size and/or white font on white background? We could use a minimum font size of 9pt, or the like, on the Stylist and ignore values below. But is this really wanted? I mean there might be a reason to reduce the font size to an unreadable value. (We have some maximum value right now, btw.) When it comes to colors we decided to show what is configured. So white on white produces a white-out same as black on black (or very dark). Using "Automatic" shows the font either in white or black depending on the brightness of the background. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140820] Should there be a "Default Frame Style", which each builtin Frame Style "Inherits from"?
https://bugs.documentfoundation.org/show_bug.cgi?id=140820 --- Comment #6 from Mike Kaganski --- (In reply to Heiko Tietze from comment #5) > I wonder if we could just show the None or No Frame Style or Default Frame > Style in the list without touching the inheritance. Can we, Mike? This is basically what comment 1 suggests: > In the 'Inherit From' dropdown box "- None -" should be removed and "Default > Frame Style" should be added. But this is wrong or not easy. The suggestion tries to mimic fake default character style, but the latter is the metaphor for "nothing set; inherit everything from paragraph". So "nothing set on character style level" has a well-defined source for each character property. In case of other styles, like frame styles (and paragraph styles btw), the root of inheritance takes all its *fallback* values from global defaults. The "fake default" would have to show all the global defaults, even if not modifiable. Being unable to modify those would raise questions (valid btw, since hardcoded defaults is poor IMO). That would raise need of exposing the global defaults also on paragraph styles, since current "default" paragraph style is a proper style. If you instead introduce a normal "default" frame style, you will need to keep None, since being able to have multiple style hierarchies is a feature. And that introduced default style would still define nothing in itself, so it will still fallback to global defaults, so the (imagined IMO) problem discussed here will stay. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 140820] Should there be a "Default Frame Style", which each builtin Frame Style "Inherits from"?
https://bugs.documentfoundation.org/show_bug.cgi?id=140820 --- Comment #6 from Mike Kaganski --- (In reply to Heiko Tietze from comment #5) > I wonder if we could just show the None or No Frame Style or Default Frame > Style in the list without touching the inheritance. Can we, Mike? This is basically what comment 1 suggests: > In the 'Inherit From' dropdown box "- None -" should be removed and "Default > Frame Style" should be added. But this is wrong or not easy. The suggestion tries to mimic fake default character style, but the latter is the metaphor for "nothing set; inherit everything from paragraph". So "nothing set on character style level" has a well-defined source for each character property. In case of other styles, like frame styles (and paragraph styles btw), the root of inheritance takes all its *fallback* values from global defaults. The "fake default" would have to show all the global defaults, even if not modifiable. Being unable to modify those would raise questions (valid btw, since hardcoded defaults is poor IMO). That would raise need of exposing the global defaults also on paragraph styles, since current "default" paragraph style is a proper style. If you instead introduce a normal "default" frame style, you will need to keep None, since being able to have multiple style hierarchies is a feature. And that introduced default style would still define nothing in itself, so it will still fallback to global defaults, so the (imagined IMO) problem discussed here will stay. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - include/oox oox/qa oox/source
include/oox/vml/vmlshape.hxx |6 ++
oox/qa/unit/data/watermark.docx|binary
oox/qa/unit/vml.cxx| 22 ++
oox/source/vml/vmlshape.cxx|7 +++
oox/source/vml/vmlshapecontext.cxx | 28
5 files changed, 63 insertions(+)
New commits:
commit 3c4abdfe2032ebb1c9de4e55d42d27546e9b2842
Author: Miklos Vajna
AuthorDate: Thu Dec 16 10:16:02 2021 +0100
Commit: Miklos Vajna
CommitDate: Mon Dec 20 10:50:29 2021 +0100
VML import: handle
Map it to (the UNO API of) GraphicDrawMode::Watermark, similar to what
the binary import does in SvxMSDffManager::ImportGraphic() and how the
drawingML import does it in
oox::drawingml::GraphicProperties::pushToPropMap().
On export, the drawingML export is used, and that already maps
GraphicDrawMode::Watermark to .
(cherry picked from commit 90556b6df0f6378fb60d7dee18b2f5d275ece530)
Conflicts:
oox/qa/unit/vml.cxx
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126949
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Mike Kaganski
Conflicts:
oox/source/vml/vmlshape.cxx
Change-Id: I33986a03bf3d3863da5c5b1f0a2e0da0fa595c9e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127136
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Miklos Vajna
diff --git a/include/oox/vml/vmlshape.hxx b/include/oox/vml/vmlshape.hxx
index 2b3677df106d..1e9f000a41e8 100644
--- a/include/oox/vml/vmlshape.hxx
+++ b/include/oox/vml/vmlshape.hxx
@@ -114,6 +114,12 @@ struct OOX_DLLPUBLIC ShapeTypeModel
OptValue moCropTop; ///< Specifies how much to crop the image
from the top down as a fraction of picture size.
OUString maLayoutFlowAlt; ///< Specifies the alternate layout flow for
text in textboxes.
+/// An adjustment for the intensity of all colors, i.e. contrast, on a
0..0x1 scale.
+sal_Int32 mnGain = 0x1;
+
+/// The image brightness, on a 0..0x1 scale.
+sal_Int16 mnBlacklevel = 0;
+
explicitShapeTypeModel();
voidassignUsed( const ShapeTypeModel& rSource );
diff --git a/oox/qa/unit/data/watermark.docx b/oox/qa/unit/data/watermark.docx
new file mode 100644
index ..c9eacff9a643
Binary files /dev/null and b/oox/qa/unit/data/watermark.docx differ
diff --git a/oox/qa/unit/vml.cxx b/oox/qa/unit/vml.cxx
index 36a120dbc938..88d69492e431 100644
--- a/oox/qa/unit/vml.cxx
+++ b/oox/qa/unit/vml.cxx
@@ -18,6 +18,7 @@
#include
#include
#include
+#include
#include
#include
@@ -153,6 +154,27 @@ CPPUNIT_TEST_FIXTURE(OoxVmlTest, testGraphicStroke)
CPPUNIT_ASSERT_EQUAL(drawing::LineStyle_SOLID, eLineStyle);
}
+CPPUNIT_TEST_FIXTURE(OoxVmlTest, testWatermark)
+{
+// Given a document with a picture watermark, and the "washout" checkbox
is ticked on the Word
+// UI:
+// When loading that document:
+load(u"watermark.docx");
+
+// Then make sure the watermark effect is not lost on import:
+uno::Reference
xDrawPagesSupplier(getComponent(), uno::UNO_QUERY);
+uno::Reference
xDrawPage(xDrawPagesSupplier->getDrawPages()->getByIndex(0),
+ uno::UNO_QUERY);
+uno::Reference xShape(xDrawPage->getByIndex(0),
uno::UNO_QUERY);
+drawing::ColorMode eMode{};
+xShape->getPropertyValue("GraphicColorMode") >>= eMode;
+// Without the accompanying fix in place, this test would have failed with:
+// - Expected: 3
+// - Actual : 0
+// i.e. the color mode was STANDARD, not WATERMARK.
+CPPUNIT_ASSERT_EQUAL(drawing::ColorMode_WATERMARK, eMode);
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/oox/source/vml/vmlshape.cxx b/oox/source/vml/vmlshape.cxx
index 3dd9747f0a84..038f35ec37c5 100644
--- a/oox/source/vml/vmlshape.cxx
+++ b/oox/source/vml/vmlshape.cxx
@@ -55,6 +55,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -923,6 +924,12 @@ Reference< XShape > SimpleShape::createPictureObject(const
Reference< XShapes >&
aPropSet.setProperty(PROP_GraphicCrop, aGraphicCrop);
}
+
+if (maTypeModel.mnGain == -70 && maTypeModel.mnBlacklevel == 70)
+{
+// Map MSO 'washout' to our watermark colormode.
+aPropSet.setProperty(PROP_GraphicColorMode,
uno::makeAny(drawing::ColorMode_WATERMARK));
+}
}
return xShape;
}
diff --git a/oox/source/vml/vmlshapecontext.cxx
b/oox/source/vml/vmlshapecontext.cxx
index d27839a79084..0679362401fc 100644
--- a/oox/source/vml/vmlshapecontext.cxx
+++ b/oox/source/vml/vmlshapecontext.cxx
@@ -386,6 +386,34 @@ ContextHandlerRef ShapeTypeContext::onCreateContext(
sal_Int32 nElement, const A
mrTypeModel.moCropLeft = rAttribs.getString(XML_cropleft);
mrTypeModel.moCropRight =
[Libreoffice-bugs] [Bug 146329] New: Macro editor check (F7) unable copy value of variable
https://bugs.documentfoundation.org/show_bug.cgi?id=146329 Bug ID: 146329 Summary: Macro editor check (F7) unable copy value of variable Product: LibreOffice Version: 7.0 all versions Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: e...@helpidea.net Description: While debug basic code step by step, with check F7 I see the variable value in the bottom window. If there I selected the value, in LibreOffice 6 I was able to copy that value and then paste, now with LO 7 it is not possible. If the variable is a large string, I am able to paste it in Notepad++ end examine all. This is VERY IMPORTANT for debug. Steps to Reproduce: 1.Open macro Basic with Alt+F11 and select a macro 2.F8 and run step by step, select a variable and F7 for his value 3.In the bottom window select the variable value and context menu ... nothing Actual Results: No context menu (mouse right button) Expected Results: Open Context menu with Copy Value option Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: [Information automatically included from LibreOffice] Locale: it Module: SpreadsheetDocument Version: 7.1.8.1 (x64) / LibreOffice Community Build ID: e1f30c802c3269a1d052614453f260e49458c82c CPU threads: 16; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: it-IT (it_IT); UI: it-IT Calc: CL [Information guessed from browser] OS: Windows (All) OS is 64bit: yes -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143098] The 'Styles Preview' section in the Tabbed NB doesn't follow the system theme
https://bugs.documentfoundation.org/show_bug.cgi?id=143098 Heiko Tietze changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #12 from Heiko Tietze --- Please retest, it works well for me with black font on white background using Version: 7.2.4.1 / LibreOffice Community Build ID: 20(Build:1) CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: de-DE (en_US.UTF-8); UI: en-US 7.2.4-3 Calc: threaded (KDE with Breeze Dark) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/core/inc/frmtool.hxx|4 -
sw/source/core/layout/frmtool.cxx |8 +--
sw/source/uibase/inc/hyp.hxx | 12 ++---
sw/source/uibase/inc/unoatxt.hxx |2
sw/source/uibase/lingu/hyp.cxx| 44 ++---
sw/source/uibase/lingu/sdrhhcwrap.cxx | 70 +-
sw/source/uibase/lingu/sdrhhcwrap.hxx | 18
sw/source/uibase/uno/unoatxt.cxx | 18
8 files changed, 88 insertions(+), 88 deletions(-)
New commits:
commit 38768976f82834010f160cc234eade5ca5aeefa5
Author: Miklos Vajna
AuthorDate: Mon Dec 20 08:12:53 2021 +0100
Commit: Miklos Vajna
CommitDate: Mon Dec 20 10:39:44 2021 +0100
sw: prefix members of SdrHHCWrapper, SwAutoTextEventDescriptor, ...
... SwFlyNotify and SwHyphWrapper
See tdf#94879 for motivation.
Change-Id: Ib1508f7a97cedebd70186e379f5f7e571cd1f60a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127133
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/sw/source/core/inc/frmtool.hxx b/sw/source/core/inc/frmtool.hxx
index 1ef396a7a960..c7177379a88e 100644
--- a/sw/source/core/inc/frmtool.hxx
+++ b/sw/source/core/inc/frmtool.hxx
@@ -261,8 +261,8 @@ public:
class SwFlyNotify : public SwLayNotify
{
-SwPageFrame *pOldPage;
-const SwRect aFrameAndSpace;
+SwPageFrame *m_pOldPage;
+const SwRect m_aFrameAndSpace;
void ImplDestroy();
diff --git a/sw/source/core/layout/frmtool.cxx
b/sw/source/core/layout/frmtool.cxx
index 2b218097ec13..3a6269287e68 100644
--- a/sw/source/core/layout/frmtool.cxx
+++ b/sw/source/core/layout/frmtool.cxx
@@ -657,8 +657,8 @@ SwFlyNotify::SwFlyNotify( SwFlyFrame *pFlyFrame ) :
SwLayNotify( pFlyFrame ),
// #115759# - keep correct page frame - the page frame
// the Writer fly frame is currently registered at.
-pOldPage( pFlyFrame->GetPageFrame() ),
-aFrameAndSpace( pFlyFrame->GetObjRectWithSpaces() )
+m_pOldPage( pFlyFrame->GetPageFrame() ),
+m_aFrameAndSpace( pFlyFrame->GetObjRectWithSpaces() )
{
}
@@ -673,11 +673,11 @@ void SwFlyNotify::ImplDestroy()
{
//If in the LayAction the IsAgain is set it can be
//that the old page is destroyed in the meantime!
-::Notify( pFly, pOldPage, aFrameAndSpace, );
+::Notify( pFly, m_pOldPage, m_aFrameAndSpace, );
// #i35640# - additional notify anchor text frame,
// if Writer fly frame has changed its page
if ( pFly->GetAnchorFrame()->IsTextFrame() &&
- pFly->GetPageFrame() != pOldPage )
+ pFly->GetPageFrame() != m_pOldPage )
{
pFly->AnchorFrame()->Prepare( PrepareHint::FlyFrameLeave );
}
diff --git a/sw/source/uibase/inc/hyp.hxx b/sw/source/uibase/inc/hyp.hxx
index acec1b25f163..bbe8208f9fb8 100644
--- a/sw/source/uibase/inc/hyp.hxx
+++ b/sw/source/uibase/inc/hyp.hxx
@@ -28,12 +28,12 @@ class SwView;
class SW_DLLPUBLIC SwHyphWrapper final : public SvxSpellWrapper {
private:
-SwView* pView;
-sal_uInt16 nPageCount; // page count for progress view
-sal_uInt16 nPageStart; // 1st checked page
-boolbInSelection : 1; // separating selected text
-boolbAutomatic : 1; // insert separators without further
inquiry
-boolbInfoBox : 1; // display info-box when ending
+SwView* m_pView;
+sal_uInt16 m_nPageCount; // page count for progress view
+sal_uInt16 m_nPageStart; // 1st checked page
+boolm_bInSelection : 1; // separating selected text
+boolm_bAutomatic : 1; // insert separators without further
inquiry
+boolm_bInfoBox : 1; // display info-box when ending
virtual void SpellStart( SvxSpellArea eSpell ) override;
virtual void SpellContinue() override;
diff --git a/sw/source/uibase/inc/unoatxt.hxx b/sw/source/uibase/inc/unoatxt.hxx
index 376b1dced7c5..633a0630a4b2 100644
--- a/sw/source/uibase/inc/unoatxt.hxx
+++ b/sw/source/uibase/inc/unoatxt.hxx
@@ -239,7 +239,7 @@ public:
/** Implement the XNameAccess for the AutoText events */
class SwAutoTextEventDescriptor final : public SvBaseEventDescriptor
{
-SwXAutoTextEntry& rAutoTextEntry;
+SwXAutoTextEntry& m_rAutoTextEntry;
using SvBaseEventDescriptor::replaceByName;
using SvBaseEventDescriptor::getByName;
diff --git a/sw/source/uibase/lingu/hyp.cxx b/sw/source/uibase/lingu/hyp.cxx
index d7d0c87a5bc4..7a9a21b9ca82 100644
--- a/sw/source/uibase/lingu/hyp.cxx
+++ b/sw/source/uibase/lingu/hyp.cxx
@@ -31,7 +31,7 @@
#include
-#define PSH (>GetWrtShell())
+#define PSH (_pView->GetWrtShell())
using namespace ::com::sun::star;
@@ -40,44 +40,44 @@ SwHyphWrapper::SwHyphWrapper( SwView* pVw,
uno::Reference< linguistic2::XHyphenator > const ,
bool bStart, bool
[Libreoffice-bugs] [Bug 140820] Should there be a "Default Frame Style", which each builtin Frame Style "Inherits from"?
https://bugs.documentfoundation.org/show_bug.cgi?id=140820 Heiko Tietze changed: What|Removed |Added CC||mikekagan...@hotmail.com Keywords||needsUXEval --- Comment #5 from Heiko Tietze --- I wonder if we could just show the None or No Frame Style or Default Frame Style in the list without touching the inheritance. Can we, Mike? Btw, same problem at the table style - though with clearly no inheritance. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 140820] Should there be a "Default Frame Style", which each builtin Frame Style "Inherits from"?
https://bugs.documentfoundation.org/show_bug.cgi?id=140820 Heiko Tietze changed: What|Removed |Added CC||mikekagan...@hotmail.com Keywords||needsUXEval --- Comment #5 from Heiko Tietze --- I wonder if we could just show the None or No Frame Style or Default Frame Style in the list without touching the inheritance. Can we, Mike? Btw, same problem at the table style - though with clearly no inheritance. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-commits] core.git: Changes to 'distro/collabora/libreoffice-4.0.6.2'
New branch 'distro/collabora/libreoffice-4.0.6.2' available with the following commits: commit 36f1060e3c5be0946cd1bc811b84cc542fafe70b Author: Damjan Jovanovic Date: Sun Aug 20 06:22:29 2017 + i#32546# - Java UnoRuntime.getUniqueKey/generateOid do not work reliably In the Java UNO bridge, UnoRuntime.generateOid() generated the object-specific part of the OID using java.lang.Object.hashCode(), which is only 32 bits long, and is commonly overriden and could thus return values from an even smaller range, so OID collisions were quite likely. This changes UnoRuntime.generateOid() to use 128 bit UUIDs for the object-specific part of the OID, and store these in an object => oid java.util.WeakHashMap, making OID collisions almost impossible. Patch by: me Suggested by: Stephan Bergmann (stephan dot bergmann dot secondary at googlemail dot com) (cherry picked from commit 6dd83d1c6c5c580d14ca3d0458be4020603ba118) Change-Id: I8e851a7a69ac2defefa15e9a00118d8f9fc0da95 Reviewed-on: https://gerrit.libreoffice.org/41576 Reviewed-by: Stephan Bergmann Reviewed-by: Noel Grandin Tested-by: Jenkins commit 4a92919c5b1f94ccc58acc01ad3fb40961fce7ad Author: Miklos Vajna Date: Mon Jun 6 12:34:08 2016 +0200 SwXDispatchProviderInterceptor: implement frame::XInterceptorInfo With this, framework::InterceptionHelper can make a better decision what interceptor to call: it can avoid calling SwXDispatchProviderInterceptor when the sw code would just call the previous interceptor anyway. Reviewed-on: https://gerrit.libreoffice.org/25961 Reviewed-by: Miklos Vajna Tested-by: Jenkins (cherry picked from commit b0d819ac5667a07f629f2acb5d3c542fa76d348b) Conflicts: sw/source/uibase/inc/unodispatch.hxx sw/source/uibase/uno/unodispatch.cxx Change-Id: I92897f2c8baa264dc9ccbc11b63f415da30a910d commit b99c91d1d78915fea57ba6b8c905e68ae1ad4632 Author: Thorsten Behrens Date: Fri May 20 16:48:00 2016 +0200 framework: last dispatchInterceptor gets asked first Align implementation with API contract as spelled out in offapi/com/sun/star/frame/XDispatchProviderInterception.idl - no idea why this change happenend in 2003: Date: Fri Apr 4 16:16:05 2003 + INTEGRATION: CWS fwk01 (1.1.72); FILE MERGED 2003/04/01 12:40:09 as 1.1.72.1: #107642# change order of used interception objects At any rate, with this change extensions actually get a chance to see dispatch requests first, and process/ignore at will. Change-Id: I58876150ee6d67e592f41b3e82a9ffc314e091a3 Reviewed-on: https://gerrit.libreoffice.org/25215 Tested-by: Jenkins Reviewed-by: Thorsten Behrens (cherry picked from commit 08cf2fd01064306eef7fdbb5b62320947c4d1089) commit aa7f4295c0d428f79149228c3b4d38d6212d3906 Author: Thorsten Behrens Date: Wed Mar 2 15:28:36 2016 +0100 framework: avoid excessive queryDispatch calls Make better use of the css::frame::XInterceptorInfo interface, to avoid calling queryDispatch() pointlessly on interfaces that have explicitely opted out. Since that already broadcasts which urls we're interested in - so just don't bother calling entries who are not matching. Reviewed-on: https://gerrit.libreoffice.org/25214 Tested-by: Jenkins Reviewed-by: Thorsten Behrens (cherry picked from commit 27b6cdb5ab5af33dbba561923c8db81e144c88b9) Conflicts: framework/source/dispatch/interceptionhelper.cxx Change-Id: Id5e780568fd60c38f4cee4ee800d747d65a31dae commit b910152f23678e83b6f6ac0b2ad6728de9ebd92c Author: shubhamtibra Date: Sat Jan 16 21:50:24 2016 +0530 tdf#96949 Remove global static variable m_bPreferrFirstInterceptor and ... ... unused code Remove global static variable "m_bPreferrFirstInterceptor" which is always true, and remove the ifs where it is false. Reviewed-on: https://gerrit.libreoffice.org/21519 Reviewed-by: jan iversen Tested-by: jan iversen (cherry picked from commit 5d4f1f6f630d4382679087a4fb0da364c9c9692b) Conflicts: framework/inc/dispatch/interceptionhelper.hxx framework/source/dispatch/interceptionhelper.cxx Change-Id: I54dcea7a6010c825a66020ec3f7448bb32d120b8 commit 3e4efb6902141051374082458626b97e543b0053 Author: Miklos Vajna Date: Thu May 12 20:32:34 2016 +0200 framework: register DispatchDisabler service Change-Id: I72d9f8b00ba8b2e4e5dc70d7fd77e13ccf9d3bcc Reviewed-on: https://gerrit.libreoffice.org/24940 Reviewed-by: Miklos Vajna Tested-by: Jenkins (cherry picked from commit 1f041bf31e071611a15ffa1559d2f5df05a685f0) commit 333c2e3ae9c1184ecb2894cb280364a31571eeae Author: Michael Meeks Date: Thu Jan 7 19:24:41 2016 + framework: initial implementation of a dispatch disabler.
[Libreoffice-bugs] [Bug 146312] Chapter numbering dialog doesn't show Heading 1-2 in preview those headings a present in document (but shows if not present)
https://bugs.documentfoundation.org/show_bug.cgi?id=146312 --- Comment #5 from Heiko Tietze --- It's obviously the PS "[None]" which hides the text from preview. Since the preview shows the PS name, [None] means none. I agree with the bug assessment. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: formula/source include/editeng include/formula include/IwyuFilter_include.yaml include/LibreOfficeKit include/linguistic include/o3tl include/oox oox/source sc/qa sc/so
formula/source/core/api/FormulaCompiler.cxx |1 +
include/IwyuFilter_include.yaml |7 +++
include/LibreOfficeKit/LibreOfficeKitTypes.h |2 --
include/editeng/editund2.hxx |1 -
include/editeng/editview.hxx |1 -
include/editeng/overflowingtxt.hxx |2 --
include/editeng/txtrange.hxx |1 -
include/editeng/unoforou.hxx |1 -
include/editeng/unoipset.hxx |1 -
include/editeng/unonames.hxx |2 ++
include/editeng/xmlcnitm.hxx |1 -
include/formula/errorcodes.hxx |2 +-
include/linguistic/lngprops.hxx |2 ++
include/o3tl/cow_wrapper.hxx |1 -
include/o3tl/hash_combine.hxx|4
include/o3tl/string_view.hxx |1 -
include/oox/core/fragmenthandler2.hxx|2 --
include/oox/drawingml/drawingmltypes.hxx |1 -
include/oox/export/drawingml.hxx |1 +
include/oox/export/utils.hxx |2 ++
include/oox/ppt/pptimport.hxx|1 -
include/oox/shape/ShapeContextHandler.hxx|2 --
include/oox/shape/ShapeFilterBase.hxx|1 +
oox/source/drawingml/chart/converterbase.cxx |1 +
oox/source/drawingml/diagram/datamodel.hxx |1 +
sc/qa/unit/ucalc_pivottable.cxx |1 +
sc/source/core/data/global2.cxx |1 +
sc/source/ui/docshell/impex.cxx |1 +
sc/source/ui/vba/vbarange.cxx|1 +
sc/source/ui/view/viewfun6.cxx |1 +
30 files changed, 28 insertions(+), 19 deletions(-)
New commits:
commit 807f238f12e0774fabf507a17ca0ba9204d47833
Author: Gabor Kelemen
AuthorDate: Thu Dec 16 20:59:35 2021 +0100
Commit: Miklos Vajna
CommitDate: Mon Dec 20 10:06:34 2021 +0100
Recheck include/[e-r]* with IWYU
See tdf#42949 for motivation
Change-Id: I44e4e3a88067c1c29ce9d563b22741e984b43576
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126964
Tested-by: Jenkins
Reviewed-by: Miklos Vajna
diff --git a/formula/source/core/api/FormulaCompiler.cxx
b/formula/source/core/api/FormulaCompiler.cxx
index 9d84909c71c2..80065f2bc855 100644
--- a/formula/source/core/api/FormulaCompiler.cxx
+++ b/formula/source/core/api/FormulaCompiler.cxx
@@ -18,6 +18,7 @@
*/
#include
#include
+#include
#include
#include
#include
diff --git a/include/IwyuFilter_include.yaml b/include/IwyuFilter_include.yaml
index d608a87768d8..f56ed368c98b 100644
--- a/include/IwyuFilter_include.yaml
+++ b/include/IwyuFilter_include.yaml
@@ -43,6 +43,10 @@ excludelist:
include/android/compatibility.hxx:
# TODO check whether actually needed, just silence this for now
- math.h
+include/LibreOfficeKit/LibreOfficeKit.h:
+# the unstable API needs C99's bool
+- stdbool.h
+- stdint.h
include/sfx2/toolbarids.hxx:
# needed for enum definition
- sal/types.h
@@ -233,6 +237,9 @@ excludelist:
include/o3tl/make_shared.hxx:
# Needed for __COVERITY__
- o3tl/deleter.hxx
+include/o3tl/safeint.hxx:
+# Needed for std::min
+- algorithm
include/sot/exchange.hxx:
# Used in a macro #define
- com/sun/star/datatransfer/dnd/DNDConstants.hpp
diff --git a/include/LibreOfficeKit/LibreOfficeKitTypes.h
b/include/LibreOfficeKit/LibreOfficeKitTypes.h
index 5f4e3d4d870f..8513ef75421d 100644
--- a/include/LibreOfficeKit/LibreOfficeKitTypes.h
+++ b/include/LibreOfficeKit/LibreOfficeKitTypes.h
@@ -10,8 +10,6 @@
#ifndef INCLUDED_LIBREOFFICEKIT_LIBREOFFICEKIT_TYPES_H
#define INCLUDED_LIBREOFFICEKIT_LIBREOFFICEKIT_TYPES_H
-#include
-
#ifdef __cplusplus
extern "C" {
#endif
diff --git a/include/editeng/editund2.hxx b/include/editeng/editund2.hxx
index fb8d66b99443..3f6975a3a2e8 100644
--- a/include/editeng/editund2.hxx
+++ b/include/editeng/editund2.hxx
@@ -20,7 +20,6 @@
#ifndef INCLUDED_EDITENG_EDITUND2_HXX
#define INCLUDED_EDITENG_EDITUND2_HXX
-#include
#include
#include
diff --git a/include/editeng/editview.hxx b/include/editeng/editview.hxx
index 8332e516915d..f610f5ee6bf5 100644
--- a/include/editeng/editview.hxx
+++ b/include/editeng/editview.hxx
@@ -20,7 +20,6 @@
#ifndef INCLUDED_EDITENG_EDITVIEW_HXX
#define INCLUDED_EDITENG_EDITVIEW_HXX
-#include
#include
#include
diff --git a/include/editeng/overflowingtxt.hxx
b/include/editeng/overflowingtxt.hxx
index 1c11c7797d00..031b4d82d9d5 100644
--- a/include/editeng/overflowingtxt.hxx
+++ b/include/editeng/overflowingtxt.hxx
@@ -20,12 +20,10 @@
#ifndef INCLUDED_EDITENG_OVERFLOWINGTXT_HXX
#define INCLUDED_EDITENG_OVERFLOWINGTXT_HXX
-#include
#include
#include
#include
-#include
#include
namespace com::sun::star {
diff --git a/include/editeng/txtrange.hxx b/include/editeng/txtrange.hxx
index ab6be6d283a2..c6661f687dad 100644
---
[Libreoffice-bugs] [Bug 139990] When I try to add a hyperlink, LibreOffice crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=139990 Julien Nabet changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146321] Starting Libre Office just crashes, when in safe mode no file open
https://bugs.documentfoundation.org/show_bug.cgi?id=146321 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #1 from Julien Nabet --- Could you give a try at https://wiki.documentfoundation.org/QA/FirstSteps ? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146320] Base Report generator Java error
https://bugs.documentfoundation.org/show_bug.cgi?id=146320 Julien Nabet changed: What|Removed |Added CC||rob...@familiegrosskopf.de --- Comment #4 from Julien Nabet --- Thank you Dennis for your feedback. Robert: If I remember well you use OpenSuse, any idea here? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: svx/source
svx/source/sdr/contact/viewobjectcontact.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 309c8bd4fc5cc7034754b90d6306bbe4084be4d9
Author: Noel Grandin
AuthorDate: Mon Dec 20 09:37:48 2021 +0200
Commit: Noel Grandin
CommitDate: Mon Dec 20 09:47:34 2021 +0100
remove leftover
from commit b33a4d3c4acc37b9284c611c661d2fe34db8
Change-Id: I6218b84d040a2b3ebd32cc515c5bf25e303487f7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127134
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/svx/source/sdr/contact/viewobjectcontact.cxx
b/svx/source/sdr/contact/viewobjectcontact.cxx
index 8b8f0c3250d7..79b2d03e625c 100644
--- a/svx/source/sdr/contact/viewobjectcontact.cxx
+++ b/svx/source/sdr/contact/viewobjectcontact.cxx
@@ -347,7 +347,7 @@ drawinglayer::primitive2d::Primitive2DContainer const &
ViewObjectContact::getPr
drawinglayer::primitive2d::Primitive2DContainer xNewPrimitiveSequence;
// take care of redirectors and create new list
-ViewObjectContactRedirector* pRedirector =
GetObjectContact().GetViewObjectContactRedirector();\
+ViewObjectContactRedirector* pRedirector =
GetObjectContact().GetViewObjectContactRedirector();
if(pRedirector)
{
[Libreoffice-commits] core.git: framework/inc framework/source
framework/inc/dispatch/oxt_handler.hxx|3 ++-
framework/source/dispatch/oxt_handler.cxx |2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
New commits:
commit 599cb40c92f2d758d21c7040790cbf2ceab213f3
Author: Noel Grandin
AuthorDate: Sat Dec 18 18:55:02 2021 +0200
Commit: Noel Grandin
CommitDate: Mon Dec 20 09:47:16 2021 +0100
osl::Mutex->std::mutex in Oxt_Handler
Change-Id: Iaa7120a5373c09a1515dc76e5a5ba19b16cf1554
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127102
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/framework/inc/dispatch/oxt_handler.hxx
b/framework/inc/dispatch/oxt_handler.hxx
index 162821bc1aa8..85c6312efbf9 100644
--- a/framework/inc/dispatch/oxt_handler.hxx
+++ b/framework/inc/dispatch/oxt_handler.hxx
@@ -28,6 +28,7 @@
#include
#include
+#include
namespace framework{
@@ -78,7 +79,7 @@ class Oxt_Handler final : public ::cppu::WeakImplHelper<
virtual OUString SAL_CALL detect (css::uno::Sequence<
css::beans::PropertyValue >&lDescriptor ) override;
private:
-osl::Mutex m_mutex;
+std::mutex m_mutex;
css::uno::Reference< css::uno::XComponentContext > m_xContext;
/// global uno service factory to create new services
diff --git a/framework/source/dispatch/oxt_handler.cxx
b/framework/source/dispatch/oxt_handler.cxx
index 8c806dd9a2cc..35d196ee046f 100644
--- a/framework/source/dispatch/oxt_handler.cxx
+++ b/framework/source/dispatch/oxt_handler.cxx
@@ -91,7 +91,7 @@ void SAL_CALL Oxt_Handler::dispatchWithNotification( const
css::util::URL& aURL,
const css::uno::Sequence<
css::beans::PropertyValue >&/*lArguments*/,
const
css::uno::Reference< css::frame::XDispatchResultListener >& xListener )
{
-osl::MutexGuard g(m_mutex);
+std::unique_lock g(m_mutex);
css::uno::Sequence< css::uno::Any > lParams{ css::uno::Any(aURL.Main) };
[Libreoffice-ux-advise] [Bug 99027] [FORMATTING] Default table border width is useless
https://bugs.documentfoundation.org/show_bug.cgi?id=99027 Samuel Mehrbrodt (allotropia) changed: What|Removed |Added CC||samuel.mehrbrodt@allotropia ||.de Resolution|WORKSFORME |FIXED -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 99027] [FORMATTING] Default table border width is useless
https://bugs.documentfoundation.org/show_bug.cgi?id=99027 Samuel Mehrbrodt (allotropia) changed: What|Removed |Added CC||samuel.mehrbrodt@allotropia ||.de Resolution|WORKSFORME |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146022] Text not wrapping (going behind image) when image moved certain way
https://bugs.documentfoundation.org/show_bug.cgi?id=146022 --- Comment #5 from Telesto --- Created attachment 177027 --> https://bugs.documentfoundation.org/attachment.cgi?id=177027=edit Screencast -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146312] Chapter numbering dialog doesn't show Heading 1-2 in preview those headings a present in document (but shows if not present)
https://bugs.documentfoundation.org/show_bug.cgi?id=146312 Telesto changed: What|Removed |Added Summary|Chapter numbering dialog|Chapter numbering dialog |doesn't show Heading 1-3 in |doesn't show Heading 1-2 in |preview those headings a|preview those headings a |present in document (but|present in document (but |shows if not present) |shows if not present) --- Comment #4 from Telesto --- (In reply to stragu from comment #3) > Following the steps, I could reproduce but only heading 1 and heading 2 are > not showing. (The two heading styles used in the document.) > Can you confirm that it only affects 1 and 2, Telesto? Yes -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 115538] GnuPG / OpenPGP keys not found on macOS unless from command line
https://bugs.documentfoundation.org/show_bug.cgi?id=115538 --- Comment #47 from Alex Thurgood --- Still present in Version: 7.2.4.1 / LibreOffice Community Build ID: 27d75539669ac387bb498e35313b970b7fe9c4f9 CPU threads: 8; OS: Mac OS X 10.16; UI render: default; VCL: osx Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: officecfg/registry
officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu |1 - 1 file changed, 1 deletion(-) New commits: commit 656ed2c6f217d73e4686726783dec5b940851daf Author: Gabor Kelemen AuthorDate: Sun Dec 19 10:00:31 2021 +0100 Commit: Gabor Kelemen CommitDate: Mon Dec 20 09:37:20 2021 +0100 tdf#146311 Hide Columns section in sidebar for media file in Calc Change-Id: Ia3e50d79eff645d66e7315bff51a62307dff2d69 Change-Id: Ie8f2a6439a1cc68bce6d13bc304de9597fe86b5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127131 Reviewed-by: Mike Kaganski Tested-by: Jenkins diff --git a/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu b/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu index 884133d0d915..61b702749b19 100644 --- a/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu +++ b/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu @@ -1856,7 +1856,6 @@ Calc, Draw, hidden ; Calc, Graphic,hidden ; -Calc, Media, hidden ; DrawImpress,Draw, hidden ; DrawImpress,Graphic,hidden ; DrawImpress,TextObject, hidden ;
[Libreoffice-bugs] [Bug 146328] Columns break oddly after moving image frame
https://bugs.documentfoundation.org/show_bug.cgi?id=146328 --- Comment #3 from Telesto --- It's only 'live' issue, no issue after save & reload -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146319] [SVG] load/export of W3C SVG example car.svg is slow
https://bugs.documentfoundation.org/show_bug.cgi?id=146319 --- Comment #2 from Hossein --- (In reply to Rainer Bielefeld Retired from comment #1) > NOT reproducible with suggested Installation of Version 7.2.4.1 (x64) / > LibreOffice Build 27d75539669ac387bb498e35313b970b7fe9c4f9 > CPU threads: 12; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: > win; Locale: de-DE (de_DE); UI: de-DE; Calc: threaded; Elementary Theme; My > normal User Profile, on PC with AMD Ryzen 5 3600 6-Core Processor 3.60 GHz > 16GB RAM, SSD: > > Open in DRAW and import to DRAWing take a fraction of a second. > PDF export (300 DPI, jpg 95%) takes 2s or so May be my computer is not that fast (although I use a recent generation of Core i7). Could you please compare the output for these on your machine? $ time libreoffice7.2 --headless --convert-to pdf car.svg $ time google-chrome --headless --disable-gpu --print-to-pdf car.svg -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146328] Columns break oddly after moving image frame
https://bugs.documentfoundation.org/show_bug.cgi?id=146328 --- Comment #2 from Telesto --- Same happens with 4x right instead of 5x arrow up -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146328] Columns break oddly after moving image frame
https://bugs.documentfoundation.org/show_bug.cgi?id=146328 Telesto changed: What|Removed |Added Keywords||bibisectRequest, regression Version|7.4.0.0 alpha0+ Master |7.0.0.3 release --- Comment #1 from Telesto --- Also in 7.0 Fine with Version: 6.4.0.0.alpha0+ (x64) Build ID: c56bf1479cc71d1a2b0639f6383e90c1f7e3655b CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; Locale: nl-NL (nl_NL); UI-Language: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 36709] For first line indent using Ch (Characters) as unit, the indent value should change when font-size changes
https://bugs.documentfoundation.org/show_bug.cgi?id=36709 --- Comment #25 from Kevin Suo --- One ch unit means one character unit, which equals to the height of the character of the current paragraph using the font of the current paragraph style. In Chinese language there is a long standing convention that in a paragraph the first line indent should be 2 characters. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: framework/inc framework/source
framework/inc/helper/wakeupthread.hxx|9 -
framework/source/helper/wakeupthread.cxx | 12 +++-
2 files changed, 11 insertions(+), 10 deletions(-)
New commits:
commit 95b7ecbbdb445a8f2408d1b0b3d32cb799d15568
Author: Noel Grandin
AuthorDate: Sat Dec 18 19:03:44 2021 +0200
Commit: Noel Grandin
CommitDate: Mon Dec 20 09:25:41 2021 +0100
osl::Mutex->std::mutex in WakeUpThread
Change-Id: I469fa855eb373829f23232875669f607dcb0c6a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127104
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/framework/inc/helper/wakeupthread.hxx
b/framework/inc/helper/wakeupthread.hxx
index f9099180d03f..cdc8700a5266 100644
--- a/framework/inc/helper/wakeupthread.hxx
+++ b/framework/inc/helper/wakeupthread.hxx
@@ -23,8 +23,8 @@
#include
#include
-#include
-#include
+#include
+#include
#include
namespace com::sun::star::util
@@ -37,9 +37,8 @@ namespace framework
class WakeUpThread final : public salhelper::Thread
{
css::uno::WeakReference updatable_;
-osl::Condition condition_;
-
-osl::Mutex mutex_;
+std::condition_variable condition_;
+std::mutex mutex_;
bool terminate_;
void execute() override;
diff --git a/framework/source/helper/wakeupthread.cxx
b/framework/source/helper/wakeupthread.cxx
index 503f6707a010..556d59dbb581 100644
--- a/framework/source/helper/wakeupthread.cxx
+++ b/framework/source/helper/wakeupthread.cxx
@@ -25,13 +25,15 @@
#include
#include
+#include
+
+using namespace std::chrono_literals;
void framework::WakeUpThread::execute() {
for (;;) {
-TimeValue t{0, 2500}; // 25 msec
-condition_.wait();
{
-osl::MutexGuard g(mutex_);
+std::unique_lock g(mutex_);
+condition_.wait_for(g, 25ms, [this] { return terminate_; });
if (terminate_) {
break;
}
@@ -50,10 +52,10 @@ framework::WakeUpThread::WakeUpThread(
void framework::WakeUpThread::stop() {
{
-osl::MutexGuard g(mutex_);
+std::unique_lock g(mutex_);
terminate_ = true;
}
-condition_.set();
+condition_.notify_one();
join();
}
[Libreoffice-bugs] [Bug 146062] UI gets blocked while downloading new icon theme
https://bugs.documentfoundation.org/show_bug.cgi?id=146062 Dieter changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||dgp-m...@gmx.de --- Comment #1 from Dieter --- Thank you for reporting the bug. It seems you're using an old version of LibreOffice. Could you please try to reproduce it with the latest version of LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ ? I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the latest version. Change to RESOLVED WORKSFORME, if the problem went away. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 126716] Export/Save as HTML produce different result from DOCX numbered list
https://bugs.documentfoundation.org/show_bug.cgi?id=126716 Dieter changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||6015 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 115326] Change multiple spaces to upon HTML export
https://bugs.documentfoundation.org/show_bug.cgi?id=115326 Dieter changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||6015 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 83890] Save as HTML numbering confusion
https://bugs.documentfoundation.org/show_bug.cgi?id=83890 Dieter changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||6015 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146015] Output to HTML: Chapter numbering wrong, missing styles
https://bugs.documentfoundation.org/show_bug.cgi?id=146015 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de Status|UNCONFIRMED |NEW See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=83 ||890, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||6716, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||5326 Ever confirmed|0 |1 Blocks||108799 Whiteboard| QA:needsComment| --- Comment #5 from Dieter --- I confirm the different problems with Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: deea3b7471c3dab0220eca6146c225a2d47681a2 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL but as there is the basic rule "one problem one bug report" I recommend to reduce this bug report to one problem and open a new report for the second one. First problem: Wrong numbering Export as xhtml: Every chapter starts with chapter numbering 1 Save as html: O.K. Create Html-document: Numbering of chapter 3 is again chapter 1 => uses a differnet list? Second problem: Spacing after chapter numbering Export as xhtml: Smaller space in level 1 (tab stop) and no space in level 2 and level 3(blank space) Save as html: No space in all levels Create Html-document: No space in all levels Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108799 [Bug 108799] [META] HTML export bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108799] [META] HTML export bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108799 Dieter changed: What|Removed |Added Depends on||146015 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=146015 [Bug 146015] Output to HTML: Chapter numbering wrong, missing styles -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146326] The Autofilter Input Box should get focus upon mouse-hover
https://bugs.documentfoundation.org/show_bug.cgi?id=146326 Kevin Suo changed: What|Removed |Added Summary|The Input Box should get|The Autofilter Input Box |focus upon mouse-hover |should get focus upon ||mouse-hover -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146326] The Input Box should get focus upon mouse-hover
https://bugs.documentfoundation.org/show_bug.cgi?id=146326 Kevin Suo changed: What|Removed |Added Keywords||bibisected, bisected, ||regression CC||caol...@redhat.com --- Comment #1 from Kevin Suo --- Regression caused by the (great) improvements of hover-style autofitler submenus by Caolán in: commit 29145df0977baa866e7da94d1d385b772ae1e6ce Author: Caolán McNamara Date: Mon Nov 29 12:55:38 2021 + Resolves: tdf#144811 use the hover-style menu for color submenus Caolán could you please take a look? Thanks. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: avmedia/source
avmedia/source/win/framegrabber.cxx | 24 --
avmedia/source/win/player.cxx | 58
avmedia/source/win/player.hxx | 20
3 files changed, 23 insertions(+), 79 deletions(-)
New commits:
commit 00eb9b8954a129fb365191ce8cdcbc4cf66a7333
Author: Mike Kaganski
AuthorDate: Mon Dec 20 10:12:13 2021 +0300
Commit: Mike Kaganski
CommitDate: Mon Dec 20 09:22:09 2021 +0100
Use more sal::systools::COMReference
Change-Id: I29bf304d90db968682c2b0791372d0ea41375096
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127132
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/avmedia/source/win/framegrabber.cxx
b/avmedia/source/win/framegrabber.cxx
index 6ed07a87935a..b7109b251497 100644
--- a/avmedia/source/win/framegrabber.cxx
+++ b/avmedia/source/win/framegrabber.cxx
@@ -38,6 +38,7 @@
#include
#include
#include
+#include
constexpr OUStringLiteral AVMEDIA_WIN_FRAMEGRABBER_IMPLEMENTATIONNAME =
u"com.sun.star.comp.avmedia.FrameGrabber_DirectX";
constexpr OUStringLiteral AVMEDIA_WIN_FRAMEGRABBER_SERVICENAME =
u"com.sun.star.media.FrameGrabber_DirectX";
@@ -60,11 +61,11 @@ FrameGrabber::~FrameGrabber()
namespace {
-IMediaDet* implCreateMediaDet( const OUString& rURL )
+sal::systools::COMReference implCreateMediaDet( const OUString&
rURL )
{
-IMediaDet* pDet = nullptr;
+sal::systools::COMReference pDet;
-if( SUCCEEDED( CoCreateInstance( CLSID_MediaDet, nullptr,
CLSCTX_INPROC_SERVER, IID_IMediaDet, reinterpret_cast() ) ) )
+if( pDet.CoCreateInstance(CLSID_MediaDet, nullptr, CLSCTX_INPROC_SERVER) )
{
OUString aLocalStr;
@@ -78,8 +79,7 @@ IMediaDet* implCreateMediaDet( const OUString& rURL )
// I cannot find information why do we pass a newly allocated
BSTR to the put_Filename
// and if it frees the string internally
SysFreeString(bstrFilename);
-pDet->Release();
-pDet = nullptr;
+pDet.clear();
}
}
}
@@ -92,14 +92,8 @@ IMediaDet* implCreateMediaDet( const OUString& rURL )
bool FrameGrabber::create( const OUString& rURL )
{
// just check if a MediaDet interface can be created with the given URL
-IMediaDet* pDet = implCreateMediaDet( rURL );
-
-if( pDet )
-{
+if (implCreateMediaDet(rURL))
maURL = rURL;
-pDet->Release();
-pDet = nullptr;
-}
else
maURL.clear();
@@ -110,9 +104,7 @@ bool FrameGrabber::create( const OUString& rURL )
uno::Reference< graphic::XGraphic > SAL_CALL FrameGrabber::grabFrame( double
fMediaTime )
{
uno::Reference< graphic::XGraphic > xRet;
-IMediaDet* pDet = implCreateMediaDet( maURL );
-
-if( pDet )
+if (sal::systools::COMReference pDet =
implCreateMediaDet(maURL))
{
double fLength;
longnStreamCount;
@@ -195,8 +187,6 @@ uno::Reference< graphic::XGraphic > SAL_CALL
FrameGrabber::grabFrame( double fMe
}
}
}
-
-pDet->Release();
}
return xRet;
diff --git a/avmedia/source/win/player.cxx b/avmedia/source/win/player.cxx
index 4d764d4a4fa6..ab2c9c8eb20d 100644
--- a/avmedia/source/win/player.cxx
+++ b/avmedia/source/win/player.cxx
@@ -64,16 +64,6 @@ static LRESULT CALLBACK MediaPlayerWndProc_2( HWND hWnd,UINT
nMsg, WPARAM nPar1,
Player::Player() :
Player_BASE(m_aMutex),
-mpGB( nullptr ),
-mpOMF( nullptr ),
-mpMC( nullptr ),
-mpME( nullptr ),
-mpMS( nullptr ),
-mpMP( nullptr ),
-mpBA( nullptr ),
-mpBV( nullptr ),
-mpVW( nullptr ),
-mpEV( nullptr ),
mnUnmutedVolume( 0 ),
mnFrameWnd( nullptr ),
mbMuted( false ),
@@ -97,47 +87,16 @@ void SAL_CALL Player::disposing()
{
::osl::MutexGuard aGuard(m_aMutex);
stop();
-if( mpBA )
-mpBA->Release();
-
-if( mpBV )
-mpBV->Release();
-
-if( mpVW )
-mpVW->Release();
-
-if( mpMP )
-mpMP->Release();
-
-if( mpMS )
-mpMS->Release();
-
if( mpME )
-{
mpME->SetNotifyWindow( 0, WM_GRAPHNOTIFY, 0);
-mpME->Release();
-}
-
-if( mpMC )
-mpMC->Release();
-
-if( mpEV )
-mpEV->Release();
-
-if( mpOMF )
-mpOMF->Release();
-
-if( mpGB )
-mpGB->Release();
}
bool Player::create( const OUString& rURL )
{
-HRESULT hR;
boolbRet = false;
-if( SUCCEEDED( hR = CoCreateInstance( CLSID_FilterGraph, nullptr,
CLSCTX_INPROC_SERVER, IID_IGraphBuilder, reinterpret_cast() ) ) )
+if( mpGB.CoCreateInstance(CLSID_FilterGraph, nullptr,
CLSCTX_INPROC_SERVER) )
{
// Don't use the overlay mixer on Windows Vista
// It disables the desktop composition as soon as RenderFile is called
@@ -149,18 +108,17 @@ bool Player::create( const OUString& rURL )
if
[Libreoffice-bugs] [Bug 146328] New: Columns break oddly after moving image frame
https://bugs.documentfoundation.org/show_bug.cgi?id=146328 Bug ID: 146328 Summary: Columns break oddly after moving image frame Product: LibreOffice Version: 7.4.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Columns break oddly after moving image frame Steps to Reproduce: 1. Open attachment 164256 [details] 2. Select the image frame 3. Change anchor to 'to paragraph' 4. Press arrow up 5x Actual Results: Image frame moves to second page left column Expected Results: Same page flow as before (so single page) Reproducible: Always User Profile Reset: No Additional Info: Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: deea3b7471c3dab0220eca6146c225a2d47681a2 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146327] Frame & image detached moving image across columns
https://bugs.documentfoundation.org/show_bug.cgi?id=146327 Telesto changed: What|Removed |Added Keywords||bibisectRequest, regression CC||libreoff...@nisz.hu --- Comment #1 from Telesto --- Still fine with Version: 7.2.1.0.0+ (x64) / LibreOffice Community Build ID: 8fdbb8aed1b48734a717d5f98ada566de7204605 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146327] New: Frame & image detached moving image across columns
https://bugs.documentfoundation.org/show_bug.cgi?id=146327 Bug ID: 146327 Summary: Frame & image detached moving image across columns Product: LibreOffice Version: 7.4.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Frame & image detached moving image across columns Steps to Reproduce: 1. Open attachment 164256 2. Select the image frame 3. press 8x arrow up or down or 8x times arrow left or right Actual Results: Frame moves, images stays put Expected Results: Image in frame Reproducible: Always User Profile Reset: No Additional Info: Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: deea3b7471c3dab0220eca6146c225a2d47681a2 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 130565] EDITING: Cannot edit protected document
https://bugs.documentfoundation.org/show_bug.cgi?id=130565 Vasily Melenchuk (CIB) changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |vasily.melenc...@cib.de |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146326] New: The Input Box should get focus upon mouse-hover
https://bugs.documentfoundation.org/show_bug.cgi?id=146326 Bug ID: 146326 Summary: The Input Box should get focus upon mouse-hover Product: LibreOffice Version: 7.3.0.0 beta1+ Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: suokunl...@126.com Steps to Reproduce: 1. Click on any autofilter dropdown. --> The focus is within the input box, that's good, we can now type in any text for quick search. 2. Move your mouse from the top entry (i.e. Sorting") down through the Filter by Color, then further down to the text Input Box. --> When mouse hover any other entry, that entry is focused (and if that entry has sub-entries then the sub-entries are popped up). This is good. --> However, when mouse hover on top of the text Input Box, the input box does not get focus, thus if you want to type anything into the text box then you need an extra click. This is annoying. Expected Result: In step 2, when mouse hover to the text input box, the text input box should get focus to allow quick input of text. Addition Info: Actually, at the time when the input box has not get focus, you actually can type, but the typing is not in the input box. It is in a "new" input box, and after you hit ENTER nothing take effect. Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 64589ddc911ed7bcc334adecd46b472adfec15f2 CPU threads: 8; OS: Linux 5.14; UI render: default; VCL: gtk3 Locale: zh-CN (zh_CN.UTF-8); UI: zh-CN Build Platform: Fedora34@X64, Branch:master, bibisect-linux-64-7.4-CN Calc: threaded and also in Version: 7.3.0.0.beta1+ / LibreOffice Community Build ID: c25067e46d7d849a584295de365e32c6c7af11bf CPU threads: 8; OS: Linux 5.14; UI render: default; VCL: gtk3 Locale: zh-CN (zh_CN.UTF-8); UI: zh-CN Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
