[Libreoffice-bugs] [Bug 146395] Input field for QR Code does not allow newlines
https://bugs.documentfoundation.org/show_bug.cgi?id=146395 --- Comment #3 from achim --- IMHO, if entry fields should not have/allow multiline, the the entry field in the QR Code dialog should be replace by an text field (sorry, not sure what the proper GTK names are). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: svx/source
svx/source/xml/xmlgrhlp.cxx | 38 --
1 file changed, 16 insertions(+), 22 deletions(-)
New commits:
commit 56c233961f3121f45448fe06104c36fe3bf92f4c
Author: Noel Grandin
AuthorDate: Sat Dec 25 08:35:48 2021 +0200
Commit: Noel Grandin
CommitDate: Sun Dec 26 08:27:27 2021 +0100
no need to store 3 different refs to the same object
Change-Id: I025719a9682cf0f0a6e3773362fe37d80fddb1ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127490
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/svx/source/xml/xmlgrhlp.cxx b/svx/source/xml/xmlgrhlp.cxx
index f78787d5b674..0604f0f95d8e 100644
--- a/svx/source/xml/xmlgrhlp.cxx
+++ b/svx/source/xml/xmlgrhlp.cxx
@@ -984,9 +984,7 @@ protected:
private:
SvXMLGraphicHelperMode m_eGraphicHelperMode;
-Reference< XGraphicObjectResolver > m_xGraphicObjectResolver;
-Reference< XGraphicStorageHandler > m_xGraphicStorageHandler;
-Reference< XBinaryStreamResolver > m_xBinaryStreamResolver;
+rtl::Reference m_xXMLGraphicHelper;
};
SvXMLGraphicImportExportHelper::SvXMLGraphicImportExportHelper(
SvXMLGraphicHelperMode eMode ) :
@@ -995,12 +993,11 @@
SvXMLGraphicImportExportHelper::SvXMLGraphicImportExportHelper( SvXMLGraphicHelp
void SvXMLGraphicImportExportHelper::disposing(std::unique_lock&)
{
-Reference< XComponent > xComp( m_xGraphicObjectResolver, UNO_QUERY );
-OSL_ASSERT( xComp.is());
-if( xComp.is())
-xComp->dispose();
-// m_xBinaryStreamResolver and m_xGraphicStorageHandler are a reference to
the same object,
-// don't call dispose() again
+if (m_xXMLGraphicHelper)
+{
+m_xXMLGraphicHelper->dispose();
+m_xXMLGraphicHelper.clear();
+}
}
// XInitialization
@@ -1011,57 +1008,54 @@ void SAL_CALL
SvXMLGraphicImportExportHelper::initialize(
if( aArguments.hasElements() )
aArguments[0] >>= xStorage;
-rtl::Reference pHelper( SvXMLGraphicHelper::Create(
xStorage, m_eGraphicHelperMode ));
-m_xGraphicObjectResolver = pHelper;
-m_xGraphicStorageHandler = pHelper;
-m_xBinaryStreamResolver = pHelper;
+m_xXMLGraphicHelper = SvXMLGraphicHelper::Create( xStorage,
m_eGraphicHelperMode );
}
// XGraphicObjectResolver
OUString SAL_CALL SvXMLGraphicImportExportHelper::resolveGraphicObjectURL(
const OUString& aURL )
{
-return m_xGraphicObjectResolver->resolveGraphicObjectURL( aURL );
+return m_xXMLGraphicHelper->resolveGraphicObjectURL( aURL );
}
// XGraphicStorageHandler
uno::Reference SAL_CALL
SvXMLGraphicImportExportHelper::loadGraphic(OUString const & rURL)
{
-return m_xGraphicStorageHandler->loadGraphic(rURL);
+return m_xXMLGraphicHelper->loadGraphic(rURL);
}
uno::Reference SAL_CALL
SvXMLGraphicImportExportHelper::loadGraphicFromOutputStream(uno::Reference
const & rxOutputStream)
{
-return
m_xGraphicStorageHandler->loadGraphicFromOutputStream(rxOutputStream);
+return m_xXMLGraphicHelper->loadGraphicFromOutputStream(rxOutputStream);
}
OUString SAL_CALL
SvXMLGraphicImportExportHelper::saveGraphic(css::uno::Reference
const & rxGraphic)
{
-return m_xGraphicStorageHandler->saveGraphic(rxGraphic);
+return m_xXMLGraphicHelper->saveGraphic(rxGraphic);
}
OUString SAL_CALL
SvXMLGraphicImportExportHelper::saveGraphicByName(css::uno::Reference
const & rxGraphic,
OUString &
rOutSavedMimeType, OUString const & rRequestName)
{
-return m_xGraphicStorageHandler->saveGraphicByName(rxGraphic,
rOutSavedMimeType, rRequestName);
+return m_xXMLGraphicHelper->saveGraphicByName(rxGraphic,
rOutSavedMimeType, rRequestName);
}
uno::Reference SAL_CALL
SvXMLGraphicImportExportHelper::createInputStream(uno::Reference
const & rxGraphic)
{
-return m_xGraphicStorageHandler->createInputStream(rxGraphic);
+return m_xXMLGraphicHelper->createInputStream(rxGraphic);
}
// XBinaryStreamResolver
Reference< io::XInputStream > SAL_CALL
SvXMLGraphicImportExportHelper::getInputStream( const OUString& aURL )
{
-return m_xBinaryStreamResolver->getInputStream( aURL );
+return m_xXMLGraphicHelper->getInputStream( aURL );
}
Reference< io::XOutputStream > SAL_CALL
SvXMLGraphicImportExportHelper::createOutputStream()
{
-return m_xBinaryStreamResolver->createOutputStream();
+return m_xXMLGraphicHelper->createOutputStream();
}
OUString SAL_CALL SvXMLGraphicImportExportHelper::resolveOutputStream( const
Reference< io::XOutputStream >& aBinaryStream )
{
-return m_xBinaryStreamResolver->resolveOutputStream( aBinaryStream );
+return m_xXMLGraphicHelper->resolveOutputStream( aBinaryStream );
}
// XServiceInfo
[Libreoffice-commits] core.git: framework/inc framework/source
framework/inc/uielement/statusbaritem.hxx| 10 --
framework/source/uielement/statusbaritem.cxx | 12 +---
2 files changed, 9 insertions(+), 13 deletions(-)
New commits:
commit 8566b3f8d2c89ac408e5a66335f978848bfc9e9f
Author: Noel Grandin
AuthorDate: Fri Dec 24 20:42:20 2021 +0200
Commit: Noel Grandin
CommitDate: Sun Dec 26 08:23:53 2021 +0100
use comphelper::WeakComponentImplHelper in StatusbarItem
Change-Id: I2c278547d16c5ad0530188f1e465cb784d345746
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127460
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/framework/inc/uielement/statusbaritem.hxx
b/framework/inc/uielement/statusbaritem.hxx
index 62e3c1f4e62e..44fecd1dff68 100644
--- a/framework/inc/uielement/statusbaritem.hxx
+++ b/framework/inc/uielement/statusbaritem.hxx
@@ -19,8 +19,7 @@
#pragma once
#include
-#include
-#include
+#include
#include
class StatusBar;
@@ -30,10 +29,9 @@ namespace framework
struct AddonStatusbarItemData;
-typedef cppu::WeakComponentImplHelper< css::ui::XStatusbarItem >
StatusbarItem_Base;
+typedef comphelper::WeakComponentImplHelper< css::ui::XStatusbarItem >
StatusbarItem_Base;
-class StatusbarItem final : protected cppu::BaseMutex,
- public StatusbarItem_Base
+class StatusbarItem final : public StatusbarItem_Base
{
public:
explicit StatusbarItem(
@@ -42,7 +40,7 @@ public:
const OUString& aCommand );
virtual ~StatusbarItem() override;
-void SAL_CALL disposing() override;
+void disposing(std::unique_lock&) override;
// css::ui::XStatusbarItem Attributes
virtual OUString SAL_CALL getCommand() override;
diff --git a/framework/source/uielement/statusbaritem.cxx
b/framework/source/uielement/statusbaritem.cxx
index a453f0079fc0..27985791ae86 100644
--- a/framework/source/uielement/statusbaritem.cxx
+++ b/framework/source/uielement/statusbaritem.cxx
@@ -62,8 +62,7 @@ StatusbarItem::StatusbarItem(
StatusBar *pStatusBar,
sal_uInt16 nId,
const OUString&aCommand )
-: StatusbarItem_Base( m_aMutex )
-, m_pStatusBar( pStatusBar )
+: m_pStatusBar( pStatusBar )
, m_nId( nId )
, m_nStyle( 0 )
, m_aCommand( aCommand )
@@ -77,21 +76,20 @@ StatusbarItem::~StatusbarItem()
{
}
-void SAL_CALL StatusbarItem::disposing()
+void StatusbarItem::disposing(std::unique_lock&)
{
-osl::MutexGuard aGuard( m_aMutex );
m_pStatusBar = nullptr;
}
OUString SAL_CALL StatusbarItem::getCommand()
{
-osl::MutexGuard aGuard( m_aMutex );
+std::unique_lock aGuard( m_aMutex );
return m_aCommand;
}
::sal_uInt16 SAL_CALL StatusbarItem::getItemId()
{
-osl::MutexGuard aGuard( m_aMutex );
+std::unique_lock aGuard( m_aMutex );
return m_nId;
}
@@ -106,7 +104,7 @@ OUString SAL_CALL StatusbarItem::getCommand()
::sal_uInt16 SAL_CALL StatusbarItem::getStyle()
{
-osl::MutexGuard aGuard( m_aMutex );
+std::unique_lock aGuard( m_aMutex );
return m_nStyle;
}
[Libreoffice-commits] core.git: framework/inc framework/source
framework/inc/uielement/uicommanddescription.hxx|8 +++-
framework/source/uielement/uicommanddescription.cxx | 14 ++
2 files changed, 9 insertions(+), 13 deletions(-)
New commits:
commit a839a6afada46b44095be184548f6fa75d80e961
Author: Noel Grandin
AuthorDate: Fri Dec 24 20:46:01 2021 +0200
Commit: Noel Grandin
CommitDate: Sun Dec 26 08:23:14 2021 +0100
use comphelper::WeakComponentImplHelper in UICommandDescription
Change-Id: I042c9761c60d3b1c39950cfede80958edf2d84c2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127461
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/framework/inc/uielement/uicommanddescription.hxx
b/framework/inc/uielement/uicommanddescription.hxx
index 146b4f42db3a..aeeb1f9aa216 100644
--- a/framework/inc/uielement/uicommanddescription.hxx
+++ b/framework/inc/uielement/uicommanddescription.hxx
@@ -26,19 +26,17 @@
#include
#include
-#include
-#include
+#include
#include
#include
#include
namespace framework
{
-typedef ::cppu::WeakComponentImplHelper< css::lang::XServiceInfo,
+typedef comphelper::WeakComponentImplHelper< css::lang::XServiceInfo,
css::container::XNameAccess > UICommandDescription_BASE;
-class UICommandDescription : private cppu::BaseMutex,
- public UICommandDescription_BASE
+class UICommandDescription : public UICommandDescription_BASE
{
public:
UICommandDescription( const css::uno::Reference<
css::uno::XComponentContext >& rxContext );
diff --git a/framework/source/uielement/uicommanddescription.cxx
b/framework/source/uielement/uicommanddescription.cxx
index 682b482766fc..9f81afced1a7 100644
--- a/framework/source/uielement/uicommanddescription.cxx
+++ b/framework/source/uielement/uicommanddescription.cxx
@@ -565,8 +565,7 @@ void
UICommandDescription::ensureGenericUICommandsForLanguage(const LanguageTag&
}
UICommandDescription::UICommandDescription(const Reference< XComponentContext
>& rxContext)
-: UICommandDescription_BASE(m_aMutex)
-, m_aPrivateResourceURL(PRIVATE_RESOURCE_URL)
+: m_aPrivateResourceURL(PRIVATE_RESOURCE_URL)
, m_xContext(rxContext)
{
SvtSysLocale aSysLocale;
@@ -584,14 +583,13 @@ UICommandDescription::UICommandDescription(const
Reference< XComponentContext >&
}
UICommandDescription::UICommandDescription(const Reference< XComponentContext
>& rxContext, bool)
-: UICommandDescription_BASE(m_aMutex)
-, m_xContext(rxContext)
+: m_xContext(rxContext)
{
}
UICommandDescription::~UICommandDescription()
{
-osl::MutexGuard g(rBHelper.rMutex);
+std::unique_lock g(m_aMutex);
m_aModuleToCommandFileMap.clear();
m_aUICommandsHashMap.clear();
m_xGenericUICommands.clear();
@@ -637,7 +635,7 @@ Any SAL_CALL UICommandDescription::getByName( const
OUString& aName )
const LanguageTag& rCurrentLanguage = aSysLocale.GetUILanguageTag();
Any a;
-osl::MutexGuard g(rBHelper.rMutex);
+std::unique_lock g(m_aMutex);
ModuleToCommandFileMap::const_iterator pM2CIter =
m_aModuleToCommandFileMap.find( aName );
if ( pM2CIter != m_aModuleToCommandFileMap.end() )
@@ -682,14 +680,14 @@ Any SAL_CALL UICommandDescription::getByName( const
OUString& aName )
Sequence< OUString > SAL_CALL UICommandDescription::getElementNames()
{
-osl::MutexGuard g(rBHelper.rMutex);
+std::unique_lock g(m_aMutex);
return comphelper::mapKeysToSequence( m_aModuleToCommandFileMap );
}
sal_Bool SAL_CALL UICommandDescription::hasByName( const OUString& aName )
{
-osl::MutexGuard g(rBHelper.rMutex);
+std::unique_lock g(m_aMutex);
ModuleToCommandFileMap::const_iterator pIter =
m_aModuleToCommandFileMap.find( aName );
return ( pIter != m_aModuleToCommandFileMap.end() );
[Libreoffice-commits] core.git: framework/source
framework/source/services/substitutepathvars.cxx | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
New commits:
commit 92c0775f2fa4f90ef9a19cb1d466e6bfec3dd9f0
Author: Noel Grandin
AuthorDate: Fri Dec 24 20:49:12 2021 +0200
Commit: Noel Grandin
CommitDate: Sun Dec 26 08:22:42 2021 +0100
use comphelper::WeakComponentImplHelper in SubstitutePathVariables
Change-Id: I1b41ae57b65b42ef63d2d2c026cf78a00b5b937d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127462
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/framework/source/services/substitutepathvars.cxx
b/framework/source/services/substitutepathvars.cxx
index 84725a3a18c4..bf50f889a9e4 100644
--- a/framework/source/services/substitutepathvars.cxx
+++ b/framework/source/services/substitutepathvars.cxx
@@ -20,8 +20,7 @@
#include
#include
-#include
-#include
+#include
#include
#include
@@ -129,12 +128,11 @@ struct ReSubstFixedVarOrder
}
};
-typedef ::cppu::WeakComponentImplHelper<
+typedef comphelper::WeakComponentImplHelper<
css::util::XStringSubstitution,
css::lang::XServiceInfo > SubstitutePathVariables_BASE;
-class SubstitutePathVariables : private cppu::BaseMutex,
-public SubstitutePathVariables_BASE
+class SubstitutePathVariables : public SubstitutePathVariables_BASE
{
public:
explicit SubstitutePathVariables(const css::uno::Reference<
css::uno::XComponentContext >& xContext);
@@ -191,7 +189,6 @@ private:
};
SubstitutePathVariables::SubstitutePathVariables( const Reference<
XComponentContext >& xContext ) :
-SubstitutePathVariables_BASE(m_aMutex),
m_xContext( xContext )
{
SetPredefinedPathVariables();
@@ -227,19 +224,19 @@ SubstitutePathVariables::SubstitutePathVariables( const
Reference< XComponentCon
// XStringSubstitution
OUString SAL_CALL SubstitutePathVariables::substituteVariables( const
OUString& aText, sal_Bool bSubstRequired )
{
-osl::MutexGuard g(rBHelper.rMutex);
+std::unique_lock g(m_aMutex);
return impl_substituteVariable( aText, bSubstRequired );
}
OUString SAL_CALL SubstitutePathVariables::reSubstituteVariables( const
OUString& aText )
{
-osl::MutexGuard g(rBHelper.rMutex);
+std::unique_lock g(m_aMutex);
return impl_reSubstituteVariables( aText );
}
OUString SAL_CALL SubstitutePathVariables::getSubstituteVariableValue( const
OUString& aVariable )
{
-osl::MutexGuard g(rBHelper.rMutex);
+std::unique_lock g(m_aMutex);
return impl_getSubstituteVariableValue( aVariable );
}
[Libreoffice-commits] core.git: framework/source
framework/source/services/taskcreatorsrv.cxx | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
New commits:
commit 2d1ed93e46e01f575b3f3755bf9f5da0d6f370ef
Author: Noel Grandin
AuthorDate: Fri Dec 24 20:50:28 2021 +0200
Commit: Noel Grandin
CommitDate: Sun Dec 26 08:22:20 2021 +0100
use comphelper::WeakComponentImplHelper in TaskCreatorService
Change-Id: I2414ef01bc0990c68bb6fa02a897bfa19d7982a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127463
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/framework/source/services/taskcreatorsrv.cxx
b/framework/source/services/taskcreatorsrv.cxx
index 9ce0941fb745..c484e115d7c6 100644
--- a/framework/source/services/taskcreatorsrv.cxx
+++ b/framework/source/services/taskcreatorsrv.cxx
@@ -35,8 +35,7 @@
#include
#include
-#include
-#include
+#include
#include
#include
#include
@@ -47,12 +46,11 @@ using namespace framework;
namespace {
-typedef ::cppu::WeakComponentImplHelper<
+typedef comphelper::WeakComponentImplHelper<
css::lang::XServiceInfo,
css::lang::XSingleServiceFactory> TaskCreatorService_BASE;
-class TaskCreatorService : private cppu::BaseMutex,
- public TaskCreatorService_BASE
+class TaskCreatorService : public TaskCreatorService_BASE
{
private:
@@ -106,8 +104,7 @@ private:
};
TaskCreatorService::TaskCreatorService(const css::uno::Reference<
css::uno::XComponentContext >& xContext)
-: TaskCreatorService_BASE(m_aMutex)
-, m_xContext (xContext )
+: m_xContext (xContext )
{
}
[Libreoffice-commits] core.git: framework/source
framework/source/uiconfiguration/windowstateconfiguration.cxx | 17 --
1 file changed, 7 insertions(+), 10 deletions(-)
New commits:
commit 058c64ad17ef8ed0d7f583a804368aa8d0071e59
Author: Noel Grandin
AuthorDate: Fri Dec 24 20:54:15 2021 +0200
Commit: Noel Grandin
CommitDate: Sun Dec 26 08:21:59 2021 +0100
use comphelper::WeakComponentImplHelper in WindowStateConfiguration
Change-Id: Iada515ab1926aa1e0b7a3f39690d7c6eebf28aea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127465
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/framework/source/uiconfiguration/windowstateconfiguration.cxx
b/framework/source/uiconfiguration/windowstateconfiguration.cxx
index cc6f72f36a11..acb0ae059ff9 100644
--- a/framework/source/uiconfiguration/windowstateconfiguration.cxx
+++ b/framework/source/uiconfiguration/windowstateconfiguration.cxx
@@ -36,8 +36,7 @@
#include
#include
-#include
-#include
+#include
#include
#include
#include
@@ -1222,11 +1221,10 @@ void
ConfigurationAccess_WindowState::impl_initializeConfigAccess()
}
}
-typedef ::cppu::WeakComponentImplHelper< css::container::XNameAccess,
+typedef comphelper::WeakComponentImplHelper< css::container::XNameAccess,
css::lang::XServiceInfo> WindowStateConfiguration_BASE;
-class WindowStateConfiguration : private cppu::BaseMutex,
- public WindowStateConfiguration_BASE
+class WindowStateConfiguration : public WindowStateConfiguration_BASE
{
public:
explicit WindowStateConfiguration( const css::uno::Reference<
css::uno::XComponentContext >& rxContext );
@@ -1271,7 +1269,6 @@ private:
};
WindowStateConfiguration::WindowStateConfiguration( const Reference<
XComponentContext >& rxContext ) :
-WindowStateConfiguration_BASE(m_aMutex),
m_xContext( rxContext )
{
css::uno::Reference< css::frame::XModuleManager2 > xModuleManager =
@@ -1317,14 +1314,14 @@ WindowStateConfiguration::WindowStateConfiguration(
const Reference< XComponentC
WindowStateConfiguration::~WindowStateConfiguration()
{
-osl::MutexGuard g(cppu::WeakComponentImplHelperBase::rBHelper.rMutex);
+std::unique_lock g(m_aMutex);
m_aModuleToFileHashMap.clear();
m_aModuleToWindowStateHashMap.clear();
}
Any SAL_CALL WindowStateConfiguration::getByName( const OUString&
aModuleIdentifier )
{
-osl::MutexGuard g(cppu::WeakComponentImplHelperBase::rBHelper.rMutex);
+std::unique_lock g(m_aMutex);
ModuleToWindowStateFileMap::const_iterator pIter =
m_aModuleToFileHashMap.find( aModuleIdentifier );
if ( pIter != m_aModuleToFileHashMap.end() )
@@ -1353,14 +1350,14 @@ Any SAL_CALL WindowStateConfiguration::getByName( const
OUString& aModuleIdentif
Sequence< OUString > SAL_CALL WindowStateConfiguration::getElementNames()
{
-osl::MutexGuard g(cppu::WeakComponentImplHelperBase::rBHelper.rMutex);
+std::unique_lock g(m_aMutex);
return comphelper::mapKeysToSequence( m_aModuleToFileHashMap );
}
sal_Bool SAL_CALL WindowStateConfiguration::hasByName( const OUString& aName )
{
-osl::MutexGuard g(cppu::WeakComponentImplHelperBase::rBHelper.rMutex);
+std::unique_lock g(m_aMutex);
ModuleToWindowStateFileMap::const_iterator pIter =
m_aModuleToFileHashMap.find( aName );
return ( pIter != m_aModuleToFileHashMap.end() );
[Libreoffice-bugs] [Bug 146162] JUMBO SHEETS: cannot hide all columns
https://bugs.documentfoundation.org/show_bug.cgi?id=146162 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146180] Show fields in Calc's navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=146180 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146175] fo:keep-with-next="always" does not work if next paragraph covers less than remaining page but more than remaining space down to bottom margin
https://bugs.documentfoundation.org/show_bug.cgi?id=146175 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145995] Defined DATA ranges merge destructively if cells seperating them are inadvertantly filled.
https://bugs.documentfoundation.org/show_bug.cgi?id=145995 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146063] Trying to write a letter with a tilde (e.g. á) to the end of a line results in changing to the next line if such a line exists
https://bugs.documentfoundation.org/show_bug.cgi?id=146063 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146063] Trying to write a letter with a tilde (e.g. á) to the end of a line results in changing to the next line if such a line exists
https://bugs.documentfoundation.org/show_bug.cgi?id=146063 --- Comment #5 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142256] set the size the ordinal number suffixes in LibreOffice Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=142256 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142256] set the size the ordinal number suffixes in LibreOffice Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=142256 --- Comment #3 from QA Administrators --- Dear André Luiz, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142019] Crash after reopen a special saved file
https://bugs.documentfoundation.org/show_bug.cgi?id=142019 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142019] Crash after reopen a special saved file
https://bugs.documentfoundation.org/show_bug.cgi?id=142019 --- Comment #7 from QA Administrators --- Dear Regina Henschel, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 125489] Slow start with AD users
https://bugs.documentfoundation.org/show_bug.cgi?id=125489 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 125489] Slow start with AD users
https://bugs.documentfoundation.org/show_bug.cgi?id=125489 --- Comment #19 from QA Administrators --- Dear Vincent, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143097] Loss of setting
https://bugs.documentfoundation.org/show_bug.cgi?id=143097 --- Comment #3 from QA Administrators --- Dear danmarco, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143094] speed and performance issues while opening a large size file
https://bugs.documentfoundation.org/show_bug.cgi?id=143094 --- Comment #2 from QA Administrators --- Dear chintu.rohit19, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 93139] The orca Screen Reader is silent when placing focus over a bullet in a bulleted list.
https://bugs.documentfoundation.org/show_bug.cgi?id=93139 --- Comment #13 from QA Administrators --- Dear am_dxer, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 92593] Check out file from OpenDataSpace via CMIS does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=92593 --- Comment #3 from QA Administrators --- Dear Andras Timar, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 92592] Save as to OpenDataSpace via CMIS is buggy
https://bugs.documentfoundation.org/show_bug.cgi?id=92592 --- Comment #3 from QA Administrators --- Dear Andras Timar, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 92591] Save to OpenDataSpace via CMIS fails
https://bugs.documentfoundation.org/show_bug.cgi?id=92591 --- Comment #3 from QA Administrators --- Dear Andras Timar, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 90693] Underline Does Also Include Indent for First Bullet Point After an Image
https://bugs.documentfoundation.org/show_bug.cgi?id=90693 --- Comment #12 from QA Administrators --- Dear Thomas Ascher, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 129564] Insert Picture function default directory problem
https://bugs.documentfoundation.org/show_bug.cgi?id=129564 --- Comment #4 from QA Administrators --- Dear Paul Connacher, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 129530] vertical flip, which is contained in draw:transform, does not flip a legacy arc
https://bugs.documentfoundation.org/show_bug.cgi?id=129530 --- Comment #2 from QA Administrators --- Dear Regina Henschel, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112641] freeze rows/columns functions incorrect or unexpected when frozen rows/columns don't fit in Window
https://bugs.documentfoundation.org/show_bug.cgi?id=112641 --- Comment #11 from QA Administrators --- Dear Winfried Donkers (retired), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 100871] Bullets and numberings not expose to Assistives Technologies
https://bugs.documentfoundation.org/show_bug.cgi?id=100871 --- Comment #8 from QA Administrators --- Dear Alex ARNAUD, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - icon-themes/colibre icon-themes/colibre_svg
icon-themes/colibre/cmd/32/ar/recsave.png |binary icon-themes/colibre/cmd/32/mailmergesavedocuments.png |binary icon-themes/colibre/cmd/32/recsave.png|binary icon-themes/colibre/cmd/32/save.png |binary icon-themes/colibre/cmd/32/saveacopy.png |binary icon-themes/colibre/cmd/32/saveall.png|binary icon-themes/colibre/cmd/32/saveas.png |binary icon-themes/colibre/cmd/32/saveasremote.png |binary icon-themes/colibre/cmd/32/saveastemplate.png |binary icon-themes/colibre/cmd/32/savebackground.png |binary icon-themes/colibre/cmd/ar/lc_recsave.png |binary icon-themes/colibre/cmd/ar/sc_recsave.png |binary icon-themes/colibre/cmd/lc_mailmergesavedocuments.png |binary icon-themes/colibre/cmd/lc_recsave.png|binary icon-themes/colibre/cmd/lc_save.png |binary icon-themes/colibre/cmd/lc_saveacopy.png |binary icon-themes/colibre/cmd/lc_saveall.png|binary icon-themes/colibre/cmd/lc_saveasremote.png |binary icon-themes/colibre/cmd/lc_saveastemplate.png |binary icon-themes/colibre/cmd/lc_savebackground.png |binary icon-themes/colibre/cmd/sc_mailmergesavedocuments.png |binary icon-themes/colibre/cmd/sc_recsave.png|binary icon-themes/colibre/cmd/sc_save.png |binary icon-themes/colibre/cmd/sc_saveacopy.png |binary icon-themes/colibre/cmd/sc_saveas.png |binary icon-themes/colibre/cmd/sc_saveasremote.png |binary icon-themes/colibre/cmd/sc_saveastemplate.png |binary icon-themes/colibre/cmd/sc_savebackground.png |binary icon-themes/colibre/res/savemodified_extralarge.png |binary icon-themes/colibre/res/savemodified_large.png|binary icon-themes/colibre/res/savemodified_small.png|binary icon-themes/colibre_svg/cmd/32/ar/recsave.svg |2 +- icon-themes/colibre_svg/cmd/32/mailmergesavedocuments.svg |2 +- icon-themes/colibre_svg/cmd/32/recsave.svg|2 +- icon-themes/colibre_svg/cmd/32/save.svg |2 +- icon-themes/colibre_svg/cmd/32/saveacopy.svg |2 +- icon-themes/colibre_svg/cmd/32/saveall.svg|2 +- icon-themes/colibre_svg/cmd/32/saveas.svg |2 +- icon-themes/colibre_svg/cmd/32/saveasremote.svg |2 +- icon-themes/colibre_svg/cmd/32/saveastemplate.svg |2 +- icon-themes/colibre_svg/cmd/32/savebackground.svg |2 +- icon-themes/colibre_svg/cmd/ar/lc_recsave.svg |2 +- icon-themes/colibre_svg/cmd/ar/sc_recsave.svg |3 +-- icon-themes/colibre_svg/cmd/lc_mailmergesavedocuments.svg |2 +- icon-themes/colibre_svg/cmd/lc_recsave.svg|2 +- icon-themes/colibre_svg/cmd/lc_save.svg |2 +- icon-themes/colibre_svg/cmd/lc_saveacopy.svg |2 +- icon-themes/colibre_svg/cmd/lc_saveall.svg|2 +- icon-themes/colibre_svg/cmd/lc_saveasremote.svg |2 +- icon-themes/colibre_svg/cmd/lc_saveastemplate.svg |2 +- icon-themes/colibre_svg/cmd/lc_savebackground.svg |2 +- icon-themes/colibre_svg/cmd/sc_mailmergesavedocuments.svg |2 +- icon-themes/colibre_svg/cmd/sc_recsave.svg|3 +-- icon-themes/colibre_svg/cmd/sc_save.svg |2 +- icon-themes/colibre_svg/cmd/sc_saveacopy.svg |2 +- icon-themes/colibre_svg/cmd/sc_saveas.svg |2 +- icon-themes/colibre_svg/cmd/sc_saveasremote.svg |2 +- icon-themes/colibre_svg/cmd/sc_saveastemplate.svg |3 +-- icon-themes/colibre_svg/cmd/sc_savebackground.svg |3 +-- icon-themes/colibre_svg/res/savemodified_extralarge.svg |2 +- icon-themes/colibre_svg/res/savemodified_large.svg|2 +- icon-themes/colibre_svg/res/savemodified_small.svg|2 +- 62 files changed, 31 insertions(+), 35 deletions(-) New commits: commit 5abdeb97d14a956b152ff7c08add9f313d554358 Author: Rizal Muttaqin AuthorDate: Sat Dec 25 21:07:14 2021 +0700 Commit: Rizal Muttaqin CommitDate: Sun Dec 26 01:55:11 2021 +0100 Colibre: update Save related icons Change-Id: I01542908edf1d855fe723e0a7818cd05297f49aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127473 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin diff --git a/icon-themes/colibre/cmd/32/ar/recsave.png b/icon-themes/colibre/cmd/32/ar/recsave.png index 7389970a1ff3..ecb925d2d1d3 100644 Binary files a/icon-themes/colibre/cmd/32/ar/recsave.png and b/icon-themes/colibre/cmd/32/ar/recsave.png differ diff --git
[Libreoffice-bugs] [Bug 48409] FILEOPEN LibO 3.3 documents shows Writer OLE object contents shifted right / down in object after edit of object because of page border issue
https://bugs.documentfoundation.org/show_bug.cgi?id=48409 eisa01 changed: What|Removed |Added Priority|highest |medium Severity|normal |minor --- Comment #39 from eisa01 --- If I read this correctly, this is a bug that manifests itself if you have a document created in LO3.3 that uses OLE objects As such, this can hardly have the "highest" priority any longer E.g., the 3.6 test case does not shift the text when I open in 7.4 alpha, so it's been stable for almost a decade? Setting as Medium - Minor as per my interpretation of the prioritization flow chart, but it could just as well be won't fix at this point? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 83066] [META] CJK (Chinese, Japanese, Korean, and Vietnamese) language issues
https://bugs.documentfoundation.org/show_bug.cgi?id=83066 eisa01 changed: What|Removed |Added Depends on||123555 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=123555 [Bug 123555] Table of Content link tooltip renders blank squares instead of Chinese characters in Word openxml document (macOS-only) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108042] Tooltips display for toolbar icons suffer from broken font fallback on OSX in CJK UIs
https://bugs.documentfoundation.org/show_bug.cgi?id=108042 eisa01 changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||3555 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 123555] Table of Content link tooltip renders blank squares instead of Chinese characters in Word openxml document (macOS-only)
https://bugs.documentfoundation.org/show_bug.cgi?id=123555 eisa01 changed: What|Removed |Added Blocks||83066 See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||8042 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=83066 [Bug 83066] [META] CJK (Chinese, Japanese, Korean, and Vietnamese) language issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 98290] [META] Better shortcuts on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=98290 eisa01 changed: What|Removed |Added Depends on||53965 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=53965 [Bug 53965] Character ` is inserted while cycling through the windows on macOS on some keyboard layouts -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 53965] Character ` is inserted while cycling through the windows on macOS on some keyboard layouts
https://bugs.documentfoundation.org/show_bug.cgi?id=53965 eisa01 changed: What|Removed |Added Blocks||98290 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=98290 [Bug 98290] [META] Better shortcuts on macOS -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 98290] [META] Better shortcuts on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=98290 eisa01 changed: What|Removed |Added Depends on||135651 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=135651 [Bug 135651] Cmd+left/right arrow does the wrong thing in Calc -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135651] Cmd+left/right arrow does the wrong thing in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=135651 eisa01 changed: What|Removed |Added Blocks||98290 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=98290 [Bug 98290] [META] Better shortcuts on macOS -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 101958] "Find" toolbar field won't accept pasted text from the clipboard other than unformatted text after keyboard switch
https://bugs.documentfoundation.org/show_bug.cgi?id=101958 eisa01 changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||6976 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 106976] Can't paste english text as a filename when russian keyboard is on
https://bugs.documentfoundation.org/show_bug.cgi?id=106976 eisa01 changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||1958 --- Comment #12 from eisa01 --- Still present Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 9bfc42015acd6ae3475ab7927ccc006507cc38a2 CPU threads: 4; OS: Mac OS X 10.14.6; UI render: Skia/Raster; VCL: osx Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 98290] [META] Better shortcuts on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=98290 eisa01 changed: What|Removed |Added Depends on||128392 See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=12 | |8392| Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=128392 [Bug 128392] Libreoffice for Mac OS X does not respect Dvorak-QWERTY keyboard layout for command keys. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 128392] Libreoffice for Mac OS X does not respect Dvorak-QWERTY keyboard layout for command keys.
https://bugs.documentfoundation.org/show_bug.cgi?id=128392 eisa01 changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=98 | |290 | Blocks||98290 --- Comment #12 from eisa01 --- Still present Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 9bfc42015acd6ae3475ab7927ccc006507cc38a2 CPU threads: 4; OS: Mac OS X 10.14.6; UI render: Skia/Raster; VCL: osx Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=98290 [Bug 98290] [META] Better shortcuts on macOS -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107838] [META] Character-level bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107838 Bug 107838 depends on bug 38533, which changed state. Bug 38533 Summary: FORMATING : text color render different from background color whereas it's the same color https://bugs.documentfoundation.org/show_bug.cgi?id=38533 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107831] [META] Paragraph-level bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107831 Bug 107831 depends on bug 38533, which changed state. Bug 38533 Summary: FORMATING : text color render different from background color whereas it's the same color https://bugs.documentfoundation.org/show_bug.cgi?id=38533 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 38533] FORMATING : text color render different from background color whereas it's the same color
https://bugs.documentfoundation.org/show_bug.cgi?id=38533 eisa01 changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #29 from eisa01 --- I can no longer repro this Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 9bfc42015acd6ae3475ab7927ccc006507cc38a2 CPU threads: 4; OS: Mac OS X 10.14.6; UI render: Skia/Raster; VCL: osx Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 79460] EDITING: macOS - Select all shortcut jumps to beginning of footer paragraph in particular Word document
https://bugs.documentfoundation.org/show_bug.cgi?id=79460 --- Comment #21 from eisa01 --- Still present Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 9bfc42015acd6ae3475ab7927ccc006507cc38a2 CPU threads: 4; OS: Mac OS X 10.14.6; UI render: Skia/Raster; VCL: osx Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: comphelper/source include/comphelper
comphelper/source/misc/compbase.cxx |5 -
include/comphelper/compbase.hxx |1 -
2 files changed, 6 deletions(-)
New commits:
commit 9f5188173a4a37a9d41ee90a874f1f17136e
Author: Mike Kaganski
AuthorDate: Sat Dec 25 19:29:32 2021 +0100
Commit: Jan-Marek Glogowski
CommitDate: Sat Dec 25 23:35:39 2021 +0100
Revert "Init WeakComponentImplHelperBase::m_bDisposed"
This reverts commit c1f21a6ce6491ac82a022502c618e2758d3b3a31.
Reason for revert: a better fix is implemented in commit
f0c0c62c10e4ffdb9ce44202e2540d2f39a9fcb5
author Noel Grandin
dateSat Dec 25 11:43:11 2021 +0200
uninitialised field in comphelper::WeakComponentImplHelperBase
That change allows to keep the ctor implicitly defined and inline.
Change-Id: Icb8064ebc77d4120d279d30df5de4ebee5479b4b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127474
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
diff --git a/comphelper/source/misc/compbase.cxx
b/comphelper/source/misc/compbase.cxx
index b8a207ceedb1..6e2019a255ae 100644
--- a/comphelper/source/misc/compbase.cxx
+++ b/comphelper/source/misc/compbase.cxx
@@ -11,11 +11,6 @@
namespace comphelper
{
-WeakComponentImplHelperBase::WeakComponentImplHelperBase()
-: m_bDisposed(false)
-{
-}
-
WeakComponentImplHelperBase::~WeakComponentImplHelperBase() {}
// css::lang::XComponent
diff --git a/include/comphelper/compbase.hxx b/include/comphelper/compbase.hxx
index ce3e44b3732e..5b7e1f7ba7a1 100644
--- a/include/comphelper/compbase.hxx
+++ b/include/comphelper/compbase.hxx
@@ -31,7 +31,6 @@ class COMPHELPER_DLLPUBLIC WeakComponentImplHelperBase :
public cppu::OWeakObjec
public
css::lang::XComponent
{
public:
-WeakComponentImplHelperBase();
virtual ~WeakComponentImplHelperBase() override;
// css::lang::XComponent
[Libreoffice-bugs] [Bug 60582] EDITING: Incorrect inserting of images to Draw when done by Copy/Paste from Finder
https://bugs.documentfoundation.org/show_bug.cgi?id=60582 --- Comment #10 from eisa01 --- Still present Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 9bfc42015acd6ae3475ab7927ccc006507cc38a2 CPU threads: 4; OS: Mac OS X 10.14.6; UI render: Skia/Raster; VCL: osx Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 42082] [META] Make LibreOffice shine and glow on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=42082 Bug 42082 depends on bug 102018, which changed state. Bug 102018 Summary: Toolbar mode switching slow on Mac https://bugs.documentfoundation.org/show_bug.cgi?id=102018 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102018] Toolbar mode switching slow on Mac
https://bugs.documentfoundation.org/show_bug.cgi?id=102018 eisa01 changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #9 from eisa01 --- This is quite quick now Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 9bfc42015acd6ae3475ab7927ccc006507cc38a2 CPU threads: 4; OS: Mac OS X 10.14.6; UI render: Skia/Raster; VCL: osx Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 101958] "Find" toolbar field won't accept pasted text from the clipboard other than unformatted text after keyboard switch
https://bugs.documentfoundation.org/show_bug.cgi?id=101958 --- Comment #12 from eisa01 --- Still present Interestingly it pops up a text import options dialog box Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 9bfc42015acd6ae3475ab7927ccc006507cc38a2 CPU threads: 4; OS: Mac OS X 10.14.6; UI render: Skia/Raster; VCL: osx Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146377] Error doesn't propagate as first parameter in IF when "IfFalse" contains ISERROR or IFERROR
https://bugs.documentfoundation.org/show_bug.cgi?id=146377 --- Comment #6 from Commit Notification --- Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-7-3": https://git.libreoffice.org/core/commit/eb050ea5b004e2f4a6ba96474177251f678707e9 Related: tdf#146377 Let AND(), OR(), XOR() propagate the current error, if any It will be available in 7.3.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146377] Error doesn't propagate as first parameter in IF when "IfFalse" contains ISERROR or IFERROR
https://bugs.documentfoundation.org/show_bug.cgi?id=146377 Commit Notification changed: What|Removed |Added Whiteboard||target:7.3.0.2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sc/source
sc/source/core/tool/interpr1.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit eb050ea5b004e2f4a6ba96474177251f678707e9 Author: Eike Rathke AuthorDate: Sat Dec 25 19:38:14 2021 +0100 Commit: Eike Rathke CommitDate: Sat Dec 25 23:20:45 2021 +0100 Related: tdf#146377 Let AND(), OR(), XOR() propagate the current error, if any ... instead of forcing Err:504 Change-Id: I7e91671ffc61bf82d9095378656b41981040f55e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127492 Reviewed-by: Eike Rathke Tested-by: Jenkins (cherry picked from commit 4674ff347cd2e71445503efdc0c110d094daa80b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127476 diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx index fae8a6eeb222..345ab7115815 100644 --- a/sc/source/core/tool/interpr1.cxx +++ b/sc/source/core/tool/interpr1.cxx @@ -1342,7 +1342,7 @@ void ScInterpreter::ScAnd() } break; default: -Pop(); +PopError(); SetError( FormulaError::IllegalParameter); } } @@ -1441,7 +1441,7 @@ void ScInterpreter::ScOr() } break; default: -Pop(); +PopError(); SetError( FormulaError::IllegalParameter); } } @@ -1543,7 +1543,7 @@ void ScInterpreter::ScXor() } break; default: -Pop(); +PopError(); SetError( FormulaError::IllegalParameter); } }
[Libreoffice-bugs] [Bug 146377] Error doesn't propagate as first parameter in IF when "IfFalse" contains ISERROR or IFERROR
https://bugs.documentfoundation.org/show_bug.cgi?id=146377 --- Comment #5 from Mike Kaganski --- (In reply to Eike Rathke from comment #4) > What does Excel do for this specific case? Both: =IF(NA();1;IFERROR(NA();2)) =AND(NA();IFERROR(NA();1)) result in #N/A. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - icon-themes/colibre icon-themes/colibre_svg
icon-themes/colibre/dbaccess/res/lc039.png |binary icon-themes/colibre/dbaccess/res/sc039.png |binary icon-themes/colibre/sd/res/pagobjex.png|binary icon-themes/colibre/sw/res/sc20248.png |binary icon-themes/colibre_svg/dbaccess/res/lc039.svg |2 +- icon-themes/colibre_svg/dbaccess/res/sc039.svg |3 ++- icon-themes/colibre_svg/sd/res/pagobjex.svg|2 +- icon-themes/colibre_svg/sw/res/sc20248.svg |3 ++- 8 files changed, 6 insertions(+), 4 deletions(-) New commits: commit 8d95c59b79516fe1eab0fd8612962470bce303e1 Author: Rizal Muttaqin AuthorDate: Sat Dec 25 22:14:08 2021 +0700 Commit: Rizal Muttaqin CommitDate: Sat Dec 25 22:53:34 2021 +0100 Colibre: update Save related icons part II Change-Id: Ic2bbd21ae12d8465cc8ba1f6429e0c516f6dbc59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127458 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin (cherry picked from commit 5e528165e2e6026d2d1ba3386f2b45544c0c6ab1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127475 diff --git a/icon-themes/colibre/dbaccess/res/lc039.png b/icon-themes/colibre/dbaccess/res/lc039.png index d117989919f5..b9bab570f49c 100644 Binary files a/icon-themes/colibre/dbaccess/res/lc039.png and b/icon-themes/colibre/dbaccess/res/lc039.png differ diff --git a/icon-themes/colibre/dbaccess/res/sc039.png b/icon-themes/colibre/dbaccess/res/sc039.png index 4b1624a98118..36543dd673bd 100644 Binary files a/icon-themes/colibre/dbaccess/res/sc039.png and b/icon-themes/colibre/dbaccess/res/sc039.png differ diff --git a/icon-themes/colibre/sd/res/pagobjex.png b/icon-themes/colibre/sd/res/pagobjex.png index 96e31e3b0a4b..84f89c318bb8 100644 Binary files a/icon-themes/colibre/sd/res/pagobjex.png and b/icon-themes/colibre/sd/res/pagobjex.png differ diff --git a/icon-themes/colibre/sw/res/sc20248.png b/icon-themes/colibre/sw/res/sc20248.png index 0cfd3323ec37..4da40ea96cef 100644 Binary files a/icon-themes/colibre/sw/res/sc20248.png and b/icon-themes/colibre/sw/res/sc20248.png differ diff --git a/icon-themes/colibre_svg/dbaccess/res/lc039.svg b/icon-themes/colibre_svg/dbaccess/res/lc039.svg index 9867e7ef3cf9..51bebd1ac2e6 100644 --- a/icon-themes/colibre_svg/dbaccess/res/lc039.svg +++ b/icon-themes/colibre_svg/dbaccess/res/lc039.svg @@ -1 +1 @@ -http://www.w3.org/2000/svg;> \ No newline at end of file +http://www.w3.org/2000/svg;> \ No newline at end of file diff --git a/icon-themes/colibre_svg/dbaccess/res/sc039.svg b/icon-themes/colibre_svg/dbaccess/res/sc039.svg index d09059c87ba5..14df9c01968f 100644 --- a/icon-themes/colibre_svg/dbaccess/res/sc039.svg +++ b/icon-themes/colibre_svg/dbaccess/res/sc039.svg @@ -1,4 +1,5 @@ http://www.w3.org/2000/svg;> -/amp;amp;gt; \ No newline at end of file + +/amp;amp;amp;gt; \ No newline at end of file diff --git a/icon-themes/colibre_svg/sd/res/pagobjex.svg b/icon-themes/colibre_svg/sd/res/pagobjex.svg index ca8df96d5760..4301823d3d6b 100644 --- a/icon-themes/colibre_svg/sd/res/pagobjex.svg +++ b/icon-themes/colibre_svg/sd/res/pagobjex.svg @@ -1 +1 @@ -http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file +http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file diff --git a/icon-themes/colibre_svg/sw/res/sc20248.svg b/icon-themes/colibre_svg/sw/res/sc20248.svg index 7529ef40d616..a97720f96aea 100644 --- a/icon-themes/colibre_svg/sw/res/sc20248.svg +++ b/icon-themes/colibre_svg/sw/res/sc20248.svg @@ -1 +1,2 @@ -http://www.w3.org/2000/svg;>/amp;amp;gt; \ No newline at end of file +http://www.w3.org/2000/svg;> +/amp;amp;amp;gt; \ No newline at end of file
[Libreoffice-bugs] [Bug 45089] FILELOAD: Table formatting damaged loading file from .doc
https://bugs.documentfoundation.org/show_bug.cgi?id=45089 --- Comment #16 from eisa01 --- Still present on point 33. Double checked it actually looks OK in modern Word Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 9bfc42015acd6ae3475ab7927ccc006507cc38a2 CPU threads: 4; OS: Mac OS X 10.14.6; UI render: Skia/Raster; VCL: osx Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/source
sc/source/core/tool/interpr1.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 4674ff347cd2e71445503efdc0c110d094daa80b Author: Eike Rathke AuthorDate: Sat Dec 25 19:38:14 2021 +0100 Commit: Eike Rathke CommitDate: Sat Dec 25 22:29:25 2021 +0100 Related: tdf#146377 Let AND(), OR(), XOR() propagate the current error, if any ... instead of forcing Err:504 Change-Id: I7e91671ffc61bf82d9095378656b41981040f55e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127492 Reviewed-by: Eike Rathke Tested-by: Jenkins diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx index fae8a6eeb222..345ab7115815 100644 --- a/sc/source/core/tool/interpr1.cxx +++ b/sc/source/core/tool/interpr1.cxx @@ -1342,7 +1342,7 @@ void ScInterpreter::ScAnd() } break; default: -Pop(); +PopError(); SetError( FormulaError::IllegalParameter); } } @@ -1441,7 +1441,7 @@ void ScInterpreter::ScOr() } break; default: -Pop(); +PopError(); SetError( FormulaError::IllegalParameter); } } @@ -1543,7 +1543,7 @@ void ScInterpreter::ScXor() } break; default: -Pop(); +PopError(); SetError( FormulaError::IllegalParameter); } }
[Libreoffice-bugs] [Bug 125750] PIVOTTABLE scatter chart
https://bugs.documentfoundation.org/show_bug.cgi?id=125750 GfEw changed: What|Removed |Added CC||gfew3...@gmail.com --- Comment #4 from GfEw --- I found this in the aftermath of my unresolved question at https://ask.libreoffice.org/t/pivot-table-chart-how-to-enforce-linear-x-axis-pace-across-skipped-rows/ . This bug is still present in LO version 7.2.3.2, build ID 20, at Linux 4.15. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: icon-themes/colibre icon-themes/colibre_svg
icon-themes/colibre/cmd/32/ar/recsave.png |binary icon-themes/colibre/cmd/32/mailmergesavedocuments.png |binary icon-themes/colibre/cmd/32/recsave.png|binary icon-themes/colibre/cmd/32/save.png |binary icon-themes/colibre/cmd/32/saveacopy.png |binary icon-themes/colibre/cmd/32/saveall.png|binary icon-themes/colibre/cmd/32/saveas.png |binary icon-themes/colibre/cmd/32/saveasremote.png |binary icon-themes/colibre/cmd/32/saveastemplate.png |binary icon-themes/colibre/cmd/32/savebackground.png |binary icon-themes/colibre/cmd/ar/lc_recsave.png |binary icon-themes/colibre/cmd/ar/sc_recsave.png |binary icon-themes/colibre/cmd/lc_mailmergesavedocuments.png |binary icon-themes/colibre/cmd/lc_recsave.png|binary icon-themes/colibre/cmd/lc_save.png |binary icon-themes/colibre/cmd/lc_saveacopy.png |binary icon-themes/colibre/cmd/lc_saveall.png|binary icon-themes/colibre/cmd/lc_saveasremote.png |binary icon-themes/colibre/cmd/lc_saveastemplate.png |binary icon-themes/colibre/cmd/lc_savebackground.png |binary icon-themes/colibre/cmd/sc_mailmergesavedocuments.png |binary icon-themes/colibre/cmd/sc_recsave.png|binary icon-themes/colibre/cmd/sc_save.png |binary icon-themes/colibre/cmd/sc_saveacopy.png |binary icon-themes/colibre/cmd/sc_saveas.png |binary icon-themes/colibre/cmd/sc_saveasremote.png |binary icon-themes/colibre/cmd/sc_saveastemplate.png |binary icon-themes/colibre/cmd/sc_savebackground.png |binary icon-themes/colibre/res/savemodified_extralarge.png |binary icon-themes/colibre/res/savemodified_large.png|binary icon-themes/colibre/res/savemodified_small.png|binary icon-themes/colibre_svg/cmd/32/ar/recsave.svg |2 +- icon-themes/colibre_svg/cmd/32/mailmergesavedocuments.svg |2 +- icon-themes/colibre_svg/cmd/32/recsave.svg|2 +- icon-themes/colibre_svg/cmd/32/save.svg |2 +- icon-themes/colibre_svg/cmd/32/saveacopy.svg |2 +- icon-themes/colibre_svg/cmd/32/saveall.svg|2 +- icon-themes/colibre_svg/cmd/32/saveas.svg |2 +- icon-themes/colibre_svg/cmd/32/saveasremote.svg |2 +- icon-themes/colibre_svg/cmd/32/saveastemplate.svg |2 +- icon-themes/colibre_svg/cmd/32/savebackground.svg |2 +- icon-themes/colibre_svg/cmd/ar/lc_recsave.svg |2 +- icon-themes/colibre_svg/cmd/ar/sc_recsave.svg |3 +-- icon-themes/colibre_svg/cmd/lc_mailmergesavedocuments.svg |2 +- icon-themes/colibre_svg/cmd/lc_recsave.svg|2 +- icon-themes/colibre_svg/cmd/lc_save.svg |2 +- icon-themes/colibre_svg/cmd/lc_saveacopy.svg |2 +- icon-themes/colibre_svg/cmd/lc_saveall.svg|2 +- icon-themes/colibre_svg/cmd/lc_saveasremote.svg |2 +- icon-themes/colibre_svg/cmd/lc_saveastemplate.svg |2 +- icon-themes/colibre_svg/cmd/lc_savebackground.svg |2 +- icon-themes/colibre_svg/cmd/sc_mailmergesavedocuments.svg |2 +- icon-themes/colibre_svg/cmd/sc_recsave.svg|3 +-- icon-themes/colibre_svg/cmd/sc_save.svg |2 +- icon-themes/colibre_svg/cmd/sc_saveacopy.svg |2 +- icon-themes/colibre_svg/cmd/sc_saveas.svg |2 +- icon-themes/colibre_svg/cmd/sc_saveasremote.svg |2 +- icon-themes/colibre_svg/cmd/sc_saveastemplate.svg |3 +-- icon-themes/colibre_svg/cmd/sc_savebackground.svg |3 +-- icon-themes/colibre_svg/res/savemodified_extralarge.svg |2 +- icon-themes/colibre_svg/res/savemodified_large.svg|2 +- icon-themes/colibre_svg/res/savemodified_small.svg|2 +- 62 files changed, 31 insertions(+), 35 deletions(-) New commits: commit b7acac77f5bff97b3d525507a64c3d6bea8b43e1 Author: Rizal Muttaqin AuthorDate: Sat Dec 25 21:07:14 2021 +0700 Commit: Rizal Muttaqin CommitDate: Sat Dec 25 21:55:57 2021 +0100 Colibre: update Save related icons Change-Id: I01542908edf1d855fe723e0a7818cd05297f49aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127457 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin diff --git a/icon-themes/colibre/cmd/32/ar/recsave.png b/icon-themes/colibre/cmd/32/ar/recsave.png index 7389970a1ff3..ecb925d2d1d3 100644 Binary files a/icon-themes/colibre/cmd/32/ar/recsave.png and b/icon-themes/colibre/cmd/32/ar/recsave.png differ diff --git
[Libreoffice-commits] core.git: icon-themes/colibre icon-themes/colibre_svg
icon-themes/colibre/dbaccess/res/lc039.png |binary icon-themes/colibre/dbaccess/res/sc039.png |binary icon-themes/colibre/sd/res/pagobjex.png|binary icon-themes/colibre/sw/res/sc20248.png |binary icon-themes/colibre_svg/dbaccess/res/lc039.svg |2 +- icon-themes/colibre_svg/dbaccess/res/sc039.svg |3 ++- icon-themes/colibre_svg/sd/res/pagobjex.svg|2 +- icon-themes/colibre_svg/sw/res/sc20248.svg |3 ++- 8 files changed, 6 insertions(+), 4 deletions(-) New commits: commit 5e528165e2e6026d2d1ba3386f2b45544c0c6ab1 Author: Rizal Muttaqin AuthorDate: Sat Dec 25 22:14:08 2021 +0700 Commit: Rizal Muttaqin CommitDate: Sat Dec 25 21:55:37 2021 +0100 Colibre: update Save related icons part II Change-Id: Ic2bbd21ae12d8465cc8ba1f6429e0c516f6dbc59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127458 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin diff --git a/icon-themes/colibre/dbaccess/res/lc039.png b/icon-themes/colibre/dbaccess/res/lc039.png index d117989919f5..b9bab570f49c 100644 Binary files a/icon-themes/colibre/dbaccess/res/lc039.png and b/icon-themes/colibre/dbaccess/res/lc039.png differ diff --git a/icon-themes/colibre/dbaccess/res/sc039.png b/icon-themes/colibre/dbaccess/res/sc039.png index 4b1624a98118..36543dd673bd 100644 Binary files a/icon-themes/colibre/dbaccess/res/sc039.png and b/icon-themes/colibre/dbaccess/res/sc039.png differ diff --git a/icon-themes/colibre/sd/res/pagobjex.png b/icon-themes/colibre/sd/res/pagobjex.png index 96e31e3b0a4b..84f89c318bb8 100644 Binary files a/icon-themes/colibre/sd/res/pagobjex.png and b/icon-themes/colibre/sd/res/pagobjex.png differ diff --git a/icon-themes/colibre/sw/res/sc20248.png b/icon-themes/colibre/sw/res/sc20248.png index 0cfd3323ec37..4da40ea96cef 100644 Binary files a/icon-themes/colibre/sw/res/sc20248.png and b/icon-themes/colibre/sw/res/sc20248.png differ diff --git a/icon-themes/colibre_svg/dbaccess/res/lc039.svg b/icon-themes/colibre_svg/dbaccess/res/lc039.svg index 9867e7ef3cf9..51bebd1ac2e6 100644 --- a/icon-themes/colibre_svg/dbaccess/res/lc039.svg +++ b/icon-themes/colibre_svg/dbaccess/res/lc039.svg @@ -1 +1 @@ -http://www.w3.org/2000/svg;> \ No newline at end of file +http://www.w3.org/2000/svg;> \ No newline at end of file diff --git a/icon-themes/colibre_svg/dbaccess/res/sc039.svg b/icon-themes/colibre_svg/dbaccess/res/sc039.svg index d09059c87ba5..14df9c01968f 100644 --- a/icon-themes/colibre_svg/dbaccess/res/sc039.svg +++ b/icon-themes/colibre_svg/dbaccess/res/sc039.svg @@ -1,4 +1,5 @@ http://www.w3.org/2000/svg;> -/amp;amp;gt; \ No newline at end of file + +/amp;amp;amp;gt; \ No newline at end of file diff --git a/icon-themes/colibre_svg/sd/res/pagobjex.svg b/icon-themes/colibre_svg/sd/res/pagobjex.svg index ca8df96d5760..4301823d3d6b 100644 --- a/icon-themes/colibre_svg/sd/res/pagobjex.svg +++ b/icon-themes/colibre_svg/sd/res/pagobjex.svg @@ -1 +1 @@ -http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file +http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file diff --git a/icon-themes/colibre_svg/sw/res/sc20248.svg b/icon-themes/colibre_svg/sw/res/sc20248.svg index 7529ef40d616..a97720f96aea 100644 --- a/icon-themes/colibre_svg/sw/res/sc20248.svg +++ b/icon-themes/colibre_svg/sw/res/sc20248.svg @@ -1 +1,2 @@ -http://www.w3.org/2000/svg;>/amp;amp;gt; \ No newline at end of file +http://www.w3.org/2000/svg;> +/amp;amp;amp;gt; \ No newline at end of file
[Libreoffice-bugs] [Bug 146172] Window "Table of Contents, Index or Bibliography." out screen
https://bugs.documentfoundation.org/show_bug.cgi?id=146172 --- Comment #5 from li...@newwhitebear.net --- Hello I read in comment 4 which is a duplicate of the old report 137269. This would be resolved with the indications of comment 5 of the aforementioned report. I disagree in considering it resolved for these reasons. 1. in my ubuntu 20.04 the export command reports me a syntax error. Furthermore, under etc there is only the Libreoffice folder and not the one relating to the versions that are placed under opt. 2. I do not think it is a solution since if it changes soft it does not work anymore. 3. it is not a solution because soffice is unique for all versions and not specific. Among other things, it also manages the open office. So if I open LO 7.2 and Alpha0 7.3 together I have a single soffice. With 7.2 it gives an error, with 7.3 no. My graphics system is Gnome, GTK. So for me the error persists. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146417] New: Create a suggestion for document link if same word linked
https://bugs.documentfoundation.org/show_bug.cgi?id=146417 Bug ID: 146417 Summary: Create a suggestion for document link if same word linked Product: LibreOffice Version: 7.0.4.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: enhancement Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: a...@alum.mit.edu Description: Hi, this is a suggestion. I am writing a book, it already has almost 1600 pages in Writer, and often use the same exact Document hyperlink (a section in my book) when I highlight a given word. That word always links only to that location. The suggestion is to have the software recall my last link for that word or the most frequent link and prefill it so I don't have to scroll among my 200 book bookmarks to select it again. This would make hyperlinks to book sections easier. Since 99% of the time we link to the same place for an identical word, makes sense to suggest the last link or most common or whatever is easier to write a code for. Actual Results: suggestion Expected Results: see above Reproducible: Always User Profile Reset: No Additional Info: see above -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146414] cant make a database
https://bugs.documentfoundation.org/show_bug.cgi?id=146414 --- Comment #2 from Leslie --- Some LibreOffice functions require the Java runtime. Look here for help on it. https://wiki.documentfoundation.org/Faq/General/InstallJava -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141732] Each module should default to its own PDF import filter
https://bugs.documentfoundation.org/show_bug.cgi?id=141732 Eyal Rozenberg changed: What|Removed |Added Severity|enhancement |normal --- Comment #8 from Eyal Rozenberg --- (In reply to V Stuart Foote from comment #7) Quoting from the dupe bug: > Many users can not figure this out. I'd say _most_ users who might want to import PDFs don't figure this out. They probably check by opening their PDF in Writer, seeing that it's Draw that gets opened, and give up. > They resort to various less-then-ideal workarounds such as using online > converters and using MS Word to convert pdf to odt etc. See > https://ask.libreoffice.org/t/trying-to-convert-pdf-to-odt/45070/7 Indeed! > Please improve your UI. At the very minimum a PDF opened via the Writer > should > open in Writer. This is my original ask here. If that's difficult for the reasons V Stuart Foote gave, another alternative would be an "import filter" which makes the user select the module using a dialog, i.e. "Open this file in..." dialog; or perhaps an extra option in the Open File dialog, made visible only for a generic PDF import filter. Also, marking this as a (usability) bug rather than a mere enhancement. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145921] Crash in: SfxItemSet::Get(unsigned short, bool) - EDITING
https://bugs.documentfoundation.org/show_bug.cgi?id=145921 --- Comment #10 from to.give@outlook.com --- Ok. A thought: If the bug is useless if it is not from the most recent version, perhaps the "LibreOffice has crashed" dialogue text needs improvement. Specifically, to explicitly state that you need to check the version of LibreOffice installed against the current version of LibreOffice before submitting a bug report. If you guys are interested, I would be willing to contribute to the rewording, as time permits. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146416] New: save copy dialog / export to pdf dialog: file picker cuts parts of the filename
https://bugs.documentfoundation.org/show_bug.cgi?id=146416 Bug ID: 146416 Summary: save copy dialog / export to pdf dialog: file picker cuts parts of the filename Product: LibreOffice Version: 6.4.7.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: dma...@mailbox.org Description: When saving the document as copy or exporting it to pdf parts of the filename are missing in the file picker. Steps to Reproduce: 1. Create a document and save it as "Test 01.01.2021".odt 2. settings: extra-options-general use LO dialogs for open/save 2. Close Writer and reopen the document "Test 01.01.2021.odt". 3. a. Save the document as a copy. or 3. b. Export it - directly - to pdf. Actual Results: 3. a. with automatic file-extension flag: filename: "Test 01.01" without automatic file-extension flag: filename "Test 01.01.2021" 3. b. with automatic file-extension flag: filename "Test 01.01" without automatic file-extension flag: filename "Test 01.01.pdf" Expected Results: The file picker must not cut parts of the (base) filename and shall use the full filename as default suggestion: "Test 01.01.2021" and save/export it as "Test 01.01.2021.odt" or "Test 01.01.2021.pdf". Reproducible: Always User Profile Reset: No Additional Info: When using the system file picker the results are: 3. a. with automatic file-extension flag: filename: "Test 01.odt" without automatic file-extension flag: filename "Test 01.01.odt" 3. b. with automatic file-extension flag: filename "Test 01.pdf" without automatic file-extension flag: filename "Test 01.01.pdf" -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146415] New: Allow Basic + "Extended" Dictionaries
https://bugs.documentfoundation.org/show_bug.cgi?id=146415 Bug ID: 146415 Summary: Allow Basic + "Extended" Dictionaries Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sad_bu...@hotmail.com Enhancement Request - Multiple Dictionaries As an author, I would like to be able to use Writer to produce works of fiction. This typically involves the inclusion of names (individuals, places) technologies or artefacts (genres include science fiction and fantasy) that are fanciful and/or imaginary. However, when working with longer pieces - chapters spanning tens of pages - it can be frustrating to try and maintain spelling for these synthetic names across multiple documents. A perfect solution for this would be a feature in which Writer could be configured to allow a third type of dictionary (after "default" and "user"), along the lines of "project". So if I wanted to write a book, "The Adventures of Bod", then all the unique names and places created for that book could be placed in a custom dictionary called "Bod". This feature would require a slight modification to the "Spelling" window, in that the current version has a single "Add to Dictionary" button and will add the word to the *user* dictionary. This would have to be amended to detect if a "Project" dictionary had been associated with the file; and if this were the case, there would need to be two options on the Spelling window: "Add to User Dictionary" and "Add to Project Dictionary". Implemented, this solution would permit a user to curate individual custom dictionaries for discrete projects. This might be particularly relevant given close similarities of some names. Consider:- Clare Claire Antony Anthony A writer may wish to use different (but similar) versions of names, localised to different works of art. However, if that author had added "Clare" to a dictionary for one book, and then added a new character, "Claire" in a different piece of writing, a mis-spelling to "Clare" in the second work would not flag as an error if the author has to rely on a single User dictionary. I do appreciate that this is a 99th percentile requirement, but I can also see all sorts of different applications where this sort of capability would be very useful. Thanks for your consideration. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146414] cant make a database
https://bugs.documentfoundation.org/show_bug.cgi?id=146414 --- Comment #1 from Allison --- Created attachment 177137 --> https://bugs.documentfoundation.org/attachment.cgi?id=177137=edit bug screen shot -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146414] New: cant make a database
https://bugs.documentfoundation.org/show_bug.cgi?id=146414 Bug ID: 146414 Summary: cant make a database Product: LibreOffice Version: 7.4.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: alli...@sableranch.net Description: i tried to make a database and followed the instructions online and i get the error that there is ...No Java installation could be found. Please check your installation. i don't even know what that means i just downloaded libre office this month so it's new and should not be an issue. i can't even make a table let alone FILEOPEN Steps to Reproduce: 1.click open new database 2.create new database, next, 3.yes register, open for editing, click tables Actual Results: get the error No Java installation could be found. Please check your installation. Expected Results: to see a way to add a table and use the database features Reproducible: Always User Profile Reset: No Additional Info: i don't know what a user profile is i just got this software, i don't know want a open gl thing is if that was supposed to be done it should have done it on installation -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146171] Tracked changes with no date (0000-00-00) in .doc(x) documents are no longer tracked when converted to ODF format.
https://bugs.documentfoundation.org/show_bug.cgi?id=146171
kevbu...@gmail.com changed:
What|Removed |Added
Ever confirmed|1 |0
Status|NEEDINFO|UNCONFIRMED
--- Comment #2 from kevbu...@gmail.com ---
For v. 7.2.4.1, the problem is still present. Specifically, when a DOCX file
is imported with :00:00 in the date fields ("null date") of tracked
changes, LibreOffice displays them with that date and saves them when exported
to an ODF file. However, when the ODF file is then opened by LibreOffice, the
null date seems to be ignored: the changes are no longer marked as tracked, and
the date field is not retained when the file is saved (again to ODF).
HOWEVER, I did see the report in the release notes: "In the Security Options
dialog, choosing "Remove personal information on saving" now removes names and
dates from comments and tracked changes. core commit 12da70. (László Németh,
NISZ)". So upon importing the DOCX file with the null dates for tracked
changes, I set the security option to "Remove personal information on saving",
and upon saving to ODF format, the date was changed to 1970:01:01 and the
changes were then successfully recognized as tracked with that date upon
opening the ODF file.
This is a step forward, but users cannot be expected to know to change this
setting after importing DOCX files with null dates for tracked changes. So
LibreOffice needs to *automatically* insert 1970:01:01 into the date fields of
tracked changes when importing such DOCX files.
Thank you for your help.
(PS. I have donated to LibreOffice)
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-commits] core.git: 2 commits - framework/inc framework/source
framework/inc/uielement/menubarmanager.hxx |9 +++---
framework/source/services/ContextChangeEventMultiplexer.cxx | 16 ++--
framework/source/uielement/menubarmanager.cxx | 15 +--
3 files changed, 19 insertions(+), 21 deletions(-)
New commits:
commit d4257daba1155ebccbfebea99bad0e4152ca9b08
Author: Noel Grandin
AuthorDate: Fri Dec 24 20:58:28 2021 +0200
Commit: Noel Grandin
CommitDate: Sat Dec 25 19:34:05 2021 +0100
use comphelper::WeakComponentImplHelper in MenuBarManager
Change-Id: I687f71c5af810618b3ab27b004bf765b53d7b8e6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127466
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/framework/inc/uielement/menubarmanager.hxx
b/framework/inc/uielement/menubarmanager.hxx
index a77552a67213..079d127d4d83 100644
--- a/framework/inc/uielement/menubarmanager.hxx
+++ b/framework/inc/uielement/menubarmanager.hxx
@@ -41,8 +41,8 @@
#include
#include
#include
-#include
-#include
+#include
+#include
#include
namespace framework
@@ -56,8 +56,7 @@ struct PopupControllerEntry
typedef std::unordered_map< OUString, PopupControllerEntry >
PopupControllerCache;
class MenuBarManager final :
-protected cppu::BaseMutex,
-public cppu::WeakComponentImplHelper<
+public comphelper::WeakComponentImplHelper<
css::frame::XStatusListener,
css::frame::XFrameActionListener,
css::ui::XUIConfigurationListener,
@@ -121,7 +120,7 @@ class MenuBarManager final :
DECL_LINK( Deactivate, Menu *, bool );
DECL_LINK( AsyncSettingsHdl, Timer *, void );
-void SAL_CALL disposing() override;
+void disposing(std::unique_lock&) override;
void RemoveListener();
void RequestImages();
void RetrieveImageManagers();
diff --git a/framework/source/uielement/menubarmanager.cxx
b/framework/source/uielement/menubarmanager.cxx
index 08998a4b8fe8..7b856a01d43d 100644
--- a/framework/source/uielement/menubarmanager.cxx
+++ b/framework/source/uielement/menubarmanager.cxx
@@ -87,8 +87,7 @@ MenuBarManager::MenuBarManager(
const Reference< XDispatchProvider >& rDispatchProvider,
const OUString& rModuleIdentifier,
Menu* pMenu, bool bDelete, bool bHasMenuBar ):
-WeakComponentImplHelper( m_aMutex )
-, m_bRetrieveImages( false )
+ m_bRetrieveImages( false )
, m_bAcceleratorCfg( false )
, m_bHasMenuBar( bHasMenuBar )
, m_xContext(rxContext)
@@ -104,7 +103,7 @@ Any SAL_CALL MenuBarManager::getMenuHandle( const Sequence<
sal_Int8 >& /*Proces
{
SolarMutexGuard aSolarGuard;
-if ( rBHelper.bDisposed || rBHelper.bInDispose )
+if ( m_bDisposed )
throw css::lang::DisposedException();
Any a;
@@ -141,7 +140,7 @@ void MenuBarManager::Destroy()
{
SolarMutexGuard aGuard;
-if ( rBHelper.bDisposed )
+if ( m_bDisposed )
return;
// stop asynchronous settings timer and
@@ -159,7 +158,7 @@ void MenuBarManager::Destroy()
}
// XComponent
-void SAL_CALL MenuBarManager::disposing()
+void MenuBarManager::disposing(std::unique_lock& )
{
Reference< XComponent > xThis( this );
@@ -202,7 +201,7 @@ void SAL_CALL MenuBarManager::elementInserted( const
css::ui::ConfigurationEvent
SolarMutexGuard g;
/* SAFE AREA
---
*/
-if ( rBHelper.bDisposed || rBHelper.bInDispose )
+if ( m_bDisposed )
return;
sal_Int16 nImageType = sal_Int16();
@@ -225,7 +224,7 @@ void SAL_CALL MenuBarManager::frameAction( const
FrameActionEvent& Action )
{
SolarMutexGuard g;
-if ( rBHelper.bDisposed || rBHelper.bInDispose )
+if ( m_bDisposed )
throw css::lang::DisposedException();
if ( Action.Action != FrameAction_CONTEXT_CHANGED )
@@ -253,7 +252,7 @@ void SAL_CALL MenuBarManager::statusChanged( const
FeatureStateEvent& Event )
SolarMutexGuard aSolarGuard;
{
-if ( rBHelper.bDisposed || rBHelper.bInDispose )
+if ( m_bDisposed )
return;
// We have to check all menu entries as there can be identical entries
in a popup menu.
commit 98dbe250d7d5e3ebe626e8c8650e7fdccd399869
Author: Noel Grandin
AuthorDate: Fri Dec 24 21:01:56 2021 +0200
Commit: Noel Grandin
CommitDate: Sat Dec 25 19:33:53 2021 +0100
use comphelper::WeakComponentImplHelper in ContextChangeEventMultiplexer
Change-Id: I6f8c2be817695e44b25f209a5a56e021cd3e94d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127487
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/framework/source/services/ContextChangeEventMultiplexer.cxx
b/framework/source/services/ContextChangeEventMultiplexer.cxx
index 0dea0823c52b..76424b3aea03 100644
--- a/framework/source/services/ContextChangeEventMultiplexer.cxx
+++
[Libreoffice-bugs] [Bug 146377] Error doesn't propagate as first parameter in IF when "IfFalse" contains ISERROR or IFERROR
https://bugs.documentfoundation.org/show_bug.cgi?id=146377 Eike Rathke changed: What|Removed |Added Version|7.2.4.1 release |Inherited From OOo CC||er...@redhat.com --- Comment #4 from Eike Rathke --- Quite.. While the NA() propagates the error, as a condition it never evaluates to TRUE (that's probably what you see as "continues execution with a 0 value"), so the IF()'s else-path is taken that correctly evaluates ISERROR(NA()) to TRUE. The ISERROR() function (like other IS...() error evaluating functions) clears the current nGlobalError because it must not be propagated but the result of the function be pushed instead. I don't see this (error leading to false-path) as a wrong behaviour, though one might argue that already the IF(NA();...) should bail out and execute not even the false-path. Which btw matters only if it contains an error evaluating function. Gnumeric seems to agree and returns #N/A. What does Excel do for this specific case? (In reply to Paul den Hollander from comment #2) > An example: > =AND(NA();1) > =AND(NA();IFERROR(NA();1)) > Result of first formula is #N/A, result of second is Err:504. > > Basically IFERROR can affect the handling of errors that do not originate in > it's parameters. This also seems to happen with the IS* functions, like > ISTEXT, ISNA, etc. E.g.: =AND(NA();IF(ISNUMBER(1);1)) Results in Err:504 Of course the presence of functions that may evaluate error conditions affects until what point an expression is interpreted, that's expected. However, the AND() function (and OR() as well) lacks handling/propagation of error values. It discards unexpected arguments, including error values, and pushes its own Err:504 value. That doesn't happen with =AND(NA();1) because that already doesn't even call AND() as the NA() error would persist. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: i18npool/CustomTarget_localedata.mk
i18npool/CustomTarget_localedata.mk | 27 +++
1 file changed, 11 insertions(+), 16 deletions(-)
New commits:
commit 752052cb1ff82949183cea59ca18683266c7b4ff
Author: Jan-Marek Glogowski
AuthorDate: Wed Dec 22 15:59:49 2021 +0100
Commit: Jan-Marek Glogowski
CommitDate: Sat Dec 25 19:17:48 2021 +0100
Convert i18npool_LD_RULE template to pattern rule
No need for various, evaled custom rules. A normal pattern rule is
sufficent for this task.
Change-Id: I4f7ad0cafb7fe78fc161eab54bb3170003c83ade
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127325
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
diff --git a/i18npool/CustomTarget_localedata.mk
b/i18npool/CustomTarget_localedata.mk
index e4b1d1fb0339..c9fd9c213a95 100644
--- a/i18npool/CustomTarget_localedata.mk
+++ b/i18npool/CustomTarget_localedata.mk
@@ -15,24 +15,19 @@ $(eval $(call
gb_CustomTarget_register_targets,i18npool/localedata,\
$(foreach name,$(i18npool_LD_NAMES),localedata_$(name).cxx) \
))
-define i18npool_LD_RULE
-$(call gb_CustomTarget_get_workdir,i18npool/localedata)/localedata_$(1).cxx : \
- $(SRCDIR)/i18npool/source/localedata/data/$(1).xml \
+$(call gb_CustomTarget_get_workdir,i18npool/localedata)/localedata_%.cxx : \
+ $(SRCDIR)/i18npool/source/localedata/data/%.xml \
$(call gb_Executable_get_runtime_dependencies,saxparser)
- $$(call gb_Output_announce,$$(subst $(WORKDIR)/,,$$@),$(true),SAX,1)
- $$(call gb_Trace_StartRange,$$(subst $(WORKDIR)/,,$$@),SAX)
- TEMPSAX=$$(shell $$(gb_MKTEMP)) && TEMPSED=$$(shell $$(gb_MKTEMP)) && \
- $$(call gb_Helper_abbreviate_dirs, \
- $$(call gb_Helper_print_on_error, \
- $$(call gb_Helper_execute,saxparser) $(1) $$<
{TEMPSAX} \
+ $(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),$(true),SAX,1)
+ $(call gb_Trace_StartRange,$(subst $(WORKDIR)/,,$@),SAX)
+ TEMPSAX=$(shell $(gb_MKTEMP)) && TEMPSED=$(shell $(gb_MKTEMP)) && \
+ $(call gb_Helper_abbreviate_dirs, \
+ $(call gb_Helper_print_on_error, \
+ $(call gb_Helper_execute,saxparser) $* $< $${TEMPSAX} \
-env:LO_LIB_DIR=$(call
gb_Helper_make_url,$(INSTROOT_FOR_BUILD)/$(LIBO_LIB_FOLDER)) \
-env:URE_MORE_SERVICES=$(call
gb_Helper_make_url,$(call gb_Rdb_get_target_for_build,saxparser))) && \
- sed 's/\(^.*get[^;]*\)/SAL_DLLPUBLIC_EXPORT \1/'
{TEMPSAX} > {TEMPSED} && \
- rm {TEMPSAX} && $(call
gb_Helper_replace_if_different_and_touch,{TEMPSED},$$@))
- $$(call gb_Trace_EndRange,$$(subst $(WORKDIR)/,,$$@),SAX)
-
-endef
-
-$(foreach name,$(i18npool_LD_NAMES),$(eval $(call i18npool_LD_RULE,$(name
+ sed 's/\(^.*get[^;]*$$\)/SAL_DLLPUBLIC_EXPORT \1/' $${TEMPSAX}
> $${TEMPSED} && \
+ rm $${TEMPSAX} && $(call
gb_Helper_replace_if_different_and_touch,$${TEMPSED},$@))
+ $(call gb_Trace_EndRange,$(subst $(WORKDIR)/,,$@),SAX)
# vim: set noet sw=4 ts=4:
[Libreoffice-bugs] [Bug 146378] Solver dialog is disappeared after switching to Writer window and back to Calc window
https://bugs.documentfoundation.org/show_bug.cgi?id=146378 raal changed: What|Removed |Added Status|UNCONFIRMED |NEW OS|Windows (All) |All CC||r...@post.cz Ever confirmed|0 |1 --- Comment #4 from raal --- Confirm with Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: c13db6e792cc3474585f23866f195651f21f CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded Jumbo -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146396] "Find" not finding words that are present in the Draw document
https://bugs.documentfoundation.org/show_bug.cgi?id=146396 raal changed: What|Removed |Added Ever confirmed|0 |1 CC||r...@post.cz Status|UNCONFIRMED |NEEDINFO --- Comment #1 from raal --- Hello, Thank you for filing the bug. Please send us a sample document, as this makes it easier for us to verify the bug. I have set the bug's status to 'NEEDINFO', so please do change it back to 'UNCONFIRMED' once you have attached a document. (Please note that the attachment will be public, remove any sensitive information before attaching it.) How can I eliminate confidential data from a sample document? https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F Thank you No repro Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: c13db6e792cc3474585f23866f195651f21f CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded Jumbo -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 51665] Support diagonal borders in TABLEs
https://bugs.documentfoundation.org/show_bug.cgi?id=51665 raal changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||6407 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146407] Writer - Dysfunction of Diagonal & Criss-Cross Border.
https://bugs.documentfoundation.org/show_bug.cgi?id=146407 raal changed: What|Removed |Added OS|Windows (All) |All Status|UNCONFIRMED |NEW See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=51 ||665 Ever confirmed|0 |1 CC||m...@bayramcicek.com.tr, ||r...@post.cz --- Comment #1 from raal --- I can confirm with Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: c13db6e792cc3474585f23866f195651f21f CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded Jumbo Looks like unfinished feature: https://gerrit.libreoffice.org/c/core/+/120262 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146162] JUMBO SHEETS: cannot hide all columns
https://bugs.documentfoundation.org/show_bug.cgi?id=146162 raal changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW CC||r...@post.cz --- Comment #1 from raal --- Repro Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: c13db6e792cc3474585f23866f195651f21f CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded Jumbo -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: tools/source
tools/source/fsys/urlobj.cxx | 20 +---
1 file changed, 9 insertions(+), 11 deletions(-)
New commits:
commit be5f70e2b8498345f2301598cba325d5524513f2
Author: Mike Kaganski
AuthorDate: Sat Dec 25 12:51:53 2021 +0300
Commit: Mike Kaganski
CommitDate: Sat Dec 25 18:44:09 2021 +0100
Simplify INetURLObject::parseHostOrNetBiosName a bit more
Change-Id: Ie22e7a142aabd2c0f12c34945ad0858f5bd868a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127451
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/tools/source/fsys/urlobj.cxx b/tools/source/fsys/urlobj.cxx
index 67cb1f1cd024..1d08a5590eaa 100644
--- a/tools/source/fsys/urlobj.cxx
+++ b/tools/source/fsys/urlobj.cxx
@@ -2843,9 +2843,16 @@ bool INetURLObject::parseHostOrNetBiosName(
while (pBegin < pEnd)
{
EscapeType eEscapeType;
-sal_uInt32 nUTF32 = getUTF32(pBegin, pEnd, eMechanism, eCharset,
eEscapeType);
-switch (nUTF32)
+switch (sal_uInt32 nUTF32 = getUTF32(pBegin, pEnd, eMechanism,
eCharset, eEscapeType))
{
+default:
+if (INetMIME::isVisible(nUTF32))
+{
+if (pCanonic)
+appendUCS4(*pCanonic, nUTF32, eEscapeType, PART_URIC,
eCharset, true);
+break;
+}
+[[fallthrough]];
case '"':
case '*':
case '+':
@@ -2865,16 +2872,7 @@ bool INetURLObject::parseHostOrNetBiosName(
if (pCanonic)
pCanonic->setLength(nOriginalCanonicLength);
return false;
-default:
-if (!INetMIME::isVisible(nUTF32))
-{
-if (pCanonic)
-pCanonic->setLength(nOriginalCanonicLength);
-return false;
-}
}
-if (pCanonic)
-appendUCS4(*pCanonic, nUTF32, eEscapeType, PART_URIC, eCharset,
true);
}
return true;
}
[Libreoffice-bugs] [Bug 146413] Crash if I open a spreadsheet saved previously with same program
https://bugs.documentfoundation.org/show_bug.cgi?id=146413 raal changed: What|Removed |Added CC||r...@post.cz --- Comment #2 from raal --- No crash with Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: c13db6e792cc3474585f23866f195651f21f CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded and Version: 7.1.7.2 / LibreOffice Community Build ID: 10(Build:2) CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: cs-CZ Ubuntu package version: 1:7.1.7-0ubuntu0.21.04.1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 41316] Page styles should support hierarchical parent-child relationships (like paragraph or character styles)
https://bugs.documentfoundation.org/show_bug.cgi?id=41316 Evil Overlord changed: What|Removed |Added CC||bma.qu...@gmail.com --- Comment #23 from Evil Overlord --- I'd love to see this. For example, I publish many books in different sizes. I have 5 basic page styles in each book. Changing the trim size of the book requires changing each page style, one by one. It would save me time, effort, and - most important - chance of error if I could simply change the page size one time, and have that flow to all subsidiary page styles. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 45338] EDITING ReportBuilder: 'Details - General Keep Together' without visible effect
https://bugs.documentfoundation.org/show_bug.cgi?id=45338
--- Comment #26 from Robert Großkopf ---
Have had a new look on this bug.
Detail-section won't be kept together, because
1) there will be created only one table "Detail0" when starting a report
without grouping
2) the section will always been set tho allow table to split across pages.
The first part will be changed by grouping the report ("Detail0", "Detail1" …
will be created)
Now I'm looking in the code for getting this behavior also for non-grouped
reports …
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-commits] core.git: framework/source
framework/source/uiconfiguration/moduleuicfgsupplier.cxx | 22 ++-
1 file changed, 9 insertions(+), 13 deletions(-)
New commits:
commit a7a1d8647a8e03675746d4cbbcf707422f4db888
Author: Noel Grandin
AuthorDate: Fri Dec 24 20:52:39 2021 +0200
Commit: Noel Grandin
CommitDate: Sat Dec 25 18:14:05 2021 +0100
use comphelper::WeakComponentImplHelper in
ModuleUIConfigurationManagerSupplier
Change-Id: I22164080dd87ab3c3a93b50d06cba8574e00c189
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127464
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/framework/source/uiconfiguration/moduleuicfgsupplier.cxx
b/framework/source/uiconfiguration/moduleuicfgsupplier.cxx
index f28c2afedddf..cdbd647c3108 100644
--- a/framework/source/uiconfiguration/moduleuicfgsupplier.cxx
+++ b/framework/source/uiconfiguration/moduleuicfgsupplier.cxx
@@ -31,8 +31,7 @@
#include
#include
-#include
-#include
+#include
#include
#include
@@ -49,13 +48,12 @@ using namespace framework;
namespace {
-typedef cppu::WeakComponentImplHelper<
+typedef comphelper::WeakComponentImplHelper<
css::lang::XServiceInfo,
css::ui::XModuleUIConfigurationManagerSupplier >
ModuleUIConfigurationManagerSupplier_BASE;
-class ModuleUIConfigurationManagerSupplier : private cppu::BaseMutex,
- public
ModuleUIConfigurationManagerSupplier_BASE
+class ModuleUIConfigurationManagerSupplier : public
ModuleUIConfigurationManagerSupplier_BASE
{
public:
explicit ModuleUIConfigurationManagerSupplier( const css::uno::Reference<
css::uno::XComponentContext >& rxContext );
@@ -80,7 +78,7 @@ public:
virtual css::uno::Reference< css::ui::XUIConfigurationManager > SAL_CALL
getUIConfigurationManager( const OUString& ModuleIdentifier ) override;
private:
-virtual void SAL_CALL disposing() final override;
+virtual void disposing(std::unique_lock&) final override;
typedef std::unordered_map< OUString, css::uno::Reference<
css::ui::XModuleUIConfigurationManager2 > > ModuleToModuleCfgMgr;
@@ -92,8 +90,7 @@ private:
};
ModuleUIConfigurationManagerSupplier::ModuleUIConfigurationManagerSupplier(
const Reference< XComponentContext >& xContext ) :
-ModuleUIConfigurationManagerSupplier_BASE(m_aMutex)
-, m_xModuleMgr( ModuleManager::create( xContext ) )
+ m_xModuleMgr( ModuleManager::create( xContext ) )
, m_xContext( xContext )
{
try
@@ -111,13 +108,12 @@
ModuleUIConfigurationManagerSupplier::ModuleUIConfigurationManagerSupplier( cons
ModuleUIConfigurationManagerSupplier::~ModuleUIConfigurationManagerSupplier()
{
-disposing();
+std::unique_lock g(m_aMutex);
+disposing(g);
}
-void SAL_CALL ModuleUIConfigurationManagerSupplier::disposing()
+void
ModuleUIConfigurationManagerSupplier::disposing(std::unique_lock&)
{
-osl::MutexGuard g(rBHelper.rMutex);
-
// dispose all our module user interface configuration managers
for (auto const& elem : m_aModuleToModuleUICfgMgrMap)
{
@@ -132,7 +128,7 @@ void SAL_CALL
ModuleUIConfigurationManagerSupplier::disposing()
// XModuleUIConfigurationManagerSupplier
Reference< XUIConfigurationManager > SAL_CALL
ModuleUIConfigurationManagerSupplier::getUIConfigurationManager( const
OUString& sModuleIdentifier )
{
-osl::MutexGuard g(rBHelper.rMutex);
+std::unique_lock g(m_aMutex);
/* SAFE AREA
---
*/
ModuleToModuleCfgMgr::iterator pIter = m_aModuleToModuleUICfgMgrMap.find(
sModuleIdentifier );
[Libreoffice-bugs] [Bug 141732] Each module should default to its own PDF import filter
https://bugs.documentfoundation.org/show_bug.cgi?id=141732 V Stuart Foote changed: What|Removed |Added CC||hexagon-recurs...@posteo.ne ||t --- Comment #7 from V Stuart Foote --- *** Bug 146412 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146412] [Writer][UX] the ability to open PDF suffers from poor discoverability
https://bugs.documentfoundation.org/show_bug.cgi?id=146412 V Stuart Foote changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||vstuart.fo...@utsa.edu Resolution|--- |DUPLICATE --- Comment #1 from V Stuart Foote --- *** This bug has been marked as a duplicate of bug 141732 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146413] Crash if I open a spreadsheet saved previously with same program
https://bugs.documentfoundation.org/show_bug.cgi?id=146413 --- Comment #1 from nabe...@gmail.com --- Created attachment 177136 --> https://bugs.documentfoundation.org/attachment.cgi?id=177136=edit spreadsheet that crashes calc Thi sis the file that crashes Calc -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146413] New: Crash if I open a spreadsheet saved previously with same program
https://bugs.documentfoundation.org/show_bug.cgi?id=146413 Bug ID: 146413 Summary: Crash if I open a spreadsheet saved previously with same program Product: LibreOffice Version: 7.1.8.1 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: nabe...@gmail.com Description: Libreoffice Crashes when I open a spreadsheet saved previously with same program Steps to Reproduce: 1.open the spreadsheet file 2.try to scroll UP the second sheet "Problema 2" Actual Results: it crashes and close the program Calc Expected Results: Scroll up Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: SpreadsheetDocument [Information guessed from browser] OS: Linux (All) OS is 64bit: yes -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103238] [META] Customize dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103238 V Stuart Foote changed: What|Removed |Added Depends on||146409 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=146409 [Bug 146409] customize keyboard simpler -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146409] customize keyboard simpler
https://bugs.documentfoundation.org/show_bug.cgi?id=146409 V Stuart Foote changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||vstuart.fo...@utsa.edu Blocks||103238 Keywords||needsUXEval --- Comment #1 from V Stuart Foote --- Don't see much advantage to removing distinction between global vs module specific keyboard shortcut/accelerator assignments, for "scope" as controlled by the radio-button toggle: LibreOffice or . Shortcuts assigned in one of the module modes, override any shortcut set in global. And when not assigned to global shortcut applies (if it is functional in the module). And of course the Customize dialog controls settings for other UI elements, not just Keyboard shortcuts. So it needs some consistency (but I guess radiobuttons could become list box like the other tabs). But the UI layout might be improved, @Heiko any thoughts? As to the second item, that is bug 140070 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103238 [Bug 103238] [META] Customize dialog bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 146409] customize keyboard simpler
https://bugs.documentfoundation.org/show_bug.cgi?id=146409 V Stuart Foote changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||vstuart.fo...@utsa.edu Blocks||103238 Keywords||needsUXEval --- Comment #1 from V Stuart Foote --- Don't see much advantage to removing distinction between global vs module specific keyboard shortcut/accelerator assignments, for "scope" as controlled by the radio-button toggle: LibreOffice or . Shortcuts assigned in one of the module modes, override any shortcut set in global. And when not assigned to global shortcut applies (if it is functional in the module). And of course the Customize dialog controls settings for other UI elements, not just Keyboard shortcuts. So it needs some consistency (but I guess radiobuttons could become list box like the other tabs). But the UI layout might be improved, @Heiko any thoughts? As to the second item, that is bug 140070 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103238 [Bug 103238] [META] Customize dialog bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 61914] [META] Start Center bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=61914 Bug 61914 depends on bug 129130, which changed state. Bug 129130 Summary: Start center: Black border around previews of Base-files https://bugs.documentfoundation.org/show_bug.cgi?id=129130 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 129130] Start center: Black border around previews of Base-files
https://bugs.documentfoundation.org/show_bug.cgi?id=129130 Robert Großkopf changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #8 from Robert Großkopf --- Tested again with LO 7.1.5.2. Couldn't see any black border with OpenSUSE 15.3 64bit rpm Linux. Will set this one to WORKSFORME. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146169] LibreOffice Writer prints one copy when I requested 20
https://bugs.documentfoundation.org/show_bug.cgi?id=146169 --- Comment #2 from Timur --- Of problem persists after user reset /delete, please clarify if problem is only with duplex printing of multiple copies. Please attach screenshot of print settings. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146412] New: [Writer][UX] the ability to open PDF suffers from poor discoverability
https://bugs.documentfoundation.org/show_bug.cgi?id=146412 Bug ID: 146412 Summary: [Writer][UX] the ability to open PDF suffers from poor discoverability Product: LibreOffice Version: 7.1.8.1 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: hexagon-recurs...@posteo.net Description: I wanted to convert a pdf into odt. Apparently LibreOffice Writer can open and edit pdf documents as well as converting them to odt and many other formats. The enormous effort that must have went into implementing this feature is currently undermined by a simple user interface oversight - poor discoverability. When I open a pdf in LibreOffice Writer 7.1.8.1 via the File->Open menu, it opens in LibreOffice Draw instead. LibreOffice Draw can not convert a pdf into odt. The ability to open a pdf in Writer is hidden behind an unobvious action: you have to select "PDF - Portable Document Format (Writer)" in the file format dropdown in the Open dialogue. Many users can not figure this out. They resort to various less-then-ideal workarounds such as using online converters and using MS Word to convert pdf to odt etc. See https://ask.libreoffice.org/t/trying-to-convert-pdf-to-odt/45070/7 Please improve your UI. At the very minimum a PDF opened via the Writer should open in Writer. Version: 7.1.8.1 Build ID: 10(Build:1) CPU threads: 2; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: en-US (C.UTF-8); UI: en-US Calc: threaded Steps to Reproduce: 1. Start LibreOffice Writer 2. File->Open 3. Select a PDF 4. Double click it Actual Results: The PDF opens in LibreOffice Draw Expected Results: The PDF opens in LibreOffice Writer Reproducible: Always User Profile Reset: No Additional Info: LibreOffice Draw is also used instead of LibreOffice Writer when opening PDF files via the file manager even if I explicitly select LibreOffice Writer as the application to open the PDF -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146411] correct CONVERT_000 € currency conversion help
https://bugs.documentfoundation.org/show_bug.cgi?id=146411 V Stuart Foote changed: What|Removed |Added Component|Calc|Documentation Status|ASSIGNED|RESOLVED CC||olivier.hallot@libreoffice. ||org, vstuart.fo...@utsa.edu Summary|: Misunderstanding of |correct CONVERT_000 € |European Political Entities |currency conversion help Whiteboard||target:7.3.0.2 Resolution|--- |FIXED --- Comment #2 from V Stuart Foote --- https://gerrit.libreoffice.org/c/help/+/127099 https://gerrit.libreoffice.org/c/help/+/127059 The Wiki article still needs a tweak https://wiki.documentfoundation.org/Documentation/Calc_Functions/CONVERT_OOO -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: bin/oss-fuzz-build.sh configure.ac desktop/Module_desktop.mk distro-configs/LibreOfficeOssFuzz.conf Makefile.in smoketest/Module_smoketest.mk vcl/commonfuzzer.mk vcl/Ex
Makefile.in|2 --
bin/oss-fuzz-build.sh |9 +
configure.ac |4 ++--
desktop/Module_desktop.mk |2 ++
distro-configs/LibreOfficeOssFuzz.conf |2 ++
smoketest/Module_smoketest.mk |2 ++
vcl/Executable_docxfuzzer.mk |2 ++
vcl/Executable_fodtfuzzer.mk |2 ++
vcl/Executable_htmlfuzzer.mk |4 +++-
vcl/Module_vcl.mk |3 +--
vcl/commonfuzzer.mk|4 +++-
vcl/workben/docxfuzzer.cxx |5 -
vcl/workben/fodtfuzzer.cxx |5 -
vcl/workben/htmlfuzzer.cxx |2 --
14 files changed, 24 insertions(+), 24 deletions(-)
New commits:
commit 37106f20bd5cc016a473fbdb2e9e37da096cff5f
Author: Jan-Marek Glogowski
AuthorDate: Sun Dec 12 22:03:49 2021 +0100
Commit: Jan-Marek Glogowski
CommitDate: Sat Dec 25 17:05:08 2021 +0100
oss-fuzz: convert to static cross-build
This way we can get rid of the pre-generated locale data and the
special fuzzers target, which invokes a full gbuild make for
every prereqisite, always parsing the whole tree, taking ages.
This also reverts:
- commit d0780b21cfe235c4446adf649eb690f9c1771dd5 ("fix oss-fuzz
build") by adding epubgen and revenge dependencies.
- commit ff25d6a123beb42476bf42d189b3033a86835b2a ("ofz#41602 fix
more build failure"), which shouldn't happen anymore since
commit d47628f287f4377394c4ff488c433bfe254b6abe ("don't want to
link to system static libs for DISABLE_DYNLOADING")
Change-Id: I3aed9ec62da507254b42e4e7470bae1097b4bc8c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127031
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
diff --git a/Makefile.in b/Makefile.in
index 3ac9ce6d3c22..7c30271cffb9 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -504,8 +504,6 @@ $(BUILDDIR)/vs-code.code-workspace:
$(BUILDDIR)/vs-code.code-workspace.template
@test -e $@ || cp $< $@ && \
cmp -s $@ $< || echo "ATTN: $(@F) differs from $( templateservices.rdb
diff --git a/configure.ac b/configure.ac
index 1ba896d7defb..f85e0b1701f3 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3799,7 +3799,7 @@ if test -n "$WIN_MULTI_ARCH" -a -n "$WIN_OTHER_ARCH"; then
fi
-if test "$build_cpu" != "$host_cpu" -o \( "$DISABLE_DYNLOADING" = TRUE -a
"$enable_fuzzers" != yes \); then
+if test "$build_cpu" != "$host_cpu" -o "$DISABLE_DYNLOADING" = TRUE; then
# To allow building Windows multi-arch releases without cross-tooling
if test "$DISABLE_DYNLOADING" = TRUE -o \( -z "$WIN_MULTI_ARCH" -a -z
"$WIN_OTHER_ARCH" \); then
cross_compiling="yes"
@@ -9574,7 +9574,7 @@ else
LIBXML_LIBS="${WORKDIR}/UnpackedTarball/libxml2/win32/bin.msvc/libxml2.lib"
else
LIBXML_LIBS="-L${WORKDIR}/UnpackedTarball/libxml2/.libs -lxml2"
-if test "$DISABLE_DYNLOADING" = TRUE -a "$ENABLE_FUZZERS" != "TRUE";
then
+if test "$DISABLE_DYNLOADING" = TRUE; then
LIBXML_LIBS="$LIBXML_LIBS -lm"
fi
fi
diff --git a/desktop/Module_desktop.mk b/desktop/Module_desktop.mk
index a03a552e4271..ce8f254d7af1 100644
--- a/desktop/Module_desktop.mk
+++ b/desktop/Module_desktop.mk
@@ -100,9 +100,11 @@ $(eval $(call gb_Module_add_targets,desktop,\
else ifeq (,$(filter MACOSX ANDROID iOS HAIKU,$(OS)))
+ifeq (,$(filter FUZZERS,$(BUILD_TYPE)))
$(eval $(call gb_Module_add_targets,desktop,\
Executable_oosplash \
))
+endif
endif
diff --git a/distro-configs/LibreOfficeOssFuzz.conf
b/distro-configs/LibreOfficeOssFuzz.conf
index 434452a673f0..5f50f2774bc5 100644
--- a/distro-configs/LibreOfficeOssFuzz.conf
+++ b/distro-configs/LibreOfficeOssFuzz.conf
@@ -8,6 +8,7 @@
--disable-cups
--disable-dbus
--disable-dconf
+--disable-extensions
--disable-firebird-sdbc
--disable-gio
--disable-gtk3
@@ -29,5 +30,6 @@
--with-locales=en
--with-system-lockfile
--without-fonts
+--without-galleries
--without-java
--without-webdav
diff --git a/smoketest/Module_smoketest.mk b/smoketest/Module_smoketest.mk
index 217dbfa6543a..5d66a0daa1e4 100644
--- a/smoketest/Module_smoketest.mk
+++ b/smoketest/Module_smoketest.mk
@@ -12,10 +12,12 @@ $(eval $(call gb_Module_Module,smoketest))
ifeq ($(CROSS_COMPILING),)
+ifneq (,$(filter DESKTOP,$(BUILD_TYPE)))
$(eval $(call gb_Module_add_targets,smoketest,\
Library_smoketest \
Zip_smoketestdoc \
))
+endif
ifneq ($(ENABLE_JAVA),)
ifneq ($(filter EXTENSIONS,$(BUILD_TYPE)),)
diff --git a/vcl/Executable_docxfuzzer.mk b/vcl/Executable_docxfuzzer.mk
index fbacbe92fd98..57bc9020713b 100644
--- a/vcl/Executable_docxfuzzer.mk
+++ b/vcl/Executable_docxfuzzer.mk
@@ -19,6 +19,8 @@ $(eval $(call gb_Executable_use_api,docxfuzzer,\
$(eval $(call gb_Executable_use_externals,docxfuzzer,\
$(fuzzer_externals) \
+epubgen \
+revenge \
))
$(eval
[Libreoffice-commits] core.git: connectivity/source sc/source solenv/bin
connectivity/source/drivers/file/FDatabaseMetaData.cxx |2 ++
connectivity/source/manager/mdrivermanager.cxx | 15 ++-
sc/source/core/data/documen3.cxx |6 +-
solenv/bin/native-code.py |1 +
4 files changed, 14 insertions(+), 10 deletions(-)
New commits:
commit fa5db38ae5bbe9abfd41b6765074ca1200b8def2
Author: Jan-Marek Glogowski
AuthorDate: Fri Dec 24 02:37:33 2021 +0100
Commit: Jan-Marek Glogowski
CommitDate: Sat Dec 25 17:04:13 2021 +0100
oss-fuzz: fix some compiler warnings
Some unused functions and variables and many missing
HAVE_FEATURE_NSS warnings, because the native-code.py
stubs were missing the config_crypto.h header.
Change-Id: I88ff7d8f96e7382027a21f205db982fd797bd6af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127392
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
diff --git a/connectivity/source/drivers/file/FDatabaseMetaData.cxx
b/connectivity/source/drivers/file/FDatabaseMetaData.cxx
index f6480744e665..6d0a4f2fe0b1 100644
--- a/connectivity/source/drivers/file/FDatabaseMetaData.cxx
+++ b/connectivity/source/drivers/file/FDatabaseMetaData.cxx
@@ -73,6 +73,7 @@ Reference< XResultSet > SAL_CALL
ODatabaseMetaData::getColumns(
namespace
{
+#if !ENABLE_FUZZERS
sal_Int16 isCaseSensitiveParentFolder( const OUString& _rFolderOrDoc,
std::u16string_view _rDocName )
{
sal_Int16 nIsCS = 1;
@@ -151,6 +152,7 @@ namespace
return nIsCS;
}
+#endif
}
diff --git a/connectivity/source/manager/mdrivermanager.cxx
b/connectivity/source/manager/mdrivermanager.cxx
index 390b6da13e27..c605573b703e 100644
--- a/connectivity/source/manager/mdrivermanager.cxx
+++ b/connectivity/source/manager/mdrivermanager.cxx
@@ -102,8 +102,8 @@ Any SAL_CALL ODriverEnumeration::nextElement( )
return makeAny( *m_aPos++ );
}
-namespace {
-
+namespace
+{
/// an STL functor which ensures that a SdbcDriver described by a
DriverAccess is loaded
struct EnsureDriver
{
@@ -174,9 +174,8 @@ Any SAL_CALL ODriverEnumeration::nextElement( )
}
};
-}
-
-static sal_Int32 lcl_getDriverPrecedence( const
Reference& _rContext, Sequence< OUString >& _rPrecedence )
+#if !ENABLE_FUZZERS
+sal_Int32 lcl_getDriverPrecedence( const Reference&
_rContext, Sequence< OUString >& _rPrecedence )
{
_rPrecedence.realloc( 0 );
try
@@ -210,8 +209,7 @@ Any SAL_CALL ODriverEnumeration::nextElement( )
return _rPrecedence.getLength();
}
-
-namespace {
+#endif
/// an STL algorithm compatible predicate comparing two DriverAccess
instances by their implementation names
struct CompareDriverAccessByName
@@ -234,8 +232,7 @@ Any SAL_CALL ODriverEnumeration::nextElement( )
return lhs.sImplementationName == m_sImplName;
}
};
-
-}
+}
OSDBCDriverManager::OSDBCDriverManager( const Reference< XComponentContext >&
_rxContext )
:OSDBCDriverManager_Base(m_aMutex)
diff --git a/sc/source/core/data/documen3.cxx b/sc/source/core/data/documen3.cxx
index 163c374b6406..35f1f936392e 100644
--- a/sc/source/core/data/documen3.cxx
+++ b/sc/source/core/data/documen3.cxx
@@ -575,8 +575,11 @@ bool ScDocument::LinkExternalTab( SCTAB& rTab, const
OUString& aDocTab,
}
rTab = 0;
#if ENABLE_FUZZERS
+(void)aDocTab;
+(void)aFileName;
+(void)aTabName;
return false;
-#endif
+#else
OUString aFilterName; // Is filled by the Loader
OUString aOptions; // Filter options
sal_uInt32 nLinkCnt = pExtDocOptions ?
pExtDocOptions->GetDocSettings().mnLinkCnt : 0;
@@ -618,6 +621,7 @@ bool ScDocument::LinkExternalTab( SCTAB& rTab, const
OUString& aDocTab,
pBindings->Invalidate( SID_LINKS );
}
return true;
+#endif
}
ScExternalRefManager* ScDocument::GetExternalRefManager() const
diff --git a/solenv/bin/native-code.py b/solenv/bin/native-code.py
index 7abb6c97ac4d..88d53d320602 100755
--- a/solenv/bin/native-code.py
+++ b/solenv/bin/native-code.py
@@ -861,6 +861,7 @@ print ("""/*
* File generated by solenv/bin/native-code.py
*/
+#include
#include
#include
#include
[Libreoffice-commits] core.git: svtools/source
svtools/source/control/valueacc.cxx | 29 +
svtools/source/control/valueimp.hxx | 11 ---
2 files changed, 17 insertions(+), 23 deletions(-)
New commits:
commit 35267be7ce33c5203a76e8023382c287b2e1f180
Author: Noel Grandin
AuthorDate: Fri Dec 24 11:51:29 2021 +0200
Commit: Noel Grandin
CommitDate: Sat Dec 25 16:52:14 2021 +0100
use comphelper::WeakComponentImplHelper in ValueSetAcc
and remove unnecessary use of SolarMutex, the fields
are already protected by mutex and the locked region
doesn't call into vcl.
Change-Id: Ia010674b14fafe2bfac27956af71fb557a4df212
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127408
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/svtools/source/control/valueacc.cxx
b/svtools/source/control/valueacc.cxx
index d8f97826499f..23d3dcde9bc6 100644
--- a/svtools/source/control/valueacc.cxx
+++ b/svtools/source/control/valueacc.cxx
@@ -418,7 +418,6 @@ void ValueItemAcc::FireAccessibleEvent( short nEventId,
const uno::Any& rOldValu
}
ValueSetAcc::ValueSetAcc( ValueSet* pParent ) :
-ValueSetAccComponentBase (m_aMutex),
mpParent( pParent ),
mbIsFocused(false)
{
@@ -661,7 +660,7 @@ lang::Locale SAL_CALL ValueSetAcc::getLocale()
void SAL_CALL ValueSetAcc::addAccessibleEventListener( const uno::Reference<
accessibility::XAccessibleEventListener >& rxListener )
{
ThrowIfDisposed();
-::osl::MutexGuard aGuard (m_aMutex);
+std::unique_lock aGuard (m_aMutex);
if( !rxListener.is() )
return;
@@ -685,7 +684,7 @@ void SAL_CALL ValueSetAcc::addAccessibleEventListener(
const uno::Reference< acc
void SAL_CALL ValueSetAcc::removeAccessibleEventListener( const
uno::Reference< accessibility::XAccessibleEventListener >& rxListener )
{
ThrowIfDisposed();
-::osl::MutexGuard aGuard (m_aMutex);
+std::unique_lock aGuard (m_aMutex);
if( rxListener.is() )
{
@@ -911,21 +910,19 @@ sal_Int64 SAL_CALL ValueSetAcc::getSomething( const
uno::Sequence< sal_Int8 >& r
}
-void SAL_CALL ValueSetAcc::disposing()
+void ValueSetAcc::disposing(std::unique_lock& rGuard)
{
-::std::vector >
aListenerListCopy;
+// Make a copy of the list and clear the original.
+::std::vector >
aListenerListCopy = std::move(mxEventListeners);
-{
-// Make a copy of the list and clear the original.
-const SolarMutexGuard aSolarGuard;
-::osl::MutexGuard aGuard (m_aMutex);
-aListenerListCopy.swap(mxEventListeners);
-
-// Reset the pointer to the parent. It has to be the one who has
-// disposed us because he is dying.
-mpParent = nullptr;
-}
+// Reset the pointer to the parent. It has to be the one who has
+// disposed us because he is dying.
+mpParent = nullptr;
+
+if (aListenerListCopy.empty())
+return;
+rGuard.unlock();
// Inform all listeners that this objects is disposing.
lang::EventObject aEvent (static_cast(this));
for (auto const& listenerCopy : aListenerListCopy)
@@ -974,7 +971,7 @@ ValueSetItem* ValueSetAcc::getItem (sal_uInt16 nIndex) const
void ValueSetAcc::ThrowIfDisposed()
{
-if (rBHelper.bDisposed || rBHelper.bInDispose)
+if (m_bDisposed)
{
SAL_WARN("svx", "Calling disposed object. Throwing exception:");
throw lang::DisposedException (
diff --git a/svtools/source/control/valueimp.hxx
b/svtools/source/control/valueimp.hxx
index ca25ddbc12cf..4f9e9ec9c945 100644
--- a/svtools/source/control/valueimp.hxx
+++ b/svtools/source/control/valueimp.hxx
@@ -23,8 +23,7 @@
#include
#include
#include
-#include
-#include
+#include
#include
#include
#include
@@ -68,7 +67,7 @@ struct ValueSetItem
GetAccessible( bool bIsTransientChildrenDisabled );
};
-typedef ::cppu::WeakComponentImplHelper<
+typedef comphelper::WeakComponentImplHelper<
css::accessibility::XAccessible,
css::accessibility::XAccessibleEventBroadcaster,
css::accessibility::XAccessibleContext,
@@ -77,9 +76,7 @@ typedef ::cppu::WeakComponentImplHelper<
css::lang::XUnoTunnel >
ValueSetAccComponentBase;
-class ValueSetAcc :
-public ::cppu::BaseMutex,
-public ValueSetAccComponentBase
+class ValueSetAcc final : public ValueSetAccComponentBase
{
public:
@@ -156,7 +153,7 @@ private:
/** Tell all listeners that the object is dying. This callback is
usually called from the WeakComponentImplHelper class.
*/
-virtual void SAL_CALL disposing() override;
+virtual void disposing(std::unique_lock&) override;
/** Return the number of items. This takes the None-Item into account.
*/
