date:20220226

[Libreoffice-commits] core.git: sc/inc sc/source

2022-02-26 Thread Luboš Luňák (via logerrit)

 sc/inc/fillinfo.hxx  |   40 +++
 sc/source/core/data/fillinfo.cxx |   22 ++---
 sc/source/ui/view/gridwin4.cxx   |4 +--
 sc/source/ui/view/output.cxx |   14 ++---
 sc/source/ui/view/output2.cxx|   20 +--
 sc/source/ui/view/printfun.cxx   |4 +--
 6 files changed, 52 insertions(+), 52 deletions(-)

New commits:
commit 77ebac1021e1e795b6c6a7456a2ed8c56dd9370c
Author: Luboš Luňák 
AuthorDate: Sat Feb 26 18:49:58 2022 +0100
Commit: Luboš Luňák 
CommitDate: Sun Feb 27 08:22:38 2022 +0100

prefix CellInfo and BasicCellInfo with Sc

CellInfo is a pretty generic term to be used in the global namespace.

Change-Id: I9a2ce6b7b2157f75d7213321c615fc9636817252
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130608
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/sc/inc/fillinfo.hxx b/sc/inc/fillinfo.hxx
index d6ab0bd537c6..e348f7648bc7 100644
--- a/sc/inc/fillinfo.hxx
+++ b/sc/inc/fillinfo.hxx
@@ -98,11 +98,11 @@ struct ScIconSetInfo
 
 // FillInfo() computes some info for all cells starting from column 0,
 // but most of the info is needed only for cells in the given columns.
-// Keeping all the info in CellInfo could lead to allocation and initialization
+// Keeping all the info in ScCellInfo could lead to allocation and 
initialization
 // of MiB's of memory, so split the info needed for all cells to a smaller 
structure.
-struct BasicCellInfo
+struct ScBasicCellInfo
 {
-BasicCellInfo()
+ScBasicCellInfo()
 : nWidth(0)
 , bEmptyCellText(true)
 , bEditEngine(false)// view-internal
@@ -112,9 +112,9 @@ struct BasicCellInfo
 boolbEditEngine : 1;// output-internal
 };
 
-struct CellInfo
+struct ScCellInfo
 {
-CellInfo()
+ScCellInfo()
 : pPatternAttr(nullptr)
 , pConditionSet(nullptr)
 , pDataBar(nullptr)
@@ -142,8 +142,8 @@ struct CellInfo
 {
 }
 
-CellInfo(const CellInfo&) = delete;
-const CellInfo& operator=(const CellInfo&) = delete;
+ScCellInfo(const ScCellInfo&) = delete;
+const ScCellInfo& operator=(const ScCellInfo&) = delete;
 
 ScRefCellValue  maCell;
 
@@ -188,7 +188,7 @@ struct RowInfo
 RowInfo(const RowInfo&) = delete;
 const RowInfo& operator=(const RowInfo&) = delete;
 
-CellInfo&   cellInfo(SCCOL nCol)
+ScCellInfo& cellInfo(SCCOL nCol)
 {
 assert( nCol >= nStartCol - 1 );
 #ifdef DBG_UTIL
@@ -196,12 +196,12 @@ struct RowInfo
 #endif
 return pCellInfo[ nCol - nStartCol + 1 ];
 }
-const CellInfo& cellInfo(SCCOL nCol) const
+const ScCellInfo&   cellInfo(SCCOL nCol) const
 {
 return const_cast(this)->cellInfo(nCol);
 }
 
-BasicCellInfo&  basicCellInfo(SCCOL nCol)
+ScBasicCellInfo&basicCellInfo(SCCOL nCol)
 {
 assert( nCol >= -1 );
 #ifdef DBG_UTIL
@@ -209,7 +209,7 @@ struct RowInfo
 #endif
 return pBasicCellInfo[ nCol + 1 ];
 }
-const BasicCellInfo& basicCellInfo(SCCOL nCol) const
+const ScBasicCellInfo& basicCellInfo(SCCOL nCol) const
 {
 return const_cast(this)->basicCellInfo(nCol);
 }
@@ -220,8 +220,8 @@ struct RowInfo
 #ifdef DBG_UTIL
 nEndCol = endCol;
 #endif
-pCellInfo = new CellInfo[ endCol - nStartCol + 1 + 2 ];
-pBasicCellInfo = new BasicCellInfo[ endCol + 2 ];
+pCellInfo = new ScCellInfo[ endCol - nStartCol + 1 + 2 ];
+pBasicCellInfo = new ScBasicCellInfo[ endCol + 2 ];
 }
 voidfreeCellInfo()
 {
@@ -239,13 +239,13 @@ struct RowInfo
 boolbChanged:1;   // TRUE, if not tested
 
 private:
-// This class allocates CellInfo with also one item extra before and after.
+// This class allocates ScCellInfo with also one item extra before and 
after.
 // To make handling easier, this is private and access functions take care 
of adjusting
-// the array indexes and error-checking. CellInfo is allocated only for a 
given
-// range of columns plus one on each side, BasicCellInfo is allocated for 
columns
+// the array indexes and error-checking. ScCellInfo is allocated only for 
a given
+// range of columns plus one on each side, ScBasicCellInfo is allocated 
for columns
 // starting from column 0 until the last column given, again plus one on 
each side.
-CellInfo*   pCellInfo;
-BasicCellInfo*  pBasicCellInfo;
+ScCellInfo* pCellInfo;
+ScBasicCellInfo*pBasicCellInfo;
 SCCOL   nStartCol;
 #ifdef DBG_UTIL
 SCCOL   nEndCol;
@@ -275,8 +275,8 @@ struct ScTableInfo
 mIconSetInfos.push_back(std::move(info));
 }
 private:
-// These are owned here and not in CellInfo to avoid freeing
-// memory for every pointer in CellInfo, most of which are nullptr.
+//

[Libreoffice-bugs] [Bug 147639] Incorrect zoom (except for menubar) on enabling fractional scaling on KDE Wayland

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147639

--- Comment #1 from Jay Aurabind  ---
The env var mentioned in
https://bugs.documentfoundation.org/show_bug.cgi?id=121275 fixes the issue, but
gtk backend is used and some icons are not rendered properly. Most elements are
rendered using GTK instead of the KDE/Qt theme that I normally have (with the
scaling issue)

export OOO_FORCE_DESKTOP=gnome-wayland

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/inc sc/source

2022-02-26 Thread Luboš Luňák (via logerrit)

 sc/inc/fillinfo.hxx  |   63 +--
 sc/source/core/data/fillinfo.cxx |   56 ++
 sc/source/ui/view/output.cxx |   56 +-
 sc/source/ui/view/output2.cxx|   27 
 sc/source/ui/view/printfun.cxx   |9 +++--
 5 files changed, 124 insertions(+), 87 deletions(-)

New commits:
commit 694148a9898b47d749588f9a32173a9933262e29
Author: Luboš Luňák 
AuthorDate: Sat Feb 26 18:18:34 2022 +0100
Commit: Luboš Luňák 
CommitDate: Sun Feb 27 08:22:24 2022 +0100

do not allocate so many CellInfo objects in FillInfo()

FillInfo() is used for drawing to screen, so it's given a range
of rows and columns, but drawing also depends on all cells
to the left (e.g. their width, for position), so it allocated
CellInfo for all columns starting from 0. But with many columns
this can easily mean allocating and initializing a large amount
of memory, easily 90MiB with a maximized window and going to XFD1,
and handling all that can be slow enough to be seen when moving
around.

Since only few of the CellInfo fields are actually needed for all
columns, split them into a separate smaller BasicCellInfo, and
allocate CellInfo only for columns that need it. And exception
is the nRotMaxCol code (for rotated cells?), which accesses more
of the fields, so for that case allocate the same way as before.

Change-Id: I2f0f2a9c27b1a8b74b70fc2d208d0689e16ee1a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130607
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/sc/inc/fillinfo.hxx b/sc/inc/fillinfo.hxx
index dc1fc5ada0ab..d6ab0bd537c6 100644
--- a/sc/inc/fillinfo.hxx
+++ b/sc/inc/fillinfo.hxx
@@ -96,6 +96,22 @@ struct ScIconSetInfo
 bool mbShowValue;
 };
 
+// FillInfo() computes some info for all cells starting from column 0,
+// but most of the info is needed only for cells in the given columns.
+// Keeping all the info in CellInfo could lead to allocation and initialization
+// of MiB's of memory, so split the info needed for all cells to a smaller 
structure.
+struct BasicCellInfo
+{
+BasicCellInfo()
+: nWidth(0)
+, bEmptyCellText(true)
+, bEditEngine(false)// view-internal
+{}
+sal_uInt16  nWidth;
+boolbEmptyCellText : 1;
+boolbEditEngine : 1;// output-internal
+};
+
 struct CellInfo
 {
 CellInfo()
@@ -113,9 +129,7 @@ struct CellInfo
 , eHShadowPart(SC_SHADOW_HSTART)
 , eVShadowPart(SC_SHADOW_HSTART)
 , nClipMark(ScClipMark::NONE)
-, nWidth(0)
 , nRotateDir(ScRotateDir::NONE)
-, bEmptyCellText(false)
 , bMerged(false)
 , bHOverlapped(false)
 , bVOverlapped(false)
@@ -125,7 +139,6 @@ struct CellInfo
 , bFilterActive(false)
 , bPrinted(false)   // view-internal
 , bHideGrid(false)  // view-internal
-, bEditEngine(false)// view-internal
 {
 }
 
@@ -154,10 +167,8 @@ struct CellInfo
 ScShadowParteHShadowPart : 4;   // shadow 
effective for drawing
 ScShadowParteVShadowPart : 4;
 ScClipMark  nClipMark;
-sal_uInt16  nWidth;
 ScRotateDir nRotateDir;
 
-boolbEmptyCellText : 1;
 boolbMerged : 1;
 boolbHOverlapped : 1;
 boolbVOverlapped : 1;
@@ -167,7 +178,6 @@ struct CellInfo
 boolbFilterActive:1;
 boolbPrinted : 1;   // when required 
(pagebreak mode)
 boolbHideGrid : 1;  // output-internal
-boolbEditEngine : 1;// output-internal
 };
 
 const SCCOL SC_ROTMAX_NONE = SCCOL_MAX;
@@ -180,25 +190,44 @@ struct RowInfo
 
 CellInfo&   cellInfo(SCCOL nCol)
 {
-assert( nCol >= -1 );
+assert( nCol >= nStartCol - 1 );
 #ifdef DBG_UTIL
-assert( nCol <= nCols + 1 );
+assert( nCol <= nEndCol + 1 );
 #endif
-return pCellInfo[ nCol + 1 ];
+return pCellInfo[ nCol - nStartCol + 1 ];
 }
 const CellInfo& cellInfo(SCCOL nCol) const
 {
 return const_cast(this)->cellInfo(nCol);
 }
 
-voidallocCellInfo(SCCOL cols)
+BasicCellInfo&  basicCellInfo(SCCOL nCol)
 {
+assert( nCol >= -1 );
 #ifdef DBG_UTIL
-nCols = cols;
+assert( nCol <= nEndCol + 1 );
 #endif
-pCellInfo = new CellInfo[ cols + 2 ];
+return pBasicCellInfo[ nCol + 1 ];
+}
+const BasicCellInfo& basicCellInfo(SCCOL nCol) const
+{
+return const_cast(this)->basicCellInfo(nCol);
+}
+
+void

[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - icon-themes/colibre icon-themes/colibre_svg

2022-02-26 Thread Rizal Muttaqin (via logerrit)

 icon-themes/colibre/cmd/32/changecasetolower.png   |binary
 icon-themes/colibre/cmd/32/es/underline.png|binary
 icon-themes/colibre/cmd/32/es/underlinedouble.png  |binary
 icon-themes/colibre/cmd/32/hu/underline.png|binary
 icon-themes/colibre/cmd/32/hu/underlinedouble.png  |binary
 icon-themes/colibre/cmd/32/km/underline.png|binary
 icon-themes/colibre/cmd/32/km/underlinedouble.png  |binary
 icon-themes/colibre/cmd/32/ko/designerdialog.png   |binary
 icon-themes/colibre/cmd/32/ko/editstyle.png|binary
 icon-themes/colibre/cmd/32/ko/overline.png |binary
 icon-themes/colibre/cmd/32/ko/stylenewbyexample.png|binary
 icon-themes/colibre/cmd/32/ko/styleupdatebyexample.png |binary
 icon-themes/colibre/cmd/32/ko/underline.png|binary
 icon-themes/colibre/cmd/32/ko/underlinedouble.png  |binary
 icon-themes/colibre/cmd/32/nl/underline.png|binary
 icon-themes/colibre/cmd/32/nl/underlinedouble.png  |binary
 icon-themes/colibre/cmd/32/outlinefont.png |binary
 icon-themes/colibre/cmd/32/overline.png|binary
 icon-themes/colibre/cmd/32/pl/underline.png|binary
 icon-themes/colibre/cmd/32/pl/underlinedouble.png  |binary
 icon-themes/colibre/cmd/32/ru/underline.png|binary
 icon-themes/colibre/cmd/32/ru/underlinedouble.png  |binary
 icon-themes/colibre/cmd/32/smallcaps.png   |binary
 icon-themes/colibre/cmd/32/underline.png   |binary
 icon-themes/colibre/cmd/32/underlinedouble.png |binary
 icon-themes/colibre/cmd/lc_changecasetolower.png   |binary
 icon-themes/colibre/cmd/lc_changecasetoupper.png   |binary
 icon-themes/colibre/cmd/lc_italic.png  |binary
 icon-themes/colibre/cmd/lc_outlinefont.png |binary
 icon-themes/colibre_svg/cmd/32/changecasetolower.svg   |2 +-
 icon-themes/colibre_svg/cmd/32/es/underline.svg|2 +-
 icon-themes/colibre_svg/cmd/32/es/underlinedouble.svg  |2 +-
 icon-themes/colibre_svg/cmd/32/hu/underline.svg|2 +-
 icon-themes/colibre_svg/cmd/32/hu/underlinedouble.svg  |2 +-
 icon-themes/colibre_svg/cmd/32/km/underline.svg|2 +-
 icon-themes/colibre_svg/cmd/32/km/underlinedouble.svg  |2 +-
 icon-themes/colibre_svg/cmd/32/ko/designerdialog.svg   |2 +-
 icon-themes/colibre_svg/cmd/32/ko/editstyle.svg|2 +-
 icon-themes/colibre_svg/cmd/32/ko/overline.svg |2 +-
 icon-themes/colibre_svg/cmd/32/ko/stylenewbyexample.svg|2 +-
 icon-themes/colibre_svg/cmd/32/ko/styleupdatebyexample.svg |2 +-
 icon-themes/colibre_svg/cmd/32/ko/underline.svg|2 +-
 icon-themes/colibre_svg/cmd/32/ko/underlinedouble.svg  |2 +-
 icon-themes/colibre_svg/cmd/32/nl/underline.svg|2 +-
 icon-themes/colibre_svg/cmd/32/nl/underlinedouble.svg  |2 +-
 icon-themes/colibre_svg/cmd/32/outlinefont.svg |2 +-
 icon-themes/colibre_svg/cmd/32/overline.svg|2 +-
 icon-themes/colibre_svg/cmd/32/pl/underline.svg|2 +-
 icon-themes/colibre_svg/cmd/32/pl/underlinedouble.svg  |2 +-
 icon-themes/colibre_svg/cmd/32/ru/underline.svg|2 +-
 icon-themes/colibre_svg/cmd/32/ru/underlinedouble.svg  |2 +-
 icon-themes/colibre_svg/cmd/32/smallcaps.svg   |2 +-
 icon-themes/colibre_svg/cmd/32/underline.svg   |2 +-
 icon-themes/colibre_svg/cmd/32/underlinedouble.svg |2 +-
 icon-themes/colibre_svg/cmd/lc_changecasetolower.svg   |2 +-
 icon-themes/colibre_svg/cmd/lc_changecasetoupper.svg   |2 +-
 icon-themes/colibre_svg/cmd/lc_italic.svg  |2 +-
 icon-themes/colibre_svg/cmd/lc_outlinefont.svg |2 +-
 58 files changed, 29 insertions(+), 29 deletions(-)

New commits:
commit 971f891e271c50793cbd0a814cbecf8224532ed9
Author: Rizal Muttaqin 
AuthorDate: Sun Feb 27 06:35:00 2022 +0700
Commit: Rizal Muttaqin 
CommitDate: Sun Feb 27 07:49:13 2022 +0100

Colibre: tdf#137520 Adjust some icons size to make them balance

Change-Id: I168b00b5132742984520486535c391a7a46a902f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130615
Tested-by: Rizal Muttaqin 
Reviewed-by: Rizal Muttaqin 
(cherry picked from commit 61105658881ac0b05b2d92a3a6723a7b6a6f1d72)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130629
Tested-by: Jenkins

diff --git a/icon-themes/colibre/cmd/32/changecasetolower.png 
b/icon-themes/colibre/cmd/32/changecasetolower.png
index 1b233d781057..32f3e513061a 100644
Binary files a/icon-themes/colibre/cmd/32/changecasetolower.png and 
b/icon-themes/colibre/cmd/32/changecasetolower.png differ
diff --git

[Libreoffice-bugs] [Bug 140918] Compressing EMF into PNG/JPG doesn't result in a crisp an clear result (compared to EMF) even at highest quality

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140918

Dieter  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #5 from Dieter  ---
Hello Telesto, a new major release of LibreOffice is available since this bug
was reported. Could you please try to reproduce it with the latest version of
LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ ?
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the bug is still present in the latest version.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140439] UI: dark theme: Table styles > AutoFormat contrast too low, should be white on dark background (currently black)

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140439

Dieter  changed:

   What|Removed |Added

 OS|All |Linux (All)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143344] [META] Linux Dark Mode bugs and enhancements

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=143344

Dieter  changed:

   What|Removed |Added

 Depends on||140439


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=140439
[Bug 140439] UI: dark theme: Table styles > AutoFormat contrast too low, should
be white on dark background (currently black)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140439] UI: dark theme: Table styles > AutoFormat contrast too low, should be white on dark background (currently black)

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140439

Dieter  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de
 Blocks||143344


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=143344
[Bug 143344] [META] Linux Dark Mode bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140650] And easy the select a collection of shapes for grouping

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140650

Dieter  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #5 from Dieter  ---
Telesto, do you agree, if we change component to documentation?
=> NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140671] Cannot display or edit bad existing formula in table cell

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140671

Dieter  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #3 from Dieter  ---
Hello Ulrich, a new major release of LibreOffice is available since this bug
was reported. Could you please try to reproduce it with the latest version of
LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ ?
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the bug is still present in the latest version.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140507] embedded pictures disappear when name changed

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140507

Dieter  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #8 from Dieter  ---
Hello Matthias, a new major release of LibreOffice is available since this bug
was reported. Could you please try to reproduce it with the latest version of
LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ ?
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the bug is still present in the latest version.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 130819] Remove direct formatting affects paragraph indent only after saving and reloading file.

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130819

Dieter  changed:

   What|Removed |Added

Summary|Remove direct formatting|Remove direct formatting
   |affects paragraph indent|affects paragraph indent
   |only after saving, closing, |only after saving and
   |reopening file. |reloading file.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 130819] Remove direct formatting affects paragraph indent only after saving, closing, reopening file.

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130819

--- Comment #4 from Dieter  ---
Still present in 

Version: 7.3.1.2 (x64) / LibreOffice Community
Build ID: 9fff0292474d6d0bf5df787b512c71d9ac4bc98e
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sal/rtl

2022-02-26 Thread Mike Kaganski (via logerrit)

 sal/rtl/string.cxx  |   20 ++--
 sal/rtl/strtmpl.hxx |  219 
 sal/rtl/ustring.cxx |  147 +-
 3 files changed, 154 insertions(+), 232 deletions(-)

New commits:
commit 2126968ffbceb3c6f05db29c26ec90975e3f6331
Author: Mike Kaganski 
AuthorDate: Sat Feb 26 20:41:55 2022 +0300
Commit: Mike Kaganski 
CommitDate: Sun Feb 27 06:07:21 2022 +0100

Deduplicate more comparison functions

Change-Id: I93aba36b7cde268e358bd96b55183533ddc70b16
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130603
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sal/rtl/string.cxx b/sal/rtl/string.cxx
index 2b118a57aada..4b08b5e2c39f 100644
--- a/sal/rtl/string.cxx
+++ b/sal/rtl/string.cxx
@@ -337,14 +337,15 @@ sal_Int32 SAL_CALL rtl_str_getLength(const char* pStr) 
SAL_THROW_EXTERN_C()
 
 sal_Int32 SAL_CALL rtl_str_compare(const char* pStr1, const char* pStr2) 
SAL_THROW_EXTERN_C()
 {
-return rtl::str::compare(pStr1, pStr2);
+return rtl::str::compare(pStr1, pStr2, rtl::str::CompareNormal());
 }
 
 sal_Int32 SAL_CALL rtl_str_compare_WithLength(const char* pStr1, sal_Int32 
nStr1Len,
   const char* pStr2, sal_Int32 
nStr2Len)
 SAL_THROW_EXTERN_C()
 {
-return rtl::str::compare_WithLength(pStr1, nStr1Len, pStr2, nStr2Len);
+return rtl::str::compare_WithLengths(pStr1, nStr1Len, pStr2, nStr2Len,
+ rtl::str::CompareNormal());
 }
 
 sal_Int32 SAL_CALL rtl_str_shortenedCompare_WithLength(const char* pStr1, 
sal_Int32 nStr1Len,
@@ -352,35 +353,38 @@ sal_Int32 SAL_CALL 
rtl_str_shortenedCompare_WithLength(const char* pStr1, sal_In
sal_Int32 
nShortenedLength)
 SAL_THROW_EXTERN_C()
 {
-return rtl::str::shortenedCompare_WithLength(pStr1, nStr1Len, pStr2, 
nStr2Len, nShortenedLength);
+return rtl::str::shortenedCompare_WithLengths(pStr1, nStr1Len, pStr2, 
nStr2Len,
+  nShortenedLength, 
rtl::str::CompareNormal());
 }
 
 sal_Int32 SAL_CALL rtl_str_reverseCompare_WithLength(const char* pStr1, 
sal_Int32 nStr1Len,
  const char* pStr2, 
sal_Int32 nStr2Len)
 SAL_THROW_EXTERN_C()
 {
-return rtl::str::reverseCompare_WithLength(pStr1, nStr1Len, pStr2, 
nStr2Len);
+return rtl::str::reverseCompare_WithLengths(pStr1, nStr1Len, pStr2, 
nStr2Len,
+rtl::str::CompareNormal());
 }
 
 sal_Int32 SAL_CALL rtl_str_compareIgnoreAsciiCase(const char* pStr1, const 
char* pStr2)
 SAL_THROW_EXTERN_C()
 {
-return rtl::str::compareIgnoreAsciiCase(pStr1, pStr2);
+return rtl::str::compare(pStr1, pStr2, rtl::str::CompareIgnoreAsciiCase());
 }
 
 sal_Int32 SAL_CALL rtl_str_compareIgnoreAsciiCase_WithLength(const char* 
pStr1, sal_Int32 nStr1Len,
  const char* 
pStr2, sal_Int32 nStr2Len)
 SAL_THROW_EXTERN_C()
 {
-return rtl::str::compareIgnoreAsciiCase_WithLength(pStr1, nStr1Len, pStr2, 
nStr2Len);
+return rtl::str::compare_WithLengths(pStr1, nStr1Len, pStr2, nStr2Len,
+ rtl::str::CompareIgnoreAsciiCase());
 }
 
 sal_Int32 SAL_CALL rtl_str_shortenedCompareIgnoreAsciiCase_WithLength(
 const char* pStr1, sal_Int32 nStr1Len, const char* pStr2, sal_Int32 
nStr2Len,
 sal_Int32 nShortenedLength) SAL_THROW_EXTERN_C()
 {
-return rtl::str::shortenedCompareIgnoreAsciiCase_WithLength(pStr1, 
nStr1Len, pStr2, nStr2Len,
-  
nShortenedLength);
+return rtl::str::shortenedCompare_WithLengths(
+pStr1, nStr1Len, pStr2, nStr2Len, nShortenedLength, 
rtl::str::CompareIgnoreAsciiCase());
 }
 
 sal_Int32 SAL_CALL rtl_str_hashCode(const char* pStr) SAL_THROW_EXTERN_C()
diff --git a/sal/rtl/strtmpl.hxx b/sal/rtl/strtmpl.hxx
index 256c0cc99dd0..c5cdc23fbc84 100644
--- a/sal/rtl/strtmpl.hxx
+++ b/sal/rtl/strtmpl.hxx
@@ -98,143 +98,173 @@ template  void 
warnIfOneIsCharAndNotAscii(C1 c1, C2 c2
 }
 }
 
-/* --- */
-
-template  sal_Int32 compare(const C1* pStr1, const 
C2* pStr2)
+struct CompareNormal
 {
-assert(pStr1);
-assert(pStr2);
-if constexpr (sizeof(C1) == sizeof(char) && sizeof(C2) == sizeof(char))
+template  static sal_Int32 compare(C1 c1, C2 c2)
 {
-// take advantage of builtin optimisations
-return strcmp( pStr1, pStr2);
+warnIfOneIsCharAndNotAscii(c1, c2);
+return static_cast(IMPL_RTL_USTRCODE(c1))
+   - static_cast(IMPL_RTL_USTRCODE(c2));
 }
-else if constexpr (sizeof(C1) == sizeof(wchar_t) && sizeof(C2) == 
sizeof(wchar_t))
+};
+
+struct CompareIgnoreAsciiCase
+{
+template  static sal_Int32

[Libreoffice-bugs] [Bug 147565] Browsing comments in the navigation pane also browses hidden solved comments

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147565

Jim Raykowski  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #9 from Jim Raykowski  ---
(In reply to Anduril from comment #7)
> Great patch Jim! This is what I was looking for! I imagine that this will be
> merged in some future version of Libreoffice and no further action from me
> is needed.

You can test the patch by following instructions given here:
https://wiki.documentfoundation.org/Testing_Daily_Builds

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/sdi sw/source

2022-02-26 Thread Jim Raykowski (via logerrit)

 sw/sdi/swriter.sdi  |1 
 sw/source/uibase/uiview/viewmdi.cxx |   57 +---
 2 files changed, 34 insertions(+), 24 deletions(-)

New commits:
commit 5df0289f6af5aa7142017b56a8e17c134d54fe41
Author: Jim Raykowski 
AuthorDate: Fri Feb 25 00:31:29 2022 -0900
Commit: Jim Raykowski 
CommitDate: Sun Feb 27 05:08:38 2022 +0100

tdf#147565 Make navigate by comments skip hidden comments

Change-Id: I80f55146529505e5b6146db8cc324971fbc475e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130518
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 

diff --git a/sw/sdi/swriter.sdi b/sw/sdi/swriter.sdi
index 0e994261c28c..265a4000c5a0 100644
--- a/sw/sdi/swriter.sdi
+++ b/sw/sdi/swriter.sdi
@@ -2494,7 +2494,6 @@ SfxVoidItem InsertAnnotation FN_POSTIT
 Container = FALSE,
 RecordAbsolute = FALSE,
 RecordPerSet;
-Asynchron;
 
 AccelConfig = TRUE,
 MenuConfig = TRUE,
diff --git a/sw/source/uibase/uiview/viewmdi.cxx 
b/sw/source/uibase/uiview/viewmdi.cxx
index b85c05eb1af8..9acb7f8f7bd0 100644
--- a/sw/source/uibase/uiview/viewmdi.cxx
+++ b/sw/source/uibase/uiview/viewmdi.cxx
@@ -530,38 +530,48 @@ IMPL_LINK( SwView, MoveNavigationHdl, void*, p, void )
 {
 if (m_pPostItMgr->HasNotes())
 {
-rSh.EnterStdMode();
-sw::annotation::SwAnnotationWin* pPostIt = 
m_pPostItMgr->GetActiveSidebarWin();
-if (pPostIt)
-m_pPostItMgr->SetActiveSidebarWin(nullptr);
+m_pPostItMgr->AssureStdModeAtShell();
+m_pPostItMgr->SetActiveSidebarWin(nullptr);
+GetEditWin().GrabFocus();
+SwShellCursor* pCursor = rSh.GetCursor_();
+SwCursorSaveState aSaveState(*pCursor);
 SwFieldType* pFieldType = rSh.GetFieldType(0, 
SwFieldIds::Postit);
+bool bWrapped = false;
+bool bFound = false;
 rSh.StartAction();
-if (!rSh.MoveFieldType(pFieldType, bNext))
+while (!bFound)
 {
-// no postits found in the move direction
-// wrap and try again
-SwShellCursor* pCursor = rSh.GetCursor_();
-SwCursorSaveState aSaveState(*pCursor);
-rSh.SttEndDoc(bNext);
-if (rSh.MoveFieldType(pFieldType, bNext))
+if (!rSh.MoveFieldType(pFieldType, bNext))
 {
-GetViewFrame()->GetDispatcher()->Execute(FN_POSTIT);
-SvxSearchDialogWrapper::SetSearchLabel(bNext ? 
SearchLabel::EndWrapped :
-   
SearchLabel::StartWrapped);
+if (bWrapped)
+break;
+bWrapped = true;
+rSh.SttEndDoc(bNext);
+continue;
 }
-else
+do
 {
-// no visible postits
-pCursor->RestoreSavePos();
-
SvxSearchDialogWrapper::SetSearchLabel(SearchLabel::NavElementNotFound);
-}
+auto pAnnotationWin = m_pPostItMgr->GetAnnotationWin(
+rSh.GetPostItFieldAtCursor());
+if (pAnnotationWin && pAnnotationWin->IsVisible())
+bFound = true;
+} while (!bFound && rSh.MoveFieldType(pFieldType, bNext));
 }
-else
+if (!bFound)
 {
-GetViewFrame()->GetDispatcher()->Execute(FN_POSTIT);
-SvxSearchDialogWrapper::SetSearchLabel( SearchLabel::Empty 
);
+pCursor->RestoreSavePos();
+
SvxSearchDialogWrapper::SetSearchLabel(SearchLabel::NavElementNotFound);
 }
 rSh.EndAction();
+if (bFound)
+{
+GetViewFrame()->GetDispatcher()->Execute(FN_POSTIT);
+if (bWrapped)
+SvxSearchDialogWrapper::SetSearchLabel(bNext ? 
SearchLabel::EndWrapped :
+   
SearchLabel::StartWrapped);
+else
+
SvxSearchDialogWrapper::SetSearchLabel(SearchLabel::Empty);
+}
 }
 else
 
SvxSearchDialogWrapper::SetSearchLabel(SearchLabel::NavElementNotFound);
@@ -597,7 +607,8 @@ IMPL_LINK( SwView, MoveNavigationHdl, void*, p, void )
 bNext ? rSh.GetNavigationMgr().goForward() : 
rSh.GetNavigationMgr().goBack();
 break;
 }
-m_pEditWin->GrabFocus();
+if

[Libreoffice-bugs] [Bug 147565] Browsing comments in the navigation pane also browses hidden solved comments

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147565

--- Comment #8 from Commit Notification 
 ---
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5df0289f6af5aa7142017b56a8e17c134d54fe41

tdf#147565 Make navigate by comments skip hidden comments

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147565] Browsing comments in the navigation pane also browses hidden solved comments

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147565

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: icon-themes/colibre icon-themes/colibre_svg

2022-02-26 Thread Rizal Muttaqin (via logerrit)

 icon-themes/colibre/cmd/32/changecasetolower.png   |binary
 icon-themes/colibre/cmd/32/es/underline.png|binary
 icon-themes/colibre/cmd/32/es/underlinedouble.png  |binary
 icon-themes/colibre/cmd/32/hu/underline.png|binary
 icon-themes/colibre/cmd/32/hu/underlinedouble.png  |binary
 icon-themes/colibre/cmd/32/km/underline.png|binary
 icon-themes/colibre/cmd/32/km/underlinedouble.png  |binary
 icon-themes/colibre/cmd/32/ko/designerdialog.png   |binary
 icon-themes/colibre/cmd/32/ko/editstyle.png|binary
 icon-themes/colibre/cmd/32/ko/overline.png |binary
 icon-themes/colibre/cmd/32/ko/stylenewbyexample.png|binary
 icon-themes/colibre/cmd/32/ko/styleupdatebyexample.png |binary
 icon-themes/colibre/cmd/32/ko/underline.png|binary
 icon-themes/colibre/cmd/32/ko/underlinedouble.png  |binary
 icon-themes/colibre/cmd/32/nl/underline.png|binary
 icon-themes/colibre/cmd/32/nl/underlinedouble.png  |binary
 icon-themes/colibre/cmd/32/outlinefont.png |binary
 icon-themes/colibre/cmd/32/overline.png|binary
 icon-themes/colibre/cmd/32/pl/underline.png|binary
 icon-themes/colibre/cmd/32/pl/underlinedouble.png  |binary
 icon-themes/colibre/cmd/32/ru/underline.png|binary
 icon-themes/colibre/cmd/32/ru/underlinedouble.png  |binary
 icon-themes/colibre/cmd/32/smallcaps.png   |binary
 icon-themes/colibre/cmd/32/underline.png   |binary
 icon-themes/colibre/cmd/32/underlinedouble.png |binary
 icon-themes/colibre/cmd/lc_changecasetolower.png   |binary
 icon-themes/colibre/cmd/lc_changecasetoupper.png   |binary
 icon-themes/colibre/cmd/lc_italic.png  |binary
 icon-themes/colibre/cmd/lc_outlinefont.png |binary
 icon-themes/colibre_svg/cmd/32/changecasetolower.svg   |2 +-
 icon-themes/colibre_svg/cmd/32/es/underline.svg|2 +-
 icon-themes/colibre_svg/cmd/32/es/underlinedouble.svg  |2 +-
 icon-themes/colibre_svg/cmd/32/hu/underline.svg|2 +-
 icon-themes/colibre_svg/cmd/32/hu/underlinedouble.svg  |2 +-
 icon-themes/colibre_svg/cmd/32/km/underline.svg|2 +-
 icon-themes/colibre_svg/cmd/32/km/underlinedouble.svg  |2 +-
 icon-themes/colibre_svg/cmd/32/ko/designerdialog.svg   |2 +-
 icon-themes/colibre_svg/cmd/32/ko/editstyle.svg|2 +-
 icon-themes/colibre_svg/cmd/32/ko/overline.svg |2 +-
 icon-themes/colibre_svg/cmd/32/ko/stylenewbyexample.svg|2 +-
 icon-themes/colibre_svg/cmd/32/ko/styleupdatebyexample.svg |2 +-
 icon-themes/colibre_svg/cmd/32/ko/underline.svg|2 +-
 icon-themes/colibre_svg/cmd/32/ko/underlinedouble.svg  |2 +-
 icon-themes/colibre_svg/cmd/32/nl/underline.svg|2 +-
 icon-themes/colibre_svg/cmd/32/nl/underlinedouble.svg  |2 +-
 icon-themes/colibre_svg/cmd/32/outlinefont.svg |2 +-
 icon-themes/colibre_svg/cmd/32/overline.svg|2 +-
 icon-themes/colibre_svg/cmd/32/pl/underline.svg|2 +-
 icon-themes/colibre_svg/cmd/32/pl/underlinedouble.svg  |2 +-
 icon-themes/colibre_svg/cmd/32/ru/underline.svg|2 +-
 icon-themes/colibre_svg/cmd/32/ru/underlinedouble.svg  |2 +-
 icon-themes/colibre_svg/cmd/32/smallcaps.svg   |2 +-
 icon-themes/colibre_svg/cmd/32/underline.svg   |2 +-
 icon-themes/colibre_svg/cmd/32/underlinedouble.svg |2 +-
 icon-themes/colibre_svg/cmd/lc_changecasetolower.svg   |2 +-
 icon-themes/colibre_svg/cmd/lc_changecasetoupper.svg   |2 +-
 icon-themes/colibre_svg/cmd/lc_italic.svg  |2 +-
 icon-themes/colibre_svg/cmd/lc_outlinefont.svg |2 +-
 58 files changed, 29 insertions(+), 29 deletions(-)

New commits:
commit 61105658881ac0b05b2d92a3a6723a7b6a6f1d72
Author: Rizal Muttaqin 
AuthorDate: Sun Feb 27 06:35:00 2022 +0700
Commit: Rizal Muttaqin 
CommitDate: Sun Feb 27 04:41:33 2022 +0100

Colibre: tdf#137520 Adjust some icons size to make them balance

Change-Id: I168b00b5132742984520486535c391a7a46a902f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130615
Tested-by: Rizal Muttaqin 
Reviewed-by: Rizal Muttaqin 

diff --git a/icon-themes/colibre/cmd/32/changecasetolower.png 
b/icon-themes/colibre/cmd/32/changecasetolower.png
index 1b233d781057..32f3e513061a 100644
Binary files a/icon-themes/colibre/cmd/32/changecasetolower.png and 
b/icon-themes/colibre/cmd/32/changecasetolower.png differ
diff --git a/icon-themes/colibre/cmd/32/es/underline.png 
b/icon-themes/colibre/cmd/32/es/underline.png
index baddbdada28d..635e58742e1a 100644
Binary files

[Libreoffice-commits] core.git: icon-themes/colibre icon-themes/colibre_svg

2022-02-26 Thread Rizal Muttaqin (via logerrit)

 icon-themes/colibre/cmd/es/lc_underline.png   |binary
 icon-themes/colibre/cmd/es/lc_underlinedouble.png |binary
 icon-themes/colibre/cmd/hu/lc_underline.png   |binary
 icon-themes/colibre/cmd/hu/lc_underlinedouble.png |binary
 icon-themes/colibre/cmd/km/lc_underline.png   |binary
 icon-themes/colibre/cmd/km/lc_underlinedouble.png |binary
 icon-themes/colibre/cmd/ko/lc_overline.png|binary
 icon-themes/colibre/cmd/ko/lc_underline.png   |binary
 icon-themes/colibre/cmd/ko/lc_underlinedouble.png |binary
 icon-themes/colibre/cmd/lc_overline.png   |binary
 icon-themes/colibre/cmd/lc_underline.png  |binary
 icon-themes/colibre/cmd/lc_underlinedouble.png|binary
 icon-themes/colibre/cmd/nl/lc_underline.png   |binary
 icon-themes/colibre/cmd/nl/lc_underlinedouble.png |binary
 icon-themes/colibre/cmd/pl/lc_underline.png   |binary
 icon-themes/colibre/cmd/pl/lc_underlinedouble.png |binary
 icon-themes/colibre/cmd/ru/lc_underline.png   |binary
 icon-themes/colibre/cmd/ru/lc_underlinedouble.png |binary
 icon-themes/colibre_svg/cmd/es/lc_underline.svg   |2 +-
 icon-themes/colibre_svg/cmd/es/lc_underlinedouble.svg |2 +-
 icon-themes/colibre_svg/cmd/hu/lc_underline.svg   |2 +-
 icon-themes/colibre_svg/cmd/hu/lc_underlinedouble.svg |2 +-
 icon-themes/colibre_svg/cmd/km/lc_underline.svg   |2 +-
 icon-themes/colibre_svg/cmd/km/lc_underlinedouble.svg |2 +-
 icon-themes/colibre_svg/cmd/ko/lc_overline.svg|2 +-
 icon-themes/colibre_svg/cmd/ko/lc_underline.svg   |2 +-
 icon-themes/colibre_svg/cmd/ko/lc_underlinedouble.svg |2 +-
 icon-themes/colibre_svg/cmd/lc_overline.svg   |2 +-
 icon-themes/colibre_svg/cmd/lc_underline.svg  |2 +-
 icon-themes/colibre_svg/cmd/lc_underlinedouble.svg|2 +-
 icon-themes/colibre_svg/cmd/nl/lc_underline.svg   |2 +-
 icon-themes/colibre_svg/cmd/nl/lc_underlinedouble.svg |2 +-
 icon-themes/colibre_svg/cmd/pl/lc_underline.svg   |2 +-
 icon-themes/colibre_svg/cmd/pl/lc_underlinedouble.svg |2 +-
 icon-themes/colibre_svg/cmd/ru/lc_underline.svg   |2 +-
 icon-themes/colibre_svg/cmd/ru/lc_underlinedouble.svg |2 +-
 36 files changed, 18 insertions(+), 18 deletions(-)

New commits:
commit 03ef44a8f3c392486acd7d42a5854c7594ff50b1
Author: Rizal Muttaqin 
AuthorDate: Sun Feb 27 07:15:31 2022 +0700
Commit: Rizal Muttaqin 
CommitDate: Sun Feb 27 04:40:49 2022 +0100

Colibre: tdf#137520 Adjust some icons size to make them balance (large size)

Change-Id: Id16f53d867b4487399e33a548e623950a1b76197
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130616
Tested-by: Rizal Muttaqin 
Reviewed-by: Rizal Muttaqin 

diff --git a/icon-themes/colibre/cmd/es/lc_underline.png 
b/icon-themes/colibre/cmd/es/lc_underline.png
index 84e4a75e43c5..42592bc6de60 100644
Binary files a/icon-themes/colibre/cmd/es/lc_underline.png and 
b/icon-themes/colibre/cmd/es/lc_underline.png differ
diff --git a/icon-themes/colibre/cmd/es/lc_underlinedouble.png 
b/icon-themes/colibre/cmd/es/lc_underlinedouble.png
index 66d2cb5d4eca..fc78a272b270 100644
Binary files a/icon-themes/colibre/cmd/es/lc_underlinedouble.png and 
b/icon-themes/colibre/cmd/es/lc_underlinedouble.png differ
diff --git a/icon-themes/colibre/cmd/hu/lc_underline.png 
b/icon-themes/colibre/cmd/hu/lc_underline.png
index 8f5b07b27a3e..03c48b983c7b 100644
Binary files a/icon-themes/colibre/cmd/hu/lc_underline.png and 
b/icon-themes/colibre/cmd/hu/lc_underline.png differ
diff --git a/icon-themes/colibre/cmd/hu/lc_underlinedouble.png 
b/icon-themes/colibre/cmd/hu/lc_underlinedouble.png
index b91d5a700266..97e22216f210 100644
Binary files a/icon-themes/colibre/cmd/hu/lc_underlinedouble.png and 
b/icon-themes/colibre/cmd/hu/lc_underlinedouble.png differ
diff --git a/icon-themes/colibre/cmd/km/lc_underline.png 
b/icon-themes/colibre/cmd/km/lc_underline.png
index 95fd59387987..8a9604391fd0 100644
Binary files a/icon-themes/colibre/cmd/km/lc_underline.png and 
b/icon-themes/colibre/cmd/km/lc_underline.png differ
diff --git a/icon-themes/colibre/cmd/km/lc_underlinedouble.png 
b/icon-themes/colibre/cmd/km/lc_underlinedouble.png
index 7559f0b711eb..7968dcfd66e1 100644
Binary files a/icon-themes/colibre/cmd/km/lc_underlinedouble.png and 
b/icon-themes/colibre/cmd/km/lc_underlinedouble.png differ
diff --git a/icon-themes/colibre/cmd/ko/lc_overline.png 
b/icon-themes/colibre/cmd/ko/lc_overline.png
index d05c1fce914a..2cf67ea3ff0a 100644
Binary files a/icon-themes/colibre/cmd/ko/lc_overline.png and 
b/icon-themes/colibre/cmd/ko/lc_overline.png differ
diff --git a/icon-themes/colibre/cmd/ko/lc_underline.png 
b/icon-themes/colibre/cmd/ko/lc_underline.png
index 579e1456ccb9..966a69108a18 100644
Binary files a/icon-themes/colibre/cmd/ko/lc_underline.png and 
b/icon-themes/colibre/cmd/ko/lc_underline.png differ
diff

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - icon-themes/colibre icon-themes/colibre_svg

2022-02-26 Thread Rizal Muttaqin (via logerrit)

 icon-themes/colibre/cmd/es/lc_underline.png   |binary
 icon-themes/colibre/cmd/es/lc_underlinedouble.png |binary
 icon-themes/colibre/cmd/hu/lc_underline.png   |binary
 icon-themes/colibre/cmd/hu/lc_underlinedouble.png |binary
 icon-themes/colibre/cmd/km/lc_underline.png   |binary
 icon-themes/colibre/cmd/km/lc_underlinedouble.png |binary
 icon-themes/colibre/cmd/ko/lc_overline.png|binary
 icon-themes/colibre/cmd/ko/lc_underline.png   |binary
 icon-themes/colibre/cmd/ko/lc_underlinedouble.png |binary
 icon-themes/colibre/cmd/lc_overline.png   |binary
 icon-themes/colibre/cmd/lc_underline.png  |binary
 icon-themes/colibre/cmd/lc_underlinedouble.png|binary
 icon-themes/colibre/cmd/nl/lc_underline.png   |binary
 icon-themes/colibre/cmd/nl/lc_underlinedouble.png |binary
 icon-themes/colibre/cmd/pl/lc_underline.png   |binary
 icon-themes/colibre/cmd/pl/lc_underlinedouble.png |binary
 icon-themes/colibre/cmd/ru/lc_underline.png   |binary
 icon-themes/colibre/cmd/ru/lc_underlinedouble.png |binary
 icon-themes/colibre_svg/cmd/es/lc_underline.svg   |2 +-
 icon-themes/colibre_svg/cmd/es/lc_underlinedouble.svg |2 +-
 icon-themes/colibre_svg/cmd/hu/lc_underline.svg   |2 +-
 icon-themes/colibre_svg/cmd/hu/lc_underlinedouble.svg |2 +-
 icon-themes/colibre_svg/cmd/km/lc_underline.svg   |2 +-
 icon-themes/colibre_svg/cmd/km/lc_underlinedouble.svg |2 +-
 icon-themes/colibre_svg/cmd/ko/lc_overline.svg|2 +-
 icon-themes/colibre_svg/cmd/ko/lc_underline.svg   |2 +-
 icon-themes/colibre_svg/cmd/ko/lc_underlinedouble.svg |2 +-
 icon-themes/colibre_svg/cmd/lc_overline.svg   |2 +-
 icon-themes/colibre_svg/cmd/lc_underline.svg  |2 +-
 icon-themes/colibre_svg/cmd/lc_underlinedouble.svg|2 +-
 icon-themes/colibre_svg/cmd/nl/lc_underline.svg   |2 +-
 icon-themes/colibre_svg/cmd/nl/lc_underlinedouble.svg |2 +-
 icon-themes/colibre_svg/cmd/pl/lc_underline.svg   |2 +-
 icon-themes/colibre_svg/cmd/pl/lc_underlinedouble.svg |2 +-
 icon-themes/colibre_svg/cmd/ru/lc_underline.svg   |2 +-
 icon-themes/colibre_svg/cmd/ru/lc_underlinedouble.svg |2 +-
 36 files changed, 18 insertions(+), 18 deletions(-)

New commits:
commit 82fb397d1e228a37aad5fe5cc423c6b0b520f2a3
Author: Rizal Muttaqin 
AuthorDate: Sun Feb 27 07:15:31 2022 +0700
Commit: Rizal Muttaqin 
CommitDate: Sun Feb 27 04:40:11 2022 +0100

Colibre: tdf#137520 Adjust some icons size to make them balance (large size)

Change-Id: Id16f53d867b4487399e33a548e623950a1b76197
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130627
Tested-by: Rizal Muttaqin 
Reviewed-by: Rizal Muttaqin 

diff --git a/icon-themes/colibre/cmd/es/lc_underline.png 
b/icon-themes/colibre/cmd/es/lc_underline.png
index 84e4a75e43c5..42592bc6de60 100644
Binary files a/icon-themes/colibre/cmd/es/lc_underline.png and 
b/icon-themes/colibre/cmd/es/lc_underline.png differ
diff --git a/icon-themes/colibre/cmd/es/lc_underlinedouble.png 
b/icon-themes/colibre/cmd/es/lc_underlinedouble.png
index 66d2cb5d4eca..fc78a272b270 100644
Binary files a/icon-themes/colibre/cmd/es/lc_underlinedouble.png and 
b/icon-themes/colibre/cmd/es/lc_underlinedouble.png differ
diff --git a/icon-themes/colibre/cmd/hu/lc_underline.png 
b/icon-themes/colibre/cmd/hu/lc_underline.png
index 8f5b07b27a3e..03c48b983c7b 100644
Binary files a/icon-themes/colibre/cmd/hu/lc_underline.png and 
b/icon-themes/colibre/cmd/hu/lc_underline.png differ
diff --git a/icon-themes/colibre/cmd/hu/lc_underlinedouble.png 
b/icon-themes/colibre/cmd/hu/lc_underlinedouble.png
index b91d5a700266..97e22216f210 100644
Binary files a/icon-themes/colibre/cmd/hu/lc_underlinedouble.png and 
b/icon-themes/colibre/cmd/hu/lc_underlinedouble.png differ
diff --git a/icon-themes/colibre/cmd/km/lc_underline.png 
b/icon-themes/colibre/cmd/km/lc_underline.png
index 95fd59387987..8a9604391fd0 100644
Binary files a/icon-themes/colibre/cmd/km/lc_underline.png and 
b/icon-themes/colibre/cmd/km/lc_underline.png differ
diff --git a/icon-themes/colibre/cmd/km/lc_underlinedouble.png 
b/icon-themes/colibre/cmd/km/lc_underlinedouble.png
index 7559f0b711eb..7968dcfd66e1 100644
Binary files a/icon-themes/colibre/cmd/km/lc_underlinedouble.png and 
b/icon-themes/colibre/cmd/km/lc_underlinedouble.png differ
diff --git a/icon-themes/colibre/cmd/ko/lc_overline.png 
b/icon-themes/colibre/cmd/ko/lc_overline.png
index d05c1fce914a..2cf67ea3ff0a 100644
Binary files a/icon-themes/colibre/cmd/ko/lc_overline.png and 
b/icon-themes/colibre/cmd/ko/lc_overline.png differ
diff --git a/icon-themes/colibre/cmd/ko/lc_underline.png 
b/icon-themes/colibre/cmd/ko/lc_underline.png
index 579e1456ccb9..966a69108a18 100644
Binary files a/icon-themes/colibre/cmd/ko/lc_underline.png and 
b/icon-themes/colibre/cmd/ko/lc_underline.png differ
diff

[Libreoffice-commits] core.git: icon-themes/sukapura icon-themes/sukapura_svg

2022-02-26 Thread Rizal Muttaqin (via logerrit)

 icon-themes/sukapura/cmd/32/emphasischarstyle.png |binary
 icon-themes/sukapura/cmd/lc_emphasischarstyle.png |binary
 icon-themes/sukapura/cmd/sc_emphasischarstyle.png |binary
 icon-themes/sukapura_svg/cmd/32/emphasischarstyle.svg |2 +-
 icon-themes/sukapura_svg/cmd/lc_emphasischarstyle.svg |2 +-
 icon-themes/sukapura_svg/cmd/sc_emphasischarstyle.svg |2 +-
 6 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit c189137f846399fbf30099592efc8750682f6d97
Author: Rizal Muttaqin 
AuthorDate: Sun Feb 27 07:30:20 2022 +0700
Commit: Rizal Muttaqin 
CommitDate: Sun Feb 27 04:39:01 2022 +0100

Sukapura: Make Emphasis Character Style icons slimmer

Change-Id: Ib4a5497d0393be4b08fcdc2eafa6ab6332623bc2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130617
Tested-by: Rizal Muttaqin 
Reviewed-by: Rizal Muttaqin 

diff --git a/icon-themes/sukapura/cmd/32/emphasischarstyle.png 
b/icon-themes/sukapura/cmd/32/emphasischarstyle.png
index 448c71cb51f8..3fcbca793bf1 100644
Binary files a/icon-themes/sukapura/cmd/32/emphasischarstyle.png and 
b/icon-themes/sukapura/cmd/32/emphasischarstyle.png differ
diff --git a/icon-themes/sukapura/cmd/lc_emphasischarstyle.png 
b/icon-themes/sukapura/cmd/lc_emphasischarstyle.png
index 6e96fb6d4f12..55730ed8e4d2 100644
Binary files a/icon-themes/sukapura/cmd/lc_emphasischarstyle.png and 
b/icon-themes/sukapura/cmd/lc_emphasischarstyle.png differ
diff --git a/icon-themes/sukapura/cmd/sc_emphasischarstyle.png 
b/icon-themes/sukapura/cmd/sc_emphasischarstyle.png
index de316f8e2fc7..da2c5796b082 100644
Binary files a/icon-themes/sukapura/cmd/sc_emphasischarstyle.png and 
b/icon-themes/sukapura/cmd/sc_emphasischarstyle.png differ
diff --git a/icon-themes/sukapura_svg/cmd/32/emphasischarstyle.svg 
b/icon-themes/sukapura_svg/cmd/32/emphasischarstyle.svg
index b524a6a2bfa4..d85731a9208e 100644
--- a/icon-themes/sukapura_svg/cmd/32/emphasischarstyle.svg
+++ b/icon-themes/sukapura_svg/cmd/32/emphasischarstyle.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg;>
\ No newline at end of file
+http://www.w3.org/2000/svg;>
\ No newline at end of file
diff --git a/icon-themes/sukapura_svg/cmd/lc_emphasischarstyle.svg 
b/icon-themes/sukapura_svg/cmd/lc_emphasischarstyle.svg
index 03a053474a29..e615d93dbb5a 100644
--- a/icon-themes/sukapura_svg/cmd/lc_emphasischarstyle.svg
+++ b/icon-themes/sukapura_svg/cmd/lc_emphasischarstyle.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg;>
\ No newline at end of file
+http://www.w3.org/2000/svg;>
\ No newline at end of file
diff --git a/icon-themes/sukapura_svg/cmd/sc_emphasischarstyle.svg 
b/icon-themes/sukapura_svg/cmd/sc_emphasischarstyle.svg
index 8d2cb0abb6d6..1273371697cf 100644
--- a/icon-themes/sukapura_svg/cmd/sc_emphasischarstyle.svg
+++ b/icon-themes/sukapura_svg/cmd/sc_emphasischarstyle.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg;>
\ No newline at end of file
+http://www.w3.org/2000/svg;>
\ No newline at end of file

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - icon-themes/sukapura icon-themes/sukapura_svg

2022-02-26 Thread Rizal Muttaqin (via logerrit)

 icon-themes/sukapura/cmd/32/emphasischarstyle.png |binary
 icon-themes/sukapura/cmd/lc_emphasischarstyle.png |binary
 icon-themes/sukapura/cmd/sc_emphasischarstyle.png |binary
 icon-themes/sukapura_svg/cmd/32/emphasischarstyle.svg |2 +-
 icon-themes/sukapura_svg/cmd/lc_emphasischarstyle.svg |2 +-
 icon-themes/sukapura_svg/cmd/sc_emphasischarstyle.svg |2 +-
 6 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit add78f76cd30c4bc7484b149cecbac7782ad3b34
Author: Rizal Muttaqin 
AuthorDate: Sun Feb 27 07:30:20 2022 +0700
Commit: Rizal Muttaqin 
CommitDate: Sun Feb 27 04:37:20 2022 +0100

Sukapura: Make Emphasis Character Style icons slimmer

Change-Id: Ib4a5497d0393be4b08fcdc2eafa6ab6332623bc2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130628
Tested-by: Rizal Muttaqin 
Reviewed-by: Rizal Muttaqin 

diff --git a/icon-themes/sukapura/cmd/32/emphasischarstyle.png 
b/icon-themes/sukapura/cmd/32/emphasischarstyle.png
index 448c71cb51f8..3fcbca793bf1 100644
Binary files a/icon-themes/sukapura/cmd/32/emphasischarstyle.png and 
b/icon-themes/sukapura/cmd/32/emphasischarstyle.png differ
diff --git a/icon-themes/sukapura/cmd/lc_emphasischarstyle.png 
b/icon-themes/sukapura/cmd/lc_emphasischarstyle.png
index 6e96fb6d4f12..55730ed8e4d2 100644
Binary files a/icon-themes/sukapura/cmd/lc_emphasischarstyle.png and 
b/icon-themes/sukapura/cmd/lc_emphasischarstyle.png differ
diff --git a/icon-themes/sukapura/cmd/sc_emphasischarstyle.png 
b/icon-themes/sukapura/cmd/sc_emphasischarstyle.png
index de316f8e2fc7..da2c5796b082 100644
Binary files a/icon-themes/sukapura/cmd/sc_emphasischarstyle.png and 
b/icon-themes/sukapura/cmd/sc_emphasischarstyle.png differ
diff --git a/icon-themes/sukapura_svg/cmd/32/emphasischarstyle.svg 
b/icon-themes/sukapura_svg/cmd/32/emphasischarstyle.svg
index b524a6a2bfa4..d85731a9208e 100644
--- a/icon-themes/sukapura_svg/cmd/32/emphasischarstyle.svg
+++ b/icon-themes/sukapura_svg/cmd/32/emphasischarstyle.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg;>
\ No newline at end of file
+http://www.w3.org/2000/svg;>
\ No newline at end of file
diff --git a/icon-themes/sukapura_svg/cmd/lc_emphasischarstyle.svg 
b/icon-themes/sukapura_svg/cmd/lc_emphasischarstyle.svg
index 03a053474a29..e615d93dbb5a 100644
--- a/icon-themes/sukapura_svg/cmd/lc_emphasischarstyle.svg
+++ b/icon-themes/sukapura_svg/cmd/lc_emphasischarstyle.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg;>
\ No newline at end of file
+http://www.w3.org/2000/svg;>
\ No newline at end of file
diff --git a/icon-themes/sukapura_svg/cmd/sc_emphasischarstyle.svg 
b/icon-themes/sukapura_svg/cmd/sc_emphasischarstyle.svg
index 8d2cb0abb6d6..1273371697cf 100644
--- a/icon-themes/sukapura_svg/cmd/sc_emphasischarstyle.svg
+++ b/icon-themes/sukapura_svg/cmd/sc_emphasischarstyle.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg;>
\ No newline at end of file
+http://www.w3.org/2000/svg;>
\ No newline at end of file

[Libreoffice-bugs] [Bug 147399] Row size autofit

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147399

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147380] VLOOKUP() result within and acting upon another sorted AUTOFILTER ARRAY does not update when the source is amended

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147380

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147268] Some selected preferences are not remembered when installing a new version

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147268

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147382] LibreOffice 7.3 Calc crashes after I click the icon. The crash includes a "send crash report" screen.

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147382

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147382] LibreOffice 7.3 Calc crashes after I click the icon. The crash includes a "send crash report" screen.

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147382

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144054] 7.2.0.3 (x64) インストーラ

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=144054

--- Comment #3 from QA Administrators  ---
Dear nori hisa,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147664] Sukapura: Some icons with text (like B, I, U, etc) are too big that make them unbalance with the rest of the icons

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147664

--- Comment #2 from Commit Notification 
 ---
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/eeac435199737f91c57184b46b3afd92b945e238

Sukapura: tdf#147664 Shrink some icons to make them balance

It will be available in 7.3.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147664] Sukapura: Some icons with text (like B, I, U, etc) are too big that make them unbalance with the rest of the icons

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147664

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.4.0|target:7.4.0 target:7.3.2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - icon-themes/sukapura icon-themes/sukapura_svg

2022-02-26 Thread Rizal Muttaqin (via logerrit)

 icon-themes/sukapura/cmd/32/bg/bold.png |binary
 icon-themes/sukapura/cmd/32/bg/italic.png   |binary
 icon-themes/sukapura/cmd/32/bold.png|binary
 icon-themes/sukapura/cmd/32/changecasetolower.png   |binary
 icon-themes/sukapura/cmd/32/changecasetoupper.png   |binary
 icon-themes/sukapura/cmd/32/color.png   |binary
 icon-themes/sukapura/cmd/32/de/bold.png |binary
 icon-themes/sukapura/cmd/32/de/italic.png   |binary
 icon-themes/sukapura/cmd/32/defaultcharstyle.png|binary
 icon-themes/sukapura/cmd/32/designerdialog.png  |binary
 icon-themes/sukapura/cmd/32/editstyle.png   |binary
 icon-themes/sukapura/cmd/32/emphasischarstyle.png   |binary
 icon-themes/sukapura/cmd/32/es/bold.png |binary
 icon-themes/sukapura/cmd/32/es/underline.png|binary
 icon-themes/sukapura/cmd/32/es/underlinedouble.png  |binary
 icon-themes/sukapura/cmd/32/fr/bold.png |binary
 icon-themes/sukapura/cmd/32/heading1parastyle.png   |binary
 icon-themes/sukapura/cmd/32/heading2parastyle.png   |binary
 icon-themes/sukapura/cmd/32/heading3parastyle.png   |binary
 icon-themes/sukapura/cmd/32/heading4parastyle.png   |binary
 icon-themes/sukapura/cmd/32/heading5parastyle.png   |binary
 icon-themes/sukapura/cmd/32/heading6parastyle.png   |binary
 icon-themes/sukapura/cmd/32/hu/italic.png   |binary
 icon-themes/sukapura/cmd/32/hu/underline.png|binary
 icon-themes/sukapura/cmd/32/hu/underlinedouble.png  |binary
 icon-themes/sukapura/cmd/32/it/italic.png   |binary
 icon-themes/sukapura/cmd/32/italic.png  |binary
 icon-themes/sukapura/cmd/32/km/bold.png |binary
 icon-themes/sukapura/cmd/32/km/italic.png   |binary
 icon-themes/sukapura/cmd/32/km/underline.png|binary
 icon-themes/sukapura/cmd/32/km/underlinedouble.png  |binary
 icon-themes/sukapura/cmd/32/ko/bold.png |binary
 icon-themes/sukapura/cmd/32/ko/color.png|binary
 icon-themes/sukapura/cmd/32/ko/designerdialog.png   |binary
 icon-themes/sukapura/cmd/32/ko/editstyle.png|binary
 icon-themes/sukapura/cmd/32/ko/italic.png   |binary
 icon-themes/sukapura/cmd/32/ko/outlinefont.png  |binary
 icon-themes/sukapura/cmd/32/ko/overline.png |binary
 icon-themes/sukapura/cmd/32/ko/resetattributes.png  |binary
 icon-themes/sukapura/cmd/32/ko/shadowed.png |binary
 icon-themes/sukapura/cmd/32/ko/stylenewbyexample.png|binary
 icon-themes/sukapura/cmd/32/ko/styleupdatebyexample.png |binary
 icon-themes/sukapura/cmd/32/ko/underline.png|binary
 icon-themes/sukapura/cmd/32/ko/underlinedouble.png  |binary
 icon-themes/sukapura/cmd/32/nl/bold.png |binary
 icon-themes/sukapura/cmd/32/nl/underline.png|binary
 icon-themes/sukapura/cmd/32/nl/underlinedouble.png  |binary
 icon-themes/sukapura/cmd/32/outlinefont.png |binary
 icon-themes/sukapura/cmd/32/overline.png|binary
 icon-themes/sukapura/cmd/32/pl/underline.png|binary
 icon-themes/sukapura/cmd/32/pl/underlinedouble.png  |binary
 icon-themes/sukapura/cmd/32/preformattedparastyle.png   |binary
 icon-themes/sukapura/cmd/32/quotecharstyle.png  |binary
 icon-themes/sukapura/cmd/32/quoteparastyle.png  |binary
 icon-themes/sukapura/cmd/32/resetattributes.png |binary
 icon-themes/sukapura/cmd/32/ru/bold.png |binary
 icon-themes/sukapura/cmd/32/ru/underline.png|binary
 icon-themes/sukapura/cmd/32/ru/underlinedouble.png  |binary
 icon-themes/sukapura/cmd/32/searchdialog.png|binary
 icon-themes/sukapura/cmd/32/shadowed.png|binary
 icon-themes/sukapura/cmd/32/sl/bold.png |binary
 icon-themes/sukapura/cmd/32/sl/italic.png   |binary
 icon-themes/sukapura/cmd/32/smallcaps.png   |binary
 icon-themes/sukapura/cmd/32/sourcecharstyle.png |binary
 icon-themes/sukapura/cmd/32/strikeout.png   |binary
 icon-themes/sukapura/cmd/32/strongemphasischarstyle.png |binary
 icon-themes/sukapura/cmd/32/stylenewbyexample.png   |binary
 icon-themes/sukapura/cmd/32/styleupdatebyexample.png|binary
 icon-themes/sukapura/cmd/32/subscript.png   |binary
 icon-themes/sukapura/cmd/32/subtitleparastyle.png   |binary
 icon-themes/sukapura/cmd/32/superscript.png |binary
 icon-themes/sukapura/cmd/32/textbodyparastyle.png   |binary

[Libreoffice-bugs] [Bug 147660] Implement Jalali Calendar in LibreOffice

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147660

--- Comment #1 from Eike Rathke  ---
Note that *only* the libjalali sources
https://github.com/ashkang/jcal/tree/master/sources/libjalali
are licensed LGPLv3+ and could be used as external module, jcal itself is
GPLv3+ and as such can not be incorporated into LibreOffice source code.
The library is available in Debian as
https://packages.debian.org/sid/libjalali0
and in Fedora as
https://packages.fedoraproject.org/pkgs/jcal/libjalali/

Original upstream appears to be
https://savannah.nongnu.org/projects/jcal/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147682] In my LibreWriter document brackets "[ ]" are randomly displaying throughout the document.

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147682

--- Comment #1 from Thorn  ---
Created attachment 178564
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178564=edit
Screenshot of the brackets randomly displaying in my document

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147682] New: In my LibreWriter document brackets "[ ]" are randomly displaying throughout the document.

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147682

Bug ID: 147682
   Summary: In my LibreWriter document brackets "[ ]" are randomly
displaying throughout the document.
   Product: LibreOffice
   Version: 7.3.0.3 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: chicoth...@live.com

Description:
After installing LibreOffice 7.3.0.3 one of my most important LibreWriter
documents began displaying brackets randomly throughout the entire document.
These are not in the text itself as they cannot be selected nor edited. 

Steps to Reproduce:
1.I just reopened a document created in LibreWriter 7.2.5.2. 
2.
3.

Actual Results:
Noneditable random brackets displayed throughout document

Expected Results:
My document should open normally as it had done before the version upgrade.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 7.3.0.3 (x64) / LibreOffice Community
Build ID: 0f246aa12d0eee4a0f7adcefbf7c878fc2238db3
CPU threads: 8; OS: Windows 10.0 Build 22563; UI render: default; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147680] Autotext replacement not willing to ignore space after shortcut

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147680

Eyal Rozenberg  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||7681

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147681] New: Autotext replacement not willing to ignore parenthesis before shortcut

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147681

Bug ID: 147681
   Summary: Autotext replacement not willing to ignore parenthesis
before shortcut
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: eyalr...@gmx.com
Blocks: 108663

Suppose I have some autotext entry with a certain shortcut (e.g. ---). 

If I type in that shortcut and press F3, it should be replaced with the
autotext entry (well, that and the gratuitous newline, see bug 53023).

However, if, before the shortcut, I have a parenthesis character rather than a
space (or nothing), - F3 will not be match my shortcut and I'll get an error
message.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108663
[Bug 108663] [META] AutoText bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108663] [META] AutoText bugs and enhancements

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108663

Eyal Rozenberg  changed:

   What|Removed |Added

 Depends on||147681


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=147681
[Bug 147681] Autotext replacement not willing to ignore parenthesis before
shortcut
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108663] [META] AutoText bugs and enhancements

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108663

Eyal Rozenberg  changed:

   What|Removed |Added

 Depends on||147680


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=147680
[Bug 147680] Autotext replacement not willing to ignore space after shortcut
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147680] New: Autotext replacement not willing to ignore space after shortcut

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147680

Bug ID: 147680
   Summary: Autotext replacement not willing to ignore space after
shortcut
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: eyalr...@gmx.com
Blocks: 108663

Suppose I have some autotext entry with a certain shortcut. 

If I type in that shortcut and press F3, it should be replaced with the
autotext entry (well, that and the gratuitous newline, see bug 53023).

However, if I have an extra space character after the shortcut, and my caret is
just after that space - F3 will not be match my shortcut and I'll get an error
message.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108663
[Bug 108663] [META] AutoText bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147679] New: Can not select initial characters in the formula bar

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147679

Bug ID: 147679
   Summary: Can not select initial characters in the formula bar
   Product: LibreOffice
   Version: 7.3.0.3 release
  Hardware: All
OS: macOS (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: dreapp...@yahoo.com

Description:
When I go to the formula bar to edit a cell, I cannot select or position the
mouse cursor within the first few characters of the entry. Also, the X and
Checkmark are not selectable. Clicking on them does nothing. The formula
selection icon is selectable though, and causes the current contents of the
cell to be accepted while displaying the formula selection dialog.

Steps to Reproduce:
1. Select a cell and position the mouse over near the beginning of the formula
bar entry, say within 2 or 3 characters of the beginning.
2A. Click to set the cursor icon at that location. The cursor icon does not
appear and you cannot enter anything into the formula bar.
2B. Double-click to select the first word in the cell. The word is not selected
and cannot be replaced.
3. Attempt to click the checkmark just to the left of the formula bar entry.
Nothing happens.
4. Attempt to click the X icon to the left of the formula bar. Nothing happens.
5. Move the cursor further to the right within the formula bar, say 4 or 5
characters from the beginning.
6. Click or double-click as directed in steps above. The cursor text icon
appears or the word under the mouse is selected for editing.

Actual Results:
Cursor is not entered in the desired position of the formula bar text when the
cursor is near the beginning of the text.

Expected Results:
Cursor text icon should appear in the text or the word should be selected for
editing.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.3.0.3
Build: 0f246aa12d0eee4a0f7adcefbf7c878fc2238db3

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147678] New: Can not select initial characters in the formula bar

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147678

Bug ID: 147678
   Summary: Can not select initial characters in the formula bar
   Product: LibreOffice
   Version: 7.3.0.3 release
  Hardware: All
OS: macOS (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: dreapp...@yahoo.com

Description:
When I go to the formula bar to edit a cell, I cannot select or position the
mouse cursor within the first few characters of the entry. Also, the X and
Checkmark are not selectable. Clicking on them does nothing. The formula
selection icon is selectable though, and causes the current contents of the
cell to be accepted while displaying the formula selection dialog.

Steps to Reproduce:
1. Select a cell and position the mouse over near the beginning of the formula
bar entry, say within 2 or 3 characters of the beginning.
2A. Click to set the cursor icon at that location. The cursor icon does not
appear and you cannot enter anything into the formula bar.
2B. Double-click to select the first word in the cell. The word is not selected
and cannot be replaced.
3. Attempt to click the checkmark just to the left of the formula bar entry.
Nothing happens.
4. Attempt to click the X icon to the left of the formula bar. Nothing happens.
5. Move the cursor further to the right within the formula bar, say 4 or 5
characters from the beginning.
6. Click or double-click as directed in steps above. The cursor text icon
appears or the word under the mouse is selected for editing.

Actual Results:
Cursor is not entered in the desired position of the formula bar text when the
cursor is near the beginning of the text.

Expected Results:
Cursor text icon should appear in the text or the word should be selected for
editing.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.3.0.3
Build: 0f246aa12d0eee4a0f7adcefbf7c878fc2238db3

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147677] New: Highlighted cell in spreadsheet is not the cell actually having focus.

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147677

Bug ID: 147677
   Summary: Highlighted cell in spreadsheet is not the cell
actually having focus.
   Product: LibreOffice
   Version: 7.3.0.3 release
  Hardware: All
OS: macOS (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: dreapp...@yahoo.com

Description:
When the arrow keys (and sometimes the mouse) is used to select a cell, the
highlight of the cell remains with the cell that was exited. The highlight of
the row and column headers does change though. And the formula bar contains the
correct contents of the currently selected cell. But the highlight around the
previously selected cell is still there.

Steps to Reproduce:
1. Select a cell in the spreadsheet
2. Use arrow keys on keyboard to select an adjacent cell.
3.

Actual Results:
Highlight of cell being exited remains. No highlight around selected cell.

Expected Results:
Highlight of selected cell should appear and exited cell should not have a
highlight around its borders.


Reproducible: Sometimes


User Profile Reset: No



Additional Info:
Version: 7.3.0.3
Build: 0f246aa12d0eee4a0f7adcefbf7c878fc2238db3
Environ: CPU thread: 8; OS: Mac OS X 10.16

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147676] New: Continue to show cell contents in the formula bar when another document gets the mouse focus.

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147676

Bug ID: 147676
   Summary: Continue to show cell contents in the formula bar when
another document gets the mouse focus.
   Product: LibreOffice
   Version: 7.3.0.3 release
  Hardware: All
OS: macOS (All)
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: dreapp...@yahoo.com

Description:
When I change the mouse focus from a spreadsheet to any other LibreOffice
document, say a text document, the contents of the spreadsheet formula bar are
wiped out. This does not happen if the focus is to any other application, which
is good.

Steps to Reproduce:
1. Select a cell in the spreadsheet - its contents are displayed in the formula
bar. OK.
2. Give focus of the mouse to some other LibreOffice document - the spreadsheet
formula bar is wiped out.
3.

Actual Results:
See steps above.

Expected Results:
The formula bar should never be wiped out, regardless of where the focus is.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.3.0.3 and earlier versions did this
Build: 0f246aa12d0eee4a0f7adcefbf7c878fc2238db3
Environ: CPU threads: 8; OS: Mac OS X 10.16
UI: UI render: Skia/Metal; VCL: osx
Locale: en-US (en.UTF-8(; UI: en-US
Misc: Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147664] Sukapura: Some icons with text (like B, I, U, etc) are too big that make them unbalance with the rest of the icons

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147664

--- Comment #1 from Commit Notification 
 ---
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2a403801576543a7254edd41d6919c8c57c34f9e

Sukapura: tdf#147664 Shrink some icons to make them balance

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147664] Sukapura: Some icons with text (like B, I, U, etc) are too big that make them unbalance with the rest of the icons

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147664

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: icon-themes/sukapura icon-themes/sukapura_svg

2022-02-26 Thread Rizal Muttaqin (via logerrit)

 icon-themes/sukapura/cmd/32/bg/bold.png |binary
 icon-themes/sukapura/cmd/32/bg/italic.png   |binary
 icon-themes/sukapura/cmd/32/bold.png|binary
 icon-themes/sukapura/cmd/32/changecasetolower.png   |binary
 icon-themes/sukapura/cmd/32/changecasetoupper.png   |binary
 icon-themes/sukapura/cmd/32/color.png   |binary
 icon-themes/sukapura/cmd/32/de/bold.png |binary
 icon-themes/sukapura/cmd/32/de/italic.png   |binary
 icon-themes/sukapura/cmd/32/defaultcharstyle.png|binary
 icon-themes/sukapura/cmd/32/designerdialog.png  |binary
 icon-themes/sukapura/cmd/32/editstyle.png   |binary
 icon-themes/sukapura/cmd/32/emphasischarstyle.png   |binary
 icon-themes/sukapura/cmd/32/es/bold.png |binary
 icon-themes/sukapura/cmd/32/es/underline.png|binary
 icon-themes/sukapura/cmd/32/es/underlinedouble.png  |binary
 icon-themes/sukapura/cmd/32/fr/bold.png |binary
 icon-themes/sukapura/cmd/32/heading1parastyle.png   |binary
 icon-themes/sukapura/cmd/32/heading2parastyle.png   |binary
 icon-themes/sukapura/cmd/32/heading3parastyle.png   |binary
 icon-themes/sukapura/cmd/32/heading4parastyle.png   |binary
 icon-themes/sukapura/cmd/32/heading5parastyle.png   |binary
 icon-themes/sukapura/cmd/32/heading6parastyle.png   |binary
 icon-themes/sukapura/cmd/32/hu/italic.png   |binary
 icon-themes/sukapura/cmd/32/hu/underline.png|binary
 icon-themes/sukapura/cmd/32/hu/underlinedouble.png  |binary
 icon-themes/sukapura/cmd/32/it/italic.png   |binary
 icon-themes/sukapura/cmd/32/italic.png  |binary
 icon-themes/sukapura/cmd/32/km/bold.png |binary
 icon-themes/sukapura/cmd/32/km/italic.png   |binary
 icon-themes/sukapura/cmd/32/km/underline.png|binary
 icon-themes/sukapura/cmd/32/km/underlinedouble.png  |binary
 icon-themes/sukapura/cmd/32/ko/bold.png |binary
 icon-themes/sukapura/cmd/32/ko/color.png|binary
 icon-themes/sukapura/cmd/32/ko/designerdialog.png   |binary
 icon-themes/sukapura/cmd/32/ko/editstyle.png|binary
 icon-themes/sukapura/cmd/32/ko/italic.png   |binary
 icon-themes/sukapura/cmd/32/ko/outlinefont.png  |binary
 icon-themes/sukapura/cmd/32/ko/overline.png |binary
 icon-themes/sukapura/cmd/32/ko/resetattributes.png  |binary
 icon-themes/sukapura/cmd/32/ko/shadowed.png |binary
 icon-themes/sukapura/cmd/32/ko/stylenewbyexample.png|binary
 icon-themes/sukapura/cmd/32/ko/styleupdatebyexample.png |binary
 icon-themes/sukapura/cmd/32/ko/underline.png|binary
 icon-themes/sukapura/cmd/32/ko/underlinedouble.png  |binary
 icon-themes/sukapura/cmd/32/nl/bold.png |binary
 icon-themes/sukapura/cmd/32/nl/underline.png|binary
 icon-themes/sukapura/cmd/32/nl/underlinedouble.png  |binary
 icon-themes/sukapura/cmd/32/outlinefont.png |binary
 icon-themes/sukapura/cmd/32/overline.png|binary
 icon-themes/sukapura/cmd/32/pl/underline.png|binary
 icon-themes/sukapura/cmd/32/pl/underlinedouble.png  |binary
 icon-themes/sukapura/cmd/32/preformattedparastyle.png   |binary
 icon-themes/sukapura/cmd/32/quotecharstyle.png  |binary
 icon-themes/sukapura/cmd/32/quoteparastyle.png  |binary
 icon-themes/sukapura/cmd/32/resetattributes.png |binary
 icon-themes/sukapura/cmd/32/ru/bold.png |binary
 icon-themes/sukapura/cmd/32/ru/underline.png|binary
 icon-themes/sukapura/cmd/32/ru/underlinedouble.png  |binary
 icon-themes/sukapura/cmd/32/searchdialog.png|binary
 icon-themes/sukapura/cmd/32/shadowed.png|binary
 icon-themes/sukapura/cmd/32/sl/bold.png |binary
 icon-themes/sukapura/cmd/32/sl/italic.png   |binary
 icon-themes/sukapura/cmd/32/smallcaps.png   |binary
 icon-themes/sukapura/cmd/32/sourcecharstyle.png |binary
 icon-themes/sukapura/cmd/32/strikeout.png   |binary
 icon-themes/sukapura/cmd/32/strongemphasischarstyle.png |binary
 icon-themes/sukapura/cmd/32/stylenewbyexample.png   |binary
 icon-themes/sukapura/cmd/32/styleupdatebyexample.png|binary
 icon-themes/sukapura/cmd/32/subscript.png   |binary
 icon-themes/sukapura/cmd/32/subtitleparastyle.png   |binary
 icon-themes/sukapura/cmd/32/superscript.png |binary
 icon-themes/sukapura/cmd/32/textbodyparastyle.png   |binary

[Libreoffice-bugs] [Bug 132643] [LOCALHELP] Translate section id to English mnemonics

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=132643

--- Comment #745 from Commit Notification 
 ---
Johnny_M committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/dd0acce907394934a9323fc2d34290f1db74f166

tdf#132643 Translate German section IDs

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: helpcontent2

2022-02-26 Thread Johnny_M (via logerrit)

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit de9480a3225209902919294306dbf00ff105e999
Author: Johnny_M 
AuthorDate: Sat Feb 26 23:11:30 2022 +0100
Commit: Gerrit Code Review 
CommitDate: Sat Feb 26 23:11:30 2022 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to dd0acce907394934a9323fc2d34290f1db74f166
  - tdf#132643 Translate German section IDs

Change-Id: I5a45f355b77d899a24ae346ceedf10fcb882d420
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130589
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 671306d813db..dd0acce90739 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 671306d813dbf9546aac2963cc84a0a56e587d80
+Subproject commit dd0acce907394934a9323fc2d34290f1db74f166

[Libreoffice-bugs] [Bug 132643] [LOCALHELP] Translate section id to English mnemonics

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=132643

--- Comment #744 from Commit Notification 
 ---
Johnny_M committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/671306d813dbf9546aac2963cc84a0a56e587d80

tdf#132643 Translate German section IDs

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] help.git: source/text

2022-02-26 Thread Johnny_M (via logerrit)

 source/text/swriter/00/0404.xhp |4 ++--
 source/text/swriter/01/04120100.xhp |2 +-
 source/text/swriter/02/1801.xhp |2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit dd0acce907394934a9323fc2d34290f1db74f166
Author: Johnny_M 
AuthorDate: Sat Feb 26 12:55:07 2022 +0100
Commit: Olivier Hallot 
CommitDate: Sat Feb 26 23:11:29 2022 +0100

tdf#132643 Translate German section IDs

Change-Id: I5a45f355b77d899a24ae346ceedf10fcb882d420
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130589
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/swriter/00/0404.xhp 
b/source/text/swriter/00/0404.xhp
index 6aa2b074b..483cd10c7 100644
--- a/source/text/swriter/00/0404.xhp
+++ b/source/text/swriter/00/0404.xhp
@@ -169,11 +169,11 @@
 
 Choose Insert - Table of Contents and Index
 
-
+
 Choose 
Insert - Table of Contents and Index - Index Entry
 
 Open 
Insert toolbar, click
-
+
 
 
 
diff --git a/source/text/swriter/01/04120100.xhp 
b/source/text/swriter/01/04120100.xhp
index fb51c9619..41b90158e 100644
--- a/source/text/swriter/01/04120100.xhp
+++ b/source/text/swriter/01/04120100.xhp
@@ -37,7 +37,7 @@
 Marks the selected text as 
index or table of contents entry.
 
 
-  
+  
 
 To edit an 
index entry, place the cursor in front of the index field, and then choose 
Edit - Reference - Index 
Entry...removed a para - see 
#i64023
 You can leave 
the Insert Index Entry dialog open while you select and insert 
entries.
diff --git a/source/text/swriter/02/1801.xhp 
b/source/text/swriter/02/1801.xhp
index 15df31ef2..ea06f9ac4 100644
--- a/source/text/swriter/02/1801.xhp
+++ b/source/text/swriter/02/1801.xhp
@@ -87,6 +87,6 @@
 Inserts an 
index or a table of contents at the current cursor position.
 Entry
 
-
+

[Libreoffice-commits] core.git: helpcontent2

2022-02-26 Thread Johnny_M (via logerrit)

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 2bf8623d46f1d5b5beb495954a99318b9e69f7f9
Author: Johnny_M 
AuthorDate: Sat Feb 26 23:10:46 2022 +0100
Commit: Gerrit Code Review 
CommitDate: Sat Feb 26 23:10:46 2022 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 671306d813dbf9546aac2963cc84a0a56e587d80
  - tdf#132643 Translate German section IDs

Change-Id: Iafebe7e8c835f8fcdaf206f078d92ac4234443c4
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130588
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 93d42d638422..671306d813db 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 93d42d6384221b98d93dd5730cdd99082961c99c
+Subproject commit 671306d813dbf9546aac2963cc84a0a56e587d80

[Libreoffice-commits] help.git: source/text

2022-02-26 Thread Johnny_M (via logerrit)

 source/text/swriter/00/0404.xhp |4 ++--
 source/text/swriter/01/0404.xhp |2 +-
 source/text/swriter/02/1801.xhp |2 +-
 source/text/swriter/02/1903.xhp |2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

New commits:
commit 671306d813dbf9546aac2963cc84a0a56e587d80
Author: Johnny_M 
AuthorDate: Sat Feb 26 12:47:55 2022 +0100
Commit: Olivier Hallot 
CommitDate: Sat Feb 26 23:10:44 2022 +0100

tdf#132643 Translate German section IDs

Change-Id: Iafebe7e8c835f8fcdaf206f078d92ac4234443c4
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130588
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/swriter/00/0404.xhp 
b/source/text/swriter/00/0404.xhp
index 340044c49..6aa2b074b 100644
--- a/source/text/swriter/00/0404.xhp
+++ b/source/text/swriter/00/0404.xhp
@@ -145,11 +145,11 @@
 Open context 
menu - choose Caption - Options
 
 
-
+
 Choose 
Insert - Bookmark
 
 Open 
Insert toolbar, click
-
+
 
 
 
diff --git a/source/text/swriter/01/0404.xhp 
b/source/text/swriter/01/0404.xhp
index ed1876852..f16025c79 100644
--- a/source/text/swriter/01/0404.xhp
+++ b/source/text/swriter/01/0404.xhp
@@ -38,7 +38,7 @@
 Inserts a bookmark at the cursor position. You can 
then use the Navigator to quickly jump to the marked location at a later 
time. In an HTML document, bookmarks are converted to anchors that you 
can jump to from a hyperlink.
 
 
-
+
 
 To jump to a 
specific bookmark, press F5 to open the Navigator, click 
the plus sign (+) next to the Bookmarks entry, and then 
double-click the bookmark.
 
diff --git a/source/text/swriter/02/1801.xhp 
b/source/text/swriter/02/1801.xhp
index 03d12de6f..15df31ef2 100644
--- a/source/text/swriter/02/1801.xhp
+++ b/source/text/swriter/02/1801.xhp
@@ -57,7 +57,7 @@
 Inserts a note 
at the current cursor position.
 Bookmark
 
-UFI: "insert 
cross reference" hereFile
+UFI: 
"insert cross reference" hereFile
 
 
 AutoText
diff --git a/source/text/swriter/02/1903.xhp 
b/source/text/swriter/02/1903.xhp
index 7d57724b5..b8137c169 100644
--- a/source/text/swriter/02/1903.xhp
+++ b/source/text/swriter/02/1903.xhp
@@ -68,6 +68,6 @@
 
 Insert 
Bookmark
 
-
+

[Libreoffice-bugs] [Bug 132643] [LOCALHELP] Translate section id to English mnemonics

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=132643

--- Comment #743 from Commit Notification 
 ---
Johnny_M committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/93d42d6384221b98d93dd5730cdd99082961c99c

tdf#132643 Translate German section IDs

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 132643] [LOCALHELP] Translate section id to English mnemonics

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=132643

--- Comment #742 from Commit Notification 
 ---
Johnny_M committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/c16c09e9672fe032e965197b2431682274d9cf08

tdf#132643 Translate German section IDs

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: helpcontent2

2022-02-26 Thread Johnny_M (via logerrit)

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f516c685fbb51bf16258338425ac0bc3478cabe6
Author: Johnny_M 
AuthorDate: Sat Feb 26 23:09:51 2022 +0100
Commit: Gerrit Code Review 
CommitDate: Sat Feb 26 23:09:51 2022 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 93d42d6384221b98d93dd5730cdd99082961c99c
  - tdf#132643 Translate German section IDs

Change-Id: Ibca93fc3f787797cb9f085bba04d3db63231be7f
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130587
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index c16c09e9672f..93d42d638422 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit c16c09e9672fe032e965197b2431682274d9cf08
+Subproject commit 93d42d6384221b98d93dd5730cdd99082961c99c

[Libreoffice-commits] help.git: source/text

2022-02-26 Thread Johnny_M (via logerrit)

 source/text/swriter/00/0404.xhp |2 +-
 source/text/swriter/01/04060100.xhp |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 93d42d6384221b98d93dd5730cdd99082961c99c
Author: Johnny_M 
AuthorDate: Sat Feb 26 12:40:56 2022 +0100
Commit: Olivier Hallot 
CommitDate: Sat Feb 26 23:09:50 2022 +0100

tdf#132643 Translate German section IDs

Change-Id: Ibca93fc3f787797cb9f085bba04d3db63231be7f
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130587
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/swriter/00/0404.xhp 
b/source/text/swriter/00/0404.xhp
index 9b0a65e1b..340044c49 100644
--- a/source/text/swriter/00/0404.xhp
+++ b/source/text/swriter/00/0404.xhp
@@ -139,7 +139,7 @@
 Open context 
menu - choose Caption
 
 
-
+
 Choose 
Insert - Caption - Options
 
 Open context 
menu - choose Caption - Options
diff --git a/source/text/swriter/01/04060100.xhp 
b/source/text/swriter/01/04060100.xhp
index c50d1921e..8189ce30f 100644
--- a/source/text/swriter/01/04060100.xhp
+++ b/source/text/swriter/01/04060100.xhp
@@ -35,7 +35,7 @@
 Adds 
the chapter number to the caption label. To use this feature, you must first 
assign an outline level to a paragraph style, and then apply the style to 
the chapter headings in your document.
 
 
-  
+

[Libreoffice-commits] core.git: helpcontent2

2022-02-26 Thread Johnny_M (via logerrit)

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1d831d89cbe7143d17cbfd25749eb024f9a84239
Author: Johnny_M 
AuthorDate: Sat Feb 26 23:09:18 2022 +0100
Commit: Gerrit Code Review 
CommitDate: Sat Feb 26 23:09:18 2022 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to c16c09e9672fe032e965197b2431682274d9cf08
  - tdf#132643 Translate German section IDs

Change-Id: Ibaeee3ea64bdc2c42d83607a624f864103468d72
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130586
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 0bbeaceff9f8..c16c09e9672f 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 0bbeaceff9f8d9c4c636d27ded4546c7b0533fba
+Subproject commit c16c09e9672fe032e965197b2431682274d9cf08

[Libreoffice-commits] help.git: source/text

2022-02-26 Thread Johnny_M (via logerrit)

 source/text/swriter/00/0404.xhp |2 +-
 source/text/swriter/01/0406.xhp |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit c16c09e9672fe032e965197b2431682274d9cf08
Author: Johnny_M 
AuthorDate: Sat Feb 26 12:33:54 2022 +0100
Commit: Olivier Hallot 
CommitDate: Sat Feb 26 23:09:16 2022 +0100

tdf#132643 Translate German section IDs

Change-Id: Ibaeee3ea64bdc2c42d83607a624f864103468d72
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130586
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/swriter/00/0404.xhp 
b/source/text/swriter/00/0404.xhp
index 0f035f783..9b0a65e1b 100644
--- a/source/text/swriter/00/0404.xhp
+++ b/source/text/swriter/00/0404.xhp
@@ -133,7 +133,7 @@
 
 
 
-
+
 Choose 
Insert - Caption
 
 Open context 
menu - choose Caption
diff --git a/source/text/swriter/01/0406.xhp 
b/source/text/swriter/01/0406.xhp
index a76755e3b..516870d83 100644
--- a/source/text/swriter/01/0406.xhp
+++ b/source/text/swriter/01/0406.xhp
@@ -38,7 +38,7 @@
 
 
 
-
+
 
 
 Properties

[Libreoffice-bugs] [Bug 132643] [LOCALHELP] Translate section id to English mnemonics

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=132643

--- Comment #741 from Commit Notification 
 ---
Johnny_M committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/0bbeaceff9f8d9c4c636d27ded4546c7b0533fba

tdf#132643 Translate German section IDs

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: helpcontent2

2022-02-26 Thread Johnny_M (via logerrit)

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5d484a3fd17677f2966fbb02946683b3ba18f14b
Author: Johnny_M 
AuthorDate: Sat Feb 26 23:08:38 2022 +0100
Commit: Gerrit Code Review 
CommitDate: Sat Feb 26 23:08:38 2022 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 0bbeaceff9f8d9c4c636d27ded4546c7b0533fba
  - tdf#132643 Translate German section IDs

Change-Id: If62f841f29d15ddbd143541a56488412384ca5b0
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130585
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 3851aac7a173..0bbeaceff9f8 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 3851aac7a173686b5c74f2b744e3e7732905713b
+Subproject commit 0bbeaceff9f8d9c4c636d27ded4546c7b0533fba

[Libreoffice-commits] help.git: source/text

2022-02-26 Thread Johnny_M (via logerrit)

 source/text/swriter/00/0404.xhp |6 +++---
 source/text/swriter/01/0403.xhp |2 +-
 source/text/swriter/02/1801.xhp |4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 0bbeaceff9f8d9c4c636d27ded4546c7b0533fba
Author: Johnny_M 
AuthorDate: Sat Feb 26 12:25:02 2022 +0100
Commit: Olivier Hallot 
CommitDate: Sat Feb 26 23:08:36 2022 +0100

tdf#132643 Translate German section IDs

Change-Id: If62f841f29d15ddbd143541a56488412384ca5b0
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130585
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/swriter/00/0404.xhp 
b/source/text/swriter/00/0404.xhp
index 86ac0870f..0f035f783 100644
--- a/source/text/swriter/00/0404.xhp
+++ b/source/text/swriter/00/0404.xhp
@@ -97,12 +97,12 @@
 
 Choose Insert > Section > Indents tab 
or choose Format > Sections - Options 
button - Indents tab
 
-
+
 Choose 
Insert - Footnote and Endnote - Footnote or Endnote
 
 Open context 
menu - choose Footnote/Endnote (inserted 
Footnote/Endnote)
 Open 
Insert toolbar, click
-
+
 
 
 
@@ -118,7 +118,7 @@
 
 
 
-
+
 
 
 
diff --git a/source/text/swriter/01/0403.xhp 
b/source/text/swriter/01/0403.xhp
index 38cd46b6f..6abcc8a44 100644
--- a/source/text/swriter/01/0403.xhp
+++ b/source/text/swriter/01/0403.xhp
@@ -40,7 +40,7 @@
 Footnotes are inserted at the end of a page, and endnotes are 
inserted at the end of a document.
 UFI: what about sections? Will endnotes be placed 
there?
 
-
+
 
 Numbering
 Select the 
type of numbering that you want to use for footnotes and endnotes.
diff --git a/source/text/swriter/02/1801.xhp 
b/source/text/swriter/02/1801.xhp
index f6b587f5e..03d12de6f 100644
--- a/source/text/swriter/02/1801.xhp
+++ b/source/text/swriter/02/1801.xhp
@@ -49,10 +49,10 @@
 
 Insert 
Footnote Directly
 
-
+
 Insert 
Endnote Directly
 
-
+
 Note
 Inserts a note 
at the current cursor position.
 Bookmark

[Libreoffice-commits] core.git: helpcontent2

2022-02-26 Thread Johnny_M (via logerrit)

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0b65a3bda5cc3a83f80f7da2bb7765ef5de9d34b
Author: Johnny_M 
AuthorDate: Sat Feb 26 23:07:53 2022 +0100
Commit: Gerrit Code Review 
CommitDate: Sat Feb 26 23:07:53 2022 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 3851aac7a173686b5c74f2b744e3e7732905713b
  - tdf#132643 Translate German section IDs

Change-Id: I0ceb0df437e37d91f0c84898bb2880fd3651de3f
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130584
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 13bc989cc1e9..3851aac7a173 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 13bc989cc1e90d627387bf4a4b18804662c1f8eb
+Subproject commit 3851aac7a173686b5c74f2b744e3e7732905713b

[Libreoffice-bugs] [Bug 132643] [LOCALHELP] Translate section id to English mnemonics

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=132643

--- Comment #740 from Commit Notification 
 ---
Johnny_M committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/3851aac7a173686b5c74f2b744e3e7732905713b

tdf#132643 Translate German section IDs

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] help.git: source/text

2022-02-26 Thread Johnny_M (via logerrit)

 source/text/swriter/00/0404.xhp |4 ++--
 source/text/swriter/01/0402.xhp |2 +-
 source/text/swriter/02/1801.xhp |2 +-
 source/text/swriter/02/1903.xhp |2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

New commits:
commit 3851aac7a173686b5c74f2b744e3e7732905713b
Author: Johnny_M 
AuthorDate: Sat Feb 26 12:20:07 2022 +0100
Commit: Olivier Hallot 
CommitDate: Sat Feb 26 23:07:52 2022 +0100

tdf#132643 Translate German section IDs

Change-Id: I0ceb0df437e37d91f0c84898bb2880fd3651de3f
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130584
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/swriter/00/0404.xhp 
b/source/text/swriter/00/0404.xhp
index f625f158a..86ac0870f 100644
--- a/source/text/swriter/00/0404.xhp
+++ b/source/text/swriter/00/0404.xhp
@@ -73,11 +73,11 @@
 Choose Insert - Field - More Fields - 
DocInformation tab
 Choose Insert - Field - More Fields - Variables 
tab
 Choose Insert - Field - More Fields - Database 
tab
-
+
 Choose 
Insert - Section
 
 Open 
Insert toolbar, click
-
+
 
 
 
diff --git a/source/text/swriter/01/0402.xhp 
b/source/text/swriter/01/0402.xhp
index c01e44164..d8a5b999c 100644
--- a/source/text/swriter/01/0402.xhp
+++ b/source/text/swriter/01/0402.xhp
@@ -35,7 +35,7 @@
 Inserts a text section at the cursor 
position in the document. You can also select a block of text and then choose 
this command to create a section. You can use sections to insert blocks of text 
from other documents, to apply custom column layouts, or to protect or to hide 
blocks of text if a condition is met.
 
 
-  
+  
 
 You can insert 
an entire document in a section, or a named section from another. You can also 
insert a section as a DDE link.
 To edit a 
section, choose Format - Sections.
diff --git a/source/text/swriter/02/1801.xhp 
b/source/text/swriter/02/1801.xhp
index f2c9f830d..f6b587f5e 100644
--- a/source/text/swriter/02/1801.xhp
+++ b/source/text/swriter/02/1801.xhp
@@ -40,7 +40,7 @@
 
 Section
 
-
+
 Insert Frame 
Manually
 
 
diff --git a/source/text/swriter/02/1903.xhp 
b/source/text/swriter/02/1903.xhp
index 6f3d71f84..7d57724b5 100644
--- a/source/text/swriter/02/1903.xhp
+++ b/source/text/swriter/02/1903.xhp
@@ -65,7 +65,7 @@
 
 Insert 
Section
 
-
+
 Insert 
Bookmark

[Libreoffice-bugs] [Bug 132643] [LOCALHELP] Translate section id to English mnemonics

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=132643

--- Comment #739 from Commit Notification 
 ---
Johnny_M committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/13bc989cc1e90d627387bf4a4b18804662c1f8eb

tdf#132643 Translate German section IDs

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: helpcontent2

2022-02-26 Thread Johnny_M (via logerrit)

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f503e567f8fc6ead3d280686b8a1d020653bd114
Author: Johnny_M 
AuthorDate: Sat Feb 26 22:52:26 2022 +0100
Commit: Gerrit Code Review 
CommitDate: Sat Feb 26 22:52:26 2022 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 13bc989cc1e90d627387bf4a4b18804662c1f8eb
  - tdf#132643 Translate German section IDs

Change-Id: Iec56c3f7338fb8abbdfdd5bbb118fd10b10df616
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130583
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 24d491106fb6..13bc989cc1e9 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 24d491106fb6efa1e226551b8ca92264b1a09281
+Subproject commit 13bc989cc1e90d627387bf4a4b18804662c1f8eb

[Libreoffice-commits] help.git: source/text

2022-02-26 Thread Johnny_M (via logerrit)

 source/text/swriter/00/0404.xhp |2 +-
 source/text/swriter/01/04090002.xhp |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 13bc989cc1e90d627387bf4a4b18804662c1f8eb
Author: Johnny_M 
AuthorDate: Sat Feb 26 12:16:05 2022 +0100
Commit: Olivier Hallot 
CommitDate: Sat Feb 26 22:52:24 2022 +0100

tdf#132643 Translate German section IDs

Change-Id: Iec56c3f7338fb8abbdfdd5bbb118fd10b10df616
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130583
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/swriter/00/0404.xhp 
b/source/text/swriter/00/0404.xhp
index 32f444349..f625f158a 100644
--- a/source/text/swriter/00/0404.xhp
+++ b/source/text/swriter/00/0404.xhp
@@ -65,7 +65,7 @@
 
 
 Choose Insert - Field - More Fields - Document 
tab
-
+
 Choose 
Insert - Field - More Fields - Cross-references tab
 Choose 
Insert - Cross-reference
 
diff --git a/source/text/swriter/01/04090002.xhp 
b/source/text/swriter/01/04090002.xhp
index dc08ab08f..513b5fcc7 100644
--- a/source/text/swriter/01/04090002.xhp
+++ b/source/text/swriter/01/04090002.xhp
@@ -38,7 +38,7 @@
 The advantage 
of entering a cross-reference as a field is that you do not have to adjust the 
references manually every time you change the document. Just update the fields 
with F9 and the references in the document are updated too.
 
 
-
+

[Libreoffice-bugs] [Bug 147675] Writer discards table manual formatting and styling

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147675

--- Comment #1 from Eyal Rozenberg  ---
(In reply to Eyal Rozenberg from comment #0)


... and now this has happened to me when editing the table itself - adding a
column.

LO version:

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 250e4886d85a7e131da76f181b3fa7be02d1a76d
CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-IL (en_IL); UI: en-US

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147652] Convert-to isn’t working in Debian 9, Libreoffice 7.3

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147652

--- Comment #7 from Joshua Coppersmith  ---
RE: Regression/Progression: Cannot replicate with LO 7.2.5 on Debian 11 for
conversion from ods to xlsx. The xlsx version of the file pops up as expected.

Note: Any deviation where requested source file does not exist will result in
quiet failure, identical to result in bug report.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147675] New: Writer discards table manual formatting and styling

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147675

Bug ID: 147675
   Summary: Writer discards table manual formatting and styling
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: eyalr...@gmx.com

I'm working on a large-sih document important from MS word, which has a table.
I've Cleared the manual styling on it, then proceeded to set some paragraph
styles and also apply some manual formatting: Font, alignment, direction
(unfortunately the paragraph style's default direction seems to be ignored, but
that's another unrelated bug).

Anyway, as I was editing some text before this table, causing it to move
upwards or downwards, suddenly - the font changes to the default font size of
the Default Paragraph Style font; the alignment switches from Right to Left for
some reason (I was using Right, with RTL paragraphs, and it switches to Left);
and boldface'ing is lost. Spacing before and after the paragraph does not
change.

Selecting and applying  "no character style" does nothing. Selecting and
re-applying the paragraph style the different cells are reported to have -
changes the formatting to that of the paragraph style.

This has already happened to me twice today.

Luckily, no text is actually lost, only formatting. Annoying!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147674] New: Generated bullet styles should not be have the WW8Num name prefix

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147674

Bug ID: 147674
   Summary: Generated bullet styles should not be have the WW8Num
name prefix
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: filters and storage
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: eyalr...@gmx.com

When a .doc file is imported into LO (writer), several numbering styles are
auto-generated (I suppose they're based on some kind of anonymous styles in
MS-Word of manually-formatted numbered lists). These are given the names:
WW8Num01, WW8Num02 etc. Perhaps in some cases the prefix is WW7Num or something
similar.

The thing is, the same prefix is used both for _numbering_ styles and for
_bulleted list_ styles.

At the very list the styles should be WW8Num and WW8Bul. 

It would be even better if other features of the style would also be reflected
in the name somehow, to better differentiate the generic names.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: LibreOffice Digest, Vol 138, Issue 28

2022-02-26 Thread Ilmari Lauhakangas

Just follow the instructions on 
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Ilmari

On 26.2.2022 22.23, Abdelghani Sbai Idrissi wrote:

Hi,

Can you please remove me from your mailing list?

Thank you

Le mer. 23 févr. 2022 à 10:53, 
> a écrit :


Send LibreOffice mailing list submissions to
libreoffice@lists.freedesktop.org


To subscribe or unsubscribe via the World Wide Web, visit
https://lists.freedesktop.org/mailman/listinfo/libreoffice

or, via email, send a message with subject or body 'help' to
libreoffice-requ...@lists.freedesktop.org


You can reach the person managing the list at
libreoffice-ow...@lists.freedesktop.org


When replying, please edit your Subject line so it is more specific
than "Re: Contents of LibreOffice digest..."


Today's Topics:

    1. ESC meeting agenda: 2022-02-24 16:00 Berlin time (Miklos Vajna)


--

Message: 1
Date: Wed, 23 Feb 2022 16:53:15 +0100
From: Miklos Vajna mailto:vmik...@collabora.com>>
To: libreoffice@lists.freedesktop.org

Cc: libreoffice...@lists.freedesktop.org

Subject: ESC meeting agenda: 2022-02-24 16:00 Berlin time
Message-ID: mailto:yhzya9w149ucc...@collabora.com>>
Content-Type: text/plain; charset="utf-8"; Format="flowed"

Hi,

The prototype agenda is below. Extra items are appreciated either in
this document or as a reply to this mail:

https://pad.documentfoundation.org/p/esc


You can join using Jitsi here:

https://jitsi.documentfoundation.org/esc


Regards,

Miklos



* Present:
      +

* Completed Action Items:
      + None

* Pending Action Items:
      + add a note to the
https://wiki.documentfoundation.org/Development/Environment_variables 

wiki page to have prefixes (to prevent collision) + think twice
before adding a new one (Hossein)
      + go back to have a prefix for NO_QUERYSAVE (Heiko)

* Release Engineering update (Cloph)
      + 7.3 status: 7.3.1 rc2
      + 7.2 status: 7.2.6 rc2
      + Remotes: Android, iOS
      + Android viewer

* Documentation (Olivier)
      + Bugzilla Documentation statistics
          240(240) bugs open
      + Updates:
          BZ changes   1 week    1 month    3 months   12 months
             created     12(-3)     46(-5)    126(1)      331(-2)
           commented     15(-19)   117(-39)   421(-33)   1650(-2)
            resolved      3(-1)     15(-2)     61(2)      202(1)
      + top 10 contributors:
            Olivier Hallot made 71 changes in 1 month, and 585
changes in 1 year
            Heiko Tietze made 22 changes in 1 month, and 86 changes
in 1 year
            Kaganski, Mike made 15 changes in 1 month, and 100
changes in 1 year
            Rafael Lima made 13 changes in 1 month, and 372 changes
in 1 year
            Nabet, Julien made 13 changes in 1 month, and 62 changes
in 1 year
            Xisco Fauli made 11 changes in 1 month, and 91 changes
in 1 year
            Michael Warner made 9 changes in 1 month, and 10 changes
in 1 year
            Seth Chaiklin made 8 changes in 1 month, and 123 changes
in 1 year
            Alain Romedenne made 6 changes in 1 month, and 35
changes in 1 year
            St?phane Guillou made 6 changes in 1 month, and 30
changes in 1 year

* UX Update (Heiko)
      + Bugzilla (topicUI) statistics
          260(260) (topicUI) bugs open, 96(96) (needsUXEval) needs
to be evaluated by the UXteam
      + Updates:
          BZ changes   1 week   1 month   3 months   12 months
               added      4(2)     10(2)     15(2)       58(-3)
           commented     52(-3)   241(8)    656(7)     2804(-6)
             removed      2(-1)     6(-1)    13(1)       36(1)
            resolved      7(-7)    48(0)    107(2)      402(-1)
      + top 10 contributors:
            Heiko Tietze made 246 changes in 1 month, and 1941
changes in 1 year
            Seth Chaiklin made 26 changes in 1 month, and 129
changes in 1 year
            Foote, V Stuart made 20 changes in 1 month, and 479
changes in 1 year
            Dieter made 17 changes in 1 month, and 255 changes in 1 year
            Rafael Lima made 16

[Libreoffice-bugs] [Bug 147673] New: LO seems to import/generate unused MS Word numbering styles

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147673

Bug ID: 147673
   Summary: LO seems to import/generate unused MS Word numbering
styles
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: filters and storage
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: eyalr...@gmx.com

Description:
I have this large .doc file which I imported into LO Writer (unfortunately I
can't share it here). When importing this file, the import filter generates 40
(!) different numbering styles; however, when I view the "applied styles", I
only see 14 or 15 of these.

Now, if it were some named style which was stored in the MS-Word file and
imported, then - fine, I can live with that. But these are styles named:
WW8Num01, WW8Num02, etc - so, these must be generated based on anonymous styles
or manually-applied formatting.

I claim that no such style should be generated unless some text in the imported
document actually uses it. Alternatively, if a style is generated in a
preliminary step, and it is then determined the style is not in use - it should
be deleted.

As for the minimum affected version - I remember this since forever, but I
haven't actually checked. It's probably inherited from Open Office.


Actual Results:


Expected Results:



Reproducible: Always


User Profile Reset: No



Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/source

2022-02-26 Thread Luboš Luňák (via logerrit)

 sc/source/core/data/fillinfo.cxx |9 +++--
 1 file changed, 7 insertions(+), 2 deletions(-)

New commits:
commit 17db94f1e8425d6ccd430eeda3ec17b4acd1a3d9
Author: Luboš Luňák 
AuthorDate: Sat Feb 26 12:08:50 2022 +0100
Commit: Luboš Luňák 
CommitDate: Sat Feb 26 22:22:53 2022 +0100

do not repeatedly call ColHidden()

The function returns the last column that has the same return value,
so reuse the return value until that column.

Change-Id: I5d19478ee37068049d4ff035efcacdb5eb724e15
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130606
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/sc/source/core/data/fillinfo.cxx b/sc/source/core/data/fillinfo.cxx
index db18514b7120..2dc6fbdb7ebe 100644
--- a/sc/source/core/data/fillinfo.cxx
+++ b/sc/source/core/data/fillinfo.cxx
@@ -413,6 +413,8 @@ void ScDocument::FillInfo(
 if (pCondFormList)
 pCondFormList->startRendering();
 
+SCCOL nLastHiddenCheckedCol = -2;
+bool bColHidden = false;
 for (SCCOL nCol=-1; nCol<=nCol2+1; nCol++)// left & 
right + 1
 {
 if (ValidCol(nCol))
@@ -420,10 +422,13 @@ void ScDocument::FillInfo(
 // #i58049#, #i57939# Hidden columns must be skipped here, or 
their attributes
 // will disturb the output
 
+if (nCol > nLastHiddenCheckedCol)
+bColHidden = ColHidden(nCol, nTab, nullptr, 
);
 // TODO: Optimize this loop.
-if (!ColHidden(nCol, nTab))
+if (!bColHidden)
 {
-sal_uInt16 nThisWidth = 
static_cast(std::clamp(GetColWidth( nCol, nTab ) * fColScale, 1.0, 
double(std::numeric_limits::max(;
+sal_uInt16 nColWidth = GetColWidth( nCol, nTab, false ); // 
false=no need to check for hidden, checked above
+sal_uInt16 nThisWidth = 
static_cast(std::clamp(nColWidth * fColScale, 1.0, 
double(std::numeric_limits::max(;
 
 pRowInfo[0].cellInfo(nCol).nWidth = nThisWidth;   
//TODO: this should be enough

[Libreoffice-bugs] [Bug 147672] New: Crash in: SwContentNode::GetAttr(SfxItemSet &) fails during Spell-Check Editing

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147672

Bug ID: 147672
   Summary: Crash in: SwContentNode::GetAttr(SfxItemSet &)  fails
during Spell-Check Editing
   Product: LibreOffice
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: agenceli...@gmail.com

This bug was filed from the crash reporting server and is
br-d24abce4-b957-4757-9a1f-f59a1e8a25a0.
=

Every time I check spelling it gets to the fourth or fifth word that I either
leave or change and away it goes -

NB it may have conflicted with an unscheduled background windows update
installation or a failed Backup attempt? the only thing I can find in the event
viewer. It failed three times in a row. Have since tried using spellcheck and 
1 - it won't load text language and 
2 - it highlights blank section and
3 - it provides no suggestions for correction.

I updated LO a few days ago and now it is misbehaving.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147382] LibreOffice 7.3 Calc crashes after I click the icon. The crash includes a "send crash report" screen.

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147382

--- Comment #2 from lmart...@yahoo.com  ---
Created attachment 178563
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178563=edit
Crash message screenshot

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147661] formatting: vertical fraction feature present in font not applied by Writer

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147661

Julien Nabet  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #7 from Julien Nabet  ---
Thank you for your feedback. I could reproduce the pb => let's put this one to
NEW.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: LibreOffice Digest, Vol 138, Issue 28

2022-02-26 Thread Abdelghani Sbai Idrissi

Hi,

Can you please remove me from your mailing list?

Thank you

Le mer. 23 févr. 2022 à 10:53, 
a écrit :

> Send LibreOffice mailing list submissions to
> libreoffice@lists.freedesktop.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
> https://lists.freedesktop.org/mailman/listinfo/libreoffice
> or, via email, send a message with subject or body 'help' to
> libreoffice-requ...@lists.freedesktop.org
>
> You can reach the person managing the list at
> libreoffice-ow...@lists.freedesktop.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of LibreOffice digest..."
>
>
> Today's Topics:
>
>1. ESC meeting agenda: 2022-02-24 16:00 Berlin time (Miklos Vajna)
>
>
> --
>
> Message: 1
> Date: Wed, 23 Feb 2022 16:53:15 +0100
> From: Miklos Vajna 
> To: libreoffice@lists.freedesktop.org
> Cc: libreoffice...@lists.freedesktop.org
> Subject: ESC meeting agenda: 2022-02-24 16:00 Berlin time
> Message-ID: 
> Content-Type: text/plain; charset="utf-8"; Format="flowed"
>
> Hi,
>
> The prototype agenda is below. Extra items are appreciated either in
> this document or as a reply to this mail:
>
> https://pad.documentfoundation.org/p/esc
>
> You can join using Jitsi here:
>
> https://jitsi.documentfoundation.org/esc
>
> Regards,
>
> Miklos
>
> 
>
> * Present:
>  +
>
> * Completed Action Items:
>  + None
>
> * Pending Action Items:
>  + add a note to the
> https://wiki.documentfoundation.org/Development/Environment_variables
> wiki page to have prefixes (to prevent collision) + think twice before
> adding a new one (Hossein)
>  + go back to have a prefix for NO_QUERYSAVE (Heiko)
>
> * Release Engineering update (Cloph)
>  + 7.3 status: 7.3.1 rc2
>  + 7.2 status: 7.2.6 rc2
>  + Remotes: Android, iOS
>  + Android viewer
>
> * Documentation (Olivier)
>  + Bugzilla Documentation statistics
>  240(240) bugs open
>  + Updates:
>  BZ changes   1 week1 month3 months   12 months
> created 12(-3) 46(-5)126(1)  331(-2)
>   commented 15(-19)   117(-39)   421(-33)   1650(-2)
>resolved  3(-1) 15(-2) 61(2)  202(1)
>  + top 10 contributors:
>Olivier Hallot made 71 changes in 1 month, and 585 changes in 1
> year
>Heiko Tietze made 22 changes in 1 month, and 86 changes in 1
> year
>Kaganski, Mike made 15 changes in 1 month, and 100 changes in 1
> year
>Rafael Lima made 13 changes in 1 month, and 372 changes in 1
> year
>Nabet, Julien made 13 changes in 1 month, and 62 changes in 1
> year
>Xisco Fauli made 11 changes in 1 month, and 91 changes in 1 year
>Michael Warner made 9 changes in 1 month, and 10 changes in 1
> year
>Seth Chaiklin made 8 changes in 1 month, and 123 changes in 1
> year
>Alain Romedenne made 6 changes in 1 month, and 35 changes in 1
> year
>St?phane Guillou made 6 changes in 1 month, and 30 changes in 1
> year
>
> * UX Update (Heiko)
>  + Bugzilla (topicUI) statistics
>  260(260) (topicUI) bugs open, 96(96) (needsUXEval) needs to be
> evaluated by the UXteam
>  + Updates:
>  BZ changes   1 week   1 month   3 months   12 months
>   added  4(2) 10(2) 15(2)   58(-3)
>   commented 52(-3)   241(8)656(7) 2804(-6)
> removed  2(-1) 6(-1)13(1)   36(1)
>resolved  7(-7)48(0)107(2)  402(-1)
>  + top 10 contributors:
>Heiko Tietze made 246 changes in 1 month, and 1941 changes in 1
> year
>Seth Chaiklin made 26 changes in 1 month, and 129 changes in 1
> year
>Foote, V Stuart made 20 changes in 1 month, and 479 changes in
> 1 year
>Dieter made 17 changes in 1 month, and 255 changes in 1 year
>Rafael Lima made 16 changes in 1 month, and 52 changes in 1 year
>Ilmari Lauhakangas made 14 changes in 1 month, and 295 changes
> in 1 year
>kabilo made 12 changes in 1 month, and 21 changes in 1 year
>Thomas Lendo made 11 changes in 1 month, and 40 changes in 1
> year
>*UNKNOWN* made 10 changes in 1 month, and 10 changes in 1 year
>Albrecht M?ller made 9 changes in 1 month, and 11 changes in 1
> year
>
> * Crash Testing (Caolan)
>  + 13(+0) import failure, 6(+0) export failures
>  + ??? coverity issues
>  + Google / ossfuzz: ?? fuzzers active now
>
> * Crash Reporting (Xisco)
>  + 7.2.5.120(+0)
>  + 7.2.5.219023(+3396)
>  + 7.3.0.2110(+4)
>  + 7.3.0.39900(+3875)
>
> * Mentoring/EasyHack update (Hossein)
>committer...   1 week 1 month 3 months12 months
>open  97(50) 146(52) 177(27)

[Libreoffice-bugs] [Bug 53023] AutoText (text only) embeds extra carriage return

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=53023

--- Comment #18 from Regina Henschel  ---
*** Bug 147670 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147670] Autotext entry saved with extra paragraph break

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147670

Regina Henschel  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE
 CC||rb.hensc...@t-online.de

--- Comment #1 from Regina Henschel  ---
It is the still unsolved bug 53023.

*** This bug has been marked as a duplicate of bug 53023 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: hwpfilter/source

2022-02-26 Thread Caolán McNamara (via logerrit)

 hwpfilter/source/hbox.cxx |7 +++
 hwpfilter/source/hbox.h   |2 +-
 2 files changed, 8 insertions(+), 1 deletion(-)

New commits:
commit f6a9910623cdeb30b7c0a8dc712153a11658e43d
Author: Caolán McNamara 
AuthorDate: Sat Feb 26 16:10:09 2022 +
Commit: Caolán McNamara 
CommitDate: Sat Feb 26 21:05:49 2022 +0100

ofz#44991 Use-of-uninitialized-value

Change-Id: I0e3bcce489b665bac3e470e743394935a2ba3a18
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130601
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/hwpfilter/source/hbox.cxx b/hwpfilter/source/hbox.cxx
index 6bbf6d22448b..f9c1542b7cab 100644
--- a/hwpfilter/source/hbox.cxx
+++ b/hwpfilter/source/hbox.cxx
@@ -107,6 +107,8 @@ DateFormat::DateFormat()
 // date code(8)
 DateCode::DateCode()
 : HBox(CH_DATE_CODE)
+, format{0}
+, date{0}
 , dummy(0)
 , key(0)
 {
@@ -344,6 +346,7 @@ TxtBox::~TxtBox()
 
 Picture::Picture()
 : FBox(CH_PICTURE)
+, reserved{0}
 , dummy(0)
 , follow_block_size(0)
 , dummy1(0)
@@ -352,6 +355,10 @@ Picture::Picture()
 , cap_pos(0)
 , num(0)
 , pictype(0)
+, skip{0}
+, scale{0}
+, picinfo{}
+, reserved3{0}
 , ishyper(false)
 {
 }
diff --git a/hwpfilter/source/hbox.h b/hwpfilter/source/hbox.h
index 869fedd8ba90..afc208f956e0 100644
--- a/hwpfilter/source/hbox.h
+++ b/hwpfilter/source/hbox.h
@@ -617,7 +617,7 @@ struct Picture: public FBox
  * Ratio of magnification or reduction.
  */
 hunit scale[2];
-PicDefpicinfo = {};
+PicDefpicinfo;
 char  reserved3[9];
 
 std::vector> caption;

Re: Overview of variable naming conventions

2022-02-26 Thread Mike Kaganski


On 26.02.2022 20:48, Luboš Luňák wrote:

On Saturday 26 of February 2022, Jan Rheinlc3a4nder wrote:

Hi,

is there somewhere a key to naming variables?


  'm' is member, 'r' is reference, 'p' is pointer, 'x' is UNO reference, 'a' is
array (or string), 's' is string, 'e' is enum, 'n' is number, 'b' is bool. Or
maybe not, since in a number of variables it's wrong.

  I personally consider 'm' to be the only one useful and the rest is garbage
that gets in the way and can be ignored.



I also consider 'm' useful; but also I consider 'x' highly useful when 
used properly (i.e., only for UNO interfaces, making it easy to se which 
methodology of handling is for them), and also 'p' (for pointers), 'o' 
(newly introduced for optionals), and 'r' for references. This 
information is very handy at a glance, since you can tell if changing an 
'r' is expected to have effects elsewhere, and if some 'oString' is a 
string or just "maybe a string".



--
Best regards,
Mike Kaganski

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3-1' - sc/inc

2022-02-26 Thread Eike Rathke (via logerrit)

 sc/inc/refreshtimer.hxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit a6dc1d415492c160551dd98bad1cd4c116f136eb
Author: Eike Rathke 
AuthorDate: Sat Feb 26 01:57:51 2022 +0100
Commit: Mike Kaganski 
CommitDate: Sat Feb 26 20:12:51 2022 +0100

Resolves: tdf#147448 ScRefreshTimerControl mutex must be 
std::recursive_mutex

ScRefreshTimer::Invoke() locks the mutex and subsequent nested
locks are attempted in ScDocShell::ConvertFrom() and
ScDocShellModificator ctor by ScRefreshTimerProtector.

A std::mutex must not be owned by the calling thread when a lock
is attempted, otherwise even deadlocks may occur, as was the case
here. This is exactly the difference of std::recursive_mutex.

Likely a regression from

commit 287680683ca266f1fb4f447ac9bdaf76669d559d
CommitDate: Mon Aug 2 12:17:07 2021 +0200

osl::Mutex->std::mutex in ScRefreshTimer

Change-Id: Iaa0f1da2b4b9616e9627d8d0001775f554756048
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130573
Reviewed-by: Eike Rathke 
Tested-by: Jenkins
(cherry picked from commit 4361ee2585e616cb3c504eb719deca4076de78da)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130552
Reviewed-by: Luboš Luňák 
Reviewed-by: Mike Kaganski 
Tested-by: Mike Kaganski 

diff --git a/sc/inc/refreshtimer.hxx b/sc/inc/refreshtimer.hxx
index 9582d1b19a2c..e6be7431d9e5 100644
--- a/sc/inc/refreshtimer.hxx
+++ b/sc/inc/refreshtimer.hxx
@@ -29,14 +29,14 @@
 
 class ScRefreshTimerControl
 {
-std::mutex  aMutex;
-sal_uInt16  nBlockRefresh;
+std::recursive_mutexaMutex;
+sal_uInt16  nBlockRefresh;
 
 public:
 ScRefreshTimerControl() : nBlockRefresh(0) {}
 void SetAllowRefresh( bool b );
 bool IsRefreshAllowed() const { return !nBlockRefresh; }
-std::mutex& GetMutex() { return aMutex; }
+std::recursive_mutex& GetMutex() { return aMutex; }
 };
 
 class ScRefreshTimer : public AutoTimer

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sc/source

2022-02-26 Thread Eike Rathke (via logerrit)

 sc/source/core/data/documen2.cxx |6 +-
 1 file changed, 1 insertion(+), 5 deletions(-)

New commits:
commit 7aae1d338aaf454b99c7354aca78951e26043b2b
Author: Eike Rathke 
AuthorDate: Sat Feb 26 17:52:29 2022 +0100
Commit: Caolán McNamara 
CommitDate: Sat Feb 26 20:07:38 2022 +0100

Revert "Related: tdf#147448 Scope owning mutex before it gets destroyed"

This reverts commit dcd042c6f28276d707af409a87a1a4380398e9b0.

Reason for revert:
Revisiting, it was wrong to put that protector in its own scope because the 
actual mutex lock is only held in its ctor and it does SetAllowRefresh(true) in 
dtor, so while it exists it prevents other refresh timers to execute.

Change-Id: I058c1359c19971dba59a9273a7a8cddd77ece37f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130556
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sc/source/core/data/documen2.cxx b/sc/source/core/data/documen2.cxx
index 6cfae1502c17..9a3a2fb1ce0f 100644
--- a/sc/source/core/data/documen2.cxx
+++ b/sc/source/core/data/documen2.cxx
@@ -337,11 +337,7 @@ ScDocument::~ScDocument()
 if ( pRefreshTimerControl )
 {   // To be sure there isn't anything running do it with a protector,
 // this ensures also that nothing needs the control anymore.
-{
-// Use a scope on its own because it is undefined behaviour if a
-// mutex is destroyed while still owned.
-ScRefreshTimerProtector aProt( GetRefreshTimerControlAddress() );
-}
+ScRefreshTimerProtector aProt( GetRefreshTimerControlAddress() );
 pRefreshTimerControl.reset();
 }

[Libreoffice-commits] core.git: vcl/source

2022-02-26 Thread Caolán McNamara (via logerrit)

 vcl/source/gdi/impanmvw.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit e58d1b535bd7f0e30d41d72242cfe9f41ce8cd19
Author: Caolán McNamara 
AuthorDate: Sat Feb 26 15:31:59 2022 +
Commit: Caolán McNamara 
CommitDate: Sat Feb 26 20:06:04 2022 +0100

cid#708598 Uninitialized scalar field

Change-Id: I35ee291afe6af5a20e7fca3e03af9cbc0d1d6b32
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130600
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/source/gdi/impanmvw.cxx b/vcl/source/gdi/impanmvw.cxx
index 5757d3d36e5c..00a02912abc1 100644
--- a/vcl/source/gdi/impanmvw.cxx
+++ b/vcl/source/gdi/impanmvw.cxx
@@ -39,6 +39,7 @@ ImplAnimView::ImplAnimView( Animation* pParent, OutputDevice* 
pOut,
 maClip  ( mpRenderContext->GetClipRegion() ),
 mpBackground( VclPtr::Create() ),
 mpRestore   ( VclPtr::Create() ),
+mnActPos( 0 ),
 meLastDisposal  ( Disposal::Back ),
 mbIsPaused  ( false ),
 mbIsMarked  ( false ),

[Libreoffice-commits] core.git: 2 commits - sd/source vcl/source

2022-02-26 Thread Caolán McNamara (via logerrit)

 sd/source/filter/eppt/pptx-text.cxx |1 +
 vcl/source/control/prgsbar.cxx  |3 +++
 2 files changed, 4 insertions(+)

New commits:
commit d4bb147320f381010f25c9232f4147406c443fbf
Author: Caolán McNamara 
AuthorDate: Sat Feb 26 15:30:43 2022 +
Commit: Caolán McNamara 
CommitDate: Sat Feb 26 20:05:51 2022 +0100

cid#1362689 Uninitialized scalar field

Change-Id: I14bb8fce8bb2d8aa744463da4a065dec6a15f3ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130599
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sd/source/filter/eppt/pptx-text.cxx 
b/sd/source/filter/eppt/pptx-text.cxx
index 4fad12a0871b..85c37f77d729 100644
--- a/sd/source/filter/eppt/pptx-text.cxx
+++ b/sd/source/filter/eppt/pptx-text.cxx
@@ -68,6 +68,7 @@ PortionObj::PortionObj(const css::uno::Reference< 
css::beans::XPropertySet > & r
 , meAsianOrComplexFont(css::beans::PropertyState_AMBIGUOUS_VALUE)
 , meCharEscapement(css::beans::PropertyState_AMBIGUOUS_VALUE)
 , mnCharAttrHard(0)
+, mnCharColor(0)
 , mnCharAttr(0)
 , mnFont(0)
 , mnAsianOrComplexFont(0x)
commit 9c6a2a63fcca8d60f19e40d7c7125c38ee943ca0
Author: Caolán McNamara 
AuthorDate: Sat Feb 26 15:29:05 2022 +
Commit: Caolán McNamara 
CommitDate: Sat Feb 26 20:05:34 2022 +0100

cid#1500406 Uninitialized scalar field

Change-Id: I1e2de80f8943d2bfe288b8ddcabd376561269d24
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130598
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/source/control/prgsbar.cxx b/vcl/source/control/prgsbar.cxx
index eabd2b29e942..6b7a7007c599 100644
--- a/vcl/source/control/prgsbar.cxx
+++ b/vcl/source/control/prgsbar.cxx
@@ -30,7 +30,10 @@
 
 void ProgressBar::ImplInit()
 {
+mnPrgsWidth = 0;
+mnPrgsHeight = 0;
 mnPercent = 0;
+mnPercentCount = 0;
 mbCalcNew = true;
 
 ImplInitSettings( true, true, true );

[Libreoffice-commits] core.git: 2 commits - sc/source sw/source

2022-02-26 Thread Caolán McNamara (via logerrit)

 sc/source/ui/undo/undodat.cxx  |2 ++
 sw/source/uibase/config/modcfg.cxx |5 +++--
 2 files changed, 5 insertions(+), 2 deletions(-)

New commits:
commit 2e2bd25b4a13758745aa9ae687c5d94a0f32bb6e
Author: Caolán McNamara 
AuthorDate: Sat Feb 26 15:25:47 2022 +
Commit: Caolán McNamara 
CommitDate: Sat Feb 26 20:05:21 2022 +0100

cid#1500566 Uninitialized scalar field

Change-Id: Idd0e3d461f84a5ec476d77fde9c8ab03b4dbbbd0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130597
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sc/source/ui/undo/undodat.cxx b/sc/source/ui/undo/undodat.cxx
index 5fdf3917aa6b..006527d7bacd 100644
--- a/sc/source/ui/undo/undodat.cxx
+++ b/sc/source/ui/undo/undodat.cxx
@@ -1690,6 +1690,8 @@ ScUndoChartData::ScUndoChartData( ScDocShell* 
pNewDocShell, const OUString& rNam
 bool bAdd ) :
 ScSimpleUndo( pNewDocShell ),
 aChartName( rName ),
+bOldColHeaders(false),
+bOldRowHeaders(false),
 bNewColHeaders( bColHdr ),
 bNewRowHeaders( bRowHdr ),
 bAddRange( bAdd )
commit 50cd7345dbafdf612f796fad8083e7ec0c7ace0c
Author: Caolán McNamara 
AuthorDate: Sat Feb 26 15:24:15 2022 +
Commit: Caolán McNamara 
CommitDate: Sat Feb 26 20:05:09 2022 +0100

cid#1500568 Uninitialized scalar field

Change-Id: I0d6fb3b378d890daf5efbef588fdb0fe40fb625d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130596
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sw/source/uibase/config/modcfg.cxx 
b/sw/source/uibase/config/modcfg.cxx
index 3f690795b41d..2b80d8127b74 100644
--- a/sw/source/uibase/config/modcfg.cxx
+++ b/sw/source/uibase/config/modcfg.cxx
@@ -229,8 +229,9 @@ const Sequence& 
SwRevisionConfig::GetPropertyNames()
 return aNames;
 }
 
-SwRevisionConfig::SwRevisionConfig() :
-ConfigItem("Office.Writer/Revision", ConfigItemMode::ReleaseTree)
+SwRevisionConfig::SwRevisionConfig()
+: ConfigItem("Office.Writer/Revision", ConfigItemMode::ReleaseTree)
+, m_nMarkAlign(0)
 {
 m_aInsertAttr.m_nItemId = SID_ATTR_CHAR_UNDERLINE;
 m_aInsertAttr.m_nAttr = LINESTYLE_SINGLE;

[Libreoffice-commits] core.git: 2 commits - sd/source vcl/source

2022-02-26 Thread Caolán McNamara (via logerrit)

 sd/source/filter/eppt/pptx-text.cxx |1 +
 vcl/source/gdi/virdev.cxx   |3 +++
 2 files changed, 4 insertions(+)

New commits:
commit caf833b67c03c419322c88732d4eed7cdaf55cc0
Author: Caolán McNamara 
AuthorDate: Sat Feb 26 15:22:41 2022 +
Commit: Caolán McNamara 
CommitDate: Sat Feb 26 20:04:55 2022 +0100

cid#1500598 Uninitialized scalar field

Change-Id: I732117dae2b383356dc58b5f47e52f6e722e991d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130595
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sd/source/filter/eppt/pptx-text.cxx 
b/sd/source/filter/eppt/pptx-text.cxx
index 14b760e4d3e7..4fad12a0871b 100644
--- a/sd/source/filter/eppt/pptx-text.cxx
+++ b/sd/source/filter/eppt/pptx-text.cxx
@@ -651,6 +651,7 @@ ParagraphObj::ParagraphObj(const css::uno::Reference< 
css::beans::XPropertySet >
 : mnTextSize(0)
 , mbFirstParagraph(false)
 , mbLastParagraph(false)
+, meBullet(css::beans::PropertyState_AMBIGUOUS_VALUE)
 , mnTextAdjust(0)
 , mnLineSpacing(0)
 , mbFixedLineSpacing(false)
commit b6b9c6ebf66c1fa8f35d82d149aa108d91a86ba0
Author: Caolán McNamara 
AuthorDate: Sat Feb 26 15:20:21 2022 +
Commit: Caolán McNamara 
CommitDate: Sat Feb 26 20:04:42 2022 +0100

cid#1500651 Uninitialized scalar field

Change-Id: If22e0931c13c6945640264c55edb1af52b2c4187
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130594
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/source/gdi/virdev.cxx b/vcl/source/gdi/virdev.cxx
index 87721c683d77..1aec06239913 100644
--- a/vcl/source/gdi/virdev.cxx
+++ b/vcl/source/gdi/virdev.cxx
@@ -129,6 +129,9 @@ void VirtualDevice::ImplInitVirDev( const OutputDevice* 
pOutDev,
 
 meRefDevMode = RefDevMode::NONE;
 mbForceZeroExtleadBug = false;
+mnBitCount = 0;
+mbScreenComp = false;
+
 
 bool bErase = nDX > 0 && nDY > 0;

[Libreoffice-commits] core.git: 2 commits - connectivity/source sc/source

2022-02-26 Thread Caolán McNamara (via logerrit)

 connectivity/source/inc/odbc/OResultSetMetaData.hxx |2 +-
 sc/source/ui/Accessibility/AccessibleDocument.cxx   |7 +++
 2 files changed, 4 insertions(+), 5 deletions(-)

New commits:
commit dc3d27c53e5c8149571025a031857973783a9248
Author: Caolán McNamara 
AuthorDate: Sat Feb 26 15:17:27 2022 +
Commit: Caolán McNamara 
CommitDate: Sat Feb 26 20:04:29 2022 +0100

cid#1500706 Uninitialized scalar field

Change-Id: I2546ea6880ad1cdb4312ca1c1251dbf6758ff5ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130593
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sc/source/ui/Accessibility/AccessibleDocument.cxx 
b/sc/source/ui/Accessibility/AccessibleDocument.cxx
index 1d58af05fe2a..21e3d1813a77 100644
--- a/sc/source/ui/Accessibility/AccessibleDocument.cxx
+++ b/sc/source/ui/Accessibility/AccessibleDocument.cxx
@@ -258,7 +258,6 @@ private:
 
 mutable ::accessibility::AccessibleShapeTreeInfo maShapeTreeInfo;
 mutable css::uno::Reference 
xSelectionSupplier;
-mutable size_t mnSdrObjCount;
 mutable sal_uInt32 mnShapesSelected;
 ScTabViewShell* mpViewShell;
 ScAccessibleDocument* mpAccessibleDocument;
@@ -499,9 +498,9 @@ sal_Int32 ScChildrenShapes::GetCount() const
 SdrPage* pDrawPage = GetDrawPage();
 if (pDrawPage && (maZOrderedShapes.size() == 1)) // the table is always in
 {
-mnSdrObjCount = pDrawPage->GetObjCount();
-maZOrderedShapes.reserve(mnSdrObjCount + 1); // the table is always in
-for (size_t i = 0; i < mnSdrObjCount; ++i)
+size_t nSdrObjCount = pDrawPage->GetObjCount();
+maZOrderedShapes.reserve(nSdrObjCount + 1); // the table is always in
+for (size_t i = 0; i < nSdrObjCount; ++i)
 {
 SdrObject* pObj = pDrawPage->GetObj(i);
 if (pObj/* && (pObj->GetLayer() != SC_LAYER_INTERN)*/)
commit 10d8ba5fa6fac708c960278454ba403a95e355c3
Author: Caolán McNamara 
AuthorDate: Sat Feb 26 15:12:37 2022 +
Commit: Caolán McNamara 
CommitDate: Sat Feb 26 20:04:16 2022 +0100

cid#1500433 Using a moved object

Change-Id: I150cd0f021aeb1aefe411f19dfcac111ac35b295
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130592
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/connectivity/source/inc/odbc/OResultSetMetaData.hxx 
b/connectivity/source/inc/odbc/OResultSetMetaData.hxx
index 6c1acc13bfb9..ea32a453e99a 100644
--- a/connectivity/source/inc/odbc/OResultSetMetaData.hxx
+++ b/connectivity/source/inc/odbc/OResultSetMetaData.hxx
@@ -62,7 +62,7 @@ namespace connectivity::odbc
 :m_vMapping(std::move(_vMapping))
 ,m_aStatementHandle( _pStmt )
 ,m_pConnection(_pConnection)
-,m_nColCount(_vMapping.size()-1)
+,m_nColCount(m_vMapping.size()-1)
 ,m_bUseODBC2Types(false)
 {}
 virtual ~OResultSetMetaData() override;

[Libreoffice-commits] core.git: 2 commits - sc/inc vcl/source

2022-02-26 Thread Caolán McNamara (via logerrit)

 sc/inc/sortparam.hxx   |8 
 vcl/source/filter/ixpm/xpmread.cxx |2 +-
 2 files changed, 9 insertions(+), 1 deletion(-)

New commits:
commit dfa791941ee13bd06adc91ed097c44b65a995a14
Author: Caolán McNamara 
AuthorDate: Sat Feb 26 15:09:08 2022 +
Commit: Caolán McNamara 
CommitDate: Sat Feb 26 20:04:02 2022 +0100

cid#1500582 Uninitialized scalar variable

Change-Id: Idec4ce43f99be60658a6e60cff73dd6702bb3d91
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130591
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sc/inc/sortparam.hxx b/sc/inc/sortparam.hxx
index d9047f873b1e..63d83e2c0595 100644
--- a/sc/inc/sortparam.hxx
+++ b/sc/inc/sortparam.hxx
@@ -165,6 +165,14 @@ struct ReorderParam
  * original reordering.
  */
 void reverse();
+
+ReorderParam()
+: mbByRow(false)
+, mbHiddenFiltered(false)
+, mbUpdateRefs(false)
+, mbHasHeaders(false)
+{
+}
 };
 
 }
commit ad4692357b2d32ab10301576031a60ff68b51482
Author: Caolán McNamara 
AuthorDate: Sat Feb 26 15:00:18 2022 +
Commit: Caolán McNamara 
CommitDate: Sat Feb 26 20:03:48 2022 +0100

cid#1500670 Uninitialized scalar variable

Change-Id: Ib4b873194c6db55212a5b786322b2a6d45277369
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130590
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/source/filter/ixpm/xpmread.cxx 
b/vcl/source/filter/ixpm/xpmread.cxx
index ace45f577826..2a979d2df238 100644
--- a/vcl/source/filter/ixpm/xpmread.cxx
+++ b/vcl/source/filter/ixpm/xpmread.cxx
@@ -288,7 +288,7 @@ bool XPMReader::ImplGetColor()
 return false;
 
 OString aKey(reinterpret_cast(pString), mnCpp);
-colordata aValue;
+colordata aValue{0};
 bool bStatus = ImplGetColSub(aValue);
 if (bStatus)
 {

[Libreoffice-commits] core.git: sc/source

2022-02-26 Thread Luboš Luňák (via logerrit)

 sc/source/core/data/column2.cxx |7 +++
 1 file changed, 3 insertions(+), 4 deletions(-)

New commits:
commit d2fea40762d5d9ee918edcb4ff281e362df92c5d
Author: Luboš Luňák 
AuthorDate: Sat Feb 26 11:16:16 2022 +0100
Commit: Luboš Luňák 
CommitDate: Sat Feb 26 19:55:19 2022 +0100

optimize ScColumns::HasCellNotes()

This probably doesn't matter much for optimized code, but in dbgutil
builds this avoids all the libstdc++ iterators mutex locking (WTH
does libstdc++ debug mode need to lock anything?). It's functionally
equivalent (similarly to ScColumn::IsEmptyData(), and the container
can contain only notes or empty elements), and cuts run time of e.g.
sc_uicalc test to about a half.

Change-Id: Ibb2bd8be522de889a8a06cbb7a4f880c9b065c71
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130604
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/sc/source/core/data/column2.cxx b/sc/source/core/data/column2.cxx
index c6be6f4ce8f2..f24ac6726495 100644
--- a/sc/source/core/data/column2.cxx
+++ b/sc/source/core/data/column2.cxx
@@ -2053,10 +2053,9 @@ void ScColumn::DeleteCellNotes( sc::ColumnBlockPosition& 
rBlockPos, SCROW nRow1,
 
 bool ScColumn::HasCellNotes() const
 {
-return std::any_of(maCellNotes.begin(), maCellNotes.end(),
-[](const auto& rCellNote) {
-// Having a cellnote block automatically means there is at least 
one cell note.
-return rCellNote.type == sc::element_type_cellnote; });
+if (maCellNotes.block_size() == 1 && maCellNotes.begin()->type == 
sc::element_type_empty)
+return false; // all elements are empty
+return true; // otherwise some must be notes
 }
 
 SCROW ScColumn::GetCellNotesMaxRow() const

[Libreoffice-commits] core.git: sc/inc

2022-02-26 Thread Luboš Luňák (via logerrit)

 sc/inc/compressedarray.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit dcf98b570fc33bc9ee3bdf5591c6cc92cfbf3aa1
Author: Luboš Luňák 
AuthorDate: Sat Feb 26 14:04:35 2022 +0100
Commit: Luboš Luňák 
CommitDate: Sat Feb 26 19:54:45 2022 +0100

ScCompressedArray doesn't need to be polymorphic

It's value-based, and only inherited by ScBitMaskCompressedArray,
which is also value-based and doesn't need a virtual destructor.

Change-Id: I0814702107d50208aaff19690c989a501d2c4e3f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130605
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/sc/inc/compressedarray.hxx b/sc/inc/compressedarray.hxx
index 010200068be5..d10db1269b6a 100644
--- a/sc/inc/compressedarray.hxx
+++ b/sc/inc/compressedarray.hxx
@@ -72,7 +72,7 @@ public:
 /** Construct with nMaxAccess=MAXROW, for example. */
 ScCompressedArray( A nMaxAccess,
 const D& rValue );
-virtual ~ScCompressedArray();
+~ScCompressedArray();
 voidReset( const D& rValue );
 voidSetValue( A nPos, const D& rValue );
 voidSetValue( A nStart, A nEnd, const D& rValue );

[Libreoffice-commits] core.git: sc/qa sc/source

2022-02-26 Thread Luboš Luňák (via logerrit)

 sc/source/ui/docshell/docsh.cxx |   42 ++--
 1 file changed, 28 insertions(+), 14 deletions(-)

New commits:
commit 61abbc2f9698f48bf92ec102952cd6b4fcc536d1
Author: Luboš Luňák 
AuthorDate: Thu Feb 24 16:26:09 2022 +0100
Commit: Luboš Luňák 
CommitDate: Sat Feb 26 19:54:20 2022 +0100

do not fail import if there are only warnings

When opening CVE-2012-4233-4.xls or ofz5527-1.xls in LO UI, they
show a warning about too many columns (presumably because Excel
as of now supports 16k and LO only 1k columns by default), but
besides stripping the extra columns they otherwise actually load
normally. But ScFiltersTest::testCVEs() fails loading them
just because of the warning. And if 16k columns are forced
for the tests, the files unexpectedly load fine, making the test
fail.

ScDocShell::ConvertFrom() is rather inconsistent on whether
only a warning results in a failed load or not, but most seem
not to return failure on only warnings, and I think that makes
sense, so make code paths for all formats consistently handle
it that way.

Change-Id: I202f29f5a5a44aecd34b84cf2f8180222e8d870a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130500
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/sc/qa/unit/data/xls/fail/CVE-2012-4233-4.xls 
b/sc/qa/unit/data/xls/pass/CVE-2012-4233-4.xls
similarity index 100%
rename from sc/qa/unit/data/xls/fail/CVE-2012-4233-4.xls
rename to sc/qa/unit/data/xls/pass/CVE-2012-4233-4.xls
diff --git a/sc/qa/unit/data/xls/fail/ofz5527-1.xls 
b/sc/qa/unit/data/xls/pass/ofz5527-1.xls
similarity index 100%
rename from sc/qa/unit/data/xls/fail/ofz5527-1.xls
rename to sc/qa/unit/data/xls/pass/ofz5527-1.xls
diff --git a/sc/source/ui/docshell/docsh.cxx b/sc/source/ui/docshell/docsh.cxx
index d30d4b89f236..5cfe7ee0b78b 100644
--- a/sc/source/ui/docshell/docsh.cxx
+++ b/sc/source/ui/docshell/docsh.cxx
@@ -1217,16 +1217,12 @@ bool ScDocShell::ConvertFrom( SfxMedium& rMedium )
 // all graphics objects must have names
 m_aDocument.EnsureGraphicNames();
 
-if (eError == SCWARN_IMPORT_RANGE_OVERFLOW)
-{
-if (!GetError())
-SetError(eError);
-bRet = true;
-}
-else if (eError != ERRCODE_NONE)
+if (eError != ERRCODE_NONE)
 {
 if (!GetError())
 SetError(eError);
+if( eError.IsWarning() )
+bRet = true;
 }
 else
 bRet = true;
@@ -1317,6 +1313,8 @@ bool ScDocShell::ConvertFrom( SfxMedium& rMedium )
 {
 if (!GetError())
 SetError(eError);
+if( eError.IsWarning() )
+bRet = true;
 }
 else if (!GetError() && (bOverflowRow || bOverflowCol || 
bOverflowCell))
 {
@@ -1357,7 +1355,8 @@ bool ScDocShell::ConvertFrom( SfxMedium& rMedium )
 {
 if (!GetError())
 SetError(eError);
-bRet = ( eError == SCWARN_IMPORT_RANGE_OVERFLOW );
+if( eError.IsWarning() )
+bRet = true;
 }
 else
 bRet = true;
@@ -1435,8 +1434,13 @@ bool ScDocShell::ConvertFrom( SfxMedium& rMedium )
 }
 }
 
-if ( eError != ERRCODE_NONE && !GetError() )
-SetError(eError);
+if (eError != ERRCODE_NONE)
+{
+if (!GetError())
+SetError(eError);
+if( eError.IsWarning() )
+bRet = true;
+}
 else if (!GetError() && (bOverflowRow || bOverflowCol || 
bOverflowCell))
 {
 // precedence: row, column, cell
@@ -1500,8 +1504,13 @@ bool ScDocShell::ConvertFrom( SfxMedium& rMedium )
 }
 }
 
-if ( eError != ERRCODE_NONE && !GetError() )
-SetError(eError);
+if (eError != ERRCODE_NONE)
+{
+if (!GetError())
+SetError(eError);
+if( eError.IsWarning() )
+bRet = true;
+}
 }
 else if (aFltName == pFilterHtml || aFltName == pFilterHtmlWebQ)
 {
@@ -1551,8 +1560,13 @@ bool ScDocShell::ConvertFrom( SfxMedium& rMedium )
 }
 }
 
-if ( eError != ERRCODE_NONE && !GetError() )
-SetError(eError);
+if (eError != ERRCODE_NONE)
+{
+if (!GetError())
+SetError(eError);
+if( eError.IsWarning() )
+bRet = true;
+}
 }
 else
 {

Re: Overview of variable naming conventions

2022-02-26 Thread Luboš Luňák

On Saturday 26 of February 2022, Jan Rheinlc3a4nder wrote:
> Hi,
>
> is there somewhere a key to naming variables? For example, I see
>
> OUString msDocAccTitle
> DocumentType    meDocType
> std::unique_ptr mpGrammarContact
> const OUString& rBuffer
> SmFormat    maFormat
> OUString    maAccText
> bool    mbFormulaArranged
> sal_uInt16  mnSmSyntaxVersion
>
> So there is "ms" maybe meaning "member string"? "mb": "member bool"? But
> "ma" and "me" ?

 It's called Hungarian notation 
(https://en.wikipedia.org/wiki/Hungarian_notation). It's one of the obsolete 
obnoxious things LibreOffice inherited from OpenOffice that keeps going on 
because of inertia.

 'm' is member, 'r' is reference, 'p' is pointer, 'x' is UNO reference, 'a' is 
array (or string), 's' is string, 'e' is enum, 'n' is number, 'b' is bool. Or 
maybe not, since in a number of variables it's wrong.

 I personally consider 'm' to be the only one useful and the rest is garbage 
that gets in the way and can be ignored.

-- 
 Luboš Luňák
 l.lu...@collabora.com

[Libreoffice-bugs] [Bug 147671] Only works to Excel generated ActiveCell in the first open file, failed after save and reopen

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147671

zexcel  changed:

   What|Removed |Added

 CC||aist0...@gmail.com

--- Comment #1 from zexcel  ---
Created attachment 178560
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178560=edit
xlsm file for ActiveCell function generated using Excel

>From the point of security, macro is not a good choice. I hope Calc can give a
function, something like getValueinNameBox() to access the Active Cell easily.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147671] New: Only works to Excel generated ActiveCell in the first open file, failed after save and reopen

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147671

Bug ID: 147671
   Summary: Only works to Excel generated ActiveCell in the first
open file, failed after save and reopen
   Product: LibreOffice
   Version: 6.4 all versions
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: aist0...@gmail.com

Description:
There are many discussion on Active Cell.(for example:
https://forum.openoffice.org/en/forum/viewtopic.php?f=9=89911#:~:text=Loop%20through%20the%20cells%20of%20the%20range%20and,mean%20the%20cell%20currently%20having%20the%20input%20focus.)

I try to use the Excel xlsm approach. It works in Calc, however, only single
time. After Calc saves the file and reopen it, it will never function any more.

Steps to Reproduce:
1.making the xlsm file in Excel
2.open the xlsm file in Calc, click different cell and check the response in
the  cells of A2, A3 and A4
3.save the file in Calc, close the file and reopen the file in Calc or Excel,
the cell, neither A2 nor A3 nor A4, does not response to mouse click any more. 

Actual Results:
Function related with Active Cell lost when reopen the Calc saved file.

Expected Results:
Function work as the first open the xlsm file.


Reproducible: Always


User Profile Reset: No



Additional Info:
[Information automatically included from LibreOffice]
Locale: en-US
Module: SpreadsheetDocument
[Information guessed from browser]
OS: Linux (All)
OS is 64bit: yes

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 132126] Result of exporting selection to HTML includes content from other sheet

2022-02-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=132126

--- Comment #2 from jk...@topsec.cz ---
Confirmed.

Version: 7.3.0.3 / LibreOffice Community
Build ID: 30(Build:3)
CPU threads: 2; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-GB (en_GB.UTF-8); UI: en-GB
Debian package version: 1:7.3.0-1~bpo11+1
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

Overview of variable naming conventions

2022-02-26 Thread Jan Rheinländer


Hi,

is there somewhere a key to naming variables? For example, I see

OUString msDocAccTitle
DocumentType    meDocType
std::unique_ptr mpGrammarContact
const OUString& rBuffer
SmFormat    maFormat
OUString    maAccText
bool    mbFormulaArranged
sal_uInt16  mnSmSyntaxVersion

So there is "ms" maybe meaning "member string"? "mb": "member bool"? But 
"ma" and "me" ?


Thanks for any help




OpenPGP_signature
Description: OpenPGP digital signature

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sc/source

2022-02-26 Thread Eike Rathke (via logerrit)

 sc/source/core/data/documen2.cxx |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit dcd042c6f28276d707af409a87a1a4380398e9b0
Author: Eike Rathke 
AuthorDate: Sat Feb 26 02:19:23 2022 +0100
Commit: Caolán McNamara 
CommitDate: Sat Feb 26 17:11:38 2022 +0100

Related: tdf#147448 Scope owning mutex before it gets destroyed

Change-Id: I9bacffe1d075431427fb3bf01e4bf30ba6fbc201
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130574
Reviewed-by: Eike Rathke 
Tested-by: Jenkins
(cherry picked from commit aaa75591b0c0c7b097e2794a0b24ec7d0e0fa07f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130553
Reviewed-by: Caolán McNamara 

diff --git a/sc/source/core/data/documen2.cxx b/sc/source/core/data/documen2.cxx
index 9a3a2fb1ce0f..6cfae1502c17 100644
--- a/sc/source/core/data/documen2.cxx
+++ b/sc/source/core/data/documen2.cxx
@@ -337,7 +337,11 @@ ScDocument::~ScDocument()
 if ( pRefreshTimerControl )
 {   // To be sure there isn't anything running do it with a protector,
 // this ensures also that nothing needs the control anymore.
-ScRefreshTimerProtector aProt( GetRefreshTimerControlAddress() );
+{
+// Use a scope on its own because it is undefined behaviour if a
+// mutex is destroyed while still owned.
+ScRefreshTimerProtector aProt( GetRefreshTimerControlAddress() );
+}
 pRefreshTimerControl.reset();
 }

1 2 >

1 - 100 of 186 matches

Mail list logo