[Libreoffice-bugs] [Bug 107838] [META] Character-level bugs and enhancements

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107838

Dieter  changed:

   What|Removed |Added

 Depends on||147717


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=147717
[Bug 147717] The order of Arabic letters is reversed or there is no rotation in
LTR paragraphs
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147717] The order of Arabic letters is reversed or there is no rotation in LTR paragraphs

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147717

Dieter  changed:

   What|Removed |Added

 Blocks||112810, 107838
 CC||dgp-m...@gmx.de


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107838
[Bug 107838] [META] Character-level bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=112810
[Bug 112810] [META] Arabic language-specific RTL issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148001] impossible to open XLSX file and other µsoft office file

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148001

--- Comment #3 from Timur  ---
https://www.libreoffice.org/get-help/system-requirements/
Do you have KB3063858 , if not that's bug 144902?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148002] Bangalore girls bangalore escorts

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148002

Timur  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED
Version|1.0.2   |unspecified
  Component|General |deletionRequest
Product|Impress Remote  |LibreOffice

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148005] okkk

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148005

himajin100...@gmail.com changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148005] okkk

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148005

himajin100...@gmail.com changed:

   What|Removed |Added

  Component|General |deletionRequest
Product|cppunit |LibreOffice
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148005] New: okkk

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148005

Bug ID: 148005
   Summary: okkk
   Product: cppunit
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: General
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bohiwid...@songsign.com
CC: markus.mohrh...@googlemail.com

Created attachment 178895
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178895=edit
o

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: editeng/source

2022-03-15 Thread Hossein (via logerrit)
 editeng/source/items/numitem.cxx |   48 ---
 1 file changed, 11 insertions(+), 37 deletions(-)

New commits:
commit 3cc41346f5529026d7d38f2863ae3d84948e6ab7
Author: Hossein 
AuthorDate: Tue Mar 15 09:07:59 2022 +0100
Commit: Mike Kaganski 
CommitDate: Tue Mar 15 13:50:38 2022 +0100

Better CreateRomanString() to create Roman numbers

The previous implementation of CreateRomanString() was complex and
was using various tricks and pointers to create Roman representation
of the integers.

The new implementation is simpler, and easier to understand.

Change-Id: Ibda4f8cfab02fd360e718736c957b3e04110c57a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131573
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/editeng/source/items/numitem.cxx b/editeng/source/items/numitem.cxx
index 7d6fa5fe23ae..c4220c78a4b5 100644
--- a/editeng/source/items/numitem.cxx
+++ b/editeng/source/items/numitem.cxx
@@ -539,48 +539,22 @@ Size SvxNumberFormat::GetGraphicSizeMM100(const Graphic* 
pGraphic)
 
 OUString SvxNumberFormat::CreateRomanString( sal_Int32 nNo, bool bUpper )
 {
-nNo %= 4000;// more can not be displayed
-//  i, ii, iii, iv, v, vi, vii, vii, viii, ix
-//  (Dummy),1000,500,100,50,10,5,1
-const char *cRomanArr = bUpper
-? "MDCLXVI--"   // +2 Dummy entries!
-: "mdclxvi--";  // +2 Dummy entries!
-
 OUStringBuffer sRet;
-sal_uInt16 nMask = 1000;
-while( nMask )
-{
-sal_uInt8 nNumber = sal_uInt8(nNo / nMask);
-sal_uInt8 nDiff = 1;
-nNo %= nMask;
 
-if( 5 < nNumber )
-{
-if( nNumber < 9 )
-sRet.append(*(cRomanArr-1));
-++nDiff;
-nNumber -= 5;
-}
-switch( nNumber )
+constexpr char romans[][13] = {"M", "CM", "D", "CD", "C", "XC", "L", "XL", 
"X", "IX", "V", "IV", "I"};
+constexpr sal_Int32 values[] = {1000, 900, 500, 400, 100, 90, 50, 40, 10, 
9, 5, 4, 1};
+
+for (size_t i = 0; i < std::size(romans); ++i)
+{
+while(nNo - values[i] >= 0)
 {
-case 3: { sRet.append(*cRomanArr); [[fallthrough]]; }
-case 2: { sRet.append(*cRomanArr); [[fallthrough]]; }
-case 1: { sRet.append(*cRomanArr); }
-break;
-
-case 4: {
-sRet.append(*cRomanArr);
-sRet.append(*(cRomanArr-nDiff));
-}
-break;
-case 5: { sRet.append(*(cRomanArr-nDiff)); }
-break;
+sRet.appendAscii(romans[i]);
+nNo -= values[i];
 }
-
-nMask /= 10;// for the next decade
-cRomanArr += 2;
 }
-return sRet.makeStringAndClear();
+
+return bUpper ? sRet.makeStringAndClear()
+  : sRet.makeStringAndClear().toAsciiLowerCase();
 }
 
 void SvxNumberFormat::SetListFormat(const OUString& rPrefix, const OUString& 
rSuffix, int nLevel)


[Libreoffice-bugs] [Bug 147982] On macOS Monterey LibreOffice 7.3 crashes about every day. This was also with previous versions of LibreOffice.

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147982

--- Comment #5 from Alexander Van den Panhuysen 
 ---
Unfortunately restarting via Safe Mode didn't solve a thing, I tried all
possibilities, but my Calc workbook does not open without a recovery.
At last I did the following: instead of closing the Calc, I quit LibreOffice
entirely (to do that on macOS it is needed to do command+Q Twice !).
A bit later launching LibreOffice, I can open my Calc workbook in a normal way.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147989] The size of a MediaBox of the PDF exported from an A5-paper Writer Document might be wrong (very slightly).

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147989

--- Comment #1 from Shinji Enoki  ---
I reproduced it. 
I don't know if this is a LibreOffice bug. 

Version: 7.3.1.3 / LibreOffice Community
Build ID: a69ca51ded25f3eefd52d7bf9a5fad8c90b87951
CPU threads: 8; OS: Linux 5.16; UI render: default; VCL: gtk3
Locale: ja-JP (ja_JP.UTF-8); UI: ja-JP
Calc: threaded

$ pdfinfo -v
pdfinfo version 20.09.0
Copyright 2005-2020 The Poppler Developers - http://poppler.freedesktop.org
Copyright 1996-2011 Glyph & Cog, LLC


$ pdfinfo pdf-size.pdf 
Creator:Writer
Producer:   LibreOffice 7.3
CreationDate:   Tue Mar 15 21:08:56 2022 JST
Tagged: no
UserProperties: no
Suspects:   no
Form:   none
JavaScript: no
Pages:  1
Encrypted:  no
Page size:  419.556 x 595.304 pts
Page rot:   0
File size:  9992 bytes
Optimized:  no
PDF version:1.6

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: jvmfwk/plugins

2022-03-15 Thread Stephan Bergmann (via logerrit)
 jvmfwk/plugins/sunmajor/pluginlib/sunversion.cxx |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 8e6462571bb4cb872f607b4ac9dfde7f43b79ac3
Author: Stephan Bergmann 
AuthorDate: Tue Mar 15 12:17:30 2022 +0100
Commit: Stephan Bergmann 
CommitDate: Tue Mar 15 13:46:06 2022 +0100

Allow for java.version consisting of four dotted segments

...like "11.0.14.1" reported now by
java-11-openjdk-headless-11.0.14.1.1-5.fc35.x86_64, and which caused

> warn:jfw:274674:274674:jvmfwk/plugins/sunmajor/pluginlib/sunjre.cxx:100: 
[Java framework] sunjavaplugin.so does not know the version: 11.0.14.1 as valid 
for a SUN/Oracle JRE.

(For simplicity, cover it with the same code block that already covers a
potential "_01" etc. part following the official(?) three dotted segments.)

Change-Id: Id98235d3be59653ab412f9b6c1ffbf3b0470bd6f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131586
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/jvmfwk/plugins/sunmajor/pluginlib/sunversion.cxx 
b/jvmfwk/plugins/sunmajor/pluginlib/sunversion.cxx
index 490d5febbea4..16a1e14f3662 100644
--- a/jvmfwk/plugins/sunmajor/pluginlib/sunversion.cxx
+++ b/jvmfwk/plugins/sunmajor/pluginlib/sunversion.cxx
@@ -72,8 +72,8 @@ bool SunVersion::init(const char *szVersion)
 //separators after maintenance (1.4.1_01, 1.4.1-beta, or 1.4.1)
 (pCur == pEnd || *pCur == '_' || *pCur == '-')
 ||
-//separators between major-minor and minor-maintenance
-(nPart < 2 && *pCur == '.') )
+//separators between major-minor and minor-maintenance (or 
fourth segment)
+(nPart < 3 && *pCur == '.') )
 && (
 //prevent 1.4.0. 1.4.0-
 pCur + 1 != pEnd
@@ -113,10 +113,10 @@ bool SunVersion::init(const char *szVersion)
 }
 if (pCur >= pEnd)
 return true;
-//We have now 1.4.1. This can be followed by _01, -beta, etc.
+//We have now 1.4.1. This can be followed by _01 (or a fourth segment .1), 
-beta, etc.
 // _01 (update) According to docu must not be followed by any other
 //characters, but on Solaris 9 we have a 1.4.1_01a!!
-if (* (pCur - 1) == '_')
+if (* (pCur - 1) == '_' || *(pCur - 1) == '.')
 {// _01, _02
 // update is the last part _01, _01a, part 0 is the digits parts and 1 
the trailing alpha
 while (true)


[Libreoffice-bugs] [Bug 148004] Is The Cash App ++ Real Version Of Cash App?

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148004

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID
  Component|Android Editor  |deletionRequest

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147986] Position in shortcut keys should not change after using Reset button in Customize Keyboard

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147986

--- Comment #3 from sdc.bla...@youmail.dk ---
(In reply to Shinji Enoki from comment #2)
> I think this report is a usability issue
Correct. The issue is usability.

Also reproduced in 7.4.0.0+

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: compilerplugins/clang

2022-03-15 Thread Stephan Bergmann (via logerrit)
 compilerplugins/clang/test/trivialdestructor.cxx |   24 +++
 compilerplugins/clang/trivialdestructor.cxx  |4 ---
 2 files changed, 24 insertions(+), 4 deletions(-)

New commits:
commit 25fee1f66ba42c0b6828409bfd2c2e822c1f7eb6
Author: Stephan Bergmann 
AuthorDate: Mon Mar 14 22:14:22 2022 +0100
Commit: Stephan Bergmann 
CommitDate: Tue Mar 15 13:41:02 2022 +0100

loplugin:trivialdestructor: Remove spurious anonymous union special case

No idea what this "The destructor for an implicit anonymous union member is
never invoked" block was meant to be good for.

If a union-like class X has a variant member Y with a non-trivial 
destructor, an
(implicitly-declared) defaulted destructor of X would be defined as 
deleted, so
we must not warn about a user-provided destructor of X with an empty body.  
But
that is already covered by the fact that the anonymous union of which Y is a
member will have a non-trivial destructor if Y has a non-trivial destructor.

Change-Id: Ia30381a07fadd3132f5595575716c6c5097fa34d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131576
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/compilerplugins/clang/test/trivialdestructor.cxx 
b/compilerplugins/clang/test/trivialdestructor.cxx
index 98bf8262f29e..b6ba4e968193 100644
--- a/compilerplugins/clang/test/trivialdestructor.cxx
+++ b/compilerplugins/clang/test/trivialdestructor.cxx
@@ -30,4 +30,28 @@ struct S3
 ~S3() = delete;
 };
 
+struct S4
+{
+union {
+int i;
+float f;
+};
+// expected-error@+1 {{no need for explicit destructor decl 
[loplugin:trivialdestructor]}}
+~S4() {}
+};
+
+struct Nontrivial
+{
+~Nontrivial();
+};
+
+struct S5
+{
+union {
+int i;
+Nontrivial n;
+};
+~S5() {}
+};
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */
diff --git a/compilerplugins/clang/trivialdestructor.cxx 
b/compilerplugins/clang/trivialdestructor.cxx
index 7ec54045dea7..09c0f9adcaed 100644
--- a/compilerplugins/clang/trivialdestructor.cxx
+++ b/compilerplugins/clang/trivialdestructor.cxx
@@ -125,10 +125,6 @@ bool 
TrivialDestructor::FieldHasTrivialDestructorBody(const FieldDecl* Field)
 
 CXXRecordDecl* FieldClassDecl = cast(RT->getDecl());
 
-// The destructor for an implicit anonymous union member is never invoked.
-if (FieldClassDecl->isUnion() && 
FieldClassDecl->isAnonymousStructOrUnion())
-return false;
-
 return FieldClassDecl->hasTrivialDestructor();
 }
 


[Libreoffice-commits] core.git: compilerplugins/clang

2022-03-15 Thread Stephan Bergmann (via logerrit)
 compilerplugins/clang/test/trivialdestructor.cxx |5 +
 1 file changed, 5 insertions(+)

New commits:
commit 5e6ee5503bcfdf47327a019e7ff172a378939d31
Author: Stephan Bergmann 
AuthorDate: Mon Mar 14 22:10:39 2022 +0100
Commit: Stephan Bergmann 
CommitDate: Tue Mar 15 13:40:28 2022 +0100

Check that loplugin:trivialdestructor doesn't warn about deleted dtors

...which happens to be covered by

  if (!destructorDecl->hasTrivialBody())
  return false;

Change-Id: Ica2874e710da08d668b7e773373a1188a8ae16a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131575
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/compilerplugins/clang/test/trivialdestructor.cxx 
b/compilerplugins/clang/test/trivialdestructor.cxx
index 16168cb5f927..98bf8262f29e 100644
--- a/compilerplugins/clang/test/trivialdestructor.cxx
+++ b/compilerplugins/clang/test/trivialdestructor.cxx
@@ -25,4 +25,9 @@ struct S2
 // expected-error@+1 {{no need for explicit destructor decl 
[loplugin:trivialdestructor]}}
 S2::~S2() = default;
 
+struct S3
+{
+~S3() = delete;
+};
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */


[Libreoffice-commits] core.git: compilerplugins/clang solenv/CompilerTest_compilerplugins_clang.mk

2022-03-15 Thread Stephan Bergmann (via logerrit)
 compilerplugins/clang/test/trivialdestructor.cxx |   28 +++
 compilerplugins/clang/trivialdestructor.cxx  |   15 
 solenv/CompilerTest_compilerplugins_clang.mk |1 
 3 files changed, 39 insertions(+), 5 deletions(-)

New commits:
commit c3346dc5731ecadb4762b939b76056eaed193341
Author: Stephan Bergmann 
AuthorDate: Mon Mar 14 21:33:31 2022 +0100
Commit: Stephan Bergmann 
CommitDate: Tue Mar 15 13:40:00 2022 +0100

loplugin:trivialdestructor: Only warn about definitions

Change-Id: I666e72a5c95b48cd5bc0cb775de3ec6a6c82fe39
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131574
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/compilerplugins/clang/test/trivialdestructor.cxx 
b/compilerplugins/clang/test/trivialdestructor.cxx
new file mode 100644
index ..16168cb5f927
--- /dev/null
+++ b/compilerplugins/clang/test/trivialdestructor.cxx
@@ -0,0 +1,28 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+struct S1
+{
+// expected-note@+1 {{previous declaration is here 
[loplugin:trivialdestructor]}}
+~S1();
+};
+
+// expected-error@+1 {{no need for explicit destructor decl 
[loplugin:trivialdestructor]}}
+S1::~S1() {}
+
+struct S2
+{
+// expected-note@+1 {{previous declaration is here 
[loplugin:trivialdestructor]}}
+~S2();
+};
+
+// expected-error@+1 {{no need for explicit destructor decl 
[loplugin:trivialdestructor]}}
+S2::~S2() = default;
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */
diff --git a/compilerplugins/clang/trivialdestructor.cxx 
b/compilerplugins/clang/trivialdestructor.cxx
index 208e4931a152..7ec54045dea7 100644
--- a/compilerplugins/clang/trivialdestructor.cxx
+++ b/compilerplugins/clang/trivialdestructor.cxx
@@ -45,6 +45,8 @@ bool 
TrivialDestructor::VisitCXXDestructorDecl(CXXDestructorDecl const* destruct
 {
 if (ignoreLocation(destructorDecl))
 return true;
+if (!destructorDecl->isThisDeclarationADefinition())
+return true;
 if (!destructorDecl->hasTrivialBody())
 return true;
 if (destructorDecl->isVirtual())
@@ -62,12 +64,15 @@ bool 
TrivialDestructor::VisitCXXDestructorDecl(CXXDestructorDecl const* destruct
 report(DiagnosticsEngine::Warning, "no need for explicit destructor decl",
destructorDecl->getLocation())
 << destructorDecl->getSourceRange();
-if (destructorDecl->getCanonicalDecl() != destructorDecl)
+for (FunctionDecl const* d2 = destructorDecl;;)
 {
-destructorDecl = destructorDecl->getCanonicalDecl();
-report(DiagnosticsEngine::Warning, "no need for explicit destructor 
decl",
-   destructorDecl->getLocation())
-<< destructorDecl->getSourceRange();
+d2 = d2->getPreviousDecl();
+if (d2 == nullptr)
+{
+break;
+}
+report(DiagnosticsEngine::Note, "previous declaration is here", 
d2->getLocation())
+<< d2->getSourceRange();
 }
 return true;
 }
diff --git a/solenv/CompilerTest_compilerplugins_clang.mk 
b/solenv/CompilerTest_compilerplugins_clang.mk
index 66b0579dd69b..b95771b75dff 100644
--- a/solenv/CompilerTest_compilerplugins_clang.mk
+++ b/solenv/CompilerTest_compilerplugins_clang.mk
@@ -94,6 +94,7 @@ $(eval $(call 
gb_CompilerTest_add_exception_objects,compilerplugins_clang, \
 compilerplugins/clang/test/stringstatic \
 compilerplugins/clang/test/stringview \
 compilerplugins/clang/test/stringviewparam \
+compilerplugins/clang/test/trivialdestructor \
 compilerplugins/clang/test/typedefparam \
 compilerplugins/clang/test/typeidcomparison \
 compilerplugins/clang/test/unnecessarycatchthrow \


[Libreoffice-bugs] [Bug 148004] New: Is The Cash App ++ Real Version Of Cash App?

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148004

Bug ID: 148004
   Summary: Is The Cash App ++ Real Version Of Cash App?
   Product: LibreOffice
   Version: 3.4 all versions
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Android Editor
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: adamkent2...@gmail.com

Description:
Are you one of those who are going to use of the advanced version of the Cash
App? Is The Cash App ++ Real update through which you can update your
application? All you can do is to have a word with the professionals who will
clarify your doubts and hurdles within the least time frame.
https://www.emailsupport-contact.com/blog/how-do-i-get-cash-app-plus-plus/

Actual Results:
Done

Expected Results:
Done


Reproducible: Always


User Profile Reset: No



Additional Info:
Done

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147988] Opening links with odt at the end gives network errors

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147988

--- Comment #1 from Shinji Enoki  ---
Did not reproduce in my environment:

Version: 7.3.1.3 / LibreOffice Community
Build ID: a69ca51ded25f3eefd52d7bf9a5fad8c90b87951
CPU threads: 8; OS: Linux 5.16; UI render: default; VCL: gtk3
Locale: ja-JP (ja_JP.UTF-8); UI: ja-JP
Calc: threaded

Inserting a hyperlink and Ctrl + click it opened the browser.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: basegfx/source

2022-03-15 Thread Hossein (via logerrit)
 basegfx/source/workbench/Makefile   |   13 --
 basegfx/source/workbench/bezierclip.cxx |  186 
 2 files changed, 95 insertions(+), 104 deletions(-)

New commits:
commit 59cb2aa7908e1a7079a6fb692465b1bbe4321e2b
Author: Hossein 
AuthorDate: Thu Dec 16 07:59:33 2021 +0100
Commit: Hossein 
CommitDate: Tue Mar 15 13:03:08 2022 +0100

Update basegfx workbench

* Update Makefile
  + Remove obsolete 'test' rule
  + Fix include
* Add needed headers, std:: where needed
* Add newlines in the print

One can run the workbench simply by invoking:

make

inside 'basegfx/source/workbench' and then

./bezierclip

Change-Id: I1055260a801d3a95c102a92004874000efb6871c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126903
Tested-by: Jenkins
Reviewed-by: Hossein 

diff --git a/basegfx/source/workbench/Makefile 
b/basegfx/source/workbench/Makefile
index 21dfc1400d11..6218141da1c8 100644
--- a/basegfx/source/workbench/Makefile
+++ b/basegfx/source/workbench/Makefile
@@ -16,19 +16,8 @@
 #   the License at http://www.apache.org/licenses/LICENSE-2.0 .
 #
 
-# Testbuild
-
-#test : bezierclip.cxx convexhull.cxx
-#  g++ -Wall -g \
-#  -I. -I. -I../inc -I./inc -I./unx/inc -I./unxlngi4/inc -I. 
-I/develop4/update/SRX644/unxlngi4/inc.m4/stl 
-I/develop4/update/SRX644/unxlngi4/inc.m4/external 
-I/develop4/update/SRX644/unxlngi4/inc.m4 
-I/develop4/update/SRX644/src.m4/solenv/unxlngi4/inc  
-I/net/grande/develop6/update/dev/gcc_3.0.1_linux_libc2.11_turbolinux/include 
-I/develop4/update/SRX644/src.m4/solenv/inc 
-I/develop4/update/SRX644/unxlngi4/inc.m4/stl 
-I/net/grande.germany/develop6/update/dev/gcc_3.0.1_linux_libc2.11_turbolinux/redhat60/usr/include
 
-I/net/grande.germany/develop6/update/dev/gcc_3.0.1_linux_libc2.11_turbolinux/redhat60/usr/include/X11
 -I/develop4/update/SRX644/src.m4/res 
-I/net/grande/develop6/update/dev/Linux_JDK_1.4.0/include 
-I/net/grande/develop6/update/dev/Linux_JDK_1.4.0/include/linux -I. -I./res -I. 
\
-#  -include preinclude.h -D_USE_NAMESPACE -DGLIBC=2 -D_USE_NAMESPACE=1 
-D_DEBUG_RUNTIME \
-#  bezierclip.cxx convexhull.cxx -o bezierclip
-
 prog : bezierclip.cxx convexhull.cxx
-   g++ -Wall -g bezierclip.cxx convexhull.cxx -o bezierclip
-
-test : testconvexhull.cxx
-   g++ -Wall -g testconvexhull.cxx -o testhull
+   g++ -I. -Wall -g bezierclip.cxx convexhull.cxx -o bezierclip
 
 .cxx.o:
g++ -c $(LOCALDEFINES) $(CCFLAGS) $<
diff --git a/basegfx/source/workbench/bezierclip.cxx 
b/basegfx/source/workbench/bezierclip.cxx
index 1f16ed37c05c..7c939f9b 100644
--- a/basegfx/source/workbench/bezierclip.cxx
+++ b/basegfx/source/workbench/bezierclip.cxx
@@ -17,6 +17,8 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
+#include 
+#include 
 #include 
 #include 
 #include 
@@ -287,9 +289,9 @@ bool Impl_calcSafeParams_clip( double&  t1,
 
 Polygon2D convHull( convexHull( poly ) );
 
-cout << "# convex hull testing" << endl
+std::cout << "# convex hull testing" << std::endl
  << "plot [t=0:1] ";
-cout << " bez("
+std::cout << " bez("
  << poly[0].x << ","
  << poly[1].x << ","
  << poly[2].x << ","
@@ -303,22 +305,22 @@ bool Impl_calcSafeParams_clip( double&  t1,
  << t1 << ", t, "
  << t2 << ", t, "
  << "'-' using ($1):($2) title \"control polygon\" with lp, "
- << "'-' using ($1):($2) title \"convex hull\" with lp" << endl;
+ << "'-' using ($1):($2) title \"convex hull\" with lp" << std::endl;
 
 unsigned int k;
 for( k=0; k void Impl_applySafeRanges_rec( 
std::back_insert_iterato
 // tangency, and justifies to return a single intersection
 // point. Otherwise, inside/outside test might fail here.
 
-for( int i=0; i

[Libreoffice-bugs] [Bug 55846] Comboboxes aren’t displayed when the toolbar is vertical

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=55846

Rainer Bielefeld Retired  changed:

   What|Removed |Added

 CC|LibreOffice@bielefeldundbus |
   |s.de|

--- Comment #28 from Rainer Bielefeld Retired  
---


-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145614] Convert #define to enum or constexpr

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145614

--- Comment #7 from Commit Notification 
 ---
Hossein committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3e7dd04dd8ca1baea4b7918eb7a7080c595c4625

tdf#145614 Convert #define to enum and constexpr

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: emfio/inc emfio/qa emfio/source

2022-03-15 Thread Hossein (via logerrit)
 emfio/inc/mtftools.hxx |  445 ++---
 emfio/qa/cppunit/wmf/wmfimporttest.cxx |4 
 emfio/source/reader/emfreader.cxx  |   23 -
 emfio/source/reader/mtftools.cxx   |  168 ++--
 emfio/source/reader/wmfreader.cxx  |   64 ++--
 5 files changed, 397 insertions(+), 307 deletions(-)

New commits:
commit 3e7dd04dd8ca1baea4b7918eb7a7080c595c4625
Author: Hossein 
AuthorDate: Mon Feb 28 00:07:16 2022 +0100
Commit: Hossein 
CommitDate: Tue Mar 15 13:00:59 2022 +0100

tdf#145614 Convert #define to enum and constexpr

* Converted symbolic constants with #define in mftools.hxx to:
  a) 'enum' where facing multiple values of the same category with
 similar prefixes, or enums from the [MS-WMF] / [MS-EMF]
  b) extracted the underlying integral type from the above documents
  c) 'constexpr' where there was a single value

* Where possible, 'enum class' in 'emfio' namespace is used
  * Some enums with binary or comparison operations are not converted
MappingMode, TextAlignmentMode, RasterOperations, PenStyle
CharacterSet, ExtTextOutOptions, PitchFont, FamilyFont, WeightFont

Change-Id: I144b2df4722e23d3b0c0aca7880cf603faa80686
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124099
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek 

diff --git a/emfio/inc/mtftools.hxx b/emfio/inc/mtftools.hxx
index d258a9250b91..cb6e1c7ff243 100644
--- a/emfio/inc/mtftools.hxx
+++ b/emfio/inc/mtftools.hxx
@@ -32,51 +32,60 @@
 
 #include "emfiodllapi.h"
 
-#define ERROR   0
-#define NULLREGION  1
-#define COMPLEXREGION   3
-
-#define RGN_AND 1
-#define RGN_OR  2
-#define RGN_XOR 3
-#define RGN_DIFF4
-#define RGN_COPY5
-
 namespace emfio
 {
-enum class BkMode
+/* [MS-EMF] - v20210625 - pages 43, 107 */
+enum class RegionMode : sal_uInt32
+{
+RGN_AND  = 0x01,
+RGN_OR   = 0x02,
+RGN_XOR  = 0x03,
+RGN_DIFF = 0x04,
+RGN_COPY = 0x05
+};
+
+/* [MS-EMF] - v20210625 - pages 40, 198 */
+enum class BackgroundMode : sal_uInt32
 {
 NONE = 0,
 Transparent = 1,
 OPAQUE = 2,
 };
-}
 
-/* xform stuff */
-#define MWT_IDENTITY1
-#define MWT_LEFTMULTIPLY2
-#define MWT_RIGHTMULTIPLY   3
-#define MWT_SET 4
-
-#define ENHMETA_STOCK_OBJECT0x8000
-
-/* Stock Logical Objects */
-#define WHITE_BRUSH 0
-#define LTGRAY_BRUSH1
-#define GRAY_BRUSH  2
-#define DKGRAY_BRUSH3
-#define BLACK_BRUSH 4
-#define NULL_BRUSH  5
-#define WHITE_PEN   6
-#define BLACK_PEN   7
-#define NULL_PEN8
-#define ANSI_FIXED_FONT 11
-#define ANSI_VAR_FONT   12
-#define SYSTEM_FIXED_FONT   16
+/* [MS-EMF] - v20210625 - pages 40, 210 */
+/* xform stuff */
+enum class ModifyWorldTransformMode : sal_uInt32
+{
+MWT_IDENTITY  = 0x01,
+MWT_LEFTMULTIPLY  = 0x02,
+MWT_RIGHTMULTIPLY = 0x03,
+MWT_SET   = 0x04
+};
+
+constexpr sal_uInt32 ENHMETA_STOCK_OBJECT = 0x8000;
 
-namespace emfio
-{
-enum class WMFRasterOp {
+/* [MS-EMF] - v20210625 - pages 44, 45, 182 */
+/* Stock Logical Objects */
+enum class StockObject : sal_uInt32
+{
+WHITE_BRUSH   = 0,
+LTGRAY_BRUSH  = 1,
+GRAY_BRUSH= 2,
+DKGRAY_BRUSH  = 3,
+BLACK_BRUSH   = 4,
+NULL_BRUSH= 5,
+WHITE_PEN = 6,
+BLACK_PEN = 7,
+NULL_PEN  = 8,
+ANSI_FIXED_FONT   = 11,
+ANSI_VAR_FONT = 12,
+SYSTEM_FIXED_FONT = 16
+};
+
+/* Note: This enum is incomplete compared to the specification */
+/* [MS-WMF] - v20210625 - pages 25-26 */
+enum class WMFRasterOp : sal_uInt16
+{
 NONE = 0,
 Black = 1,
 Not = 6,
@@ -84,35 +93,48 @@ namespace emfio
 Nop = 11,
 CopyPen = 13
 };
-}
 
-/* Mapping modes */
-#define MM_TEXT 1
-#define MM_LOMETRIC 2
-#define MM_HIMETRIC 3
-#define MM_LOENGLISH4
-#define MM_HIENGLISH5
-#define MM_TWIPS6
-#define MM_ISOTROPIC7
-#define MM_ANISOTROPIC  8
-
-/* Graphics modes */
-#define GM_COMPATIBLE   1
-#define GM_ADVANCED 2
-
-/* StretchBlt() modes */
-#define BLACKONWHITE1
-#define WHITEONBLACK2
-#define COLORONCOLOR3
-#define HALFTONE4
-#define STRETCH_ANDSCANSBLACKONWHITE
-#define STRETCH_ORSCANS WHITEONBLACK
-#define STRETCH_DELETESCANS COLORONCOLOR
-
-#define LF_FACESIZE 32
+/* Note: We have 

[Libreoffice-bugs] [Bug 147986] Position in shortcut keys should not change after using Reset button in Customize Keyboard

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147986

Shinji Enoki  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #2 from Shinji Enoki  ---
This case reset worked correctly, but the pointer position in the list moved
up. I think this report is a usability issue

Reproduced in:

Version: 7.3.1.3 / LibreOffice Community
Build ID: a69ca51ded25f3eefd52d7bf9a5fad8c90b87951
CPU threads: 8; OS: Linux 5.16; UI render: default; VCL: gtk3
Locale: ja-JP (ja_JP.UTF-8); UI: ja-JP
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] dictionaries.git: Changes to 'distro/mimo/mimo-7-2'

2022-03-15 Thread Stanislav Horacek (via logerrit)
New branch 'distro/mimo/mimo-7-2' available with the following commits:


[Libreoffice-commits] core.git: sw/qa

2022-03-15 Thread Xisco Fauli (via logerrit)
 sw/qa/extras/ooxmlexport/ooxmlexport.cxx   |6 +++---
 sw/qa/extras/ooxmlexport/ooxmlexport10.cxx |   11 ---
 sw/qa/extras/ooxmlexport/ooxmlexport11.cxx |   22 +++---
 sw/qa/extras/ooxmlexport/ooxmlexport12.cxx |3 +--
 sw/qa/extras/ooxmlexport/ooxmlexport13.cxx |2 +-
 sw/qa/extras/ooxmlexport/ooxmlexport14.cxx |2 +-
 sw/qa/extras/ooxmlexport/ooxmlexport2.cxx  |   19 +--
 sw/qa/extras/ooxmlexport/ooxmlexport3.cxx  |   12 ++--
 sw/qa/extras/ooxmlexport/ooxmlexport5.cxx  |6 +++---
 sw/qa/extras/ooxmlexport/ooxmlexport6.cxx  |   18 +-
 sw/qa/extras/ooxmlexport/ooxmlexport8.cxx  |7 +++
 sw/qa/extras/ooxmlexport/ooxmlexport9.cxx  |   18 +-
 12 files changed, 60 insertions(+), 66 deletions(-)

New commits:
commit 9b6a44a3d58cb050156f6f5253c14f6e0f79eabf
Author: Xisco Fauli 
AuthorDate: Tue Mar 15 11:40:06 2022 +0100
Commit: Xisco Fauli 
CommitDate: Tue Mar 15 12:30:13 2022 +0100

CppunitTest_sw_ooxmlexport*: use getProperty when possible

Change-Id: I87116aeb0c176d67588ecfcff94098346e17dd6d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131584
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
index d1a348612779..7ff6b11f1baa 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
@@ -522,7 +522,7 @@ DECLARE_OOXMLEXPORT_TEST(testWpsCharColor, 
"wps-char-color.docx")
 {
 uno::Reference xShape(getShape(1), uno::UNO_QUERY);
 // This was -1, i.e. the character color was default (-1), not white.
-CPPUNIT_ASSERT_EQUAL(COL_WHITE, Color(ColorTransparency, 
getProperty(xShape->getStart(), "CharColor")));
+CPPUNIT_ASSERT_EQUAL(COL_WHITE, getProperty(xShape->getStart(), 
"CharColor"));
 }
 
 DECLARE_OOXMLEXPORT_TEST(testTableStyleCellBackColor, 
"table-style-cell-back-color.docx")
@@ -533,7 +533,7 @@ DECLARE_OOXMLEXPORT_TEST(testTableStyleCellBackColor, 
"table-style-cell-back-col
 uno::Reference xTable(xTables->getByIndex(0), 
uno::UNO_QUERY);
 uno::Reference xCell = xTable->getCellByName("A1");
 // This was 0xff.
-CPPUNIT_ASSERT_EQUAL(Color(0x00ff00), Color(ColorTransparency, 
getProperty(xCell, "BackColor")));
+CPPUNIT_ASSERT_EQUAL(Color(0x00ff00), getProperty(xCell, 
"BackColor"));
 }
 
 DECLARE_OOXMLEXPORT_TEST(testTableStyleBorder, "table-style-border.docx")
@@ -880,7 +880,7 @@ DECLARE_OOXMLEXPORT_TEST(testTdf97090, "tdf97090.docx")
 uno::Reference xTablesSupplier(mxComponent, 
uno::UNO_QUERY);
 uno::Reference 
xTables(xTablesSupplier->getTextTables(), uno::UNO_QUERY);
 uno::Reference xTable(xTables->getByIndex(0), 
uno::UNO_QUERY);
-CPPUNIT_ASSERT_EQUAL(Color(0x95B3D7), Color(ColorTransparency, 
getProperty(xTable->getCellByName("A1"), "BackColor")));
+CPPUNIT_ASSERT_EQUAL(Color(0x95B3D7), 
getProperty(xTable->getCellByName("A1"), "BackColor"));
 
 uno::Reference 
paraEnumAccess(xTable->getCellByName("A1"), uno::UNO_QUERY);
 assert( paraEnumAccess.is() );
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx
index 29996d119812..21f81b619bda 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx
@@ -120,9 +120,7 @@ DECLARE_OOXMLEXPORT_TEST(testSmartart, "smartart.docx")
 CPPUNIT_ASSERT_EQUAL(sal_Int32(5), xGroup->getCount()); // background, 3 
rectangles and an arrow in the group
 
 uno::Reference xPropertySet(xGroup->getByIndex(2), 
uno::UNO_QUERY);
-sal_Int32 nValue(0);
-xPropertySet->getPropertyValue("FillColor") >>= nValue;
-CPPUNIT_ASSERT_EQUAL(Color(0x4f81bd), Color(ColorTransparency, nValue)); 
// If fill color is right, theme import is OK
+CPPUNIT_ASSERT_EQUAL(Color(0x4f81bd), getProperty(xPropertySet, 
"FillColor")); // If fill color is right, theme import is OK
 
 uno::Reference xTextRange(xGroup->getByIndex(2), 
uno::UNO_QUERY);
 CPPUNIT_ASSERT_EQUAL(OUString("Sample"), xTextRange->getString()); // 
Shape has text
@@ -130,8 +128,7 @@ DECLARE_OOXMLEXPORT_TEST(testSmartart, "smartart.docx")
 uno::Reference 
xParaEnumAccess(xTextRange->getText(), uno::UNO_QUERY);
 uno::Reference xParaEnum = 
xParaEnumAccess->createEnumeration();
 xPropertySet.set(xParaEnum->nextElement(), uno::UNO_QUERY);
-xPropertySet->getPropertyValue("ParaAdjust") >>= nValue;
-CPPUNIT_ASSERT_EQUAL(sal_Int32(style::ParagraphAdjust_CENTER), nValue); // 
Paragraph properties are imported
+CPPUNIT_ASSERT_EQUAL(sal_Int32(style::ParagraphAdjust_CENTER), 
getProperty( xPropertySet, "ParaAdjust")); // Paragraph properties 
are imported
 }
 
 CPPUNIT_TEST_FIXTURE(Test, testFdo69548)
@@ -248,7 +245,7 @@ DECLARE_OOXMLEXPORT_TEST(testMceNested, "mce-nested.docx")
 // positionV's posOffset from the bugdoc, was 0.
 CPPUNIT_ASSERT(6879 <= 

[Libreoffice-commits] core.git: sc/qa

2022-03-15 Thread Xisco Fauli (via logerrit)
 sc/qa/uitest/solver/solver.py |   18 ++
 1 file changed, 14 insertions(+), 4 deletions(-)

New commits:
commit 34636bea78020e98bb5db6c3165d98d984e022dd
Author: Xisco Fauli 
AuthorDate: Tue Mar 15 10:51:11 2022 +0100
Commit: Xisco Fauli 
CommitDate: Tue Mar 15 12:07:43 2022 +0100

UITest_solver: add more asserts to find where the test fails

This test fails sometimes for unknown reasons
See 
https://ci.libreoffice.org//job/lo_ubsan/2329/consoleFull#2818066648ce9c26-9d0a-43a8-83d8-c44f54920d59

Change-Id: Ib5c01355fff1056f64cab7fcc8b486b31a0ba5e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131583
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sc/qa/uitest/solver/solver.py b/sc/qa/uitest/solver/solver.py
index f7372719c879..0ac87200f68a 100644
--- a/sc/qa/uitest/solver/solver.py
+++ b/sc/qa/uitest/solver/solver.py
@@ -22,28 +22,38 @@ class solver(UITestCase):
 gridwin.executeAction("SELECT", mkPropertyValues({"CELL": "B4"}))
 with 
self.ui_test.execute_modeless_dialog_through_command(".uno:SolverDialog", 
close_button="") as xDialog:
 xtargetedit = xDialog.getChild("targetedit")
+xmax = xDialog.getChild("max")
 xvalue = xDialog.getChild("value")
 xvalueedit = xDialog.getChild("valueedit")
 xchangeedit = xDialog.getChild("changeedit")
 xref1edit = xDialog.getChild("ref1edit")
 xval1edit = xDialog.getChild("val1edit")
+xop1list = xDialog.getChild("op1list")
 xref2edit = xDialog.getChild("ref2edit")
 xval2edit = xDialog.getChild("val2edit")
 xop2list = xDialog.getChild("op2list")
 
+self.assertEqual("$B$4", 
get_state_as_dict(xtargetedit)["Text"])
+self.assertEqual("true", get_state_as_dict(xmax)["Checked"])
+
 xvalue.executeAction("CLICK", tuple())
+select_by_text(xop2list, "=>")
+
+self.assertEqual("<=", 
get_state_as_dict(xop1list)["SelectEntryText"])
+self.assertEqual("=>", 
get_state_as_dict(xop2list)["SelectEntryText"])
+
 xvalueedit.executeAction("TYPE", 
mkPropertyValues({"TEXT":"1000"}))
 xchangeedit.executeAction("TYPE", 
mkPropertyValues({"TEXT":"C2"}))
 xref1edit.executeAction("TYPE", 
mkPropertyValues({"TEXT":"C2"}))
 xval1edit.executeAction("TYPE", 
mkPropertyValues({"TEXT":"C4"}))
 xref2edit.executeAction("TYPE", 
mkPropertyValues({"TEXT":"C4"}))
-select_by_text(xop2list, "=>")
-
 xval2edit.executeAction("TYPE", mkPropertyValues({"TEXT":"0"}))
+
 xOKBtn = xDialog.getChild("ok")
 
-with 
self.ui_test.execute_blocking_action(xOKBtn.executeAction, args=('CLICK', ())):
-pass
+with 
self.ui_test.execute_blocking_action(xOKBtn.executeAction, args=('CLICK', ())) 
as xWarnDialog:
+self.assertEqual("Solving successfully finished.", 
get_state_as_dict(xWarnDialog.getChild("label2"))["Text"])
+self.assertEqual("Result: 1000", 
get_state_as_dict(xWarnDialog.getChild("result"))["Text"])
 
 #verify
 self.assertEqual(get_cell_by_position(calc_doc, 0, 1, 
1).getValue(), 400)


[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - include/basegfx include/vcl sw/qa sw/source vcl/inc vcl/qt5 vcl/quartz vcl/skia vcl/source vcl/unx vcl/win

2022-03-15 Thread Caolán McNamara (via logerrit)
 include/basegfx/tuple/Tuple2D.hxx|6 
 include/vcl/devicecoordinate.hxx |   11 -
 include/vcl/outdev.hxx   |   10 +
 include/vcl/vcllayout.hxx|   17 +-
 sw/qa/extras/layout/layout.cxx   |2 
 sw/source/core/inc/fntcache.hxx  |8 -
 sw/source/core/inc/scriptinfo.hxx|   10 -
 sw/source/core/text/itradj.cxx   |6 
 sw/source/core/text/porlay.cxx   |   10 -
 sw/source/core/text/portxt.cxx   |4 
 sw/source/core/txtnode/fntcache.cxx  |  201 ++-
 sw/source/uibase/config/usrpref.cxx  |2 
 vcl/inc/ImplLayoutArgs.hxx   |6 
 vcl/inc/impglyphitem.hxx |4 
 vcl/inc/quartz/salgdi.h  |4 
 vcl/inc/salgdi.hxx   |   11 +
 vcl/inc/sallayout.hxx|   18 ++
 vcl/inc/skia/osx/gdiimpl.hxx |3 
 vcl/inc/skia/win/gdiimpl.hxx |4 
 vcl/inc/win/DWriteTextRenderer.hxx   |   17 +-
 vcl/inc/win/salgdi.h |2 
 vcl/inc/win/winlayout.hxx|8 -
 vcl/qt5/QtGraphics_Text.cxx  |   21 ++-
 vcl/quartz/salgdi.cxx|   16 +-
 vcl/skia/gdiimpl.cxx |4 
 vcl/skia/osx/gdiimpl.cxx |   11 +
 vcl/skia/win/gdiimpl.cxx |   78 ++--
 vcl/skia/x11/textrender.cxx  |   18 ++
 vcl/source/gdi/CommonSalLayout.cxx   |   35 ++---
 vcl/source/gdi/pdfwriter_impl.cxx|   28 ++--
 vcl/source/gdi/salgdilayout.cxx  |3 
 vcl/source/gdi/sallayout.cxx |  102 +--
 vcl/source/gdi/virdev.cxx|2 
 vcl/source/outdev/font.cxx   |   10 -
 vcl/source/outdev/map.cxx|   25 +++
 vcl/source/outdev/outdev.cxx |   19 ++
 vcl/source/outdev/text.cxx   |  150 ++-
 vcl/source/outdev/textline.cxx   |   18 +-
 vcl/source/text/ImplLayoutArgs.cxx   |   18 ++
 vcl/unx/generic/gdi/cairotextrender.cxx  |   23 ++-
 vcl/unx/generic/print/genpspgraphics.cxx |4 
 vcl/win/gdi/DWriteTextRenderer.cxx   |   42 ++
 vcl/win/gdi/winlayout.cxx|   31 +++-
 43 files changed, 618 insertions(+), 404 deletions(-)

New commits:
commit f793891368d1fbe47b6dc119a89a1cd3e7a40082
Author: Caolán McNamara 
AuthorDate: Mon Dec 20 11:38:47 2021 +
Commit: Andras Timar 
CommitDate: Tue Mar 15 08:07:10 2022 +0100

tdf#144862 use resolution independent positions for writer's 
screen-rendering

in favor of pushing it down to the text renderers and leave
it to them to optimized as best they can the the rendering
to make it look as well as possible.

Change-Id: Ic0849c091a36e1a90453771b1c91b8ff706b679e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128418
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 
(cherry picked from commit 4ed26badfd6fd9190cb6e54078b41eb38cb37dca)

diff --git a/include/basegfx/tuple/Tuple2D.hxx 
b/include/basegfx/tuple/Tuple2D.hxx
index 2007732543b6..b173ad3033c1 100644
--- a/include/basegfx/tuple/Tuple2D.hxx
+++ b/include/basegfx/tuple/Tuple2D.hxx
@@ -73,6 +73,12 @@ public:
 /// Set Y-Coordinate of 2D Tuple
 void setY(TYPE fY) { mnY = fY; }
 
+/// Adjust X-Coordinate of 2D Tuple
+void adjustX(TYPE fX) { mnX += fX; }
+
+/// Adjust Y-Coordinate of 2D Tuple
+void adjustY(TYPE fY) { mnY += fY; }
+
 // comparators with tolerance
 
 template , int> 
= 0>
diff --git a/include/vcl/devicecoordinate.hxx b/include/vcl/devicecoordinate.hxx
index acece32cc204..bd0bf1ee7963 100644
--- a/include/vcl/devicecoordinate.hxx
+++ b/include/vcl/devicecoordinate.hxx
@@ -7,23 +7,22 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
-#ifndef INCLUDED_VCL_DEVICE_COORDINATE_HXX
-#define INCLUDED_VCL_DEVICE_COORDINATE_HXX
+#pragma once
 
 #include 
 #include 
 
-#if VCL_FLOAT_DEVICE_PIXEL
 #include 
+typedef basegfx::B2DPoint DevicePoint;
+
+#if VCL_FLOAT_DEVICE_PIXEL
+
 typedef double DeviceCoordinate;
 
 #else /* !VCL_FLOAT_DEVICE_PIXEL */
 
-#include 
 typedef sal_Int32 DeviceCoordinate;
 
 #endif /* ! Carpet Cushion */
 
-#endif /* NDef INCLUDED_VCL_DEVICE_COORDINATE_HXX */
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx
index e8011412955c..85670e44dec3 100644
--- a/include/vcl/outdev.hxx
+++ b/include/vcl/outdev.hxx
@@ -242,6 +242,7 @@ private:
 Point   maRefPoint;
 AntialiasingFlags   mnAntialiasing;
 LanguageTypemeTextLanguage;
+bool mbTextRenderModeForResolutionIndependentLayout;
 
 mutable boolmbMap : 1;
 mutable boolmbClipRegion : 1;
@@ -489,6 +490,10 @@ public:
 voidSetAntialiasing( 

[Libreoffice-bugs] [Bug 147963] WRITER: Endnotes composition not following standard formatting rules

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147963

--- Comment #2 from ajlittoz  ---
Update to my "Part B" statement:

Endnotes are in the note area of the Endnote page style, just the same as with
other styles. Endnote page style is configured with no separator.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 128610] "Import MathML from Clipboard", is broken on linux ( steps in comment 19 )

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128610

--- Comment #35 from Xisco Faulí  ---
Verified in

Version: 7.2.7.0.0+ / LibreOffice Community
Build ID: 6fb5a87e31b7df01f4b212ab979ae57e8d4ab4fb
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded

@Mike, thanks for fixing this issue!!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 121133] Adobe Reader DC claims that the PDF has been modified after signing

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121133

Kurt Russell  changed:

   What|Removed |Added

URL||https://greentrustcashappli
   ||cation.com

--- Comment #56 from Kurt Russell  ---
Hello! I'm Kurt Russell and I'm a new user. I've been working as Financial
advisor for over 3 yrs. I've a Bachelor of Commerce from NY, U.S.A. I've
assisted more than 100 clients in investing also help them to bring their
business at the top with digital means.  For more information you can visit my
blog which is related to Green Trust Cash App. Click here:-
https://greentrustcashapplication.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147921] Filesave DOC: wrong layout and then all missing from 7.3

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147921

--- Comment #15 from Xisco Faulí  ---
(In reply to Timur from comment #13)
> OK, I narrow down problem in headless:
> only for "--convert-to doc" and not for "--convert-to doc:"MS Word 97"
> But I always use doc because it should be enough, and not doc:"MS Word 97".

I always use '--convert-to doc' as well...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147921] Filesave DOC: wrong layout and then all missing from 7.3

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147921

--- Comment #14 from Timur  ---
This is not general --convert-to issue, but one that started with bibisected
commit and still bugged for me.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147921] Filesave DOC: wrong layout and then all missing from 7.3

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147921

--- Comment #13 from Timur  ---
OK, I narrow down problem in headless:
only for "--convert-to doc" and not for "--convert-to doc:"MS Word 97"
But I always use doc because it should be enough, and not doc:"MS Word 97".

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148002] Bangalore girls bangalore escorts

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148002

raal  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|UNCONFIRMED |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147464] Undo rejecting changes freezes LibreOffice; lots of time spend in SwRangeRedline::GetExtraData

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147464

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||8003

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148003] Lots of time spend in SwRangeRedline::GetExtraData in a Document with +/- 480 pages and lots of recorded track changes (file open/scrolling/rejecting changes)

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148003

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||7464

--- Comment #2 from Telesto  ---
Bug 147464 pretty similar (same type of file/author). So maybe focus on the
file open part?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148003] Lots of time spend in SwRangeRedline::GetExtraData in a Document with +/- 480 pages and lots of recorded track changes (file open/scrolling/rejecting changes)

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148003

--- Comment #1 from Telesto  ---
FWIW: Scrolling is smooth with 4.4.7.2

Rejecting changes is also slow with 4.4.7.2 . Populating the changes dialog
takes ages, but not a topic here). Rejecting all changes takes 180 seconds or
so.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148001] impossible to open XLSX file and other µsoft office file

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148001

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #2 from Xisco Faulí  ---
Thank you for reporting the bug. Please attach a sample document, as this makes
it easier for us to verify the bug. 
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' once the requested document is provided.
(Please note that the attachment will be public, remove any sensitive
information before attaching it. 
See
https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F
for help on how to do so.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148003] New: Lots of time spend in SwRangeRedline::GetExtraData in a Document with +/- 480 pages and lots of recorded track changes (file open/scrolling/rejecting changes)

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148003

Bug ID: 148003
   Summary: Lots of time spend in SwRangeRedline::GetExtraData in
a Document with +/- 480 pages and lots of recorded
track changes (file open/scrolling/rejecting changes)
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
Lots of time spend in SwRangeRedline::GetExtraData in a Document with +/- 480
pages and lots of recorded track changes (file open/scrolling/rejecting
changes)

Steps to Reproduce:
1. Open attachment 167497
2. Takes 110 seconds with 7.4 master and 45 seconds with 4.4.7.2
3. Press and hold page down .. or simply scroll with scroll wheel notice the
lag..
4. Edit Track Changes -> Reject all -> Start waiting.. 

Actual Results:
Slow file opening (and scrolling; press and hold page down) & try to reject
changes... 

Expected Results:
45 seconds


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 3ccc4c123f5e78e0204d11abeab2d1a74278ca3e
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140401] LibreOffice crashed on macOS Big Sur due to custom installed fonts

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140401

--- Comment #13 from Mike Little  ---
MacOS Hardware Overview:

  Model Name:   Mac mini
  Model Identifier: Macmini8,1
  Processor Name:   Quad-Core Intel Core i3
  Processor Speed:  3.6 GHz
  Number of Processors: 1
  Total Number of Cores:4
  L2 Cache (per Core):  256 KB
  L3 Cache: 6 MB
  Memory:   8 GB


System Software Version:

  System Version:   macOS 12.1 (21C52)
  Kernel Version:   Darwin 21.2.0


LibreOffice Version:
Version: 7.3.1.3 / LibreOffice Community
Build ID: 
CPU threads: 4; OS: Mac OS X 12.2.1; UI render: default; VCL: osx
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded



Procedure:

1.  Downloaded latest LibreOffice  release, 7.3.1.3   using MacPorts for
macOS x86_64.
2.  Downloaded the Hanazono Micho OTF fonts 

- Hanazono Mincho (HanaMin.sfont)
- Hanazono Mincho Ex A1 (HanaMinExA1.otf)
- Hanazono Mincho Ex A2 (HanaMinExA2.otf)
- Hanazono Mincho Ex B (HanaMinExB.otf)

from https://github.com/cjkvi/HanaMinAFDKO/releases


3.  Checked the contents of ~/librarcy/fonts, and fount it empty
4.  Copied the custom Hanazono Micho OTF fonts into  ~/librarcy/fonts.
5.  Opened the “Font Book” and under user, the Hanazono Micho OTF fonts
appear enabled.
6.  Started LibreOffice. Application opened.
7.  Open Writer, and wrote “This is test” with each of the custom
downloaded fonts.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sw/qa sw/source

2022-03-15 Thread Vasily Melenchuk (via logerrit)
 sw/qa/extras/odfexport/odfexport.cxx |2 -
 sw/qa/extras/ooxmlexport/data/tdf144563.docx |binary
 sw/qa/extras/ooxmlexport/ooxmlexport17.cxx   |   29 +++
 sw/qa/python/check_cross_references.py   |   10 -
 sw/source/core/doc/number.cxx|6 +
 5 files changed, 41 insertions(+), 6 deletions(-)

New commits:
commit 1a85d29bbc467354a5bc2d02e672fcdbffe5586d
Author: Vasily Melenchuk 
AuthorDate: Wed Mar 9 17:00:02 2022 +0300
Commit: Michael Stahl 
CommitDate: Tue Mar 15 11:36:38 2022 +0100

tdf#144563: remove final dot in cross-references to paragraph

It looks like in cross-references ending with dot (".") one last
dot is removed in case of MS Word. This is not a true for any other
suffixes after numeration.

Change-Id: I554e62cf45e643bf27823df5344e1689b5b6ae54
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131254
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 
Signed-off-by: Xisco Fauli 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131542
Reviewed-by: Michael Stahl 

diff --git a/sw/qa/extras/odfexport/odfexport.cxx 
b/sw/qa/extras/odfexport/odfexport.cxx
index f06778fc25b4..87e2aead4997 100644
--- a/sw/qa/extras/odfexport/odfexport.cxx
+++ b/sw/qa/extras/odfexport/odfexport.cxx
@@ -2794,7 +2794,7 @@ DECLARE_ODFEXPORT_TEST(testReferenceLanguage, 
"referencelanguage.odt")
 OUString const aFieldTexts[] = { "A 2", "Az Isten", "Az 50-esek",
 "A 2018-asok", "Az egyebek", "A fejezetek",
 u"Az „Őseinket...”", "a 2",
-"Az v.", "az 1", "Az e)", "az 1",
+"Az v", "az 1", "Az e)", "az 1",
 "Az (5)", "az 1", "A 2", "az 1" };
 uno::Reference xTextFieldsSupplier(mxComponent, 
uno::UNO_QUERY);
 // update "A (4)" to "Az (5)"
diff --git a/sw/qa/extras/ooxmlexport/data/tdf144563.docx 
b/sw/qa/extras/ooxmlexport/data/tdf144563.docx
new file mode 100644
index ..59d64d2d1bf3
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf144563.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
index ec07a5a946f0..52465ed66d90 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
@@ -12,6 +12,9 @@
 #include 
 
 #include 
+#include 
+#include 
+#include 
 
 #include 
 #include 
@@ -170,6 +173,32 @@ DECLARE_OOXMLEXPORT_TEST(testTdf81507, "tdf81507.docx")
 xmlXPathFreeObject(pXmlObj);
 }
 
+DECLARE_OOXMLEXPORT_TEST(testTdf144563, "tdf144563.docx")
+{
+uno::Reference xTextFieldsSupplier(mxComponent, 
uno::UNO_QUERY);
+uno::Reference 
xFieldsAccess(xTextFieldsSupplier->getTextFields());
+
+// Refresh all cross-reference fields
+uno::Reference(xFieldsAccess, 
uno::UNO_QUERY_THROW)->refresh();
+
+// Verify values
+uno::Reference 
xFields(xFieldsAccess->createEnumeration());
+
+std::vector aExpectedValues = {
+// These field values are NOT in order in document: getTextFields did 
provide
+// fields in a strange but fixed order
+"1", "1", "1", "1", "1/", "1/", "1/", "1)", "1)", "1)", "1.)",
+"1.)", "1.)", "1..", "1..", "1..", "1.", "1.", "1.", "1", "1"
+};
+
+sal_uInt16 nIndex = 0;
+while (xFields->hasMoreElements())
+{
+uno::Reference xTextField(xFields->nextElement(), 
uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(aExpectedValues[nIndex++], 
xTextField->getPresentation(false));
+}
+}
+
 DECLARE_OOXMLEXPORT_TEST(testTdf144668, "tdf144668.odt")
 {
 uno::Reference xPara1(getParagraph(1, u"level1"), 
uno::UNO_QUERY);
diff --git a/sw/qa/python/check_cross_references.py 
b/sw/qa/python/check_cross_references.py
index 3c9319200ea7..7778ff5f2100 100644
--- a/sw/qa/python/check_cross_references.py
+++ b/sw/qa/python/check_cross_references.py
@@ -89,16 +89,16 @@ class CheckCrossReferences(unittest.TestCase):
 FieldResult1 = "*i*"
 FieldResult2 = "+b+*i*"
 FieldResult3 = "-1-+b+*i*"
-FieldResult4 = "1."
-FieldResult5 = "1."
-FieldResult6 = "A.1."
+FieldResult4 = "1"
+FieldResult5 = "1"
+FieldResult6 = "A.1"
 FieldResult7 = " 2.(a)"
 FieldResult8 = " 2.(b)"
-FieldResult9 = " 2."
+FieldResult9 = " 2"
 FieldResult10 = " 1.(a)"
 FieldResult11 = "(b)"
 FieldResult12 = "(a)"
-FieldResult13 = " 1."
+FieldResult13 = " 1"
 
 # variables for current field
 xField = self.getNextField()
diff --git a/sw/source/core/doc/number.cxx b/sw/source/core/doc/number.cxx
index 93a5c149f15c..8a5b9c5d7c60 100644
--- a/sw/source/core/doc/number.cxx
+++ b/sw/source/core/doc/number.cxx
@@ -882,6 +882,12 @@ OUString SwNumRule::MakeRefNumString( const SwNodeNum& 
rNodeNum,
   pWorkingNodeNum->GetLevelInListTree() >= 
nRestrictInclToThisLevel );
 }
 
+if (aRefNumStr.endsWith("."))
+{

[Libreoffice-bugs] [Bug 136040] Undo doesn't restore text in columns (Hebrew?)

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136040

--- Comment #7 from Telesto  ---
Repro
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 3ccc4c123f5e78e0204d11abeab2d1a74278ca3e
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

STR
1. open the attached file
2. Scroll to page 11 (yellow marking) [not at the yellow marking, but below)
3. Place the cursor in a column
4. Press CTRL+A
5. Press backspace (missing in comment 0)
6. Press CTRL+Z

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147990] Misalignment of text when opening RTF.

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147990

m.a.riosv  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||miguelangelrv@libreoffice.o
   ||rg
 Status|UNCONFIRMED |NEEDINFO

--- Comment #1 from m.a.riosv  ---
Please attach a sample file.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147921] Filesave DOC: wrong layout and then all missing from 7.3

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147921

Timur  changed:

   What|Removed |Added

 CC||ilmari.lauhakangas@libreoff
   ||ice.org

--- Comment #12 from Timur  ---
Lin Headless DOC NOK in LO - empty for some, why?, NOK in MSO - cannot open
(this bug 147921 ?)
Lin GUI DOC OK in LO, OK in MSO (both resolved in bug 147921)
Win Headless DOC OK in LO, OK in MSO 
Win GUI DOC OK in LO, OK in MSO

Lin Headless DOCX OK in LO (resolved in bug 147921), NOK in MSO - image on the
left (bug 135943)
Lin GUI DOCX OK in LO, NOK in MSO - image left, same as headless
Win Headless DOCX OK in LO, NOK in MSO 
Win GUI DOCX OK in LO, NOK in MSO

Note: convert in Windows gives warnings:
warn:sw.core:3736:512:sw/source/core/docnode/node.cxx:1983: Wrong cond
collection, skipping check of Cond Colls.

I don't see why I see problem in Lin headless convert that Xisco doesn't see,
and that is the only issue left here.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 128610] "Import MathML from Clipboard", is broken on linux ( steps in comment 19 )

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128610

--- Comment #34 from Commit Notification 
 ---
Mike Kaganski committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/6fb5a87e31b7df01f4b212ab979ae57e8d4ab4fb

Related: tdf#128610 Avoid use-after-free

It will be available in 7.2.7.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 128610] "Import MathML from Clipboard", is broken on linux ( steps in comment 19 )

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128610

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.4.0 target:7.3.3   |target:7.4.0 target:7.3.3
   ||target:7.2.7

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - starmath/source

2022-03-15 Thread Mike Kaganski (via logerrit)
 starmath/source/view.cxx |   21 -
 1 file changed, 4 insertions(+), 17 deletions(-)

New commits:
commit 6fb5a87e31b7df01f4b212ab979ae57e8d4ab4fb
Author: Mike Kaganski 
AuthorDate: Fri Mar 11 15:19:41 2022 +0300
Commit: Michael Stahl 
CommitDate: Tue Mar 15 11:27:40 2022 +0100

Related: tdf#128610 Avoid use-after-free

Creating SvMemoryStream from string makes it non-owning, i.e. pointing
to the string's memory. So the string must outlive the stream.

Since commit 64bc8b45b5c23efc5fe57585a69aa4263aaf4e83
  Date   Wed Jul 08 12:31:43 2015 +
i#107734 Support for Math Input Panel in Windows 7

Was only working by chance, when destructor didn't clean the memory
(e.g., in optimized release builds) and the released memory hasn't
been reused yet.

Change-Id: I2e0c195de7bd2aff2889a94ef0f2eb084411933f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131373
Tested-by: Mike Kaganski 
Reviewed-by: Mike Kaganski 
(cherry picked from commit c964700d16d99d1569373a1eb9a1352fb3512915)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131474
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 
Signed-off-by: Xisco Fauli 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131541
Reviewed-by: Michael Stahl 

diff --git a/starmath/source/view.cxx b/starmath/source/view.cxx
index d369ad97db20..34b5572a5286 100644
--- a/starmath/source/view.cxx
+++ b/starmath/source/view.cxx
@@ -1774,31 +1774,18 @@ void SmViewShell::Execute(SfxRequest& rReq)
 SfxFilter::GetFilterByName(MATHML_XML);
 aClipboardMedium.SetFilter(pMathFilter);
 
-std::unique_ptr pStrm;
 // The text to be imported might asserts encoding 
like 'encoding="utf-8"' but FORMAT_STRING is UTF-16.
 // Force encoding to UTF-16, if encoding exists.
-bool bForceUTF16 = false;
 sal_Int32 nPosL = aString.indexOf("encoding=\"");
-sal_Int32 nPosU = -1;
 if ( nPosL >= 0 && nPosL +10 < aString.getLength() 
)
 {
 nPosL += 10;
-nPosU = aString.indexOf( '"',nPosL);
+sal_Int32 nPosU = aString.indexOf( '"',nPosL);
 if (nPosU > nPosL)
-{
-bForceUTF16 = true;
-}
+aString = aString.replaceAt(nPosL, nPosU - 
nPosL, u"UTF-16");
 }
-if ( bForceUTF16 )
-{
-OUString aNewString = aString.replaceAt( 
nPosL,nPosU-nPosL,"UTF-16");
-pStrm.reset(new SvMemoryStream( 
const_cast(aNewString.getStr()), aNewString.getLength() * 
sizeof(sal_Unicode), StreamMode::READ));
-}
-else
-{
-pStrm.reset(new SvMemoryStream( 
const_cast(aString.getStr()), aString.getLength() * 
sizeof(sal_Unicode), StreamMode::READ));
-}
-uno::Reference xStrm2( new 
::utl::OInputStreamWrapper(*pStrm) );
+SvMemoryStream aStrm( const_cast(aString.getStr()), aString.getLength() * sizeof(sal_Unicode), 
StreamMode::READ);
+uno::Reference xStrm2( new 
::utl::OInputStreamWrapper(aStrm) );
 aClipboardMedium.setStreamToLoadFrom(xStrm2, true 
/*bIsReadOnly*/);
 InsertFrom(aClipboardMedium);
 GetDoc()->UpdateText();


[Libreoffice-bugs] [Bug 148002] New: Bangalore girls bangalore escorts

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148002

Bug ID: 148002
   Summary: Bangalore  girls bangalore escorts
   Product: Impress Remote
   Version: 1.0.2
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: General
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: folad...@ema-sofia.eu

Description:
Discharge your everyday worry with our high profile independent Bangalore
escorts who spend significant time in giving comfort and joy. The
administrations are protected and secure at better than average rates. Book
now.

http://qooh.me/nikiescor
http://staffvibe.com/profile/19918
https://getinkspired.com/en/u/nikiescor5/
https://timetoriot.com/companies/list/1cbbf7eb-1f98-44c9-a883-3f583133979c
https://centralsterilizationschool.com/members/nikiescor5/
https://sustainabilityma.org/groups/female-model-escorts-service-in-bangalore/
https://purothemes.com/support/users/nikiescor5/

https://challonge.com/events/M5EJ
https://www.sexars.com/girl-profile/nikitha-escort-3295.html
https://platform.xr4all.eu/dibukiji
https://www.download.io/forum/members/nikiescor5.61717/
https://postheaven.net/3xqyulqo4w
https://kontakan.com/nikiescor5
https://www.emazoo.com/nikiescor5
https://pharmatalk.org/nikiescor5

Actual Results:
https://www.metooo.io/u/623063f991dc825e3ee68253
https://my.archdaily.com/us/@foladaru


Expected Results:
https://www.metooo.io/u/623063f991dc825e3ee68253
https://my.archdaily.com/us/@foladaru



Reproducible: Always


User Profile Reset: Yes



Additional Info:
https://www.metooo.io/u/623063f991dc825e3ee68253
https://my.archdaily.com/us/@foladaru
https://www.flightsim.com/vbfs/member.php?1140214-nikiescor5

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147982] On macOS Monterey LibreOffice 7.3 crashes about every day. This was also with previous versions of LibreOffice.

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147982

--- Comment #4 from m.a.riosv  ---
The profile, it's where LibreOffice saves your options.
In that menu follow in safe mode to verify if it works fine, if so, it's
something with your configuration. Better restart it.
https://help.libreoffice.org/latest/en-US/text/shared/01/profile_safe_mode.html?DbPAR=SHARED#bm_id281120160951421436

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148001] impossible to open XLSX file and other µsoft office file

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148001

alsuh...@free.fr changed:

   What|Removed |Added

Crash report or||F. D.
crash signature||

--- Comment #1 from alsuh...@free.fr ---
I tried with different computers. All are with WIN7 SP1 and latest os update.
No help!

Many Thanks to all the team working on L. O. software and kind regards,
François

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148001] New: impossible to open XLSX file and other µsoft office file

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148001

Bug ID: 148001
   Summary: impossible to open XLSX file and other µsoft office
file
   Product: LibreOffice
   Version: 7.2.4.1 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: alsuh...@free.fr

Description:
The opening of microsoft files is not possible with L.O. 
Please note that this operation was possible with the L.O. version 7.1 before

I experienced the same difficultis with othe type of document: Word and PPT. 

Herafter is the crash report (sorry in french!)

Signature du problème :
  Nom d’événement de problème:  APPCRASH
  Nom de l’application: soffice.bin
  Version de l’application: 7.2.6.2
  Horodatage de l’application:  62212f53
  Nom du module par défaut: ucrtbase.DLL
  Version du module par défaut: 10.0.10240.16390
  Horodateur du module par défaut:  55a5b718
  Code de l’exception:  4015
  Décalage de l’exception:  00065a5f
  Version du système:   6.1.7601.2.1.0.256.1
  Identificateur de paramètres régionaux:   1036
  Information supplémentaire n° 1:  6718
  Information supplémentaire n° 2:  67180ec2be69d610ef3eaacdd017451b
  Information supplémentaire n° 3:  b5f3
  Information supplémentaire n° 4:  b5f377a20d4cff7ee65eda7f44863fd3

Lire notre déclaration de confidentialité en ligne :
  http://go.microsoft.com/fwlink/?linkid=104288=0x040c

Si la déclaration de confidentialité en ligne n’est pas disponible, lisez la
version hors connexion :
  C:\Windows\system32\fr-FR\erofflps.txt


Steps to Reproduce:
1.open L.O.
2.open the file XLSX
3.

Actual Results:
The L.O. software didn't open the file an generate a message indicating it
stopped

Expected Results:
opening of the document


Reproducible: Always


User Profile Reset: No



Additional Info:
the safe mode did the same result

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 113209] [META] UI bugs and enhancements

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113209
Bug 113209 depends on bug 147954, which changed state.

Bug 147954 Summary: Use a subtle gradient with darker colors for the 
application background (behind the page "sheets")
https://bugs.documentfoundation.org/show_bug.cgi?id=147954

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103184] [META] UI theming bugs and enhancements

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103184
Bug 103184 depends on bug 147954, which changed state.

Bug 147954 Summary: Use a subtle gradient with darker colors for the 
application background (behind the page "sheets")
https://bugs.documentfoundation.org/show_bug.cgi?id=147954

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 125217] Replace Mozilla themes with a proprietary tool reusing the existing

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125217

Heiko Tietze  changed:

   What|Removed |Added

 CC||nekoh...@gmail.com

--- Comment #16 from Heiko Tietze  ---
*** Bug 147954 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 147954] Use a subtle gradient with darker colors for the application background (behind the page "sheets")

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147954

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #8 from Heiko Tietze  ---
To summarize, the idea was not accepted but would be an option for
personalization. Making it a duplicate.

*** This bug has been marked as a duplicate of bug 125217 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 147954] Use a subtle gradient with darker colors for the application background (behind the page "sheets")

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147954

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #8 from Heiko Tietze  ---
To summarize, the idea was not accepted but would be an option for
personalization. Making it a duplicate.

*** This bug has been marked as a duplicate of bug 125217 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135220] Different number of pages/ layout after CTRL+X undo

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135220

Michael Stahl (allotropia)  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |michael.st...@allotropia.de
   |desktop.org |

--- Comment #8 from Michael Stahl (allotropia)  ---
i got 397 pages, always.

fixed on master.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105948] [META] Undo/Redo bugs and enhancements

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105948
Bug 105948 depends on bug 135220, which changed state.

Bug 135220 Summary: Different number of pages/ layout after CTRL+X undo
https://bugs.documentfoundation.org/show_bug.cgi?id=135220

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135220] Different number of pages/ layout after CTRL+X undo

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135220

--- Comment #7 from Commit Notification 
 ---
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d9e38d5830ac278d7180b96fb6cefe3ee8ef6d76

tdf#135220 sw: fix layout after SwUndoDelete

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135220] Different number of pages/ layout after CTRL+X undo

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135220

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||  target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/source

2022-03-15 Thread Michael Stahl (via logerrit)
 sw/source/core/layout/flycnt.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit d9e38d5830ac278d7180b96fb6cefe3ee8ef6d76
Author: Michael Stahl 
AuthorDate: Mon Mar 14 19:11:21 2022 +0100
Commit: Michael Stahl 
CommitDate: Tue Mar 15 10:59:25 2022 +0100

tdf#135220 sw: fix layout after SwUndoDelete

The bugdoc is 398 pages after initial load and 397 pages after Undo.

There is really only one problem, on page 6 the fly frame 7370 "Figure
3: Hay Rake in Weeds" anchored on SwTextFrame 5896 should be on page 7
and aligned to the top of its paragraph.

First, 5986 moves forward from page 6 to 7, hitting the condition added
in commit c799de145f7e289f31e3669646e5bd12814e6c5e
debug:1170918:1170918: 
SwObjectFormatterTextFrame::CheckMovedFwdCondition(): 
o_rbPageHasFlysAnchoredBelowThis because next chain on same page

Then 5986 moves back to page 6.  When it is formatted there, the
ConsiderObjWrapInfluenceOnObjPos() is true, preventing a formatting of
the anchor frame - so it does not move forward.

The flag SetTmpConsiderWrapInfluence(true) was set the first time (when
it moved forward).

Setting this flag for any anchor frame that moves forward was added in
2005 in commit 46297c0923c50a12510c7b15b725c8d2fd80f9c0 and apparently
the only way the flag is cleared is when SwDoc's SetModified() is
called (or the frame is in a table or column).

So it is similar to the InsertMovedFwdFrame() case that was addressed by
commit c799de145f7e289f31e3669646e5bd12814e6c5e in that the flag should
not be set if bPageHasFlysAnchoredBelowThis is true.

(reportedly regression from sw_redlinehide
 commit 6c7245e789f973cf6dad03f7008ab3f9d12d350c)

Change-Id: I27b2a1becf5f7a760e74e801e23472116d0a5ced
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131560
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/sw/source/core/layout/flycnt.cxx b/sw/source/core/layout/flycnt.cxx
index 2ed6bb36b67a..5e9bdfe92ef0 100644
--- a/sw/source/core/layout/flycnt.cxx
+++ b/sw/source/core/layout/flycnt.cxx
@@ -426,7 +426,10 @@ void SwFlyAtContentFrame::MakeAll(vcl::RenderContext* 
pRenderContext)
 bAnchoredAtMaster, nToPageNum, bDummy,
 bPageHasFlysAnchoredBelowThis) )
 {
-bConsiderWrapInfluenceDueToMovedFwdAnchor = true;
+if (!bPageHasFlysAnchoredBelowThis)
+{
+bConsiderWrapInfluenceDueToMovedFwdAnchor = true;
+}
 // mark anchor text frame
 // directly, that it is moved forward by object positioning.
 SwTextFrame* pAnchorTextFrame( 
static_cast(AnchorFrame()) );


[Libreoffice-commits] core.git: hwpfilter/source

2022-03-15 Thread Michael Stahl (via logerrit)
 hwpfilter/source/hwpread.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 4c86ed851bc1c0a2414e254082064760c99437f1
Author: Michael Stahl 
AuthorDate: Fri Mar 11 17:29:41 2022 +0100
Commit: Michael Stahl 
CommitDate: Tue Mar 15 10:58:38 2022 +0100

hwpfilter: why isn't that path string null terminated

Change-Id: Iaedc23bd91d0d46e34d55dcc65760b73c5772b7e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131559
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/hwpfilter/source/hwpread.cxx b/hwpfilter/source/hwpread.cxx
index 85dd89a32f88..a1b9415f70b4 100644
--- a/hwpfilter/source/hwpread.cxx
+++ b/hwpfilter/source/hwpread.cxx
@@ -455,6 +455,7 @@ bool Picture::Read(HWPFile & hwpf)
 scale[1] = tmp16;
 
 hwpf.ReadBlock(picinfo.picun.path, 256);  /* Picture File Name: when 
type is not a Drawing. */
+picinfo.picun.path[255] = 0; // ensure null terminated
 hwpf.ReadBlock(reserved3, 9); /* Brightness / Contrast / 
Picture Effect, etc. */
 
 UpdateBBox(this);


[Libreoffice-bugs] [Bug 147999] Emojis displaying poorly in Presentation during presentation

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147999

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #1 from Xisco Faulí  ---
Thank you for reporting the bug. Please attach a sample document, as this makes
it easier for us to verify the bug. 
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' once the requested document is provided.
(Please note that the attachment will be public, remove any sensitive
information before attaching it. 
See
https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F
for help on how to do so.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148000] FILEOPEN PPTX: curved text doesn't line break properly and becomes too wide

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148000

--- Comment #1 from Gerald Pfeifer  ---
Created attachment 178894
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178894=edit
Visual comparison LibreOffice (left) vs Office 365 (right)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148000] New: FILEOPEN PPTX: curved text doesn't line break properly and becomes too wide

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148000

Bug ID: 148000
   Summary: FILEOPEN PPTX: curved text doesn't line break properly
and becomes too wide
   Product: LibreOffice
   Version: 6.4 all versions
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ger...@pfeifer.com

Created attachment 178893
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178893=edit
Sample slide (PPTX)

How to repeat:

 1. Open sample PPTX document in LibreOffice
 2. Compare with rendering in Office 365 and notice how the "Business..."
text is too wide and how the "Enterprise..." text fails to line break
and is too wide.

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: be1aab8632ead65d75c0436005d3cac7d43b9f02
CPU threads: 8; OS: Linux 5.16; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/CppunitTest_sc_sparkline_test.mk

2022-03-15 Thread Mike Kaganski (via logerrit)
 sc/CppunitTest_sc_sparkline_test.mk |4 
 1 file changed, 4 insertions(+)

New commits:
commit d3797ebe6fbd93bae27c6406a68a9154fa8401fd
Author: Mike Kaganski 
AuthorDate: Tue Mar 15 10:11:54 2022 +0300
Commit: Stephan Bergmann 
CommitDate: Tue Mar 15 10:45:16 2022 +0100

Fix no-PCH build

Failing locally with

  C:\lo\src\core\include\svl/poolitem.hxx(34): fatal error C1083: Cannot 
open include file: 'boost/property_tree/ptree_fwd.hpp': No such file or 
directory
  make[1]: *** [C:/lo/src/core/solenv/gbuild/LinkTarget.mk:344: 
C:/lo/src/build/workdir/CxxObject/sc/qa/unit/SparklineImportExportTest.o] Error 
2

Change-Id: I6d71a2a8da32ecb33faf470f7a5ddc0c7c8f4b1c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131577
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/sc/CppunitTest_sc_sparkline_test.mk 
b/sc/CppunitTest_sc_sparkline_test.mk
index 5dcd9a9921b5..92f121df7b35 100644
--- a/sc/CppunitTest_sc_sparkline_test.mk
+++ b/sc/CppunitTest_sc_sparkline_test.mk
@@ -35,6 +35,10 @@ $(eval $(call 
gb_CppunitTest_use_libraries,sc_sparkline_test, \
 vcl \
 ))
 
+$(eval $(call gb_CppunitTest_use_externals,sc_sparkline_test,\
+boost_headers \
+))
+
 $(eval $(call gb_CppunitTest_set_include,sc_sparkline_test,\
 -I$(SRCDIR)/sc/source/ui/inc \
 -I$(SRCDIR)/sc/inc \


[Libreoffice-commits] core.git: configure.ac

2022-03-15 Thread Tor Lillqvist (via logerrit)
 configure.ac |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 85adfa77911acb072a1a31f9e021e7a1707a2544
Author: Tor Lillqvist 
AuthorDate: Tue Mar 15 10:13:34 2022 +0200
Commit: Tor Lillqvist 
CommitDate: Tue Mar 15 10:42:38 2022 +0100

Accept iOS SDK 15.4

Change-Id: I53efea3dcc7308f2189d331a9f5ec52d0e610b42
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131581
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist 

diff --git a/configure.ac b/configure.ac
index f577a45423c7..1e26c8be4225 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3660,8 +3660,8 @@ dnl 
===
 
 if test $_os = iOS; then
 AC_MSG_CHECKING([what iOS SDK to use])
-current_sdk_ver=15.2
-older_sdk_vers="15.0 14.5"
+current_sdk_ver=15.4
+older_sdk_vers="15.2 15.0 14.5"
 if test "$enable_ios_simulator" = "yes"; then
 platform=iPhoneSimulator
 versionmin=-mios-simulator-version-min=13.6


[Libreoffice-commits] core.git: vcl/source

2022-03-15 Thread Michael Meeks (via logerrit)
 vcl/source/window/window.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 3d347d1e7835104156ff3cce0b5ea05cefa8ba15
Author: Michael Meeks 
AuthorDate: Fri Mar 11 17:23:43 2022 +
Commit: Michael Meeks 
CommitDate: Tue Mar 15 10:41:19 2022 +0100

Avoid segv when co-editing around SvxColorTabPage.

vcl::Window::ImplCallDeactivateListeners(vcl::Window*)
vcl/source/window/window.cxx:3403 (discriminator 2)
vcl::Window::ImplCallDeactivateListeners(vcl::Window*)
vcl/source/window/window.cxx:3404
...
vcl::Window::ImplCallDeactivateListeners(vcl::Window*)
vcl/source/window/window.cxx:3404
vcl::Window::ImplAsyncFocusHdl(void*)
include/rtl/ref.hxx:112
...
Dialog::Execute()
vcl/source/window/dialog.cxx:1056
virtual thunk to SalInstanceDialog::run()
vcl/source/app/salvtables.cxx:4924
AbstractSvxNameDialog_Impl::Execute()
cui/source/factory/dlgfact.cxx:222
SvxColorTabPage::ClickAddHdl_Impl(weld::Button&)
include/rtl/ref.hxx:192

Change-Id: I12a78d65a8e7b8b728dde84f7c51cc19005c9aa6
Signed-off-by: Michael Meeks 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131353
Tested-by: Jenkins

diff --git a/vcl/source/window/window.cxx b/vcl/source/window/window.cxx
index 453bf8e2ca14..180aa4a78dd2 100644
--- a/vcl/source/window/window.cxx
+++ b/vcl/source/window/window.cxx
@@ -3412,7 +3412,8 @@ void Window::ImplCallDeactivateListeners( vcl::Window 
*pNew )
 
 // #100759#, avoid walking the wrong frame's hierarchy
 //   eg, undocked docking windows (ImplDockFloatWin)
-if ( ImplGetParent() && mpWindowImpl->mpFrameWindow == 
ImplGetParent()->mpWindowImpl->mpFrameWindow )
+if ( ImplGetParent() && ImplGetParent()->mpWindowImpl &&
+ mpWindowImpl->mpFrameWindow == 
ImplGetParent()->mpWindowImpl->mpFrameWindow )
 ImplGetParent()->ImplCallDeactivateListeners( pNew );
 }
 }


[Libreoffice-bugs] [Bug 113117] [META] Windows installer/uninstaller bugs and enhancements

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113117
Bug 113117 depends on bug 93083, which changed state.

Bug 93083 Summary: Uninstall leaves folder "LibreOffice 5" with empty subfolders
https://bugs.documentfoundation.org/show_bug.cgi?id=93083

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 93083] Uninstall leaves folder "LibreOffice 5" with empty subfolders

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93083

Regina Henschel  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #5 from Regina Henschel  ---
Does not happen with LO 7.4.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147999] New: Emojis displaying poorly in Presentation during presentation

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147999

Bug ID: 147999
   Summary: Emojis displaying poorly in Presentation during
presentation
   Product: LibreOffice
   Version: 7.1.3.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ddraise...@gmail.com

Description:
When I enter presentation mode in LibreOffice Presentation file that contains
emotes (mine were large, about 150-300 size), the emojis display squashed, even
though the emotes appear normally when outside the presentation.

Steps to Reproduce:
1. Insert emoji into text
2. (Optional) Make emoji large
3. Start presentation from current slide

Actual Results:
The emoji becomes warped.

Expected Results:
The emoji retains its size like the one seen during the editing of the
presentation


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.3.2 (x64) / LibreOffice Community
Build ID: 47f78053abe362b9384784d31a6e56f8511eb1c1
CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: en-US (en_CH); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147905] LibreOffice Calc 7.3.1: PROPER function in long table leads to wrong capitalization

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147905

--- Comment #14 from Commit Notification 
 ---
Xisco Fauli committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/111b6d6c0421f78e383df24d05442b9fe943424a

tdf#147905: sc_parallelism: Add unittest

It will be available in 7.3.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sc/qa

2022-03-15 Thread Xisco Fauli (via logerrit)
 sc/qa/unit/parallelism.cxx |   30 ++
 1 file changed, 30 insertions(+)

New commits:
commit 111b6d6c0421f78e383df24d05442b9fe943424a
Author: Xisco Fauli 
AuthorDate: Mon Mar 14 16:23:57 2022 +0100
Commit: Xisco Fauli 
CommitDate: Tue Mar 15 10:23:23 2022 +0100

tdf#147905: sc_parallelism: Add unittest

Change-Id: Ib71a30d7ef8d907c1fd86e35d3e6cae5c15218bf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131549
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 
(cherry picked from commit bee6568ae5d49f5b697740a23c5a1c6775f64d52)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131483

diff --git a/sc/qa/unit/parallelism.cxx b/sc/qa/unit/parallelism.cxx
index 37dcd79e546c..5fc47c23304d 100644
--- a/sc/qa/unit/parallelism.cxx
+++ b/sc/qa/unit/parallelism.cxx
@@ -35,6 +35,7 @@ public:
 void testVLOOKUP();
 void testVLOOKUPSUM();
 void testSingleRef();
+void testTdf147905();
 void testSUMIFImplicitRange();
 void testFGCycleWithPlainFormulaCell1();
 void testFGCycleWithPlainFormulaCell2();
@@ -54,6 +55,7 @@ public:
 CPPUNIT_TEST(testVLOOKUP);
 CPPUNIT_TEST(testVLOOKUPSUM);
 CPPUNIT_TEST(testSingleRef);
+CPPUNIT_TEST(testTdf147905);
 CPPUNIT_TEST(testSUMIFImplicitRange);
 CPPUNIT_TEST(testFGCycleWithPlainFormulaCell1);
 CPPUNIT_TEST(testFGCycleWithPlainFormulaCell2);
@@ -400,6 +402,34 @@ void ScParallelismTest::testSingleRef()
 m_pDoc->DeleteTab(0);
 }
 
+void ScParallelismTest::testTdf147905()
+{
+m_pDoc->InsertTab(0, "1");
+
+OUString aFormula;
+const size_t nNumRows = 500;
+for (size_t i = 0; i < nNumRows; ++i)
+{
+m_pDoc->SetString(0, i, 0, "");
+aFormula = "=PROPER($A" + OUString::number(i+1) + ")";
+m_pDoc->SetFormula(ScAddress(1, i, 0),
+   aFormula,
+   formula::FormulaGrammar::GRAM_NATIVE_UI);
+}
+
+m_xDocShell->DoHardRecalc();
+
+for (size_t i = 0; i < nNumRows; ++i)
+{
+OString aMsg = "At row " + OString::number(i);
+CPPUNIT_ASSERT_EQUAL_MESSAGE(aMsg.getStr(), OUString(""), 
m_pDoc->GetString(0, i, 0));
+
+// Without the fix in place, this test would have failed here
+CPPUNIT_ASSERT_EQUAL_MESSAGE(aMsg.getStr(), OUString("Aaaa"), 
m_pDoc->GetString(1, i, 0));
+}
+m_pDoc->DeleteTab(0);
+}
+
 // Common test setup steps for testSUMIFImplicitRange*()
 static void lcl_setupCommon(ScDocument* pDoc, size_t nNumRows, size_t 
nConstCellValue)
 {


[Libreoffice-bugs] [Bug 147998] App overlay icons are blurry

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147998

Rizal Muttaqin  changed:

   What|Removed |Added

Summary|Mime type overlay icons are |App overlay icons are
   |blurry  |blurry

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 61914] [META] Start Center bugs and enhancements

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=61914

Rizal Muttaqin  changed:

   What|Removed |Added

 Depends on||147998


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=147998
[Bug 147998] Mime type overlay icons are blurry
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147998] Mime type overlay icons are blurry

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147998

Rizal Muttaqin  changed:

   What|Removed |Added

 Blocks||61914


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=61914
[Bug 61914] [META] Start Center bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147998] New: Mime type overlay icons are blurry

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147998

Bug ID: 147998
   Summary: Mime type overlay icons are blurry
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: riz...@libreoffice.org

Created attachment 178892
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178892=edit
Blurry Icons in Start Center

In the Start Center, tdf#125756 give additional icon as a overlay. Assuming
this icon is an app icon for now but they are somehow blurry. This is occurs in
my work laptop (1920x1080) as well as my personal laptop (1360x768)


I can help to add additional icon size if needed, but something should be
adjusted in coding part

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: d156995180b565f34b52859aa1d6953995a76b9a
CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb)
Locale: id-ID (id_ID.UTF-8); UI: id-ID
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141039] mouse over

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141039

--- Comment #7 from Paul Mourick  ---
alles OK

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sfx2/source

2022-03-15 Thread Mike Kaganski (via logerrit)
 sfx2/source/control/recentdocsviewitem.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b70d17b08a7f24e4c470831910e63493082e0874
Author: Mike Kaganski 
AuthorDate: Tue Mar 15 11:13:09 2022 +0300
Commit: Mike Kaganski 
CommitDate: Tue Mar 15 10:12:07 2022 +0100

Round calculation to avoid blurry default icons

Having the paper of 21000 x 29700, and nThumbnailSize of 256, the
ratio is 0.0086195286195286195; aThumbnailSize would be calculated
from 255.99915 x 181.0101010101010095; truncation will
make the end result 255 x 181, and after drawing the icon on that,
it will be stretched to 256x256 (so there will be 255->256 scale).

Change-Id: Ic7d37206b42e2229b36161c215a36e4b71486802
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131582
Tested-by: Mike Kaganski 
Reviewed-by: Mike Kaganski 

diff --git a/sfx2/source/control/recentdocsviewitem.cxx 
b/sfx2/source/control/recentdocsviewitem.cxx
index 6f046e3dc6e8..5741f59b2108 100644
--- a/sfx2/source/control/recentdocsviewitem.cxx
+++ b/sfx2/source/control/recentdocsviewitem.cxx
@@ -81,7 +81,7 @@ RecentDocsViewItem::RecentDocsViewItem(sfx2::RecentDocsView 
, const OUStri
 nPaperWidth = aInfo.getWidth();
 }
 double ratio = double(nThumbnailSize) / double(std::max(nPaperHeight, 
nPaperWidth));
-Size aThumbnailSize(nPaperWidth * ratio, nPaperHeight * ratio);
+Size aThumbnailSize(std::round(nPaperWidth * ratio), 
std::round(nPaperHeight * ratio));
 
 if (aExtSize.Width() > aThumbnailSize.Width() || aExtSize.Height() > 
aThumbnailSize.Height())
 {


[Libreoffice-bugs] [Bug 122619] Remove AppMenu export via DBus

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122619

Buovjaga  changed:

   What|Removed |Added

 CC||ilmari.lauhakangas@libreoff
   ||ice.org
 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #11 from Buovjaga  ---
No response from Björn in years, so let's close to avoid future noise.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: connectivity/source

2022-03-15 Thread Stephan Bergmann (via logerrit)
 connectivity/source/drivers/macab/MacabHeader.cxx  |4 
 connectivity/source/drivers/macab/MacabHeader.hxx  |1 -
 connectivity/source/drivers/macab/MacabRecords.cxx |5 -
 connectivity/source/drivers/macab/MacabRecords.hxx |1 -
 4 files changed, 11 deletions(-)

New commits:
commit d0c2c78725f5f50e3f2d08b3495cda6ec03b4297
Author: Stephan Bergmann 
AuthorDate: Tue Mar 15 08:35:42 2022 +0100
Commit: Stephan Bergmann 
CommitDate: Tue Mar 15 09:53:06 2022 +0100

loplugin:trivialdestructor (macOS)

Change-Id: I4f379f9f5c848e8fb01b05591d8a80a45719b43b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131578
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/connectivity/source/drivers/macab/MacabHeader.cxx 
b/connectivity/source/drivers/macab/MacabHeader.cxx
index 46f0c177d3fc..da270dd05ac8 100644
--- a/connectivity/source/drivers/macab/MacabHeader.cxx
+++ b/connectivity/source/drivers/macab/MacabHeader.cxx
@@ -290,10 +290,6 @@ MacabHeader::iterator::iterator ()
 }
 
 
-MacabHeader::iterator::~iterator ()
-{
-}
-
 MacabHeader::iterator& MacabHeader::iterator::operator= (MacabHeader *_record)
 {
 id = 0;
diff --git a/connectivity/source/drivers/macab/MacabHeader.hxx 
b/connectivity/source/drivers/macab/MacabHeader.hxx
index a230d237ab72..24b3fc7b0b9c 100644
--- a/connectivity/source/drivers/macab/MacabHeader.hxx
+++ b/connectivity/source/drivers/macab/MacabHeader.hxx
@@ -50,7 +50,6 @@ namespace connectivity::macab
 public:
 iterator& operator= (MacabHeader *_record);
 iterator();
-~iterator();
 void operator++ ();
 bool operator!= (const sal_Int32 i) const;
 bool operator== (const sal_Int32 i) const;
diff --git a/connectivity/source/drivers/macab/MacabRecords.cxx 
b/connectivity/source/drivers/macab/MacabRecords.cxx
index 4c2d4aed8fa1..17ee6585d45c 100644
--- a/connectivity/source/drivers/macab/MacabRecords.cxx
+++ b/connectivity/source/drivers/macab/MacabRecords.cxx
@@ -1099,11 +1099,6 @@ MacabRecords::iterator::iterator ()
 }
 
 
-MacabRecords::iterator::~iterator ()
-{
-}
-
-
 MacabRecords::iterator& MacabRecords::iterator::operator= (MacabRecords 
*_records)
 {
 id = 0;
diff --git a/connectivity/source/drivers/macab/MacabRecords.hxx 
b/connectivity/source/drivers/macab/MacabRecords.hxx
index 004d10b1b6d2..8d0d5cf6f796 100644
--- a/connectivity/source/drivers/macab/MacabRecords.hxx
+++ b/connectivity/source/drivers/macab/MacabRecords.hxx
@@ -113,7 +113,6 @@ namespace connectivity::macab
 sal_Int32 id;
 iterator& operator= (MacabRecords *_records);
 iterator();
-~iterator();
 void operator++ ();
 bool operator!= (const sal_Int32 i) const;
 bool operator== (const sal_Int32 i) const;


[Libreoffice-commits] core.git: vcl/inc

2022-03-15 Thread Caolán McNamara (via logerrit)
 vcl/inc/win/wingdiimpl.hxx |   10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

New commits:
commit 1b04fbca0dc7a49aa5acc799396ef993471a992d
Author: Caolán McNamara 
AuthorDate: Mon Mar 14 20:40:53 2022 +
Commit: Caolán McNamara 
CommitDate: Tue Mar 15 09:40:50 2022 +0100

drop some redundant semicolons

Change-Id: Ib09ac9cfec70f803b23b28b0c0a8031620436e9f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131563
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/inc/win/wingdiimpl.hxx b/vcl/inc/win/wingdiimpl.hxx
index 6fc08f0a355a..5abf86e6e36f 100644
--- a/vcl/inc/win/wingdiimpl.hxx
+++ b/vcl/inc/win/wingdiimpl.hxx
@@ -19,7 +19,7 @@ class ControlCacheKey;
 class WinSalGraphicsImplBase
 {
 public:
-virtual ~WinSalGraphicsImplBase(){};
+virtual ~WinSalGraphicsImplBase() {}
 
 // If true is returned, the following functions are used for drawing 
controls.
 virtual bool UseRenderNativeControl() const { return false; }
@@ -27,17 +27,17 @@ public:
   int /*nX*/, int /*nY*/)
 {
 abort();
-};
+}
 virtual bool RenderAndCacheNativeControl(CompatibleDC& /*rWhite*/, 
CompatibleDC& /*rBlack*/,
  int /*nX*/, int /*nY*/,
  ControlCacheKey& 
/*aControlCacheKey*/)
 {
 abort();
-};
+}
 
-virtual void ClearDevFontCache(){};
+virtual void ClearDevFontCache() {}
 
-virtual void Flush(){};
+virtual void Flush() {}
 
 // Implementation for WinSalGraphics::DrawTextLayout().
 // Returns true if handled, if false, then WinSalGraphics will handle it 
itself.


[Libreoffice-bugs] [Bug 141026] Lock files and privacy (leaking user and computer name)

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141026

Heiko Tietze  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |urss...@gmail.com
   |desktop.org |
 Status|NEW |ASSIGNED

--- Comment #8 from Heiko Tietze  ---
(In reply to Siddhant Chaudhary from comment #7)
> Hi. I would like to work on this issue. 

Great! To learn how exactly the code works you could debug
uui/source/iahndl.cxx UUIInteractionHelper::replaceMessageWithArguments().

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103378

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||147284


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=147284
[Bug 147284] Time required to export a large document has doubled for Latin
(Win?)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147284] Time required to export a large document has doubled for Latin (Win?)

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147284

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru
 Blocks||103378


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103378
[Bug 103378] [META] PDF export bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 64314] [META] Macro recording issues

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=64314
Bug 64314 depends on bug 147761, which changed state.

Bug 147761 Summary: Record macro, does not record "sort"
https://bugs.documentfoundation.org/show_bug.cgi?id=147761

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147992] Azril

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147992

raal  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||r...@post.cz
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147994] Azril

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147994

raal  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 CC||r...@post.cz
 Status|UNCONFIRMED |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 122619] Remove AppMenu export via DBus

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122619

--- Comment #10 from Konstantin  ---
This is a bug to request a feature removal. It is a bad practice bug, and this
feature is used now (but not by Ubuntu, yes, but by HUD applications). 
And you need GMenuModel for GTK4. So, I think this bug should be closed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147993] Azril

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147993

raal  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143317] Base crashes viewing / browsing mysql database table using direct mysql connector

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143317

Robert Großkopf  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||7997

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147997] MySQL/MariaDB: Dialog for direct connection should be changed from MySQL to MariaDB

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147997

Robert Großkopf  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||3317

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147997] New: MySQL/MariaDB: Dialog for direct connection should be changed from MySQL to MariaDB

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147997

Bug ID: 147997
   Summary: MySQL/MariaDB: Dialog for direct connection should be
changed from MySQL to MariaDB
   Product: LibreOffice
   Version: 7.3.1.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rob...@familiegrosskopf.de

Since LO 6.2 the direct connection for MariaDB is included in LO:
https://wiki.documentfoundation.org/ReleaseNotes/6.2#Base

Start LO.
Click on "Base Database"
Connect to an existing database.
Choose MySQL (should be changed to MySQL/MariaDB)
Next (Step 2) → Connect directly (Step 2 should be changed from "Setup MySQL
Connection" to …MySQL/MariaDB…)
Step 3 now declares to be a connection to MySQL, also the dialog declares to
connect to MySQL. But the connection we are using is a MariaDB-connection.

Nobody cares about this, because there was no essential difference between
MySQL and MariaDB when creating the direct connection with MariaDB. But with
newer versions of MySQL the connection could be buggy together with MySQL. So
we should show it is a MariaDB-connector we are using, not a MySQL-connector.

See, for example, https://bugs.documentfoundation.org/show_bug.cgi?id=143317

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147996] New: keyboardshortcut font-color doesn't work

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147996

Bug ID: 147996
   Summary: keyboardshortcut font-color doesn't work
   Product: LibreOffice
   Version: 7.1.6.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mey@web.de

Description:
in older versions I could assign a shortcut to font-color (german:
Zeichenfarbe)

I could select some text in writer, the press the shortcut and the selected
text became colored with the font-color used last time before.

Now there are two problems:

1. in the menu, where I can (re)assign keyboard-shortcuts, there appears
"Zeichenfarbe" (font-color) twice. No one works.

2. the font color used last time (button in a bar) changes back to a
default-color after a while - formerly it didn't change automatically, but only
could be changed by the user, which I prefere!!

Steps to Reproduce:
1. change font-color for some text
2. reassign shortcut to font-color (Zeichenfarbe) 
3. select some text
4. press the shortcut defined before

Actual Results:
1. some time later the choosen font color changes back (button in a bar)
4. nothing happens or (there are two "Zeichenfarbe"-commands, which can be
assigned to a shortcut) it opens a font-property-dialog-window

Expected Results:
1. the font-color used last time should stay
2. there are several commands several times in the shortcut-reassigning-dialog
- it would be better to use every name only once and make clear, what it means
4. pressing the shortcut should just make the selected text colored with the
font-color choosen last time before


Reproducible: Always


User Profile Reset: No



Additional Info:
In older versions it worked fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147981] Improving Spanish translation for «mayusculación» (LO Writer UI)

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147981

--- Comment #3 from Camaleón  ---
I miss the notion of the iterative action here.

I mean, «Cycle case» goes through a loop of actions (Aaa → AAA → aaa → Aaa...):

action 1 → action 2 → action 3 → action 1 → action 2 → action 3 (and so on)

In Spanish that nuance is hard to describe with just one word (maybe "Iterar
cambio de mayúsculas"). 

Note sure what other Spanish speaking users think.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141039] mouse over

2022-03-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141039

Dieter  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: helpcontent2

2022-03-15 Thread Stephan Bergmann (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0a9838700ba31ce6fc16015de68949e47d984d07
Author: Stephan Bergmann 
AuthorDate: Tue Mar 15 08:33:13 2022 +0100
Commit: Gerrit Code Review 
CommitDate: Tue Mar 15 08:33:13 2022 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 14b884e807078b67f47d8615df2e4c2e363890ed
  - Revert "Update Clac Tools menu with Forms submenu"

This reverts commit 31f0c48d3bc30742d49af32ac9686d71f8aa7215, because
it broke the build, presumably because it forgot to add
helpcontent2/source/text/shared/menu/forms.xhp as a new file.

Change-Id: Ie51a7683f254b0439bbbc2e563ba943b8f98e02a
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131486
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/helpcontent2 b/helpcontent2
index 31f0c48d3bc3..14b884e80707 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 31f0c48d3bc30742d49af32ac9686d71f8aa7215
+Subproject commit 14b884e807078b67f47d8615df2e4c2e363890ed


[Libreoffice-commits] help.git: AllLangHelp_shared.mk source/text

2022-03-15 Thread Stephan Bergmann (via logerrit)
 AllLangHelp_shared.mk  |1 -
 source/text/scalc/00/0406.xhp  |2 --
 source/text/scalc/main0106.xhp |4 
 source/text/shared/02/01170400.xhp |   23 ++-
 source/text/shared/guide/dev_tools.xhp |7 ++-
 source/text/swriter/main0120.xhp   |   18 ++
 6 files changed, 18 insertions(+), 37 deletions(-)

New commits:
commit 14b884e807078b67f47d8615df2e4c2e363890ed
Author: Stephan Bergmann 
AuthorDate: Tue Mar 15 08:29:01 2022 +0100
Commit: Stephan Bergmann 
CommitDate: Tue Mar 15 08:33:11 2022 +0100

Revert "Update Clac Tools menu with Forms submenu"

This reverts commit 31f0c48d3bc30742d49af32ac9686d71f8aa7215, because
it broke the build, presumably because it forgot to add
helpcontent2/source/text/shared/menu/forms.xhp as a new file.

Change-Id: Ie51a7683f254b0439bbbc2e563ba943b8f98e02a
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131486
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/AllLangHelp_shared.mk b/AllLangHelp_shared.mk
index 344f2bc4d..2f3c9b40a 100644
--- a/AllLangHelp_shared.mk
+++ b/AllLangHelp_shared.mk
@@ -777,7 +777,6 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,shared,\
 helpcontent2/source/text/shared/main0800 \
 helpcontent2/source/text/shared/submenu_text \
 helpcontent2/source/text/shared/submenu_spacing \
-helpcontent2/source/text/shared/menu/forms \
 helpcontent2/source/text/shared/menu/insert_chart \
 helpcontent2/source/text/shared/menu/insert_form_control \
 helpcontent2/source/text/shared/menu/insert_shape \
diff --git a/source/text/scalc/00/0406.xhp 
b/source/text/scalc/00/0406.xhp
index 64239b361..6fee82076 100644
--- a/source/text/scalc/00/0406.xhp
+++ b/source/text/scalc/00/0406.xhp
@@ -51,8 +51,6 @@
 Choose Tools - Solver, click 
Options button.
 Choose Tools - Scenarios.
 
-Choose Tools - Forms.
-
 Choose Tools - Share 
Spreadsheet
 
 Choose Tools - Protect 
Sheet.
diff --git a/source/text/scalc/main0106.xhp b/source/text/scalc/main0106.xhp
index 908491258..c1b38cb18 100644
--- a/source/text/scalc/main0106.xhp
+++ b/source/text/scalc/main0106.xhp
@@ -54,15 +54,11 @@
 Scenarios
 
 
-
-
 
 
 
 
 
-
-
 
 
 Customize
diff --git a/source/text/shared/02/01170400.xhp 
b/source/text/shared/02/01170400.xhp
index 6df2946e5..70ba11085 100644
--- a/source/text/shared/02/01170400.xhp
+++ b/source/text/shared/02/01170400.xhp
@@ -1,4 +1,7 @@
 
+
+
+
 
-
+
+
+   
 
 
 Add Field
@@ -25,21 +30,13 @@
 
 
 
-
-database field;add to form
-forms;add database field
-database field;add to report
-report;add database field
-
-
-Add Field
-Opens a window where you can select a 
database field to add to the form or report.same 
help id used for forms and reports
-
+Add Field
+Opens a window where you can select a 
database field to add to the form or report.
+same help id used for forms and 
reports
 
   
 
-
-The field selection window lists all database fields of the 
table or query that was specified as the data source in the Form 
Properties.
+The field selection window lists 
all database fields of the table or query that was specified as the data source 
in the Form 
Properties.
 You can insert 
a field into the current document by dragging and dropping. A field is then 
inserted which contains a link to the database.
 If you add 
fields to a form and you switch off the Design Mode, you 
can see that $[officename] adds a labeled input field for every inserted 
database field.may be different for reports
 
diff --git a/source/text/shared/guide/dev_tools.xhp 
b/source/text/shared/guide/dev_tools.xhp
index 5463a7312..1b905c3f0 100644
--- a/source/text/shared/guide/dev_tools.xhp
+++ b/source/text/shared/guide/dev_tools.xhp
@@ -31,11 +31,8 @@
   
   
   
-
-Development 
Tools
-Inspects objects in 
%PRODUCTNAME documents and shows supported UNO services, as well as available 
methods, properties and implemented interfaces.
-
-This feature also 
allows to explore the document structure using the Document Object Model 
(DOM).
+  Development 
Tools
+  Inspects objects in 
%PRODUCTNAME documents and shows supported UNO services, as well as available 
methods, properties and implemented interfaces. This feature also allows to 
explore the document structure using the Document Object Model 
(DOM).
   
 Choose 
Tools - Development Tools
 
diff --git a/source/text/swriter/main0120.xhp b/source/text/swriter/main0120.xhp
index 61582ff91..d0571c0b0 100644
--- a/source/text/swriter/main0120.xhp
+++ b/source/text/swriter/main0120.xhp
@@ -19,16 +19,12 @@
 
 
 Form
-Contains commands for 
activate form design mode, open control wizards and insert form controls in 
your document.
+Contains commands for activate form design mode, open control wizards 
and insert form controls in your text document.
 
-
-Design Mode
-

[Libreoffice-commits] core.git: Branch 'distro/mimo/mimo-7-1' - 13 commits - bin/lo-all-static-libs config_host.mk.in configure.ac dictionaries download.lst external/expat external/libwebp external/Mo

2022-03-15 Thread Caolán McNamara (via logerrit)
Rebased ref, commits from common ancestor:
commit 881af695e5ae56aee3ec8534ccec4d75db2a251b
Author: Caolán McNamara 
AuthorDate: Sat Feb 19 16:53:58 2022 +
Commit: Andras Timar 
CommitDate: Mon Mar 14 21:59:41 2022 +0100

upgrade expat to 2.4.5

CVE-2022-25235
CVE-2022-25236
CVE-2022-25313
CVE-2022-25314
CVE-2022-25315

Change-Id: I1cb0449411fe938fe47ab47cead685fd04e137dd

diff --git a/download.lst b/download.lst
index 0a7624c2d47d..fcc06ceb31d7 100644
--- a/download.lst
+++ b/download.lst
@@ -52,8 +52,8 @@ export EPUBGEN_TARBALL := libepubgen-0.1.1.tar.xz
 export ETONYEK_SHA256SUM := 
e61677e8799ce6e55b25afc11aa5339113f6a49cff031f336e32fa58635b1a4a
 export ETONYEK_VERSION_MICRO := 9
 export ETONYEK_TARBALL := libetonyek-0.1.$(ETONYEK_VERSION_MICRO).tar.xz
-export EXPAT_SHA256SUM := 
5963005ff8720735beb2d2db669afc681adcbcb43dd1eb397d5c2dd7adbc631f
-export EXPAT_TARBALL := expat-2.4.4.tar.gz
+export EXPAT_SHA256SUM := 
f2af8fc7cdc63a87920da38cd6d12cb113c3c3a3f437495b1b6541e0cff32579
+export EXPAT_TARBALL := expat-2.4.5.tar.xz
 export FIREBIRD_SHA256SUM := 
6994be3555e23226630c587444be19d309b25b0fcf1f87df3b4e3f88943e5860
 export FIREBIRD_TARBALL := Firebird-3.0.0.32483-0.tar.bz2
 export FONTCONFIG_SHA256SUM := 
19e5b1bc9d013a52063a44e1307629711f0bfef35b9aca16f9c793971e2eb1e5
diff --git a/external/expat/expat-winapi.patch 
b/external/expat/expat-winapi.patch
index bd4da1472fc8..7eae7d5d6139 100644
--- a/external/expat/expat-winapi.patch
+++ b/external/expat/expat-winapi.patch
@@ -13,15 +13,12 @@
  
 --- misc/expat-2.1.0/lib/xmlparse.c2021-05-23 16:56:25.0 +0100
 +++ misc/build/expat-2.1.0/lib/xmlparse.c  2021-05-25 12:42:11.997173600 
+0100
-@@ -92,6 +92,11 @@
+@@ -64,6 +64,8 @@
+ #endif
  
- #include 
- 
-+#ifdef _WIN32
+ #ifdef _WIN32
 +#  undef HAVE_GETRANDOM
 +#  undef HAVE_SYSCALL_GETRANDOM
-+#endif
-+
- #include "ascii.h"
- #include "expat.h"
- #include "siphash.h"
+ /* force stdlib to define rand_s() */
+ #  if ! defined(_CRT_RAND_S)
+ #define _CRT_RAND_S
commit 9d547512d81b72ed20b0fafbd1e2a1cc41ac802b
Author: Caolán McNamara 
AuthorDate: Sun Jan 30 19:28:23 2022 +
Commit: Andras Timar 
CommitDate: Mon Mar 14 21:59:40 2022 +0100

upgrade to expat 2.4.4

Change-Id: Ie141268793dc4332d8c253bec4e986894682c7a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129179
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/download.lst b/download.lst
index 281e485ed588..0a7624c2d47d 100644
--- a/download.lst
+++ b/download.lst
@@ -52,8 +52,8 @@ export EPUBGEN_TARBALL := libepubgen-0.1.1.tar.xz
 export ETONYEK_SHA256SUM := 
e61677e8799ce6e55b25afc11aa5339113f6a49cff031f336e32fa58635b1a4a
 export ETONYEK_VERSION_MICRO := 9
 export ETONYEK_TARBALL := libetonyek-0.1.$(ETONYEK_VERSION_MICRO).tar.xz
-export EXPAT_SHA256SUM := 
2f9b6a580b94577b150a7d5617ad4643a4301a6616ff459307df3e225bcfbf40
-export EXPAT_TARBALL := expat-2.4.1.tar.bz2
+export EXPAT_SHA256SUM := 
5963005ff8720735beb2d2db669afc681adcbcb43dd1eb397d5c2dd7adbc631f
+export EXPAT_TARBALL := expat-2.4.4.tar.gz
 export FIREBIRD_SHA256SUM := 
6994be3555e23226630c587444be19d309b25b0fcf1f87df3b4e3f88943e5860
 export FIREBIRD_TARBALL := Firebird-3.0.0.32483-0.tar.bz2
 export FONTCONFIG_SHA256SUM := 
19e5b1bc9d013a52063a44e1307629711f0bfef35b9aca16f9c793971e2eb1e5
commit 99b1556c6343a17b900d1557878b7fa6a1039b3d
Author: Luboš Luňák 
AuthorDate: Thu Jan 13 15:59:49 2022 +0100
Commit: Andras Timar 
CommitDate: Mon Mar 14 21:59:40 2022 +0100

support for the WebP image format (tdf#114532)

This commit implements a WebP reader and writer for both lossless
and lossy WebP, export dialog options for selecting lossless/lossy
and quality for lossy, and various internal support for the format.

Since writing WebP to e.g. ODT documents would make those images
unreadable by previous versions with no WebP support, support
for that is explicitly disabled in GraphicFilter, to be enabled
somewhen later.

Change-Id: I9b10f6da6faa78a0bb74415a92e9f163c14685f7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128978
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Tomaž Vajngerl 

diff --git a/Makefile.fetch b/Makefile.fetch
index 0a6202a4b3c7..8e6cff22e0bc 100644
--- a/Makefile.fetch
+++ b/Makefile.fetch
@@ -163,6 +163,7 @@ $(WORKDIR)/download: $(BUILDDIR)/config_$(gb_Side).mk 
$(SRCDIR)/download.lst $(S
$(call fetch_Optional,LIBNUMBERTEXT,LIBNUMBERTEXT_TARBALL) \
$(call fetch_Optional,LIBPNG,LIBPNG_TARBALL) \
$(call fetch_Optional,LIBTOMMATH,LIBTOMMATH_TARBALL) \
+   $(call fetch_Optional,LIBWEBP,LIBWEBP_TARBALL) \
$(call fetch_Optional,LIBXML2,LIBXML_TARBALL) \
$(call fetch_Optional,XMLSEC,XMLSEC_TARBALL) \
$(call fetch_Optional,LIBXSLT,LIBXSLT_TARBALL) \
diff --git a/RepositoryExternal.mk 

[Libreoffice-commits] core.git: chart2/source svx/source

2022-03-15 Thread Dennis Francis (via logerrit)
 chart2/source/controller/main/ChartController.cxx |   15 +++
 svx/source/svdraw/svdmrkv.cxx |8 
 2 files changed, 23 insertions(+)

New commits:
commit 64631ddcf360102d6f72a938a154529a1edc69f7
Author: Dennis Francis 
AuthorDate: Mon Mar 7 12:17:07 2022 +0530
Commit: Dennis Francis 
CommitDate: Tue Mar 15 08:28:46 2022 +0100

lokCalcRTL: chart-edit: no bounding box

Fix for selections(svx-marks) similar to the fix for chart edit mode
tile painting

```
4fd2a14c6ee68f0574766ec7ec3dca35debe9d20
lokCalcRTL: global RTL: fix chart edit mode rendering
```

Conflicts:
chart2/source/controller/main/ChartController.cxx

Change-Id: I2b5a2af7023b09254b8471b750122bec10126bde
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131091
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Szymon Kłos 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131572
Tested-by: Jenkins
Reviewed-by: Dennis Francis 

diff --git a/chart2/source/controller/main/ChartController.cxx 
b/chart2/source/controller/main/ChartController.cxx
index 974c36ba20e0..54e950a3b6eb 100644
--- a/chart2/source/controller/main/ChartController.cxx
+++ b/chart2/source/controller/main/ChartController.cxx
@@ -71,6 +71,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -79,6 +80,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 
@@ -703,7 +705,20 @@ void ChartController::impl_createDrawViewController()
 {
 if( m_pDrawModelWrapper )
 {
+bool bLokCalcGlobalRTL = false;
+if(comphelper::LibreOfficeKit::isActive() && 
AllSettings::GetLayoutRTL())
+{
+rtl::Reference< ChartModel > xChartModel = getChartModel();
+if (xChartModel.is())
+{
+uno::Reference 
xSSDoc(xChartModel->getParent(), uno::UNO_QUERY);
+if (xSSDoc.is())
+bLokCalcGlobalRTL = true;
+}
+}
+
 m_pDrawViewWrapper.reset( new 
DrawViewWrapper(m_pDrawModelWrapper->getSdrModel(),GetChartWindow()->GetOutDev())
 );
+m_pDrawViewWrapper->SetNegativeX(bLokCalcGlobalRTL);
 m_pDrawViewWrapper->attachParentReferenceDevice( getChartModel() );
 }
 }
diff --git a/svx/source/svdraw/svdmrkv.cxx b/svx/source/svdraw/svdmrkv.cxx
index cac8dfc2db51..e831dbc92733 100644
--- a/svx/source/svdraw/svdmrkv.cxx
+++ b/svx/source/svdraw/svdmrkv.cxx
@@ -786,6 +786,14 @@ void SdrMarkView::SetMarkHandlesForLOKit(tools::Rectangle 
const & rRect, const S
 if (pViewShellWindow && pViewShellWindow->IsAncestorOf(*pWin))
 {
 Point aOffsetPx = 
pWin->GetOffsetPixelFrom(*pViewShellWindow);
+if (mbNegativeX && AllSettings::GetLayoutRTL())
+{
+// mbNegativeX is set only for Calc in RTL mode.
+// If global RTL flag is set, vcl-window X offset of 
chart window is
+// mirrored w.r.t parent window rectangle. This needs 
to be reverted.
+aOffsetPx.setX(pViewShellWindow->GetOutOffXPixel() + 
pViewShellWindow->GetSizePixel().Width()
+- pWin->GetOutOffXPixel() - 
pWin->GetSizePixel().Width());
+}
 Point aLogicOffset = pWin->PixelToLogic(aOffsetPx);
 addLogicOffset = aLogicOffset;
 aSelection.Move(aLogicOffset.getX(), aLogicOffset.getY());


<    1   2   3   4   >