[Libreoffice-bugs] [Bug 149252] "Margin" -> "Entire Paragraph Area" in "to" for Vertical Positioning and "Paragraph Area" -> "Entire Paragraph Area" in "to" for Horizontal positioning
https://bugs.documentfoundation.org/show_bug.cgi?id=149252 Mike Kaganski changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149254] Make the selection behavior when double-clicking a word a user preference.
https://bugs.documentfoundation.org/show_bug.cgi?id=149254 Chris changed: What|Removed |Added CC||libre-bugzi...@knoxcomm.com Keywords||accessibility, topicDesign, ||topicUI -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144258] Left Area Header is not editable for some users (all on Qt systems?)
https://bugs.documentfoundation.org/show_bug.cgi?id=144258 Justin L changed: What|Removed |Added Summary|Left Area Header is not |Left Area Header is not |editable for some users |editable for some users ||(all on Qt systems?) --- Comment #11 from Justin L --- Siduction offers KDE, LXQt, and Xfce from a Debian base. Is everyone who is seeing this problem running Qt with gtk3? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148864] Kubuntu 22.04 LTS LibreOffice Impress 7.3.3 Fails to Play Embedded Videos
https://bugs.documentfoundation.org/show_bug.cgi?id=148864 --- Comment #7 from Michael Weghorn --- (In reply to Jan-Marek Glogowski from comment #6) > Had just some time looking into this and at least I can confirm that in the > bibisect repo this commit breaks playback. For master, initial playback > works here, but not going back to the first slide, resulting in a black box > instead of a video (but my master has a lot of changes for the per-screen > scaling, but that is nothing Qt related AFAIK). I retested: When using the 7.4 bibisect repo, I initially see a light gray rectangle in the place where the video is supposed to be. However, initial playback works fine with a self-compiled master, the behavior is the same for me as the one you described. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149254] New: Make the selection behavior when double-clicking a word a user preference.
https://bugs.documentfoundation.org/show_bug.cgi?id=149254 Bug ID: 149254 Summary: Make the selection behavior when double-clicking a word a user preference. Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: libre-bugzi...@knoxcomm.com I would like to see the behavor when double-clicking a word be user-modifiable preference. Most WYSIWIG editors I use, including the one I'm using to create this report, select a group of consecutive letters plus trailing whitespace up to the punctuation or the next letter. Writer selects only the word. This is not necessarily /wrong/ behavior, however it is contrary to what my muscle memory expects. The behavior is especially bothersome when editing a document as I tend to write a lot and then delete words either as a group, or one at a time. To delete a word I have to hit the delete key twice, once for the word, once for the space. This is an admittedly minor point, but it can be irritating when I really want to focus on what I'm doing rather than the technology. Thanks! Chris -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149252] "Margin" -> "Entire Paragraph Area" in "to" for Vertical Positioning and "Paragraph Area" -> "Entire Paragraph Area" in "to" for Horizontal positioning
https://bugs.documentfoundation.org/show_bug.cgi?id=149252 Mike Kaganski changed: What|Removed |Added CC||gordon1dr...@yahoo.com --- Comment #2 from Mike Kaganski --- *** Bug 92138 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 92138] FORMATTING: Object vertical position from top to margin is the same as paragraph text area
https://bugs.documentfoundation.org/show_bug.cgi?id=92138 Mike Kaganski changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #6 from Mike Kaganski --- (In reply to sdc.blanco from comment #5) > I believe this is NAB. ... Expected > behavior in OP is based on a misinterpretation of "Margin". Agree. (In reply to Gordo from comment #0) > Actual Result: > The Vertical From Top to Margin shows a value that is relative from the > paragraph (text) area and not the margin. So this is a dupe of bug 149252. *** This bug has been marked as a duplicate of bug 149252 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107805] [META] Writer master document issues
https://bugs.documentfoundation.org/show_bug.cgi?id=107805 Bug 107805 depends on bug 149231, which changed state. Bug 149231 Summary: Crash on print preview of master document (Linux) https://bugs.documentfoundation.org/show_bug.cgi?id=149231 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149230] Create sketches for ajlittoz's vision of a UI promoting the use of styles
https://bugs.documentfoundation.org/show_bug.cgi?id=149230 --- Comment #5 from Mike Kaganski --- (In reply to Rafael Lima from comment #4) Your proposal has two main parts: 1. #1, #3: detect existing DF. This is something targeted on resolving *problems*, i.e., it's not a feature to help *creating and working* on documents normally, but a means to rectify some document causing headaches because of its (lack of) structure. While it's useful, I disagree that this mental model should be considered the main UI part. IMO we should not make Writer look like repairment toolset (which is the central part *currently* for anyone *already fluent with styles*, and who has to rectify everything before starting to work creatively). Its UI should focus on ease of creation good documents from start to end, using proper tools, so *initially* I suggest to focus on an idealized workflow as if user does not use DF in wrong ways, and the existing documents and templates are using styles. So for that idealized model, the UI would *not* need repairment tools at all. Start with some limited workflow where all the content comes from user typing and drawing themselves, and make that comfortable using styles as main tool. Then extend the workflow to pieces of content coming from outside, like using clipboard - and then again, don't focus on repair, but think what workflow could make it correct from start (e.g., what limits usefulness of paste as plain text? that it drops *content* and *styles* along with other formatting. Imagine "Paste with clean formatting" pasting rich content, and only dropping DF in the process automatically, and make it the default paste - and one place where we need repairs would be gone). After a UI is prepared with that mental model, we could *then* think how to supplement it with convenience tools to repair what needs repair. Also that part alienates DF completely, making it something completely "bad", to be avoided at all cost. Note that that approach is wrong. There are lots of DF that is OK and beneficial, and which lack would force users to have exponentially growing number of styles: e.g., each time I switch keyboard layout from English to Russian on my Windows system, my Writer applies a DF with respective language to the typed text, and I don't need two paragraph texts, two emphasized texts, two footnotes, ... Same for rsid - the identified added as DF to allow comparing documents better. Not to mention many legitimate one-off DF use cases. Writer has styles *and* DF, and the goal should not be "never ever use DF". 2. #2: make documents ODF-incompliant, and in fact make DF completely useless (simply because if styles have precedence over DF, it is equivalent to DF completely absent: there is no formatting that is not defined in some style (e.g., in paragraph style) at least implicitly; so no matter what DF you would try to apply, it would not be used, because respective formatting from paragraph style would be used). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/utlui/glbltree.cxx | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
New commits:
commit f817b3de1aa827d93e2a622735c4d570514f4849
Author: Jim Raykowski
AuthorDate: Mon May 23 15:35:57 2022 -0800
Commit: Jim Raykowski
CommitDate: Tue May 24 06:24:10 2022 +0200
tdf#149231 Fix crash on print preview of master
caused by commit 1f9a792a391f0811bbb5f570ad5c84d13312c539.
Change-Id: Iecfa019b04b84bb70b5e04af51f9f786d7cd9fdf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134846
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
diff --git a/sw/source/uibase/utlui/glbltree.cxx
b/sw/source/uibase/utlui/glbltree.cxx
index 7e044f64ad65..38abd661566c 100644
--- a/sw/source/uibase/utlui/glbltree.cxx
+++ b/sw/source/uibase/utlui/glbltree.cxx
@@ -773,7 +773,8 @@ void
SwGlobalTree::ExecuteContextMenuAction(std::string_view rSelectedPopupEntry
IMPL_LINK_NOARG(SwGlobalTree, Timeout, Timer *, void)
{
-if (m_pActiveShell && m_pActiveShell->GetView().GetEditWin().HasFocus())
+SwView* pView = GetParentWindow()->GetCreateView();
+if (pView && pView->GetEditWin().HasFocus())
{
if (Update(false))
Display();
@@ -877,14 +878,13 @@ bool SwGlobalTree::Update(bool bHard)
bool bRet = false;
if (pActView && pActView->GetWrtShellPtr())
{
-SwWrtShell* pOldShell = m_pActiveShell;
+const SwWrtShell* pOldShell = m_pActiveShell;
m_pActiveShell = pActView->GetWrtShellPtr();
if(m_pActiveShell != pOldShell)
{
-if (pOldShell)
-EndListening(*pOldShell->GetView().GetDocShell());
-StartListening(*m_pActiveShell->GetView().GetDocShell());
m_pSwGlblDocContents.reset();
+if (!IsListening(*m_pActiveShell->GetView().GetDocShell()))
+StartListening(*m_pActiveShell->GetView().GetDocShell());
}
if(!m_pSwGlblDocContents)
{
[Libreoffice-bugs] [Bug 149246] Win10 buildtin ‚Snip & Sketch‘ and STRG+V doesn't work with Writer and calc
https://bugs.documentfoundation.org/show_bug.cgi?id=149246 --- Comment #2 from Wolfgag Nickl --- Hello Julien, sorry, but I forgot to test it with version 7. And there it works. Pleas close this bug. Best Regards Wolfgang -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148755] A Quirk in the focusing property of the Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=148755 --- Comment #5 from Jim Raykowski --- I don't think I can explain the current behavior any better than Dieter has. The content view can be toggled to show only Headings content, this seems to be what you are after. 1) Click the Headings category in the Navigator content tree or one of the headings listed in the Heading category. 2) Click the 'Content Navigation View' toggle button. It is the first button on the second line of controls in the Navigator. Here is a link to a screen cast demo that hopefully helps: https://bugs.documentfoundation.org/attachment.cgi?id=179020 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147991] FILESAVE PPTX: text shows as black instead of white - paragraph indentation differs, too
https://bugs.documentfoundation.org/show_bug.cgi?id=147991 Aron Budea changed: What|Removed |Added Attachment #178886|application/vnd.ms-powerpoi |application/vnd.openxmlform mime type|nt |ats-officedocument.presenta ||tionml.presentation -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147991] FILESAVE PPTX: text shows as black instead of white - paragraph indentation differs, too
https://bugs.documentfoundation.org/show_bug.cgi?id=147991 Aron Budea changed: What|Removed |Added Blocks||107899 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107899 [Bug 107899] [META] PPTX paragraph-related issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107899] [META] PPTX paragraph-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=107899 Aron Budea changed: What|Removed |Added Depends on||147991 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=147991 [Bug 147991] FILESAVE PPTX: text shows as black instead of white - paragraph indentation differs, too -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147991] FILESAVE PPTX: text shows as black instead of white - paragraph indentation differs, too
https://bugs.documentfoundation.org/show_bug.cgi?id=147991 Aron Budea changed: What|Removed |Added CC||aron.bu...@gmail.com See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=94 ||122 --- Comment #6 from Aron Budea --- (In reply to Gerald Pfeifer from comment #0) > 4. Observe how the title color changed from white to black and also This is probably closely related to bug 94122. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 94122] Automatic colors (white on dark background) (or colors predefined ?) not exported to PPTX correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=94122 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||7991 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148567] Hyperlinks in Google documents exported to docx converted to PDF lose their clickability in most viewers
https://bugs.documentfoundation.org/show_bug.cgi?id=148567 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149004] Libreoffice crashes when remote instances using the installation
https://bugs.documentfoundation.org/show_bug.cgi?id=149004 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135555] type 'struct Document' violates the C++ One Definition Rule
https://bugs.documentfoundation.org/show_bug.cgi?id=13 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135555] type 'struct Document' violates the C++ One Definition Rule
https://bugs.documentfoundation.org/show_bug.cgi?id=13 --- Comment #9 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145293] Crash when clicking "data sources"
https://bugs.documentfoundation.org/show_bug.cgi?id=145293 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145293] Crash when clicking "data sources"
https://bugs.documentfoundation.org/show_bug.cgi?id=145293 --- Comment #3 from QA Administrators --- Dear Per Schoerner, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145228] Cannot open .odt files
https://bugs.documentfoundation.org/show_bug.cgi?id=145228 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145228] Cannot open .odt files
https://bugs.documentfoundation.org/show_bug.cgi?id=145228 --- Comment #9 from QA Administrators --- Dear surfbird, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145876] Cannot open files
https://bugs.documentfoundation.org/show_bug.cgi?id=145876 --- Comment #3 from QA Administrators --- Dear arnold.teusch, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135455] Cannot load document from local storage
https://bugs.documentfoundation.org/show_bug.cgi?id=135455 --- Comment #2 from QA Administrators --- Dear marthef100, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135138] Using CLI assemblies result in Invalid IL code in uno.util.Bootstrap:bootstrap
https://bugs.documentfoundation.org/show_bug.cgi?id=135138 --- Comment #2 from QA Administrators --- Dear Peter Hagen, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131724] Allow for virtual XDocumentDataSource to be registered
https://bugs.documentfoundation.org/show_bug.cgi?id=131724 --- Comment #2 from QA Administrators --- Dear Oleg Shchelykalnov, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149049] Navigator does not show media objects unless a "Name" is added
https://bugs.documentfoundation.org/show_bug.cgi?id=149049 Jim Raykowski changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103030] [META] Navigator sidebar deck and floating window
https://bugs.documentfoundation.org/show_bug.cgi?id=103030 Bug 103030 depends on bug 149049, which changed state. Bug 149049 Summary: Navigator does not show media objects unless a "Name" is added https://bugs.documentfoundation.org/show_bug.cgi?id=149049 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149253] Anchor help page needs some improvement
https://bugs.documentfoundation.org/show_bug.cgi?id=149253 sdc.bla...@youmail.dk changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |sdc.bla...@youmail.dk |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 132864] Harmony in position settings of different objects
https://bugs.documentfoundation.org/show_bug.cgi?id=132864 --- Comment #22 from sdc.bla...@youmail.dk --- This ticket is categorized as "Documentation", but the discussion is more general. Have opened bug 149253 strictly in relation to: ( Heiko Tietze from comment #10) > What is missing at the documentation? > > https://help.libreoffice.org/latest/en-US/text/shared/01/0526.html > https://help.libreoffice.org/latest/en-US/text/swriter/guide/anchor_object. > html?DbPAR=WRITER#bm_id3147828 and (Heiko Tietze from comment #20) > I'd appreciate more under-the-hood information in the online > help. For example recommendations and limitations, special conditions etc. (a) short "tips", "notes" and "warnings" are possible in help pages. (b) put concrete suggestions in bug 149253. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149253] New: Anchor help page needs some improvement
https://bugs.documentfoundation.org/show_bug.cgi?id=149253 Bug ID: 149253 Summary: Anchor help page needs some improvement Product: LibreOffice Version: 7.4.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Documentation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sdc.bla...@youmail.dk CC: olivier.hal...@libreoffice.org Copied from bug 132864 comment 18 (In reply to Heiko Tietze from comment #10) > What is missing at the documentation? > > https://help.libreoffice.org/latest/en-US/text/shared/01/0526.html "To page" could be clarified "As character" is not correct about height of current line. (or, correct only under certain, but not all, circumstances). > https://help.libreoffice.org/latest/en-US/text/swriter/guide/anchor_object. > html?DbPAR=WRITER#bm_id3147828 First sentence (and rest of page) is missing critical information about positioning options. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149231] Crash on print preview of master document (Linux)
https://bugs.documentfoundation.org/show_bug.cgi?id=149231 Jim Raykowski changed: What|Removed |Added Regression By|Jim Raykowski | Assignee|libreoffice-b...@lists.free |rayk...@gmail.com |desktop.org | --- Comment #7 from Jim Raykowski --- Thanks all. Looking at the comments made in https://gerrit.libreoffice.org/c/core/+/122103, I see that I was suspicious of that patch. Here is another go at it. This one doesn't crash for the steps given to repro the crash: https://gerrit.libreoffice.org/c/core/+/134846 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113108] [META] Dialog UI/UX bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113108 sdc.bla...@youmail.dk changed: What|Removed |Added Depends on||149252 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149252 [Bug 149252] "Margin" -> "Entire Paragraph Area" in "to" for Vertical Positioning and "Paragraph Area" -> "Entire Paragraph Area" in "to" for Horizontal positioning -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103305] [META] Frame dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103305 sdc.bla...@youmail.dk changed: What|Removed |Added Depends on||149252 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149252 [Bug 149252] "Margin" -> "Entire Paragraph Area" in "to" for Vertical Positioning and "Paragraph Area" -> "Entire Paragraph Area" in "to" for Horizontal positioning -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108741] [META] Shapes bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108741 sdc.bla...@youmail.dk changed: What|Removed |Added Depends on||149252 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149252 [Bug 149252] "Margin" -> "Entire Paragraph Area" in "to" for Vertical Positioning and "Paragraph Area" -> "Entire Paragraph Area" in "to" for Horizontal positioning -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149252] "Margin" -> "Entire Paragraph Area" in "to" for Vertical Positioning and "Paragraph Area" -> "Entire Paragraph Area" in "to" for Horizontal positioning
https://bugs.documentfoundation.org/show_bug.cgi?id=149252 sdc.bla...@youmail.dk changed: What|Removed |Added Blocks||103270, 103305, 113108, ||108741 --- Comment #1 from sdc.bla...@youmail.dk --- https://gerrit.libreoffice.org/c/core/+/134785 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103270 [Bug 103270] [META] Image/Picture dialog bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=103305 [Bug 103305] [META] Frame dialog bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=108741 [Bug 108741] [META] Shapes bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=113108 [Bug 113108] [META] Dialog UI/UX bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103270] [META] Image/Picture dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103270 sdc.bla...@youmail.dk changed: What|Removed |Added Depends on||149252 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149252 [Bug 149252] "Margin" -> "Entire Paragraph Area" in "to" for Vertical Positioning and "Paragraph Area" -> "Entire Paragraph Area" in "to" for Horizontal positioning -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133104] Anchor To Character not persistent
https://bugs.documentfoundation.org/show_bug.cgi?id=133104 --- Comment #20 from sdc.bla...@youmail.dk --- (In reply to Mike Kaganski from comment #19) > (In reply to sdc.blanco from comment #17) > > Propose: > > > > "Entire paragraph" (to be parallel with "Entire Page" and "Entire Frame") > > +1 Bug 149252 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149252] "Margin" -> "Entire Paragraph Area" in "to" for Vertical Positioning and "Paragraph Area" -> "Entire Paragraph Area" in "to" for Horizontal positioning
https://bugs.documentfoundation.org/show_bug.cgi?id=149252 sdc.bla...@youmail.dk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||9245 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149245] Shouldn't "Paragraph Area" and "Page Text Area" be different in Horizontal Positioning?
https://bugs.documentfoundation.org/show_bug.cgi?id=149245 sdc.bla...@youmail.dk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||9252 --- Comment #8 from sdc.bla...@youmail.dk --- (In reply to Mike Kaganski from comment #7) > Just consider keeping the "area": "Entire paragraph area". Kept. Bug 149252 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149252] New: "Margin" -> "Entire Paragraph Area" in "to" for Vertical Positioning and "Paragraph Area" -> "Entire Paragraph Area" in "to" for Horizontal positioning
https://bugs.documentfoundation.org/show_bug.cgi?id=149252 Bug ID: 149252 Summary: "Margin" -> "Entire Paragraph Area" in "to" for Vertical Positioning and "Paragraph Area" -> "Entire Paragraph Area" in "to" for Horizontal positioning Product: LibreOffice Version: 7.4.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sdc.bla...@youmail.dk (Context: position dialog for objects) Bug 133104 comment 15 suggests that the "Margin" option in the ”to” control for Vertical positioning might deserve renaming. I propose: "Margin" -> "Entire paragraph area" (which would make it almost parallel to "Entire page" and "Entire frame", which are already used). Further, in the ”to” control for Horizontal positioning: "Paragraph area" --> "Entire paragraph area" (again to keep things parallel -- and to use the same name for the same region between Horizontal and Vertical). See bug 149245 comment 6 for elaborated motivation. The reason for using ”Entire paragraph area” instead of ”Entire paragraph” is because unlike ”page” and ”frame”, the horizontal meaning of paragraph is contextual. See bug 149245 comment 7 for elaboration of that choice. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 92138] FORMATTING: Object vertical position from top to margin is the same as paragraph text area
https://bugs.documentfoundation.org/show_bug.cgi?id=92138 sdc.bla...@youmail.dk changed: What|Removed |Added CC||mikekagan...@hotmail.com, ||sdc.bla...@youmail.dk --- Comment #5 from sdc.bla...@youmail.dk --- I believe this is NAB. That is, the actual behavior is correct. Expected behavior in OP is based on a misinterpretation of "Margin". cc: Mike Kaganski -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149251] Sometimes Writer doesn't refresh page display immediately after inserting or deleting characters when the line has formula
https://bugs.documentfoundation.org/show_bug.cgi?id=149251 --- Comment #1 from water.q...@gmail.com --- Created attachment 180322 --> https://bugs.documentfoundation.org/attachment.cgi?id=180322=edit example file to show the bug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149251] New: Sometimes Writer doesn't refresh page display immediately after inserting or deleting characters when the line has formula
https://bugs.documentfoundation.org/show_bug.cgi?id=149251 Bug ID: 149251 Summary: Sometimes Writer doesn't refresh page display immediately after inserting or deleting characters when the line has formula Product: LibreOffice Version: 7.3.3.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: water.q...@gmail.com Description: In the example file, if you put cursor before sinADB, type space key, formula is pushed to right, but sinADB is not changed. If you delete some character, e.g. delete s from sin, only formula position is updated. Steps to Reproduce: 1.Open attached file, put cursor before sinADB, type some character or space bar 2. formula is pushed to right, but sinADB position not updated 3. if you delete some character from sin, only formula is updated Actual Results: page contents not updated immediately, if you press F5 twine, the page is refreshed Expected Results: each time you input or delete character, the page contents should be immediately updated Reproducible: Always User Profile Reset: No Additional Info: The following version has the same bug. Version: 7.3.4.1 (x64) / LibreOffice Community Build ID: 13668373362b52f6e3ebcaaecb031bd59a3ac66b CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: zh-CN (zh_CN); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149250] New: Crash in: ScColumn::SetPattern(long, ScPatternAttr const &)
https://bugs.documentfoundation.org/show_bug.cgi?id=149250 Bug ID: 149250 Summary: Crash in: ScColumn::SetPattern(long,ScPatternAttr const &) Product: LibreOffice Version: unspecified Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: k_coll...@yahoo.com This bug was filed from the crash reporting server and is br-7a715da8-0c91-450e-bac1-684cb23f0848. = I was using the "paste special" feature to transpose rows and columns when the application crashed. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149230] Create sketches for ajlittoz's vision of a UI promoting the use of styles
https://bugs.documentfoundation.org/show_bug.cgi?id=149230 --- Comment #4 from Rafael Lima --- I agree with Eyal statement that styles "should be encouraged by some means - but not to the extent of making it difficult to create a simple document with direct formatting, or to make direct-formatting changes to an existing document." To that end, we should provide some new features for users who are interested in using styles in their documents and that will make their lives easier. I'll share a few ideas: 1) Create a feature to "Mark all direct formatting". In Writer, this would search the document and highlight which portions were formatted with Direct formatting instead of styles. This would also be useful while inspecting documents (such as books, theses, etc) in search of portions of text where direct formatting would be in the way of styles. 2) In Writer we could create an edit mode called "Prefer styles over direct formatting". If this mode were ON, applied styles would have precedence over direct formatting on the entire document. Also, every time the user applies direct formatting, Writer could add a yellow-line (similar to the red line) below the text emphasizing that this portion is formatted with direct formatting, indicating that this is not desirable in a style-oriented document. Placing the mouse over such "yellow line" could suggest similar styles to apply or even recommend creating a style based on this section of text, which would automatically apply to all other occurrences of the same direct formatting. 3) We could add an option to automatically detect all occurrences of direct formatting in the text and group them by frequency, such that we show the user common direct formatting options used in the document. This would help identify possible missing styles and let the user create new styles based on them. I know all of my ideas are vague, but maybe they may lead to some more refined ideas. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145037] UI: Animation list, show all entry's by default. Add search & drop down to filter
https://bugs.documentfoundation.org/show_bug.cgi?id=145037 --- Comment #14 from Eyal Rozenberg --- (In reply to Telesto from comment #13) (In reply to Telesto from comment #13) > There is also the bug tracker issue > 1) If you propose a specific fix for alleged problem, shooting down the > proposal means, shooting down the 'bug' (annoyance/ design issue). Ah, but you often propose more than a fix - you propose a change which will be detrimental to other workflows. For example, in 145034 - you didn't say you wanted to be able to have the effect kinds sorted alphabetically, you wrote you wanted to change it for everyone. Those are two different requests. > 2) If I put forward a genetic description of the perceived problem - to > avoid people shooting on the solution - it will be soon to vague (lacking > direction) Well, you can: 1. Ask for help with making it concrete. 2. Write the mailing list (or soon the discourse forums). 3. Try to make the problem more concrete by describing your workflow, and be more exact about what's problematic/annoying to you. I also have this problem sometime, and am frustrated by, uhm, certain people repeatedly not understanding my bug reports. 4. Ask Heiko to put some subject on the design meeting agenda (if it's a UI/design issue). > Sometimes people ... don't see something which need to > addressed. There no problem at all: like it isn't a bug, but a feature. Or > seeing it as a trivial/unimportant drawback. My courses of action above should be relevant in those cases too. Of course, it may be the case that they're mostly right and what you want is a niche use case (happens to me occasionally). > However a single person having to come up with ideas, and others shooting on > it isn't much fun. I feel your pain, my friend ! T_T -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149247] Image is overlapping text after rotating 90 degrees left/right (not honoring wrap)
https://bugs.documentfoundation.org/show_bug.cgi?id=149247 Rafael Lima changed: What|Removed |Added Status|UNCONFIRMED |NEW Assignee|libreoffice-b...@lists.free |rafael.palma.l...@gmail.com |desktop.org | Ever confirmed|0 |1 --- Comment #3 from Rafael Lima --- Created attachment 180321 --> https://bugs.documentfoundation.org/attachment.cgi?id=180321=edit Screenshots showing the problem I can confirm this bug using LO 7.3. See attached image showing that the image indeed overlaps with text if you change its rotation to 90º. However, if you first rotate to 45º and then to 90º it works. It shouldn't have to need this to work, so setting this to NEW. System info: Version: 7.3.3.2 / LibreOffice Community Build ID: 30(Build:2) CPU threads: 12; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Ubuntu package version: 1:7.3.3~rc2-0ubuntu0.21.10.1~lo1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144060] Writer process hangs sometimes on macOS 11.4 on MacBook Air M1 (Intel version, Zotero uninstalled)
https://bugs.documentfoundation.org/show_bug.cgi?id=144060 --- Comment #18 from David Snow --- Created attachment 180320 --> https://bugs.documentfoundation.org/attachment.cgi?id=180320=edit Big File -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144060] Writer process hangs sometimes on macOS 11.4 on MacBook Air M1 (Intel version, Zotero uninstalled)
https://bugs.documentfoundation.org/show_bug.cgi?id=144060 --- Comment #17 from David Snow --- I just went back fixing typos in my 80 page document on the Intel version of 7.3.3.2. In 15 minutes of simple editing it hung! I have a recent profile, no Zotero, no languagetools. Java= AdoptOpenJDK 11.0.11, but nothing uses Java that I know of. I'll attach the file. MacOS was 12.4 and it DID NOT offer me a chance for a crash dump or I would have attached it. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149248] Feature request: Option to not hyphenate last word in a paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=149248 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #2 from Regina Henschel --- Which settings do you use in section 'Hyphenation' on tab 'Text Flow' of the paragraph style? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149249] New: Ship LibreOfficeKit headers and library files with the LibreOffice community packages
https://bugs.documentfoundation.org/show_bug.cgi?id=149249 Bug ID: 149249 Summary: Ship LibreOfficeKit headers and library files with the LibreOffice community packages Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: sdk Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: hoss...@libreoffice.org With LibreOfficeKit (LOK), it is possible to create C++ applications that can access LibreOffice functionality. Documentation for LibreOfficeKit module: https://docs.libreoffice.org/libreofficekit.html As there are few dependencies for creating applications with LOK, it would be beneficial to have LibreOfficeKit headers and pre-built library files shipped with the SDK. In this way, one can build LOK C++ apps without building LibreOffice, and just by installing SDK and build tools. These are the header files for LibreOfficeKit: LibreOfficeKit/LibreOfficeKitEnums.h \ LibreOfficeKit/LibreOfficeKit.h \ LibreOfficeKit/LibreOfficeKitInit.h \ LibreOfficeKit/LibreOfficeKitGtk.h \ LibreOfficeKit/LibreOfficeKit.hxx \ LibreOfficeKit/LibreOfficeKitTypes.h \ Although Debian and Ubuntu provide the above headers in the libreofficekit-dev packages, these headers are not shipped with the LibreOffice community packages: https://packages.debian.org/stretch/all/libreofficekit-dev/filelist https://packages.ubuntu.com/jammy/amd64/libreofficekit-dev/filelist $ dpkg -S LibreOfficeKit.hxx dpkg-query: no path found matching pattern *LibreOfficeKit* $ dpkg -S liblibreofficekitgtk.so libobasis7.3-core: /opt/libreoffice7.3/program/liblibreofficekitgtk.so I think it would be better to ship both the headers and library files in the SDK or a separate package. $ dpkg -L libobasis7.3-libreofficekit-data /. /opt /opt/libreoffice7.3 /opt/libreoffice7.3/share /opt/libreoffice7.3/share/libreofficekit /opt/libreoffice7.3/share/libreofficekit/handle_image_end.png /opt/libreoffice7.3/share/libreofficekit/handle_image_middle.png /opt/libreoffice7.3/share/libreofficekit/handle_image_start.png On Windows, both headers and library files are missing from an installation of LibreOffice plus SDK. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145037] UI: Animation list, show all entry's by default. Add search & drop down to filter
https://bugs.documentfoundation.org/show_bug.cgi?id=145037 --- Comment #13 from Telesto --- (In reply to Eyal Rozenberg from comment #12) > (In reply to Telesto from comment #11) > > Thank you for clarifying. The thing is, with a large number of > annoyances/requests/suggestions, I believe there's no getting around opening > five or six or however bugs you need; with each of them focused on a single > suggestion, with a clear explanation and maybe a mockup. I have some > comments about some of the suggestions but I don't think it makes sense to > write that all up in here. I'm somewhat in 'repeat mode' with comment 11. I brought few things up separately see bug 145035 comment 1 and bug 145034. And well bug 145034 (alphabetically order of the list of effects) got some objections/ issues with my alphabetical proposal (which is fine), however got dropped pretty easy (IMHO) There is also the bug tracker issue 1) If you propose a specific fix for alleged problem, shooting down the proposal means, shooting down the 'bug' (annoyance/ design issue). 2) If I put forward a genetic description of the perceived problem - to avoid people shooting on the solution - it will be soon to vague (lacking direction) An certain reply's have lots of strategic ambiguity. Sometimes people object the solution, but de facto don't see something which need to addressed. There no problem at all: like it isn't a bug, but a feature. Or seeing it as a trivial/unimportant drawback. -- In case someone acknowledge an issue, but dislike the proposed solution I prefer people to put forward different idea's (brainstorming) in attempt to work something out. People taking an interest. Which can result in an alternative, or ultimately sticking to the current situation because every other solution having more drawbacks. However a single person having to come up with ideas, and others shooting on it isn't much fun. -- So I'm happy to open yet again some bug reports on the matter, but I really don't have some fully conceptualized integral mock-up ready with meeting all UI design standards. Or total overview what needs to be taken in consideration. It's more that I wanted to share my opinion on the animation deck and maybe getting some idea's for improvement. -- You are receiving this mail because: You are the assignee for the bug.
HarfBuzz 4.3 released. May be it's time to update it in LibreOffice? =)
Hi. The 4.3 version seems interesting with some speed improvements https://github.com/harfbuzz/harfbuzz/releases/tag/4.3.0 May be someone can update HarfBuzz in LibreOffice to the 4.3 version? ps: I would do it myself as Caolan did it in 6ebf46e332facfae5fd6027ec667ccd5993dd493 but I'm not sure if it needs some additional .patch ... Thanks -- Best Regards, Roman Kuznetsov
[Libreoffice-bugs] [Bug 124438] [META] Presenter console bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=124438 Timur changed: What|Removed |Added Depends on||92717 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=92717 [Bug 92717] VIEWING UI LibreOffice Impress Internet Presentation with 1 monitor and having 2 windows (1 for the presentation and 1 for the console) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 92717] VIEWING UI LibreOffice Impress Internet Presentation with 1 monitor and having 2 windows (1 for the presentation and 1 for the console)
https://bugs.documentfoundation.org/show_bug.cgi?id=92717 Timur changed: What|Removed |Added Blocks||124438 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=124438 [Bug 124438] [META] Presenter console bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143811] Multipage tables are malformed on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=143811 --- Comment #9 from Jim Nissen --- Were are we at with this bug fix? I just hit it again, and even on the previous version (7.0.6.2), that used to work around it. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144258] Left Area Header is not editable for some users
https://bugs.documentfoundation.org/show_bug.cgi?id=144258 Manfred changed: What|Removed |Added Regression By|Szymon Kłos | --- Comment #10 from Manfred --- My problem was solved with apt remove libreoffice-gtk3 && apt install libreoffice-qt5 libreoffice-kf5 Thanks to whistler_mb https://forum.siduction.org/index.php?topic=8612.msg68856#msg68856 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: external/libtiff
external/libtiff/UnpackedTarball_libtiff.mk |1 + external/libtiff/ubsan.patch| 11 +++ 2 files changed, 12 insertions(+) New commits: commit 91f408fd94cf38b27dcb26ced9cd6c4e1a9d1cd2 Author: Stephan Bergmann AuthorDate: Mon May 23 15:05:47 2022 +0200 Commit: Stephan Bergmann CommitDate: Mon May 23 21:59:21 2022 +0200 external/libtiff: Silence invalid-null-argument ...during CppunitTest_vcl_filters_test, > tif_dirread.c:4176:40: runtime error: null pointer passed as argument 2, which is declared to never be null > /usr/include/string.h:44:28: note: nonnull attribute specified here > #0 in TIFFReadDirectory at workdir/UnpackedTarball/libtiff/libtiff/tif_dirread.c:4176:17 (instdir/program/libvcllo.so +0xc4dbb6d) > #1 in ImportTiffGraphicImport(SvStream&, Graphic&) at vcl/source/filter/itiff/itiff.cxx:238:14 (instdir/program/libvcllo.so +0xa691680) > #2 in TiffFilterTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) at vcl/qa/cppunit/graphicfilter/filters-tiff-test.cxx:70:12 (workdir/LinkTarget/CppunitTest/libtest_vcl_filters_test.so +0x16dc48) > #3 in test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) at unotest/source/cpp/filters-test.cxx:132:20 (workdir/LinkTarget/CppunitTest/../Library/libunotest.so +0xd8d5c) > #4 in test::FiltersTest::testDir(rtl::OUString const&, std::basic_string_view>, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) at unotest/source/cpp/filters-test.cxx:160:5 (workdir/LinkTarget/CppunitTest/../Library/libunotest.so +0xdcc71) > #5 in TiffFilterTest::testCVEs() at vcl/qa/cppunit/graphicfilter/filters-tiff-test.cxx:76:5 (workdir/LinkTarget/CppunitTest/libtest_vcl_filters_test.so +0x16e1c5) Change-Id: I2de4363ff0f5552e89fd0af84b7b88e38b7bb209 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134823 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/external/libtiff/UnpackedTarball_libtiff.mk b/external/libtiff/UnpackedTarball_libtiff.mk index ee3d4ab6cb27..f874d6d61743 100644 --- a/external/libtiff/UnpackedTarball_libtiff.mk +++ b/external/libtiff/UnpackedTarball_libtiff.mk @@ -16,6 +16,7 @@ $(eval $(call gb_UnpackedTarball_set_patchlevel,libtiff,0)) $(eval $(call gb_UnpackedTarball_add_patches,libtiff,\ external/libtiff/libtiff.linknolibs.patch \ external/libtiff/libtiff.16bitcielab.patch \ +external/libtiff/ubsan.patch \ )) # vim: set noet sw=4 ts=4: diff --git a/external/libtiff/ubsan.patch b/external/libtiff/ubsan.patch new file mode 100644 index ..853d069ad795 --- /dev/null +++ b/external/libtiff/ubsan.patch @@ -0,0 +1,11 @@ +--- libtiff/tif_dirread.c libtiff/tif_dirread.c +@@ -4173,7 +4173,7 @@ + goto bad; + } + +-memcpy(new_sampleinfo, tif->tif_dir.td_sampleinfo, old_extrasamples * sizeof(uint16_t)); ++if (old_extrasamples != 0) memcpy(new_sampleinfo, tif->tif_dir.td_sampleinfo, old_extrasamples * sizeof(uint16_t)); + _TIFFsetShortArray(>tif_dir.td_sampleinfo, new_sampleinfo, tif->tif_dir.td_extrasamples); + _TIFFfree(new_sampleinfo); + }
[Libreoffice-bugs] [Bug 149132] Zoom sharing (single screen available only)
https://bugs.documentfoundation.org/show_bug.cgi?id=149132 Timur changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #1 from Timur --- Seems duplicate. *** This bug has been marked as a duplicate of bug 92717 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 92717] VIEWING UI LibreOffice Impress Internet Presentation with 1 monitor and having 2 windows (1 for the presentation and 1 for the console)
https://bugs.documentfoundation.org/show_bug.cgi?id=92717 Timur changed: What|Removed |Added CC||ler.ste...@gmail.com --- Comment #5 from Timur --- *** Bug 149132 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149248] Feature request: Option to not hyphenate last word in a paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=149248 Rafael Lima changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from Rafael Lima --- Could you provide a sample file where this happens? Also, what version of LibreOffice are you using? What operating system? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sw/source
sw/source/filter/ww8/docxattributeoutput.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 6f6d61ea5d7700fb18bfb49c6e1d16a55944e581
Author: Stephan Bergmann
AuthorDate: Mon May 23 10:08:08 2022 +0200
Commit: Xisco Fauli
CommitDate: Mon May 23 21:24:45 2022 +0200
tdf#149198 Fix use of nullptr
...which would have caused std::abort for non-production debug builds since
4f0c70fb5554325e0cc2129741175bf07de22029 "Avoid calling OString ctor with
null
pointer", and started to erroneously pass a nullptr argument into a
std::string_view for all kinds of builds with
af16aa625682b649e8843237652b9246d519cbae "Improve loplugin:stringview"
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134758
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
(cherry picked from commit c8d4ae2ad0cfdac770d897e7aca72fbb4a87765f, plus
follow-up f546767b4e9bf3de288ea50336cf1e15f1ee7435 "tdf#149198 Fix previous
fix")
Change-Id: Iad4d1576ed651a74c0f8b2e8dee3c59f5214accd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134780
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx
b/sw/source/filter/ww8/docxattributeoutput.cxx
index 6f8a24acd255..a6da6244898a 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -3064,7 +3064,7 @@ void DocxAttributeOutput::WriteCollectedRunProperties()
{
const char* pVal = nullptr;
m_pColorAttrList->getAsChar(FSNS(XML_w, XML_val), pVal);
-if (std::string_view("auto") != pVal)
+if (pVal == nullptr || std::string_view("auto") != pVal)
{
m_pSerializer->startElementNS(XML_w14, XML_textFill);
m_pSerializer->startElementNS(XML_w14, XML_solidFill);
[Libreoffice-commits] core.git: vcl/source
vcl/source/window/dockwin.cxx |2 -- 1 file changed, 2 deletions(-) New commits: commit 38751a8d5e07a448fe56c4602701f567538b139e Author: Andrea Gelmini AuthorDate: Mon May 23 11:05:50 2022 +0200 Commit: Julien Nabet CommitDate: Mon May 23 21:24:44 2022 +0200 Removed duplicated include Change-Id: I66e5f8ec9cb3d2c590bbd23c173f7028c23ce241 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134807 Reviewed-by: Julien Nabet Tested-by: Jenkins diff --git a/vcl/source/window/dockwin.cxx b/vcl/source/window/dockwin.cxx index b799fbe6aad6..fb216913b803 100644 --- a/vcl/source/window/dockwin.cxx +++ b/vcl/source/window/dockwin.cxx @@ -36,8 +36,6 @@ #include "impldockingwrapper.hxx" -#include - #define DOCKWIN_FLOATSTYLES (WB_SIZEABLE | WB_MOVEABLE | WB_CLOSEABLE | WB_STANDALONE) class DockingWindow::ImplData
[Libreoffice-bugs] [Bug 149248] New: Feature request: Option to not hyphenate last word in a paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=149248 Bug ID: 149248 Summary: Feature request: Option to not hyphenate last word in a paragraph Product: LibreOffice Version: 7.3.3.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rferr...@sccoast.net Description: I am using justified paragraphs in a long document. It often hyphenates the last word in a paragraph. This is typographically incorrect and there is no option to prevent this in the options. Please add this feature to hyphenation options. Steps to Reproduce: Nothing to enter here Actual Results: Nothing to enter here Expected Results: Nothing to enter here Reproducible: Always User Profile Reset: No Additional Info: Nothing to enter here -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149114] LibreOffice crashed on closing the tip of the day
https://bugs.documentfoundation.org/show_bug.cgi?id=149114 --- Comment #3 from Timur --- Please try with LO User Profile Reset. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/impglyphitem.cxx | 25 -
1 file changed, 8 insertions(+), 17 deletions(-)
New commits:
commit 091e615912e123f9d714952b61e2d9b8ae48a043
Author: Luboš Luňák
AuthorDate: Mon May 23 15:28:05 2022 +0200
Commit: Luboš Luňák
CommitDate: Mon May 23 21:05:12 2022 +0200
don't use glyph subsets with complicated LTR/RTL setups
This should be a more generic solution for problems of some characters
having neutral direction (spaces, commas, etc.) and ending up with
different RTL flag depending on exactly what subset of the string
is wanted (e.g. a space on its own will end up treated as LRT but
if surrounded by RTL text then it'll be flagged as RTL too).
Previous attempts 5d02daa5198d5bff9234d5db698e934a5e31c95f
and 467f2c50a935efff6ff8911e7282ecea535665a3 still left some corner
cases, and it seems that simply requiring BiDiStrong and matching LTR/RTL
for this optimization covers the usual cases.
Change-Id: I9824ba7ac52750d0a933e8ad818f809b8520ec87
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134824
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
diff --git a/vcl/source/gdi/impglyphitem.cxx b/vcl/source/gdi/impglyphitem.cxx
index a3ab689ff23e..ffed4d56c743 100644
--- a/vcl/source/gdi/impglyphitem.cxx
+++ b/vcl/source/gdi/impglyphitem.cxx
@@ -98,11 +98,18 @@ SalLayoutGlyphsImpl*
SalLayoutGlyphsImpl::cloneCharRange(sal_Int32 index, sal_In
copy->SetFlags(GetFlags());
if (empty())
return copy.release();
+bool rtl = front().IsRTLGlyph();
+// Avoid mixing LTR/RTL or layouts that do not have it set explicitly
(BiDiStrong). Otherwise
+// the subset may not quite match what would a real layout call give (e.g.
some characters with neutral
+// direction such as space might have different LTR/RTL flag). It seems
bailing out here mostly
+// avoid relatively rare corner cases and doesn't matter for performance.
+if (!(GetFlags() & SalLayoutFlags::BiDiStrong)
+|| rtl != bool(GetFlags() & SalLayoutFlags::BiDiRtl))
+return nullptr;
copy->reserve(std::min(size(), length));
sal_Int32 beginPos = index;
sal_Int32 endPos = index + length;
const_iterator pos;
-bool rtl = front().IsRTLGlyph();
if (rtl)
{
// Glyphs are in reverse order for RTL.
@@ -164,22 +171,6 @@ SalLayoutGlyphsImpl*
SalLayoutGlyphsImpl::cloneCharRange(sal_Int32 index, sal_In
if (!isSafeToBreak(pos, rtl))
return nullptr;
}
-// HACK: If mode is set to be RTL, but the last glyph is a non-RTL space,
-// then making a subset would give a different result than the actual
layout,
-// because the weak BiDi mode code in ImplLayoutArgs ctor would interpret
-// the string subset ending with space as the space being RTL, but it would
-// treat it as non-RTL for the whole string if there would be more non-RTL
-// characters after the space. So bail out.
-if (GetFlags() & SalLayoutFlags::BiDiRtl && !rtl && !copy->empty() &&
copy->back().IsSpacing())
-{
-return nullptr;
-}
-// Similarly, if mode is not RTL but the last glyph is an RTL space.
-if (!(GetFlags() & SalLayoutFlags::BiDiRtl) && rtl && !copy->empty()
-&& copy->back().IsSpacing())
-{
-return nullptr;
-}
return copy.release();
}
[Libreoffice-bugs] [Bug 148966] FILEOPEN PPTX: extra paragraph after some 2-line text with link
https://bugs.documentfoundation.org/show_bug.cgi?id=148966 Aron Budea changed: What|Removed |Added Attachment #179977|application/vnd.ms-powerpoi |application/vnd.openxmlform mime type|nt |ats-officedocument.presenta ||tionml.presentation -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107899] [META] PPTX paragraph-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=107899 Aron Budea changed: What|Removed |Added Depends on||148966 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148966 [Bug 148966] FILEOPEN PPTX: extra paragraph after some 2-line text with link -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148966] FILEOPEN PPTX: extra paragraph after some 2-line text with link
https://bugs.documentfoundation.org/show_bug.cgi?id=148966 Aron Budea changed: What|Removed |Added CC||aron.bu...@gmail.com Blocks||107899 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107899 [Bug 107899] [META] PPTX paragraph-related issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131687] Windows open in wrong display when used both through ssh and locally by the same user
https://bugs.documentfoundation.org/show_bug.cgi?id=131687 --- Comment #8 from Timur --- gedit works the same. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sal/osl
sal/osl/unx/file.cxx | 47 --
sal/osl/unx/file_impl.hxx |2 -
2 files changed, 26 insertions(+), 23 deletions(-)
New commits:
commit 476b1fa176f00ec8128ae72b48dfde11096ed85a
Author: Noel Grandin
AuthorDate: Mon May 23 18:47:15 2022 +0200
Commit: Noel Grandin
CommitDate: Mon May 23 20:14:33 2022 +0200
Revert "[API CHANGE] call ftruncate instead of ftruncate_by_name"
This reverts commit 1d58828f2285064635ed776e0641e83ee26d34da.
because we need the filename for "sandboxed LibreOffice on OS X"
functionality
Change-Id: I598759de0f4bd9e6387df66038fc060e8a08027e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134783
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sal/osl/unx/file.cxx b/sal/osl/unx/file.cxx
index caa7f5dd57e9..ac93ffacd13f 100644
--- a/sal/osl/unx/file.cxx
+++ b/sal/osl/unx/file.cxx
@@ -82,6 +82,7 @@ namespace {
struct FileHandle_Impl
{
pthread_mutex_t m_mutex;
+OString m_strFilePath; /*< holds native file path */
int m_fd;
enum Kind
@@ -108,7 +109,7 @@ struct FileHandle_Impl
rtl_String* m_memstreambuf; /*< used for in-memory streams */
#endif
-explicit FileHandle_Impl(int fd, Kind kind = KIND_FD);
+explicit FileHandle_Impl(int fd, Kind kind = KIND_FD, OString path =
"");
~FileHandle_Impl();
static size_t getpagesize();
@@ -181,8 +182,9 @@ FileHandle_Impl::Guard::~Guard()
(void) pthread_mutex_unlock(m_mutex);
}
-FileHandle_Impl::FileHandle_Impl(int fd, enum Kind kind)
-: m_fd (fd),
+FileHandle_Impl::FileHandle_Impl(int fd, enum Kind kind, OString path)
+: m_strFilePath(std::move(path)),
+ m_fd (fd),
m_kind(kind),
m_state (State::Seekable | State::Readable),
m_size(0),
@@ -242,7 +244,7 @@ sal_uInt64 FileHandle_Impl::getSize() const
oslFileError FileHandle_Impl::setSize(sal_uInt64 uSize)
{
off_t const nSize = sal::static_int_cast< off_t >(uSize);
-if (ftruncate(m_fd, nSize) == -1)
+if (ftruncate_with_name(m_fd, nSize, m_strFilePath) == -1)
{
/* Failure. Save original result. Try fallback algorithm */
oslFileError result = oslTranslateFileError(errno);
@@ -730,12 +732,12 @@ oslFileHandle osl::detail::createFileHandleFromFD(int fd)
pImpl->m_size = sal::static_int_cast< sal_uInt64 >(aFileStat.st_size);
}
-SAL_INFO("sal.file", "osl::detail::createFileHandleFromFD(" << pImpl->m_fd
<< ", writeable)");
+SAL_INFO("sal.file", "osl::detail::createFileHandleFromFD(" << pImpl->m_fd
<< ", writeable) => " << pImpl->m_strFilePath);
return static_cast(pImpl);
}
-static int osl_file_adjustLockFlags(const char* cpPath, int flags)
+static int osl_file_adjustLockFlags(const OString& path, int flags)
{
#ifdef MACOSX
/*
@@ -746,7 +748,7 @@ static int osl_file_adjustLockFlags(const char* cpPath, int
flags)
* for the filesystem name.
*/
struct statfs s;
-if(statfs(cpPath, ) >= 0)
+if(statfs(path.getStr(), ) >= 0)
{
if(strncmp("afpfs", s.f_fstypename, 5) == 0)
{
@@ -760,7 +762,7 @@ static int osl_file_adjustLockFlags(const char* cpPath, int
flags)
}
}
#else
-(void) cpPath;
+(void) path;
#endif
return flags;
@@ -796,12 +798,13 @@ static bool osl_file_queryLocking(sal_uInt32 uFlags)
namespace {
static oslFileError openMemoryAsFile(const OString ,
- oslFileHandle *pHandle)
+ oslFileHandle *pHandle,
+ const OString& path)
{
const char *address = rData.getStr();
size_t size = rData.getLength();
-FileHandle_Impl *pImpl = new FileHandle_Impl(-1,
FileHandle_Impl::KIND_MEM);
+FileHandle_Impl *pImpl = new FileHandle_Impl(-1,
FileHandle_Impl::KIND_MEM, path);
pImpl->m_size = sal::static_int_cast< sal_uInt64 >(size);
*pHandle = (oslFileHandle)(pImpl);
@@ -871,7 +874,7 @@ private:
#endif
-oslFileError openFilePath(const char* cpFilePath, oslFileHandle* pHandle,
+oslFileError openFilePath(const OString& filePath, oslFileHandle* pHandle,
sal_uInt32 uFlags, mode_t mode)
{
oslFileError eRet;
@@ -880,16 +883,16 @@ oslFileError openFilePath(const char* cpFilePath,
oslFileHandle* pHandle,
/* Opening a file from /assets read-only means
* we should mmap it from the .apk file
*/
-if (o3tl::starts_with(cpFilePath, "/assets/"))
+if (o3tl::starts_with(filePath, "/assets/"))
{
OString aData;
bool bCache = true;
-const char *cpAssetsPath = cpFilePath + sizeof("/assets/") - 1;
+const char *cpAssetsPath = filePath.getStr() + sizeof("/assets/") - 1;
// some requests are /assets//foo...
if (cpAssetsPath[0] == '/')
{
-
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3/gtkinst.cxx | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
New commits:
commit 97d90a9da36965f4f50293d50c8b2e5e043d3d9a
Author: Caolán McNamara
AuthorDate: Mon May 23 12:23:22 2022 +0100
Commit: Caolán McNamara
CommitDate: Mon May 23 20:12:10 2022 +0200
gtk: fix leak in treeview tooltip
Change-Id: Ib268729abf501da7e9f217ac3c3700cd853dfd43
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134815
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index bc2fbc8a5c1f..481bb8b573f7 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -14077,12 +14077,13 @@ private:
return false;
#endif
OUString aTooltip =
pThis->signal_query_tooltip(GtkInstanceTreeIter(iter));
-if (aTooltip.isEmpty())
-return false;
-gtk_tooltip_set_text(tooltip, OUStringToOString(aTooltip,
RTL_TEXTENCODING_UTF8).getStr());
-gtk_tree_view_set_tooltip_row(pTreeView, tooltip, pPath);
+if (!aTooltip.isEmpty())
+{
+gtk_tooltip_set_text(tooltip, OUStringToOString(aTooltip,
RTL_TEXTENCODING_UTF8).getStr());
+gtk_tree_view_set_tooltip_row(pTreeView, tooltip, pPath);
+}
gtk_tree_path_free(pPath);
-return true;
+return !aTooltip.isEmpty();
}
void last_child(GtkTreeModel* pModel, GtkTreeIter* result, GtkTreeIter*
pParent, int nChildren) const
[Libreoffice-bugs] [Bug 149247] Image is overlapping text after rotating 90 degrees left/right (not honoring wrap)
https://bugs.documentfoundation.org/show_bug.cgi?id=149247 Telesto changed: What|Removed |Added Version|7.0.0.3 release |6.1.0.3 release Keywords||bibisectRequest, regression --- Comment #2 from Telesto --- Also in Version: 6.1.0.0.alpha0+ Build ID: e1b247a843c5eb850fe0079819239d9883412d38 CPU threads: 4; OS: Windows 6.3; UI render: default; Locale: nl-NL (nl_NL); Calc: CL still OK with Version: 6.0.0.0.alpha0+ Build ID: 9127d1a89cbfba89eb9df6755ea7b9e161cfc67a CPU threads: 4; OS: Windows 6.3; UI render: default; Locale: nl-NL (nl_NL); Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144060] Writer process hangs sometimes on macOS 11.4 on MacBook Air M1 (Intel version, Zotero uninstalled)
https://bugs.documentfoundation.org/show_bug.cgi?id=144060 --- Comment #16 from Julien Nabet --- Ok so not network related. If possible, you can try to disable accessibility just for some time, eg if the hang happens at least once per day, try to disable accessibility during 2 days (of course if it still hangs with the same frequency, you can stop the test and re-enable accessibility). You can also try to get a stacktrace or any debug info (see https://wiki.documentfoundation.org/QA/BugReport/Debug_Information#macOS:_How_to_get_debug_information) it could help too. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149247] Image is overlapping text after rotating 90 degrees left/right (not honoring wrap)
https://bugs.documentfoundation.org/show_bug.cgi?id=149247 --- Comment #1 from Telesto --- Created attachment 180319 --> https://bugs.documentfoundation.org/attachment.cgi?id=180319=edit Example file -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149247] New: Image is overlapping text after rotating 90 degrees left/right (not honoring wrap)
https://bugs.documentfoundation.org/show_bug.cgi?id=149247 Bug ID: 149247 Summary: Image is overlapping text after rotating 90 degrees left/right (not honoring wrap) Product: LibreOffice Version: 7.0.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Image is overlapping text after rotating 90 degrees left/right (not honoring wrap) Steps to Reproduce: 1. Open the attached file 2. Select the cat image 3. Press rotate 90 degree in context menu or toolbar Actual Results: Cat image is overlapping part of the text Expected Results: Shouldn't be the case Reproducible: Always User Profile Reset: No Additional Info: Found in 7.4 and in Version: 7.0.7.0.0+ (x64) Build ID: 626ea4e62a3e5005fe9825923a1c0c5bdb61cc08 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145037] UI: Animation list, show all entry's by default. Add search & drop down to filter
https://bugs.documentfoundation.org/show_bug.cgi?id=145037 --- Comment #12 from Eyal Rozenberg --- (In reply to Telesto from comment #11) Thank you for clarifying. The thing is, with a large number of annoyances/requests/suggestions, I believe there's no getting around opening five or six or however bugs you need; with each of them focused on a single suggestion, with a clear explanation and maybe a mockup. I have some comments about some of the suggestions but I don't think it makes sense to write that all up in here. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149241] Text flow doesn't adapt with image anchored to character (fine with to paragraph)
https://bugs.documentfoundation.org/show_bug.cgi?id=149241 --- Comment #5 from Telesto --- Created attachment 180318 --> https://bugs.documentfoundation.org/attachment.cgi?id=180318=edit Example file Slightly different, approach.. but likely same area 1. Open the attached file 2. Put the cursor after the yellow highlighting 3. Press Enter.. Notice parallel wrap being disabled -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149242] "Left paragraph border" -> "Left of paragraph indent" and "Right paragraph border" -> "Right of paragraph indent"
https://bugs.documentfoundation.org/show_bug.cgi?id=149242 --- Comment #9 from sdc.bla...@youmail.dk --- (In reply to sdc.blanco from comment #6) > (In reply to Heiko Tietze from comment #4) > > Doubt an ordinary user can follow these considerations if > > just one adjective is added. I agree that an individual label in this context will never be able to explain its meaning by itself ...but two additional considerations that shift the perspective from the semantic meaning of an individual label to a perspective of the meaning of that label in its immediate context. 1. If you have experience with (understanding of) other labels like "Left of page text area" which is also a possibility here, then you have a better chance of guessing the meaning of "Left of paragraph text area" (compared to the current "Left paragraph border"). 2. It always a matter of choosing one label among a limited list of possibilities, so the label is often being interpreted in relation to the other possibilities. For example, there is "paragraph text area" in the same dropdown list -- so if you know "Paragraph text area" -- then you will have a better chance to guess the likely meaning of "Left of paragraph text area". -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 149242] "Left paragraph border" -> "Left of paragraph indent" and "Right paragraph border" -> "Right of paragraph indent"
https://bugs.documentfoundation.org/show_bug.cgi?id=149242 --- Comment #9 from sdc.bla...@youmail.dk --- (In reply to sdc.blanco from comment #6) > (In reply to Heiko Tietze from comment #4) > > Doubt an ordinary user can follow these considerations if > > just one adjective is added. I agree that an individual label in this context will never be able to explain its meaning by itself ...but two additional considerations that shift the perspective from the semantic meaning of an individual label to a perspective of the meaning of that label in its immediate context. 1. If you have experience with (understanding of) other labels like "Left of page text area" which is also a possibility here, then you have a better chance of guessing the meaning of "Left of paragraph text area" (compared to the current "Left paragraph border"). 2. It always a matter of choosing one label among a limited list of possibilities, so the label is often being interpreted in relation to the other possibilities. For example, there is "paragraph text area" in the same dropdown list -- so if you know "Paragraph text area" -- then you will have a better chance to guess the likely meaning of "Left of paragraph text area". -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 149241] Text flow doesn't adapt with image anchored to character (fine with to paragraph)
https://bugs.documentfoundation.org/show_bug.cgi?id=149241 Telesto changed: What|Removed |Added Summary|Text flow doesn't adapt |Text flow doesn't adapt ||with image anchored to ||character (fine with to ||paragraph) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144060] Writer process hangs sometimes on macOS 11.4 on MacBook Air M1 (Intel version, Zotero uninstalled)
https://bugs.documentfoundation.org/show_bug.cgi?id=144060 --- Comment #15 from David Snow --- No network printers, no network disks. Accessability enabled. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149242] "Left paragraph border" -> "Left of paragraph indent" and "Right paragraph border" -> "Right of paragraph indent"
https://bugs.documentfoundation.org/show_bug.cgi?id=149242 --- Comment #8 from sdc.bla...@youmail.dk --- (In reply to Heiko Tietze from comment #7) > Maybe the screencast makes it more clear. Enough... Because your dialog box is covering the relevant diamonds, it is hard to see. But -- when I place my mouse cursor over the middle diamond (with (center) in your screencast -- and follow your change from 4cm to 0cm -- where I can see the length of the text line increases -- then I can also see that the position of the diamond changes in relation to the mouse cursor. It will be easier for you to see what is happening if you would follow the advice to use the Paragraph section in the Properties Sidebar. (and maybe focus on the middle diamond, which should be the most visible). At the same time, your experience may help you to understand why a name change is appropriate -- because the relevant area here is from the left edge of the page text area (which is why the first diamond never moves) and the left edge of the paragraph text area (which is why the lowest diamond is always tracking the left edge of the paragraph). This why Left paragraph border should be "Left of Paragraph text area". -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 149242] "Left paragraph border" -> "Left of paragraph indent" and "Right paragraph border" -> "Right of paragraph indent"
https://bugs.documentfoundation.org/show_bug.cgi?id=149242 --- Comment #8 from sdc.bla...@youmail.dk --- (In reply to Heiko Tietze from comment #7) > Maybe the screencast makes it more clear. Enough... Because your dialog box is covering the relevant diamonds, it is hard to see. But -- when I place my mouse cursor over the middle diamond (with (center) in your screencast -- and follow your change from 4cm to 0cm -- where I can see the length of the text line increases -- then I can also see that the position of the diamond changes in relation to the mouse cursor. It will be easier for you to see what is happening if you would follow the advice to use the Paragraph section in the Properties Sidebar. (and maybe focus on the middle diamond, which should be the most visible). At the same time, your experience may help you to understand why a name change is appropriate -- because the relevant area here is from the left edge of the page text area (which is why the first diamond never moves) and the left edge of the paragraph text area (which is why the lowest diamond is always tracking the left edge of the paragraph). This why Left paragraph border should be "Left of Paragraph text area". -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-commits] core.git: connectivity/source sw/source
connectivity/source/drivers/dbase/dindexnode.cxx |2 +-
sw/source/uibase/shells/basesh.cxx |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 2106dff67921ba9d8555bee285f55a4157662d33
Author: Andrea Gelmini
AuthorDate: Mon May 23 11:53:10 2022 +0200
Commit: Julien Nabet
CommitDate: Mon May 23 19:26:48 2022 +0200
Fix typos
Change-Id: I53f00e1914283480600dbe84ee96fb38e3cc8e03
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134808
Tested-by: Julien Nabet
Reviewed-by: Julien Nabet
diff --git a/connectivity/source/drivers/dbase/dindexnode.cxx
b/connectivity/source/drivers/dbase/dindexnode.cxx
index 422fef11ce20..3ac8b806499b 100644
--- a/connectivity/source/drivers/dbase/dindexnode.cxx
+++ b/connectivity/source/drivers/dbase/dindexnode.cxx
@@ -482,7 +482,7 @@ void ONDXPage::Merge(sal_uInt16 nParentNodePos, const
ONDXPagePtr& xPage)
nMaxNodes_2 = nMaxNodes / 2;
// Determine if page is right or left neighbour
-boolbRight= ((*xPage)[0].GetKey() > (*this)[0].GetKey()); //
sal_True, whenn xPage the right side is
+boolbRight= ((*xPage)[0].GetKey() > (*this)[0].GetKey()); // true
when xPage is at the right side
sal_uInt16 nNewCount = (*xPage).Count() + Count();
if (IsLeaf())
diff --git a/sw/source/uibase/shells/basesh.cxx
b/sw/source/uibase/shells/basesh.cxx
index e63384824b43..4792e0af9f09 100644
--- a/sw/source/uibase/shells/basesh.cxx
+++ b/sw/source/uibase/shells/basesh.cxx
@@ -1903,7 +1903,7 @@ void SwBaseShell::GetState( SfxItemSet )
break;
case FN_FRAME_WRAP_CONTOUR:
bDisable |= bHtmlMode;
-//no contour available whenn no wrap or wrap
through is set
+//no contour available when no wrap or wrap
through is set
bDisable |= (nSurround ==
css::text::WrapTextMode_NONE || nSurround == css::text::WrapTextMode_THROUGH);
if( !bDisable )
{
[Libreoffice-bugs] [Bug 149246] Win10 buildtin ‚Snip & Sketch‘ and STRG+V doesn't work with Writer and calc
https://bugs.documentfoundation.org/show_bug.cgi?id=149246 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from Julien Nabet --- 6.3.4 LO version is quite old, please give a try at 7.2.7 or brand new 7.3.3 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144060] Writer process hangs sometimes on macOS 11.4 on MacBook Air M1 (Intel version, Zotero uninstalled)
https://bugs.documentfoundation.org/show_bug.cgi?id=144060 Julien Nabet changed: What|Removed |Added Hardware|ARM |x86-64 (AMD64) --- Comment #14 from Julien Nabet --- I changed the title and hardware since you switched back to Intel LO. About the remaining hangs, there may be several causes: - network printer - network disk - accessibility stuff enabled You can give a try first at https://wiki.documentfoundation.org/QA/FirstSteps. Finally does it hang at random or on some specific actions or on specific documents? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144060] Writer process hangs sometimes on macOS 11.4 on MacBook Air M1 (Intel version, Zotero uninstalled)
https://bugs.documentfoundation.org/show_bug.cgi?id=144060 Julien Nabet changed: What|Removed |Added Summary|Writer process hangs|Writer process hangs |frequently on macOS 11.4 on |sometimes on macOS 11.4 on |MacBook Air M1 -- Apple |MacBook Air M1 (Intel |Silicon |version, Zotero ||uninstalled) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136617] FILEOPEN: DOCX: table is larger from LO 7.1
https://bugs.documentfoundation.org/show_bug.cgi?id=136617 Gabor Kelemen (allotropia) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||5474 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104442] [META] OOXML shape (DrawingML and VML) related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104442 Bug 104442 depends on bug 145474, which changed state. Bug 145474 Summary: FILEOPEN DOCX: Shapes loosing their position when opening in writer https://bugs.documentfoundation.org/show_bug.cgi?id=145474 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137825] Images from docx are moved and jumbled when opened with LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=137825 Gabor Kelemen (allotropia) changed: What|Removed |Added CC||forum...@gmail.com --- Comment #9 from Gabor Kelemen (allotropia) --- *** Bug 145474 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145474] FILEOPEN DOCX: Shapes loosing their position when opening in writer
https://bugs.documentfoundation.org/show_bug.cgi?id=145474 Gabor Kelemen (allotropia) changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||6617 CC||kelem...@ubuntu.com --- Comment #7 from Gabor Kelemen (allotropia) --- I see two main issues in this document. First is that the rectangle shapes are placed next to each other and paragraphs around them are wrapped differently: * In Word the empty paragraph is wrapping around all shapes horizontally and vertically, so it's below all of them. The circle shapes are all anchored relative to this paragraph, in practice all appear vertically above it. * In Writer the empty paragraph wraps only the top-left shape and it's rendered next to it. The circle shapes are anchored to this paragraph, so a few cm above this means they appear above the top margin of the page except for those used to be at the bottom, those are still visible. This is the same issue as bug 137825 (and there are likely some others stemming from this difference too...). Let me mark this a duplicate of that one. Second issue is the colorful tables becoming larger, because their empty cells have in Word a 6 pt font size direct formatting that is not imported in Writer, so the style default 11 pt is applied, making the rows taller. This was imported correctly in 7.0, broken since 7.1, just bibisected to the same commit as bug 136617. *** This bug has been marked as a duplicate of bug 137825 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144060] Writer process hangs frequently on macOS 11.4 on MacBook Air M1 -- Apple Silicon
https://bugs.documentfoundation.org/show_bug.cgi?id=144060 --- Comment #13 from David Snow --- The report is 9 months old. I do not remember the exact conditions. I am currently several versions of LO later. I now only use the Intel vesion on my 2020 MacBook Air M1, since it hangs much less frequently than in Apple Silicon one does. I have removed Zotero. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: filter/source
filter/source/config/cache/basecontainer.cxx |6 +-
filter/source/config/cache/cacheitem.cxx | 12 ++--
filter/source/config/cache/cacheitem.hxx |6 +++---
filter/source/config/cache/filtercache.cxx |4 ++--
filter/source/config/cache/filtercache.hxx |6 +++---
filter/source/config/cache/filterfactory.cxx | 10 --
filter/source/config/cache/typedetection.cxx | 14 +++---
7 files changed, 26 insertions(+), 32 deletions(-)
New commits:
commit 41bbc62f38b9eac97c03dc5a7e706fa6aaff055c
Author: Noel Grandin
AuthorDate: Mon May 23 11:26:07 2022 +0200
Commit: Noel Grandin
CommitDate: Mon May 23 18:48:42 2022 +0200
elide allocation of CacheItem when enumerating filters
Change-Id: I44f83485b984548118364dc58cbc3939001506d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134805
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/filter/source/config/cache/basecontainer.cxx
b/filter/source/config/cache/basecontainer.cxx
index 6f9491eeaac1..c5c9ff939443 100644
--- a/filter/source/config/cache/basecontainer.cxx
+++ b/filter/source/config/cache/basecontainer.cxx
@@ -362,14 +362,10 @@ css::uno::Reference< css::container::XEnumeration >
SAL_CALL BaseContainer::crea
try
{
-// convert the given properties first to our internal representation
-CacheItem lProps;
-lProps << lProperties;
-
// search the key names of all items, where its properties match
// the given ones in its minimum
FilterCache* pCache = impl_getWorkingCache();
-lKeys = pCache->getMatchingItemsByProps(m_eType, lProps);
+lKeys = pCache->getMatchingItemsByProps(m_eType, o3tl::span( lProperties.getConstArray(), lProperties.getLength()
));
}
catch(const css::uno::Exception&)
{
diff --git a/filter/source/config/cache/cacheitem.cxx
b/filter/source/config/cache/cacheitem.cxx
index dc28b5471d55..595d3891aa7d 100644
--- a/filter/source/config/cache/cacheitem.cxx
+++ b/filter/source/config/cache/cacheitem.cxx
@@ -263,19 +263,19 @@ static bool isSubSet(const css::uno::Any& aSubSet,
}
-bool CacheItem::haveProps(const CacheItem& lProps) const
+bool CacheItem::haveProps(o3tl::span< const css::beans::NamedValue > lProps)
const
{
for (auto const& prop : lProps)
{
// i) one required property does not exist at this item => return false
-const_iterator pItThis = find(prop.first);
+const_iterator pItThis = find(prop.Name);
if (pItThis == end())
{
return false;
}
// ii) one item does not have the right value => return false
-if (!isSubSet(prop.second, pItThis->second))
+if (!isSubSet(prop.Value, pItThis->second))
{
return false;
}
@@ -288,7 +288,7 @@ bool CacheItem::haveProps(const CacheItem& lProps) const
}
-bool CacheItem::dontHaveProps(const CacheItem& lProps) const
+bool CacheItem::dontHaveProps(o3tl::span< const css::beans::NamedValue >
lProps) const
{
for (auto const& prop : lProps)
{
@@ -296,7 +296,7 @@ bool CacheItem::dontHaveProps(const CacheItem& lProps) const
//=> continue with next one, because
//"excluding" means... "don't have it".
//And "not exists" matches to "don't have it".
-const_iterator pItThis = find(prop.first);
+const_iterator pItThis = find(prop.Name);
if (pItThis == end())
{
continue;
@@ -305,7 +305,7 @@ bool CacheItem::dontHaveProps(const CacheItem& lProps) const
// ii) one item have the right value => return false
// because this item has the requested property...
// But we checked for "don't have it" here.
-if (isSubSet(prop.second, pItThis->second))
+if (isSubSet(prop.Value, pItThis->second))
{
return false;
}
diff --git a/filter/source/config/cache/cacheitem.hxx
b/filter/source/config/cache/cacheitem.hxx
index 965bf7a40126..b20bf72c805c 100644
--- a/filter/source/config/cache/cacheitem.hxx
+++ b/filter/source/config/cache/cacheitem.hxx
@@ -24,7 +24,7 @@
#include
#include
#include
-
+#include
namespace filter::config {
@@ -74,7 +74,7 @@ class CacheItem : public ::comphelper::SequenceAsHashMap
@return sal_True if all given properties exists
at this item; sal_False otherwise.
*/
-bool haveProps(const CacheItem& lProps) const;
+bool haveProps(o3tl::span< const css::beans::NamedValue > lProps)
const;
/** @short check, if the given properties don't exist
@@ -90,7 +90,7 @@ class CacheItem : public ::comphelper::SequenceAsHashMap
@return sal_False if at least on property exists at this item(!);
sal_True otherwise.
*/
-bool dontHaveProps(const CacheItem& lProps) const;
+bool
[Libreoffice-commits] core.git: ucb/source
ucb/source/ucp/file/filtask.cxx |9 +
ucb/source/ucp/file/filtask.hxx | 15 ---
2 files changed, 9 insertions(+), 15 deletions(-)
New commits:
commit 86c95d195dfb1af7511cc0e70a93de9813284855
Author: Noel Grandin
AuthorDate: Mon May 23 11:05:10 2022 +0200
Commit: Noel Grandin
CommitDate: Mon May 23 18:48:25 2022 +0200
std::unordered_set->o3tl::sorted_vector in TaskManager
avoids repeated allocation
Change-Id: Ie3f380ab2f38314b9c8a51fdcd1985329254f5dc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134804
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/ucb/source/ucp/file/filtask.cxx b/ucb/source/ucp/file/filtask.cxx
index 122ad052618c..7c87f5652be7 100644
--- a/ucb/source/ucp/file/filtask.cxx
+++ b/ucb/source/ucp/file/filtask.cxx
@@ -539,7 +539,7 @@ TaskManager::associate( const OUString& aUnqPath,
beans::PropertyState_DEFAULT_VALUE,
Attributes );
-TaskManager::PropertySet::iterator it1 = m_aDefaultProperties.find(
newProperty );
+auto it1 = m_aDefaultProperties.find( newProperty );
if( it1 != m_aDefaultProperties.end() )
throw beans::PropertyExistException( THROW_WHERE );
@@ -570,7 +570,7 @@ TaskManager::deassociate( const OUString& aUnqPath,
{
MyProperty oldProperty( PropertyName );
-TaskManager::PropertySet::iterator it1 = m_aDefaultProperties.find(
oldProperty );
+auto it1 = m_aDefaultProperties.find( oldProperty );
if( it1 != m_aDefaultProperties.end() )
throw beans::NotRemoveableException( THROW_WHERE );
@@ -845,7 +845,7 @@ TaskManager::setv( const OUString& aUnqPath,
TaskManager::ContentMap::iterator it = m_aContent.find( aUnqPath );
PropertySet& properties = it->second.properties;
-TaskManager::PropertySet::iterator it1;
+TaskManager::PropertySet::const_iterator it1;
uno::Any aAny;
for( sal_Int32 i = 0; i < values.getLength(); ++i )
@@ -1934,6 +1934,7 @@ void TaskManager::insertDefaultProperties( const
OUString& aUnqPath )
PropertySet& properties = it->second.properties;
bool ContentNotDefau = properties.find( ContentTProperty ) !=
properties.end();
+properties.reserve(properties.size() + m_aDefaultProperties.size());
for (auto const& defaultprop : m_aDefaultProperties)
{
if( !ContentNotDefau || defaultprop.getPropertyName() != ContentType )
@@ -2243,7 +2244,7 @@ void
TaskManager::commit( const TaskManager::ContentMap::iterator& it,
const osl::FileStatus& aFileStatus )
{
-TaskManager::PropertySet::iterator it1;
+TaskManager::PropertySet::const_iterator it1;
if( it->second.properties.empty() )
{
diff --git a/ucb/source/ucp/file/filtask.hxx b/ucb/source/ucp/file/filtask.hxx
index 3fa4b85752ed..c7199159fb44 100644
--- a/ucb/source/ucp/file/filtask.hxx
+++ b/ucb/source/ucp/file/filtask.hxx
@@ -18,6 +18,7 @@
*/
#pragma once
+#include
#include
#include
@@ -186,23 +187,15 @@ namespace fileaccess
inline void setState( const css::beans::PropertyState& theState )
const;
};
-struct eMyProperty
+struct MyPropertyLess
{
bool operator()( const MyProperty& rKey1, const MyProperty& rKey2
) const
{
-return rKey1.getPropertyName() == rKey2.getPropertyName();
+return rKey1.getPropertyName() < rKey2.getPropertyName();
}
};
-struct hMyProperty
-{
-size_t operator()( const MyProperty& rName ) const
-{
-return rName.getPropertyName().hashCode();
-}
-};
-
-typedef std::unordered_set< MyProperty,hMyProperty,eMyProperty >
PropertySet;
+typedef o3tl::sorted_vector< MyProperty, MyPropertyLess > PropertySet;
class UnqPathData
{
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/appl/appuno.cxx |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit d850510bae778afb788f7d5d48a418858686ea46
Author: Noel Grandin
AuthorDate: Mon May 23 11:03:53 2022 +0200
Commit: Noel Grandin
CommitDate: Mon May 23 18:48:06 2022 +0200
use std::move to avoid some object allocation
Change-Id: Id37b54810e7755bd7a4e354c777e0cfdf069080f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134801
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sfx2/source/appl/appuno.cxx b/sfx2/source/appl/appuno.cxx
index 1c4994f93929..6c75faa21977 100644
--- a/sfx2/source/appl/appuno.cxx
+++ b/sfx2/source/appl/appuno.cxx
@@ -208,7 +208,7 @@ void TransformParameters( sal_uInt16 nSlotId, const
uno::SequencePutValue( rProp.Value, bConvertTwips ? CONVERT_TWIPS :
0 ) )
// only use successfully converted items
-rSet.Put( *pItem );
+rSet.Put( std::move(pItem) );
else
{
SAL_WARN( "sfx", "Property not convertible: " <<
pSlot->pUnoName );
@@ -304,7 +304,7 @@ void TransformParameters( sal_uInt16 nSlotId, const
uno::SequencePutValue( pProp->Value, 0 ) )
// only use successfully converted items
-rSet.Put( *pItem );
+rSet.Put( std::move(pItem) );
else
{
SAL_WARN( "sfx", "Property not convertible: " <<
rArg.pName );
@@ -326,7 +326,7 @@ void TransformParameters( sal_uInt16 nSlotId, const
uno::SequencePutValue( rProp.Value, 0 ) )
// only use successfully converted items
-rSet.Put( *pItem );
+rSet.Put( std::move(pItem) );
else
{
SAL_WARN( "sfx", "Property not convertible: " <<
rArg.pName );
