[Libreoffice-bugs] [Bug 149356] Choose which adjacent column of a "double clicked" formula dictates the extent of the fill
https://bugs.documentfoundation.org/show_bug.cgi?id=149356 Colin changed: What|Removed |Added OS|Windows (All) |All -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149356] Choose which adjacent column of a "double clicked" formula dictates the extent of the fill
https://bugs.documentfoundation.org/show_bug.cgi?id=149356 Colin changed: What|Removed |Added Summary|Choose which adjacent side |Choose which adjacent |of a "double clicked" |column of a "double |formula dictates the extent |clicked" formula dictates |of the fill |the extent of the fill -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149356] New: Choose which adjacent side of a "double clicked" formula dictates the extent of the fill
https://bugs.documentfoundation.org/show_bug.cgi?id=149356 Bug ID: 149356 Summary: Choose which adjacent side of a "double clicked" formula dictates the extent of the fill Product: LibreOffice Version: 7.2.7.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: that.man.co...@gmail.com Description: Imagine a sheet with three columns A-C Column A data extends for 50 rows and column C data for 500 If a formula is entered into B1, selected and double-clicked, it will only ever fill-down to row 50 OR the cell preceding the first "obstruction". The first obstructed cell is an excellent delimiting mechanism but it would be nice if the double-click could be modified - perhaps [Ctrl]+[double-click] - to define that it should fill-down to the right column's extremity. Obviously, the workaround is to pre-identify the extremity, select the source cell and fill-down with [Ctrl]+[Shft]+[Down]. Fun with a large sheet. Steps to Reproduce: Suggested enhancement, see Description Actual Results: Copies delimited by depth of left column or obstructing cell contents Expected Results: Copies delimited by depth of user choice of left or right column or obstructing cell contents Reproducible: Always User Profile Reset: No Additional Info: Version: 7.2.7.2 (x64) / LibreOffice Community Build ID: 8d71d29d553c0f7dcbfa38fbfda25ee34cce99a2 CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: sv-SE (en_GB); UI: en-GB Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143781] [META] Development- and code-related bug reports and tasks
https://bugs.documentfoundation.org/show_bug.cgi?id=143781 Aron Budea changed: What|Removed |Added Depends on||147377 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=147377 [Bug 147377] Reimplement SbiDllMgr::Call using libffi -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147377] Reimplement SbiDllMgr::Call using libffi
https://bugs.documentfoundation.org/show_bug.cgi?id=147377 Aron Budea changed: What|Removed |Added Blocks||143781 CC||aron.bu...@gmail.com Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143781 [Bug 143781] [META] Development- and code-related bug reports and tasks -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143781] [META] Development- and code-related bug reports and tasks
https://bugs.documentfoundation.org/show_bug.cgi?id=143781 Aron Budea changed: What|Removed |Added Depends on||147168 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=147168 [Bug 147168] SbiRuntime::StepPAD is a no-op -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147168] SbiRuntime::StepPAD is a no-op
https://bugs.documentfoundation.org/show_bug.cgi?id=147168 Aron Budea changed: What|Removed |Added CC||aron.bu...@gmail.com Blocks||143781 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143781 [Bug 143781] [META] Development- and code-related bug reports and tasks -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149353] With "to paragraph" anchoring, cannot position an object at the bottom of a paragraph that extends over two pages
https://bugs.documentfoundation.org/show_bug.cgi?id=149353 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de --- Comment #2 from Dieter --- (In reply to sdc.blanco from comment #1) I confirm it with Version: 7.3.4.1 (x64) / LibreOffice Community Build ID: 13668373362b52f6e3ebcaaecb031bd59a3ac66b CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL > "Positioning in paragraphs that extend over two pages is limited to the part > of the paragraph in the page where the anchor is located." Or: "Anchor and it's image or object needs to be on the same page" (or soemthing like that) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 149353] With "to paragraph" anchoring, cannot position an object at the bottom of a paragraph that extends over two pages
https://bugs.documentfoundation.org/show_bug.cgi?id=149353 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de --- Comment #2 from Dieter --- (In reply to sdc.blanco from comment #1) I confirm it with Version: 7.3.4.1 (x64) / LibreOffice Community Build ID: 13668373362b52f6e3ebcaaecb031bd59a3ac66b CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL > "Positioning in paragraphs that extend over two pages is limited to the part > of the paragraph in the page where the anchor is located." Or: "Anchor and it's image or object needs to be on the same page" (or soemthing like that) -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 149354] Writer CRASH on start or opening.
https://bugs.documentfoundation.org/show_bug.cgi?id=149354 Dieter changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 CC||dgp-m...@gmx.de --- Comment #1 from Dieter --- Thank you for reporting the bug. Please just copy and paste link to crash report here. => NEEDINFO If you use Windows 7, SP1 is necessary. Is it installed on your system? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 33787] FORMATTING, FILEOPEN: Bullet point numbers don't increment (.lwp import)
https://bugs.documentfoundation.org/show_bug.cgi?id=33787 --- Comment #10 from Jan Švanda --- Still repro in: Version: 7.4.0.0.alpha1+ (x64) / LibreOffice Community Build ID: bbec710bd25fc5da27636cde73fe4ab23c76904f CPU threads: 12; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win Locale: cs-CZ (cs_CZ); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 33614] Impress [FILEOPEN] did not import double lines from a Powerpoint .ppt correctly.
https://bugs.documentfoundation.org/show_bug.cgi?id=33614 --- Comment #21 from Jan Švanda --- Still repro in: Version: 7.4.0.0.alpha1+ (x64) / LibreOffice Community Build ID: bbec710bd25fc5da27636cde73fe4ab23c76904f CPU threads: 12; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win Locale: cs-CZ (cs_CZ); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 33613] FILEOPEN: MSDraw OLE object not displaying (Word 2 .doc import)
https://bugs.documentfoundation.org/show_bug.cgi?id=33613 --- Comment #31 from Jan Švanda --- Still repro in: Version: 7.4.0.0.alpha1+ (x64) / LibreOffice Community Build ID: bbec710bd25fc5da27636cde73fe4ab23c76904f CPU threads: 12; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win Locale: cs-CZ (cs_CZ); UI: en-US Calc: CL First version (Word for Windows 2) shows nothing. Second version (Word Document 7) shows image, double clicking it results in error box with following text: "Error activating object: General OLE error." Third version (Word Document 8) shows image, double clicking bring up properties. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140227] Lost some multibyte symbols on copying from Calc to Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=140227 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149091] loext:hyperlink as attribute of table-cell-properties is not documented
https://bugs.documentfoundation.org/show_bug.cgi?id=149091 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149090] Excel kind hyperlink as cell-property produces invalid ODF
https://bugs.documentfoundation.org/show_bug.cgi?id=149090 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149327] Can't type accented letters at the end of a paragraph in Writer (EDITING)
https://bugs.documentfoundation.org/show_bug.cgi?id=149327 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149327] Can't type accented letters at the end of a paragraph in Writer (EDITING)
https://bugs.documentfoundation.org/show_bug.cgi?id=149327 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 122805] When loolwsd starts in a NextCloud environment, a zombie process is always created.
https://bugs.documentfoundation.org/show_bug.cgi?id=122805 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 122805] When loolwsd starts in a NextCloud environment, a zombie process is always created.
https://bugs.documentfoundation.org/show_bug.cgi?id=122805 --- Comment #7 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143772] Currency doesn't round properly in calculated fields of Calc.
https://bugs.documentfoundation.org/show_bug.cgi?id=143772 --- Comment #3 from QA Administrators --- Dear Michael Boyer, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135516] Image in Calc sheet partly rendered (MacOS)
https://bugs.documentfoundation.org/show_bug.cgi?id=135516 --- Comment #9 from QA Administrators --- Dear Telesto, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 122149] Libreoffice gives access to the same file (for other Users) with a different UID/GID in Servermode
https://bugs.documentfoundation.org/show_bug.cgi?id=122149 --- Comment #9 from QA Administrators --- Dear Nadi Sanli, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 92821] Make Shift-F5 jump to the last four places where you edited something
https://bugs.documentfoundation.org/show_bug.cgi?id=92821 Aman changed: What|Removed |Added URL||https://ilde2.upf.edu/levin ||sky/v/u1i -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140227] Lost some multibyte symbols on copying from Calc to Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=140227 Aman changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED URL|https://homedecorr.in/ |https://tricks.nayag.com/am ||azon-gift-card-online/ Ever confirmed|0 |1 --- Comment #2 from Aman --- Correct Steps to Reproduce: 1.PPS. Again: 1. Open LO, create new Spreadsheet 2. Double click here on Šampūnas right-click, Copy 3. In Calc ctrl+v, ctrl+c 4. Create new Writer Document 5. ctrl+v in my environment I see Љampūnas 6. Close LO. All apps. 7. Open LO, create new Spreadsheet, ctrl+v, in my env I see ?amp?nas https://tricks.nayag.com/world-zero-codes/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 92826] Make it possible to disable connection to the Internet
https://bugs.documentfoundation.org/show_bug.cgi?id=92826 aman80@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #10 from aman80@gmail.com --- Yes, It is not posible to make the setting. Dont connect to internet So can you open spam save and see what it is to make some protection scanner @ serverside. you can also ask it so people wil have that connection and have https://tricks.nayag.com/delete-pof-account/ .and can now if there is some image that wil comfirm if that desteny email exist. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149355] Writer ENGLISH SENTENCE CHECKING CRASH
https://bugs.documentfoundation.org/show_bug.cgi?id=149355 --- Comment #3 from sdc.bla...@youmail.dk --- (In reply to Don from comment #0) > - OS: Windows 7 64 bit Home From: https://wiki.documentfoundation.org/ReleaseNotes/7.1#Windows: Because of updated Python's change bpo-36085, LibreOffice now requires KB2533623 on Windows 7. The mentioned update is not directly available from Microsoft anymore, but KB3063858 (32-bit/64-bit) may be used, that superseded the older one (details in tdf#144902) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149355] Writer ENGLISH SENTENCE CHECKING CRASH
https://bugs.documentfoundation.org/show_bug.cgi?id=149355 sdc.bla...@youmail.dk changed: What|Removed |Added CC||sdc.bla...@youmail.dk --- Comment #2 from sdc.bla...@youmail.dk --- Do not repro. Can open and change settings for "English Sentence Checking" without a crash. Version: 7.4.0.0.alpha1+ (x64) / LibreOffice Community Build ID: 09822cf77cdbe32b03553cd05154100b5f2591d0 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: da-DK (da_DK); UI: en-US Calc: CL Version: 7.2.6.2 (x64) / LibreOffice Community Build ID: b0ec3a565991f7569a5a7f5d24fed7f52653d754 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: da-DK (da_DK); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149355] Writer ENGLISH SENTENCE CHECKING CRASH
https://bugs.documentfoundation.org/show_bug.cgi?id=149355 --- Comment #1 from Don --- Created attachment 180449 --> https://bugs.documentfoundation.org/attachment.cgi?id=180449=edit SafeMode Crash Dump Dump.ini file ProductName=LibreOffice Version=7.3.2.2 BuildID=49f2b1bff42cfccbd8f788c8dc32c1c309559be0 URL=https://crashreport.libreoffice.org/submit/ UseSkia=false Language=en-US CPUModelName=Pentium(R) Dual-Core CPU E5800 @ 3.20GHz CPUFlags=sse3 monitor ssse3 cpmxch16b xsave osxsave msr cx8 sep cmov clfsh mmx fxsr sse sse2 ht lahf syscall MemoryTotal=4158712 kB Active-SfxObject= Last-4-Uno-Commands=OptionsTreeDialog DumpFile=C:\Users\User\AppData\Roaming\LibreOffice\4\crash\3f19af88-ea57-4732-a472-62afdf9d56b9.dmp GDIHandles=67 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149355] New: Writer ENGLISH SENTENCE CHECKING CRASH
https://bugs.documentfoundation.org/show_bug.cgi?id=149355 Bug ID: 149355 Summary: Writer ENGLISH SENTENCE CHECKING CRASH Product: LibreOffice Version: 7.3.3.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Extensions Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: donny.dan...@hotmail.com Created attachment 180448 --> https://bugs.documentfoundation.org/attachment.cgi?id=180448=edit Crash Dump Description: When attempting to open tools>Options>Language Settings> English Sentence Checking in Writer, LibreOffice hangs then the page, “LibreOffice has stopped working” appears. Safemode makes no difference. Opening the tools>Options>Language Settings> English Sentence Checking in the main Libre Office hub, loads only a blank page. -Grammar checking has stopped working, assuming related problem. -Spell checking still works. Worked fine in Libre 6.4.3.2. Upgraded to 7.3.3.2 and this appeared. Attempted to downgrade to 7.2.7. Same error. Attempted 7.4.0. Same error. Steps to Reproduce: 1.Start libre office writer go to: tools>Options>Language Settings> English Sentence Checking Actual Results: crash Expected Results: To open the settings correctly without crashing. Reproducible: Always User Profile Reset: Yes Crash file attached. Additional Info: Computer: - Processor: Pentium, E5800, 4gb Ram, Intel G41 Express - OS: Windows 7 64 bit Home -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149354] New: Writer CRASH on start or opening.
https://bugs.documentfoundation.org/show_bug.cgi?id=149354 Bug ID: 149354 Summary: Writer CRASH on start or opening. Product: LibreOffice Version: 7.3.3.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: donny.dan...@hotmail.com Created attachment 180447 --> https://bugs.documentfoundation.org/attachment.cgi?id=180447=edit Crash report Description: When attempting to open LO Writer from a pinned shortcut on the taskbar, Writer loads the splash page, opens a new blank Writer document for a second or two, then disappears and says "Due to an error LibreOffice crashed. All the files you were working on will now be saved. The next time LibreOffice is launched, your files will be recovered automatically. "The following files will be recovered." Followed by a blank list. If I press "Ok" Libre opens the main hub without recovering anything. Same error and results when attempting to open a document by double clicking or click and drag onto the LibreOffice 7.3 shortcut on desktop. I can open the LibreOffice main-hub when I can choose which component I want to use (Writer/Calc/ etc.) with no error. If I have the main hub open previous to clicking the Writer pinned shortcut, or double clicking/ click and dragging a file, blank document, or saved file opens fine. No errors. Worked fine in Libre 6.4.3.2. Upgraded to 7.3.3.2 and this appeared. Attempted to downgrade to 7.2.7. Same error. Attempted 7.4.0. Same error. May or may not be related. Grammar checker no longer works. Writer crashes when attempting to open Tools>Options>Language Settings>English Spell Checking. Separate bug report to follow. Steps to Reproduce: 1.Start libre office writer by pinned shortcut or Double click a .odt etc. document. Actual Results: crash Expected Results: To open correctly without crashing. Reproducible: Always User Profile Reset: Yes Crash file attached. Additional Info: Computer: - Processor: Pentium, E5800, 4gb Ram, Intel G41 Express - OS: Windows 7 64 bit Home -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108741] [META] Shapes bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108741 sdc.bla...@youmail.dk changed: What|Removed |Added Depends on||149353 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149353 [Bug 149353] With "to paragraph" anchoring, cannot position an object at the bottom of a paragraph that extends over two pages -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103305] [META] Frame dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103305 sdc.bla...@youmail.dk changed: What|Removed |Added Depends on||149353 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149353 [Bug 149353] With "to paragraph" anchoring, cannot position an object at the bottom of a paragraph that extends over two pages -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149353] With "to paragraph" anchoring, cannot position an object at the bottom of a paragraph that extends over two pages
https://bugs.documentfoundation.org/show_bug.cgi?id=149353 sdc.bla...@youmail.dk changed: What|Removed |Added Keywords||needsUXEval Blocks||103270, 103305, 108741 CC||libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #1 from sdc.bla...@youmail.dk --- Sending to NeedsUXEval -- mostly because this behavior violates the design of the Position dialog for objects. If this is considered NAB or WF, then perhaps a sentence is needed in a help page that says (something like): "Positioning in paragraphs that extend over two pages is limited to the part of the paragraph in the page where the anchor is located." (this would cover both the "to paragraph" and "to character" anchors) Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103270 [Bug 103270] [META] Image/Picture dialog bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=103305 [Bug 103305] [META] Frame dialog bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=108741 [Bug 108741] [META] Shapes bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 149353] With "to paragraph" anchoring, cannot position an object at the bottom of a paragraph that extends over two pages
https://bugs.documentfoundation.org/show_bug.cgi?id=149353 sdc.bla...@youmail.dk changed: What|Removed |Added Keywords||needsUXEval Blocks||103270, 103305, 108741 CC||libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #1 from sdc.bla...@youmail.dk --- Sending to NeedsUXEval -- mostly because this behavior violates the design of the Position dialog for objects. If this is considered NAB or WF, then perhaps a sentence is needed in a help page that says (something like): "Positioning in paragraphs that extend over two pages is limited to the part of the paragraph in the page where the anchor is located." (this would cover both the "to paragraph" and "to character" anchors) Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103270 [Bug 103270] [META] Image/Picture dialog bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=103305 [Bug 103305] [META] Frame dialog bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=108741 [Bug 108741] [META] Shapes bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 103270] [META] Image/Picture dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103270 sdc.bla...@youmail.dk changed: What|Removed |Added Depends on||149353 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149353 [Bug 149353] With "to paragraph" anchoring, cannot position an object at the bottom of a paragraph that extends over two pages -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149353] New: With "to paragraph" anchoring, cannot position an object at the bottom of a paragraph that extends over two pages
https://bugs.documentfoundation.org/show_bug.cgi?id=149353 Bug ID: 149353 Summary: With "to paragraph" anchoring, cannot position an object at the bottom of a paragraph that extends over two pages Product: LibreOffice Version: 7.4.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sdc.bla...@youmail.dk Created attachment 180446 --> https://bugs.documentfoundation.org/attachment.cgi?id=180446=edit Minimal test file to demonstrate positioning in a paragraph across two pages Attachment has a paragraph that extends over two pages. The first page has an image that is: (a) anchored "to paragraph" and (b) positioned with Vertical: Bottom to "Margin" (now "Entire paragraph area"). Actual: Positioned at bottom margin of first page. Expected: Positioned at bottom of paragraph (on second page). (similarly, an image anchored to the same paragraph, but now on the second page, necessarily with a "to character" anchor and using Vertical: Top to "Margin" will only position at top of page text area, not top of paragraph) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120721] Select object also outside of page canvas
https://bugs.documentfoundation.org/show_bug.cgi?id=120721 sdc.bla...@youmail.dk changed: What|Removed |Added CC||sdc.bla...@youmail.dk --- Comment #20 from sdc.bla...@youmail.dk --- (In reply to Heiko Tietze from comment #19) > If we multiselect objects in the document we also have to take care of the > Navigator. Let's keep the idea alive. Maybe this ticket is a DUP of bug 121967, if bug 121967 is expanded slightly to make explicit that selection/grouping should also be possible across two different pages. Please note -- it is possible to select and group shapes across pages, if multiple-page view or book view is used -- but when grouping, the shapes are moved to the same page (i.e., cannot have a group across two pages). Tested with: Version: 7.4.0.0.alpha1+ (x64) / LibreOffice Community Build ID: 09822cf77cdbe32b03553cd05154100b5f2591d0 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: da-DK (da_DK); UI: en-US Calc: CL If this ticket is kept, then it would be good to improve the bug summary. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149325] Statement.xls crash when Excel VBA code is run
https://bugs.documentfoundation.org/show_bug.cgi?id=149325 Aron Budea changed: What|Removed |Added CC||aron.bu...@gmail.com See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||8788 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149352] New: F1 (Help) Edit > Selection Mode > Standard in Writer gives 404 error
https://bugs.documentfoundation.org/show_bug.cgi?id=149352 Bug ID: 149352 Summary: F1 (Help) Edit > Selection Mode > Standard in Writer gives 404 error Product: LibreOffice Version: 7.4.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Documentation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sdc.bla...@youmail.dk CC: olivier.hal...@libreoffice.org In Writer: Edit > Selection Mode > Standard, press F1 gives 404 error Help ID: .uno:SelectionModeDefault Expect: https://help.libreoffice.org/7.4/en-US/text/swriter/01/selection_mode.html?=WRITER -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149350] EDITING: Impress crash in perspective for editing notes
https://bugs.documentfoundation.org/show_bug.cgi?id=149350 --- Comment #1 from lord.dia...@gmx.de --- Additional Info: Version: 7.3.3.2 (x64) / LibreOffice Community Build ID: d1d0ea68f081ee2800a922cac8f79445e4603348 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149351] New: SLIDESHOW: Feature request to add well known keyboard shortcut from Powerpoint CTRL+A
https://bugs.documentfoundation.org/show_bug.cgi?id=149351 Bug ID: 149351 Summary: SLIDESHOW: Feature request to add well known keyboard shortcut from Powerpoint CTRL+A Product: LibreOffice Version: 7.3.3.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: lord.dia...@gmx.de Description: Please add the well known shortcut to always switch back from pen to the arrow using CTRL+A. See also the Microsoft documentation for this shortcut: https://support.microsoft.com/en-us/office/use-keyboard-shortcuts-to-deliver-powerpoint-presentations-1524ffce-bd2a-45f4-9a7f-f18b992b93a0 This shortcut is important to make some hardware presenter devices work as expected. Alternatively the shortcuts for the slideshow could be customizable, but I didn't found any possibility for doing this. Steps to Reproduce: 1. In Impress start the presentation with F5 2. Press CTRL+P to start using the pen 3. Press CTRL+A to switch back to the arrow (currently NOT working) Actual Results: In slideshow nothing happens, when CTRL+A is pressed. Expected Results: In slideshow switch back to arrow from pen, when CTRL+A is pressed. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.3.3.2 (x64) / LibreOffice Community Build ID: d1d0ea68f081ee2800a922cac8f79445e4603348 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149350] EDITING: Impress crash in perspective for editing notes
https://bugs.documentfoundation.org/show_bug.cgi?id=149350 lord.dia...@gmx.de changed: What|Removed |Added Summary|Impress crash in|EDITING: Impress crash in |perspective for editing |perspective for editing |notes |notes -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149350] New: Impress crash in perspective for editing notes
https://bugs.documentfoundation.org/show_bug.cgi?id=149350 Bug ID: 149350 Summary: Impress crash in perspective for editing notes Product: LibreOffice Version: 7.3.3.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: lord.dia...@gmx.de Description: Create a new blank presentation. Switch to the perspective for editing the notes for a slide. Then open the navigator (ctrl + shift + F5). Then click on an item in the navigator to crash Impress. Steps to Reproduce: 1. Create a new blank presentation. 2. Switch to the perspective for editing notes for a slide. 3. Open the navigator (ctrl + shift + F5) in the notes editing perspective. 4. Click on an item in the navigator to crash Impress. Actual Results: Impress crashes and starts again trying to recover the presentation. Expected Results: Impress should not crash Reproducible: Always User Profile Reset: No Additional Info: Was also reproducible in older versions of Impress. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 125943] [META] Qt5 VCL backend bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=125943 Bug 125943 depends on bug 144601, which changed state. Bug 144601 Summary: Rotating image results in inverted colors https://bugs.documentfoundation.org/show_bug.cgi?id=144601 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144601] Rotating image results in inverted colors
https://bugs.documentfoundation.org/show_bug.cgi?id=144601 Jan-Marek Glogowski changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 50206] EDITING: Unable to move/position pictures and objects outside page boundary when using "single page view"
https://bugs.documentfoundation.org/show_bug.cgi?id=50206 sdc.bla...@youmail.dk changed: What|Removed |Added CC||sdc.bla...@youmail.dk Summary|EDITING: Unable to |EDITING: Unable to |move/position pictures and |move/position pictures and |objects outside page|objects outside page |boundary|boundary when using "single ||page view" --- Comment #10 from sdc.bla...@youmail.dk --- Repro comment 0 and comment 8 with: Version: 7.4.0.0.alpha1+ (x64) / LibreOffice Community Build ID: 09822cf77cdbe32b03553cd05154100b5f2591d0 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: da-DK (da_DK); UI: en-US Calc: CL Comment 8 => changing bug summary to indicate "single-page view" (no problem with "Multiple-page view" and "Book view") -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149349] New: LibreOffice Daily Master Build Is Crashed
https://bugs.documentfoundation.org/show_bug.cgi?id=149349 Bug ID: 149349 Summary: LibreOffice Daily Master Build Is Crashed Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: riz...@libreoffice.org Open up Writer make the app crash Here what I can get from CLI Using GTK3: SAL_USE_VCLPLUGIN=gtk3 libreofficedev7.4 (soffice:85912): Gdk-WARNING **: 05:21:20.410: XSetErrorHandler() called with a GDK error trap pushed. Don't do that. warn:sal.osl:85912:85912:sal/osl/unx/module.cxx:152: dlopen(/opt/libreofficedev7.4/program/libjava_gcc3.so, 257): /opt/libreofficedev7.4/program/libjava_gcc3.so: cannot open shared object file: No such file or directory warn:sal.osl:85912:85912:sal/osl/unx/module.cxx:152: dlopen(/opt/libreofficedev7.4/program/libgcc3_java.so, 257): /opt/libreofficedev7.4/program/libgcc3_java.so: cannot open shared object file: No such file or directory KCrash: crashing... crashRecursionCounter = 2 KCrash: Application Name = soffice.bin path = /opt/libreofficedev7.4/program pid = 85912 KCrash: Arguments: /opt/libreofficedev7.4/program/soffice.bin --nocrashhandler KCrash: Attempting to start /usr/lib/x86_64-linux-gnu/libexec/drkonqi libpng warning: iCCP: known incorrect sRGB profile libpng warning: known incorrect sRGB profile libpng warning: profile matches sRGB but writing iCCP instead Unable to find file for pid 85912 expected at "kcrash-metadata/85912.ini" warn:sal.osl.pipe:85912:85914:sal/osl/unx/pipe.cxx:389: accept() failed: EBADF warn:desktop.app:85912:85914:desktop/source/app/officeipcthread.cxx:1209: Error on accept: 10 (soffice:85912): GLib-GIO-ERROR **: 05:22:24.855: inotify read(): Bad file descriptor Using kf5: SAL_USE_VCLPLUGIN=kf5 libreofficedev7.4 warn:sal.osl:86202:86202:sal/osl/unx/module.cxx:152: dlopen(/opt/libreofficedev7.4/program/libjava_gcc3.so, 257): /opt/libreofficedev7.4/program/libjava_gcc3.so: cannot open shared object file: No such file or directory warn:sal.osl:86202:86202:sal/osl/unx/module.cxx:152: dlopen(/opt/libreofficedev7.4/program/libgcc3_java.so, 257): /opt/libreofficedev7.4/program/libgcc3_java.so: cannot open shared object file: No such file or directory KCrash: crashing... crashRecursionCounter = 2 KCrash: Application Name = soffice.bin path = /opt/libreofficedev7.4/program pid = 86202 KCrash: Arguments: /opt/libreofficedev7.4/program/soffice.bin --nocrashhandler KCrash: Attempting to start /usr/lib/x86_64-linux-gnu/libexec/drkonqi libpng warning: iCCP: known incorrect sRGB profile libpng warning: known incorrect sRGB profile libpng warning: profile matches sRGB but writing iCCP instead ^Cwarn:sal.osl.pipe:86202:86206:sal/osl/unx/pipe.cxx:389: accept() failed: EBADF warn:desktop.app:86202:86206:desktop/source/app/officeipcthread.cxx:1209: Error on accept: 10 QSocketNotifier: Invalid socket 9 and type 'Read', disabling... QSocketNotifier: Invalid socket 28 and type 'Read', disabling... Version: 7.4.0.0.alpha1+ / LibreOffice Community Build ID: 7674399aac661eb503d7badc53b9a4d68bd9839d CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb) Locale: id-ID (id_ID.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144601] Rotating image results in inverted colors
https://bugs.documentfoundation.org/show_bug.cgi?id=144601 --- Comment #16 from Commit Notification --- Jan-Marek Glogowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6959a18d1a8fea4d65498083dc3ba05f640d0f39 tdf#144601 Qt fix creating QImage with alpha mask It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144601] Rotating image results in inverted colors
https://bugs.documentfoundation.org/show_bug.cgi?id=144601 Commit Notification changed: What|Removed |Added Whiteboard||target:7.4.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/qt5
vcl/qt5/QtGraphics_GDI.cxx | 66 ++---
1 file changed, 16 insertions(+), 50 deletions(-)
New commits:
commit 6959a18d1a8fea4d65498083dc3ba05f640d0f39
Author: Jan-Marek Glogowski
AuthorDate: Fri May 27 19:08:41 2022 +0200
Commit: Jan-Marek Glogowski
CommitDate: Sun May 29 00:16:21 2022 +0200
tdf#144601 Qt fix creating QImage with alpha mask
Rechecking the QImage documentation, this actually can be easily
done; no more bit twiddling, which I got wrong to begin with.
LO's alpha mask is inverted to Qt's expectations, but we have
invertPixels() and then apply it with setAlphaChannel(). And we
can even set the fAlpha using setOpacity()!
Change-Id: If2030d3f87d3a4698d1cd9af005d307c2ee63061
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135044
Reviewed-by: Michael Weghorn
Reviewed-by: Jan-Marek Glogowski
Tested-by: Jenkins
diff --git a/vcl/qt5/QtGraphics_GDI.cxx b/vcl/qt5/QtGraphics_GDI.cxx
index f87de50827df..6849a3bc7bde 100644
--- a/vcl/qt5/QtGraphics_GDI.cxx
+++ b/vcl/qt5/QtGraphics_GDI.cxx
@@ -601,55 +601,24 @@ bool QtGraphicsBackend::blendAlphaBitmap(const
SalTwoRect&, const SalBitmap& /*r
return false;
}
-static bool getAlphaImage(const SalBitmap& rSourceBitmap, const SalBitmap&
rAlphaBitmap,
- QImage& rAlphaImage)
+static QImage getAlphaImage(const SalBitmap& rSourceBitmap, const SalBitmap&
rAlphaBitmap)
{
-if (rAlphaBitmap.GetBitCount() != 8 && rAlphaBitmap.GetBitCount() != 1)
-{
-SAL_WARN("vcl.gdi", "unsupported alpha depth case: " <<
rAlphaBitmap.GetBitCount());
-return false;
-}
+assert(rSourceBitmap.GetSize() == rAlphaBitmap.GetSize());
+assert(rAlphaBitmap.GetBitCount() == 8 || rAlphaBitmap.GetBitCount() == 1);
-const QImage* pBitmap = static_cast()->GetQImage();
-const QImage* pAlpha = static_cast()->GetQImage();
-rAlphaImage = pBitmap->convertToFormat(Qt_DefaultFormat32);
+QImage aAlphaMask = *static_cast()->GetQImage();
+aAlphaMask.invertPixels();
-if (rAlphaBitmap.GetBitCount() == 8)
-{
-for (int y = 0; y < rAlphaImage.height(); ++y)
-{
-uchar* image_line = rAlphaImage.scanLine(y);
-const uchar* alpha_line = pAlpha->scanLine(y);
-for (int x = 0; x < rAlphaImage.width(); ++x, image_line += 4)
-image_line[3] = 255 - alpha_line[x];
-}
-}
-else
-{
-for (int y = 0; y < rAlphaImage.height(); ++y)
-{
-uchar* image_line = rAlphaImage.scanLine(y);
-const uchar* alpha_line = pAlpha->scanLine(y);
-for (int x = 0; x < rAlphaImage.width(); ++x, image_line += 4)
-{
-if (x && !(x % 8))
-++alpha_line;
-if (0 != (*alpha_line & (1 << (7 - x % 8
-image_line[3] = 0;
-}
-}
-}
-
-return true;
+const QImage* pBitmap = static_cast()->GetQImage();
+QImage aImage = pBitmap->convertToFormat(Qt_DefaultFormat32);
+aImage.setAlphaChannel(aAlphaMask);
+return aImage;
}
bool QtGraphicsBackend::drawAlphaBitmap(const SalTwoRect& rPosAry, const
SalBitmap& rSourceBitmap,
const SalBitmap& rAlphaBitmap)
{
-QImage aImage;
-if (!getAlphaImage(rSourceBitmap, rAlphaBitmap, aImage))
-return false;
-drawScaledImage(rPosAry, aImage);
+drawScaledImage(rPosAry, getAlphaImage(rSourceBitmap, rAlphaBitmap));
return true;
}
@@ -659,20 +628,17 @@ bool QtGraphicsBackend::drawTransformedBitmap(const
basegfx::B2DPoint& rNull,
const SalBitmap& rSourceBitmap,
const SalBitmap* pAlphaBitmap,
double fAlpha)
{
-if (fAlpha != 1.0)
-return false;
QImage aImage;
-if (pAlphaBitmap && !getAlphaImage(rSourceBitmap, *pAlphaBitmap, aImage))
-return false;
+if (!pAlphaBitmap)
+aImage = *static_cast()->GetQImage();
else
-{
-const QImage* pBitmap = static_cast()->GetQImage();
-aImage = pBitmap->convertToFormat(Qt_DefaultFormat32);
-}
+aImage = getAlphaImage(rSourceBitmap, *pAlphaBitmap);
-QtPainter aPainter(*this);
const basegfx::B2DVector aXRel = rX - rNull;
const basegfx::B2DVector aYRel = rY - rNull;
+
+QtPainter aPainter(*this);
+aPainter.setOpacity(fAlpha);
aPainter.setTransform(QTransform(aXRel.getX() / aImage.width(),
aXRel.getY() / aImage.width(),
aYRel.getX() / aImage.height(),
aYRel.getY() / aImage.height(),
rNull.getX(), rNull.getY()));
[Libreoffice-bugs] [Bug 149337] Center s/be Centre
https://bugs.documentfoundation.org/show_bug.cgi?id=149337 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr, ||stuart.swales.croftnuisk@gm ||ail.com --- Comment #1 from Julien Nabet --- Here's the link: https://translations.documentfoundation.org/translate/libo_ui-master/officecfgregistrydataorgopenofficeofficeui/en_GB/?checksum=9298c169936ac187=note%3APaLDT_by=-priority%2Cposition Stuart: Searching about "Center", show there are several cases. Any thoughts here? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 31914] FILEOPEN: incorrectly formatting 2007 DOCX; missing first page text shape content with Content Controls
https://bugs.documentfoundation.org/show_bug.cgi?id=31914 --- Comment #22 from Jan Švanda --- Still present in: Version: 7.4.0.0.alpha1+ (x64) / LibreOffice Community Build ID: bbec710bd25fc5da27636cde73fe4ab23c76904f CPU threads: 12; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win Locale: cs-CZ (cs_CZ); UI: en-US Calc: CL The columns formatting issues seems mostly gone, but the text on the first page of the original reference document is still missing. The text on the resaved document is present, but without any formatting. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 33263] FILEOPEN wrong wrap at frame in imported .doc from original Wrap Around tables used as bullets
https://bugs.documentfoundation.org/show_bug.cgi?id=33263 --- Comment #14 from Jan Švanda --- Still present in: Version: 7.4.0.0.alpha1+ (x64) / LibreOffice Community Build ID: bbec710bd25fc5da27636cde73fe4ab23c76904f CPU threads: 12; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win Locale: cs-CZ (cs_CZ); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sw/source
sw/source/core/layout/wsfrm.cxx | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
New commits:
commit c3a1f4cc50fa4a17589ca1b4643a554964af59a3
Author: Michael Stahl
AuthorDate: Tue May 24 15:20:42 2022 +0200
Commit: Caolán McNamara
CommitDate: Sat May 28 22:32:39 2022 +0200
sw: fix mysterious layout loop in CppunitTest_sw_uiwriter3 testTdf104649
This didn't happen with master from a week ago on Fedora 35, but happens
with Monday's master on Fedora 36. Also happens with libreoffice-7-3
branch.
Fundamentally the problem with the bugdoc is that there are tables in
footnotes, which aren't really supported and can't split across pages
like they would need to.
The loop happens because a footnote on page 48 invalidates position of
its anchor frame 549 on page 45.
This is probably pointless, let's only invalidate if the anchor is on
the same page (it should be on the same page, but probably the tables in
other footnotes get in the way).
Change-Id: I87976c7f8b35725bc8e642133bebb396d37ff0be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134877
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 0496252c2c7fd2d694c4a73f387ef75e0021de3e)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134894
Reviewed-by: Caolán McNamara
diff --git a/sw/source/core/layout/wsfrm.cxx b/sw/source/core/layout/wsfrm.cxx
index 62c99a5f6e87..43bd9a7037a1 100644
--- a/sw/source/core/layout/wsfrm.cxx
+++ b/sw/source/core/layout/wsfrm.cxx
@@ -3001,7 +3001,16 @@ SwTwips SwLayoutFrame::ShrinkFrame( SwTwips nDist, bool
bTst, bool bInfo )
pTmp->InvalidateSize();
}
else
-pCnt->InvalidatePos();
+{
+if (pCnt->FindPageFrame() == FindPageFrame())
+{
+pCnt->InvalidatePos();
+}
+else
+{
+SAL_WARN("sw.layout", "footnote frame on different page
than ref frame?");
+}
+}
}
}
return nReal;
[Libreoffice-bugs] [Bug 136027] Accessibility Cursor Focus jumps using settings menu with keys
https://bugs.documentfoundation.org/show_bug.cgi?id=136027 Martin Srdoš changed: What|Removed |Added CC||srd...@email.cz --- Comment #5 from Martin Srdoš --- Hello Karl, today is newer version of NVDA. Is this issue still present in this? Also in newest version of LO? I can't reproduce it in any version. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144395] LibreOffice from 6.4 very slow and one CPU 100% while opening large Chinese .docx with 2521 pages
https://bugs.documentfoundation.org/show_bug.cgi?id=144395 --- Comment #6 from Roman Kuznetsov <79045_79...@mail.ru> --- I got the crash when tried to open the file after 3 min 30 sec in Version: 7.4.0.0.alpha1+ (x64) / LibreOffice Community Build ID: a8df5c815c8b002b7083b8777e3dd8beac573bf3 CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: ru-RU Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104450] [META] DOCX (OOXML) file opening issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104450 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||144395 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=144395 [Bug 144395] LibreOffice from 6.4 very slow and one CPU 100% while opening large Chinese .docx with 2521 pages -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144395] LibreOffice from 6.4 very slow and one CPU 100% while opening large Chinese .docx with 2521 pages
https://bugs.documentfoundation.org/show_bug.cgi?id=144395 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||104450 CC||79045_79...@mail.ru, ||mark...@gmail.com Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104450 [Bug 104450] [META] DOCX (OOXML) file opening issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113338] [META] Embedded fonts bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113338 libreu...@online.de changed: What|Removed |Added Depends on||149348 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149348 [Bug 149348] Fonts used in applied styles not embedded even if enabled in file properties -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149348] Fonts used in applied styles not embedded even if enabled in file properties
https://bugs.documentfoundation.org/show_bug.cgi?id=149348 libreu...@online.de changed: What|Removed |Added Blocks||113338 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=113338 [Bug 113338] [META] Embedded fonts bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 106179] [META] Writer comment bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=106179 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||144681 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=144681 [Bug 144681] UI: Comment box starts flashing on keypress when in table causing lots of redundant paints (hammering the CPU) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144681] UI: Comment box starts flashing on keypress when in table causing lots of redundant paints (hammering the CPU)
https://bugs.documentfoundation.org/show_bug.cgi?id=144681 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru Blocks||106179 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=106179 [Bug 106179] [META] Writer comment bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 61174] [META] Rework of Recent Documents List, options to prevent logging and to manage entries on the list
https://bugs.documentfoundation.org/show_bug.cgi?id=61174 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||144756 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=144756 [Bug 144756] Recent Documents list extremely slow, even hangs -- using "PPA version" 7.2.1.2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144756] Recent Documents list extremely slow, even hangs -- using "PPA version" 7.2.1.2
https://bugs.documentfoundation.org/show_bug.cgi?id=144756 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||61174 CC||79045_79...@mail.ru Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=61174 [Bug 61174] [META] Rework of Recent Documents List, options to prevent logging and to manage entries on the list -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149347] Libre Office does not start
https://bugs.documentfoundation.org/show_bug.cgi?id=149347 Timur changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from Timur --- You should paste here info from Help-About. Then try with LO User Profile Reset, which is profile folder rename or delete. Then you can uninstall and reinstall LO. Then you can see if Skia problem by turning it off. Please write what you tried and see https://wiki.documentfoundation.org/QA/FirstSteps. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 83946] [META] Tracking changes issues
https://bugs.documentfoundation.org/show_bug.cgi?id=83946 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||146436 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=146436 [Bug 146436] Short freeze when going to next line with record track changes hidden (not shown) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146436] Short freeze when going to next line with record track changes hidden (not shown)
https://bugs.documentfoundation.org/show_bug.cgi?id=146436 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru Blocks||83946 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=83946 [Bug 83946] [META] Tracking changes issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149348] Fonts used in applied styles not embedded even if enabled in file properties
https://bugs.documentfoundation.org/show_bug.cgi?id=149348 --- Comment #1 from libreu...@online.de --- See also bug 83675. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104444] [META] DOCX (OOXML) table-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=10 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||147131 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=147131 [Bug 147131] [DOCX] A simple table in a table causes freezes; and cells or cells' contents disappear/reappear on scrolling -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147131] [DOCX] A simple table in a table causes freezes; and cells or cells' contents disappear/reappear on scrolling
https://bugs.documentfoundation.org/show_bug.cgi?id=147131 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Summary|A simple table in a table |[DOCX] A simple table in a |causes freezes; and cells |table causes freezes; and |or cells' contents |cells or cells' contents |disappear/reappear on |disappear/reappear on |scrolling |scrolling Blocks||10 Keywords||filter:docx CC||79045_79...@mail.ru Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=10 [Bug 10] [META] DOCX (OOXML) table-related issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 83675] embedded fonts are double and also non-used fonts are embedded - the used font is not embedded
https://bugs.documentfoundation.org/show_bug.cgi?id=83675 --- Comment #18 from libreu...@online.de --- Created attachment 180445 --> https://bugs.documentfoundation.org/attachment.cgi?id=180445=edit used_fonts_embedded.odt -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 105948] [META] Undo/Redo bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=105948 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||147464 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=147464 [Bug 147464] Undo rejecting changes freezes LibreOffice; lots of time spend in SwRangeRedline::GetExtraData -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 83946] [META] Tracking changes issues
https://bugs.documentfoundation.org/show_bug.cgi?id=83946 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||147464 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=147464 [Bug 147464] Undo rejecting changes freezes LibreOffice; lots of time spend in SwRangeRedline::GetExtraData -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147464] Undo rejecting changes freezes LibreOffice; lots of time spend in SwRangeRedline::GetExtraData
https://bugs.documentfoundation.org/show_bug.cgi?id=147464 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru Blocks||83946, 105948 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=83946 [Bug 83946] [META] Tracking changes issues https://bugs.documentfoundation.org/show_bug.cgi?id=105948 [Bug 105948] [META] Undo/Redo bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 109530] [META] File opening issues
https://bugs.documentfoundation.org/show_bug.cgi?id=109530 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||148013 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148013 [Bug 148013] Larger ODT with ~500 pages and comments an record changes very slow to load, worse than before -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 83946] [META] Tracking changes issues
https://bugs.documentfoundation.org/show_bug.cgi?id=83946 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||148013 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148013 [Bug 148013] Larger ODT with ~500 pages and comments an record changes very slow to load, worse than before -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148013] Larger ODT with ~500 pages and comments an record changes very slow to load, worse than before
https://bugs.documentfoundation.org/show_bug.cgi?id=148013 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru Blocks||109530, 83946 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=83946 [Bug 83946] [META] Tracking changes issues https://bugs.documentfoundation.org/show_bug.cgi?id=109530 [Bug 109530] [META] File opening issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 83675] embedded fonts are double and also non-used fonts are embedded - the used font is not embedded
https://bugs.documentfoundation.org/show_bug.cgi?id=83675 --- Comment #17 from libreu...@online.de --- Created attachment 180444 --> https://bugs.documentfoundation.org/attachment.cgi?id=180444=edit unused_font_not_removed_used_font_not_embedded.odt I also hit the bug and spent hours to find a workaround or to fix my odt. In a fresh document, my used font "Breitkopf FrakturUNZ1L" is embedded (except if only using it in an applied style - see bug 149348), but not in the document I edited. I even completely cleared the complete document and removed the direct formatting of the one and only remaining empty paragraph. Surprisingly one font is still embedded despite it's now unused - "Alte DIN 1451 Mittelschrift". The workaround I've done now is completely unfeasible for the average user and big documents - see below steps. - Open document. - Reformat document to only use styles. - Close document. - Open content.xml of the odt file and delete everything within the tags - except the ones having 'style:family="graphic"'. - Open document. - Add empty paragraph(s), each directly formatted with the required font. - Save and close document. Fonts will now get embedded. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104848] [META] DOC (binary) file opening issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104848 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||149147 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149147 [Bug 149147] FILEOPEN .DOC File opening takes minutes in Linux -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149147] FILEOPEN .DOC File opening takes minutes in Linux
https://bugs.documentfoundation.org/show_bug.cgi?id=149147 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||104848 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104848 [Bug 104848] [META] DOC (binary) file opening issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149237] SingleSignOn unsuccessful loop
https://bugs.documentfoundation.org/show_bug.cgi?id=149237 Timur changed: What|Removed |Added Resolution|--- |NOTABUG Status|NEEDINFO|RESOLVED --- Comment #3 from Timur --- I close then. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149334] Tip of the day doesn't open on startup if re-enabled later
https://bugs.documentfoundation.org/show_bug.cgi?id=149334 Timur changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |NOTABUG --- Comment #6 from Timur --- Thanks Julien for pointing out and Rafael for testing. NAB xes. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 125760] UI: Notes View: Currently selected / opened slide is not visible during edit
https://bugs.documentfoundation.org/show_bug.cgi?id=125760 Timur changed: What|Removed |Added Severity|trivial |minor Keywords|notBibisectable |preBibisect Priority|lowest |low -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/source
vcl/source/filter/itiff/itiff.cxx | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
New commits:
commit 8c4ca609c532b01c880d9803ba655c5688e5f0f1
Author: Caolán McNamara
AuthorDate: Fri May 27 14:14:06 2022 +0100
Commit: Caolán McNamara
CommitDate: Sat May 28 21:01:00 2022 +0200
ofz#47673 skip oversized tiff images
Change-Id: I78727819b7c440855f89240f396dad845a295d61
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135041
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/vcl/source/filter/itiff/itiff.cxx
b/vcl/source/filter/itiff/itiff.cxx
index 6eac698121f0..59021b8c4999 100644
--- a/vcl/source/filter/itiff/itiff.cxx
+++ b/vcl/source/filter/itiff/itiff.cxx
@@ -136,8 +136,14 @@ bool ImportTiffGraphicImport(SvStream& rTIFF, Graphic&
rGraphic)
}
}
-size_t npixels = w * h;
-std::vector raster(npixels);
+uint32_t nPixelsRequired;
+if (o3tl::checked_multiply(w, h, nPixelsRequired))
+{
+SAL_WARN("filter.tiff", "skipping oversized tiff image");
+break;
+}
+
+std::vector raster(nPixelsRequired);
if (TIFFReadRGBAImageOriented(tif, w, h, raster.data(),
ORIENTATION_TOPLEFT, 1))
{
Bitmap bitmap(Size(w, h), vcl::PixelFormat::N24_BPP);
[Libreoffice-commits] core.git: editeng/source include/svl svl/source sw/source
editeng/source/rtf/svxrtf.cxx |6 +--
include/svl/itemiter.hxx |1
include/svl/itemset.hxx |2 -
include/svl/whiter.hxx|1
svl/source/items/itemiter.cxx |6 +++
svl/source/items/itemset.cxx | 74 +-
svl/source/items/whiter.cxx |7 +++
sw/source/core/txtnode/thints.cxx |4 +-
sw/source/uibase/wrtsh/wrtsh1.cxx |2 -
9 files changed, 64 insertions(+), 39 deletions(-)
New commits:
commit 9ae3863f2afaa07abda6af11daf34bf6b808c3af
Author: Noel Grandin
AuthorDate: Sat May 28 18:14:29 2022 +0200
Commit: Noel Grandin
CommitDate: Sat May 28 20:50:40 2022 +0200
add ClearItem to the SfxItemSet iterators
to speed up operations when iterating over SfxItemSets
Change-Id: Ie40327ffaf7faa801ccc12d2b05c546a7fe49802
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135079
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/editeng/source/rtf/svxrtf.cxx b/editeng/source/rtf/svxrtf.cxx
index bb07beae826c..b06337a143b1 100644
--- a/editeng/source/rtf/svxrtf.cxx
+++ b/editeng/source/rtf/svxrtf.cxx
@@ -654,7 +654,7 @@ void SvxRTFParser::ClearStyleAttr_( SvxRTFItemStackType&
rStkType )
if (SfxItemPool::IsWhich(nWhich) &&
SfxItemState::SET == aIter.GetItemState( false, ) &&
rPool.GetDefaultItem( nWhich ) == *pItem )
-rSet.ClearItem( nWhich ); // delete
+aIter.ClearItem(); // delete
}
}
else
@@ -707,7 +707,7 @@ void SvxRTFParser::AttrGroupEnd() // process the current,
delete from Stack
if( SfxItemState::SET == pCurrent->aAttrSet.GetItemState(
pItem->Which(), false, ) &&
*pItem == *pGet )
-pOld->aAttrSet.ClearItem( pItem->Which() );
+aIter.ClearItem();
pItem = aIter.NextItem();
} while (pItem);
@@ -1109,7 +1109,7 @@ void SvxRTFItemStackType::Compress( const SvxRTFParser&
rParser )
sal_uInt16 nWhich = pIterItem->Which();
if( SfxItemState::SET != pTmp->aAttrSet.GetItemState( nWhich,
false, ) || *pItem != *pIterItem)
-aMrgSet.ClearItem( nWhich );
+aIter.ClearItem();
pIterItem = aIter.NextItem();
} while(pIterItem);
diff --git a/include/svl/itemiter.hxx b/include/svl/itemiter.hxx
index dfe3c9dc6e22..13cf14b61012 100644
--- a/include/svl/itemiter.hxx
+++ b/include/svl/itemiter.hxx
@@ -49,6 +49,7 @@ public:
SfxItemState GetItemState(bool bSrchInParent = true,
const SfxPoolItem** ppItem = nullptr) const;
+void ClearItem();
private:
const SfxPoolItem* ImplNextItem();
diff --git a/include/svl/itemset.hxx b/include/svl/itemset.hxx
index 086ddc42f74e..b6404b6cc984 100644
--- a/include/svl/itemset.hxx
+++ b/include/svl/itemset.hxx
@@ -227,7 +227,7 @@ public:
void dumpAsXml(xmlTextWriterPtr pWriter) const;
private:
-sal_uInt16 ClearSingleItemImpl( sal_uInt16 nWhich );
+sal_uInt16 ClearSingleItemImpl( sal_uInt16 nWhich,
std::optional oItemOffsetHint );
sal_uInt16 ClearAllItemsImpl();
SfxItemState GetItemStateImpl( sal_uInt16 nWhich,
bool bSrchInParent,
diff --git a/include/svl/whiter.hxx b/include/svl/whiter.hxx
index df8c6fea79f2..155d02d7f3ab 100644
--- a/include/svl/whiter.hxx
+++ b/include/svl/whiter.hxx
@@ -46,6 +46,7 @@ public:
sal_uInt16 FirstWhich();
SfxItemState GetItemState(bool bSrchInParent = true,
const SfxPoolItem** ppItem = nullptr) const;
+void ClearItem();
};
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/svl/source/items/itemiter.cxx b/svl/source/items/itemiter.cxx
index b1bdedf416e0..fd0f6240e0c6 100644
--- a/svl/source/items/itemiter.cxx
+++ b/svl/source/items/itemiter.cxx
@@ -62,4 +62,10 @@ SfxItemState SfxItemIter::GetItemState(bool bSrchInParent,
const SfxPoolItem** p
return m_rSet.GetItemStateImpl(nWhich, bSrchInParent, ppItem, m_nCurrent);
}
+void SfxItemIter::ClearItem()
+{
+sal_uInt16 nWhich = (*(m_rSet.m_ppItems + m_nCurrent))->Which();
+const_cast(m_rSet).ClearSingleItemImpl(nWhich, m_nCurrent);
+}
+
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/svl/source/items/itemset.cxx b/svl/source/items/itemset.cxx
index 133603fe0f39..982cbc837898 100644
--- a/svl/source/items/itemset.cxx
+++ b/svl/source/items/itemset.cxx
@@ -199,50 +199,60 @@ sal_uInt16 SfxItemSet::ClearItem( sal_uInt16 nWhich )
if( !Count() )
return 0;
if( nWhich )
-return ClearSingleItemImpl(nWhich);
+return ClearSingleItemImpl(nWhich, std::nullopt);
else
return ClearAllItemsImpl();
}
-sal_uInt16 SfxItemSet::ClearSingleItemImpl( sal_uInt16
[Libreoffice-commits] core.git: include/svl svl/source
include/svl/itemset.hxx |2
svl/source/items/itemset.cxx | 132 +++
2 files changed, 73 insertions(+), 61 deletions(-)
New commits:
commit 8f3e12b7a918935eae4e98c47cdc3b575e8bf089
Author: Noel Grandin
AuthorDate: Sat May 28 17:11:54 2022 +0200
Commit: Noel Grandin
CommitDate: Sat May 28 20:50:25 2022 +0200
split SfxItem::ClearItem into two methods
in preparation for passing a hint into it
Change-Id: Id9e5516619a314406d8250bb2145996593dafbaf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135078
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/svl/itemset.hxx b/include/svl/itemset.hxx
index 746ba8448afb..086ddc42f74e 100644
--- a/include/svl/itemset.hxx
+++ b/include/svl/itemset.hxx
@@ -227,6 +227,8 @@ public:
void dumpAsXml(xmlTextWriterPtr pWriter) const;
private:
+sal_uInt16 ClearSingleItemImpl( sal_uInt16 nWhich );
+sal_uInt16 ClearAllItemsImpl();
SfxItemState GetItemStateImpl( sal_uInt16 nWhich,
bool bSrchInParent,
const SfxPoolItem **ppItem,
diff --git a/svl/source/items/itemset.cxx b/svl/source/items/itemset.cxx
index e0e1ee8823a3..133603fe0f39 100644
--- a/svl/source/items/itemset.cxx
+++ b/svl/source/items/itemset.cxx
@@ -198,87 +198,97 @@ sal_uInt16 SfxItemSet::ClearItem( sal_uInt16 nWhich )
{
if( !Count() )
return 0;
+if( nWhich )
+return ClearSingleItemImpl(nWhich);
+else
+return ClearAllItemsImpl();
+}
+sal_uInt16 SfxItemSet::ClearSingleItemImpl( sal_uInt16 nWhich )
+{
sal_uInt16 nDel = 0;
SfxPoolItem const** ppFnd = m_ppItems;
-if( nWhich )
+for (const WhichPair& rPair : m_pWhichRanges)
{
-for (const WhichPair& rPair : m_pWhichRanges)
+// Within this range?
+if( rPair.first <= nWhich && nWhich <= rPair.second )
{
-// Within this range?
-if( rPair.first <= nWhich && nWhich <= rPair.second )
+// Actually set?
+ppFnd += nWhich - rPair.first;
+if( *ppFnd )
{
-// Actually set?
-ppFnd += nWhich - rPair.first;
-if( *ppFnd )
-{
-// Due to the assertions in the sub calls, we need to do
the following
---m_nCount;
-const SfxPoolItem *pItemToClear = *ppFnd;
-*ppFnd = nullptr;
+// Due to the assertions in the sub calls, we need to do the
following
+--m_nCount;
+const SfxPoolItem *pItemToClear = *ppFnd;
+*ppFnd = nullptr;
-if ( !IsInvalidItem(pItemToClear) )
+if ( !IsInvalidItem(pItemToClear) )
+{
+if (SfxItemPool::IsWhich(nWhich))
{
-if (SfxItemPool::IsWhich(nWhich))
-{
-const SfxPoolItem& rNew = m_pParent
-? m_pParent->Get( nWhich )
-: m_pPool->GetDefaultItem( nWhich );
+const SfxPoolItem& rNew = m_pParent
+? m_pParent->Get( nWhich )
+: m_pPool->GetDefaultItem( nWhich );
-Changed( *pItemToClear, rNew );
-}
-if ( pItemToClear->Which() )
-m_pPool->Remove( *pItemToClear );
+Changed( *pItemToClear, rNew );
}
-++nDel;
+if ( pItemToClear->Which() )
+m_pPool->Remove( *pItemToClear );
}
-
-// found => break
-break;
+++nDel;
}
-ppFnd += rPair.second - rPair.first + 1;
+
+// found => break
+break;
}
+ppFnd += rPair.second - rPair.first + 1;
}
-else
-{
-nDel = m_nCount;
+return nDel;
+}
+
-for (const WhichPair& rPair : m_pWhichRanges)
+sal_uInt16 SfxItemSet::ClearAllItemsImpl()
+{
+sal_uInt16 nDel = m_nCount;
+SfxPoolItem const** ppFnd = m_ppItems;
+
+for (const WhichPair& rPair : m_pWhichRanges)
+{
+for( sal_uInt16 nWhich = rPair.first; nWhich <= rPair.second;
++nWhich, ++ppFnd )
{
-for( nWhich = rPair.first; nWhich <= rPair.second; ++nWhich,
++ppFnd )
-if( *ppFnd )
-{
-// Due to the assertions in the sub calls, we need to do
this
---m_nCount;
-const SfxPoolItem *pItemToClear = *ppFnd;
-*ppFnd = nullptr;
+if( !*ppFnd )
+continue;
-
[Libreoffice-bugs] [Bug 149329] After right-click cursor doesn't change back to the typing cursor
https://bugs.documentfoundation.org/show_bug.cgi?id=149329 --- Comment #3 from Commit Notification --- Jan-Marek Glogowski committed a patch related to this issue. It has been pushed to "libreoffice-7-3": https://git.libreoffice.org/core/commit/8e92328c3f7d93810f0b40bafb62b981d8e98f9f tdf#149329 Qt change cursor via QWidget It will be available in 7.3.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149329] After right-click cursor doesn't change back to the typing cursor
https://bugs.documentfoundation.org/show_bug.cgi?id=149329 Commit Notification changed: What|Removed |Added Whiteboard|target:7.4.0|target:7.4.0 target:7.3.5 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - vcl/qt5
vcl/qt5/QtFrame.cxx |5 +
1 file changed, 1 insertion(+), 4 deletions(-)
New commits:
commit 8e92328c3f7d93810f0b40bafb62b981d8e98f9f
Author: Jan-Marek Glogowski
AuthorDate: Fri May 27 23:36:20 2022 +0200
Commit: Michael Weghorn
CommitDate: Sat May 28 20:32:38 2022 +0200
tdf#149329 Qt change cursor via QWidget
... instead of its QWindow
No idea, why my initial implementation used the QWindow. Neither
do I know, why it's now somehow broken. The code is called, but
the cursor doesn't change. But it seems to work via QWidget, so
just do that. IMHO less QWindow is preferable generally; let Qt
handle more of the low-level stuff.
Change-Id: Id23fba719c9a4d7e760991c51e6021c6f89be345
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135051
Reviewed-by: Michael Weghorn
Reviewed-by: Jan-Marek Glogowski
Tested-by: Jenkins
(cherry picked from commit caf862fc843c89cceae2121f743a3822e09bbd46)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135080
diff --git a/vcl/qt5/QtFrame.cxx b/vcl/qt5/QtFrame.cxx
index b9a5f40bea91..8af59966dcd7 100644
--- a/vcl/qt5/QtFrame.cxx
+++ b/vcl/qt5/QtFrame.cxx
@@ -819,14 +819,11 @@ void QtFrame::ToTop(SalFrameToTop nFlags)
void QtFrame::SetPointer(PointerStyle ePointerStyle)
{
-QWindow* pWindow = m_pQWidget->window()->windowHandle();
-if (!pWindow)
-return;
if (ePointerStyle == m_ePointerStyle)
return;
m_ePointerStyle = ePointerStyle;
-
pWindow->setCursor(static_cast(GetSalData())->getCursor(ePointerStyle));
+
m_pQWidget->setCursor(static_cast(GetSalData())->getCursor(ePointerStyle));
}
void QtFrame::CaptureMouse(bool bMouse)
[Libreoffice-bugs] [Bug 149348] New: Fonts used in applied styles not embedded even if enabled in file properties
https://bugs.documentfoundation.org/show_bug.cgi?id=149348 Bug ID: 149348 Summary: Fonts used in applied styles not embedded even if enabled in file properties Product: LibreOffice Version: 7.3.3.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: libreu...@online.de Description: Fonts are only embedded if they are used in direct formatting. If a document is formatted only using styles, no fonts are embedded, even if they are used in the applied styles. When switching the font of the one and only paragraph in the test document and saving, the used font is embedded. When switching back to the font used before, it's also embedded. Workaround: So if using only styles for formatting, all the needed fonts currently must be used once in the document by direct formatting, even if it's only for whitespace. Steps to Reproduce: - Open LibreOffice Writer - unsaved document "Untitled 1" will be open. - Open menu File -> Properties... - In dialog "Properties of "Untitled 1" switch to tab "Font". - Tick both checkboxes of "Font Embedding" and untick the three checkboxes of "Font scripts to embed". - Close dialog with "OK". - Type test into first line of document. For me, default font is Liberation Serif. - Save document in home directory with name test.odt. - View contents of zip test.odt. Actual Results: No directory Fonts present in zip test.odt meaning no embedded fonts. Expected Results: Directory Fonts present in zip test.odt meaning fonts have been embedded. Reproducible: Always User Profile Reset: No Additional Info: - -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: svl/source
svl/source/items/itemset.cxx | 29 +++--
1 file changed, 11 insertions(+), 18 deletions(-)
New commits:
commit 1cfa3f8694d4b585549e6dae7396d408184106cb
Author: Noel Grandin
AuthorDate: Sat May 28 17:05:03 2022 +0200
Commit: Noel Grandin
CommitDate: Sat May 28 19:31:20 2022 +0200
simplify SfxItemSet::Differentiate and SfxItemSet::Intersect
using SfxWhichIter instead of SfxItemIter
Change-Id: I046ae2cec9246b1dea9c484f94b88d64825f952c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135077
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/svl/source/items/itemset.cxx b/svl/source/items/itemset.cxx
index 842bc2d16623..e0e1ee8823a3 100644
--- a/svl/source/items/itemset.cxx
+++ b/svl/source/items/itemset.cxx
@@ -887,17 +887,14 @@ void SfxItemSet::Intersect( const SfxItemSet& rSet )
}
else
{
-SfxItemIter aIter( *this );
-const SfxPoolItem* pItem = aIter.GetCurItem();
-do
+SfxWhichIter aIter( *this );
+sal_uInt16 nWhich = aIter.FirstWhich();
+while ( nWhich )
{
-sal_uInt16 nWhich = IsInvalidItem( pItem )
-? GetWhichByPos( aIter.GetCurPos() )
-: pItem->Which();
if( SfxItemState::UNKNOWN == rSet.GetItemState( nWhich, false ) )
-ClearItem( nWhich );// Delete
-pItem = aIter.NextItem();
-} while (pItem);
+ClearItem( nWhich ); // Delete
+nWhich = aIter.NextWhich();
+}
}
}
@@ -936,18 +933,14 @@ void SfxItemSet::Differentiate( const SfxItemSet& rSet )
}
else
{
-SfxItemIter aIter( *this );
-const SfxPoolItem* pItem = aIter.GetCurItem();
-do
+SfxWhichIter aIter( *this );
+sal_uInt16 nWhich = aIter.FirstWhich();
+while ( nWhich )
{
-sal_uInt16 nWhich = IsInvalidItem( pItem )
-? GetWhichByPos( aIter.GetCurPos() )
-: pItem->Which();
if( SfxItemState::SET == rSet.GetItemState( nWhich, false ) )
ClearItem( nWhich ); // Delete
-pItem = aIter.NextItem();
-} while (pItem);
-
+nWhich = aIter.NextWhich();
+}
}
}
[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102495 Bug 102495 depends on bug 149329, which changed state. Bug 149329 Summary: After right-click cursor doesn't change back to the typing cursor https://bugs.documentfoundation.org/show_bug.cgi?id=149329 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149329] After right-click cursor doesn't change back to the typing cursor
https://bugs.documentfoundation.org/show_bug.cgi?id=149329 Jan-Marek Glogowski changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149329] After right-click cursor doesn't change back to the typing cursor
https://bugs.documentfoundation.org/show_bug.cgi?id=149329 --- Comment #2 from Commit Notification --- Jan-Marek Glogowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/caf862fc843c89cceae2121f743a3822e09bbd46 tdf#149329 Qt change cursor via QWidget It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149329] After right-click cursor doesn't change back to the typing cursor
https://bugs.documentfoundation.org/show_bug.cgi?id=149329 Commit Notification changed: What|Removed |Added Whiteboard||target:7.4.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/qt5
vcl/qt5/QtFrame.cxx |5 +
1 file changed, 1 insertion(+), 4 deletions(-)
New commits:
commit caf862fc843c89cceae2121f743a3822e09bbd46
Author: Jan-Marek Glogowski
AuthorDate: Fri May 27 23:36:20 2022 +0200
Commit: Jan-Marek Glogowski
CommitDate: Sat May 28 18:41:21 2022 +0200
tdf#149329 Qt change cursor via QWidget
... instead of its QWindow
No idea, why my initial implementation used the QWindow. Neither
do I know, why it's now somehow broken. The code is called, but
the cursor doesn't change. But it seems to work via QWidget, so
just do that. IMHO less QWindow is preferable generally; let Qt
handle more of the low-level stuff.
Change-Id: Id23fba719c9a4d7e760991c51e6021c6f89be345
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135051
Reviewed-by: Michael Weghorn
Reviewed-by: Jan-Marek Glogowski
Tested-by: Jenkins
diff --git a/vcl/qt5/QtFrame.cxx b/vcl/qt5/QtFrame.cxx
index 0933bf33b029..4b94273e1cff 100644
--- a/vcl/qt5/QtFrame.cxx
+++ b/vcl/qt5/QtFrame.cxx
@@ -835,14 +835,11 @@ void QtFrame::ToTop(SalFrameToTop nFlags)
void QtFrame::SetPointer(PointerStyle ePointerStyle)
{
-QWindow* pWindow = m_pQWidget->window()->windowHandle();
-if (!pWindow)
-return;
if (ePointerStyle == m_ePointerStyle)
return;
m_ePointerStyle = ePointerStyle;
-pWindow->setCursor(GetQtData()->getCursor(ePointerStyle));
+m_pQWidget->setCursor(GetQtData()->getCursor(ePointerStyle));
}
void QtFrame::CaptureMouse(bool bMouse)
[Libreoffice-bugs] [Bug 149338] It is sometimes impossible to clear direct formatting with some of the contents pasted from the web
https://bugs.documentfoundation.org/show_bug.cgi?id=149338 Dieter changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||dgp-m...@gmx.de Resolution|--- |NOTABUG --- Comment #3 from Dieter --- I can't confirm with Version: 7.3.4.1 (x64) / LibreOffice Community Build ID: 13668373362b52f6e3ebcaaecb031bd59a3ac66b CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL Bold text is character style "Strong Emphasis". You can easily see in style inspector, that there is no direct formatting. => RESOLVED NOTABUG Feel free to change it back to UNONFIRMED with a short reasoning, if you disagree. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148969] Position properties of image are changed when image is moved
https://bugs.documentfoundation.org/show_bug.cgi?id=148969 Dieter changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=90 | |933 | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 90933] EDITING: Moving an image or object changes positions relative to settings
https://bugs.documentfoundation.org/show_bug.cgi?id=90933 Dieter changed: What|Removed |Added Summary|EDITING Moving an image or |EDITING: Moving an image or |object with key board, |object changes positions |changes positions relative |relative to settings |to settings | See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=14 | |8969| CC||dgp-m...@gmx.de --- Comment #12 from Dieter --- Not related to keyboard. Same result with mouse (bug 148969) and touchpad => I've changed bug summary. -- You are receiving this mail because: You are the assignee for the bug.
