[Libreoffice-bugs] [Bug 108799] [META] HTML export bugs and enhancements

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108799
Bug 108799 depends on bug 126883, which changed state.

Bug 126883 Summary: HTML-Export: Tableexport with background supresses border
https://bugs.documentfoundation.org/show_bug.cgi?id=126883

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 126883] HTML-Export: Tableexport with background supresses border

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126883

Robert Großkopf  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #9 from Robert Großkopf  ---
Have tested again with the attached "writer_table_as_ODT". Could see the border
now with LO 7.3.4.2 on OpenSUSE 15.3 64bit rpm Linux.

I will set this one to WORKSFORME.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149510] LibreOffice windows in gnome 42 can be resized to be extremely small x11

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149510

--- Comment #1 from oxyuyleilkibpxz...@kvhrs.com ---
Created attachment 180662
  --> https://bugs.documentfoundation.org/attachment.cgi?id=180662=edit
Picture of small window size

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sc/source

2022-06-09 Thread Caolán McNamara (via logerrit)
 sc/source/ui/app/inputhdl.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 65738d67321bbe2aedd67edd5a43b3f3ed7bf960
Author: Caolán McNamara 
AuthorDate: Thu Jun 9 12:46:49 2022 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Fri Jun 10 07:22:16 2022 +0200

Resolves: tdf#142368 drop popover on ControlLoseFocus

which is what appears when the Control derived inputbar loses focus
while the main window losing focus gives WindowLoseFocus

Change-Id: Iae9a2874c3dd513a1a092a18846858f819542370
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135534
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/sc/source/ui/app/inputhdl.cxx b/sc/source/ui/app/inputhdl.cxx
index 30f18a075c7c..042fed788ff8 100644
--- a/sc/source/ui/app/inputhdl.cxx
+++ b/sc/source/ui/app/inputhdl.cxx
@@ -1079,14 +1079,14 @@ void ScInputHandler::GetFormulaData()
 IMPL_LINK( ScInputHandler, ShowHideTipVisibleParentListener, VclWindowEvent&, 
rEvent, void )
 {
 if (rEvent.GetId() == VclEventId::ObjectDying || rEvent.GetId() == 
VclEventId::WindowHide
-|| rEvent.GetId() == VclEventId::WindowLoseFocus)
+|| rEvent.GetId() == VclEventId::WindowLoseFocus || rEvent.GetId() == 
VclEventId::ControlLoseFocus)
 HideTip();
 }
 
 IMPL_LINK( ScInputHandler, ShowHideTipVisibleSecParentListener, 
VclWindowEvent&, rEvent, void )
 {
 if (rEvent.GetId() == VclEventId::ObjectDying || rEvent.GetId() == 
VclEventId::WindowHide
-|| rEvent.GetId() == VclEventId::WindowLoseFocus)
+|| rEvent.GetId() == VclEventId::WindowLoseFocus || rEvent.GetId() == 
VclEventId::ControlLoseFocus)
 HideTipBelow();
 }
 


[Libreoffice-bugs] [Bug 149510] New: LibreOffice windows in gnome 42 can be resized to be extremely small x11

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149510

Bug ID: 149510
   Summary: LibreOffice windows in gnome 42 can be resized to be
extremely small x11
   Product: LibreOffice
   Version: unspecified
  Hardware: x86 (IA32)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: trivial
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: oxyuyleilkibpxz...@kvhrs.com

Description:
It appears that the minimum window size in libreoffice hasn't been set
correctly allowing the window to be absurdly small. 

Steps to Reproduce:
1.Open a libreoffice program
2.resize window reducing it's height and width

Actual Results:
Window becomes very small making it hard to select and size back to normal

Expected Results:
Window resized to sensible minimum size and then prevents user from resizing
any smaller.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Sometimes when moving the window from full screen using the title bar, this
problem occurs instead of the usual behavior of resizing to a usable size.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/qa

2022-06-09 Thread Andrea Gelmini (via logerrit)
 sw/qa/uitest/writer_tests7/tdf137802.py |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit dfa2365dd8060cb5611a5c43830c3a8bc3af79a6
Author: Andrea Gelmini 
AuthorDate: Thu Jun 9 08:11:55 2022 +0200
Commit: Julien Nabet 
CommitDate: Fri Jun 10 07:06:08 2022 +0200

Fix typo

Change-Id: Id11f0afe9aa32373837289b8bc7fa1b36112a28a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135521
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/sw/qa/uitest/writer_tests7/tdf137802.py 
b/sw/qa/uitest/writer_tests7/tdf137802.py
index 2c378664bcfd..8616e52553a5 100644
--- a/sw/qa/uitest/writer_tests7/tdf137802.py
+++ b/sw/qa/uitest/writer_tests7/tdf137802.py
@@ -51,7 +51,7 @@ class tdf137802(UITestCase):
 
 # Delete the second paragraph. Shape 2 is anchored to this 
paragraph
 # so it should be deleted
-# tdf#137587 fly is no longer deleted by backspace so explictly 
select
+# tdf#137587 fly is no longer deleted by backspace so explicitly 
select
 xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE": 
"SHIFT+LEFT"}))
 xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE": 
"BACKSPACE"}))
 


[Libreoffice-bugs] [Bug 149294] [UI] Function "Select to End of Word" (.uno:WordRightSel) must be renamed, because it also selects spaces and tabs at the right side of word

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149294

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148208] Can't insert image in LibreOffice Calc or not anchored correctly

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148208

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145646] UI While selecting from the dropdown of data validation using keyboard, different one gets entered on pressing return.

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145646

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149323] Contents cannot display or blinking when clicking on PPSX file by using Impress

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149323

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149320] Configure global date format independent of locale setting

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149320

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149319] In Draw and Writer, F1 (Help) on "Optimize" in Table bar does not have a linked help page

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149319

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149318] (F1) Help for Format > Table (in Draw) has no help page linked to it, as well as "Minimal Row Height" and "Minimal Column Width" in its submenu

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149318

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149313] FILEOPEN DOCX Consecutive page break and section break result in extra page

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149313

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149307] Increase/Decrease indent should apply to paragraph when nothing is selected

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149307

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149306] Problem with decimal number selection using double click

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149306

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149305] Increase/Decrease indent buttons should be part of the Text Formatting toolbar

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149305

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149302] Error running VclTextTest::testSimpleText

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149302

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149301] HELP for Navigator: Change "Content View" to "Content Management View"

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149301

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147822] LO Calc with RadioButton Crash in: ScUnoListenerCalls::ExecuteAndClear()

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147822

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147822] LO Calc with RadioButton Crash in: ScUnoListenerCalls::ExecuteAndClear()

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147822

--- Comment #21 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138319] The whole sidebar is repainted on file reload (it's or painting more or slower; but obviously flashes)

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138319

--- Comment #6 from QA Administrators  ---
Dear Telesto,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133721] VIEWING: Arrows for cell resizing in table not showing if picture or shape is in background

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133721

--- Comment #2 from QA Administrators  ---
Dear Markus,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 132222] Extra page added when inserting an image - OK after reopen

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=13

--- Comment #11 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147565] Browsing comments in the navigation pane also browses hidden solved comments

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147565

--- Comment #11 from bevis  ---
Thanks for your post, it's very helpful I hope in the future you will provide
more information. I will visit and support the article for you
https://drift-hunters.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148208] Can't insert image in LibreOffice Calc or not anchored correctly

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148208

--- Comment #2 from Suthagar  ---
Version: 7.4.0.0.alpha1+ / LibreOffice Community
Build ID: f2d2334b032780d97f7a95aacb8283008e91c529
CPU threads: 2; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-IN (en_IN); UI: en-US
Calc: threaded

Os   : Linux mint 20.3
 : 5.4.0-117-generic

Steps to Reproduce:

1. Open Libreoffice calc
2. drag image to insert or insert--> image 
3. Move the image by cursor
4. move the image by position x and position Y

Actual Result:

Inserted image moved to exact position.

Expected Result:
Inserted image move by position x and position y

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141886] Data saving error in latest updates 7.1.2 & 7.1.1 & 7.1.8.1

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141886

--- Comment #5 from gjr...@xtra.co.nz ---
Still not fixed in 7.2.7.2. Apparently saving one's data is not important!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149453] Copy-paste with changes showing deletions

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149453

--- Comment #3 from ThomasU  ---
Thank you, Miklos, for offering to help. I'm a beginner.
I'm not sure there's an API to access SwRedlineTable.
I see void SwRedlineTable::dumpAsXml(xmlTextWriterPtr pWriter) const
at line 857 of
https://docs.libreoffice.org/sw/html/docredln_8cxx_source.html#l00417

Despite some attempts, I don't know how to go beyond that.
If dumpAsXml is callable from a macro, then a short example could maybe get me
started.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149509] CRASH: inserting page break in content control

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149509

Xisco Faulí  changed:

   What|Removed |Added

 CC||vmik...@collabora.com,
   ||xiscofa...@libreoffice.org
   Keywords||bibisected, bisected,
   ||regression
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from Xisco Faulí  ---
author  Miklos Vajna 2022-04-20 08:29:35 +0200
committer   Miklos Vajna 2022-04-20 11:47:40
+0200
commit  f2ab1375b266d7465ef31d06ec8f949c6b91d853 (patch)
treecbc45f6929f5df75530310d4dbd6c2f10e25cd88
parent  d5fb8d502e77c1dfc77b2c7bdda4bb1540f3ddaf (diff)
sw content controls: add initial DOCX import

Bisected with: bibisect-linux64-7.4

Adding Cc: to Miklos Vajna

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149509] New: CRASH: inserting page break in content control

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149509

Bug ID: 149509
   Summary: CRASH: inserting page break in content control
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

Created attachment 180661
  --> https://bugs.documentfoundation.org/attachment.cgi?id=180661=edit
sample file

Steps to reproduce:
1. Open attached document
2. Insert page break

-> Crash

Reproduced in

Version: 7.4.0.0.alpha1+ / LibreOffice Community
Build ID: d4123356c61db269651e950a0a2cc93e6d801c90
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: x11
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149493] Should be able to select visible toolbars in Toolbar context menu

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149493

Eyal Rozenberg  changed:

   What|Removed |Added

 Resolution|DUPLICATE   |---
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=78
   ||525
 Status|RESOLVED|UNCONFIRMED

--- Comment #2 from Eyal Rozenberg  ---
(In reply to Timur from comment #1)
> I close as a duplicate of existing close but better request.

If it's "better", it's probably not a dupe.

More specifically - that request regards the empty space outside of toolbars,
this one regards toolbars themselves. The requests are related, but are in fact
complementary.

It's often the case that you have no extra empty space, or you have a bit of
it, but it's "far away" to navigate to when you're looking for stuff on the
existing toolbars. It would be convenient to have the toolbar choice to be more
immediately available.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 78525] Right-click access in the empty toolbar area to hide/show toolbars and change icon style and size

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=78525

Eyal Rozenberg  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||9493

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149508] poor performance scrolling and storing

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149508

Rafael Lima  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #2 from Rafael Lima  ---
Hi. I could not open attachment 180658 (the ODT sample file). When I open it,
Writer shows the file for a second and right after it crashes. The crash
happens in LO 7.3 and 7.4.

Can you please test again if your sample file works?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - vcl/jsdialog

2022-06-09 Thread Szymon Kłos (via logerrit)
 vcl/jsdialog/jsdialogbuilder.cxx |6 ++
 1 file changed, 6 insertions(+)

New commits:
commit cea6679e11b8c18e4641f317831859c159cb8455
Author: Szymon Kłos 
AuthorDate: Wed Jun 8 14:56:46 2022 +0200
Commit: Szymon Kłos 
CommitDate: Thu Jun 9 23:28:34 2022 +0200

jsdialog: be sure we send close popup message when destroyed

use different m_sTypeOfJSON for popups so we can later
detect popup closing

Change-Id: Id0086815317011b142b49f4e1421b76e1e663358
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135497
Reviewed-by: Szymon Kłos 
Tested-by: Jenkins CollaboraOffice 

diff --git a/vcl/jsdialog/jsdialogbuilder.cxx b/vcl/jsdialog/jsdialogbuilder.cxx
index eb2fab02c0fc..11edcb26d94d 100644
--- a/vcl/jsdialog/jsdialogbuilder.cxx
+++ b/vcl/jsdialog/jsdialogbuilder.cxx
@@ -515,7 +515,10 @@ JSInstanceBuilder::JSInstanceBuilder(weld::Widget* 
pParent, const OUString& rUIR
 {
 // when it is a popup we initialize sender in weld_popover
 if (bPopup)
+{
+m_sTypeOfJSON = "popup";
 return;
+}
 
 vcl::Window* pRoot = m_xBuilder->get_widget_root();
 
@@ -662,6 +665,9 @@ JSInstanceBuilder::CreateFormulabarBuilder(vcl::Window* 
pParent, const OUString&
 
 JSInstanceBuilder::~JSInstanceBuilder()
 {
+if (m_sTypeOfJSON == "popup")
+sendClosePopup(m_nWindowId);
+
 if (m_aWindowToRelease)
 {
 m_aWindowToRelease->ReleaseLOKNotifier();


[Libreoffice-bugs] [Bug 149505] [CRASH] Writer hangs opening a DOCX file

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149505

Dieter  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de

--- Comment #1 from Dieter  ---
Can't confirm with

Version: 7.3.4.1 (x64) / LibreOffice Community
Build ID: 13668373362b52f6e3ebcaaecb031bd59a3ac66b
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148072] Sheet-local named expression destroyed with Cut-Paste-Undo

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148072

Eike Rathke  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |er...@redhat.com
   |desktop.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148234] symbol bar in Calc while editing

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148234

--- Comment #9 from ThP  ---
It's Groundhog Day. Again.

Version: 7.3.4.2 (x64) / LibreOffice Community
Build ID: 728fec16bd5f605073805c3c9e7c4212a0120dc5
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: default; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147822] LO Calc with RadioButton Crash in: ScUnoListenerCalls::ExecuteAndClear()

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147822

robert_hartm...@gmx.net changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #20 from robert_hartm...@gmx.net ---
Changed status to "NEEDINFO" because I need an answer from 
Xisco Faulí to my question to Xisco Faulí , see:
https://bugs.documentfoundation.org/show_bug.cgi?id=147822#c19

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149502] CRASH: deleting sheet

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149502

Julien Nabet  changed:

   What|Removed |Added

   Keywords||haveBacktrace

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149502] CRASH: deleting sheet

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149502

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #2 from Julien Nabet  ---
Created attachment 180660
  --> https://bugs.documentfoundation.org/attachment.cgi?id=180660=edit
bt with debug symbols

On pc Debian x86-64 with master sources updated today, I could reproduce this.

I also noticed this log repeated several times:
warn:sc.ui:1576435:1576435:sc/source/ui/unoobj/chart2uno.cxx:2807: range list
and range index list have different sizes after the reference update.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148978] Business Cards in Writer don't show database

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148978

Julien Nabet  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr
   |desktop.org |
 Status|NEW |ASSIGNED

--- Comment #8 from Julien Nabet  ---
I gave a try with https://gerrit.libreoffice.org/c/core/+/135566

I quote the description of the patch (in addition to make database part work):
'
+ Remove "medium" tab since its goal is exactly what "label" tab does.
So now "label" tab is common for "File - New - Business Cards" and "File - New
- Labels
'

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149508] poor performance scrolling and storing

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149508

Dr. Matthias Weisser  changed:

   What|Removed |Added

   Hardware|All |x86-64 (AMD64)
 OS|All |Windows (All)
Version|7.4.0.0 alpha0+ Master  |5.4.7.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149508] poor performance scrolling and storing

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149508

Dr. Matthias Weisser  changed:

   What|Removed |Added

 CC||matthias.weis...@gmx.de

--- Comment #1 from Dr. Matthias Weisser  ---
Created attachment 180659
  --> https://bugs.documentfoundation.org/attachment.cgi?id=180659=edit
test picture for test file to be put in a folder Bilder

this png picture in folder Bilder to be used with the 110kB odt file for
testing of scrolling and saving. The picture is 4MB and the odt is 110kB.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149508] New: poor performance scrolling and storing

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149508

Bug ID: 149508
   Summary: poor performance scrolling and storing
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: matthias.weis...@gmx.de

Created attachment 180658
  --> https://bugs.documentfoundation.org/attachment.cgi?id=180658=edit
test file for scrolling and saving

I have been using LO for writing 15 books about medicine. 
Using LO 5.4.7 storing an odt file of just 110kB (see ) takes several minutes.
All pictures are external and therefore need not to be saved.

With a newly installed LO 7.2.7 the file did not open. "Durch einen Fehler ist
LO abgestürzt". I tried repair install. Same problem. "Libre Office
funktioniert nicht mehr".

Using LO 7.4.0.0 the file opened. But scrolling the 1010 page document takes
5min to page 216. Saving the 110kB file takes 15min. Trying to close LO
reported "keine Rückmeldung". LO is 811MB huge. System is Win 7pro 64bit Intel
Duo 2.53GHz 4GB RAM.

Which alternative (Hardware/Software) would you recommend to use now?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149308] CTRL + SHIFT + right-arrow should not select whitespace after word

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149308

--- Comment #5 from LeroyG  ---
(In reply to Buovjaga from comment #2)
> In Firefox, it only selects the word.

Not in Windows 10.

(In reply to geoff from comment #0)
> Expected Results:
> Selection stops on end of the word.

And what is selected with the next stroke of Ctrl+Shift+Right_arrow? The
spaces/tabs between the actual word and the next?
Or only the first shortcut stroke do not select spaces/tabs?

I think that there must be consistency between the selection of words and
paragraphs.
Just tested with Ctrl+Shift+Up/Down_arrow, and this selects to the next
leftmost/rightmost position of paragraph (not to the next beginning of
paragraph; the behavior has changed from the last time I used it; is not what I
expected; but consistency is important).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - sc/source

2022-06-09 Thread Dennis Francis (via logerrit)
 sc/source/ui/view/gridwin4.cxx |   17 ++---
 1 file changed, 10 insertions(+), 7 deletions(-)

New commits:
commit c17c410706eab6e4d449b2a20a51bf3702329341
Author: Dennis Francis 
AuthorDate: Fri May 6 10:56:38 2022 +0530
Commit: Andras Timar 
CommitDate: Thu Jun 9 21:32:54 2022 +0200

lok: do not recreate lok-drawview for every tile paint

This lets the ScLOKDrawView live long enough for non-tile painting
related invocation of its methods and hopefully those of its member objects.

This is a blind fix for the following crash:

/opt/collaboraoffice/program/../program/libsclo.so
(anonymous 
namespace)::ScLOKProxyObjectContact::calculateGridOffsetForViewOjectContact(basegfx::B2DVector&,
 sdr::contact::ViewObjectContact const&) const
...
/opt/collaboraoffice/program/libmergedlo.so

SdrTextObj::NbcSetOutlinerParaObjectForText(std::unique_ptr >, SdrText*)

/home/collabora/jenkins/workspace/build_linux_co-2021_online_snapshot/svx/source/svdraw/svdotext.cxx:1379
/opt/collaboraoffice/program/libmergedlo.so
sdr::properties::TextProperties::ItemSetChanged(SfxItemSet const&)

/opt/rh/devtoolset-10/root/usr/include/c++/10/bits/unique_ptr.h:360
/opt/collaboraoffice/program/libmergedlo.so
sdr::properties::RectangleProperties::ItemSetChanged(SfxItemSet 
const&)

/home/collabora/jenkins/workspace/build_linux_co-2021_online_snapshot/svx/source/sdr/properties/rectangleproperties.cxx:54
/opt/collaboraoffice/program/libmergedlo.so
sdr::properties::DefaultProperties::SetObjectItem(SfxPoolItem 
const&)

/home/collabora/jenkins/workspace/build_linux_co-2021_online_snapshot/svx/source/sdr/properties/defaultproperties.cxx:120
/opt/collaboraoffice/program/libscfiltlo.so
XclTxo::XclTxo(XclExpRoot const&, EditTextObject const&, SdrObject*)

/home/collabora/jenkins/workspace/build_linux_co-2021_online_snapshot/include/svl/cenumitm.hxx:26
/opt/collaboraoffice/program/libscfiltlo.so
XclObjComment::XclObjComment(XclExpObjectManager&, tools::Rectangle 
const&, EditTextObject const&, SdrCaptionObj*, bool, ScAddress const&, 
tools::Rectangle const&, tools::Rectangle const&)

/opt/rh/devtoolset-10/root/usr/include/c++/10/bits/unique_ptr.h:179
/opt/collaboraoffice/program/libscfiltlo.so
XclExpNote::XclExpNote(XclExpRoot const&, ScAddress const&, 
ScPostIt const*, rtl::OUString const&)
/opt/rh/devtoolset-10/root/usr/include/c++/10/tuple:137
/opt/collaboraoffice/program/libscfiltlo.so
ExcTable::FillAsTableXml()

/home/collabora/jenkins/workspace/build_linux_co-2021_online_snapshot/include/rtl/ref.hxx:65
/opt/collaboraoffice/program/libscfiltlo.so
ExcDocument::ReadDoc()

/home/collabora/jenkins/workspace/build_linux_co-2021_online_snapshot/sc/source/filter/excel/excdoc.cxx:747
/opt/collaboraoffice/program/libscfiltlo.so
XclExpXmlStream::exportDocument()

/home/collabora/jenkins/workspace/build_linux_co-2021_online_snapshot/sc/source/filter/excel/xestream.cxx:1107
/opt/collaboraoffice/program/libooxlo.so

Change-Id: I248395cca1e2da37208fc449aca731175a5aa368
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133914
Tested-by: Andras Timar 
Reviewed-by: Andras Timar 

diff --git a/sc/source/ui/view/gridwin4.cxx b/sc/source/ui/view/gridwin4.cxx
index 2580b25fafd2..0c697bf085ef 100644
--- a/sc/source/ui/view/gridwin4.cxx
+++ b/sc/source/ui/view/gridwin4.cxx
@@ -1571,13 +1571,16 @@ void ScGridWindow::PaintTile( VirtualDevice& rDevice,
 {
 bool bPrintTwipsMsgs = comphelper::LibreOfficeKit::isCompatFlagSet(
 comphelper::LibreOfficeKit::Compat::scPrintTwipsMsgs);
-mpLOKDrawView.reset(bPrintTwipsMsgs ?
-new ScLOKDrawView(
-,
-mrViewData) :
-new FmFormView(
-*pModel,
-));
+if (!mpLOKDrawView)
+{
+mpLOKDrawView.reset(bPrintTwipsMsgs ?
+new ScLOKDrawView(
+,
+mrViewData) :
+new FmFormView(
+*pModel,
+));
+}
 
 mpLOKDrawView->SetNegativeX(bLayoutRTL);
 mpLOKDrawView->ShowSdrPage(mpLOKDrawView->GetModel()->GetPage(nTab));


[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - editeng/source

2022-06-09 Thread Luboš Luňák (via logerrit)
 editeng/source/editeng/impedit.cxx |6 +-
 1 file changed, 1 insertion(+), 5 deletions(-)

New commits:
commit f88b5a5f5c18d23a2b479eb9556026e19fb1fe42
Author: Luboš Luňák 
AuthorDate: Thu Jun 9 15:08:41 2022 +0200
Commit: Andras Timar 
CommitDate: Thu Jun 9 21:28:50 2022 +0200

remove incorrect #ifdef DBG_UTIL around normal code (tdf#149476)

This code sets sufficient size for the virtual device that saves
the content, so it's not some optional debug code. Without this
selecting text in Calc formula bar and dragging it around leaves
artifacts, because the saved content is not large enough to restore
the original widget content. This dates back to
d51fe1189dcbe0fe06805c8d99687c125cd254eb, which supposedly made
the code warning-free (and also correct-free).

Change-Id: I52dab8c8d3a083fff9da8aed27facdf21076622e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/13
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 
(cherry picked from commit dabf52b81621f1cbff508dfb7ae2e92597e521c3)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135537
Tested-by: Andras Timar 
Reviewed-by: Andras Timar 

diff --git a/editeng/source/editeng/impedit.cxx 
b/editeng/source/editeng/impedit.cxx
index bb1a1ae00d47..c9131cd521d0 100644
--- a/editeng/source/editeng/impedit.cxx
+++ b/editeng/source/editeng/impedit.cxx
@@ -2175,9 +2175,6 @@ void ImpEditView::ShowDDCursor( const tools::Rectangle& 
rRect )
 aSaveRect.AdjustRight(1 );
 aSaveRect.AdjustBottom(1 );
 
-#ifdef DBG_UTIL
-Size aNewSzPx( aSaveRect.GetSize() );
-#endif
 if ( !pDragAndDropInfo->pBackground )
 {
 pDragAndDropInfo->pBackground = VclPtr::Create(rOutDev);
@@ -2187,14 +2184,13 @@ void ImpEditView::ShowDDCursor( const tools::Rectangle& 
rRect )
 
 }
 
-#ifdef DBG_UTIL
+Size aNewSzPx( aSaveRect.GetSize() );
 Size aCurSzPx( pDragAndDropInfo->pBackground->GetOutputSizePixel() );
 if ( ( aCurSzPx.Width() < aNewSzPx.Width() ) ||( aCurSzPx.Height() < 
aNewSzPx.Height() ) )
 {
 bool bDone = pDragAndDropInfo->pBackground->SetOutputSizePixel( 
aNewSzPx );
 DBG_ASSERT( bDone, "Virtual Device broken?" );
 }
-#endif
 
 aSaveRect = rOutDev.PixelToLogic( aSaveRect );
 


[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - sw/source

2022-06-09 Thread Luboš Luňák (via logerrit)
 sw/source/core/view/viewimp.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit cccf3894bf8b7d47cec983a62a1f394724e82b3b
Author: Luboš Luňák 
AuthorDate: Tue Jun 7 12:21:28 2022 +0200
Commit: Andras Timar 
CommitDate: Thu Jun 9 21:17:35 2022 +0200

fix SwViewShellImp::AddPaintRect() rectangle compression (tdf#148255)

Both the checks test whether a follow-up rectangle can be merged
with the previous one by merging it at the bottom or the right of it,
so the previous one should be always the top-left and the follow-up
one should be the bottom-right.

Change-Id: Ie5809595ec9bf28bd169fc503a6b391c6188d0b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135468
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 
(cherry picked from commit 0372da98bf9b2af82afc2e4ff919068bdcaae7db)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135385
Tested-by: Andras Timar 
Reviewed-by: Andras Timar 

diff --git a/sw/source/core/view/viewimp.cxx b/sw/source/core/view/viewimp.cxx
index d86c06e23593..1436cf152ba3 100644
--- a/sw/source/core/view/viewimp.cxx
+++ b/sw/source/core/view/viewimp.cxx
@@ -149,7 +149,7 @@ bool SwViewShellImp::AddPaintRect( const SwRect  )
 if(last2.Top() == last.Top() && last2.Height() == 
last.Height()
 && last2.Right() + 1 >= last.Left() && last2.Right() 
<= last2.Right())
 {
-last2 = SwRect( last.TopLeft(), rRect.BottomRight());
+last2 = SwRect( last2.TopLeft(), last.BottomRight());
 m_pRegion->pop_back();
 return true;
 }


[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - desktop/inc desktop/source

2022-06-09 Thread Luboš Luňák (via logerrit)
 desktop/inc/lib/init.hxx|2 +-
 desktop/source/lib/init.cxx |8 
 2 files changed, 5 insertions(+), 5 deletions(-)

New commits:
commit e9dc2d59b0a362af512f4523ec7b120640ea7cf1
Author: Luboš Luňák 
AuthorDate: Wed Jun 8 15:23:22 2022 +0200
Commit: Andras Timar 
CommitDate: Thu Jun 9 21:16:23 2022 +0200

use recursive mutex for LOK queue

Callbacks may be invoked while calling getLOKPayload(), which
would try to lock the mutex again. I actually originally expected
this possibility, as the comment and moving the data to
temporaries in CallbackFlushHandler::enqueueUpdatedTypes()
shows, I just didn't realize the used mutex wasn't recursive
and so would deadlock.

Change-Id: I2b5c4b6b4c1a3933a32ae4641830877e085f2b6c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135499
Tested-by: Jenkins
Reviewed-by: Michael Meeks 
(cherry picked from commit 118bafcfd1ce4a26ec9df912197ebd466d1bd497)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135388
Tested-by: Andras Timar 
Reviewed-by: Andras Timar 

diff --git a/desktop/inc/lib/init.hxx b/desktop/inc/lib/init.hxx
index c19e4c5b0ac1..8b26e117c1fb 100644
--- a/desktop/inc/lib/init.hxx
+++ b/desktop/inc/lib/init.hxx
@@ -219,7 +219,7 @@ namespace desktop {
 LibreOfficeKitCallback m_pCallback;
 void *m_pData;
 int m_nDisableCallbacks;
-std::mutex m_mutex;
+std::recursive_mutex m_mutex;
 class TimeoutIdle : public Timer
 {
 public:
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index e99dace9c24e..9d88234bdb21 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -1464,7 +1464,7 @@ void 
CallbackFlushHandler::libreOfficeKitViewInvalidateTilesCallback(const tools
 void CallbackFlushHandler::libreOfficeKitViewUpdatedCallback(int nType)
 {
 assert(isUpdatedType( nType ));
-std::unique_lock lock(m_mutex);
+std::unique_lock lock(m_mutex);
 SAL_INFO("lok", "Updated: [" << nType << "]");
 setUpdatedType(nType, true);
 }
@@ -1472,7 +1472,7 @@ void 
CallbackFlushHandler::libreOfficeKitViewUpdatedCallback(int nType)
 void CallbackFlushHandler::libreOfficeKitViewUpdatedCallbackPerViewId(int 
nType, int nViewId, int nSourceViewId)
 {
 assert(isUpdatedTypePerViewId( nType ));
-std::unique_lock lock(m_mutex);
+std::unique_lock lock(m_mutex);
 SAL_INFO("lok", "Updated: [" << nType << "]");
 setUpdatedTypePerViewId(nType, nViewId, nSourceViewId, true);
 }
@@ -1543,7 +1543,7 @@ void CallbackFlushHandler::queue(const int type, 
CallbackData& aCallbackData)
 return;
 }
 
-std::unique_lock lock(m_mutex);
+std::unique_lock lock(m_mutex);
 
 // Update types should be received via the updated callbacks for 
performance,
 // getting them as normal callbacks is technically not wrong, but probably 
should be avoided.
@@ -2138,7 +2138,7 @@ void CallbackFlushHandler::Invoke()
 viewShell->flushPendingLOKInvalidateTiles();
 }
 
-std::scoped_lock lock(m_mutex);
+std::unique_lock lock(m_mutex);
 
 // Append messages for updated types, fetch them only now.
 enqueueUpdatedTypes();


[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - vcl/jsdialog

2022-06-09 Thread Szymon Kłos (via logerrit)
 vcl/jsdialog/executor.cxx |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit b6b7b3a5a46790baf2266aaeb10976753dfe0fce
Author: Szymon Kłos 
AuthorDate: Thu Jun 9 17:41:15 2022 +0200
Commit: Andras Timar 
CommitDate: Thu Jun 9 21:12:48 2022 +0200

jsdialog: toggle toolbox buttons correctly

Change-Id: Ic02f9ceab29257ebc4cb6261aae10c4f1a7ef176
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135562
Tested-by: Andras Timar 
Reviewed-by: Andras Timar 

diff --git a/vcl/jsdialog/executor.cxx b/vcl/jsdialog/executor.cxx
index 8662b246e5f9..8d3dd2d876d1 100644
--- a/vcl/jsdialog/executor.cxx
+++ b/vcl/jsdialog/executor.cxx
@@ -243,8 +243,9 @@ bool ExecuteAction(const std::string& nWindowId, const 
OString& rWidget, StringM
 }
 else if (sAction == "togglemenu")
 {
-pToolbar->set_menu_item_active(
-OUStringToOString(rData["data"], 
RTL_TEXTENCODING_ASCII_US), true);
+OString sId = OUStringToOString(rData["data"], 
RTL_TEXTENCODING_ASCII_US);
+bool bIsActive = pToolbar->get_menu_item_active(sId);
+pToolbar->set_menu_item_active(sId, !bIsActive);
 return true;
 }
 }


[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - vcl/jsdialog

2022-06-09 Thread Szymon Kłos (via logerrit)
 vcl/jsdialog/jsdialogbuilder.cxx |6 ++
 1 file changed, 6 insertions(+)

New commits:
commit 7569ee7e7009bb2a4193090040a7f1a83e1090b0
Author: Szymon Kłos 
AuthorDate: Wed Jun 8 14:56:46 2022 +0200
Commit: Andras Timar 
CommitDate: Thu Jun 9 21:11:54 2022 +0200

jsdialog: be sure we send close popup message when destroyed

use different m_sTypeOfJSON for popups so we can later
detect popup closing

Change-Id: Id0086815317011b142b49f4e1421b76e1e663358
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135498
Tested-by: Andras Timar 
Reviewed-by: Andras Timar 

diff --git a/vcl/jsdialog/jsdialogbuilder.cxx b/vcl/jsdialog/jsdialogbuilder.cxx
index ff543ca60be8..ac66f669c239 100644
--- a/vcl/jsdialog/jsdialogbuilder.cxx
+++ b/vcl/jsdialog/jsdialogbuilder.cxx
@@ -517,7 +517,10 @@ JSInstanceBuilder::JSInstanceBuilder(weld::Widget* 
pParent, const OUString& rUIR
 {
 // when it is a popup we initialize sender in weld_popover
 if (bPopup)
+{
+m_sTypeOfJSON = "popup";
 return;
+}
 
 vcl::Window* pRoot = m_xBuilder->get_widget_root();
 
@@ -666,6 +669,9 @@ JSInstanceBuilder* 
JSInstanceBuilder::CreatePopupBuilder(weld::Widget* pParent,
 
 JSInstanceBuilder::~JSInstanceBuilder()
 {
+if (m_sTypeOfJSON == "popup")
+sendClosePopup(m_nWindowId);
+
 if (m_aWindowToRelease)
 {
 m_aWindowToRelease->ReleaseLOKNotifier();


[Libreoffice-bugs] [Bug 108409] Copy and paste of picture doesn't paste to the same place but a bit off (ODT in Comment 6)

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108409

--- Comment #12 from Dr. Matthias Weisser  ---
Unfortunately in newer versions of LO I have still seen this. For example I
made a test file with only 110kB odt and one external picture file in folder
Bilder. When I copy this picture and try pasting it over others this sometimes
fails. It can be seen that sometimes the space between pictures gets lost. And
also sometimes the picture even goes unwanted into "Kopfzeile" where it clearly
does not belong to.

Its a real pity that such problems occurs.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - desktop/source sfx2/source

2022-06-09 Thread Pranam Lashkari (via logerrit)
 desktop/source/lib/init.cxx  |4 +++-
 sfx2/source/control/unoctitm.cxx |4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

New commits:
commit e5a106f8b8de9936fce64d9056a81154c879527e
Author: Pranam Lashkari 
AuthorDate: Mon Jun 6 19:30:35 2022 +0530
Commit: Andras Timar 
CommitDate: Thu Jun 9 20:48:09 2022 +0200

LOK: send state of Protect, UnsetCellsReadOnly

Signed-off-by: Pranam Lashkari 
Change-Id: I92675ed0033088233fb442138b39a3c8d663c614
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135454
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Gökay ŞATIR 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135500
Tested-by: Andras Timar 
Reviewed-by: Andras Timar 

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 35bee204a24e..e99dace9c24e 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -3203,7 +3203,9 @@ static void doc_iniUnoCommands ()
 OUString(".uno:RunMacro"),
 OUString(".uno:SpacePara1"),
 OUString(".uno:SpacePara15"),
-OUString(".uno:SpacePara2")
+OUString(".uno:SpacePara2"),
+OUString(".uno:Protect"),
+OUString(".uno:UnsetCellsReadOnly")
 };
 
 util::URL aCommandURL;
diff --git a/sfx2/source/control/unoctitm.cxx b/sfx2/source/control/unoctitm.cxx
index 025dace91506..aeffcc9ab2b4 100644
--- a/sfx2/source/control/unoctitm.cxx
+++ b/sfx2/source/control/unoctitm.cxx
@@ -1220,7 +1220,9 @@ static void InterceptLOKStateChangeEvent(sal_uInt16 nSID, 
SfxViewFrame* pViewFra
  aEvent.FeatureURL.Path == "DecrementIndent" ||
  aEvent.FeatureURL.Path == "EditHeaderAndFooter" ||
  aEvent.FeatureURL.Path == "NumberFormatDecDecimals" ||
- aEvent.FeatureURL.Path == "NumberFormatIncDecimals")
+ aEvent.FeatureURL.Path == "NumberFormatIncDecimals" ||
+ aEvent.FeatureURL.Path == "Protect" ||
+ aEvent.FeatureURL.Path == "UnsetCellsReadOnly")
 {
 aBuffer.append(aEvent.IsEnabled ? std::u16string_view(u"enabled") : 
std::u16string_view(u"disabled"));
 }


[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - config_host.mk.in configure.ac instsetoo_native/CustomTarget_install.mk solenv/bin

2022-06-09 Thread Thorsten Behrens (via logerrit)
 config_host.mk.in|1 
 configure.ac |4 +
 instsetoo_native/CustomTarget_install.mk |   83 ---
 solenv/bin/call_installer.sh |   58 +
 4 files changed, 96 insertions(+), 50 deletions(-)

New commits:
commit d78aba37168399b92418b4f3b7571efa4e042211
Author: Thorsten Behrens 
AuthorDate: Fri Apr 29 12:46:58 2022 +0200
Commit: Andras Timar 
CommitDate: Thu Jun 9 20:45:56 2022 +0200

Get make_installer calls to run in parallel

If available, use GNU parallel to run N make_installer.pl scripts in
parallel, to scale packaging LibreOffice up with the rest of gbuild.

* fallback if no GNU parallel found - run make_installer sequentially
  as before
* push most of the make_installer.pl input param tweaks from gbuild
  down into a shared call_installer.sh script
* call gnu parallel with generated number of
  "templ:lang:prodname:ext:pkgfmt:strip-flag" tuples, one for each
  package to build (empty templ for non-windows, to save on cmd line
  length)
* such that we can run all those in parallel (taking into account
  the build's PARALLELISM parameter)
* there's still the main package build running epm sequentially for
  umpteen sub-packages from within _one_ make_installer.pl instance, but
  that's much harder to parallelize from inside Perl (so we punt on
  that here)

Change-Id: Ie7d3084ed60d003d587c5e64dc9fb1809b23e409
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133957
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135343
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Andras Timar 

diff --git a/config_host.mk.in b/config_host.mk.in
index d00f868e2757..96723061447c 100644
--- a/config_host.mk.in
+++ b/config_host.mk.in
@@ -233,6 +233,7 @@ export GIO_LIBS=$(gb_SPACE)@GIO_LIBS@
 export GIT_REFERENCE_SRC=@GIT_REFERENCE_SRC@
 export GIT_LINK_SRC=@GIT_LINK_SRC@
 export GIT_NEEDED_SUBMODULES=@GIT_NEEDED_SUBMODULES@
+export GNUPARALLEL=@GNUPARALLEL@
 export EPOXY_CFLAGS=$(gb_SPACE)@EPOXY_CFLAGS@
 export EPOXY_LIBS=$(gb_SPACE)@EPOXY_LIBS@
 export GLM_CFLAGS=$(gb_SPACE)@GLM_CFLAGS@
diff --git a/configure.ac b/configure.ac
index 95585a8293c9..d23731af2f18 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2824,6 +2824,10 @@ if test -z "$COMPRESSIONTOOL"; then
 fi
 AC_SUBST(COMPRESSIONTOOL)
 
+# use GNU parallel for packaging, if available
+AC_PATH_PROG(GNUPARALLEL, parallel)
+AC_SUBST(GNUPARALLEL)
+
 AC_MSG_CHECKING([for GNU or BSD tar])
 for a in $GNUTAR gtar gnutar bsdtar tar /usr/sfw/bin/gtar; do
 $a --version 2> /dev/null | egrep "GNU|bsdtar"  2>&1 > /dev/null
diff --git a/instsetoo_native/CustomTarget_install.mk 
b/instsetoo_native/CustomTarget_install.mk
index 0974240be1fb..2edb9ef365fa 100644
--- a/instsetoo_native/CustomTarget_install.mk
+++ b/instsetoo_native/CustomTarget_install.mk
@@ -62,41 +62,18 @@ export LOCAL_COMMON_OUT := $(instsetoo_OUT)
 
 instsetoo_native_WITH_LANG := en-US $(filter-out en-US,$(gb_WITH_LANG))
 
-PRODUCTNAME_no_spaces := $(subst $(WHITESPACE),,$(PRODUCTNAME))
-
-ifeq (WNT,$(OS))
-define instsetoo_native_msitemplates
-
-TEMPLATE_DIR=$(dir $@)msi_templates \
-&& rm -rf $${TEMPLATE_DIR} \
-&& mkdir -p $${TEMPLATE_DIR}/Binary \
-&& for I in $(SRCDIR)/instsetoo_native/inc_$(1)/windows/msi_templates/*.* ; do 
$(GREP) -v '^#' "$$I" > $${TEMPLATE_DIR}/`basename $$I` || true ; done \
-&& $(GNUCOPY) 
$(SRCDIR)/instsetoo_native/inc_common/windows/msi_templates/Binary/*.* 
$${TEMPLATE_DIR}/Binary
-endef
-else
-instsetoo_native_msitemplates :=
-endif
-
 define instsetoo_native_install_command
-$(call instsetoo_native_msitemplates,$(1))
-$(call gb_Helper_print_on_error, \
-cd $(dir $@) \
-$(foreach pkgformat,$(5),\
-&& $(PERL) -w $< \
-   -f $(BUILDDIR)/instsetoo_native/util/openoffice.lst \
-   -l $(subst $(WHITESPACE),$(COMMA),$(strip $(2))) \
-   -p $(PRODUCTNAME_no_spaces)$(3) \
-   -u $(instsetoo_OUT) \
-   -packer $(COMPRESSIONTOOL) \
-   -buildid $(if $(filter deb0 
rpm0,$(pkgformat)$(LIBO_VERSION_PATCH)),1,$(LIBO_VERSION_PATCH)) \
-   $(if $(filter WNT,$(OS)), \
-   -msitemplate $(dir $@)msi_templates \
-   -msilanguage $(dir $@)win_ulffiles \
-   ) \
-   $(4) \
-   -format $(pkgformat) \
-   $(if $(verbose),-verbose,-quiet) \
-),$@.log)
+$(if $(GNUPARALLEL), \
+$(call gb_Helper_print_on_error, \
+cd $(dir $@) && \
+$(GNUPARALLEL) -j $(PARALLELISM) $(SRCDIR)/solenv/bin/call_installer.sh 
$(if $(verbose),-verbose,-quiet) -- $(1) \
+,$@.log) \
+, \
+$(call gb_Helper_print_on_error, \
+cd $(dir $@) \
+$(foreach curpkg,$(1),\
+&& $(SRCDIR)/solenv/bin/call_installer.sh $(if $(verbose),-verbose,-quiet) 
$(curpkg) \
+),$@.log))
 endef
 
 $(call 

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - sw/source

2022-06-09 Thread Miklos Vajna (via logerrit)
 sw/source/core/layout/pagechg.cxx |   16 +++-
 1 file changed, 11 insertions(+), 5 deletions(-)

New commits:
commit 6430fd9034c8d52d953a7fd61c439c27c0ce3cc7
Author: Miklos Vajna 
AuthorDate: Wed Jun 8 11:51:21 2022 +0200
Commit: Andras Timar 
CommitDate: Thu Jun 9 20:45:15 2022 +0200

sw: fix use-after-free in SwFrame::ImplFindPageFrame()

Header-footer controls have a non-owning pointer to their page frames in
Writer views, so whenever a page frame gets deleted, we need to manually
make sure that the header-footer control doesn't have a pointer to the
deleted page frame.

This already works with a single view, but in case one view has a
visible header-footer control and an other view deletes the page frame
that is known to the header-footer control, then we have a problem.

Fix the problematic outdated SwFrameMenuButtonBase::m_pFrame by
extending SwPageFrame::DestroyImpl(), so it un-registers itself (before
deletion) not only from the current view, but from all views.

Found by online.git's:

tst=/tmp/testfoo.odt
cp test/data/hello-world.odt $tst
./coolstress wss://localhost:9980 $tst test/traces/writer-hello-shape.txt 
$tst test/traces/writer-document-edit.txt $tst 
test/traces/writer-mash-text-table.txt $tst 
test/traces/writer-rambling-text-table.txt $tst 
test/traces/writer-add-bullet.txt

although also reproducible on the
desktop, in case you have two views (windows), do cltr-enter to have 2
pages, go to the 2nd page in both views, view 1 clicks on the 2nd page's
header, view 2 deletes the page (backspace) and finally view 1 clicks in
the body text of the current page.

Change-Id: I35e5d82256ab5db8e5f0ba198f5d2638cbff7d3c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135489
Reviewed-by: Michael Meeks 
Tested-by: Jenkins CollaboraOffice 
(cherry picked from commit 8d1627ff8aeb0eb128d93d9bf8c1d9b373edbf4a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135503
Tested-by: Andras Timar 

diff --git a/sw/source/core/layout/pagechg.cxx 
b/sw/source/core/layout/pagechg.cxx
index 7b885474f135..20423f85b19d 100644
--- a/sw/source/core/layout/pagechg.cxx
+++ b/sw/source/core/layout/pagechg.cxx
@@ -255,13 +255,19 @@ SwPageFrame::SwPageFrame( SwFrameFormat *pFormat, 
SwFrame* pSib, SwPageDesc *pPg
 
 void SwPageFrame::DestroyImpl()
 {
-// Cleanup the header-footer controls in the SwEditWin
+// Cleanup the header-footer controls in all SwEditWins
 SwViewShell* pSh = getRootFrame()->GetCurrShell();
-SwWrtShell* pWrtSh = dynamic_cast< SwWrtShell* >( pSh );
-if ( pWrtSh )
+if (pSh)
 {
-SwEditWin& rEditWin = pWrtSh->GetView().GetEditWin();
-rEditWin.GetFrameControlsManager( ).RemoveControls( this );
+for (SwViewShell& rSh : pSh->GetRingContainer())
+{
+SwWrtShell* pWrtSh = dynamic_cast< SwWrtShell* >(  );
+if ( pWrtSh )
+{
+SwEditWin& rEditWin = pWrtSh->GetView().GetEditWin();
+rEditWin.GetFrameControlsManager( ).RemoveControls( this );
+}
+}
 }
 
 // empty FlyContainer, deletion of the Flys is done by the anchor (in base 
class SwFrame)


[Libreoffice-bugs] [Bug 149507] CRASH: pasting and undoing

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149507

Xisco Faulí  changed:

   What|Removed |Added

  Regression By||Michael Stahl
 Status|UNCONFIRMED |NEW
   Keywords||bibisected, bisected,
   ||regression
 CC||michael.st...@allotropia.de
   ||,
   ||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #1 from Xisco Faulí  ---
Regression introduced by:

author  Michael Stahl  2021-11-19 16:08:57
+0100
committer   Michael Stahl  2021-12-23
09:11:59 +0100
commit  657de5fba12b0e9afcdee361654d2a2d0dbd7311 (patch)
tree5826d4081b90c4e55e262d203b0d3bbbc51d
parent  d11fb6cecaf72787973990e09cc7e8d03bdbf9d7 (diff)
Revert "Revert "sw_fieldmarkhide: init fieldmark mode from options""

Bisected with: bibisect-linux64-7.4

Adding Cc: to Michael Stahl

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149507] New: CRASH: pasting and undoing

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149507

Bug ID: 149507
   Summary: CRASH: pasting and undoing
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

Created attachment 180657
  --> https://bugs.documentfoundation.org/attachment.cgi?id=180657=edit
sample file

Steps to reproduce:
1. Open attached document
2. Select all
3. Copy
4. Paste
5. Undo

-> Crash

Reproduced in

Version: 7.4.0.0.alpha1+ / LibreOffice Community
Build ID: d4123356c61db269651e950a0a2cc93e6d801c90
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: x11
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148978] Business Cards in Writer don't show database

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148978

--- Comment #7 from Julien Nabet  ---
(In reply to Timur from comment #5)
> I don't get 2 things. 
> Julien, if you have a patch that would resolve this bug albeit leaving
> different labels, why didn't you apply it?
> ...
Because I prefer knowing first what we want for UI. It's not as if it was a
critical bug which needs to hurry a lot :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149506] New: Slow start-up and opening of files since 7.3 release

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149506

Bug ID: 149506
   Summary: Slow start-up and opening of files since 7.3 release
   Product: LibreOffice
   Version: 7.3.3.2 release
  Hardware: x86-64 (AMD64)
OS: macOS (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bun...@gmail.com

Description:
Libreoffice was always very quick to start and open files on my MBP i7 16GM RAM
1T SSD.

Since the upgrade to the v7.3.x family, the start-up takes much longer. 
Opening files takes 5+ sec.  It used to open files nearly instantaneously.

Steps to Reproduce:
1. Click on Libreoffice icon to start application
2. Open any file.


Actual Results:
It takes over 5 seconds to open the application.  Opening a file takes 5+
seconds.  this is much longer than the 7.2 branch which I estimate to be in the
1-2 sec.

Expected Results:
Libreoffice 7.3 branch should start-up and open files as quickly as the 7.2 and
previous branches.


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
As stated above, upto and including the 7.2 branch for MacOS Intel, Libreoffice
started and opened files very quickly.  Since 7.3.0 Libreoffice start-up and
open files is considerably slower.  Something has changed in the Mac version. 
My suspicion is that it's the display of the file as the progress bar shows the
file has opened but you can't see anything until 5+ seconds.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149341] When clicking an Insert-shape button, focus is wrong

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149341

--- Comment #8 from Eyal Rozenberg  ---
(In reply to Heiko Tietze from comment #7)
> (In reply to Eyal Rozenberg from comment #6)
> > Was your design focused only on the side-bar "angle" which Rafael brought
> > up, or are you agreeing with my suggestion generally?
> 
> True, c1 has some different angle. Don't see much need to unfocus the object
> when a command/action is _selected_. You are not drawing a shape unless
> clicking the canvas and that's the moment when the previously focused object
> is unselected.

But I get actively distracted by the change in focus, which makes a lot of
visual changes in front of me, in places where I was going to draw a box. Sorry
I couldn't be in the design meeting to clarify that, but I feel like the app is
blinking at me, discouraging me from doing what I wanted to do.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148072] Sheet-local named expression destroyed with Cut-Paste-Undo

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148072

--- Comment #1 from Eike Rathke  ---
Scenario slightly changed:
For A)3. the scope in the dialog is still Sheet1 as it should, not Global.
For B)3. and B)4. the formula in Sheet2.B3 is =Sheet1.testfield_1 where
testfield_1 with scope Sheet1 points correctly to $Sheet2.$B$2, nothing with
scope Sheet2.
For B)8. nope, deleting testfield_1 name results in #NAME? in Sheet1.B3 as it
should.
Similar B)9. and B)10. do not occur.

Actual problems:
A)5. after Ctrl+Z Ctrl+Z the testfield_1 name is gone.
B)6. after Ctrl+Z Ctrl+Z the Sheet1 scope testfield_1 still points to
$Sheet2.$B$2 instead of $Sheet1.$B$2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/mimo/mimo-7-2' - editeng/source

2022-06-09 Thread Luboš Luňák (via logerrit)
 editeng/source/editeng/impedit.cxx |6 +-
 1 file changed, 1 insertion(+), 5 deletions(-)

New commits:
commit 9f60d8858a5b6ba0ea7cd9958e1cd8701b918b2c
Author: Luboš Luňák 
AuthorDate: Thu Jun 9 15:08:41 2022 +0200
Commit: Andras Timar 
CommitDate: Thu Jun 9 19:53:17 2022 +0200

remove incorrect #ifdef DBG_UTIL around normal code (tdf#149476)

This code sets sufficient size for the virtual device that saves
the content, so it's not some optional debug code. Without this
selecting text in Calc formula bar and dragging it around leaves
artifacts, because the saved content is not large enough to restore
the original widget content. This dates back to
d51fe1189dcbe0fe06805c8d99687c125cd254eb, which supposedly made
the code warning-free (and also correct-free).

Change-Id: I52dab8c8d3a083fff9da8aed27facdf21076622e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/13
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/editeng/source/editeng/impedit.cxx 
b/editeng/source/editeng/impedit.cxx
index 348bb24f9577..d33632f56838 100644
--- a/editeng/source/editeng/impedit.cxx
+++ b/editeng/source/editeng/impedit.cxx
@@ -2151,9 +2151,6 @@ void ImpEditView::ShowDDCursor( const tools::Rectangle& 
rRect )
 aSaveRect.AdjustRight(1 );
 aSaveRect.AdjustBottom(1 );
 
-#ifdef DBG_UTIL
-Size aNewSzPx( aSaveRect.GetSize() );
-#endif
 if ( !pDragAndDropInfo->pBackground )
 {
 pDragAndDropInfo->pBackground = VclPtr::Create(rOutDev);
@@ -2163,14 +2160,13 @@ void ImpEditView::ShowDDCursor( const tools::Rectangle& 
rRect )
 
 }
 
-#ifdef DBG_UTIL
+Size aNewSzPx( aSaveRect.GetSize() );
 Size aCurSzPx( pDragAndDropInfo->pBackground->GetOutputSizePixel() );
 if ( ( aCurSzPx.Width() < aNewSzPx.Width() ) ||( aCurSzPx.Height() < 
aNewSzPx.Height() ) )
 {
 bool bDone = pDragAndDropInfo->pBackground->SetOutputSizePixel( 
aNewSzPx );
 DBG_ASSERT( bDone, "Virtual Device broken?" );
 }
-#endif
 
 aSaveRect = rOutDev.PixelToLogic( aSaveRect );
 


[Libreoffice-bugs] [Bug 78525] Right-click access in the empty toolbar area to hide/show toolbars and change icon style and size

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=78525

Timur  changed:

   What|Removed |Added

 CC||eyalr...@gmx.com

--- Comment #6 from Timur  ---
*** Bug 149493 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149493] Should be able to select visible toolbars in Toolbar context menu

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149493

Timur  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Timur  ---
I close as a duplicate of existing close but better request.

*** This bug has been marked as a duplicate of bug 78525 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/source

2022-06-09 Thread Rene Engelhard (via logerrit)
 sw/source/filter/ww8/wrtww8.cxx  |2 +-
 sw/source/filter/ww8/ww8scan.cxx |   16 
 2 files changed, 9 insertions(+), 9 deletions(-)

New commits:
commit 089c91b1ad16232f130cb50266732509f83c52eb
Author: Rene Engelhard 
AuthorDate: Thu Jun 9 15:51:33 2022 +0200
Commit: René Engelhard 
CommitDate: Thu Jun 9 19:32:10 2022 +0200

fix bigendian builds

after 410a64b472ae9de0bb06ddd8f4b55fd16686c860 and
6624721b3226ace33f5032b1c1ce595c19f1915c which changed the
surrounding places but missed the occurence in #ifdef OSL_BIGENDIAN:

Change-Id: I610b0e19a37207b925668d7f2315b27abce21b2d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135558
Tested-by: René Engelhard 
Reviewed-by: René Engelhard 

diff --git a/sw/source/filter/ww8/wrtww8.cxx b/sw/source/filter/ww8/wrtww8.cxx
index 2a25fdc8a1e3..fdf0bd056de9 100644
--- a/sw/source/filter/ww8/wrtww8.cxx
+++ b/sw/source/filter/ww8/wrtww8.cxx
@@ -1239,7 +1239,7 @@ void WW8_WrFkp::Combine()
 sal_uInt16 i;   // the Sprms must be rotated elsewhere
 
 sal_uInt32* p;
-for( i = 0, p = (sal_uInt32*)pFkp; i <= nIMax; i++, p++ )
+for( i = 0, p = (sal_uInt32*)m_pFkp; i <= m_nIMax; i++, p++ )
 *p = OSL_SWAPDWORD( *p );
 #endif // ifdef OSL_BIGENDIAN
 }
diff --git a/sw/source/filter/ww8/ww8scan.cxx b/sw/source/filter/ww8/ww8scan.cxx
index 51aa725e36b8..79ad6b110530 100644
--- a/sw/source/filter/ww8/ww8scan.cxx
+++ b/sw/source/filter/ww8/ww8scan.cxx
@@ -2159,9 +2159,9 @@ WW8PLCFspecial::WW8PLCFspecial(SvStream* pSt, sal_uInt32 
nFilePos,
 
 m_nIMax = ( nPLCF - 4 ) / ( 4 + nStruct );
 #ifdef OSL_BIGENDIAN
-for( nIdx = 0; nIdx <= nIMax; nIdx++ )
-pPLCF_PosArray[nIdx] = OSL_SWAPDWORD( pPLCF_PosArray[nIdx] );
-nIdx = 0;
+for( m_nIdx = 0; m_nIdx <= m_nIMax; nIdx++ )
+m_pPLCF_PosArray[m_nIdx] = OSL_SWAPDWORD( m_pPLCF_PosArray[m_nIdx] );
+m_nIdx = 0;
 #endif // OSL_BIGENDIAN
 if( nStruct ) // Pointer to content array
 m_pPLCF_Contents = 
reinterpret_cast(_pPLCF_PosArray[m_nIMax + 1]);
@@ -2327,9 +2327,9 @@ void WW8PLCF::ReadPLCF(SvStream& rSt, WW8_FC nFilePos, 
sal_uInt32 nPLCF)
 if (bValid)
 {
 #ifdef OSL_BIGENDIAN
-for( nIdx = 0; nIdx <= nIMax; nIdx++ )
-pPLCF_PosArray[nIdx] = OSL_SWAPDWORD( pPLCF_PosArray[nIdx] );
-nIdx = 0;
+for( m_nIdx = 0; m_nIdx <= m_nIMax; m_nIdx++ )
+m_pPLCF_PosArray[m_nIdx] = OSL_SWAPDWORD( m_pPLCF_PosArray[m_nIdx] 
);
+m_nIdx = 0;
 #endif // OSL_BIGENDIAN
 // Pointer to content array
 m_pPLCF_Contents = 
reinterpret_cast(_pPLCF_PosArray[m_nIMax + 1]);
@@ -2545,8 +2545,8 @@ WW8PLCFpcd::WW8PLCFpcd(SvStream* pSt, sal_uInt32 nFilePos,
 
 m_nIMax = ( nPLCF - 4 ) / ( 4 + nStruct );
 #ifdef OSL_BIGENDIAN
-for( tools::Long nI = 0; nI <= nIMax; nI++ )
-  pPLCF_PosArray[nI] = OSL_SWAPDWORD( pPLCF_PosArray[nI] );
+for( tools::Long nI = 0; nI <= m_nIMax; nI++ )
+  m_pPLCF_PosArray[nI] = OSL_SWAPDWORD( m_pPLCF_PosArray[nI] );
 #endif // OSL_BIGENDIAN
 
 // Pointer to content array


[Libreoffice-bugs] [Bug 149505] [CRASH] Writer hangs opening a DOCX file

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149505

Rafael Lima  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||8365

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 109178] [META] Cell names bugs and enhancements

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=109178
Bug 109178 depends on bug 81293, which changed state.

Bug 81293 Summary: The dialog “manage names” forgets size and column width 
settings
https://bugs.documentfoundation.org/show_bug.cgi?id=81293

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 102019] [META] Dialog bugs and enhancements

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=102019
Bug 102019 depends on bug 81293, which changed state.

Bug 81293 Summary: The dialog “manage names” forgets size and column width 
settings
https://bugs.documentfoundation.org/show_bug.cgi?id=81293

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 81293] The dialog “manage names” forgets size and column width settings

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=81293

Noel Grandin  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149505] New: [CRASH] Writer hangs opening a DOCX file

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149505

Bug ID: 149505
   Summary: [CRASH] Writer hangs opening a DOCX file
   Product: LibreOffice
   Version: 7.3.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rafael.palma.l...@gmail.com

Created attachment 180656
  --> https://bugs.documentfoundation.org/attachment.cgi?id=180656=edit
DOCX file where the problem occurs

Steps to reproduce:

1) Open attached file
2) Writer hangs and becomes unresponsive
3) Only way out is "killing" the process

Running LO from the terminal, after some time waiting for the document to open
I start getting the following message multiple times:

warn:legacy.osl:51766:51766:sw/source/core/layout/layact.cxx:574: LoopControl_1
in SwLayAction::InternalAction


Repro with

Version: 7.4.0.0.alpha1+ / LibreOffice Community
Build ID: 118bafcfd1ce4a26ec9df912197ebd466d1bd497
CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL

And also in LO 7.3

Version: 7.3.3.2 / LibreOffice Community
Build ID: 30(Build:2)
CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Ubuntu package version: 1:7.3.3~rc2-0ubuntu0.21.10.1~lo1
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143004] LibreOffice shows ~2px on second monitor if maximized on first monitor

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143004

V Stuart Foote  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEW |UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149476] dragging text in formula bar causes graphical artifact

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149476

Luboš Luňák  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: editeng/source

2022-06-09 Thread Luboš Luňák (via logerrit)
 editeng/source/editeng/impedit.cxx |6 +-
 1 file changed, 1 insertion(+), 5 deletions(-)

New commits:
commit dabf52b81621f1cbff508dfb7ae2e92597e521c3
Author: Luboš Luňák 
AuthorDate: Thu Jun 9 15:08:41 2022 +0200
Commit: Luboš Luňák 
CommitDate: Thu Jun 9 18:42:12 2022 +0200

remove incorrect #ifdef DBG_UTIL around normal code (tdf#149476)

This code sets sufficient size for the virtual device that saves
the content, so it's not some optional debug code. Without this
selecting text in Calc formula bar and dragging it around leaves
artifacts, because the saved content is not large enough to restore
the original widget content. This dates back to
d51fe1189dcbe0fe06805c8d99687c125cd254eb, which supposedly made
the code warning-free (and also correct-free).

Change-Id: I52dab8c8d3a083fff9da8aed27facdf21076622e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/13
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/editeng/source/editeng/impedit.cxx 
b/editeng/source/editeng/impedit.cxx
index 87ddc0bcd994..53aefa9b8cc1 100644
--- a/editeng/source/editeng/impedit.cxx
+++ b/editeng/source/editeng/impedit.cxx
@@ -2180,9 +2180,6 @@ void ImpEditView::ShowDDCursor( const tools::Rectangle& 
rRect )
 aSaveRect.AdjustRight(1 );
 aSaveRect.AdjustBottom(1 );
 
-#ifdef DBG_UTIL
-Size aNewSzPx( aSaveRect.GetSize() );
-#endif
 if ( !pDragAndDropInfo->pBackground )
 {
 pDragAndDropInfo->pBackground = VclPtr::Create(rOutDev);
@@ -2192,14 +2189,13 @@ void ImpEditView::ShowDDCursor( const tools::Rectangle& 
rRect )
 
 }
 
-#ifdef DBG_UTIL
+Size aNewSzPx( aSaveRect.GetSize() );
 Size aCurSzPx( pDragAndDropInfo->pBackground->GetOutputSizePixel() );
 if ( ( aCurSzPx.Width() < aNewSzPx.Width() ) ||( aCurSzPx.Height() < 
aNewSzPx.Height() ) )
 {
 bool bDone = pDragAndDropInfo->pBackground->SetOutputSizePixel( 
aNewSzPx );
 DBG_ASSERT( bDone, "Virtual Device broken?" );
 }
-#endif
 
 aSaveRect = rOutDev.PixelToLogic( aSaveRect );
 


[Libreoffice-bugs] [Bug 149476] dragging text in formula bar causes graphical artifact

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149476

--- Comment #5 from Commit Notification 
 ---
Luboš Luňák committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/dabf52b81621f1cbff508dfb7ae2e92597e521c3

remove incorrect #ifdef DBG_UTIL around normal code (tdf#149476)

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149476] dragging text in formula bar causes graphical artifact

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149476

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147576] SLIDESHOW: Shapes get stretched in slideshow

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147576

--- Comment #13 from Timur  ---
(In reply to Gabor Kelemen (allotropia) from comment #12)
> this is not a new issue by any means.

I read this aa "not a regression" but it's marked so, please clarify.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148321] FILEOPEN PPTX: text on top of circular object misplaced

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148321

--- Comment #6 from Gerald Pfeifer  ---
(In reply to Regina Henschel from comment #5)
> @Tomaž: Thank you for these test files.

+1

> For all of the shapes the round-trip PPTX->LO->PPTX works fine. I have
> tested it in addition with some rotated shapes and found no problems. 

Great - thank you for that additional validation, Regina!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143004] LibreOffice shows ~2px on second monitor if maximized on first monitor

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143004

Alex Botez  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143004] LibreOffice shows ~2px on second monitor if maximized on first monitor

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143004

--- Comment #4 from Alex Botez  ---
If you really want to experience a new Discord server that has welcoming
people, you might want to check out the no mans sky Discords here
(https://discordserverlists.com/no-mans-sky-discord/). They are really cool
people with a heart of gold. There are hundreds of thousands of them in the
community.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Review requested: updated gcov/lcov report shell script

2022-06-09 Thread Maarten Hoes
Hi,


After my previous emails on the gcov/lcov code coverage subject on this
list, I have modified the existing lcov html report generating script [1],
and would like some feedback/reviewer on the modifications.

The major changes compared to the previous version are:

1.)
The script was reworked to make its usage simpler. The current script
requires you to run the script multiple times, in multiple 'steps/phases',
and for you to run a manual 'make check' in between these steps at some
point. The new version only needs to be run once, and only needs flags to
tell it where the sources are, where the report should go, etc. With the
new version, you basically don't have to know anything about lcov/gcov,
while the current version assumes you have a basic understanding of how
lcov works / should be used.

2.)
The order of the various steps in the script has been changed, to (more)
correctly reflect how the lcov tool should be used (both the current script
and the wiki page [4] get this wrong, I'm thinking about updating the wiki
as well).


Some open points and notes (which I should perhaps put in a 'NOTES' or
'TODO' file next to the actual shell script in git ?) are :

1.)
The current build system tries to enforce building Skia with clang, which
led to incompatibilities between clang and gcc [2]. But - intended or not -
when clang is not installed, Skia gets built with gcc as fallback. The
script currently does not verify if clang is indeed not installed, but will
fail when parts of the build (Skia) get built with clang, and other parts
with gcc.

2.)
On my test system, 3 checks of 'make check' (specifically and only in
combination with a 'gcov' build) fail when run on my PC (UITest_solver,
CppunitTest_sccomp_solver, CppunitTest_sccomp_swarmsolvertest). It is
currently assumed that the 'slowness' of my PC leads to timeouts, and
running the tests on a faster system will resolve this issue [3]. This is
currently not verified as I do not have a faster system at my disposal. As
it currently stands, the script fails when 'make check' fails, and in that
case no report is generated.

3.)
The current directory in git for the script has a subdirectory called
'tinderbox', apparently with things for use with, well, a 'tinderbox'. I
wonder how useful and/or relevant this still is ? I can't really remember
much about this, even though 'git log' tells me I'm the author of the
things in there. Is this something that still is relevant today and needs
to be updated along with the new script, or can this safely be removed ?


PS: Sorry, but as a result of my ferocious editing, the 'diff' between the
old and new versions of the script are a bit of a mess, and doesn't really
make sense anymore.


- Maarten


[1]
https://gerrit.libreoffice.org/c/buildbot/+/135560

[2]
https://lists.freedesktop.org/archives/libreoffice/2022-May/088867.html

[3]
https://lists.freedesktop.org/archives/libreoffice/2022-June/088971.html

[4]
https://wiki.documentfoundation.org/Development/Lcov


[Libreoffice-bugs] [Bug 149490] multiple copies of dialogs can be opened from undocked toolbars

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149490

sdc.bla...@youmail.dk changed:

   What|Removed |Added

Version|7.4.0.0 alpha0+ Master  |7.2.6.2 release

--- Comment #6 from sdc.bla...@youmail.dk ---
Can reproduce all described effects (also with docked OLE Object toolbar) with:

Version: 7.2.6.2 (x64) / LibreOffice Community
Build ID: b0ec3a565991f7569a5a7f5d24fed7f52653d754
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: da-DK (da_DK); UI: en-US
Calc: threaded

(changing version number)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: accessibility/inc accessibility/Library_acc.mk accessibility/source include/vcl starmath/source vcl/inc vcl/source

2022-06-09 Thread Mike Kaganski (via logerrit)
 accessibility/Library_acc.mk |1 
 accessibility/inc/extended/AccessibleIconView.hxx|   30 
 accessibility/inc/extended/accessiblelistbox.hxx |9 +-
 accessibility/source/extended/AccessibleIconView.cxx |   53 +++
 accessibility/source/extended/accessiblelistboxentry.cxx |   25 ---
 accessibility/source/helper/acc_factory.cxx  |   13 +++
 include/vcl/accessiblefactory.hxx|5 +
 include/vcl/toolkit/treelistbox.hxx  |2 
 include/vcl/weld.hxx |5 +
 starmath/source/accessibility.cxx|6 -
 vcl/inc/iconview.hxx |   11 +++
 vcl/inc/salvtables.hxx   |1 
 vcl/source/app/salvtables.cxx|   12 +++
 vcl/source/helper/svtaccessiblefactory.cxx   |9 ++
 vcl/source/treelist/iconview.cxx |   25 +++
 vcl/source/treelist/treelistbox.cxx  |   27 +++
 16 files changed, 202 insertions(+), 32 deletions(-)

New commits:
commit 2a28ebeef5ea3e2b01d836a7233d2316b765bf38
Author: Mike Kaganski 
AuthorDate: Wed Jun 1 11:18:26 2022 +0300
Commit: Mike Kaganski 
CommitDate: Thu Jun 9 17:49:16 2022 +0200

Accessibility for IconView

Change-Id: I65ca9d43f70a50e2e95aabfc3b8ba1b15f9ff8be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135226
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/accessibility/Library_acc.mk b/accessibility/Library_acc.mk
index 0926fee97e5d..34c4dc7eb0c5 100644
--- a/accessibility/Library_acc.mk
+++ b/accessibility/Library_acc.mk
@@ -62,6 +62,7 @@ $(eval $(call gb_Library_add_exception_objects,acc,\
 accessibility/source/extended/accessibleeditbrowseboxcell \
 accessibility/source/extended/accessibleiconchoicectrl \
 accessibility/source/extended/accessibleiconchoicectrlentry \
+accessibility/source/extended/AccessibleIconView \
 accessibility/source/extended/accessiblelistbox \
 accessibility/source/extended/accessiblelistboxentry \
 accessibility/source/extended/accessibletablistbox \
diff --git a/accessibility/inc/extended/AccessibleIconView.hxx 
b/accessibility/inc/extended/AccessibleIconView.hxx
new file mode 100644
index ..d5ab5eafb198
--- /dev/null
+++ b/accessibility/inc/extended/AccessibleIconView.hxx
@@ -0,0 +1,30 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#pragma once
+
+#include 
+
+#include "accessiblelistbox.hxx"
+
+namespace accessibility
+{
+class AccessibleIconView final : public AccessibleListBox
+{
+public:
+AccessibleIconView(SvTreeListBox const& _rListBox,
+   const 
css::uno::Reference& _xParent);
+
+protected:
+// VCLXAccessibleComponent
+virtual void ProcessWindowEvent(const VclWindowEvent& rVclWindowEvent) 
override;
+};
+} // namespace accessibility
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */
diff --git a/accessibility/inc/extended/accessiblelistbox.hxx 
b/accessibility/inc/extended/accessiblelistbox.hxx
index 4f4104701709..40b01ea180a5 100644
--- a/accessibility/inc/extended/accessiblelistbox.hxx
+++ b/accessibility/inc/extended/accessiblelistbox.hxx
@@ -37,7 +37,7 @@ namespace accessibility
 
 /** the class OAccessibleListBoxEntry represents the base class for an 
accessible object of a listbox entry
 */
-class AccessibleListBox final :
+class AccessibleListBox :
 public cppu::ImplHelper2<
 css::accessibility::XAccessible,
 css::accessibility::XAccessibleSelection>,
@@ -45,18 +45,17 @@ namespace accessibility
 {
 
 css::uno::Reference< css::accessibility::XAccessible > m_xParent;
-
-virtual ~AccessibleListBox() override;
-
 // OComponentHelper overridables
 /** this function is called upon disposing the component */
 virtual void SAL_CALL   disposing() override;
 
+protected:
 // VCLXAccessibleComponent
 virtual voidProcessWindowEvent( const VclWindowEvent& 
rVclWindowEvent ) override;
 virtual voidProcessWindowChildEvent( const VclWindowEvent& 
rVclWindowEvent ) override;
 virtual voidFillAccessibleStateSet( utl::AccessibleStateSetHelper& 
rStateSet ) override;
 
+private:
 VclPtr< SvTreeListBox > getListBox() const;
 
 voidRemoveChildEntries(SvTreeListEntry*);
@@ -73,6 +72,8 @@ namespace accessibility
 AccessibleListBox( SvTreeListBox const & 

Re: How to clone/commit/push (for 'buildbot' repo) ?

2022-06-09 Thread Maarten Hoes
On Thu, Jun 9, 2022 at 4:20 PM Maarten Hoes  wrote:

>
> What I think I see happening is that the client is trying to force 'sftp'
> when the scp command is used, and the server is not having it ? Or perhaps
> I am simply using the wrong command to clone the repo and set it up for
> commiting / putting things up for review ?
>
>
Hrm.

I did some more googling, and came across scp's '-O' switch, which as
described in the man page :

"
-O  Use the original SCP protocol for file transfers instead of the
SFTP protocol.  Forcing the use of the SCP protocol may be necessary for
servers that do not implement SFTP, for backwards-compatibility for
particular filename wildcard patterns and for expanding paths with a ‘~’
prefix for older
 SFTP servers.
"


And if I add that to the scp commandline, it all works as expected, and I
was able to put my changes up for review in gerrit, doing the following, as
I mentioned in my earlier email :


> cd buildbot/lcov-report/
> git checkout -b lcov-report
> cp ~/bin/libreoffice/README ~/bin/libreoffice/lcov-report.sh .
> git add README lcov-report.sh
> git commit
> git push origin lcov-report:refs/for/master
>


But perhaps someone should look at this for a more structural solution ?


- Maarten


[Libreoffice-commits] core.git: helpcontent2

2022-06-09 Thread Rafael Lima (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 2910ce0b43552cbd6415e5930953c660e41b1965
Author: Rafael Lima 
AuthorDate: Thu Jun 9 17:46:08 2022 +0200
Commit: Gerrit Code Review 
CommitDate: Thu Jun 9 17:46:08 2022 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to 6a94b253eee022e358504b335e190e883e74749f
  - Document new CreatePivotTable method in SF_Calc

Change-Id: I56de41d153c650058e85faaad023f169b3ca79cd
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134436
Tested-by: Jenkins
Reviewed-by: Alain Romedenne 

diff --git a/helpcontent2 b/helpcontent2
index 09dfc9550cc7..6a94b253eee0 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 09dfc9550cc74aae157411e570375edb7abda341
+Subproject commit 6a94b253eee022e358504b335e190e883e74749f


[Libreoffice-commits] help.git: source/text

2022-06-09 Thread Rafael Lima (via logerrit)
 source/text/sbasic/shared/03/sf_calc.xhp |   67 ++-
 1 file changed, 65 insertions(+), 2 deletions(-)

New commits:
commit 6a94b253eee022e358504b335e190e883e74749f
Author: Rafael Lima 
AuthorDate: Tue May 17 15:26:25 2022 +0200
Commit: Jean-Pierre Ledure 
CommitDate: Thu Jun 9 17:46:05 2022 +0200

Document new CreatePivotTable method in SF_Calc

Change-Id: I56de41d153c650058e85faaad023f169b3ca79cd
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134436
Tested-by: Jenkins
Reviewed-by: Alain Romedenne 

diff --git a/source/text/sbasic/shared/03/sf_calc.xhp 
b/source/text/sbasic/shared/03/sf_calc.xhp
index 7be0ecaf7..738b9017f 100644
--- a/source/text/sbasic/shared/03/sf_calc.xhp
+++ b/source/text/sbasic/shared/03/sf_calc.xhp
@@ -533,6 +533,7 @@
  CopyToCell
  CopyToRange
  CreateChart
+ CreatePivotTable
  DAvg


@@ -551,7 +552,7 @@
  InsertSheet
  MoveRange
  MoveSheet
- Offset
+ Offset



@@ -569,7 +570,7 @@
  ShiftLeft
  ShiftRight
  ShiftUp
- SortRange
+ SortRange



@@ -1040,6 +1041,68 @@
   Refer to the help page about ScriptForge's 
Chart 
service to learn more how to further manipulate chart objects. It is 
possible to change properties as the chart type, chart and axes titles and 
chart position.
 
 
+
+   CreatePivotTable 

 
+  
+  Calc service;CreatePivotTable
+  
+  CreatePivotTable
+  Creates a new pivot 
table with the properties defined by the arguments  passed to the 
method.
+  A name must be 
provided for the pivot table. If a pivot table with the same name already 
exists in the targeted sheet, it will be replaced without warning.
+  This method returns a 
string containing the range where the new pivot table was placed.
+  
+  
+svc.CreatePivotTable(pivottablename: str, sourcerange: str, 
targetcell: str, datafields: str[0..*], rowfields: str[0..*], columnfields: 
str[0..*], filterbutton: bool = true, rowtotals: bool = true, columntotals: 
bool = true): str
+  
+  
+  pivottablename: The user-defined name 
of the new pivot table.
+  sourcerange: The range containing the 
raw data, as a string. It is assumed that the first row contains the field 
names that are used by the pivot table.
+  targetcell: The top-left cell where 
the new pivot table will be placed. If a range is specified, only its top-left 
cell is considered.
+  datafields: It can be either a single 
string or an array containing strings that define field names and functions to 
be applied. When an array is specified, it must follow the syntax 
Array("FieldName[;Function]", ...).
+  The allowed functions 
are: Sum, Count, 
Average, Max, Min, 
Product, CountNums, 
StDev, StDevP, Var, 
VarP and Median. Function names must be 
provided in English. When all values are numerical, Sum is 
the default function, otherwise the default function is 
Count.
+  rowfields: A single string or an array 
with the field names that will be used as the pivot table rows.
+  columnfields: A single string or an 
array with the field names that will be used as the pivot table 
columns.
+  filterbutton: Determines whether a 
filter button will be displayed above the pivot table (Default = 
True).
+  rowtotals: Specifies if a separate 
column for row totals will be added to the pivot table (Default = 
True).
+  columntotals Specifies if a separate 
row for column totals will be added to the pivot table (Default = 
True)
+  
+  
+  
+Dim 
vData As Variant, oDoc As Object, ui As Object, sTable As String, sPivot As 
String
+Set 
ui = CreateScriptService("UI")
+Set 
oDoc = ui.CreateDocument("Calc")
+vData = 
Array(Array("Item", "State", "Team", "2002", "2003", "2004"), _
+Array("Books", 
"Michigan", "Jean", 14788, 30222, 23490), _
+Array("Candy", 
"Michigan", "Jean", 26388, 15641, 32849), _
+Array("Pens", 
"Michigan", "Jean", 16569, 32675, 25396), _
+Array("Books", 
"Michigan", "Volker", 21961, 21242, 29009), _
+Array("Candy", 
"Michigan", "Volker", 26142, 22407, 32841))
+sTable = oDoc.SetArray("A1", vData)
+sPivot = oDoc.CreatePivotTable("PT1", sTable, "H1", 
_
+Array("2002", 
"2003;count", "2004;average"), _ ' Three data fields
+"Item", _ ' A 
single row field
+Array("State", 
"Team"), False) ' Two column fields
+  
+  
+  
+ui = 
CreateScriptService("UI")
+doc = 
ui.CreateDocument("Calc")
+vData = [["Item", 
"State", "Team", "2002", "2003", "2004"],
+ ["Books", 
"Michigan", "Jean", 14788, 30222, 23490],
+ ["Candy", 
"Michigan", "Jean", 26388, 15641, 32849],
+ ["Pens", 
"Michigan", "Jean", 16569, 32675, 25396)],
+ 

[Libreoffice-commits] core.git: helpcontent2

2022-06-09 Thread Alain Romedenne (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0f9658f94f3505fa49449d0fca354f27edd89569
Author: Alain Romedenne 
AuthorDate: Thu Jun 9 17:34:05 2022 +0200
Commit: Gerrit Code Review 
CommitDate: Thu Jun 9 17:34:05 2022 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to 09dfc9550cc74aae157411e570375edb7abda341
  - Replace outdated links to OOo's wiki

Change-Id: I4603f02312347b203dbbc13170f92819401e9a3a
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135535
Tested-by: Jenkins
Reviewed-by: Rafael Lima 
Reviewed-by: Alain Romedenne 

diff --git a/helpcontent2 b/helpcontent2
index b97210c58dbb..09dfc9550cc7 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit b97210c58dbbf9c16f4a4cbeba5665ada2efe6fb
+Subproject commit 09dfc9550cc74aae157411e570375edb7abda341


[Libreoffice-commits] help.git: source/text

2022-06-09 Thread Alain Romedenne (via logerrit)
 source/text/sbasic/shared/03/sf_dialog.xhp|2 +-
 source/text/sbasic/shared/03/sf_dialogcontrol.xhp |2 +-
 source/text/sbasic/shared/03/sf_form.xhp  |2 +-
 source/text/sbasic/shared/03/sf_formcontrol.xhp   |2 +-
 source/text/sbasic/shared/03/sf_menu.xhp  |2 +-
 source/text/shared/guide/lotusdbasediff.xhp   |2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 09dfc9550cc74aae157411e570375edb7abda341
Author: Alain Romedenne 
AuthorDate: Thu Jun 9 16:11:43 2022 +0200
Commit: Alain Romedenne 
CommitDate: Thu Jun 9 17:34:03 2022 +0200

Replace outdated links to OOo's wiki

Change-Id: I4603f02312347b203dbbc13170f92819401e9a3a
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135535
Tested-by: Jenkins
Reviewed-by: Rafael Lima 
Reviewed-by: Alain Romedenne 

diff --git a/source/text/sbasic/shared/03/sf_dialog.xhp 
b/source/text/sbasic/shared/03/sf_dialog.xhp
index 4d2108b0f..8f9f755c1 100644
--- a/source/text/sbasic/shared/03/sf_dialog.xhp
+++ b/source/text/sbasic/shared/03/sf_dialog.xhp
@@ -254,7 +254,7 @@
   

Event properties
-   Returns a URI string with the reference to the script 
triggered by the event. Read its specification in the https://wiki.openoffice.org/wiki/Documentation/DevGuide/Scripting/Scripting_Framework_URI_Specification;
 name="URI specification">scripting framework URI 
specification.
+   Returns a URI string with the reference to the script 
triggered by the event. Read its specification in the https://wiki.documentfoundation.org/Documentation/DevGuide/Scripting_Framework#Scripting_Framework_URI_Specification;
 name="URI specification">scripting framework URI 
specification.

   
  
diff --git a/source/text/sbasic/shared/03/sf_dialogcontrol.xhp 
b/source/text/sbasic/shared/03/sf_dialogcontrol.xhp
index 9f92015a7..59bb03085 100644
--- a/source/text/sbasic/shared/03/sf_dialogcontrol.xhp
+++ b/source/text/sbasic/shared/03/sf_dialogcontrol.xhp
@@ -767,7 +767,7 @@
   

Event properties
-   Returns a URI string with the reference to the script 
triggered by the event. Read its specification in the https://wiki.openoffice.org/wiki/Documentation/DevGuide/Scripting/Scripting_Framework_URI_Specification;
 name="URI specification">scripting framework URI 
specification.
+   Returns a URI string with the reference to the script 
triggered by the event. Read its specification in the https://wiki.documentfoundation.org/Documentation/DevGuide/Scripting_Framework#Scripting_Framework_URI_Specification;
 name="URI specification">scripting framework URI 
specification.

   
  
diff --git a/source/text/sbasic/shared/03/sf_form.xhp 
b/source/text/sbasic/shared/03/sf_form.xhp
index 78354a040..d9515a222 100644
--- a/source/text/sbasic/shared/03/sf_form.xhp
+++ b/source/text/sbasic/shared/03/sf_form.xhp
@@ -548,7 +548,7 @@
  
   

-   To learn more about URI strings, refer to 
the https://wiki.openoffice.org/wiki/Documentation/DevGuide/Scripting/Scripting_Framework_URI_Specification;
 name="URI specification">Scripting Framework URI Specification.
+   To learn more about URI strings, refer to 
the https://wiki.documentfoundation.org/Documentation/DevGuide/Scripting_Framework#Scripting_Framework_URI_Specification;
 name="URI specification">Scripting Framework URI Specification.

 
List of methods in the Form service
diff --git a/source/text/sbasic/shared/03/sf_formcontrol.xhp 
b/source/text/sbasic/shared/03/sf_formcontrol.xhp
index 448fc99c8..4bcfaf687 100644
--- a/source/text/sbasic/shared/03/sf_formcontrol.xhp
+++ b/source/text/sbasic/shared/03/sf_formcontrol.xhp
@@ -1043,7 +1043,7 @@
  
   

-   To learn more about URI strings, refer to 
the https://wiki.openoffice.org/wiki/Documentation/DevGuide/Scripting/Scripting_Framework_URI_Specification;
 name="URI specification">Scripting Framework URI Specification.
+   To learn more about URI strings, refer to 
the https://wiki.documentfoundation.org/Documentation/DevGuide/Scripting_Framework#Scripting_Framework_URI_Specification;
 name="URI specification">Scripting Framework URI Specification.


List of Methods in the FormControl 
Service
diff --git a/source/text/sbasic/shared/03/sf_menu.xhp 
b/source/text/sbasic/shared/03/sf_menu.xhp
index 56ef1531d..162c63083 100644
--- a/source/text/sbasic/shared/03/sf_menu.xhp
+++ b/source/text/sbasic/shared/03/sf_menu.xhp
@@ -234,7 +234,7 @@
 script: 
The URI for a Basic or Python script that will be executed when the item is 
clicked.
 
   The arguments command 
and script are mutually exclusive, hence only one of them 
can be set for each menu item.
-  Read https://wiki.openoffice.org/wiki/Documentation/DevGuide/Scripting/Scripting_Framework_URI_Specification;
 name="URI_Notation">Scripting Framework URI Specification to learn more 
about the URI syntax used in the script 

[Libreoffice-bugs] [Bug 149490] multiple copies of dialogs can be opened from undocked toolbars

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149490

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 Blocks||103239
  Component|Writer  |LibreOffice
 CC||caol...@redhat.com
Summary|multiple copies of  |multiple copies of dialogs
   |Properties dialog can be|can be opened from undocked
   |opened from undocked|toolbars
   |toolbars  (docked is OK,|
   |except for OLE Object)  |

--- Comment #5 from sdc.bla...@youmail.dk ---
In Draw

1. With selected image, open Image toolbar undocked.
2. Click multiple times on "Line" icon

Result: Multiple copies of Line dialog are opened.

=> Bold generalization:  undocked toolbars (in all applications) with icons
that open a dialog box will open multiple copies of that dialog (if the icon is
clicked multiple times).

cc: Caolán, because I think this is his bailiwick.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103239
[Bug 103239] [META] Toolbars bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103239] [META] Toolbars bugs and enhancements

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103239

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 Depends on||149490


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=149490
[Bug 149490] multiple copies of dialogs can be opened from undocked toolbars
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149490] multiple copies of Properties dialog can be opened from undocked toolbars (docked is OK, except for OLE Object)

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149490

sdc.bla...@youmail.dk changed:

   What|Removed |Added

Summary|multiple copies of Table|multiple copies of
   |Properties dialog can be|Properties dialog can be
   |opened from an undocked |opened from undocked
   |Table toolbar  (docked is   |toolbars  (docked is OK,
   |OK) |except for OLE Object)

--- Comment #4 from sdc.bla...@youmail.dk ---
Let's make this more interesting.

(in all cases, clicking on "Properties" icon on relevant toolbar)

1. Frame:   Undocked (multiple copies)  Docked (one)
2. ImageUndocked (multiple copies)  Docked (one)
3. OLE Object:  Undocked (multiple copies)  Docked (multiple copies!)

For a Shape -- no Properties dialog -- but:

- click the "Position and Size" icon on the status bar multiple times (count
how many).

- it appears that only one Position and Size dialog is open -- but -- click
"Cancel" and a new copy appears, until you have cancelled the number of times
that you originally clicked.

Additional information:

I have encountered this multiple case before with Position and Size, and have
had some crashes, without being able to figure out STR, but usually involves
changing some control options, and cancelling

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147576] SLIDESHOW: Shapes get stretched in slideshow

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147576

--- Comment #12 from Gabor Kelemen (allotropia)  ---
(In reply to Armin Le Grand from comment #11)
> Created a version without the change in discussion. The context menu
> convert/to metafile creates the same error, so the BoundRect is already
> wrong in that version. But he Presentation works - have to check why, AFAIK
> GraphicExporter::GetGraphic (where the change is) is not used by
> Presentation preparations...?

I just checked the error with the convert/to metafile case, can confirm that is
changing the shapes from square to rectangle shape at least since 3.5.0 - this
is not a new issue by any means.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149503] CRASH: Pasting content from sheet

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149503

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |xiscofa...@libreoffice.org
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149504] incorrect import/insertion of datetime value into Calc using ctrl-shift-alt-v (Date (YMD) format is selected)

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149504

--- Comment #1 from Mike Kaganski  ---
Not reproducible using Version: 7.3.4.1 (x64) / LibreOffice Community
Build ID: 13668373362b52f6e3ebcaaecb031bd59a3ac66b
CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: en-US (ru_RU); UI: en-US
Calc: CL Jumbo

Are you sure that in the Text Import dialog, the Language (actually locale
defining how the numbers would be parsed by default) is set to a locale using
dot as decimal separator (required for correct handling of second fractions in
your data); that [x] Detect special numbers is checked (required for date
recognition), and that separator is Tab?

-- 
You are receiving this mail because:
You are the assignee for the bug.

ESC meeting minutes: 2022-06-09

2022-06-09 Thread Stephan Bergmann

* Present:
+ Michael W, Thorsten, Heiko, Hossein, Caolan, Stephan, Ilmari, 
Lubos, Michael S,

  Gabriel, Eike, Olivier, Xisco, Cloph, Kendy, Quikee, Michael M

* Completed Action Items:
+ create a bugzilla query for open easy hacks without the 
reviewed:2022 whiteboard field (Hossein) → 
https://wiki.documentfoundation.org/Development/EasyHacks/Review

+ document Java baseline in README.md (Hossein)
  Add information on Java baseline in README.md
  https://gerrit.libreoffice.org/c/core/+/135557

* Pending Action Items:

* Release Engineering update (Cloph)
+ 7.4 status:
  + beta 1 + feature freeze + 7-4 branch later today
  + self-approval still possible on 7-4 branch for now
  + string/UI freeze in week 27, additional approvals needed then
+ 7.3 status: 7.3.4 final today
   + 7.3.5 rc1 end of June
+ Windows ARM build (Thorsten)
  + add similarly to macOS ARM build (Cloph)
  + Gerrit CI would be great (Thorsten)
- tough w/o adding more hw (Cloph)
- get every N'ths build done, Thorsten committing to act in 
case of failure

  then
  + Any use of that build? (Heiko)
 - there are low-cost Windows machines using ARM (Thorsten)
 - Microsoft introduced the SQ1/SQ2 Processor based on ARM
 - see e.g. here 
https://www.androidauthority.com/windows-on-arm-explained-3100713/

+ Remotes: Android, iOS; Android viewer

* Under-loved areas of the codebase (Michael M)
  + https://wiki.documentfoundation.org/Development/Under-loved_areas
  + personal communication from a foundation director (Michael S)
 + very unhappy we're discussing this topic
 + that we have started our own list - instead of using his proposal
 + asking us to replace the description with a sentence - don't have
   an opinion on it.
   "This page is meant to build a selection of "Focus areas" of the 
LibreOffice codebase with contributions from the ESC and TDF's team to 
list areas that have been neglected for a while and would benefit from 
additional attention from commercial contributors, in-house developers 
and volunteers."
  + seems to me it's good to have the ESC oversee engineering things 
(Michael)

 + like to keep it clear of political manoevers (Stephan B)
 + strongly support that (Thorsten, Xisco, Michael M)
  + says:
  "This page is meant to build a list of under-loved areas of the 
LibreOffice codebase where the ESC recommends more attention and would 
benefit from investment of resources without duplicating existing 
investment. The intention is to list higher level areas, like RTL or CTL 
support, or Base (no micro-ideas, please)."

+ nothing problematic with that (Stephan B)
   + what is the difference ?
   + no idea (Michael S)
  + only a developer, not a grand visionary.
+ note it is a wiki - it's easy to edit it yourself (Michael M)
   + motivation - avoiding delay (Michael M)
  + propose come up with a spreadsheet to rank these
  + BoD can use it, or not use it as it sees fit.
   + was there interesting bugs/LOC? (Michael M)
  + expected someone else to do it from my sheet (Xisco)
AI:   + create the ranking sheet and include anything from Xisco's bug 
data (Miklos)


* Atticization of LOOL (Michael M)
  + policy is here: https://wiki.documentfoundation.org/TDF/Policies/Attic
  + technical vs. political
  + limbo state currently.
+ contributors moved away 2020-10-01
   + no commits for ~3 months
+ was 'frozen' since 2021-01-19
   + https://cgit.freedesktop.org/libreoffice/online/log
+ make clear that no bugfixing is going on (Caolan)
   + real security issues / hazard here:
   + https://github.com/CollaboraOnline/online/security/advisories
+ and how to un-freeze it if wanted
   + support the idea to get some clarity here (Thorsten)
  + as one of the co-authors of the process - reminder we need to 
decide

if it small/medium/large
   + we might become something similar as ASF for OO if continues 
(Michael S)

   + size: between medium & large (Caolan)
  + agree (Thorsten)
  + initial thought it is large (Stephan B)
  + quite complex - JS + C++ - leaflet etc. (Michael M)
  + intimiately tied to core (Thorsten)
 + size: 1 small, 3 medium, 6 large
 + not sure tightness to core should count (Kendy)
+ project itself - C++/JS server-side quite large.
+ Atticization proposal evolved (Thorsten)
  + was one-size-fits all initially, thought for small projects too 
onerous

to require 3 devs, so - we had this three sizes added
   + consensus that it is at least medium sized (Thorsten)
  + little practical difference if 3-6 need to show up (Stephan B)
   * propose the "atticization" of LOOL
  + 9 - no concerns
  + 6 - abstain
  => passed.
=> AI: pass on to board (Stephan)

* Documentation (Olivier)
+ New Help, no news
 

[Libreoffice-qa] ESC meeting minutes: 2022-06-09

2022-06-09 Thread Stephan Bergmann

* Present:
+ Michael W, Thorsten, Heiko, Hossein, Caolan, Stephan, Ilmari, 
Lubos, Michael S,

  Gabriel, Eike, Olivier, Xisco, Cloph, Kendy, Quikee, Michael M

* Completed Action Items:
+ create a bugzilla query for open easy hacks without the 
reviewed:2022 whiteboard field (Hossein) → 
https://wiki.documentfoundation.org/Development/EasyHacks/Review

+ document Java baseline in README.md (Hossein)
  Add information on Java baseline in README.md
  https://gerrit.libreoffice.org/c/core/+/135557

* Pending Action Items:

* Release Engineering update (Cloph)
+ 7.4 status:
  + beta 1 + feature freeze + 7-4 branch later today
  + self-approval still possible on 7-4 branch for now
  + string/UI freeze in week 27, additional approvals needed then
+ 7.3 status: 7.3.4 final today
   + 7.3.5 rc1 end of June
+ Windows ARM build (Thorsten)
  + add similarly to macOS ARM build (Cloph)
  + Gerrit CI would be great (Thorsten)
- tough w/o adding more hw (Cloph)
- get every N'ths build done, Thorsten committing to act in 
case of failure

  then
  + Any use of that build? (Heiko)
 - there are low-cost Windows machines using ARM (Thorsten)
 - Microsoft introduced the SQ1/SQ2 Processor based on ARM
 - see e.g. here 
https://www.androidauthority.com/windows-on-arm-explained-3100713/

+ Remotes: Android, iOS; Android viewer

* Under-loved areas of the codebase (Michael M)
  + https://wiki.documentfoundation.org/Development/Under-loved_areas
  + personal communication from a foundation director (Michael S)
 + very unhappy we're discussing this topic
 + that we have started our own list - instead of using his proposal
 + asking us to replace the description with a sentence - don't have
   an opinion on it.
   "This page is meant to build a selection of "Focus areas" of the 
LibreOffice codebase with contributions from the ESC and TDF's team to 
list areas that have been neglected for a while and would benefit from 
additional attention from commercial contributors, in-house developers 
and volunteers."
  + seems to me it's good to have the ESC oversee engineering things 
(Michael)

 + like to keep it clear of political manoevers (Stephan B)
 + strongly support that (Thorsten, Xisco, Michael M)
  + says:
  "This page is meant to build a list of under-loved areas of the 
LibreOffice codebase where the ESC recommends more attention and would 
benefit from investment of resources without duplicating existing 
investment. The intention is to list higher level areas, like RTL or CTL 
support, or Base (no micro-ideas, please)."

+ nothing problematic with that (Stephan B)
   + what is the difference ?
   + no idea (Michael S)
  + only a developer, not a grand visionary.
+ note it is a wiki - it's easy to edit it yourself (Michael M)
   + motivation - avoiding delay (Michael M)
  + propose come up with a spreadsheet to rank these
  + BoD can use it, or not use it as it sees fit.
   + was there interesting bugs/LOC? (Michael M)
  + expected someone else to do it from my sheet (Xisco)
AI:   + create the ranking sheet and include anything from Xisco's bug 
data (Miklos)


* Atticization of LOOL (Michael M)
  + policy is here: https://wiki.documentfoundation.org/TDF/Policies/Attic
  + technical vs. political
  + limbo state currently.
+ contributors moved away 2020-10-01
   + no commits for ~3 months
+ was 'frozen' since 2021-01-19
   + https://cgit.freedesktop.org/libreoffice/online/log
+ make clear that no bugfixing is going on (Caolan)
   + real security issues / hazard here:
   + https://github.com/CollaboraOnline/online/security/advisories
+ and how to un-freeze it if wanted
   + support the idea to get some clarity here (Thorsten)
  + as one of the co-authors of the process - reminder we need to 
decide

if it small/medium/large
   + we might become something similar as ASF for OO if continues 
(Michael S)

   + size: between medium & large (Caolan)
  + agree (Thorsten)
  + initial thought it is large (Stephan B)
  + quite complex - JS + C++ - leaflet etc. (Michael M)
  + intimiately tied to core (Thorsten)
 + size: 1 small, 3 medium, 6 large
 + not sure tightness to core should count (Kendy)
+ project itself - C++/JS server-side quite large.
+ Atticization proposal evolved (Thorsten)
  + was one-size-fits all initially, thought for small projects too 
onerous

to require 3 devs, so - we had this three sizes added
   + consensus that it is at least medium sized (Thorsten)
  + little practical difference if 3-6 need to show up (Stephan B)
   * propose the "atticization" of LOOL
  + 9 - no concerns
  + 6 - abstain
  => passed.
=> AI: pass on to board (Stephan)

* Documentation (Olivier)
+ New Help, no news
 

[Libreoffice-bugs] [Bug 149490] multiple copies of Table Properties dialog can be opened from an undocked Table toolbar (docked is OK)

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149490

Rafael Lima  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #3 from Rafael Lima  ---
Indeed... now with the undocked toolbar I can confirm this bug using "win" and
"gen".

However it does not happen in "kf5".

I'm setting this to NEW, since the reported behavior should not be happenning.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149503] CRASH: Pasting content from sheet

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149503

Xisco Faulí  changed:

   What|Removed |Added

Version|6.1 all versions|5.4 all versions

--- Comment #3 from Xisco Faulí  ---
Started to happen in 5.4 branch

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149504] New: incorrect import/insertion of datetime value into Calc using ctrl-shift-alt-v (Date (YMD) format is selected)

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149504

Bug ID: 149504
   Summary: incorrect import/insertion of datetime value into Calc
using ctrl-shift-alt-v (Date (YMD) format is selected)
   Product: LibreOffice
   Version: 7.3.0.0 beta1+
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: minute.visit...@gmail.com

Description:
since version 7.3 it is not possible to insert datetime values from the
clipboard into Calc (using ctrl-shift-alt-v) as Date (YMD) format - they are
inserted as text. Values are inserted correctly only when the US English format
is selected.

Steps to Reproduce:
1.open Calc version 7.3 and later
2.copy the following data to the clipboard
2022-06-10 14:00:00.000 2022-06-10 14:00:00.000
2022-06-10 14:00:00.000 2022-06-10 14:00:00.000
2022-06-10 06:00:00.000 2022-06-10 14:00:00.000
2022-06-10 06:00:00.000 2022-06-10 14:00:00.000
2022-06-10 06:00:00.000 2022-06-10 14:00:00.000
3.use ctrl-shift-alt-v and select DATE (YMD) format


Actual Results:
values are inserted as text

Expected Results:
values are inserted correctly


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149135] Writer does not always apply styles correctly

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149135

Timur  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG

--- Comment #5 from Timur  ---
I close as NotABug. 

Maybe something else can be added to
https://wiki.documentfoundation.org/Faq/Writer/026.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149490] multiple copies of Table Properties dialog can be opened from an undocked Table toolbar (docked is OK)

2022-06-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149490

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED
Summary|multiple copies of Table|multiple copies of Table
   |Properties dialog can be|Properties dialog can be
   |opened from Table toolbar   |opened from an undocked
   ||Table toolbar  (docked is
   ||OK)

--- Comment #2 from sdc.bla...@youmail.dk ---
(In reply to Rafael Lima from comment #1)
> Can you check this again? 
Further testing (also in Safe Mode) reveals:

Table bar docked.  Only one copy (i.e., modal)  (OK)

Table bar undocked. Multiple copies  (NOK)

(changing summary)

-- 
You are receiving this mail because:
You are the assignee for the bug.

  1   2   3   >