[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - pyuno/source

[Stephan Bergmann (via logerrit)]

 pyuno/source/loader/pyuno_loader.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit b8ff07fd7dfcfaa344778a4a1a8ba4ff431c66c1
Author: Stephan Bergmann 
AuthorDate: Thu Jun 16 18:58:18 2022 +0200
Commit: Stephan Bergmann 
CommitDate: Fri Jun 17 07:17:56 2022 +0200

rhbz#2097411 Avoid obsolete PyThreadState_Delete crashing Python 3.11

1fb53a637597f76bea86514b62ddfad34f60c889 "pyuno_loader::CreateInstance: 
delete
the initial PyThreadState" had added the PyThreadState_Delete for claimed
benefits but whose details appear lost to history (cf. the comment thread
starting at


"pyuno_loader::CreateInstance: delete the initial PyThreadState").  And at 
least
a recent master Linux --enable-python=fully-internal build with the bundled
Python 3.8.12 appears to succeed `make check` just fine with the
PyThreadState_Delete temporarily removed.

But on the other hand, building against upcoming Python 3.11 now started to 
make
CppunitTest_services fail with

> Fatal Python error: init_threadstate: thread state already initialized
> Python runtime state: initialized
> Thread 0x81c8b020 (most recent call first):
>   
> Fatal exception: Signal 6
> Stack:
> 
/builddir/build/BUILD/libreoffice-7.3.4.2/instdir/program/libuno_sal.so.3(+0x37c28)[0x81be7c28]
> 
/builddir/build/BUILD/libreoffice-7.3.4.2/instdir/program/libuno_sal.so.3(+0x37e40)[0x81be7e40]
> linux-vdso.so.1(__kernel_rt_sigreturn+0x0)[0x81ccb7ec]
> /lib64/libc.so.6(+0x82878)[0x81742878]
> /lib64/libc.so.6(raise+0x20)[0x816fae00]
> /lib64/libc.so.6(abort+0xe8)[0x816e72b8]
> /lib64/libpython3.11.so.1.0(+0x104e28)[0xfffee4de4e28]
> /lib64/libpython3.11.so.1.0(+0x105200)[0xfffee4de5200]
> 
/lib64/libpython3.11.so.1.0(PyThread_get_thread_native_id+0x0)[0xfffee4ed6764]
> /lib64/libpython3.11.so.1.0(PyThreadState_New+0x14)[0xfffee4ed6628]
> 
/builddir/build/BUILD/libreoffice-7.3.4.2/instdir/program/libpyuno.so(_ZN5pyuno14PyThreadAttachC2EP3_is+0x78)[0xfffee4c8c52c]
> 
/builddir/build/BUILD/libreoffice-7.3.4.2/instdir/program/libpythonloaderlo.so(pyuno_Loader_get_implementation+0x5c)[0xfffee5243060]
> 
/builddir/build/BUILD/libreoffice-7.3.4.2/instdir/program/libuno_cppuhelpergcc3.so.3(+0x544b4)[0x815544b4]

because of the PyThreadState_Delete.  (The deleted PyThreadState, while not
reused again directly, is still recorded in the state obtained from
PyInterpreterState_Head() later.)

So conservatively keep the PyThreadState_Delete of unclear benefit for older
Python versions and only drop it for 3.11 where it is known to have negative
effects now.

Change-Id: I9b99f1e947f0b165ddc95c2bfbd764858dda39db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136006
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 
(cherry picked from commit e7bf4f8ccf2b2d8ed512ce8817394764a93e0a37)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136024

diff --git a/pyuno/source/loader/pyuno_loader.cxx 
b/pyuno/source/loader/pyuno_loader.cxx
index c9b8248c1b25..da0467f450c6 100644
--- a/pyuno/source/loader/pyuno_loader.cxx
+++ b/pyuno/source/loader/pyuno_loader.cxx
@@ -229,10 +229,12 @@ void pythonInit() {
 
 PyThreadState *tstate = PyThreadState_Get();
 PyEval_ReleaseThread( tstate );
+#if PY_VERSION_HEX < 0x030B
 // This tstate is never used again, so delete it here.
 // This prevents an assertion in PyThreadState_Swap on the
 // PyThreadAttach below.
 PyThreadState_Delete(tstate);
+#endif
 }
 
 }

[Libreoffice-commits] core.git: sc/source

[Julien Nabet (via logerrit)]

 sc/source/ui/vba/vbarange.cxx |7 ++-
 1 file changed, 2 insertions(+), 5 deletions(-)

New commits:
commit 0cea5d817434c5f7ccc8816f7f5e29a4ba95f8f0
Author: Julien Nabet 
AuthorDate: Thu Jun 16 21:06:37 2022 +0200
Commit: Julien Nabet 
CommitDate: Fri Jun 17 07:08:00 2022 +0200

Another "One call to XCellRangeAddressable::getRangeAddress() is enough"

See 
https://cgit.freedesktop.org/libreoffice/core/commit/?id=e44e418783d101c530c916db0b0f72c376188fdf

Change-Id: I1106d1777690c27b9e4765a3a94145bb73609005
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136005
Reviewed-by: Eike Rathke 
Tested-by: Jenkins

diff --git a/sc/source/ui/vba/vbarange.cxx b/sc/source/ui/vba/vbarange.cxx
index 99933f165c24..d94bd7b04a35 100644
--- a/sc/source/ui/vba/vbarange.cxx
+++ b/sc/source/ui/vba/vbarange.cxx
@@ -2657,11 +2657,8 @@ ScVbaRange::Resize( const uno::Any , const 
uno::Any  )
 xCursor->collapseToSize( nColumnSize, nRowSize );
 uno::Reference< sheet::XCellRangeAddressable > 
xCellRangeAddressable(xCursor, ::uno::UNO_QUERY_THROW );
 uno::Reference< table::XCellRange > xRange( xSheetRange->getSpreadsheet(), 
::uno::UNO_QUERY_THROW );
-return new ScVbaRange( mxParent, mxContext,xRange->getCellRangeByPosition(
-
xCellRangeAddressable->getRangeAddress().StartColumn,
-
xCellRangeAddressable->getRangeAddress().StartRow,
-
xCellRangeAddressable->getRangeAddress().EndColumn,
-
xCellRangeAddressable->getRangeAddress().EndRow ) );
+const table::CellRangeAddress aRA( 
xCellRangeAddressable->getRangeAddress());
+return new ScVbaRange( mxParent, mxContext, 
xRange->getCellRangeByPosition( aRA.StartColumn, aRA.StartRow, aRA.EndColumn, 
aRA.EndRow));
 }
 
 void

[Libreoffice-bugs] [Bug 145843] Incidental Crash on macOS with skia raster

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145843

Luboš Luňák  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 129062] [META] Skia library bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129062
Bug 129062 depends on bug 145843, which changed state.

Bug 145843 Summary: Incidental Crash on macOS with skia raster
https://bugs.documentfoundation.org/show_bug.cgi?id=145843

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145843] Incidental Crash on macOS with skia raster

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145843

--- Comment #24 from Commit Notification 
 ---
Luboš Luňák committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8a5beccc19b4fdffb7b82ba5fd26f4cf316d9811

handle GC* pixmap functions on Mac reading past pixmap (tdf#145843)

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/skia

[Luboš Luňák (via logerrit)]

 vcl/skia/osx/gdiimpl.cxx |   12 
 1 file changed, 12 insertions(+)

New commits:
commit 8a5beccc19b4fdffb7b82ba5fd26f4cf316d9811
Author: Luboš Luňák 
AuthorDate: Thu Jun 16 18:21:10 2022 +0200
Commit: Luboš Luňák 
CommitDate: Fri Jun 17 06:16:28 2022 +0200

handle GC* pixmap functions on Mac reading past pixmap (tdf#145843)

The code passes adjusted position for pixel data in order to create
a sub-rect of the pixmap without copying, but at least on Intel Mac
the GC* functions then try to read the entire pixel row even though
it shouldn't be necessary. Since that may cause reading past the
pixmap data if the last line is involved, use entire pixmap width
to avoid that.

Change-Id: Ia08059b363d39dd465b2cadde5138ee045628f59
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136003
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/vcl/skia/osx/gdiimpl.cxx b/vcl/skia/osx/gdiimpl.cxx
index 0c9ac5e9c14b..f8bcdd68352e 100644
--- a/vcl/skia/osx/gdiimpl.cxx
+++ b/vcl/skia/osx/gdiimpl.cxx
@@ -139,6 +139,18 @@ void AquaSkiaSalGraphicsImpl::flushSurfaceToScreenCG()
 // This creates the bitmap context from the cropped part, 
writable_addr32() will get
 // the first pixel of mDirtyRect.topLeft(), and using pixmap.rowBytes() 
ensures the following
 // pixel lines will be read from correct positions.
+if (pixmap.bounds() != mDirtyRect && pixmap.bounds().bottom() == 
mDirtyRect.bottom())
+{
+// HACK for tdf#145843: If mDirtyRect includes the last line but not 
the first pixel of it,
+// then the rowBytes() trick would lead to the GC* functions thinking 
that even pixels after
+// the pixmap data belong to the area (since the shifted 
x()+rowBytes() points there) and
+// at least on Intel Mac they would actually read those data, even 
though I see no good reason
+// to do that, as that's beyond the x()+width() for the last line. 
That could be handled
+// by creating a subset SkImage (which as is said above copies data), 
or set the x coordinate
+// to 0, which will then make rowBytes() match the actual data.
+mDirtyRect.fLeft = 0;
+assert(mDirtyRect.width() == pixmap.bounds().width());
+}
 CGContextRef context = CGBitmapContextCreate(
 pixmap.writable_addr32(mDirtyRect.x() * mScaling, mDirtyRect.y() * 
mScaling),
 mDirtyRect.width() * mScaling, mDirtyRect.height() * mScaling, 8, 
pixmap.rowBytes(),

[Libreoffice-bugs] [Bug 145843] Incidental Crash on macOS with skia raster

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145843

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.5.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 47057] EDITING: crash through inserting picture bigger than page

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=47057

--- Comment #2 from vaquezjohn  ---
Thank you for providing such valuable information. Your webpage is rather
appealing. The information on this page shocked me. https://retrobowl.games

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149109] Explain what "fresh" and "still" are in the AppImage download page

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149109

Dan Dascalescu  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|RESOLVED|REOPENED
 Resolution|NOTABUG |---

--- Comment #3 from Dan Dascalescu  ---
Scott, my report wasn't as much as request for help, but a bug to update
https://www.libreoffice.org/download/appimage/ to explain *for all subsequent
users* what those download types are.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149435] Implement ODF draw:glue-point-type for Custom Shapes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149435

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149427] Backwards incompatibility: table ids parsed from links to external HTML files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149427

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145717] The formatting of the cell is not copied if the font is set inside the cell for the text itself

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145717

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145717] The formatting of the cell is not copied if the font is set inside the cell for the text itself

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145717

--- Comment #4 from QA Administrators  ---
Dear ppae,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146302] Not possible to install help files Libroffice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146302

--- Comment #3 from QA Administrators  ---
Dear rramis1981,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145987] Writer typesets identically defined automatic and custom graphic-styles differently

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145987

--- Comment #9 from QA Administrators  ---
Dear Jambunathan K,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 131560] Data/Form provides access to cells that are protected

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131560

--- Comment #9 from QA Administrators  ---
Dear Paul Hodgson,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108373] Conditional formatting changes format of dates and numbers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108373

--- Comment #10 from QA Administrators  ---
Dear john4070,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 34438] [feature request, FORMATTING] group selection does not work with raster images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=34438

--- Comment #53 from dirk.meil...@gmail.com ---
I made an account on this platform for the sole purpose of adding this comment
to this thread. 
I found this when searching Why, Oh, Why I can't seem to perform the
mindbogglingly basic task of selecting two images at once -- despite LO Help
telling me Sure You Can!

Although I have not once ever, while using any software at all, run into a
problem with the primordial first function anything should have ('SELECTING'),
this has been a known 'bug' FOR OVER A FULL DECADE. 
SELECTING MORE THAN A SINGLE IMAGE. 10+ YEARS.

Y'all are the reason Open Source gets a bad rep.
Can I/do I need to pay someone to get cracking on this? Is there any progress
expected before - say - 2050? With SELECTING THINGS?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - helpcontent2

[Olivier Hallot (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b402e8c1d045590d8a814a496ab15ca51c384e76
Author: Olivier Hallot 
AuthorDate: Fri Jun 17 03:33:53 2022 +0200
Commit: Gerrit Code Review 
CommitDate: Fri Jun 17 03:33:53 2022 +0200

Update git submodules

* Update helpcontent2 from branch 'libreoffice-7-4'
  to 9c49f2a9e8140358395e423ccf1c07b7b4af1a15
  - Mute l10n

Change-Id: Icd723b9b933788c5ac9e1b2bbb9e541f241bdbe1
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136020
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 
(cherry picked from commit b01904aabf78c6981d4c3b3953483bea9e86c2b3)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136028
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/helpcontent2 b/helpcontent2
index 2823fbf593dc..9c49f2a9e814 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 2823fbf593dc4f9d87f3d14731bf997cc7de7deb
+Subproject commit 9c49f2a9e8140358395e423ccf1c07b7b4af1a15

[Libreoffice-commits] help.git: Branch 'libreoffice-7-4' - source/text

[Olivier Hallot (via logerrit)]

 source/text/shared/01/0220.xhp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 9c49f2a9e8140358395e423ccf1c07b7b4af1a15
Author: Olivier Hallot 
AuthorDate: Thu Jun 16 21:25:34 2022 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Fri Jun 17 03:33:52 2022 +0200

Mute l10n

Change-Id: Icd723b9b933788c5ac9e1b2bbb9e541f241bdbe1
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136020
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 
(cherry picked from commit b01904aabf78c6981d4c3b3953483bea9e86c2b3)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136028
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/source/text/shared/01/0220.xhp 
b/source/text/shared/01/0220.xhp
index 25e9464d9..b7f4622fd 100644
--- a/source/text/shared/01/0220.xhp
+++ b/source/text/shared/01/0220.xhp
@@ -36,7 +36,7 @@
 
 
 
-
+
 
 
 Resizes the object to the original size.

[Libreoffice-bugs] [Bug 149018] "Object" property dialog (and Navigator and UI elements) should be retitled "OLE Object"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149018

--- Comment #36 from Commit Notification 
 ---
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/help/commit/2823fbf593dc4f9d87f3d14731bf997cc7de7deb

(related)tdf#138844, (related)tdf#149018  "Type"  -> "Position and Size"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - helpcontent2

[Seth Chaiklin (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit bad63ab71226eb768fd390dae1e78f215196f2e2
Author: Seth Chaiklin 
AuthorDate: Fri Jun 17 03:23:35 2022 +0200
Commit: Gerrit Code Review 
CommitDate: Fri Jun 17 03:23:35 2022 +0200

Update git submodules

* Update helpcontent2 from branch 'libreoffice-7-4'
  to 2823fbf593dc4f9d87f3d14731bf997cc7de7deb
  - (related)tdf#138844, (related)tdf#149018  "Type"  -> "Position and Size"

  tdf#138844 changed the "Type" tab in the Properties dialog for Image
  and Frame to be labeled "Position and Size" and tdf#149018 did the
  same change for OLE Object. This patch updates relevant help pages to
  reflect the change in the tab name.

Change-Id: Ieb8f1f6947b59638a713e583d2bb9a174b8815a2
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136026
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 
(cherry picked from commit 9827b5c7c1e4da68b704e59382a6b46d0c252136)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136027

diff --git a/helpcontent2 b/helpcontent2
index 907f876a9a0a..2823fbf593dc 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 907f876a9a0ab822fe6a67ab779ca03f4134e4d5
+Subproject commit 2823fbf593dc4f9d87f3d14731bf997cc7de7deb

[Libreoffice-commits] help.git: Branch 'libreoffice-7-4' - source/text

[Seth Chaiklin (via logerrit)]

 source/text/swriter/00/0405.xhp |8 
 source/text/swriter/01/05060100.xhp |6 +++---
 2 files changed, 7 insertions(+), 7 deletions(-)

New commits:
commit 2823fbf593dc4f9d87f3d14731bf997cc7de7deb
Author: Seth Chaiklin 
AuthorDate: Fri Jun 17 00:42:38 2022 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Fri Jun 17 03:23:34 2022 +0200

(related)tdf#138844, (related)tdf#149018  "Type"  -> "Position and Size"

  tdf#138844 changed the "Type" tab in the Properties dialog for Image
  and Frame to be labeled "Position and Size" and tdf#149018 did the
  same change for OLE Object. This patch updates relevant help pages to
  reflect the change in the tab name.

Change-Id: Ieb8f1f6947b59638a713e583d2bb9a174b8815a2
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136026
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 
(cherry picked from commit 9827b5c7c1e4da68b704e59382a6b46d0c252136)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136027

diff --git a/source/text/swriter/00/0405.xhp 
b/source/text/swriter/00/0405.xhp
index c9dad60a6..67f47711c 100644
--- a/source/text/swriter/00/0405.xhp
+++ b/source/text/swriter/00/0405.xhp
@@ -130,10 +130,10 @@
  
   
   
- Choose Format - Image - Properties - Type 
tab.
- Choose Format - Frame and Object - Properties - 
Type tab.UFI: removed some lines with 
Format-Object, see #i64150
-Choose 
View - Styles - open context menu Modify/New - Type 
tab.
- Choose Insert - Frame - Frame - Type 
tab.
+ Choose Format - Image - Properties - Position and 
Size tab.
+ Choose Format - Frame and Object - Properties - 
Position and Size tab.UFI: removed some lines 
with Format-Object, see #i64150
+Choose 
View - Styles - Frame Styles - open context menu 
Modify/New - Type tab.
+ Choose Insert - Frame - Frame - Position and 
Size tab.
   
   
  Choose Format - Image - Properties - Wrap 
tab.
diff --git a/source/text/swriter/01/05060100.xhp 
b/source/text/swriter/01/05060100.xhp
index 465692745..098d2c9ba 100644
--- a/source/text/swriter/01/05060100.xhp
+++ b/source/text/swriter/01/05060100.xhp
@@ -20,7 +20,7 @@
 
 
   
-Type
+Position and Size
 /text/swriter/01/05060100.xhp
   
 
@@ -32,8 +32,8 @@
 UFI: new index entries, see i54237
 
 
-Type
-Specifies the size and the position of the selected object or frame on 
a page.
+Position and Size
+Specifies the size and the position of the selected image, frame, or 
OLE object on a page.
   
   
 

[Libreoffice-bugs] [Bug 149018] "Object" property dialog (and Navigator and UI elements) should be retitled "OLE Object"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149018

--- Comment #35 from Commit Notification 
 ---
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/9f035d777141d5f039a85d6f64b627eaf73b8079

(related)tdf#138844, (related)tdf#149018  "Type"  -> "Position and Size"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: helpcontent2

[Seth Chaiklin (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 9ace7e3a6c2ebb8311a8277e05564953480aa3bc
Author: Seth Chaiklin 
AuthorDate: Fri Jun 17 03:22:15 2022 +0200
Commit: Gerrit Code Review 
CommitDate: Fri Jun 17 03:22:15 2022 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to 9f035d777141d5f039a85d6f64b627eaf73b8079
  - (related)tdf#138844, (related)tdf#149018  "Type"  -> "Position and Size"

  tdf#138844 changed the "Type" tab in the Properties dialog for Image
  and Frame to be labeled "Position and Size" and tdf#149018 did the
  same change for OLE Object. This patch updates relevant help pages to
  reflect the change in the tab name.

Change-Id: Ieb8f1f6947b59638a713e583d2bb9a174b8815a2
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136026
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/helpcontent2 b/helpcontent2
index b01904aabf78..9f035d777141 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit b01904aabf78c6981d4c3b3953483bea9e86c2b3
+Subproject commit 9f035d777141d5f039a85d6f64b627eaf73b8079

[Libreoffice-commits] help.git: source/text

[Seth Chaiklin (via logerrit)]

 source/text/swriter/00/0405.xhp |8 
 source/text/swriter/01/05060100.xhp |6 +++---
 2 files changed, 7 insertions(+), 7 deletions(-)

New commits:
commit 9f035d777141d5f039a85d6f64b627eaf73b8079
Author: Seth Chaiklin 
AuthorDate: Fri Jun 17 00:42:38 2022 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Fri Jun 17 03:22:14 2022 +0200

(related)tdf#138844, (related)tdf#149018  "Type"  -> "Position and Size"

  tdf#138844 changed the "Type" tab in the Properties dialog for Image
  and Frame to be labeled "Position and Size" and tdf#149018 did the
  same change for OLE Object. This patch updates relevant help pages to
  reflect the change in the tab name.

Change-Id: Ieb8f1f6947b59638a713e583d2bb9a174b8815a2
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136026
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/source/text/swriter/00/0405.xhp 
b/source/text/swriter/00/0405.xhp
index c9dad60a6..67f47711c 100644
--- a/source/text/swriter/00/0405.xhp
+++ b/source/text/swriter/00/0405.xhp
@@ -130,10 +130,10 @@
  
   
   
- Choose Format - Image - Properties - Type 
tab.
- Choose Format - Frame and Object - Properties - 
Type tab.UFI: removed some lines with 
Format-Object, see #i64150
-Choose 
View - Styles - open context menu Modify/New - Type 
tab.
- Choose Insert - Frame - Frame - Type 
tab.
+ Choose Format - Image - Properties - Position and 
Size tab.
+ Choose Format - Frame and Object - Properties - 
Position and Size tab.UFI: removed some lines 
with Format-Object, see #i64150
+Choose 
View - Styles - Frame Styles - open context menu 
Modify/New - Type tab.
+ Choose Insert - Frame - Frame - Position and 
Size tab.
   
   
  Choose Format - Image - Properties - Wrap 
tab.
diff --git a/source/text/swriter/01/05060100.xhp 
b/source/text/swriter/01/05060100.xhp
index 465692745..098d2c9ba 100644
--- a/source/text/swriter/01/05060100.xhp
+++ b/source/text/swriter/01/05060100.xhp
@@ -20,7 +20,7 @@
 
 
   
-Type
+Position and Size
 /text/swriter/01/05060100.xhp
   
 
@@ -32,8 +32,8 @@
 UFI: new index entries, see i54237
 
 
-Type
-Specifies the size and the position of the selected object or frame on 
a page.
+Position and Size
+Specifies the size and the position of the selected image, frame, or 
OLE object on a page.
   
   
 

[Libreoffice-bugs] [Bug 104877] Implement support for filter import and playback of animated PNG -- APNG

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104877

--- Comment #10 from Maverick  ---
I would like to say I prefer the use of apng over to webp because of it's
better compression and performance.

As to it being officially supported by the png group that will most likely
never happen (I would say 99.9% sure).

But it's supported by every major browser and one can use .apng for animated as
opposed to .png for static.

I would also like to leave A very interesting link about performance and
compression comparison:

http://littlesvr.ca/apng/gif_apng_webp.html

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104877] Implement support for filter import and playback of animated PNG -- APNG

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104877

Maverick  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||4532

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 114532] add support for WEBP image reading (image import and inside .ods/.odt)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114532

Maverick  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||4877

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148569] Character highlighting: custom color color picker shows wrong colors with Skia raster on macOS

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148569

--- Comment #5 from Aron Budea  ---
Happens with Skia/Metal as well. And only the large color area and the color
band has wrong color, the small color preview in the bottom left corner and the
actual color that is used in the end are both correct.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 54857] FILEOPEN: slow opening, 2Mb .PPT file opens several minutes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=54857

--- Comment #22 from paulyste...@web.de ---
Still reproduced

Small bug examples 1:30 also.

Version: 7.3.4.2 (x64) / LibreOffice Community
Build ID: 728fec16bd5f605073805c3c9e7c4212a0120dc5
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 70710] [WMF/EMF/EMF+] FILEOPEN Filled areas are not filled for WMF images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=70710

--- Comment #31 from paulyste...@web.de ---
Version: 7.3.4.2 (x64) / LibreOffice Community
Build ID: 728fec16bd5f605073805c3c9e7c4212a0120dc5
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL

same like in 7.2.0.2

updated WMF is also ok in 7.3.4.2 win64 

workaround WMF to EMF in Irfanview is also ok.

original WMF also in 7.3.4.2 with the same limitations as before.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 120708] Error rendering different page sizes and orientation when importing PDF files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120708

--- Comment #13 from paulyste...@web.de ---
Maximum paper size of masterpiece in user mode is quadratic area 600 cm to 600
cm.

So different sizes of papers should be possible.

Work around is import of pdf by different draw files with their sizes.

PDF can also divised before in different pdf their format.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149390] From Insert Hyperlink... (to Document), search doesn't drill down

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149390

--- Comment #5 from lblyt...@gmail.com ---
Thanks Caolán! That was it. Ubuntu 22.04 provides gtk3-3.24.33; as you
suggested, it shows the same problem with gedit, Firefox etc which also use
GtkFileChooser. Googling:

  gtk file chooser search

shows the problem goes back a while and is still present even in GTK4 (which
Gnome isn't fully ported to yet anyway). Most likely culprit seems to be that
GtkFileChooser isn't built against Gnome Tracker by default. There's a patch
for that (which, from your report that behaviour's OK in gtk3-3.24.34, may be
included now). I won't build GTK from source just to get it; I'll wait for
Ubuntu 22.04 to update to gtk3-3.24.34 which sounds like it'll fix the issue.
Thanks again.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143249] Improve configuration of table borders

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143249

--- Comment #37 from LeroyG  ---
(In reply to Heiko Tietze from comment #35)
> [...] toggle buttons for all 12 options plus some combined defaults.

For me, it is better.

And, maybe, add a Reset button like in other dialogs.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 88278] [META] SVG import image filter (all modules)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88278
Bug 88278 depends on bug 101083, which changed state.

Bug 101083 Summary: Insert SVG with too small scaling causes LibreOffice to 
hang, consuming 100% cpu
https://bugs.documentfoundation.org/show_bug.cgi?id=101083

   What|Removed |Added

 Status|VERIFIED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 101083] Insert SVG with too small scaling causes LibreOffice to hang, consuming 100% cpu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101083

paulyste...@web.de changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|VERIFIED|REOPENED

--- Comment #25 from paulyste...@web.de ---
SVG-import of examples hangs in 7.3.4.2


Version: 7.3.4.2 (x64) / LibreOffice Community
Build ID: 728fec16bd5f605073805c3c9e7c4212a0120dc5
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149590] LibreOffice Writer 7.2.4.1 or later hangs under macOS 10.13.6 (High Sierra)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149590

--- Comment #1 from kevbu...@gmail.com ---
Created attachment 180802
  --> https://bugs.documentfoundation.org/attachment.cgi?id=180802=edit
Report generated by MacOS upon force-quit of unresponive application.

I do not know if this information will be helpful.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149590] New: LibreOffice Writer 7.2.4.1 or later hangs under macOS 10.13.6 (High Sierra)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149590

Bug ID: 149590
   Summary: LibreOffice Writer 7.2.4.1 or later hangs under macOS
10.13.6 (High Sierra)
   Product: LibreOffice
   Version: 7.2.4.1 release
  Hardware: x86-64 (AMD64)
OS: macOS (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kevbu...@gmail.com

Description:
LibreOffice Writer 7.2.4.1 (7.2.0.x?) or later, including v7.2.7.2 and
v7.3.4.2, becomes unresponsive under macOS 10.13.6, either immediately upon, or
within a few minutes of, opening or creating a document, independently of
actions taken on the document. LibreOffice Writer 7.1.8.1 functions normally;
have the more recent versions been tested under macOS X 10.13.6?

Steps to Reproduce:
1.Launch LibreOffice
2.Open or create a Writer document
3.Wait

Actual Results:
LibreOffice becomes unresponsive, meaning the macOS cursor becomes a spinning
pinwheel.

Expected Results:
LibreOffice should remain responsive.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
>From menu LibreOffice – About LibreOffice:
Version: 7.2x and 7.3x / LibreOffice Community
Build:   many
User Interface: UI render: default; VCL: osx
Locale:  en-US (en_US.UTF-8); UI: en-US
Misc: Calc: threader

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sc/inc sc/source

[Eike Rathke (via logerrit)]

 sc/inc/listenercalls.hxx  |6 --
 sc/source/ui/unoobj/listenercalls.cxx |2 +-
 2 files changed, 5 insertions(+), 3 deletions(-)

New commits:
commit b137bbe994cf5b23128c27fc65866406c32bec8b
Author: Eike Rathke 
AuthorDate: Thu Jun 16 21:44:40 2022 +0200
Commit: Eike Rathke 
CommitDate: Thu Jun 16 23:30:00 2022 +0200

Resolves: tdf#147822 ScUnoListenerEntry container must be std::list

... instead of std::vector to not get invalidated iterators when
the container is resized.

Regression from

commit f8defe59ff75df2b516ee407f1dac22b0ac72a19
CommitDate: Wed Sep 6 22:45:10 2017 +0200

Replace some lists by vectors in unoobj (sc)

which was bad for this case.

Change-Id: I8d3a001242865cadc82b359a3198906d26373a41
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136007
Reviewed-by: Eike Rathke 
Tested-by: Jenkins
(cherry picked from commit 7eda1a7346677fc85a6a3fd5e16adcb4590d7b03)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136022

diff --git a/sc/inc/listenercalls.hxx b/sc/inc/listenercalls.hxx
index ff835a048b1a..acb009937fa1 100644
--- a/sc/inc/listenercalls.hxx
+++ b/sc/inc/listenercalls.hxx
@@ -19,7 +19,7 @@
 
 #pragma once
 
-#include 
+#include 
 #include 
 #include 
 
@@ -48,7 +48,9 @@ struct ScUnoListenerEntry
 class ScUnoListenerCalls
 {
 private:
-::std::vector aEntries;
+// Must be list, not vector, to not invalidate iterators, see
+// ExecuteAndClear() implementation.
+::std::list aEntries;
 
 public:
 ScUnoListenerCalls();
diff --git a/sc/source/ui/unoobj/listenercalls.cxx 
b/sc/source/ui/unoobj/listenercalls.cxx
index 2d9a23083ca8..7ff7c7df0956 100644
--- a/sc/source/ui/unoobj/listenercalls.cxx
+++ b/sc/source/ui/unoobj/listenercalls.cxx
@@ -44,7 +44,7 @@ void ScUnoListenerCalls::ExecuteAndClear()
 //  During each modified() call, Add may be called again.
 //  These new calls are executed here, too.
 
-std::vector::iterator aItr(aEntries.begin());
+std::list::iterator aItr(aEntries.begin());
 while (aItr != aEntries.end())
 {
 ScUnoListenerEntry aEntry = *aItr;

[Libreoffice-bugs] [Bug 149589] Calc fails to open context menu in edit-mode for some cell contents (breaks spell checker and other features)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149589

--- Comment #2 from m.a.riosv  ---
When beginning with a minus '-' or a plus '+'.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149589] Calc fails to open context menu in edit-mode for some cell contents (breaks spell checker and other features)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149589

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from m.a.riosv  ---
Repro.
The issue looks relative, with the text beginning with a hyphen.

Version: 7.3.4.2 (x64) / LibreOffice Community
Build ID: 728fec16bd5f605073805c3c9e7c4212a0120dc5
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107742] [META] Form control bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107742
Bug 107742 depends on bug 147822, which changed state.

Bug 147822 Summary: LO Calc with RadioButton Crash in: 
ScUnoListenerCalls::ExecuteAndClear() - steps Comment 22
https://bugs.documentfoundation.org/show_bug.cgi?id=147822

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: pyuno/source

[Stephan Bergmann (via logerrit)]

 pyuno/source/loader/pyuno_loader.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 1638b4f78af70b7b97d0a081ed51390dd87bf1f9
Author: Stephan Bergmann 
AuthorDate: Thu Jun 16 18:58:18 2022 +0200
Commit: Stephan Bergmann 
CommitDate: Thu Jun 16 22:40:28 2022 +0200

rhbz#2097411 Avoid obsolete PyThreadState_Delete crashing Python 3.11

1fb53a637597f76bea86514b62ddfad34f60c889 "pyuno_loader::CreateInstance: 
delete
the initial PyThreadState" had added the PyThreadState_Delete for claimed
benefits but whose details appear lost to history (cf. the comment thread
starting at


"pyuno_loader::CreateInstance: delete the initial PyThreadState").  And at 
least
a recent master Linux --enable-python=fully-internal build with the bundled
Python 3.8.12 appears to succeed `make check` just fine with the
PyThreadState_Delete temporarily removed.

But on the other hand, building against upcoming Python 3.11 now started to 
make
CppunitTest_services fail with

> Fatal Python error: init_threadstate: thread state already initialized
> Python runtime state: initialized
> Thread 0x81c8b020 (most recent call first):
>   
> Fatal exception: Signal 6
> Stack:
> 
/builddir/build/BUILD/libreoffice-7.3.4.2/instdir/program/libuno_sal.so.3(+0x37c28)[0x81be7c28]
> 
/builddir/build/BUILD/libreoffice-7.3.4.2/instdir/program/libuno_sal.so.3(+0x37e40)[0x81be7e40]
> linux-vdso.so.1(__kernel_rt_sigreturn+0x0)[0x81ccb7ec]
> /lib64/libc.so.6(+0x82878)[0x81742878]
> /lib64/libc.so.6(raise+0x20)[0x816fae00]
> /lib64/libc.so.6(abort+0xe8)[0x816e72b8]
> /lib64/libpython3.11.so.1.0(+0x104e28)[0xfffee4de4e28]
> /lib64/libpython3.11.so.1.0(+0x105200)[0xfffee4de5200]
> 
/lib64/libpython3.11.so.1.0(PyThread_get_thread_native_id+0x0)[0xfffee4ed6764]
> /lib64/libpython3.11.so.1.0(PyThreadState_New+0x14)[0xfffee4ed6628]
> 
/builddir/build/BUILD/libreoffice-7.3.4.2/instdir/program/libpyuno.so(_ZN5pyuno14PyThreadAttachC2EP3_is+0x78)[0xfffee4c8c52c]
> 
/builddir/build/BUILD/libreoffice-7.3.4.2/instdir/program/libpythonloaderlo.so(pyuno_Loader_get_implementation+0x5c)[0xfffee5243060]
> 
/builddir/build/BUILD/libreoffice-7.3.4.2/instdir/program/libuno_cppuhelpergcc3.so.3(+0x544b4)[0x815544b4]

because of the PyThreadState_Delete.  (The deleted PyThreadState, while not
reused again directly, is still recorded in the state obtained from
PyInterpreterState_Head() later.)

So conservatively keep the PyThreadState_Delete of unclear benefit for older
Python versions and only drop it for 3.11 where it is known to have negative
effects now.

Change-Id: I9b99f1e947f0b165ddc95c2bfbd764858dda39db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136006
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/pyuno/source/loader/pyuno_loader.cxx 
b/pyuno/source/loader/pyuno_loader.cxx
index c9b8248c1b25..da0467f450c6 100644
--- a/pyuno/source/loader/pyuno_loader.cxx
+++ b/pyuno/source/loader/pyuno_loader.cxx
@@ -229,10 +229,12 @@ void pythonInit() {
 
 PyThreadState *tstate = PyThreadState_Get();
 PyEval_ReleaseThread( tstate );
+#if PY_VERSION_HEX < 0x030B
 // This tstate is never used again, so delete it here.
 // This prevents an assertion in PyThreadState_Swap on the
 // PyThreadAttach below.
 PyThreadState_Delete(tstate);
+#endif
 }
 
 }

[Libreoffice-commits] core.git: sc/inc sc/source

[Eike Rathke (via logerrit)]

 sc/inc/listenercalls.hxx  |6 --
 sc/source/ui/unoobj/listenercalls.cxx |2 +-
 2 files changed, 5 insertions(+), 3 deletions(-)

New commits:
commit 7a0a0e23b7e81c1ee0601824a4ee990a2178f98b
Author: Eike Rathke 
AuthorDate: Thu Jun 16 21:44:40 2022 +0200
Commit: Eike Rathke 
CommitDate: Thu Jun 16 22:39:38 2022 +0200

Resolves: tdf#147822 ScUnoListenerEntry container must be std::list

... instead of std::vector to not get invalidated iterators when
the container is resized.

Regression from

commit f8defe59ff75df2b516ee407f1dac22b0ac72a19
CommitDate: Wed Sep 6 22:45:10 2017 +0200

Replace some lists by vectors in unoobj (sc)

which was bad for this case.

Change-Id: I8d3a001242865cadc82b359a3198906d26373a41
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136007
Reviewed-by: Eike Rathke 
Tested-by: Jenkins

diff --git a/sc/inc/listenercalls.hxx b/sc/inc/listenercalls.hxx
index ff835a048b1a..acb009937fa1 100644
--- a/sc/inc/listenercalls.hxx
+++ b/sc/inc/listenercalls.hxx
@@ -19,7 +19,7 @@
 
 #pragma once
 
-#include 
+#include 
 #include 
 #include 
 
@@ -48,7 +48,9 @@ struct ScUnoListenerEntry
 class ScUnoListenerCalls
 {
 private:
-::std::vector aEntries;
+// Must be list, not vector, to not invalidate iterators, see
+// ExecuteAndClear() implementation.
+::std::list aEntries;
 
 public:
 ScUnoListenerCalls();
diff --git a/sc/source/ui/unoobj/listenercalls.cxx 
b/sc/source/ui/unoobj/listenercalls.cxx
index 2d9a23083ca8..7ff7c7df0956 100644
--- a/sc/source/ui/unoobj/listenercalls.cxx
+++ b/sc/source/ui/unoobj/listenercalls.cxx
@@ -44,7 +44,7 @@ void ScUnoListenerCalls::ExecuteAndClear()
 //  During each modified() call, Add may be called again.
 //  These new calls are executed here, too.
 
-std::vector::iterator aItr(aEntries.begin());
+std::list::iterator aItr(aEntries.begin());
 while (aItr != aEntries.end())
 {
 ScUnoListenerEntry aEntry = *aItr;

[Libreoffice-bugs] [Bug 148833] [FILEOPEN] QPW dropping sheets

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148833

--- Comment #3 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated today, I could reproduce this.

Just for info, it uses libwps lib.
Beginning of logs:
./soffice /tmp/q10test.qpw 
WPSDocument::isFileFormatSupported()
WPSHeader::constructHeader: find a Quatto Pro qpw spreadsheet
Throwing InvalidHeaderException
Throwing InvalidHeaderException
WPSDocument::isFileFormatSupported()
WPSHeader::constructHeader: find a Quatto Pro qpw spreadsheet
warn:oox.storage:1308993:1308993:oox/source/helper/zipstorage.cxx:68:
ZipStorage::ZipStorage exception opening input storage
com.sun.star.io.IOException message: "at
/home/julien/lo/libreoffice/package/source/xstor/xfactory.cxx:260"
warn:oox:1308993:1308993:oox/source/crypto/DocumentDecryption.cxx:166:
Encrypted package does not contain DataSpaceMap
Throwing InvalidHeaderException
WPSDocument::isFileFormatSupported()
WPSHeader::constructHeader: find a Quatto Pro qpw spreadsheet
Throwing InvalidHeaderException
AbiDocument::isFileFormatSupported
Found xml parser severity error Document is empty

WPSDocument::isFileFormatSupported()
WPSHeader::constructHeader: find a Quatto Pro qpw spreadsheet
PageSpan::get: can not find a master page name
...

But I don't know where's the 256 sheets limit.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: helpcontent2

[Olivier Hallot (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e247d62ea65f269d8ec304e08d21796a1cc52c52
Author: Olivier Hallot 
AuthorDate: Thu Jun 16 21:32:09 2022 +0200
Commit: Gerrit Code Review 
CommitDate: Thu Jun 16 21:32:09 2022 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to b01904aabf78c6981d4c3b3953483bea9e86c2b3
  - Mute l10n

Change-Id: Icd723b9b933788c5ac9e1b2bbb9e541f241bdbe1
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136020
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 51cfc9a957ee..b01904aabf78 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 51cfc9a957eec7be595e8b667a528cbe749992a0
+Subproject commit b01904aabf78c6981d4c3b3953483bea9e86c2b3

[Libreoffice-commits] help.git: source/text

[Olivier Hallot (via logerrit)]

 source/text/shared/01/0220.xhp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b01904aabf78c6981d4c3b3953483bea9e86c2b3
Author: Olivier Hallot 
AuthorDate: Thu Jun 16 21:25:34 2022 +0200
Commit: Olivier Hallot 
CommitDate: Thu Jun 16 21:32:07 2022 +0200

Mute l10n

Change-Id: Icd723b9b933788c5ac9e1b2bbb9e541f241bdbe1
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136020
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/shared/01/0220.xhp 
b/source/text/shared/01/0220.xhp
index 25e9464d9..b7f4622fd 100644
--- a/source/text/shared/01/0220.xhp
+++ b/source/text/shared/01/0220.xhp
@@ -36,7 +36,7 @@
 
 
 
-
+
 
 
 Resizes the object to the original size.

[Libreoffice-bugs] [Bug 149089] FILEOPEN: docx: get extra mini space between Chinese character when open docx file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149089

--- Comment #10 from Commit Notification 
 ---
Mark Hung committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/b345858e92351ceb997cf8e77024d7fe573a99c6

tdf#149089 snap to grid if IsSnapToChars() is false

It will be available in 7.4.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149089] FILEOPEN: docx: get extra mini space between Chinese character when open docx file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149089

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.4.0 target:7.5.0   |target:7.4.0 target:7.5.0
   ||target:7.4.0.0.beta2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sw/qa sw/source

[Mark Hung (via logerrit)]

 sw/qa/extras/uiwriter/uiwriter7.cxx |   19 ++-
 sw/source/core/text/itrform2.cxx|   13 -
 2 files changed, 22 insertions(+), 10 deletions(-)

New commits:
commit b345858e92351ceb997cf8e77024d7fe573a99c6
Author: Mark Hung 
AuthorDate: Sat Jun 11 19:52:28 2022 +0800
Commit: Xisco Fauli 
CommitDate: Thu Jun 16 21:15:29 2022 +0200

tdf#149089 snap to grid if IsSnapToChars() is false

for non-CJK scripts. Non Asian text was centered within as many cells
as required according to ODF1.2 20.301. But it also required that
text should be snapped to grid if style:layout-grid-snap-to is
true ( i.e. IsSnapToChars() is false ) per ODF1.2 20.305. That means
ODF1.2 20.301 ruled.

This patch changes the width of inserted SwKernGridPortion so that
non-CJK text aligns to the edge of text grid to make ODF1.2 20.301
rule, an provide more consistent layout result as expected.

Change-Id: Id6b4d2b965e20670eb9ddf657d36b8a49073f32a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135654
Tested-by: Jenkins
Reviewed-by: Mark Hung 
(cherry picked from commit 47eff9bf12abf963907b4d3dcb90b73e0ccc646d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135984
Reviewed-by: Xisco Fauli 

diff --git a/sw/qa/extras/uiwriter/uiwriter7.cxx 
b/sw/qa/extras/uiwriter/uiwriter7.cxx
index 8b5a23d1a695..0ac6b0183068 100644
--- a/sw/qa/extras/uiwriter/uiwriter7.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter7.cxx
@@ -2779,11 +2779,20 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest7, testTdf149089)
 {
 createSwDoc(DATA_DIRECTORY, "tdf149089.odt");
 xmlDocUniquePtr pXmlDoc = parseLayoutDump();
-sal_Int32 nTextPortionWidth = getXPath(pXmlDoc, "(//SwLinePortion)[1]", 
"width").toInt32();
-sal_Int32 nKernPortionWidth = getXPath(pXmlDoc, "(//SwLinePortion)[2]", 
"width").toInt32();
-// nKernPortionWidth was about 1/3 of nTextPortionWidth
-double nRatio = double(nKernPortionWidth) / nTextPortionWidth;
-CPPUNIT_ASSERT_LESS(0.05, nRatio);
+sal_Int32 nPorLen1 = getXPath(pXmlDoc, "(//SwLinePortion)[1]", 
"length").toInt32();
+sal_Int32 nPorLen2 = getXPath(pXmlDoc, "(//SwLinePortion)[2]", 
"length").toInt32();
+sal_Int32 nPorLen3 = getXPath(pXmlDoc, "(//SwLinePortion)[3]", 
"length").toInt32();
+// Two SwTextPortion and one SwKernPortion
+CPPUNIT_ASSERT_EQUAL(sal_Int32(3), nPorLen1); // SwTextPortion 
" "
+CPPUNIT_ASSERT_EQUAL(sal_Int32(12), nPorLen2); // SwTextPortion "BUG 
"
+CPPUNIT_ASSERT_EQUAL(sal_Int32(0), nPorLen3); // SwKernPortion
+
+sal_Int32 nPorWidth1 = getXPath(pXmlDoc, "(//SwLinePortion)[1]", 
"width").toInt32();
+sal_Int32 nPorWidth2 = getXPath(pXmlDoc, "(//SwLinePortion)[2]", 
"width").toInt32();
+sal_Int32 nPorWidth3 = getXPath(pXmlDoc, "(//SwLinePortion)[3]", 
"width").toInt32();
+sal_Int32 nGridWidth1 = nPorWidth1 / 3;
+sal_Int32 nGridWidth2 = (nPorWidth2 + nPorWidth3) / 7;
+CPPUNIT_ASSERT_EQUAL(nGridWidth1, nGridWidth2);
 }
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sw/source/core/text/itrform2.cxx b/sw/source/core/text/itrform2.cxx
index e7bcde5983b8..563ddd5c4c02 100644
--- a/sw/source/core/text/itrform2.cxx
+++ b/sw/source/core/text/itrform2.cxx
@@ -686,15 +686,18 @@ void SwTextFormatter::BuildPortions( SwTextFormatInfo 
 )
  0;
 const SwTwips nTmpWidth = i * nGridWidth;
 const SwTwips nKernWidth = std::min(nTmpWidth - nSumWidth, 
nRestWidth);
-const SwTwips nKernWidth_1 = nKernWidth / 2;
+const SwTwips nKernWidth_1 = pGrid->IsSnapToChars() ?
+nKernWidth / 2 : 0;
 
 OSL_ENSURE( nKernWidth <= nRestWidth,
 "Not enough space left for adjusting non-asian text in 
grid mode" );
+if (nKernWidth_1)
+{
+pGridKernPortion->Width( pGridKernPortion->Width() + 
nKernWidth_1 );
+rInf.X( rInf.X() + nKernWidth_1 );
+}
 
-pGridKernPortion->Width( pGridKernPortion->Width() + 
nKernWidth_1 );
-rInf.X( rInf.X() + nKernWidth_1 );
-
-if ( ! bFull )
+if ( ! bFull && nKernWidth - nKernWidth_1 > 0 )
 new SwKernPortion( *pPor, static_cast(nKernWidth - 
nKernWidth_1),
false, true );
 

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sw/qa sw/source

[Miklos Vajna (via logerrit)]

 sw/qa/extras/htmlexport/htmlexport.cxx  |   41 
 sw/source/filter/html/htmlatr.cxx   |   12 +++--
 sw/source/filter/html/htmlnumwriter.cxx |4 ++-
 sw/source/filter/html/wrthtml.hxx   |3 +-
 4 files changed, 56 insertions(+), 4 deletions(-)

New commits:
commit e1168fac4c7164454b679d4114f348a005efbcee
Author: Miklos Vajna 
AuthorDate: Thu Jun 16 15:55:23 2022 +0200
Commit: Xisco Fauli 
CommitDate: Thu Jun 16 21:14:58 2022 +0200

sw HTML export, XHTML mode: fix lost  with a list header + item

There is a general mismatch between XHTML and Writer lists: XHTML can
only contain list items (for ordered or unordered lists), while Writer
can contain list headers and list items. List headers have no bullet or
number at the start, list items are the normal text nodes.

Commit 8c2607ae3ce143586e623532b8ae5288277ec3ac (sw HTML export, XHTML
mode: fix lost  when last list item is not numbered, 2022-02-21)
fixed the list item end side of this problem: if all text nodes in a
list are headers, then don't write ul/ol at all, otherwise end list
headers with  as well to make sure the output XML is valid.
However, this created a mis-match, the starting  for list headers in
a list which have non-header text nodes at as was not adapted.

Fix the problem by extending OutHTML_SwFormat() so list headers in a
list with non-header text nodes always have a  and , and this
condition is the same on the start/end side.

Calculating if at least one text node is non-header in a list may not be
cheap, so reuse the already calculated info from
OutHTML_NumberBulletListStart() in OutHTML_SwFormat().

Change-Id: I3817a489f16166fc5b4c33ee64e2283c41a4402c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135999
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins
(cherry picked from commit b2bee5a4db5552c4d408800908ca717b4ea2564a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135990
Reviewed-by: Xisco Fauli 

diff --git a/sw/qa/extras/htmlexport/htmlexport.cxx 
b/sw/qa/extras/htmlexport/htmlexport.cxx
index bc0af92e93c0..44654bdbcf5a 100644
--- a/sw/qa/extras/htmlexport/htmlexport.cxx
+++ b/sw/qa/extras/htmlexport/htmlexport.cxx
@@ -1530,6 +1530,47 @@ CPPUNIT_TEST_FIXTURE(SwHtmlDomExportTest, 
testPartiallyNumberedList)
 
"/reqif-xhtml:html/reqif-xhtml:div/reqif-xhtml:ol/reqif-xhtml:li/reqif-xhtml:p",
 2);
 }
 
+CPPUNIT_TEST_FIXTURE(SwHtmlDomExportTest, testListHeaderAndItem)
+{
+// Given a document with a list, first para is not numbered, but the 
second is:
+loadURL("private:factory/swriter", nullptr);
+SwXTextDocument* pTextDoc = 
dynamic_cast(mxComponent.get());
+SwWrtShell* pWrtShell = pTextDoc->GetDocShell()->GetWrtShell();
+pWrtShell->Insert("not numbered");
+SwDoc* pDoc = pWrtShell->GetDoc();
+sal_uInt16 nPos = pDoc->MakeNumRule(pDoc->GetUniqueNumRuleName());
+SwNumRule* pNumRule = pDoc->GetNumRuleTable()[nPos];
+{
+SwNode& rNode = pWrtShell->GetCursor()->GetPoint()->nNode.GetNode();
+SwTextNode& rTextNode = *rNode.GetTextNode();
+rTextNode.SetAttr(SwNumRuleItem(pNumRule->GetName()));
+rTextNode.SetCountedInList(false);
+}
+pWrtShell->SplitNode();
+pWrtShell->Insert2("numbered");
+{
+SwNode& rNode = pWrtShell->GetCursor()->GetPoint()->nNode.GetNode();
+SwTextNode& rTextNode = *rNode.GetTextNode();
+rTextNode.SetAttr(SwNumRuleItem(pNumRule->GetName()));
+}
+
+// When exporting to ReqIF:
+ExportToReqif();
+
+// Then make sure the output is well-formed xhtml:
+SvMemoryStream aStream;
+HtmlExportTest::wrapFragment(maTempFile, aStream);
+xmlDocUniquePtr pXmlDoc = parseXmlStream();
+// Without the accompanying fix in place, this test would have failed:
+// Entity: line 3: parser error : Opening and ending tag mismatch: ol line 
3 and li
+// not 
numbered
+CPPUNIT_ASSERT(pXmlDoc);
+// Make sure that in case the list has a header and an item, then both are 
wrapped in an 
+// element.
+assertXPath(pXmlDoc,
+
"/reqif-xhtml:html/reqif-xhtml:div/reqif-xhtml:ol/reqif-xhtml:li/reqif-xhtml:p",
 2);
+}
+
 CPPUNIT_TEST_FIXTURE(SwHtmlDomExportTest, testBlockQuoteNoMargin)
 {
 // Given a document with some text, para style set to Quotations, no 
bottom margin:
diff --git a/sw/source/filter/html/htmlatr.cxx 
b/sw/source/filter/html/htmlatr.cxx
index 1f1254c19bb3..db67572c545c 100644
--- a/sw/source/filter/html/htmlatr.cxx
+++ b/sw/source/filter/html/htmlatr.cxx
@@ -681,11 +681,12 @@ static void OutHTML_SwFormat( Writer& rWrt, const 
SwFormat& rFormat,
 if( nNewDefListLvl != rHWrt.m_nDefListLvl )
 rHWrt.OutAndSetDefList( nNewDefListLvl );
 
+bool bAtLeastOneNumbered = false;
 // if necessary, start a bulleted or numbered list
 if( rInfo.bInNumberBulletList 

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sw/source

[Julien Nabet (via logerrit)]

 sw/source/core/frmedt/feshview.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit c31d7e13c73c82dab9c784bfa4eb68f3ebd84b9f
Author: Julien Nabet 
AuthorDate: Sun Jun 12 10:09:49 2022 +0200
Commit: Xisco Fauli 
CommitDate: Thu Jun 16 21:13:29 2022 +0200

tdf#149524: fix crash in Writer after a label has just been created

see bt here:
https://bugs.documentfoundation.org/attachment.cgi?id=180683

Change-Id: Iba461ffe65392a7e0e779f68d1f0737a444ae724
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135675
Tested-by: Jenkins
Tested-by: Heiko Tietze 
Reviewed-by: Heiko Tietze 
Reviewed-by: Xisco Fauli 
(cherry picked from commit d9f716c48085ed46c1af31244583d67882cc94ec)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135993

diff --git a/sw/source/core/frmedt/feshview.cxx 
b/sw/source/core/frmedt/feshview.cxx
index 464cd46412b6..8369004ac3c5 100644
--- a/sw/source/core/frmedt/feshview.cxx
+++ b/sw/source/core/frmedt/feshview.cxx
@@ -1865,8 +1865,8 @@ bool SwFEShell::EndCreate( SdrCreateCmd eSdrCreateCmd )
 
 bool SwFEShell::ImpEndCreate()
 {
-OSL_ENSURE( Imp()->GetDrawView()->GetMarkedObjectList().GetMarkCount() == 
1,
-"New object not selected." );
+if (Imp()->GetDrawView()->GetMarkedObjectList().GetMarkCount() == 0)
+return false;
 
 SdrObject& rSdrObj = 
*Imp()->GetDrawView()->GetMarkedObjectList().GetMark(0)->GetMarkedSdrObj();
 

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sc/source

[Caolán McNamara (via logerrit)]

 sc/source/core/data/colorscale.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 7e259e7b6e28e08a1ac2055b5a4c9d6bc97f78d2
Author: Caolán McNamara 
AuthorDate: Thu Jun 16 13:47:31 2022 +0100
Commit: Xisco Fauli 
CommitDate: Thu Jun 16 21:12:53 2022 +0200

tdf#149529 crash on deref deleted ScDocument*

maybe a problem since

commit 46419cd7a2d453c6f252c28dfb9dbfb08605e1c4
Date:   Tue Jun 18 15:11:30 2013 -0400

ScFormulaCell is no longer a child class of ScBaseCell.

Change-Id: Id33072f193045e2eaf51373b47dac803f9a5d52c

presumably the cloned ScColorScaleEntry should end up with
a ScFormulaCell for the destination document and not the source one

Change-Id: I451d5827be183198b61116ab8c582cfda03b2031
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135998
Tested-by: Jenkins
Reviewed-by: Eike Rathke 
(cherry picked from commit 10404751bcb643605c50d530e3855ae005e60a5e)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135992

diff --git a/sc/source/core/data/colorscale.cxx 
b/sc/source/core/data/colorscale.cxx
index 81944e4dd0c3..5cbf21cf8094 100644
--- a/sc/source/core/data/colorscale.cxx
+++ b/sc/source/core/data/colorscale.cxx
@@ -189,7 +189,7 @@ ScColorScaleEntry::ScColorScaleEntry(ScDocument* pDoc, 
const ScColorScaleEntry&
 setListener();
 if(rEntry.mpCell)
 {
-mpCell.reset(new ScFormulaCell(*rEntry.mpCell, 
rEntry.mpCell->GetDocument(), rEntry.mpCell->aPos, 
ScCloneFlags::NoMakeAbsExternal));
+mpCell.reset(new ScFormulaCell(*rEntry.mpCell, *pDoc, 
rEntry.mpCell->aPos, ScCloneFlags::NoMakeAbsExternal));
 mpCell->StartListeningTo( *pDoc );
 mpListener.reset(new ScFormulaListener(mpCell.get()));
 if (mpFormat)

[Libreoffice-bugs] [Bug 147822] LO Calc with RadioButton Crash in: ScUnoListenerCalls::ExecuteAndClear() - steps Comment 22

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147822

Eike Rathke  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Keywords||bibisectNotNeeded,
   ||regression
   Assignee|libreoffice-b...@lists.free |er...@redhat.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/inc sc/qa sc/source

[Noel Grandin (via logerrit)]

 sc/inc/cellvalue.hxx   |6 +
 sc/qa/unit/subsequent_filters_test.cxx |4 -
 sc/source/core/data/cellvalue.cxx  |   52 -
 sc/source/core/data/column3.cxx|4 -
 sc/source/core/data/column4.cxx|2 
 sc/source/core/data/conditio.cxx   |2 
 sc/source/core/data/dociter.cxx|6 -
 sc/source/core/data/document.cxx   |2 
 sc/source/core/data/documentimport.cxx |4 -
 sc/source/core/data/queryevaluator.cxx |4 -
 sc/source/core/data/queryiter.cxx  |2 
 sc/source/core/data/table3.cxx |2 
 sc/source/core/data/table4.cxx |   36 +--
 sc/source/core/data/validat.cxx|2 
 sc/source/core/tool/cellform.cxx   |4 -
 sc/source/core/tool/chgtrack.cxx   |6 -
 sc/source/core/tool/interpr4.cxx   |   10 +--
 sc/source/filter/excel/xetable.cxx |2 
 sc/source/filter/html/htmlexp.cxx  |2 
 sc/source/filter/xcl97/XclExpChangeTrack.cxx   |2 
 sc/source/filter/xml/XMLChangeTrackingExportHelper.cxx |2 
 sc/source/filter/xml/xmlexprt.cxx  |6 -
 sc/source/ui/docshell/externalrefmgr.cxx   |4 -
 sc/source/ui/undo/undocell.cxx |2 
 sc/source/ui/view/output2.cxx  |2 
 sc/source/ui/view/tabvwsh5.cxx |2 
 26 files changed, 87 insertions(+), 85 deletions(-)

New commits:
commit c2518134a55658218c924b43b5c87e4fbdaed1d4
Author: Noel Grandin 
AuthorDate: Thu Jun 16 16:29:18 2022 +0200
Commit: Noel Grandin 
CommitDate: Thu Jun 16 20:39:23 2022 +0200

create getter for ScCellValue::mfValue

so we can assert that has the correct tag type

Change-Id: I0d626130cb014e19239e88a6988018c83d061f68
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136001
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sc/inc/cellvalue.hxx b/sc/inc/cellvalue.hxx
index 942cf006cab5..9513fcfc99d5 100644
--- a/sc/inc/cellvalue.hxx
+++ b/sc/inc/cellvalue.hxx
@@ -38,7 +38,7 @@ private:
 CellType meType;
 public:
 union {
-double mfValue;
+double mfValue1;
 svl::SharedString* mpString;
 EditTextObject* mpEditText;
 ScFormulaCell* mpFormula;
@@ -62,6 +62,7 @@ public:
 void set( ScFormulaCell* pFormula );
 
 CellType getType() const { return meType; }
+double getDouble() const { assert(meType == CELLTYPE_VALUE); return 
mfValue1; }
 
 /**
  * Take cell value from specified position in specified document.
@@ -111,7 +112,7 @@ private:
 CellType meType;
 public:
 union {
-double mfValue;
+double mfValue1;
 const svl::SharedString* mpString;
 const EditTextObject* mpEditText;
 ScFormulaCell* mpFormula;
@@ -132,6 +133,7 @@ public:
 void clear();
 
 CellType getType() const { return meType; }
+double getDouble() const { assert(meType == CELLTYPE_VALUE); return 
mfValue1; }
 
 /**
  * Take cell value from specified position in specified document.
diff --git a/sc/qa/unit/subsequent_filters_test.cxx 
b/sc/qa/unit/subsequent_filters_test.cxx
index c1dd83f791a2..cb61bdd5a08a 100644
--- a/sc/qa/unit/subsequent_filters_test.cxx
+++ b/sc/qa/unit/subsequent_filters_test.cxx
@@ -552,7 +552,7 @@ void ScFiltersTest::testDeleteCircleInMergedCellODS()
 aMergedCell.assign(rDoc, aPosMergedCell);
 
 // The value of merged cell change to 6.
-aMergedCell.mfValue = 6;
+aMergedCell = ScRefCellValue(6);
 
 // Check that the data is valid.(True if the value = 6)
 const ScValidationData* pData = rDoc.GetValidationEntry(1);
@@ -584,7 +584,7 @@ void ScFiltersTest::testBasicCellContentODS()
 aCell.assign(rDoc, ScAddress(1,4,0)); // B5
 CPPUNIT_ASSERT_EQUAL_MESSAGE(
 "This cell must be numeric.", CELLTYPE_VALUE, aCell.getType());
-CPPUNIT_ASSERT_EQUAL(0.0, aCell.mfValue);
+CPPUNIT_ASSERT_EQUAL(0.0, aCell.getDouble());
 
 xDocSh->DoClose();
 }
diff --git a/sc/source/core/data/cellvalue.cxx 
b/sc/source/core/data/cellvalue.cxx
index c565e0a488d6..cfc879802446 100644
--- a/sc/source/core/data/cellvalue.cxx
+++ b/sc/source/core/data/cellvalue.cxx
@@ -92,7 +92,7 @@ bool equalsWithoutFormatImpl( const T& left, const T& right )
 case CELLTYPE_NONE:
 return true;
 case CELLTYPE_VALUE:
-return left.mfValue == right.mfValue;
+return left.getDouble() == right.getDouble();
 case CELLTYPE_STRING:
 {
 OUString aStr1 = getString(left);
@@ -118,7 +118,7 @@ void commitToColumn( const ScCellValue& rCell, 

[Libreoffice-commits] core.git: sc/inc sc/source

[Noel Grandin (via logerrit)]

 sc/inc/cellvalue.hxx  |2 +-
 sc/source/core/data/cellvalue.cxx |4 ++--
 sc/source/filter/oox/revisionfragment.cxx |2 +-
 sc/source/filter/xml/XMLTrackedChangesContext.cxx |2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

New commits:
commit 7eae7e54e0c55d5896cf807c339fd0789f54d380
Author: Noel Grandin 
AuthorDate: Thu Jun 16 14:24:56 2022 +0200
Commit: Noel Grandin 
CommitDate: Thu Jun 16 20:39:05 2022 +0200

pass EditTextObject by unique_ptr

to make the ownership passing obvious

Change-Id: Icf4b94a422b91da3082fe1ce56eff149d390a649
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136000
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sc/inc/cellvalue.hxx b/sc/inc/cellvalue.hxx
index 5876f9584a4f..942cf006cab5 100644
--- a/sc/inc/cellvalue.hxx
+++ b/sc/inc/cellvalue.hxx
@@ -58,7 +58,7 @@ public:
 void set( double fValue );
 void set( const svl::SharedString& rStr );
 void set( const EditTextObject& rEditText );
-void set( EditTextObject* pEditText );
+void set( std::unique_ptr );
 void set( ScFormulaCell* pFormula );
 
 CellType getType() const { return meType; }
diff --git a/sc/source/core/data/cellvalue.cxx 
b/sc/source/core/data/cellvalue.cxx
index ca8c8e78c954..c565e0a488d6 100644
--- a/sc/source/core/data/cellvalue.cxx
+++ b/sc/source/core/data/cellvalue.cxx
@@ -315,11 +315,11 @@ void ScCellValue::set( const EditTextObject& rEditText )
 mpEditText = rEditText.Clone().release();
 }
 
-void ScCellValue::set( EditTextObject* pEditText )
+void ScCellValue::set( std::unique_ptr xEditText )
 {
 clear();
 meType = CELLTYPE_EDIT;
-mpEditText = pEditText;
+mpEditText = xEditText.release();
 }
 
 void ScCellValue::set( ScFormulaCell* pFormula )
diff --git a/sc/source/filter/oox/revisionfragment.cxx 
b/sc/source/filter/oox/revisionfragment.cxx
index f6fee91c4051..4a0fa785e6df 100644
--- a/sc/source/filter/oox/revisionfragment.cxx
+++ b/sc/source/filter/oox/revisionfragment.cxx
@@ -147,7 +147,7 @@ protected:
 {
 svl::SharedStringPool& rPool = 
rDoc.GetSharedStringPool();
 pTextObj->NormalizeString(rPool);
-mrCellValue.set(pTextObj.release());
+mrCellValue.set(std::move(pTextObj));
 }
 }
 }
diff --git a/sc/source/filter/xml/XMLTrackedChangesContext.cxx 
b/sc/source/filter/xml/XMLTrackedChangesContext.cxx
index d478a8af0ba9..8294eb979a92 100644
--- a/sc/source/filter/xml/XMLTrackedChangesContext.cxx
+++ b/sc/source/filter/xml/XMLTrackedChangesContext.cxx
@@ -860,7 +860,7 @@ void SAL_CALL ScXMLChangeCellContext::endFastElement( 
sal_Int32 /*nElement*/ )
 }
 
 // The cell will own the text object instance.
-mrOldCell.set(mpEditTextObj->CreateTextObject().release());
+mrOldCell.set(mpEditTextObj->CreateTextObject());
 GetScImport().GetTextImport()->ResetCursor();
 mpEditTextObj.clear();
 }

[Libreoffice-bugs] [Bug 31480] Find/replace non-printing characters easily

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=31480

--- Comment #36 from 3d Cube Bpo  ---
Starting a call center business can be an effective way to earn income while
operating your own business. It is possible to run a call center from your
home, but you can also rent an office space. 
https://3dcubebpo.com/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149589] New: Calc fails to open context menu in edit-mode for some cell contents (breaks spell checker and other features)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149589

Bug ID: 149589
   Summary: Calc fails to open context menu in edit-mode for some
cell contents (breaks spell checker and other
features)
   Product: LibreOffice
   Version: 7.3.4.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: norbert.n...@gmx.de

Created attachment 180801
  --> https://bugs.documentfoundation.org/attachment.cgi?id=180801=edit
Testkit

Hi,

- please open the attached spreadsheet file

- (Cell A1 should be already selected. If not, select it.)

- Press F2 to enter cell-edit mode

- Move the mouse pointer over cell A1 and click the right mouse button

Result: The context menu does NOT appear!

Expected result: The context menu should appear.

If you copy the cell content text of A1 into other cells the target cells are
affected by the same bug.


A fix is important because a missing context menu breaks many common used
features. A very critical problem is that the suggestions of the automatic
spelling correction cannot be accepted due to this.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147846] Left border line for characters is missing for the first character in ordered and unordered list paragraphs and paragraphs that start with a bookmark

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147846

sdc.bla...@youmail.dk changed:

   What|Removed |Added

Summary|A bar is missing if I want  |Left border line for
   |to make a border for|characters is missing for
   |characters, that are at the |the first character in
   |beginning of a line.|ordered and unordered list
   ||paragraphs and paragraphs
   ||that start with a bookmark

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146842] All pages are empty/white when printing (skia, macOS only)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146842

--- Comment #69 from jefftucker1...@gmail.com ---
(In reply to Luboš Luňák from comment #67)
> Can somebody reproduce this without a physical printer? What are the exact
> steps to reproduce?

LibreOffice 7.3.4.2, macOS 11.6.6 (my Macbook Air has "aged out" of further OS
updates). LibreOffice > Preferences > LibreOffice > View, choose Use Skia for
all rendering, and restart LibreOffice.

Open any document - Writer, Calc, take your pick. Choose Print. The preview
window is blank. If you Save as PDF, the PDF is a blank page. No physical
printer is needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sc/source

[Caolán McNamara (via logerrit)]

 sc/source/core/data/colorscale.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 12e8dd5c12918ba9c2a048a8a26e830455d1e302
Author: Caolán McNamara 
AuthorDate: Thu Jun 16 13:47:31 2022 +0100
Commit: Eike Rathke 
CommitDate: Thu Jun 16 20:13:19 2022 +0200

tdf#149529 crash on deref deleted ScDocument*

maybe a problem since

commit 46419cd7a2d453c6f252c28dfb9dbfb08605e1c4
Date:   Tue Jun 18 15:11:30 2013 -0400

ScFormulaCell is no longer a child class of ScBaseCell.

Change-Id: Id33072f193045e2eaf51373b47dac803f9a5d52c

presumably the cloned ScColorScaleEntry should end up with
a ScFormulaCell for the destination document and not the source one

Change-Id: I451d5827be183198b61116ab8c582cfda03b2031
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135998
Tested-by: Jenkins
Reviewed-by: Eike Rathke 
(cherry picked from commit 81c95dd499f50f75f84cf73d2e78964d19c8f4db)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135991

diff --git a/sc/source/core/data/colorscale.cxx 
b/sc/source/core/data/colorscale.cxx
index 75f94d3bc2ed..0a357828c61e 100644
--- a/sc/source/core/data/colorscale.cxx
+++ b/sc/source/core/data/colorscale.cxx
@@ -190,7 +190,7 @@ ScColorScaleEntry::ScColorScaleEntry(ScDocument* pDoc, 
const ScColorScaleEntry&
 setListener();
 if(rEntry.mpCell)
 {
-mpCell.reset(new ScFormulaCell(*rEntry.mpCell, 
rEntry.mpCell->GetDocument(), rEntry.mpCell->aPos, 
ScCloneFlags::NoMakeAbsExternal));
+mpCell.reset(new ScFormulaCell(*rEntry.mpCell, *pDoc, 
rEntry.mpCell->aPos, ScCloneFlags::NoMakeAbsExternal));
 mpCell->StartListeningTo( *pDoc );
 mpListener.reset(new ScFormulaListener(mpCell.get()));
 if (mpFormat)

[Libreoffice-bugs] [Bug 149414] Change submenu label for formatting textboxes and shapes in Calc and Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149414

--- Comment #8 from Commit Notification 
 ---
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/help/commit/907f876a9a0ab822fe6a67ab779ca03f4134e4d5

(related) tdf#149414 change in Impress Format menu command name

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149414] Change submenu label for formatting textboxes and shapes in Calc and Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149414

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.4.0 target:7.5.0   |target:7.4.0 target:7.5.0
   ||target:7.4.0.0.beta2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - helpcontent2

[Seth Chaiklin (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 8ba4c58e83e1e005a005a3165ee63ee6ed8f9041
Author: Seth Chaiklin 
AuthorDate: Thu Jun 16 20:10:11 2022 +0200
Commit: Gerrit Code Review 
CommitDate: Thu Jun 16 20:10:11 2022 +0200

Update git submodules

* Update helpcontent2 from branch 'libreoffice-7-4'
  to 907f876a9a0ab822fe6a67ab779ca03f4134e4d5
  - (related) tdf#149414 change in Impress Format menu command name

Change-Id: I80d37dc341f35c89fe73d815df900178a3552c74
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136017
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin 
(cherry picked from commit 51cfc9a957eec7be595e8b667a528cbe749992a0)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136018

diff --git a/helpcontent2 b/helpcontent2
index 6d0866222372..907f876a9a0a 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 6d0866222372247f6792d75664ae0642798e288c
+Subproject commit 907f876a9a0ab822fe6a67ab779ca03f4134e4d5

[Libreoffice-commits] help.git: Branch 'libreoffice-7-4' - source/text

[Seth Chaiklin (via logerrit)]

 source/text/simpress/submenu_object_shape.xhp |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 907f876a9a0ab822fe6a67ab779ca03f4134e4d5
Author: Seth Chaiklin 
AuthorDate: Thu Jun 16 19:55:55 2022 +0200
Commit: Seth Chaiklin 
CommitDate: Thu Jun 16 20:10:10 2022 +0200

(related) tdf#149414 change in Impress Format menu command name

Change-Id: I80d37dc341f35c89fe73d815df900178a3552c74
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136017
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin 
(cherry picked from commit 51cfc9a957eec7be595e8b667a528cbe749992a0)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136018

diff --git a/source/text/simpress/submenu_object_shape.xhp 
b/source/text/simpress/submenu_object_shape.xhp
index fa2f0b162..cf0b7bfa2 100644
--- a/source/text/simpress/submenu_object_shape.xhp
+++ b/source/text/simpress/submenu_object_shape.xhp
@@ -10,14 +10,14 @@
 -->
 
   
-Object and Shape (Impress)
+Textbox and Shape (Impress)
 /text/simpress/submenu_object_shape.xhp
   
 
 
 
-Object 
and Shape
-Opens a submenu to edit 
the properties of the selected object or shape.
+Textbox 
and Shape
+Opens a submenu to edit 
the properties of the selected textbox or shape.
 
 
 

[Libreoffice-bugs] [Bug 149414] Change submenu label for formatting textboxes and shapes in Calc and Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149414

--- Comment #7 from Commit Notification 
 ---
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/51cfc9a957eec7be595e8b667a528cbe749992a0

(related) tdf#149414 change in Impress Format menu command name

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: helpcontent2

[Seth Chaiklin (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0fe3459b05502bc62814dc1f90059653f52046f8
Author: Seth Chaiklin 
AuthorDate: Thu Jun 16 20:03:34 2022 +0200
Commit: Gerrit Code Review 
CommitDate: Thu Jun 16 20:03:34 2022 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to 51cfc9a957eec7be595e8b667a528cbe749992a0
  - (related) tdf#149414 change in Impress Format menu command name

Change-Id: I80d37dc341f35c89fe73d815df900178a3552c74
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136017
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin 

diff --git a/helpcontent2 b/helpcontent2
index c7fba791de12..51cfc9a957ee 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit c7fba791de12f34179bb355fedbc111f4112bde8
+Subproject commit 51cfc9a957eec7be595e8b667a528cbe749992a0

[Libreoffice-bugs] [Bug 149414] Change submenu label for formatting textboxes and shapes in Calc and Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149414

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.4.0|target:7.4.0 target:7.5.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] help.git: source/text

[Seth Chaiklin (via logerrit)]

 source/text/simpress/submenu_object_shape.xhp |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 51cfc9a957eec7be595e8b667a528cbe749992a0
Author: Seth Chaiklin 
AuthorDate: Thu Jun 16 19:55:55 2022 +0200
Commit: Seth Chaiklin 
CommitDate: Thu Jun 16 20:03:32 2022 +0200

(related) tdf#149414 change in Impress Format menu command name

Change-Id: I80d37dc341f35c89fe73d815df900178a3552c74
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136017
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin 

diff --git a/source/text/simpress/submenu_object_shape.xhp 
b/source/text/simpress/submenu_object_shape.xhp
index fa2f0b162..cf0b7bfa2 100644
--- a/source/text/simpress/submenu_object_shape.xhp
+++ b/source/text/simpress/submenu_object_shape.xhp
@@ -10,14 +10,14 @@
 -->
 
   
-Object and Shape (Impress)
+Textbox and Shape (Impress)
 /text/simpress/submenu_object_shape.xhp
   
 
 
 
-Object 
and Shape
-Opens a submenu to edit 
the properties of the selected object or shape.
+Textbox 
and Shape
+Opens a submenu to edit 
the properties of the selected textbox or shape.
 
 
 

[Libreoffice-bugs] [Bug 149549] recent files list deleted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149549

m.a.riosv  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #7 from m.a.riosv  ---
Maybe it's the intended behavior, but a selection with only one selection
doesn't look very orthodoxy.

Putting directly 'Clear recent documents' seems more adequate.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149527] Calc crashes when I scroll up and down very quickly within a document.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149527

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #7 from m.a.riosv  ---
Please test if changing the values for
Menu/Tools/Options/LibreOffice/View/Graphics output, like enable/disable skia
shows any difference.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 120200] [META] Update or correct help for features

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120200
Bug 120200 depends on bug 149572, which changed state.

Bug 149572 Summary: "Left paragraph border" and "right paragraph border" 
options for Horizontal "to" position in Position and Size tab and Image - 
Position and Size tab need updating
https://bugs.documentfoundation.org/show_bug.cgi?id=149572

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - helpcontent2

[Seth Chaiklin (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 17c3bd9493dda861ccbbe6af5db2994ae1ba0287
Author: Seth Chaiklin 
AuthorDate: Thu Jun 16 19:41:39 2022 +0200
Commit: Gerrit Code Review 
CommitDate: Thu Jun 16 19:41:39 2022 +0200

Update git submodules

* Update helpcontent2 from branch 'libreoffice-7-4'
  to 6d0866222372247f6792d75664ae0642798e288c
  - tdf#149572 update "Left Paragraph Border" and "Right Paragraph Border

   tdf#149242 changed the Horizontal positioning labels in the
   "to" control from:
   "Left paragraph border" -> "Left of paragraph text area" and
   "Right paragraph border" -> "Right of paragraph text area"

This patch updates the option names and makes corrections to
in the description of the referent of these options.

Change-Id: I604cb4354f239d476375791fa57865d10b1d0d24
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135881
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 
(cherry picked from commit c7fba791de12f34179bb355fedbc111f4112bde8)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136016
Reviewed-by: Seth Chaiklin 

diff --git a/helpcontent2 b/helpcontent2
index 1f35f6f69a3e..6d0866222372 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 1f35f6f69a3e250e24994af78dc64ecfb3573a26
+Subproject commit 6d0866222372247f6792d75664ae0642798e288c

[Libreoffice-commits] help.git: Branch 'libreoffice-7-4' - source/text

[Seth Chaiklin (via logerrit)]

 source/text/swriter/01/05060100.xhp |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 6d0866222372247f6792d75664ae0642798e288c
Author: Seth Chaiklin 
AuthorDate: Wed Jun 15 10:56:12 2022 +0200
Commit: Seth Chaiklin 
CommitDate: Thu Jun 16 19:41:38 2022 +0200

tdf#149572 update "Left Paragraph Border" and "Right Paragraph Border

   tdf#149242 changed the Horizontal positioning labels in the
   "to" control from:
   "Left paragraph border" -> "Left of paragraph text area" and
   "Right paragraph border" -> "Right of paragraph text area"

This patch updates the option names and makes corrections to
in the description of the referent of these options.

Change-Id: I604cb4354f239d476375791fa57865d10b1d0d24
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135881
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 
(cherry picked from commit c7fba791de12f34179bb355fedbc111f4112bde8)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136016
Reviewed-by: Seth Chaiklin 

diff --git a/source/text/swriter/01/05060100.xhp 
b/source/text/swriter/01/05060100.xhp
index 93dd3ad2b..465692745 100644
--- a/source/text/swriter/01/05060100.xhp
+++ b/source/text/swriter/01/05060100.xhp
@@ -108,10 +108,10 @@
 Paragraph 
text area: the object is positioned considering the whole width 
available for text in the paragraph, excluding indent spaces.
   
   
-Left 
paragraph border: the object is positioned considering the width of the 
indent space available to the left of the paragraph.
+Left 
of paragraph text area: the object is positioned in the region from 
the left text boundary to the first character on the left edge of the anchored 
paragraph text. For multicolumn paragraphs, the 
region is defined in relation to the column where the anchor is 
located. When the anchor is not located in the first column, then 
the region starts at the left column margin.
   
   
-Right 
paragraph border: the object is positioned considering the width of the 
indent space available to the right of the paragraph.
+Right 
of paragraph text area: the object is positioned in the region from 
the last character on the right edge of anchored paragraph text to the right 
text boundary.  When 
the anchor is not located in the last column then the region ends at the right 
column margin.
   
   
 Left 
of page text area: the object is positioned in the region between 
the left edge of the page and the left margin plus any left page 
padding.

[Libreoffice-bugs] [Bug 149580] Text boundaries stop applying when saving as DOCX and opening both files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149580

--- Comment #2 from Eyal Rozenberg  ---
(In reply to Rafael Lima from comment #1)
> I believe the expected behavior would be to not show Table Boundaries in the
> ODT file, right?

I _think_ so, but I'm not entirely sure, since I don't know whether a table
cell is an area in which we're supposed to see text boundaries. Good point.

Anyway, if you've reproduced, please confirm.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146842] All pages are empty/white when printing (skia, macOS only)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146842

--- Comment #68 from David W  ---
Way back when I first saw this, it was apparent both in the preview window, or
if I did a "Save as PDF."

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 134759] Tracking changes items appear while not being shown at all

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=134759

--- Comment #11 from Commit Notification 
 ---
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3707c0b4ff683ac6f0942a176ebcb8d824b567ee

tdf#134759 sw: clear items in SwAttrSet::CopyToModify()

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 134759] Tracking changes items appear while not being shown at all

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=134759

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.5.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/source

[Michael Stahl (via logerrit)]

 sw/source/core/attr/swatrset.cxx |   17 +
 1 file changed, 17 insertions(+)

New commits:
commit 3707c0b4ff683ac6f0942a176ebcb8d824b567ee
Author: Michael Stahl 
AuthorDate: Fri Mar 18 21:30:07 2022 +0100
Commit: Michael Stahl 
CommitDate: Thu Jun 16 19:18:40 2022 +0200

tdf#134759 sw: clear items in SwAttrSet::CopyToModify()

Setting new items but not clearing existing items smells like an
obvious omission. Why would we want a union of two nodes' items?

This improves things a bit for the bugdoc, but now it ends up with a
different wrong list on the node 254.

Change-Id: I3f5db0a4f81ac6e9af56d1faaefc2cb107dff597
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131841
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/sw/source/core/attr/swatrset.cxx b/sw/source/core/attr/swatrset.cxx
index e50116d58459..de014a521d2e 100644
--- a/sw/source/core/attr/swatrset.cxx
+++ b/sw/source/core/attr/swatrset.cxx
@@ -423,6 +423,23 @@ void SwAttrSet::CopyToModify( sw::BroadcastingModify& rMod 
) const
 pFormat->SetFormatAttr( *this );
 }
 }
+if (pCNd && pCNd->HasSwAttrSet())
+{
+SfxWhichIter it(*this);
+std::vector toClear;
+for (sal_uInt16 nWhich = it.FirstWhich(); nWhich != 0; nWhich = 
it.NextWhich())
+{
+if (GetItemState(nWhich, false) != SfxItemState::SET
+&& pCNd->GetSwAttrSet().GetItemState(nWhich, false) == 
SfxItemState::SET)
+{
+toClear.emplace_back(nWhich);
+}
+}
+if (!toClear.empty())
+{
+pCNd->ResetAttr(toClear);
+}
+}
 }
 #if OSL_DEBUG_LEVEL > 0
 else

[Libreoffice-bugs] [Bug 129062] [META] Skia library bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129062

Luboš Luňák  changed:

   What|Removed |Added

 Depends on||146842


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=146842
[Bug 146842] All pages are empty/white when printing (skia, macOS only)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146842] All pages are empty/white when printing (skia, macOS only)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146842

Luboš Luňák  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO
 Blocks||129062

--- Comment #67 from Luboš Luňák  ---
Can somebody reproduce this without a physical printer? What are the exact
steps to reproduce?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=129062
[Bug 129062] [META] Skia library bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: helpcontent2

[Seth Chaiklin (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c0c0e33c4e74f62e77d54460595bcf0b3abb01a6
Author: Seth Chaiklin 
AuthorDate: Thu Jun 16 19:12:41 2022 +0200
Commit: Gerrit Code Review 
CommitDate: Thu Jun 16 19:12:41 2022 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to c7fba791de12f34179bb355fedbc111f4112bde8
  - tdf#149572 update "Left Paragraph Border" and "Right Paragraph Border

   tdf#149242 changed the Horizontal positioning labels in the
   "to" control from:
   "Left paragraph border" -> "Left of paragraph text area" and
   "Right paragraph border" -> "Right of paragraph text area"

This patch updates the option names and makes corrections to
in the description of the referent of these options.

Change-Id: I604cb4354f239d476375791fa57865d10b1d0d24
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135881
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/helpcontent2 b/helpcontent2
index a17fbdee73a7..c7fba791de12 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit a17fbdee73a7f567637c56a1b6354c0fef3b3a10
+Subproject commit c7fba791de12f34179bb355fedbc111f4112bde8

[Libreoffice-bugs] [Bug 146598] Freezing when using cut, copy, or paste on macOS

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146598

--- Comment #15 from Jean  ---
I met the same problems with MacBook Pro (Big Sur) and LibreOffice 7.2 et 7.3
in March, April, this year. I tried the different updates, all crashed.
I downgraded to 7.1.8.1. and everything is fine since.
I just came here to get information whether the problem was solved. Apparently
not.
I keep preciously the dmg versions of 7.1.8.1. till further notice !
For your information,

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] help.git: source/text

[Seth Chaiklin (via logerrit)]

 source/text/swriter/01/05060100.xhp |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit c7fba791de12f34179bb355fedbc111f4112bde8
Author: Seth Chaiklin 
AuthorDate: Wed Jun 15 10:56:12 2022 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Thu Jun 16 19:12:39 2022 +0200

tdf#149572 update "Left Paragraph Border" and "Right Paragraph Border

   tdf#149242 changed the Horizontal positioning labels in the
   "to" control from:
   "Left paragraph border" -> "Left of paragraph text area" and
   "Right paragraph border" -> "Right of paragraph text area"

This patch updates the option names and makes corrections to
in the description of the referent of these options.

Change-Id: I604cb4354f239d476375791fa57865d10b1d0d24
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135881
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/source/text/swriter/01/05060100.xhp 
b/source/text/swriter/01/05060100.xhp
index 93dd3ad2b..465692745 100644
--- a/source/text/swriter/01/05060100.xhp
+++ b/source/text/swriter/01/05060100.xhp
@@ -108,10 +108,10 @@
 Paragraph 
text area: the object is positioned considering the whole width 
available for text in the paragraph, excluding indent spaces.
   
   
-Left 
paragraph border: the object is positioned considering the width of the 
indent space available to the left of the paragraph.
+Left 
of paragraph text area: the object is positioned in the region from 
the left text boundary to the first character on the left edge of the anchored 
paragraph text. For multicolumn paragraphs, the 
region is defined in relation to the column where the anchor is 
located. When the anchor is not located in the first column, then 
the region starts at the left column margin.
   
   
-Right 
paragraph border: the object is positioned considering the width of the 
indent space available to the right of the paragraph.
+Right 
of paragraph text area: the object is positioned in the region from 
the last character on the right edge of anchored paragraph text to the right 
text boundary.  When 
the anchor is not located in the last column then the region ends at the right 
column margin.
   
   
 Left 
of page text area: the object is positioned in the region between 
the left edge of the page and the left margin plus any left page 
padding.

[Libreoffice-bugs] [Bug 145988] macOS skia: colors not displayed correctly for all document previews e.g. start center or impress templates

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145988

Luboš Luňák  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #38 from Luboš Luňák  ---
I still cannot reproduce, and a number of other people apparently can't either,
so for those who can reproduce this, questions from comment #10 again, in more
detail:

- Can you reproduce this with Skia/Metal enabled (shown in About dialog)?
Create a new document, save it and then check the preview of it.
- Can you reproduce this with Skia/Raster enabled (again shown in About
dialog)? This can be forced using 'Force Skia software rendering' in the
options dialog. Again, create and save a new document.
- If you the problem exists only in one of these two modes, what will happen if
you create and save a new document in one mode, then change the mode and start
LO again? For both combinations of the two modes.
- Please post the system info from the About dialog.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: offapi/com

[Samuel Mehrbrodt (via logerrit)]

 offapi/com/sun/star/drawing/FillProperties.idl |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit df454a21c6f15404b312f06ae99620bc720258ef
Author: Samuel Mehrbrodt 
AuthorDate: Thu Jun 16 16:13:26 2022 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Thu Jun 16 19:09:24 2022 +0200

Next release is 7.5

According to 27ebceb366356f65c836e7edcc3609193f6e009c

Change-Id: I0fe247ca398a3c4607840c1a190453c52204749b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135986
Reviewed-by: Stephan Bergmann 
Tested-by: Jenkins

diff --git a/offapi/com/sun/star/drawing/FillProperties.idl 
b/offapi/com/sun/star/drawing/FillProperties.idl
index 2e6ff1927424..e96c3f57a01c 100644
--- a/offapi/com/sun/star/drawing/FillProperties.idl
+++ b/offapi/com/sun/star/drawing/FillProperties.idl
@@ -219,7 +219,7 @@ published service FillProperties
 /** If this is `TRUE`, and FillStyle is FillStyle::NONE:
 The area displays the slide background
 
-@since LibreOffice 8.0
+@since LibreOffice 7.5
 */
 [optional, property] boolean FillUseSlideBackground;
 

[Libreoffice-bugs] [Bug 149565] Libreoffice Draw Doesn't Save Hatch Background Spacing Variable When Changed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149565

Regina Henschel  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #4 from Regina Henschel  ---
(In reply to Bob from comment #3)
> I moved away from the default included package of liberoffice 6.4 with
> Ubuntu 20.04 and installed 7.3.4. The bug was corrected somewhere along the
> releases.

Thank you for testing a newer version.

> 
> This report can be closed. Let me know if I need to do that.

Nothing to do for you.

Resolve it as "worksforme" according to comment 3.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149588] FILEOPEN PPTX: text box shows that does not show in PowerPoint

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149588

--- Comment #1 from Gerald Pfeifer  ---
Created attachment 180800
  --> https://bugs.documentfoundation.org/attachment.cgi?id=180800=edit
Visual comparison Office 365 (left) vs LibreOffice 7.4 (right)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149588] New: FILEOPEN PPTX: text box shows that does not show in PowerPoint

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149588

Bug ID: 149588
   Summary: FILEOPEN PPTX: text box shows that does not show in
PowerPoint
   Product: LibreOffice
   Version: 7.4.0.0 beta1+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ger...@pfeifer.com

Created attachment 180799
  --> https://bugs.documentfoundation.org/attachment.cgi?id=180799=edit
Sample slide (PPTX)

Opening the sample document in LibreOffice the two words "Edge" and
"Cloud" appear twice instead of just once in PowerPoint.

The second instances are text boxes that show in LibreOffice alas
were made (intentionally) invisible in PowerPoint.


Version: 7.4.0.0.alpha1+ / LibreOffice Community
Build ID: 66b1ebd4ddc7127a923bf81eb569e7f99dd52022
CPU threads: 8; OS: Linux 5.18; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US

all the way back to

Version: 7.0.7.0.0+
Build ID: 54e9dd41dc9dd45af12c9346199f601ea4a5994d
CPU threads: 8; OS: Linux 5.18; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:libreoffice-7-0, Time:
2021-05-07_08:22:18

and even 6.4.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149586] Crash in: __scrt_throw_std_bad_alloc()

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149586

--- Comment #3 from Julien Nabet  ---
(In reply to tsattert from comment #2)
> I upgraded to 7.3.4.2.  
> I checked Options and confirmed that the 'force Skia' box is already checked.
> I received the same abend.

Did you check you've got last stable driver for your graphic card?

If yes and it still crashes, the objective is to disable Skia for you and so
you should apply:
"However, there are known cases when using Skia/Raster still crashes
LibreOffice when starting, and in those cases (when you will not be even able
to look at Help ▸ About LibreOffice) you would need to try these manual steps.

Locate your user profile (see details above).
Open registrymodifications.xcu in a plain text editor, and search for
UseSkia text string there.
If found, replace true with false in that line.
If not found, add this line to the file before the final :

   false

If the issue is gone, locate /cache/skia.log, and attach it to
the bug report. This will help the development team assess whether the issue
could be with the Skia/Vulkan implementation in your system, or within
LibreOffice. "

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - config_host/config_skia.h.in

[Rene Engelhard (via logerrit)]

 config_host/config_skia.h.in |4 
 1 file changed, 4 deletions(-)

New commits:
commit cc3d8995fc28ca98c4ad38c5066977ea48cef9a1
Author: Rene Engelhard 
AuthorDate: Mon Jun 13 18:28:34 2022 +0200
Commit: René Engelhard 
CommitDate: Thu Jun 16 18:16:08 2022 +0200

Revert "enable Skia on big-endian too"

This reverts commit b06663135f9c7c08f5866a87a1fb0932df5af8bd.

Still/Again fails to build.
See https://lists.freedesktop.org/archives/libreoffice/2022-June/089026.html

Change-Id: I195c1584256d1da5fee3bbd1d7291a6639428acf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135771
Tested-by: Jenkins
Tested-by: René Engelhard 
Reviewed-by: René Engelhard 
(cherry picked from commit 5b5c91190c60088c6998166250acc55574d5b543)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136014

diff --git a/config_host/config_skia.h.in b/config_host/config_skia.h.in
index c81e648a0d6f..b98ba14d31ec 100644
--- a/config_host/config_skia.h.in
+++ b/config_host/config_skia.h.in
@@ -62,10 +62,6 @@ are the same.
 // the default X11 visual is actually also BGRA.
 #define SK_R32_SHIFT 16
 
-// Enable skia on big-endian too. Despite the disclaimer it reportedly
-// actually works fine.
-#define I_ACKNOWLEDGE_SKIA_DOES_NOT_SUPPORT_BIG_ENDIAN 1
-
 // Enable Skia's internal checks depending on DBG_UTIL mode. ENABLE_SKIA_DEBUG
 // controls whether to build with or without optimizations (set in Makefile).
 #ifdef DBG_UTIL

[Libreoffice-commits] core.git: config_host/config_skia.h.in

[Rene Engelhard (via logerrit)]

 config_host/config_skia.h.in |4 
 1 file changed, 4 deletions(-)

New commits:
commit 26cc731adeba5ac434f7ee76a4fe5b57e42c6702
Author: Rene Engelhard 
AuthorDate: Mon Jun 13 18:28:34 2022 +0200
Commit: René Engelhard 
CommitDate: Thu Jun 16 18:14:48 2022 +0200

Revert "enable Skia on big-endian too"

This reverts commit b06663135f9c7c08f5866a87a1fb0932df5af8bd.

Still/Again fails to build.
See https://lists.freedesktop.org/archives/libreoffice/2022-June/089026.html

Change-Id: I195c1584256d1da5fee3bbd1d7291a6639428acf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135771
Tested-by: Jenkins
Tested-by: René Engelhard 
Reviewed-by: René Engelhard 

diff --git a/config_host/config_skia.h.in b/config_host/config_skia.h.in
index c81e648a0d6f..b98ba14d31ec 100644
--- a/config_host/config_skia.h.in
+++ b/config_host/config_skia.h.in
@@ -62,10 +62,6 @@ are the same.
 // the default X11 visual is actually also BGRA.
 #define SK_R32_SHIFT 16
 
-// Enable skia on big-endian too. Despite the disclaimer it reportedly
-// actually works fine.
-#define I_ACKNOWLEDGE_SKIA_DOES_NOT_SUPPORT_BIG_ENDIAN 1
-
 // Enable Skia's internal checks depending on DBG_UTIL mode. ENABLE_SKIA_DEBUG
 // controls whether to build with or without optimizations (set in Makefile).
 #ifdef DBG_UTIL

[Libreoffice-commits] core.git: configure.ac

[Rene Engelhard (via logerrit)]

 configure.ac |4 
 1 file changed, 4 insertions(+)

New commits:
commit cd35eebe4dde6e012c2a939461a87b58b2b7a497
Author: Rene Engelhard 
AuthorDate: Mon Jun 13 18:30:05 2022 +0200
Commit: René Engelhard 
CommitDate: Thu Jun 16 18:14:02 2022 +0200

fail big-endian builds with --enable-skia. Point to --disable-skia

Change-Id: I0a1e5289a36e39eeea00e0fd67fbcf1fe7c902f8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135772
Tested-by: Jenkins
Reviewed-by: Michael Meeks 
Tested-by: René Engelhard 
Reviewed-by: René Engelhard 

diff --git a/configure.ac b/configure.ac
index 8c24eb84fd5e..2963f05e3326 100644
--- a/configure.ac
+++ b/configure.ac
@@ -12078,6 +12078,10 @@ if test "$enable_skia" != "no" -a "$build_skia" = 
"yes" -a -z "$DISABLE_GUI"; th
 ENABLE_SKIA_DEBUG=
 fi
 ENABLE_SKIA=TRUE
+   if test "$ENDIANNESS" = "big" && test "$ENABLE_SKIA" = "TRUE"; then
+   AC_MSG_ERROR([skia doesn't work/isn't supported upstream on 
big-endian. Use --disable-skia])
+   fi
+
 AC_DEFINE(HAVE_FEATURE_SKIA)
 BUILD_TYPE="$BUILD_TYPE SKIA"
 

[Libreoffice-bugs] [Bug 149586] Crash in: __scrt_throw_std_bad_alloc()

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149586

--- Comment #2 from tsatt...@outlook.com ---
I upgraded to 7.3.4.2.  
I checked Options and confirmed that the 'force Skia' box is already checked.
I received the same abend.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/qa

[Xisco Fauli (via logerrit)]

 0 files changed

New commits:
commit b1c1a4ed4874f95683325856efe4722444a7a828
Author: Xisco Fauli 
AuthorDate: Thu Jun 16 14:27:51 2022 +0200
Commit: Xisco Fauli 
CommitDate: Thu Jun 16 18:02:51 2022 +0200

sc: uitest: move test where it belongs

Change-Id: I59ce2a70622a6f3be112a5234a7d91d2efd372f1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135996
Tested-by: Xisco Fauli 
Reviewed-by: Xisco Fauli 

diff --git a/sc/qa/uitest/calc_tests9/tdf130371.py 
b/sc/qa/uitest/range_name/tdf130371.py
similarity index 100%
rename from sc/qa/uitest/calc_tests9/tdf130371.py
rename to sc/qa/uitest/range_name/tdf130371.py

[Libreoffice-commits] core.git: sw/source

[Julien Nabet (via logerrit)]

 sw/source/core/frmedt/feshview.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 2332a1ce5409c1a47d4ef6265a6377a67a8b2fd2
Author: Julien Nabet 
AuthorDate: Sun Jun 12 10:09:49 2022 +0200
Commit: Xisco Fauli 
CommitDate: Thu Jun 16 17:54:32 2022 +0200

tdf#149524: fix crash in Writer after a label has just been created

see bt here:
https://bugs.documentfoundation.org/attachment.cgi?id=180683

Change-Id: Iba461ffe65392a7e0e779f68d1f0737a444ae724
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135675
Tested-by: Jenkins
Tested-by: Heiko Tietze 
Reviewed-by: Heiko Tietze 
Reviewed-by: Xisco Fauli 

diff --git a/sw/source/core/frmedt/feshview.cxx 
b/sw/source/core/frmedt/feshview.cxx
index 464cd46412b6..8369004ac3c5 100644
--- a/sw/source/core/frmedt/feshview.cxx
+++ b/sw/source/core/frmedt/feshview.cxx
@@ -1865,8 +1865,8 @@ bool SwFEShell::EndCreate( SdrCreateCmd eSdrCreateCmd )
 
 bool SwFEShell::ImpEndCreate()
 {
-OSL_ENSURE( Imp()->GetDrawView()->GetMarkedObjectList().GetMarkCount() == 
1,
-"New object not selected." );
+if (Imp()->GetDrawView()->GetMarkedObjectList().GetMarkCount() == 0)
+return false;
 
 SdrObject& rSdrObj = 
*Imp()->GetDrawView()->GetMarkedObjectList().GetMark(0)->GetMarkedSdrObj();
 

[Libreoffice-bugs] [Bug 149587] Using the CMD shortcuts for styles causes app to crash.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149587

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #1 from Julien Nabet  ---
Which type of processor do you use (ARM, Intel) and what's macos version?

2 things to try:
1) Upgrade to 7.3.4

2) Take a look at
https://wiki.documentfoundation.org/QA/FirstSteps#Corrupted_user_profile

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149582] CRASH: in SwPageFrame::Cut()

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149582

Julien Nabet  changed:

   What|Removed |Added

   Keywords||haveBacktrace
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149582] CRASH: in SwPageFrame::Cut()

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149582

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #1 from Julien Nabet  ---
Created attachment 180798
  --> https://bugs.documentfoundation.org/attachment.cgi?id=180798=edit
bt with debug symbols

On pc Debian x86-64 with master sources updated today, I could reproduce this.

I also noticed these logs on console:
warn:legacy.osl:1212122:1212122:svx/source/dialog/rulritem.cxx:480: Wrong
MemberId!
warn:legacy.osl:1212122:1212122:svx/source/dialog/rulritem.cxx:480: Wrong
MemberId!
warn:legacy.osl:1212122:1212122:sw/source/core/frmedt/tblsel.cxx:1778:
MakeSelUnions with pStart or pEnd not in CellFrame
warn:legacy.osl:1212122:1212122:sw/source/core/frmedt/tblsel.cxx:1778:
MakeSelUnions with pStart or pEnd not in CellFrame
warn:legacy.osl:1212122:1212122:sw/source/core/frmedt/tblsel.cxx:1778:
MakeSelUnions with pStart or pEnd not in CellFrame

-- 
You are receiving this mail because:
You are the assignee for the bug.