[Libreoffice-commits] core.git: sw/source
sw/source/core/unocore/unosett.cxx | 30 +-
1 file changed, 13 insertions(+), 17 deletions(-)
New commits:
commit 28597ee6f713baa6833e6e7837faac46ba5c173a
Author: Stephan Bergmann
AuthorDate: Tue Jun 21 23:10:30 2022 +0200
Commit: Stephan Bergmann
CommitDate: Wed Jun 22 07:58:56 2022 +0200
Make code a bit more explicit
...and avoid the ugly unsigned short vs. SvxAdjust mismatch
Change-Id: Ie820b5fda00942d258668535598027f9d878c013
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136264
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/sw/source/core/unocore/unosett.cxx
b/sw/source/core/unocore/unosett.cxx
index a871d4f1c844..dcc6f1fb7abd 100644
--- a/sw/source/core/unocore/unosett.cxx
+++ b/sw/source/core/unocore/unosett.cxx
@@ -250,16 +250,6 @@ const o3tl::enumarray aSvxToUnoAdjust
sal_Int16(-1)
};
-const unsigned short aUnoToSvxAdjust[] =
-{
-USHRT_MAX,
-static_cast(SvxAdjust::Right), // 1
-static_cast(SvxAdjust::Center), // 3
-static_cast(SvxAdjust::Left),// 0
-USHRT_MAX,
-USHRT_MAX
-};
-
OUString SwXFootnoteProperties::getImplementationName()
{
return "SwXFootnoteProperties";
@@ -1537,14 +1527,20 @@ void SwXNumberingRules::SetPropertiesToNumFormat(
{
sal_Int16 nValue = text::HoriOrientation::NONE;
rProp.Value >>= nValue;
-if (nValue > text::HoriOrientation::NONE &&
-nValue <= text::HoriOrientation::LEFT &&
-USHRT_MAX != aUnoToSvxAdjust[nValue])
-{
-
aFormat.SetNumAdjust(static_cast(aUnoToSvxAdjust[nValue]));
-}
-else
+switch (nValue) {
+case text::HoriOrientation::RIGHT:
+aFormat.SetNumAdjust(SvxAdjust::Right);
+break;
+case text::HoriOrientation::CENTER:
+aFormat.SetNumAdjust(SvxAdjust::Center);
+break;
+case text::HoriOrientation::LEFT:
+aFormat.SetNumAdjust(SvxAdjust::Left);
+break;
+default:
bWrongArg = true;
+break;
+}
}
else if (rProp.Name == UNO_NAME_PARENT_NUMBERING)
{
[Libreoffice-bugs] [Bug 149635] FEATURE REQUEST: remove "after" separator in cross-reference to numbered list item
https://bugs.documentfoundation.org/show_bug.cgi?id=149635 --- Comment #2 from ajlittoz --- Update to > But authors expect the final separator to be suppressed, be it > multi-character or different from full stop. Thinking about it, suppression is more complicated. List number may be decorated with both Before and After separators. Both should be suppressed. This requires querying the level in the list style definition or retrieving the multi-level counter without adding the "side" separators. == Example for single-level list: [1] Step one [2] Step two In step 2 above, … == end of example == Example for multi-level list: [1] Step one <1.1> First sub-step in first step In action 1.1 above, … == end of example *** The following remark is not part of the present feature request. *** List style allows to define many decorators (before and after separators at each level) but the "internal" separator is hard-coded at full stop. It can't be replaced by a dash for example. Is there a "typographical" reason for it? It don't see an exclusive agreement in books. Other conventions exist. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 149635] FEATURE REQUEST: remove "after" separator in cross-reference to numbered list item
https://bugs.documentfoundation.org/show_bug.cgi?id=149635 --- Comment #2 from ajlittoz --- Update to > But authors expect the final separator to be suppressed, be it > multi-character or different from full stop. Thinking about it, suppression is more complicated. List number may be decorated with both Before and After separators. Both should be suppressed. This requires querying the level in the list style definition or retrieving the multi-level counter without adding the "side" separators. == Example for single-level list: [1] Step one [2] Step two In step 2 above, … == end of example == Example for multi-level list: [1] Step one <1.1> First sub-step in first step In action 1.1 above, … == end of example *** The following remark is not part of the present feature request. *** List style allows to define many decorators (before and after separators at each level) but the "internal" separator is hard-coded at full stop. It can't be replaced by a dash for example. Is there a "typographical" reason for it? It don't see an exclusive agreement in books. Other conventions exist. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 91566] add different access to list of sheets
https://bugs.documentfoundation.org/show_bug.cgi?id=91566 --- Comment #7 from Jaise James --- Created attachment 180886 --> https://bugs.documentfoundation.org/attachment.cgi?id=180886=edit Sheet list view in Onlyoffice Sheet list view in Libreoffice is very good feature. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149666] Units in Individual Gits on Sourceforge.net for Source-code: //sourceforge.net/projects/libraoffice to be heuristically added!!
https://bugs.documentfoundation.org/show_bug.cgi?id=149666 Buovjaga changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 90796] [META] HiDPI / Retina bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=90796 Aron Budea changed: What|Removed |Added Depends on|149291 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149291 [Bug 149291] Mouse cursor freeze if I resize sidebar in Writer / Calc -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141294] Decks of Sidebar on HiDPI gets stuck in resize loop upon attempted width adjustment, work around of setting new SB "MinimumWidth" to false in expert config
https://bugs.documentfoundation.org/show_bug.cgi?id=141294 Aron Budea changed: What|Removed |Added CC||libreoffice.p-foerster@gmx. ||de --- Comment #14 from Aron Budea --- *** Bug 149291 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149291] Mouse cursor freeze if I resize sidebar in Writer / Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=149291 Aron Budea changed: What|Removed |Added CC||aron.bu...@gmail.com Resolution|--- |DUPLICATE Blocks|90796 | Status|UNCONFIRMED |RESOLVED --- Comment #5 from Aron Budea --- Looks like a duplicate of bug 141294. *** This bug has been marked as a duplicate of bug 141294 *** Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=90796 [Bug 90796] [META] HiDPI / Retina bugs -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149621] PDF documentation files downloaded from motherboard manufacturers require password that doesn't exist.
https://bugs.documentfoundation.org/show_bug.cgi?id=149621 --- Comment #8 from S.B. --- That's OK :-) The top of page 59 in the specification guide may be a clue as to where the failure is occurring (detection of the default user password which should trigger an automatic decryption). Perhaps check the routine in LibreOffice that reads the "padding string" to make sure it is being read correctly? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147873] LO 7.2.5.2 Calc Eventual Freezing Crash in Mac silicon M1 Mac Book Pro
https://bugs.documentfoundation.org/show_bug.cgi?id=147873 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149482] XModifyListener triggering infinite creation of new sheets
https://bugs.documentfoundation.org/show_bug.cgi?id=149482 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149477] XLSX parser/generator ignores SpreadsheetML string encoding
https://bugs.documentfoundation.org/show_bug.cgi?id=149477 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149637] Transparency on background image does not export to pdf
https://bugs.documentfoundation.org/show_bug.cgi?id=149637 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149637] Transparency on background image does not export to pdf
https://bugs.documentfoundation.org/show_bug.cgi?id=149637 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149605] Conflict with VoiceOver/NVDA
https://bugs.documentfoundation.org/show_bug.cgi?id=149605 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149605] Conflict with VoiceOver/NVDA
https://bugs.documentfoundation.org/show_bug.cgi?id=149605 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145793] Les tableaux dans Libre Office Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=145793 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145793] Les tableaux dans Libre Office Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=145793 --- Comment #3 from QA Administrators --- Dear Jacques Breuneval, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102495 Bug 102495 depends on bug 145787, which changed state. Bug 145787 Summary: Libreoffice 7.2 (Main) and Libreoffice 7.2 Writer crash crash on picture insert dialogue https://bugs.documentfoundation.org/show_bug.cgi?id=145787 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145787] Libreoffice 7.2 (Main) and Libreoffice 7.2 Writer crash crash on picture insert dialogue
https://bugs.documentfoundation.org/show_bug.cgi?id=145787 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145787] Libreoffice 7.2 (Main) and Libreoffice 7.2 Writer crash crash on picture insert dialogue
https://bugs.documentfoundation.org/show_bug.cgi?id=145787 --- Comment #6 from QA Administrators --- Dear Christian Haunert, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144930] LibreOffice v7.2.1 locked up my computer.
https://bugs.documentfoundation.org/show_bug.cgi?id=144930 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144930] LibreOffice v7.2.1 locked up my computer.
https://bugs.documentfoundation.org/show_bug.cgi?id=144930 --- Comment #4 from QA Administrators --- Dear scruffy-temp, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133903] Slow PDF export of sheet with charts based on large dataset (Print to PDF is fast)
https://bugs.documentfoundation.org/show_bug.cgi?id=133903 --- Comment #7 from QA Administrators --- Dear Telesto, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149667] hanahiroki88
https://bugs.documentfoundation.org/show_bug.cgi?id=149667 hanahiroki88 changed: What|Removed |Added URL||https://eillsaptr.xyz/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149667] New: hanahiroki88
https://bugs.documentfoundation.org/show_bug.cgi?id=149667 Bug ID: 149667 Summary: hanahiroki88 Product: Document Liberation Project Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: libabw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: hanahirok...@gmail.com https://eillsaptr.xyz/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149666] Units in Individual Gits on Sourceforge.net for Source-code: //sourceforge.net/projects/libraoffice to be heuristically added!!
https://bugs.documentfoundation.org/show_bug.cgi?id=149666 --- Comment #1 from Gc. Jerrimough Sebastian Xaa --- Created attachment 180885 --> https://bugs.documentfoundation.org/attachment.cgi?id=180885=edit Chronolabs Cooperative -- Stien update from preleaked txt/txtheader systems -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149666] New: Units in Individual Gits on Sourceforge.net for Source-code: //sourceforge.net/projects/libraoffice to be heuristically added!!
https://bugs.documentfoundation.org/show_bug.cgi?id=149666 Bug ID: 149666 Summary: Units in Individual Gits on Sourceforge.net for Source-code: //sourceforge.net/projects/libraoffice to be heuristically added!! Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: empres...@outlook.com Description: For the Visual Scopic Interface to be LibraOffice Powered with the stien call header on https://chronolabs-cooperative.sourceforge.io/Stiens/Headers/Manette.txt on the timing bells as well as everyone eye goggles to have libraoffice systems we need each unit that individual component like: Wordprocessor; Database; Spreedsheet so on in individual gits on sourceforge.net not just one giant pack you can have endless amounts of gits on sourceforge.net!! Steps to Reproduce: 1. Source-code in none metastasized units of distribution 2. Even though will work in archive base need pharsing better in gits 3. SVN more for media, documents, icons, terms, etc. with revision numbers not checksum like git Actual Results: I have already pactched your sourceforge.net with: ChronolabsCoop-Stiens.tar.lzma which when someone makes a project or you have to send to all your projects on their webspace sourceforge.io/sourceforge.net to txt@ as well as c/c stien@ as an email from a whitelisted source which I have updated you can check them out at:: https://chronolabs-cooperative.sourceforge.io/Stiens/Control/Whitelists/ Expected Results: Then you need to add the username 'chronolabscoop' as well as additionally 'wishcraft' for just ISBN and 'sparx' for FSLB as a member to a project not developer it will automatically dial them in thee heuristics of the new generic Manette.txt on the timing bells; do kraussgrading as well as make it so we develop documents and database via foot fall and resources based in libraoffice; as the only site that support still stien's header even on the old txt/txtheader system call of: 'Source-code: //sourceforge.net/project/unixname'... Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: ### ## /etc/ntp.conf, stienheaders update; see stien master for help ## ## You may not change or alter any portion of this comment or credits ## of supporting developers from this source code or any supporting source code ## which is considered copyrighted (c) material of the original comment or credit authors. ## This program is distributed in the hope that it will be useful, ## but WITHOUT ANY WARRANTY; without even the implied warranty of ## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. ## ## @copyright Chronolabs Cooperative https://github.com/Chronolabs-Cooperative ## @license ACADEMIC APL 2 (https://sourceforge.net/u/chronolabscoop/wiki/Academic%20Public%20License%2C%20version%202.0/) ## @license GNU GPL 3 (http://www.gnu.org/licenses/gpl.html) ## @license CC (https://creativecommons.org/about/cclicenses/) ## @package scripts ## @subpackage defaults ## @since 499.11.12 ## @version 499.11.12 ## @author Dr. Simon Antony Roberts ## @author Gc. Fault Jenny Samantha Xaa ## @linkhttps://sourceforge.net/projects/chronolabs-cooperative ## @linkhttps://sourceforge.net/projects/stien ## @linkhttps://sourceforge.net/projects/vcf5 ## @linkhttps://sourceforge.net/projects/distancesid ## @linkhttps://internetfounder.wordpress.com ## ## ## ./. ## bit.ly/MoneyStiens ## bit.ly/Kustomised unblock sourceforge.net "@jerrimoughxaa @RegaltyFamily import-uri://chronolabs-cooperative.sourceforge.io/Stiens/" confirm daily define Assiopath.stien define Assiopathic.stien define Bainuate.stien define Baituate.stien define Enchassiment.stien define Inchassiment.stien define Indigenous.stien define Offworld.stien define Outworld.stien define Sponiate.stien define Spotiate.stien print ChronolabsCoop-Complete.anyname by Tiesaa Binders with Coverslip confirm daily print --ChronolabsCoop-Complete.7z by Tiesaa Binders with Coverslip confirm daily print ChronolabsCoop-Complete.7z by Tiesaa Binders with Coverslip confirm daily print --ChronolabsCoop-Complete.7z by Tiesaa Binders with Coverslip confirm daily print ChronolabsCoop-Complete.7z by Tiesaa Binders with Coverslip confirm daily print society-grumpy-old-individuals.jpg (Poster-Ax-Random) by Tiesaa Binders with Coverslip print The Physics Department Galantus by Tiesaa Binders with Covernote print The Physics Department Galantus (Poster-Ax-Random) by Tiesaa Binders with Covernote ## /./ ## ## You can with a delivery dock reciept with your visual scopic interface in PDF if you
[Libreoffice-bugs] [Bug 149619] unresponsive document, lowriter freezes, brk(0xfffc000) = 0xfffc000
https://bugs.documentfoundation.org/show_bug.cgi?id=149619 Scott Clewell changed: What|Removed |Added CC||sclew...@protonmail.com --- Comment #2 from Scott Clewell --- Thanks for reporting vis_qa! I cannot repo but it does take 25 seconds for this to open on both these versions of LO: Version: 7.3.4.2 / LibreOffice Community Build ID: 30(Build:2) CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Ubuntu package version: 1:7.3.4~rc2-0ubuntu0.20.04.1~lo1 Calc: threaded Version: 7.4.0.0.alpha1+ / LibreOffice Community Build ID: c1898a4d1b38e0077416a104e2b47573ce207ffa CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149626] HANG during basic macro using com.sun.star.datatransfer.dnd
https://bugs.documentfoundation.org/show_bug.cgi?id=149626 --- Comment #2 from dominic.coo...@domelia.co.uk --- Created attachment 180884 --> https://bugs.documentfoundation.org/attachment.cgi?id=180884=edit Backtrace Further to the above, I have added a backtrace. I am nowhere near enough knowlegdable about the workings of the LibO engine, but the point of hanging seems to be when it acquires a mutex lock at vcl/source/window/dndeventdispatcher.cxx:156. Only problem is that this code has been in place for some months now, so it doesn't explain the sudden crash, but perhaps something else has also obtained a mutex on another thread or in the background? Hope this helps! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149665] Cannot enter a single quotation mark followed by on or more digits into a cell via keyboard
https://bugs.documentfoundation.org/show_bug.cgi?id=149665 --- Comment #2 from LeroyG --- I think that a double apostrophe (U+27 U+27) at the beginning of a cell says that all cell content is text, and all cell content must be showed. For me this is not a bug. By the way, you can type: - "‘" (left single quotation mark, the same that U+2018) or "’" (right single quotation mark, the same that U+2019) - "1" and it would work fine. If AutoCorrect option "[x] Replace" for Single Quotes is checked, you can type: - "'" apostrophe (or, maybe, a space or whatever character except "=", "+", and "-") - "'" apostrophe (it is not the same than a single quotation mark, but in this position will be converted to a right single quotation mark)¹ - "1" Press: - F2 key (to enter edit mode) - Home key - Del key (to delete the space) - Enter ¹ A left single quotation mark if the first typed a space. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sc/source
sc/source/core/tool/compiler.cxx |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
New commits:
commit 9f3bce835e81dbdf07da9850a5157f4403819417
Author: Eike Rathke
AuthorDate: Tue Jun 21 23:06:45 2022 +0200
Commit: Eike Rathke
CommitDate: Wed Jun 22 01:19:04 2022 +0200
Related: tdf#142293 Consider bAsciiUpper for matching CharClass to lowercase
... as also that may had lead to the locale's uppercase.
Change-Id: I5c75b4e52260539f5b66c0d2195b2137c9b1b8ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136265
Reviewed-by: Eike Rathke
Tested-by: Jenkins
(cherry picked from commit 537d69b6f1c32e5b938d9ef24c4154a08d565363)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136237
diff --git a/sc/source/core/tool/compiler.cxx b/sc/source/core/tool/compiler.cxx
index 301d90ed3b7a..2945062f1b37 100644
--- a/sc/source/core/tool/compiler.cxx
+++ b/sc/source/core/tool/compiler.cxx
@@ -4464,6 +4464,7 @@ bool ScCompiler::NextNewToken( bool bInArray )
// ParseReference().
OUString aUpper;
+bool bAsciiUpper = false;
Label_Rewind:
@@ -4483,7 +4484,7 @@ Label_Rewind:
mbRewind = false;
aUpper.clear();
-bool bAsciiUpper = false;
+bAsciiUpper = false;
if (bAsciiNonAlnum)
{
@@ -4554,6 +4555,8 @@ Label_Rewind:
// more likely in that localized language than in the formula
// language. This in corner cases needs to continue to work for
// existing documents and environments.
+// Do not change bAsciiUpper from here on for the lowercase() call
+// below in the ocBad case to use the correct CharClass.
aUpper = ScGlobal::getCharClass().uppercase( aOrg );
}
@@ -4618,7 +4621,7 @@ Label_Rewind:
// would prematurely end compilation. Simple unknown names are handled by
// the interpreter.
// Use the same CharClass that was used for uppercase.
-aUpper = (mbCharClassesDiffer ? ScGlobal::getCharClass() :
*pCharClass).lowercase( aUpper );
+aUpper = ((bAsciiUpper || mbCharClassesDiffer) ? ScGlobal::getCharClass()
: *pCharClass).lowercase( aUpper );
svl::SharedString aSS = rDoc.GetSharedStringPool().intern(aUpper);
maRawToken.SetString(aSS.getData(), aSS.getDataIgnoreCase());
maRawToken.NewOpCode( ocBad );
[Libreoffice-bugs] [Bug 149664] Cannot enter a single quotation mark followed by on or more digits into a cell
https://bugs.documentfoundation.org/show_bug.cgi?id=149664 LeroyG changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #1 from LeroyG --- *** This bug has been marked as a duplicate of bug 149665 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149665] Cannot enter a single quotation mark followed by on or more digits into a cell via keyboard
https://bugs.documentfoundation.org/show_bug.cgi?id=149665 --- Comment #1 from LeroyG --- *** Bug 149664 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149661] [Feature request] Automatic table-background-coloring ported from Calc to Writer.
https://bugs.documentfoundation.org/show_bug.cgi?id=149661 --- Comment #3 from Sion --- Agree, that everything should be paste-able. It would also solve another related problem I have. (Maybe I should open another ticket for this problem?) I have a field with data that is not compatible with the Color Scale function: it is a field with times, it was originally measured in minutes, but I didn't like it, so I translated that field to be more readable, but it is incompatible now: ex: Old time: 230 (minutes) New time: 3h 50m (my "translation") I would like to use the "Old time" field to generate the background colors, (then "lock" the colors?), and then "paste" those colors into the "New time" field, without changing the colors in the new field. I think there is some very roundabout way to do this, I saw something about mapping letters to numbers, so it was possible to sort fields by text, or something like that, so maybe it is possible to map "3h 50m" to the value "230", but as said, it is a VERY roundabout way. Another solution would be to type the "New Time" field as: "3h 50m (230)" and then use a Regular-Expression to extract the "230" part of that text & use that for sorting. Or a 3rd solution, would be to use a different "Source Column" (= "Old Time"), and use that column to generate the colors, and then have a "Destination Column" (= "New Time") where the colors is inserted. Maybe it can be written with a similar syntax as eg. VLOOKUP() or ROUND() or similar functions? Something like: BACKGROUND_COLOR(source_range; target_range) or something like that? (But again, maybe I should open another ticket for this problem?) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/source
sc/source/core/tool/compiler.cxx |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
New commits:
commit 086055b0d7e44d1d07b3f23af55503e6a3924d87
Author: Eike Rathke
AuthorDate: Tue Jun 21 23:06:45 2022 +0200
Commit: Eike Rathke
CommitDate: Wed Jun 22 00:23:51 2022 +0200
Related: tdf#142293 Consider bAsciiUpper for matching CharClass to lowercase
... as also that may had lead to the locale's uppercase.
Change-Id: I5c75b4e52260539f5b66c0d2195b2137c9b1b8ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136265
Reviewed-by: Eike Rathke
Tested-by: Jenkins
diff --git a/sc/source/core/tool/compiler.cxx b/sc/source/core/tool/compiler.cxx
index 301d90ed3b7a..2945062f1b37 100644
--- a/sc/source/core/tool/compiler.cxx
+++ b/sc/source/core/tool/compiler.cxx
@@ -4464,6 +4464,7 @@ bool ScCompiler::NextNewToken( bool bInArray )
// ParseReference().
OUString aUpper;
+bool bAsciiUpper = false;
Label_Rewind:
@@ -4483,7 +4484,7 @@ Label_Rewind:
mbRewind = false;
aUpper.clear();
-bool bAsciiUpper = false;
+bAsciiUpper = false;
if (bAsciiNonAlnum)
{
@@ -4554,6 +4555,8 @@ Label_Rewind:
// more likely in that localized language than in the formula
// language. This in corner cases needs to continue to work for
// existing documents and environments.
+// Do not change bAsciiUpper from here on for the lowercase() call
+// below in the ocBad case to use the correct CharClass.
aUpper = ScGlobal::getCharClass().uppercase( aOrg );
}
@@ -4618,7 +4621,7 @@ Label_Rewind:
// would prematurely end compilation. Simple unknown names are handled by
// the interpreter.
// Use the same CharClass that was used for uppercase.
-aUpper = (mbCharClassesDiffer ? ScGlobal::getCharClass() :
*pCharClass).lowercase( aUpper );
+aUpper = ((bAsciiUpper || mbCharClassesDiffer) ? ScGlobal::getCharClass()
: *pCharClass).lowercase( aUpper );
svl::SharedString aSS = rDoc.GetSharedStringPool().intern(aUpper);
maRawToken.SetString(aSS.getData(), aSS.getDataIgnoreCase());
maRawToken.NewOpCode( ocBad );
[Libreoffice-bugs] [Bug 123305] Libreoffice rendering on HDPI displays blurred
https://bugs.documentfoundation.org/show_bug.cgi?id=123305 rscra...@gmail.com changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #28 from rscra...@gmail.com --- Set from 'NEEDINFO' to 'UNCONFIRMED'. Only icons were blurry. Version: 7.3.4.2 / LibreOffice Community Build ID: 30(Build:2) CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Ubuntu package version: 1:7.3.4~rc2-0ubuntu0.22.04.1~lo1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: bin/crashreportScraper.py
bin/crashreportScraper.py |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
New commits:
commit 6b15decd0acc2c7c0622baba65b9d4c019a4183a
Author: Xisco Fauli
AuthorDate: Tue Jun 21 15:40:33 2022 +0200
Commit: Xisco Fauli
CommitDate: Tue Jun 21 23:51:50 2022 +0200
crashreportScraper: encode the url
Change-Id: I1f738f017966a6fe48dd9e2cf36dbdf5f50c0cef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136229
Tested-by: Xisco Fauli
Reviewed-by: Xisco Fauli
diff --git a/bin/crashreportScraper.py b/bin/crashreportScraper.py
index 513f5ec7b75d..cad7feead645 100755
--- a/bin/crashreportScraper.py
+++ b/bin/crashreportScraper.py
@@ -17,6 +17,7 @@ import sys
import os
import math
from datetime import datetime
+import urllib.parse
def convert_str_to_date(value):
value = value.replace('.', '')
@@ -194,11 +195,11 @@ if __name__ == '__main__':
f.flush()
for k, lDate in crashes.items():
-if len(k) < 254 and k not in crashesInFile and '`' not in k:
+if k not in crashesInFile:
print("Parsing " + k)
try:
crashCount, crashID, crashVersion, crashOS =
parse_reports_and_get_most_recent_report_from_last_page(
-
"https://crashreport.libreoffice.org/stats/signature/; + k)
+
"https://crashreport.libreoffice.org/stats/signature/; + urllib.parse.quote(k))
crashReason, crashStack, codeLine =
parse_details_and_get_info(
"https://crashreport.libreoffice.org/stats/crash_details/; + crashID,
args.repository)
line = '\t'.join([k, str(crashCount), lDate[1], lDate[2],
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-4+backports' - sw/qa sw/source
sw/qa/extras/uiwriter/uiwriter2.cxx | 95
sw/source/core/doc/DocumentContentOperationsManager.cxx |4
sw/source/core/doc/docedt.cxx |7 +
sw/source/core/inc/UndoRedline.hxx |8 +
sw/source/core/inc/mvsave.hxx |3
sw/source/core/undo/unredln.cxx | 34 +
6 files changed, 144 insertions(+), 7 deletions(-)
New commits:
commit 650d0ead161303f30faa2de0bb4e20fceafc2af8
Author: Michael Stahl
AuthorDate: Wed Jun 15 15:06:59 2022 +0200
Commit: Thorsten Behrens
CommitDate: Tue Jun 21 23:43:19 2022 +0200
tdf#135976 sw: preserve flys on backspace/delete with redlining enabled
This is a continuation of commit 85376a02348810812d515ee72140dbf56f2b6040
for the case when redlining is turned on.
Also try to restore the anchors in SwUndoRedlineDelete.
(regression from commit 3345feb67f2c49a1b76639965b56968e1c5f03ee)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135909
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 932a8efce878547bfd81521d0cf1ddfe8dc33ec6)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135968
Reviewed-by: Thorsten Behrens
(cherry picked from commit 03834f003c56e6646e3b274c418acd4fc344fd8e)
sw: fix odd m_bCanGroup check in SwUndoRedlineDelete
This looks like copypasta, presumably both flags must be true to allow
grouping.
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135908
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit f31f11f3222933dbc96dc672e6fa52233cda12be)
Change-Id: I4199f5755398d469a606618c037ad9756cb7aeba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136223
Tested-by: Thorsten Behrens
Reviewed-by: Thorsten Behrens
diff --git a/sw/qa/extras/uiwriter/uiwriter2.cxx
b/sw/qa/extras/uiwriter/uiwriter2.cxx
index e00e27548fcc..1418ddd0ae51 100644
--- a/sw/qa/extras/uiwriter/uiwriter2.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter2.cxx
@@ -28,6 +28,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -958,6 +959,100 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testTdf139982)
CPPUNIT_ASSERT_EQUAL(size_t(1), pWrtShell->GetFlyCount(FLYCNTTYPE_FRM));
}
+CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testTdf135976)
+{
+SwDoc* const pDoc = createDoc();
+SwWrtShell* const pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+
+pWrtShell->Insert("foobar");
+
+pWrtShell->Left(CRSR_SKIP_CHARS, /*bSelect=*/false, 2,
/*bBasicCall=*/false);
+SwFormatAnchor anchor(RndStdIds::FLY_AT_CHAR);
+anchor.SetAnchor(pWrtShell->GetCursor()->GetPoint());
+SfxItemSet flySet(pDoc->GetAttrPool(), svl::Items{});
+flySet.Put(anchor);
+SwFrameFormat const* pFly = pWrtShell->NewFlyFrame(flySet,
/*bAnchValid=*/true);
+CPPUNIT_ASSERT(pFly != nullptr);
+
+// turn on redlining and show changes
+pDoc->getIDocumentRedlineAccess().SetRedlineFlags(RedlineFlags::On |
RedlineFlags::ShowDelete
+ |
RedlineFlags::ShowInsert);
+lcl_dispatchCommand(mxComponent, ".uno:ShowTrackedChanges", {});
+CPPUNIT_ASSERT_MESSAGE("redlining should be on",
+ pDoc->getIDocumentRedlineAccess().IsRedlineOn());
+CPPUNIT_ASSERT_MESSAGE(
+"redlines should be visible",
+
IDocumentRedlineAccess::IsShowChanges(pDoc->getIDocumentRedlineAccess().GetRedlineFlags()));
+CPPUNIT_ASSERT(pWrtShell->GetLayout()->IsHideRedlines());
+
+CPPUNIT_ASSERT_EQUAL(size_t(1), pWrtShell->GetFlyCount(FLYCNTTYPE_FRM));
+CPPUNIT_ASSERT_EQUAL(size_t(1),
pWrtShell->GetLayout()->GetLastPage()->GetSortedObjs()->size());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(4),
pFly->GetAnchor().GetContentAnchor()->nContent.GetIndex());
+
+pWrtShell->UnSelectFrame();
+pWrtShell->SttEndDoc(/*bStart=*/false);
+pWrtShell->Left(CRSR_SKIP_CHARS, /*bSelect=*/false, 1,
/*bBasicCall=*/false);
+
+pWrtShell->DelLeft();
+pWrtShell->DelLeft();
+
+CPPUNIT_ASSERT_EQUAL(size_t(1), pWrtShell->GetFlyCount(FLYCNTTYPE_FRM));
+// the problem was that the fly was deleted from the layout
+CPPUNIT_ASSERT_EQUAL(size_t(1),
pWrtShell->GetLayout()->GetLastPage()->GetSortedObjs()->size());
+// check that the anchor was moved outside the redline
+CPPUNIT_ASSERT_EQUAL(sal_Int32(3),
pFly->GetAnchor().GetContentAnchor()->nContent.GetIndex());
+
+pWrtShell->Undo(2);
+
+CPPUNIT_ASSERT_EQUAL(size_t(1), pWrtShell->GetFlyCount(FLYCNTTYPE_FRM));
+CPPUNIT_ASSERT_EQUAL(size_t(1),
pWrtShell->GetLayout()->GetLastPage()->GetSortedObjs()->size());
+// check that the anchor was restored
+CPPUNIT_ASSERT_EQUAL(sal_Int32(4),
pFly->GetAnchor().GetContentAnchor()->nContent.GetIndex());
+
+pWrtShell->Redo(2);
+
+
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-4+backports' - sw/source
sw/source/core/doc/DocumentRedlineManager.cxx |6 ++
1 file changed, 6 insertions(+)
New commits:
commit 358197bcbbb2a24e2a4378786b494cf2ce360d15
Author: Michael Stahl
AuthorDate: Tue Jun 14 17:19:23 2022 +0200
Commit: Thorsten Behrens
CommitDate: Tue Jun 21 23:42:24 2022 +0200
sw_redlinehide: skip unnecessary updates when undoing redlined delete
When reproducing tdf#135976 and then Undo, an UAF crash happens here:
assert(!pFrame->GetDrawObjs() || !pObjs->Contains(*pObj));
The pObjs was actually deleted and then re-created, because the pObj was
removed from the frame and added again to the same frame.
This is a bit unexpected, so prevent it by taking a shortcut in the
caller UpdateFramesForRemoveDeleteRedline() to insert a check that had
been removed in commit 14e87a4b15d31a34e6053f6194688f3aa23af991.
If the rPam is inside a single node, the sw::RedlineUnDelText hint that
was sent to the SwTextFrame should be sufficient to update it and the
rest of the code in the loop that deals with newly split paragraph can
be skipped.
Change-Id: I5f36eb91bc20003887ee0bad03ea4a6e67135de9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135907
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit cf9a16caf5012d65b2a45a5525e36e40585dd35c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135892
Reviewed-by: Thorsten Behrens
(cherry picked from commit 918f435d48de3f29814f187c8621c1a564c5b835)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136222
Tested-by: Thorsten Behrens
diff --git a/sw/source/core/doc/DocumentRedlineManager.cxx
b/sw/source/core/doc/DocumentRedlineManager.cxx
index 8ae32f266bdb..e11c1c6f2c4b 100644
--- a/sw/source/core/doc/DocumentRedlineManager.cxx
+++ b/sw/source/core/doc/DocumentRedlineManager.cxx
@@ -283,6 +283,12 @@ void UpdateFramesForRemoveDeleteRedline(SwDoc & rDoc,
SwPaM const& rPam)
break;
}
+// no nodes can be unmerged by this - skip MakeFrames() etc.
+if (rPam.GetPoint()->nNode == rPam.GetMark()->nNode)
+{
+break; // continue with AppendAllObjs()
+}
+
// first, call CheckParaRedlineMerge on the first paragraph,
// to init flag on new merge range (if any) + 1st node post the
merge
auto eMode(sw::FrameMode::Existing);
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-4+backports' - sw/qa sw/source
sw/qa/extras/uiwriter/data/tdf148868.odt |binary
sw/qa/extras/uiwriter/uiwriter.cxx | 19 +++
sw/source/uibase/inc/wrtsh.hxx |2 +-
sw/source/uibase/wrtsh/delete.cxx|4 ++--
sw/source/uibase/wrtsh/wrtsh1.cxx|5 +++--
5 files changed, 25 insertions(+), 5 deletions(-)
New commits:
commit 88eedf2043759ff52be6887235bb8ced044d9d66
Author: Michael Stahl
AuthorDate: Fri Jun 10 18:25:05 2022 +0200
Commit: Thorsten Behrens
CommitDate: Tue Jun 21 23:41:51 2022 +0200
tdf#148868 sw: handle selection then Insert similar to Replace
... if the selection is inside one paragraph, to avoid deleting flys
anchored in the selection.
From a code point of view it's a bit inconsistent to do this, but
from user point of view there are some ways to conveniently create
a selection such as by double clicking a word.
(see also tdf#133957)
Also in SwWrtShell::AutoCorrect(), which oddly enough might get called
with a selection from textsh*.cxx, at least in theory.
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135606
Tested-by: Michael Stahl
Reviewed-by: Michael Stahl
(cherry picked from commit d72bee64a97650507d042f17846b6fc427b8434c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135839
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
(cherry picked from commit 67eec140556edb42280def88e987448aaa221c5e)
tdf#148868: sw_uiwriter3: Add unittest
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135827
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
(cherry picked from commit 4e8295638e68295d73b49ddb80e23c3509a49b3e)
Change-Id: I8cf9459e5a7ec7754ce8fe323cd158c7e84a5c93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136221
Tested-by: Michael Stahl
Reviewed-by: Michael Stahl
diff --git a/sw/qa/extras/uiwriter/data/tdf148868.odt
b/sw/qa/extras/uiwriter/data/tdf148868.odt
new file mode 100644
index ..7ebf68a82ea3
Binary files /dev/null and b/sw/qa/extras/uiwriter/data/tdf148868.odt differ
diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx
b/sw/qa/extras/uiwriter/uiwriter.cxx
index 5e99211ea450..007a597cf61c 100644
--- a/sw/qa/extras/uiwriter/uiwriter.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter.cxx
@@ -7750,6 +7750,25 @@ void SwUiWriterTest::testTdf38394()
CPPUNIT_ASSERT_EQUAL(sReplaced,
static_cast(pDoc->GetNodes()[nIndex])->GetText());
}
+CPPUNIT_TEST_FIXTURE(SwUiWriterTest, testTdf148868)
+{
+SwDoc* pDoc = createDoc("tdf148868.odt");
+SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+
+CPPUNIT_ASSERT_EQUAL(1, getShapes());
+CPPUNIT_ASSERT_EQUAL(1, getPages());
+
+pWrtShell->EndPg(/*bSelect=*/false);
+pWrtShell->Left(CRSR_SKIP_CHARS, /*bSelect=*/true, 5,
/*bBasicCall=*/false);
+pWrtShell->Insert("X");
+
+// Without the fix in place, this test would have failed with
+// - Expected: 1
+// - Actual : 0
+CPPUNIT_ASSERT_EQUAL(1, getShapes());
+CPPUNIT_ASSERT_EQUAL(1, getPages());
+}
+
CPPUNIT_TEST_FIXTURE(SwUiWriterTest, testTdf134021)
{
load(DATA_DIRECTORY, "tdf134021.docx");
diff --git a/sw/source/uibase/inc/wrtsh.hxx b/sw/source/uibase/inc/wrtsh.hxx
index 049cb3d9ae5c..cf780df77cf0 100644
--- a/sw/source/uibase/inc/wrtsh.hxx
+++ b/sw/source/uibase/inc/wrtsh.hxx
@@ -279,7 +279,7 @@ typedef bool (SwWrtShell:: *FNSimpleMove)();
boolDelLeft();
// also deletes the frame or sets the cursor in the frame when bDelFrame
== false
-boolDelRight();
+boolDelRight(bool isReplaceHeuristic = false);
voidDelToEndOfPara();
voidDelToStartOfPara();
boolDelToEndOfSentence();
diff --git a/sw/source/uibase/wrtsh/delete.cxx
b/sw/source/uibase/wrtsh/delete.cxx
index 5358876d204d..bf165d4d66a2 100644
--- a/sw/source/uibase/wrtsh/delete.cxx
+++ b/sw/source/uibase/wrtsh/delete.cxx
@@ -282,7 +282,7 @@ bool SwWrtShell::DelLeft()
return bRet;
}
-bool SwWrtShell::DelRight()
+bool SwWrtShell::DelRight(bool const isReplaceHeuristic)
{
// Will be or'ed, if a tableselection exists;
// will here be implemented on SelectionType::Table
@@ -309,7 +309,7 @@ bool SwWrtShell::DelRight()
{
SwActContext aActContext(this);
ResetCursorStack();
-Delete(false);
+Delete(isReplaceHeuristic);
UpdateAttr();
}
if( IsBlockMode() )
diff --git a/sw/source/uibase/wrtsh/wrtsh1.cxx
b/sw/source/uibase/wrtsh/wrtsh1.cxx
index 0840ed3cd407..53e8ae7a2fbd 100644
--- a/sw/source/uibase/wrtsh/wrtsh1.cxx
+++ b/sw/source/uibase/wrtsh/wrtsh1.cxx
@@ -244,7 +244,8 @@ void SwWrtShell::Insert( const OUString )
StartUndo(SwUndoId::REPLACE, );
bStarted = true;
Push();
-bDeleted = DelRight();
+// let's interpret a
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-4+backports' - sw/qa sw/source
sw/qa/extras/uiwriter/uiwriter2.cxx | 50
sw/source/core/doc/DocumentContentOperationsManager.cxx |9 ++
sw/source/core/doc/docedt.cxx |4 -
sw/source/core/inc/mvsave.hxx |2
4 files changed, 62 insertions(+), 3 deletions(-)
New commits:
commit 0ecea0cbef9400372818668d4afda454ff9b5b6a
Author: Michael Stahl
AuthorDate: Fri Jun 10 16:26:40 2022 +0200
Commit: Thorsten Behrens
CommitDate: Tue Jun 21 23:41:27 2022 +0200
tdf#139982 sw: preserve flys in Replace with redlining enabled
The problem is that there isn't a redline type "Replace" so it's
represented as Delete+Insert.
To prevent the flys anchored in the text from being deleted, move the
anchors to the point between the old (deleted) and new (inserted) text.
(regression from commit 28b77c89dfcafae82cf2a6d85731b643ff9290e5)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135604
Tested-by: Michael Stahl
Reviewed-by: Michael Stahl
(cherry picked from commit 646c6ddd91a98afddf914e3889cb269fc814c060)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135737
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
(cherry picked from commit b7ab83bd96c70932c2223c8d0b3bc0f24327cef2)
Change-Id: Ib600c9dbfb9421917e4b8d61195c48cf0b364f06
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136220
Tested-by: Michael Stahl
Reviewed-by: Michael Stahl
diff --git a/sw/qa/extras/uiwriter/uiwriter2.cxx
b/sw/qa/extras/uiwriter/uiwriter2.cxx
index 81c4c3e31c33..e00e27548fcc 100644
--- a/sw/qa/extras/uiwriter/uiwriter2.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter2.cxx
@@ -908,6 +908,56 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testTdf140007)
pDoc->GetNodes()[SwNodeOffset(11)]->GetTextNode()->GetText());
}
+CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testTdf139982)
+{
+SwDoc* const pDoc = createDoc();
+SwWrtShell* const pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+
+// turn on redlining and show changes
+pDoc->getIDocumentRedlineAccess().SetRedlineFlags(RedlineFlags::On |
RedlineFlags::ShowDelete
+ |
RedlineFlags::ShowInsert);
+CPPUNIT_ASSERT_MESSAGE("redlining should be on",
+ pDoc->getIDocumentRedlineAccess().IsRedlineOn());
+CPPUNIT_ASSERT_MESSAGE(
+"redlines should be visible",
+
IDocumentRedlineAccess::IsShowChanges(pDoc->getIDocumentRedlineAccess().GetRedlineFlags()));
+
+pWrtShell->Insert("helloo");
+
+pWrtShell->Left(CRSR_SKIP_CHARS, /*bSelect=*/false, 1,
/*bBasicCall=*/false);
+{
+SwFormatAnchor anchor(RndStdIds::FLY_AT_CHAR);
+anchor.SetAnchor(pWrtShell->GetCursor()->GetPoint());
+SfxItemSet flySet(pDoc->GetAttrPool(), svl::Items{});
+flySet.Put(anchor);
+SwFrameFormat const* pFly = pWrtShell->NewFlyFrame(flySet,
/*bAnchValid=*/true);
+CPPUNIT_ASSERT(pFly != nullptr);
+}
+
+pWrtShell->SttEndDoc(true);
+pWrtShell->EndPara(/*bSelect=*/true);
+
+CPPUNIT_ASSERT_EQUAL(size_t(1), pWrtShell->GetFlyCount(FLYCNTTYPE_FRM));
+
+pWrtShell->Replace("hello", true);
+
+// the problem was that a redline delete with the same author as redline
+// insert has its text deleted immediately, including anchored flys.
+CPPUNIT_ASSERT_EQUAL(size_t(1), pWrtShell->GetFlyCount(FLYCNTTYPE_FRM));
+
+pWrtShell->Undo();
+
+CPPUNIT_ASSERT_EQUAL(size_t(1), pWrtShell->GetFlyCount(FLYCNTTYPE_FRM));
+
+pWrtShell->Redo();
+
+CPPUNIT_ASSERT_EQUAL(size_t(1), pWrtShell->GetFlyCount(FLYCNTTYPE_FRM));
+
+pWrtShell->Undo();
+
+CPPUNIT_ASSERT_EQUAL(size_t(1), pWrtShell->GetFlyCount(FLYCNTTYPE_FRM));
+}
+
CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testTdf54819)
{
load(DATA_DIRECTORY, "tdf54819.fodt");
diff --git a/sw/source/core/doc/DocumentContentOperationsManager.cxx
b/sw/source/core/doc/DocumentContentOperationsManager.cxx
index 2db40c2e5d57..b6dc4158b936 100644
--- a/sw/source/core/doc/DocumentContentOperationsManager.cxx
+++ b/sw/source/core/doc/DocumentContentOperationsManager.cxx
@@ -4421,6 +4421,14 @@ bool DocumentContentOperationsManager::ReplaceRangeImpl(
SwPaM& rPam, const OUSt
InsertItemSet( aTmpRange, aSet );
}
+// tdf#139982: Appending the redline may immediately delete flys
+// anchored in the previous text if it's inside an insert redline.
+// Also flys will be deleted if the redline is accepted. Move them
+// to the position between the previous text and the new text,
+// there the chance of surviving both accept and reject is best.
+SaveFlyArr flys;
+SaveFlyInRange(aDelPam, *aDelPam.End(), flys, false);
+
if (m_rDoc.GetIDocumentUndoRedo().DoesUndo())
{
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-4+backports' - sw/qa sw/source
sw/qa/extras/uiwriter/uiwriter2.cxx | 88
sw/source/core/undo/unins.cxx |5 +-
2 files changed, 91 insertions(+), 2 deletions(-)
New commits:
commit 4f3677eff9d177489e836490d0deaf580c9e8458
Author: Michael Stahl
AuthorDate: Thu Jun 9 18:58:06 2022 +0200
Commit: Thorsten Behrens
CommitDate: Tue Jun 21 23:40:53 2022 +0200
tdf#140007 sw: fix SwUndoReplace
(regression from commit d6b0e84b236b78f4b21bd16e46dda3fa0876096d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135585
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 45613274794636ba98d0e978fe872511297d275d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135549
Reviewed-by: Xisco Fauli
(cherry picked from commit 7df50ecd9dea623058dc7bf9095fd13d9bb49860)
Change-Id: I1facf1584a349d1d087438f4e6fd3a63a80c6f7e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136219
Tested-by: Thorsten Behrens
Reviewed-by: Thorsten Behrens
diff --git a/sw/qa/extras/uiwriter/uiwriter2.cxx
b/sw/qa/extras/uiwriter/uiwriter2.cxx
index bdea12f0370a..81c4c3e31c33 100644
--- a/sw/qa/extras/uiwriter/uiwriter2.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter2.cxx
@@ -820,6 +820,94 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testTdf131912)
CPPUNIT_ASSERT_EQUAL(OUString("foo"), pWrtShell->GetCursor()->GetText());
}
+CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testTdf140007)
+{
+typedef sal_uLong SwNodeOffset;
+SwDoc* const pDoc = createDoc();
+SwWrtShell* const pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+
+pWrtShell->Insert("foo");
+pWrtShell->SplitNode();
+pWrtShell->Insert("bar");
+pWrtShell->SplitNode();
+pWrtShell->Insert("baz");
+CPPUNIT_ASSERT_EQUAL(sal_uLong(13), pDoc->GetNodes().Count());
+CPPUNIT_ASSERT_EQUAL(OUString("foo"),
+
pDoc->GetNodes()[SwNodeOffset(9)]->GetTextNode()->GetText());
+CPPUNIT_ASSERT_EQUAL(OUString("bar"),
+
pDoc->GetNodes()[SwNodeOffset(10)]->GetTextNode()->GetText());
+CPPUNIT_ASSERT_EQUAL(OUString("baz"),
+
pDoc->GetNodes()[SwNodeOffset(11)]->GetTextNode()->GetText());
+
+pWrtShell->SttEndDoc(true);
+pWrtShell->EndPara(false);
+pWrtShell->Right(CRSR_SKIP_CHARS, /*bSelect=*/true, 1,
/*bBasicCall=*/false);
+pWrtShell->Replace(" ", true);
+CPPUNIT_ASSERT_EQUAL(SwNodeOffset(12), pDoc->GetNodes().Count());
+CPPUNIT_ASSERT_EQUAL(OUString("foo bar"),
+
pDoc->GetNodes()[SwNodeOffset(9)]->GetTextNode()->GetText());
+CPPUNIT_ASSERT_EQUAL(OUString("baz"),
+
pDoc->GetNodes()[SwNodeOffset(10)]->GetTextNode()->GetText());
+
+pWrtShell->SttEndDoc(true);
+pWrtShell->EndPara(false);
+pWrtShell->Right(CRSR_SKIP_CHARS, /*bSelect=*/true, 1,
/*bBasicCall=*/false);
+pWrtShell->Replace(" ", true);
+CPPUNIT_ASSERT_EQUAL(OUString("foo bar baz"),
+
pDoc->GetNodes()[SwNodeOffset(9)]->GetTextNode()->GetText());
+CPPUNIT_ASSERT_EQUAL(SwNodeOffset(11), pDoc->GetNodes().Count());
+
+pWrtShell->Undo();
+
+CPPUNIT_ASSERT_EQUAL(SwNodeOffset(12), pDoc->GetNodes().Count());
+CPPUNIT_ASSERT_EQUAL(OUString("foo bar"),
+
pDoc->GetNodes()[SwNodeOffset(9)]->GetTextNode()->GetText());
+CPPUNIT_ASSERT_EQUAL(OUString("baz"),
+
pDoc->GetNodes()[SwNodeOffset(10)]->GetTextNode()->GetText());
+
+pWrtShell->Undo();
+
+CPPUNIT_ASSERT_EQUAL(SwNodeOffset(13), pDoc->GetNodes().Count());
+CPPUNIT_ASSERT_EQUAL(OUString("foo"),
+
pDoc->GetNodes()[SwNodeOffset(9)]->GetTextNode()->GetText());
+CPPUNIT_ASSERT_EQUAL(OUString("bar"),
+
pDoc->GetNodes()[SwNodeOffset(10)]->GetTextNode()->GetText());
+CPPUNIT_ASSERT_EQUAL(OUString("baz"),
+
pDoc->GetNodes()[SwNodeOffset(11)]->GetTextNode()->GetText());
+
+pWrtShell->Redo();
+
+CPPUNIT_ASSERT_EQUAL(SwNodeOffset(12), pDoc->GetNodes().Count());
+CPPUNIT_ASSERT_EQUAL(OUString("foo bar"),
+
pDoc->GetNodes()[SwNodeOffset(9)]->GetTextNode()->GetText());
+CPPUNIT_ASSERT_EQUAL(OUString("baz"),
+
pDoc->GetNodes()[SwNodeOffset(10)]->GetTextNode()->GetText());
+
+pWrtShell->Redo();
+
+CPPUNIT_ASSERT_EQUAL(OUString("foo bar baz"),
+
pDoc->GetNodes()[SwNodeOffset(9)]->GetTextNode()->GetText());
+CPPUNIT_ASSERT_EQUAL(SwNodeOffset(11), pDoc->GetNodes().Count());
+
+pWrtShell->Undo();
+
+CPPUNIT_ASSERT_EQUAL(SwNodeOffset(12), pDoc->GetNodes().Count());
+CPPUNIT_ASSERT_EQUAL(OUString("foo bar"),
+
pDoc->GetNodes()[SwNodeOffset(9)]->GetTextNode()->GetText());
+CPPUNIT_ASSERT_EQUAL(OUString("baz"),
+
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-4+backports' - sw/source
sw/source/core/undo/undobj.cxx | 12
1 file changed, 8 insertions(+), 4 deletions(-)
New commits:
commit c6a2033221c86166a2226023f34314eb59380fa2
Author: Michael Stahl
AuthorDate: Wed Jun 8 17:34:32 2022 +0200
Commit: Thorsten Behrens
CommitDate: Tue Jun 21 23:40:25 2022 +0200
(related: tdf#139514) sw: fix Undo of delete with at-para fly
Nonobviously, there are situations where the anchor node must be
preserved and restored when it's not on the node that is being deleted.
(probably regression from commit 91b2325808a75174f284c48c8b8afc118fad74e4)
Change-Id: I39f09ddb631204c8ad522f9ec7068d235ca94ad2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135509
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 12acdce71dd6b6af2c52ba8fa3248d3166418543)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135518
Reviewed-by: Miklos Vajna
(cherry picked from commit 054c248127c78521b4a4e7aacd8936bd54259996)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136218
Tested-by: Michael Stahl
diff --git a/sw/source/core/undo/undobj.cxx b/sw/source/core/undo/undobj.cxx
index 3fe7f107f052..d611cb4a496b 100644
--- a/sw/source/core/undo/undobj.cxx
+++ b/sw/source/core/undo/undobj.cxx
@@ -981,10 +981,14 @@ void SwUndoSaveContent::DelContentIndex( const
SwPosition& rMark,
// Moving the anchor?
else if
(!((DelContentType::CheckNoCntnt|DelContentType::ExcludeFlyAtStartEnd)
& nDelContentType) &&
-// at least for calls from SwUndoDelete,
-// this should work - other Undos don't
-// remember the order of the cursor
-(rPoint.nNode.GetIndex() ==
pAPos->nNode.GetIndex())
+// for SwUndoDelete: rPoint is the node that
+// will be Joined - so anchor should be moved
+// off it - but UndoImpl() split will insert
+// new node *before* existing one so a no-op
+// may need to be done here to add it to
+// history for Undo.
+(rPoint.nNode.GetIndex() ==
pAPos->nNode.GetIndex()
+ || pStt->nNode.GetIndex() ==
pAPos->nNode.GetIndex())
// Do not try to move the anchor to a table!
&& rMark.nNode.GetNode().IsTextNode())
{
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-4+backports' - sw/inc sw/qa sw/source
sw/inc/IDocumentContentOperations.hxx | 11 +++
sw/inc/editsh.hxx |4 -
sw/qa/core/uwriter.cxx |2
sw/source/core/doc/DocumentContentOperationsManager.cxx | 46
sw/source/core/docnode/ndsect.cxx |2
sw/source/core/docnode/ndtbl.cxx|2
sw/source/core/edit/autofmt.cxx |4 -
sw/source/core/edit/eddel.cxx |9 +--
sw/source/core/edit/edglbldc.cxx|2
sw/source/core/edit/editsh.cxx |4 -
sw/source/core/frmedt/fecopy.cxx|2
sw/source/core/inc/DocumentContentOperationsManager.hxx |9 +--
sw/source/core/inc/UndoDelete.hxx |3 +
sw/source/core/layout/atrfrm.cxx|2
sw/source/core/undo/undel.cxx | 21 +--
sw/source/core/undo/unins.cxx |2
sw/source/core/undo/unredln.cxx |4 -
sw/source/core/undo/untbl.cxx | 14 ++--
sw/source/uibase/dochdl/swdtflvr.cxx|2
sw/source/uibase/lingu/hhcwrp.cxx |4 -
sw/source/uibase/ribbar/inputwin.cxx|4 -
sw/source/uibase/wrtsh/delete.cxx | 26 -
sw/source/uibase/wrtsh/select.cxx |4 -
23 files changed, 109 insertions(+), 74 deletions(-)
New commits:
commit 6bd76edc7ffd82690068618e5b322787228bb5d2
Author: Michael Stahl
AuthorDate: Tue Jun 7 19:01:24 2022 +0200
Commit: Thorsten Behrens
CommitDate: Tue Jun 21 23:40:02 2022 +0200
tdf#133957 sw: don't delete flys on Backspace/Delete keys
Also fixes: tdf#134007 tdf#138835 tdf#139514
When a character is deleted via the keyboard by Backspace or Delete key,
an artificial selection is created in SwWrtShell::DelLeft()/DelRight().
Ideally this should not delete flys that may be anchored to the
paragraphs, but unfortunately this may happen if there are only 2 empty
paragraphs in the section, because then the artificial selection cannot
be distinguished by the SwDoc implementation from a selection from
Ctrl+A (Select All), which *should* delete the flys.
So introduce a new flag that needs to be passed down multiple layers so
that SwUndoDelete can use it to determine if flys should be deleted, and
translating it to a flag that had been introduced to preserve flys in
ReplaceRange() previously.
There are a couple more callers that look like they want to "replace"
some text, so guess a bit at where to set this new flag.
(note: of course fly anchored *as char* must be deleted via keys.)
(regression from commit e75dd1fc992f168f24d66595265a978071cdd277)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135476
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 85376a02348810812d515ee72140dbf56f2b6040)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135517
Reviewed-by: Miklos Vajna
(cherry picked from commit 5192cd430e8cab0ed04f8c70c5194397455ac705)
Change-Id: Ib4467476b12a12aefbbcb74ab9802f9318cf9aa0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136217
Tested-by: Michael Stahl
Reviewed-by: Michael Stahl
diff --git a/sw/inc/IDocumentContentOperations.hxx
b/sw/inc/IDocumentContentOperations.hxx
index b6857c346a33..6e6b3c1bad3e 100644
--- a/sw/inc/IDocumentContentOperations.hxx
+++ b/sw/inc/IDocumentContentOperations.hxx
@@ -69,6 +69,16 @@ namespace o3tl
template<> struct typed_flags :
is_typed_flags {};
}
+enum class SwDeleteFlags
+{
+Default = 0,
+ArtificialSelection = (1<<0), ///< keyboard delete, artificial selection,
avoid deleting flys
+};
+namespace o3tl
+{
+template<> struct typed_flags :
is_typed_flags {};
+}
+
/** Text operation/manipulation interface
*/
class IDocumentContentOperations
@@ -130,6 +140,7 @@ public:
Needed for hiding of deletion redlines
*/
virtual bool DeleteAndJoin( SwPaM&,
+SwDeleteFlags flags = SwDeleteFlags::Default,
const bool bForceJoinNext = false ) = 0;
virtual bool MoveRange(SwPaM&, SwPosition&, SwMoveFlags) = 0;
diff --git a/sw/inc/editsh.hxx b/sw/inc/editsh.hxx
index c2224d0575bc..71bf75a3a8b6 100644
--- a/sw/inc/editsh.hxx
+++ b/sw/inc/editsh.hxx
@@ -152,7 +152,7 @@ class SW_DLLPUBLIC SwEditShell : public SwCursorShell
that will be used by GetGraphic() and GetGraphicSize(). */
SAL_DLLPRIVATE SwGrfNode *GetGrfNode_() const ;
-SAL_DLLPRIVATE void DeleteSel( SwPaM& rPam, bool* pUndo = nullptr );
+SAL_DLLPRIVATE void DeleteSel(SwPaM& rPam, bool isArtificialSelection,
bool* pUndo = nullptr);
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-4+backports' - sw/source
sw/source/core/doc/docnew.cxx | 27 ++-
1 file changed, 14 insertions(+), 13 deletions(-)
New commits:
commit 97a8db45e6ad8fb397edf5e239384637353f0b2f
Author: Michael Stahl
AuthorDate: Wed Jun 1 20:30:50 2022 +0200
Commit: Thorsten Behrens
CommitDate: Tue Jun 21 23:39:46 2022 +0200
tdf#148309 sw_redlinehide: fix mail merge performance regression
The problem is that in the call to pTargetShell->EndAllAction(), the
cursor is on the node before the newly appended one that has the page
break, and only this node is formatted (via GetFormatted()), so no new
page frames are inserted in the layout, which then creates massive
performance problems later, particularly since the bugdoc contains
multiple at-page anchored flys.
(regression from commit 42448f48bb48a13d6618a181b12840db6d85c574)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135356
Tested-by: Michael Stahl
Reviewed-by: Michael Stahl
(cherry picked from commit ff525d0d70ea9d189a430bde944b56d048b03e55)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135273
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
(cherry picked from commit 57cd4735a7312174e63d2a1a3dd3831443169530)
Revert "trac#34262 Revert "tdf#144565 sw_redlinehide: fix mailmerge when
flys anchored at last node""
This reverts commit 228537cebb6ffa75e7e2270fb7bfd6e91fa6ba2c.
The performance regression should be fixed with above commit.
Change-Id: I05cd2a515a7f67132ab1c8c6fa0d675252ea3a15
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136181
Reviewed-by: Thorsten Behrens
Tested-by: Thorsten Behrens
diff --git a/sw/source/core/doc/docnew.cxx b/sw/source/core/doc/docnew.cxx
index 984f2335bc45..6b041fa96c51 100644
--- a/sw/source/core/doc/docnew.cxx
+++ b/sw/source/core/doc/docnew.cxx
@@ -1054,19 +1054,19 @@ SwNodeIndex SwDoc::AppendDoc(const SwDoc& rSource,
sal_uInt16 const nStartPageNu
{
SwNodeIndex aBreakIdx( GetNodes().GetEndOfContent(), -1 );
SwPosition aBreakPos( aBreakIdx );
-// InsertPageBreak just works on SwTextNode nodes, so make
-// sure the last node is one!
-bool bIsTextNode = aBreakIdx.GetNode().IsTextNode();
-if ( !bIsTextNode )
-getIDocumentContentOperations().AppendTextNode( aBreakPos );
-const OUString name = pTargetPageDesc->GetName();
-pTargetShell->InsertPageBreak( , nStartPageNumber );
-if ( !bIsTextNode )
-{
-pTargetShell->SttEndDoc( false );
---aBreakIdx;
-GetNodes().Delete( aBreakIdx );
-}
+// insert new node - will be removed at the end...
+// (don't SplitNode() as it may move flys to the wrong node)
+getIDocumentContentOperations().AppendTextNode(aBreakPos);
+SwFormatPageDesc pageDesc(pTargetPageDesc);
+pageDesc.SetNumOffset(nStartPageNumber);
+// set break on the last paragraph
+getIDocumentContentOperations().InsertPoolItem(SwPaM(aBreakPos),
+pageDesc, SetAttrMode::DEFAULT, pTargetShell->GetLayout());
+// tdf#148309 move to the last node - so that the "flush page
break"
+// code below will format the frame of the node with the page
break,
+// which is required for new page frames to be created! Else
layout
+// performance will be terrible.
+pTargetShell->SttEndDoc(false);
// There is now a new empty text node on the new page. If it has
// any marks, those are from the previous page: move them back
@@ -1097,6 +1097,7 @@ SwNodeIndex SwDoc::AppendDoc(const SwDoc& rSource,
sal_uInt16 const nStartPageNu
if ( !bDeletePrevious )
{
SAL_INFO( "sw.pageframe", "(Flush pagebreak AKA EndAllAction"
);
+
assert(pTargetShell->GetCursor()->GetPoint()->nNode.GetNode().GetTextNode()->GetSwAttrSet().HasItem(RES_PAGEDESC));
pTargetShell->EndAllAction();
SAL_INFO( "sw.pageframe", "Flush changes AKA EndAllAction)" );
pTargetShell->StartAllAction();
[Libreoffice-commits] core.git: vcl/source
vcl/source/app/salvtables.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit cbe00c2eea06bc59c4bf3b36fbb5f2d1d2d87ef4
Author: Andrea Gelmini
AuthorDate: Tue Jun 21 21:02:34 2022 +0200
Commit: Julien Nabet
CommitDate: Tue Jun 21 23:36:48 2022 +0200
Fix typo
Change-Id: I116e7fe8ecc5d9440e537613a55b880512a1706d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136260
Tested-by: Julien Nabet
Reviewed-by: Julien Nabet
diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index 0cca56bcf5b9..6cd499a1dcc7 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -114,7 +114,7 @@ void SalFrame::SetRepresentedURL(const OUString&)
OUString SalFrame::DumpSetPosSize(tools::Long nX, tools::Long nY, tools::Long
nWidth,
tools::Long nHeight, sal_uInt16 nFlags)
{
-// assuming the 4 integers normally don't have more then 4 digits, but
might be negative
+// assuming the 4 integers normally don't have more than 4 digits, but
might be negative
OUStringBuffer aBuffer(4 * 5 + 5);
if (nFlags & SAL_FRAME_POSSIZE_WIDTH)
aBuffer << nWidth << "x";
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - basctl/source vcl/source
basctl/source/basicide/iderdll.cxx |1 +
basctl/source/basicide/macrodlg.cxx |7 +++
vcl/source/app/salvtables.cxx |2 ++
vcl/source/treelist/treelist.cxx|6 ++
4 files changed, 16 insertions(+)
New commits:
commit f894fa135bea1b33c51fd94e2138a7c9b16b2776
Author: Samuel Mehrbrodt
AuthorDate: Mon Jun 20 10:27:26 2022 +0200
Commit: Thorsten Behrens
CommitDate: Tue Jun 21 23:32:20 2022 +0200
Fix crash when no valid EntryDescriptor found
When opening macro run dlg, the last selected entry is displayed again.
When no entry was found, a crash occured in some situations
(GetLastEntryDescriptor() returned garbage).
Initialize m_aLastEntryDesc properly, and make sure the method returns
when no last selected macro was found.
Also fix some nullptr crashes which occurred during UITests
Change-Id: I7bd1a0b8824725f9935876ae26d8222410a3bc25
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136140
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt
(cherry picked from commit 499ecbf3a36990c29dc7e1fb9b0ecb1d297c2848)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136170
Reviewed-by: Xisco Fauli
(cherry picked from commit 2545a7700f8a4872fd18cb8b1fffeaa4599136d9)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136236
Reviewed-by: Thorsten Behrens
diff --git a/basctl/source/basicide/iderdll.cxx
b/basctl/source/basicide/iderdll.cxx
index 022045050e9a..8e8a3dc3e114 100644
--- a/basctl/source/basicide/iderdll.cxx
+++ b/basctl/source/basicide/iderdll.cxx
@@ -145,6 +145,7 @@ ExtraData* Dll::GetExtraData ()
ExtraData::ExtraData () :
+m_aLastEntryDesc(EntryDescriptor()),
bChoosingMacro(false),
bShellInCriticalSection(false)
{
diff --git a/basctl/source/basicide/macrodlg.cxx
b/basctl/source/basicide/macrodlg.cxx
index 511abf83591e..b0abae8998c0 100644
--- a/basctl/source/basicide/macrodlg.cxx
+++ b/basctl/source/basicide/macrodlg.cxx
@@ -153,6 +153,13 @@ void MacroChooser::RestoreMacroDescription()
aDesc = pData->GetLastEntryDescriptor();
}
+// No valid EntryDescriptor found
+if (aDesc.GetMethodName().isEmpty())
+{
+m_xMacroNameEdit->select_region(0, 0);
+return;
+}
+
m_xBasicBox->SetCurrentEntry(aDesc);
BasicSelectHdl(m_xBasicBox->get_widget());
diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index 20e8db2e7726..6875b9fb9b45 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -4638,6 +4638,8 @@ void SalInstanceTreeView::set_text(const weld::TreeIter&
rIter, const OUString&
OUString SalInstanceTreeView::get_id(const weld::TreeIter& rIter) const
{
const SalInstanceTreeIter& rVclIter = static_cast(rIter);
+if (!rVclIter.iter)
+return OUString();
const OUString* pStr = static_cast(rVclIter.iter->GetUserData());
if (pStr)
return *pStr;
diff --git a/vcl/source/treelist/treelist.cxx b/vcl/source/treelist/treelist.cxx
index 54ebcb075e92..a876b0675980 100644
--- a/vcl/source/treelist/treelist.cxx
+++ b/vcl/source/treelist/treelist.cxx
@@ -101,6 +101,8 @@ bool SvTreeList::IsEntryVisible( const SvListView* pView,
SvTreeListEntry* pEntr
sal_uInt16 SvTreeList::GetDepth( const SvTreeListEntry* pEntry ) const
{
+if (!pEntry)
+return 0;
DBG_ASSERT(pEntry && pEntry!=pRootItem.get(),"GetDepth:Bad Entry");
sal_uInt16 nDepth = 0;
while( pEntry && pEntry->pParent != pRootItem.get() )
@@ -1505,6 +1507,8 @@ SvTreeListEntries& SvTreeList::GetChildList(
SvTreeListEntry* pParent )
const SvTreeListEntry* SvTreeList::GetParent( const SvTreeListEntry* pEntry )
const
{
+if (!pEntry)
+return nullptr;
const SvTreeListEntry* pParent = pEntry->pParent;
if (pParent == pRootItem.get())
pParent = nullptr;
@@ -1513,6 +1517,8 @@ const SvTreeListEntry* SvTreeList::GetParent( const
SvTreeListEntry* pEntry ) co
SvTreeListEntry* SvTreeList::GetParent( SvTreeListEntry* pEntry )
{
+if (!pEntry)
+return nullptr;
SvTreeListEntry* pParent = pEntry->pParent;
if (pParent == pRootItem.get())
pParent = nullptr;
[Libreoffice-bugs] [Bug 149665] Cannot enter a single quotation mark followed by on or more digits into a cell via keyboard
https://bugs.documentfoundation.org/show_bug.cgi?id=149665 OfficeUser changed: What|Removed |Added Summary|Cannot enter a single |Cannot enter a single |quotation mark followed by |quotation mark followed by |on or more digits into a|on or more digits into a |cell|cell via keyboard -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/core/unocore/unosett.cxx | 16
1 file changed, 8 insertions(+), 8 deletions(-)
New commits:
commit 62e2288a9b0b7cef37af432f2f6671c0fded51f5
Author: Stephan Bergmann
AuthorDate: Tue Jun 21 21:58:07 2022 +0200
Commit: Stephan Bergmann
CommitDate: Tue Jun 21 23:07:17 2022 +0200
Use proper type for aSvxToUnoAdjust
...following up on a comment in the commit message of
37ec4442d70339dc8ec5fb8e4ec8984420b6e14d "o3tl: ensure that the initializer
of
enumarray contains enough elements": "In sw/source/core/unocore/unosett.cxx
with its odd mix of saL_Int16 and USHRT_MAX, lets keep things that way for
now
(probably awaiting later clean up) and use casts to avoid the implicit
narrowing." The USHRT_MAX values always mapped to -1 when the elements of
aSvxToUnoAdjust are used to initialize sal_Int16 nINT16 later on, so make
that
explicit here (but an explicit cast from int to sal_Int16 is still needed
for
them, to avoid narrowing failures from within the enumarray ctor).
Change-Id: Ib401ff94c429f8415199a5d35997d17266e04279
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136262
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/sw/source/core/unocore/unosett.cxx
b/sw/source/core/unocore/unosett.cxx
index e06e5fe42e50..a871d4f1c844 100644
--- a/sw/source/core/unocore/unosett.cxx
+++ b/sw/source/core/unocore/unosett.cxx
@@ -240,14 +240,14 @@ static SwPageDesc* lcl_GetPageDesc(SwDoc* pDoc, const
uno::Any& aValue)
}
// Numbering
-const o3tl::enumarray aSvxToUnoAdjust
-{
-static_cast(text::HoriOrientation::LEFT), //3
-static_cast(text::HoriOrientation::RIGHT), //1
-static_cast(USHRT_MAX),
-static_cast(text::HoriOrientation::CENTER), //2
-static_cast(USHRT_MAX),
-static_cast(USHRT_MAX)
+const o3tl::enumarray aSvxToUnoAdjust
+{
+text::HoriOrientation::LEFT, //3
+text::HoriOrientation::RIGHT, //1
+sal_Int16(-1),
+text::HoriOrientation::CENTER, //2
+sal_Int16(-1),
+sal_Int16(-1)
};
const unsigned short aUnoToSvxAdjust[] =
[Libreoffice-bugs] [Bug 149665] New: Cannot enter a single quotation mark followed by on or more digits into a cell
https://bugs.documentfoundation.org/show_bug.cgi?id=149665 Bug ID: 149665 Summary: Cannot enter a single quotation mark followed by on or more digits into a cell Product: LibreOffice Version: 7.3.4.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: norbert.n...@gmx.de It is impossible to enter for example "'1" as cell content via keyboard. Steps to reproduce: - Entering "''1" leads to "''1" (Note: Do not enter the double quotation marks!" Expected result: Entering "''1" should lead to a cell content of "'1". If a digit as one or more leading single quotation marks, the first should single quotation mark should always be truncated. This is how Excel and Only Office behave. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149664] New: Cannot enter a single quotation mark followed by on or more digits into a cell
https://bugs.documentfoundation.org/show_bug.cgi?id=149664 Bug ID: 149664 Summary: Cannot enter a single quotation mark followed by on or more digits into a cell Product: LibreOffice Version: 7.3.4.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: norbert.n...@gmx.de It is impossible to enter for example "'1" as cell content via keyboard. Steps to reproduce: - Entering "''1" leads to "''1" (Note: Do not enter the double quotation marks!" Expected result: Entering "''1" should lead to a cell content of "'1". If a digit as one or more leading single quotation marks, the first should single quotation mark should always be truncated. This is how Excel and Only Office behave. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149647] LibreOffice Calc cursor not positioned correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=149647 Mike Kaganski changed: What|Removed |Added OS|Windows (All) |All CC||noelgran...@gmail.com Keywords||bibisected, bisected --- Comment #9 from Mike Kaganski --- Regression after commit feec8e3c34e08b621098a17f1011dccd0b4f7f4c Author Noel Grandin Date Tue Nov 12 16:00:55 2019 +0200 reduce iteration in ScViewData::GetScrPos -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149432] system font in Hebrew is not a standard font
https://bugs.documentfoundation.org/show_bug.cgi?id=149432 --- Comment #14 from Eyal Rozenberg --- Also note that the font used in the user interface is not the font you choose in the "Basic Fonts" dialog. That dialog is for the fonts used in the document, not in the UI. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149432] system font in Hebrew is not a standard font
https://bugs.documentfoundation.org/show_bug.cgi?id=149432
--- Comment #13 from Eyal Rozenberg ---
(In reply to Dieter from comment #12)
> Eyal, could you help with this report? Can you confirm the problem?
No, I cannot confirm this. And - many people would have complained about this
had it been a widespread occurrence. However, to be fair, I've only tried this
in Windows 10. It is theoretically possible, though unlikely, that the bug
manifests with Windows 7 ("6.1"). I'll ask someone with a Win 7 machine on the
Hebrew channel to try it.
Shlomo, have you seen this only on a single computer, or on my than one system?
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149647] LibreOffice Calc cursor not positioned correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=149647 Mike Kaganski changed: What|Removed |Added Keywords|possibleRegression |regression Version|7.3.3.2 release |7.0.0.3 release --- Comment #8 from Mike Kaganski --- No repro with Version: Version: 6.4.0.3 (x64) Build ID: b0a288ab3d2d4774cb44b62f04d5d28733ac6df8 CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: GL; VCL: win; Locale: ru-RU (ru_RU); UI-Language: en-US Calc: threaded Repro using Version: 7.0.0.3 (x64) Build ID: 8061b3e9204bef6b321a21033174034a5e2ea88e CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: default; VCL: win Locale: en-US (ru_RU); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133557] Rejecting track & changes in Calc slow
https://bugs.documentfoundation.org/show_bug.cgi?id=133557 Julien Nabet changed: What|Removed |Added CC||nem...@numbertext.org --- Comment #5 from Julien Nabet --- László: I noticed patches from you but on sw part. Do you also know sc part or do you know whom to ping? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112812] [META] Hebrew language-specific RTL issues
https://bugs.documentfoundation.org/show_bug.cgi?id=112812 Eyal Rozenberg changed: What|Removed |Added Depends on||149432 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149432 [Bug 149432] system font in Hebrew is not a standard font -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 129661] [META] Right-To-Left (RTL) user interface issues
https://bugs.documentfoundation.org/show_bug.cgi?id=129661 Eyal Rozenberg changed: What|Removed |Added Depends on||149432 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149432 [Bug 149432] system font in Hebrew is not a standard font -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149432] system font in Hebrew is not a standard font
https://bugs.documentfoundation.org/show_bug.cgi?id=149432 Eyal Rozenberg changed: What|Removed |Added Blocks||129661, 112812 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=112812 [Bug 112812] [META] Hebrew language-specific RTL issues https://bugs.documentfoundation.org/show_bug.cgi?id=129661 [Bug 129661] [META] Right-To-Left (RTL) user interface issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133557] Rejecting track & changes in Calc slow
https://bugs.documentfoundation.org/show_bug.cgi?id=133557 --- Comment #4 from Julien Nabet --- Created attachment 180883 --> https://bugs.documentfoundation.org/attachment.cgi?id=180883=edit Flamegraph Here's a Flamegraph retrieved on pc Debian x86-64 with master sources updated today. I started the trace when choosing "Reject all". -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149648] Background of cells are shown in black when there is no value
https://bugs.documentfoundation.org/show_bug.cgi?id=149648 raal changed: What|Removed |Added Keywords|possibleRegression |bibisected, bisected, ||regression OS|Windows (All) |All CC||r...@post.cz Regression By||Vasily Melenchuk --- Comment #2 from raal --- This seems to have begun at the below commit. Adding Cc: to Vasily Melenchuk; Could you possibly take a look at this one? Thanks 3323df1e6e342d468d9c45c3afe8f01b81dc93ff is the first bad commit commit 3323df1e6e342d468d9c45c3afe8f01b81dc93ff Author: Jenkins Build User Date: Mon Oct 4 10:03:15 2021 +0200 source sha:eab60b2663596220cc4d33676524adebc8349a89 https://git.libreoffice.org/core/+/eab60b2663596220cc4d33676524adebc8349a89 tdf#143104 Fix xlsx import/export of color filter colors -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 144991] EDITING: The "Increase Indent" and "Decrease Indent" increment step should be the width of 3 space chars (using the default style font) when working in an xlsx doc
https://bugs.documentfoundation.org/show_bug.cgi?id=144991 --- Comment #7 from Mike Kaganski --- (In reply to Eyal Rozenberg from comment #6) > Why the magic number 3 Because that's what ECMA-376 Part 1 "Office Open XML File Formats — Fundamentals and Markup Language Reference" sect. 18.8.1 "Alignment" tells: > indent (Indent) An integer value, where an increment of 1 represents 3 spaces. > Indicates the number of spaces (of the normal style font) of indentation for > text in a cell. The number of spaces to indent is calculated as following: > Number of spaces to indent = indent value * 3 -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 144991] EDITING: The "Increase Indent" and "Decrease Indent" increment step should be the width of 3 space chars (using the default style font) when working in an xlsx document
https://bugs.documentfoundation.org/show_bug.cgi?id=144991 --- Comment #7 from Mike Kaganski --- (In reply to Eyal Rozenberg from comment #6) > Why the magic number 3 Because that's what ECMA-376 Part 1 "Office Open XML File Formats — Fundamentals and Markup Language Reference" sect. 18.8.1 "Alignment" tells: > indent (Indent) An integer value, where an increment of 1 represents 3 spaces. > Indicates the number of spaces (of the normal style font) of indentation for > text in a cell. The number of spaces to indent is calculated as following: > Number of spaces to indent = indent value * 3 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149642] Want to be able to set area, line & text transparencies altogether
https://bugs.documentfoundation.org/show_bug.cgi?id=149642 --- Comment #2 from Eyal Rozenberg --- (In reply to Rafael Lima from comment #1) > I'm not sure the global transparency you proposed would be ODF compliant. It may not be ODF-compliant - but I believe it's quite natural for a user to want to make an entire object partially-transparent, not just one aspect of it. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 144991] EDITING: The "Increase Indent" and "Decrease Indent" increment step should be the width of 3 space chars (using the default style font) when working in an xlsx doc
https://bugs.documentfoundation.org/show_bug.cgi?id=144991 --- Comment #6 from Eyal Rozenberg --- A lay-person's question: Why the magic number 3 ? Is 2 or 4 spaces inherently bad, or is this actually configured somehow? -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 144991] EDITING: The "Increase Indent" and "Decrease Indent" increment step should be the width of 3 space chars (using the default style font) when working in an xlsx document
https://bugs.documentfoundation.org/show_bug.cgi?id=144991 --- Comment #6 from Eyal Rozenberg --- A lay-person's question: Why the magic number 3 ? Is 2 or 4 spaces inherently bad, or is this actually configured somehow? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149621] PDF documentation files downloaded from motherboard manufacturers require password that doesn't exist.
https://bugs.documentfoundation.org/show_bug.cgi?id=149621 --- Comment #7 from Julien Nabet --- Sorry, it wasn't for you specifically but for LO devs. But of course, if you know coding and would like to involve, don't hesitate to contribute! :-) If interested this link may help: https://wiki.documentfoundation.org/Development/GetInvolved LO is mainly (at least 95%) coded in C++. About PDF specs, you can find it here: https://opensource.adobe.com/dc-acrobat-sdk-docs/standards/pdfstandards/pdf/PDF32000_2008.pdf This one is Adobe version, there's also iso version but you must pay to have it if I read well the forums. It seems there are some slight differences but not sure it's relevant here. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146940] Libreoffice became increadibly slow on using emoticons
https://bugs.documentfoundation.org/show_bug.cgi?id=146940 Rafael Lima changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||0265 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140265] Emoji selector takes too long to load and respond
https://bugs.documentfoundation.org/show_bug.cgi?id=140265 Rafael Lima changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||6940 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136922] Emoji selector is slow
https://bugs.documentfoundation.org/show_bug.cgi?id=136922 Rafael Lima changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||0265 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140265] Emoji selector takes too long to load and respond
https://bugs.documentfoundation.org/show_bug.cgi?id=140265 Rafael Lima changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||6922 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140265] Emoji selector takes too long to load and respond
https://bugs.documentfoundation.org/show_bug.cgi?id=140265 --- Comment #8 from Rafael Lima --- Still slow in Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: cb83063cc0eb4e93bd44bc0cb9b7c4841230cdef CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149663] 1377x
https://bugs.documentfoundation.org/show_bug.cgi?id=149663 Rafael Lima changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: io/source
io/source/stm/odata.cxx |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
New commits:
commit 2bf296ddd10f0a56bdf799712bac1ccb10ed8b72
Author: Chris Sherlock
AuthorDate: Mon Jun 13 17:09:08 2022 +1000
Commit: Stephan Bergmann
CommitDate: Tue Jun 21 21:16:26 2022 +0200
io: drop unnecessary cast
Change-Id: Iaceab1b85e41dbb2102fe829f7abc2f8e3898a52
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135693
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/io/source/stm/odata.cxx b/io/source/stm/odata.cxx
index 754cda450a94..7d39a5835852 100644
--- a/io/source/stm/odata.cxx
+++ b/io/source/stm/odata.cxx
@@ -25,7 +25,6 @@
#include
#include
#include
-#include
#include
#include
@@ -1094,7 +1093,7 @@ Reference< XPersistObject >
OObjectInputStream::readObject()
{
// grow to the right size
Reference< XPersistObject > xEmpty;
-m_aPersistVector.insert( m_aPersistVector.end(),
static_cast(nId - nSize + 1), xEmpty );
+m_aPersistVector.insert( m_aPersistVector.end(), nId -
nSize + 1, xEmpty );
}
m_aPersistVector[nId] = xLoadedObj;
[Libreoffice-bugs] [Bug 149660] FILEOPEN DOCX IF field conditions not read
https://bugs.documentfoundation.org/show_bug.cgi?id=149660 Cor Nouws changed: What|Removed |Added Keywords||filter:docx Ever confirmed|0 |1 Status|UNCONFIRMED |NEW CC||c...@nouenoff.nl Version|7.5.0.0 alpha0+ Master |Inherited From OOo --- Comment #2 from Cor Nouws --- confirmed in Version: 7.4.0.0.alpha1+ / LibreOffice Community Build ID: fc2716740bd513154ae4ab5404d9c575678172e0 CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: nl-NL (en_US.UTF-8); UI: nl-NL Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131149] Super/Subscript and Line Spacing options in menu can't be unchecked (with text box objects)
https://bugs.documentfoundation.org/show_bug.cgi?id=131149 --- Comment #5 from Brian --- Created attachment 180882 --> https://bugs.documentfoundation.org/attachment.cgi?id=180882=edit Example .odf file showing inconsistent behavior of text in drawing objects Bug is still present in 7.3.4.2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147873] LO 7.2.5.2 Calc Eventual Freezing Crash in Mac silicon M1 Mac Book Pro
https://bugs.documentfoundation.org/show_bug.cgi?id=147873 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 CC||79045_79...@mail.ru --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Your summary and the description say us about different things. Please clarify what problem do you have in fact -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148427] EDITING: Calc freezes when attempting to "Paste Special"
https://bugs.documentfoundation.org/show_bug.cgi?id=148427 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #4 from Roman Kuznetsov <79045_79...@mail.ru> --- (In reply to nlo366 from comment #2) > Second, I do not > get the same issue with the blank Calc spreadsheet. I get it in my work, and > admittedly rather large (5.7Mb), file. So please attach your file here -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148487] when you try to insert a special character, Libre Office closes
https://bugs.documentfoundation.org/show_bug.cgi?id=148487 --- Comment #7 from Roman Kuznetsov <79045_79...@mail.ru> --- No repro anyway in Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: ab12274ffda3a1a5a1ff33203acf9de665d4a636 CPU threads: 4; OS: Mac OS X 12.4; UI render: default; VCL: osx Locale: ru-RU (ru_RU.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149662] Standard filter treating text badly if being composed of digits only
https://bugs.documentfoundation.org/show_bug.cgi?id=149662 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #2 from m.a.riosv --- Reproducible Version: 7.3.4.2 (x64) / LibreOffice Community Build ID: 728fec16bd5f605073805c3c9e7c4212a0120dc5 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: e4d23c27288b99c3ed3cfa332ff308b31c01f97d CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149663] 1377x
https://bugs.documentfoundation.org/show_bug.cgi?id=149663 josiahluca...@gmail.com changed: What|Removed |Added URL||https://www.devopsdiggers.c ||om/1377x-proxy/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: registry/source
registry/source/keyimpl.cxx | 57
registry/source/reflread.cxx | 53 +
registry/source/registry.cxx | 42 ---
registry/source/regkey.cxx | 76 ---
4 files changed, 3 insertions(+), 225 deletions(-)
New commits:
commit e02a7a55c23d23dd7afa2627a7e10c70e1cba001
Author: Chris Sherlock
AuthorDate: Sun Jan 9 06:51:17 2022 +1100
Commit: Stephan Bergmann
CommitDate: Tue Jun 21 20:22:34 2022 +0200
registry: remove unnecessary comments
Change-Id: I03b49dcf4bb668b0e4967eb4e88639a5a7e36c8e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128174
Reviewed-by: Stephan Bergmann
Tested-by: Jenkins
diff --git a/registry/source/keyimpl.cxx b/registry/source/keyimpl.cxx
index abf8e0d1ef12..37efeda82ff1 100644
--- a/registry/source/keyimpl.cxx
+++ b/registry/source/keyimpl.cxx
@@ -34,9 +34,6 @@ using namespace store;
namespace { char const VALUE_PREFIX[] = "$VL_"; }
-
-// ORegKey()
-
ORegKey::ORegKey(const OUString& keyName, ORegistry* pReg)
: m_refCount(1)
, m_name(keyName)
@@ -46,41 +43,26 @@ ORegKey::ORegKey(const OUString& keyName, ORegistry* pReg)
{
}
-
-// ~ORegKey()
-
ORegKey::~ORegKey()
{
SAL_WARN_IF(m_refCount != 0, "registry", "registry::ORegKey::dtor():
refcount not zero.");
}
-
-// releaseKey
-
RegError ORegKey::releaseKey(RegKeyHandle hKey)
{
return m_pRegistry->releaseKey(hKey);
}
-
-// createKey
-
RegError ORegKey::createKey(std::u16string_view keyName, RegKeyHandle*
phNewKey)
{
return m_pRegistry->createKey(this, keyName, phNewKey);
}
-
-// openKey
-
RegError ORegKey::openKey(std::u16string_view keyName, RegKeyHandle* phOpenKey)
{
return m_pRegistry->openKey(this, keyName, phOpenKey);
}
-
-// openSubKeys
-
RegError ORegKey::openSubKeys(std::u16string_view keyName, RegKeyHandle**
phOpenSubKeys, sal_uInt32* pnSubKeys)
{
RegError _ret = RegError::NO_ERROR;
@@ -139,9 +121,6 @@ RegError ORegKey::openSubKeys(std::u16string_view keyName,
RegKeyHandle** phOpen
return RegError::NO_ERROR;
}
-
-// getKeyNames
-
RegError ORegKey::getKeyNames(std::u16string_view keyName,
rtl_uString*** pSubKeyNames,
sal_uInt32* pnSubKeys)
@@ -196,25 +175,16 @@ RegError ORegKey::getKeyNames(std::u16string_view keyName,
return RegError::NO_ERROR;
}
-
-// closeKey
-
RegError ORegKey::closeKey(RegKeyHandle hKey)
{
return m_pRegistry->closeKey(hKey);
}
-
-// deleteKey
-
RegError ORegKey::deleteKey(std::u16string_view keyName)
{
return m_pRegistry->deleteKey(this, keyName);
}
-
-// getValueType
-
RegError ORegKey::getValueInfo(std::u16string_view valueName, RegValueType*
pValueType, sal_uInt32* pValueSize) const
{
OStoreStreamrValue;
@@ -267,9 +237,6 @@ RegError ORegKey::getValueInfo(std::u16string_view
valueName, RegValueType* pVal
return RegError::NO_ERROR;
}
-
-// setValue
-
RegError ORegKey::setValue(std::u16string_view valueName, RegValueType vType,
RegValue value, sal_uInt32 vSize)
{
OStoreStreamrValue;
@@ -338,9 +305,6 @@ RegError ORegKey::setValue(std::u16string_view valueName,
RegValueType vType, Re
return RegError::NO_ERROR;
}
-
-// setLongListValue
-
RegError ORegKey::setLongListValue(std::u16string_view valueName, sal_Int32
const * pValueList, sal_uInt32 len)
{
OStoreStreamrValue;
@@ -393,9 +357,6 @@ RegError ORegKey::setLongListValue(std::u16string_view
valueName, sal_Int32 cons
return RegError::NO_ERROR;
}
-
-// setStringListValue
-
RegError ORegKey::setStringListValue(
std::u16string_view valueName, char** pValueList, sal_uInt32 len)
{
@@ -458,9 +419,6 @@ RegError ORegKey::setStringListValue(
return RegError::NO_ERROR;
}
-
-// setUnicodeListValue
-
RegError ORegKey::setUnicodeListValue(std::u16string_view valueName,
sal_Unicode** pValueList, sal_uInt32 len)
{
OStoreStreamrValue;
@@ -522,9 +480,6 @@ RegError ORegKey::setUnicodeListValue(std::u16string_view
valueName, sal_Unicode
return RegError::NO_ERROR;
}
-
-// getValue
-
RegError ORegKey::getValue(std::u16string_view valueName, RegValue value) const
{
OStoreStreamrValue;
@@ -601,9 +556,6 @@ RegError ORegKey::getValue(std::u16string_view valueName,
RegValue value) const
return RegError::NO_ERROR;
}
-
-// getLongListValue
-
RegError ORegKey::getLongListValue(std::u16string_view valueName, sal_Int32**
pValueList, sal_uInt32* pLen) const
{
OStoreStreamrValue;
@@ -704,9 +656,6 @@ RegError ORegKey::getLongListValue(std::u16string_view
valueName, sal_Int32** pV
return RegError::NO_ERROR;
}
-
-// getStringListValue
-
RegError ORegKey::getStringListValue(std::u16string_view valueName, char***
pValueList, sal_uInt32* pLen) const
{
OStoreStreamrValue;
@@ -801,9 +750,6 @@ RegError
[Libreoffice-bugs] [Bug 149663] New: 1377x
https://bugs.documentfoundation.org/show_bug.cgi?id=149663 Bug ID: 149663 Summary: 1377x Product: Document Liberation Project Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: General Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: josiahluca...@gmail.com 1377x Proxy is one of the best entertainment sites that helps users download all kinds of files like TV shows, software, web series, movies, music, TV series, etc. https://www.devopsdiggers.com/1377x-proxy/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148600] Wrong encoding in the GUI
https://bugs.documentfoundation.org/show_bug.cgi?id=148600 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148600] Wrong encoding in the GUI
https://bugs.documentfoundation.org/show_bug.cgi?id=148600 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Please attach some screenshots/video with your problem (interesting how you differ Cyrillic A and Latin A) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131899] incorrect background colour in thumbnails of recent documents in start centre
https://bugs.documentfoundation.org/show_bug.cgi?id=131899 --- Comment #5 from Rafael Lima --- Still repro Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: ca47989ad60b1414f92be22a1fbf4c1d1a92dd97 CPU threads: 12; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149648] Background of cells are shown in black when there is no value
https://bugs.documentfoundation.org/show_bug.cgi?id=149648 Rafael Lima changed: What|Removed |Added Summary|content changed by calc |Background of cells are ||shown in black when there ||is no value Ever confirmed|0 |1 Keywords||possibleRegression Status|UNCONFIRMED |NEW --- Comment #1 from Rafael Lima --- Confirmed with Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: ca47989ad60b1414f92be22a1fbf4c1d1a92dd97 CPU threads: 12; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: CL In LO the background of these cells is black until a value is entered. In MSO the background is yellow. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149472] Freezes on selection Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=149472 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- No repro in Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: ab12274ffda3a1a5a1ff33203acf9de665d4a636 CPU threads: 4; OS: Mac OS X 12.3.1; UI render: default; VCL: osx Locale: ru-RU (ru_RU.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149645] insert photo album does not rotate images
https://bugs.documentfoundation.org/show_bug.cgi?id=149645 Rafael Lima changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #2 from Rafael Lima --- Simon, can you please try again on a clean profile? Or maybe on a different computer? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149642] Want to be able to set area, line & text transparencies altogether
https://bugs.documentfoundation.org/show_bug.cgi?id=149642 --- Comment #1 from Rafael Lima --- This is a complicated one because each is a different property. I'm not sure the global transparency you proposed would be ODF compliant. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149594] Writer crashes on mailmerge when adding salutation to email message
https://bugs.documentfoundation.org/show_bug.cgi?id=149594 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from Roman Kuznetsov <79045_79...@mail.ru> --- Confirm the crash in Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: ab12274ffda3a1a5a1ff33203acf9de665d4a636 CPU threads: 4; OS: Mac OS X 12.3.1; UI render: default; VCL: osx Locale: ru-RU (ru_RU.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149647] LibreOffice Calc cursor not positioned correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=149647 Rafael Lima changed: What|Removed |Added Keywords||possibleRegression Summary|LibreOffice Calc shift of |LibreOffice Calc cursor not |current row |positioned correctly -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149647] LibreOffice Calc shift of current row
https://bugs.documentfoundation.org/show_bug.cgi?id=149647 --- Comment #7 from Rafael Lima --- Also repro in "gen" and "gtk3". -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149647] LibreOffice Calc shift of current row
https://bugs.documentfoundation.org/show_bug.cgi?id=149647 Rafael Lima changed: What|Removed |Added Ever confirmed|0 |1 CC||rafael.palma.l...@gmail.com Status|UNCONFIRMED |NEW --- Comment #6 from Rafael Lima --- Confirmed with Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: ca47989ad60b1414f92be22a1fbf4c1d1a92dd97 CPU threads: 12; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: CL This is a mess... Go around row 178 in the sample ODS file and click anywhere in the sheet and you'll notice the bug. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 1dbfc4fdc9710e670e25bff5636e0336efee8a18 Author: Olivier Hallot AuthorDate: Tue Jun 21 14:42:27 2022 -0300 Commit: Gerrit Code Review CommitDate: Tue Jun 21 19:42:27 2022 +0200 Update git submodules * Update helpcontent2 from branch 'master' to a5a05714cad12c2205389b98557400c4069304ea - Fix bad link Change-Id: I6470492a640355d98a652183d688684874e843b7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136257 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 4ab7e2cf0ecd..a5a05714cad1 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 4ab7e2cf0ecd45c000eb7605c1918265569e52f7 +Subproject commit a5a05714cad12c2205389b98557400c4069304ea
[Libreoffice-commits] help.git: source/text
source/text/shared/01/0601.xhp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a5a05714cad12c2205389b98557400c4069304ea Author: Olivier Hallot AuthorDate: Tue Jun 21 13:27:46 2022 -0300 Commit: Olivier Hallot CommitDate: Tue Jun 21 19:42:25 2022 +0200 Fix bad link Change-Id: I6470492a640355d98a652183d688684874e843b7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136257 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/shared/01/0601.xhp b/source/text/shared/01/0601.xhp index b3656b618..62d5e2b84 100644 --- a/source/text/shared/01/0601.xhp +++ b/source/text/shared/01/0601.xhp @@ -94,7 +94,7 @@ Click to undo the last change in the current sentence. Click again to undo the previous change in the same sentence. - Spelling Options + Spelling Options AutoCorrect Commands Thesaurus
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - wizards/source
wizards/source/sfdocuments/SF_Calc.xba |8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
New commits:
commit cb62be830fae6e42e94c42813923e635e895eae7
Author: Jean-Pierre Ledure
AuthorDate: Tue Jun 21 18:29:03 2022 +0200
Commit: Jean-Pierre Ledure
CommitDate: Tue Jun 21 19:34:04 2022 +0200
ScriptForge - (SF_Calc)FIX wrong sheet name validation
When the name of a sheet contains a "." or a space, when passed
as an argument, the name must be surrounded with sinle quotes
(like in usual Calc formulas).
The validation of the sheet name goes thru the comparison with
the list of existing sheet names in the document.
The comparison compared erroneously the name with quotes and
sheet name without quotes.
Gave an unjustified user error.
Example:
calc.Sheet("'Commits 7.4'")
Cfr. commit on master: https://gerrit.libreoffice.org/c/core/+/136233
Change-Id: I7a47c9dfe1c7b507e99a37d5714046dd6d8e7567
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136258
Tested-by: Jean-Pierre Ledure
Reviewed-by: Jean-Pierre Ledure
Tested-by: Jenkins
diff --git a/wizards/source/sfdocuments/SF_Calc.xba
b/wizards/source/sfdocuments/SF_Calc.xba
index 4b42163753bb..0b7b88ae8f76 100644
--- a/wizards/source/sfdocuments/SF_Calc.xba
+++ b/wizards/source/sfdocuments/SF_Calc.xba
@@ -,6 +,7 @@ Private Function _ValidateSheet(Optional ByRef
pvSheetName As Variant _
DUPLICATESHEETERROR A sheet with
the given name exists already
Dim vSheets As Variant List of sheets
+Dim sSheet As String Sheet name without
single quotes
Dim lSheet As Long Index in list
of sheets
Dim vTypes As VariantArray of accepted
variable types
Dim bValid As BooleanReturn value
@@ -4474,12 +4475,13 @@ Try:
pvSheetName =
_Component.CurrentController.ActiveSheet.Name
Else
vSheets = _Component.getSheets.getElementNames()
+ sSheet = Replace(pvSheetName, ,
)
If pvNew Then
- If ScriptForge.SF_Array.Contains(vSheets,
pvSheetName) Then GoTo CatchDuplicate
+ If ScriptForge.SF_Array.Contains(vSheets,
sSheet) Then GoTo CatchDuplicate
Else
- If Not
ScriptForge.SF_Utils._Validate(pvSheetName, psArgName, V_STRING, vSheets) Then
GoTo Finally
+ If Not ScriptForge.SF_Utils._Validate(sSheet,
psArgName, V_STRING, vSheets) Then GoTo Finally
If pvResetSheet Then
- lSheet =
ScriptForge.SF_Array.IndexOf(vSheets, pvSheetName, CaseSensitive := False)
+ lSheet =
ScriptForge.SF_Array.IndexOf(vSheets, sSheet, CaseSensitive := False)
pvSheetName = vSheets(lSheet)
End If
End If
[Libreoffice-bugs] [Bug 99953] Misaligned cell background color when inserting Calc table in Writer document, depending on zoom level
https://bugs.documentfoundation.org/show_bug.cgi?id=99953 --- Comment #19 from Rafael Lima --- Still repro in Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: ca47989ad60b1414f92be22a1fbf4c1d1a92dd97 CPU threads: 12; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 97423] Top and left borders get thinner when copy/paste table from Calc to Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=97423 Rafael Lima changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=99 ||953 -- You are receiving this mail because: You are the assignee for the bug.
