[Libreoffice-commits] core.git: connectivity/source

[Stephan Bergmann (via logerrit)]

 connectivity/source/sdbcx/VUser.cxx |   11 +++
 1 file changed, 3 insertions(+), 8 deletions(-)

New commits:
commit 870452546a56ce635f36247c44aee6068d70c053
Author: Stephan Bergmann 
AuthorDate: Fri Jul 1 21:06:11 2022 +0200
Commit: Stephan Bergmann 
CommitDate: Sat Jul 2 07:24:44 2022 +0200

Use some more O3TL_UNREACHABLE

Change-Id: I42401a5ba68e6e0d5b99fae4adbea01cd5fa1600
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136778
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/connectivity/source/sdbcx/VUser.cxx 
b/connectivity/source/sdbcx/VUser.cxx
index a09d82183682..51d05b9387be 100644
--- a/connectivity/source/sdbcx/VUser.cxx
+++ b/connectivity/source/sdbcx/VUser.cxx
@@ -22,6 +22,7 @@
 #include 
 #include 
 #include 
+#include 
 
 
 using namespace connectivity;
@@ -113,15 +114,12 @@ Reference< XNameAccess > SAL_CALL OUser::getGroups(  )
 return m_pGroups.get();
 }
 
-
-SAL_WNOUNREACHABLE_CODE_PUSH
-
 sal_Int32 SAL_CALL OUser::getPrivileges( const OUString& /*objName*/, 
sal_Int32 /*objType*/ )
 {
 ::osl::MutexGuard aGuard(m_aMutex);
 checkDisposed(OUser_BASE::rBHelper.bDisposed);
 ::dbtools::throwFeatureNotImplementedSQLException( 
"XAuthorizable::changePassword", *this );
-return 0;
+O3TL_UNREACHABLE;
 }
 
 sal_Int32 SAL_CALL OUser::getGrantablePrivileges( const OUString& /*objName*/, 
sal_Int32 /*objType*/ )
@@ -129,12 +127,9 @@ sal_Int32 SAL_CALL OUser::getGrantablePrivileges( const 
OUString& /*objName*/, s
 ::osl::MutexGuard aGuard(m_aMutex);
 checkDisposed(OUser_BASE::rBHelper.bDisposed);
 ::dbtools::throwFeatureNotImplementedSQLException( 
"XAuthorizable::getGrantablePrivileges", *this );
-return 0;
+O3TL_UNREACHABLE;
 }
 
-SAL_WNOUNREACHABLE_CODE_POP
-
-
 void SAL_CALL OUser::grantPrivileges( const OUString& /*objName*/, sal_Int32 
/*objType*/, sal_Int32 /*objPrivileges*/ )
 {
 ::osl::MutexGuard aGuard(m_aMutex);

[Libreoffice-commits] core.git: vcl/qt5 vcl/unx vcl/win

[Michael Weghorn (via logerrit)]

 vcl/qt5/QtFrame.cxx   |4 
 vcl/unx/gtk3/salnativewidgets-gtk.cxx |5 +
 vcl/win/window/salframe.cxx   |4 
 3 files changed, 13 insertions(+)

New commits:
commit 169ff786a6694ab412d53c911550db101fb50876
Author: Michael Weghorn 
AuthorDate: Fri Jul 1 10:45:13 2022 +0200
Commit: Michael Weghorn 
CommitDate: Sat Jul 2 06:55:15 2022 +0200

tdf#149804 Set newly introduced list box colors from system colors

commit 3c6a53b9ce64180b2a03e097c1844f7496f26815
Date:   Sat Apr 17 14:49:43 2021 +0200

improve the look of the macOS combobox

had introduced separate style colors to be used for list/combo boxes,
but since those new colors were not set explicitly for gtk3,
qt5/qt6 and Windows, this resulted in style/theme/system colors no longer
being used, but only the default colors introduced in above
commit.

This sets the style/theme/system colors for qt5/qt6, gtk3 and
Windows as well, using the same values that were used
previously.

Change-Id: I31401af38b991e7e0cdc436b894ee0f491a22752
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136735
Reviewed-by: Noel Grandin 
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/vcl/qt5/QtFrame.cxx b/vcl/qt5/QtFrame.cxx
index 3a240b2808ca..1b9f8ae88175 100644
--- a/vcl/qt5/QtFrame.cxx
+++ b/vcl/qt5/QtFrame.cxx
@@ -1085,6 +1085,7 @@ void QtFrame::UpdateSettings(AllSettings& rSettings)
 // Text
 style.SetFieldTextColor(aText);
 style.SetFieldRolloverTextColor(aText);
+style.SetListBoxWindowTextColor(aText);
 style.SetWindowTextColor(aText);
 style.SetToolTextColor(aText);
 
@@ -1092,6 +1093,7 @@ void QtFrame::UpdateSettings(AllSettings& rSettings)
 style.SetFieldColor(aBase);
 style.SetWindowColor(aBase);
 style.SetActiveTabColor(aBase);
+style.SetListBoxWindowBackgroundColor(aBase);
 style.SetAlternatingRowColor(toColor(pal.color(QPalette::Active, 
QPalette::AlternateBase)));
 
 // Buttons
@@ -1129,6 +1131,8 @@ void QtFrame::UpdateSettings(AllSettings& rSettings)
 // Selection
 style.SetHighlightColor(aHigh);
 style.SetHighlightTextColor(aHighText);
+style.SetListBoxWindowHighlightColor(aHigh);
+style.SetListBoxWindowHighlightTextColor(aHighText);
 style.SetActiveColor(aHigh);
 style.SetActiveTextColor(aHighText);
 
diff --git a/vcl/unx/gtk3/salnativewidgets-gtk.cxx 
b/vcl/unx/gtk3/salnativewidgets-gtk.cxx
index 3eaffc903e16..3074dd0fbad7 100644
--- a/vcl/unx/gtk3/salnativewidgets-gtk.cxx
+++ b/vcl/unx/gtk3/salnativewidgets-gtk.cxx
@@ -2306,6 +2306,7 @@ bool GtkSalGraphics::updateSettings(AllSettings& 
rSettings)
 aStyleSet.SetButtonTextColor( aTextColor );
 aStyleSet.SetDefaultActionButtonTextColor(aTextColor);
 aStyleSet.SetActionButtonTextColor(aTextColor);
+aStyleSet.SetListBoxWindowTextColor( aTextColor );
 aStyleSet.SetRadioCheckTextColor( aTextColor );
 aStyleSet.SetGroupTextColor( aTextColor );
 aStyleSet.SetLabelTextColor( aTextColor );
@@ -2406,6 +2407,8 @@ bool GtkSalGraphics::updateSettings(AllSettings& 
rSettings)
 ::Color aHighlightTextColor = getColor( text_color );
 aStyleSet.SetHighlightColor( aHighlightColor );
 aStyleSet.SetHighlightTextColor( aHighlightTextColor );
+aStyleSet.SetListBoxWindowHighlightColor( aHighlightColor );
+aStyleSet.SetListBoxWindowHighlightTextColor( aHighlightTextColor );
 // make active like highlight, except with a small contrast. Note, see
 // a GtkListBoxRow in a GtkStackSidebar for a gtk widget with a
 // difference between highlighted and highlighted with focus.
@@ -2424,6 +2427,8 @@ bool GtkSalGraphics::updateSettings(AllSettings& 
rSettings)
 aStyleSet.SetFieldColor( aBackFieldColor );
 // This baby is the default page/paper color
 aStyleSet.SetWindowColor( aBackFieldColor );
+// listbox background color
+aStyleSet.SetListBoxWindowBackgroundColor( aBackFieldColor );
 
 #if GTK_CHECK_VERSION(4, 0, 0)
 double caretAspectRatio = 0.04f;
diff --git a/vcl/win/window/salframe.cxx b/vcl/win/window/salframe.cxx
index b419a259c450..598b5ea70fa8 100644
--- a/vcl/win/window/salframe.cxx
+++ b/vcl/win/window/salframe.cxx
@@ -2714,10 +2714,14 @@ void WinSalFrame::UpdateSettings( AllSettings& 
rSettings )
 aStyleSettings.SetActiveTabColor( aStyleSettings.GetWindowColor() );
 aStyleSettings.SetToolTextColor( ImplWinColorToSal( GetSysColor( 
COLOR_WINDOWTEXT ) ) );
 aStyleSettings.SetFieldColor( aStyleSettings.GetWindowColor() );
+aStyleSettings.SetListBoxWindowBackgroundColor( 
aStyleSettings.GetWindowColor() );
 aStyleSettings.SetFieldTextColor( aStyleSettings.GetWindowTextColor() );
 aStyleSettings.SetFieldRolloverTextColor( 
aStyleSettings.GetFieldTextColor() );
+aStyleSettings.SetListBoxWindowTextColor( 

[Libreoffice-bugs] [Bug 149812] dashes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149812

--- Comment #1 from peter josvai  ---
ah, I forgot to say: 

I did try turning off autocorrect option "replace dashes", and deleted the "--"
to "–" replacement pair, too, and turned them ON again, in all possible
combinations..

so, I went through the routine

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149812] New: dashes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149812

Bug ID: 149812
   Summary: dashes
   Product: LibreOffice
   Version: 7.3.4.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: j...@cspv.hu

hi, 

I've just installed Writer 7 (7.3.4), and replacing dashes stopped working...

this is a very old story, I know...

what I expect:

--   -> –

what I experience instead is that if I type another word after "--", 
when I hit a space, some autocorrect action takes place, and -- becomes –

but this is NOT the expected behavior...

I did clean the configuration files, removed in (linux mint)
.config/libreoffice/4

and started it afresh, but it behaved the exact same way


BTW: it should use a directory "7.3.4", shouldn't it?


..

PS: I've checked bug report 137249 , and 139951 too... (found no useful* info)

*useful: by the use of which I could fix this glitch



- thank you for developing Writer -

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149590] LibreOffice Writer 7.2.4.1 or later hangs under macOS 10.13.6 (High Sierra)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149590

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149767] No lines for translate of some Calc functions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149767

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149439] custom usercode with lpoptions isn't shown in Libreoffice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149439

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149767] No lines for translate of some Calc functions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149767

--- Comment #6 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149751] Libreoffice freeze at first windows startup

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149751

--- Comment #4 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149751] Libreoffice freeze at first windows startup

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149751

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145993] Data Pasted into a cell in Calc goes into the cell below

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145993

--- Comment #3 from QA Administrators  ---
Dear john.davieslg5,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145993] Data Pasted into a cell in Calc goes into the cell below

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145993

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139578] Extension do not work after updating 6.4.7 to 7.0.3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139578

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139578] Extension do not work after updating 6.4.7 to 7.0.3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139578

--- Comment #3 from QA Administrators  ---
Dear Jürgen,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139564] Loading Styles From Another File Does Not Import Custom Page Styles

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139564

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139564] Loading Styles From Another File Does Not Import Custom Page Styles

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139564

--- Comment #5 from QA Administrators  ---
Dear larrybradley,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139454] Base: Open Insert table design causes memory usage bump of 600 MB with empty database

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139454

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139454] Base: Open Insert table design causes memory usage bump of 600 MB with empty database

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139454

--- Comment #9 from QA Administrators  ---
Dear Telesto,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139428] Libreoffice Calc freezes when copying a cell - poll([{fd=6, events=POLLIN} loop

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139428

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139428] Libreoffice Calc freezes when copying a cell - poll([{fd=6, events=POLLIN} loop

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139428

--- Comment #9 from QA Administrators  ---
Dear mariobaldini,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138215] LibreOffice struggles with dark themes.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138215

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138215] LibreOffice struggles with dark themes.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138215

--- Comment #4 from QA Administrators  ---
Dear bas_gommans,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146305] "Record changes" and "Deletions in margin" in doc(x) files messes up file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146305

--- Comment #2 from QA Administrators  ---
Dear Eyolf Østrem,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149811] New: FILESAVE Track changes on page headers are lost when saved

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149811

Bug ID: 149811
   Summary: FILESAVE Track changes on page headers are lost when
saved
   Product: LibreOffice
   Version: 7.3.4.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: toneldac...@gmail.com

Tracked changes on page headers are automatically accepted as changes when
saved as ODF. When saving as DOCX, the tracked changes on the page header are
also automatically accepted but the deleted items are not deleted as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149751] Libreoffice freeze at first windows startup

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149751

--- Comment #3 from siapec  ---
Yes I did it seems to be in conflict with something.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149719] UI: Background Color of "Font Color" and "Background Color" Buttons Turns Black on File Reload

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149719

Rick Whitehouse  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #2 from Rick Whitehouse  ---
No, I hadn't tried disabling Skia.

I disabled Skia (i.e., unchecked the "Use Skia for all rendering" checkbox) and
the symptoms have gone away (i.e., the background color of the buttons
in-question remain the correct color).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: .gitignore

[Stephan Bergmann (via logerrit)]

 .gitignore |1 +
 1 file changed, 1 insertion(+)

New commits:
commit e01fc6d7c1353ed2df4d8fcc06bd3b335e89fa04
Author: Stephan Bergmann 
AuthorDate: Fri Jul 1 15:40:29 2022 +0200
Commit: Stephan Bergmann 
CommitDate: Fri Jul 1 23:12:02 2022 +0200

Add generated lo.xcent to .gitignore

(recently introduced in c78b49ec132eb5126445ebee7d259d3df7fcaa68 "don't 
specify
entitlements that are not used (sdremote w/o bluetooth)")

Change-Id: Ied7db52d891e92224bc2be0ad1277f40e5d80b3c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136752
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/.gitignore b/.gitignore
index 3e5bfc0d3f5b..80da6ef39f9f 100644
--- a/.gitignore
+++ b/.gitignore
@@ -60,6 +60,7 @@
 /bin/odfvalidator.sh
 /bin/officeotron.sh
 /hardened_runtime.xcent
+/lo.xcent
 /vs-code.code-workspace.template
 /Makefile
 

[Libreoffice-commits] core.git: Branch 'feature/chartdatatable' - chart2/source officecfg/registry

[Tomaž Vajngerl (via logerrit)]

 chart2/source/controller/inc/ChartController.hxx   |3 +
 chart2/source/controller/main/ChartController.cxx  |5 +
 chart2/source/controller/main/ChartController_Insert.cxx   |   26 
++
 chart2/source/controller/main/ChartController_Window.cxx   |   20 
+--
 chart2/source/controller/main/ControllerCommandDispatch.cxx|8 +++
 officecfg/registry/data/org/openoffice/Office/UI/ChartCommands.xcu |   11 
 6 files changed, 68 insertions(+), 5 deletions(-)

New commits:
commit 8ae4366c3e2a7fbdde276b5e4229d5a9424ef841
Author: Tomaž Vajngerl 
AuthorDate: Fri Jul 1 23:03:53 2022 +0200
Commit: Tomaž Vajngerl 
CommitDate: Fri Jul 1 23:03:53 2022 +0200

chart2: InsertDataTable and DeleteDataTable for context menu

Change-Id: I8ef0698252209af01b0741a59dec70f845f0c965

diff --git a/chart2/source/controller/inc/ChartController.hxx 
b/chart2/source/controller/inc/ChartController.hxx
index f0f53c8b8990..81f3070403bc 100644
--- a/chart2/source/controller/inc/ChartController.hxx
+++ b/chart2/source/controller/inc/ChartController.hxx
@@ -440,6 +440,9 @@ private:
 void executeDispatch_OpenLegendDialog();
 void executeDispatch_InsertAxes();
 void executeDispatch_InsertGrid();
+
+void executeDispatch_InsertDataTable();
+void executeDispatch_DeleteDataTable();
 void executeDispatch_OpenInsertDataTableDialog();
 
 void executeDispatch_InsertMenu_DataLabels();
diff --git a/chart2/source/controller/main/ChartController.cxx 
b/chart2/source/controller/main/ChartController.cxx
index 79b29bb63c52..080b6bb44928 100644
--- a/chart2/source/controller/main/ChartController.cxx
+++ b/chart2/source/controller/main/ChartController.cxx
@@ -1225,6 +1225,10 @@ void SAL_CALL ChartController::dispatch(
 this->executeDispatch_DeleteMajorGrid();
 else if( aCommand == "DeleteMinorGrid" )
 this->executeDispatch_DeleteMinorGrid();
+else if( aCommand == "InsertDataTable" )
+ this->executeDispatch_InsertDataTable();
+else if( aCommand == "DeleteDataTable" )
+ this->executeDispatch_DeleteDataTable();
 //format objects
 else if( aCommand == "FormatSelection" )
 this->executeDispatch_ObjectProperties();
@@ -1634,6 +1638,7 @@ const o3tl::sorted_vector< OUString >& 
ChartController::impl_getAvailableCommand
 "DeleteXErrorBars",   "DeleteYErrorBars",
 "DeleteDataLabels",   "DeleteDataLabel",
 "InsertMenuDataTable",
+"InsertDataTable", "DeleteDataTable",
 //format objects
 "FormatSelection", "TransformDialog",
 "DiagramType","View3D",
diff --git a/chart2/source/controller/main/ChartController_Insert.cxx 
b/chart2/source/controller/main/ChartController_Insert.cxx
index b1b0598d5070..99b3e74fffac 100644
--- a/chart2/source/controller/main/ChartController_Insert.cxx
+++ b/chart2/source/controller/main/ChartController_Insert.cxx
@@ -224,6 +224,32 @@ void 
ChartController::executeDispatch_OpenInsertDataTableDialog()
 }
 }
 
+void ChartController::executeDispatch_InsertDataTable()
+{
+SolarMutexGuard aGuard;
+rtl::Reference xDiagram = getFirstDiagram();
+auto xDataTable = xDiagram->getDataTable();
+if (!xDataTable.is())
+{
+uno::Reference xNewDataTable(new DataTable);
+if (xNewDataTable.is())
+{
+xDiagram->setDataTable(xNewDataTable);
+}
+}
+}
+
+void ChartController::executeDispatch_DeleteDataTable()
+{
+SolarMutexGuard aGuard;
+rtl::Reference xDiagram = getFirstDiagram();
+auto xDataTable = xDiagram->getDataTable();
+if (xDataTable.is())
+{
+xDiagram->setDataTable(uno::Reference());
+}
+}
+
 void ChartController::executeDispatch_InsertTitles()
 {
 UndoGuard aUndoGuard(
diff --git a/chart2/source/controller/main/ChartController_Window.cxx 
b/chart2/source/controller/main/ChartController_Window.cxx
index c50749c42a87..c300b7f2e23d 100644
--- a/chart2/source/controller/main/ChartController_Window.cxx
+++ b/chart2/source/controller/main/ChartController_Window.cxx
@@ -1020,14 +1020,18 @@ void ChartController::execute_Command( const 
CommandEvent& rCEvt )
 aMenuName = m_pDrawViewWrapper->IsTextEdit() ? 
std::u16string_view( u"drawtext" ) : std::u16string_view( u"draw" );
 else
 {
+ObjectType eObjectType = ObjectIdentifier::getObjectType( 
m_aSelection.getSelectedCID() );
+
 // todo: the context menu should be specified by an xml file in 
uiconfig
 sal_Int16 nUniqueId = 1;
-lcl_insertMenuCommand( xPopupMenu, nUniqueId++, ".uno:Cut" );
-lcl_insertMenuCommand( xPopupMenu, nUniqueId++, ".uno:Copy" );
-lcl_insertMenuCommand( xPopupMenu, nUniqueId++, ".uno:Paste" );
-xPopupMenu->insertSeparator( -1 );
+if (eObjectType != OBJECTTYPE_DATA_TABLE)
+{
+lcl_insertMenuCommand( 

[Libreoffice-commits] core.git: ucbhelper/source

[Stephan Bergmann (via logerrit)]

 ucbhelper/source/client/content.cxx |8 +---
 1 file changed, 1 insertion(+), 7 deletions(-)

New commits:
commit 17217a93418c9a5233eecd9491a7c4269d15057f
Author: Stephan Bergmann 
AuthorDate: Fri Jul 1 21:07:34 2022 +0200
Commit: Stephan Bergmann 
CommitDate: Fri Jul 1 23:01:33 2022 +0200

Use some more O3TL_UNREACHABLE

Change-Id: Ibcf1b1de7b43460266e99fc9f27c1de0b510a361
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136779
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/ucbhelper/source/client/content.cxx 
b/ucbhelper/source/client/content.cxx
index 4eeeab2008d6..48d3ee84a9da 100644
--- a/ucbhelper/source/client/content.cxx
+++ b/ucbhelper/source/client/content.cxx
@@ -1022,8 +1022,6 @@ bool Content::isFolder()
 }
 
 
-SAL_WNOUNREACHABLE_CODE_PUSH
-
 bool Content::isDocument()
 {
 bool bDoc = false;
@@ -1037,13 +1035,9 @@ bool Content::isDocument()
 get() ) ),
  m_xImpl->getEnvironment() );
 
-// Unreachable - cancelCommandExecution always throws an exception,
-// But some compilers complain...
-return false;
+O3TL_UNREACHABLE;
 }
 
-SAL_WNOUNREACHABLE_CODE_POP
-
 void Content::lock()
 {
 Command aCommand;

[Libreoffice-commits] core.git: Branch 'feature/chartdatatable' - 2 commits - chart2/Library_chartcontroller.mk chart2/source chart2/uiconfig chart2/UIConfig_chart2.mk

[Tomaž Vajngerl (via logerrit)]

Rebased ref, commits from common ancestor:
commit 2e95a0c6bdb6848fa8736753c5206c7b2553da4c
Author: Tomaž Vajngerl 
AuthorDate: Fri Jul 1 22:00:38 2022 +0200
Commit: Tomaž Vajngerl 
CommitDate: Fri Jul 1 22:37:48 2022 +0200

chart2: InsertDataTableDialog for inserting/removing the data table

Change-Id: Ie3c033c587b150723e7aa39cd5ddf5774104db9a

diff --git a/chart2/Library_chartcontroller.mk 
b/chart2/Library_chartcontroller.mk
index 4bc8c7497915..cc25cdd907ae 100644
--- a/chart2/Library_chartcontroller.mk
+++ b/chart2/Library_chartcontroller.mk
@@ -109,6 +109,7 @@ $(eval $(call 
gb_Library_add_exception_objects,chartcontroller,\
 chart2/source/controller/dialogs/dlg_DataSource \
 chart2/source/controller/dialogs/dlg_InsertAxis_Grid \
 chart2/source/controller/dialogs/dlg_InsertDataLabel \
+chart2/source/controller/dialogs/dlg_InsertDataTable \
 chart2/source/controller/dialogs/dlg_InsertErrorBars \
 chart2/source/controller/dialogs/dlg_InsertLegend \
 chart2/source/controller/dialogs/dlg_InsertTitle \
@@ -122,6 +123,7 @@ $(eval $(call 
gb_Library_add_exception_objects,chartcontroller,\
 chart2/source/controller/dialogs/RangeSelectionListener \
 chart2/source/controller/dialogs/res_BarGeometry \
 chart2/source/controller/dialogs/res_DataLabel \
+chart2/source/controller/dialogs/res_DataTableProperties \
 chart2/source/controller/dialogs/res_ErrorBar \
 chart2/source/controller/dialogs/res_LegendPosition \
 chart2/source/controller/dialogs/res_Titles \
diff --git a/chart2/UIConfig_chart2.mk b/chart2/UIConfig_chart2.mk
index 59af510c5845..274efd02638f 100644
--- a/chart2/UIConfig_chart2.mk
+++ b/chart2/UIConfig_chart2.mk
@@ -44,7 +44,9 @@ $(eval $(call gb_UIConfig_add_uifiles,modules/schart,\
chart2/uiconfig/ui/combobox \
chart2/uiconfig/ui/datarangedialog \
chart2/uiconfig/ui/dlg_DataLabel \
+   chart2/uiconfig/ui/dlg_InsertDataTable \
chart2/uiconfig/ui/dlg_InsertErrorBars \
+   chart2/uiconfig/ui/dlg_InsertLegend \
chart2/uiconfig/ui/imagefragment \
chart2/uiconfig/ui/insertaxisdlg \
chart2/uiconfig/ui/insertgriddlg \
@@ -58,7 +60,6 @@ $(eval $(call gb_UIConfig_add_uifiles,modules/schart,\
chart2/uiconfig/ui/smoothlinesdlg \
chart2/uiconfig/ui/steppedlinesdlg \
chart2/uiconfig/ui/titlerotationtabpage \
-   chart2/uiconfig/ui/dlg_InsertLegend \
chart2/uiconfig/ui/tp_3D_SceneAppearance \
chart2/uiconfig/ui/tp_3D_SceneGeometry \
chart2/uiconfig/ui/tp_3D_SceneIllumination \
diff --git a/chart2/source/controller/dialogs/dlg_InsertDataTable.cxx 
b/chart2/source/controller/dialogs/dlg_InsertDataTable.cxx
new file mode 100644
index ..4b5e928db057
--- /dev/null
+++ b/chart2/source/controller/dialogs/dlg_InsertDataTable.cxx
@@ -0,0 +1,61 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include 
+
+namespace chart
+{
+InsertDataTableDialog::InsertDataTableDialog(weld::Window* pWindow)
+: GenericDialogController(pWindow, 
"modules/schart/ui/dlg_InsertDataTable.ui",
+  "InsertDataTableDialog")
+, m_aDataTablePropertiesResources(*m_xBuilder)
+, m_xCbShowDataTable(m_xBuilder->weld_check_button("showDataTable"))
+{
+m_xCbShowDataTable->connect_toggled(LINK(this, InsertDataTableDialog, 
ShowDataTableToggle));
+init(m_aData);
+}
+
+IMPL_LINK_NOARG(InsertDataTableDialog, ShowDataTableToggle, weld::Toggleable&, 
void)
+{
+changeEnabled();
+}
+
+void InsertDataTableDialog::changeEnabled()
+{
+bool bEnable = m_xCbShowDataTable->get_active();
+m_aDataTablePropertiesResources.setChecksSensitive(bEnable);
+m_aData.mbShow = bEnable;
+}
+
+void InsertDataTableDialog::init(DataTableDialogData const& rData)
+{
+m_aData = rData;
+
m_aDataTablePropertiesResources.setHorizontalBorder(m_aData.mbHorizontalBorders);
+
m_aDataTablePropertiesResources.setVerticalBorder(m_aData.mbVerticalBorders);
+m_aDataTablePropertiesResources.setOutline(m_aData.mbOutline);
+m_aDataTablePropertiesResources.setKeys(m_aData.mbKeys);
+m_xCbShowDataTable->set_active(m_aData.mbShow);
+changeEnabled();
+}
+
+DataTableDialogData& InsertDataTableDialog::getDataTableDialogData()
+{
+m_aData.mbShow = m_xCbShowDataTable->get_active();
+
+m_aData.mbHorizontalBorders = 
m_aDataTablePropertiesResources.getHorizontalBorder();
+m_aData.mbVerticalBorders = 
m_aDataTablePropertiesResources.getVerticalBorder();
+m_aData.mbOutline = m_aDataTablePropertiesResources.getOutline();
+m_aData.mbKeys = m_aDataTablePropertiesResources.getKeys();
+
+return m_aData;
+}
+

[Libreoffice-commits] core.git: connectivity/source

[Stephan Bergmann (via logerrit)]

 connectivity/source/commontools/BlobHelper.cxx |   14 
 connectivity/source/commontools/FDatabaseMetaDataResultSet.cxx |   32 
+++---
 2 files changed, 13 insertions(+), 33 deletions(-)

New commits:
commit 8895dc3c4cb3e3fafcde1d0243dd683e7283b805
Author: Stephan Bergmann 
AuthorDate: Fri Jul 1 21:04:24 2022 +0200
Commit: Stephan Bergmann 
CommitDate: Fri Jul 1 22:32:58 2022 +0200

Use some more O3TL_UNREACHABLE

Change-Id: I5885c1f33fe7d15e6bd0b572b6d0db1410252362
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136777
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/connectivity/source/commontools/BlobHelper.cxx 
b/connectivity/source/commontools/BlobHelper.cxx
index 591fe961e517..f1f048a7318e 100644
--- a/connectivity/source/commontools/BlobHelper.cxx
+++ b/connectivity/source/commontools/BlobHelper.cxx
@@ -20,6 +20,7 @@
 #include 
 #include 
 #include 
+#include 
 
 using namespace connectivity;
 using namespace dbtools;
@@ -47,25 +48,16 @@ css::uno::Reference< css::io::XInputStream > SAL_CALL 
BlobHelper::getBinaryStrea
 return new ::comphelper::SequenceInputStream(m_aValue);
 }
 
-
-// The "return" after a call to throwFeatureNotImplementedSQLException()
-// (which always throws) will be detected as unreachable when doing
-// global inlining.
-
-SAL_WNOUNREACHABLE_CODE_PUSH
-
 ::sal_Int64 SAL_CALL BlobHelper::position( const css::uno::Sequence< 
::sal_Int8 >& /*pattern*/, ::sal_Int64 /*start*/ )
 {
 ::dbtools::throwFeatureNotImplementedSQLException( "XBlob::position", 
*this );
-return 0;
+O3TL_UNREACHABLE;
 }
 
 ::sal_Int64 SAL_CALL BlobHelper::positionOfBlob( const css::uno::Reference< 
css::sdbc::XBlob >& /*pattern*/, ::sal_Int64 /*start*/ )
 {
 ::dbtools::throwFeatureNotImplementedSQLException( 
"XBlob::positionOfBlob", *this );
-return 0;
+O3TL_UNREACHABLE;
 }
 
-SAL_WNOUNREACHABLE_CODE_POP
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/connectivity/source/commontools/FDatabaseMetaDataResultSet.cxx 
b/connectivity/source/commontools/FDatabaseMetaDataResultSet.cxx
index 3c755f206224..d4ae8760f2ce 100644
--- a/connectivity/source/commontools/FDatabaseMetaDataResultSet.cxx
+++ b/connectivity/source/commontools/FDatabaseMetaDataResultSet.cxx
@@ -312,22 +312,18 @@ sal_Bool SAL_CALL 
ODatabaseMetaDataResultSet::isAfterLast(  )
 }
 
 
-SAL_WNOUNREACHABLE_CODE_PUSH
-
 sal_Bool SAL_CALL ODatabaseMetaDataResultSet::isFirst(  )
 {
 ::dbtools::throwFunctionSequenceException(*this);
-return false;
+O3TL_UNREACHABLE;
 }
 
 sal_Bool SAL_CALL ODatabaseMetaDataResultSet::isLast(  )
 {
 ::dbtools::throwFunctionSequenceException(*this);
-return false;
+O3TL_UNREACHABLE;
 }
 
-SAL_WNOUNREACHABLE_CODE_POP
-
 
 void SAL_CALL ODatabaseMetaDataResultSet::beforeFirst(  )
 {
@@ -351,41 +347,37 @@ void SAL_CALL ODatabaseMetaDataResultSet::close(  )
 }
 
 
-SAL_WNOUNREACHABLE_CODE_PUSH
-
 sal_Bool SAL_CALL ODatabaseMetaDataResultSet::first(  )
 {
 ::dbtools::throwFunctionSequenceException(*this);
-return false;
+O3TL_UNREACHABLE;
 }
 
 
 sal_Bool SAL_CALL ODatabaseMetaDataResultSet::last(  )
 {
 ::dbtools::throwFunctionSequenceException(*this);
-return false;
+O3TL_UNREACHABLE;
 }
 
 sal_Bool SAL_CALL ODatabaseMetaDataResultSet::absolute( sal_Int32 /*row*/ )
 {
 ::dbtools::throwFunctionSequenceException(*this);
-return false;
+O3TL_UNREACHABLE;
 }
 
 sal_Bool SAL_CALL ODatabaseMetaDataResultSet::relative( sal_Int32 /*row*/ )
 {
 ::dbtools::throwFunctionSequenceException(*this);
-return false;
+O3TL_UNREACHABLE;
 }
 
 sal_Bool SAL_CALL ODatabaseMetaDataResultSet::previous(  )
 {
 ::dbtools::throwFunctionSequenceException(*this);
-return false;
+O3TL_UNREACHABLE;
 }
 
-SAL_WNOUNREACHABLE_CODE_POP
-
 
 Reference< XInterface > SAL_CALL ODatabaseMetaDataResultSet::getStatement(  )
 {
@@ -393,28 +385,24 @@ Reference< XInterface > SAL_CALL 
ODatabaseMetaDataResultSet::getStatement(  )
 }
 
 
-SAL_WNOUNREACHABLE_CODE_PUSH
-
 sal_Bool SAL_CALL ODatabaseMetaDataResultSet::rowDeleted(  )
 {
 ::dbtools::throwFunctionSequenceException(*this);
-return false;
+O3TL_UNREACHABLE;
 }
 
 sal_Bool SAL_CALL ODatabaseMetaDataResultSet::rowInserted(  )
 {
 ::dbtools::throwFunctionSequenceException(*this);
-return false;
+O3TL_UNREACHABLE;
 }
 
 sal_Bool SAL_CALL ODatabaseMetaDataResultSet::rowUpdated(  )
 {
 ::dbtools::throwFunctionSequenceException(*this);
-return false;
+O3TL_UNREACHABLE;
 }
 
-SAL_WNOUNREACHABLE_CODE_POP
-
 
 sal_Bool SAL_CALL ODatabaseMetaDataResultSet::isBeforeFirst(  )
 {

[Libreoffice-commits] core.git: Branch 'feature/chartdatatable' - 3 commits - chart2/Library_chartcontroller.mk chart2/source chart2/uiconfig chart2/UIConfig_chart2.mk officecfg/registry

[Tomaž Vajngerl (via logerrit)]

Rebased ref, commits from common ancestor:
commit 4e005b051c361ab27064a3905710d944810cdc44
Author: Tomaž Vajngerl 
AuthorDate: Fri Jul 1 22:00:38 2022 +0200
Commit: Tomaž Vajngerl 
CommitDate: Fri Jul 1 22:26:38 2022 +0200

chart2: InsertDataTableDialog for inserting/removing the data table

Change-Id: Ie3c033c587b150723e7aa39cd5ddf5774104db9a

diff --git a/chart2/Library_chartcontroller.mk 
b/chart2/Library_chartcontroller.mk
index 4bc8c7497915..cc25cdd907ae 100644
--- a/chart2/Library_chartcontroller.mk
+++ b/chart2/Library_chartcontroller.mk
@@ -109,6 +109,7 @@ $(eval $(call 
gb_Library_add_exception_objects,chartcontroller,\
 chart2/source/controller/dialogs/dlg_DataSource \
 chart2/source/controller/dialogs/dlg_InsertAxis_Grid \
 chart2/source/controller/dialogs/dlg_InsertDataLabel \
+chart2/source/controller/dialogs/dlg_InsertDataTable \
 chart2/source/controller/dialogs/dlg_InsertErrorBars \
 chart2/source/controller/dialogs/dlg_InsertLegend \
 chart2/source/controller/dialogs/dlg_InsertTitle \
@@ -122,6 +123,7 @@ $(eval $(call 
gb_Library_add_exception_objects,chartcontroller,\
 chart2/source/controller/dialogs/RangeSelectionListener \
 chart2/source/controller/dialogs/res_BarGeometry \
 chart2/source/controller/dialogs/res_DataLabel \
+chart2/source/controller/dialogs/res_DataTableProperties \
 chart2/source/controller/dialogs/res_ErrorBar \
 chart2/source/controller/dialogs/res_LegendPosition \
 chart2/source/controller/dialogs/res_Titles \
diff --git a/chart2/UIConfig_chart2.mk b/chart2/UIConfig_chart2.mk
index 59af510c5845..274efd02638f 100644
--- a/chart2/UIConfig_chart2.mk
+++ b/chart2/UIConfig_chart2.mk
@@ -44,7 +44,9 @@ $(eval $(call gb_UIConfig_add_uifiles,modules/schart,\
chart2/uiconfig/ui/combobox \
chart2/uiconfig/ui/datarangedialog \
chart2/uiconfig/ui/dlg_DataLabel \
+   chart2/uiconfig/ui/dlg_InsertDataTable \
chart2/uiconfig/ui/dlg_InsertErrorBars \
+   chart2/uiconfig/ui/dlg_InsertLegend \
chart2/uiconfig/ui/imagefragment \
chart2/uiconfig/ui/insertaxisdlg \
chart2/uiconfig/ui/insertgriddlg \
@@ -58,7 +60,6 @@ $(eval $(call gb_UIConfig_add_uifiles,modules/schart,\
chart2/uiconfig/ui/smoothlinesdlg \
chart2/uiconfig/ui/steppedlinesdlg \
chart2/uiconfig/ui/titlerotationtabpage \
-   chart2/uiconfig/ui/dlg_InsertLegend \
chart2/uiconfig/ui/tp_3D_SceneAppearance \
chart2/uiconfig/ui/tp_3D_SceneGeometry \
chart2/uiconfig/ui/tp_3D_SceneIllumination \
diff --git a/chart2/source/controller/dialogs/dlg_InsertDataTable.cxx 
b/chart2/source/controller/dialogs/dlg_InsertDataTable.cxx
new file mode 100644
index ..4b5e928db057
--- /dev/null
+++ b/chart2/source/controller/dialogs/dlg_InsertDataTable.cxx
@@ -0,0 +1,61 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include 
+
+namespace chart
+{
+InsertDataTableDialog::InsertDataTableDialog(weld::Window* pWindow)
+: GenericDialogController(pWindow, 
"modules/schart/ui/dlg_InsertDataTable.ui",
+  "InsertDataTableDialog")
+, m_aDataTablePropertiesResources(*m_xBuilder)
+, m_xCbShowDataTable(m_xBuilder->weld_check_button("showDataTable"))
+{
+m_xCbShowDataTable->connect_toggled(LINK(this, InsertDataTableDialog, 
ShowDataTableToggle));
+init(m_aData);
+}
+
+IMPL_LINK_NOARG(InsertDataTableDialog, ShowDataTableToggle, weld::Toggleable&, 
void)
+{
+changeEnabled();
+}
+
+void InsertDataTableDialog::changeEnabled()
+{
+bool bEnable = m_xCbShowDataTable->get_active();
+m_aDataTablePropertiesResources.setChecksSensitive(bEnable);
+m_aData.mbShow = bEnable;
+}
+
+void InsertDataTableDialog::init(DataTableDialogData const& rData)
+{
+m_aData = rData;
+
m_aDataTablePropertiesResources.setHorizontalBorder(m_aData.mbHorizontalBorders);
+
m_aDataTablePropertiesResources.setVerticalBorder(m_aData.mbVerticalBorders);
+m_aDataTablePropertiesResources.setOutline(m_aData.mbOutline);
+m_aDataTablePropertiesResources.setKeys(m_aData.mbKeys);
+m_xCbShowDataTable->set_active(m_aData.mbShow);
+changeEnabled();
+}
+
+DataTableDialogData& InsertDataTableDialog::getDataTableDialogData()
+{
+m_aData.mbShow = m_xCbShowDataTable->get_active();
+
+m_aData.mbHorizontalBorders = 
m_aDataTablePropertiesResources.getHorizontalBorder();
+m_aData.mbVerticalBorders = 
m_aDataTablePropertiesResources.getVerticalBorder();
+m_aData.mbOutline = m_aDataTablePropertiesResources.getOutline();
+m_aData.mbKeys = m_aDataTablePropertiesResources.getKeys();
+
+return m_aData;
+}
+

[Libreoffice-commits] core.git: external/libnumbertext

[Stephan Bergmann (via logerrit)]

 external/libnumbertext/UnpackedTarball_libnumbertext.mk |1 
 external/libnumbertext/deprecated.patch.0   |   49 
 2 files changed, 50 insertions(+)

New commits:
commit e37e1a7d2007bd6896027b69271774da2568e6f8
Author: Stephan Bergmann 
AuthorDate: Fri Jul 1 19:45:19 2022 +0200
Commit: Stephan Bergmann 
CommitDate: Fri Jul 1 22:18:20 2022 +0200

external/libnumbertext: Silence -Werror,-Wdeprecated-declarations

...as seen now with LLVM 15 trunk libc++, which marks the std::codecvt_utf8 
and
std::wstring_convert functionality, deprecated since C++17, as such

(
"[libc++] Implement P0618R0 (Deprecating )")

Change-Id: Id34e3fea540b76591ead8ba3df4c31a71d7b4aaf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136776
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/external/libnumbertext/UnpackedTarball_libnumbertext.mk 
b/external/libnumbertext/UnpackedTarball_libnumbertext.mk
index 3a7a7ff6d85a..583b26308675 100644
--- a/external/libnumbertext/UnpackedTarball_libnumbertext.mk
+++ b/external/libnumbertext/UnpackedTarball_libnumbertext.mk
@@ -22,6 +22,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,libnumbertext, \
 external/libnumbertext/MSVCNonBMPBug.patch1 \
 external/libnumbertext/WinUnicodePath.patch1 \
 external/libnumbertext/EmptyString.patch1 \
+external/libnumbertext/deprecated.patch.0 \
 ))
 
 # vim: set noet sw=4 ts=4:
diff --git a/external/libnumbertext/deprecated.patch.0 
b/external/libnumbertext/deprecated.patch.0
new file mode 100644
index ..1fe5c214f602
--- /dev/null
+++ b/external/libnumbertext/deprecated.patch.0
@@ -0,0 +1,49 @@
+--- src/Numbertext.cxx
 src/Numbertext.cxx
+@@ -41,7 +41,14 @@
+ std::wifstream wif(filename);
+ if (wif.fail())
+ return false;
++#if defined __GNUC__
++#pragma GCC diagnostic push
++#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
++#endif
+ wif.imbue(std::locale(std::locale(), new std::codecvt_utf8));
++#if defined __GNUC__
++#pragma GCC diagnostic pop
++#endif
+ std::wstringstream wss;
+ wss << wif.rdbuf();
+ result = wss.str();
+@@ -122,8 +129,15 @@
+ MultiByteToWideChar(CP_UTF8, 0, s.c_str(), -1, wstr.get(), nSize);
+ return wstr.get();
+ #elif !defined NUMBERTEXT_BOOST
++#if defined __GNUC__
++#pragma GCC diagnostic push
++#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
++#endif
+ typedef std::codecvt_utf8 convert_type;
+ std::wstring_convert converter;
++#if defined __GNUC__
++#pragma GCC diagnostic pop
++#endif
+ return converter.from_bytes( s );
+ #else
+ return ::locale::conv::utf_to_utf(s.c_str(), s.c_str() + 
s.size());
+@@ -138,8 +152,15 @@
+ WideCharToMultiByte(CP_UTF8, 0, s.c_str(), -1, str.get(), nSize, nullptr, 
nullptr);
+ return str.get();
+ #elif !defined NUMBERTEXT_BOOST
++#if defined __GNUC__
++#pragma GCC diagnostic push
++#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
++#endif
+ typedef std::codecvt_utf8 convert_type;
+ std::wstring_convert converter;
++#if defined __GNUC__
++#pragma GCC diagnostic pop
++#endif
+ return converter.to_bytes( s );
+ #else
+ return ::locale::conv::utf_to_utf(s.c_str(), s.c_str() + s.size());

[Libreoffice-commits] core.git: compilerplugins/clang

[Stephan Bergmann (via logerrit)]

 compilerplugins/clang/compat.hxx|8 
 compilerplugins/clang/consttobool.cxx   |3 ++-
 compilerplugins/clang/getimplementationname.cxx |3 ++-
 compilerplugins/clang/sallogareas.cxx   |2 +-
 compilerplugins/clang/stringconstant.cxx|2 +-
 5 files changed, 14 insertions(+), 4 deletions(-)

New commits:
commit 9e2dbeea9f680f2d3d1611167820c197ce8a9685
Author: Stephan Bergmann 
AuthorDate: Fri Jul 1 14:56:01 2022 +0200
Commit: Stephan Bergmann 
CommitDate: Fri Jul 1 22:12:41 2022 +0200

Adapt to LLVM 15 trunk clang::StringLiteral::isAscii rename



"[Clang] Rename StringLiteral::isAscii() => isOrdinary() [NFC]"

Change-Id: Iac293c19bd135a94dcc3a3ef9f252ca6175c959a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136744
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/compilerplugins/clang/compat.hxx b/compilerplugins/clang/compat.hxx
index 350263da6854..1a6266ec5201 100644
--- a/compilerplugins/clang/compat.hxx
+++ b/compilerplugins/clang/compat.hxx
@@ -125,6 +125,14 @@ inline const clang::Expr *getSubExprAsWritten(const 
clang::CastExpr *This) {
   return getSubExprAsWritten(const_cast(This));
 }
 
+inline bool isOrdinary(clang::StringLiteral const * expr) {
+#if CLANG_VERSION >= 15
+return expr->isOrdinary();
+#else
+return expr->isAscii();
+#endif
+}
+
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/compilerplugins/clang/consttobool.cxx 
b/compilerplugins/clang/consttobool.cxx
index d20a0d5c9b48..c13bf7729e72 100644
--- a/compilerplugins/clang/consttobool.cxx
+++ b/compilerplugins/clang/consttobool.cxx
@@ -16,6 +16,7 @@
 #include "clang/Basic/Builtins.h"
 
 #include "check.hxx"
+#include "compat.hxx"
 #include "plugin.hxx"
 
 // Find implicit conversions from non-'bool' constants (e.g., 'sal_False') to 
'bool'.
@@ -145,7 +146,7 @@ public:
 {
 if (auto const e = 
dyn_cast(sub->IgnoreParenImpCasts()))
 {
-if (e->isAscii()) // somewhat randomly restrict to plain 
literals
+if (compat::isOrdinary(e)) // somewhat randomly restrict to 
plain literals
 {
 if (compiler.getSourceManager().isMacroArgExpansion(l)
 && Lexer::getImmediateMacroName(l, 
compiler.getSourceManager(),
diff --git a/compilerplugins/clang/getimplementationname.cxx 
b/compilerplugins/clang/getimplementationname.cxx
index acc45acb7442..65cbabfdd4e9 100644
--- a/compilerplugins/clang/getimplementationname.cxx
+++ b/compilerplugins/clang/getimplementationname.cxx
@@ -20,6 +20,7 @@
 #include 
 #include 
 #include "check.hxx"
+#include "compat.hxx"
 #include "plugin.hxx"
 #include "clang/Frontend/CompilerInstance.h"
 
@@ -170,7 +171,7 @@ bool GetImplementationName::isStringConstant(
 }
 clang::StringLiteral const * lit = dyn_cast(expr);
 if (lit != nullptr) {
-if (!lit->isAscii()) {
+if (!compat::isOrdinary(lit)) {
 return false;
 }
 *string = lit->getString();
diff --git a/compilerplugins/clang/sallogareas.cxx 
b/compilerplugins/clang/sallogareas.cxx
index bd71128aa17c..f20c7f347e2f 100644
--- a/compilerplugins/clang/sallogareas.cxx
+++ b/compilerplugins/clang/sallogareas.cxx
@@ -116,7 +116,7 @@ bool SalLogAreas::VisitCallExpr( const CallExpr* call )
 };
 if( const clang::StringLiteral* area = dyn_cast< clang::StringLiteral >( 
call->getArg( areaArgIndex )->IgnoreParenImpCasts()))
 {
-if( area->getKind() == clang::StringLiteral::Ascii )
+if( compat::isOrdinary(area) )
 checkArea( area->getBytes(), area->getExprLoc());
 else
 report( DiagnosticsEngine::Warning, "unsupported string literal 
kind (plugin needs fixing?)",
diff --git a/compilerplugins/clang/stringconstant.cxx 
b/compilerplugins/clang/stringconstant.cxx
index 80b0b13882b6..cf1eb6afedbf 100644
--- a/compilerplugins/clang/stringconstant.cxx
+++ b/compilerplugins/clang/stringconstant.cxx
@@ -1385,7 +1385,7 @@ bool StringConstant::isStringConstant(
 }
 clang::StringLiteral const * lit = dyn_cast(expr);
 if (lit != nullptr) {
-if (!(lit->isAscii() || lit->isUTF8())) {
+if (!(compat::isOrdinary(lit) || lit->isUTF8())) {
 return false;
 }
 unsigned n = lit->getLength();

[Libreoffice-commits] core.git: Branch 'feature/chartdatatable' - chart2/Library_chartcontroller.mk chart2/source chart2/uiconfig chart2/UIConfig_chart2.mk officecfg/registry

[Tomaž Vajngerl (via logerrit)]

Rebased ref, commits from common ancestor:
commit 55c559349bb43304841b2610d22d3407739df226
Author: Tomaž Vajngerl 
AuthorDate: Fri Jul 1 22:00:38 2022 +0200
Commit: Tomaž Vajngerl 
CommitDate: Fri Jul 1 22:04:32 2022 +0200

chart2: InsertDataTableDialog for inserting/removing the data table

Change-Id: Ie3c033c587b150723e7aa39cd5ddf5774104db9a

diff --git a/chart2/Library_chartcontroller.mk 
b/chart2/Library_chartcontroller.mk
index 4bc8c7497915..cc25cdd907ae 100644
--- a/chart2/Library_chartcontroller.mk
+++ b/chart2/Library_chartcontroller.mk
@@ -109,6 +109,7 @@ $(eval $(call 
gb_Library_add_exception_objects,chartcontroller,\
 chart2/source/controller/dialogs/dlg_DataSource \
 chart2/source/controller/dialogs/dlg_InsertAxis_Grid \
 chart2/source/controller/dialogs/dlg_InsertDataLabel \
+chart2/source/controller/dialogs/dlg_InsertDataTable \
 chart2/source/controller/dialogs/dlg_InsertErrorBars \
 chart2/source/controller/dialogs/dlg_InsertLegend \
 chart2/source/controller/dialogs/dlg_InsertTitle \
@@ -122,6 +123,7 @@ $(eval $(call 
gb_Library_add_exception_objects,chartcontroller,\
 chart2/source/controller/dialogs/RangeSelectionListener \
 chart2/source/controller/dialogs/res_BarGeometry \
 chart2/source/controller/dialogs/res_DataLabel \
+chart2/source/controller/dialogs/res_DataTableProperties \
 chart2/source/controller/dialogs/res_ErrorBar \
 chart2/source/controller/dialogs/res_LegendPosition \
 chart2/source/controller/dialogs/res_Titles \
diff --git a/chart2/UIConfig_chart2.mk b/chart2/UIConfig_chart2.mk
index 59af510c5845..274efd02638f 100644
--- a/chart2/UIConfig_chart2.mk
+++ b/chart2/UIConfig_chart2.mk
@@ -44,7 +44,9 @@ $(eval $(call gb_UIConfig_add_uifiles,modules/schart,\
chart2/uiconfig/ui/combobox \
chart2/uiconfig/ui/datarangedialog \
chart2/uiconfig/ui/dlg_DataLabel \
+   chart2/uiconfig/ui/dlg_InsertDataTable \
chart2/uiconfig/ui/dlg_InsertErrorBars \
+   chart2/uiconfig/ui/dlg_InsertLegend \
chart2/uiconfig/ui/imagefragment \
chart2/uiconfig/ui/insertaxisdlg \
chart2/uiconfig/ui/insertgriddlg \
@@ -58,7 +60,6 @@ $(eval $(call gb_UIConfig_add_uifiles,modules/schart,\
chart2/uiconfig/ui/smoothlinesdlg \
chart2/uiconfig/ui/steppedlinesdlg \
chart2/uiconfig/ui/titlerotationtabpage \
-   chart2/uiconfig/ui/dlg_InsertLegend \
chart2/uiconfig/ui/tp_3D_SceneAppearance \
chart2/uiconfig/ui/tp_3D_SceneGeometry \
chart2/uiconfig/ui/tp_3D_SceneIllumination \
diff --git a/chart2/source/controller/dialogs/dlg_InsertDataTable.cxx 
b/chart2/source/controller/dialogs/dlg_InsertDataTable.cxx
new file mode 100644
index ..4b5e928db057
--- /dev/null
+++ b/chart2/source/controller/dialogs/dlg_InsertDataTable.cxx
@@ -0,0 +1,61 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include 
+
+namespace chart
+{
+InsertDataTableDialog::InsertDataTableDialog(weld::Window* pWindow)
+: GenericDialogController(pWindow, 
"modules/schart/ui/dlg_InsertDataTable.ui",
+  "InsertDataTableDialog")
+, m_aDataTablePropertiesResources(*m_xBuilder)
+, m_xCbShowDataTable(m_xBuilder->weld_check_button("showDataTable"))
+{
+m_xCbShowDataTable->connect_toggled(LINK(this, InsertDataTableDialog, 
ShowDataTableToggle));
+init(m_aData);
+}
+
+IMPL_LINK_NOARG(InsertDataTableDialog, ShowDataTableToggle, weld::Toggleable&, 
void)
+{
+changeEnabled();
+}
+
+void InsertDataTableDialog::changeEnabled()
+{
+bool bEnable = m_xCbShowDataTable->get_active();
+m_aDataTablePropertiesResources.setChecksSensitive(bEnable);
+m_aData.mbShow = bEnable;
+}
+
+void InsertDataTableDialog::init(DataTableDialogData const& rData)
+{
+m_aData = rData;
+
m_aDataTablePropertiesResources.setHorizontalBorder(m_aData.mbHorizontalBorders);
+
m_aDataTablePropertiesResources.setVerticalBorder(m_aData.mbVerticalBorders);
+m_aDataTablePropertiesResources.setOutline(m_aData.mbOutline);
+m_aDataTablePropertiesResources.setKeys(m_aData.mbKeys);
+m_xCbShowDataTable->set_active(m_aData.mbShow);
+changeEnabled();
+}
+
+DataTableDialogData& InsertDataTableDialog::getDataTableDialogData()
+{
+m_aData.mbShow = m_xCbShowDataTable->get_active();
+
+m_aData.mbHorizontalBorders = 
m_aDataTablePropertiesResources.getHorizontalBorder();
+m_aData.mbVerticalBorders = 
m_aDataTablePropertiesResources.getVerticalBorder();
+m_aData.mbOutline = m_aDataTablePropertiesResources.getOutline();
+m_aData.mbKeys = m_aDataTablePropertiesResources.getKeys();
+
+return m_aData;
+}
+

[Libreoffice-commits] core.git: Branch 'feature/chartdatatable' - 21 commits - chart2/inc chart2/Library_chartcontroller.mk chart2/Library_chartcore.mk chart2/source chart2/uiconfig chart2/UIConfig_ch

[Tomaž Vajngerl (via logerrit)]

Rebased ref, commits from common ancestor:
commit dbb95218b62bc2f48c2ecd8cc5fa5b93237e7547
Author: Tomaž Vajngerl 
AuthorDate: Fri Jul 1 22:00:38 2022 +0200
Commit: Tomaž Vajngerl 
CommitDate: Fri Jul 1 22:00:38 2022 +0200

chart2: add InsertDataTableDialog for adding the data table

Change-Id: Ie3c033c587b150723e7aa39cd5ddf5774104db9a

diff --git a/chart2/Library_chartcontroller.mk 
b/chart2/Library_chartcontroller.mk
index 4bc8c7497915..cc25cdd907ae 100644
--- a/chart2/Library_chartcontroller.mk
+++ b/chart2/Library_chartcontroller.mk
@@ -109,6 +109,7 @@ $(eval $(call 
gb_Library_add_exception_objects,chartcontroller,\
 chart2/source/controller/dialogs/dlg_DataSource \
 chart2/source/controller/dialogs/dlg_InsertAxis_Grid \
 chart2/source/controller/dialogs/dlg_InsertDataLabel \
+chart2/source/controller/dialogs/dlg_InsertDataTable \
 chart2/source/controller/dialogs/dlg_InsertErrorBars \
 chart2/source/controller/dialogs/dlg_InsertLegend \
 chart2/source/controller/dialogs/dlg_InsertTitle \
@@ -122,6 +123,7 @@ $(eval $(call 
gb_Library_add_exception_objects,chartcontroller,\
 chart2/source/controller/dialogs/RangeSelectionListener \
 chart2/source/controller/dialogs/res_BarGeometry \
 chart2/source/controller/dialogs/res_DataLabel \
+chart2/source/controller/dialogs/res_DataTableProperties \
 chart2/source/controller/dialogs/res_ErrorBar \
 chart2/source/controller/dialogs/res_LegendPosition \
 chart2/source/controller/dialogs/res_Titles \
diff --git a/chart2/UIConfig_chart2.mk b/chart2/UIConfig_chart2.mk
index 59af510c5845..274efd02638f 100644
--- a/chart2/UIConfig_chart2.mk
+++ b/chart2/UIConfig_chart2.mk
@@ -44,7 +44,9 @@ $(eval $(call gb_UIConfig_add_uifiles,modules/schart,\
chart2/uiconfig/ui/combobox \
chart2/uiconfig/ui/datarangedialog \
chart2/uiconfig/ui/dlg_DataLabel \
+   chart2/uiconfig/ui/dlg_InsertDataTable \
chart2/uiconfig/ui/dlg_InsertErrorBars \
+   chart2/uiconfig/ui/dlg_InsertLegend \
chart2/uiconfig/ui/imagefragment \
chart2/uiconfig/ui/insertaxisdlg \
chart2/uiconfig/ui/insertgriddlg \
@@ -58,7 +60,6 @@ $(eval $(call gb_UIConfig_add_uifiles,modules/schart,\
chart2/uiconfig/ui/smoothlinesdlg \
chart2/uiconfig/ui/steppedlinesdlg \
chart2/uiconfig/ui/titlerotationtabpage \
-   chart2/uiconfig/ui/dlg_InsertLegend \
chart2/uiconfig/ui/tp_3D_SceneAppearance \
chart2/uiconfig/ui/tp_3D_SceneGeometry \
chart2/uiconfig/ui/tp_3D_SceneIllumination \
diff --git a/chart2/source/controller/dialogs/dlg_InsertDataTable.cxx 
b/chart2/source/controller/dialogs/dlg_InsertDataTable.cxx
new file mode 100644
index ..4b5e928db057
--- /dev/null
+++ b/chart2/source/controller/dialogs/dlg_InsertDataTable.cxx
@@ -0,0 +1,61 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include 
+
+namespace chart
+{
+InsertDataTableDialog::InsertDataTableDialog(weld::Window* pWindow)
+: GenericDialogController(pWindow, 
"modules/schart/ui/dlg_InsertDataTable.ui",
+  "InsertDataTableDialog")
+, m_aDataTablePropertiesResources(*m_xBuilder)
+, m_xCbShowDataTable(m_xBuilder->weld_check_button("showDataTable"))
+{
+m_xCbShowDataTable->connect_toggled(LINK(this, InsertDataTableDialog, 
ShowDataTableToggle));
+init(m_aData);
+}
+
+IMPL_LINK_NOARG(InsertDataTableDialog, ShowDataTableToggle, weld::Toggleable&, 
void)
+{
+changeEnabled();
+}
+
+void InsertDataTableDialog::changeEnabled()
+{
+bool bEnable = m_xCbShowDataTable->get_active();
+m_aDataTablePropertiesResources.setChecksSensitive(bEnable);
+m_aData.mbShow = bEnable;
+}
+
+void InsertDataTableDialog::init(DataTableDialogData const& rData)
+{
+m_aData = rData;
+
m_aDataTablePropertiesResources.setHorizontalBorder(m_aData.mbHorizontalBorders);
+
m_aDataTablePropertiesResources.setVerticalBorder(m_aData.mbVerticalBorders);
+m_aDataTablePropertiesResources.setOutline(m_aData.mbOutline);
+m_aDataTablePropertiesResources.setKeys(m_aData.mbKeys);
+m_xCbShowDataTable->set_active(m_aData.mbShow);
+changeEnabled();
+}
+
+DataTableDialogData& InsertDataTableDialog::getDataTableDialogData()
+{
+m_aData.mbShow = m_xCbShowDataTable->get_active();
+
+m_aData.mbHorizontalBorders = 
m_aDataTablePropertiesResources.getHorizontalBorder();
+m_aData.mbVerticalBorders = 
m_aDataTablePropertiesResources.getVerticalBorder();
+m_aData.mbOutline = m_aDataTablePropertiesResources.getOutline();
+m_aData.mbKeys = m_aDataTablePropertiesResources.getKeys();
+
+return m_aData;
+}
+
+} 

[Libreoffice-commits] core.git: Changes to 'refs/tags/libreoffice-7.3.5.1'

[Christian Lohmaier (via logerrit)]

Tag 'libreoffice-7.3.5.1' created by Christian Lohmaier 
 at 2022-07-01 19:44 +

Tag libreoffice-7.3.5.1
-BEGIN PGP SIGNATURE-

iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmK/To8ACgkQ9DSh76/u
rqOvxw//cLSom1lMiJkwFJrdtc2x9pLkst+z9AgdFSw0M6Sg3NiJbv1aKg4DWYeI
TPjJDhLvjEkPy/0pqElbMNsEqbrgkJKkVDqLMqsrkxuFuRI0i94ptoD2+mWtb4UC
kb3Q2ezMpWGGlzfLM0bWNFMcMe2XIskiYKBR2mNKpxplhMF6yCBDX5wtopaCdBBm
stl6lyPYLewodaqjbG/70QShu6YfHbtHjwjg8PWxh6BCMo4yqzdBm+P1HqejWFCb
i6yh/EjRThQxLo0doLjoHG5IUmfEPosr+IMUka32dC/4gAyosgmb9tKDr7JK17hx
KQSmfMa56oUEMoKVE/7OEl9VD6yrWzLOsaPCJrO5gbtMfotqCCQZTQCES/xD73SE
g+epuI3tyf170Y1sWnlZnnBfKAaI0Y0jCIeFn6ZhbYTUK6K3tNRA1upIoy9GLcK5
YRzyJyX1FvqDRUeAbNHwc7zI/5THdcwEEy9vFscWbevRDW4+I+/afW0hEYYSdEag
VCdPfp48BaHRmiNNwyaDPpK5PT2vrXYQuY9KvSNA3399hm5S1s9r7NLUybVqI1ZZ
SF09Ak6odahgENCz8bRp50sPpNLCl3u5nT5SX+9qklphSHH4HFQgHVWQPRy8FLTB
BzVyXnOzeDFLEoWTfL8yY2Zs81oI7vvoDms8Ig7QVubcRPaXBos=
=pOt9
-END PGP SIGNATURE-

Changes since co-22.05-branch-point-689:
---
 0 files changed
---

[Libreoffice-commits] translations.git: Changes to 'refs/tags/libreoffice-7.3.5.1'

[Christian Lohmaier (via logerrit)]

Tag 'libreoffice-7.3.5.1' created by Christian Lohmaier 
 at 2022-07-01 19:44 +

Tag libreoffice-7.3.5.1
-BEGIN PGP SIGNATURE-

iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmK/To8ACgkQ9DSh76/u
rqOQ4A//YksMmR3cLF4mCv5Rw1K9uruHHeBBk0xBRK+FrwYOlhQPVTdqvhA5k9Wo
HmzVTemgOhkk4gqqtXF0eWbdnlGXfx4SFuPhL4qloThE0w9t5nwejkvcvSZBzS1x
0D5ke6aJEKD3xRwHQ7PXMPT7pa1dwDFju8XNPOUM1Hri8d/vODNsGhwsZin0UZUq
WItgV3bZ73M2DLo/Zb95m5E+fHBX7XZEiWxUcsoSz8Ltpkgrv4bDlVHnLOxGrygh
fxXh9Pqxq3tLjWuZRww5A7yCC7gIHcf27Zc26Zs8VuenAehfNstzoPToCL58deQ9
CSt7SUrBNSA2QPVS07HgqXM8GA/fzHTkpWYEhbTmij3V54xquoIHVQF3TrBlYhRo
EyXbQB22bpmBA/bAFYHc1b3vBcGk1UIc9mtfxsHlHIYBMRN/fUfoyRRwaPAx4N04
2RcBO9J4dZ2ytPUbpnAA8GkzHji9kxMKcosJLRO8lf/7cOSngOdroZenjk6VQCsh
Dj9HgxKpLVeKZkZ5oF0VUQ9afDy+TZdejYCwMIk9zbiKNyFkVV6ZgWhy9UcsmK0C
IwGJ0k/eQ6D0NiNqQhlOU9x1NNSm91HZdkdlttfvufB+ZpbzkxlneSyibvprga3v
00yWysul9Os70kp+eXVAKGuzKfkx66G1QVkMI5ThshtPatuQeyY=
=D9pk
-END PGP SIGNATURE-

Changes since co-22.05-branch-point-13:
---
 0 files changed
---

[Libreoffice-commits] help.git: Changes to 'refs/tags/libreoffice-7.3.5.1'

[Christian Lohmaier (via logerrit)]

Tag 'libreoffice-7.3.5.1' created by Christian Lohmaier 
 at 2022-07-01 19:44 +

Tag libreoffice-7.3.5.1
-BEGIN PGP SIGNATURE-

iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmK/To8ACgkQ9DSh76/u
rqPlqg//X6yRD3CdbUNo2x5a10qVZWQDJFHTjyU1VsaRfyudb3GCl60eyjSBErjY
sNiWm29120AuGviu3gTnS+tgyyGS+PVUXHqJEY5HpsnX+JhjPwSRCnrgV0PYy5+r
6XmyP02p0oXduYmK4sX/5kSXrjMwDOPfGCI8fVJBXhvQVN/75KD/9jc7B2CUu8i7
HZ42AafcOOnoeeqJ6u8HM+Nw/ZT6nX/L997fJrrFPHzBLZtBOrlBwkZzxaMK01zr
jFKSWUMUvgnzHqGW6oK7WQhxHsdB4IQl+J/tdUBfl+wWhiYQpfB59cULN48aPrud
Tr9C0jwThS/qf7izdd7ENy0Xq8jF+7kmmynJqP7OQYAkjzyepa6FjA100TMLRUR5
8K8vJroQK85xmwRBDSnETOY8pJXIWMUiP5x1k8idmKomXWTVleaVjzeKnlWb9HjD
dJWyczvzcRCQFBykW8eGd4OQ7UYlCk+Fja87sdI8tzDtD3kJiJGuMdlejrMrXp5z
LYWIGLOZrGXJe3wk8M+ajATppQ81sGsOQKlJXoiHbPQ6WDjq9c/f5LABTY1xQeA7
CyYDhRjK00ihof7NQ4RsrmDCPOegfpHQ33hqcAhRXgZvuW4NK1ilpRlQPvNvsKnM
E/ACy2gp+SHgZB3J1zSgm7vpjCEZN15dCC8YJKA+/od5i2i5FJk=
=5i0+
-END PGP SIGNATURE-

Changes since co-22.05-branch-point-3:
---
 0 files changed
---

[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/libreoffice-7.3.5.1'

[Christian Lohmaier (via logerrit)]

Tag 'libreoffice-7.3.5.1' created by Christian Lohmaier 
 at 2022-07-01 19:44 +

Tag libreoffice-7.3.5.1
-BEGIN PGP SIGNATURE-

iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmK/TosACgkQ9DSh76/u
rqOwTQ/+PbVQ/PPdVFDr/jLRx3zGrGGTuwZgX7D902CLszOCSSG8DOew3WbvwPo6
TexAF7SLIvxeCMPOVNvwW2IYBNub95rCN6a5nGNM7kRJdIKMvt+NqqrZoUIOVuze
F7NbNkMuwZnCsGpJqFqiSyBdceAF6GqmoanEh0XM7Fp7vz0CZHhAC25yEtsAOFcx
LBgCdYYyMVpOJKSKyTypCiA70jjln4dSfkDSKOAn2o+Lt4fzJBpRba4Ue/yWOqDL
Rwjh+4qnFO49TeKA5N08yG3XA4wPvst9D7QI1XRhKzmSZmcBurOK/h0a5uj0rGfi
79S5ORSfh6l/2EDPrf/M5+fCp+h50YaV6wgNEQcupgCGFxZR1Hc+FytZrNF2lBAP
swiFljf0f6XA0fSHf+P/QglV1YFf2wGQgMJv0G3XnKhhBnfzZs/rlZiU1ILpI/c5
YaGKcDfMbEYUCCoCJxw2nurMl+oJCElj84HgA0rYEOyfM847OKeczyk4SG28qf3l
b/X96UArsq7KFSqsIhRV/gvHhHwYEgJyxmWP+naNGowix796cfI53sVVC60LN65H
KyyvgPlDaHRQ0lKjl1KdakaWQ5KRpRgpLkz97Z/VCJH/kLmvDfIIbkr8dpCosRmQ
LMKe9g4mAnqC/ctcVXqobUhMDesEFicPILihNeYixk8J+AGVnJw=
=PQiA
-END PGP SIGNATURE-

Changes since cp-22.05.3-1-1:
---
 0 files changed
---

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3-5' - configure.ac

[Christian Lohmaier (via logerrit)]

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 035ef6ad02988339107eb3cf43cbc45a4ca1f48f
Author: Christian Lohmaier 
AuthorDate: Fri Jul 1 21:44:39 2022 +0200
Commit: Christian Lohmaier 
CommitDate: Fri Jul 1 21:44:39 2022 +0200

bump product version to 7.3.5.1.0+

Change-Id: Ief0b78fa3fe4ec16b6672320c7080181d01430b0

diff --git a/configure.ac b/configure.ac
index 55099b401f32..14eeccf14117 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([LibreOffice],[7.3.5.0.0+],[],[],[http://documentfoundation.org/])
+AC_INIT([LibreOffice],[7.3.5.1.0+],[],[],[http://documentfoundation.org/])
 
 dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just 
fine if it is installed
 dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails 
hard

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - configure.ac

[Christian Lohmaier (via logerrit)]

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 9e34b51f347a00257a50e7526bb7e3437f7f3b1a
Author: Christian Lohmaier 
AuthorDate: Fri Jul 1 21:39:45 2022 +0200
Commit: Christian Lohmaier 
CommitDate: Fri Jul 1 21:39:45 2022 +0200

bump product version to 7.3.6.0.0+

Change-Id: I6eeea91eee285da5381fbd4a44bb6736c699db3c

diff --git a/configure.ac b/configure.ac
index 55099b401f32..9073fb68858f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([LibreOffice],[7.3.5.0.0+],[],[],[http://documentfoundation.org/])
+AC_INIT([LibreOffice],[7.3.6.0.0+],[],[],[http://documentfoundation.org/])
 
 dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just 
fine if it is installed
 dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails 
hard

[Libreoffice-commits] core.git: Changes to 'libreoffice-7-3-5'

[Christian Lohmaier (via logerrit)]

New branch 'libreoffice-7-3-5' available with the following commits:
commit d7427a86b53e152553870355bf863de14c4479a4
Author: Christian Lohmaier 
Date:   Fri Jul 1 21:37:57 2022 +0200

Branch libreoffice-7-3-5

This is 'libreoffice-7-3-5' - the stable branch for the 7.3.5 release.
Only very safe changes, reviewed by three people are allowed.

If you want to commit more complicated fix for the next 7.3.x release,
please use the 'libreoffice-7-3' branch.

If you want to build something cool, unstable, and risky, use master.

[Libreoffice-commits] translations.git: Changes to 'libreoffice-7-3-5'

[Christian Lohmaier (via logerrit)]

New branch 'libreoffice-7-3-5' available with the following commits:
commit 956bee7b1b0d8077117ee306815da13dfee8deb8
Author: Christian Lohmaier 
Date:   Fri Jul 1 21:37:31 2022 +0200

Branch libreoffice-7-3-5

This is 'libreoffice-7-3-5' - the stable branch for the 7.3.5 release.
Only very safe changes, reviewed by three people are allowed.

If you want to commit more complicated fix for the next 7.3.x release,
please use the 'libreoffice-7-3' branch.

If you want to build something cool, unstable, and risky, use master.

Change-Id: I5cea0bff5cc85a1ee44cf6473a83b58f82046817

[Libreoffice-commits] dictionaries.git: Changes to 'libreoffice-7-3-5'

[Christian Lohmaier (via logerrit)]

New branch 'libreoffice-7-3-5' available with the following commits:
commit 23a110ded6bacb54257743e85f36a18faad653b6
Author: Christian Lohmaier 
Date:   Fri Jul 1 21:37:31 2022 +0200

Branch libreoffice-7-3-5

This is 'libreoffice-7-3-5' - the stable branch for the 7.3.5 release.
Only very safe changes, reviewed by three people are allowed.

If you want to commit more complicated fix for the next 7.3.x release,
please use the 'libreoffice-7-3' branch.

If you want to build something cool, unstable, and risky, use master.

Change-Id: I580a63734262403ee028cfd62a2676cb5d07b947

[Libreoffice-commits] help.git: Changes to 'libreoffice-7-3-5'

[Christian Lohmaier (via logerrit)]

New branch 'libreoffice-7-3-5' available with the following commits:
commit 01154b72ae4fb0532b04ea43338e44320cf7f22c
Author: Christian Lohmaier 
Date:   Fri Jul 1 21:37:31 2022 +0200

Branch libreoffice-7-3-5

This is 'libreoffice-7-3-5' - the stable branch for the 7.3.5 release.
Only very safe changes, reviewed by three people are allowed.

If you want to commit more complicated fix for the next 7.3.x release,
please use the 'libreoffice-7-3' branch.

If you want to build something cool, unstable, and risky, use master.

Change-Id: Ib0e2fa26db267fbd04ee0881df165ea44fbb3c16

[Libreoffice-bugs] [Bug 149603] MacOS Safari (Monterey) does not display LibreOffice HELP

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149603

--- Comment #2 from Commit Notification 
 ---
Christian Lohmaier committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/5460aadf5b8539f6dc5f0215e89d0feb6730ce6f

tdf#149603 macOS: fix workaround to use web help if Safari is the default
browser

It will be available in 7.3.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149603] MacOS Safari (Monterey) does not display LibreOffice HELP

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149603

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.5.0|target:7.5.0 target:7.3.5

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - 2 commits - config_host.mk.in configure.ac lo.xcent.in Makefile.in sfx2/source

[Christian Lohmaier (via logerrit)]

 Makefile.in  |4 +++-
 config_host.mk.in|1 +
 configure.ac |   19 +++
 lo.xcent.in  |1 +
 sfx2/source/appl/sfxhelp.cxx |   16 
 5 files changed, 40 insertions(+), 1 deletion(-)

New commits:
commit 720db024133b42e92fd3258f953819a6d9a456d5
Author: Christian Lohmaier 
AuthorDate: Wed Jun 29 13:35:01 2022 +0200
Commit: Christian Lohmaier 
CommitDate: Fri Jul 1 21:07:01 2022 +0200

allow to specify a macOS provisioning profile

having one is one of the prerequisites of using TestFlight

Change-Id: I9e20eb99905071fade4179dfbe2da5b7e5dd1c24
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136618
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier 
(cherry picked from commit b43f0b0295953c8d5d16c5b9eccaddb5ec214bab)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136695

diff --git a/Makefile.in b/Makefile.in
index d3f1047be4ca..a5ae689b614e 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -387,7 +387,9 @@ ifneq ($(ENABLE_MACOSX_SANDBOX),)
rm 
$(TESTINSTALLDIR)/$(PRODUCTNAME_WITHOUT_SPACES).app/Contents/MacOS/unopkg
rm 
$(TESTINSTALLDIR)/$(PRODUCTNAME_WITHOUT_SPACES).app/Contents/MacOS/unoinfo
 endif
-#
+ifneq ($(MACOSX_PROVISIONING_PROFILE),)
+   cp "$(MACOSX_PROVISIONING_PROFILE)" 
$(TESTINSTALLDIR)/$(PRODUCTNAME_WITHOUT_SPACES).app/Contents/embedded.provisionprofile
+endif
 ifneq ($(MACOSX_CODESIGNING_IDENTITY),)
 # Then use the macosx-codesign-app-bundle script
@$(SRCDIR)/solenv/bin/macosx-codesign-app-bundle 
$(TESTINSTALLDIR)/$(PRODUCTNAME_WITHOUT_SPACES).app
diff --git a/config_host.mk.in b/config_host.mk.in
index 02f6ec6aba46..847d63c13a50 100644
--- a/config_host.mk.in
+++ b/config_host.mk.in
@@ -425,6 +425,7 @@ export MACOSX_BUNDLE_IDENTIFIER=@MACOSX_BUNDLE_IDENTIFIER@
 export MACOSX_CODESIGNING_IDENTITY=@MACOSX_CODESIGNING_IDENTITY@
 export MACOSX_DEPLOYMENT_TARGET=@MACOSX_DEPLOYMENT_TARGET@
 export MACOSX_PACKAGE_SIGNING_IDENTITY=@MACOSX_PACKAGE_SIGNING_IDENTITY@
+export MACOSX_PROVISIONING_PROFILE=@MACOSX_PROVISIONING_PROFILE@
 export MACOSX_SDK_PATH=@MACOSX_SDK_PATH@
 export MAC_OS_X_VERSION_MAX_ALLOWED=@MAC_OS_X_VERSION_MAX_ALLOWED@
 export MAC_OS_X_VERSION_MIN_REQUIRED=@MAC_OS_X_VERSION_MIN_REQUIRED@
diff --git a/configure.ac b/configure.ac
index db33c873cd83..55099b401f32 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1848,6 +1848,11 @@ AC_ARG_WITH(macosx-bundle-identifier,
  org.libreoffice.script ("script", huh?).]),
 ,with_macosx_bundle_identifier=org.libreoffice.script)
 
+AC_ARG_WITH(macosx-provisioning-profile,
+
AS_HELP_STRING([--with-macosx-provisioning-profile=/path/to/mac.provisionprofile],
+[Specify the path to a provisioning profile to use]),
+,)
+
 AC_ARG_WITH(product-name,
 AS_HELP_STRING([--with-product-name='My Own Office Suite'],
 [Define the product name. Default is AC_PACKAGE_NAME.]),
@@ -3549,6 +3554,18 @@ if test $_os = Darwin; then
 AC_MSG_CHECKING([what macOS app bundle identifier to use])
 MACOSX_BUNDLE_IDENTIFIER=$with_macosx_bundle_identifier
 AC_MSG_RESULT([$MACOSX_BUNDLE_IDENTIFIER])
+
+if test -n "$with_macosx_provisioning_profile" ; then
+if test ! -f "$with_macosx_provisioning_profile"; then
+AC_MSG_ERROR([provisioning profile not found at 
$with_macosx_provisioning_profile])
+else
+MACOSX_PROVISIONING_PROFILE=$with_macosx_provisioning_profile
+MACOSX_PROVISIONING_INFO=$([security cms -D -i 
"$MACOSX_PROVISIONING_PROFILE" | \
+xmllint --xpath "//key[.='com.apple.application-identifier' or 
.='com.apple.developer.team-identifier'] \
+| //key[.='com.apple.application-identifier' or 
.='com.apple.developer.team-identifier']/following-sibling::string[1]" - | \
+sed -e 's#><#>\n\t<#g' -e 's#^#\t#'])
+fi
+fi
 fi
 AC_SUBST(MACOSX_SDK_PATH)
 AC_SUBST(MACOSX_DEPLOYMENT_TARGET)
@@ -3560,6 +3577,8 @@ AC_SUBST(MACOSX_CODESIGNING_IDENTITY)
 AC_SUBST(MACOSX_PACKAGE_SIGNING_IDENTITY)
 AC_SUBST(ENABLE_MACOSX_SANDBOX)
 AC_SUBST(MACOSX_BUNDLE_IDENTIFIER)
+AC_SUBST(MACOSX_PROVISIONING_INFO)
+AC_SUBST(MACOSX_PROVISIONING_PROFILE)
 
 dnl ===
 dnl Check iOS SDK and compiler
diff --git a/lo.xcent.in b/lo.xcent.in
index 9a0838fbc388..4b7303876e6b 100644
--- a/lo.xcent.in
+++ b/lo.xcent.in
@@ -22,5 +22,6 @@
 com.apple.security.personal-information.addressbook
 
 @SDREMOTE_ENTITLEMENT@
+@MACOSX_PROVISIONING_INFO@
 
 
commit 5460aadf5b8539f6dc5f0215e89d0feb6730ce6f
Author: Christian Lohmaier 
AuthorDate: Thu Jun 30 22:23:30 2022 +0200
Commit: Christian Lohmaier 
CommitDate: Fri Jul 1 21:06:46 2022 +0200

tdf#149603 macOS: fix workaround to use web help if Safari is the default 
browser

Safari won't access the local helpfiles from LO's app folder 

[Libreoffice-bugs] [Bug 149085] The "Protect" section on the Options tab of {Image, Frame, Object} Properties dialog should be on the "Position and Size" tab

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149085

--- Comment #9 from Telesto  ---
(In reply to sdc.blanco from comment #8)
> Position = Position settings on Position and Size tab.
> 
> @Telesto -
>1. Try using page reference positions for Horizontal and Vertical. 
>   Dragging anchor will not change position. 

True, but is this because of the position protection or simply the result of
position area? 

>2. For Paragraph Reference area, note settings, drag anchor to new
> paragraph.
>   Note the settings have not changed.

True, but toggling protect position on/off doesn't make a difference for this
to happen, as far I'm aware.. However the absolute position has changed. 
I'm not saying the behaviour being incorrect, more that someone could assume
that the shape/image being fixated at a certain spot in any situation. 

>
>ergo: Position setting is (pretty) absolute.
> 
>  (matter of taste whether the Protect setting should 
>   also lock the dialog. Seems unnecessary imo.)

Yes it's matter of taste. The current behaviour is actually the intended one, I
guess. Protect size/position is a lock against in document modifications by
moving the shape with arrows/or mouse or resizing the shape with handles. At
least that's what I think the position/ size lock being about.

The only thing I'm concerned about is proper label. Protect actually is:
Protect against in document modifications..  or at least assume this being the
actual purpose of the checkboxes (protect position/ protect size). The current
UI doesn't reflect that (nor the documentation). But well I'm one of those who
like self-explaining UI above pointing to documentation.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149810] FILEOPEN CSV containing formula not recognized

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149810

Jay Schwartz  changed:

   What|Removed |Added

   Hardware|All |x86-64 (AMD64)
Version|unspecified |7.3.4.2 release
 OS|All |Windows (All)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149810] New: FILEOPEN CSV containing formula not recognized

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149810

Bug ID: 149810
   Summary: FILEOPEN CSV containing formula not recognized
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jschwa...@elipse.ca

Formulas in cells are treated as text. 
The leading = is not signalling formula. 
Seeing this in version 7.3.4.2.
Worked in 7.2 and earlier.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149807] Libreoffice Calc regularly/randomly hangs on macOS mojave

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149807

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #2 from m.a.riosv  ---
Maybe a dup of https://bugs.documentfoundation.org/show_bug.cgi?id=148265

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149085] The "Protect" section on the Options tab of {Image, Frame, Object} Properties dialog should be on the "Position and Size" tab

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149085

--- Comment #8 from sdc.bla...@youmail.dk ---
Position = Position settings on Position and Size tab.

@Telesto -
   1. Try using page reference positions for Horizontal and Vertical. 
  Dragging anchor will not change position. 

   2. For Paragraph Reference area, note settings, drag anchor to new
paragraph.
  Note the settings have not changed.

   ergo: Position setting is (pretty) absolute.

 (matter of taste whether the Protect setting should 
  also lock the dialog. Seems unnecessary imo.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149800] Unwanted white border in exported SVG

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149800

Buovjaga  changed:

   What|Removed |Added

Version|7.3.4.2 release |4.0.0.3 release

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149800] Unwanted white border in exported SVG

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149800

Rainer Bielefeld Retired  changed:

   What|Removed |Added

 CC||LibreOffice@bielefeldundbus
   ||s.de
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #2 from Rainer Bielefeld Retired  
---
REPRODUCIBLE with reporter's sample documentand Installation of Version:
7.3.3.2 (x64) Build ID: d1d0ea68f081ee2800a922cac8f79445e4603348
CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE |  Calc: threaded | ElementaryTheme | My
normal User Profile:

1. Open sample document
2. Select complete drawing shape by mouse frame
3. File  →  Export selection to SVG 
   » Expected: drawing shape looks exactly as in .odg (as it does in all other
   drawing format exports I tested (gif, tiff, ...)
   » Actual: ligth grey border around rectangle 2


a)Same already with Server Installation of Version:  4.0.0.3 WIN10
Build-ID  7545bee9c2a0782548772a21bc84a9dcc583b89; Special devUserProfile

b)Still REPRODUCIBLE with Server Installation of Version: 7.4.0.0.alpha0+ (x64)
 Build ID b871abad383583f02eb49c7e49aeae01f6941072
CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-US  |  Calc: CL  |  Auto Colibre Theme  | 
Special devUserProfile

c) Rectangle "2" has on margin line in .odg

d) No obvious DUP found with Query

(except Bug 149801)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145198] Bash like autocompletion for Calc's autoinput

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145198

--- Comment #4 from bugzil...@cb-computerservice.at ---
Is it possible to switch between old and new auto-completion behaviour? Because
this new behaviour is worse for me.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149085] The "Protect" section on the Options tab of {Image, Frame, Object} Properties dialog should be on the "Position and Size" tab

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149085

--- Comment #7 from Telesto  ---
Related, but not directly the bug report here: there is some confusion about
the meaning of protect size and position. See bug 148593 comment 6.

The scope of the protection is limited to resize with drag handles or
reposition shapes/images with mouse cursor, as far I'm aware.. but well the
dialog isn't to specific about that. Which surely source for confusion. 

You can still resize/reposition the shape/image in the Position and Size tab.
And you can still drag the anchor (in case of to character anchoring), which
will move the image too.

Bottom Line: the protection is not absolute, but partial. I prefer some less
genetic label (instead of protection). Something in the direction of "Block
changes by mouse" [not good enough.. needs a better phrasing]

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149808] EDITING: Right-Click Inoperative

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149808

Julien Nabet  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Julien Nabet  ---


*** This bug has been marked as a duplicate of bug 149537 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 72341] Increase/Decrease font doesn't apply to bullet in RTL paragraph when text script isn't RTL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72341

--- Comment #17 from Faisal  ---
Still reproducible in

Version: 7.3.4.2 / LibreOffice Community
Build ID: 30(Build:2)
CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-GB (en_US.UTF-8); UI: en-US
7.3.4-2
Calc: threaded


Steps to reproduce:
1. Type some text with a bullet (unnumbered or numbered)
2. Make text right-to-left using the paragraphs dialog
3. Resize the text using keyboard shortcuts (Ctrl + [ or Ctrl + ]) or
increase/decrease text size button on toolbar

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: helpcontent2

[Alain Romedenne (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 7a89eae97a970939174d59aa58147eaa194acaee
Author: Alain Romedenne 
AuthorDate: Fri Jul 1 18:14:53 2022 +0200
Commit: Gerrit Code Review 
CommitDate: Fri Jul 1 18:14:53 2022 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to e9d5f04452ea8747348da648212681b4ec46ee15
  - tdf#148611 Base help page link is missing or incorrect

Change-Id: Id835c0348887c8eba290ba8693230d1002e15c91
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136652
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index d6e98a37ec8c..e9d5f04452ea 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit d6e98a37ec8cd0adc8219466555b200bd3b9af8b
+Subproject commit e9d5f04452ea8747348da648212681b4ec46ee15

[Libreoffice-bugs] [Bug 148611] Help Page "Connection Pooling" not found

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148611

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.5.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148611] Help Page "Connection Pooling" not found

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148611

--- Comment #2 from Commit Notification 
 ---
Alain Romedenne committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/e9d5f04452ea8747348da648212681b4ec46ee15

tdf#148611 Base help page link is missing or incorrect

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] help.git: source/text

[Alain Romedenne (via logerrit)]

 source/text/shared/optionen/01160100.xhp |   20 +---
 1 file changed, 9 insertions(+), 11 deletions(-)

New commits:
commit e9d5f04452ea8747348da648212681b4ec46ee15
Author: Alain Romedenne 
AuthorDate: Thu Jun 30 17:05:56 2022 +0200
Commit: Olivier Hallot 
CommitDate: Fri Jul 1 18:14:52 2022 +0200

tdf#148611 Base help page link is missing or incorrect

Change-Id: Id835c0348887c8eba290ba8693230d1002e15c91
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136652
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/shared/optionen/01160100.xhp 
b/source/text/shared/optionen/01160100.xhp
index 6c3fff9c3..5546786b5 100644
--- a/source/text/shared/optionen/01160100.xhp
+++ b/source/text/shared/optionen/01160100.xhp
@@ -1,6 +1,5 @@
 
 
-
 
 
-
-   
 
 
 
@@ -37,26 +34,27 @@
 data sources; connection settings (Base)
 
 
-Connections
+
+Connections
 Defines how 
the connections to data sources are pooled.
 
-The 
Connections facility allows you to stipulate that connections that are 
no longer needed are not deleted immediately, but are kept freeUFI: 
better: idle ? for a certain period of time. If a new connection to 
the data source is needed in that period, the free connection can be used for 
this purpose.
+The Connections 
facility allows you to stipulate that connections that are no longer 
needed are not deleted immediately, but are kept freeUFI: better: idle 
? for a certain period of time. If a new connection to the data 
source is needed in that period, the free connection can be used for this 
purpose.
 
   
 
-Connection Pool
+Connection Pool
 
-Connection pooling enabled
+Connection pooling enabled
 Specifies whether the chosen 
connections are pooled.
-Drivers 
known in $[officename]
+Drivers known in $[officename]
 Displays a 
list of defined drivers and connection data.
-Current 
driver
+Current driver
 The currently 
selected driver is displayed below the list.
 
-Enable 
pooling for this driver
+Enable pooling for this driver
 Select a driver from the list and 
mark the Enable pooling for this driver checkbox in order to pool 
its connection.
 
-Timeout 
(seconds)
+Timeout (seconds)
 Defines the time in seconds after which a 
pooled connection is freed. The time can be anywhere between 30 and 600 
seconds.
 
 

[Libreoffice-bugs] [Bug 104444] [META] DOCX (OOXML) table-related issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=10
Bug 10 depends on bug 126395, which changed state.

Bug 126395 Summary: DOCX-Table: Incorrect column order for table using word 
document (rtl)
https://bugs.documentfoundation.org/show_bug.cgi?id=126395

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 43808] [META] Right-To-Left and Complex Text Layout language issues (RTL/CTL)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=43808
Bug 43808 depends on bug 126395, which changed state.

Bug 126395 Summary: DOCX-Table: Incorrect column order for table using word 
document (rtl)
https://bugs.documentfoundation.org/show_bug.cgi?id=126395

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

IMPORTANT UPDATE LibreOffice Conference

[Italo Vignoli]

We apologize for being silent about LibreOffice Conference 2022, but we 
have had significant but unforeseeable logistic issues in Bolzano when 
we have looked for available hotel rooms.


Even the local tourism authority has not been able to find more than a 
handful of rooms available for the last week of September, definitely 
not enough for the number of attendees we are expecting.


Luckily, there are other beautiful cities in Italy. To avoid similar 
issues, we have decided to explore Milan, as the number of conference 
venues and hotel rooms is so large that chances of finding somethig 
suitable was definitely higher.


In fact, we have found a beautiful conference space right behind Piazza 
del Duomo at Fondazione Culturale San Fedele, right in the center of the 
city, and rooms in hotels close to the metro (which reaches Piazza del 
Duomo). The conference will represent an opportunity to visit Milan, 
which is one of Italy's most beautiful cities.


We will share all logistic details before July 15. Together with the 
logistic details, we will share infos about places to see, and food & 
drinks to enjoy.


The dates of the conference have not changed: we will start on September 
28 with community meetings, while the conference will be on September 29 
and 30 (full day), and will close in the morning of October 1st.


People who want to attend the event can start looking at flights to one 
of Milan's three airports: Milan Linate (LIN), Milan Malpensa (MXP) and 
Bergamo Orio al Serio (BGY). Milan can be reached by high-speed train 
from Paris, and with long-distance trains from most of Europe.


As soon as we share logistic details, we also suggest people to look for 
hotel rooms based on the list of affordable hotels close to the metro we 
are putting together. Most of the hotels will be rather small, as large 
hotels are usually quite expensive.


Milan has a rather large metro network, and public transport which get 
almost everywhere. To get around the city with public transport, we use 
the Moovit smartphone app, which is quite helpful. Taxis are extremely 
expensive, and should be used only for emergencies (NEVER from and to 
airports, as there are cheap bus services).


Looking forward to meeting the community in Milan, nine years after 2013 
LibOCon hosted by the University of Milan.


Best regards, Italo

NOTE - Please share this message with your native language community


--
Italo Vignoli - LibreOffice Marketing & PR
mobile/signal +39.348.5653829 - email it...@libreoffice.org
GPG Key ID - 0xAAB8D5C0
DB75 1534 3FD0 EA5F 56B5 FDA6 DE82 934C AAB8 D5C0

[Libreoffice-qa] IMPORTANT UPDATE LibreOffice Conference

[Italo Vignoli]

We apologize for being silent about LibreOffice Conference 2022, but we 
have had significant but unforeseeable logistic issues in Bolzano when 
we have looked for available hotel rooms.


Even the local tourism authority has not been able to find more than a 
handful of rooms available for the last week of September, definitely 
not enough for the number of attendees we are expecting.


Luckily, there are other beautiful cities in Italy. To avoid similar 
issues, we have decided to explore Milan, as the number of conference 
venues and hotel rooms is so large that chances of finding somethig 
suitable was definitely higher.


In fact, we have found a beautiful conference space right behind Piazza 
del Duomo at Fondazione Culturale San Fedele, right in the center of the 
city, and rooms in hotels close to the metro (which reaches Piazza del 
Duomo). The conference will represent an opportunity to visit Milan, 
which is one of Italy's most beautiful cities.


We will share all logistic details before July 15. Together with the 
logistic details, we will share infos about places to see, and food & 
drinks to enjoy.


The dates of the conference have not changed: we will start on September 
28 with community meetings, while the conference will be on September 29 
and 30 (full day), and will close in the morning of October 1st.


People who want to attend the event can start looking at flights to one 
of Milan's three airports: Milan Linate (LIN), Milan Malpensa (MXP) and 
Bergamo Orio al Serio (BGY). Milan can be reached by high-speed train 
from Paris, and with long-distance trains from most of Europe.


As soon as we share logistic details, we also suggest people to look for 
hotel rooms based on the list of affordable hotels close to the metro we 
are putting together. Most of the hotels will be rather small, as large 
hotels are usually quite expensive.


Milan has a rather large metro network, and public transport which get 
almost everywhere. To get around the city with public transport, we use 
the Moovit smartphone app, which is quite helpful. Taxis are extremely 
expensive, and should be used only for emergencies (NEVER from and to 
airports, as there are cheap bus services).


Looking forward to meeting the community in Milan, nine years after 2013 
LibOCon hosted by the University of Milan.


Best regards, Italo

NOTE - Please share this message with your native language community


--
Italo Vignoli - LibreOffice Marketing & PR
mobile/signal +39.348.5653829 - email it...@libreoffice.org
GPG Key ID - 0xAAB8D5C0
DB75 1534 3FD0 EA5F 56B5 FDA6 DE82 934C AAB8 D5C0

[Libreoffice-bugs] [Bug 149809] New: FILEOPEN FILESAVE Text orientation is wrong after round-trip

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149809

Bug ID: 149809
   Summary: FILEOPEN FILESAVE Text orientation is wrong after
round-trip
   Product: LibreOffice
   Version: 7.5.0.0 alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de
CC: vmik...@collabora.com

Created attachment 181071
  --> https://bugs.documentfoundation.org/attachment.cgi?id=181071=edit
Test document from unit test

This is a follow-up to bug 87924.

The attached document is the test document from unit test
DECLARE_OOXMLIMPORT_TEST(testTdf87924, "tdf87924.docx").

Open the saved document in Word. Notice, that the text appears horizontal. In
fact the text is with text direction "Rotate all text 270°" which compensates
the 90° shape rotation.

Now open the document in LO. The text appears horizontal. Reason is, that the
text was set to "Rotate all text 0°".

Now save the document without any change to .docx format and open the saved
document in Word. Notice, that the text is vertical.

The fix for bug 87924 does not really work. But removing the matrix and the
rotation test does not solve the problem, since then the text is vertical
because the frame does not has the needed rotation for compensation.

[The matrix is wrong, but works accidentally for 90° and -90° rotations.]

A solution is complicated. I see several ways:
A) Keep "Rotate all text 270°" on import and export. But because the attached
frame is not able to rotate but honors writing modes, fake the writing
direction on rendering, so that it is looks as if the frame could rotate.
B) Set "Rotate all text 0°" on import and set it back to "Rotate all text 270°"
on export by considering the shape rotation on export too.
C) Do not use frames in case the shape is rotated.
D) Implement rotation for text frames at least for multiples of 90°.

My favorite is to use C) as short term solution. That would solve in addition
the error, that the text has a wrong position. Solution D) should be used in
the long term.
Solution C) would in addition allow to implement a true "upright" in Writer
too. Currently the text looks upright because the frame cannot rotate. But
saving and opening the saved document in Word shows that "upright" is not
handled correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 113488] Better support for Assistive Technology tools by exposing descriptive tooltips text with keyboard navigation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113488

--- Comment #2 from Michael Weghorn  ---
(In reply to Michael Weghorn from comment #1)
> Is it to have the tooltips read out by default by screen readers when
> focusing an item using the keyboard, e.g. by having them in the accessible
> name (or accessible description)?
> 
> If so: At least Orca and NVDA have an option in their settings to announce
> tooltips also, so I'm wondering whether it shouldn't be dependent on that
> option whether or not tooltips are announced.

After having looked closer at this option in Orca: I probably misunderstood
what the option is about. I thought that would somehow also have an effect when
moving keyboard focus to a UI element, but it seems to be mostly about tooltips
actually shown on screen, e.g. when hovering using the mouse. (And the "Present
tooltips" options is actually in a "Mouse" section in Orca settings.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149808] EDITING: Right-Click Inoperative

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149808

--- Comment #1 from Jorge E Restrepo  ---
I found that the Right-Click problem might be broader...   Tried a Right-Click
on Draw's left (Page) pane and does not show the add new page... menu

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149709] EDITING Track Changes: Writer does not show number change of second-level numbered paragraphs correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149709

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.5.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149709] EDITING Track Changes: Writer does not show number change of second-level numbered paragraphs correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149709

--- Comment #4 from Commit Notification 
 ---
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/db1f4457543918b5e3cd8b4d3a70676855952314

tdf#149709 sw_redlinenum: fix list levels

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143003] [META] Tracked Changes of ordered and unordered lists

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143003
Bug 143003 depends on bug 149709, which changed state.

Bug 149709 Summary: EDITING Track Changes: Writer does not show number change 
of second-level numbered paragraphs correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=149709

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149709] EDITING Track Changes: Writer does not show number change of second-level numbered paragraphs correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149709

László Németh  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/qa sw/source

[László Németh (via logerrit)]

 sw/qa/extras/layout/data/tdf149709.fodt |   41 +++
 sw/qa/extras/layout/layout2.cxx |   57 
 sw/source/core/txtnode/ndtxt.cxx|6 +++
 3 files changed, 104 insertions(+)

New commits:
commit db1f4457543918b5e3cd8b4d3a70676855952314
Author: László Németh 
AuthorDate: Fri Jul 1 11:49:45 2022 +0200
Commit: László Németh 
CommitDate: Fri Jul 1 16:48:42 2022 +0200

tdf#149709 sw_redlinenum: fix list levels

Levels of ORIGTEXT SwNodeNum weren't updated,
resulting bad numbering of multilevel lists during
editing and file import.

Follow-up to commit d0e49c07203c9ae33c5dfa1855b2b8909c3e16dc
"tdf#115524 sw_redlinenum: show original numbering of insertions".

Change-Id: I478971643a10b2007f37a4f0074067896d546228
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136734
Tested-by: Jenkins
Reviewed-by: László Németh 

diff --git a/sw/qa/extras/layout/data/tdf149709.fodt 
b/sw/qa/extras/layout/data/tdf149709.fodt
new file mode 100644
index ..0a33515d1ca9
--- /dev/null
+++ b/sw/qa/extras/layout/data/tdf149709.fodt
@@ -0,0 +1,41 @@
+
+
+http://www.w3.org/1999/xlink; 
xmlns:dc="http://purl.org/dc/elements/1.1/; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" 
xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oas
 is:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:rpt="http://openoffice.org/2005/report; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 
xmlns:officeooo="http://openoffice.org/2009/office; 
xmlns:tableooo="http://openoffice.org/2009/table; 
xmlns:drawooo="http://openoffice.org/2010/draw; 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:formx="urn:openoffice:names:
 experimental:ooxml-odf-interop:xmlns:form:1.0" 
xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" 
office:mimetype="application/vnd.oasis.opendocument.text">
+ 
+  
+   
+  
+ 
+   
+
+ 
+
+   
+   
+
+ 
+
+   
+  
+ 
+ 
+  
+   
+
+ Item
+ 
+  
+   Item
+  
+  
+   Item
+  
+ 
+
+
+ Item
+
+   
+  
+ 
+
diff --git a/sw/qa/extras/layout/layout2.cxx b/sw/qa/extras/layout/layout2.cxx
index c9c0a80ca9eb..c755bd62514f 100644
--- a/sw/qa/extras/layout/layout2.cxx
+++ b/sw/qa/extras/layout/layout2.cxx
@@ -509,6 +509,63 @@ CPPUNIT_TEST_FIXTURE(SwLayoutWriter2, 
testTdf149710_RedlineNumberingEditing)
 assertXPathContent(pXmlDoc, "/metafile/push/push/push/textarray[5]/text", 
"3.");
 }
 
+CPPUNIT_TEST_FIXTURE(SwLayoutWriter2, testTdf149709_RedlineNumberingLevel)
+{
+SwDoc* pDoc = createSwDoc(DATA_DIRECTORY, "tdf149709.fodt");
+SwXTextDocument* pTextDoc = 
dynamic_cast(mxComponent.get());
+CPPUNIT_ASSERT(pTextDoc);
+
+// Show Changes
+SwWrtShell* pWrtShell = pTextDoc->GetDocShell()->GetWrtShell();
+SwRootFrame* pLayout(pWrtShell->GetLayout());
+CPPUNIT_ASSERT(!pLayout->IsHideRedlines());
+
+// insert a new list item at start of the second list item "a)"
+dispatchCommand(mxComponent, ".uno:TrackChanges", {});
+pWrtShell->Down(false, 1);
+pWrtShell->SplitNode(false);
+
+// Dump the rendering of the first page as an XML file.
+SwDocShell* pShell = pDoc->GetDocShell();
+std::shared_ptr xMetaFile = pShell->GetPreviewMetaFile();
+MetafileXmlDump dumper;
+
+xmlDocUniquePtr pXmlDoc = dumpAndParse(dumper, *xMetaFile);
+CPPUNIT_ASSERT(pXmlDoc);
+
+// Show the correct and the original line numbering instead of counting
+// the deleted list items in Show Changes mode, as part of the list
+assertXPathContent(pXmlDoc, "/metafile/push/push/push/textarray[1]/text", 
"1.");
+assertXPathContent(pXmlDoc, "/metafile/push/push/push/textarray[3]/text", 
"a)");
+// This was "b)[2.]"
+assertXPathContent(pXmlDoc, "/metafile/push/push/push/textarray[4]/text", 
"b)[a)] ");
+// This was "c)[3.]"
+

[Libreoffice-commits] core.git: sd/qa

[Xisco Fauli (via logerrit)]

 sd/qa/uitest/impress_tests/tdf149787.py |   40 
 1 file changed, 40 insertions(+)

New commits:
commit c62587987f2046b3b4b22af3d9897dd17077d5a8
Author: Xisco Fauli 
AuthorDate: Fri Jul 1 11:33:21 2022 +0200
Commit: Xisco Fauli 
CommitDate: Fri Jul 1 16:47:54 2022 +0200

tdf#149787: sd: Add unittest

Change-Id: I27ec82fb8942f8cf6d663ae358ef29a2f6fa940f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136726
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sd/qa/uitest/impress_tests/tdf149787.py 
b/sd/qa/uitest/impress_tests/tdf149787.py
new file mode 100644
index ..3d65f1c0bb87
--- /dev/null
+++ b/sd/qa/uitest/impress_tests/tdf149787.py
@@ -0,0 +1,40 @@
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+from libreoffice.uno.propertyvalue import mkPropertyValues
+from uitest.framework import UITestCase
+from uitest.uihelper.common import select_pos
+
+class TestTdf149787(UITestCase):
+
+def testTdf149787(self):
+with self.ui_test.create_doc_in_start_center("impress") as document:
+
+xTemplateDlg = self.xUITest.getTopFocusWindow()
+xCancelBtn = xTemplateDlg.getChild("close")
+self.ui_test.close_dialog_through_button(xCancelBtn)
+
+xImpressDoc = self.xUITest.getTopFocusWindow()
+
+self.assertIsNone(document.CurrentSelection)
+
+xEditWin = xImpressDoc.getChild("impress_win")
+xEditWin.executeAction("SELECT", 
mkPropertyValues({"OBJECT":"Unnamed Drawinglayer object 1"}))
+self.assertEqual("com.sun.star.drawing.SvxShapeCollection", 
document.CurrentSelection.getImplementationName())
+
+with 
self.ui_test.execute_dialog_through_command(".uno:FormatArea", 
close_button="cancel") as xDialog:
+tabControl = xDialog.getChild("tabcontrol")
+select_pos(tabControl, "0")
+btnColor = xDialog.getChild("btncolor")
+btnColor.executeAction("CLICK", tuple())
+btnMoreColors = xDialog.getChild("btnMoreColors")
+
+with 
self.ui_test.execute_blocking_action(btnMoreColors.executeAction, 
args=('CLICK', ()), close_button="buttonClose") as dialog:
+xCloseBtn = dialog.getChild("buttonClose")
+self.ui_test.wait_until_property_is_updated(xCloseBtn, 
"Enabled", "true")
+
+
+# vim: set shiftwidth=4 softtabstop=4 expandtab:

[Libreoffice-bugs] [Bug 149770] Over the past few weeks when I open a document that has already been saved, it wants to save it.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149770

Timur  changed:

   What|Removed |Added

   Priority|medium  |lowest

--- Comment #2 from Timur  ---
That most likely a local problem, not LO bug reproducible by others. 
You wrote "User Profile Reset: Yes" but please confirm you really did rename or
delete LO user folder. 
And paste Help-About.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: helpcontent2

[Rafael Lima (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e6fcee376f45c6701ef74c9e62aa1d6aa932cef3
Author: Rafael Lima 
AuthorDate: Fri Jul 1 16:41:26 2022 +0200
Commit: Gerrit Code Review 
CommitDate: Fri Jul 1 16:41:26 2022 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to d6e98a37ec8cd0adc8219466555b200bd3b9af8b
  - Document the new UnitTest service of the ScriptForge library

This patch also updates the sbasic.tree to include the Region and 
UnitTest services. I also moved the ScriptForge library so that it appears 
right below the Advanced Basic Libraries (previously it was inside this 
section).

Change-Id: I7dfd9080dcd3212d2b53f88480087d48f5dec60c
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136548
Tested-by: Jenkins
Reviewed-by: Alain Romedenne 

diff --git a/helpcontent2 b/helpcontent2
index 3569af3cc1cf..d6e98a37ec8c 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 3569af3cc1cffcf14ff13273f422b99d652b9c39
+Subproject commit d6e98a37ec8cd0adc8219466555b200bd3b9af8b

[Libreoffice-commits] help.git: AllLangHelp_sbasic.mk source/auxiliary source/text

[Rafael Lima (via logerrit)]

 AllLangHelp_sbasic.mk|1 
 source/auxiliary/sbasic.tree |   10 
 source/text/sbasic/shared/03/lib_ScriptForge.xhp |6 
 source/text/sbasic/shared/03/sf_unittest.xhp |  818 +++
 4 files changed, 830 insertions(+), 5 deletions(-)

New commits:
commit d6e98a37ec8cd0adc8219466555b200bd3b9af8b
Author: Rafael Lima 
AuthorDate: Wed Jun 29 00:02:34 2022 +0200
Commit: Jean-Pierre Ledure 
CommitDate: Fri Jul 1 16:41:25 2022 +0200

Document the new UnitTest service of the ScriptForge library

This patch also updates the sbasic.tree to include the Region and UnitTest 
services. I also moved the ScriptForge library so that it appears right below 
the Advanced Basic Libraries (previously it was inside this section).

Change-Id: I7dfd9080dcd3212d2b53f88480087d48f5dec60c
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136548
Tested-by: Jenkins
Reviewed-by: Alain Romedenne 

diff --git a/AllLangHelp_sbasic.mk b/AllLangHelp_sbasic.mk
index 4114c5a6f..bf6eb4872 100644
--- a/AllLangHelp_sbasic.mk
+++ b/AllLangHelp_sbasic.mk
@@ -107,6 +107,7 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,sbasic,\
 helpcontent2/source/text/sbasic/shared/03/sf_textstream \
 helpcontent2/source/text/sbasic/shared/03/sf_timer \
 helpcontent2/source/text/sbasic/shared/03/sf_ui \
+helpcontent2/source/text/sbasic/shared/03/sf_unittest \
 helpcontent2/source/text/sbasic/shared/03/sf_writer \
 helpcontent2/source/text/sbasic/shared/03/lib_schedule \
 helpcontent2/source/text/sbasic/shared/03/lib_template \
diff --git a/source/auxiliary/sbasic.tree b/source/auxiliary/sbasic.tree
index 3cffcd46f..a79802e22 100644
--- a/source/auxiliary/sbasic.tree
+++ b/source/auxiliary/sbasic.tree
@@ -339,7 +339,10 @@
   ImportWizard Library
   Schedule 
Library
   ScriptBindingLibrary 
Library
-  
+  Template 
Library
+  WikiEditor Library
+
+
 Overview of the 
ScriptForge Library
 Creating 
Python Scripts with ScriptForge
 ScriptForge method 
signatures
@@ -361,17 +364,16 @@
 Menu 
service
 Platform 
service
 PopupMenu service
+Region 
service
 Services 
service
 Session 
service
 String 
service
 TextStream service
 Timer 
service
 UI 
service
+UnitTest 
service
 Writer 
service
   
-  Template 
Library
-  WikiEditor Library
-
   
   
 Recording a 
Macro
diff --git a/source/text/sbasic/shared/03/lib_ScriptForge.xhp 
b/source/text/sbasic/shared/03/lib_ScriptForge.xhp
index 35190c42d..946280ba4 100644
--- a/source/text/sbasic/shared/03/lib_ScriptForge.xhp
+++ b/source/text/sbasic/shared/03/lib_ScriptForge.xhp
@@ -146,12 +146,13 @@
  
Region
Services
+   Session
  


  
-   Session
Timer
+   UnitTest
  

 
@@ -231,6 +232,9 @@
 
   
 
+
+  
+
 
   
 
diff --git a/source/text/sbasic/shared/03/sf_unittest.xhp 
b/source/text/sbasic/shared/03/sf_unittest.xhp
new file mode 100644
index 0..80ce5c834
--- /dev/null
+++ b/source/text/sbasic/shared/03/sf_unittest.xhp
@@ -0,0 +1,818 @@
+
+
+
+
+  
+SFUnitTests.UnitTest service
+/text/sbasic/shared/03/sf_unittest.xhp
+  
+  
+
+
+  
+UnitTest service
+  
+
+
+  SFUnitTests.UnitTest 
service
+  The 
UnitTest service provides a framework for automating unit 
tests using the Basic language, including the ability to:
+  
+
+  Aggregate test 
cases into test suites and unit tests.
+
+
+  Share setup and 
shutdown code among test cases.
+
+
+  Report test results 
using the Console.
+
+  
+
+  Both the unit tests and the code to be 
tested must be written in Basic. The code being tested may call functions 
written in other languages.
+  The UnitTest service 
is not available for Python scripts.
+
+  Definitions
+  Test Case
+  A test case is the 
individual unit of testing. It checks for a specific response to a particular 
set of inputs.
+  In the 
UnitTest service, a test case is represented by a single 
Basic Sub whose name starts with a common prefix (the 
default is "Test_").
+  The test case fails 
if one of the AssertX methods returns 
False.
+  Test Suite
+  A test suite is a 
collection of test cases that should be executed together.
+  All test cases of a 
test suite are stored in a single Basic module.
+  A test suite may 
implement the SetUp and TearDown methods 
to prepare for test cases in its module.
+  Unit Test
+  A full unit test 
consists of a set of test suites in the same Basic library.
+
+  Service invocation
+  Before using the 
UnitTest service the ScriptForge library 

[Libreoffice-bugs] [Bug 149808] New: EDITING: Right-Click Inoperative

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149808

Bug ID: 149808
   Summary: EDITING: Right-Click Inoperative
   Product: LibreOffice
   Version: 7.4.0.0 beta1+
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: restrepo.seat...@gmail.com

Description:
When selecting a cell (in calc) or a word or words (in writer), the mouse's
Right-Click is inoperative.

Steps to Reproduce:
1.Select a cell or word
2. Right-Click... 
3.

Actual Results:
None

Expected Results:
Menu to format the cell or word


Reproducible: Always


User Profile Reset: No



Additional Info:
-

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - translations

[Christian Lohmaier (via logerrit)]

 translations |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit fb294b87ae95579189895738f0faf62357e6be46
Author: Christian Lohmaier 
AuthorDate: Fri Jul 1 16:32:00 2022 +0200
Commit: Gerrit Code Review 
CommitDate: Fri Jul 1 16:32:00 2022 +0200

Update git submodules

* Update translations from branch 'libreoffice-7-3'
  to e46d7675a9759e2bc9fcc6895e14095abb3eba83
  - update translations for 7.3.5 rc1

and force-fix errors using pocheck

Change-Id: I6b8f0f326c1ef1f3804409057e3081bf2b2caaa0

diff --git a/translations b/translations
index 55ec674bc949..e46d7675a975 16
--- a/translations
+++ b/translations
@@ -1 +1 @@
-Subproject commit 55ec674bc94926ed4707f51bc1be121fd351
+Subproject commit e46d7675a9759e2bc9fcc6895e14095abb3eba83

[Libreoffice-commits] core.git: helpcontent2

[Seth Chaiklin (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c2775bbab1885ce6980021153267e97d8ca89682
Author: Seth Chaiklin 
AuthorDate: Fri Jul 1 16:12:09 2022 +0200
Commit: Gerrit Code Review 
CommitDate: Fri Jul 1 16:12:09 2022 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to 3569af3cc1cffcf14ff13273f422b99d652b9c39
  - tdf#120550,tdf#121367 followup to add or correct links

Change-Id: Iee88c2927b5750d57dec1cfffee4d27bf860b834
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136645
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 6e77989ceace..3569af3cc1cf 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 6e77989ceace3a02684d5af35ed9f89712cc524d
+Subproject commit 3569af3cc1cffcf14ff13273f422b99d652b9c39

[Libreoffice-commits] help.git: source/text

[Seth Chaiklin (via logerrit)]

 source/text/shared/02/0421.xhp  |3 +--
 source/text/swriter/01/05110100.xhp |2 +-
 source/text/swriter/01/05110200.xhp |2 +-
 source/text/swriter/01/05120200.xhp |2 +-
 source/text/swriter/main0110.xhp|4 ++--
 5 files changed, 6 insertions(+), 7 deletions(-)

New commits:
commit 3569af3cc1cffcf14ff13273f422b99d652b9c39
Author: Seth Chaiklin 
AuthorDate: Thu Jun 30 00:05:52 2022 +0200
Commit: Olivier Hallot 
CommitDate: Fri Jul 1 16:12:08 2022 +0200

tdf#120550,tdf#121367 followup to add or correct links

Change-Id: Iee88c2927b5750d57dec1cfffee4d27bf860b834
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136645
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/shared/02/0421.xhp 
b/source/text/shared/02/0421.xhp
index e7b030f1c..aeff823d0 100644
--- a/source/text/shared/02/0421.xhp
+++ b/source/text/shared/02/0421.xhp
@@ -44,8 +44,7 @@
 
 You can select 
from the following functions:
 
-
-
+
 
 
 
diff --git a/source/text/swriter/01/05110100.xhp 
b/source/text/swriter/01/05110100.xhp
index 389e6f4dc..ee35416ca 100644
--- a/source/text/swriter/01/05110100.xhp
+++ b/source/text/swriter/01/05110100.xhp
@@ -43,6 +43,6 @@
 
 Fit to size
 Automatically adjusts the row height to 
match the contents of the cells.
-You can also right-click in a cell, and then choose 
Row 
- Optimal Height.
+You can also right-click in a cell, and then choose 
Size - Minimal Row Height.
 
 
diff --git a/source/text/swriter/01/05110200.xhp 
b/source/text/swriter/01/05110200.xhp
index ac239d03d..32c9d91e2 100644
--- a/source/text/swriter/01/05110200.xhp
+++ b/source/text/swriter/01/05110200.xhp
@@ -30,7 +30,7 @@
 
 
 
-Optimal Row Height
+Optimal Row Height
   Set row height for selected table rows so that each row 
has the same height as the row with the tallest 
content.
 
 
diff --git a/source/text/swriter/01/05120200.xhp 
b/source/text/swriter/01/05120200.xhp
index daec3f54e..77c9ab47e 100644
--- a/source/text/swriter/01/05120200.xhp
+++ b/source/text/swriter/01/05120200.xhp
@@ -29,7 +29,7 @@
 
 
 
-Optimal Column Width
+  Optimal Column Width
 
   
 Adjust column 
widths among columns with selected cells, according to the paragraph length in 
each selected cell. Widen the table, up to page width, if 
necessary.
diff --git a/source/text/swriter/main0110.xhp b/source/text/swriter/main0110.xhp
index 3f88965c9..620c1a120 100644
--- a/source/text/swriter/main0110.xhp
+++ b/source/text/swriter/main0110.xhp
@@ -88,7 +88,7 @@
 Row Height
 Opens the Row 
Height dialog where you can change the height of a row.
 
-Minimal Row Height
+Minimal 
Row Height
 
 
 Optimal Row Height
@@ -100,7 +100,7 @@
 Column Width
 Opens the 
Column Width dialog where you can change the width of a column.
 
-Minimal Column Width
+Minimal Column Width
 
 
 Optimal Column Width

[Libreoffice-bugs] [Bug 113488] Better support for Assistive Technology tools by exposing descriptive tooltips text with keyboard navigation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113488

Michael Weghorn  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #1 from Michael Weghorn  ---
(In reply to V Stuart Foote from comment #0)
> A rework of label structure for menus, context menus and toolbar button
> labels is being looked at for bug 108458. Perhaps in  conjunction with that,
> some structural change to facilitate use of tooltip/extended tooltips with
> keyboard navigation might be implemented.

I came across tdf#108458 in the context of
https://gerrit.libreoffice.org/c/core/+/136722 (v1), which then brought me here
again.

I don't really understand what the exact intention/request here is:

Is it to have the tooltips read out by default by screen readers when focusing
an item using the keyboard, e.g. by having them in the accessible name (or
accessible description)?

If so: At least Orca and NVDA have an option in their settings to announce
tooltips also, so I'm wondering whether it shouldn't be dependent on that
option whether or not tooltips are announced.

Since, IIUC, tooltips can contain rather long help texts, I tend to think that
not all users would want to have them announced every time (in particular when
experienced with the functionality currently being used), but a short label
might be enough then?
(And it would hopefully be possible to press some keyboard shortcut to have the
screen reader announce the tooltip on demand, but I don't know whether that's
currently implemented in the screen readers. Or is it, but LO doesn't provide
the information when the UI element has been accessed using the keyboard, as
opposed to when mouse-hovering over them?)


@Stuart: Could you possibly clarify a bit further what the request in this
ticket is (maybe also giving an example scenario of how that would be used)?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sw/source

[Miklos Vajna (via logerrit)]

 sw/source/core/crsr/contentcontrolbutton.cxx |   39 +++
 1 file changed, 23 insertions(+), 16 deletions(-)

New commits:
commit ce92c9a5fa3c9b72ddae7543dea0b93a1efe3292
Author: Miklos Vajna 
AuthorDate: Fri Jul 1 09:02:27 2022 +0200
Commit: Miklos Vajna 
CommitDate: Fri Jul 1 15:46:13 2022 +0200

sw content controls, dropdown: use DecorationView for the button's arrow

Instead of drawing manually, which was the way form field dropdowns did
it. Also enable anti-aliasing.

Change-Id: Ia1ab5fe6168e0fb51dba3c760301764cfd1e0514
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136692
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins
(cherry picked from commit 48010539f695bc269034f12cf72aa0665cca10de)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136706

diff --git a/sw/source/core/crsr/contentcontrolbutton.cxx 
b/sw/source/core/crsr/contentcontrolbutton.cxx
index 00deb260981c..34cbd38e663a 100644
--- a/sw/source/core/crsr/contentcontrolbutton.cxx
+++ b/sw/source/core/crsr/contentcontrolbutton.cxx
@@ -11,8 +11,10 @@
 
 #include 
 #include 
+#include 
 
 #include 
+#include 
 
 SwContentControlButton::SwContentControlButton(
 SwEditWin* pEditWin, const std::shared_ptr& 
pContentControl)
@@ -107,7 +109,7 @@ void SwContentControlButton::Paint(vcl::RenderContext& 
rRenderContext, const too
 
 // Draw the button next to the frame
 Point aButtonPos(aFrameRect.TopLeft());
-aButtonPos.AdjustX(aFrameRect.GetSize().getWidth() - 1);
+aButtonPos.AdjustX(aFrameRect.GetSize().getWidth() - nPadding * 2);
 Size aButtonSize(aFrameRect.GetSize());
 aButtonSize.setWidth(GetSizePixel().getWidth() - aFrameRect.getWidth() - 
nPadding);
 const tools::Rectangle aButtonRect(tools::Rectangle(aButtonPos, 
aButtonSize));
@@ -118,21 +120,26 @@ void SwContentControlButton::Paint(vcl::RenderContext& 
rRenderContext, const too
 rRenderContext.DrawRect(aButtonRect);
 
 // the arrowhead
-rRenderContext.SetLineColor(aLineColor);
-rRenderContext.SetFillColor(aLineColor);
-
-Point aCenter(aButtonPos.X() + (aButtonSize.Width() / 2),
-  aButtonPos.Y() + (aButtonSize.Height() / 2));
-tools::Long nMinWidth = 4;
-tools::Long nMinHeight = 2;
-Size aArrowSize(std::max(aButtonSize.Width() / 4, nMinWidth),
-std::max(aButtonSize.Height() / 10, nMinHeight));
-
-tools::Polygon aPoly(3);
-aPoly.SetPoint(Point(aCenter.X() - aArrowSize.Width(), aCenter.Y() - 
aArrowSize.Height()), 0);
-aPoly.SetPoint(Point(aCenter.X() + aArrowSize.Width(), aCenter.Y() - 
aArrowSize.Height()), 1);
-aPoly.SetPoint(Point(aCenter.X(), aCenter.Y() + aArrowSize.Height()), 2);
-rRenderContext.DrawPolygon(aPoly);
+DecorationView aDecoView();
+tools::Rectangle aSymbolRect(aButtonRect);
+// 20% distance to the left and right button border
+const tools::Long nBorderDistanceLeftAndRight = aSymbolRect.GetWidth() / 4;
+aSymbolRect.AdjustLeft(nBorderDistanceLeftAndRight);
+aSymbolRect.AdjustRight(-nBorderDistanceLeftAndRight);
+// 20% distance to the top and bottom button border
+const tools::Long nBorderDistanceTopAndBottom = aSymbolRect.GetHeight() / 
4;
+aSymbolRect.AdjustTop(nBorderDistanceTopAndBottom);
+aSymbolRect.AdjustBottom(-nBorderDistanceTopAndBottom);
+AntialiasingFlags eAntialiasing = rRenderContext.GetAntialiasing();
+if (SwDrawView::IsAntiAliasing())
+{
+rRenderContext.SetAntialiasing(eAntialiasing | 
AntialiasingFlags::Enable);
+}
+aDecoView.DrawSymbol(aSymbolRect, SymbolType::SPIN_DOWN, GetTextColor(), 
DrawSymbolFlags::NONE);
+if (SwDrawView::IsAntiAliasing())
+{
+rRenderContext.SetAntialiasing(eAntialiasing);
+}
 }
 
 WindowHitTest SwContentControlButton::ImplHitTest(const Point& rFramePos)

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sw/sdi

[Miklos Vajna (via logerrit)]

 sw/sdi/_grfsh.sdi |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 4206a258510f25dbd07fb654033cf775aedd43ea
Author: Miklos Vajna 
AuthorDate: Fri Jul 1 11:40:10 2022 +0200
Commit: Miklos Vajna 
CommitDate: Fri Jul 1 15:44:48 2022 +0200

sw content controls: fix picture placeholders

This went wrong in commit c321498f915f4e8b3f4853232860ce040ab48e46 (sw
content controls: reject typing inside checkbox or picture content
controls, 2022-06-10), now a freshly inserted picture content control is
not replaced with an image on click.

The problem is that we want to forbid typing into a picture content
control (it should only host a single as-char image), but changing the
picture's bitmap is meant to be still possible.

Fix the problem by allowing SID_CHANGE_PICTURE even if the cursor is
protected: this allows changing the picture again, and a real read-only
document still doesn't show the "change" menu item in its context menu.

If we later find some other corner-case where this command should be
still disabled, we can extend SwGrfShell::GetAttrState(), similar to how
e.g. inserting images in input fields is disabled there.

Change-Id: I8b55e930330b9748ecda950dedae907b86c57e2f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136729
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins
(cherry picked from commit c769c369c87a46ec877b7eefee27988044a2798f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136711

diff --git a/sw/sdi/_grfsh.sdi b/sw/sdi/_grfsh.sdi
index 8291745966bb..5475017d448e 100644
--- a/sw/sdi/_grfsh.sdi
+++ b/sw/sdi/_grfsh.sdi
@@ -63,7 +63,6 @@ interface BaseTextGraphic
 [
 ExecMethod = Execute ;
 StateMethod = GetAttrState ;
-DisableFlags="SfxDisableFlags::SwOnProtectedCursor";
 ]
 
 SID_EXTERNAL_EDIT

[Libreoffice-bugs] [Bug 108497] Convert OpenType variable font (OTVF) instances before printing and exporting to PDF or EPUB

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108497

V Stuart Foote  changed:

   What|Removed |Added

Summary|Converting OpenType Font|Convert OpenType variable
   |Variation instances before  |font (OTVF) instances
   |printing and exporting to   |before printing and
   |PDF or EPUB |exporting to PDF or EPUB

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103596] Support OpenType variable font (OTVF) based text layout

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103596

V Stuart Foote  changed:

   What|Removed |Added

Summary|Support OpenType Font   |Support OpenType variable
   |Variation based text layout |font (OTVF) based text
   ||layout

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103596] Support OpenType Font Variation based text layout

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103596

V Stuart Foote  changed:

   What|Removed |Added

 CC||finleyturnerhall@protonmail
   ||.com

--- Comment #27 from V Stuart Foote  ---
*** Bug 146355 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146355] Text in the Cantarell font will not appear when converting to a PDF

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146355

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #2 from V Stuart Foote  ---
lack of support for OpenType variable fonts, moving dupe to the enhancement

*** This bug has been marked as a duplicate of bug 103596 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103596] Support OpenType Font Variation based text layout

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103596

V Stuart Foote  changed:

   What|Removed |Added

 CC||wouter.joris@intersoft-elec
   ||tronics.com

--- Comment #26 from V Stuart Foote  ---
*** Bug 145306 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145306] Libreoffice writer does not include text while exporting to PDF.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145306

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #4 from V Stuart Foote  ---
lack of support for OpenType variable fonts, moving dupe to the enhancement

*** This bug has been marked as a duplicate of bug 103596 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71732
Bug 71732 depends on bug 130149, which changed state.

Bug 130149 Summary: Text using the Cantarell variable font is not printed or 
PDF exported in some Linux (comment 8 and comment 26)
https://bugs.documentfoundation.org/show_bug.cgi?id=130149

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103596] Support OpenType Font Variation based text layout

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103596

V Stuart Foote  changed:

   What|Removed |Added

 CC||pgkos.bugzi...@yahoo.com

--- Comment #25 from V Stuart Foote  ---
*** Bug 130149 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 130149] Text using the Cantarell variable font is not printed or PDF exported in some Linux (comment 8 and comment 26)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130149

V Stuart Foote  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #29 from V Stuart Foote  ---


*** This bug has been marked as a duplicate of bug 103596 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 130149] Text using the Cantarell variable font is not printed or PDF exported in some Linux (comment 8 and comment 26)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130149

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #28 from V Stuart Foote  ---
(In reply to Timur from comment #27)
> I retested this in new Ubuntu 22.04 Wayland. Cantarell wasn't installed so I
> installed manually. Bug wasn't reproduced. 
> Repro in openSUSE Tumbleweed.
> I amend the title. It's not about any Cantarell, but variable font.

making this pretty clearly another duplicate of bug 103596 enhancement to
support use of OpenType variable fonts (OTVF).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 137544] Opening complex electric PDF drawing is very slow with high CPU in Linux

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137544

--- Comment #13 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/779489ca5ad11476b39555d7b3169d320ff89d4b

tdf#137544 reserve space in polygon

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: 2 commits - basegfx/source sw/qa writerfilter/source

[Justin Luth (via logerrit)]

 basegfx/source/polygon/b2dpolygontools.cxx   |2 ++
 sw/qa/extras/ooxmlexport/data/table-ltr.docx |binary
 sw/qa/extras/ooxmlexport/ooxmlexport.cxx |9 +
 writerfilter/source/dmapper/DomainMapperTableHandler.cxx |4 
 4 files changed, 15 insertions(+)

New commits:
commit ed7a788dd916bd8786adb2d146ce543a727ce727
Author: Justin Luth 
AuthorDate: Thu Jun 30 06:43:46 2022 -0400
Commit: Justin Luth 
CommitDate: Fri Jul 1 15:32:39 2022 +0200

tdf#126395 writerfilter: don't guess table direction

Wihtout specifying a direction, TextToTable is going
to guess. Well, import isn't a guessing game,
and there is a default value for something unspecified.

Perhaps specifying LR_TB would be better,
but we'll try with CONTEXT first,
since it is a LO default.

Existing unit tests (not affected)
Both ooxmlexport and rtfexport have a table-rtf test
which ensure bidiVisual is properly applied to tables.

Change-Id: I1cabf518937e57dd757aca75ae5d2527c61fa736
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136673
Tested-by: Jenkins
Reviewed-by: Justin Luth 

diff --git a/sw/qa/extras/ooxmlexport/data/table-ltr.docx 
b/sw/qa/extras/ooxmlexport/data/table-ltr.docx
new file mode 100644
index ..d627b81a312b
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/table-ltr.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
index 5cd096e737f5..c10290269305 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
@@ -718,6 +718,15 @@ DECLARE_OOXMLEXPORT_TEST(testTableRtl, "table-rtl.docx")
 CPPUNIT_ASSERT_EQUAL(text::WritingMode2::RL_TB, 
getProperty(xTable, "WritingMode"));
 }
 
+DECLARE_OOXMLEXPORT_TEST(testTableLr, "table-ltr.docx")
+{
+uno::Reference xTablesSupplier(mxComponent, 
uno::UNO_QUERY);
+uno::Reference 
xTables(xTablesSupplier->getTextTables(), uno::UNO_QUERY);
+uno::Reference xTable(xTables->getByIndex(0), 
uno::UNO_QUERY);
+// This was text::WritingMode2::RL_TB, i.e. direction of the table was 
wrongly guessed.
+CPPUNIT_ASSERT_EQUAL(text::WritingMode2::CONTEXT, 
getProperty(xTable, "WritingMode"));
+}
+
 DECLARE_OOXMLEXPORT_TEST(testOoxmlCjklist30, "cjklist30.docx")
 {
 sal_Int16   numFormat = getNumberingTypeOfParagraph(1);
diff --git a/writerfilter/source/dmapper/DomainMapperTableHandler.cxx 
b/writerfilter/source/dmapper/DomainMapperTableHandler.cxx
index d0c42576202e..774cba78c3a1 100644
--- a/writerfilter/source/dmapper/DomainMapperTableHandler.cxx
+++ b/writerfilter/source/dmapper/DomainMapperTableHandler.cxx
@@ -33,6 +33,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -666,6 +667,9 @@ TableStyleSheetEntry * 
DomainMapperTableHandler::endTableGetTableStyle(TableInfo
 m_aTableProperties->Insert( PROP_HORI_ORIENT, uno::Any( 
sal_Int16(nHoriOrient) ) );
 //fill default value - if not available
 m_aTableProperties->Insert( PROP_HEADER_ROW_COUNT, uno::Any( 
sal_Int32(0)), false);
+m_aTableProperties->Insert(PROP_WRITING_MODE,
+   
uno::Any(sal_Int16(text::WritingMode2::CONTEXT)),
+   /*bOverWrite=*/false);
 
 // if table is only a single row, and row is set as don't split, set 
the same value for the whole table.
 if( m_aRowProperties.size() == 1 && m_aRowProperties[0] )
commit 779489ca5ad11476b39555d7b3169d320ff89d4b
Author: Noel Grandin 
AuthorDate: Fri Jul 1 09:48:38 2022 +0200
Commit: Noel Grandin 
CommitDate: Fri Jul 1 15:32:30 2022 +0200

tdf#137544 reserve space in polygon

Change-Id: I868584965b122735b8eb55cc17a3ee11a772b88a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136721
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/basegfx/source/polygon/b2dpolygontools.cxx 
b/basegfx/source/polygon/b2dpolygontools.cxx
index c6eb3cf5b28b..4b8550546e5c 100644
--- a/basegfx/source/polygon/b2dpolygontools.cxx
+++ b/basegfx/source/polygon/b2dpolygontools.cxx
@@ -3330,6 +3330,8 @@ namespace basegfx::utils
 
 if(0 != nCount)
 {
+aRetval.reserve(nCount);
+
 const css::awt::Point* pPointSequence = 
rPointSequenceSource.getConstArray();
 const css::drawing::PolygonFlags* pFlagSequence = 
rFlagSequenceSource.getConstArray();
 

[Libreoffice-commits] core.git: schema/libreoffice

[Miklos Vajna (via logerrit)]

 schema/libreoffice/OpenDocument-v1.3+libreoffice-schema.rng |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3f379f00b17268fbb63ba072d04336acb0c7e398
Author: Miklos Vajna 
AuthorDate: Fri Jul 1 13:36:05 2022 +0200
Commit: Miklos Vajna 
CommitDate: Fri Jul 1 15:30:21 2022 +0200

sw content controls: link ODF proposal

Change-Id: I18a62cce01eb8a5cc1764ee813a9265cb02c5fdf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136736
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/schema/libreoffice/OpenDocument-v1.3+libreoffice-schema.rng 
b/schema/libreoffice/OpenDocument-v1.3+libreoffice-schema.rng
index 9d84b4ee2343..fcf6bfaab353 100644
--- a/schema/libreoffice/OpenDocument-v1.3+libreoffice-schema.rng
+++ b/schema/libreoffice/OpenDocument-v1.3+libreoffice-schema.rng
@@ -2852,7 +2852,7 @@ 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.
 
   
 
-  
+