[Libreoffice-commits] core.git: 2 commits - starmath/source sw/source toolkit/source
starmath/source/ElementsDockingWindow.cxx |1 -
sw/source/ui/vba/vbaapplication.cxx |4 ++--
toolkit/source/controls/svtxgridcontrol.cxx |1 -
3 files changed, 2 insertions(+), 4 deletions(-)
New commits:
commit b8b9ad9ade866175d8d7f1b68a465060901efee9
Author: Andrea Gelmini
AuthorDate: Sat Aug 6 22:54:04 2022 +0200
Commit: Julien Nabet
CommitDate: Sun Aug 7 07:27:12 2022 +0200
Removed duplicated includes
Change-Id: Ic981e0916c68181cab7081091303d18c54912377
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137912
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/starmath/source/ElementsDockingWindow.cxx
b/starmath/source/ElementsDockingWindow.cxx
index 5d7b51de58a6..202396dfc282 100644
--- a/starmath/source/ElementsDockingWindow.cxx
+++ b/starmath/source/ElementsDockingWindow.cxx
@@ -40,7 +40,6 @@
#include
#include
-#include
namespace
{
diff --git a/toolkit/source/controls/svtxgridcontrol.cxx
b/toolkit/source/controls/svtxgridcontrol.cxx
index 1fd7de1f29b1..4911130b9852 100644
--- a/toolkit/source/controls/svtxgridcontrol.cxx
+++ b/toolkit/source/controls/svtxgridcontrol.cxx
@@ -24,7 +24,6 @@
#include
#include
#include
-#include
#include "unocontroltablemodel.hxx"
#include
#include
commit 30759b5ce2ef4f915a6f4ba50ce25b602162805c
Author: Hannah Meeks
AuthorDate: Fri Aug 5 12:00:25 2022 +0100
Commit: Mike Kaganski
CommitDate: Sun Aug 7 07:26:56 2022 +0200
VBA conversions inches should be in
Change-Id: I130925d9501f8cb4f3f2a8a0894bbf6824cd2eff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137856
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sw/source/ui/vba/vbaapplication.cxx
b/sw/source/ui/vba/vbaapplication.cxx
index c95c855c01fd..1a25116448ea 100644
--- a/sw/source/ui/vba/vbaapplication.cxx
+++ b/sw/source/ui/vba/vbaapplication.cxx
@@ -448,12 +448,12 @@ float SAL_CALL SwVbaApplication::PointsToPixels( float
Pixels, ::sal_Bool fVerti
float SAL_CALL SwVbaApplication::InchesToPoints( float Inches )
{
-return o3tl::convert(Inches, o3tl::Length::ch, o3tl::Length::pt);
+return o3tl::convert(Inches, o3tl::Length::in, o3tl::Length::pt);
}
float SAL_CALL SwVbaApplication::PointsToInches( float Points )
{
-return o3tl::convert(Points, o3tl::Length::pt, o3tl::Length::ch);
+return o3tl::convert(Points, o3tl::Length::pt, o3tl::Length::in);
}
float SAL_CALL SwVbaApplication::MillimetersToPoints( float Millimeters )
[Libreoffice-bugs] [Bug 150117] the restoration option of the safe mode doesn't work
https://bugs.documentfoundation.org/show_bug.cgi?id=150117 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150109] No Image Selection or functionality on a partially protected workbook
https://bugs.documentfoundation.org/show_bug.cgi?id=150109 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150288] Aug. 1st becomes Jan. 8th when using DD/MM/YYYY date format
https://bugs.documentfoundation.org/show_bug.cgi?id=150288 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150288] Aug. 1st becomes Jan. 8th when using DD/MM/YYYY date format
https://bugs.documentfoundation.org/show_bug.cgi?id=150288 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150277] .ods file causes crash in libreoffice-fresh (QT backend?)
https://bugs.documentfoundation.org/show_bug.cgi?id=150277 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150158] LibreOffice Writer 7.4rc1 freezes when I continue working after a break
https://bugs.documentfoundation.org/show_bug.cgi?id=150158 --- Comment #6 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150277] .ods file causes crash in libreoffice-fresh (QT backend?)
https://bugs.documentfoundation.org/show_bug.cgi?id=150277 --- Comment #9 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150158] LibreOffice Writer 7.4rc1 freezes when I continue working after a break
https://bugs.documentfoundation.org/show_bug.cgi?id=150158 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146624] "Find" doesn't work reliably in LO Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=146624 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146624] "Find" doesn't work reliably in LO Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=146624 --- Comment #3 from QA Administrators --- Dear David, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140494] Typing lag--Input lags very far behind keystrokes
https://bugs.documentfoundation.org/show_bug.cgi?id=140494 --- Comment #4 from QA Administrators --- Dear Tony Castelletto, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139846] Find and Find/Replace does not find all valid matches
https://bugs.documentfoundation.org/show_bug.cgi?id=139846 --- Comment #3 from QA Administrators --- Dear lillis_mark, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137883] Confusing terminology for DOCX save (Transitional versus Word 2007-365)
https://bugs.documentfoundation.org/show_bug.cgi?id=137883 --- Comment #5 from QA Administrators --- Dear Telesto, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138442] OpenSymbol font positioned incorrectly in tables in writer when no other fonts are used in the cell
https://bugs.documentfoundation.org/show_bug.cgi?id=138442 --- Comment #10 from QA Administrators --- Dear Mikhail Novosyolov, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149925] Changes color of text in Excel files from "Red" to "Orange".
https://bugs.documentfoundation.org/show_bug.cgi?id=149925 --- Comment #4 from mindunde...@gmail.com --- Version 7.3.4.2 still has the same error. An Excel file originally with Red Text will open with all Orange Text in Libre Office. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 117173] Search Dialog does not provide search results to Assistive Technology tools at 5.2 and later, results are recorded to GUI without accessible event as text in SetSearchL
https://bugs.documentfoundation.org/show_bug.cgi?id=117173 Jim Raykowski changed: What|Removed |Added CC||rayk...@gmail.com --- Comment #16 from Jim Raykowski --- Created attachment 181648 --> https://bugs.documentfoundation.org/attachment.cgi?id=181648=edit accessiblity information message dialog option Request for comments on an accessibility option to show information dialogs for screen reader use. https://gerrit.libreoffice.org/c/core/+/137914 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 126008] TABLES STYLES: If you insert a row or column (with cursor in a cell), the formatting of the whole table changes (steps in comment 5)
https://bugs.documentfoundation.org/show_bug.cgi?id=126008 Matt K changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |matt...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150291] Macro-collection-management crashes when no macro-container is selected
https://bugs.documentfoundation.org/show_bug.cgi?id=150291 --- Comment #1 from mikegebi...@gmail.com --- Created attachment 181647 --> https://bugs.documentfoundation.org/attachment.cgi?id=181647=edit Clicking "Verwalten…" here will crash LibreOffice -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150291] New: Macro-collection-management crashes when no macro-container is selected
https://bugs.documentfoundation.org/show_bug.cgi?id=150291
Bug ID: 150291
Summary: Macro-collection-management crashes when no
macro-container is selected
Product: LibreOffice
Version: 7.3.5.2 release
Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
Severity: minor
Priority: medium
Component: BASIC
Assignee: libreoffice-bugs@lists.freedesktop.org
Reporter: mikegebi...@gmail.com
Description:
Crash when I open the "BASIC-Makros" window and click the "Verwalten…"
(probably "Manage…") button.
Workaround: Just make sure you select something before clicking "Verwalten…".
Steps to Reproduce:
(The names are slightly off because I use the German locale. I'll add the
German names in parentheses.)
1. Open a new LibreOffice Calc workbook.
2. Go to the menu entry "Extras" > "Macros" > "Edit Macros…" ("Makros
bearbeiten…")
3. In the new window "My Macros and Dialogs", go to the menu entry "Extras" >
"Manage Macros" ("Makros verwalten") > "Basic…"
4. In the new window "BASIC Macros", click the button "Manage…" ("Verwalten…"),
without selecting anything first.
The screenshot was made just before the final button click.
Actual Results:
LibreOffice immediately and always crashes.
Expected Results:
LibreOffice should not crash. I don't yet understand how this dialog is
supposed to work, but maybe that button was supposed to be disabled?
Reproducible: Always
User Profile Reset: No
Additional Info:
[Information automatically included from LibreOffice]
Locale: de
Module: BasicIDE
[Information guessed from browser]
OS: Linux (All)
OS is 64bit: yes
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150215] CONFIGURATION (possibility of allowing multiple sheets/tabs)
https://bugs.documentfoundation.org/show_bug.cgi?id=150215 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #3 from Regina Henschel --- If you do not want to split the document into smaller parts but only work on different parts of the same document at the same time, then use the option "New Window" in menu "Window". -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150290] New: Connector handles do not work!
https://bugs.documentfoundation.org/show_bug.cgi?id=150290 Bug ID: 150290 Summary: Connector handles do not work! Product: LibreOffice Version: 7.2.5.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: chasdan...@gmail.com Created attachment 181646 --> https://bugs.documentfoundation.org/attachment.cgi?id=181646=edit Multiple attempts fail to attach and rearrange simple connectors on drawing.. Connectors do not work effectively anymore in Draw or Impress. I placed an ordinary right-angle connector onto the attached drawing (shown in its original form as a thin blue line). One would think that connectors would work more efficiently than plain line segments for wiring pins on electrical items together -- especially if the user has gone to the trouble of adding well-placed glue points. I guess not! Inevitably the blue handles transform into red square or round handles that are impossible to manage. Why should a right-angle connector suddenly take on an odd-angle bend (as the attachment highlights)?!? And why should the red handles only move in ONE direction, horizontal or vertical (as indicated by white arrow cursors)? The current behavior is frustrating, non-intuitive, and a waste of my time! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150288] Aug. 1st becomes Jan. 8th when using DD/MM/YYYY date format
https://bugs.documentfoundation.org/show_bug.cgi?id=150288 --- Comment #2 from Joao Carvalho --- Created attachment 181645 --> https://bugs.documentfoundation.org/attachment.cgi?id=181645=edit sample file, as requested. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150289] New: German translation of "Select Macro" is wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=150289 Bug ID: 150289 Summary: German translation of "Select Macro" is wrong Product: LibreOffice Version: 7.3.5.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: trivial Priority: medium Component: Localization Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mikegebi...@gmail.com Description: A silly typo in the "Select Macro" menu entry: "Marco" instead of "Macro". Hence, a bit of humor: There are so many Marcos to choose from, please help! https://en.wikipedia.org/wiki/Marco_(given_name) Steps to Reproduce: - Open LibreOffice Calc with a new document, with the UI in the "de-DE" locale - Go to "Extras > Makros > Makros bearbeiten…" to open a LibreOffice Basic window - Click on "Extras" and look at the menu, read the first entry closely Actual Results: The first menu entry says "Marco auswählen…". Carefully read that again, it's easy to miss. It really says "Marco" and not "Macro" (or "Makro"). Expected Results: It should probably say "Makro auswählen…" or something. Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: de Module: SpreadsheetDocument [Information guessed from browser] OS: Linux (All) OS is 64bit: yes -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146842] All pages are empty/white when printing (skia, macOS only)
https://bugs.documentfoundation.org/show_bug.cgi?id=146842 m.a.riosv changed: What|Removed |Added CC||d...@palmieri.fr --- Comment #80 from m.a.riosv --- *** Bug 150283 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150283] print empty pages
https://bugs.documentfoundation.org/show_bug.cgi?id=150283 m.a.riosv changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||miguelangelrv@libreoffice.o ||rg Resolution|--- |DUPLICATE --- Comment #1 from m.a.riosv --- *** This bug has been marked as a duplicate of bug 146842 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150288] Aug. 1st becomes Jan. 8th when using DD/MM/YYYY date format
https://bugs.documentfoundation.org/show_bug.cgi?id=150288 m.a.riosv changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m.a.riosv --- How it is interpreted depends on the language used on default style and non-other has been applied for the cell. Please attach a minimal sample file. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150287] Row height is not preserved from the default style, on insertion of a new sheet, when using custom calc template
https://bugs.documentfoundation.org/show_bug.cgi?id=150287 m.a.riosv changed: What|Removed |Added Resolution|--- |DUPLICATE CC||miguelangelrv@libreoffice.o ||rg Status|UNCONFIRMED |RESOLVED --- Comment #1 from m.a.riosv --- Please if you are not agree, reopen it. *** This bug has been marked as a duplicate of bug 81397 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 81397] FORMATTING: When Default cell style is modified, new sheets do not show correct row height since LO 4.2 change in row height
https://bugs.documentfoundation.org/show_bug.cgi?id=81397 m.a.riosv changed: What|Removed |Added CC||mbayc...@yahoo.com --- Comment #14 from m.a.riosv --- *** Bug 150287 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149989] `LibreOffice Start Center` doesn’t fit on small displays (i.e. 11” and 14”) with screen resolution 1280 x 720 (16:9)
https://bugs.documentfoundation.org/show_bug.cgi?id=149989 Óvári changed: What|Removed |Added Summary|`LibreOffice Start Center` |`LibreOffice Start Center` |doesn’t fit on small|doesn’t fit on small |displays (i.e. 11” and 14”) |displays (i.e. 11” and 14”) ||with screen resolution 1280 ||x 720 (16:9) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149989] `LibreOffice Start Center` doesn’t fit on small displays (i.e. 11” and 14”)
https://bugs.documentfoundation.org/show_bug.cgi?id=149989 Óvári changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #4 from Óvári --- Can this issue's status please be marked as NEW? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149989] `LibreOffice Start Center` doesn’t fit on small displays (i.e. 11” and 14”)
https://bugs.documentfoundation.org/show_bug.cgi?id=149989 --- Comment #3 from Óvári --- Created attachment 181644 --> https://bugs.documentfoundation.org/attachment.cgi?id=181644=edit Panel Height 60 (maximum), less vertical height for LibreOffice Start Centre (In reply to Roman Kuznetsov from comment #2) > What a screen resolution do you have on your display? Display resolution: 1280 x 720 (16:9) The Panel Height is set to the maximum of 60, as shown in the attached image, so there is less vertical height for the LibreOffice Start Centre window. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/filter/ww8/ww8par.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 641d92a73e5b3d0e062e16ed4b42236e1a4796a5 Author: Caolán McNamara AuthorDate: Sat Aug 6 16:39:22 2022 +0100 Commit: Caolán McNamara CommitDate: Sat Aug 6 21:58:49 2022 +0200 ofz#49834 Segv on unknown address regression from commit 96fb8f88bd56c113eb23e50d23a038509703c288 Date: Wed Aug 3 15:47:51 2022 +0200 elide some SwNodeIndex temporaries where the SwPam ctor a ended up getting called instead of b a) SwPaM( const SwNode& rNode, sal_Int32 nContent, SwPaM* pRing ) b) SwPaM( const SwNode& rNd, SwNodeOffset nNdOffset, sal_Int32 nContent = 0, SwPaM* pRing = nullptr ); Change-Id: I44e9f98bcbefa72301dc9a434ce5ebe720870cab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137902 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/sw/source/filter/ww8/ww8par.cxx b/sw/source/filter/ww8/ww8par.cxx index 03f3dfe4bec6..f56e4600f29c 100644 --- a/sw/source/filter/ww8/ww8par.cxx +++ b/sw/source/filter/ww8/ww8par.cxx @@ -6351,7 +6351,7 @@ bool TestImportDOC(SvStream , const OUString ) xDocSh->DoInitNew(); SwDoc *pD = static_cast(())->GetDoc(); -SwPaM aPaM(pD->GetNodes().GetEndOfContent(), -1); +SwPaM aPaM(pD->GetNodes().GetEndOfContent(), SwNodeOffset(-1)); pD->SetInReading(true); bool bRet = xReader->Read(*pD, OUString(), aPaM, OUString()) == ERRCODE_NONE; pD->SetInReading(false);
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/ndarr.hxx |2 +- sw/source/core/doc/DocumentLayoutManager.cxx |4 ++-- sw/source/core/doc/doclay.cxx|6 +++--- sw/source/core/doc/docredln.cxx |4 ++-- sw/source/core/docnode/nodes.cxx |2 +- sw/source/core/txtnode/atrftn.cxx|2 +- sw/source/core/undo/untbl.cxx|2 +- sw/source/filter/html/htmltab.cxx|7 +++ sw/source/filter/ww8/ww8par.cxx |2 +- sw/source/filter/xml/xmltbli.cxx |2 +- 10 files changed, 16 insertions(+), 17 deletions(-) New commits: commit 6a590bfe0427ed91fb20f037783ca0335f67cf6c Author: Noel Grandin AuthorDate: Fri Aug 5 20:34:09 2022 +0200 Commit: Noel Grandin CommitDate: Sat Aug 6 21:31:17 2022 +0200 make MakeTextSection take a SwNode, not an SwNodeIndex as part of the process of hiding the internals of SwPosition Change-Id: Ia64ddd3e1f34c7c160af0134ef5526faf43108e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137895 Tested-by: Noel Grandin Reviewed-by: Noel Grandin diff --git a/sw/inc/ndarr.hxx b/sw/inc/ndarr.hxx index 1b1227549583..cce94857bc3f 100644 --- a/sw/inc/ndarr.hxx +++ b/sw/inc/ndarr.hxx @@ -209,7 +209,7 @@ public: SwTextNode *MakeTextNode( const SwNodeIndex & rWhere, SwTextFormatColl *pColl, bool bNewFrames = true); ///< in ndtxt.cxx -SwStartNode* MakeTextSection( const SwNodeIndex & rWhere, +SwStartNode* MakeTextSection( const SwNode & rWhere, SwStartNodeType eSttNdTyp, SwTextFormatColl *pColl ); diff --git a/sw/source/core/doc/DocumentLayoutManager.cxx b/sw/source/core/doc/DocumentLayoutManager.cxx index 3f49328bf462..2857a9afa17e 100644 --- a/sw/source/core/doc/DocumentLayoutManager.cxx +++ b/sw/source/core/doc/DocumentLayoutManager.cxx @@ -131,10 +131,10 @@ SwFrameFormat *DocumentLayoutManager::MakeLayoutFormat( RndStdIds eRequest, cons (bHeader ? "Right header" : "Right footer"), m_rDoc.GetDfltFrameFormat() ); -SwNodeIndex aTmpIdx( m_rDoc.GetNodes().GetEndOfAutotext() ); +const SwNode& rEndOfAutotext( m_rDoc.GetNodes().GetEndOfAutotext() ); SwStartNode* pSttNd = m_rDoc.GetNodes().MakeTextSection -( aTmpIdx, +( rEndOfAutotext, bHeader ? SwHeaderStartNode : SwFooterStartNode, m_rDoc.getIDocumentStylePoolAccess().GetTextCollFromPool(o3tl::narrowing( bHeader ? ( eRequest == RndStdIds::HEADERL diff --git a/sw/source/core/doc/doclay.cxx b/sw/source/core/doc/doclay.cxx index 2e5285fe9c89..9e545a654660 100644 --- a/sw/source/core/doc/doclay.cxx +++ b/sw/source/core/doc/doclay.cxx @@ -773,7 +773,7 @@ lcl_InsertLabel(SwDoc & rDoc, SwTextFormatColls *const pTextFormatCollTable, pNewSet->Put( std::move(aFrameSize) ); SwStartNode* pSttNd = rDoc.GetNodes().MakeTextSection( -SwNodeIndex( rDoc.GetNodes().GetEndOfAutotext() ), +rDoc.GetNodes().GetEndOfAutotext(), SwFlyStartNode, pColl ); pNewSet->Put( SwFormatContent( pSttNd )); @@ -1087,8 +1087,8 @@ lcl_InsertDrawLabel( SwDoc & rDoc, SwTextFormatColls *const pTextFormatCollTable SwStartNode* pSttNd = rDoc.GetNodes().MakeTextSection( -SwNodeIndex( rDoc.GetNodes().GetEndOfAutotext() ), -SwFlyStartNode, pColl ); +rDoc.GetNodes().GetEndOfAutotext(), +SwFlyStartNode, pColl ); pNewFormat = rDoc.MakeFlyFrameFormat( rDoc.GetUniqueFrameName(), rDoc.getIDocumentStylePoolAccess().GetFrameFormatFromPool( RES_POOLFRM_FRAME ) ); diff --git a/sw/source/core/doc/docredln.cxx b/sw/source/core/doc/docredln.cxx index cead2ecf1cba..f298e67598c4 100644 --- a/sw/source/core/doc/docredln.cxx +++ b/sw/source/core/doc/docredln.cxx @@ -1531,7 +1531,7 @@ void SwRangeRedline::MoveToSection() ? pCEndNd->GetTextNode()->GetTextColl() : rDoc.getIDocumentStylePoolAccess().GetTextCollFromPool(RES_POOLCOLL_STANDARD); -pSttNd = rNds.MakeTextSection( SwNodeIndex( rNds.GetEndOfRedlines() ), +pSttNd = rNds.MakeTextSection( rNds.GetEndOfRedlines(), SwNormalStartNode, pColl ); SwTextNode* pTextNd = rNds[ pSttNd->GetIndex() + 1 ]->GetTextNode(); @@ -1598,7 +1598,7 @@ void SwRangeRedline::CopyToSection() ? pCSttNd->GetTextNode()->GetTextColl() :
[Libreoffice-bugs] [Bug 97693] Problem with SVG fx and fy attributes
https://bugs.documentfoundation.org/show_bug.cgi?id=97693 Gerald Pfeifer changed: What|Removed |Added CC||ger...@pfeifer.com --- Comment #7 from Gerald Pfeifer --- Still confirming with Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: a9d225df2f8772e21435523ca20df1ece37390e4 CPU threads: 8; OS: Linux 5.18; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150164] PDF exporter's "Export outlines as named destinations" does not export outlines, but bookmarks
https://bugs.documentfoundation.org/show_bug.cgi?id=150164 --- Comment #4 from gabriel.cra...@outlook.com --- Created attachment 181643 --> https://bugs.documentfoundation.org/attachment.cgi?id=181643=edit headings_vs_bookmarks -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150164] PDF exporter's "Export outlines as named destinations" does not export outlines, but bookmarks
https://bugs.documentfoundation.org/show_bug.cgi?id=150164 --- Comment #3 from gabriel.cra...@outlook.com --- I’m afraid there’s been a misunderstanding. I have no issues with the outline. I’m talking about named destinations, which are an entirely different thing. Named destinations are what allows your browser to point to a specific section of the PDF, such as in: $ firefox lorem_ipsum.pdf#Sodales2520posuere2520metus2520id I don't think there's a way to view named destinations with Acrobat Reader. In LibreOffice Writer, the exporter option “Export outline as named destinations” generates named destinations from the document's “Bookmarks” (c.f. screenshot), not from its “Headings”. This is why I consider the option to be misleading, as it's not exporting an "outline" (which LibreOffice calls "headings"), as its name implies, but what LibreOffice calls "bookmarks". -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149244] Autosave Autorecovery stuck on 10 min defaults. Configuration. FileSave.
https://bugs.documentfoundation.org/show_bug.cgi?id=149244 Mike Kaganski changed: What|Removed |Added Resolution|--- |DUPLICATE Status|REOPENED|RESOLVED --- Comment #3 from Mike Kaganski --- *** This bug has been marked as a duplicate of bug 149178 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150288] New: Aug. 1st becomes Jan. 8th when using DD/MM/YYYY date format
https://bugs.documentfoundation.org/show_bug.cgi?id=150288 Bug ID: 150288 Summary: Aug. 1st becomes Jan. 8th when using DD/MM/ date format Product: LibreOffice Version: 7.2.7.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: joaol...@gmail.com Description: When using DD/MM/ date format, typing 31/8/22 automatically formats to 31/08/2022, but typing 1/8/22 automatically formats to 08/01/2022. Aug. 1st becomes Jan. 8th. Steps to Reproduce: 1. On menu: File/New/Spreadsheet 2. Left-click on "A" to select the entire column A. 3. Right-click on "A" to open the pop-up menu, and select "Format Cells". 4. Select Category "Date", Language "Portuguese (Brazil)", and Format "31/12/1999". Click "Ok". This will apply the DD/MM/ date format. 5. Type 31/8/22 in cell A1. This will automatically format to 31/08/2022. 6. Now type 1/8/22 in cell A2. This will automatically format to 08/01/2022, instead of 01/08/2022. Actual Results: Typing 31/8/22 automatically formats to 31/08/2022, but typing 1/8/22 automatically formats to 08/01/2022. Aug. 1st becomes Jan. 8th. Expected Results: Since the date format is set to DD/MM/, 1/8/2022 means Aug. 1st and should automatically format to 01/08/2022 (Aug. 1st), not to 08/01/2022 (Jan. 8th). Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: Version: 7.2.7.2 Build ID: 20(Build:2) CPU threads: 8; OS: Linux 5.18; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded OpenGL vendor string: Intel OpenGL renderer string: Mesa Intel(R) HD Graphics 4000 (IVB GT2) OpenGL core profile version string: 4.2 (Core Profile) Mesa 21.3.9 OpenGL core profile shading language version string: 4.20 OpenGL core profile context flags: (none) OpenGL core profile profile mask: core profile OpenGL core profile extensions: OpenGL version string: 3.1 Mesa 21.3.9 OpenGL shading language version string: 1.40 OpenGL context flags: (none) OpenGL extensions: OpenGL ES profile version string: OpenGL ES 3.0 Mesa 21.3.9 OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.00 OpenGL ES profile extensions: -- You are receiving this mail because: You are the assignee for the bug.
Week 8 - update
Hi, This week I finished off my work on XTable, I added all the padding properties and also added unit conversions to application which I then put in global as well as adding my tests.- https://gerrit.libreoffice.org/c/core/+/137630 https://gerrit.libreoffice.org/c/core/+/137787 https://gerrit.libreoffice.org/c/core/+/137851 https://gerrit.libreoffice.org/c/core/+/137852 I also added a dialogue so that I could more easily see errors - it prints out MsgBox contents for my macros tests if they fail in writer, which is very helpful. - https://gerrit.libreoffice.org/c/core/+/137897 I also had a look at some of my previous XParagraphFormat tests but plan to do some more with this next working week. Hannah
[Libreoffice-commits] core.git: formula/source sc/source
formula/source/core/api/FormulaCompiler.cxx | 11 ++-
sc/source/ui/docshell/docsh6.cxx|3 ++-
2 files changed, 12 insertions(+), 2 deletions(-)
New commits:
commit 0a78f11fdd13d914d5f063007b2df9796e6dce9d
Author: Eike Rathke
AuthorDate: Fri Aug 5 19:28:50 2022 +0200
Commit: Eike Rathke
CommitDate: Sat Aug 6 19:37:38 2022 +0200
Related: tdf#135993 Use ScCompiler to create English OpCodeMap with AddIns
... instead of formula::FormulaCompiler base class that doesn't
know anything about AddIns, and copy AddIns along to new resulting
native map.
Change-Id: I9e4ece2f7450a561ac502ca1dbddaa5a697fa2fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137882
Tested-by: Eike Rathke
Reviewed-by: Eike Rathke
diff --git a/formula/source/core/api/FormulaCompiler.cxx
b/formula/source/core/api/FormulaCompiler.cxx
index 2b0db73d1a39..591b28744289 100644
--- a/formula/source/core/api/FormulaCompiler.cxx
+++ b/formula/source/core/api/FormulaCompiler.cxx
@@ -1296,7 +1296,16 @@ void FormulaCompiler::OpCodeMap::copyFrom( const
OpCodeMap& r )
}
}
-// TODO: maybe copy the external maps too?
+// This was meant to copy to native map that does not have AddIn symbols
+// but needs them from the source map. It is unclear what should happen if
+// the destination already had externals, so do it only if it doesn't.
+if (!hasExternals())
+{
+maExternalHashMap = r.maExternalHashMap;
+maReverseExternalHashMap = r.maReverseExternalHashMap;
+mbCore = r.mbCore;
+mbEnglish = r.mbEnglish;
+}
}
diff --git a/sc/source/ui/docshell/docsh6.cxx b/sc/source/ui/docshell/docsh6.cxx
index 738c85110967..caefdfc0fed3 100644
--- a/sc/source/ui/docshell/docsh6.cxx
+++ b/sc/source/ui/docshell/docsh6.cxx
@@ -445,7 +445,8 @@ void ScDocShell::SetFormulaOptions( const ScFormulaOptions&
rOpt, bool bForLoadi
if (rOpt.GetUseEnglishFuncName())
{
// switch native symbols to English.
-formula::FormulaCompiler aComp;
+ScAddress aAddress;
+ScCompiler aComp( *m_pDocument, aAddress);
ScCompiler::OpCodeMapPtr xMap =
aComp.GetOpCodeMap(css::sheet::FormulaLanguage::ENGLISH);
ScCompiler::SetNativeSymbols(xMap);
}
[Libreoffice-commits] core.git: sc/inc sc/source
sc/inc/addincol.hxx | 10 +-
sc/inc/funcdesc.hxx |2 -
sc/source/core/data/funcdesc.cxx |4 +-
sc/source/core/data/global.cxx |3 +
sc/source/core/tool/addincol.cxx | 59 +++
5 files changed, 48 insertions(+), 30 deletions(-)
New commits:
commit d778c6fd5c2ba8e27df46ec9e183a61ad29e30d5
Author: Eike Rathke
AuthorDate: Fri Aug 5 19:46:07 2022 +0200
Commit: Eike Rathke
CommitDate: Sat Aug 6 19:37:55 2022 +0200
Resolves: tdf#135993 Create ScFunctionList and ScFuncDesc with English names
Used in Function Wizard and formula tooltips. Without, no matching
name is found for AddIn English name and no
tooltip/description/arguments are displayed.
Change-Id: Ib0cf419c476dae495467c444f1ee1f84a55633a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137883
Tested-by: Jenkins
Reviewed-by: Eike Rathke
diff --git a/sc/inc/addincol.hxx b/sc/inc/addincol.hxx
index 14af12006637..bb89f8d3c87a 100644
--- a/sc/inc/addincol.hxx
+++ b/sc/inc/addincol.hxx
@@ -87,6 +87,7 @@ private:
OUStringaLocalName; ///< for display
OUStringaUpperName; ///< for entering formulas
OUStringaUpperLocal;///< for entering formulas
+OUStringaUpperEnglish; ///< for Function Wizard and
tooltips
OUStringaDescription;
css::uno::Reference< css::reflection::XIdlMethod> xFunction;
css::uno::Any aObject;
@@ -113,6 +114,7 @@ public:
const OUString& GetLocalName() const{ return aLocalName; }
const OUString& GetUpperName() const{ return aUpperName; }
const OUString& GetUpperLocal() const { return aUpperLocal; }
+const OUString& GetUpperEnglish() const { return aUpperEnglish; }
const css::uno::Reference< css::reflection::XIdlMethod>& GetFunction()
const
{ return xFunction; }
const css::uno::Any& GetObject() const { return aObject; }
@@ -132,6 +134,9 @@ public:
voidSetArguments( tools::Long nNewCount, const ScAddInArgDesc*
pNewDescs );
voidSetCallerPos( tools::Long nNewPos );
voidSetCompNames( ::std::vector< LocalizedName >&& rNew );
+
+/// Takes care of handling an empty name *after* upper local name was set.
+voidSetEnglishName( const OUString& rEnglishName );
};
class SC_DLLPUBLIC ScUnoAddInCollection
@@ -175,9 +180,10 @@ public:
voidLocalizeString( OUString& rName );///< modify
rName - input: exact name
tools::LongGetFuncCount();
-boolFillFunctionDesc( tools::Long nFunc, ScFuncDesc& rDesc
);
+boolFillFunctionDesc( tools::Long nFunc, ScFuncDesc&
rDesc, bool bEnglishFunctionNames );
-static bool FillFunctionDescFromData( const ScUnoAddInFuncData&
rFuncData, ScFuncDesc& rDesc );
+static bool FillFunctionDescFromData( const ScUnoAddInFuncData&
rFuncData, ScFuncDesc& rDesc,
+ bool bEnglishFunctionNames );
/// leave rRetExcelName unchanged, if no matching name is
found
boolGetExcelName( const OUString& rCalcName, LanguageType
eDestLang, OUString& rRetExcelName );
/// leave rRetCalcName unchanged, if no matching name is
found
diff --git a/sc/inc/funcdesc.hxx b/sc/inc/funcdesc.hxx
index 58c6957316b3..0f37e924d941 100644
--- a/sc/inc/funcdesc.hxx
+++ b/sc/inc/funcdesc.hxx
@@ -241,7 +241,7 @@ public:
class ScFunctionList
{
public:
-ScFunctionList();
+explicit ScFunctionList( bool bEnglishFunctionNames );
~ScFunctionList();
sal_uInt32 GetCount() const
diff --git a/sc/source/core/data/funcdesc.cxx b/sc/source/core/data/funcdesc.cxx
index dfbfd9a3a78e..c8045e6c1abf 100644
--- a/sc/source/core/data/funcdesc.cxx
+++ b/sc/source/core/data/funcdesc.cxx
@@ -397,7 +397,7 @@ bool ScFuncDesc::compareByName(const ScFuncDesc* a, const
ScFuncDesc* b)
#define ENTRY(CODE) CODE, SAL_N_ELEMENTS(CODE)
-ScFunctionList::ScFunctionList()
+ScFunctionList::ScFunctionList( bool bEnglishFunctionNames )
{
sal_Int32 nMaxFuncNameLen = 0; // Length of longest function name
@@ -958,7 +958,7 @@ ScFunctionList::ScFunctionList()
pDesc = new ScFuncDesc;
pDesc->nFIndex = nNextId++;
-if ( pUnoAddIns->FillFunctionDesc( nFunc, *pDesc ) )
+if ( pUnoAddIns->FillFunctionDesc( nFunc, *pDesc,
bEnglishFunctionNames ) )
{
tmpFuncVector.push_back(pDesc);
nStrLen = pDesc->mxFuncName->getLength();
diff --git a/sc/source/core/data/global.cxx b/sc/source/core/data/global.cxx
index a338c0c76c31..46277a807db0 100644
--- a/sc/source/core/data/global.cxx
+++ b/sc/source/core/data/global.cxx
@@ -74,6 +74,7 @@
#include
#include
#include
+#include
[Libreoffice-bugs] [Bug 149244] Autosave Autorecovery stuck on 10 min defaults. Configuration. FileSave.
https://bugs.documentfoundation.org/show_bug.cgi?id=149244 John Jackson changed: What|Removed |Added Version|7.3.3.2 release |7.3.5.2 release Ever confirmed|0 |1 Status|RESOLVED|REOPENED Resolution|DUPLICATE |--- --- Comment #2 from John Jackson --- The problem still exists in 7.5.3.2. Every ten minutes there is an autosave despite autosave being unchecked. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 124076] preview for horizontal alignment of object in frame border has left and right image exchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=124076 Julien Nabet changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr |desktop.org | --- Comment #6 from Julien Nabet --- On pc Debian x86-64 with master sources updated today, I could reproduce this. I gave a try with https://gerrit.libreoffice.org/c/core/+/137903 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150282] What is the quickest form of checking Cash App Card Balance?
https://bugs.documentfoundation.org/show_bug.cgi?id=150282 Eike Rathke changed: What|Removed |Added Component|BASIC |deletionRequest -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150158] LibreOffice Writer 7.4rc1 freezes when I continue working after a break
https://bugs.documentfoundation.org/show_bug.cgi?id=150158 --- Comment #5 from Gerry --- I did some further investigations with LO 7.4 rc2 in a clean profile but with LanguageTool and Zotero extensions. I couldn't reproduce the freezes anymore, but I do see a significant time lag of several seconds (when continuing work after a break of several minutes), before Writer reacts. Usually, the time lag is just about 2 or 3 seconds, but I had cases where the time lag was more than 10 seconds, once even triggering the crash-app-dialog of Ubuntu. Version: 7.4.0.2 / LibreOffice Community Build ID: 1512ce97d7ed39dce3121f7e15651fd8895f950e CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: de-DE (de_DE.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa xmloff/source
sw/qa/extras/odfexport/data/section-columns-separator.fodt | 24
sw/qa/extras/odfexport/odfexport2.cxx | 35 +
xmloff/source/text/XMLTextColumnsExport.cxx| 13 ++--
3 files changed, 66 insertions(+), 6 deletions(-)
New commits:
commit f1f6c82e613ace836aa78a822688721fb7fb5e80
Author: Mike Kaganski
AuthorDate: Sat Aug 6 16:50:47 2022 +0300
Commit: Mike Kaganski
CommitDate: Sat Aug 6 18:32:03 2022 +0200
tdf#150235: use correct types in XMLTextColumnsExport
The types for the properties are defined in css::text::TextColumns
servise. But before commit 95ebd24a629b4c8cd62cc20c0701683512cc8fa0
Author Mike Kaganski
Date Thu May 27 13:00:10 2021 +0300
editengine-columns: ODF support [API CHANGE]
the implementation of the service (SwXTextColumns) used smaller types
for some properties. The export code (XMLTextColumnsExport::exportXML)
mathced those implementation types.
The mentioned commit changed the implementation to use proper types;
but the export code wasn't corrected.
This fixes the export code.
Change-Id: I95838dec382edc61bb2e5b39177bf57a7d79e0bf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137900
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sw/qa/extras/odfexport/data/section-columns-separator.fodt
b/sw/qa/extras/odfexport/data/section-columns-separator.fodt
new file mode 100644
index ..b9c97eb9e38e
--- /dev/null
+++ b/sw/qa/extras/odfexport/data/section-columns-separator.fodt
@@ -0,0 +1,24 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+Lorem ipsum dolor sit amet, consectetur adipiscing elit.
Vestibulum consequat mi quis pretium semper. Proin luctus orci ac neque
venenatis, quis commodo dolor posuere. Curabitur dignissim sapien quis cursus
egestas. Donec blandit auctor arcu, nec pellentesque eros molestie eget. In
consectetur aliquam hendrerit. Sed cursus mauris vitae ligula pellentesque, non
pellentesque urna aliquet. Fusce placerat mauris enim, nec rutrum purus semper
vel. Praesent tincidunt neque eu pellentesque pharetra. Fusce pellentesque est
orci.
+Integer sodales tincidunt tristique. Sed a metus posuere,
adipiscing nunc et, viverra odio. Donec auctor molestie sem, sit amet tristique
lectus hendrerit sed. Cras sodales nisl sed orci mattis iaculis. Nunc eget
dolor accumsan, pharetra risus a, vestibulum mauris. Nunc vulputate lobortis
mollis. Vivamus nec tellus faucibus, tempor magna nec, facilisis felis. Donec
commodo enim a vehicula pellentesque. Nullam vehicula vestibulum est vel
ultricies.
+Aliquam velit massa, laoreet vel leo nec, volutpat facilisis eros.
Donec consequat arcu ut diam tempor luctus. Cum sociis natoque penatibus et
magnis dis parturient montes, nascetur ridiculus mus. Praesent vitae lacus vel
leo sodales pharetra a a nibh. Vestibulum ante ipsum primis in faucibus orci
luctus et ultrices posuere cubilia Curae; Nam luctus tempus nibh, fringilla
dictum augue consectetur eget. Curabitur at ante sit amet tortor pharetra
molestie eu nec ante. Mauris tincidunt, nibh eu sollicitudin molestie, dolor
sapien congue tortor, a pulvinar sapien turpis sed ante. Donec nec est
elementum, euismod nulla in, mollis nunc.
+
+
+
+
\ No newline at end of file
diff --git a/sw/qa/extras/odfexport/odfexport2.cxx
b/sw/qa/extras/odfexport/odfexport2.cxx
index 30b3791d0dbc..2a2f015f6b84 100644
--- a/sw/qa/extras/odfexport/odfexport2.cxx
+++ b/sw/qa/extras/odfexport/odfexport2.cxx
@@ -9,6 +9,9 @@
#include
+#include
+#include
+#include
#include
#include
#include
@@ -228,6 +231,38 @@ CPPUNIT_TEST_FIXTURE(Test, tdf120972)
"char", cDecimal);
}
+DECLARE_ODFEXPORT_TEST(testSectionColumnSeparator,
"section-columns-separator.fodt")
+{
+// tdf#150235: due to wrong types used in column export, 'style:height'
and 'style:style'
+// attributes were exported incorrectly for 'style:column-sep' element
+auto xSection =
getProperty>(getParagraph(1), "TextSection");
+auto xColumns = getProperty>(xSection,
"TextColumns");
+CPPUNIT_ASSERT(xColumns);
+CPPUNIT_ASSERT_EQUAL(sal_Int16(2), xColumns->getColumnCount());
+
+// Without the accompanying fix in place, this test would have failed with:
+// - Expected: 50
+// - Actual : 100
+CPPUNIT_ASSERT_EQUAL(static_cast(50),
+ getProperty(xColumns,
"SeparatorLineRelativeHeight"));
+// Without the accompanying fix in place, this test would have failed with:
+// - Expected: 2
+// - Actual : 0
+CPPUNIT_ASSERT_EQUAL(css::text::ColumnSeparatorStyle::DOTTED,
+ getProperty(xColumns,
"SeparatorLineStyle"));
+
+// Check the rest of the properties, too
+CPPUNIT_ASSERT_EQUAL(true, getProperty(xColumns, "IsAutomatic"));
+CPPUNIT_ASSERT_EQUAL(sal_Int32(600),
[Libreoffice-bugs] [Bug 149361] Add support for BSLN table for Apple Advanced Typography (AAT) based text layout
https://bugs.documentfoundation.org/show_bug.cgi?id=149361 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Whiteboard| QA:needsComment| Ever confirmed|0 |1 CC||79045_79...@mail.ru Status|UNCONFIRMED |NEEDINFO --- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> --- Volga, is this bsln table support depending by harfbuzz? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149739] General input/output error saving complex spreadsheet
https://bugs.documentfoundation.org/show_bug.cgi?id=149739 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 Whiteboard| QA:needsComment| --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Confirm the error in Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: d75c5c1f61a174b3b333e9db6536ab15cc37d00b CPU threads: 4; OS: Mac OS X 12.5; UI render: Skia/Raster; VCL: osx Locale: ru-RU (ru_RU.UTF-8); UI: en-US Calc: threaded Jumbo Tim, how did you create the example? I see some user defined functions there but I don't see any macro in the file -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149739] General input/output error saving complex spreadsheet
https://bugs.documentfoundation.org/show_bug.cgi?id=149739 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Component|LibreOffice |Calc -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149989] `LibreOffice Start Center` doesn’t fit on small displays (i.e. 11” and 14”)
https://bugs.documentfoundation.org/show_bug.cgi?id=149989 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Whiteboard| QA:needsComment| Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||79045_79...@mail.ru --- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> --- What a screen resolution do you have on your display? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150021] Sentence disappear when I press Enter
https://bugs.documentfoundation.org/show_bug.cgi?id=150021 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 Whiteboard| QA:needsComment| CC||79045_79...@mail.ru --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- First - please add info from your LibreOffice's Help->About dialog (use a Copy button there) Second - please write here English (use Google translate site for help if you need) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150277] .ods file causes crash in libreoffice-fresh (QT backend?)
https://bugs.documentfoundation.org/show_bug.cgi?id=150277 Telesto changed: What|Removed |Added Summary|.ods file causes crash in |.ods file causes crash in |libreoffice-fresh |libreoffice-fresh (QT ||backend?) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102495 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||144587 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=144587 [Bug 144587] Tree item is inconsistent with dark theme -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144587] Tree item is inconsistent with dark theme
https://bugs.documentfoundation.org/show_bug.cgi?id=144587 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||102495 CC||79045_79...@mail.ru Ever confirmed|0 |1 Whiteboard| QA:needsComment| Status|UNCONFIRMED |NEW Priority|medium |low --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- confirm in Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: a9d225df2f8772e21435523ca20df1ece37390e4 CPU threads: 4; OS: Linux 5.5; UI render: default; VCL: kf5 (cairo+xcb) Locale: ru-RU (ru_RU.UTF-8); UI: en-US Calc: threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102495 [Bug 102495] [META] KDE VCL backend bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146713] RTL language overlap problem when mixed with LTR language
https://bugs.documentfoundation.org/show_bug.cgi?id=146713 Hossein changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||0286 Regression By||dr.khaled.ho...@gmail.com -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150286] Wrong justification of Persian/Arabic text
https://bugs.documentfoundation.org/show_bug.cgi?id=150286 Hossein changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||6713 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145126] It'd be nice if the formula bar in Calc would accept the LibreOffice Dark application color scheme
https://bugs.documentfoundation.org/show_bug.cgi?id=145126 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru Ever confirmed|0 |1 Whiteboard| QA:needsComment| Status|UNCONFIRMED |NEEDINFO --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- LibreOffice Dark color theme inside Application colors is matter only for the document area view. All other UI elements try use the system theme. Anyway, I tried the system dark mode in Windows 10 with 7.5 and LO looks as black hole =) please try our latest 7.5 development build https://dev-builds.libreoffice.org/daily/master/Win-x86_64@tb77-TDF/2022-08-06_05.03.38/LibreOfficeDev_7.5.0.0.alpha0_Win_x86-64.msi Enable the experimental features in Tools-Option-Advance options section Enable the dark mode in your Windows 10 Restart LibreOffice -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103309] [META] Print dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103309 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||146121 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=146121 [Bug 146121] UI: Redesign proposal regarding to Page Size and Orientation feature in Print dialog -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146121] UI: Redesign proposal regarding to Page Size and Orientation feature in Print dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=146121 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Keywords||needsUXEval Severity|normal |enhancement CC||libreoffice-ux-advise@lists ||.freedesktop.org Whiteboard| QA:needsComment| Blocks||103309 --- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> --- UX-team, here is Print dialog improve proposal (but I'm not sure we need it as different report) Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103309 [Bug 103309] [META] Print dialog bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 146121] UI: Redesign proposal regarding to Page Size and Orientation feature in Print dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=146121 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Keywords||needsUXEval Severity|normal |enhancement CC||libreoffice-ux-advise@lists ||.freedesktop.org Whiteboard| QA:needsComment| Blocks||103309 --- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> --- UX-team, here is Print dialog improve proposal (but I'm not sure we need it as different report) Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103309 [Bug 103309] [META] Print dialog bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 70448] Write more unittests for regression hotspots
https://bugs.documentfoundation.org/show_bug.cgi?id=70448 Hossein changed: What|Removed |Added Whiteboard|target:5.2.0|target:5.2.0 reviewed:2022 --- Comment #7 from Hossein --- Re-evaluating the EasyHack in 2022 This task is still relevant. Finding regression hotspots and writing tests for them is very useful in countering recurring problems. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 101435] [META] Template manager bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=101435 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||146161 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=146161 [Bug 146161] Consider renaming button "open" in templates dialog -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 146161] Consider renaming button "open" in templates dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=146161 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Keywords||needsUXEval Blocks||101435 CC||libreoffice-ux-advise@lists ||.freedesktop.org Priority|medium |lowest Severity|normal |enhancement Whiteboard| QA:needsComment| --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- I don't think it's matter for users (who read the guide of course) UX-team, we need your opinion here Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=101435 [Bug 101435] [META] Template manager bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 146161] Consider renaming button "open" in templates dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=146161 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Keywords||needsUXEval Blocks||101435 CC||libreoffice-ux-advise@lists ||.freedesktop.org Priority|medium |lowest Severity|normal |enhancement Whiteboard| QA:needsComment| --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- I don't think it's matter for users (who read the guide of course) UX-team, we need your opinion here Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=101435 [Bug 101435] [META] Template manager bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: filter/source
filter/source/xsltfilter/LibXSLTTransformer.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit abb3c857bd7f00826e891859f08071f7e112841c Author: Caolán McNamara AuthorDate: Sat Aug 6 15:35:29 2022 +0100 Commit: Caolán McNamara CommitDate: Sat Aug 6 17:24:58 2022 +0200 crashtesting: keep a reference to the passed in LibXSLTTransformer otherwise, as seen with: soffice --headless --convert-to docx forum-mso-de-42789.docx and error will notify the other thread that the load has ended and the other thread will destroy the passed in LibXSLTTransformer early while this thread assumes it continues to exist Change-Id: Ieea9ecc3439ea73cd0433e5e12b87811906c49aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137901 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/filter/source/xsltfilter/LibXSLTTransformer.hxx b/filter/source/xsltfilter/LibXSLTTransformer.hxx index 6cfaebe69a92..8696bda6a34a 100644 --- a/filter/source/xsltfilter/LibXSLTTransformer.hxx +++ b/filter/source/xsltfilter/LibXSLTTransformer.hxx @@ -67,7 +67,7 @@ namespace XSLT static const sal_Int32 OUTPUT_BUFFER_SIZE; static const sal_Int32 INPUT_BUFFER_SIZE; -LibXSLTTransformer* m_transformer; +rtl::Reference m_transformer; Sequence m_readBuf; Sequence m_writeBuf;
[Libreoffice-bugs] [Bug 131177] Replace Hard-Coded Tips of The Day's Bulb by Themeable Icon
https://bugs.documentfoundation.org/show_bug.cgi?id=131177 Hossein changed: What|Removed |Added Whiteboard||reviewed:2022 --- Comment #5 from Hossein --- Re-evaluating the EasyHack in 2022 This enhancement is still relevant. In my opinion, light bulb emoji can also be used. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135771] VERTICAL RULER: Numbers in right-aligned vertical ruler flips horizontally [CONFIGURATION]
https://bugs.documentfoundation.org/show_bug.cgi?id=135771 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #15 from Julien Nabet --- I gave a try with LO Debian package 7.4.0.2, I don't reproduce this. Could someone give a try with LO 7.3.5 or a daily build from master branch (see https://dev-builds.libreoffice.org/daily/master/Win-x86_64@tb77-TDF/current/)? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140652] Copying and pasting a text from clipboard pastes it twice in LibreOffice Writer in KDE (Brazilian bank security app interfering)
https://bugs.documentfoundation.org/show_bug.cgi?id=140652 Rafael Lima changed: What|Removed |Added Blocks||102593 --- Comment #10 from Rafael Lima --- If anyone ever tries to fix this, the warsaw package is downloaded via: https://diagnostico.gasantifraud.com/ Just choose the option "CAIXA". Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102593 [Bug 102593] [META] Paste bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102593] [META] Paste bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102593 Rafael Lima changed: What|Removed |Added Depends on||140652 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=140652 [Bug 140652] Copying and pasting a text from clipboard pastes it twice in LibreOffice Writer in KDE (Brazilian bank security app interfering) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140652] Copying and pasting a text from clipboard pastes it twice in LibreOffice Writer in KDE (Brazilian bank security app interfering)
https://bugs.documentfoundation.org/show_bug.cgi?id=140652 --- Comment #9 from Rafael Lima --- This problem still persists in LO 7.5 alpha. Although it can be said that the "warsaw" package is to blame for this bug, I find it weird that only LibreOffice is affected by installing this package. I believe there's something different that LO does concerning the clipboard that results in double pasting. In comment #7 I suggested removing the "warsaw" package altogether, but this may not be very practical for some users who really need to use internet banking and must have this package installed. So I'd like to share what I've been doing to use LibreOffice alongside warsaw in Kubuntu. Basically, I installed the package and stopped the service via systemctl: systemctl stop warsaw.service Then, when I need to use internet banking, I start the service: systemctl start warsaw.service And after I'm finished, I stop the service once again to use LibreOffice. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149214] Unicode IVS occupies more space if textgrid is on
https://bugs.documentfoundation.org/show_bug.cgi?id=149214 Dieter changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #4 from Dieter --- VERIFIED with Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: a56d0c34716f381accbd9d2e3040a62d3583d18d CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL Mark, thanks for fixing it! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/skia
vcl/skia/skia_denylist_vulkan.xml |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit 407a61943539063c6d56eab8ab0c1b728dd642af Author: Julien Nabet AuthorDate: Wed Aug 3 21:19:21 2022 +0200 Commit: Julien Nabet CommitDate: Sat Aug 6 16:30:27 2022 +0200 tdf#150232: put Intel Iris driver Skia/Vulkan in denylist for all versions + Nvidia on Windows just for device id "0x1401" in order to not being too restrictive. Change-Id: Ie2cb2c6c6bb50ac6080721230ca3e451e886bb07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137768 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/vcl/skia/skia_denylist_vulkan.xml b/vcl/skia/skia_denylist_vulkan.xml index 63df3938b8a2..39163fc9a71e 100644 --- a/vcl/skia/skia_denylist_vulkan.xml +++ b/vcl/skia/skia_denylist_vulkan.xml @@ -27,7 +27,7 @@ - + @@ -36,6 +36,9 @@ + + +
[Libreoffice-bugs] [Bug 125543] Calc window width and height resize to zero when unmaximizing (Linux-only)
https://bugs.documentfoundation.org/show_bug.cgi?id=125543 --- Comment #26 from BogdanB --- Repro today on a new Ubuntu 22.04 install with Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: 5c68399e6bea3aa18477487400f8bb143d6ed84e CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: bin/find-can-be-private-symbols.py toolkit/source
bin/find-can-be-private-symbols.py |1
toolkit/source/awt/vclxtoolkit.cxx | 63 -
2 files changed, 1 insertion(+), 63 deletions(-)
New commits:
commit b2cdf8a1eac730f74160d7c7a1ab9ec90723
Author: Caolán McNamara
AuthorDate: Fri Aug 5 14:51:30 2022 +0100
Commit: Caolán McNamara
CommitDate: Sat Aug 6 16:04:51 2022 +0200
the "CreateWindow" function in svtools is newly removed
Change-Id: I6fb569cf293a896c92bec4c6aae647a0bd02d012
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137871
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/bin/find-can-be-private-symbols.py
b/bin/find-can-be-private-symbols.py
index 7203f8ed8c06..2ac7619d9026 100755
--- a/bin/find-can-be-private-symbols.py
+++ b/bin/find-can-be-private-symbols.py
@@ -182,7 +182,6 @@ with
open("bin/find-can-be-private-symbols.functions.results", "wt") as f:
elif sym.endswith("component_getFactory"): continue
elif sym == "CreateDialogFactory": continue
elif sym == "CreateUnoWrapper": continue
-elif sym == "CreateWindow": continue
elif sym == "ExportDOC": continue
elif sym == "ExportPPT": continue
elif sym == "ExportRTF": continue
diff --git a/toolkit/source/awt/vclxtoolkit.cxx
b/toolkit/source/awt/vclxtoolkit.cxx
index da81df17b2dd..18daef169414 100644
--- a/toolkit/source/awt/vclxtoolkit.cxx
+++ b/toolkit/source/awt/vclxtoolkit.cxx
@@ -403,12 +403,6 @@ Size MessBox::GetOptimalSize() const
namespace {
-extern "C" typedef vcl::Window* (*FN_SvtCreateWindow)(
-rtl::Reference* ppNewComp,
-const css::awt::WindowDescriptor* pDescriptor,
-vcl::Window* pParent,
-WinBits nWinBits );
-
class Pause : public Idle
{
public:
@@ -440,9 +434,6 @@ class VCLXToolkit : public cppu::BaseMutex,
css::uno::Reference< css::datatransfer::clipboard::XClipboard >
mxClipboard;
css::uno::Reference< css::datatransfer::clipboard::XClipboard >
mxSelection;
-oslModule hSvToolsLib;
-FN_SvtCreateWindow fnSvtCreateWindow;
-
::comphelper::OInterfaceContainerHelper3
m_aTopWindowListeners;
::comphelper::OInterfaceContainerHelper3
m_aKeyHandlers;
::comphelper::OInterfaceContainerHelper3
m_aFocusListeners;
@@ -941,9 +932,6 @@ VCLXToolkit::VCLXToolkit():
m_bEventListener(false),
m_bKeyListener(false)
{
-hSvToolsLib = nullptr;
-fnSvtCreateWindow = nullptr;
-
#ifndef IOS
osl::Guard< osl::Mutex > aGuard( getInitMutex() );
nVCLToolkitInstanceCount++;
@@ -958,15 +946,6 @@ VCLXToolkit::VCLXToolkit():
void SAL_CALL VCLXToolkit::disposing()
{
-#ifndef DISABLE_DYNLOADING
-if ( hSvToolsLib )
-{
-osl_unloadModule( hSvToolsLib );
-hSvToolsLib = nullptr;
-fnSvtCreateWindow = nullptr;
-}
-#endif
-
#ifndef IOS
{
osl::Guard< osl::Mutex > aGuard( getInitMutex() );
@@ -1855,16 +1834,6 @@ vcl::Window* VCLXToolkit::ImplCreateWindow(
rtl::Reference* ppNewCom
return pNewWindow;
}
-#ifndef DISABLE_DYNLOADING
-
-extern "C" { static void thisModule() {} }
-
-#else
-
-extern "C" vcl::Window* SAL_CALL CreateWindow( rtl::Reference*
ppNewComp, const css::awt::WindowDescriptor* pDescriptor, vcl::Window* pParent,
WinBits nWinBits );
-
-#endif
-
css::uno::Reference< css::awt::XWindowPeer > VCLXToolkit::ImplCreateWindow(
const css::awt::WindowDescriptor& rDescriptor,
MessBoxStyle nForceMessBoxStyle )
@@ -1893,37 +1862,7 @@ css::uno::Reference< css::awt::XWindowPeer >
VCLXToolkit::ImplCreateWindow(
rtl::Reference pNewComp;
-vcl::Window* pNewWindow = nullptr;
-// Try to create the window with SvTools
-// (do this _before_ creating it on our own: The old mechanism (extended
toolkit in SvTools) did it this way,
-// and we need to stay compatible)
-// try to load the lib
-if ( !fnSvtCreateWindow
-#ifndef DISABLE_DYNLOADING
- && !hSvToolsLib
-#endif
- )
-{
-#ifndef DISABLE_DYNLOADING
-OUString aLibName(SVT_DLL_NAME);
-hSvToolsLib = osl_loadModuleRelative(
-, aLibName.pData, SAL_LOADMODULE_DEFAULT );
-if ( hSvToolsLib )
-{
-OUString aFunctionName( "CreateWindow" );
-fnSvtCreateWindow =
reinterpret_cast(osl_getFunctionSymbol( hSvToolsLib,
aFunctionName.pData ));
-}
-#else
-fnSvtCreateWindow = nullptr;
-#endif
-}
-// ask the SvTool creation function
-if ( fnSvtCreateWindow )
-pNewWindow = fnSvtCreateWindow( , , pParent,
nWinBits );
-
-// if SvTools could not provide a window, create it ourself
-if ( !pNewWindow )
-pNewWindow = ImplCreateWindow( , rDescriptor, pParent,
nWinBits, aPair.second );
+vcl::Window* pNewWindow = ImplCreateWindow( , rDescriptor,
pParent, nWinBits, aPair.second );
DBG_ASSERT( pNewWindow, "createWindow: Unknown Component!" );
SAL_INFO_IF( !pNewComp, "toolkit",
[Libreoffice-bugs] [Bug 150235] Separator line in columned section
https://bugs.documentfoundation.org/show_bug.cgi?id=150235 Mike Kaganski changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com |desktop.org | --- Comment #7 from Mike Kaganski --- https://gerrit.libreoffice.org/c/core/+/137900 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 38890] Remove hard-coded project URLs
https://bugs.documentfoundation.org/show_bug.cgi?id=38890 Hossein changed: What|Removed |Added Whiteboard||reviewed:2022 --- Comment #21 from Hossein --- Re-evaluating the EasyHack in 2022 This enhancement is still relevant. Some hard-coded project URLs are still in the code. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=71732 Hossein changed: What|Removed |Added Depends on||150285 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=150285 [Bug 150285] (Justified-Arabic-Text-Kashida) - [META] Problems with Justified Arabic/Persian text -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150285] (Justified-Arabic-Text-Kashida) - [META] Problems with Justified Arabic/Persian text
https://bugs.documentfoundation.org/show_bug.cgi?id=150285 Hossein changed: What|Removed |Added Blocks||71732 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=71732 [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: basctl/source
basctl/source/basicide/bastypes.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit de5135060d01b650b7258c02e847e916ae9541fd
Author: Caolán McNamara
AuthorDate: Sat Aug 6 12:13:29 2022 +0100
Commit: Caolán McNamara
CommitDate: Sat Aug 6 15:25:52 2022 +0200
cid#1507764 Unintended comparison to logical negation
missing - from ->
Change-Id: Ieca42cf3fd3e1c10186ba57dd422f3e4ddf9e20a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137898
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/basctl/source/basicide/bastypes.cxx
b/basctl/source/basicide/bastypes.cxx
index 1790c4b5444f..5411b73336bb 100644
--- a/basctl/source/basicide/bastypes.cxx
+++ b/basctl/source/basicide/bastypes.cxx
@@ -72,7 +72,7 @@ BaseWindow::~BaseWindow()
void BaseWindow::dispose()
{
-if (pShellVScrollBar && !pShellVScrollBar>isDisposed())
+if (pShellVScrollBar && !pShellVScrollBar->isDisposed())
pShellVScrollBar->SetScrollHdl( Link() );
if (pShellHScrollBar && !pShellHScrollBar->isDisposed())
pShellHScrollBar->SetScrollHdl( Link() );
[Libreoffice-bugs] [Bug 150285] (Justified-Arabic-Text-Kashida) - [META] Problems with Justified Arabic/Persian text
https://bugs.documentfoundation.org/show_bug.cgi?id=150285 Hossein changed: What|Removed |Added Component|LibreOffice |graphics stack -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=71732 Hossein changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||0285 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150285] (Justified-Arabic-Text-Kashida) - [META] Problems with Justified Arabic/Persian text
https://bugs.documentfoundation.org/show_bug.cgi?id=150285 Hossein changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=71 ||732, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=89 ||870 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150287] New: Row height is not preserved from the default style, on insertion of a new sheet, when using custom calc template
https://bugs.documentfoundation.org/show_bug.cgi?id=150287 Bug ID: 150287 Summary: Row height is not preserved from the default style, on insertion of a new sheet, when using custom calc template Product: LibreOffice Version: 7.3.4.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mbayc...@yahoo.com Description: When I create a template with a custom default cell style then create a document with that template, the default cell style is not completely preserved on new sheets inserted after 'Sheet1'. The initial 'Sheet1' has the correct formatting, however, when a new sheet is added the row heights on the new sheet appear to use the libre calc default and not the format of the template and original sheet. My customization included padding so it may be the padding not being honored or the optimal-height setting not being honored. Steps to Reproduce: 1. Open blank worksheet. 2. Open styles manager, right click on 'default' style and select 'modify'. 3. On font tab change font to 'Calibri'. 4. On the 'Borders' tab increase padding to 3.0pt on all 4 sides. 5. Save worksheet as template, with 'use as default' checked. 6. Create new document, which will have a single initial sheet with the new formatting. 7. Insert a new sheet using the '+' or from 'Sheet'->'insert sheet' Actual Results: The new sheet row height is not preserved on the new blank worksheet. Expected Results: I expect that every new sheet will look exactly like the initial default blank sheet that is there at the creation of a new datasheet. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: I can correct the problem by taking an extra step of selecting the entire newly created sheet, right clicking on the rows and selecting 'optimal-height' and then my new sheet looks like what I have on my initial sheet. I don't know if other style properties are also not displaying correctly. Also, I can't tell if it's a row height property or maybe just the padding that is not being displayed. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150285] (Justified-Arabic-Text-Kashida) - [META] Problems with Justified Arabic/Persian text
https://bugs.documentfoundation.org/show_bug.cgi?id=150285 Hossein changed: What|Removed |Added Depends on||150286 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=150286 [Bug 150286] Wrong justification of Persian/Arabic text -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150286] Wrong justification of Persian/Arabic text
https://bugs.documentfoundation.org/show_bug.cgi?id=150286 Hossein changed: What|Removed |Added Regression By||dr.khaled.ho...@gmail.com Blocks||150285 Keywords||bibisected, bisected, ||regression Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=150285 [Bug 150285] (Justified-Arabic-Text-Kashida) - [META] Problems with Justified Arabic/Persian text -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150286] Wrong justification of Persian/Arabic text
https://bugs.documentfoundation.org/show_bug.cgi?id=150286 --- Comment #4 from Hossein --- This is a regression, bibisected to: commit f0393d7ff69011a16b100541ef18e5090544e4a1 Author: Khaled Hosny Date: Mon May 6 16:54:53 2013 +0200 [harfbuzz] Fix text width calculation, 3rd try It turns out storing the width in the layout is not so good idea, because in some mysterious cases when font fallback is involved we call GetTextWidth() without calling LayoutText() first, and we return the width of the previous text run. It seems all I needed is to pass down the X offset with the glyph item, and take it into account when calculating the width. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150286] Wrong justification of Persian/Arabic text
https://bugs.documentfoundation.org/show_bug.cgi?id=150286 --- Comment #3 from Hossein --- Created attachment 181642 --> https://bugs.documentfoundation.org/attachment.cgi?id=181642=edit Vazirmatn font The latest version of "Vazirmatn" font, which is currently 33.003, can be downloaded from: https://github.com/rastikerdar/vazirmatn/releases -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150286] Wrong justification of Persian/Arabic text
https://bugs.documentfoundation.org/show_bug.cgi?id=150286 --- Comment #2 from Hossein --- Created attachment 181641 --> https://bugs.documentfoundation.org/attachment.cgi?id=181641=edit Incorrect justified text with LO 7.5 dev master -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/ftnidx.hxx |3 ++-
sw/source/core/crsr/trvlfnfl.cxx|4 ++--
sw/source/core/doc/DocumentContentOperationsManager.cxx |2 +-
sw/source/core/doc/docftn.cxx |2 +-
sw/source/core/doc/ftnidx.cxx |2 +-
sw/source/core/docnode/ndsect.cxx |2 +-
sw/source/core/docnode/node.cxx |2 +-
sw/source/core/undo/undobj.cxx |2 +-
8 files changed, 10 insertions(+), 9 deletions(-)
New commits:
commit 71ce0e354437db3086d6d746b0e9edbc693ddcca
Author: Noel Grandin
AuthorDate: Fri Aug 5 16:06:16 2022 +0200
Commit: Noel Grandin
CommitDate: Sat Aug 6 15:05:36 2022 +0200
make SeekEntry take a SwNode, not an SwNodeIndex
as part of the process of hiding the internals of SwPosition
Change-Id: Id43211f221f3b90c46629bedec25f9078c7bf9dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137894
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/inc/ftnidx.hxx b/sw/inc/ftnidx.hxx
index 39acdf0a96a0..7d5a22a01359 100644
--- a/sw/inc/ftnidx.hxx
+++ b/sw/inc/ftnidx.hxx
@@ -27,6 +27,7 @@ class IDocumentRedlineAccess;
class SwTextFootnote;
class SwNodeIndex;
class SwSectionNode;
+class SwNode;
// Everywhere where NodeIndex is used, the header files missing here
// are already included. Therefore put here as defines only and
@@ -46,7 +47,7 @@ public:
void UpdateFootnote( const SwNodeIndex& rStt ); // Update all from pos.
void UpdateAllFootnote(); // Update all footnotes.
-SwTextFootnote* SeekEntry( const SwNodeIndex& rIdx, size_t* pPos = nullptr
) const;
+SwTextFootnote* SeekEntry( const SwNode& rNd, size_t* pPos = nullptr )
const;
};
class SwUpdFootnoteEndNtAtEnd
diff --git a/sw/source/core/crsr/trvlfnfl.cxx b/sw/source/core/crsr/trvlfnfl.cxx
index 714750477d14..11ede589747c 100644
--- a/sw/source/core/crsr/trvlfnfl.cxx
+++ b/sw/source/core/crsr/trvlfnfl.cxx
@@ -206,7 +206,7 @@ bool SwCursor::GotoNextFootnoteAnchor()
return false;
}
-if( rFootnoteArr.SeekEntry( GetPoint()->nNode, ))
+if( rFootnoteArr.SeekEntry( GetPoint()->GetNode(), ))
{
// there is a footnote with this index, so search also for the next one
if( nPos < rFootnoteArr.size() )
@@ -278,7 +278,7 @@ bool SwCursor::GotoPrevFootnoteAnchor()
return false;
}
-if( rFootnoteArr.SeekEntry( GetPoint()->nNode, ) )
+if( rFootnoteArr.SeekEntry( GetPoint()->GetNode(), ) )
{
// there is a footnote with this index, so search also for the next one
SwNodeOffset nNdPos = GetPoint()->GetNodeIndex();
diff --git a/sw/source/core/doc/DocumentContentOperationsManager.cxx
b/sw/source/core/doc/DocumentContentOperationsManager.cxx
index 37e21b5506c6..b95740932b07 100644
--- a/sw/source/core/doc/DocumentContentOperationsManager.cxx
+++ b/sw/source/core/doc/DocumentContentOperationsManager.cxx
@@ -976,7 +976,7 @@ namespace
{
size_t nPos = 0;
-rFootnoteArr.SeekEntry( rSttNd, );
+rFootnoteArr.SeekEntry( rSttNd.GetNode(), );
SwTextFootnote* pSrch;
const SwNode* pFootnoteNd;
diff --git a/sw/source/core/doc/docftn.cxx b/sw/source/core/doc/docftn.cxx
index 59ef1da0aede..61dbe5071cd2 100644
--- a/sw/source/core/doc/docftn.cxx
+++ b/sw/source/core/doc/docftn.cxx
@@ -442,7 +442,7 @@ bool SwDoc::SetCurFootnote( const SwPaM& rPam, const
OUString& rNumStr,
const sal_Int32 nEndCnt = pEnd->GetContentIndex();
size_t nPos = 0;
-rFootnoteArr.SeekEntry( pStt->nNode, );
+rFootnoteArr.SeekEntry( pStt->GetNode(), );
std::unique_ptr pUndo;
if (GetIDocumentUndoRedo().DoesUndo())
diff --git a/sw/source/core/doc/ftnidx.cxx b/sw/source/core/doc/ftnidx.cxx
index 778a6ed388ee..7a1fb7d89f12 100644
--- a/sw/source/core/doc/ftnidx.cxx
+++ b/sw/source/core/doc/ftnidx.cxx
@@ -405,7 +405,7 @@ void SwFootnoteIdxs::UpdateAllFootnote()
aLayout->UpdateFootnoteNums();
}
-SwTextFootnote* SwFootnoteIdxs::SeekEntry( const SwNodeIndex& rPos, size_t*
pFndPos ) const
+SwTextFootnote* SwFootnoteIdxs::SeekEntry( const SwNode& rPos, size_t* pFndPos
) const
{
SwNodeOffset nIdx = rPos.GetIndex();
diff --git a/sw/source/core/docnode/ndsect.cxx
b/sw/source/core/docnode/ndsect.cxx
index a285d0a0829f..a9fa873e7748 100644
--- a/sw/source/core/docnode/ndsect.cxx
+++ b/sw/source/core/docnode/ndsect.cxx
@@ -751,7 +751,7 @@ void sw_DeleteFootnote( SwSectionNode *pNd, SwNodeOffset
nStt, SwNodeOffset nEnd
return;
size_t nPos = 0;
-rFootnoteArr.SeekEntry( SwNodeIndex( *pNd ), );
+rFootnoteArr.SeekEntry( *pNd, );
SwTextFootnote* pSrch;
// Delete all succeeding Footnotes
diff --git a/sw/source/core/docnode/node.cxx b/sw/source/core/docnode/node.cxx
index
[Libreoffice-bugs] [Bug 150286] Wrong justification of Persian/Arabic text
https://bugs.documentfoundation.org/show_bug.cgi?id=150286 --- Comment #1 from Hossein --- Created attachment 181640 --> https://bugs.documentfoundation.org/attachment.cgi?id=181640=edit Correct justified text with LO 4.4 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: solenv/gbuild
solenv/gbuild/platform/com_GCC_defs.mk |1 + 1 file changed, 1 insertion(+) New commits: commit a95bf932ed22abbb346b1d70e3c32578074667f3 Author: Noel Grandin AuthorDate: Sat Aug 6 12:47:22 2022 +0200 Commit: Noel Grandin CommitDate: Sat Aug 6 15:05:16 2022 +0200 turn on -Wshadow-all for clang compilers mostly so that it matches the existing behaviour of the GCC compiler, which makes it easier submitting patches when building locally with clang Change-Id: I0197ec61bc97a3899c2b379efa0f2ad8ed028986 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137896 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/solenv/gbuild/platform/com_GCC_defs.mk b/solenv/gbuild/platform/com_GCC_defs.mk index 004945a32d32..443ff10eaae1 100644 --- a/solenv/gbuild/platform/com_GCC_defs.mk +++ b/solenv/gbuild/platform/com_GCC_defs.mk @@ -70,6 +70,7 @@ gb_CFLAGS_COMMON := \ -Wunreachable-code \ $(if $(or $(and $(COM_IS_CLANG),$(or $(findstring icecc,$(CC)),$(findstring icecc,$(CCACHE_PREFIX,$(findstring sccache,$(CC))),,-Wunused-macros) \ $(if $(COM_IS_CLANG),-Wembedded-directive) \ + $(if $(COM_IS_CLANG),-Wshadow-all) \ -finput-charset=UTF-8 \ -fmessage-length=0 \ -fno-common \
[Libreoffice-bugs] [Bug 150286] New: Wrong justification of Persian/Arabic text
https://bugs.documentfoundation.org/show_bug.cgi?id=150286 Bug ID: 150286 Summary: Wrong justification of Persian/Arabic text Product: LibreOffice Version: 4.4.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: hoss...@libreoffice.org Created attachment 181639 --> https://bugs.documentfoundation.org/attachment.cgi?id=181639=edit Justified Persian/Arabic text Description: As described (in Persian) below, the user could use the justified text until LibreOffice 4.4, but after that the output became incorrect: Problem with justified text in LibreOffice: https://forum.ubuntu.ir/index.php?topic=155184.0 Steps to Reproduce: 1. Open the attachment Actual Results: Text is not justified in page 1 Expected Results: Text should be justified in page 1 Reproducible: Always User Profile Reset: No Additional Info: Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: 56145f237b63a35c142dbccd434fd780badcf489 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: x11 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150285] (Justified-Arabic-Text-Kashida) - [META] Problems with Justified Arabic/Persian text
https://bugs.documentfoundation.org/show_bug.cgi?id=150285 Hossein changed: What|Removed |Added Depends on||106653 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=106653 [Bug 106653] RTL Arabic justified text has some gaps between characters when using diacritics -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 106653] RTL Arabic justified text has some gaps between characters when using diacritics
https://bugs.documentfoundation.org/show_bug.cgi?id=106653 Hossein changed: What|Removed |Added Blocks||150285 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=150285 [Bug 150285] (Justified-Arabic-Text-Kashida) - [META] Problems with Justified Arabic/Persian text -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150285] New: (Justified-Arabic-Text-Kashida) - [META] Problems with Justified Arabic/Persian text
https://bugs.documentfoundation.org/show_bug.cgi?id=150285 Bug ID: 150285 Summary: (Justified-Arabic-Text-Kashida) - [META] Problems with Justified Arabic/Persian text Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: hoss...@libreoffice.org This is a meta issue to track all the bugs related to justified text and also kashida related issues. Feel free to add related bugs. Description: When writing Arabic/Persian text, and setting the paragraph to justified, kashida is inserted incorrectly. Sometimes, there are gaps in the text (usually when using diacritics), and sometimes there are black lines in the text, where it is not expected (bad positioning of kashidas) Kashida https://en.wikipedia.org/wiki/Kashida Before version 5.3, LibreOffice used "three different layout systems; Uniscribe on Windows, Core Text on Mac OS X and HarfBuzz everywhere else". Justified Arabic text had problems, but most of them were fixed. With LibreOffice 5.3, the text layout engine was changed to use HarfBuzz for laying out text on all platforms. See tdf#89870 and LibreOffice 5.3 release notes: https://wiki.documentfoundation.org/ReleaseNotes/5.3#Text_Layout After this change, new problem appeared in text rendering for RTL/CTL languages, and many of them are revealed when setting the RTL paragraphs as justified. As described in tdf#104921, the current approach for Arabic text justification is brittle, and leads to several problems. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 106653] RTL Arabic justified text has some gaps between characters when using diacritics
https://bugs.documentfoundation.org/show_bug.cgi?id=106653 Hossein changed: What|Removed |Added Keywords||bibisected, bisected, ||regression Version|5.3.1.2 release |5.3.0.3 release Summary|RTL Arabic justified text |RTL Arabic justified text |has some gaps between |has some gaps between |characters |characters when using ||diacritics Regression By||dr.khaled.ho...@gmail.com --- Comment #32 from Hossein --- This is a regression, bibisected to: commit 8f2dd1df1d6cc94ebbc1149de72bc6d6dffa6533 Author: Khaled Hosny Date: Wed Nov 2 23:52:06 2016 +0200 Revert "Revert "Enable the new text layout engine by default"" This reverts commit 3950166877bf1308f9e449992e20b558342af825. This problem first appeared in LibreOffice 5.3, after enabling the new text engine that uses HarfBuzz as the default for rendering text on all platforms. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 106653] RTL Arabic justified text has some gaps between characters
https://bugs.documentfoundation.org/show_bug.cgi?id=106653 --- Comment #30 from Hossein --- Created attachment 181637 --> https://bugs.documentfoundation.org/attachment.cgi?id=181637=edit Gaps inside Arabic/Persian text with diacritics in justified paragraphs This problem happens when you use diacritics. To show the problem better, I attach an example from Ask LibreOffice, in which the problem is more clearly visible: Justified Persian (Farsi) paragraphs! https://ask.libreoffice.org/t/justified-persian-farsi-paragraphs/60605 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 106653] RTL Arabic justified text has some gaps between characters
https://bugs.documentfoundation.org/show_bug.cgi?id=106653 Hossein changed: What|Removed |Added CC||hoss...@libreoffice.org --- Comment #31 from Hossein --- Created attachment 181638 --> https://bugs.documentfoundation.org/attachment.cgi?id=181638=edit Gaps inside Arabic/Persian text with diacritics in justified paragraphs This is the PNG version of the above attachment. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: oovbaapi/ooo sw/source
oovbaapi/ooo/vba/word/XGlobals.idl |9 +++
sw/source/ui/vba/vbaglobals.cxx| 45 +
sw/source/ui/vba/vbaglobals.hxx| 10
3 files changed, 64 insertions(+)
New commits:
commit 5fecf10b9ef6e76aa1d06b7ab350abb5a495dda0
Author: Hannah Meeks
AuthorDate: Fri Aug 5 10:48:50 2022 +0100
Commit: Tomaž Vajngerl
CommitDate: Sat Aug 6 14:16:50 2022 +0200
VBA Add conversion methods to global
Change-Id: I920799321f245c015a527c816272c1038cc04544
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137851
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/oovbaapi/ooo/vba/word/XGlobals.idl
b/oovbaapi/ooo/vba/word/XGlobals.idl
index 9808187a0d9f..8d2ee3900fcc 100644
--- a/oovbaapi/ooo/vba/word/XGlobals.idl
+++ b/oovbaapi/ooo/vba/word/XGlobals.idl
@@ -37,6 +37,15 @@ interface XGlobals : com::sun::star::uno::XInterface
any Dialogs( [in] any Index );
any ListGalleries( [in] any aIndex );
float CentimetersToPoints([in] float Centimeters );
+float PointsToCentimeters( [in] float Points);
+float PixelsToPoints( [in] float Pixels, [in] boolean fVertical );
+float PointsToPixels( [in] float Points, [in] boolean fVertical);
+float InchesToPoints( [in] float Inches);
+float PointsToInches( [in] float Points);
+float MillimetersToPoints( [in] float Millimeters );
+float PointsToMillimeters( [in] float Points);
+float PicasToPoints( [in] float Picas);
+float PointsToPicas( [in] float Points);
};
}; }; };
diff --git a/sw/source/ui/vba/vbaglobals.cxx b/sw/source/ui/vba/vbaglobals.cxx
index 0e5db3802895..6492b2628d59 100644
--- a/sw/source/ui/vba/vbaglobals.cxx
+++ b/sw/source/ui/vba/vbaglobals.cxx
@@ -129,6 +129,51 @@ float SAL_CALL SwVbaGlobals::CentimetersToPoints( float
Centimeters )
return getApplication()->CentimetersToPoints( Centimeters );
}
+float SAL_CALL SwVbaGlobals::PointsToCentimeters( float Points )
+{
+return getApplication()->PointsToCentimeters( Points );
+}
+
+float SAL_CALL SwVbaGlobals::PixelsToPoints( float Pixels, ::sal_Bool
fVertical )
+{
+return getApplication()->PixelsToPoints( Pixels, fVertical );
+}
+
+float SAL_CALL SwVbaGlobals::PointsToPixels( float Points, ::sal_Bool
fVertical )
+{
+return getApplication()->PointsToPixels( Points, fVertical );
+}
+
+float SAL_CALL SwVbaGlobals::InchesToPoints( float Inches )
+{
+return getApplication()->InchesToPoints( Inches );
+}
+
+float SAL_CALL SwVbaGlobals::PointsToInches( float Points )
+{
+return getApplication()->PointsToInches( Points );
+}
+
+float SAL_CALL SwVbaGlobals::MillimetersToPoints( float Millimeters )
+{
+return getApplication()->MillimetersToPoints( Millimeters );
+}
+
+float SAL_CALL SwVbaGlobals::PointsToMillimeters( float Points )
+{
+return getApplication()->PointsToMillimeters( Points );
+}
+
+float SAL_CALL SwVbaGlobals::PicasToPoints( float Picas )
+{
+return getApplication()->PicasToPoints( Picas );
+}
+
+float SAL_CALL SwVbaGlobals::PointsToPicas( float Points )
+{
+return getApplication()->PointsToPicas( Points );
+}
+
OUString
SwVbaGlobals::getServiceImplName()
{
diff --git a/sw/source/ui/vba/vbaglobals.hxx b/sw/source/ui/vba/vbaglobals.hxx
index 1d8c0b4f8a2a..af26f1b6256d 100644
--- a/sw/source/ui/vba/vbaglobals.hxx
+++ b/sw/source/ui/vba/vbaglobals.hxx
@@ -56,6 +56,16 @@ public:
virtual css::uno::Any SAL_CALL Dialogs(const css::uno::Any& aIndex)
override;
virtual css::uno::Any SAL_CALL ListGalleries(const css::uno::Any& aIndex)
override;
virtual float SAL_CALL CentimetersToPoints(float Centimeters) override;
+virtual float SAL_CALL PointsToCentimeters(float Points) override;
+virtual float SAL_CALL PixelsToPoints(float Pixels, ::sal_Bool fVertical)
override;
+virtual float SAL_CALL PointsToPixels(float Pixels, ::sal_Bool fVertical)
override;
+virtual float SAL_CALL InchesToPoints(float Inches) override;
+virtual float SAL_CALL PointsToInches(float Points) override;
+virtual float SAL_CALL MillimetersToPoints(float Millimeters) override;
+virtual float SAL_CALL PointsToMillimeters(float Points) override;
+virtual float SAL_CALL PicasToPoints(float Picas) override;
+virtual float SAL_CALL PointsToPicas(float Points) override;
+
// XMultiServiceFactory
virtual css::uno::Sequence SAL_CALL getAvailableServiceNames()
override;
