[Libreoffice-bugs] [Bug 115481] Paper size output does not match the paper size selected
https://bugs.documentfoundation.org/show_bug.cgi?id=115481 --- Comment #24 from João Paulo --- Created attachment 181970 --> https://bugs.documentfoundation.org/attachment.cgi?id=181970=edit Print dialog shows LibreOffice will try to print as an A4 document in landscape instead of Envelope C6/5 Sorry, I sent the same screenshot three times. Those new screenshots are correct. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 115481] Paper size output does not match the paper size selected
https://bugs.documentfoundation.org/show_bug.cgi?id=115481 João Paulo changed: What|Removed |Added Attachment #181842|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148626] Printing Envelopes
https://bugs.documentfoundation.org/show_bug.cgi?id=148626 --- Comment #5 from João Paulo --- Created attachment 181969 --> https://bugs.documentfoundation.org/attachment.cgi?id=181969=edit Print dialog shows incorrect paper size after creating a custom paper size on the printer driver settings -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148626] Printing Envelopes
https://bugs.documentfoundation.org/show_bug.cgi?id=148626 --- Comment #4 from João Paulo --- Created attachment 181968 --> https://bugs.documentfoundation.org/attachment.cgi?id=181968=edit Print dialog shows LibreOffice will try to print as an A4 document in landscape instead of Envelope C6/5 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 8f2c68e5d85602b2472db5e5836c934cae5805a2 Author: Olivier Hallot AuthorDate: Tue Aug 23 01:20:02 2022 -0300 Commit: Gerrit Code Review CommitDate: Tue Aug 23 06:20:02 2022 +0200 Update git submodules * Update helpcontent2 from branch 'libreoffice-7-4' to 278086ec01e796c7668de4760a1f2cde09bbf370 - Update LO7.4 new features video (no translation needed) Change-Id: Ic1290ef2d90aca04f1bf6df1aae5d19f64f5919f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/138486 Tested-by: Jenkins Reviewed-by: Olivier Hallot (cherry picked from commit a37e043d12c969f3c12686ff09bc9087130b91aa) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/138425 Reviewed-by: Adolfo Jayme Barrientos diff --git a/helpcontent2 b/helpcontent2 index a4989eb67de8..278086ec01e7 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit a4989eb67de865d030f3a5012734da7b72d7583b +Subproject commit 278086ec01e796c7668de4760a1f2cde09bbf370
[Libreoffice-bugs] [Bug 107733] [META] Hyperlink bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107733 Bug 107733 depends on bug 43431, which changed state. Bug 43431 Summary: EDITING: Hyperlinks do not work if DRAW picture in background (wrongly select object) https://bugs.documentfoundation.org/show_bug.cgi?id=43431 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - vcl/unx
vcl/unx/generic/gdi/cairotextrender.cxx | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
New commits:
commit 4ec4fee0cf48142e2f4c594fe401f72872dc1bd9
Author: Caolán McNamara
AuthorDate: Mon Aug 22 13:22:04 2022 +0100
Commit: Adolfo Jayme Barrientos
CommitDate: Tue Aug 23 06:18:52 2022 +0200
tdf#150507 set hint style even if the platform returns no default font
options
if the platform (e.g. gen/kf5) doesn't return anything for
GetCairoFontOptions() but we have need for specific font options then we
also need to set them
Change-Id: Ia805341d2ec75bdaf3d9de62955a247c33b106d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138543
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/vcl/unx/generic/gdi/cairotextrender.cxx
b/vcl/unx/generic/gdi/cairotextrender.cxx
index 7300562d5d68..1e2e75c01d79 100644
--- a/vcl/unx/generic/gdi/cairotextrender.cxx
+++ b/vcl/unx/generic/gdi/cairotextrender.cxx
@@ -191,14 +191,15 @@ void CairoTextRender::DrawTextLayout(const
GenericSalLayout& rLayout, const SalG
__lsan_disable();
#endif
-if (const cairo_font_options_t* pFontOptions =
GetSalInstance()->GetCairoFontOptions())
-{
-const StyleSettings& rStyleSettings =
Application::GetSettings().GetStyleSettings();
-bool bDisableAA = !rStyleSettings.GetUseFontAAFromSystem() &&
!rGraphics.getAntiAlias();
+const StyleSettings& rStyleSettings =
Application::GetSettings().GetStyleSettings();
+const bool bDisableAA = !rStyleSettings.GetUseFontAAFromSystem() &&
!rGraphics.getAntiAlias();
+const bool bResolutionIndependentLayoutEnabled =
rGraphics.getTextRenderModeForResolutionIndependentLayoutEnabled();
-const bool bResolutionIndependentLayoutEnabled =
rGraphics.getTextRenderModeForResolutionIndependentLayoutEnabled();
-cairo_hint_style_t eHintStyle =
cairo_font_options_get_hint_style(pFontOptions);
-cairo_hint_metrics_t eHintMetricsStyle =
cairo_font_options_get_hint_metrics(pFontOptions);
+const cairo_font_options_t* pFontOptions =
GetSalInstance()->GetCairoFontOptions();
+if (pFontOptions || bDisableAA || bResolutionIndependentLayoutEnabled)
+{
+cairo_hint_style_t eHintStyle = pFontOptions ?
cairo_font_options_get_hint_style(pFontOptions) : CAIRO_HINT_STYLE_DEFAULT;
+cairo_hint_metrics_t eHintMetricsStyle = pFontOptions ?
cairo_font_options_get_hint_metrics(pFontOptions) : CAIRO_HINT_METRICS_DEFAULT;
bool bAllowedHintStyle = !bResolutionIndependentLayoutEnabled ||
(eHintStyle == CAIRO_HINT_STYLE_NONE);
bool bAllowedHintMetricStyle = !bResolutionIndependentLayoutEnabled ||
(eHintMetricsStyle == CAIRO_HINT_METRICS_OFF);
@@ -206,7 +207,7 @@ void CairoTextRender::DrawTextLayout(const
GenericSalLayout& rLayout, const SalG
{
// Disable font AA in case global AA setting is supposed to affect
// font rendering (not the default) and AA is disabled.
-cairo_font_options_t* pOptions =
cairo_font_options_copy(pFontOptions);
+cairo_font_options_t* pOptions = pFontOptions ?
cairo_font_options_copy(pFontOptions) : cairo_font_options_create();
if (bDisableAA)
cairo_font_options_set_antialias(pOptions,
CAIRO_ANTIALIAS_NONE);
if (!bAllowedHintMetricStyle)
@@ -216,7 +217,7 @@ void CairoTextRender::DrawTextLayout(const
GenericSalLayout& rLayout, const SalG
cairo_set_font_options(cr, pOptions);
cairo_font_options_destroy(pOptions);
}
-else
+else if (pFontOptions)
cairo_set_font_options(cr, pFontOptions);
}
[Libreoffice-bugs] [Bug 43431] EDITING: Hyperlinks do not work if DRAW picture in background (wrongly select object)
https://bugs.documentfoundation.org/show_bug.cgi?id=43431 Rainer Bielefeld Retired changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #11 from Rainer Bielefeld Retired --- No longer reproducible at least since LibO Version 4.0.0.3 (Build ID: 7545bee9c2a0782548772a21bc84a9dcc583b89 (WIN 10) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150295] JDBC exception stack trace lost
https://bugs.documentfoundation.org/show_bug.cgi?id=150295 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150305] A marked Fontwork shape is not in 'Current Selection' in Development tools
https://bugs.documentfoundation.org/show_bug.cgi?id=150305 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147613] Table properties dialog: Tab columns does not show more than 4 columns anymore
https://bugs.documentfoundation.org/show_bug.cgi?id=147613 --- Comment #2 from QA Administrators --- Dear info, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150531] Incorrectly rendered SVG images with Skia enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=150531 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150531] Incorrectly rendered SVG images with Skia enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=150531 --- Comment #8 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 125431] An unwanted image appears in exported PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=125431 --- Comment #18 from QA Administrators --- Dear 510jrb2301, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143144] Input list field: Add confirmation dialog in order to prevent loss of data
https://bugs.documentfoundation.org/show_bug.cgi?id=143144 Dieter changed: What|Removed |Added Priority|medium |low -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143144] Input list field: Add confirmation dialog in order to prevent loss of data
https://bugs.documentfoundation.org/show_bug.cgi?id=143144 Dieter changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WONTFIX CC||dgp-m...@gmx.de --- Comment #7 from Dieter --- No further input since more than a year, so nobody suppoted that idea. I agree with Heiko and Buovjaga, that it's not useful to implement every wish. So let's close it as WF. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 142446] In folding outlines, enable specifying, document-wide, the level to which text should be collapsed.
https://bugs.documentfoundation.org/show_bug.cgi?id=142446 Dieter changed: What|Removed |Added Keywords||needsUXEval CC||dgp-m...@gmx.de, ||libreoffice-ux-advise@lists ||.freedesktop.org, ||rayk...@gmail.com --- Comment #2 from Dieter --- Let's ask design-team and Jim Raykowski. cc: Design-Team, Jim Raykowski -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 142446] In folding outlines, enable specifying, document-wide, the level to which text should be collapsed.
https://bugs.documentfoundation.org/show_bug.cgi?id=142446 Dieter changed: What|Removed |Added Keywords||needsUXEval CC||dgp-m...@gmx.de, ||libreoffice-ux-advise@lists ||.freedesktop.org, ||rayk...@gmail.com --- Comment #2 from Dieter --- Let's ask design-team and Jim Raykowski. cc: Design-Team, Jim Raykowski -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150322] EDITING: An ordered list will reset the footnote sequence
https://bugs.documentfoundation.org/show_bug.cgi?id=150322 Dieter changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150322] EDITING: An ordered list will reset the footnote sequence
https://bugs.documentfoundation.org/show_bug.cgi?id=150322 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de --- Comment #1 from Dieter --- Created attachment 181967 --> https://bugs.documentfoundation.org/attachment.cgi?id=181967=edit Sample document I can't confirm it with Version: 7.4.0.3 (x64) / LibreOffice Community Build ID: f85e47c08ddd19c015c0114a68350214f7066f5a CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL Steps 1. Open attached document 2. Mark fourth item -> context menu -> list -> Restart Numbering Actual and expected result No change in footnotes KK, could you please retest with document? => NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103369] [META] Bullet, numbered, and outline list bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103369 Bug 103369 depends on bug 57317, which changed state. Bug 57317 Summary: Writer FILESAVE: bullets list saved as numbered list (in specific ODT) https://bugs.documentfoundation.org/show_bug.cgi?id=57317 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 57317] Writer FILESAVE: bullets list saved as numbered list (in specific ODT)
https://bugs.documentfoundation.org/show_bug.cgi?id=57317 Justin L changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |jl...@mail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 57317] Writer FILESAVE: bullets list saved as numbered list (in specific ODT)
https://bugs.documentfoundation.org/show_bug.cgi?id=57317 --- Comment #10 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/46dc9f3bbac67e9240adc44ab017f905482ef786 tdf#57317 odf export: avoid autolist conflict with NumberingStyles It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 57317] Writer FILESAVE: bullets list saved as numbered list (in specific ODT)
https://bugs.documentfoundation.org/show_bug.cgi?id=57317 Commit Notification changed: What|Removed |Added Whiteboard||target:7.5.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: include/xmloff sw/qa xmloff/source
include/xmloff/xmlnume.hxx|4 --
sw/qa/extras/odfexport/data/tdf57317_autoListName.odt |binary
sw/qa/extras/odfexport/odfexport2.cxx | 31 ++
xmloff/source/style/xmlnume.cxx |9 +
xmloff/source/text/XMLTextListAutoStylePool.cxx | 20 +++
xmloff/source/text/txtstyle.cxx |2 -
6 files changed, 55 insertions(+), 11 deletions(-)
New commits:
commit 46dc9f3bbac67e9240adc44ab017f905482ef786
Author: Justin Luth
AuthorDate: Mon Aug 22 12:52:22 2022 -0400
Commit: Justin Luth
CommitDate: Tue Aug 23 04:09:04 2022 +0200
tdf#57317 odf export: avoid autolist conflict with NumberingStyles
Somehow you can have autoStyles writing into the styles.xml.
Well, the code to prevent duplicates for that needs to exist
for autoStyles written into document.xml as well.
Change-Id: I9602b7023a1ef009ad644374dc5081afb8a76916
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138703
Tested-by: Jenkins
Reviewed-by: Justin Luth
diff --git a/include/xmloff/xmlnume.hxx b/include/xmloff/xmlnume.hxx
index 68818f1076ff..85f78047ee80 100644
--- a/include/xmloff/xmlnume.hxx
+++ b/include/xmloff/xmlnume.hxx
@@ -63,9 +63,7 @@ public:
const css::uno::Reference< css::container::XIndexReplace > &
xNumRule,
bool bOutline=false );
-void exportStyles( bool bUsed,
- XMLTextListAutoStylePool *pPool,
- bool bExportChapterNumbering );
+void exportStyles(bool bUsed, bool bExportChapterNumbering);
void exportNumberingRule(
const OUString& rName, bool bIsHidden,
const css::uno::Reference< css::container::XIndexReplace > &
xNumRule );
diff --git a/sw/qa/extras/odfexport/data/tdf57317_autoListName.odt
b/sw/qa/extras/odfexport/data/tdf57317_autoListName.odt
new file mode 100644
index ..3aafbc519387
Binary files /dev/null and
b/sw/qa/extras/odfexport/data/tdf57317_autoListName.odt differ
diff --git a/sw/qa/extras/odfexport/odfexport2.cxx
b/sw/qa/extras/odfexport/odfexport2.cxx
index 2a2f015f6b84..5d2f91b92d5d 100644
--- a/sw/qa/extras/odfexport/odfexport2.cxx
+++ b/sw/qa/extras/odfexport/odfexport2.cxx
@@ -94,6 +94,37 @@ DECLARE_ODFEXPORT_TEST(testTdf143605, "tdf143605.odt")
CPPUNIT_ASSERT_EQUAL(OUString("."), getProperty(getParagraph(1),
"ListLabelString"));
}
+CPPUNIT_TEST_FIXTURE(Test, testTdf57317_autoListName)
+{
+load(mpTestDocumentPath, "tdf57317_autoListName.odt");
+// The list style (from styles.xml) overrides a duplicate named auto-style
+//uno::Any aNumStyle = getStyles("NumberingStyles")->getByName("L1");
+//CPPUNIT_ASSERT(aNumStyle.hasValue());
+uno::Reference xPara(getParagraph(1), uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(OUString(">1<"), getProperty(xPara,
"ListLabelString"));
+CPPUNIT_ASSERT_EQUAL(OUString("L1"), getProperty(xPara,
"NumberingStyleName"));
+
+dispatchCommand(mxComponent, ".uno:SelectAll", {});
+dispatchCommand(mxComponent, ".uno:DefaultBullet", {});
+
+// This was failing with a duplicate auto numbering style name of L1
instead of a unique name,
+// thus it was showing the same info as before the bullet modification.
+reload(mpFilter, "");
+xPara.set(getParagraph(1), uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(OUString(""), getProperty(xPara,
"ListLabelString"));
+
+uno::Reference
xLevels(xPara->getPropertyValue("NumberingRules"),
+uno::UNO_QUERY);
+uno::Sequence aProps;
+xLevels->getByIndex(0) >>= aProps;
+for (beans::PropertyValue const& rProp : std::as_const(aProps))
+{
+if (rProp.Name == "BulletChar")
+return;
+}
+CPPUNIT_FAIL("no BulletChar property");
+}
+
CPPUNIT_TEST_FIXTURE(Test, testListFormatDocx)
{
loadAndReload("listformat.docx");
diff --git a/xmloff/source/style/xmlnume.cxx b/xmloff/source/style/xmlnume.cxx
index 682fc648af41..9ec9350374db 100644
--- a/xmloff/source/style/xmlnume.cxx
+++ b/xmloff/source/style/xmlnume.cxx
@@ -782,9 +782,7 @@ void SvxXMLNumRuleExport::exportOutline()
}
}
-void SvxXMLNumRuleExport::exportStyles( bool bUsed,
-XMLTextListAutoStylePool *pPool,
-bool bExportChapterNumbering )
+void SvxXMLNumRuleExport::exportStyles( bool bUsed, bool
bExportChapterNumbering )
{
if( bExportChapterNumbering )
exportOutline();
@@ -821,11 +819,8 @@ void SvxXMLNumRuleExport::exportStyles( bool bUsed,
xStyles->getByIndex( i ) >>= xStyle;
if( !bUsed || xStyle->isInUse() )
-{
exportStyle( xStyle );
-if( pPool )
-pPool->RegisterName( xStyle->getName() );
-}
+
}
}
diff --git a/xmloff/source/text/XMLTextListAutoStylePool.cxx
[Libreoffice-bugs] [Bug 150556] New: Libreoffice 7.3.5.2 x64 can't open or save ODS files
https://bugs.documentfoundation.org/show_bug.cgi?id=150556 Bug ID: 150556 Summary: Libreoffice 7.3.5.2 x64 can't open or save ODS files Product: LibreOffice Version: 7.4.0.3 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jer...@creative-afternoon.com Description: Libreoffice 7.3.5.2 x64 problem LO will not start as normal - blank screen with rotating whirligig LO will start in safe mode Writer opens new doc and can save it - also recovers doc at next startup(?) Presentation ditto Drawing ditto Formula does not open and hangs LO Database opens new doc and can save it Spreadsheet opens new doc and can save it but NOT reopen it Tried repair in control panel programs and features - trundled but did not work After repair LO does load and will create ODS file but cannot open one (app hangs) Note the problem with ODS files was happening before I updated to 7.3.5.2 Steps to Reproduce: 1.Start W10 2.Open LibreOffice 3.Open new ODS 4: App hangs and has to be shut down Actual Results: App hangs Expected Results: Calc would fileopen Reproducible: Always User Profile Reset: Yes Additional Info: gerrit.libreoffice.org / core / 184fe81b8c8c30d8b5082578aee2fed2ea847c01 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150555] Crash after resizing Writer's main window
https://bugs.documentfoundation.org/show_bug.cgi?id=150555 Przemas changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |przemaspierw...@gmail.com |desktop.org | --- Comment #1 from Przemas --- Created attachment 181966 --> https://bugs.documentfoundation.org/attachment.cgi?id=181966=edit LO logo after bug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 106306] RTL: Wrong text language detection for punctuation at the beginning of sentence
https://bugs.documentfoundation.org/show_bug.cgi?id=106306 --- Comment #15 from Hossein --- Still reproducible with the latest LO 7.5 master: Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: 947a6455d23bff290319313734c8c30e8f495773 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: fa-IR (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150555] New: Crash after resizing Writer's main window
https://bugs.documentfoundation.org/show_bug.cgi?id=150555 Bug ID: 150555 Summary: Crash after resizing Writer's main window Product: LibreOffice Version: 7.4.0.3 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: przemaspierw...@gmail.com Description: After multiple resizing of the main window painting is distorted. No letters no icons only random points. After that "show" Writer is sometimes crashed. Steps to Reproduce: 1.Run Writer 2.Resize window horizontally and vertically several times 3. Actual Results: no letters no icons even in menu only non-client (term from Win API) elements exist Expected Results: normal rendering client of the window Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.4.0.3 (x64) / LibreOffice Community Build ID: f85e47c08ddd19c015c0114a68350214f7066f5a CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Vulkan; VCL: win Locale: pl-PL (pl_PL); UI: pl-PL Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 91400] LibreOffice doesn’t use system font since OS X 10.10+
https://bugs.documentfoundation.org/show_bug.cgi?id=91400 خالد حسني changed: What|Removed |Added OS|All |macOS (All) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150554] Specific image anchoring properties (alignment & keep text) change when saving file to .docx
https://bugs.documentfoundation.org/show_bug.cgi?id=150554 Dave Seitman changed: What|Removed |Added Keywords||filter:docx -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 52582] Problem with combining unencoded characters in Brahmi Graphite font
https://bugs.documentfoundation.org/show_bug.cgi?id=52582 --- Comment #11 from خالد حسني --- It is been 10 years and these combining marks are included in Unicode 14, so the original issue is no longer reproducible. I think I know what was breaking the encoded combining marks, though, so if you can make a different test with characters that are still unencoded, I might be able to finally fix it. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150554] Specific image anchoring properties (alignment & keep text) change when saving file to .docx
https://bugs.documentfoundation.org/show_bug.cgi?id=150554 --- Comment #5 from Dave Seitman --- Created attachment 181965 --> https://bugs.documentfoundation.org/attachment.cgi?id=181965=edit screenshot of document page showing image locations changed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150554] Specific image anchoring properties (alignment & keep text) change when saving file to .docx
https://bugs.documentfoundation.org/show_bug.cgi?id=150554 --- Comment #4 from Dave Seitman --- Created attachment 181964 --> https://bugs.documentfoundation.org/attachment.cgi?id=181964=edit screenshot to show correct placement of images -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150554] Specific image anchoring properties (alignment & keep text) change when saving file to .docx
https://bugs.documentfoundation.org/show_bug.cgi?id=150554 --- Comment #3 from Dave Seitman --- Created attachment 181963 --> https://bugs.documentfoundation.org/attachment.cgi?id=181963=edit File I was working with - properties changed when previously saved -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150554] Specific image anchoring properties (alignment & keep text) change when saving file to .docx
https://bugs.documentfoundation.org/show_bug.cgi?id=150554 --- Comment #2 from Dave Seitman --- Created attachment 181962 --> https://bugs.documentfoundation.org/attachment.cgi?id=181962=edit File with properties altered after conversion from .odt to .docx -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150554] Specific image anchoring properties (alignment & keep text) change when saving file to .docx
https://bugs.documentfoundation.org/show_bug.cgi?id=150554 --- Comment #1 from Dave Seitman --- Created attachment 181961 --> https://bugs.documentfoundation.org/attachment.cgi?id=181961=edit File with "correct" image placement properties -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103729] [META] HarfBuzz-based common text layout regressions
https://bugs.documentfoundation.org/show_bug.cgi?id=103729 Bug 103729 depends on bug 119342, which changed state. Bug 119342 Summary: EDITING: Pasted HTML table into Calc can't optimize width https://bugs.documentfoundation.org/show_bug.cgi?id=119342 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 119342] EDITING: Pasted HTML table into Calc can't optimize width
https://bugs.documentfoundation.org/show_bug.cgi?id=119342 خالد حسني changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150167] createUnoService returns wrong type for CharacterProperties and ParagraphProperties
https://bugs.documentfoundation.org/show_bug.cgi?id=150167 Maxim Monastirsky changed: What|Removed |Added CC||momonas...@gmail.com --- Comment #8 from Maxim Monastirsky --- The term "service" used here is a bit misleading. There is no such thing as a "ParagraphProperties service" that you can instantiate. ParagraphProperties is just a *specification* that can be implemented by different components (like paragraphs, cells etc.). That means that if such "service" references some interfaces or properties, you can expect them to be present in components that claim to implement this service (among others). That's it. Regarding createUnoService, I believe it just picks a random component whose entry in a .component file has that service listed. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 83066] [META] CJK (Chinese, Japanese, Korean, and Vietnamese) language issues
https://bugs.documentfoundation.org/show_bug.cgi?id=83066 Bug 83066 depends on bug 114272, which changed state. Bug 114272 Summary: [macOS] Some Asian characters are garbled with western fonts. https://bugs.documentfoundation.org/show_bug.cgi?id=114272 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=71732 Bug 71732 depends on bug 114272, which changed state. Bug 114272 Summary: [macOS] Some Asian characters are garbled with western fonts. https://bugs.documentfoundation.org/show_bug.cgi?id=114272 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 114272] [macOS] Some Asian characters are garbled with western fonts.
https://bugs.documentfoundation.org/show_bug.cgi?id=114272 خالد حسني changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #22 from خالد حسني --- Can’t reproduce this with 7.3.5 on macOS. Please reopen if still reproducible on recent LibreOffice. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142020] Cannot combine ï with a dot below in most of the fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=142020 خالد حسني changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |NOTOURBUG --- Comment #13 from خالد حسني --- It is up to the fonts to handle such combining marks, we have no say on this. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=71732 Bug 71732 depends on bug 142020, which changed state. Bug 142020 Summary: Cannot combine ï with a dot below in most of the fonts https://bugs.documentfoundation.org/show_bug.cgi?id=142020 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |NOTOURBUG -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150280] After pasting image 3x, save, close and reopen, middle Image not appearing
https://bugs.documentfoundation.org/show_bug.cgi?id=150280 Scott Clewell changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED Summary|Image not appearing |After pasting image 3x, ||save, close and reopen, ||middle Image not appearing --- Comment #8 from Scott Clewell --- I understand. I've added more of your details in the bug summary and placed this back to "UNCONFIRMED" so others may help out. Thank you -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150167] createUnoService returns wrong type for CharacterProperties and ParagraphProperties
https://bugs.documentfoundation.org/show_bug.cgi?id=150167 --- Comment #7 from eseb63 --- maybe, but "why the createUnoService does not return the good service" is a question for the support team i think ? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 127066] UI: Font size in input line (formular bar) larger than in other UI elements
https://bugs.documentfoundation.org/show_bug.cgi?id=127066 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||0552 -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 101646] UI option "Scaling" was removed
https://bugs.documentfoundation.org/show_bug.cgi?id=101646 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||0552 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150552] UI fonts rendered too small on high resolution retina displays using macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=150552 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||1646, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||7066 --- Comment #3 from V Stuart Foote --- Reasonable, but hope we don't have a repeat of bug 127066, but probably not since in the interim the inputlince has been welded. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150553] EDITING: Text corruption when editing text field containing specific characters
https://bugs.documentfoundation.org/show_bug.cgi?id=150553 --- Comment #2 from Eric Lasota --- Forgot to mention: This does not happen if I press the left or right arrow keys to move the editing carat before step 7. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150553] EDITING: Text corruption when editing text field containing specific characters
https://bugs.documentfoundation.org/show_bug.cgi?id=150553 --- Comment #1 from Eric Lasota --- Created attachment 181960 --> https://bugs.documentfoundation.org/attachment.cgi?id=181960=edit Test document -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150553] New: EDITING: Text corruption when editing text field containing specific characters
https://bugs.documentfoundation.org/show_bug.cgi?id=150553 Bug ID: 150553 Summary: EDITING: Text corruption when editing text field containing specific characters Product: LibreOffice Version: 7.4.0.3 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ejlas...@gmail.com Description: Double-clicking a text cell to edit it may put the character in some kind of invalid "mid-character" position that corrupts the text. See reproduction steps. Steps to Reproduce: 1. Install LibreOffice 7.4.0.3 on Windows. 2. Open the attached CSV. It contains 1 cel with 6 consecutive musical note characters. 3. In the import dialog, ensure the character set is set to UTF-8 4. Notice that the cell preview displays the content incorrectly at this step. 5. Click OK 6. Double-click in cell A1 anywhere between two of the note characters. 7. Press the "a" key Actual Results: The character preceding the editing carat is replaced with 2 damaged characters and an "a" character between them. Additionally, the cell edit box above the spreadsheet will no longer match the cell contents. Expected Results: The "a" character should be inserted between the note characters where the editing carat indicates. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: Version: 7.4.0.3 (x64) / LibreOffice Community Build ID: f85e47c08ddd19c015c0114a68350214f7066f5a CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150550] After drawing a shape, the shape tool should be unselected from the sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=150550 --- Comment #2 from Maxim Monastirsky --- (In reply to Rafael Lima from comment #1) > If you click the tool twice, it will remain enabled and you can > draw as many instances of the same shape as you like. > > Is this indeed a feature? Yes. > I could not find documentation for it. Seems to be documented at https://help.libreoffice.org/latest/en-US/text/simpress/main0210.html > [1] https://help.libreoffice.org/latest/en-US/text/shared/02/0114.html That page seems to be for Writer and Calc only. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150552] UI fonts rendered too small on high resolution retina displays using macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=150552 --- Comment #2 from Thorsten Wagner --- Created attachment 181959 --> https://bugs.documentfoundation.org/attachment.cgi?id=181959=edit Screenshot 2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150552] UI fonts rendered too small on high resolution retina displays using macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=150552 --- Comment #1 from Thorsten Wagner --- Created attachment 181958 --> https://bugs.documentfoundation.org/attachment.cgi?id=181958=edit Screenshot 1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150552] New: UI fonts rendered too small on high resolution retina displays using macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=150552 Bug ID: 150552 Summary: UI fonts rendered too small on high resolution retina displays using macOS Product: LibreOffice Version: 7.5.0.0 alpha0+ Master Hardware: All OS: macOS (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: thorsten.wagne...@gmail.com Description: UI fonts are rendered too small on laptop retina displays with native resolution greater than 220 ppi (see screenshot 1, red boxes). Font rendering within document area is ok, because these fonts have to be rendered at their physical extent and independent from display resolution. For better readability UI font rendering should be like in screenshot 2, red boxes with larger fonts similar to font rendering on external displays. Steps to Reproduce: 1. Open any LO application like Writer, Calc, Impress, Draw 2. Look at statusbar or sidebar Actual Results: UI fonts are rendered too small on displays with native resolution greater than 220 ppi (see screenshot 1, red boxes). Expected Results: UI fonts should be rendered larger and as large as on external displays or on displays with native resolution less or equal than 220 ppi (see screenshot 2, red boxese). Reproducible: Always User Profile Reset: No Additional Info: I will provide a patch resulting in screenshot 2 in short. Reason is VCL font handling for UI fonts using integer values in points (pt). Due to a rounding issue, fonts are rendered using a smaller height after recalculation of font height for display resolution. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150547] Unusable documentation for scripting
https://bugs.documentfoundation.org/show_bug.cgi?id=150547 --- Comment #1 from Rafael Lima --- Documentation about scripting in Basic/Python has improved significantly in recent years, but still documenting the entire API is a daunting task. TBH it's unrealistic that we'll have help pages and examples for every method available in the API. If you want to write scripts using Basic, I recommend you check out Pitonyak's book, which is a wonderful learning resource. https://www.pitonyak.org/oo.php If you want to write Calc scripts, I also recommend checking out the Calc service of the ScriptForge library (which is thoroughly documented): https://help.libreoffice.org/latest/en-US/text/sbasic/shared/03/sf_calc.html Finally, if you run into issues to which you cannot find an answer, post a question at: https://ask.libreoffice.org/ There are a lot of knowledgeable people willing to help with scripting questions. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150551] Exporting shape with gradient fill as PDF results in wrong output
https://bugs.documentfoundation.org/show_bug.cgi?id=150551 Rafael Lima changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||0545 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150545] Incorrect handling of "Automatic" increment in gradient fill
https://bugs.documentfoundation.org/show_bug.cgi?id=150545 Rafael Lima changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||0551 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150551] New: Exporting shape with gradient fill as PDF results in wrong output
https://bugs.documentfoundation.org/show_bug.cgi?id=150551 Bug ID: 150551 Summary: Exporting shape with gradient fill as PDF results in wrong output Product: LibreOffice Version: 7.3.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rafael.palma.l...@gmail.com Created attachment 181956 --> https://bugs.documentfoundation.org/attachment.cgi?id=181956=edit Screenshot showing the problem Export of shapes with gradient fill to PDF does not seem to work. Steps to reproduce: 1) Create a blank presentation; insert a single shape to the slide 2) Right-click the shape - Area 3) Select "Gradient"; Type "Radial"; Increment "Automatic"; Center X/Y: 50% for both; From color "Dark Blue 1"; To color "Dark Blue 3" (other colors show the same behavior) 4) Click OK; notice that the gradient will look fine in Impress 5) Export to PDF; open the PDF file and notice that the gradient was not exported correctly See attached image comparing what I see in Impress and what I get as the PDF output. This bug is probably related to bug 150545. System info Version: 7.3.5.2 / LibreOffice Community Build ID: 30(Build:2) CPU threads: 12; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Ubuntu package version: 1:7.3.5-0ubuntu0.22.04.1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/qa
sc/qa/uitest/inputLine/tdf131326.py |4 +++-
sc/qa/uitest/inputLine/tdf54197.py |2 ++
sc/qa/uitest/inputLine/tdf67346.py |2 ++
3 files changed, 7 insertions(+), 1 deletion(-)
New commits:
commit 3cc6b870c48b23418f65d2c3cd6eab72ef0680de
Author: Caolán McNamara
AuthorDate: Mon Aug 22 20:21:39 2022 +0100
Commit: Caolán McNamara
CommitDate: Mon Aug 22 22:30:01 2022 +0200
make an effort to fix the UITest_inputLine intermittent failure
debugging what normally happens I see that the EditEngine belonging to
this inputbar widget is thrown away by calc when the content of the cell
changes and is only recreated on the next "Paint" of the inputbar.
It's plausible that throwing processEventsToIdle at the problem solves
this.
Change-Id: I620bae9eb87b2ff91755da9b8d7821791f0e4240
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138708
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/sc/qa/uitest/inputLine/tdf131326.py
b/sc/qa/uitest/inputLine/tdf131326.py
index 6fbfe25f02bd..90809ab42c79 100755
--- a/sc/qa/uitest/inputLine/tdf131326.py
+++ b/sc/qa/uitest/inputLine/tdf131326.py
@@ -17,10 +17,12 @@ class tdf131326(UITestCase):
with self.ui_test.create_doc_in_start_center("calc"):
xCalcDoc = self.xUITest.getTopFocusWindow()
gridwin = xCalcDoc.getChild("grid_window")
-xInputWin = xCalcDoc.getChild("sc_input_window")
enter_text_to_cell(gridwin, "A1", "=1")
self.xUITest.executeCommand(".uno:ConvertFormulaToValue")
+xToolkit =
self.xContext.ServiceManager.createInstance('com.sun.star.awt.Toolkit')
+xToolkit.processEventsToIdle()
+xInputWin = xCalcDoc.getChild("sc_input_window")
self.assertEqual(get_state_as_dict(xInputWin)["Text"], "1")
# vim: set shiftwidth=4 softtabstop=4 expandtab:
diff --git a/sc/qa/uitest/inputLine/tdf54197.py
b/sc/qa/uitest/inputLine/tdf54197.py
index ba86982d91ca..a7a82d5c338f 100644
--- a/sc/qa/uitest/inputLine/tdf54197.py
+++ b/sc/qa/uitest/inputLine/tdf54197.py
@@ -29,6 +29,8 @@ class tdf54197(UITestCase):
# The same text as above is displayed at cell A2, BUT input line
is still blank
self.assertEqual(get_cell_by_position(document, 0, 0,
0).getString(), "t")
self.assertEqual(get_cell_by_position(document, 0, 0,
1).getString(), "t")
+xToolkit =
self.xContext.ServiceManager.createInstance('com.sun.star.awt.Toolkit')
+xToolkit.processEventsToIdle()
xInputWin = xCalcDoc.getChild("sc_input_window")
self.assertEqual(get_state_as_dict(xInputWin)["Text"], "t")
diff --git a/sc/qa/uitest/inputLine/tdf67346.py
b/sc/qa/uitest/inputLine/tdf67346.py
index 5d5ff32cefb5..cc9dc14d628c 100644
--- a/sc/qa/uitest/inputLine/tdf67346.py
+++ b/sc/qa/uitest/inputLine/tdf67346.py
@@ -26,6 +26,8 @@ class tdf67346(UITestCase):
# Move focus to input window and copy the text from there
gridwin.executeAction("TYPE",
mkPropertyValues({"KEYCODE":"CTRL+SHIFT+F2"}))
+xToolkit =
self.xContext.ServiceManager.createInstance('com.sun.star.awt.Toolkit')
+xToolkit.processEventsToIdle()
xInputWin = xCalcDoc.getChild("sc_input_window")
self.assertEqual('true', get_state_as_dict(xInputWin)["HasFocus"])
[Libreoffice-bugs] [Bug 150550] After drawing a shape, the shape tool should be unselected from the sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=150550 --- Comment #1 from Rafael Lima --- By the way, while testing this bug I came across a (possibly undocumented) feature. If you click the tool twice, it will remain enabled and you can draw as many instances of the same shape as you like. In such case, the highlight should remain visible. Is this indeed a feature? I could not find documentation for it. If it is indeed a feature, it should be documented in the help [1] via a tip or note. [1] https://help.libreoffice.org/latest/en-US/text/shared/02/0114.html -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150550] New: After drawing a shape, the shape tool should be unselected from the sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=150550 Bug ID: 150550 Summary: After drawing a shape, the shape tool should be unselected from the sidebar Product: LibreOffice Version: 7.3.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rafael.palma.l...@gmail.com Created attachment 181955 --> https://bugs.documentfoundation.org/attachment.cgi?id=181955=edit Video showing the problem After drawing a shape in Impress the shape tool should no longer be selected (highlighted) because it is no longer enabled. See attached video for more information. Steps to reproduce: 1) Create a new Impress document 2) Open the "Shapes" sidebar 3) Click once in any of the shapes and draw it onto the canvas 4) Right after finishing to draw it, try to draw again; notice that it wont draw a new shape, hence the tool should no longer be highlighted The expected behavior would be to automatically remove the tool highlight from the sidebar after finishing drawing the shape. System info Version: 7.3.5.2 / LibreOffice Community Build ID: 30(Build:2) CPU threads: 12; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Ubuntu package version: 1:7.3.5-0ubuntu0.22.04.1 Calc: threaded Also repro in Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: 641d92a73e5b3d0e062e16ed4b42236e1a4796a5 CPU threads: 12; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/source
sc/source/ui/navipi/navipi.cxx | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
New commits:
commit 6b68ac7d989dd34071c12ee64fe7c4cb99e37c09
Author: Caolán McNamara
AuthorDate: Mon Aug 22 16:38:01 2022 +0100
Commit: Caolán McNamara
CommitDate: Mon Aug 22 21:52:50 2022 +0200
cid#1509273 Unchecked dynamic_cast
get ScDocument the way the rest of ScNavigatorDlg does
Change-Id: Ib1e66a48cc385ac1ad479e8e3b6efa04349116e6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138706
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sc/source/ui/navipi/navipi.cxx b/sc/source/ui/navipi/navipi.cxx
index 44ba8fee2c26..6340c1a80f33 100644
--- a/sc/source/ui/navipi/navipi.cxx
+++ b/sc/source/ui/navipi/navipi.cxx
@@ -126,23 +126,22 @@ namespace
IMPL_LINK(ScNavigatorDlg, ParseRowInputHdl, int*, result, bool)
{
-SCCOL nCol;
+SCCOL nCol(0);
OUString aStrCol = m_xEdCol->get_text();
if (!aStrCol.isEmpty())
{
-// nKeyGroup is no longer set at VCL, in cause of lack of keyinput
+if (ScViewData* pData = GetViewData())
+{
+ScDocument& rDoc = pData->GetDocument();
-ScTabViewShell* pViewSh = dynamic_cast(
SfxViewShell::Current() );
-auto& rDoc = pViewSh->GetViewData().GetDocument();
-if ( CharClass::isAsciiNumeric(aStrCol) )
-nCol = NumStrToAlpha( rDoc.GetSheetLimits(), aStrCol );
-else
-nCol = AlphaToNum( rDoc, aStrCol );
+if ( CharClass::isAsciiNumeric(aStrCol) )
+nCol = NumStrToAlpha( rDoc.GetSheetLimits(), aStrCol );
+else
+nCol = AlphaToNum( rDoc, aStrCol );
+}
}
-else
-nCol = 0;
*result = nCol;
return true;
[Libreoffice-bugs] [Bug 150549] Libreoffice leaves "zombie process" running after closing any LibreOffice component, preventing new components from opening
https://bugs.documentfoundation.org/show_bug.cgi?id=150549 --- Comment #2 from Dan --- Okay... after some more investigation, although safemode crashes for whatever reason, running with " soffice.com -env:UserInstallation=file:///c:/my-test-profile" yields the expected result and renaming my actual profile so the lo creates a new profile, does fix the issue. so it looks like "corrupt user profile" is to blame for this issue. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: formula/source
formula/source/core/api/FormulaCompiler.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit cd816c0b4e698386a482f20c975281a0f3a7d332 Author: Caolán McNamara AuthorDate: Mon Aug 22 16:21:21 2022 +0100 Commit: Caolán McNamara CommitDate: Mon Aug 22 21:23:50 2022 +0200 cid#1509296 silence Use after free Change-Id: I6c1d8c0365cb59f3c63537c08e27a34bac111aaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138705 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/formula/source/core/api/FormulaCompiler.cxx b/formula/source/core/api/FormulaCompiler.cxx index 591b28744289..55e65ae9fd7c 100644 --- a/formula/source/core/api/FormulaCompiler.cxx +++ b/formula/source/core/api/FormulaCompiler.cxx @@ -2053,6 +2053,7 @@ void FormulaCompiler::IntersectionLine() FormulaTokenRef pIntersect( new FormulaByteToken( ocIntersect)); // Replace ocSpaces with ocIntersect so that when switching // formula syntax the correct operator string is created. +// coverity[freed_arg : FALSE] - FormulaTokenRef has a ref so ReplaceToken won't delete pIntersect pArr->ReplaceToken( nCodeIndex, pIntersect.get(), FormulaTokenArray::ReplaceMode::CODE_ONLY); PutCode( pIntersect); }
[Libreoffice-bugs] [Bug 150549] Libreoffice leaves "zombie process" running after closing any LibreOffice component, preventing new components from opening
https://bugs.documentfoundation.org/show_bug.cgi?id=150549 --- Comment #1 from Dan --- In case the "Safe-mode" crashing is related, here is the event log export for that crash. Faulting application name: soffice.bin, version: 7.4.0.3, time stamp: 0x62f401e3 Faulting module name: ucrtbase.dll, version: 10.0.22621.436, time stamp: 0xf5fc15a3 Exception code: 0xc409 Fault offset: 0x0007f61e Faulting process id: 0x0x22A4 Faulting application start time: 0x0x1D8B659A5ECE055 Faulting application path: C:\Program Files\LibreOffice\program\soffice.bin Faulting module path: C:\WINDOWS\System32\ucrtbase.dll Report Id: c27f6d3d-33ac-4b0b-be9b-57e646074662 Faulting package full name: Faulting package-relative application ID: -- You are receiving this mail because: You are the assignee for the bug.
Fwd: [core] tdf#148251 Use std::swap instead of using temporary values
Which reviewer should I add to merge this patch? https://gerrit.libreoffice.org/c/core/+/138256 -- Forwarded message - 发件人： Paris Oplopoios (via Code Review) Date: 2022年8月23日周二 00:30 Subject: [core] tdf#148251 Use std::swap instead of using temporary values To: Hao Liu Attention is currently required from: Hao Liu. Paris Oplopoios has posted comments on this change. ( https://gerrit.libreoffice.org/c/core/+/138256 ) Change subject: tdf#148251 Use std::swap instead of using temporary values .. Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: Looks good to me but don't have merge privileges so you're gonna have to find a different reviewer -- To view, visit https://gerrit.libreoffice.org/c/core/+/138256 To unsubscribe, or for help writing mail filters, visit https://gerrit.libreoffice.org/settings Gerrit-Project: core Gerrit-Branch: master Gerrit-Change-Id: Ibbc46bfb17d4d27dc40e63c65190b3f3a5f2d9c4 Gerrit-Change-Number: 138256 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Liu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Paris Oplopoios Gerrit-Attention: Hao Liu Gerrit-Comment-Date: Mon, 22 Aug 2022 16:29:47 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[Libreoffice-bugs] [Bug 150531] Incorrectly rendered SVG images with Skia enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=150531 --- Comment #7 from gibt...@gmx.de --- Sorry, forgot to add in my last comment: Switching the different Skia options does not change anything, the effect is the same. Currently, the issue is mostly visible in the full screen mode of Impress, i.e. it is actually impossible to compare this to Draw. Still, I will perform further tests to reproduce the issue in editing mode and compare this to Draw. If I succeed in reproducing the issue with Draw, I will add another comment. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150549] New: Libreoffice leaves "zombie process" running after closing any LibreOffice component, preventing new components from opening
https://bugs.documentfoundation.org/show_bug.cgi?id=150549 Bug ID: 150549 Summary: Libreoffice leaves "zombie process" running after closing any LibreOffice component, preventing new components from opening Product: LibreOffice Version: 7.4.0.3 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: d...@leeprecision.com Description: I can open a LibreOffice component, calc or writer, then close it (using [CTRL + W] or the generic close button in the top right) and a "Zombie" LibreOffice process is opened and does not close, as well as the original LibreOffice and Calc processes staying alive. This new "Zombie" process consumes an odd amount of CPU resources, anywhere from 5%-15% of CPU, and ~115MB of RAM, while the original LibreOffice process consumes exactly 0 CPU and 0.9MB RAM, and the original Calc process consumes 0% CPU and 0.5MB of RAM. The "Zombie" process will run forever, bouncing between 5%-15% CPU utilization while i keep it alive. It can only be killed with the task manager, and once this process is killed, the other two original processes also close. While the zombie process is alive, no new LibreOffice processes are allowed to open, of any kind. They will "start" and can be seen in the Task manager, but will not actually open the UI until the zombie process is killed. This bug occurs in both windows 10 and 11 environments and on several different machines. I experienced it in 7.2, 7.3 and now in 7.4. If I can provide some debug report from LibreOffice, let me know. However, it does not occur on ALL of my machine running LibreOffice. It seems that at some point something in the config gets corrupt or something and then it occurs every time LibreOffice is run. Steps to Reproduce: 1. Open any LibreOffice component. 2. Close same component. Actual Results: New zombie process started and original processes still running, no new components are allowed to be started. Expected Results: Application closes completely. New components are able to be opened without issue. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: Version: 7.4.0.3 (x64) / LibreOffice Community Build ID: f85e47c08ddd19c015c0114a68350214f7066f5a CPU threads: 12; OS: Windows 10.0 Build 22622; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL Tried launching in safe mode. In safe mode, the application starts and crashes...so it made it worse. Disabling safe mode allows application to start. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 128801] switching from 4:3 to 16:9 aspect ratio warps images and formulas
https://bugs.documentfoundation.org/show_bug.cgi?id=128801 --- Comment #5 from Faisal --- Still reproducible with Version: 7.3.5.2 / LibreOffice Community Build ID: 30(Build:2) CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: en-US (en_US); UI: en-US 7.3.5-3 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135569] FILEOPEN DOCX Inner margins are rotated with textbox
https://bugs.documentfoundation.org/show_bug.cgi?id=135569 --- Comment #9 from Commit Notification --- Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/9ad83843742354312cd543bfbed286c9f52baf1a crashtesting: fix DOCX export of tdf135569-1.docx It will be available in 7.4.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135569] FILEOPEN DOCX Inner margins are rotated with textbox
https://bugs.documentfoundation.org/show_bug.cgi?id=135569 Commit Notification changed: What|Removed |Added Whiteboard|target:7.5.0|target:7.5.0 target:7.4.1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150531] Incorrectly rendered SVG images with Skia enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=150531 --- Comment #6 from V Stuart Foote --- (In reply to Gibtnix from comment #5) >... > Hope this helps. Thanks for responding and let me know in case you need any > further information. Yes thank you. And just to clarify--the bad SVG rendering is with Vulkan accelerated rendering, or *also* occurs with Skia software rendering? And, is this only with Impress? Or are the other modules also affected--Draw, Writer, or Calc? Thanks! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sw/qa
sw/qa/extras/ooxmlexport/data/content-control-shape.docx |binary
sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx| 12
2 files changed, 12 insertions(+)
New commits:
commit 9ad83843742354312cd543bfbed286c9f52baf1a
Author: Miklos Vajna
AuthorDate: Mon Aug 22 14:37:56 2022 +0200
Commit: Xisco Fauli
CommitDate: Mon Aug 22 21:00:46 2022 +0200
crashtesting: fix DOCX export of tdf135569-1.docx
This went wrong in commit 9700c1b2170ad04453a361ed5647937833ac3c18 (sw
content controls, plain text: add DOCX import, 2022-07-25), which
conditionally disabled the DOCX export of content control starts.
The trouble is that the matching content control end is still written
unconditionally, leading to a not-well-formed XML output.
Reading the commit message, the motivation for the conditional start was
testSdtAndShapeOverlapping in CppunitTest_sw_ooxmlexport7, but it seems
that is no longer necessary since we try it harder to not pollute the
doc model with never-read grab-bags in commit
7ad44f3dd271a591529b048212c4391d8b38ed9d (crashtesting: fix DOCX export
of forum-mso-de-99522.docx, 2022-08-16).
Fix the problem by just reverting the problematic hunk, seeing it's no
longer needed for the testSdtAndShapeOverlapping scenario and it causes
a problem here.
Change-Id: I5cc94ee00dfdf55de1fffe1c28242388549862ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138685
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
(cherry picked from commit 223a43537559efc96b4b5bca32d93211ed849ae5)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138544
Reviewed-by: Xisco Fauli
diff --git a/sw/qa/extras/ooxmlexport/data/content-control-shape.docx
b/sw/qa/extras/ooxmlexport/data/content-control-shape.docx
new file mode 100644
index ..ab5be6cb694a
Binary files /dev/null and
b/sw/qa/extras/ooxmlexport/data/content-control-shape.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx
b/sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx
index d624a2de0469..952f397e5cf6 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx
@@ -881,6 +881,18 @@ CPPUNIT_TEST_FIXTURE(Test, testContentControlGrabBag)
save("Office Open XML Text", maTempFile);
}
+CPPUNIT_TEST_FIXTURE(Test, testContentControlShape)
+{
+// Given a document with a tag:
+OUString aURL = m_directories.getURLFromSrc(DATA_DIRECTORY) +
"content-control-shape.docx";
+loadURL(aURL, nullptr);
+
+// When exporting that document back to DOCX:
+// Then make sure that completes without an assertion failure, which would
mean not-well-formed
+// output was produced, since the was conditional but the
was unconditional:
+save("Office Open XML Text", maTempFile);
+}
+
CPPUNIT_TEST_FIXTURE(Test, testTdf104823)
{
// Test how we can roundtrip sdt plain text with databindings support
[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=71732 Bug 71732 depends on bug 150507, which changed state. Bug 150507 Summary: VIEWING: Text in Writer 7.4.0 appears smeared https://bugs.documentfoundation.org/show_bug.cgi?id=150507 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150515] Document font rendering looks (very) ugly but fine when placed in text boxes
https://bugs.documentfoundation.org/show_bug.cgi?id=150515 Timur changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #6 from Timur --- please see if a duplicate of bug 150507. There was a fix trial there today so please test daily master with that fix. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: 2 commits - svx/source unotools/source
svx/source/tbxctrls/tbcontrl.cxx |3 +++
unotools/source/i18n/localedatawrapper.cxx | 20 +++-
2 files changed, 10 insertions(+), 13 deletions(-)
New commits:
commit 37494dc5457f5feb44465d2eb508a5f77fec74cd
Author: Caolán McNamara
AuthorDate: Mon Aug 22 14:44:43 2022 +0100
Commit: Caolán McNamara
CommitDate: Mon Aug 22 20:30:32 2022 +0200
I see this empty entry for the separator in the styles dropdown
Change-Id: I0c0787f893e50ea32b3dc7bf4356b4603d8f8cdd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138689
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/svx/source/tbxctrls/tbcontrl.cxx b/svx/source/tbxctrls/tbcontrl.cxx
index 610bb630e55e..db147949c306 100644
--- a/svx/source/tbxctrls/tbcontrl.cxx
+++ b/svx/source/tbxctrls/tbcontrl.cxx
@@ -1575,6 +1575,9 @@ void
SvxStyleBox_Base::CalcOptimalExtraUserWidth(vcl::RenderContext& rRenderCont
{
OUString sStyleName(get_text(i));
+if (sStyleName.isEmpty())
+continue;
+
rRenderContext.Push(vcl::PushFlags::FILLCOLOR | vcl::PushFlags::FONT |
vcl::PushFlags::TEXTCOLOR);
SetupEntry(rRenderContext, i, tools::Rectangle(0, 0, RECT_MAX,
ITEM_HEIGHT), sStyleName, true);
auto aScriptChanges = CheckScript(sStyleName);
commit b759f6720b50487200740a6202e21774897b44b2
Author: Eike Rathke
AuthorDate: Mon Aug 22 16:16:08 2022 +0200
Commit: Eike Rathke
CommitDate: Mon Aug 22 20:30:20 2022 +0200
Resolves: tdf#150288 Do not prepend the locale's full date acceptance
pattern
... if it wasn't present as first, but take the date acceptance
patterns as specified by the user.
Change-Id: Ife2fd39731bac0e0b121f22392f22b48ffc9c978
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138694
Reviewed-by: Eike Rathke
Tested-by: Jenkins
diff --git a/unotools/source/i18n/localedatawrapper.cxx
b/unotools/source/i18n/localedatawrapper.cxx
index 54aa49f44877..9e6fe8990979 100644
--- a/unotools/source/i18n/localedatawrapper.cxx
+++ b/unotools/source/i18n/localedatawrapper.cxx
@@ -1550,19 +1550,13 @@ void LocaleDataWrapper::loadDateAcceptancePatterns(
}
}
-// Never overwrite the locale's full date pattern! The first.
-if (std::as_const(aDateAcceptancePatterns)[0] == rPatterns[0])
-aDateAcceptancePatterns = comphelper::containerToSequence(rPatterns);
// sane
-else
-{
-// Copy existing full date pattern and append the sequence passed.
-/* TODO: could check for duplicates and shrink target sequence */
-Sequence< OUString > aTmp( rPatterns.size() + 1 );
-auto it = aTmp.getArray();
-*it = std::as_const(aDateAcceptancePatterns)[0];
-std::copy(rPatterns.begin(), rPatterns.end(), std::next(it));
-aDateAcceptancePatterns = aTmp;
-}
+// Earlier versions checked for presence of the full date pattern with
+// aDateAcceptancePatterns[0] == rPatterns[0] and prepended that if not.
+// This lead to confusion if the patterns were intentionally specified
+// without, giving entirely a different DMY order, see tdf#150288.
+// Not checking this and accepting the given patterns as is may result in
+// the user shooting themself in the foot, but we can't have both.
+aDateAcceptancePatterns = comphelper::containerToSequence(rPatterns);
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
[Libreoffice-bugs] [Bug 149506] Slow start-up and opening of files since 7.3 release
https://bugs.documentfoundation.org/show_bug.cgi?id=149506 --- Comment #9 from Timur --- Please turn off proxy, to check if bug 135754. Joe, please see Ubuntu bug 150479. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143651] Calc fails to fill-in default value from prior rows
https://bugs.documentfoundation.org/show_bug.cgi?id=143651 Buovjaga changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150531] Incorrectly rendered SVG images with Skia enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=150531 --- Comment #5 from gibt...@gmx.de --- Thanks for the clarification. I did not know that there is a significant difference in using the force skia for rendering checkbox. I unchecked it and the skia.log now contains the following content: RenderMethod: vulkan Vendor: 0x8086 Device: 0x9b41 API: 1.2.196 Driver: 0.404.1122 DeviceType: integrated DeviceName: Intel(R) UHD Graphics Denylisted: no Hope this helps. Thanks for responding and let me know in case you need any further information. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148311] calc . REQUEST for Copy & Past configurability
https://bugs.documentfoundation.org/show_bug.cgi?id=148311 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Resolution|--- |WORKSFORME Status|UNCONFIRMED |RESOLVED --- Comment #6 from Roman Kuznetsov <79045_79...@mail.ru> --- So, Karl, I close your bug report as WORKSFORME then. If you have some ideas to improve the dialog or other any things in LibreOffice, just file another report. But please file one report per problem. Thank you -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: chart2/qa chart2/source
chart2/qa/extras/chart2import2.cxx
| 16 ++
chart2/qa/extras/data/xlsx/DataTable-MultipleLegendEntriesForOneDataSeries.xlsx
|binary
chart2/source/view/charttypes/VSeriesPlotter.cxx
| 78 --
chart2/source/view/main/DataTableView.cxx
| 26 +--
4 files changed, 38 insertions(+), 82 deletions(-)
New commits:
commit e5583150a3953f08782865e0f90d41f5c35cc6c5
Author: Tomaž Vajngerl
AuthorDate: Mon Aug 22 16:46:41 2022 +0200
Commit: Tomaž Vajngerl
CommitDate: Mon Aug 22 19:50:28 2022 +0200
chart2: always use the series for the keys (symbols) in data table
In special case the legend keys are not series, but can be each
value of a series. This can't be done for the data table where so
this has been disabled.
This caused a crash when positioning the symbols, as in some cases
we got 0 symbols (due to another bug that didn't put the symbols
into the collection) or more symbols that there were series (and
the symbols couldn't be positioned correctly). With this change
we now get the correct number of symbols for the data table.
Also added the test document and test to open the document, to
make sure we don't crash anymore.
Change-Id: Idbebdd5295595a823b5420958e803b13258df035
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138697
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/chart2/qa/extras/chart2import2.cxx
b/chart2/qa/extras/chart2import2.cxx
index eb983f7687f1..81e274400c67 100644
--- a/chart2/qa/extras/chart2import2.cxx
+++ b/chart2/qa/extras/chart2import2.cxx
@@ -61,6 +61,7 @@ public:
void testTdf139658();
void testTdf146066();
void testTdf150434();
+void testChartDataTableWithMultipleLegendEntriesForOneDataSeries();
CPPUNIT_TEST_SUITE(Chart2ImportTest2);
@@ -103,6 +104,7 @@ public:
CPPUNIT_TEST(testTdf139658);
CPPUNIT_TEST(testTdf146066);
CPPUNIT_TEST(testTdf150434);
+CPPUNIT_TEST(testChartDataTableWithMultipleLegendEntriesForOneDataSeries);
CPPUNIT_TEST_SUITE_END();
};
@@ -948,6 +950,20 @@ void Chart2ImportTest2::testTdf150434()
CPPUNIT_ASSERT_GREATEREQUAL(static_cast(0), aPosition.Y);
}
+void
Chart2ImportTest2::testChartDataTableWithMultipleLegendEntriesForOneDataSeries()
+{
+load(u"/chart2/qa/extras/data/xlsx/",
u"DataTable-MultipleLegendEntriesForOneDataSeries.xlsx");
+// Loading this file caused a crash in the data table code
+
+Reference xChartDoc(getChartDocFromSheet(0,
mxComponent),
+ UNO_QUERY_THROW);
+Reference xDrawPageSupplier(xChartDoc,
UNO_QUERY_THROW);
+Reference xDrawPage(xDrawPageSupplier->getDrawPage(),
UNO_SET_THROW);
+Reference xShapes(xDrawPage->getByIndex(0),
UNO_QUERY_THROW);
+Reference xDataTableShape = getShapeByName(xShapes,
"CID/D=0:DataTable=");
+CPPUNIT_ASSERT(xDataTableShape.is());
+}
+
CPPUNIT_TEST_SUITE_REGISTRATION(Chart2ImportTest2);
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git
a/chart2/qa/extras/data/xlsx/DataTable-MultipleLegendEntriesForOneDataSeries.xlsx
b/chart2/qa/extras/data/xlsx/DataTable-MultipleLegendEntriesForOneDataSeries.xlsx
new file mode 100644
index ..b077fd2e0315
Binary files /dev/null and
b/chart2/qa/extras/data/xlsx/DataTable-MultipleLegendEntriesForOneDataSeries.xlsx
differ
diff --git a/chart2/source/view/charttypes/VSeriesPlotter.cxx
b/chart2/source/view/charttypes/VSeriesPlotter.cxx
index e34606cd1dc9..65d404fb0be8 100644
--- a/chart2/source/view/charttypes/VSeriesPlotter.cxx
+++ b/chart2/source/view/charttypes/VSeriesPlotter.cxx
@@ -2516,11 +2516,6 @@ std::vector
VSeriesPlotter::createSymbols(const awt::Size& rEn
if (!pSeries)
continue;
-if
(!pSeries->getPropertiesOfSeries()->getPropertyValue("ShowLegendEntry").get())
-{
-continue;
-}
-
std::vector aSeriesSymbols =
createSymbolsForSeries(rEntryKeyAspectRatio, *pSeries, xTarget, xContext);
//add series entries to the result now
@@ -2887,75 +2882,16 @@ std::vector
VSeriesPlotter::createSymbolsForSeries(
try
{
ViewLegendSymbol aEntry;
-bool bVaryColorsByPoint = rSeries.isVaryColorsByPoint();
-bool bIsPie =
m_xChartTypeModel->getChartType().equalsIgnoreAsciiCase(CHART2_SERVICE_NAME_CHARTTYPE_PIE);
-try
-{
-if (bIsPie)
-{
-bool bDonut = false;
-if ((m_xChartTypeModel->getPropertyValue("UseRings") >>=
bDonut) && bDonut)
-bIsPie = false;
-}
-}
-catch (const uno::Exception&)
-{
-}
-
-if (bVaryColorsByPoint || bIsPie)
-{
-Sequence<
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - chart2/source
chart2/source/controller/main/ChartController_Window.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit 4c789414bf53c4df2b3c798c379adcb493a9e84a Author: Tomaž Vajngerl AuthorDate: Mon Aug 22 12:12:01 2022 +0200 Commit: Tomaž Vajngerl CommitDate: Mon Aug 22 19:50:09 2022 +0200 chart2: remove duplicate eObjectType Change-Id: Ia5b7b5a6f7f7f42cfbf784c37e6f5a825c0967f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138670 Tested-by: Jenkins CollaboraOffice Reviewed-by: Tomaž Vajngerl diff --git a/chart2/source/controller/main/ChartController_Window.cxx b/chart2/source/controller/main/ChartController_Window.cxx index cc8125057a09..435f4b1474f3 100644 --- a/chart2/source/controller/main/ChartController_Window.cxx +++ b/chart2/source/controller/main/ChartController_Window.cxx @@ -1035,7 +1035,6 @@ void ChartController::execute_Command( const CommandEvent& rCEvt ) xPopupMenu->insertSeparator( -1 ); } -ObjectType eObjectType = ObjectIdentifier::getObjectType( m_aSelection.getSelectedCID() ); Reference< XDiagram > xDiagram = ChartModelHelper::findDiagram( getModel() ); OUString aFormatCommand( lcl_getFormatCommandForObjectCID( m_aSelection.getSelectedCID() ) );
[Libreoffice-bugs] [Bug 143651] Calc fails to fill-in default value from prior rows
https://bugs.documentfoundation.org/show_bug.cgi?id=143651 --- Comment #13 from MR Zenwiz --- (In reply to Buovjaga from comment #12) : > > Is Tools - AutoInput checked? > Yes. > Note also that in 7.3 there was a change in how the suggestions appear: > https://wiki.documentfoundation.org/ReleaseNotes/7.3#General_improvements_2 > "Bash like autocompletion for Calc autoinput was implemented" I appreciate that. I was not aware of it and will explore this. However, that does not really apply here - when I type in the first character of a prior entry, nothing is prompted at all, and adding more promptable characters also has no effect. Thank you. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/ui/misc/bookmark.cxx |2 +-
sw/source/uibase/utlui/content.cxx |6 --
2 files changed, 5 insertions(+), 3 deletions(-)
New commits:
commit 5c3c49bbf768f88b3d9a45d1ffc88c44ad2870c1
Author: Michael Stahl
AuthorDate: Mon Aug 22 15:12:54 2022 +0200
Commit: Michael Stahl
CommitDate: Mon Aug 22 19:09:26 2022 +0200
sw: Navigator: Protect Bookmarks should allow editing the text ...
... in the bookmark. Only deleting/renaming it is forbidden.
Change-Id: I66c6d106f0fd97b416edabd0271cd3230909a279
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138692
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/sw/source/ui/misc/bookmark.cxx b/sw/source/ui/misc/bookmark.cxx
index 89d353c20245..363b861653a4 100644
--- a/sw/source/ui/misc/bookmark.cxx
+++ b/sw/source/ui/misc/bookmark.cxx
@@ -396,7 +396,7 @@ SwInsertBookmarkDlg::SwInsertBookmarkDlg(weld::Window*
pParent, SwWrtShell& rS,
m_xEditTextBtn->set_sensitive(false);
m_xRenameBtn->set_sensitive(false);
-// select 3rd column, otherwise it'll pick 1st one FIXME doesn't work with
gtk?
+// select 3rd column, otherwise it'll pick 1st one
m_xBookmarksBox->set_column_editables({ false, false, true, false, false
});
PopulateTable();
diff --git a/sw/source/uibase/utlui/content.cxx
b/sw/source/uibase/utlui/content.cxx
index dfba5294a35e..7922655252fa 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -1680,7 +1680,7 @@ IMPL_LINK(SwContentTree, CommandHdl, const CommandEvent&,
rCEvt, bool)
const bool bProtectBM = (ContentTypeId::BOOKMARK == nContentType)
&&
m_pActiveShell->getIDocumentSettingAccess().get(DocumentSettingId::PROTECT_BOOKMARKS);
const bool bEditable = pType->IsEditable() &&
-((bVisible && !bProtected && !bProtectBM) ||
ContentTypeId::REGION == nContentType);
+((bVisible && !bProtected) || ContentTypeId::REGION ==
nContentType);
const bool bDeletable = pType->IsDeletable() &&
((bVisible && !bProtected && !bProtectBM) ||
ContentTypeId::REGION == nContentType);
const bool bRenamable = bEditable && !bReadonly &&
@@ -4911,20 +4911,22 @@ void SwContentTree::EditEntry(const weld::TreeIter&
rEntry, EditEntryMode nMode)
nSlot = FN_FORMAT_FRAME_DLG;
break;
case ContentTypeId::BOOKMARK :
-
assert(!m_pActiveShell->getIDocumentSettingAccess().get(DocumentSettingId::PROTECT_BOOKMARKS));
if(nMode == EditEntryMode::DELETE)
{
+
assert(!m_pActiveShell->getIDocumentSettingAccess().get(DocumentSettingId::PROTECT_BOOKMARKS));
IDocumentMarkAccess* const pMarkAccess =
m_pActiveShell->getIDocumentMarkAccess();
pMarkAccess->deleteMark(pMarkAccess->findMark(pCnt->GetName()), false);
}
else if(nMode == EditEntryMode::RENAME)
{
+
assert(!m_pActiveShell->getIDocumentSettingAccess().get(DocumentSettingId::PROTECT_BOOKMARKS));
uno::Reference< frame::XModel > xModel =
m_pActiveShell->GetView().GetDocShell()->GetBaseModel();
uno::Reference< text::XBookmarksSupplier > xBkms(xModel,
uno::UNO_QUERY);
xNameAccess = xBkms->getBookmarks();
}
else
{
+// allowed despite PROTECT_BOOKMARKS: the dialog itself
enforces it
SfxStringItem const name(FN_EDIT_BOOKMARK, pCnt->GetName());
SfxPoolItem const* args[2] = { , nullptr };
m_pActiveShell->GetView().GetViewFrame()->
[Libreoffice-commits] core.git: basic/inc basic/source include/basic
basic/inc/sbxbase.hxx|1 +
basic/source/classes/sb.cxx |4 ++--
basic/source/sbx/sbxbase.cxx | 17 +
basic/source/sbx/sbxexec.cxx |2 +-
basic/source/sbx/sbxobj.cxx |2 +-
include/basic/sbxcore.hxx|2 ++
6 files changed, 24 insertions(+), 4 deletions(-)
New commits:
commit 7e2a8a9869e362ae181ad92f50ea287e9abf85bb
Author: Andreas Heinisch
AuthorDate: Tue Aug 9 18:42:40 2022 +0200
Commit: Andreas Heinisch
CommitDate: Mon Aug 22 19:03:42 2022 +0200
tdf#150139 - Add a concrete name to the error message
Add a concrete name to the "Property or method not found: $(ARG1)" error
message when creating a listener.
Change-Id: I76c904793a96082c49f8aa2d45c76c50a453d892
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138061
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch
diff --git a/basic/inc/sbxbase.hxx b/basic/inc/sbxbase.hxx
index 80552c2fbf08..e06d76161dec 100644
--- a/basic/inc/sbxbase.hxx
+++ b/basic/inc/sbxbase.hxx
@@ -36,6 +36,7 @@ class SbxBasicFormater;
struct SbxAppData
{
ErrCode eErrCode; // Error code
+OUString aErrorMsg; // Error message for $ARG
SbxVariableRef m_aGlobErr; // Global error object
std::vector m_Factories; // these are owned by fields in
SbiGlobals
tools::SvRef mrImplRepository;
diff --git a/basic/source/classes/sb.cxx b/basic/source/classes/sb.cxx
index 8d87330e469b..f1ab6dd1da0c 100644
--- a/basic/source/classes/sb.cxx
+++ b/basic/source/classes/sb.cxx
@@ -1325,11 +1325,11 @@ bool StarBASIC::Call( const OUString& rName, SbxArray*
pParam )
if( !bRes )
{
ErrCode eErr = SbxBase::GetError();
-SbxBase::ResetError();
if( eErr != ERRCODE_NONE )
{
-RTError( eErr, OUString(), 0, 0, 0 );
+RTError(eErr, SbxBase::GetErrorMsg(), 0, 0, 0);
}
+SbxBase::ResetError();
}
return bRes;
}
diff --git a/basic/source/sbx/sbxbase.cxx b/basic/source/sbx/sbxbase.cxx
index 3b70307ec3e7..9d2129e68a1e 100644
--- a/basic/source/sbx/sbxbase.cxx
+++ b/basic/source/sbx/sbxbase.cxx
@@ -37,6 +37,7 @@
SbxAppData::SbxAppData()
: eErrCode(ERRCODE_NONE)
+, aErrorMsg(OUString())
, eBasicFormaterLangType(LANGUAGE_DONTKNOW)
{
}
@@ -96,6 +97,21 @@ ErrCode const & SbxBase::GetError()
return GetSbxData_Impl().eErrCode;
}
+OUString const & SbxBase::GetErrorMsg()
+{
+return GetSbxData_Impl().aErrorMsg;
+}
+
+void SbxBase::SetError(ErrCode e, const OUString& rMsg)
+{
+SbxAppData& r = GetSbxData_Impl();
+if (e && r.eErrCode == ERRCODE_NONE)
+{
+r.eErrCode = e;
+r.aErrorMsg = rMsg;
+}
+}
+
void SbxBase::SetError( ErrCode e )
{
SbxAppData& r = GetSbxData_Impl();
@@ -111,6 +127,7 @@ bool SbxBase::IsError()
void SbxBase::ResetError()
{
GetSbxData_Impl().eErrCode = ERRCODE_NONE;
+GetSbxData_Impl().aErrorMsg = OUString();
}
void SbxBase::AddFactory( SbxFactory* pFac )
diff --git a/basic/source/sbx/sbxexec.cxx b/basic/source/sbx/sbxexec.cxx
index d830061f071d..f3abca766d35 100644
--- a/basic/source/sbx/sbxexec.cxx
+++ b/basic/source/sbx/sbxexec.cxx
@@ -323,7 +323,7 @@ static SbxVariableRef Element
}
}
else
-SbxBase::SetError( ERRCODE_BASIC_NO_METHOD );
+SbxBase::SetError( ERRCODE_BASIC_NO_METHOD, aSym );
}
*ppBuf = p;
return refVar;
diff --git a/basic/source/sbx/sbxobj.cxx b/basic/source/sbx/sbxobj.cxx
index f83324a26bb8..4dd054959823 100644
--- a/basic/source/sbx/sbxobj.cxx
+++ b/basic/source/sbx/sbxobj.cxx
@@ -275,7 +275,7 @@ bool SbxObject::Call( const OUString& rName, SbxArray*
pParam )
pMeth->SetParameters( nullptr );
return true;
}
-SetError( ERRCODE_BASIC_NO_METHOD );
+SetError( ERRCODE_BASIC_NO_METHOD, rName );
return false;
}
diff --git a/include/basic/sbxcore.hxx b/include/basic/sbxcore.hxx
index e5f726e8d016..477858d9656c 100644
--- a/include/basic/sbxcore.hxx
+++ b/include/basic/sbxcore.hxx
@@ -85,7 +85,9 @@ public:
virtual boolLoadCompleted();
static ErrCode const & GetError();
+static OUString const& GetErrorMsg();
static void SetError( ErrCode );
+static void SetError(ErrCode, const OUString&);
static bool IsError();
static void ResetError();
[Libreoffice-bugs] [Bug 142031] Formula bar suggestion tooltips don't like accents
https://bugs.documentfoundation.org/show_bug.cgi?id=142031 Andreas Heinisch changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |andreas.heini...@yahoo.de |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150548] Spreadsheet shows useful information after FILEOPEN in MSO but in Libre Calc 7.3.5.2 no useful information can be seen
https://bugs.documentfoundation.org/show_bug.cgi?id=150548 tom1willi...@yandex.com changed: What|Removed |Added OS|Linux (All) |All -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150548] Spreadsheet shows useful information after FILEOPEN in MSO but in Libre Calc 7.3.5.2 no useful information can be seen
https://bugs.documentfoundation.org/show_bug.cgi?id=150548 --- Comment #1 from tom1willi...@yandex.com --- Created attachment 181954 --> https://bugs.documentfoundation.org/attachment.cgi?id=181954=edit an .XLS file from a reputable source on the internet -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150548] New: Spreadsheet shows useful information after FILEOPEN in MSO but in Libre Calc 7.3.5.2 no useful information can be seen
https://bugs.documentfoundation.org/show_bug.cgi?id=150548 Bug ID: 150548 Summary: Spreadsheet shows useful information after FILEOPEN in MSO but in Libre Calc 7.3.5.2 no useful information can be seen Product: LibreOffice Version: 7.3.5.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tom1willi...@yandex.com Description: Spreadsheet shows useful information after FILEOPEN in MSO but in Libre Calc 7.3.5.2 no useful information can be seen. Steps to Reproduce: 1.Open the file in Libre Calc 7.3.5.2 2. No useful data can be seen 3. Open the file in MSO and the data can be easily seen Actual Results: no data visible except for the names of individual sheets Expected Results: Expected to see an income statement, a balance sheet and other financial statements Reproducible: Always User Profile Reset: No Additional Info: This file comes from the US SEC EDGAR system. That seems like an important source for data and a file format that Libre should open as well as MS Excel does. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150547] New: Unusable documentation for scripting
https://bugs.documentfoundation.org/show_bug.cgi?id=150547 Bug ID: 150547 Summary: Unusable documentation for scripting Product: LibreOffice Version: 6.4.7.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: BASIC Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: fsd...@gmail.com Description: I try to find the Sheet in a Basic script for more than a week. The documentation on the net is for OpenOffice. ThisComponent which returns the actual document fits here but there is no Sheets method nor getSheetByName nor getSheetByIndex. The documentation for ThisComponent says that the availble methods of the object returned depends on the document type (what makes sense). There is no way to figure out which methods ARE available tough using: https://help.libreoffice.org/latest/gu/text/sbasic/shared/ Steps to Reproduce: 1. From a Spreadsheet open the Macro Editor 2. Get the actual document using ThisComponent 3. Try to find the Sheets, Cells, Rows, Columns, ... Actual Results: well, nothing Expected Results: Documentation which makes it possible to find the required information Reproducible: Always User Profile Reset: No Additional Info: Structuring the documentation as if it was an API documentation would make sense. Object/Service and in this Methods, Properties etc. Doc = ThisComponent # which is a spreadsheet at the moment Sheet = Doc.getSheets() fails There should a section "SpreadsheetDocumetObject" with the methods and properties listed Doc = ThisComponent Sheet = Doc.theRightMethodFromTheDocumentationToGetTheSheets() should work -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150533] Font and font size fields overwrite field rather than clear first creating illegible gibberish
https://bugs.documentfoundation.org/show_bug.cgi?id=150533 Ken changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150533] Font and font size fields overwrite field rather than clear first creating illegible gibberish
https://bugs.documentfoundation.org/show_bug.cgi?id=150533 --- Comment #4 from Ken --- Created attachment 181953 --> https://bugs.documentfoundation.org/attachment.cgi?id=181953=edit Facsimile of document that presented bug change some fonts or font sizes -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/core/doc/DocumentRedlineManager.cxx | 48 +-
1 file changed, 24 insertions(+), 24 deletions(-)
New commits:
commit 0bda4401eda5b19b1ebfeb712cab6af8c8d1f59b
Author: Noel Grandin
AuthorDate: Mon Aug 22 15:27:21 2022 +0200
Commit: Noel Grandin
CommitDate: Mon Aug 22 18:08:50 2022 +0200
use more SwPosition::Assign
as part of the attempt to keep the internals of SwPosition in sync with
each other
Change-Id: I6f109c32f5748ef3f76ab178a2aa9d6822bc58a8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138688
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/source/core/doc/DocumentRedlineManager.cxx
b/sw/source/core/doc/DocumentRedlineManager.cxx
index 6670aca270ed..cc51a0dc9d55 100644
--- a/sw/source/core/doc/DocumentRedlineManager.cxx
+++ b/sw/source/core/doc/DocumentRedlineManager.cxx
@@ -567,7 +567,7 @@ namespace
case SwComparePosition::Equal:
{
bool bInsert = RedlineType::Insert == pRedl->GetType();
-SwPosition aPos(pRedl->Start()->nNode);
+SwPosition aPos(pRedl->Start()->GetNode());
rArr.DeleteAndDestroy( rPos-- );
// remove tracking of the table row, if needed
@@ -778,7 +778,7 @@ namespace
aPam.GetBound( false ).nContent.Assign( nullptr, 0
);
if (aPam.End()->GetNode().IsStartNode())
{ // end node will be deleted too! see
nNodeDiff+1
---aPam.End()->nNode;
+aPam.End()->Adjust(SwNodeOffset(-1));
}
assert(!aPam.End()->GetNode().IsStartNode());
rDoc.getIDocumentContentOperations().DelFullPara(
aPam );
@@ -3141,7 +3141,7 @@ const SwRangeRedline*
DocumentRedlineManager::SelNextRedline( SwPaM& rPam ) cons
{
SwNodeIndex aTmp( pEnd->GetNode() );
SwContentNode* pCNd = SwNodes::GoPrevSection( );
-if( !pCNd || ( aTmp == rSttPos.nNode &&
+if( !pCNd || ( aTmp == rSttPos.GetNode() &&
pCNd->Len() == rSttPos.GetContentIndex() ))
pFnd = nullptr;
}
@@ -3196,14 +3196,14 @@ const SwRangeRedline*
DocumentRedlineManager::SelNextRedline( SwPaM& rPam ) cons
const SwRangeRedline* pSaveFnd = pFnd;
SwContentNode* pCNd;
-SwNodeIndex* pIdx = ()->nNode;
-if( !pIdx->GetNode().IsContentNode() )
+SwPosition* pPos = rPam.GetMark();
+if( !pPos->GetNode().IsContentNode() )
{
-pCNd = m_rDoc.GetNodes().GoNextSection( pIdx );
+pCNd = m_rDoc.GetNodes().GoNextSection( pPos );
if( pCNd )
{
-if( *pIdx <= rPam.GetPoint()->GetNode() )
-rPam.GetMark()->nContent.Assign( pCNd, 0 );
+if( pPos->GetNode() <= rPam.GetPoint()->GetNode() )
+pPos->Assign( *pCNd, 0 );
else
pFnd = nullptr;
}
@@ -3211,14 +3211,14 @@ const SwRangeRedline*
DocumentRedlineManager::SelNextRedline( SwPaM& rPam ) cons
if( pFnd )
{
-pIdx = ()->nNode;
-if( !pIdx->GetNode().IsContentNode() )
+pPos = rPam.GetPoint();
+if( !pPos->GetNode().IsContentNode() )
{
-pCNd = SwNodes::GoPrevSection( pIdx );
+pCNd = SwNodes::GoPrevSection( pPos );
if( pCNd )
{
-if( *pIdx >= rPam.GetMark()->nNode )
-rPam.GetPoint()->nContent.Assign( pCNd,
pCNd->Len() );
+if( pPos->GetNode() >= rPam.GetMark()->GetNode() )
+pPos->Assign( *pCNd, pCNd->Len() );
else
pFnd = nullptr;
}
@@ -3267,7 +3267,7 @@ const SwRangeRedline*
DocumentRedlineManager::SelPrevRedline( SwPaM& rPam ) cons
{
SwNodeIndex aTmp( pStt->GetNode() );
SwContentNode* pCNd = m_rDoc.GetNodes().GoNextSection( );
-if( !pCNd || ( aTmp == rSttPos.nNode &&
+if( !pCNd || ( aTmp == rSttPos.GetNode() &&
!rSttPos.GetContentIndex() ))
pFnd = nullptr;
}
@@ -3323,14 +3323,14 @@ const SwRangeRedline*
DocumentRedlineManager::SelPrevRedline( SwPaM& rPam ) cons
const SwRangeRedline* pSaveFnd = pFnd;
SwContentNode* pCNd;
-SwNodeIndex* pIdx = ()->nNode;
-if( !pIdx->GetNode().IsContentNode() )
+SwPosition* pPos = rPam.GetMark();
+
[Libreoffice-commits] core.git: vcl/source
vcl/source/filter/GraphicFormatDetector.cxx | 40 +-
vcl/source/filter/graphicfilter2.cxx| 50 ++--
2 files changed, 42 insertions(+), 48 deletions(-)
New commits:
commit 86d49f41d46519235b55918ac375bc1d2b99552b
Author: offtkp
AuthorDate: Sat Aug 13 12:52:26 2022 +0300
Commit: Tomaž Vajngerl
CommitDate: Mon Aug 22 18:05:29 2022 +0200
Remove code duplication in GraphicDescriptor for PSD
GraphicFormatDetector and GraphicDescriptor have duplicate format
detection code so now GraphicDescriptor uses GraphicFormatDetector
functions instead to detect the format for PSD files
Change-Id: Icae532a7143477dada411224293250a26676c684
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138227
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/source/filter/GraphicFormatDetector.cxx
b/vcl/source/filter/GraphicFormatDetector.cxx
index 5b5ccf33d004..8956c3cd9530 100644
--- a/vcl/source/filter/GraphicFormatDetector.cxx
+++ b/vcl/source/filter/GraphicFormatDetector.cxx
@@ -792,12 +792,48 @@ bool GraphicFormatDetector::checkPCD()
bool GraphicFormatDetector::checkPSD()
{
+bool bRet = false;
if ((mnFirstLong == 0x38425053) && ((mnSecondLong >> 16) == 1))
{
maMetadata.mnFormat = GraphicFileFormat::PSD;
-return true;
+bRet = true;
+if (mbExtendedInfo)
+{
+sal_uInt16 nChannels = 0;
+sal_uInt32 nRows = 0;
+sal_uInt32 nColumns = 0;
+sal_uInt16 nDepth = 0;
+sal_uInt16 nMode = 0;
+mrStream.Seek(mnStreamPosition + 6);
+mrStream.SeekRel(6); // Pad
+mrStream.ReadUInt16(nChannels)
+.ReadUInt32(nRows)
+.ReadUInt32(nColumns)
+.ReadUInt16(nDepth)
+.ReadUInt16(nMode);
+if ((nDepth == 1) || (nDepth == 8) || (nDepth == 16))
+{
+maMetadata.mnBitsPerPixel = (nDepth == 16) ? 8 : nDepth;
+switch (nChannels)
+{
+case 4:
+case 3:
+maMetadata.mnBitsPerPixel = 24;
+[[fallthrough]];
+case 2:
+case 1:
+maMetadata.maPixSize.setWidth(nColumns);
+maMetadata.maPixSize.setHeight(nRows);
+break;
+default:
+bRet = false;
+}
+}
+else
+bRet = false;
+}
}
-return false;
+return bRet;
}
bool GraphicFormatDetector::checkEPS()
diff --git a/vcl/source/filter/graphicfilter2.cxx
b/vcl/source/filter/graphicfilter2.cxx
index 4327ef5e2f59..1117b2cc9cbb 100644
--- a/vcl/source/filter/graphicfilter2.cxx
+++ b/vcl/source/filter/graphicfilter2.cxx
@@ -683,54 +683,12 @@ bool GraphicDescriptor::ImpDetectTGA( SvStream& rStm,
bool )
bool GraphicDescriptor::ImpDetectPSD( SvStream& rStm, bool bExtendedInfo )
{
-bool bRet = false;
-
-sal_uInt32 nMagicNumber = 0;
sal_Int32 nStmPos = rStm.Tell();
-rStm.SetEndian( SvStreamEndian::BIG );
-rStm.ReadUInt32( nMagicNumber );
-if ( nMagicNumber == 0x38425053 )
-{
-sal_uInt16 nVersion = 0;
-rStm.ReadUInt16( nVersion );
-if ( nVersion == 1 )
-{
-bRet = true;
-if ( bExtendedInfo )
-{
-sal_uInt16 nChannels = 0;
-sal_uInt32 nRows = 0;
-sal_uInt32 nColumns = 0;
-sal_uInt16 nDepth = 0;
-sal_uInt16 nMode = 0;
-rStm.SeekRel( 6 ); // Pad
-rStm.ReadUInt16( nChannels ).ReadUInt32( nRows ).ReadUInt32(
nColumns ).ReadUInt16( nDepth ).ReadUInt16( nMode );
-if ( ( nDepth == 1 ) || ( nDepth == 8 ) || ( nDepth == 16 ) )
-{
-aMetadata.mnBitsPerPixel = ( nDepth == 16 ) ? 8 : nDepth;
-switch ( nChannels )
-{
-case 4 :
-case 3 :
-aMetadata.mnBitsPerPixel = 24;
-[[fallthrough]];
-case 2 :
-case 1 :
-aMetadata.maPixSize.setWidth( nColumns );
-aMetadata.maPixSize.setHeight( nRows );
-break;
-default:
-bRet = false;
-}
-}
-else
-bRet = false;
-}
-}
-}
-
+vcl::GraphicFormatDetector aDetector( rStm, aPathExt, bExtendedInfo );
+bool bRet = aDetector.detect();
+bRet &= aDetector.checkPSD();
if ( bRet )
-aMetadata.mnFormat =
[Libreoffice-commits] core.git: 2 commits - vcl/source
vcl/source/filter/GraphicFormatDetector.cxx | 172 +++-
vcl/source/filter/graphicfilter2.cxx| 199 +---
2 files changed, 180 insertions(+), 191 deletions(-)
New commits:
commit 6a2fd2d07ed1cb7713776b32ff175b300ee732e9
Author: offtkp
AuthorDate: Sat Aug 13 12:02:01 2022 +0300
Commit: Tomaž Vajngerl
CommitDate: Mon Aug 22 18:04:54 2022 +0200
Remove code duplication in GraphicDescriptor for PNG
GraphicFormatDetector and GraphicDescriptor have duplicate format
detection code so now GraphicDescriptor uses GraphicFormatDetector
functions instead to detect the format for PNG files
Change-Id: I8ce1c5eee44ff4122f4ecf1094d3d8b18379c6b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138226
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/source/filter/GraphicFormatDetector.cxx
b/vcl/source/filter/GraphicFormatDetector.cxx
index 43e403e59936..5b5ccf33d004 100644
--- a/vcl/source/filter/GraphicFormatDetector.cxx
+++ b/vcl/source/filter/GraphicFormatDetector.cxx
@@ -645,6 +645,102 @@ bool GraphicFormatDetector::checkPNG()
if (mnFirstLong == 0x89504e47 && mnSecondLong == 0x0d0a1a0a)
{
maMetadata.mnFormat = GraphicFileFormat::PNG;
+if (mbExtendedInfo)
+{
+sal_uInt32 nTemp32;
+mrStream.Seek(mnStreamPosition + 8);
+do
+{
+sal_uInt8 cByte = 0;
+
+// IHDR-Chunk
+mrStream.SeekRel(8);
+
+// width
+mrStream.ReadUInt32(nTemp32);
+if (!mrStream.good())
+break;
+maMetadata.maPixSize.setWidth(nTemp32);
+
+// height
+mrStream.ReadUInt32(nTemp32);
+if (!mrStream.good())
+break;
+maMetadata.maPixSize.setHeight(nTemp32);
+
+// Bits/Pixel
+mrStream.ReadUChar(cByte);
+if (!mrStream.good())
+break;
+maMetadata.mnBitsPerPixel = cByte;
+
+// Colour type - check whether it supports alpha values
+sal_uInt8 cColType = 0;
+mrStream.ReadUChar(cColType);
+if (!mrStream.good())
+break;
+maMetadata.mbIsAlpha = maMetadata.mbIsTransparent
+= (cColType == 4 || cColType == 6);
+
+// Planes always 1;
+// compression always
+maMetadata.mnPlanes = 1;
+
+sal_uInt32 nLen32 = 0;
+nTemp32 = 0;
+
+mrStream.SeekRel(7);
+
+// read up to the start of the image
+mrStream.ReadUInt32(nLen32);
+mrStream.ReadUInt32(nTemp32);
+while (mrStream.good() && nTemp32 != 0x49444154)
+{
+if (nTemp32 == 0x70485973) // physical pixel dimensions
+{
+sal_uLong nXRes;
+sal_uLong nYRes;
+
+// horizontal resolution
+nTemp32 = 0;
+mrStream.ReadUInt32(nTemp32);
+nXRes = nTemp32;
+
+// vertical resolution
+nTemp32 = 0;
+mrStream.ReadUInt32(nTemp32);
+nYRes = nTemp32;
+
+// unit
+cByte = 0;
+mrStream.ReadUChar(cByte);
+
+if (cByte)
+{
+if (nXRes)
+maMetadata.maLogSize.setWidth(
+(maMetadata.maPixSize.Width() * 10) /
nXRes);
+
+if (nYRes)
+maMetadata.maLogSize.setHeight(
+(maMetadata.maPixSize.Height() * 10) /
nYRes);
+}
+
+nLen32 -= 9;
+}
+else if (nTemp32 == 0x74524e53) // transparency
+{
+maMetadata.mbIsTransparent = true;
+maMetadata.mbIsAlpha = (cColType != 0 && cColType !=
2);
+}
+
+// skip forward to next chunk
+mrStream.SeekRel(4 + nLen32);
+mrStream.ReadUInt32(nLen32);
+mrStream.ReadUInt32(nTemp32);
+}
+} while (false);
+}
return true;
}
return false;
diff --git a/vcl/source/filter/graphicfilter2.cxx
b/vcl/source/filter/graphicfilter2.cxx
index 0ef05ef1db9d..4327ef5e2f59 100644
--- a/vcl/source/filter/graphicfilter2.cxx
+++ b/vcl/source/filter/graphicfilter2.cxx
@@ -427,113 +427,12 @@
[Libreoffice-commits] core.git: 2 commits - vcl/source
vcl/source/filter/GraphicFormatDetector.cxx |8 +
vcl/source/filter/graphicfilter2.cxx| 43 ++--
2 files changed, 18 insertions(+), 33 deletions(-)
New commits:
commit c24b88efc4ac80d25d79b9764e6718d0392f718a
Author: offtkp
AuthorDate: Fri Aug 12 22:04:35 2022 +0300
Commit: Tomaž Vajngerl
CommitDate: Mon Aug 22 18:04:02 2022 +0200
Remove code duplication in GraphicDescriptor for RAS
GraphicFormatDetector and GraphicDescriptor have duplicate format
detection code so now GraphicDescriptor uses GraphicFormatDetector
functions instead to detect the format for RAS files
Change-Id: I736c583a9cc974a9eb4151443295dbb4b1e71053
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138212
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/source/filter/graphicfilter2.cxx
b/vcl/source/filter/graphicfilter2.cxx
index 0706e1b2301c..e622901767e8 100644
--- a/vcl/source/filter/graphicfilter2.cxx
+++ b/vcl/source/filter/graphicfilter2.cxx
@@ -838,16 +838,12 @@ bool GraphicDescriptor::ImpDetectPPM( SvStream& rStm,
bool )
bool GraphicDescriptor::ImpDetectRAS( SvStream& rStm, bool )
{
-sal_uInt32 nMagicNumber = 0;
-bool bRet = false;
sal_Int32 nStmPos = rStm.Tell();
-rStm.SetEndian( SvStreamEndian::BIG );
-rStm.ReadUInt32( nMagicNumber );
-if ( nMagicNumber == 0x59a66a95 )
-{
-aMetadata.mnFormat = GraphicFileFormat::RAS;
-bRet = true;
-}
+vcl::GraphicFormatDetector aDetector( rStm, aPathExt, false /*
bExtendedInfo */ );
+bool bRet = aDetector.detect();
+bRet &= aDetector.checkRAS();
+if ( bRet )
+aMetadata = aDetector.getMetadata();
rStm.Seek( nStmPos );
return bRet;
}
commit 0853187cbc66f17620c2951d24d1f71c9ea9f81a
Author: offtkp
AuthorDate: Fri Aug 12 22:01:58 2022 +0300
Commit: Tomaž Vajngerl
CommitDate: Mon Aug 22 18:03:53 2022 +0200
Remove code duplication in GraphicDescriptor for WEBP
GraphicFormatDetector and GraphicDescriptor have duplicate format
detection code so now GraphicDescriptor uses GraphicFormatDetector
functions instead to detect the format for WEBP files
Change-Id: Ib9d7169433b391e2520d6b9bca831fa964a8d136
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138211
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/source/filter/GraphicFormatDetector.cxx
b/vcl/source/filter/GraphicFormatDetector.cxx
index 684298ac773a..0bd3394bc99d 100644
--- a/vcl/source/filter/GraphicFormatDetector.cxx
+++ b/vcl/source/filter/GraphicFormatDetector.cxx
@@ -25,6 +25,7 @@
#include
#include
#include
+#include
#include
constexpr sal_uInt32 SVG_CHECK_SIZE = 2048;
@@ -884,6 +885,13 @@ bool GraphicFormatDetector::checkWEBP()
&& maFirstBytes[10] == 'B' && maFirstBytes[11] == 'P')
{
maMetadata.mnFormat = GraphicFileFormat::WEBP;
+if (mbExtendedInfo)
+{
+mrStream.Seek(mnStreamPosition);
+ReadWebpInfo(mrStream, maMetadata.maPixSize,
maMetadata.mnBitsPerPixel,
+ maMetadata.mbIsAlpha);
+maMetadata.mbIsTransparent = maMetadata.mbIsAlpha;
+}
return true;
}
return false;
diff --git a/vcl/source/filter/graphicfilter2.cxx
b/vcl/source/filter/graphicfilter2.cxx
index 93588c40c229..0706e1b2301c 100644
--- a/vcl/source/filter/graphicfilter2.cxx
+++ b/vcl/source/filter/graphicfilter2.cxx
@@ -26,7 +26,6 @@
#include
#include
#include
-#include
#include
#include "graphicfilter_internal.hxx"
@@ -1081,30 +1080,12 @@ bool GraphicDescriptor::ImpDetectSVG( SvStream& rStm,
bool /*bExtendedInfo*/ )
bool GraphicDescriptor::ImpDetectWEBP( SvStream& rStm, bool bExtendedInfo )
{
-sal_uInt32 nTemp32 = 0;
-boolbRet = false;
-
sal_Int32 nStmPos = rStm.Tell();
-rStm.SetEndian( SvStreamEndian::BIG );
-rStm.ReadUInt32( nTemp32 );
-
-if ( nTemp32 == 0x52494646 )
-{
-rStm.ReadUInt32( nTemp32 ); // skip
-rStm.ReadUInt32( nTemp32 );
-if ( nTemp32 == 0x57454250 )
-{
-aMetadata.mnFormat = GraphicFileFormat::WEBP;
-bRet = true;
-
-if ( bExtendedInfo )
-{
-rStm.Seek(nStmPos);
-ReadWebpInfo(rStm, aMetadata.maPixSize,
aMetadata.mnBitsPerPixel, aMetadata.mbIsAlpha );
-aMetadata.mbIsTransparent = aMetadata.mbIsAlpha;
-}
-}
-}
+vcl::GraphicFormatDetector aDetector( rStm, aPathExt, bExtendedInfo );
+bool bRet = aDetector.detect();
+bRet &= aDetector.checkWEBP();
+if ( bRet )
+aMetadata = aDetector.getMetadata();
rStm.Seek( nStmPos );
return bRet;
}
[Libreoffice-commits] core.git: 2 commits - vcl/source
vcl/source/filter/graphicfilter2.cxx | 26 --
1 file changed, 16 insertions(+), 10 deletions(-)
New commits:
commit 3682ef9da1ba3b6479e6bd6bf6d9705c784b4fd4
Author: offtkp
AuthorDate: Fri Aug 12 21:35:25 2022 +0300
Commit: Tomaž Vajngerl
CommitDate: Mon Aug 22 18:03:17 2022 +0200
Remove code duplication in GraphicDescriptor for MET
GraphicFormatDetector and GraphicDescriptor have duplicate format
detection code so now GraphicDescriptor uses GraphicFormatDetector
functions instead to detect the format for MET files
Change-Id: I3188fe4bcdd5e0d9a942c6606d28a01c56319619
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138210
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/source/filter/graphicfilter2.cxx
b/vcl/source/filter/graphicfilter2.cxx
index 59b468a5317e..93588c40c229 100644
--- a/vcl/source/filter/graphicfilter2.cxx
+++ b/vcl/source/filter/graphicfilter2.cxx
@@ -943,12 +943,15 @@ bool GraphicDescriptor::ImpDetectDXF( SvStream& rStm,
bool )
return bRet;
}
-bool GraphicDescriptor::ImpDetectMET( SvStream&, bool )
+bool GraphicDescriptor::ImpDetectMET( SvStream& rStm, bool )
{
-bool bRet = aPathExt.startsWith( "met" );
-if (bRet)
-aMetadata.mnFormat = GraphicFileFormat::MET;
-
+sal_Int32 nStmPos = rStm.Tell();
+vcl::GraphicFormatDetector aDetector( rStm, aPathExt, false
/*bExtendedInfo*/ );
+bool bRet = aDetector.detect();
+bRet &= aDetector.checkMET();
+if ( bRet )
+aMetadata = aDetector.getMetadata();
+rStm.Seek( nStmPos );
return bRet;
}
commit a1b2a8370e61ada2690a29a623d55b38bd7a7cf3
Author: offtkp
AuthorDate: Fri Aug 12 21:30:19 2022 +0300
Commit: Tomaž Vajngerl
CommitDate: Mon Aug 22 18:03:05 2022 +0200
Remove code duplication in GraphicDescriptor for TGA
GraphicFormatDetector and GraphicDescriptor have duplicate format
detection code so now GraphicDescriptor uses GraphicFormatDetector
functions instead to detect the format for TGA files
Change-Id: I939426d3016c90500c2a250ef464213b0fd7d642
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138209
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/source/filter/graphicfilter2.cxx
b/vcl/source/filter/graphicfilter2.cxx
index 01741afa7ec2..59b468a5317e 100644
--- a/vcl/source/filter/graphicfilter2.cxx
+++ b/vcl/source/filter/graphicfilter2.cxx
@@ -853,12 +853,15 @@ bool GraphicDescriptor::ImpDetectRAS( SvStream& rStm,
bool )
return bRet;
}
-bool GraphicDescriptor::ImpDetectTGA( SvStream&, bool )
+bool GraphicDescriptor::ImpDetectTGA( SvStream& rStm, bool )
{
-bool bRet = aPathExt.startsWith( "tga" );
-if (bRet)
-aMetadata.mnFormat = GraphicFileFormat::TGA;
-
+sal_Int32 nStmPos = rStm.Tell();
+vcl::GraphicFormatDetector aDetector( rStm, aPathExt, false /*
bExtendedInfo */ );
+bool bRet = aDetector.detect();
+bRet &= aDetector.checkTGA();
+if ( bRet )
+aMetadata = aDetector.getMetadata();
+rStm.Seek( nStmPos );
return bRet;
}
