[Libreoffice-bugs] [Bug 106179] [META] Writer comment bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=106179 Bug 106179 depends on bug 136734, which changed state. Bug 136734 Summary: Can't position the cursor at line end via mouse or touchpad after a comment https://bugs.documentfoundation.org/show_bug.cgi?id=136734 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136734] Can't position the cursor at line end via mouse or touchpad after a comment
https://bugs.documentfoundation.org/show_bug.cgi?id=136734 Dieter changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #3 from Dieter --- Can't reproduce with Version: 7.4.1.2 (x64) / LibreOffice Community Build ID: 3c58a8f3a960df8bc8fd77b461821e42c061c5f0 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL => RESOLVED WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150628] most URIs can't be hyperlinked
https://bugs.documentfoundation.org/show_bug.cgi?id=150628 --- Comment #4 from Dieter --- Tested with Version: 7.4.1.2 (x64) / LibreOffice Community Build ID: 3c58a8f3a960df8bc8fd77b461821e42c061c5f0 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL Results: Hyperlinks seems to work with NEWS, NNTP and IRC (but it seems, that I don't have the correct app to open it). Hyperlink doesn't work for SSH and TELNET But I think, it needs a user with more experience in this field for testing. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138325] Some OTF font names are exported in PDF as "DummyName"
https://bugs.documentfoundation.org/show_bug.cgi?id=138325 خالد حسني changed: What|Removed |Added Status|NEW |ASSIGNED CC||kha...@aliftype.com Assignee|libreoffice-b...@lists.free |kha...@aliftype.com |desktop.org | --- Comment #7 from خالد حسني --- Similar to bug 151039, we are trying to access font names from “CFF” table, but these fonts lack such names (they are available from the “name” table). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150796] LibreOffice/Calc/Basic/Linux: result of a call function overload the macro call in cell !!! NOT OCCURE Windows/Calc/Basic
https://bugs.documentfoundation.org/show_bug.cgi?id=150796 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150429] FILEOPEN PPTX: line in "chevron + textboxes" SmartArt renders quite thinner than in PowerPoint
https://bugs.documentfoundation.org/show_bug.cgi?id=150429 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150628] most URIs can't be hyperlinked
https://bugs.documentfoundation.org/show_bug.cgi?id=150628 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150628] most URIs can't be hyperlinked
https://bugs.documentfoundation.org/show_bug.cgi?id=150628 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147783] Cannot undo typing in Hyperlink dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=147783 --- Comment #9 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147783] Cannot undo typing in Hyperlink dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=147783 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147527] When drag and dropping a vector graphic in an A4 document it's resized
https://bugs.documentfoundation.org/show_bug.cgi?id=147527 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147527] When drag and dropping a vector graphic in an A4 document it's resized
https://bugs.documentfoundation.org/show_bug.cgi?id=147527 --- Comment #3 from QA Administrators --- Dear felix.dahmen, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147517] Inserting image as character blocks new paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=147517 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147517] Inserting image as character blocks new paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=147517 --- Comment #3 from QA Administrators --- Dear Goran Hasse, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147442] Libre office ODP file does not save changes made to tables
https://bugs.documentfoundation.org/show_bug.cgi?id=147442 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147442] Libre office ODP file does not save changes made to tables
https://bugs.documentfoundation.org/show_bug.cgi?id=147442 --- Comment #3 from QA Administrators --- Dear Alberto, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148097] Black flash during slide transition
https://bugs.documentfoundation.org/show_bug.cgi?id=148097 --- Comment #2 from QA Administrators --- Dear Sébastien, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136734] Can't position the cursor at line end via mouse or touchpad after a comment
https://bugs.documentfoundation.org/show_bug.cgi?id=136734 --- Comment #2 from QA Administrators --- Dear Luke Kendall, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138086] No undo after deleting the header
https://bugs.documentfoundation.org/show_bug.cgi?id=138086 --- Comment #3 from QA Administrators --- Dear Szasz-Fabian Jozsef, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 61185] Calc Charts: Non-contiguous category ranges
https://bugs.documentfoundation.org/show_bug.cgi?id=61185 --- Comment #16 from QA Administrators --- Dear tmacalp, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136167] Autocorrect doesn't correct after a language change on the first instance
https://bugs.documentfoundation.org/show_bug.cgi?id=136167 --- Comment #3 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135240] Undo restores hidden track changes information
https://bugs.documentfoundation.org/show_bug.cgi?id=135240 --- Comment #3 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135382] Document scrolls to top after undo of pasting a frame
https://bugs.documentfoundation.org/show_bug.cgi?id=135382 --- Comment #2 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133424] 'Go to Page' not working if cursor is in a comment
https://bugs.documentfoundation.org/show_bug.cgi?id=133424 --- Comment #9 from QA Administrators --- Dear Chris, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 128065] BASIC Runtime Error on start LOCalc
https://bugs.documentfoundation.org/show_bug.cgi?id=128065 --- Comment #5 from QA Administrators --- Dear p_consti, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 127848] Chart object not visible on Linux
https://bugs.documentfoundation.org/show_bug.cgi?id=127848 --- Comment #8 from QA Administrators --- Dear raal, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 127973] Sidebar: Measurement unit's not initialized with char unit
https://bugs.documentfoundation.org/show_bug.cgi?id=127973 --- Comment #4 from QA Administrators --- Dear Oliver Brinzing, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 127804] copy/paste using alt key reverses lines
https://bugs.documentfoundation.org/show_bug.cgi?id=127804 --- Comment #5 from QA Administrators --- Dear Robert L Margulski, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 123005] FILEOPEN: Error on creating getCurrentController().getActiveSheet() for basic script from location=document ?
https://bugs.documentfoundation.org/show_bug.cgi?id=123005 --- Comment #17 from QA Administrators --- Dear Taka~ TIDA, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150642] FILEOPEN DOCX Table structure destroyed if cell with vertical text direction exists
https://bugs.documentfoundation.org/show_bug.cgi?id=150642 Kevin Suo changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||1055 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151055] Table is corrupted when vertical Text Orientation is enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=151055 Kevin Suo changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||0642 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 115645] Should be able to permanently delete comments with track changes enabled.
https://bugs.documentfoundation.org/show_bug.cgi?id=115645 Aron Budea changed: What|Removed |Added CC||aron.bu...@gmail.com --- Comment #9 from Aron Budea --- Created attachment 182559 --> https://bugs.documentfoundation.org/attachment.cgi?id=182559=edit Non-straightforward sample 1. It's possible to accept a tracked comment deletion by right-clicking around where the comment is placed in the text, and choosing Accept Change. 2. This isn't always straightforward. In the attached sample, the comment and the surrounding text is deleted in one go (eg. by selecting the whole paragraph, and hitting Del/backspace). In this case there'd be no way to finalize only the comment removal, as the whole deletion is a single change. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 115645] Should be able to permanently delete comments with track changes enabled.
https://bugs.documentfoundation.org/show_bug.cgi?id=115645 Aron Budea changed: What|Removed |Added Ever confirmed|1 |0 Status|REOPENED|UNCONFIRMED -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 115645] Should be able to permanently delete comments with track changes enabled.
https://bugs.documentfoundation.org/show_bug.cgi?id=115645 Aron Budea changed: What|Removed |Added Ever confirmed|1 |0 Status|REOPENED|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 115645] Should be able to permanently delete comments with track changes enabled.
https://bugs.documentfoundation.org/show_bug.cgi?id=115645 Aron Budea changed: What|Removed |Added CC||aron.bu...@gmail.com --- Comment #9 from Aron Budea --- Created attachment 182559 --> https://bugs.documentfoundation.org/attachment.cgi?id=182559=edit Non-straightforward sample 1. It's possible to accept a tracked comment deletion by right-clicking around where the comment is placed in the text, and choosing Accept Change. 2. This isn't always straightforward. In the attached sample, the comment and the surrounding text is deleted in one go (eg. by selecting the whole paragraph, and hitting Del/backspace). In this case there'd be no way to finalize only the comment removal, as the whole deletion is a single change. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-ux-advise] [Bug 151063] Rename "Index marks" to "Index entries" (if the latter is correct)
https://bugs.documentfoundation.org/show_bug.cgi?id=151063 Telesto changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||tele...@surfxs.nl Keywords||needsUXEval -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 151063] Rename "Index marks" to "Index entries" (if the latter is correct)
https://bugs.documentfoundation.org/show_bug.cgi?id=151063 Telesto changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||tele...@surfxs.nl Keywords||needsUXEval -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150628] most URIs can't be hyperlinked
https://bugs.documentfoundation.org/show_bug.cgi?id=150628 --- Comment #2 from David Melik --- Good. In future; not yet besides standard (in related/such Internet Engineering Task First (IETF.org) Requests for Comments (RFCs)) example.com. news://news.example.com nntp://news.example.com/news.groups irc://irc.example.com ssh://u...@example.com common for IRC bots: telnet://127.0.0.1 was common; recommended don't except to a local host (SSH for remote): telnet://user:password@example:port It's unlikely example.com hosts such services/servers/daemons if you want to test (unnecessary for this enhancement... all URIs are in Internet RFCs). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 125965] [META] Sifr icons
https://bugs.documentfoundation.org/show_bug.cgi?id=125965 Rizal Muttaqin changed: What|Removed |Added Depends on||151071 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=151071 [Bug 151071] Revise Sifr to Follow Upstream (Adwaita) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151071] Revise Sifr to Follow Upstream (Adwaita)
https://bugs.documentfoundation.org/show_bug.cgi?id=151071 Rizal Muttaqin changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |riz...@libreoffice.org |desktop.org | Blocks||125965 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=125965 [Bug 125965] [META] Sifr icons -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151071] New: Revise Sifr to Follow Upstream (Adwaita)
https://bugs.documentfoundation.org/show_bug.cgi?id=151071 Bug ID: 151071 Summary: Revise Sifr to Follow Upstream (Adwaita) Product: LibreOffice Version: 7.5.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: riz...@libreoffice.org Created attachment 182558 --> https://bugs.documentfoundation.org/attachment.cgi?id=182558=edit Adwaita (top, latest as current bug written) vs Sifr (below) The Sifr icon theme was historically an advanced derivative version of the GNOME icon theme which is now known as Adwaita. GNOME UI has evolved a lot, including in this case its icon themes. Currently the symbolic version of Adwaita's icon theme has a rounded look, but still retains its cuteness. Meanwhile Sifr still maintains a look that has sharp corners. Apart from that, in many ways, it seems to me personally that it is not harmonious, tends to be childish and messy. This bug report intends to suggest a change in Sifr, so that it follows the rhythm that is sung by Adwaita. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151064] CRASH: executing macro with .uno:InsertObjectChart
https://bugs.documentfoundation.org/show_bug.cgi?id=151064 Rafael Lima changed: What|Removed |Added CC||rafael.palma.l...@gmail.com --- Comment #1 from Rafael Lima --- The macro worked for me in: Version: 7.3.5.2 / LibreOffice Community Build ID: 30(Build:2) CPU threads: 12; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Ubuntu package version: 1:7.3.5-0ubuntu0.22.04.1 Calc: threaded It also works in Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: 8b5a989dcdcf4edd50c9fdb092d4180432ce4b6a CPU threads: 12; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: CL threaded The macro created an empty column chart (I did not have any data in sheet Table1). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151068] Add calculated tooltips to cells
https://bugs.documentfoundation.org/show_bug.cgi?id=151068 Rafael Lima changed: What|Removed |Added CC||rafael.palma.l...@gmail.com --- Comment #2 from Rafael Lima --- Apparently users have worked around the lack of actual tooltips in cells using Comments [1] or Help messages from Validity rules [2]. [1] https://forum.openoffice.org/en/forum/viewtopic.php?f=9=64099 [2] https://ask.libreoffice.org/t/custom-mouseover-tooltips-on-cells/50958 However, none of them are dynamic, i.e. whose tooltip text would depend on the cell contents. I have already found myself needing a feature similar as this one. Maybe we could have a tooltip option where a possible value would be a Calc formula that generates the tooltip. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103238] [META] Customize dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103238 Bug 103238 depends on bug 112237, which changed state. Bug 112237 Summary: Add the multiline tooltip on the Available Commands also to the Assigned Commands in the Customize dialog https://bugs.documentfoundation.org/show_bug.cgi?id=112237 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: cui/source cui/uiconfig
cui/source/customize/SvxNotebookbarConfigPage.cxx | 22 +++--- cui/source/customize/cfg.cxx | 16 cui/source/inc/SvxNotebookbarConfigPage.hxx |1 + cui/source/inc/cfg.hxx|1 + cui/uiconfig/ui/menuassignpage.ui |2 ++ 5 files changed, 39 insertions(+), 3 deletions(-) New commits: commit e79741488cc740f49ebd4426c40b45e7139ff663 Author: Jim Raykowski AuthorDate: Fri Sep 16 15:56:49 2022 -0800 Commit: Jim Raykowski CommitDate: Tue Sep 20 00:41:04 2022 +0200 tdf#112237 Show tooltips for Assigned Commands in Customize dialog Change-Id: Iff1946d5d6ac7f2046d36df8fbd76e32edf371c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140142 Tested-by: Jenkins Reviewed-by: Jim Raykowski diff --git a/cui/source/customize/SvxNotebookbarConfigPage.cxx b/cui/source/customize/SvxNotebookbarConfigPage.cxx index 99c15b8f3ca9..91ce6352ddca 100644 --- a/cui/source/customize/SvxNotebookbarConfigPage.cxx +++ b/cui/source/customize/SvxNotebookbarConfigPage.cxx @@ -240,7 +240,7 @@ void SvxConfigPage::InsertEntryIntoNotebookbarTabUI(std::u16string_view sClassId if (xImage.is()) rTreeView.set_image(rIter, xImage, -1); rTreeView.set_text(rIter, aName, 0); -rTreeView.set_id(rIter, sUIItemId); +rTreeView.set_id(rIter, sUIItemCommand); } } @@ -438,8 +438,6 @@ void SvxNotebookbarConfigPage::SelectElement() weld::TreeView& rTreeView = m_xContentsListBox->get_widget(); rTreeView.bulk_insert_for_each( aEntries.size(), [this, , ](weld::TreeIter& rIter, int nIdx) { -OUString sId(OUString::number(nIdx)); -rTreeView.set_id(rIter, sId); if (aEntries[nIdx].sActionName != "Null") { if (aEntries[nIdx].sVisibleValue == "True") @@ -467,6 +465,9 @@ SvxNotebookbarEntriesListBox::SvxNotebookbarEntriesListBox(std::unique_ptrconnect_toggled(LINK(this, SvxNotebookbarEntriesListBox, CheckButtonHdl)); m_xControl->connect_key_press(Link()); m_xControl->connect_key_press(LINK(this, SvxNotebookbarEntriesListBox, KeyInputHdl)); +// remove the inherited connect_query_tooltip then add the new one +m_xControl->connect_query_tooltip(Link()); +m_xControl->connect_query_tooltip(LINK(this, SvxNotebookbarEntriesListBox, QueryTooltip)); } SvxNotebookbarEntriesListBox::~SvxNotebookbarEntriesListBox() {} @@ -540,4 +541,19 @@ IMPL_LINK(SvxNotebookbarEntriesListBox, KeyInputHdl, const KeyEvent&, rKeyEvent, return SvxMenuEntriesListBox::KeyInputHdl(rKeyEvent); } +IMPL_LINK(SvxNotebookbarEntriesListBox, QueryTooltip, const weld::TreeIter&, rIter, OUString) +{ +OUString sCommand = m_xControl->get_id(rIter); +if (sCommand.isEmpty()) +return OUString(); +OUString aModuleName(vcl::CommandInfoProvider::GetModuleIdentifier(m_pPage->GetFrame())); +auto aProperties = vcl::CommandInfoProvider::GetCommandProperties(sCommand, aModuleName); +OUString sTooltipLabel = vcl::CommandInfoProvider::GetTooltipForCommand(sCommand, aProperties, + m_pPage->GetFrame()); +return CuiResId(RID_CUISTR_COMMANDLABEL) + ": " + + m_xControl->get_text(rIter).replaceFirst("~", "") + "\n" + + CuiResId(RID_CUISTR_COMMANDNAME) + ": " + sCommand + "\n" + + CuiResId(RID_CUISTR_COMMANDTIP) + ": " + sTooltipLabel.replaceFirst("~", ""); +} + /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/cui/source/customize/cfg.cxx b/cui/source/customize/cfg.cxx index eefa264ba3bd..f5ed658512e9 100644 --- a/cui/source/customize/cfg.cxx +++ b/cui/source/customize/cfg.cxx @@ -937,6 +937,7 @@ SvxMenuEntriesListBox::SvxMenuEntriesListBox(std::unique_ptr xCo m_xControl->enable_toggle_buttons(weld::ColumnToggleType::Check); CreateDropDown(); m_xControl->connect_key_press(LINK(this, SvxMenuEntriesListBox, KeyInputHdl)); +m_xControl->connect_query_tooltip(LINK(this, SvxMenuEntriesListBox, QueryTooltip)); } SvxMenuEntriesListBox::~SvxMenuEntriesListBox() @@ -968,6 +969,21 @@ IMPL_LINK(SvxMenuEntriesListBox, KeyInputHdl, const KeyEvent&, rKeyEvent, bool) return true; } +IMPL_LINK(SvxMenuEntriesListBox, QueryTooltip, const weld::TreeIter&, rIter, OUString) +{ +SvxConfigEntry *pEntry = weld::fromId(m_xControl->get_id(rIter)); +if (!pEntry || pEntry->GetCommand().isEmpty()) +return OUString(); +const OUString sCommand(pEntry->GetCommand()); +OUString aModuleName(vcl::CommandInfoProvider::GetModuleIdentifier(m_pPage->GetFrame())); +auto aProperties = vcl::CommandInfoProvider::GetCommandProperties(sCommand, aModuleName); +OUString sTooltipLabel = vcl::CommandInfoProvider::GetTooltipForCommand(sCommand, aProperties, +
[Libreoffice-bugs] [Bug 32950] FILEOPEN XLS: Cell height may be wrong because 'Optimal height" of rows is not re-calculated at load time.
https://bugs.documentfoundation.org/show_bug.cgi?id=32950 --- Comment #31 from Justin L --- This bSetRowHeights was true earlier (and called UpdateAllRowHeights), until commit c3ce9a34e710538aee37def65d0077af18140bcb Author: Daniel Rentz on Tue Oct 23 13:51:33 2001 + #93255# speed up chart import bSetRowHeights started calling the brand new ScDocRowHeightUpdater with commit 0cfa5a12cc75e95f26fb6d8b348045bf8ba9bdd1 Author: Kohei Yoshida on Fri Oct 1 22:30:59 2010 -0400 Ported calc-perf-import-dbf-sc.diff from ooo-build This speeds up import of dBase (dbf) files 4-5 times. and as noted in comment 27, ScDocRowHeightUpdater is also used with ODS import. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151068] Add calculated tooltips to cells
https://bugs.documentfoundation.org/show_bug.cgi?id=151068 --- Comment #1 from Eike Rathke --- Do you mean a calculated tooltip like a formula expression with relative references that recalculates on each cell hovered over? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - vcl/win
vcl/win/window/salframe.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 286000f2df456cffabd678e3bde56af14c7bd185 Author: Caolán McNamara AuthorDate: Mon Sep 19 17:26:15 2022 +0100 Commit: Adolfo Jayme Barrientos CommitDate: Mon Sep 19 23:58:57 2022 +0200 tdf#151052 set Windows darkmode "ToolTextColor" to same as "WindowTextColor" they are the same in light mode, so do the same in darkmode Change-Id: Ib0186383fcd7f8d74c7ada6826c6955a747e4ecd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140162 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/vcl/win/window/salframe.cxx b/vcl/win/window/salframe.cxx index 2ae47ec57630..db4da4e3e076 100644 --- a/vcl/win/window/salframe.cxx +++ b/vcl/win/window/salframe.cxx @@ -2667,6 +2667,7 @@ void WinSalFrame::UpdateSettings( AllSettings& rSettings ) aStyleSettings.SetWindowColor( ImplWinColorToSal( color ) ); GetThemeColor(hTheme, 0, 0, TMT_TEXTCOLOR, ); aStyleSettings.SetWindowTextColor( ImplWinColorToSal( color ) ); +aStyleSettings.SetToolTextColor( ImplWinColorToSal( color ) ); CloseThemeData(hTheme); hTheme = OpenThemeData(mhWnd, L"Button"); @@ -2694,6 +2695,7 @@ void WinSalFrame::UpdateSettings( AllSettings& rSettings ) aStyleSettings.SetFaceColor( ImplWinColorToSal( GetSysColor( COLOR_3DFACE ) ) ); aStyleSettings.SetWindowColor( ImplWinColorToSal( GetSysColor( COLOR_WINDOW ) ) ); aStyleSettings.SetWindowTextColor( ImplWinColorToSal( GetSysColor( COLOR_WINDOWTEXT ) ) ); +aStyleSettings.SetToolTextColor( ImplWinColorToSal( GetSysColor( COLOR_WINDOWTEXT ) ) ); aControlTextColor = ImplWinColorToSal(GetSysColor(COLOR_BTNTEXT)); aStyleSettings.SetRadioCheckTextColor( ImplWinColorToSal( GetSysColor( COLOR_WINDOWTEXT ) ) ); aStyleSettings.SetMenuTextColor( ImplWinColorToSal( GetSysColor( COLOR_MENUTEXT ) ) ); @@ -2744,7 +2746,6 @@ void WinSalFrame::UpdateSettings( AllSettings& rSettings ) aStyleSettings.SetGroupTextColor( aStyleSettings.GetRadioCheckTextColor() ); aStyleSettings.SetLabelTextColor( aStyleSettings.GetRadioCheckTextColor() ); aStyleSettings.SetActiveTabColor( aStyleSettings.GetWindowColor() ); -aStyleSettings.SetToolTextColor( ImplWinColorToSal( GetSysColor( COLOR_WINDOWTEXT ) ) ); aStyleSettings.SetFieldColor( aStyleSettings.GetWindowColor() ); aStyleSettings.SetFieldTextColor( aStyleSettings.GetWindowTextColor() ); aStyleSettings.SetFieldRolloverTextColor( aStyleSettings.GetFieldTextColor() );
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 032e1aee7aaae04ca7aaa7792ba49849364fd249 Author: Adolfo Jayme Barrientos AuthorDate: Mon Sep 19 16:52:15 2022 -0500 Commit: Gerrit Code Review CommitDate: Mon Sep 19 23:52:15 2022 +0200 Update git submodules * Update helpcontent2 from branch 'master' to 80034ff19535b6320a8ea113a9cf2f068e6aea31 - Wrong words Change-Id: I391a5fd97005fcffac324581856bbdb8a48f1ae9 diff --git a/helpcontent2 b/helpcontent2 index 4b86dd440667..80034ff19535 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 4b86dd440667832cd5510a1bd31ff35514532d06 +Subproject commit 80034ff19535b6320a8ea113a9cf2f068e6aea31
[Libreoffice-commits] help.git: source/text
source/text/shared/guide/ctl.xhp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 80034ff19535b6320a8ea113a9cf2f068e6aea31 Author: Adolfo Jayme Barrientos AuthorDate: Mon Sep 19 16:51:43 2022 -0500 Commit: Adolfo Jayme Barrientos CommitDate: Mon Sep 19 16:52:00 2022 -0500 Wrong words Change-Id: I391a5fd97005fcffac324581856bbdb8a48f1ae9 diff --git a/source/text/shared/guide/ctl.xhp b/source/text/shared/guide/ctl.xhp index 099ce00ef..edf50297f 100644 --- a/source/text/shared/guide/ctl.xhp +++ b/source/text/shared/guide/ctl.xhp @@ -42,7 +42,7 @@ Currently, $[officename] supports Hindi, Thai, Hebrew, and Arabic as CTL languages. If you select the text flow from right to left, embedded Western text still runs from left to right. The cursor responds to the arrow keys in that Right Arrow moves it "to the text end" and Left Arrow "to the text start". -You can change the text writing direction directly be pressing one of the following keys: +You can change the text writing direction directly by pressing one of the following key combinations: CommandCtrl+Shift+D or CommandCtrl+Right Shift Key - switch to right-to-left text entry
[Libreoffice-bugs] [Bug 151070] Consistency between dependent objects
https://bugs.documentfoundation.org/show_bug.cgi?id=151070 Adolfo Jayme Barrientos changed: What|Removed |Added Ever confirmed|0 |1 Assignee|libreoffice-b...@lists.free |fit...@ubuntu.com |desktop.org | Status|UNCONFIRMED |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/qa
sc/qa/unit/ucalc_formula.cxx | 25 + 1 file changed, 25 insertions(+) New commits: commit 3e65f33d450e512c31eeafc80956ada1cfade903 Author: Xisco Fauli AuthorDate: Mon Sep 19 17:01:15 2022 +0200 Commit: Xisco Fauli CommitDate: Mon Sep 19 23:48:15 2022 +0200 tdf#132519: sc_ucalc_formula: Add unittest Change-Id: Ie2ff5a8961556cf21ca75a58d46f37754e0bb61b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140183 Tested-by: Jenkins Reviewed-by: Xisco Fauli diff --git a/sc/qa/unit/ucalc_formula.cxx b/sc/qa/unit/ucalc_formula.cxx index 7463f1a23f57..1ade8026f3bc 100644 --- a/sc/qa/unit/ucalc_formula.cxx +++ b/sc/qa/unit/ucalc_formula.cxx @@ -243,6 +243,7 @@ public: void testTdf97369(); void testTdf97587(); void testTdf93415(); +void testTdf132519(); void testTdf100818(); void testMatConcat(); void testMatConcatReplication(); @@ -363,6 +364,7 @@ public: CPPUNIT_TEST(testTdf97369); CPPUNIT_TEST(testTdf97587); CPPUNIT_TEST(testTdf93415); +CPPUNIT_TEST(testTdf132519); CPPUNIT_TEST(testTdf100818); CPPUNIT_TEST(testMatConcat); CPPUNIT_TEST(testMatConcatReplication); @@ -8901,6 +8903,29 @@ void TestFormula::testTdf93415() m_pDoc->DeleteTab(0); } +void TestFormula::testTdf132519() +{ +CPPUNIT_ASSERT(m_pDoc->InsertTab (0, "Sheet1")); + +ScCalcConfig aConfig; +aConfig.SetStringRefSyntax( formula::FormulaGrammar::CONV_XL_R1C1 ); +m_pDoc->SetCalcConfig(aConfig); +m_pDoc->CalcAll(); + +m_pDoc->SetString(2, 0, 0, "X"); +m_pDoc->SetString(1, 0, 0, "=CELL(\"ADDRESS\"; C1)"); +m_pDoc->SetString(0, 0, 0, "=INDIRECT(B1)"); + +// Without the fix in place, this test would have failed with +// - Expected: X +// - Actual : #REF! +CPPUNIT_ASSERT_EQUAL(OUString("X"), m_pDoc->GetString(0,0,0)); + +CPPUNIT_ASSERT_EQUAL(OUString("R1C3"), m_pDoc->GetString(1,0,0)); + +m_pDoc->DeleteTab(0); +} + void TestFormula::testTdf100818() { CPPUNIT_ASSERT(m_pDoc->InsertTab (0, "Sheet1"));
[Libreoffice-bugs] [Bug 150892] Base: Form window lost title in KDE
https://bugs.documentfoundation.org/show_bug.cgi?id=150892 Rafael Lima changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #10 from Rafael Lima --- (In reply to Michael Weghorn from comment #7) > Created attachment 182553 [details] > Screenshot with title with kf5 (Debian testing, Plasma) I am using Plasma 5.25.5 and I get the same result as Michael. The window title appears as expected, both in 7.4 and 7.5. Works in Version: 7.4.0.3 / LibreOffice Community Build ID: f85e47c08ddd19c015c0114a68350214f7066f5a CPU threads: 12; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: threaded Also works in Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: 8b5a989dcdcf4edd50c9fdb092d4180432ce4b6a CPU threads: 12; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151065] Incomplete sentence: "Select the brackets that you want to enclose bibliography entries."
https://bugs.documentfoundation.org/show_bug.cgi?id=151065 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #2 from V Stuart Foote --- "Select the brackets used to enclose bibliography entries" would be simpler and easier for l10n translators. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/qa
sc/qa/unit/data/ods/tdf151046.ods |binary sc/qa/unit/subsequent_filters_test.cxx | 19 +++ 2 files changed, 19 insertions(+) New commits: commit dfa01bb05cc82811cdc306285a31c51816f81c6a Author: Xisco Fauli AuthorDate: Mon Sep 19 17:18:11 2022 +0200 Commit: Xisco Fauli CommitDate: Mon Sep 19 23:40:19 2022 +0200 tdf#151046: sc_subsequent_filters: Add unittest Change-Id: I552d53f511373b170985185361621d8e149e582b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140184 Tested-by: Jenkins Reviewed-by: Xisco Fauli diff --git a/sc/qa/unit/data/ods/tdf151046.ods b/sc/qa/unit/data/ods/tdf151046.ods new file mode 100644 index ..bcda940c3293 Binary files /dev/null and b/sc/qa/unit/data/ods/tdf151046.ods differ diff --git a/sc/qa/unit/subsequent_filters_test.cxx b/sc/qa/unit/subsequent_filters_test.cxx index 9149d4379db4..d7a6ee45b616 100644 --- a/sc/qa/unit/subsequent_filters_test.cxx +++ b/sc/qa/unit/subsequent_filters_test.cxx @@ -171,6 +171,7 @@ public: void testCellAnchoredHiddenShapesXLSX(); void testFormulaDependency(); +void testTdf151046(); void testRowHeightODS(); void testRichTextContentODS(); @@ -266,6 +267,7 @@ public: CPPUNIT_TEST(testRowHeightODS); CPPUNIT_TEST(testFormulaDependency); +CPPUNIT_TEST(testTdf151046); CPPUNIT_TEST(testRichTextContentODS); //disable testPassword on MacOSX due to problems with libsqlite3 @@ -2980,6 +2982,23 @@ void ScFiltersTest::testFormulaDependency() xDocSh->DoClose(); } +void ScFiltersTest::testTdf151046() +{ +ScDocShellRef xDocSh = loadDoc(u"tdf151046.", FORMAT_ODS); + +ScDocument& rDoc = xDocSh->GetDocument(); + +CPPUNIT_ASSERT_EQUAL(1.0, rDoc.GetValue(0, 0, 0)); +CPPUNIT_ASSERT_EQUAL(1.0, rDoc.GetValue(0, 1, 0)); + +// Without the fix in place, this test would have failed with +// - Expected: 1 +// - Actual : 0 +CPPUNIT_ASSERT_EQUAL(1.0, rDoc.GetValue(0, 2, 0)); + +xDocSh->DoClose(); +} + void ScFiltersTest::testImportCrashes() { testImportCrash(u"tdf149752.", FORMAT_ODS); testImportCrash(u"tdf122643.", FORMAT_ODS);
[Libreoffice-bugs] [Bug 151070] Consistency between dependent objects
https://bugs.documentfoundation.org/show_bug.cgi?id=151070 --- Comment #3 from Leandro Martín Drudi --- Created attachment 182557 --> https://bugs.documentfoundation.org/attachment.cgi?id=182557=edit Other settings that maintain consistency in the same dialog box. In order to select the transparency level, I must select the 'Transparency' option; to access the configuration of the other objects I must select 'Gradient'. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151066] Reload breaks Calc save icon properly showing document changed and not saved red circle
https://bugs.documentfoundation.org/show_bug.cgi?id=151066 Rafael Lima changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #2 from Rafael Lima --- What icon theme are you using? This may be related to a specific icon theme. To see that, go to Tools - Options - View and see which option is selected in Icon Theme (or Icon Style) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151070] Consistency between dependent objects
https://bugs.documentfoundation.org/show_bug.cgi?id=151070 --- Comment #2 from Leandro Martín Drudi --- Created attachment 182556 --> https://bugs.documentfoundation.org/attachment.cgi?id=182556=edit Suggested change -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151070] Consistency between dependent objects
https://bugs.documentfoundation.org/show_bug.cgi?id=151070 --- Comment #1 from Leandro Martín Drudi --- Created attachment 182555 --> https://bugs.documentfoundation.org/attachment.cgi?id=182555=edit This is the current order of the objects. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151070] New: Consistency between dependent objects
https://bugs.documentfoundation.org/show_bug.cgi?id=151070 Bug ID: 151070 Summary: Consistency between dependent objects Product: LibreOffice Version: 7.4.1.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sanipache...@outlook.com.ar Description: When there are dependent objects, the main one is above and the dependent ones below. Some remain disabled until a certain value is selected in the main object, and even appear further to the right of the main object denoting that it is dependent on the topmost object. I have noticed that this is not true in Writer's page style settings. The dependent object "Reference Style", which depends on the "Use page line-spacing" checkbox being checked, would not be respecting this consistency. Steps to Reproduce: 1. Open LibreOffice. 2. Select Writer document 3. Edit or create a new page style. 4. Click on the Page tab. 5. Check 'Use page line-spacing'. 6. The Reference style combobox is enabled. --- 7. Uncheck 'Use page line-spacing'. 8. The Reference style combobox is disabled. Actual Results: The 'Use page line-spacing' checkbox is is below 'Reference style' combobox which is dependent on the state of the checkbox Expected Results: The check box 'Use page line-spacing' should be moved above the combo box 'Reference style'. Reproducible: Always User Profile Reset: Yes Additional Info: This would maintain consistency with respect to other dependent objects, even within the same dialog box. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 32950] FILEOPEN XLS: Cell height may be wrong because 'Optimal height" of rows is not re-calculated at load time.
https://bugs.documentfoundation.org/show_bug.cgi?id=32950 --- Comment #30 from Justin L --- (In reply to Justin L from comment #28) > This is fairly easily fixed for XLS The code change is here. https://gerrit.libreoffice.org/c/core/+/140199 It shows good potential, with only one unit test failing, and that at least partly is because XLSX also needs a fix like this. But even so, empty rows are calculated differently, so the unit test still fails when XLSX is also "fixed". For now, I leave this as a code pointer only. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/win
vcl/win/gdi/salfont.cxx |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) New commits: commit e9262729e6b41065596af8092905bafe986803e9 Author: Stephan Bergmann AuthorDate: Sat Sep 17 12:52:53 2022 +0200 Commit: Stephan Bergmann CommitDate: Mon Sep 19 23:14:05 2022 +0200 loplugin:unreffun (clang-cl) ...and with ScopedFontHDC::fsp gone, there appears to be no reason to keep ScopedFontHDC::m_aFSP alive for the whole lifetime of the ScopedFontHDC instance Change-Id: I1028bc24f49f3bbaf6e23c09aef4459418267154 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140100 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/vcl/win/gdi/salfont.cxx b/vcl/win/gdi/salfont.cxx index a126dffb3ebd..058c24284cc9 100644 --- a/vcl/win/gdi/salfont.cxx +++ b/vcl/win/gdi/salfont.cxx @@ -1456,15 +1456,15 @@ class ScopedFontHDC final public: explicit ScopedFontHDC(WinSalGraphics& rGraphics, const vcl::font::PhysicalFontFace& rFontFace) // use height=1000 for easier debugging (to match psprint's font units) -: m_aFSP(rFontFace, Size(0,1000), 1000.0, 0, false) -, m_hDC(nullptr) +: m_hDC(nullptr) , m_hOrigFont(nullptr) { m_hDC = CreateCompatibleDC(rGraphics.getHDC()); if (!m_hDC) return; -rGraphics.ImplDoSetFont(m_hDC, m_aFSP, , m_hOrigFont); +vcl::font::FontSelectPattern aFSP(rFontFace, Size(0,1000), 1000.0, 0, false); +rGraphics.ImplDoSetFont(m_hDC, aFSP, , m_hOrigFont); } ~ScopedFontHDC() @@ -1476,10 +1476,8 @@ public: } HDC hdc() const { return m_hDC; } -const vcl::font::FontSelectPattern& fsp() const { return m_aFSP; } private: -vcl::font::FontSelectPattern m_aFSP; HDC m_hDC; HFONT m_hOrigFont; };
[Libreoffice-bugs] [Bug 151066] Reload breaks Calc save icon properly showing document changed and not saved red circle
https://bugs.documentfoundation.org/show_bug.cgi?id=151066 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m.a.riosv --- Works for me Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: bfb0dbee201a69c26293947c78356f320ff62a0b CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Version: 7.3.6.2 (x64) / LibreOffice Community Build ID: c28ca90fd6e1a19e189fc16c05f8f8924961e12e CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151069] New: When running Calc the program crashes immediately if JAWS (screen reader) is in use. JAWS version is 2022 latest build. I have tested with NVDA and Narrator and bo
https://bugs.documentfoundation.org/show_bug.cgi?id=151069 Bug ID: 151069 Summary: When running Calc the program crashes immediately if JAWS (screen reader) is in use. JAWS version is 2022 latest build. I have tested with NVDA and Narrator and both work with no issues. Also currently no issues with any screen reader using Writer (no o Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: petetor...@cwgsy.net -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150236] Does not open full screen, ooSetupFactoryWindowAttributes not being filled ( steps in comment 21 ) ( LibreOffice 7.4 only )
https://bugs.documentfoundation.org/show_bug.cgi?id=150236 V Stuart Foote changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=15 | |0615| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150615] Window position/size not respected when opening from a file
https://bugs.documentfoundation.org/show_bug.cgi?id=150615 V Stuart Foote changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=15 | |0236| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104371] Window size is minuscule when unmaximizing after a LibreOffice app was started maximized
https://bugs.documentfoundation.org/show_bug.cgi?id=104371 stragu changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||5543 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 125543] unmaximizing the window reduces to minimal width and height, making window barely visible (Linux-only)
https://bugs.documentfoundation.org/show_bug.cgi?id=125543 stragu changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||4371 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151067] Window opens minimized on start of Libreoffice writer or any other component
https://bugs.documentfoundation.org/show_bug.cgi?id=151067 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #2 from V Stuart Foote --- This has been corrected for the 7.4.2 release, but you can test a nightly against master, or of the 7.4 branch. -- https://dev-builds.libreoffice.org/daily/ *** This bug has been marked as a duplicate of bug 150779 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150236] Does not open full screen, ooSetupFactoryWindowAttributes not being filled ( steps in comment 21 ) ( LibreOffice 7.4 only )
https://bugs.documentfoundation.org/show_bug.cgi?id=150236 m.a.riosv changed: What|Removed |Added CC||h...@eck-dv.de --- Comment #67 from m.a.riosv --- *** Bug 151067 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151067] Window opens minimized on start of Libreoffice writer or any other component
https://bugs.documentfoundation.org/show_bug.cgi?id=151067 m.a.riosv changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #1 from m.a.riosv --- *** This bug has been marked as a duplicate of bug 150236 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150915] [META] Windows Dark Mode bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=150915 Bug 150915 depends on bug 151052, which changed state. Bug 151052 Summary: Find Bar's "Find All" button text invisible in dark mode, Windows https://bugs.documentfoundation.org/show_bug.cgi?id=151052 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151068] New: Add calculated tooltips to cells
https://bugs.documentfoundation.org/show_bug.cgi?id=151068 Bug ID: 151068 Summary: Add calculated tooltips to cells Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rob...@prino.org When hovering over cells, it's possible to show tooltips. What would for me, and the people around me, really be an absolute killer feature if a tooltip could change dynamically, i.e. if hovering over a cell on the cross-roads between day-of-the-month and weekday, it would for example show us the month when the ***next***, just to give an example, Friday the 13th would be, based on the 1st row/column data, and the today() function as a formula inside the tooltip, with the update only triggered upon hovering for "longer" over the cell, where "longer" is a user-defined time. And yes, it's obviously possible to do this in another always visible cell, but if your sheet is big, this "other" cell may require scrolling, whether to reach this info, or if it's next to the cell, to reach other cells with "real" data. No clue is something like this is present in "that" (or any other) product, but I wouldn't be surprised if MS also keeps an eye on what's happening here... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/win
vcl/win/window/salframe.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 2f1ad908310918d964b2996ccf4e987b7b0af86f Author: Caolán McNamara AuthorDate: Mon Sep 19 17:26:15 2022 +0100 Commit: Caolán McNamara CommitDate: Mon Sep 19 22:25:54 2022 +0200 tdf#151052 set Windows darkmode "ToolTextColor" to same as "WindowTextColor" they are the same in light mode, so do the same in darkmode Change-Id: Ib0186383fcd7f8d74c7ada6826c6955a747e4ecd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140195 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/vcl/win/window/salframe.cxx b/vcl/win/window/salframe.cxx index 1d8d372e5053..9880613e7fa3 100644 --- a/vcl/win/window/salframe.cxx +++ b/vcl/win/window/salframe.cxx @@ -2640,6 +2640,7 @@ void WinSalFrame::UpdateSettings( AllSettings& rSettings ) aStyleSettings.SetWindowColor( ImplWinColorToSal( color ) ); GetThemeColor(hTheme, 0, 0, TMT_TEXTCOLOR, ); aStyleSettings.SetWindowTextColor( ImplWinColorToSal( color ) ); +aStyleSettings.SetToolTextColor( ImplWinColorToSal( color ) ); CloseThemeData(hTheme); hTheme = OpenThemeData(mhWnd, L"Button"); @@ -2667,6 +2668,7 @@ void WinSalFrame::UpdateSettings( AllSettings& rSettings ) aStyleSettings.SetFaceColor( ImplWinColorToSal( GetSysColor( COLOR_3DFACE ) ) ); aStyleSettings.SetWindowColor( ImplWinColorToSal( GetSysColor( COLOR_WINDOW ) ) ); aStyleSettings.SetWindowTextColor( ImplWinColorToSal( GetSysColor( COLOR_WINDOWTEXT ) ) ); +aStyleSettings.SetToolTextColor( ImplWinColorToSal( GetSysColor( COLOR_WINDOWTEXT ) ) ); aControlTextColor = ImplWinColorToSal(GetSysColor(COLOR_BTNTEXT)); aStyleSettings.SetRadioCheckTextColor( ImplWinColorToSal( GetSysColor( COLOR_WINDOWTEXT ) ) ); aStyleSettings.SetMenuTextColor( ImplWinColorToSal( GetSysColor( COLOR_MENUTEXT ) ) ); @@ -2717,7 +2719,6 @@ void WinSalFrame::UpdateSettings( AllSettings& rSettings ) aStyleSettings.SetGroupTextColor( aStyleSettings.GetRadioCheckTextColor() ); aStyleSettings.SetLabelTextColor( aStyleSettings.GetRadioCheckTextColor() ); aStyleSettings.SetActiveTabColor( aStyleSettings.GetWindowColor() ); -aStyleSettings.SetToolTextColor( ImplWinColorToSal( GetSysColor( COLOR_WINDOWTEXT ) ) ); aStyleSettings.SetFieldColor( aStyleSettings.GetWindowColor() ); aStyleSettings.SetListBoxWindowBackgroundColor( aStyleSettings.GetWindowColor() ); aStyleSettings.SetFieldTextColor( aStyleSettings.GetWindowTextColor() );
[Libreoffice-bugs] [Bug 92479] Make info data in status bar cut-able
https://bugs.documentfoundation.org/show_bug.cgi?id=92479 --- Comment #3 from rob...@prino.org --- Seven year itch, valid enhancement, so is this ever going to see the light of day? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 125543] unmaximizing the window reduces to minimal width and height, making window barely visible (Linux-only)
https://bugs.documentfoundation.org/show_bug.cgi?id=125543 stragu changed: What|Removed |Added CC||russell.g.alm...@gmail.com --- Comment #29 from stragu --- *** Bug 150079 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150079] Default window size in LibreOffice Draw is too small (X11)
https://bugs.documentfoundation.org/show_bug.cgi?id=150079 stragu changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED CC||stephane.guil...@member.fsf ||.org --- Comment #8 from stragu --- I'm going to go ahead and mark this as a duplicate of bug 125543, given that it actually has been confirmed with most components over there. *** This bug has been marked as a duplicate of bug 125543 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 119901] [META] Bugs related to maximized window
https://bugs.documentfoundation.org/show_bug.cgi?id=119901 stragu changed: What|Removed |Added Depends on||149510 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149510 [Bug 149510] LibreOffice windows in gnome 42 can be resized to be extremely small x11 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149510] LibreOffice windows in gnome 42 can be resized to be extremely small x11
https://bugs.documentfoundation.org/show_bug.cgi?id=149510 stragu changed: What|Removed |Added CC||stephane.guil...@member.fsf ||.org Status|NEW |NEEDINFO Blocks||119901 --- Comment #5 from stragu --- Thanks, oxyuyleilkibpxzasa. Could you please share your version information by copying and pasting it from "Help > About LibreOffice"? Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=119901 [Bug 119901] [META] Bugs related to maximized window -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 125543] unmaximizing the window reduces to minimal width and height, making window barely visible (Linux-only)
https://bugs.documentfoundation.org/show_bug.cgi?id=125543 stragu changed: What|Removed |Added Component|Calc|UI Version|unspecified |6.3 all versions Summary|Calc window width and |unmaximizing the window |height resize to zero when |reduces to minimal width |unmaximizing (Linux-only) |and height, making window ||barely visible ||(Linux-only) --- Comment #28 from stragu --- Removing "Calc" from summary and component as issue has been reported for Writer and Impress as well (as well as Dray in another report that I will probably mark as duplicate). Earliest known version from Description is 6.3 alpha1+, using "6.3 all versions" as it is not available. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151067] New: Window opens minimized on start of Libreoffice writer or any other component
https://bugs.documentfoundation.org/show_bug.cgi?id=151067 Bug ID: 151067 Summary: Window opens minimized on start of Libreoffice writer or any other component Product: LibreOffice Version: 7.4.1.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: h...@eck-dv.de If I start libreoffice, the application window opens minimized in the left upper corner of the screen. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/core/fields/reffld.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 8cc530b1ecbb706e998177ab6e85f33ac111b389 Author: Noel Grandin AuthorDate: Mon Sep 19 16:55:34 2022 +0200 Commit: Noel Grandin CommitDate: Mon Sep 19 21:29:10 2022 +0200 size this OUStringBuffer at initial construction Change-Id: I6414281cef5eedf1e797139695bf05c72c300447 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140181 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/sw/source/core/fields/reffld.cxx b/sw/source/core/fields/reffld.cxx index eb36f8d44f90..277540d12ee0 100644 --- a/sw/source/core/fields/reffld.cxx +++ b/sw/source/core/fields/reffld.cxx @@ -401,7 +401,7 @@ const SwTextNode* SwGetRefField::GetReferencedTextNode() const // strikethrough for tooltips using Unicode combining character static OUString lcl_formatStringByCombiningCharacter(const OUString& sText, const sal_Unicode cChar) { -OUStringBuffer sRet; +OUStringBuffer sRet(sText.getLength() * 2); for (sal_Int32 i = 0; i < sText.getLength(); ++i) { sRet.append(sText[i]);
[Libreoffice-commits] core.git: sc/source
sc/source/filter/xml/celltextparacontext.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit 648f06e583cf2cd878580c587afb5813c3db4e33 Author: Justin Luth AuthorDate: Mon Sep 19 12:26:22 2022 -0400 Commit: Justin Luth CommitDate: Mon Sep 19 21:22:39 2022 +0200 crashtesting: "unknown cell text: element" assert for text:bookmark #2 since... commit 690a35680adad07c4ab79d82cd1531bb82fe4bc1 Date: Sat Sep 10 16:32:46 2022 -0400 tdf#103829 ods import: parse From documentation, it looks like we can also have bookmark-start and bookmark-end, so adding these even though no examples found. I looked for how to insert bookmarks in calc - basically no UI or menu (except one notebookbar, no calc documentation, no abandoned bookmark code removal, no bookmark import code. IIUC, in writer a bookmark is basically a field. Perhaps it is similar in Calc? In any case, with this limited wealth of information, I don't plan on trying to fix the LO 4.1 loss of bookmark. Change-Id: I44708a5c7d69ce37f688ec7beb243e08844dbfa8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140197 Tested-by: Justin Luth Reviewed-by: Justin Luth diff --git a/sc/source/filter/xml/celltextparacontext.cxx b/sc/source/filter/xml/celltextparacontext.cxx index 88316798ee5f..5274a36f0599 100644 --- a/sc/source/filter/xml/celltextparacontext.cxx +++ b/sc/source/filter/xml/celltextparacontext.cxx @@ -70,6 +70,8 @@ uno::Reference< xml::sax::XFastContextHandler > SAL_CALL ScXMLCellTextParaContex maContent += "\x0a"; break; case XML_ELEMENT(TEXT, XML_BOOKMARK): +case XML_ELEMENT(TEXT, XML_BOOKMARK_START): +case XML_ELEMENT(TEXT, XML_BOOKMARK_END): // TODO: ooo95423-1 [file.ods] and tdf#116079-3 have these bookmarks. // Is this valid, and how can we prevent losing these? break;
[Libreoffice-commits] core.git: slideshow/source
slideshow/source/engine/shapes/drawshape.cxx |2 +- slideshow/source/engine/shapes/drawshape.hxx |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit c6c3e364697a908949409ab2c77d0e0b021b65d3 Author: Andrea Gelmini AuthorDate: Mon Sep 19 18:46:59 2022 +0200 Commit: Julien Nabet CommitDate: Mon Sep 19 21:21:21 2022 +0200 Fix typos Change-Id: If24b9756d7fd8f6346580b4da84fac4f5ab1d3ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140198 Tested-by: Julien Nabet Reviewed-by: Julien Nabet diff --git a/slideshow/source/engine/shapes/drawshape.cxx b/slideshow/source/engine/shapes/drawshape.cxx index bc50fc695375..f7ffbe1de622 100644 --- a/slideshow/source/engine/shapes/drawshape.cxx +++ b/slideshow/source/engine/shapes/drawshape.cxx @@ -401,7 +401,7 @@ namespace slideshow::internal // It lets us detect the potential error case that a PageField is contained in // the Text of the Shape. That is a hint that maBounds contains the wrong Range // and needs to be corrected. The correct size is in the PrefSize of the metafile. -// For more backgrund information please refer to tdf#150402, Comment 16. +// For more background information please refer to tdf#150402, Comment 16. const double fWidthDiff(fabs(mpCurrMtf->GetPrefSize().Width() - maBounds.getWidth())); const double fHeightDiff(fabs(mpCurrMtf->GetPrefSize().Height() - maBounds.getHeight())); diff --git a/slideshow/source/engine/shapes/drawshape.hxx b/slideshow/source/engine/shapes/drawshape.hxx index 4ede703cc982..6c71d151b6fa 100644 --- a/slideshow/source/engine/shapes/drawshape.hxx +++ b/slideshow/source/engine/shapes/drawshape.hxx @@ -349,7 +349,7 @@ namespace slideshow::internal /// whether a drawing layer animation has to be performed bool mbDrawingLayerAnim; -/// tdf#150402 wether mpCurrMtf contains any Text with a PageField ("FIELD_SEQ_BEGIN;PageField") +/// tdf#150402 whether mpCurrMtf contains any Text with a PageField ("FIELD_SEQ_BEGIN;PageField") mutable bool mbContainsPageField; };
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - writerfilter/source
writerfilter/source/dmapper/DomainMapperTableManager.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 3a457df72a832ee19d6c9b6da01aa88e83e203af Author: Xisco Fauli AuthorDate: Fri Sep 9 12:22:55 2022 +0200 Commit: Caolán McNamara CommitDate: Mon Sep 19 21:20:33 2022 +0200 writerfilter: avoid divide by zero in DomainMapperTableManager::endOfRowAction() See https://crashreport.libreoffice.org/stats/signature/writerfilter::dmapper::DomainMapperTableManager::endOfRowAction() Probably since 116cadb5d2582532c69677a2f8499e8e9b7b9b80 "tdf#59274 DOCX import: fix tables with incomplete grid" Change-Id: I12f2842107885fbbc62be2186511102f642e3efc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139657 Tested-by: Jenkins Reviewed-by: Caolán McNamara (cherry picked from commit b69a37e567a6a0b6c24a4438a0da906497c750f0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139660 diff --git a/writerfilter/source/dmapper/DomainMapperTableManager.cxx b/writerfilter/source/dmapper/DomainMapperTableManager.cxx index 127f9b067c4d..c3e44542d5f7 100644 --- a/writerfilter/source/dmapper/DomainMapperTableManager.cxx +++ b/writerfilter/source/dmapper/DomainMapperTableManager.cxx @@ -797,9 +797,6 @@ void DomainMapperTableManager::endOfRowAction() size_t nWidthsBound = pCellWidths->size() - 1; if (nWidthsBound) { -if (nFullWidthRelative == 0) -throw o3tl::divide_by_zero(); - // At incomplete table grids, last cell width can be smaller, than its final width. // Correct it based on the last but one column width and their span values. if ( bIsIncompleteGrid && rCurrentSpans.size()-1 == nWidthsBound ) @@ -810,6 +807,9 @@ void DomainMapperTableManager::endOfRowAction() nFullWidthRelative += nFixLastCellWidth - (*pCellWidths)[nWidthsBound]; } +if (nFullWidthRelative == 0) +throw o3tl::divide_by_zero(); + for (size_t i = 0; i < nWidthsBound; ++i) { nSum += (*pCellWidths)[i];
[Libreoffice-commits] core.git: drawinglayer/source
drawinglayer/source/processor2d/vclhelperbufferdevice.cxx |2 +- drawinglayer/source/processor2d/vclhelperbufferdevice.hxx |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) New commits: commit 31640cce53e850da53c75e3882375d286c0e9024 Author: Andrea Gelmini AuthorDate: Mon Sep 19 13:16:50 2022 +0200 Commit: Julien Nabet CommitDate: Mon Sep 19 21:20:17 2022 +0200 Fix typos Change-Id: If33ae9acbc1ed17398584efa3574566b2d854b3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140149 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/drawinglayer/source/processor2d/vclhelperbufferdevice.cxx b/drawinglayer/source/processor2d/vclhelperbufferdevice.cxx index fbb375417be3..f4373778ceb0 100644 --- a/drawinglayer/source/processor2d/vclhelperbufferdevice.cxx +++ b/drawinglayer/source/processor2d/vclhelperbufferdevice.cxx @@ -529,7 +529,7 @@ void impBufferDevice::paint(double fTrans) // Note: I am aware that the Dbg are of limited usefulness, but include them here // for reference. // -// The important part is "av. last 500 Former/New is %ld" which decribes the averaged factor from Former/New +// The important part is "av. last 500 Former/New is %ld" which describes the averaged factor from Former/New // over the last 500 measurements. When < 1.0 Former is better (Linux), > 1.0 (Win) New is better. Since the // factor on Win is still close to 1.0 what means we lose nearly nothing and Linux Former is better, I will // use Former for now. diff --git a/drawinglayer/source/processor2d/vclhelperbufferdevice.hxx b/drawinglayer/source/processor2d/vclhelperbufferdevice.hxx index f893ec79bb93..618fb38209a5 100644 --- a/drawinglayer/source/processor2d/vclhelperbufferdevice.hxx +++ b/drawinglayer/source/processor2d/vclhelperbufferdevice.hxx @@ -33,7 +33,7 @@ // - It initializes a 'Content' VDev which is buffered (since it had // shown that re-allocating all the time is slower). It checks // visibility and all usages initializing this should check for -// isVisible() after contruction. +// isVisible() after construction. // - It pre-initializes the 'Content' VDev with blitting the content // of the target VDev. // - It offers to get a 'Transparence' VDev (also from the buffer) if @@ -64,7 +64,7 @@ // // Note: This principle only works when the target is RGB, so // useful for EditViews like for PrimitiveRenderers where this is -// the case. For usage with GBA tragets the starting conditions +// the case. For usage with GBA targets the starting conditions // would have to be modified to not blend against the initial color // of 'Content' (usually COL_WHITE). //
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sw/source
sw/source/core/docnode/ndtbl1.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 49cdadd5878da393dc640a8f7ec75b98cb2e0147 Author: Xisco Fauli AuthorDate: Fri Sep 9 13:33:09 2022 +0200 Commit: Caolán McNamara CommitDate: Mon Sep 19 21:19:47 2022 +0200 sw: avoid divide by zero in SwDoc::AdjustCellWidth See https://crashreport.libreoffice.org/stats/signature/SwDoc::AdjustCellWidth(SwCursor%20const%20&,bool,bool) Change-Id: I98b90dcbed6b6f3ea0a7d1668a5c248f39e7a2a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139658 Reviewed-by: Miklos Vajna Tested-by: Jenkins (cherry picked from commit b884772e4aa3d6f438c8a74f3a15250530830162) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139661 Reviewed-by: Caolán McNamara diff --git a/sw/source/core/docnode/ndtbl1.cxx b/sw/source/core/docnode/ndtbl1.cxx index 4d0e38b794ab..923999f647cb 100644 --- a/sw/source/core/docnode/ndtbl1.cxx +++ b/sw/source/core/docnode/ndtbl1.cxx @@ -1626,7 +1626,8 @@ void SwDoc::AdjustCellWidth( const SwCursor& rCursor, } fTotalWish += aWish[i]; } -const sal_uInt16 nEqualWidth = nSelectedWidth / nCols; +assert(nCols); +const sal_uInt16 nEqualWidth = nCols ? nSelectedWidth / nCols : 0; // bBalance: Distribute the width evenly for (sal_uInt16 & rn : aWish) if ( rn && bBalance )
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - vcl/source
vcl/source/fontsubset/cff.cxx | 16 1 file changed, 8 insertions(+), 8 deletions(-) New commits: commit 3890b65ffa04c2cb9b4956ac65409d64b5c7f11c Author: Mike Kaganski AuthorDate: Sun Sep 18 17:30:22 2022 +0300 Commit: Caolán McNamara CommitDate: Mon Sep 19 21:18:26 2022 +0200 tdf#151039: use the same defaults also for FontSubsetInfo::m_aFontBBox The defaults for "maFontBBox is not valid" case were already introduced in commit 2d1f08d63942666c0094904f50ba8c512ab69b9d Author Release Engineers Date Thu Aug 27 12:02:29 2009 + CWS-TOOLING: integrate CWS otf01 but it used the four elements of maFontBBox unconditionally in later calculations. Possibly that code path is untested, because unless the wrong size is greater than 4, it would always crash. Unfortunately, use of { 0, 0, 0, 0 } here (as Khaled proposed in the bug, for "garbage in, garbage out" principle) is impossible: the PDF with such data shows an error in Acrobat Reader: "The font contains a bad /BBox". As Khaled mentioned, a better fix would be to use the equivalent font extents from head table. Change-Id: I949db23d8af7c1fd4c2362655bf602eea0e70062 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140121 Tested-by: Mike Kaganski Reviewed-by: Mike Kaganski (cherry picked from commit 1f985cb4779b581a77d419605ceb084707d408b8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139993 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/vcl/source/fontsubset/cff.cxx b/vcl/source/fontsubset/cff.cxx index 7d418ef2694c..fdc210e040a7 100644 --- a/vcl/source/fontsubset/cff.cxx +++ b/vcl/source/fontsubset/cff.cxx @@ -1801,10 +1801,10 @@ void CffSubsetterContext::emitAsType1( Type1Emitter& rEmitter, else // emit default FontMatrix if needed pOut += sprintf( pOut, "/FontMatrix [0.001 0 0 0.001 0 0]readonly def\n"); // emit FontBBox -if( maFontBBox.size() == 4) -rEmitter.emitValVector( "/FontBBox {", "}readonly def\n", maFontBBox); -else // emit default FontBBox if needed -pOut += sprintf( pOut, "/FontBBox {0 0 999 999}readonly def\n"); +auto aFontBBox = maFontBBox; +if (aFontBBox.size() != 4) +aFontBBox = { 0, 0, 999, 999 }; // emit default FontBBox if needed +rEmitter.emitValVector( "/FontBBox {", "}readonly def\n", aFontBBox); // emit FONTINFO into TOPDICT pOut += sprintf( pOut, "/FontInfo 2 dict dup begin\n" // TODO: check fontinfo entry count @@ -2026,10 +2026,10 @@ void CffSubsetterContext::emitAsType1( Type1Emitter& rEmitter, fXFactor = 1000.0F * maFontMatrix[0]; fYFactor = 1000.0F * maFontMatrix[3]; } -rFSInfo.m_aFontBBox = tools::Rectangle( Point( static_cast(maFontBBox[0] * fXFactor), -static_cast(maFontBBox[1] * fYFactor) ), -Point( static_cast(maFontBBox[2] * fXFactor), -static_cast(maFontBBox[3] * fYFactor) ) ); +rFSInfo.m_aFontBBox = { Point(static_cast(aFontBBox[0] * fXFactor), + static_cast(aFontBBox[1] * fYFactor)), +Point(static_cast(aFontBBox[2] * fXFactor), + static_cast(aFontBBox[3] * fYFactor)) }; // PDF-Spec says the values below mean the ink bounds! // TODO: use better approximations for these ink bounds rFSInfo.m_nAscent = +rFSInfo.m_aFontBBox.Bottom(); // for capital letters
[Libreoffice-bugs] [Bug 148370] In Calc, Autocomplete places black marks in cell where letters should be, instead of previously used characters
https://bugs.documentfoundation.org/show_bug.cgi?id=148370 Martin Srdoš changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - vcl/source
vcl/source/bitmap/BitmapPopArtFilter.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 2c7052a76e5348981883ca95cf3c0b079ded5068 Author: Julien Nabet AuthorDate: Mon Sep 19 14:22:32 2022 +0200 Commit: Caolán McNamara CommitDate: Mon Sep 19 21:16:18 2022 +0200 tdf#150992: fix crash popart filter to an SVG image part of bt: 6 0x7f018c80186f in BitmapPalette::operator[](unsigned short) const (this=0x5576a198fe48, nIndex=176) at vcl/source/bitmap/bitmappalette.cxx:139 7 0x7f018c3d1fce in BitmapInfoAccess::GetPaletteColor(unsigned short) const (this=0x5576a2bbc520, nColor=176) at include/vcl/BitmapInfoAccess.hxx:121 8 0x7f018c85b63f in BitmapPopArtFilter::execute(BitmapEx const&) const (this=0x7fffb7394728, rBitmapEx=...) at vcl/source/bitmap/BitmapPopArtFilter.cxx:73 9 0x7f018c83e66b in BitmapFilter::Filter(BitmapEx&, BitmapFilter const&) (rBmpEx=..., rFilter=...) at vcl/source/bitmap/bitmapfilter.cxx:22 10 0x7f01905e5bd4 in SvxGraphicFilter::ExecuteGrfFilterSlot(SfxRequest const&, GraphicObject&) (rReq=..., rFilterObject=...) at svx/source/dialog/grfflt.cxx:202 some gdb info (gdb) p nIndex $1 = 176 (gdb) p mpImpl->GetBitmapData().size() $2 = 34 full bt here: https://bugs.documentfoundation.org/attachment.cgi?id=182499 See https://bugs.documentfoundation.org/show_bug.cgi?id=150992#c2 for some comments the main thing that makes me think that the order is reversed is the "nLastEntry" treatment. Indeed with the current sort, mnCount with 0 come first nLastEntry = nEntryCount - 1 (unless there's no color at all) Change-Id: I3b89f2f4d6f115ea9f6752c49bad776a33f0b020 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140153 Reviewed-by: Julien Nabet (cherry picked from commit 8dbbc1ca6dfe75affe13dda92bdf82b6b38f1a37) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140160 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/vcl/source/bitmap/BitmapPopArtFilter.cxx b/vcl/source/bitmap/BitmapPopArtFilter.cxx index 5d5a6ee256ba..ce37c91fdd58 100644 --- a/vcl/source/bitmap/BitmapPopArtFilter.cxx +++ b/vcl/source/bitmap/BitmapPopArtFilter.cxx @@ -56,7 +56,7 @@ BitmapEx BitmapPopArtFilter::execute(BitmapEx const& rBitmapEx) const // sort table std::sort(aPopArtTable.begin(), aPopArtTable.end(), [](const PopArtEntry& lhs, const PopArtEntry& rhs) { - return lhs.mnCount < rhs.mnCount; + return lhs.mnCount > rhs.mnCount; }); // get last used entry
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/filter/html/data/relative-keep-aspect-image.xhtml |3 sw/qa/filter/html/html.cxx | 27 sw/source/filter/html/htmlgrin.cxx | 51 3 files changed, 71 insertions(+), 10 deletions(-) New commits: commit 2e6144fc350fd94f8e66be5a9007c7f06c0213e0 Author: Miklos Vajna AuthorDate: Mon Sep 19 16:08:25 2022 +0200 Commit: Miklos Vajna CommitDate: Mon Sep 19 21:14:41 2022 +0200 sw HTML import: fix height of images when it is missing and width is relative This is similar to commit 456abae730a787693c3ad98f7e57eba5f6163a76 (sw HTML import: fix height of OLE objs when it is missing and width is relative, 2022-09-06), but this is for images, while that was for OLE objects. The idea is still that in case only axis is specified in the HTML and that's a relative percentage, then the ratio should be taken from the bitmap and it should be kept. Change-Id: I36184ff6531bff2775013462cd8cc711e1a249c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140178 Reviewed-by: Miklos Vajna Tested-by: Jenkins diff --git a/sw/qa/filter/html/data/relative-keep-aspect-image.xhtml b/sw/qa/filter/html/data/relative-keep-aspect-image.xhtml new file mode 100644 index ..96b8d14047bb --- /dev/null +++ b/sw/qa/filter/html/data/relative-keep-aspect-image.xhtml @@ -0,0 +1,3 @@ + + + diff --git a/sw/qa/filter/html/html.cxx b/sw/qa/filter/html/html.cxx index 6739341d2566..973feeec2951 100644 --- a/sw/qa/filter/html/html.cxx +++ b/sw/qa/filter/html/html.cxx @@ -78,6 +78,33 @@ CPPUNIT_TEST_FIXTURE(Test, testRelativeKeepAspect) CPPUNIT_ASSERT_EQUAL(static_cast(SwFormatFrameSize::SYNCED), static_cast(rSize.GetHeightPercent())); } + +CPPUNIT_TEST_FIXTURE(Test, testRelativeKeepAspectImage) +{ +// Given a document with an image, width set to 100%, height is not set: +OUString aURL += m_directories.getURLFromSrc(DATA_DIRECTORY) + "relative-keep-aspect-image.xhtml"; +uno::Sequence aLoadArgs = { +comphelper::makePropertyValue("FilterName", OUString("HTML (StarWriter)")), +comphelper::makePropertyValue("FilterOptions", OUString("xhtmlns=reqif-xhtml")), +}; + +// When loading that file: +mxComponent = loadFromDesktop(aURL, OUString(), aLoadArgs); + +// Then make sure that the aspect ratio of the image is kept: +auto pTextDocument = dynamic_cast(mxComponent.get()); +SwDoc* pDoc = pTextDocument->GetDocShell()->GetDoc(); +const SwFrameFormats& rFormats = *pDoc->GetSpzFrameFormats(); +const SwFrameFormat* pFormat = rFormats[0]; +const SwFormatFrameSize& rSize = pFormat->GetFrameSize(); +// Without the accompanying fix in place, this test would have failed with: +// - Expected: 255 +// - Actual : 0 +// i.e. the height had a fixed value, not "keep aspect". +CPPUNIT_ASSERT_EQUAL(static_cast(SwFormatFrameSize::SYNCED), + static_cast(rSize.GetHeightPercent())); +} } CPPUNIT_PLUGIN_IMPLEMENT(); diff --git a/sw/source/filter/html/htmlgrin.cxx b/sw/source/filter/html/htmlgrin.cxx index 2fbd30610705..c29a9ae8e1ca 100644 --- a/sw/source/filter/html/htmlgrin.cxx +++ b/sw/source/filter/html/htmlgrin.cxx @@ -527,10 +527,30 @@ IMAGE_SETEVENT: if (!bHeightProvided) nHeight = aPixelSize.Height(); // tdf#142781 - calculate the width/height keeping the aspect ratio -if (!bPercentWidth && bWidthProvided && !bHeightProvided && aPixelSize.Width()) -nHeight = nWidth * aPixelSize.Height() / aPixelSize.Width(); -else if (!bPercentHeight && !bWidthProvided && bHeightProvided && aPixelSize.Height()) -nWidth = nHeight * aPixelSize.Width() / aPixelSize.Height(); +if (bWidthProvided && !bHeightProvided && aPixelSize.Width()) +{ +if (bPercentWidth) +{ +nHeight = SwFormatFrameSize::SYNCED; +bPercentHeight = true; +} +else +{ +nHeight = nWidth * aPixelSize.Height() / aPixelSize.Width(); +} +} +else if (!bWidthProvided && bHeightProvided && aPixelSize.Height()) +{ +if (bPercentHeight) +{ +nWidth = SwFormatFrameSize::SYNCED; +bPercentWidth = true; +} +else +{ +nWidth = nHeight * aPixelSize.Width() / aPixelSize.Height(); +} +} } SfxItemSet aItemSet( m_xDoc->GetAttrPool(), m_pCSS1Parser->GetWhichMap() ); @@ -648,7 +668,11 @@ IMAGE_SETEVENT: // bPercentWidth / bPercentHeight means we have a percent size. If that's not the case and we have no // size from nWidth / nHeight either, then inspect the image header. -if ((!bPercentWidth && !nWidth) && (!bPercentHeight && !nHeight) &&
[Libreoffice-bugs] [Bug 75702] FILEOPEN: line-break ignored
https://bugs.documentfoundation.org/show_bug.cgi?id=75702 --- Comment #17 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/60585bb65330ad703b5683aece1564dfc6301436 tdf#75702 sc: unit test for preserving text:line-break It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 75702] FILEOPEN: line-break ignored
https://bugs.documentfoundation.org/show_bug.cgi?id=75702 Commit Notification changed: What|Removed |Added Whiteboard|BSA |BSA target:7.5.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/qa
sc/qa/unit/data/ods/tdf75702_textLineBreak.ods |binary sc/qa/unit/subsequent_export_test2.cxx | 21 - 2 files changed, 20 insertions(+), 1 deletion(-) New commits: commit 60585bb65330ad703b5683aece1564dfc6301436 Author: Justin Luth AuthorDate: Mon Sep 19 10:57:41 2022 -0400 Commit: Justin Luth CommitDate: Mon Sep 19 21:10:39 2022 +0200 tdf#75702 sc: unit test for preserving text:line-break Change-Id: Id61e46ba4e0b3e2b534cf9f8bafe03fba10cd355 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140182 Tested-by: Jenkins Reviewed-by: Justin Luth diff --git a/sc/qa/unit/data/ods/tdf75702_textLineBreak.ods b/sc/qa/unit/data/ods/tdf75702_textLineBreak.ods new file mode 100644 index ..b2e47b8f6ff6 Binary files /dev/null and b/sc/qa/unit/data/ods/tdf75702_textLineBreak.ods differ diff --git a/sc/qa/unit/subsequent_export_test2.cxx b/sc/qa/unit/subsequent_export_test2.cxx index b722137934fa..7bbb908a96fb 100644 --- a/sc/qa/unit/subsequent_export_test2.cxx +++ b/sc/qa/unit/subsequent_export_test2.cxx @@ -125,6 +125,7 @@ public: void testTdf91634XLSX(); void testTdf115159(); void testTdf112567(); +void testTdf75702(); void testTdf103829(); void testTdf122191(); void testTdf142881(); @@ -249,6 +250,7 @@ public: CPPUNIT_TEST(testTdf91634XLSX); CPPUNIT_TEST(testTdf115159); CPPUNIT_TEST(testTdf112567); +CPPUNIT_TEST(testTdf75702); CPPUNIT_TEST(testTdf103829); CPPUNIT_TEST(testTdf122191); CPPUNIT_TEST(testTdf142881); @@ -1439,6 +1441,24 @@ void ScExportTest2::testTdf112567() xDocSh->DoClose(); } +void ScExportTest2::testTdf75702() +{ +// The problem was that line breaks were not imported. +const OUString sA1("line1\nline2"); + +ScDocShellRef xShell = loadDoc(u"tdf75702_textLineBreak.", FORMAT_ODS); +ScDocument& rDoc = xShell->GetDocument(); +CPPUNIT_ASSERT_EQUAL_MESSAGE("load a1", sA1, rDoc.GetString(0, 0, 0)); + +xShell = saveAndReload(*xShell, FORMAT_ODS); +ScDocument& rDoc2 = xShell->GetDocument(); +CPPUNIT_ASSERT_EQUAL_MESSAGE("reload a1", sA1, rDoc2.GetString(0, 0, 0)); + +xmlDocUniquePtr pContent += XPathHelper::parseExport2(*this, *xShell, m_xSFactory, "content.xml", FORMAT_ODS); +assertXPath(pContent, "//table:table-row[1]/table:table-cell/text:p/text:line-break"); +} + void ScExportTest2::testTdf103829() { // The problem was that tabspaces were not imported or exported at all. @@ -1453,7 +1473,6 @@ void ScExportTest2::testTdf103829() xShell = saveAndReload(*xShell, FORMAT_ODS); ScDocument& rDoc2 = xShell->GetDocument(); -//CPPUNIT_ASSERT_EQUAL_MESSAGE("reload a1", sA1.getLength(), rDoc2.GetString(0, 0, 0).getLength()); CPPUNIT_ASSERT_EQUAL_MESSAGE("reload a1", sA1, rDoc2.GetString(0, 0, 0)); CPPUNIT_ASSERT_EQUAL_MESSAGE("reload a2", sA2, rDoc2.GetString(0, 1, 0)); }
[Libreoffice-commits] dev-tools.git: test-bugzilla-files/test-bugzilla-files.py
test-bugzilla-files/test-bugzilla-files.py |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) New commits: commit 7646673d496c3a4efc71dcebbfb00f8ff3494944 Author: Caolán McNamara AuthorDate: Mon Sep 19 20:02:21 2022 +0100 Commit: Caolán McNamara CommitDate: Mon Sep 19 21:07:07 2022 +0200 remove the OSL_PIPE_$uid_pytest_foo on killing process we pass this name to soffice ourself, so we know what the final name of the pipe will be, so we can remove it ourself Change-Id: I8d98f8464a203278da09b20be5c7d76f85a6d437 Reviewed-on: https://gerrit.libreoffice.org/c/dev-tools/+/140205 Tested-by: Caolán McNamara Reviewed-by: Caolán McNamara diff --git a/test-bugzilla-files/test-bugzilla-files.py b/test-bugzilla-files/test-bugzilla-files.py index ec3d492..50a7508 100644 --- a/test-bugzilla-files/test-bugzilla-files.py +++ b/test-bugzilla-files/test-bugzilla-files.py @@ -83,6 +83,7 @@ class OfficeConnection: self.args = args self.soffice = None self.socket = None +self.pipename = None self.xContext = None self.pro = None self.suicided = False @@ -91,7 +92,8 @@ class OfficeConnection: if sep != ":": raise Exception("soffice parameter does not specify method") if method == "path": -socket = "pipe,name=pytest" + str(uuid.uuid1()) +self.pipename = "pytest" + str(uuid.uuid1()) +socket = "pipe,name=" + self.pipename try: userdir = self.args["--userdir"] except KeyError: @@ -159,6 +161,9 @@ class OfficeConnection: #return ret def kill(self): self.suicided = True +command = "rm /tmp/OSL_PIPE_" + str(os.getuid()) + "_" + self.pipename; +print(command) +os.system(command) command = "kill " + str(self.pro.pid) killFile = open("killFile.log", "a") killFile.write(command + "\n")
[Libreoffice-bugs] [Bug 134176] LibreOffice does not remove the hyperlink of many selected URLs when an URL is only partially selected
https://bugs.documentfoundation.org/show_bug.cgi?id=134176 --- Comment #3 from BDF --- Still exists Version: 7.4.1.2 / LibreOffice Community Build ID: 3c58a8f3a960df8bc8fd77b461821e42c061c5f0 CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: de-AT (de_AT.UTF-8); UI: de-DE Flatpak Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 126457] FILEOPEN XLSX VBA macro to switch between active documents does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=126457 Andreas Heinisch changed: What|Removed |Added CC||andreas.heini...@yahoo.de --- Comment #7 from Andreas Heinisch --- The macro works in excel using: Public Sub FileOpenExample() file1 = "C:\temp\Example.xlsx" file2 = "C:\temp\Example1.xlsx" Workbooks.Open Filename:=file1 Workbooks.Open Filename:=file2 Windows("Example.xlsx").Activate Windows("Example1.xlsx").Activate End Sub I could not get it to work using your macro: Public Sub FileOpenExample() file1 = "C:\temp\Example.xlsx" file2 = "C:\temp\Example1.xlsx" Workbooks.Open Filename:=file1 Workbooks.Open Filename:=file2 Windows(file1).Activate Windows(file2).Activate End Sub Did I something wrong? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149790] Alt-F11 doesn't Standard.Module1.Main anymore
https://bugs.documentfoundation.org/show_bug.cgi?id=149790 Samuel Mehrbrodt (allotropia) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #3 from Samuel Mehrbrodt (allotropia) --- My commit was reverted with 6e2bd11251afbe64f9889ede36b28b00f47aaff5. Closing this bug. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148876] Add Thai hyphenation patterns
https://bugs.documentfoundation.org/show_bug.cgi?id=148876 Eike Rathke changed: What|Removed |Added Blocks||150433 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=150433 [Bug 150433] Add Thai thesaurus -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150433] Add Thai thesaurus
https://bugs.documentfoundation.org/show_bug.cgi?id=150433 Eike Rathke changed: What|Removed |Added Depends on||148876 Keywords||patch Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148876 [Bug 148876] Add Thai hyphenation patterns -- You are receiving this mail because: You are the assignee for the bug.