[Libreoffice-commits] core.git: include/vcl vcl/inc vcl/Library_vcl.mk vcl/source
include/vcl/filter/pdfdocument.hxx |2 vcl/Library_vcl.mk |1 vcl/inc/pdf/ExternalPDFStreams.hxx |2 vcl/inc/pdf/pdfcompat.hxx | 42 vcl/source/filter/ipdf/pdfcompat.cxx | 114 + vcl/source/filter/ipdf/pdfdocument.cxx | 14 vcl/source/filter/ipdf/pdfread.cxx | 110 ++- 7 files changed, 183 insertions(+), 102 deletions(-) New commits: commit 3f9e8ac6172f5b1dfd2869ee1c6aea4f24d3f480 Author: Dennis Francis AuthorDate: Tue Oct 18 16:14:37 2022 +0530 Commit: Dennis Francis CommitDate: Thu Oct 27 07:54:59 2022 +0200 vcl: re-exporting broken pdfs -> empty pages Certain pdf documents when loaded in LO_IMPORT_USE_PDFIUM=1 mode even if pdf-version < v1.6 sometimes has missing objects referred by other objects for determing its stream length for instance. As a result parsing fails and results in a pdf with empty pages. A round trip through pdfium and exporting to v1.6 seems to cure the issue. Possibly it does some repairing work to determine the length of the stream in a independent pass through the file. Conflicts: vcl/source/filter/ipdf/pdfread.cxx Change-Id: Id09f67eddab4163ed12a3a3f3a73baf92e2912aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141856 Tested-by: Jenkins Reviewed-by: Dennis Francis diff --git a/include/vcl/filter/pdfdocument.hxx b/include/vcl/filter/pdfdocument.hxx index dd03029227d2..fbe0be89cdc6 100644 --- a/include/vcl/filter/pdfdocument.hxx +++ b/include/vcl/filter/pdfdocument.hxx @@ -576,6 +576,8 @@ public: //@{ /// Read elements from the start of the stream till its end. bool Read(SvStream& rStream); +/// Calls Read() first and if it fails it tries to fixup and then retry. +bool ReadWithPossibleFixup(SvStream& rStream); void SetSignatureLine(std::vector&& rSignatureLine); void SetSignaturePage(size_t nPage); /// Sign the read document with xCertificate in the edit buffer. diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk index 4b1751005bf0..d0087d682d22 100644 --- a/vcl/Library_vcl.mk +++ b/vcl/Library_vcl.mk @@ -452,6 +452,7 @@ $(eval $(call gb_Library_add_exception_objects,vcl,\ vcl/source/filter/ipict/ipict \ vcl/source/filter/ipsd/ipsd \ vcl/source/filter/ipict/shape \ +vcl/source/filter/ipdf/pdfcompat \ vcl/source/filter/ipdf/pdfread \ vcl/source/filter/ipdf/pdfdocument \ vcl/source/filter/iras/iras \ diff --git a/vcl/inc/pdf/ExternalPDFStreams.hxx b/vcl/inc/pdf/ExternalPDFStreams.hxx index 7840217630c8..45b15f7a74bc 100644 --- a/vcl/inc/pdf/ExternalPDFStreams.hxx +++ b/vcl/inc/pdf/ExternalPDFStreams.hxx @@ -42,7 +42,7 @@ struct VCL_DLLPUBLIC ExternalPDFStream aPDFStream.WriteBytes(maDataContainer.getData(), maDataContainer.getSize()); aPDFStream.Seek(0); auto pPDFDocument = std::make_shared(); -if (!pPDFDocument->Read(aPDFStream)) +if (!pPDFDocument->ReadWithPossibleFixup(aPDFStream)) { SAL_WARN("vcl.pdfwriter", "PDFWriterImpl::writeReferenceXObject: reading the PDF document failed"); diff --git a/vcl/inc/pdf/pdfcompat.hxx b/vcl/inc/pdf/pdfcompat.hxx new file mode 100644 index ..8f629b3bc8ee --- /dev/null +++ b/vcl/inc/pdf/pdfcompat.hxx @@ -0,0 +1,42 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#pragma once + +#include +#include +#include +#include +#include + +namespace vcl::pdf +{ +/// Convert to inch, then assume 96 DPI. +inline double pointToPixel(const double fPoint, const double fResolutionDPI) +{ +return o3tl::convert(fPoint, o3tl::Length::pt, o3tl::Length::in) * fResolutionDPI; +} + +/// Decide if PDF data is old enough to be compatible. +bool isCompatible(SvStream& rInStream, sal_uInt64 nPos, sal_uInt64 nSize); + +/// Converts to highest supported format version (currently 1.6). +/// Usually used to deal with missing referenced objects in the +/// source pdf stream. +bool convertToHighestSupported(SvStream& rInStream, SvStream& rOutStream); + +/// Takes care of transparently downgrading the version of the PDF stream in +/// case it's too new for our PDF export. +bool getCompatibleStream(SvStream& rInStream, SvStream& rOutStream); + +BinaryDataContainer createBinaryDataContainer(SvStream& rStream); + +} // end of vcl::filter::ipdf namespace + +/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/vcl/source/filter/ipdf/pdfcompat.cxx b/vcl/source/filter/ipdf/pdfcompat.cxx new file mode 100644 index
[Libreoffice-bugs] [Bug 143276] FILEOPEN DOCX Splitting a table in Word does not appear in Writers Manage Changes panel
https://bugs.documentfoundation.org/show_bug.cgi?id=143276 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||3360 CC||aron.bu...@gmail.com -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143360] EDITING Splitting a table is not change tracked
https://bugs.documentfoundation.org/show_bug.cgi?id=143360 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||3276 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151769] Text disappearing from slide after saving presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=151769 Julien Nabet changed: What|Removed |Added Summary|Text dissappearing from |Text disappearing from |slide after saving |slide after saving |presentation|presentation -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151774] Can't create new database in Base, it is disabled
https://bugs.documentfoundation.org/show_bug.cgi?id=151774 Mike Kaganski changed: What|Removed |Added Resolution|--- |NOTOURBUG Status|UNCONFIRMED |RESOLVED --- Comment #1 from Mike Kaganski --- You are using a distro-packaged (or PPA) LibreOffice. Distros take their own decisions WRT which components to install from their metapackages by default. Ubuntu packaging team (maybe Debian) don't install libreoffice-base by default. You need to install it explicitly. Anyway, this is not related to LibreOffice project. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151776] New: possible new feature: "Session" (File/Session)
https://bugs.documentfoundation.org/show_bug.cgi?id=151776 Bug ID: 151776 Summary: possible new feature: "Session" (File/Session) Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: j...@cspv.hu hi, some enhancement ideas might be pointlessly sophisticated, aiming a level of effortlessness that in real life never is a desired thing, and one might think that "Session" could belong to this category, too... however, if you keep it simple, it could serve a good workflow... its goals should be and remain: reopening the documents you're currently working on sometimes reopening past sessions, or other sessions, i.e. another "bunch" - - - - - NOTE 1: this could be best done in the Publisher (that the Master document could evolve to be) one of its functions could be to handle "bunches" of documents -- not necessarily incorporating all into a Master Document In "Publisher" (in the future) it could get a column in the menu... like "Project Files" (handling documents and objects, including exporting all of them as copies into a folder on request, when it comes to that, like in video editor software) NOTE 2: in Navigator it could dwell perfectly well :) NOTE 3: a very simple version in Writer (not yet in Publisher :) ) of it in "File / Recent Documents" could be a very visible separator under the last document of the previous session sessions, by extensive use has become a function in Firefox, for example, obsolete, cause just reopening the tabs from the last time is suffice, and works perfectly... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137677] FILEOPEN DOCX Change tracked paragraph deletion with style change split to two changes
https://bugs.documentfoundation.org/show_bug.cgi?id=137677 Aron Budea changed: What|Removed |Added Version|7.0.3.1 release |4.3.0.4 release Keywords||bibisectRequest CC||aron.bu...@gmail.com --- Comment #3 from Aron Budea --- This actually seems like a regression, or at least something was different before 4.3, as it was still only imported as a single change. Might be interesting to know what changed. Bibisecting using bibisect-43max gave me 236c0762c14cace93deae4175073519ef67e4b48 / 05fa566b17902f76343952fb8355d576208fd097 (single commit in the bibisect repo), which are obviously wrong, though: https://cgit.freedesktop.org/libreoffice/core/log/?id=236c0762c14cace93deae4175073519ef67e4b48 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143065] [META] DOC Tracking changes-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=143065 Aron Budea changed: What|Removed |Added Depends on||132616 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=132616 [Bug 132616] FILESAVE: ODT->DOC/X: deleted track-changes content not completely marked as deleted -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 132616] FILESAVE: ODT->DOC/X: deleted track-changes content not completely marked as deleted
https://bugs.documentfoundation.org/show_bug.cgi?id=132616 Aron Budea changed: What|Removed |Added Version|4.1 all versions|Inherited From OOo Blocks||143065 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143065 [Bug 143065] [META] DOC Tracking changes-related issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150433] Add Thai thesaurus
https://bugs.documentfoundation.org/show_bug.cgi?id=150433 --- Comment #5 from Theppitak Karoonboonyanan --- (In reply to Eike Rathke from comment #3) > Apparently we don't have your license statement on file, could you > please send us a blanket statement that you contribute all your past and > future patches under the MPLv2 and LGPLv3+ licenses? Best on the dev > mailing list libreoff...@lists.freedesktop.org so we can link to it from > https://wiki.documentfoundation.org/Development/Developers > > Something like this does nicely: > > All of my past & future contributions to LibreOffice may be > licensed under the MPLv2/LGPLv3+ dual license. > > Best use Subject: license statement > > Sorry for the inconvenience and thank you for cooperating :-) The license of this patch is specified in th_TH/README_thes_th_TH.txt as CC-0 1.0, based on the data source it was converted from. Of course, it could either be CC-0 as before to maintain its permissiveness, or be relicensed to MPLv2/LGPLv3+ if required by the project. In case it could be CC-0, would it conflict with my license statement to always have my contributions be under MPLv2/LGPLv3+ dual license? Or would it simply be overridden by the license statement in the patch? In general, I prefer my future code contributions to be under MPLv2/LGPLv3+, BTW, but the source of this one is such permissive. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 124472] FILEOPEN DOCX Field code change is not parsed as Track Changes entry
https://bugs.documentfoundation.org/show_bug.cgi?id=124472 Aron Budea changed: What|Removed |Added CC||aron.bu...@gmail.com --- Comment #6 from Aron Budea --- Still in LO 7.5.0.0.alpha0+ (5a1f41a0d3aab15c113651f2edc9d4137ae99063) / Windows. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 101378] DOC(X): Writer doesn't handle tracked changes in formula
https://bugs.documentfoundation.org/show_bug.cgi?id=101378 Aron Budea changed: What|Removed |Added CC||aron.bu...@gmail.com --- Comment #7 from Aron Budea --- Still in LO 7.5.0.0.alpha0+ (5a1f41a0d3aab15c113651f2edc9d4137ae99063) / Windows. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151376] Unexpected 'DisposedException' when calling Basic Script
https://bugs.documentfoundation.org/show_bug.cgi?id=151376 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151494] Writer - Export to pdf keeping cross reference to reference visibility on hyperlinked word
https://bugs.documentfoundation.org/show_bug.cgi?id=151494 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151488] page line-spacing: lines don't seem to be in level
https://bugs.documentfoundation.org/show_bug.cgi?id=151488 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151487] page line-spacing: active page line-spacing cannot be set "OFF" in template
https://bugs.documentfoundation.org/show_bug.cgi?id=151487 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151472] FORMATTING: Style change breaks direct formatting (bold, italic, underline)
https://bugs.documentfoundation.org/show_bug.cgi?id=151472 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151756] Menu text almost invisible
https://bugs.documentfoundation.org/show_bug.cgi?id=151756 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151723] When printout (to the printer or to .pdf) table from Writer see the horizontal line of the table incorrect
https://bugs.documentfoundation.org/show_bug.cgi?id=151723 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151756] Menu text almost invisible
https://bugs.documentfoundation.org/show_bug.cgi?id=151756 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143093] Windows File Explorer created docx file, edited in libreoffice Writer, and Ctrl-S saved, ends up with question marks
https://bugs.documentfoundation.org/show_bug.cgi?id=143093 --- Comment #10 from QA Administrators --- Dear Raghu, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151723] When printout (to the printer or to .pdf) table from Writer see the horizontal line of the table incorrect
https://bugs.documentfoundation.org/show_bug.cgi?id=151723 --- Comment #11 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142843] Font hinting of Arial font bit excessive?
https://bugs.documentfoundation.org/show_bug.cgi?id=142843 --- Comment #5 from QA Administrators --- Dear Telesto, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142008] Grid control with multiline text column doesn't wrap
https://bugs.documentfoundation.org/show_bug.cgi?id=142008 --- Comment #6 from QA Administrators --- Dear patrick.gelin, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 88551] Event "Text modified" happens in tablecontrol while navigating through form without modifying anything
https://bugs.documentfoundation.org/show_bug.cgi?id=88551 --- Comment #14 from QA Administrators --- Dear Robert Großkopf, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134138] Options to change position and size of connectors should be limited if they're connected
https://bugs.documentfoundation.org/show_bug.cgi?id=134138 --- Comment #3 from QA Administrators --- Dear mat.venturini, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 71790] PDF: Use of dotted paragraph border makes exported PDF files huge
https://bugs.documentfoundation.org/show_bug.cgi?id=71790 --- Comment #7 from QA Administrators --- Dear tobias, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133988] Stacked chart: put bars for secondary Y axis near the bar attached to primary axis, not overlap
https://bugs.documentfoundation.org/show_bug.cgi?id=133988 --- Comment #3 from QA Administrators --- Dear Mike Kaganski, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133347] save as ODF1.2extended produces invalid ODF for pivot table based on named range
https://bugs.documentfoundation.org/show_bug.cgi?id=133347 --- Comment #5 from QA Administrators --- Dear Regina Henschel, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150433] Add Thai thesaurus
https://bugs.documentfoundation.org/show_bug.cgi?id=150433 --- Comment #4 from Theppitak Karoonboonyanan --- (In reply to Michael Warner from comment #2) > Sounds good to me, marking as NEW. > > However, since you already have the code downloaded, rather than attaching > the patch files here, why not just push the patch to gerrit and create a > review? It would get merged quicker that way. Thanks for the advice. I've just set up my gerrit account after a brief learning. I'll make my first push soon. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148876] Add Thai hyphenation patterns
https://bugs.documentfoundation.org/show_bug.cgi?id=148876 --- Comment #5 from Theppitak Karoonboonyanan --- (In reply to Eike Rathke from comment #3) > Apparently we don't have your license statement on file, could you > please send us a blanket statement that you contribute all your past and > future patches under the MPLv2 and LGPLv3+ licenses? Best on the dev > mailing list libreoff...@lists.freedesktop.org so we can link to it from > https://wiki.documentfoundation.org/Development/Developers > > Something like this does nicely: > > All of my past & future contributions to LibreOffice may be > licensed under the MPLv2/LGPLv3+ dual license. > > Best use Subject: license statement > > Sorry for the inconvenience and thank you for cooperating :-) The license is specified in th_TH/README_hyph_th_TH.txt as LPPL 1.3+, just the same as my contribution to tex-hyphen, from which this patch was derived. Do I need to relicense it to MPLv2/LGPLv3+? Fortunately, I should have the full right to do so if needed, as the work has been done solely by me so far. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148876] Add Thai hyphenation patterns
https://bugs.documentfoundation.org/show_bug.cgi?id=148876 --- Comment #4 from Theppitak Karoonboonyanan --- (In reply to Julien Nabet from comment #2) > Thought you might be interested in this page: > https://wiki.documentfoundation.org/Language > > (put Andras in cc). Yes, I had been the Thai translation coordinator for a while when creating this issue, and the page gave me more info for other areas. Thanks. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151363] [MacOS Apple Silicon] Writer+Calc hang frequently
https://bugs.documentfoundation.org/show_bug.cgi?id=151363 Christopher M. Penalver changed: What|Removed |Added URL||https://github.com/rxhanson ||/Rectangle/issues/964 Summary|[MacOS 12.6 Apple Silicon] |[MacOS Apple Silicon] |Writer+Calc hang frequently |Writer+Calc hang frequently --- Comment #10 from Christopher M. Penalver --- Reproducible in: MacOS 13.0 Rectangle 0.60 Version: 7.4.2.3 / LibreOffice Community Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf CPU threads: 8; OS: Mac OS X 13.0; UI render: default; VCL: osx Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151770] Improve LibreOffice grids -- defaults (Writer/Calc) help page with an answer from ask.libreoffice.org
https://bugs.documentfoundation.org/show_bug.cgi?id=151770 --- Comment #1 from u...@net9.ga --- Quoting the 2nd part of comment 1: 2. EarnestAl statement about the default grid is quite faint is a misnomer. It can not be observed, unless one knows it is there. Change his statement when copying to reflect that. As of this writing, I can not reproduce the fact that it can not be seen. It could be I did something wrong, and was confused. It is quite faint. I still think the 1st part, about integrating EarnestAl answer, is close to a must. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142172] LO colors theme: dark mode: use darker document background color
https://bugs.documentfoundation.org/show_bug.cgi?id=142172 Rafael Lima changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |rafael.palma.l...@gmail.com |desktop.org | --- Comment #18 from Rafael Lima --- Patch available for review at: https://gerrit.libreoffice.org/c/core/+/141850 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151775] New: Ability to filter comments in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=151775 Bug ID: 151775 Summary: Ability to filter comments in Writer Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: loma...@gmail.com Description: I am surprised that Writer doesn't have a way to filter comments by person. Filtering by date would also be handy. MS Word and Acrobat Reader have the ability to filter by comments. Steps to Reproduce: N/A Actual Results: N/A Expected Results: N/A Reproducible: Always User Profile Reset: No Additional Info: N/A -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151773] improve explanation of extensions location
https://bugs.documentfoundation.org/show_bug.cgi?id=151773 m.a.riosv changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151774] New: Can't create new database in Base, it is disabled
https://bugs.documentfoundation.org/show_bug.cgi?id=151774 Bug ID: 151774 Summary: Can't create new database in Base,it is disabled Product: LibreOffice Version: 7.4.2.3 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rajasekara...@gmail.com Description: After opening LO,it shows options to create new files in Writer,Calc,Impress,Draw and Math except Base.It showing like Base is disabled.Don't know how to change it.I am using LO in LXLE Linux(x64) Focal Release. Steps to Reproduce: 1.Open LO wizard. 2.Under "Create:" menu try to create database in Base 3.Can't access the Base. Actual Results: Can't create new database file in Base. Expected Results: Create new database in Base. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.4.2.3 / LibreOffice Community Build ID: 40(Build:3) CPU threads: 1; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Ubuntu package version: 1:7.4.2~rc3-0ubuntu0.20.04.1~lo1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151771] Malwarebytes blocks libreoffice
https://bugs.documentfoundation.org/show_bug.cgi?id=151771 m.a.riosv changed: What|Removed |Added Resolution|FIXED |NOTOURBUG Status|RESOLVED|CLOSED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151770] Improve LibreOffice grids -- defaults (Writer/Calc) help page with an answer from ask.libreoffice.org
https://bugs.documentfoundation.org/show_bug.cgi?id=151770 m.a.riosv changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151768] table toolbar in Writer on MacOSX appears at the bottom
https://bugs.documentfoundation.org/show_bug.cgi?id=151768 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #3 from m.a.riosv --- Please take a look: https://help.libreoffice.org/latest/en-US/text/shared/guide/floating_toolbar.html?DbPAR=SHARED#bm_id3152801 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151771] Malwarebytes blocks libreoffice
https://bugs.documentfoundation.org/show_bug.cgi?id=151771 csyu@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #1 from csyu@gmail.com --- Resolved Windows HP Elitebook Version: 7.4.2.3 (x64) / LibreOffice Community Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151763] Long pause of up to 1 min. while opening files (e.g. ods).
https://bugs.documentfoundation.org/show_bug.cgi?id=151763 m.a.riosv changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #5 from m.a.riosv --- You can report, when you see the issue, it's fine so. But without a way to reproduce the issue, it's no easy for a dev to do something. Maybe something in relation with your machine, some driver, some hardware. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151723] When printout (to the printer or to .pdf) table from Writer see the horizontal line of the table incorrect
https://bugs.documentfoundation.org/show_bug.cgi?id=151723 --- Comment #10 from Joseph --- Played a lot with View and Print options from Option Menu with file .odt. Didn't help. But in safe mode - OK! So as I may see problem somewhere in this. What is the main difference between Normal and Safe mode??? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138601] Conditional formats of a XLSX-File are opened and saved in a different order than the original one. This breaks the documents appearance
https://bugs.documentfoundation.org/show_bug.cgi?id=138601 Justin L changed: What|Removed |Added Version|7.0.3.1 release |5.0.0.5 release OS|Windows (All) |All -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151513] LibreOffice Writer 7.3.6 on Mac Monterey 12.6 freezes within 10 seconds after opening
https://bugs.documentfoundation.org/show_bug.cgi?id=151513 Dieter changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||dgp-m...@gmx.de Ever confirmed|0 |1 --- Comment #1 from Dieter --- Thank you for reporting the bug. Could you please try to reproduce it with the latest version of LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ To be certain the reported issue is not related to corruption in the user profile, could you please also reset your Libreoffice profile (https://wiki.documentfoundation.org/UserProfile) and re-test? I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the latest version. Change to RESOLVED WORKSFORME, if the problem went away. => NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113782] [META] XLSX (OOXML) conditional formatting bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=113782 Bug 113782 depends on bug 91477, which changed state. Bug 91477 Summary: FILEOPEN: XLSX Databar color is different than in Word 2010 https://bugs.documentfoundation.org/show_bug.cgi?id=91477 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138601] Conditional formats of a XLSX-File are opened and saved in a different order than the original one. This breaks the documents appearance
https://bugs.documentfoundation.org/show_bug.cgi?id=138601 Justin L changed: What|Removed |Added CC||darshan.gan...@synerzip.com --- Comment #5 from Justin L --- *** Bug 91477 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 91477] FILEOPEN: XLSX Databar color is different than in Word 2010
https://bugs.documentfoundation.org/show_bug.cgi?id=91477 Justin L changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #12 from Justin L --- *** This bug has been marked as a duplicate of bug 138601 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151111] Paste special dialog significantly deficient in options
https://bugs.documentfoundation.org/show_bug.cgi?id=15 Eyal Rozenberg changed: What|Removed |Added Summary|Paste special mechanism |Paste special dialog |significantly deficient in |significantly deficient in |options |options --- Comment #8 from Eyal Rozenberg --- (In reply to Heiko Tietze from comment #7) > Then we discuss the context menu coming back to the dialog with c5 > stating the dialog has not enough functionality. Let's forget about the context menu entirely. I should not have mentioned it. > Admittedly the documentation has some room for improvement > https://help.libreoffice.org/latest/en-US/text/shared/01/0207.html This bug report is not about the documentation. > I cannot follow this enhancement request. C0 lists a couple of scenarios and > asks to combine everything, which makes no sense (and lacks of a clear use > case). C0 is about the space of options for Pasting available via the Paste Special dialog. I believe it should be enlarged beyond what it has currently. Would you like me to split these suggestions into separate bugs? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 122093] FILESAVE XLSX, Conditional formatting with "automatic" font color changes to "black"
https://bugs.documentfoundation.org/show_bug.cgi?id=122093 --- Comment #7 from Justin L --- repro 7.5+ Contrary to the title, the font in the light-blue square is turning white, not black. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'private/tvajngerl/staging' - 3 commits - editeng/source include/editeng include/svx sd/qa sd/source svx/source
Rebased ref, commits from common ancestor: commit 39a5579ed5bcf500d2ba026cb7f376d270b7eafd Author: Tomaž Vajngerl AuthorDate: Tue Oct 18 21:28:29 2022 +0200 Commit: Tomaž Vajngerl CommitDate: Wed Oct 26 21:22:31 2022 +0200 editeng: fix rendering of text when "fit to frame" is enabbled This changes the nStretchX and nStretchY from sal_uInt16 to double so the text in text boxes is rendered correctly (text should be resized to the same size as the textbox). Change-Id: Ic92d03043af0abe86f1b67ae15522d0176ebbb51 diff --git a/editeng/source/editeng/editeng.cxx b/editeng/source/editeng/editeng.cxx index 88bc04a9efed..c8a66d0470a4 100644 --- a/editeng/source/editeng/editeng.cxx +++ b/editeng/source/editeng/editeng.cxx @@ -2266,12 +2266,12 @@ bool EditEngine::HasText( const SvxSearchItem& rSearchItem ) return pImpEditEngine->HasText( rSearchItem ); } -void EditEngine::SetGlobalCharStretching( sal_uInt16 nX, sal_uInt16 nY ) +void EditEngine::SetGlobalCharStretching(double nX, double nY) { pImpEditEngine->SetCharStretching( nX, nY ); } -void EditEngine::GetGlobalCharStretching( sal_uInt16& rX, sal_uInt16& rY ) const +void EditEngine::GetGlobalCharStretching(double& rX, double& rY) const { pImpEditEngine->GetCharStretching( rX, rY ); } diff --git a/editeng/source/editeng/editobj.cxx b/editeng/source/editeng/editobj.cxx index 6d57c7497c2b..437754d70def 100644 --- a/editeng/source/editeng/editobj.cxx +++ b/editeng/source/editeng/editobj.cxx @@ -71,10 +71,10 @@ void XEditAttribute::SetItem(const SfxPoolItem& rNew) } XParaPortionList::XParaPortionList( -OutputDevice* pRefDev, sal_uInt32 nPW, sal_uInt16 _nStretchX, sal_uInt16 _nStretchY) +OutputDevice* pRefDev, sal_uInt32 nPW, double nStretchX, double nStretchY) : pRefDevPtr(pRefDev) -, nStretchX(_nStretchX) -, nStretchY(_nStretchY) +, mnStretchX(nStretchX) +, mnStretchY(nStretchY) , nPaperWidth(nPW) { } diff --git a/editeng/source/editeng/editobj2.hxx b/editeng/source/editeng/editobj2.hxx index 250341fd4283..86a2e379be20 100644 --- a/editeng/source/editeng/editobj2.hxx +++ b/editeng/source/editeng/editobj2.hxx @@ -94,12 +94,12 @@ class XParaPortionList ListType maList; VclPtr pRefDevPtr; -sal_uInt16 nStretchX; -sal_uInt16 nStretchY; +double mnStretchX; +double mnStretchY; sal_uInt32 nPaperWidth; public: -XParaPortionList(OutputDevice* pRefDev, sal_uInt32 nPW, sal_uInt16 _nStretchX, sal_uInt16 _nStretchY); +XParaPortionList(OutputDevice* pRefDev, sal_uInt32 nPW, double nStretchX, double nStretchY); void push_back(XParaPortion* p); const XParaPortion& operator[](size_t i) const; @@ -108,8 +108,8 @@ public: sal_uInt32 GetPaperWidth() const { return nPaperWidth; } boolRefDevIsVirtual() const {return pRefDevPtr->IsVirtual();} const MapMode& GetRefMapMode() const { return pRefDevPtr->GetMapMode(); } -sal_uInt16 GetStretchX() const { return nStretchX; } -sal_uInt16 GetStretchY() const { return nStretchY; } +double GetStretchX() const { return mnStretchX; } +double GetStretchY() const { return mnStretchY; } }; class ContentInfo diff --git a/editeng/source/editeng/impedit.hxx b/editeng/source/editeng/impedit.hxx index b761e3bc4135..20e116b2ab3f 100644 --- a/editeng/source/editeng/impedit.hxx +++ b/editeng/source/editeng/impedit.hxx @@ -528,8 +528,8 @@ private: Color maBackgroundColor; -sal_uInt16 nStretchX; -sal_uInt16 nStretchY; +double mnStretchX; +double mnStretchY; CharCompressTypenAsianCompressionMode; @@ -1080,8 +1080,8 @@ public: SvxCellJustifyMethodGetJustifyMethod( sal_Int32 nPara ) const; SvxCellVerJustify GetVerJustification( sal_Int32 nPara ) const; -voidSetCharStretching( sal_uInt16 nX, sal_uInt16 nY ); -inline void GetCharStretching( sal_uInt16& rX, sal_uInt16& rY ) const; +voidSetCharStretching(double nX, double nY); +inline void GetCharStretching(double& rX, double& rY) const; sal_Int32 GetBigTextObjectStart() const { return nBigTextObjectStart; } @@ -1282,43 +1282,43 @@ inline ParaPortion* ImpEditEngine::FindParaPortion( ContentNode const * pNode ) return GetParaPortions()[ nPos ]; } -inline void ImpEditEngine::GetCharStretching( sal_uInt16& rX, sal_uInt16& rY ) const +inline void ImpEditEngine::GetCharStretching(double& rX, double& rY) const { -rX = nStretchX; -rY = nStretchY; +rX = mnStretchX; +rY = mnStretchY; } inline short ImpEditEngine::GetXValue( short nXValue ) const { -if ( !aStatus.DoStretch() || ( nStretchX == 100 ) ) +if ( !aStatus.DoStretch() || ( mnStretchX == 100.0 ) ) return nXValue; -return
[Libreoffice-bugs] [Bug 138601] Conditional formats of a XLSX-File are opened and saved in a different order than the original one. This breaks the documents appearance
https://bugs.documentfoundation.org/show_bug.cgi?id=138601 --- Comment #4 from Justin L --- repro 7.5+ In column G, all the cells are plain white without gridlines, while it ought to have a green 90%, a yellow 25%, and a green 10%. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151769] Text dissappearing from slide after saving presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=151769 --- Comment #6 from Regina Henschel --- And this is OK too: Version: 7.4.1.2 (x64) / LibreOffice Community Build ID: 3c58a8f3a960df8bc8fd77b461821e42c061c5f0 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: de-DE (en_US); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 40258] PRINTING With printing a selection: if the last paragraph has a bullet/numbering, all selected paragraphs get that bullet/numbering in the print
https://bugs.documentfoundation.org/show_bug.cgi?id=40258 Terrence Enger changed: What|Removed |Added Status|RESOLVED|VERIFIED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151769] Text dissappearing from slide after saving presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=151769 --- Comment #5 from Regina Henschel --- No problem in Version: 7.3.2.2 (x64) / LibreOffice Community Build ID: 49f2b1bff42cfccbd8f788c8dc32c1c309559be0 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: de-DE (en_US); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103309] [META] Print dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103309 Bug 103309 depends on bug 40258, which changed state. Bug 40258 Summary: PRINTING With printing a selection: if the last paragraph has a bullet/numbering, all selected paragraphs get that bullet/numbering in the print https://bugs.documentfoundation.org/show_bug.cgi?id=40258 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 40258] PRINTING With printing a selection: if the last paragraph has a bullet/numbering, all selected paragraphs get that bullet/numbering in the print
https://bugs.documentfoundation.org/show_bug.cgi?id=40258 Terrence Enger changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108660] [META] Formula bar (input line) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108660 Bug 108660 depends on bug 99708, which changed state. Bug 99708 Summary: Calc Formula Bar multiline input doesn't remember state https://bugs.documentfoundation.org/show_bug.cgi?id=99708 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 40258] PRINTING With printing a selection: if the last paragraph has a bullet/numbering, all selected paragraphs get that bullet/numbering in the print
https://bugs.documentfoundation.org/show_bug.cgi?id=40258 --- Comment #23 from Terrence Enger --- Created attachment 183285 --> https://bugs.documentfoundation.org/attachment.cgi?id=183285=edit reverse bibisect in linux-64-7.4 repo I see no bug in my local --enable-dbgutil build of commit 53d5f5e1 (2022-10-07), built and running on debian-buster. I am setting bug status VERIFIED FIXED. Reverse bibisect in the 7.4 repository points to commit cdf48e57 "tdf#134759 sw: clear items in SwAttrSet::CopyToModify()". result commits-h date - 3 bullets 392efeb7 f3c74dff 2022-06-17 07:18:19 2 bullets 9e277b0e cdf48e57 2022-06-17 07:41:54 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151769] Text dissappearing from slide after saving presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=151769 Regina Henschel changed: What|Removed |Added Keywords||bibisectRequest, regression --- Comment #4 from Regina Henschel --- There is no such problem in Version: 7.1.5.2 (x64) / LibreOffice Community Build ID: 85f04e9f809797b8199d13c421bd8a2b025d52b5 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: de-DE (en_US); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151769] Text dissappearing from slide after saving presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=151769 --- Comment #3 from Regina Henschel --- Yes, it seem to be a problem with animation as reported in bug 151379. If I remove the animation, save and reload, then appending text works. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-4+backports' - ucb/source
ucb/source/ucp/ftp/ftpcontent.cxx | 15 +++ 1 file changed, 15 insertions(+) New commits: commit f2090aa5af719dacadb23cc49f3a5d5478c29143 Author: Michael Stahl AuthorDate: Wed Oct 26 14:58:09 2022 +0200 Commit: Thorsten Behrens CommitDate: Wed Oct 26 21:42:59 2022 +0200 ucb: FTP UCP: report CURLE_URL_MALFORMAT as IllegalIdentifierException With curl 7.86, the test JunitTest_ucb_complex starts to fail: .ftp://noname:nopasswd@*nohost.invalid now executing open com.sun.star.ucb.InteractiveAugmentedIOException: at com.sun.proxy.$Proxy15.execute(Unknown Source) at complex.ucb.UCB.executeCommand(UCB.java:63) at complex.ucb.UCB.checkWrongFtpConnection(UCB.java:119) because curl_easy_perform() now returns CURLE_URL_MALFORMAT where previously it was CURLE_COULDNT_RESOLVE_HOST. Map this to an exception the test expects. Change-Id: Ifdb672946726ddb4cb4d9426b7e70eefac63f040 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141877 Tested-by: Jenkins Reviewed-by: Michael Stahl (cherry picked from commit 022e476af44c0dfc97403dc0f3a3b63e731903e6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141883 Tested-by: Thorsten Behrens Reviewed-by: Thorsten Behrens diff --git a/ucb/source/ucp/ftp/ftpcontent.cxx b/ucb/source/ucp/ftp/ftpcontent.cxx index 92c3639bebf0..a7703e98ed75 100644 --- a/ucb/source/ucp/ftp/ftpcontent.cxx +++ b/ucb/source/ucp/ftp/ftpcontent.cxx @@ -62,6 +62,7 @@ #include #include #include +#include #include #include #include @@ -223,6 +224,7 @@ enum ACTION { NOACTION, THROWAUTHENTICATIONREQUEST, THROWACCESSDENIED, THROWINTERACTIVECONNECT, + THROWMALFORMED, THROWRESOLVENAME, THROWQUOTE, THROWNOFILE, @@ -339,6 +341,15 @@ Any SAL_CALL FTPContent::execute( const Command& aCommand, Environment); break; } +case THROWMALFORMED: +{ +IllegalIdentifierException ex; +aRet <<= ex; +ucbhelper::cancelCommandExecution( +aRet, +Environment); +break; +} case THROWRESOLVENAME: { InteractiveNetworkResolveNameException excep; @@ -533,6 +544,10 @@ Any SAL_CALL FTPContent::execute( const Command& aCommand, { if(e.code() == CURLE_COULDNT_CONNECT) action = THROWINTERACTIVECONNECT; +else if (e.code() == CURLE_URL_MALFORMAT) +{ +action = THROWMALFORMED; +} else if(e.code() == CURLE_COULDNT_RESOLVE_HOST ) action = THROWRESOLVENAME; else if(e.code() == CURLE_FTP_USER_PASSWORD_INCORRECT ||
[Libreoffice-commits] core.git: include/test sc/CppunitTest_sc_jumbosheets_test.mk sc/qa test/source
include/test/unoapi_test.hxx |2 sc/CppunitTest_sc_jumbosheets_test.mk |2 sc/qa/unit/helper/qahelper.cxx| 11 - sc/qa/unit/helper/qahelper.hxx|1 sc/qa/unit/jumbosheets-test.cxx | 320 -- test/source/unoapi_test.cxx |4 6 files changed, 160 insertions(+), 180 deletions(-) New commits: commit bdb76c9ff1832041fa7a9bda30e8d4d7d937ff94 Author: Xisco Fauli AuthorDate: Wed Oct 26 19:30:15 2022 +0200 Commit: Xisco Fauli CommitDate: Wed Oct 26 21:38:56 2022 +0200 CppunitTest_sc_jumbosheets_test: inherit from UnoApiTest Split a couple of tests into 2, one for ods and the other for xlsx Change-Id: I9f6f908b150c435933739335f6618d335ce8f9a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141889 Tested-by: Xisco Fauli Reviewed-by: Xisco Fauli diff --git a/include/test/unoapi_test.hxx b/include/test/unoapi_test.hxx index 577c2d62ece7..d5b8d2145d99 100644 --- a/include/test/unoapi_test.hxx +++ b/include/test/unoapi_test.hxx @@ -38,7 +38,7 @@ public: utl::TempFileNamed save(const OUString& rFilter); utl::TempFileNamed saveAndClose(const OUString& rFilter); -void saveAndReload(const OUString& rFilter); +utl::TempFileNamed saveAndReload(const OUString& rFilter); protected: // reference to document component that we are testing diff --git a/sc/CppunitTest_sc_jumbosheets_test.mk b/sc/CppunitTest_sc_jumbosheets_test.mk index 867589c4fa60..554d3152cbc3 100644 --- a/sc/CppunitTest_sc_jumbosheets_test.mk +++ b/sc/CppunitTest_sc_jumbosheets_test.mk @@ -32,10 +32,12 @@ $(eval $(call gb_CppunitTest_use_libraries,sc_jumbosheets_test, \ sc \ scqahelper \ sfx \ +subsequenttest \ svxcore \ test \ tl \ unotest \ +utl \ vcl \ )) diff --git a/sc/qa/unit/helper/qahelper.cxx b/sc/qa/unit/helper/qahelper.cxx index 40cc56859c4f..be0fe4d2bcf6 100644 --- a/sc/qa/unit/helper/qahelper.cxx +++ b/sc/qa/unit/helper/qahelper.cxx @@ -827,17 +827,6 @@ ScDocShellRef ScBootstrapFixture::saveAndReloadPassword( ScDocShell& rShell, sal return xDocSh; } -ScDocShellRef ScBootstrapFixture::saveAndReloadNoClose( ScDocShell& rShell, sal_Int32 nFormat, std::shared_ptr* pTempFile ) -{ -OUString aFilterName(aFileFormats[nFormat].pFilterName, strlen(aFileFormats[nFormat].pFilterName), RTL_TEXTENCODING_UTF8) ; -OUString aFilterType(aFileFormats[nFormat].pTypeName, strlen(aFileFormats[nFormat].pTypeName), RTL_TEXTENCODING_UTF8); - -ScDocShellRef xDocSh = saveAndReload(rShell, aFilterName, OUString(), aFilterType, aFileFormats[nFormat].nFormatType, pTempFile, nullptr, false); - -CPPUNIT_ASSERT(xDocSh.is()); -return xDocSh; -} - std::shared_ptr ScBootstrapFixture::exportTo( ScDocShell& rShell, sal_Int32 nFormat, bool bValidate ) { OUString aFilterName(aFileFormats[nFormat].pFilterName, strlen(aFileFormats[nFormat].pFilterName), RTL_TEXTENCODING_UTF8) ; diff --git a/sc/qa/unit/helper/qahelper.hxx b/sc/qa/unit/helper/qahelper.hxx index b3541d9c0c5f..32447f716c02 100644 --- a/sc/qa/unit/helper/qahelper.hxx +++ b/sc/qa/unit/helper/qahelper.hxx @@ -226,7 +226,6 @@ public: ScDocShellRef saveAndReload( ScDocShell& rShell, sal_Int32 nFormat, std::shared_ptr* pTempFile = nullptr ); ScDocShellRef saveAndReloadPassword( ScDocShell& rShell, sal_Int32 nFormat, std::shared_ptr* pTempFile = nullptr ); -ScDocShellRef saveAndReloadNoClose( ScDocShell& rShell, sal_Int32 nFormat, std::shared_ptr* pTempFile = nullptr ); std::shared_ptr exportTo(ScDocShell& rShell, sal_Int32 nFormat, bool bValidate = true); diff --git a/sc/qa/unit/jumbosheets-test.cxx b/sc/qa/unit/jumbosheets-test.cxx index 388967e9c43c..1cf820895ed5 100644 --- a/sc/qa/unit/jumbosheets-test.cxx +++ b/sc/qa/unit/jumbosheets-test.cxx @@ -8,8 +8,7 @@ */ #include -#include -#include +#include #include #include #include @@ -19,13 +18,14 @@ #include #include +#include #include #include #include #include #include +#include -#include "helper/qahelper.hxx" #include "helper/xpath.hxx" using namespace ::com::sun::star; @@ -33,7 +33,7 @@ using namespace ::com::sun::star::uno; /* Tests for sheets larger than 1024 columns and/or 1048576 rows. */ -class ScJumboSheetsTest : public unotest::MacrosTest, public ScBootstrapFixture, public XmlTestTools +class ScJumboSheetsTest : public UnoApiTest, public XmlTestTools { public: ScJumboSheetsTest(); @@ -43,8 +43,10 @@ public: void testRoundtripColumn2000Ods(); void testRoundtripColumn2000Xlsx(); -void testRoundtripColumnRange(); -void testRoundtripNamedRanges(); +void testRoundtripColumnRangeOds(); +void testRoundtripColumnRangeXlsx(); +void testRoundtripNamedRangesOds(); +void testRoundtripNamedRangesXlsx(); void testNamedRangeNameConflict(); void testTdf134553(); void testTdf134392(); @@ -56,8 +58,10
[Libreoffice-commits] core.git: chart2/CppunitTest_chart2_geometry.mk sc/CppunitTest_sc_macros_test.mk sc/CppunitTest_sc_shapetest.mk sc/CppunitTest_sc_uicalc.mk sd/CppunitTest_sd_uiimpress.mk sw/Cppu
chart2/CppunitTest_chart2_geometry.mk |4 sc/CppunitTest_sc_macros_test.mk |4 sc/CppunitTest_sc_shapetest.mk|4 sc/CppunitTest_sc_uicalc.mk |4 sd/CppunitTest_sd_uiimpress.mk|4 sw/CppunitTest_sw_macros_test.mk |4 6 files changed, 24 insertions(+) New commits: commit 5e43ccb27584d98699e2b2e06658d5b52ebcdff7 Author: Stephan Bergmann AuthorDate: Wed Oct 26 15:01:00 2022 +0200 Commit: Stephan Bergmann CommitDate: Wed Oct 26 21:22:53 2022 +0200 More CppunitTests need the ASan hack ...from e854abe076155fc085b56549ced50b3ee9a095d2 "Avoid external processes picking up instdir/program/libnspr4.so", after Xisco's recent CppunitTest clean- up Change-Id: Ia47e770a439af3476f81f8c28f2527bbf144baa4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141890 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/chart2/CppunitTest_chart2_geometry.mk b/chart2/CppunitTest_chart2_geometry.mk index 9b9ff34b5335..1b31bf9d7269 100644 --- a/chart2/CppunitTest_chart2_geometry.mk +++ b/chart2/CppunitTest_chart2_geometry.mk @@ -134,6 +134,10 @@ $(eval $(call gb_CppunitTest_use_uiconfigs,chart2_geometry, \ $(eval $(call gb_CppunitTest_use_configuration,chart2_geometry)) +$(eval $(call gb_CppunitTest_add_arguments,chart2_geometry, \ + -env:arg-env=$(gb_Helper_LIBRARY_PATH_VAR)"{$(gb_Helper_LIBRARY_PATH_VAR)+=$(gb_Helper_LIBRARY_PATH_VAR)}" \ +)) + $(call gb_CppunitTest_get_target,chart2_geometry): $(call gb_Package_get_target,postprocess_images) # vim: set noet sw=4 ts=4: diff --git a/sc/CppunitTest_sc_macros_test.mk b/sc/CppunitTest_sc_macros_test.mk index a6dd427cde67..e505f721396f 100644 --- a/sc/CppunitTest_sc_macros_test.mk +++ b/sc/CppunitTest_sc_macros_test.mk @@ -79,4 +79,8 @@ $(eval $(call gb_CppunitTest_use_rdb,sc_macros_test,services)) $(eval $(call gb_CppunitTest_use_configuration,sc_macros_test)) +$(eval $(call gb_CppunitTest_add_arguments,sc_macros_test, \ + -env:arg-env=$(gb_Helper_LIBRARY_PATH_VAR)"{$(gb_Helper_LIBRARY_PATH_VAR)+=$(gb_Helper_LIBRARY_PATH_VAR)}" \ +)) + # vim: set noet sw=4 ts=4: diff --git a/sc/CppunitTest_sc_shapetest.mk b/sc/CppunitTest_sc_shapetest.mk index 9ca17f2512c0..e8dde4042409 100644 --- a/sc/CppunitTest_sc_shapetest.mk +++ b/sc/CppunitTest_sc_shapetest.mk @@ -53,4 +53,8 @@ $(eval $(call gb_CppunitTest_use_components,sc_shapetest,\ $(eval $(call gb_CppunitTest_use_configuration,sc_shapetest)) +$(eval $(call gb_CppunitTest_add_arguments,sc_shapetest, \ + -env:arg-env=$(gb_Helper_LIBRARY_PATH_VAR)"{$(gb_Helper_LIBRARY_PATH_VAR)+=$(gb_Helper_LIBRARY_PATH_VAR)}" \ +)) + # vim: set noet sw=4 ts=4: diff --git a/sc/CppunitTest_sc_uicalc.mk b/sc/CppunitTest_sc_uicalc.mk index da0326757b46..af23c8b38966 100644 --- a/sc/CppunitTest_sc_uicalc.mk +++ b/sc/CppunitTest_sc_uicalc.mk @@ -53,4 +53,8 @@ $(eval $(call gb_CppunitTest_use_rdb,sc_uicalc,services)) $(eval $(call gb_CppunitTest_use_configuration,sc_uicalc)) +$(eval $(call gb_CppunitTest_add_arguments,sc_uicalc, \ + -env:arg-env=$(gb_Helper_LIBRARY_PATH_VAR)"{$(gb_Helper_LIBRARY_PATH_VAR)+=$(gb_Helper_LIBRARY_PATH_VAR)}" \ +)) + # vim: set noet sw=4 ts=4: diff --git a/sd/CppunitTest_sd_uiimpress.mk b/sd/CppunitTest_sd_uiimpress.mk index e7ee786e98ba..2599d0a97982 100644 --- a/sd/CppunitTest_sd_uiimpress.mk +++ b/sd/CppunitTest_sd_uiimpress.mk @@ -84,4 +84,8 @@ $(eval $(call gb_CppunitTest_use_custom_headers,sd_uiimpress,\ $(eval $(call gb_CppunitTest_use_configuration,sd_uiimpress)) +$(eval $(call gb_CppunitTest_add_arguments,sd_uiimpress, \ + -env:arg-env=$(gb_Helper_LIBRARY_PATH_VAR)"{$(gb_Helper_LIBRARY_PATH_VAR)+=$(gb_Helper_LIBRARY_PATH_VAR)}" \ +)) + # vim: set noet sw=4 ts=4: diff --git a/sw/CppunitTest_sw_macros_test.mk b/sw/CppunitTest_sw_macros_test.mk index 74887fa70ea3..a0be4e6cd27f 100644 --- a/sw/CppunitTest_sw_macros_test.mk +++ b/sw/CppunitTest_sw_macros_test.mk @@ -73,4 +73,8 @@ $(eval $(call gb_CppunitTest_use_rdb,sw_macros_test,services)) $(eval $(call gb_CppunitTest_use_configuration,sw_macros_test)) +$(eval $(call gb_CppunitTest_add_arguments,sw_macros_test, \ + -env:arg-env=$(gb_Helper_LIBRARY_PATH_VAR)"{$(gb_Helper_LIBRARY_PATH_VAR)+=$(gb_Helper_LIBRARY_PATH_VAR)}" \ +)) + # vim: set noet sw=4 ts=4:
[Libreoffice-bugs] [Bug 151379] Only 3 characters of slide title remain after save and reload if effect attached
https://bugs.documentfoundation.org/show_bug.cgi?id=151379 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||1769 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151769] Text dissappearing from slide after saving presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=151769 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||1379 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151769] Text dissappearing from slide after saving presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=151769 Regina Henschel changed: What|Removed |Added Ever confirmed|0 |1 CC||rb.hensc...@t-online.de Status|UNCONFIRMED |NEW --- Comment #2 from Regina Henschel --- I can reproduce the problem with the attached file. But I'm not able to create a new file which has this problem, and I do not see any special in the file markup. Tested with Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 17dfc9a9da009cc23de3fb4e2cef9c97d581 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: de-DE (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151772] Unable to open specific CSV file
https://bugs.documentfoundation.org/show_bug.cgi?id=151772 Buovjaga changed: What|Removed |Added Ever confirmed|0 |1 Summary|file *.csv |Unable to open specific CSV ||file CC||ilmari.lauhakangas@libreoff ||ice.org Status|UNCONFIRMED |NEEDINFO Component|LibreOffice |Calc --- Comment #1 from Buovjaga --- Please attach an example document. Set to NEEDINFO. Change back to UNCONFIRMED after you have provided the document. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151670] Can not use japanese IME on FreeBSD
https://bugs.documentfoundation.org/show_bug.cgi?id=151670 Shinji Enoki changed: What|Removed |Added Summary|Can not use japanese IME|Can not use japanese IME on ||FreeBSD -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/source
vcl/source/control/tabctrl.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit aad5baa3836087032658a5db3673decd9e242e75 Author: Caolán McNamara AuthorDate: Wed Oct 26 16:47:14 2022 +0100 Commit: Caolán McNamara CommitDate: Wed Oct 26 20:44:25 2022 +0200 tab items not exactly centered Change-Id: I98938855876f8f7d821bacd8ba135053c92683a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141887 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/vcl/source/control/tabctrl.cxx b/vcl/source/control/tabctrl.cxx index cd37a777f5bf..0a9d3677fe2f 100644 --- a/vcl/source/control/tabctrl.cxx +++ b/vcl/source/control/tabctrl.cxx @@ -378,7 +378,7 @@ static void lcl_AdjustSingleLineTabs(tools::Long nMaxWidth, ImplTabCtrlData *pTa { if (!item.m_bVisible) continue; -nRightSpace -= item.maRect.Right() - item.maRect.Left(); +nRightSpace -= item.maRect.GetWidth(); } nRightSpace /= 2;
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - sw/source
sw/source/uibase/app/docst.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 4d89a1f455ffec0a03b5568b201c4e2f73c4fe11 Author: Aron Budea AuthorDate: Sat Oct 8 00:58:12 2022 +0200 Commit: Andras Timar CommitDate: Wed Oct 26 20:39:04 2022 +0200 "No List" option in Styles Sidebar doesn't remove list in non-English UI In a list, with Styles sidebar open and List Styles selected, the No List option did not remove the list if the UI language was other than English. No List entry exists since a56aa46fcc62227df7dc9a8fa04205e8ff5ed2a1 . Change-Id: I5210c07c811d08489c1b9a199f6756273153e05d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141092 Tested-by: Jenkins Reviewed-by: Aron Budea (cherry picked from commit 6a97ccad4a5d2a0d97bfe023aedf7a0146cd9782) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141179 Tested-by: Jenkins CollaboraOffice Reviewed-by: Andras Timar diff --git a/sw/source/uibase/app/docst.cxx b/sw/source/uibase/app/docst.cxx index 44e42d6f58c3..65859c303d0d 100644 --- a/sw/source/uibase/app/docst.cxx +++ b/sw/source/uibase/app/docst.cxx @@ -1185,7 +1185,7 @@ SfxStyleFamily SwDocShell::ApplyStyles(const OUString , SfxStyleFamily nFa // reset indent attribute on applying list style // continue list of list style const SwNumRule* pNumRule = pStyle->GetNumRule(); -if (pNumRule->GetName() == "No List") +if (pNumRule->GetName() == SwResId(STR_POOLNUMRULE_NOLIST)) { SfxViewFrame::Current()->GetDispatcher()->Execute(FN_NUM_BULLET_OFF); break;
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - include/vcl vcl/inc vcl/Library_vcl.mk vcl/source
include/vcl/filter/pdfdocument.hxx |2 vcl/Library_vcl.mk |1 vcl/inc/pdf/ExternalPDFStreams.hxx |2 vcl/inc/pdf/pdfcompat.hxx | 42 vcl/source/filter/ipdf/pdfcompat.cxx | 113 + vcl/source/filter/ipdf/pdfdocument.cxx | 14 vcl/source/filter/ipdf/pdfread.cxx | 104 +- 7 files changed, 178 insertions(+), 100 deletions(-) New commits: commit 03a0b41ba21f7d546160c819e088e0b0023b68bb Author: Dennis Francis AuthorDate: Tue Oct 18 16:14:37 2022 +0530 Commit: Andras Timar CommitDate: Wed Oct 26 20:38:17 2022 +0200 vcl: re-exporting broken pdfs -> empty pages Certain pdf documents when loaded in LO_IMPORT_USE_PDFIUM=1 mode even if pdf-version < v1.6 sometimes has missing objects referred by other objects for determing its stream length for instance. As a result parsing fails and results in a pdf with empty pages. A round trip through pdfium and exporting to v1.6 seems to cure the issue. Possibly it does some repairing work to determine the length of the stream in a independent pass through the file. Change-Id: Id09f67eddab4163ed12a3a3f3a73baf92e2912aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141854 Tested-by: Jenkins CollaboraOffice Reviewed-by: Andras Timar diff --git a/include/vcl/filter/pdfdocument.hxx b/include/vcl/filter/pdfdocument.hxx index dd03029227d2..fbe0be89cdc6 100644 --- a/include/vcl/filter/pdfdocument.hxx +++ b/include/vcl/filter/pdfdocument.hxx @@ -576,6 +576,8 @@ public: //@{ /// Read elements from the start of the stream till its end. bool Read(SvStream& rStream); +/// Calls Read() first and if it fails it tries to fixup and then retry. +bool ReadWithPossibleFixup(SvStream& rStream); void SetSignatureLine(std::vector&& rSignatureLine); void SetSignaturePage(size_t nPage); /// Sign the read document with xCertificate in the edit buffer. diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk index b0a6ee533133..25f6a0ef9562 100644 --- a/vcl/Library_vcl.mk +++ b/vcl/Library_vcl.mk @@ -450,6 +450,7 @@ $(eval $(call gb_Library_add_exception_objects,vcl,\ vcl/source/filter/ipict/ipict \ vcl/source/filter/ipsd/ipsd \ vcl/source/filter/ipict/shape \ +vcl/source/filter/ipdf/pdfcompat \ vcl/source/filter/ipdf/pdfread \ vcl/source/filter/ipdf/pdfdocument \ vcl/source/filter/iras/iras \ diff --git a/vcl/inc/pdf/ExternalPDFStreams.hxx b/vcl/inc/pdf/ExternalPDFStreams.hxx index 7840217630c8..45b15f7a74bc 100644 --- a/vcl/inc/pdf/ExternalPDFStreams.hxx +++ b/vcl/inc/pdf/ExternalPDFStreams.hxx @@ -42,7 +42,7 @@ struct VCL_DLLPUBLIC ExternalPDFStream aPDFStream.WriteBytes(maDataContainer.getData(), maDataContainer.getSize()); aPDFStream.Seek(0); auto pPDFDocument = std::make_shared(); -if (!pPDFDocument->Read(aPDFStream)) +if (!pPDFDocument->ReadWithPossibleFixup(aPDFStream)) { SAL_WARN("vcl.pdfwriter", "PDFWriterImpl::writeReferenceXObject: reading the PDF document failed"); diff --git a/vcl/inc/pdf/pdfcompat.hxx b/vcl/inc/pdf/pdfcompat.hxx new file mode 100644 index ..8f629b3bc8ee --- /dev/null +++ b/vcl/inc/pdf/pdfcompat.hxx @@ -0,0 +1,42 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#pragma once + +#include +#include +#include +#include +#include + +namespace vcl::pdf +{ +/// Convert to inch, then assume 96 DPI. +inline double pointToPixel(const double fPoint, const double fResolutionDPI) +{ +return o3tl::convert(fPoint, o3tl::Length::pt, o3tl::Length::in) * fResolutionDPI; +} + +/// Decide if PDF data is old enough to be compatible. +bool isCompatible(SvStream& rInStream, sal_uInt64 nPos, sal_uInt64 nSize); + +/// Converts to highest supported format version (currently 1.6). +/// Usually used to deal with missing referenced objects in the +/// source pdf stream. +bool convertToHighestSupported(SvStream& rInStream, SvStream& rOutStream); + +/// Takes care of transparently downgrading the version of the PDF stream in +/// case it's too new for our PDF export. +bool getCompatibleStream(SvStream& rInStream, SvStream& rOutStream); + +BinaryDataContainer createBinaryDataContainer(SvStream& rStream); + +} // end of vcl::filter::ipdf namespace + +/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/vcl/source/filter/ipdf/pdfcompat.cxx b/vcl/source/filter/ipdf/pdfcompat.cxx new file mode 100644 index ..52be1f3b2c07 --- /dev/null +++
[Libreoffice-bugs] [Bug 151670] Can not use japanese IME
https://bugs.documentfoundation.org/show_bug.cgi?id=151670 --- Comment #2 from Shinji Enoki --- @sergej, FreeBSD version of LibreOffice is not provided by The Document Foundation. Shouldn't you report it to the FreeBSD project? I've searched the FreeBSD bugzilla for LibreOffice. https://bugs.freebsd.org/bugzilla/buglist.cgi?order=changeddate%2Cpriority%2Cbug_severity_format=advanced_desc=LibreOffice_desc_type=allwordssubstr -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151773] New: improve explanation of extensions location
https://bugs.documentfoundation.org/show_bug.cgi?id=151773 Bug ID: 151773 Summary: improve explanation of extensions location Product: LibreOffice Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: inp...@gmail.com Description: To save internet bandwidth, unable to copy via removable media, an extension on one computer, onto another computer Directory contains oxt content: ../.config/libreoffice/4/user/uno_packages/cache/uno_packages/ names of extensions in this directory are not clear. Copy of this directory to another computer, not recognised on new computer libreoffice Steps to Reproduce: To save internet bandwidth, unable to copy via removable media, an extension on one computer, onto another computer Directory contains oxt content: ../.config/libreoffice/4/user/uno_packages/cache/uno_packages/ names of extensions in this directory are not clear. Copy of this directory to another computer, not recognised on new computer libreoffice Actual Results: To save internet bandwidth, unable to copy via removable media, an extension on one computer, onto another computer Directory contains oxt content: ../.config/libreoffice/4/user/uno_packages/cache/uno_packages/ names of extensions in this directory are not clear. Copy of this directory to another computer, not recognised on new computer libreoffice Expected Results: After exit, re-start libreoffice, oxt directory should be recognised. Reproducible: Always User Profile Reset: No Additional Info: To save internet bandwidth, unable to copy via removable media, an extension on one computer, onto another computer Directory contains oxt content: ../.config/libreoffice/4/user/uno_packages/cache/uno_packages/ names of extensions in this directory are not clear. Copy of this directory to another computer, not recognised on new computer libreoffice -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'private/tvajngerl/staging' - 9 commits - basegfx/test editeng/inc editeng/source filter/source include/basegfx include/editeng include/svx sd/qa sd/source svx/s
Rebased ref, commits from common ancestor: commit 08e0010da2a24ccc65e6a98af89363e0eeeb6a45 Author: Tomaž Vajngerl AuthorDate: Wed Oct 26 20:21:37 2022 +0200 Commit: Tomaž Vajngerl CommitDate: Wed Oct 26 20:23:58 2022 +0200 svx: change PaperInfo to return gfx::Length paper sizes Change-Id: Ie99a748ab9282893a852278be9793f7379522541 diff --git a/editeng/source/items/paperinf.cxx b/editeng/source/items/paperinf.cxx index 86401e63f387..130e7c020a41 100644 --- a/editeng/source/items/paperinf.cxx +++ b/editeng/source/items/paperinf.cxx @@ -39,6 +39,12 @@ Size SvxPaperInfo::GetPaperSize( Paper ePaper, MapUnit eUnit ) : OutputDevice::LogicToLogic(aRet, MapMode(MapUnit::Map100thMM), MapMode(eUnit)); } +gfx::Size2DL SvxPaperInfo::getPaperSize(Paper ePaper) +{ +PaperInfo aInfo(ePaper); +return { gfx::Length::hmm(aInfo.getWidth()), gfx::Length::hmm(aInfo.getHeight()) }; +} + /* Description: Return the paper size of the printer, aligned to our own sizes. If no Printer is set in the system, A4 portrait @@ -108,6 +114,12 @@ Size SvxPaperInfo::GetDefaultPaperSize( MapUnit eUnit ) : OutputDevice::LogicToLogic(aRet, MapMode(MapUnit::Map100thMM), MapMode(eUnit)); } +gfx::Size2DL SvxPaperInfo::getDefaultPaperSize() +{ +PaperInfo aInfo(PaperInfo::getSystemDefaultPaper()); +return { gfx::Length::hmm(aInfo.getWidth()), gfx::Length::hmm(aInfo.getHeight()) }; +} + /* Description: String representation for the SV-defines of paper size */ diff --git a/include/editeng/paperinf.hxx b/include/editeng/paperinf.hxx index 2ccc8fbf96fa..20bc1441ba74 100644 --- a/include/editeng/paperinf.hxx +++ b/include/editeng/paperinf.hxx @@ -25,6 +25,7 @@ #include #include #include +#include #include // forward --- @@ -42,6 +43,9 @@ public: static PaperGetSvxPaper( const Size , MapUnit eUnit ); static tools::Long GetSloppyPaperDimension( tools::Long nSize ); static OUString GetName( Paper ePaper ); + +static gfx::Size2DL getPaperSize(Paper ePaper); +static gfx::Size2DL getDefaultPaperSize(); }; // INLINE - diff --git a/include/svx/svdpage.hxx b/include/svx/svdpage.hxx index c9b38f1bbebf..c1a238f72c0f 100644 --- a/include/svx/svdpage.hxx +++ b/include/svx/svdpage.hxx @@ -371,6 +371,13 @@ public: , maLower(0_emu) {} +Border(gfx::Length const& nLeft, gfx::Length const& nUpper, gfx::Length const& nRight, gfx::Length const& nLower) +: maLeft(nLeft) +, maRight(nRight) +, maUpper(nUpper) +, maLower(nLower) +{} + gfx::Length const& getLeft() const { return maLeft; } gfx::Length const& getRight() const { return maRight; } gfx::Length const& getUpper() const { return maUpper; } diff --git a/sd/source/core/drawdoc2.cxx b/sd/source/core/drawdoc2.cxx index a14e4382a8e0..4b8f8360e6ac 100644 --- a/sd/source/core/drawdoc2.cxx +++ b/sd/source/core/drawdoc2.cxx @@ -499,7 +499,7 @@ void SdDrawDocument::CreateFirstPages( SdDrawDocument const * pRefDocument /* = return; // #i57181# Paper size depends on Language, like in Writer -Size aDefSize = SvxPaperInfo::GetDefaultPaperSize( MapUnit::Map100thMM ); +gfx::Size2DL aDefaultSize = SvxPaperInfo::getDefaultPaperSize(); // Insert handout page rtl::Reference pHandoutPage = AllocSdPage(false); @@ -516,8 +516,8 @@ void SdDrawDocument::CreateFirstPages( SdDrawDocument const * pRefDocument /* = } else { -pHandoutPage->setSize(gfx::length::fromSizeHmm(aDefSize)); -pHandoutPage->SetBorder(0, 0, 0, 0); +pHandoutPage->setSize(aDefaultSize); +pHandoutPage->setBorder(svx::Border()); } pHandoutPage->SetPageKind(PageKind::Handout); @@ -553,7 +553,7 @@ void SdDrawDocument::CreateFirstPages( SdDrawDocument const * pRefDocument /* = else if (meDocType == DocumentType::Draw) { // Draw: always use default size with margins -pPage->setSize(gfx::length::fromSizeHmm(aDefSize)); +pPage->setSize(aDefaultSize); SfxPrinter* pPrinter = mpDocSh->GetPrinter(false); if (pPrinter && pPrinter->IsValid()) @@ -563,12 +563,12 @@ void SdDrawDocument::CreateFirstPages( SdDrawDocument const * pRefDocument /* = aPageOffset -= pPrinter->PixelToLogic( Point() ); ::tools::Long nOffset = !aPageOffset.X() && !aPageOffset.Y() ? 0 : PRINT_OFFSET; -sal_uLong nTop= aPageOffset.Y(); -sal_uLong nLeft = aPageOffset.X(); -sal_uLong nBottom =
[Libreoffice-bugs] [Bug 151736] Opening Writer document with direct formatting crashes whole LO
https://bugs.documentfoundation.org/show_bug.cgi?id=151736 Telesto changed: What|Removed |Added Keywords||bibisectRequest, regression CC||tele...@surfxs.nl -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151772] New: file *.csv
https://bugs.documentfoundation.org/show_bug.cgi?id=151772 Bug ID: 151772 Summary: file *.csv Product: LibreOffice Version: 7.3.6.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: j@tuta.io in calc impossible to open file *.csv probably done with excel, while it works in Open Ofice v4.1.13 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: chart2/qa include/test sc/qa test/source
chart2/qa/extras/chart2export2.cxx |2 -- chart2/qa/extras/chart2geometry.cxx |3 --- include/test/unoapi_test.hxx|1 + sc/qa/unit/uicalc/uicalc.cxx|8 test/source/unoapi_test.cxx | 14 +++--- 5 files changed, 16 insertions(+), 12 deletions(-) New commits: commit b45ab31f2b5eb93773608f06b947cd9c5a169150 Author: Xisco Fauli AuthorDate: Wed Oct 26 18:12:42 2022 +0200 Commit: Xisco Fauli CommitDate: Wed Oct 26 19:34:28 2022 +0200 UnoApiTest: do not dispose on save Change-Id: Id100591517da48ec8e5cfd38f5c44ac0d7b16198 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141888 Tested-by: Jenkins Reviewed-by: Xisco Fauli diff --git a/chart2/qa/extras/chart2export2.cxx b/chart2/qa/extras/chart2export2.cxx index 64e5e5c676d4..1d79de8e119a 100644 --- a/chart2/qa/extras/chart2export2.cxx +++ b/chart2/qa/extras/chart2export2.cxx @@ -1127,8 +1127,6 @@ void Chart2ExportTest2::testTdf127792() assertXPath(pXmlDoc, "/c:chartSpace/c:chart/c:plotArea/c:valAx/c:crossBetween", "val", "between"); } - -loadFromURL(u"docx/MSO_axis_position.docx"); { xmlDocUniquePtr pXmlDoc = parseExport("word/charts/chart2", "Office Open XML Text"); CPPUNIT_ASSERT(pXmlDoc); diff --git a/chart2/qa/extras/chart2geometry.cxx b/chart2/qa/extras/chart2geometry.cxx index 9073fcb42cfe..873d00a7f33e 100644 --- a/chart2/qa/extras/chart2geometry.cxx +++ b/chart2/qa/extras/chart2geometry.cxx @@ -209,7 +209,6 @@ void Chart2GeometryTest::testTdf128345ChartArea_CG_TS_import() = getXPathContent(pXmlDoc, sStylePath + "/style:graphic-properties/@draw:opacity-name"); // Verify the content of the opacity definition -loadFromURL(u"pptx/tdf128345_ChartArea_CG_TS.pptx"); xmlDocUniquePtr pXmlDoc2 = parseExport("Object 1/styles.xml", "impress8"); CPPUNIT_ASSERT(pXmlDoc2); const OString sAttribute("@draw:name='" + OU2O(sOUOpacityName) + "'"); @@ -261,7 +260,6 @@ void Chart2GeometryTest::testTdf128345ChartWall_CS_TG_import() = getXPathContent(pXmlDoc, sStylePath + "/style:graphic-properties/@draw:opacity-name"); // Verify content of the opacity definition -loadFromURL(u"pptx/tdf128345_ChartWall_CS_TG.pptx"); xmlDocUniquePtr pXmlDoc2 = parseExport("Object 1/styles.xml", "impress8"); CPPUNIT_ASSERT(pXmlDoc2); const OString sAttribute("@draw:name='" + OU2O(sOUOpacityName) + "'"); @@ -312,7 +310,6 @@ void Chart2GeometryTest::testTdf128345Legend_CS_TG_axial_import() const OUString sOUOpacityName = getXPathContent(pXmlDoc, sStylePath + "/style:graphic-properties/@draw:opacity-name"); -loadFromURL(u"pptx/tdf128345_Legend_CS_TG_axial.pptx"); // Verify content of the opacity definition xmlDocUniquePtr pXmlDoc2 = parseExport("Object 1/styles.xml", "impress8"); CPPUNIT_ASSERT(pXmlDoc2); diff --git a/include/test/unoapi_test.hxx b/include/test/unoapi_test.hxx index 8c19a56333a9..577c2d62ece7 100644 --- a/include/test/unoapi_test.hxx +++ b/include/test/unoapi_test.hxx @@ -37,6 +37,7 @@ public: const css::uno::Sequence& rParams = {}); utl::TempFileNamed save(const OUString& rFilter); +utl::TempFileNamed saveAndClose(const OUString& rFilter); void saveAndReload(const OUString& rFilter); protected: diff --git a/sc/qa/unit/uicalc/uicalc.cxx b/sc/qa/unit/uicalc/uicalc.cxx index 27e28175bc23..38c8cb537371 100644 --- a/sc/qa/unit/uicalc/uicalc.cxx +++ b/sc/qa/unit/uicalc/uicalc.cxx @@ -153,7 +153,7 @@ CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testTdf100847) CPPUNIT_ASSERT(pDoc); // Save the document -utl::TempFileNamed aTempFile = save("calc8"); +saveAndClose("calc8"); // Open a new document mxComponent = loadFromDesktop("private:factory/scalc"); @@ -186,7 +186,7 @@ CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testExternalReferences) insertStringToCell(*pModelObj, "D3", u"FISHY"); // Save the document -utl::TempFileNamed aTempFile = save("calc8"); +utl::TempFileNamed aTempFile = saveAndClose("calc8"); // Open a new document mxComponent = loadFromDesktop("private:factory/scalc"); @@ -292,7 +292,7 @@ CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testTdf103994) insertStringToCell(*pModelObj, "B1", u"2"); // Save the document -utl::TempFileNamed aTempFile = save("calc8"); +utl::TempFileNamed aTempFile = saveAndClose("calc8"); // Open a new document mxComponent = loadFromDesktop("private:factory/scalc"); @@ -334,7 +334,7 @@ CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testTdf113541) insertStringToCell(*pModelObj, "A1", u"50"); // Save the document -utl::TempFileNamed aTempFile = save("calc8"); +utl::TempFileNamed aTempFile = saveAndClose("calc8"); // Open a new document mxComponent = loadFromDesktop("private:factory/scalc"); diff --git a/test/source/unoapi_test.cxx
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-4+backports' - download.lst external/zlib
download.lst |4 - external/zlib/1eb7682f845ac9e9bf9ae35bbfb3bad5dacbd91d.patch | 29 - external/zlib/UnpackedTarball_zlib.mk|7 -- external/zlib/eff308af425b67093bab25f80f1ae950166bece1.patch | 32 --- 4 files changed, 3 insertions(+), 69 deletions(-) New commits: commit 74dcb9bdfb1fde848e05cef0dc783067a397616b Author: Taichi Haradaguchi <20001...@ymail.ne.jp> AuthorDate: Mon Oct 24 18:00:18 2022 +0900 Commit: Michael Stahl CommitDate: Wed Oct 26 19:15:38 2022 +0200 zlib: upgrade to release 1.2.13 Fixes CVE-2022-37434 Removed two patches as fixed upstream. Change-Id: I10465b7eafc4952cf8dc64e6d7a77f5e5255a386 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141757 Tested-by: Jenkins Reviewed-by: Caolán McNamara (cherry picked from commit b2d6ad64473527f88dfb7088376ccf1242d97666) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141881 Tested-by: Michael Stahl Reviewed-by: Michael Stahl diff --git a/download.lst b/download.lst index 5f8454d2ab1c..8a9b535b9561 100644 --- a/download.lst +++ b/download.lst @@ -253,8 +253,8 @@ export WPS_VERSION_MICRO := 10 export WPS_TARBALL := libwps-0.4.$(WPS_VERSION_MICRO).tar.xz export XSLTML_SHA256SUM := 75823776fb51a9c526af904f1503a7afaaab900fba83eda64f8a41073724c870 export XSLTML_TARBALL := a7983f859eafb2677d7ff386a023bc40-xsltml_2.1.2.zip -export ZLIB_SHA256SUM := 7db46b8d7726232a621befaab4a1c870f00a90805511c0e0090441dac57def18 -export ZLIB_TARBALL := zlib-1.2.12.tar.xz +export ZLIB_SHA256SUM := d14c38e313afc35a9a8760dadf26042f51ea0f5d154b0630a31da0540107fb98 +export ZLIB_TARBALL := zlib-1.2.13.tar.xz export ZMF_SHA256SUM := 27051a30cb057fdb5d5de65a1f165c7153dc76e27fe62251cbb86639eb2caf22 export ZMF_TARBALL := libzmf-0.0.2.tar.xz diff --git a/external/zlib/1eb7682f845ac9e9bf9ae35bbfb3bad5dacbd91d.patch b/external/zlib/1eb7682f845ac9e9bf9ae35bbfb3bad5dacbd91d.patch deleted file mode 100644 index c5c95a92b28a.. --- a/external/zlib/1eb7682f845ac9e9bf9ae35bbfb3bad5dacbd91d.patch +++ /dev/null @@ -1,29 +0,0 @@ -From 1eb7682f845ac9e9bf9ae35bbfb3bad5dacbd91d Mon Sep 17 00:00:00 2001 -From: Mark Adler -Date: Mon, 8 Aug 2022 10:50:09 -0700 -Subject: [PATCH] Fix extra field processing bug that dereferences NULL - state->head. - -The recent commit to fix a gzip header extra field processing bug -introduced the new bug fixed here. - inflate.c | 4 ++-- - 1 file changed, 2 insertions(+), 2 deletions(-) - -diff --git a/inflate.c b/inflate.c -index 7a7289749..2a3c4fe98 100644 a/inflate.c -+++ b/inflate.c -@@ -763,10 +763,10 @@ int flush; - copy = state->length; - if (copy > have) copy = have; - if (copy) { --len = state->head->extra_len - state->length; - if (state->head != Z_NULL && - state->head->extra != Z_NULL && --len < state->head->extra_max) { -+(len = state->head->extra_len - state->length) < -+state->head->extra_max) { - zmemcpy(state->head->extra + len, next, - len + copy > state->head->extra_max ? - state->head->extra_max - len : copy); diff --git a/external/zlib/UnpackedTarball_zlib.mk b/external/zlib/UnpackedTarball_zlib.mk index 10ee74b9568a..dd9fc1c31445 100644 --- a/external/zlib/UnpackedTarball_zlib.mk +++ b/external/zlib/UnpackedTarball_zlib.mk @@ -16,11 +16,6 @@ $(eval $(call gb_UnpackedTarball_set_post_action,zlib,\ cp $(addsuffix .c,adler32 compress crc32 deflate inffast inflate inftrees trees zutil) x64 \ )) -$(eval $(call gb_UnpackedTarball_set_patchlevel,zlib,1)) - -$(eval $(call gb_UnpackedTarball_add_patches,zlib,\ - external/zlib/eff308af425b67093bab25f80f1ae950166bece1.patch \ - external/zlib/1eb7682f845ac9e9bf9ae35bbfb3bad5dacbd91d.patch \ -)) +$(eval $(call gb_UnpackedTarball_set_patchlevel,zlib,0)) # vim: set noet sw=4 ts=4: diff --git a/external/zlib/eff308af425b67093bab25f80f1ae950166bece1.patch b/external/zlib/eff308af425b67093bab25f80f1ae950166bece1.patch deleted file mode 100644 index dc84d3a1d385.. --- a/external/zlib/eff308af425b67093bab25f80f1ae950166bece1.patch +++ /dev/null @@ -1,32 +0,0 @@ -From eff308af425b67093bab25f80f1ae950166bece1 Mon Sep 17 00:00:00 2001 -From: Mark Adler -Date: Sat, 30 Jul 2022 15:51:11 -0700 -Subject: [PATCH] Fix a bug when getting a gzip header extra field with - inflate(). - -If the extra field was larger than the space the user provided with -inflateGetHeader(), and if multiple calls of inflate() delivered -the extra header data, then there could be a buffer overflow of the -provided space. This commit assures that provided space is not -exceeded. - inflate.c | 5 +++-- - 1 file
[Libreoffice-bugs] [Bug 151764] LibreOffice 7.3.6.2, Linux Mint 21 x86-64: Media_without_Macros.odb Report error thrashes disk.
https://bugs.documentfoundation.org/show_bug.cgi?id=151764 Robert Großkopf changed: What|Removed |Added CC||rob...@familiegrosskopf.de --- Comment #3 from Robert Großkopf --- No problem to open report "Recall" from "Media_without_Macros.odb" here with LO 7.4.2.3 on OpenSUSE 15.3 64bit rpm Linux. Version: 7.4.2.3 / LibreOffice Community Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf CPU threads: 6; OS: Linux 5.3; UI render: default; VCL: kf5 (cairo+xcb) Locale: de-DE (de_DE.UTF-8); UI: de-DE Calc: threaded Special packages from OpenSUSE won't work here with any report created with Report Builder. You are using a special LO package from Ubuntu (Build ID: 30(Build:2)). Please try the original packages from LO. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151771] New: Malwarebytes blocks libreoffice
https://bugs.documentfoundation.org/show_bug.cgi?id=151771 Bug ID: 151771 Summary: Malwarebytes blocks libreoffice Product: LibreOffice Version: 7.4.2.3 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: hans.rott...@gmail.com Description: When opening a document or starting Writer blank (FileOpen) it is blocked by MalwareBytes as an Exploit Steps to Reproduce: 1.Install Malwarbytes 2.Start LibreOffice 3. Actual Results: LibreOffice stops and MalwareBytes gives a report Expected Results: Started application without interference of MalwareBytes Reproducible: Always User Profile Reset: Yes Additional Info: The report from MalwareBytes: Malwarebytes www.malwarebytes.com -Logboekdetails- Datum beveiligingsgebeurtenis: 26-10-2022 Tijd beveiligingsgebeurtenis: 15:59 Logbestand: 51a00a0c-5536-11ed-b6f2-f0bf97686fff.json -Software-informatie- Versie: 4.5.15.215 Versie componenten: 1.0.1784 Update pakketversie: 1.0.61573 Licentie: Premium -Systeeminformatie- Besturingssysteem: Windows 10 (Build 19044.2130) Processor: x64 Bestandssysteem: NTFS Gebruiker: System -Details van exploit- Bestand: 0 (Geen kwaadaardige items gedetecteerd) Exploit: 1 Malware.Exploit.Agent.Generic, C:\WINDOWS\system32\cmd.exe C:\WINDOWS\system32\cmd.exe \c c:\Program Files (x86)\ATI Stream\bin\x86_64\clc -Dfp_t=double -Dfp_t4=double4 -Dfp_t16=double16 -DINPUTSIZE=15360 -DAMD_DP_EXTENSION --emit=llvmbc --march=x86-64 -D__CPU__=1 -D__x86_64__=1 -Dcl_amd_fp64=1 -Dcl_khr_global_int32_base_atomics=1 -Dcl_khr_global_int32_extended_atomics=1 -Dcl_khr_local_int32_base_atomics=1 -Dcl_khr_local_int32_extended_atomics=1 -Dcl_khr_int64_base_atomics=1 -Dcl_khr_int64_extended_atomics=1 -Dcl_khr_byte_addressable_store=1 -Dcl_khr_gl_sharing=1 -Dcl_ext_device_fission=1 -Dcl_amd_device_attribute_query=1 -Dcl_amd_printf=1 -Dcl_khr_d3d10_sharing=1 -o C:\Users\Henk\AppData\Local\Temp\OCLAA77.tmp.bc C:\Users\Henk\AppData\Local\Temp\OCLAA77.tmp.cl 1> C:\Users\Henk\AppData\Local\Temp\OCLAA77.tmp.log 2>&1, Geblokkeerd, 0, 392684, 0.0.0, , -Exploit-gegevens- Getroffen toepassing: LibreOffice Beveiligingslaag: Application Behavior Protection Beveiligingstechniek: Exploit Office spawning batch command blocked Bestandsnaam: C:\WINDOWS\system32\cmd.exe C:\WINDOWS\system32\cmd.exe \c c:\Program Files (x86)\ATI Stream\bin\x86_64\clc -Dfp_t=double -Dfp_t4=double4 -Dfp_t16=double16 -DINPUTSIZE=15360 -DAMD_DP_EXTENSION --emit=llvmbc --march=x86-64 -D__CPU__=1 -D__x86_64__=1 -Dcl_amd_fp64=1 -Dcl_khr_global_int32_base_atomics=1 -Dcl_khr_global_int32_extended_atomics=1 -Dcl_khr_local_int32_base_atomics=1 -Dcl_khr_local_int32_extended_atomics=1 -Dcl_khr_int64_base_atomics=1 -Dcl_khr_int64_extended_atomics=1 -Dcl_khr_byte_addressable_store=1 -Dcl_khr_gl_sharing=1 -Dcl_ext_device_fission=1 -Dcl_amd_device_attribute_query=1 -Dcl_amd_printf=1 -Dcl_khr_d3d10_sharing=1 -o C:\Users\Henk\AppData\Local\Temp\OCLAA77.tmp.bc C:\Users\Henk\AppData\Local\Temp\OCLAA77.tmp.cl 1> C:\Users\Henk\AppData\Local\Temp\OCLAA77.tmp.log 2>&1 URL: (end) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - libreofficekit/qa
libreofficekit/qa/gtktiledviewer/gtv-lokdocview-signal-handlers.cxx |5 + 1 file changed, 5 insertions(+) New commits: commit 00b552c02efe3bc157218dc8452a2cf87714ca0b Author: Mike Kaganski AuthorDate: Wed Oct 26 17:10:10 2022 +0300 Commit: Mike Kaganski CommitDate: Wed Oct 26 18:19:13 2022 +0200 gtktiledviewer: don't crash on sidebar creation There's no dialog parent for the sidebar child window. Just ignore the signal for now. Change-Id: Iadfae9174780b10b94e8dd3e6c9efc8c4e8b4b2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141878 Tested-by: Jenkins Reviewed-by: Mike Kaganski (cherry picked from commit 4a8fa1ba2fa5b4e3c95a255c0cb2d45df54aea38) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141847 Tested-by: Jenkins CollaboraOffice diff --git a/libreofficekit/qa/gtktiledviewer/gtv-lokdocview-signal-handlers.cxx b/libreofficekit/qa/gtktiledviewer/gtv-lokdocview-signal-handlers.cxx index 6816a17fcc2f..5b4bf08ec0b2 100644 --- a/libreofficekit/qa/gtktiledviewer/gtv-lokdocview-signal-handlers.cxx +++ b/libreofficekit/qa/gtktiledviewer/gtv-lokdocview-signal-handlers.cxx @@ -367,6 +367,11 @@ void LOKDocViewSigHandlers::window(LOKDocView* pDocView, gchar* pPayload, gpoint { const unsigned nParentId = std::atoi(aRoot.get("parentId").c_str()); GtkWindow* pDialog = gtv_application_window_get_child_window_by_id(window, nParentId); +if (!pDialog) +{ +g_warning("no parent dialog (id: %d) for created child; is child a sidebar?", nParentId); +return; +} const std::string aPos = aRoot.get("position"); std::vector aPosPoints = GtvHelpers::split(aPos, ", ", 2); gtv_lok_dialog_child_create(GTV_LOK_DIALOG(pDialog), nWinId, aPosPoints[0], aPosPoints[1], aSizePoints[0], aSizePoints[1]);
[Libreoffice-bugs] [Bug 151770] New: Improve LibreOffice grids -- defaults (Writer/Calc) help page with an answer from ask.libreoffice.org
https://bugs.documentfoundation.org/show_bug.cgi?id=151770 Bug ID: 151770 Summary: Improve LibreOffice grids -- defaults (Writer/Calc) help page with an answer from ask.libreoffice.org Product: LibreOffice Version: 7.4.2.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Documentation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: u...@net9.ga CC: olivier.hal...@libreoffice.org In my opinion, LibreOffice grids -- defaults (Writer/Calc) help page at file:///usr/lib/libreoffice/help/en-US/text/shared/optionen/01050100.html?DbPAR=SHARED#bm_id3147226 , is unsatisfactory way too short. I suggest to 1. Integrate EarnestAl answer at https://ask.libreoffice.org/t/creating-dot-grid-paper-in-writer/69539 , even as is, within the help page for grids -- defaults (Writer/Calc). Or copy his answer as an example section, or a comment section. With the Sample DotGrid.odt provided by that answer to download. 2. EarnestAl statement about the default grid is quite faint is a misnomer. It can not be observed, unless one knows it is there. Change his statement when copying to reflect that. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146360] bitmap fill is not shown for extruded shape if set in style
https://bugs.documentfoundation.org/show_bug.cgi?id=146360 Armin Le Grand changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |armin.le.gr...@me.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146360] bitmap fill is not shown for extruded shape if set in style
https://bugs.documentfoundation.org/show_bug.cgi?id=146360 --- Comment #14 from Armin Le Grand --- Tried diverse methods to fix it, decided for one, see comments in patch. Fix is at https://gerrit.libreoffice.org/c/core/+/141886 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151763] Long pause of up to 1 min. while opening files (e.g. ods).
https://bugs.documentfoundation.org/show_bug.cgi?id=151763 --- Comment #4 from Alex Winzer --- Same as before. I had to click "Tested it with a clean profile" prior to be able to create a new bug report. I even deleted "%UserProfile%\AppData\Roaming\LibreOffice" which should deliver the same effect. On the machine with 7.3.6.2 I unstalled it an installed 7.1.8.1 again. LibreOffice doesn't start there anymore but in safe mode only. I would not have opened a bug report, if this wouldn't happen on 2 PC at the same time. I got more W10 machines here, I could test. But I'm afraid to make them inproductive this way. Btw it's not even loading a table, but also changing Text in writer. If I want to change the Kerning between the letters it takes almost 1 min. to load that menu, too. I also believe, it could be a matter of Windows 10, since my W11 Laptop and 2 Desktops of my sons with W11 are not affected. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: libreofficekit/qa
libreofficekit/qa/gtktiledviewer/gtv-lokdocview-signal-handlers.cxx |5 + 1 file changed, 5 insertions(+) New commits: commit 4a8fa1ba2fa5b4e3c95a255c0cb2d45df54aea38 Author: Mike Kaganski AuthorDate: Wed Oct 26 17:10:10 2022 +0300 Commit: Mike Kaganski CommitDate: Wed Oct 26 16:59:53 2022 +0200 gtktiledviewer: don't crash on sidebar creation There's no dialog parent for the sidebar child window. Just ignore the signal for now. Change-Id: Iadfae9174780b10b94e8dd3e6c9efc8c4e8b4b2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141878 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/libreofficekit/qa/gtktiledviewer/gtv-lokdocview-signal-handlers.cxx b/libreofficekit/qa/gtktiledviewer/gtv-lokdocview-signal-handlers.cxx index 8d1b3eb67e10..520472f201e5 100644 --- a/libreofficekit/qa/gtktiledviewer/gtv-lokdocview-signal-handlers.cxx +++ b/libreofficekit/qa/gtktiledviewer/gtv-lokdocview-signal-handlers.cxx @@ -367,6 +367,11 @@ void LOKDocViewSigHandlers::window(LOKDocView* pDocView, gchar* pPayload, gpoint { const unsigned nParentId = std::atoi(aRoot.get("parentId").c_str()); GtkWindow* pDialog = gtv_application_window_get_child_window_by_id(window, nParentId); +if (!pDialog) +{ +g_warning("no parent dialog (id: %d) for created child; is child a sidebar?", nParentId); +return; +} const std::string aPos = aRoot.get("position"); std::vector aPosPoints = GtvHelpers::split(aPos, ", ", 2); gtv_lok_dialog_child_create(GTV_LOK_DIALOG(pDialog), nWinId, aPosPoints[0], aPosPoints[1], aSizePoints[0], aSizePoints[1]);
[Libreoffice-bugs] [Bug 146360] bitmap fill is not shown for extruded shape if set in style
https://bugs.documentfoundation.org/show_bug.cgi?id=146360 --- Comment #13 from Armin Le Grand --- Found the problem now: The default FillBitmap gets set at the 3D shape at the 3rd 3D object (back - but it's actually the front). Basic problem is that the source BM gets fetched by using p3DObj->GetMergedItem(XATTR_FILLBITMAP) where at the p3DObj the ItemSet is already set using p3DObj->SetMergedItemSet( aLocalSet ); *but* setting it at the SdrObject removes the StyleSheet's ItemSet which is set as parent in aLocalSet. I found three locations where this is done. Now I have to think about how to best fix that... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: download.lst external/curl
download.lst |4 ++-- external/curl/ExternalProject_curl.mk |2 +- external/curl/curl-nss.patch.1|7 ++- 3 files changed, 9 insertions(+), 4 deletions(-) New commits: commit a76a88203d8508f38b10d9bbb94c3bba2485fcaf Author: Michael Stahl AuthorDate: Wed Oct 26 11:07:49 2022 +0200 Commit: Michael Stahl CommitDate: Wed Oct 26 16:32:27 2022 +0200 curl: upgrade to release 7.86.0 Fixes CVE-2022-32221 which could affect libcmis, CVE-2022-42915, and 2 more CVEs that probably don't affect LO. * remove --without-ssl: On the one hand, on GNU/Linux this now results in: configure: error: --without-ssl has been set together with an explicit option to use an ssl library On the other hand, using the more obvious --without-openssl yields a link failure on Android on the nss check in configure: configure:28220: checking for SSL_VersionRangeSet in -lnss /home/cl/Android/Sdk/ndk/20.1.5948944/toolchains/llvm/prebuilt/linux-x86_64/bin/../lib/gcc/aarch64-linux-android/4.9.x/../../../../aarch64-linux-android/bin/ld: warning: liblog.so, needed by /home/cl/rpmbuild/BUILD/lo-android2/workdir/UnpackedTarball/nss/dist/out/lib/libnss3.so, not found (try using -rpath or -rpath-link) /home/cl/rpmbuild/BUILD/lo-android2/workdir/UnpackedTarball/nss/dist/out/lib/libnspr4.so: undefined reference to `__android_log_write' /home/cl/rpmbuild/BUILD/lo-android2/workdir/UnpackedTarball/nss/dist/out/lib/libnspr4.so: undefined reference to `__android_log_assert' ... so add the -llog for android in curl-nss.patch.1 Change-Id: I3931a1eec2d681c2ce0e5695039492772e9fcc81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141866 Tested-by: Jenkins Reviewed-by: Michael Stahl diff --git a/download.lst b/download.lst index 0db9970fcd5d..146b58391232 100644 --- a/download.lst +++ b/download.lst @@ -33,8 +33,8 @@ export COINMP_SHA256SUM := 86c798780b9e1f5921fe4efe651a93cb420623b45aa1fdff57af8 export COINMP_TARBALL := CoinMP-1.7.6.tgz export CPPUNIT_SHA256SUM := 89c5c6665337f56fd2db36bc3805a5619709d51fb136e51937072f63fcc717a7 export CPPUNIT_TARBALL := cppunit-1.15.1.tar.gz -export CURL_SHA256SUM := 88b54a6d4b9a48cb4d873c7056dcba997ddd5b7be5a2d537a4acb55c20b04be6 -export CURL_TARBALL := curl-7.85.0.tar.xz +export CURL_SHA256SUM := 2d61116e5f485581f6d59865377df4463f2e788677ac43222b496d4e49fb627b +export CURL_TARBALL := curl-7.86.0.tar.xz export EBOOK_SHA256SUM := 7e8d8ff34f27831aca3bc6f9cc532c2f90d2057c778963b884ff3d1e34dfe1f9 export EBOOK_TARBALL := libe-book-0.1.3.tar.xz export EPOXY_SHA256SUM := a7ced37f4102b745ac86d6a70a9da399cc139ff168ba6b8002b4d8d43c900c15 diff --git a/external/curl/ExternalProject_curl.mk b/external/curl/ExternalProject_curl.mk index cad4199b5927..8d8bd13aefab 100644 --- a/external/curl/ExternalProject_curl.mk +++ b/external/curl/ExternalProject_curl.mk @@ -44,7 +44,7 @@ $(call gb_ExternalProject_get_state_target,curl,build): $(if $(filter iOS MACOSX,$(OS)),\ --with-secure-transport,\ $(if $(ENABLE_NSS),--with-nss$(if $(SYSTEM_NSS),,="$(call gb_UnpackedTarball_get_dir,nss)/dist/out") --with-nss-deprecated,--without-nss)) \ - --without-ssl --without-gnutls --without-polarssl --without-cyassl --without-axtls --without-mbedtls \ + --without-openssl --without-gnutls --without-polarssl --without-cyassl --without-axtls --without-mbedtls \ --enable-ftp --enable-http --enable-ipv6 \ --without-libidn2 --without-libpsl --without-librtmp \ --without-libssh2 --without-metalink --without-nghttp2 \ diff --git a/external/curl/curl-nss.patch.1 b/external/curl/curl-nss.patch.1 index 016cd109c7a2..5ef25748d7eb 100644 --- a/external/curl/curl-nss.patch.1 +++ b/external/curl/curl-nss.patch.1 @@ -1,12 +1,17 @@ diff -ur curl.org/configure curl/configure --- curl.org/configure 2016-03-13 15:14:07.17776 +0100 +++ curl/configure 2016-03-13 15:16:44.13276 +0100 -@@ -27985,7 +27985,7 @@ +@@ -27985,7 +27985,12 @@ { printf "%s\n" "$as_me:${as_lineno-$LINENO}: WARNING: Using hard-wired libraries and compilation flags for NSS." >&5 printf "%s\n" "$as_me: WARNING: Using hard-wired libraries and compilation flags for NSS." >&2;} addld="-L$OPT_NSS/lib" - addlib="-lssl3 -lsmime3 -lnss3 -lplds4 -lplc4 -lnspr4" + addlib="-lssl3 -lsmime3 -lnss3 -lplds4 -lplc4 -lnspr4 -lnssutil3" ++ case $host_os in ++*android*) ++ addlib="${addlib} -llog" ++ ;; ++ esac addcflags="-I$OPT_NSS/include" version="unknown" nssprefix=$OPT_NSS
[Libreoffice-bugs] [Bug 151764] LibreOffice 7.3.6.2, Linux Mint 21 x86-64: Media_without_Macros.odb Report error thrashes disk.
https://bugs.documentfoundation.org/show_bug.cgi?id=151764 --- Comment #2 from tne...@gmail.com --- 1. Created new linux user libreofficetest so anything from my work not included. 2. Unzipped "Sample-databases.zip" so new copy of Media_without_Macros.odb. 3. Opened BaseGuide for LibreOffice 7.2 in Xreader so no influence on LibreOffice. 4. Opened Media_without_Macros.odb in LibreOffice. 5. Started at page 15 of BaseGuide. 6. Opened Loan form tried: g + OK :2 entries displayed %g + OK:3 entries displayed %g% + OK: 3 entries displayed g% + OK:2 entries displayed OK so far. 7. Checked Greta Garbo return date fields drop down to todays date, but did not enter it - OK. 8. Checked Greta Garbo new loan request blocked, hit "Refresh" - OK. 9. Checked can't delete row from "Return" - OK. 10. Switched from Forms to Tables, double clicked "Loan", displayed OK. 11. Switched from Tables to Queries, double clicked "Media_Loan_Balance_time", displayed OK. (4 database windows open now). 12. Switched from Queries to Reports (should have been Forms..), double clicked "Recall", got error message: The document "Recall" could not be opened ... xfactory.cxx:227 13. Clicked OK to kill error message and switched from Reports to Forms. 14. Double clicked "Recall", displayed OK on entry for Greta Garbo, 3 - Traditionelle und kritische Theorie - by Horkheimer, Max. ... 15. No recall date or number displayed. Put in todays date, hit return. Moves to next line with date entered but no recall number. (5 database windows open now). 16. Switch from Forms to Reports. Double click "Recall". Get Recall could not be opened message as before (see 12 above). Click OK to close error, no problems. 17. Back on Recall form, hitting return with cursor in Recall Date now writes a "1" to Recall No. What other user input is required to create recall notices in this database??? 18. Double clicking "Recall" in "Reports" gives Recall could not be opened message as before (see 12 above). Click OK to close error, no problems. 19. Gave up trying to reproduce error. In short, I was unable to reproduce the error. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151769] Text dissappearing from slide after saving presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=151769 --- Comment #1 from Mihai Vasiliu --- Created attachment 183284 --> https://bugs.documentfoundation.org/attachment.cgi?id=183284=edit The slide with the issue -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151769] New: Text dissappearing from slide after saving presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=151769 Bug ID: 151769 Summary: Text dissappearing from slide after saving presentation Product: LibreOffice Version: 7.4.2.3 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mihai.vasiliu...@gmail.com Description: In the presentation attached, if I add any more characters to the last line and save the presentation, on reopening the presentation all added characters are missing and cannot be recovered. Steps to Reproduce: I was working on a new presentation in odp format, writing text on the slide from scratch, saved the presentation. Then when I reopened the presentation, the last lines were missing. If I try to reopen and rewrite the lines, they do not save anymore. Any other lines on other slides are getting saved. (I removed all slides except the one with the issue). 1. Open the attached presentation 2. Write any characters on the end of the last line 3. Save the presentation 4. Open it again and see that all characters written are now missing. I cannot reproduce it with another new presentation. Actual Results: The newly added text is missing. Expected Results: The text should be saved. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.4.2.3 (x64) / LibreOffice Community Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf CPU threads: 8; OS: Windows 10.0 Build 22000; UI render: Skia/Raster; VCL: win Locale: ro-RO (ro_RO); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: ucb/source
ucb/source/ucp/ftp/ftpcontent.cxx | 15 +++ 1 file changed, 15 insertions(+) New commits: commit 022e476af44c0dfc97403dc0f3a3b63e731903e6 Author: Michael Stahl AuthorDate: Wed Oct 26 14:58:09 2022 +0200 Commit: Michael Stahl CommitDate: Wed Oct 26 16:02:25 2022 +0200 ucb: FTP UCP: report CURLE_URL_MALFORMAT as IllegalIdentifierException With curl 7.86, the test JunitTest_ucb_complex starts to fail: .ftp://noname:nopasswd@*nohost.invalid now executing open com.sun.star.ucb.InteractiveAugmentedIOException: at com.sun.proxy.$Proxy15.execute(Unknown Source) at complex.ucb.UCB.executeCommand(UCB.java:63) at complex.ucb.UCB.checkWrongFtpConnection(UCB.java:119) because curl_easy_perform() now returns CURLE_URL_MALFORMAT where previously it was CURLE_COULDNT_RESOLVE_HOST. Map this to an exception the test expects. Change-Id: Ifdb672946726ddb4cb4d9426b7e70eefac63f040 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141877 Tested-by: Jenkins Reviewed-by: Michael Stahl diff --git a/ucb/source/ucp/ftp/ftpcontent.cxx b/ucb/source/ucp/ftp/ftpcontent.cxx index 0294cea7b9f8..65e2b86f8f21 100644 --- a/ucb/source/ucp/ftp/ftpcontent.cxx +++ b/ucb/source/ucp/ftp/ftpcontent.cxx @@ -63,6 +63,7 @@ #include #include #include +#include #include #include #include @@ -226,6 +227,7 @@ enum ACTION { NOACTION, THROWAUTHENTICATIONREQUEST, THROWACCESSDENIED, THROWINTERACTIVECONNECT, + THROWMALFORMED, THROWRESOLVENAME, THROWQUOTE, THROWNOFILE, @@ -344,6 +346,15 @@ Any SAL_CALL FTPContent::execute( const Command& aCommand, Environment); break; } +case THROWMALFORMED: +{ +IllegalIdentifierException ex; +aRet <<= ex; +ucbhelper::cancelCommandExecution( +aRet, +Environment); +break; +} case THROWRESOLVENAME: { InteractiveNetworkResolveNameException excep; @@ -538,6 +549,10 @@ Any SAL_CALL FTPContent::execute( const Command& aCommand, { if(e.code() == CURLE_COULDNT_CONNECT) action = THROWINTERACTIVECONNECT; +else if (e.code() == CURLE_URL_MALFORMAT) +{ +action = THROWMALFORMED; +} else if(e.code() == CURLE_COULDNT_RESOLVE_HOST ) action = THROWRESOLVENAME; else if(e.code() == CURLE_FTP_USER_PASSWORD_INCORRECT ||
[Libreoffice-bugs] [Bug 147867] HANG: trying to scroll down
https://bugs.documentfoundation.org/show_bug.cgi?id=147867 Noel Grandin changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Noel Grandin --- In current master, I can no longer reproduce this -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108075] [META] Scrolling and Page up/down issues
https://bugs.documentfoundation.org/show_bug.cgi?id=108075 Bug 108075 depends on bug 56323, which changed state. Bug 56323 Summary: EDITING: Hang while scrolling through document https://bugs.documentfoundation.org/show_bug.cgi?id=56323 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 56323] EDITING: Hang while scrolling through document
https://bugs.documentfoundation.org/show_bug.cgi?id=56323 Noel Grandin changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #16 from Noel Grandin --- In current master, I can no longer reproduce this -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - offapi/com sw/inc sw/source writerfilter/qa writerfilter/source
offapi/com/sun/star/text/ContentControl.idl | 10 +++- sw/inc/unoprnms.hxx |1 sw/source/core/txtnode/attrcontentcontrol.cxx | 11 +++- sw/source/core/unocore/unocontentcontrol.cxx |7 +++ sw/source/core/unocore/unomap1.cxx |1 writerfilter/qa/cppunittests/dmapper/DomainMapper_Impl.cxx | 23 ++ writerfilter/qa/cppunittests/dmapper/data/content-control-date-data-binding.docx |binary writerfilter/source/dmapper/DomainMapper_Impl.cxx | 18 ++- 8 files changed, 64 insertions(+), 7 deletions(-) New commits: commit 23272c0cfe01d0719572bc80733833f6f8c09f24 Author: Miklos Vajna AuthorDate: Wed Oct 26 10:03:04 2022 +0200 Commit: Miklos Vajna CommitDate: Wed Oct 26 15:34:30 2022 +0200 sw content controls: enable data binding for date The document had a 2022 date in document.xml, but had a 2012 date in data binding. Writer used to show 2022, while Word picks 2012. Data binding for dates were disabled in commit de90c192cb8f1f03a4028493d8bfe9a127a76b2a (sw content controls, plain text: enable DOCX filter with data binding, 2022-09-19), because the formatting of those date timestamps were missing, so it was better to just not update them from data binding, temporarily. Fix the problem by adding a new read-only DateString property on SwXContentControl, this way the import filter can set not only the timestamp but the formatted date as well. This shares the SwContentControl::GetDateString() code with the UI, which already had the need in the past to turn a timestamp into a date string, based on a provided language and date format. (cherry picked from commit 58002ab85d992c7ac44d8bb4d135246b67aa5cc7) Conflicts: sw/source/core/unocore/unomap1.cxx Change-Id: I842a9483a675f895129a9854caec347be6b6b84e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141867 Tested-by: Jenkins CollaboraOffice Reviewed-by: Miklos Vajna diff --git a/offapi/com/sun/star/text/ContentControl.idl b/offapi/com/sun/star/text/ContentControl.idl index 8f390665c2b3..ae8a0e1a9396 100644 --- a/offapi/com/sun/star/text/ContentControl.idl +++ b/offapi/com/sun/star/text/ContentControl.idl @@ -100,17 +100,23 @@ service ContentControl */ [optional, property] boolean ComboBox; -/** The alias: just remembered. +/** The alias: kind of a human-readable title / description, show up on the UI. @since LibreOffice 7.5 */ [optional, property] string Alias; -/** The tag: just remembered. +/** The tag: similar to Alias, but is meant to be machine-readable. @since LibreOffice 7.5 */ [optional, property] string Tag; + +/** The formatted date string, based on DateFormat, DateLanguage and CurrentDate. + +@since LibreOffice 7.5 +*/ +[optional, property, readonly] string DateString; }; diff --git a/sw/inc/unoprnms.hxx b/sw/inc/unoprnms.hxx index 4f952b733ad7..64fe359f7ac7 100644 --- a/sw/inc/unoprnms.hxx +++ b/sw/inc/unoprnms.hxx @@ -889,6 +889,7 @@ #define UNO_NAME_COLOR "Color" #define UNO_NAME_ALIAS "Alias" #define UNO_NAME_TAG "Tag" +#define UNO_NAME_DATE_STRING "DateString" #endif /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/sw/source/core/txtnode/attrcontentcontrol.cxx b/sw/source/core/txtnode/attrcontentcontrol.cxx index 399b954ea08f..dc451ca927e4 100644 --- a/sw/source/core/txtnode/attrcontentcontrol.cxx +++ b/sw/source/core/txtnode/attrcontentcontrol.cxx @@ -234,9 +234,14 @@ OUString SwContentControl::GetDateString() const const Color* pColor = nullptr; OUString aFormatted; -if (!m_oSelectedDate) +double fSelectedDate = 0; +if (m_oSelectedDate) { -return OUString(); +fSelectedDate = *m_oSelectedDate; +} +else +{ +fSelectedDate = GetCurrentDateValue(); } if (nFormat == NUMBERFORMAT_ENTRY_NOT_FOUND) @@ -244,7 +249,7 @@ OUString SwContentControl::GetDateString() const return OUString(); } -pNumberFormatter->GetOutputString(*m_oSelectedDate, nFormat, aFormatted, , false); +pNumberFormatter->GetOutputString(fSelectedDate, nFormat, aFormatted, , false); return aFormatted; } diff --git a/sw/source/core/unocore/unocontentcontrol.cxx b/sw/source/core/unocore/unocontentcontrol.cxx index 994c5db7346a..0e19b7e57f41 100644 --- a/sw/source/core/unocore/unocontentcontrol.cxx +++ b/sw/source/core/unocore/unocontentcontrol.cxx @@ -1231,6 +1231,13 @@ uno::Any SAL_CALL SwXContentControl::getPropertyValue(const OUString& rPropertyN aRet <<= m_pImpl->m_pContentControl->GetTag(); }
[Libreoffice-bugs] [Bug 151765] After giving a printing-order Libre Office only prints a part of the document
https://bugs.documentfoundation.org/show_bug.cgi?id=151765 m.a.riosv changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m.a.riosv --- Enlarging print dialogue, you can see better what LO is going to print. Is it right there? With Print Preview, can you see it right? Please, can you attach a sample file showing the issue? If it's no way to reproduce it, no way to find the issue. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151763] Long pause of up to 1 min. while opening files (e.g. ods).
https://bugs.documentfoundation.org/show_bug.cgi?id=151763 m.a.riosv changed: What|Removed |Added Ever confirmed|0 |1 CC||miguelangelrv@libreoffice.o ||rg Status|UNCONFIRMED |NEEDINFO --- Comment #3 from m.a.riosv --- Both open without any delay for me: Version: 7.3.7.1 (x64) / LibreOffice Community Build ID: ee816339cde623389f19e5eb99a60dbf03ee8b66 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: es-ES (es_ES); UI: es-ES Calc: CL Version: 7.4.2.3 (x64) / LibreOffice Community Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: es-ES Calc: CL Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 17dfc9a9da009cc23de3fb4e2cef9c97d581 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Jumbo Please test with a clean profile, Menu/Help/Restart in Safe Mode -- You are receiving this mail because: You are the assignee for the bug.