[Libreoffice-commits] core.git: dbaccess/inc dbaccess/source include/xmloff reportdesign/inc reportdesign/source sc/inc sc/source xmloff/inc xmloff/source
dbaccess/inc/strings.hxx | 309 +-- dbaccess/source/core/api/definitioncolumn.cxx | 26 dbaccess/source/filter/xml/xmlHelper.cxx | 26 include/xmloff/maptype.hxx| 35 reportdesign/inc/strings.hxx | 418 ++-- reportdesign/source/filter/xml/xmlHelper.cxx | 24 reportdesign/source/ui/inspection/DataProviderHandler.cxx | 10 reportdesign/source/ui/inspection/metadata.cxx| 52 sc/inc/unonames.hxx | 1136 ++--- sc/source/filter/xml/xmlstyle.cxx |2 sc/source/ui/unoobj/styleuno.cxx | 530 +++--- xmloff/inc/xmlprop.hxx| 670 +++ xmloff/source/chart/PropertyMaps.cxx | 247 +- xmloff/source/draw/sdpropls.cxx | 477 ++--- xmloff/source/draw/shapeexport.cxx|6 xmloff/source/draw/ximpshap.cxx |7 xmloff/source/forms/controlpropertymap.cxx| 63 xmloff/source/forms/elementexport.cxx | 66 xmloff/source/forms/elementimport.cxx | 44 xmloff/source/forms/propertyexport.cxx|5 xmloff/source/forms/propertyexport.hxx|2 xmloff/source/forms/strings.hxx | 230 +- xmloff/source/forms/valueproperties.cxx | 12 xmloff/source/forms/valueproperties.hxx | 13 xmloff/source/style/PageMasterStyleMap.cxx| 438 ++--- xmloff/source/style/xmlprmap.cxx |7 xmloff/source/table/XMLTableExport.cxx| 39 xmloff/source/text/txtprmap.cxx | 1199 +++--- 28 files changed, 3385 insertions(+), 2708 deletions(-) New commits: commit e14a3ebf801848236bd9559f64c134412e498a32 Author: Noel Grandin AuthorDate: Thu Nov 3 08:29:41 2022 +0200 Commit: Noel Grandin CommitDate: Fri Nov 4 06:50:43 2022 +0100 tdf#54857 use OUStringConstExpr in XMLPropertyMapEntry which means we don't need to allocate a bunch of strings when building the property maps in xmloff Change-Id: I83cb013f816d9b7bcb0dd55c59e5151b33b91c9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142192 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/dbaccess/inc/strings.hxx b/dbaccess/inc/strings.hxx index eb90a6c04d82..021f34cc70b5 100644 --- a/dbaccess/inc/strings.hxx +++ b/dbaccess/inc/strings.hxx @@ -12,147 +12,152 @@ // property names -#define PROPERTY_URL "URL" -#define PROPERTY_INFO "Info" -#define PROPERTY_SETTINGS "Settings" -#define PROPERTY_ISPASSWORDREQUIRED "IsPasswordRequired" -#define PROPERTY_TABLEFILTER "TableFilter" -#define PROPERTY_TABLETYPEFILTER "TableTypeFilter" -#define PROPERTY_NAME "Name" -#define PROPERTY_SCHEMANAME "SchemaName" -#define PROPERTY_CATALOGNAME "CatalogName" -#define PROPERTY_PRIVILEGES "Privileges" -#define PROPERTY_ESCAPE_PROCESSING "EscapeProcessing" -#define PROPERTY_COMMAND "Command" -#define PROPERTY_TYPE "Type" -#define PROPERTY_TYPENAME "TypeName" -#define PROPERTY_PRECISION "Precision" -#define PROPERTY_SCALE "Scale" -#define PROPERTY_ISNULLABLE "IsNullable" -#define PROPERTY_ISAUTOINCREMENT "IsAutoIncrement" -#define PROPERTY_ISROWVERSION "IsRowVersion" -#define PROPERTY_DESCRIPTION "Description" -#define PROPERTY_DEFAULTVALUE "DefaultValue" -#define PROPERTY_NUMBERFORMAT "FormatKey" -#define PROPERTY_QUERYTIMEOUT "QueryTimeOut" -#define PROPERTY_MAXFIELDSIZE "MaxFieldSize" -#define PROPERTY_MAXROWS "MaxRows" -#define PROPERTY_CURSORNAME "CursorName" -#define PROPERTY_RESULTSETCONCURRENCY "ResultSetConcurrency" -#define PROPERTY_RESULTSETTYPE "ResultSetType" -#define PROPERTY_FETCHDIRECTION "FetchDirection" -#define PROPERTY_FETCHSIZE "FetchSize" -#define PROPERTY_USEBOOKMARKS "UseBookmarks" -#define PROPERTY_ISSEARCHABLE "IsSearchable" -#define PROPERTY_ISCURRENCY "IsCurrency" -#define PROPERTY_ISSIGNED "IsSigned" -#define PROPERTY_DISPLAYSIZE "DisplaySize" -#define PROPERTY_LABEL "Label" -#define PROPERTY_ISREADONLY "IsReadOnly" -#define PROPERTY_ISWRITABLE "IsWritable" -#define PROPERTY_ISDEFINITELYWRITABLE "IsDefinitelyWritable" -#define PROPERTY_VALUE "Value" -#define PROPERTY_TABLENAME "TableName" -#define PROPERTY_ISCASESENSITIVE "IsCaseSensitive" -#define PROPERTY_SERVICENAME "ServiceName" -#define PROPERTY_ISBOOKMARKABLE "IsBookmarkable" -#define PROPERTY_CANUPDATEINSERTEDROWS "CanUpdateInsertedRows" -#define PROPERTY_NUMBERFORMATSSUPPLIER "NumberFormatsSupplier" -#define PROPERTY_DATASOURCENAME "DataSourceName" -#define PROPERTY_DATABASE_LOCATION "DatabaseLocation" -#define PROPERTY_CONNECTION_RESOURCE "ConnectionResource" -#define PROPERTY_CONNECTION_INFO "ConnectionInfo"
[Libreoffice-bugs] [Bug 54857] FILEOPEN: slow opening, 2Mb .PPT file opens several minutes
https://bugs.documentfoundation.org/show_bug.cgi?id=54857 --- Comment #30 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e14a3ebf801848236bd9559f64c134412e498a32 tdf#54857 use OUStringConstExpr in XMLPropertyMapEntry It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 126788] FILEOPEN: ODT big performance drop for big table from 6.1 to 6.3, 6.4, 7.0
https://bugs.documentfoundation.org/show_bug.cgi?id=126788 --- Comment #34 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2ae53eb5dcbe0a3c5b4dc5323639a11878a38101 tdf#126788 remove weak m_wThis reference It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/core/unocore/unoparagraph.cxx | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
New commits:
commit 2ae53eb5dcbe0a3c5b4dc5323639a11878a38101
Author: Noel Grandin
AuthorDate: Tue Nov 1 10:05:17 2022 +0200
Commit: Noel Grandin
CommitDate: Fri Nov 4 06:50:22 2022 +0100
tdf#126788 remove weak m_wThis reference
weak references are surprsingly expensive in bulk.
To make sure we don't get revive an object, we need to stop listening
before we destroy the Impl object
Change-Id: I8a3d99e29681e1f844598bc7ac792a659e1104f0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142092
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/source/core/unocore/unoparagraph.cxx
b/sw/source/core/unocore/unoparagraph.cxx
index 7f8aa247260c..d2f3db46680e 100644
--- a/sw/source/core/unocore/unoparagraph.cxx
+++ b/sw/source/core/unocore/unoparagraph.cxx
@@ -114,7 +114,6 @@ class SwXParagraph::Impl
{
public:
SwXParagraph& m_rThis;
-unotools::WeakReference m_wThis;
std::mutex m_Mutex; // just for OInterfaceContainerHelper4
::comphelper::OInterfaceContainerHelper4
m_EventListeners;
SfxItemPropertySet const& m_rPropSet;
@@ -192,12 +191,8 @@ void SwXParagraph::Impl::Notify(const SfxHint& rHint)
std::unique_lock aGuard(m_Mutex);
if (m_EventListeners.getLength(aGuard) != 0)
{
-uno::Reference const xThis(m_wThis);
-if (!xThis.is())
-{ // fdo#72695: if UNO object is already dead, don't revive it
with event
-return;
-}
-lang::EventObject const ev(xThis);
+uno::Reference const xThis(m_rThis);
+lang::EventObject const ev(m_rThis);
m_EventListeners.disposeAndClear(aGuard, ev);
}
}
@@ -219,6 +214,10 @@ SwXParagraph::SwXParagraph(
SwXParagraph::~SwXParagraph()
{
+SolarMutexGuard aGuard;
+// need to stop listening before destruction so we don't get DYING events
+// that might then revive the SwXParagraph when constructing an EventObject
+m_pImpl->EndListeningAll();
}
const SwTextNode * SwXParagraph::GetTextNode() const
@@ -265,8 +264,6 @@ SwXParagraph::CreateXParagraph(SwDoc & rDoc, SwTextNode
*const pTextNode,
{
pTextNode->SetXParagraph(xParagraph);
}
-// need a permanent Reference to initialize m_wThis
-pXPara->m_pImpl->m_wThis = xParagraph.get();
return xParagraph;
}
[Libreoffice-bugs] [Bug 151869] Freeze deleting an image with Track Changes Record ON
https://bugs.documentfoundation.org/show_bug.cgi?id=151869 --- Comment #6 from Jim Raykowski --- Hi All, This is a difficult one to bisect due to a bug during a period in 7.2 when outline folding is on that causes a crash when delete is pressed. I turning off outline folding to bisect, Menu > Tools > Options... > LibreOffice Writer > View > uncheck 'Show outline-folding buttons'. I never got a hang on delete in 7.2 but did run into an X being placed across image94 on the third bisect and later in the bisect process no X but also no delete. My bisect effort came up with this in 7.2: commit d6322bcedc197a654abc7d64bfea8cf570f123bf Author: László Németh Date: Mon Apr 26 09:33:45 2021 +0200 tdf#59463 track changes: record deletion of images and in 7.3 commit b50d386dfa70f7c1d4eb1a49091ec9dd782b767b Author: László Németh Date: Sun Jul 11 13:04:54 2021 +0200 tdf#142701 track changes: fix layout regression of image deletion I stepped through the code and saw that the hang occurs here: SwWrtShell::DelRight Insert( OUStringChar(CH_TXT_TRACKED_DUMMY_CHAR) + OUStringChar(CH_TXT_TRACKED_DUMMY_CHAR) ); https://opengrok.libreoffice.org/xref/core/sw/source/uibase/wrtsh/delete.cxx?r=70973680#475 I always get expected results, image deleted, no hang, when Track Changes is turned off, Menu > Edit > Track Changes > Record unticked. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151653] The Libre app freezes and stops working
https://bugs.documentfoundation.org/show_bug.cgi?id=151653 Dieter changed: What|Removed |Added Component|Writer |LibreOffice -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151886] "Use English function names" changes decimal separator recognition
https://bugs.documentfoundation.org/show_bug.cgi?id=151886 Mike Kaganski changed: What|Removed |Added URL||https://forumooo.ru/index.p ||hp?topic=9461 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151886] New: "Use English function names" changes decimal separator recognition
https://bugs.documentfoundation.org/show_bug.cgi?id=151886 Bug ID: 151886 Summary: "Use English function names" changes decimal separator recognition Product: LibreOffice Version: 7.4.2.3 release Hardware: All OS: All Status: UNCONFIRMED Keywords: bibisected, bisected, regression Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mikekagan...@hotmail.com CC: er...@redhat.com 1. Use a locale that uses decimal comma 2. Make sure "Use English function names" is DISABLED 3. In a cell, type formula "=1,1" (with comma) => See that the cell shows "1,1" numeric value 4. Now ENABLE "Use English function names" 5. In another cell, type formula "=1,1" (with comma) => See that the cell shows #NAME? error => It only accepts "=1.1" now This is a regression. It accepted "=1,1" with "Use English function names" enabled in Version: 7.4.0.3 (x64) / LibreOffice Community Build ID: f85e47c08ddd19c015c0114a68350214f7066f5a CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: CL It fails starting from commit 0a78f11fdd13d914d5f063007b2df9796e6dce9d. It was backported to 7.4.2 as part of commit 32019fae7730fc8d94f14d47ebaccbdc6775340a. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103494] [META] Textbox bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103494 Bug 103494 depends on bug 143117, which changed state. Bug 143117 Summary: Artifacts remain when editing long text box in Impress https://bugs.documentfoundation.org/show_bug.cgi?id=143117 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103494] [META] Textbox bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103494 Aron Budea changed: What|Removed |Added Depends on||143117 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143117 [Bug 143117] Artifacts remain when editing long text box in Impress -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143117] Artifacts remain when editing long text box in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=143117 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=94 ||223 Status|NEW |RESOLVED Whiteboard||target:7.5.0 Blocks||103494 Resolution|--- |FIXED --- Comment #3 from Aron Budea --- Indeed, and the fix could be reverse bibisected to the following commit in 7.5: https://cgit.freedesktop.org/libreoffice/core/commit/?id=4b1a57e075af70135703e38337e1096b2f248ebd author Caolán McNamara 2022-01-05 20:40:26 + committer Caolán McNamara 2022-08-16 09:49:59 +0200 "tdf#94223 always visualize surrounding frame for active text object" (In reply to Armin Le Grand from comment #2) > The mentioned annoyance happens, so I tried to reproduce that shape, but > failed. All I could reproduce does not show that. > -> How was that shape created? > -> What type of shape is it? > -> Can you add a description that starts with an empty document, please? The ODP came from Michael, I'm afraid I have no further information on how it was created, thought perhaps he can comment on it. It might be worth looking into the XML and comparing it to a regular text box sometimes. For now let me close this, as the original bug is resolved. If there's interest in the text box, I can create a separate bug report. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103494 [Bug 103494] [META] Textbox bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151885] New: Etrends News
https://bugs.documentfoundation.org/show_bug.cgi?id=151885 Bug ID: 151885 Summary: Etrends News Product: LibreOffice Online Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: etrendsnew...@gmail.com This etrendsnews.com is the new stop for all types of news updates, you can get info about cars here and other than that there are many more things for which you can take reference from the website. To read more: https://etrendsnews.com/2021/06/25/solo-leveling-chapter-156-release-date-but-its-delayed-reason-reveal/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: starmath/inc starmath/source
starmath/inc/utility.hxx| 29 -
starmath/source/cfgitem.cxx |6 +++---
starmath/source/dialog.cxx |7 ---
starmath/source/format.cxx |2 +-
starmath/source/mathml/mathmlexport.cxx | 14 +++---
starmath/source/node.cxx|6 +++---
starmath/source/unomodel.cxx|7 +++
starmath/source/utility.cxx |2 +-
8 files changed, 22 insertions(+), 51 deletions(-)
New commits:
commit a37a979107a8643136ff3733b5b350b6b1be2bb7
Author: Mike Kaganski
AuthorDate: Thu Nov 3 21:36:26 2022 +0200
Commit: Mike Kaganski
CommitDate: Fri Nov 4 05:32:27 2022 +0100
Use o3tl::convert in Math
... and use our standard definition of pt.
Change-Id: I5a162b137360210335b84de33606dc7404cfc2de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142204
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/starmath/inc/utility.hxx b/starmath/inc/utility.hxx
index ee504017038a..c0b473264532 100644
--- a/starmath/inc/utility.hxx
+++ b/starmath/inc/utility.hxx
@@ -27,35 +27,6 @@
#include
#include
-inline tools::Long SmPtsTo100th_mm(tools::Long nNumPts)
-// returns the length (in 100th of mm) that corresponds to the length
-// 'nNumPts' (in units points).
-// 72.27 [pt] = 1 [inch] = 2,54 [cm] = 2540 [100th of mm].
-// result is being rounded to the nearest integer.
-{
-SAL_WARN_IF( nNumPts < 0, "starmath", "Ooops..." );
-// broken into multiple and fraction of 'nNumPts' to reduce chance
-// of overflow
-// (7227 / 2) is added in order to round to the nearest integer
-return 35 * nNumPts + (nNumPts * 1055L + (7227 / 2)) / 7227L;
-}
-
-
-inline Fraction Sm100th_mmToPts(tools::Long nNum100th_mm)
-// returns the length (in points) that corresponds to the length
-// 'nNum100th_mm' (in 100th of mm).
-{
-SAL_WARN_IF( nNum100th_mm < 0, "starmath", "Ooops..." );
-return Fraction(7227L, 254000L) * Fraction(nNum100th_mm);
-}
-
-
-inline tools::Long SmRoundFraction(const Fraction )
-{
-SAL_WARN_IF( rFrac <= Fraction(), "starmath", "Ooops..." );
-return (rFrac.GetNumerator() + rFrac.GetDenominator() / 2) /
rFrac.GetDenominator();
-}
-
class SmViewShell;
SmViewShell * SmGetActiveView();
diff --git a/starmath/source/cfgitem.cxx b/starmath/source/cfgitem.cxx
index a8c0e5fcae38..9b6a4eadd184 100644
--- a/starmath/source/cfgitem.cxx
+++ b/starmath/source/cfgitem.cxx
@@ -988,7 +988,7 @@ void SmMathConfig::LoadFormat()
++pVal;
// StandardFormat/BaseSize
if (pVal->hasValue() && (*pVal >>= nTmp16))
-pFormat->SetBaseSize( Size(0, SmPtsTo100th_mm( nTmp16 )) );
+pFormat->SetBaseSize(Size(0, o3tl::convert(nTmp16, o3tl::Length::pt,
o3tl::Length::mm100)));
++pVal;
sal_uInt16 i;
@@ -1059,8 +1059,8 @@ void SmMathConfig::SaveFormat()
// StandardFormat/HorizontalAlignment
*pValue++ <<= static_cast(pFormat->GetHorAlign());
// StandardFormat/BaseSize
-*pValue++ <<= static_cast(SmRoundFraction( Sm100th_mmToPts(
-pFormat->GetBaseSize().Height() ) ));
+*pValue++ <<= static_cast(
+o3tl::convert(pFormat->GetBaseSize().Height(), o3tl::Length::mm100,
o3tl::Length::pt));
sal_uInt16 i;
for (i = SIZ_BEGIN; i <= SIZ_END; ++i)
diff --git a/starmath/source/dialog.cxx b/starmath/source/dialog.cxx
index 043739cf5c0d..f700b8e6ce9a 100644
--- a/starmath/source/dialog.cxx
+++ b/starmath/source/dialog.cxx
@@ -392,8 +392,9 @@ SmFontSizeDialog::~SmFontSizeDialog()
void SmFontSizeDialog::ReadFrom(const SmFormat )
{
//! watch out: round properly!
-m_xBaseSize->set_value( SmRoundFraction(
-Sm100th_mmToPts( rFormat.GetBaseSize().Height() ) ), FieldUnit::NONE );
+m_xBaseSize->set_value(
+o3tl::convert(rFormat.GetBaseSize().Height(), o3tl::Length::mm100,
o3tl::Length::pt),
+FieldUnit::NONE);
m_xTextSize->set_value( rFormat.GetRelSize(SIZ_TEXT), FieldUnit::NONE );
m_xIndexSize->set_value( rFormat.GetRelSize(SIZ_INDEX), FieldUnit::NONE );
@@ -404,7 +405,7 @@ void SmFontSizeDialog::ReadFrom(const SmFormat )
void SmFontSizeDialog::WriteTo(SmFormat ) const
{
-rFormat.SetBaseSize( Size(0, SmPtsTo100th_mm( static_cast< tools::Long
>(m_xBaseSize->get_value(FieldUnit::NONE );
+rFormat.SetBaseSize( Size(0,
o3tl::convert(m_xBaseSize->get_value(FieldUnit::NONE), o3tl::Length::pt,
o3tl::Length::mm100)) );
rFormat.SetRelSize(SIZ_TEXT,
sal::static_int_cast(m_xTextSize->get_value(FieldUnit::NONE)));
rFormat.SetRelSize(SIZ_INDEX,
sal::static_int_cast(m_xIndexSize->get_value(FieldUnit::NONE)));
diff --git a/starmath/source/format.cxx b/starmath/source/format.cxx
index 65ec09558d56..f1f7a00f3806 100644
--- a/starmath/source/format.cxx
+++ b/starmath/source/format.cxx
@@ -21,7 +21,7 @@
SmFormat::SmFormat()
-: aBaseSize(0,
[Libreoffice-bugs] [Bug 151875] MySQL/MariaDB direct Connection: Column Description won't be saved
https://bugs.documentfoundation.org/show_bug.cgi?id=151875 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151669] Error help tip popup when hovering over it
https://bugs.documentfoundation.org/show_bug.cgi?id=151669 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151666] Weird popup - window during repair installation (repair process stops)
https://bugs.documentfoundation.org/show_bug.cgi?id=151666 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151662] 7.4 LanguageTool Server not working on Apple Silicon
https://bugs.documentfoundation.org/show_bug.cgi?id=151662 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151660] application window problem
https://bugs.documentfoundation.org/show_bug.cgi?id=151660 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151659] LO Impress crashes on FreeBSD when creating a new File
https://bugs.documentfoundation.org/show_bug.cgi?id=151659 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151653] The Libre app freezes and stops working
https://bugs.documentfoundation.org/show_bug.cgi?id=151653 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151648] Formatted List Styles do not retain indent after copy/paste
https://bugs.documentfoundation.org/show_bug.cgi?id=151648 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151878] LibreCalc buttons change color, horizontal lines from the top and bottoms of buttons radiate across a background image and buttons briefly appear and disappear in the w
https://bugs.documentfoundation.org/show_bug.cgi?id=151878 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151878] LibreCalc buttons change color, horizontal lines from the top and bottoms of buttons radiate across a background image and buttons briefly appear and disappear in the w
https://bugs.documentfoundation.org/show_bug.cgi?id=151878 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151749] version 7.4.2.3 crashing
https://bugs.documentfoundation.org/show_bug.cgi?id=151749 --- Comment #7 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151749] version 7.4.2.3 crashing
https://bugs.documentfoundation.org/show_bug.cgi?id=151749 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151358] Languagetool not working in latest Libreoffice release after setup
https://bugs.documentfoundation.org/show_bug.cgi?id=151358 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151358] Languagetool not working in latest Libreoffice release after setup
https://bugs.documentfoundation.org/show_bug.cgi?id=151358 --- Comment #9 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148614] Date fields not printed
https://bugs.documentfoundation.org/show_bug.cgi?id=148614 --- Comment #9 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 144141] Suggestion for a new feature - setting the default border line width
https://bugs.documentfoundation.org/show_bug.cgi?id=144141 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 148614] Date fields not printed
https://bugs.documentfoundation.org/show_bug.cgi?id=148614 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144141] Suggestion for a new feature - setting the default border line width
https://bugs.documentfoundation.org/show_bug.cgi?id=144141 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 144141] Suggestion for a new feature - setting the default border line width
https://bugs.documentfoundation.org/show_bug.cgi?id=144141 --- Comment #7 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 144141] Suggestion for a new feature - setting the default border line width
https://bugs.documentfoundation.org/show_bug.cgi?id=144141 --- Comment #7 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 94030] line wrap at non-breaking space when recording changes
https://bugs.documentfoundation.org/show_bug.cgi?id=94030 --- Comment #8 from QA Administrators --- Dear Ulrich Windl, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 93941] Invisible table borders show up in pdf through non-white cell background
https://bugs.documentfoundation.org/show_bug.cgi?id=93941 --- Comment #14 from QA Administrators --- Dear thanasis57, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 78527] FORMATTING: automatic hyphenation doesn't work on text in small caps or all caps
https://bugs.documentfoundation.org/show_bug.cgi?id=78527 --- Comment #9 from QA Administrators --- Dear nbusch, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137665] Glow effect in presentation mode only present after they animation ends (so not while animating) Skia
https://bugs.documentfoundation.org/show_bug.cgi?id=137665 --- Comment #3 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137682] FILESAVE Export of custom shape to pptx loses formulas and handles
https://bugs.documentfoundation.org/show_bug.cgi?id=137682 --- Comment #2 from QA Administrators --- Dear NISZ LibreOffice Team, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137404] Clone formatting ICON and Format / Clone Formatting grayed out inside of text box
https://bugs.documentfoundation.org/show_bug.cgi?id=137404 --- Comment #2 from QA Administrators --- Dear box.documentfoundation, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137291] Leaving (personally selected) Impress toolbars pinned for repeated use through multiple file closing/reopening
https://bugs.documentfoundation.org/show_bug.cgi?id=137291 --- Comment #3 from QA Administrators --- Dear josselin.janv...@wanadoo.fr, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137299] In a Writer table, SelectCell doesn't include the background colour
https://bugs.documentfoundation.org/show_bug.cgi?id=137299 --- Comment #3 from QA Administrators --- Dear TorrAB, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118276] FILEOPEN XLSX Basic code with Validity and Sheets does not work in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=118276 --- Comment #6 from QA Administrators --- Dear Gabor Kelemen, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138668] support image format AVIF import
https://bugs.documentfoundation.org/show_bug.cgi?id=138668 --- Comment #15 from Logan Shire --- @Buovjaga they are partially supported -- I am able to get 4:2:0 and 4:4:4 AVIF images to work but not 4:2:2 images. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/mimo/mimo-7-3' - dbaccess/source
dbaccess/source/ui/uno/copytablewizard.cxx | 68 ++---
1 file changed, 33 insertions(+), 35 deletions(-)
New commits:
commit 509703632ec0dc24d4c30a7a2400c05647c89aba
Author: Noel Grandin
AuthorDate: Fri Oct 28 11:28:58 2022 +0200
Commit: Aron Budea
CommitDate: Fri Nov 4 04:31:35 2022 +0100
make ValueTransfer easier to understand
storing references to local variables makes it harder to figure out what
the control flow is doing.
Change-Id: Ifa7fedd6e4be19a0aa8180aa4f754f1811ca44a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141965
Tested-by: Jenkins
Reviewed-by: Noel Grandin
(cherry picked from commit ca82061c2cad00aeddb17b766063776fee0ee41a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142206
Tested-by: Aron Budea
Reviewed-by: Aron Budea
diff --git a/dbaccess/source/ui/uno/copytablewizard.cxx
b/dbaccess/source/ui/uno/copytablewizard.cxx
index 4404c9595c1d..5894a642594e 100644
--- a/dbaccess/source/ui/uno/copytablewizard.cxx
+++ b/dbaccess/source/ui/uno/copytablewizard.cxx
@@ -942,40 +942,39 @@ namespace
class ValueTransfer
{
public:
-ValueTransfer( const sal_Int32& _rSourcePos, const sal_Int32&
_rDestPos, std::vector< sal_Int32 >&& _rColTypes,
+ValueTransfer( std::vector< sal_Int32 > _rColTypes,
const Reference< XRow >& _rxSource, const Reference< XParameters
>& _rxDest )
-:m_rSourcePos( _rSourcePos )
-,m_rDestPos( _rDestPos )
-,m_rColTypes( std::move(_rColTypes) )
+:m_ColTypes( std::move(_rColTypes) )
,m_xSource( _rxSource )
,m_xDest( _rxDest )
{
}
template< typename VALUE_TYPE >
-void transferValue( VALUE_TYPE ( SAL_CALL XRow::*_pGetter )( sal_Int32 ),
+void transferValue( sal_Int32 _nSourcePos, sal_Int32 _nDestPos,
+VALUE_TYPE ( SAL_CALL XRow::*_pGetter )( sal_Int32 ),
void (SAL_CALL XParameters::*_pSetter)( sal_Int32, VALUE_TYPE ) )
{
-VALUE_TYPE value( (m_xSource.get()->*_pGetter)( m_rSourcePos ) );
+VALUE_TYPE value( (m_xSource.get()->*_pGetter)( _nSourcePos ) );
if ( m_xSource->wasNull() )
-m_xDest->setNull( m_rDestPos, m_rColTypes[ m_rSourcePos ] );
+m_xDest->setNull( _nDestPos, m_ColTypes[ _nSourcePos ] );
else
-(m_xDest.get()->*_pSetter)( m_rDestPos, value );
+(m_xDest.get()->*_pSetter)( _nDestPos, value );
}
- template< typename VALUE_TYPE >
-void transferComplexValue( VALUE_TYPE ( SAL_CALL XRow::*_pGetter )(
sal_Int32 ),
+
+template< typename VALUE_TYPE >
+void transferComplexValue( sal_Int32 _nSourcePos, sal_Int32 _nDestPos,
+VALUE_TYPE ( SAL_CALL XRow::*_pGetter )( sal_Int32 ),
void (SAL_CALL XParameters::*_pSetter)( sal_Int32, const VALUE_TYPE& )
)
{
-const VALUE_TYPE value( (m_xSource.get()->*_pGetter)( m_rSourcePos ) );
+const VALUE_TYPE value( (m_xSource.get()->*_pGetter)( _nSourcePos ) );
if ( m_xSource->wasNull() )
-m_xDest->setNull( m_rDestPos, m_rColTypes[ m_rSourcePos ] );
+m_xDest->setNull( _nDestPos, m_ColTypes[ _nSourcePos ] );
else
-(m_xDest.get()->*_pSetter)( m_rDestPos, value );
+(m_xDest.get()->*_pSetter)( _nDestPos, value );
}
private:
-const sal_Int32&m_rSourcePos;
-const sal_Int32&m_rDestPos;
-const std::vector< sal_Int32 >m_rColTypes;
+const std::vector< sal_Int32 > m_ColTypes;
const Reference< XRow > m_xSource;
const Reference< XParameters > m_xDest;
};
@@ -1144,13 +1143,12 @@ void CopyTableWizard::impl_copyRows_throw( const
Reference< XResultSet >& _rxSou
// notify listeners
m_aCopyTableListeners.notifyEach( ::copyingRow,
aCopyEvent );
-sal_Int32 nDestColumn( 0 );
-sal_Int32 nSourceColumn( 1 );
-ValueTransfer aTransfer( nSourceColumn, nDestColumn,
std::vector(aSourceColTypes), xRow, xStatementParams );
+sal_Int32 nSourceColumn( 0 );
+ValueTransfer aTransfer( aSourceColTypes, xRow, xStatementParams );
for ( auto const& rColumnPos : aColumnPositions )
{
-nDestColumn = rColumnPos.first;
+sal_Int32 nDestColumn = rColumnPos.first;
if ( nDestColumn == COLUMN_POSITION_NOT_FOUND )
{
++nSourceColumn;
@@ -1176,7 +1174,7 @@ void CopyTableWizard::impl_copyRows_throw( const
Reference< XResultSet >& _rxSou
{
case DataType::DOUBLE:
case DataType::REAL:
-aTransfer.transferValue( ::getDouble,
::setDouble );
+aTransfer.transferValue( nSourceColumn, nDestColumn,
[Libreoffice-commits] core.git: sc/uiconfig
sc/uiconfig/scalc/ui/validationcriteriapage.ui |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit 5efb023c27e693654b09c45894a6f4a50f3d950e Author: Adolfo Jayme Barrientos AuthorDate: Thu Nov 3 04:59:17 2022 -0600 Commit: Adolfo Jayme Barrientos CommitDate: Fri Nov 4 04:31:11 2022 +0100 tdf#150045 Supplemental label in Validity dialog In a type ramp, this label has secondary importance. This change gives texture to the dialog and makes it easier to parse. Change-Id: If1dbb01ff2fb0a103a7f534b9ca4cc4681e923ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142227 Reviewed-by: Adolfo Jayme Barrientos Tested-by: Jenkins diff --git a/sc/uiconfig/scalc/ui/validationcriteriapage.ui b/sc/uiconfig/scalc/ui/validationcriteriapage.ui index 6bd6b7b29c2c..48f2395cb4e7 100644 --- a/sc/uiconfig/scalc/ui/validationcriteriapage.ui +++ b/sc/uiconfig/scalc/ui/validationcriteriapage.ui @@ -1,5 +1,5 @@ - + @@ -268,6 +268,9 @@ 50 0 0 + + + 1
[Libreoffice-bugs] [Bug 151876] Slow Chart Render open, cpu spike, and view if data point is more than 1000 data point in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=151876 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #4 from m.a.riosv --- Created attachment 183401 --> https://bugs.documentfoundation.org/attachment.cgi?id=183401=edit Sample file modified chart ranges Seems calc doesn't like column ranges in chart ranges. Charts have column ranges, but calc doesn't treat them like that and doesn't shortcut to analyze at then end of the data. Changed in the sample file, the chart ranges to rows, runs very smoothly. It also makes load and save near instantly. And problem with the original sample, at load & save it's also in ods format. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'feature/cib_contract891c' - configure.ac
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 7c307a92a8e6a8aa6ea403ebb67c8a4e3335faa4 Author: Thorsten Behrens AuthorDate: Fri Nov 4 03:50:24 2022 +0100 Commit: Thorsten Behrens CommitDate: Fri Nov 4 03:50:24 2022 +0100 Release 5.4.16 Change-Id: Ifffd9a8dfe6802fb829ca38541783f6e433a323b diff --git a/configure.ac b/configure.ac index 5c5f843c168c..a52137e6f88a 100644 --- a/configure.ac +++ b/configure.ac @@ -9,7 +9,7 @@ dnl in order to create a configure script. # several non-alphanumeric characters, those are split off and used only for the # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no idea. -AC_INIT([LibreOffice],[5.4.15.0],[],[],[http://documentfoundation.org/]) +AC_INIT([LibreOffice],[5.4.16.0],[],[],[http://documentfoundation.org/]) AC_PREREQ([2.59])
[Libreoffice-commits] core.git: Branch 'feature/cib_contract891c' - 7 commits - download.lst external/curl external/libxml2 external/poppler external/zlib sc/source sdext/Executable_xpdfimport.mk unox
download.lst | 18 ++-- external/curl/ExternalProject_curl.mk|2 external/curl/curl-7.26.0_win-proxy.patch|8 - external/curl/curl-nss.patch.1 |7 + external/libxml2/ExternalPackage_xml2.mk |2 external/libxml2/UnpackedTarball_xml2.mk |5 - external/libxml2/libxml2-android.patch |6 - external/libxml2/libxml2-config.patch.1 | 43 - external/libxml2/xml2-config.in | 28 ++ external/poppler/UnpackedTarball_poppler.mk |2 external/poppler/disable-freetype.patch.1| 41 + external/poppler/gcc7-EntityInfo.patch.1 | 48 +++ external/poppler/poppler-c++11.patch.1 | 13 ++ external/poppler/poppler-config.patch.1 | 27 ++ external/zlib/1eb7682f845ac9e9bf9ae35bbfb3bad5dacbd91d.patch | 29 ++ external/zlib/UnpackedTarball_zlib.mk|7 + external/zlib/eff308af425b67093bab25f80f1ae950166bece1.patch | 32 +++ sc/source/core/tool/interpr7.cxx |3 sdext/Executable_xpdfimport.mk |4 unoxml/source/xpath/xpathobject.cxx |2 20 files changed, 248 insertions(+), 79 deletions(-) New commits: commit 98d3d103fb99ee4433e84aa2fd1f0fa13016cf02 Author: Jan-Marek Glogowski AuthorDate: Sun May 30 13:23:16 2021 +0200 Commit: Thorsten Behrens CommitDate: Fri Nov 4 03:05:50 2022 +0100 libxml2: use xml2-config dummy for internal build When building a static LO with --disable-dynloading on Linux, --without-system-libs failed for me. And it left me really puzzled: raptor configure failed and claimed it couldn't link libxml2. raptor's config.log showed missing math functions. xml2-config of LO's build is patched and it includes a -lm. The xml2-config in my chroot doesn't. But we explicitly pass the xml2-config for non-system-libxml2 build. Reading the configure from raptor didn't reveal a way, that it could somehow pick up the xml2-config from the chroot, but that code is autoconf-complex... When running "sh -x configure", it turned out the configure script actually picks up the LIBXML_* flags from the environment, which are set by LO's config_host.mk. These just add -lm for Android. So this adds a xml2-config.in "dummy", which overwrites the one from the libxml2 source and just echos LO's LIBXML_* values and it adds -lm for all DISABLE_DYNLOADING targets. Change-Id: Ia713cf80c8e7dc989cf23c224e7a0f7ea1210a87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116409 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski (cherry picked from commit 8b9f8f0f9d38cc64f742fe5358fce88d0f82391a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139965 Reviewed-by: Michael Stahl (cherry picked from commit 5c044ae7a3246bddbd0513bd5ed3efef10cb1503) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142035 Tested-by: Thorsten Behrens Reviewed-by: Thorsten Behrens Conflicts: external/libxml2/UnpackedTarball_xml2.mk external/libxml2/libxml2-config.patch.1 diff --git a/external/libxml2/UnpackedTarball_xml2.mk b/external/libxml2/UnpackedTarball_xml2.mk index 5cff2aed0a87..52523c5c8bd3 100644 --- a/external/libxml2/UnpackedTarball_xml2.mk +++ b/external/libxml2/UnpackedTarball_xml2.mk @@ -11,12 +11,15 @@ $(eval $(call gb_UnpackedTarball_UnpackedTarball,xml2)) $(eval $(call gb_UnpackedTarball_set_tarball,xml2,$(LIBXML_TARBALL),,libxml2)) +$(eval $(call gb_UnpackedTarball_update_autoconf_configs,xml2)) + $(eval $(call gb_UnpackedTarball_add_patches,xml2,\ - external/libxml2/libxml2-config.patch.1 \ external/libxml2/libxml2-global-symbols.patch \ external/libxml2/libxml2-vc10.patch \ $(if $(filter ANDROID,$(OS)),external/libxml2/libxml2-android.patch) \ external/libxml2/libxml2-icu.patch.0 \ )) +$(eval $(call gb_UnpackedTarball_add_file,xml2,xml2-config.in,external/libxml2/xml2-config.in)) + # vim: set noet sw=4 ts=4: diff --git a/external/libxml2/libxml2-config.patch.1 b/external/libxml2/libxml2-config.patch.1 deleted file mode 100644 index 28ac8f2809a7.. --- a/external/libxml2/libxml2-config.patch.1 +++ /dev/null @@ -1,43 +0,0 @@ -Hack the xml2-config to return paths into WORKDIR. - a/xml2-config.in 2009-12-17 11:45:20.0 + -+++ b/xml2-config.in 2009-12-17 11:45:36.0 + -@@ -1,9 +1,14 @@ - #! /bin/sh - --prefix=@prefix@ --exec_prefix=@exec_prefix@ --includedir=@includedir@ --libdir=@libdir@ -+#prefix=@prefix@ -+#exec_prefix=@exec_prefix@
[Libreoffice-bugs] [Bug 147565] Browsing comments in the navigation pane also browses hidden solved comments
https://bugs.documentfoundation.org/show_bug.cgi?id=147565 --- Comment #13 from jordanlaris --- These tips seem simple but extremely useful, can not be without it. More information can be found at https://deathrun3d.com -- You are receiving this mail because: You are the assignee for the bug.
Interacting with AT-SPI2 in CI environment
Hello everyone, As part of my effort to improve accessibility test infrastructure and coverage [1], I'll have to work on covering the platform layer. The chosen approach, after discussing with Florian Effenberger (back in late 2021 I think), is communicating with a LO process through AT-SPI2 on Linux. This is because it's the true outer layer, and that GTK4 does not use ATK anymore, so tests relying on simply checking the ATK implementations in the GTK3 VCL would not be future-proof, and don't seem sensible to invest on nowadays. Using AT-SPI2 directly would also allow testing the Qt VCLs. This means that to perform tests I'll have to run LO in the CI environment in a way where it can use the gtk3/4 VCL, and have a working AT-SPI2 bus so they can communicate. The tests themselves would then simply use the exposed AT-SPI2 interfaces and control they behave as expected. We at Hypra already have done similar setups (even with LO itself) using xvfb-run (or xvnc, but that's not very useful in CI) and dbus-launch, and then interacting through AT-SPI2 using Python and the excellent dogtail module [2]. My question here is: what would be acceptable in CIs, and how would it work to add such CI dependencies? I'd rather not rebuild xvfb & al for each CI run, as it seems heavy and not very sensible: it's a fairly standard piece of software and I wouldn't need any specific version of it. A follow-up question would be whether you have any pointers in how to integrate this kind of things to the build? I didn't start investigating because I'd like to make sure I'm not pursuing the wrong path, but anything that could save me reading a hundred gbuild files would be much appreciated :) Thanks in advance, Colomban [1] https://blog.documentfoundation.org/blog/2021/10/13/tender-to-implement-c-accessibility-tests-202110-01/ [2] https://gitlab.com/dogtail/dogtail
[Libreoffice-bugs] [Bug 151442] [UI] Windows menu item (Sheet, Delete Rows) has a non-unique accelerator
https://bugs.documentfoundation.org/show_bug.cgi?id=151442
--- Comment #11 from Alex Pakhotin ---
The previous versions used "D" as a hot-key for the "Delete Rows" command in
the menu. The key is unique, makes sense to identify the action ("D"elete), and
easy to remember.
Can we please have this back in the next version.
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151884] New: Drop-down menus are sometimes darkened out
https://bugs.documentfoundation.org/show_bug.cgi?id=151884 Bug ID: 151884 Summary: Drop-down menus are sometimes darkened out Product: LibreOffice Version: 7.4.2.3 release Hardware: x86 (IA32) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rogerd1...@gmail.com Description: Frequently, when I click on a menu, Format for example, the items to select are there but the area containing the selections is dark. Steps to Reproduce: 1.Itjust happens at times 2. 3. Actual Results: It cannot be reproduced. It happens on its on frequently Expected Results: NA Reproducible: Sometimes User Profile Reset: No Additional Info: Version: 7.4.2.3 (x64) / LibreOffice Community Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf CPU threads: 4; OS: Windows 10.0 Build 22621; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL == I have uninstalled and reinstalled, but the bug remains. My PC Specs: OS Name Microsoft Windows 11 Pro Version 10.0.22621 Build 22621 Other OS DescriptionNot Available OS Manufacturer Microsoft Corporation System Manufacturer HP System ModelHP Laptop 14-dk0xxx System Type x64-based PC System SKU 6BW41UA#ABA Processor AMD Ryzen 3 3200U with Radeon Vega Mobile Gfx, 2600 Mhz, 2 Core(s), 4 Logical Processor(s) BIOS Version/Date AMI F.65, 3/3/2022 SMBIOS Version 3.2 Embedded Controller Version 84.51 BIOS Mode UEFI BaseBoard Manufacturer HP BaseBoard Product 85E0 BaseBoard Version 84.51 Platform Role Mobile Secure Boot State On PCR7 Configuration Elevation Required to View Windows Directory C:\WINDOWS System DirectoryC:\WINDOWS\system32 Boot Device \Device\HarddiskVolume1 Locale United States Hardware Abstraction Layer Version = "10.0.22621.1" Installed Physical Memory (RAM) 16.0 GB Total Physical Memory 13.9 GB Available Physical Memory 8.36 GB Total Virtual Memory16.5 GB Available Virtual Memory5.26 GB Page File Space 2.63 GB Page File C:\pagefile.sys Kernel DMA Protection Off Virtualization-based security Running Virtualization-based security Required Security Properties Virtualization-based security Available Security Properties Base Virtualization Support, Secure Boot, DMA Protection, UEFI Code Readonly, SMM Security Mitigations 1.0 Virtualization-based security Services Configured Hypervisor enforced Code Integrity Virtualization-based security Services Running Credential Guard, Hypervisor enforced Code Integrity Windows Defender Application Control policy Enforced Windows Defender Application Control user mode policy Audit -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144438] Cell editing random spurious odd content re-arrangements and deletions
https://bugs.documentfoundation.org/show_bug.cgi?id=144438 --- Comment #14 from John --- Created attachment 183400 --> https://bugs.documentfoundation.org/attachment.cgi?id=183400=edit Paragraph Link Creation Example As I mentioned this issue this week, I thought I would give you an example of what occasionally happens. It still does: entering text with an @ symbol can convert the adjacent text or whole paragraph into what appears to be a link that is not text wrapped as intended. This example is from an extensive address list of 100s of entries on each of five sheets within a single Calc file. I think I supplied a cut-down version of this file years ago as I did not want to release the full content for confidentiality reasons. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151883] LibreOffice cannot use document-support fonts in macOS 13
https://bugs.documentfoundation.org/show_bug.cgi?id=151883 --- Comment #1 from Stephen Heumann --- Created attachment 183399 --> https://bugs.documentfoundation.org/attachment.cgi?id=183399=edit Example document using document-support fonts This is an example document showing the problem. It contains the Garamond and Times fonts, which are document-support fonts in macOS 13. Note that Apple's TextEdit and Pages can display this document with proper fonts in macOS 13, so the fonts clearly are present and usable. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151883] New: LibreOffice cannot use document-support fonts in macOS 13
https://bugs.documentfoundation.org/show_bug.cgi?id=151883 Bug ID: 151883 Summary: LibreOffice cannot use document-support fonts in macOS 13 Product: LibreOffice Version: 7.4.2.3 release Hardware: All OS: macOS (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: stephenheum...@gmail.com Description: Recent versions of macOS include some fonts that are described as document-support fonts. An Apple support document (https://support.apple.com/en-us/HT213266) lists these fonts toward the bottom and describes them a follows: "These fonts are available only to documents that already use the font, or to apps that request the font by name. Some are older fonts that were included with earlier versions of macOS or Apple apps." In macOS 13, LibreOffice cannot display these fonts (even in existing documents) and will substitute them instead. It would be nice if they could be used, at least for the documented purpose of supporting existing documents. This behavior is different from macOS 11, where document-support fonts can be used. I have not tested on macOS 12. Steps to Reproduce: 1. Open a document containing a document-support font (e.g. Garamond). 2. Check whether the correct font is used. Actual Results: The correct font is not used, and the font name is italicized to indicate it was substituted. Expected Results: The specified font is used. Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.4.2.3 / LibreOffice Community Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf CPU threads: 10; OS: Mac OS X 13.0; UI render: default; VCL: osx Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144438] Cell editing random spurious odd content re-arrangements and deletions
https://bugs.documentfoundation.org/show_bug.cgi?id=144438 --- Comment #13 from John --- It is possible that typing in the wrong place can occur due to accidental wrist touching of the trackpad. However, my submission clearly indicates new text being added, and in the past I have seen the changes taking place in front of me with no hands touching the computer. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151863] Array SUM along sheets with INDIRECT reference list result and comparison operator returns #VALUE, while it works fine with 5.4.7
https://bugs.documentfoundation.org/show_bug.cgi?id=151863 --- Comment #7 from Commit Notification --- Eike Rathke committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/94c64c0c999eeaa91ebdc335186289046eacdc4f Related: tdf#151863 Set #REF! error if reference list is not convertible It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151863] Array SUM along sheets with INDIRECT reference list result and comparison operator returns #VALUE, while it works fine with 5.4.7
https://bugs.documentfoundation.org/show_bug.cgi?id=151863 Commit Notification changed: What|Removed |Added Whiteboard||target:7.5.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/source
sc/source/core/tool/interpr4.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 94c64c0c999eeaa91ebdc335186289046eacdc4f
Author: Eike Rathke
AuthorDate: Thu Nov 3 19:10:00 2022 +0100
Commit: Eike Rathke
CommitDate: Fri Nov 4 01:02:34 2022 +0100
Related: tdf#151863 Set #REF! error if reference list is not convertible
i.e. to array/matrix that a function or operator may expect.
That indicates the actual problem better than #VALUE! and also
seems to be what Excel does.
Change-Id: I9c3857613e330f9a93d4a0595e740106addc6e67
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142250
Reviewed-by: Eike Rathke
Tested-by: Jenkins
diff --git a/sc/source/core/tool/interpr4.cxx b/sc/source/core/tool/interpr4.cxx
index 90b02b1e7f47..b122a836d654 100644
--- a/sc/source/core/tool/interpr4.cxx
+++ b/sc/source/core/tool/interpr4.cxx
@@ -1581,7 +1581,7 @@ bool ScInterpreter::ConvertMatrixParameters()
eType != formula::ParamClass::ForceArray)
{
// can't convert to matrix
-SetError( FormulaError::NoValue);
+SetError( FormulaError::NoRef);
}
// else: the consuming function has to decide if and how to
// handle a reference list argument in array context.
[Libreoffice-bugs] [Bug 151863] Array SUM along sheets with INDIRECT reference list result and comparison operator returns #VALUE, while it works fine with 5.4.7
https://bugs.documentfoundation.org/show_bug.cgi?id=151863 --- Comment #6 from Eike Rathke --- I doubt 3D matrices will be generally supported; in many contexts it doesn't make sense, the result couldn't even be displayed on a 2D sheet.. only functions that accept multiple ranges like SUM() and its family would be able to consume 3D and deliver a meaningful result. All iterating over arrays for scalar values expecting functions would have to be adapted and wherever 2D matrices are handled as well, just for the little benefit of a few constellations that could make sense. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151878] LibreCalc buttons change color, horizontal lines from the top and bottoms of buttons radiate across a background image and buttons briefly appear and disappear in the w
https://bugs.documentfoundation.org/show_bug.cgi?id=151878 --- Comment #2 from Michael --- I started in Safe Mode, but I can't run macros, so I can't load a new image to see if there are the white lines, and I can't run a CopyDown macro to see if the buttons flash. The buttons on the Setup Page are black. If I open the Kearsarge spreadsheet, the buttons on the Setup sheet are mottled grey and they remain the same if I replace them with good buttons, save and re-open the spreadsheet. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151691] Better distinguish shape text from shape name
https://bugs.documentfoundation.org/show_bug.cgi?id=151691 --- Comment #8 from Eyal Rozenberg --- (In reply to Heiko Tietze from comment #6) > I'm also in the pro-colon camp. Your only point, at least what I can see, is > that colons may appear in regular text as well, which is a quite academic > argument. No, the colon was not the point, it was just an _illustration_ on how the shape name is not distinguished from the shape text. Heiko, where else in the LO UI are we presenting multiple pieces of information as a concatenated string of text characters? What are we, xfontsel of 30 years ago? :-( > The alternative, to move the object text into a second line, is not really > helpful. Neither go with brackets or quotes. That's still just text. It won't do... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 151691] Better distinguish shape text from shape name
https://bugs.documentfoundation.org/show_bug.cgi?id=151691 --- Comment #8 from Eyal Rozenberg --- (In reply to Heiko Tietze from comment #6) > I'm also in the pro-colon camp. Your only point, at least what I can see, is > that colons may appear in regular text as well, which is a quite academic > argument. No, the colon was not the point, it was just an _illustration_ on how the shape name is not distinguished from the shape text. Heiko, where else in the LO UI are we presenting multiple pieces of information as a concatenated string of text characters? What are we, xfontsel of 30 years ago? :-( > The alternative, to move the object text into a second line, is not really > helpful. Neither go with brackets or quotes. That's still just text. It won't do... -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 44387] double shadow for rectangle / square shape
https://bugs.documentfoundation.org/show_bug.cgi?id=44387 --- Comment #20 from Rajasekaran Karunanithi --- Reproducable in LO 7.4.2.3 under LXLE(x64) Focal distro. Version: 7.4.2.3 / LibreOffice Community Build ID: 40(Build:3) CPU threads: 1; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Ubuntu package version: 1:7.4.2~rc3-0ubuntu0.20.04.1~lo1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108230] [META] OOXML document theme issues
https://bugs.documentfoundation.org/show_bug.cgi?id=108230 Regina Henschel changed: What|Removed |Added Depends on||151882 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=151882 [Bug 151882] Theme color does not work for docx -> odt ->docx -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151882] New: Theme color does not work for docx -> odt ->docx
https://bugs.documentfoundation.org/show_bug.cgi?id=151882 Bug ID: 151882 Summary: Theme color does not work for docx -> odt ->docx Product: LibreOffice Version: 7.5.0.0 alpha0+ Master Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rb.hensc...@t-online.de Blocks: 108230 Created attachment 183398 --> https://bugs.documentfoundation.org/attachment.cgi?id=183398=edit SmartArt 'Venn diagram' with theme colors The commits 0c13e476 and 1868dea8 have introduced theme colors (Miklos Vajna). But using them produces a regression in Writer. Make sure option "SmartArt to LibreOffice shapes or reverse" is enabled in 'Microsoft Office' in 'Load/Save' in Tools>Options. Open attached docx file. It contains a SmartArt shape. Save it to ODF 1.3extended. Reopen the saved file. You have no longer a SmartArt but a group. That is OK. The colors are OK. Save that file to docx format. Open the saved docx file in Word. The colors are missing. Instead a single blue is used. Problem is, that the shapes get a reference to the theme in their fill attribute, but the folder 'Theme' is missing. That is a regression compared to LO 7.3, which has no support for themes but sets the correct fill colors directly in the shape attributes and so the colors were correct in Word. If a solution with generating the needed 'Theme' folder is not possible for LO 7.4, then the old way with direct colors should be used. For LO 7.5 a solution with generating the needed 'Theme' folder would be nice. But if that will not be possible in time, for 7.5 too the old way with direct colors should be used for odt->docx. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108230 [Bug 108230] [META] OOXML document theme issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151881] New: new ODF color theme attributes missing in Implementer Notes
https://bugs.documentfoundation.org/show_bug.cgi?id=151881 Bug ID: 151881 Summary: new ODF color theme attributes missing in Implementer Notes Product: LibreOffice Version: 7.5.0.0 alpha0+ Master Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rb.hensc...@t-online.de CC: vmik...@collabora.com The commits 0c13e476 and 1868dea8 have introduced 'fill-theme-color', 'fill-color-lum-off' and 'fill-color-lum-mode' attributes. They are written to files in ODF format in loext namespace. The new attributes need to be documented in "ODF Implementer Notes" https://wiki.documentfoundation.org/Development/ODF_Implementer_Notes/List_of_LibreOffice_ODF_Extensions -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: chart2/qa include/test oox/qa sc/qa sd/qa
chart2/qa/extras/chart2export.cxx | 22 +++---
chart2/qa/extras/chart2export2.cxx | 36 ++--
chart2/qa/extras/chart2export3.cxx |8
chart2/qa/extras/chart2geometry.cxx |2 +-
include/test/unoapi_test.hxx|5 ++---
oox/qa/unit/export.cxx |8
sc/qa/unit/scshapetest.cxx |2 +-
sc/qa/unit/uicalc/uicalc.cxx|2 +-
sd/qa/unit/export-tests.cxx |4 ++--
9 files changed, 44 insertions(+), 45 deletions(-)
New commits:
commit 2640796d90ad4c69f5093e7b3353d43b647901e1
Author: Xisco Fauli
AuthorDate: Thu Nov 3 17:20:11 2022 +0100
Commit: Xisco Fauli
CommitDate: Thu Nov 3 23:22:14 2022 +0100
UnoApiTest: make mbSkipValidation private
Change-Id: Icc292b40b3295e7890f81d448bb4907725f46970
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142245
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/chart2/qa/extras/chart2export.cxx
b/chart2/qa/extras/chart2export.cxx
index f58796a3219c..f287577fb63a 100644
--- a/chart2/qa/extras/chart2export.cxx
+++ b/chart2/qa/extras/chart2export.cxx
@@ -354,7 +354,7 @@ void Chart2ExportTest::testTrendline()
{
// Validation fails with
// Error: tag name "chart:symbol-image" is not allowed. Possible tag names
are:
-mbSkipValidation = true;
+skipValidation();
loadFromURL(u"ods/trendline.ods");
checkTrendlinesInChart(getChartDocFromSheet( 0, mxComponent));
saveAndReload("calc8");
@@ -594,7 +594,7 @@ void Chart2ExportTest::testAreaChartLoad()
loadFromURL(u"docx/testAreaChartLoad.docx");
// FIXME: validation error in OOXML export: Errors: 1
-mbSkipValidation = true;
+skipValidation();
xmlDocUniquePtr pXmlDoc = parseExport("word/charts/chart","Office Open XML
Text");
CPPUNIT_ASSERT(pXmlDoc);
@@ -652,7 +652,7 @@ void Chart2ExportTest::testPieChartWallLineStyle()
loadFromURL(u"odt/testPieChartWallLineStyle.odt");
// FIXME: validation error in OOXML export: Errors: 9
-mbSkipValidation = true;
+skipValidation();
xmlDocUniquePtr pXmlDoc = parseExport("word/charts/chart", "Office Open
XML Text");
CPPUNIT_ASSERT(pXmlDoc);
@@ -920,7 +920,7 @@ void Chart2ExportTest::testDataLabelBordersDOCX()
aTest.checkObject2(xChartDoc);
// FIXME: validation error in OOXML export: Errors: 3
-mbSkipValidation = true;
+skipValidation();
saveAndReload("Office Open XML Text");
@@ -938,7 +938,7 @@ void Chart2ExportTest::testDataLabel3DChartDOCX()
CPPUNIT_ASSERT(xChartDoc.is());
// FIXME: validation error in OOXML export: Errors: 1
-mbSkipValidation = true;
+skipValidation();
xmlDocUniquePtr pXmlDoc = parseExport("word/charts/chart","Office Open XML
Text");
CPPUNIT_ASSERT(pXmlDoc);
@@ -972,7 +972,7 @@ void Chart2ExportTest::testDataLabelClusteredBarChartDOCX()
CPPUNIT_ASSERT(xChartDoc.is());
// FIXME: validation error in OOXML export: Errors: 9
-mbSkipValidation = true;
+skipValidation();
xmlDocUniquePtr pXmlDoc = parseExport("word/charts/chart","Office Open XML
Text");
CPPUNIT_ASSERT(pXmlDoc);
@@ -1004,7 +1004,7 @@ void Chart2ExportTest::testDataLabelDoughnutChartDOCX()
CPPUNIT_ASSERT(xChartDoc.is());
// FIXME: validation error in OOXML export: Errors: 1
-mbSkipValidation = true;
+skipValidation();
xmlDocUniquePtr pXmlDoc = parseExport("word/charts/chart","Office Open XML
Text");
CPPUNIT_ASSERT(pXmlDoc);
@@ -1022,7 +1022,7 @@ void Chart2ExportTest::testDataLabelAreaChartDOCX()
CPPUNIT_ASSERT(xChartDoc.is());
// FIXME: validation error in OOXML export: Errors: 1
-mbSkipValidation = true;
+skipValidation();
xmlDocUniquePtr pXmlDoc = parseExport("word/charts/chart","Office Open XML
Text");
CPPUNIT_ASSERT(pXmlDoc);
@@ -1060,7 +1060,7 @@ void Chart2ExportTest::testIndividualDataLabelProps()
loadFromURL(u"xlsx/tdf122915.xlsx");
// FIXME: validation error in OOXML export: Errors: 1
-mbSkipValidation = true;
+skipValidation();
xmlDocUniquePtr pXmlDoc = parseExport("xl/charts/chart","Calc Office Open
XML");
CPPUNIT_ASSERT(pXmlDoc);
@@ -1090,7 +1090,7 @@ void Chart2ExportTest::testShapeFollowedByChart()
loadFromURL(u"docx/FDO74430.docx");
// FIXME: validation error in OOXML export: Errors: 5
-mbSkipValidation = true;
+skipValidation();
xmlDocUniquePtr pXmlDoc = parseExport("word/document", "Office Open XML
Text" );
CPPUNIT_ASSERT(pXmlDoc);
@@ -1106,7 +1106,7 @@ void Chart2ExportTest::testPieChartDataLabels()
loadFromURL(u"docx/PieChartDataLabels.docx");
// FIXME: validation error in OOXML export: Errors: 19
-mbSkipValidation = true;
+skipValidation();
xmlDocUniquePtr pXmlDoc = parseExport("word/charts/chart", "Office Open
XML Text");
CPPUNIT_ASSERT(pXmlDoc);
diff --git
[Libreoffice-commits] core.git: sw/qa
sw/qa/core/text/text.cxx | 16
sw/qa/inc/swmodeltestbase.hxx |2 --
sw/qa/unit/swmodeltestbase.cxx |8
3 files changed, 8 insertions(+), 18 deletions(-)
New commits:
commit c5e872e06a070ff8e90f644036981fa202c2b1e0
Author: Xisco Fauli
AuthorDate: Thu Nov 3 17:37:11 2022 +0100
Commit: Xisco Fauli
CommitDate: Thu Nov 3 23:21:44 2022 +0100
swmodeltestbase: remove duplicated method
Change-Id: I16b785c31f0e235b6a71b6ea86b17b72e063e95d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142247
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sw/qa/core/text/text.cxx b/sw/qa/core/text/text.cxx
index 8f3f18fd56d3..0bece6e95f2b 100644
--- a/sw/qa/core/text/text.cxx
+++ b/sw/qa/core/text/text.cxx
@@ -122,7 +122,7 @@ CPPUNIT_TEST_FIXTURE(SwCoreTextTest,
testBibliographyUrlPdfExport)
xText->insertTextContent(xCursor, xContent, /*bAbsorb=*/false);
// When exporting to PDF:
-StoreToTempFile("writer_pdf_Export");
+save("writer_pdf_Export");
// Then make sure the field links the source.
std::unique_ptr pPdfDocument =
LoadPdfFromTempFile();
@@ -646,7 +646,7 @@ CPPUNIT_TEST_FIXTURE(SwCoreTextTest, testContentControlPDF)
pContentControl->SetAlias("mydesc");
// When exporting to PDF:
-StoreToTempFile("writer_pdf_Export");
+save("writer_pdf_Export");
// Then make sure that a fillable form widget is emitted:
std::unique_ptr pPdfDocument =
LoadPdfFromTempFile();
@@ -672,7 +672,7 @@ CPPUNIT_TEST_FIXTURE(SwCoreTextTest,
testCheckboxContentControlPDF)
pWrtShell->InsertContentControl(SwContentControlType::CHECKBOX);
// When exporting to PDF:
-StoreToTempFile("writer_pdf_Export");
+save("writer_pdf_Export");
// Then make sure that a checkbox form widget is emitted:
std::unique_ptr pPdfDocument =
LoadPdfFromTempFile();
@@ -697,7 +697,7 @@ CPPUNIT_TEST_FIXTURE(SwCoreTextTest,
testDropdownContentControlPDF)
pWrtShell->InsertContentControl(SwContentControlType::DROP_DOWN_LIST);
// When exporting to PDF:
-StoreToTempFile("writer_pdf_Export");
+save("writer_pdf_Export");
// Then make sure that a dropdown form widget is emitted:
std::unique_ptr pPdfDocument =
LoadPdfFromTempFile();
@@ -722,7 +722,7 @@ CPPUNIT_TEST_FIXTURE(SwCoreTextTest,
testDateContentControlPDF)
pWrtShell->InsertContentControl(SwContentControlType::DATE);
// When exporting to PDF:
-StoreToTempFile("writer_pdf_Export");
+save("writer_pdf_Export");
// Then make sure that a date form widget is emitted:
std::unique_ptr pPdfDocument =
LoadPdfFromTempFile();
@@ -751,7 +751,7 @@ CPPUNIT_TEST_FIXTURE(SwCoreTextTest,
testContentControlPDFFont)
pWrtShell->InsertContentControl(SwContentControlType::RICH_TEXT);
// When exporting that document to PDF:
-StoreToTempFile("writer_pdf_Export");
+save("writer_pdf_Export");
// Then make sure that the widget in the PDF result has that custom font
size:
std::unique_ptr pPdfDocument =
LoadPdfFromTempFile();
@@ -774,7 +774,7 @@ CPPUNIT_TEST_FIXTURE(SwCoreTextTest,
testComboContentControlPDF)
pWrtShell->InsertContentControl(SwContentControlType::COMBO_BOX);
// When exporting to PDF:
-StoreToTempFile("writer_pdf_Export");
+save("writer_pdf_Export");
// Then make sure that a combo box form widget is emitted:
std::unique_ptr pPdfDocument =
LoadPdfFromTempFile();
@@ -811,7 +811,7 @@ CPPUNIT_TEST_FIXTURE(SwCoreTextTest,
testRichContentControlPDF)
pWrtShell->SetAttrSet(aSet);
// When exporting to PDF:
-StoreToTempFile("writer_pdf_Export");
+save("writer_pdf_Export");
// Then make sure that a single fillable form widget is emitted:
std::unique_ptr pPdfDocument =
LoadPdfFromTempFile();
diff --git a/sw/qa/inc/swmodeltestbase.hxx b/sw/qa/inc/swmodeltestbase.hxx
index db51a1f75aec..1c64baf4fbff 100644
--- a/sw/qa/inc/swmodeltestbase.hxx
+++ b/sw/qa/inc/swmodeltestbase.hxx
@@ -402,8 +402,6 @@ protected:
*/
SwDoc* getSwDoc();
-void StoreToTempFile(const OUString& rFilterName);
-
std::unique_ptr LoadPdfFromTempFile();
/**
diff --git a/sw/qa/unit/swmodeltestbase.cxx b/sw/qa/unit/swmodeltestbase.cxx
index b12f640fb34f..65048ffbac20 100644
--- a/sw/qa/unit/swmodeltestbase.cxx
+++ b/sw/qa/unit/swmodeltestbase.cxx
@@ -744,14 +744,6 @@ SwXTextDocument& SwModelTestBase::getSwXTextDocument()
SwDoc* SwModelTestBase::getSwDoc() { return
getSwXTextDocument().GetDocShell()->GetDoc(); }
-void SwModelTestBase::StoreToTempFile(const OUString& rFilterName)
-{
-uno::Reference xStorable(mxComponent, uno::UNO_QUERY);
-utl::MediaDescriptor aMediaDescriptor;
-aMediaDescriptor["FilterName"] <<= rFilterName;
-xStorable->storeToURL(maTempFile.GetURL(),
aMediaDescriptor.getAsConstPropertyValueList());
-}
-
std::unique_ptr
SwModelTestBase::LoadPdfFromTempFile()
{
[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/layout/layout2.cxx |7 +++
sw/qa/extras/odfexport/odfexport.cxx |5 ++---
sw/qa/extras/odfimport/odfimport.cxx |2 +-
sw/qa/extras/ooxmlexport/ooxmlexport14.cxx| 10 +-
sw/qa/extras/ooxmlexport/ooxmlexport17.cxx| 14 +++---
sw/qa/extras/ooxmlexport/ooxmlexport18.cxx|6 +++---
sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx |6 +++---
sw/qa/extras/uiwriter/uiwriter4.cxx | 20
sw/qa/extras/uiwriter/uiwriter6.cxx |5 ++---
sw/qa/filter/ww8/ww8.cxx |6 +++---
sw/qa/inc/swmodeltestbase.hxx |2 +-
sw/qa/unit/swmodeltestbase.cxx| 11 +--
12 files changed, 43 insertions(+), 51 deletions(-)
New commits:
commit ee1154d7fe84d507ce977b851c4044cafe0b9da9
Author: Xisco Fauli
AuthorDate: Thu Nov 3 15:01:43 2022 +0100
Commit: Xisco Fauli
CommitDate: Thu Nov 3 23:21:17 2022 +0100
swmodeltestbase: use maTempFile everywhere
Change-Id: Ifd840984e4144599f2527702a57688863854b7ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142235
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sw/qa/extras/layout/layout2.cxx b/sw/qa/extras/layout/layout2.cxx
index 92ad57c742ff..367eb23f05da 100644
--- a/sw/qa/extras/layout/layout2.cxx
+++ b/sw/qa/extras/layout/layout2.cxx
@@ -2246,12 +2246,11 @@ CPPUNIT_TEST_FIXTURE(SwLayoutWriter2, testTdf121509)
CPPUNIT_ASSERT(pTriangleShapeFormat->SetFormatAttr(aNewAnch));
// Reload (docx)
-utl::TempFileNamed aTemp;
-save("Office Open XML Text", aTemp);
+save("Office Open XML Text");
// The second part: check if the reloaded doc has flys inside a fly
uno::Reference xComponent
-= loadFromDesktop(aTemp.GetURL(), "com.sun.star.text.TextDocument");
+= loadFromDesktop(maTempFile.GetURL(),
"com.sun.star.text.TextDocument");
uno::Reference xTextDoc(xComponent, uno::UNO_QUERY);
auto pTextDoc = dynamic_cast(xTextDoc.get());
CPPUNIT_ASSERT(pTextDoc);
@@ -2270,7 +2269,7 @@ CPPUNIT_TEST_FIXTURE(SwLayoutWriter2, testTdf121509)
}
}
// Drop the tempfile
-aTemp.CloseStream();
+maTempFile.CloseStream();
// With the fix this cannot be true, if it is, that means Word unable to
read the file..
CPPUNIT_ASSERT_MESSAGE("Corrupt exported docx file!", !bFlyInFlyFound);
diff --git a/sw/qa/extras/odfexport/odfexport.cxx
b/sw/qa/extras/odfexport/odfexport.cxx
index d5fe2c8cf706..0fa0f9b5ed30 100644
--- a/sw/qa/extras/odfexport/odfexport.cxx
+++ b/sw/qa/extras/odfexport/odfexport.cxx
@@ -901,10 +901,9 @@ CPPUNIT_TEST_FIXTURE(Test, testFdo58949)
* and replacement image) OLE objects using UNO, so we'll check the zip
file directly.
*/
-utl::TempFileNamed aTempFile;
-save("writer8", aTempFile);
+save("writer8");
-uno::Sequence aArgs{ uno::Any(aTempFile.GetURL()) };
+uno::Sequence aArgs{ uno::Any(maTempFile.GetURL()) };
uno::Reference
xNameAccess(m_xSFactory->createInstanceWithArguments("com.sun.star.packages.zip.ZipFileAccess",
aArgs), uno::UNO_QUERY);
const css::uno::Sequence aNames(xNameAccess->getElementNames());
// The exported document must have three objects named ObjNNN. The names
are assigned in
diff --git a/sw/qa/extras/odfimport/odfimport.cxx
b/sw/qa/extras/odfimport/odfimport.cxx
index eeea54388ab8..49ebdbfdeba7 100644
--- a/sw/qa/extras/odfimport/odfimport.cxx
+++ b/sw/qa/extras/odfimport/odfimport.cxx
@@ -1278,7 +1278,7 @@ CPPUNIT_TEST_FIXTURE(Test, testVerticallyMergedCellBorder)
CPPUNIT_ASSERT(!rA2Set.GetBox().GetRight());
// Given this document model, when exporting to ODT:
-save("writer8", maTempFile);
+save("writer8");
mbExported = true;
// Then make sure the covered cell has a style.
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
index 337926c8dfb0..86fa7ea808a1 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
@@ -805,7 +805,7 @@ CPPUNIT_TEST_FIXTURE(SwModelTestBase, testTdf133771)
// Without the fix in place, this test would have failed with
// "An uncaught exception of type com.sun.star.io.IOException"
// exporting to docx
-save("Office Open XML Text", maTempFile);
+save("Office Open XML Text");
mbExported = true;
xmlDocUniquePtr pXmlDoc = parseExport("word/document.xml");
CPPUNIT_ASSERT(pXmlDoc);
@@ -823,7 +823,7 @@ CPPUNIT_TEST_FIXTURE(SwModelTestBase, testZeroLineSpacing)
xParagraph->setPropertyValue("ParaLineSpacing", uno::Any(aSpacing));
// Export to docx.
-save("Office Open XML Text", maTempFile);
+save("Office Open XML Text");
mbExported = true;
xmlDocUniquePtr pXmlDoc = parseExport("word/document.xml");
CPPUNIT_ASSERT(pXmlDoc);
@@ -851,7 +851,7 @@
[Libreoffice-bugs] [Bug 151509] Sidebar content disappearing with gtk3 backend
https://bugs.documentfoundation.org/show_bug.cgi?id=151509 Caolán McNamara changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | Status|NEW |ASSIGNED --- Comment #5 from Caolán McNamara --- I think the embedded frame that contains the non-native widgets used to backwards compatible support these external sidebar things is updating its geometry to be relative to the screen and it maybe for this case it should be relative to its its container or something of that nature. (move the window to make the sidebar as far left and top on the screen and still be visible and on clicking it should shift downwards and rightwards small enough to still be partially visible). Under wayland because we can't know the position on screen this code path is mostly disabled. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151880] New: CALC inserting new rows into conditional formatted column creates orphan and non-contiguous cell references
https://bugs.documentfoundation.org/show_bug.cgi?id=151880 Bug ID: 151880 Summary: CALC inserting new rows into conditional formatted column creates orphan and non-contiguous cell references Product: LibreOffice Version: 7.4.2.3 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: that.man.co...@gmail.com Description: In an auto-sorted array, where a column has a conditional format of 3 colours, orphan and non-contiguous array references appear in the format manager when additional rows are inserted into the array. The formatting is correct but the manager will show an orphan entry for the inserted cell(s) and the portions of the array which precede and follow the insert point will have two references excluding the orphan. Notably, the second portion will appear first followed by the first portion. Fortunately, the manager will permit the removal of the orphan and overwriting the non-contiguous references with a single contiguous reference. Many inserts will result in numerous orphans and "snippets" which do make a "joined up" chain. Steps to Reproduce: 1. Create a column with drag-filled dates and then make that an auto-filtered column 2. Conditionally format the array with three colours - it's fine to accept the defaults 3. Insert a row about midway and copy paste a cell from another location. It makes sense to copy a date firly well removed from the insert point 4. Bibisect the array a couple of times and repeat step 3 5. Observe that the FORMAT>CONDITIONAL>MANAGE facility will now list all the inserted cells as orphans together with a number of small ranges matching the number of inserts 6. Delete the orphans and edit one contiguous range 7. It doesn't crash anymore but it would be nice if you could fix it for me - Yesterday ;) Actual Results: The impact upon the colour rendition functions normally but following any number of inserts the process of assessing the range and implementing the colour rendition must take magnituides of processor cycles to assess "what is the range requiring this conditional format" Expected Results: One contiguous list in the Conditional Format Manager Reproducible: Always User Profile Reset: No Additional Info: Version: 7.3.6.2 (x64) / LibreOffice Community Build ID: c28ca90fd6e1a19e189fc16c05f8f8924961e12e CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: sv-SE (en_GB); UI: en-GB Calc: threaded And 7.4.2.3 on one of my other boxes which was specifically installed to test a related bug on the latest release. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: i18npool/source
i18npool/source/localedata/data/bg_BG.xml | 21 + i18npool/source/localedata/data/ca_ES.xml | 21 + i18npool/source/localedata/data/cs_CZ.xml | 21 + i18npool/source/localedata/data/da_DK.xml | 21 + i18npool/source/localedata/data/de_AT.xml | 21 + i18npool/source/localedata/data/de_CH.xml | 21 + i18npool/source/localedata/data/de_DE.xml | 21 + i18npool/source/localedata/data/de_LI.xml | 21 + i18npool/source/localedata/data/de_LU.xml | 21 + i18npool/source/localedata/data/el_GR.xml | 21 + i18npool/source/localedata/data/en_AU.xml | 24 i18npool/source/localedata/data/en_CA.xml | 24 i18npool/source/localedata/data/en_DK.xml | 24 i18npool/source/localedata/data/en_GB.xml | 24 i18npool/source/localedata/data/en_GH.xml | 24 i18npool/source/localedata/data/en_IE.xml | 15 ++- i18npool/source/localedata/data/en_JM.xml | 24 i18npool/source/localedata/data/en_NA.xml | 24 i18npool/source/localedata/data/en_ZA.xml | 24 i18npool/source/localedata/data/eo.xml|9 + i18npool/source/localedata/data/es_AR.xml | 21 + i18npool/source/localedata/data/es_BO.xml | 21 + i18npool/source/localedata/data/es_CL.xml | 21 + i18npool/source/localedata/data/es_CO.xml | 21 + i18npool/source/localedata/data/es_CR.xml | 21 + i18npool/source/localedata/data/es_DO.xml | 21 + i18npool/source/localedata/data/es_EC.xml | 21 + i18npool/source/localedata/data/es_ES.xml | 21 + i18npool/source/localedata/data/es_GT.xml | 21 + i18npool/source/localedata/data/es_PE.xml | 21 + i18npool/source/localedata/data/es_SV.xml | 21 + i18npool/source/localedata/data/et_EE.xml | 21 + i18npool/source/localedata/data/fi_FI.xml | 21 + i18npool/source/localedata/data/fr_BE.xml | 21 + i18npool/source/localedata/data/fr_BF.xml | 21 + i18npool/source/localedata/data/fr_CA.xml | 21 + i18npool/source/localedata/data/fr_CH.xml | 21 + i18npool/source/localedata/data/fr_FR.xml | 21 + i18npool/source/localedata/data/fr_LU.xml | 21 + i18npool/source/localedata/data/fr_TG.xml | 21 + i18npool/source/localedata/data/gl_ES.xml | 21 + i18npool/source/localedata/data/he_IL.xml | 21 + i18npool/source/localedata/data/hr_HR.xml | 21 + i18npool/source/localedata/data/hu_HU.xml | 21 + i18npool/source/localedata/data/id_ID.xml | 21 + i18npool/source/localedata/data/is_IS.xml | 21 + i18npool/source/localedata/data/it_CH.xml | 21 + i18npool/source/localedata/data/it_IT.xml | 21 + i18npool/source/localedata/data/lb_LU.xml | 21 + i18npool/source/localedata/data/lg_UG.xml | 21 + i18npool/source/localedata/data/lt_LT.xml | 21 + i18npool/source/localedata/data/lv_LV.xml | 21 + i18npool/source/localedata/data/mt_MT.xml |9 + i18npool/source/localedata/data/nl_BE.xml | 21 + i18npool/source/localedata/data/nl_NL.xml | 21 + i18npool/source/localedata/data/no_NO.xml | 21 + i18npool/source/localedata/data/pl_PL.xml | 21 + i18npool/source/localedata/data/pt_AO.xml | 21 + i18npool/source/localedata/data/pt_BR.xml | 21 + i18npool/source/localedata/data/pt_PT.xml | 21 + i18npool/source/localedata/data/ro_RO.xml | 21 + i18npool/source/localedata/data/ru_RU.xml | 21 + i18npool/source/localedata/data/sl_SI.xml | 21 + i18npool/source/localedata/data/sr_RS.xml |9 + i18npool/source/localedata/data/sv_FI.xml | 21 + i18npool/source/localedata/data/sv_SE.xml | 21 + i18npool/source/localedata/data/tr_TR.xml | 21 + i18npool/source/localedata/data/uk_UA.xml | 21 + i18npool/source/localedata/data/vi_VN.xml |9 + 69 files changed, 1418 insertions(+), 1 deletion(-) New
[Libreoffice-commits] core.git: chart2/qa cui/source i18npool/source sc/qa svl/source svx/source
chart2/qa/extras/chart2dump/reference/chartdatatest/simple_chart.txt |2
cui/source/tabpages/numfmt.cxx | 10 +
i18npool/source/localedata/data/en_US.xml| 24
i18npool/source/nativenumber/nativenumbersupplier.cxx| 18 ++-
sc/qa/uitest/calc_tests/formatCells.py | 59
++
svl/source/numbers/zformat.cxx | 38
++
svx/source/items/numfmtsh.cxx| 12 +-
7 files changed, 157 insertions(+), 6 deletions(-)
New commits:
commit 2a1d2d42af7f365330479f4032ddfdd9eeba7c1d
Author: László Németh
AuthorDate: Thu Oct 27 08:36:37 2022 +0200
Commit: László Németh
CommitDate: Thu Nov 3 22:20:36 2022 +0100
tdf#115007 add NatNum12 number format list items, fix title case
Add NumberText NatNum12 number formats, e.g. "One Hundred",
and currency formats, e.g. "One U.S. Dollar and Twenty Cents"
to number formatting dialog windows, i.e. Format Cells->Numbers
in Calc and Format Numbers in Writer (Edit Fields->Format->
Additional formats...).
Fix also bad English title case:
"One Euro *and* *Twenty-Two* cents" (not *And* and *Twenty-two*)
Details:
– svl: list NatNum12 NumberText currency codes in Currency
formats (i.e. after choosing Currency category).
– svx: Recognize bank symbol "CURRENCY" in NatNum12 parameters
defined in locale resource files. For example,
"[NatNum12 CURRENCY]" is converted to "[NatNum12 USD]" in
the number format dialog windows, using bank symbol of
the current locale settings.
Recognize compatible (old) bank symbol "CCC" in NatNum12
parameters defined in locale resource files. For example,
"[NatNum12 CCC]" is converted to "[NatNum12 DEM]" in
the number format dialog windows, using bank symbol of
the compatible currency of the German locale settings.
User-defined formats with arbitrary bank codes are
recognized as currency formats, e.g. modifying
"[NatNum12 USD]" to "[NatNum12 EUR]" in the dialog window
results a new currency format item.
– i18npool/*en_US.xml: define four Standard NatNum12 formats
(lower case, sentence case, title case, upper case) and
four Currency NatNum12 formats (title case, title case with
digits, upper case, upper case with digits).
– cui: use lower sample numbers for spell out formats:
– 100 for Standard:
One Hundred
one hundred
One hundred
ONE HUNDRED
– 1.2 for Currency:
One U.S. Dollar
ONE U.S. DOLLAR
One U.S. Dollar and Twenty Cents
ONE U.S. DOLLAR AND TWENTY CENTS
– i18npool: fix English title casing of NatNum12 conversions:
– Don't apply casing on "and", according to the title
case rules, for example:
"One Euro and One Cent" instead of
"One Euro And One Cent".
– Apply casing on the second element of the hyphenated
compound words:
"Twenty-One" instead of the bad "Twenty-one".
– add unit test for extended Number and Currency categories.
Note: according to the changes, update user-defined number format id in
chart2/qa/extras/chart2dump/reference/chartdatatest/simple_chart.txt
Change-Id: Ieaf9a8f75a4f197b858eaf67f83484df70295834
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141994
Tested-by: Jenkins
Reviewed-by: László Németh
diff --git
a/chart2/qa/extras/chart2dump/reference/chartdatatest/simple_chart.txt
b/chart2/qa/extras/chart2dump/reference/chartdatatest/simple_chart.txt
index 28a125d7a5ed..ec3bfa72e397 100644
--- a/chart2/qa/extras/chart2dump/reference/chartdatatest/simple_chart.txt
+++ b/chart2/qa/extras/chart2dump/reference/chartdatatest/simple_chart.txt
@@ -11,7 +11,7 @@ Quarter
// sYAxisTitle
Income (Ft)
// nYAxisNumberFormat
-151
+159
// nYAxisNumberType
17
// aColumnLabels.getLength()
diff --git a/cui/source/tabpages/numfmt.cxx b/cui/source/tabpages/numfmt.cxx
index ee6d949353a0..54b5b53d9aac 100644
--- a/cui/source/tabpages/numfmt.cxx
+++ b/cui/source/tabpages/numfmt.cxx
@@ -1665,6 +1665,16 @@ OUString SvxNumberFormatTabPage::GetExpColorString(
}
double fVal = fSvxNumValConst[i];
+// use lower number for long NatNum12 transliteration
+if ( ( CAT_CURRENCY == nTmpCatPos || CAT_NUMBER == nTmpCatPos ) &&
+ rFormatStr.indexOf("NatNum12") >= 0 )
+{
+if ( CAT_CURRENCY == nTmpCatPos )
+fVal = 1.2;
+else
+fVal = 100; // show also title case for English: One Hundred
+}
+
OUString aPreviewString;
pNumFmtShell->MakePrevStringFromVal( rFormatStr, aPreviewString,
rpPreviewColor, fVal );
return aPreviewString;
diff --git
[Libreoffice-bugs] [Bug 151692] UI for controlling elements visible in animations list entry
https://bugs.documentfoundation.org/show_bug.cgi?id=151692 --- Comment #5 from Telesto --- (In reply to Heiko Tietze from comment #3) > I also doubt that many users have very small screens There where quite some changes to adapt dialogs to small/low resolution screens :-). And what do you call a small screen. I find the animation list already 'small' using a 23 inch, 1920x1080 screen. Presentations are often run from notebooks: even smaller screen dimensions, say: 15,6 inch > I also doubt that many users uses more than 10 animations per slide so often. * With fresh profile, default UI design, I can have 8 animations in a list without scrollbar. * We really need to establish some baseline how many animations a slide being to expected, and to be accounted for while design the UI. A example illustrating animations adding up: attachment 183294. And I have surely encountered more of these in the bugtracker in the past. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/source
sc/source/ui/view/gridwin.cxx | 61 +-
1 file changed, 2 insertions(+), 59 deletions(-)
New commits:
commit 142d3e15916afd1c38bcccf0d23cac292ea357fc
Author: Jan Holesovsky
AuthorDate: Mon Oct 24 16:27:17 2022 +0200
Commit: Jan Holesovsky
CommitDate: Thu Nov 3 21:52:40 2022 +0100
sc lok: Double-click should behave more like on desktop
When editing was introduced in Calc LibreOfficeKit, there were lots of
limitations. Particularly the thinking was that it would be good if a
double-click into any text (even if spanning over more cells)
actually started editing that text.
These days, the LOK behaves much more consistently, so it is better to
behave as the LibreOffice on desktop (or other tools, like gdocs) do:
If the cell:
* Is empty
-> single click places the cell cursor
-> double click places the cell cursor & shows the text caret
* Is empty, but covered by text bleeding from other cell
-> same as if it was empty
* Isn't empty
-> single click places the cell cursor
-> double click places the cell cursor & places the text caret
inside the text where the user clicked
+ this is actually different in gdocs - there the caret is
placed at the end of the text; in LO it is where the user has
double-clicked
Change-Id: Ib5884f887c98f803b06d8bed5057ec435be480ef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142196
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky
diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 69a1daf6f9ce..1ae16dd962aa 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -1833,49 +1833,6 @@ void ScGridWindow::HandleMouseButtonDown( const
MouseEvent& rMEvt, MouseEventSta
if ( !nButtonDown || !bDouble ) // single (first) click is
always valid
nButtonDown = rMEvt.GetButtons(); // set nButtonDown first, so
StopMarking works
-// special handling of empty cells with tiled rendering
-if (bIsTiledRendering)
-{
-Point aPos(rMEvt.GetPosPixel());
-SCCOL nPosX, nNonEmptyX(0);
-SCROW nPosY;
-SCTAB nTab = mrViewData.GetTabNo();
-mrViewData.GetPosFromPixel(aPos.X(), aPos.Y(), eWhich, nPosX, nPosY);
-
-ScRefCellValue aCell(rDoc, ScAddress(nPosX, nPosY, nTab));
-bool bIsEmpty = aCell.isEmpty();
-bool bIsCoveredByText = bIsEmpty && IsCellCoveredByText(nPosX, nPosY,
nTab, nNonEmptyX);
-
-if (bIsCoveredByText)
-{
-// if there's any text flowing to this cell, activate the
-// editengine, so that the text actually gets the events
-if (bDouble)
-{
-ScViewFunc* pView = mrViewData.GetView();
-
-pView->SetCursor(nNonEmptyX, nPosY);
-SC_MOD()->SetInputMode(SC_INPUT_TABLE);
-
-bEditMode = mrViewData.HasEditView(eWhich);
-assert(bEditMode);
-
-// synthesize the 1st click
-EditView* pEditView = mrViewData.GetEditView(eWhich);
-MouseEvent aEditEvt(rMEvt.GetPosPixel(), 1,
MouseEventModifiers::SYNTHETIC, MOUSE_LEFT, 0);
-pEditView->MouseButtonDown(aEditEvt);
-pEditView->MouseButtonUp(aEditEvt);
-}
-}
-else if (bIsEmpty && bEditMode && bDouble)
-{
-// double-click in an empty cell: the entire cell is selected
-SetCellSelectionPixel(LOK_SETTEXTSELECTION_START, aPos.X(),
aPos.Y());
-SetCellSelectionPixel(LOK_SETTEXTSELECTION_END, aPos.X(),
aPos.Y());
-return;
-}
-}
-
if ( ( bEditMode && mrViewData.GetActivePart() == eWhich ) ||
!bFormulaMode )
GrabFocus();
@@ -2406,14 +2363,11 @@ void ScGridWindow::MouseButtonUp( const MouseEvent&
rMEvt )
mrViewData.GetPosFromPixel( aPos.X(), aPos.Y(), eWhich, nPosX, nPosY );
ScDPObject* pDPObj = rDoc.GetDPAtCursor( nPosX, nPosY, nTab );
-bool bInDataPilotTable = (pDPObj != nullptr);
-
// double click (only left button)
-// in the tiled rendering case, single click works this way too
bool bIsTiledRendering = comphelper::LibreOfficeKit::isActive();
bool bDouble = ( rMEvt.GetClicks() == 2 && rMEvt.IsLeft() );
-if ((bDouble || (bIsTiledRendering && !bInDataPilotTable))
+if ( bDouble
&& !bRefMode
&& (nMouseStatus == SC_GM_DBLDOWN || (bIsTiledRendering &&
nMouseStatus != SC_GM_URLDOWN))
&& !pScMod->IsRefDialogOpen())
@@ -2473,19 +2427,8 @@ void ScGridWindow::MouseButtonUp( const MouseEvent&
rMEvt )
bEditAllowed = false;
}
-// We don't want to activate the edit view for a single click in tiled
rendering
-//
[Libreoffice-bugs] [Bug 143049] Crash in: ScDocument::GetPool()
https://bugs.documentfoundation.org/show_bug.cgi?id=143049 raal changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME --- Comment #19 from raal --- Thanks for testing. About condition formatting, please see meta bug 87351. You can still open new bug about "creating orphan and non-contiguous ranges in the manager still exists". -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151692] UI for controlling elements visible in animations list entry
https://bugs.documentfoundation.org/show_bug.cgi?id=151692 --- Comment #4 from Eyal Rozenberg --- (In reply to Heiko Tietze from comment #3) > This topic has been reported multiple times now. And I still disagree with > less information (happy to help on bug 151377 with a collapsible section). That bug is about a different part of the animation side-bar, not the list of animation effects. > I also doubt that many users have very small screens and uses more than 10 > animations per slide so often. Users using animation effects have over 10 effects per slide quite often. Just a gradual entrance and a single transformation for, say, 4 objects gets you to 8. If you have a couple of paragraphs of text as well you're at 10 for just the appearance. But many many people's laptops aren't 1920-pixels tall. On my laptop, it's 768 pixels. > Thing is that you save the second line by adding the effect on the first. If > you drop the object type you rely on the naming (or get just numbers) and > putting the effect info behind makes the list hard to read and likely > overflow. You are right, in the sense that certain changes might be a disservice to some users, while for others, the compact lines are an absolute must. And that's exactly why the user should be able to _control_ what they see in the animation list. A one-size-fits-all solution is not the right choice here. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151509] Sidebar content disappearing with gtk3 backend
https://bugs.documentfoundation.org/show_bug.cgi?id=151509 Caolán McNamara changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #4 from Caolán McNamara --- oddly works with wayland backend but not x11 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151879] Opening a Base document a second time with macro executed after view has been created gives error message - no macro executed any more
https://bugs.documentfoundation.org/show_bug.cgi?id=151879 Robert Großkopf changed: What|Removed |Added Keywords||regression Version|7.4.2.3 release |7.4.0.3 release --- Comment #1 from Robert Großkopf --- Macro appears also with Version: 7.4.0.3 / LibreOffice Community Build ID: f85e47c08ddd19c015c0114a68350214f7066f5a CPU threads: 6; OS: Linux 5.3; UI render: default; VCL: kf5 (cairo+xcb) Locale: de-DE (de_DE.UTF-8); UI: en-US Calc: threaded on OpenSUSE 15.3 64bit rpm Linux. Seems it has ben introduced with LO 7.4 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151879] New: Opening a Base document a second time with macro executed after view has been created gives error message - no macro executed any more
https://bugs.documentfoundation.org/show_bug.cgi?id=151879 Bug ID: 151879 Summary: Opening a Base document a second time with macro executed after view has been created gives error message - no macro executed any more Product: LibreOffice Version: 7.4.2.3 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rob...@familiegrosskopf.de Created attachment 183397 --> https://bugs.documentfoundation.org/attachment.cgi?id=183397=edit Open the database. Macro will be executed. Close and open it again … Open the attached database. A macro will be executed. First there is a messagebox, which shows: The macro has started and tries to open a form. Then a form will be opened. Close the form. Close the Base file. Open the Base file again. Instead of executing the macro appears an Error: com.sun.star.lang.DisposedException: Component is already disposed. at /home/buildslave/source/libo-core/dbaccess/source/core/inc/ModelImpl.hxx:471 This buggy behavior appears in LO 7.4.2.3. It doesn't appear in LO 7.3.6.2 and earlier versions of LO. So a regression. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151873] Writer doc crashes when scrolling document
https://bugs.documentfoundation.org/show_bug.cgi?id=151873 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #3 from m.a.riosv --- Please test in safe mode, Menu/Help/Restart in Safe Mode -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151878] LibreCalc buttons change color, horizontal lines from the top and bottoms of buttons radiate across a background image and buttons briefly appear and disappear in the w
https://bugs.documentfoundation.org/show_bug.cgi?id=151878 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from m.a.riosv --- Please test in safe mode, Menu/Help/Restart in Safe Mode -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151876] Slow Chart Render open, cpu spike, and view if data point is more than 1000 data point in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=151876 Telesto changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #3 from Telesto --- A flamegraph would be nice -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151876] Slow Chart Render open, cpu spike, and view if data point is more than 1000 data point in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=151876 Telesto changed: What|Removed |Added Keywords||perf CC||tele...@surfxs.nl Version|7.4.2.3 release |7.1.0.1 rc OS|Linux (All) |All --- Comment #2 from Telesto --- Confirm slowness with Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 9cd0f4c2d25462feba0ffcbd906c199273821243 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL threaded and with 7.1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103182 Bug 103182 depends on bug 149932, which changed state. Bug 149932 Summary: When using ibus input methods, the underlining style set by the input method is ignored in the gtk3 backend. https://bugs.documentfoundation.org/show_bug.cgi?id=149932 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/osx
vcl/osx/salframeview.mm |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 6c0ac70a512c1789d26721bd1f7d01a8b24fa718 Author: Caolán McNamara AuthorDate: Thu Nov 3 10:30:44 2022 + Commit: Caolán McNamara CommitDate: Thu Nov 3 20:48:53 2022 +0100 Related: tdf#149932 map NSUnderlineStyleDouble to new DoubleUnderline and NSUnderlineStyleThick to ExtTextInputAttr::BoldUnderline Change-Id: I66696cfd24ccd2cf02a2af63290419ac584079e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142224 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/vcl/osx/salframeview.mm b/vcl/osx/salframeview.mm index 07d3c08a2960..40a06ddd54ad 100644 --- a/vcl/osx/salframeview.mm +++ b/vcl/osx/salframeview.mm @@ -1578,10 +1578,10 @@ static AquaSalFrame* getMouseContainerFrame() aInputFlags[i] = ExtTextInputAttr::Underline; break; case NSUnderlineStyleThick: -aInputFlags[i] = ExtTextInputAttr::Underline | ExtTextInputAttr::Highlight; +aInputFlags[i] = ExtTextInputAttr::BoldUnderline; break; case NSUnderlineStyleDouble: -aInputFlags[i] = ExtTextInputAttr::BoldUnderline; +aInputFlags[i] = ExtTextInputAttr::DoubleUnderline; break; default: aInputFlags[i] = ExtTextInputAttr::Highlight;
[Libreoffice-commits] core.git: editeng/source include/vcl sw/source vcl/source vcl/unx
editeng/source/editeng/impedit3.cxx |2 ++
include/vcl/commandevent.hxx| 19 ++-
sw/source/core/text/redlnitr.cxx|2 ++
vcl/source/control/edit.cxx |2 ++
vcl/source/edit/texteng.cxx |2 ++
vcl/unx/gtk3/gtkframe.cxx | 13 +++--
6 files changed, 29 insertions(+), 11 deletions(-)
New commits:
commit d1cd19b56d5fefaa6f41a4d70e748331525820a4
Author: Caolán McNamara
AuthorDate: Thu Nov 3 10:21:59 2022 +
Commit: Caolán McNamara
CommitDate: Thu Nov 3 20:48:37 2022 +0100
Related: tdf#149932 honour PANGO_UNDERLINE_DOUBLE for preedit underline
we already have support for double underline so that's an easy add
Change-Id: I1bba5620038e396765bd79050ff6a520096f9476
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142223
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/editeng/source/editeng/impedit3.cxx
b/editeng/source/editeng/impedit3.cxx
index f932fd0df8ed..2d2a339658df 100644
--- a/editeng/source/editeng/impedit3.cxx
+++ b/editeng/source/editeng/impedit3.cxx
@@ -3061,6 +3061,8 @@ void ImpEditEngine::SeekCursor( ContentNode* pNode,
sal_Int32 nPos, SvxFont& rFo
ExtTextInputAttr nAttr = mpIMEInfos->pAttribs[ nPos -
mpIMEInfos->aPos.GetIndex() - 1 ];
if ( nAttr & ExtTextInputAttr::Underline )
rFont.SetUnderline( LINESTYLE_SINGLE );
+else if ( nAttr & ExtTextInputAttr::DoubleUnderline )
+rFont.SetUnderline( LINESTYLE_DOUBLE );
else if ( nAttr & ExtTextInputAttr::BoldUnderline )
rFont.SetUnderline( LINESTYLE_BOLD );
else if ( nAttr & ExtTextInputAttr::DottedUnderline )
diff --git a/include/vcl/commandevent.hxx b/include/vcl/commandevent.hxx
index d5b043ddb97a..fc6ba290793f 100644
--- a/include/vcl/commandevent.hxx
+++ b/include/vcl/commandevent.hxx
@@ -48,18 +48,19 @@ enum class CommandEventId;
enum class ExtTextInputAttr {
NONE = 0x,
-GrayWaveline = 0x0100,
-Underline = 0x0200,
-BoldUnderline = 0x0400,
-DottedUnderline = 0x0800,
-DashDotUnderline = 0x1000,
-Highlight = 0x2000,
-RedText = 0x4000,
-HalfToneText = 0x8000
+GrayWaveline = 0x0010,
+Underline = 0x0020,
+BoldUnderline = 0x0040,
+DottedUnderline = 0x0080,
+DashDotUnderline = 0x0100,
+DoubleUnderline = 0x0200,
+Highlight = 0x0400,
+RedText = 0x0800,
+HalfToneText = 0x1000
};
namespace o3tl
{
-template<> struct typed_flags :
is_typed_flags {};
+template<> struct typed_flags :
is_typed_flags {};
}
#define EXTTEXTINPUT_CURSOR_INVISIBLE (sal_uInt16(0x0001))
diff --git a/sw/source/core/text/redlnitr.cxx b/sw/source/core/text/redlnitr.cxx
index 2b8c11693d20..2b77d86aa350 100644
--- a/sw/source/core/text/redlnitr.cxx
+++ b/sw/source/core/text/redlnitr.cxx
@@ -1049,6 +1049,8 @@ void SwExtend::ActualizeFont( SwFont ,
ExtTextInputAttr nAttr )
{
if ( nAttr & ExtTextInputAttr::Underline )
rFnt.SetUnderline( LINESTYLE_SINGLE );
+else if ( nAttr & ExtTextInputAttr::DoubleUnderline )
+rFnt.SetUnderline( LINESTYLE_DOUBLE );
else if ( nAttr & ExtTextInputAttr::BoldUnderline )
rFnt.SetUnderline( LINESTYLE_BOLD );
else if ( nAttr & ExtTextInputAttr::DottedUnderline )
diff --git a/vcl/source/control/edit.cxx b/vcl/source/control/edit.cxx
index 1554f846ba95..a072a42ec467 100644
--- a/vcl/source/control/edit.cxx
+++ b/vcl/source/control/edit.cxx
@@ -639,6 +639,8 @@ void Edit::ImplRepaint(vcl::RenderContext& rRenderContext,
const tools::Rectangl
vcl::Font aFont = rRenderContext.GetFont();
if (nAttr & ExtTextInputAttr::Underline)
aFont.SetUnderline(LINESTYLE_SINGLE);
+else if (nAttr & ExtTextInputAttr::DoubleUnderline)
+aFont.SetUnderline(LINESTYLE_DOUBLE);
else if (nAttr & ExtTextInputAttr::BoldUnderline)
aFont.SetUnderline( LINESTYLE_BOLD);
else if (nAttr & ExtTextInputAttr::DottedUnderline)
diff --git a/vcl/source/edit/texteng.cxx b/vcl/source/edit/texteng.cxx
index 75d6085859e3..90140a58df11 100644
--- a/vcl/source/edit/texteng.cxx
+++ b/vcl/source/edit/texteng.cxx
@@ -1382,6 +1382,8 @@ void TextEngine::SeekCursor( sal_uInt32 nPara, sal_Int32
nPos, vcl::Font& rFont,
ExtTextInputAttr nAttr = mpIMEInfos->pAttribs[ nPos -
mpIMEInfos->aPos.GetIndex() - 1 ];
if ( nAttr & ExtTextInputAttr::Underline )
rFont.SetUnderline( LINESTYLE_SINGLE );
+else if ( nAttr & ExtTextInputAttr::DoubleUnderline )
+rFont.SetUnderline( LINESTYLE_DOUBLE );
else if ( nAttr & ExtTextInputAttr::BoldUnderline )
rFont.SetUnderline(
[Libreoffice-bugs] [Bug 138668] support image format AVIF import
https://bugs.documentfoundation.org/show_bug.cgi?id=138668 Buovjaga changed: What|Removed |Added CC||logan.sh...@gmail.com --- Comment #14 from Buovjaga --- (In reply to Logan Shire from comment #13) > Does Apple and/or WebKit not support these types of AVIF images? Is the set > of allowed encodings documented somewhere? Or is this a bug? As you say yourself, in Safari they are supported on macOS Ventura. Check the caniuse page, still no support in Edge. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151866] Crash swlo!SwFrame::GetPrevSctLeaf+0x52d: on CTRL+X
https://bugs.documentfoundation.org/show_bug.cgi?id=151866 raal changed: What|Removed |Added CC||r...@post.cz --- Comment #6 from raal --- No crash Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: cfc8a8f5d841b3f84d207196153be67da7f60652 CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151869] Freeze deleting an image with Track Changes Record ON
https://bugs.documentfoundation.org/show_bug.cgi?id=151869 raal changed: What|Removed |Added Regression By||Jim Raykowski Keywords|bibisectRequest |bibisected, bisected CC||r...@post.cz, ||rayk...@gmail.com --- Comment #5 from raal --- This seems to have begun at the below commit. Adding Cc: to Jim Raykowski ; Could you possibly take a look at this one? Thanks >From this commit LO crash after delete d267c44c1503c7f93a83d60d3ec4a2bb6a1278f2 is the first bad commit commit d267c44c1503c7f93a83d60d3ec4a2bb6a1278f2 Author: Jenkins Build User Date: Fri May 14 06:18:42 2021 +0200 source sha:6b09276d157abada74e1a4989700139167207778 https://git.libreoffice.org/core/+/6b09276d157abada74e1a4989700139167207778 >From this commit LO freeze after delete d715c2f7fdacdba9480311099068fd21259610f0 is the first bad commit commit d715c2f7fdacdba9480311099068fd21259610f0 Author: Jenkins Build User Date: Wed Aug 11 15:28:34 2021 +0200 source sha:d3f5f1b0068b8ab57f7aae9588cc0cff4af1db54 https://git.libreoffice.org/core/+/d3f5f1b0068b8ab57f7aae9588cc0cff4af1db54 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142446] In folding outlines, enable specifying, document-wide, the level to which text should be collapsed.
https://bugs.documentfoundation.org/show_bug.cgi?id=142446 --- Comment #17 from Commit Notification --- Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/be2cd4bcc4e55b9fe6e5fcd6276511d37f3f8e4c tdf#142446 Improve show outline content to level It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/inc/wrtsh.hxx|2
sw/source/uibase/wrtsh/wrtsh1.cxx | 95 ++
2 files changed, 47 insertions(+), 50 deletions(-)
New commits:
commit be2cd4bcc4e55b9fe6e5fcd6276511d37f3f8e4c
Author: Jim Raykowski
AuthorDate: Thu Nov 3 02:53:34 2022 -0800
Commit: Jim Raykowski
CommitDate: Thu Nov 3 20:09:37 2022 +0100
tdf#142446 Improve show outline content to level
by reworking the MakeOutlineLevelsVisible function
Change-Id: I0a102420475ed97e35b8f92315eaa4cca2958599
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142226
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
diff --git a/sw/source/uibase/inc/wrtsh.hxx b/sw/source/uibase/inc/wrtsh.hxx
index ebc255d3b05e..61f4570a71ab 100644
--- a/sw/source/uibase/inc/wrtsh.hxx
+++ b/sw/source/uibase/inc/wrtsh.hxx
@@ -501,7 +501,7 @@ typedef bool (SwWrtShell::*FNSimpleMove)();
void InsertPostIt(SwFieldMgr& rFieldMgr, const SfxRequest& rReq);
bool IsOutlineContentVisible(const size_t nPos);
-void MakeOutlineContentVisible(const size_t nPos, bool bMakeVisible =
true);
+void MakeOutlineContentVisible(const size_t nPos, bool bMakeVisible =
true, bool bSetAttrOutlineVisibility = true);
void MakeAllFoldedOutlineContentVisible(bool bMakeVisible = true);
void InvalidateOutlineContentVisibility();
bool GetAttrOutlineContentVisible(const size_t nPos);
diff --git a/sw/source/uibase/wrtsh/wrtsh1.cxx
b/sw/source/uibase/wrtsh/wrtsh1.cxx
index 9bf10af5ce2a..9ca81b72b4cd 100644
--- a/sw/source/uibase/wrtsh/wrtsh1.cxx
+++ b/sw/source/uibase/wrtsh/wrtsh1.cxx
@@ -2360,59 +2360,53 @@ bool SwWrtShell::IsOutlineContentVisible(const size_t
nPos)
void SwWrtShell::MakeOutlineLevelsVisible(const int nLevel)
{
+MakeAllOutlineContentTemporarilyVisible a(GetDoc());
+
m_rView.SetMaxOutlineLevelShown(nLevel);
bool bDocChanged = false;
-const SwNodes& rNodes = GetNodes();
-const SwOutlineNodes& rOutlineNodes = rNodes.GetOutLineNds();
+const SwOutlineNodes& rOutlineNodes = GetNodes().GetOutLineNds();
-StartAction();
+// Make all missing frames.
for (SwOutlineNodes::size_type nPos = 0; nPos < rOutlineNodes.size();
++nPos)
{
SwNode* pNode = rOutlineNodes[nPos];
-auto nOutlineLevel = pNode->GetTextNode()->GetAttrOutlineLevel();
-if ( nOutlineLevel > nLevel)
+if (!pNode->GetTextNode()->getLayoutFrame(GetLayout()))
{
-// MakeOutlineContentVisible(nPos, false) sets the outline node
outline content
-// visible attribute false so it needs restored to true if it was
true.
-bool bOutlineContentVisible = false;
-
pNode->GetTextNode()->GetAttrOutlineContentVisible(bOutlineContentVisible);
-MakeOutlineContentVisible(nPos, false);
-pNode->GetTextNode()->DelFrames(GetLayout());
-if (bOutlineContentVisible)
-pNode->GetTextNode()->SetAttrOutlineContentVisible(true);
+SwNodeIndex aIdx(*pNode, +1);
+// Make the outline paragraph frame
+MakeFrames(GetDoc(), *pNode, aIdx.GetNode());
+// Make the outline content visible but don't set the outline
visible attribute and
+// don't make outline content made visible not visible that have
outline visible
+// attribute false. Visibility will be taken care of when
+// MakeAllOutlineContentTemporarilyVisible goes out of scope.
+MakeOutlineContentVisible(nPos, true, false);
bDocChanged = true;
}
-else
+}
+// Remove outline paragraph frame and outline content frames above given
level.
+for (SwOutlineNodes::size_type nPos = 0; nPos < rOutlineNodes.size();
++nPos)
+{
+SwNode* pNode = rOutlineNodes[nPos];
+auto nOutlineLevel = pNode->GetTextNode()->GetAttrOutlineLevel();
+if (nOutlineLevel > nLevel)
{
-if (!pNode->GetTextNode()->getLayoutFrame(GetLayout()))
-{
-SwNodeIndex aIdx(*pNode, +1);
-{
-// MakeAllOutlineContentTemporarilyVisible in this scope!
Don't place at the
-// start of the function. Placed there will restore
content to what it was
-// was at that point when the function exits.
-MakeAllOutlineContentTemporarilyVisible a(GetDoc());
-MakeFrames(GetDoc(), *pNode, aIdx.GetNode());
-}
-bool bVisible = true;
-if (GetViewOptions()->IsShowOutlineContentVisibilityButton())
-
pNode->GetTextNode()->GetAttrOutlineContentVisible(bVisible);
-if (bVisible)
-MakeOutlineContentVisible(nPos, true);
-bDocChanged = true;
-}
+// Remove the outline content but don't set the outline visible
Re: LibreOffice Source File Compile Help
Hello Siddharth, You can cd from the core directory to instdir/program and then do ./soffice.bin or from the core directory ./instdir/program/soffice.bin should work. HTH, Jim On Thu, Nov 3, 2022 at 10:33 AM Siddharth Khattar wrote: > Hello all, > > So I recently compiled LibreOffice from source files. Can somebody please > tell me how can I access this development version of LibreOffice from the > bash terminal & also why can't I see it as an installed application when I > click "show applications"? I am a beginner to this so if I am missing > something extremely obvious please guide me. I also studied on the webpage > : https://wiki.documentfoundation.org/Development/Environment_variables > But when I tried the bash command given there ( using export ), It didn't > work on my computer and showed and error message. > > For reference, I am using Linux Ubuntu. Thanks in advance for > reading/answering my question! >
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - sfx2/source
sfx2/source/doc/objstor.cxx | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
New commits:
commit 17bf69ba9d8168106162d1a4ddef7cb34d50fe73
Author: Henry Castro
AuthorDate: Thu Nov 3 10:52:16 2022 -0400
Commit: Aron Budea
CommitDate: Thu Nov 3 19:47:05 2022 +0100
sfx2: add log information to catch the exception
Add log information for data analysis if the ExportTo
fails due to an exception.
Signed-off-by: Henry Castro
Change-Id: I888545da14f413a970faf50b3ce60d12966f3f9e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142202
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Aron Budea
diff --git a/sfx2/source/doc/objstor.cxx b/sfx2/source/doc/objstor.cxx
index cee35fc3443c..e657ca6dad1c 100644
--- a/sfx2/source/doc/objstor.cxx
+++ b/sfx2/source/doc/objstor.cxx
@@ -2486,8 +2486,19 @@ bool SfxObjectShell::ExportTo( SfxMedium& rMedium )
}
return xFilter->filter( aArgs );
-}catch(...)
-{}
+}
+catch (const css::uno::RuntimeException & e)
+{
+SAL_INFO("sfx.doc", "ExportTo: " << e);
+}
+catch (const std::exception & e)
+{
+SAL_INFO("sfx.doc", "ExportTo: " << e.what());
+}
+catch(...)
+{
+SAL_INFO("sfx.doc", "ExportTo: Unknown exception!");
+}
}
return false;
[Libreoffice-commits] core.git: oox/source
oox/source/export/drawingml.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit dc9ebcbfd28b417189c94ad6d7492928e2cfd43e
Author: Andrea Gelmini
AuthorDate: Thu Nov 3 18:07:04 2022 +0100
Commit: Julien Nabet
CommitDate: Thu Nov 3 19:35:59 2022 +0100
Fix typo
Change-Id: I73fec7b8634704a8ceedf7a1be6eacd4dafc06e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142249
Tested-by: Julien Nabet
Reviewed-by: Julien Nabet
diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx
index 80d38e8dfc79..7c996be1d892 100644
--- a/oox/source/export/drawingml.cxx
+++ b/oox/source/export/drawingml.cxx
@@ -3352,7 +3352,7 @@ void DrawingML::WriteText(const Reference&
rXIface, bool bBodyPr, bo
if (nTop + nBottom >= nTextHeight)
{
// Effective bottom would be above effective top of text area. LO
normalizes the
-// effective text area in such case implicitely for rendering. MS
needs indents so that
+// effective text area in such case implicitly for rendering. MS
needs indents so that
// the result is the normalized effective text area.
std::swap(nTop, nBottom);
nTop = nTextHeight - nTop;
[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/ooxmlexport/ooxmlexport18.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 46f00c710f6deb59f369dd6736693e133e51f05f
Author: Andrea Gelmini
AuthorDate: Thu Nov 3 18:05:41 2022 +0100
Commit: Julien Nabet
CommitDate: Thu Nov 3 19:34:58 2022 +0100
Fix typo
Change-Id: If6bfabcfb1f9bc653b72c3775cdeaa91e0058fe0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142248
Tested-by: Julien Nabet
Reviewed-by: Julien Nabet
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
index 867fdca9c8e6..d336625159a5 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
@@ -148,7 +148,7 @@ CPPUNIT_TEST_FIXTURE(Test, testTdf150966_regularInset)
// That should result in tIns="179640" and bIns="36" on export.
// Without fix the insets were tIns="359280" and bIns="539640". The text
area had 1080Emu height
-// and Word displayes no text at all.
+// and Word displays no text at all.
save("Office Open XML Text", maTempFile);
mbExported = true;
xmlDocUniquePtr pXmlDoc = parseExport("word/document.xml");
LibreOffice Source File Compile Help
Hello all, So I recently compiled LibreOffice from source files. Can somebody please tell me how can I access this development version of LibreOffice from the bash terminal & also why can't I see it as an installed application when I click "show applications"? I am a beginner to this so if I am missing something extremely obvious please guide me. I also studied on the webpage : https://wiki.documentfoundation.org/Development/Environment_variables But when I tried the bash command given there ( using export ), It didn't work on my computer and showed and error message. For reference, I am using Linux Ubuntu. Thanks in advance for reading/answering my question!
[Libreoffice-bugs] [Bug 109527] [META] Spell check dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109527 Bug 109527 depends on bug 116566, which changed state. Bug 116566 Summary: Respect configured AutoSpellCheck colour in the dialog too https://bugs.documentfoundation.org/show_bug.cgi?id=116566 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142074] [META] Application Colours settings bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=142074 Bug 142074 depends on bug 116566, which changed state. Bug 116566 Summary: Respect configured AutoSpellCheck colour in the dialog too https://bugs.documentfoundation.org/show_bug.cgi?id=116566 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
