[Libreoffice-bugs] [Bug 152184] macOS: dark mode: Application Colors > Color Scheme should automatically follow System Settings > Appearance

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152184

Julien Nabet  changed:

   What|Removed |Added

 CC||caol...@redhat.com,
   ||serval2...@yahoo.fr

--- Comment #1 from Julien Nabet  ---
Caolán: as tdf#152183, thought you might be interested in this one since it
concerns dark mode in macOS

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152183] macOS: Dark Mode: change in System Settings > Appearance Light | Dark should automatically switch icon theme

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152183

Julien Nabet  changed:

   What|Removed |Added

 CC||caol...@redhat.com,
   ||serval2...@yahoo.fr

--- Comment #1 from Julien Nabet  ---
Caolán: thought you might be interested in this one since it concerns dark mode
in macOS

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152199] Image garbled after roundtrip

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152199

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Version|7.5.0.0 alpha0+ Master  |7.1.8.1 release
 Status|RESOLVED|VERIFIED

--- Comment #5 from Stéphane Guillou (stragu) 
 ---
Was already a problem in:

Version: 7.1.8.1 / LibreOffice Community
Build ID: e1f30c802c3269a1d052614453f260e49458c82c
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: de-DE (en_AU.UTF-8); UI: en-US
Calc: threaded

Fixed verified in build from today:

Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 24d7431876e87eba700a9f141dc8e030143a92ad
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Thanks Jan!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152083] Ligatures are incorrectly reversed opening RTL PDF files

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152083

--- Comment #3 from Commit Notification 
 ---
Kevin Suo committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3a2f0e4772e7b4646dd518b33aeafb6fd7025179

Resolves tdf#152083: Ligatures are incorrectly reversed in Draw pdf import

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152083] Ligatures are incorrectly reversed opening RTL PDF files

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152083

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.5.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sdext/source

2022-11-24 Thread Kevin Suo (via logerrit)
 sdext/source/pdfimport/test/tests.cxx|   11 ++---
 sdext/source/pdfimport/tree/drawtreevisiting.cxx |   46 ++-
 2 files changed, 49 insertions(+), 8 deletions(-)

New commits:
commit 3a2f0e4772e7b4646dd518b33aeafb6fd7025179
Author: Kevin Suo 
AuthorDate: Sun Nov 20 00:10:14 2022 +0800
Commit: Noel Grandin 
CommitDate: Fri Nov 25 08:44:02 2022 +0100

Resolves tdf#152083: Ligatures are incorrectly reversed in Draw pdf import

For the string "بسم الله الرحمن الرحیم", the xpdfimport generates the 
following drawChar tokens:
drawChar 438.50 723.30 446.744000 723.30 1.00 0.00 
0.00 1.00 12.00 م
drawChar 446.696000 723.30 450.908000 723.30 1.00 0.00 
0.00 1.00 12.00 ی
drawChar 450.896000 723.30 458.804000 723.30 1.00 0.00 
0.00 1.00 12.00 ح
drawChar 458.792000 723.30 463.784000 723.30 1.00 0.00 
0.00 1.00 12.00 ر
drawChar 463.688000 723.30 467.048000 723.30 1.00 0.00 
0.00 1.00 12.00 ل
drawChar 467.072000 723.30 469.964000 723.30 1.00 0.00 
0.00 1.00 12.00 ا
drawChar 469.964000 723.30 473.708000 723.30 1.00 0.00 
0.00 1.00 12.00
drawChar 473.756000 723.30 482.78 723.30 1.00 0.00 
0.00 1.00 12.00 ن
drawChar 482.756000 723.30 490.028000 723.30 1.00 0.00 
0.00 1.00 12.00 م
drawChar 490.04 723.30 497.948000 723.30 1.00 0.00 
0.00 1.00 12.00 ح
drawChar 497.936000 723.30 502.928000 723.30 1.00 0.00 
0.00 1.00 12.00 ر
drawChar 502.928000 723.30 506.288000 723.30 1.00 0.00 
0.00 1.00 12.00 ل
drawChar 506.312000 723.30 509.204000 723.30 1.00 0.00 
0.00 1.00 12.00 ا
drawChar 509.108000 723.30 512.852000 723.30 1.00 0.00 
0.00 1.00 12.00
drawChar 512.90 723.30 527.216000 723.30 1.00 0.00 
0.00 1.00 12.00 الله
drawChar 527.204000 723.30 530.948000 723.30 1.00 0.00 
0.00 1.00 12.00
drawChar 530.996000 723.30 539.24 723.30 1.00 0.00 
0.00 1.00 12.00 م
drawChar 539.288000 723.30 552.02 723.30 1.00 0.00 
0.00 1.00 12.00 س
drawChar 551.888000 723.30 555.236000 723.30 1.00 0.00 
0.00 1.00 12.00 ب

Previously, all the above are combined to a single text frame in 
DrawXmlOptimizer::optimizeTextElements,
and then the text in the text frame is reversed (commit 
69e9925ded584113e52f84ef0ed7c224079fa061, and
further improved by commit 50d73574b6c3d71f9a539c895a15d6fcda22390b).

The problem is that, the single token "الله" was already in correct order. 
Thus when it is reversed
together with others, the order for itself would be wrong. Fix this by 
doing a pre-reverse.

The space char needs special treatment, as observed in 
tdf104597_textrun.pdf.

Change-Id: If0bd716cc2d68820436d0e3f0f161ffb9cb4397a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142978
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sdext/source/pdfimport/test/tests.cxx 
b/sdext/source/pdfimport/test/tests.cxx
index c199c2cc4547..7c10c85b29a5 100644
--- a/sdext/source/pdfimport/test/tests.cxx
+++ b/sdext/source/pdfimport/test/tests.cxx
@@ -798,15 +798,14 @@ namespace
 // Test for امُ عَلَيْكَ
 OString xpath = 
"string(//draw:frame[@draw:transform='matrix(917. 0 0 
917. 14821.958333 
2159.23861112778)']/draw:text-box/text:p/text:span)";
 OUString sContent = getXPathContent(pXmlDoc, xpath);
-CPPUNIT_ASSERT_EQUAL_MESSAGE(aOutput.getStr(), OUString(u"اُم 
َعَلْيَك"), sContent.replaceAll("\n\n", " ").replaceAll("\n", ""));
+CPPUNIT_ASSERT_EQUAL_MESSAGE(aOutput.getStr(), OUString(u"امُ 
عَلَيَْك"), sContent.replaceAll("\n\n", " ").replaceAll("\n", ""));
 
-// Test for ٱلسََّل . It appears in the 3rd frame, i.e. after the 
امُ عَلَيْكَ which is in the 2nd frame (from left to right)
+// Test for ٱلسََّل . It appears in the 3rd frame, i.e. after the 
امُ عَلَيَْك which is in the 2nd frame (from left to right)
 // thus these two frames together appear as ٱلسََّل امُ عَلَيْكَ 
in Draw‬.
 // FIXME: Should be ٱلسَّلَامُ عَلَيْكَ (i.e. the two text frames 
should be merged into one so that the ل and the ا will show as لَا rather than 
ل ا)
-// Note: this is commented due to ٱلسََّل is currently shown as 
ٱلَّسَل and will be fixed in a separate commit.
-//xpath = 
"string(//draw:frame[@draw:transform='matrix(917. 0 0 
917. 17420.17 

[Libreoffice-bugs] [Bug 108355] [META] Slide background bugs and enhancements

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108355
Bug 108355 depends on bug 108356, which changed state.

Bug 108356 Summary: FILESAVE: Master slide background image set as tiled when 
exporting to PPTX
https://bugs.documentfoundation.org/show_bug.cgi?id=108356

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139898] [META] PPTX Master slides / notes / handouts related issues

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139898
Bug 139898 depends on bug 108356, which changed state.

Bug 108356 Summary: FILESAVE: Master slide background image set as tiled when 
exporting to PPTX
https://bugs.documentfoundation.org/show_bug.cgi?id=108356

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/source

2022-11-24 Thread Miklos Vajna (via logerrit)
 sw/source/uibase/inc/frmpage.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit bfee63e502f341f0bd039189f2d7492529c4340a
Author: Miklos Vajna 
AuthorDate: Thu Nov 24 20:28:29 2022 +0100
Commit: Miklos Vajna 
CommitDate: Fri Nov 25 08:11:56 2022 +0100

sw: document SwFramePage

Which has nothing to with SwPageFrame. SwPageFrame is a page in the
layout, SwFramePage is a tab page in a dialog.

Change-Id: I4a88bcfb9e1aab541f099c4f6d84501610105f76
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143245
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sw/source/uibase/inc/frmpage.hxx b/sw/source/uibase/inc/frmpage.hxx
index 2f816348332c..2a6b280c68c6 100644
--- a/sw/source/uibase/inc/frmpage.hxx
+++ b/sw/source/uibase/inc/frmpage.hxx
@@ -34,7 +34,7 @@ struct FrameMap;
 // OD 12.11.2003 #i22341#
 struct SwPosition;
 
-// frame dialog
+/// This is the Position & Size tab page of the Insert -> Frame -> Frame 
dialog.
 class SwFramePage final : public SfxTabPage
 {
 boolm_bAtHorzPosModified;


[Libreoffice-commits] core.git: include/vcl vcl/source

2022-11-24 Thread Szymon Kłos (via logerrit)
 include/vcl/filter/PDFiumLibrary.hxx |3 +-
 vcl/source/filter/ipdf/pdfread.cxx   |   14 --
 vcl/source/pdf/PDFiumLibrary.cxx |   49 ++-
 3 files changed, 45 insertions(+), 21 deletions(-)

New commits:
commit a5c1cbcbb506e1c33c7e80673bfc01a34c834ed5
Author: Szymon Kłos 
AuthorDate: Mon Nov 21 15:23:59 2022 +0100
Commit: Szymon Kłos 
CommitDate: Fri Nov 25 08:01:20 2022 +0100

pdfium: reduce size if cannot create bitmap

In files with large pages it was rendering white, empty
content. That was because bitmap creation in the PDFium
failed. This reduces the size to possible value.

Signed-off-by: Szymon Kłos 
Change-Id: I093a6aff94104cdc8223d7b8cbc00ff9217021b8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143037
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143243
Tested-by: Jenkins

diff --git a/include/vcl/filter/PDFiumLibrary.hxx 
b/include/vcl/filter/PDFiumLibrary.hxx
index 7b319a727259..347b64619045 100644
--- a/include/vcl/filter/PDFiumLibrary.hxx
+++ b/include/vcl/filter/PDFiumLibrary.hxx
@@ -61,7 +61,8 @@ public:
  const OString& 
rPassword)
 = 0;
 virtual PDFErrorType getLastErrorCode() = 0;
-virtual std::unique_ptr createBitmap(int nWidth, int 
nHeight, int nAlpha) = 0;
+/// createBitmap can reduce requested size to possible value
+virtual std::unique_ptr createBitmap(int& nWidth, int& 
nHeight, int nAlpha) = 0;
 };
 
 class PDFiumPage;
diff --git a/vcl/source/filter/ipdf/pdfread.cxx 
b/vcl/source/filter/ipdf/pdfread.cxx
index 296e5ba69a5c..deb341157137 100644
--- a/vcl/source/filter/ipdf/pdfread.cxx
+++ b/vcl/source/filter/ipdf/pdfread.cxx
@@ -65,12 +65,10 @@ size_t RenderPDFBitmaps(const void* pBuffer, int nSize, 
std::vector& r
 
 // Returned unit is points, convert that to pixel.
 
-const size_t nPageWidth
-= std::round(vcl::pdf::pointToPixel(nPageWidthPoints, 
fResolutionDPI)
- * PDF_INSERT_MAGIC_SCALE_FACTOR);
-const size_t nPageHeight
-= std::round(vcl::pdf::pointToPixel(nPageHeightPoints, 
fResolutionDPI)
- * PDF_INSERT_MAGIC_SCALE_FACTOR);
+int nPageWidth = std::round(vcl::pdf::pointToPixel(nPageWidthPoints, 
fResolutionDPI)
+* PDF_INSERT_MAGIC_SCALE_FACTOR);
+int nPageHeight = std::round(vcl::pdf::pointToPixel(nPageHeightPoints, 
fResolutionDPI)
+ * PDF_INSERT_MAGIC_SCALE_FACTOR);
 std::unique_ptr pPdfBitmap
 = pPdfium->createBitmap(nPageWidth, nPageHeight, /*nAlpha=*/1);
 if (!pPdfBitmap)
@@ -97,12 +95,12 @@ size_t RenderPDFBitmaps(const void* pBuffer, int nSize, 
std::vector& r
 ConstScanline pPdfBuffer = pPdfBitmap->getBuffer();
 const int nStride = pPdfBitmap->getStride();
 std::vector aScanlineAlpha(nPageWidth);
-for (size_t nRow = 0; nRow < nPageHeight; ++nRow)
+for (int nRow = 0; nRow < nPageHeight; ++nRow)
 {
 ConstScanline pPdfLine = pPdfBuffer + (nStride * nRow);
 // pdfium byte order is BGRA.
 pWriteAccess->CopyScanline(nRow, pPdfLine, 
ScanlineFormat::N32BitTcBgra, nStride);
-for (size_t nCol = 0; nCol < nPageWidth; ++nCol)
+for (int nCol = 0; nCol < nPageWidth; ++nCol)
 {
 // Invert alpha (source is alpha, target is opacity).
 aScanlineAlpha[nCol] = ~pPdfLine[3];
diff --git a/vcl/source/pdf/PDFiumLibrary.cxx b/vcl/source/pdf/PDFiumLibrary.cxx
index ad2f3332bea9..9fa291898f8c 100644
--- a/vcl/source/pdf/PDFiumLibrary.cxx
+++ b/vcl/source/pdf/PDFiumLibrary.cxx
@@ -12,6 +12,7 @@
 
 #include 
 
+#include 
 #include 
 #include 
 #include 
@@ -466,7 +467,8 @@ public:
 std::unique_ptr openDocument(const void* pData, int nSize,
  const OString& rPassword) 
override;
 PDFErrorType getLastErrorCode() override;
-std::unique_ptr createBitmap(int nWidth, int nHeight, int 
nAlpha) override;
+/// @brief creates bitmap, can reduce size if needed, check nWidth and 
nHeight
+std::unique_ptr createBitmap(int& nWidth, int& nHeight, int 
nAlpha) override;
 };
 }
 
@@ -537,13 +539,36 @@ PDFErrorType PDFiumImpl::getLastErrorCode()
 return static_cast(FPDF_GetLastError());
 }
 
-std::unique_ptr PDFiumImpl::createBitmap(int nWidth, int 
nHeight, int nAlpha)
+std::unique_ptr PDFiumImpl::createBitmap(int& nWidth, int& 
nHeight, int nAlpha)
 {
 std::unique_ptr pPDFiumBitmap;
+
 FPDF_BITMAP pPdfBitmap = FPDFBitmap_Create(nWidth, nHeight, nAlpha);
+if (!pPdfBitmap)
+{
+int nOriginal = nHeight;
+// PDFium cannot create big 

[Libreoffice-bugs] [Bug 142446] In folding outlines, enable specifying, document-wide, the level to which text should be collapsed.

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142446

--- Comment #22 from Jim Raykowski  ---
(In reply to j.a.swami from comment #20)
> 2. When I issue a command that content should be expanded to more levels,
> the system sometimes responds a bit slowly. The lag is long enough to create
> uncertainty as to whether the command has been recognized or not.
Yes, for large files there can be significant delay when a large amount of
layout frames need to be remade. Are you testing with a full debug build or
perhaps a container version? These will have slower layout. 

> 3. It seems that specifying a content level greater than 3 has an
> inconsistent effect. Sometimes specifying "4" shows me level 4, sometimes
> not.
I haven't been able to repro this. Could you supply the steps to repro and
attach a test file that this happens?  

> 4. When content is collapsed to a certain level, I would have expected to
> see the "no-level" content beneath that level collapsed, consistently.
> Instead, it seems, such content is always shown, unless already collapsed
> manually with "toggle outline folding." This seems to me a less-desirable
> approach. 
>
> Imagine, for example, that I have a several-page hieararchical document,
> with some of the "no-level content" extending for several paragraphs (or
> even pages). Using "Show outline content to level" may or may not show me
> the actual bare-bones outline, depending on what I've previously done.
> 
> If I have previously collapsed some NL content but not all, expanding or
> contracting the outline will show me that NL content accordingly, in a
> manner that would seem to me inconsistent. That is, it would be consistent
> with my previous actions but inconsistent with what I'm now trying to do,
> namely view the whole outline at a certain level.
But doing this seems like it would make the feature just an on canvas copy of
what the Navigator Headings already does, which is, shows the actual bare-bones
outline.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135881] Support WOFF encoded fonts when used in SVG

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135881

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||8562

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108562] SVGIO: Add support for font feature settings in SVG

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108562

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||5881

--- Comment #10 from Stéphane Guillou (stragu) 
 ---
Note the example file uses a WOFF-encoded font in its CSS style. See also bug
135881.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 126008] TABLES STYLES: Inserting a row/column changes entire table's formatting (see comment 5)

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126008

Matt K  changed:

   What|Removed |Added

   Assignee|matt...@gmail.com   |libreoffice-b...@lists.free
   ||desktop.org

--- Comment #69 from Matt K  ---
(In reply to Dieter from comment #58)
> (In reply to Matt K from comment #49)
> > Fix is tracked in https://gerrit.libreoffice.org/c/core/+/137915.
> 
> Matt, are you still working on it? As far as I understand comments in
> gerrit, it isn't fixed. Since importance is highest, it would be nice to
> have an update about your work. If you're not longer working on it, please
> remove yourself as assignee. Thank you.

I'm no longer working on it.  My fix is simple for the simple situations (most
common?), but it seems additional behavior is wanted.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103596] Support OpenType variable font (OTVF) based text layout

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103596

--- Comment #33 from Volga  ---
(In reply to خالد حسني from comment #32)
> This should be fixed now. We support variable fonts and apply variations to
> text metrics and layout features properly. Support is currently limited to
> named instances, to support arbitrary font variations, we will need both UI
> support as well as file format support, so this should be tracked separately.

OK, go to bug 152206.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152206] New: Create interface to tweak font variation axis

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152206

Bug ID: 152206
   Summary: Create interface to tweak font variation axis
   Product: LibreOffice
   Version: 7.5.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: shanshandehongx...@outlook.com

Description:
After LibreOffice got support for variable fonts, the Character dialog should
also have specific interface to let user tweak values on font variation axis,
so any user would feel free to use variable fonts.

Steps to Reproduce:
N/A

Actual Results:
N/A

Expected Results:
This interface should be a separate dialog that is accessible via Character
dialog. While this is implemented, this dialog should display informations to
show which axis could be used, user can set value by either slider or input
box.


Reproducible: Always


User Profile Reset: No

Additional Info:
N/A

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 64679] [META] Printer settings related issues

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=64679

Michael Weghorn  changed:

   What|Removed |Added

URL|https://intellimindz.com/sc |
   |rum-master-training-in-chen |
   |nai/|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 151337] Can't change table row height without selecting the row

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151337

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 151337] Can't change table row height without selecting the row

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151337

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151338] When selecting a cell or table row/column, "Position & Size" regards entire table

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151338

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147692] FORMATTING Crash while formatting bullet point lists

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147692

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147692] FORMATTING Crash while formatting bullet point lists

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147692

--- Comment #3 from QA Administrators  ---
Dear Marcus Menzel,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145589] Crash in: SalInstanceTreeView::get_drag_source()

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145589

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145589] Crash in: SalInstanceTreeView::get_drag_source()

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145589

--- Comment #5 from QA Administrators  ---
Dear wolfgang.fech...@freenet.de,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142570] Saving ODP to PPT trashes character formats, saving to PPTX trashes pics

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142570

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142570] Saving ODP to PPT trashes character formats, saving to PPTX trashes pics

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142570

--- Comment #7 from QA Administrators  ---
Dear Nick Brown,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142482] Fuzzy menu bar and Can't recognize the characters and icons

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142482

--- Comment #6 from QA Administrators  ---
Dear forcek...@126.com,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142482] Fuzzy menu bar and Can't recognize the characters and icons

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142482

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149340] LibreOffice BASE crashes; LibreOffice no longer starts

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149340

--- Comment #2 from QA Administrators  ---
Dear LaVerne,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149347] Libre Office does not start

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149347

--- Comment #2 from QA Administrators  ---
Dear Daniela,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 77685] DOC/DOCX IMPORT: Wrong import of clipped OLE object in footer (missing functionality)

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=77685

--- Comment #9 from QA Administrators  ---
Dear Mike Kaganski,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 125307] PyUno wrongly converts Tuples of Strings

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125307

--- Comment #10 from QA Administrators  ---
Dear Thomas Viehmann,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142147] File->Save As: "Save with password" is deselected by default for password-protected documents

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142147

--- Comment #27 from Justin L  ---
(In reply to Tomaz Vajngerl from comment #13)
> Well, the use cases with "Save As" aren't simple at all. 
> So in general you have 3 possibilities if the document is password protected:
> - target document format doesn't support password protection
That is easy. The UI already disables password protection in this case.

> - target document format is different than source
That is easy. The UI already asks for a password.

> - target document format is the same as source -> no action needed - just
> use the same password
Or ask for a new password anyway. The UI already asks for a new password. I
think that makes sense anyway. No need to save with the same password in a
different file.

> But yeah - there is also password protected templates as you say. Do we want
> to save the documents with the same password as the template.
Definitely do not save the document with the template password. Thus ask the
user for a new password - same as case 3.

People are running on two different tracks in this bug report. The off-track
people are talking about bug 148416 - an open-as-read-only document that
requires a password to get into edit mode.

This bug report is talking about a file that needs a password in order to open.
For instance, attachment 178351 from bug 147491.

So the simple fix seems to be to just revert one line back to pre 7.0.
https://gerrit.libreoffice.org/c/core/+/143250

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152115] Hyperlink Target in document: The last user setting is not remembered

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152115

--- Comment #9 from Jim Raykowski  ---
Can anyone confirm the gtk3 only misbehavior mentioned in Comment 4 of the last
tree entry not being selected (highlighted) when the Target in document dialog
is reopened?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 152115] Hyperlink Target in document: The last user setting is not remembered

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152115

--- Comment #9 from Jim Raykowski  ---
Can anyone confirm the gtk3 only misbehavior mentioned in Comment 4 of the last
tree entry not being selected (highlighted) when the Target in document dialog
is reopened?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 152115] Hyperlink Target in document: The last user setting is not remembered

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152115

--- Comment #8 from Jim Raykowski  ---
(In reply to V Stuart Foote from comment #6)
> A selection from the tree view is retained (and is highlighted on Windwos),
> but the rest of the tree view has collapsed.  Think leaving it expanded is
> what the ask is.
Behavior has always been to only restore the last tree view selection when
possible. Introduced by commit d7d7b51c23a921803929f716a6554d869b1150a3.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 152115] Hyperlink Target in document: The last user setting is not remembered

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152115

--- Comment #8 from Jim Raykowski  ---
(In reply to V Stuart Foote from comment #6)
> A selection from the tree view is retained (and is highlighted on Windwos),
> but the rest of the tree view has collapsed.  Think leaving it expanded is
> what the ask is.
Behavior has always been to only restore the last tree view selection when
possible. Introduced by commit d7d7b51c23a921803929f716a6554d869b1150a3.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 146479] Use basegfx fTools for converting the angle unit

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146479

--- Comment #7 from Hossein  ---
(In reply to BogdanB from comment #6)
> (In reply to Hossein from comment #4)
> > Re-evaluating the EasyHack in 2022
> > 
> > This is still relevant, as there are many places in the code that needs
> > change. For example, see these results:
> > 
> > git grep -F "/ 180.0" *.cxx
> 
> Hossein, with today core I found just one line needing changes. You have
> mentioned many places. Is the search term wrong?
> sc/source/core/opencl/op_math.cxx:ss << "return arg0 * M_PI /
> 180.0;\n";
I don't exactly remember the number of instances 5 month ago, but that 1
instance might be enough for you to experiment changing the code. This is the
main purpose of the EasyHacks.

After you have done 1 or 2 instance of each EasyHack, you should find other
issues to work on. This is the path that I suggest:
https://wiki.documentfoundation.org/Development/GetInvolved#Roadmap_for_personal_growth

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152115] Hyperlink Target in document: The last user setting is not remembered

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152115

--- Comment #7 from Jim Raykowski  ---
(In reply to Stéphane Guillou (stragu) from comment #5)
> Jim, do you think your fix for bug 151387 might have been what fixed it?
Yes I think so.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 152115] Hyperlink Target in document: The last user setting is not remembered

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152115

--- Comment #7 from Jim Raykowski  ---
(In reply to Stéphane Guillou (stragu) from comment #5)
> Jim, do you think your fix for bug 151387 might have been what fixed it?
Yes I think so.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 148435] LibreOffice on macOS hangs on using window snapping / window manager (BetterTouchTool, Rectangle, Raycast, Amethyst, ...) or any other redraw, context switch, etc, from

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148435

steve  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 42082] [META] Make LibreOffice shine and glow on macOS

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=42082
Bug 42082 depends on bug 148435, which changed state.

Bug 148435 Summary: LibreOffice on macOS hangs on using window snapping / 
window manager (BetterTouchTool, Rectangle, Raycast, Amethyst, ...) or any 
other redraw, context switch, etc, from idle thread
https://bugs.documentfoundation.org/show_bug.cgi?id=148435

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148435] LibreOffice on macOS hangs on using window snapping / window manager (BetterTouchTool, Rectangle, Raycast, Amethyst, ...) or any other redraw, context switch, etc, from

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148435

steve  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #54 from steve  ---
Taking the liberty to close this as fixed verified. I would be surprised if
this persisted specifically on Apple Silicon. But who knows. In that case
please file a follow-up bug and interlink the two issues.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112604] Set a maximum width for the Calc Sort dialog

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112604

andréb  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

--- Comment #15 from andréb  ---
The test file works for me now, by displaying the sort options in a popup with
ascending/descending reserved in a column to the right.
The popup displays all 4 lines of the test heading of a wide column, with the
middle of long lines being replaced by ... character.

To me that is a very satisfactory solution : not only are the sort order
options displayed, but a considerable width is now displayed, making it easy to
identify the column in question.

Tested with libo 7.3.6.2
(The latest version on the current official release of my distro of Linux)

Thanks for fixing the issue.

Will close as resolved / worksforme.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141438] remove obsolete comment ...

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141438

BogdanB  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |buzea.bog...@libreoffice.or
   |desktop.org |g
 CC||buzea.bog...@libreoffice.or
   ||g
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151548] No access to FormField controls in StarBASIC/VBA

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151548

--- Comment #10 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/24d7431876e87eba700a9f141dc8e030143a92ad

tdf#151548 vba ContentControls: Add basic word::XContentControl

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: oovbaapi/ooo oovbaapi/UnoApi_oovbaapi.mk sw/Library_vbaswobj.mk sw/qa sw/source

2022-11-24 Thread Justin Luth (via logerrit)
 oovbaapi/UnoApi_oovbaapi.mk|3 
 oovbaapi/ooo/vba/word/WdContentControlType.idl |   25 
 oovbaapi/ooo/vba/word/XContentControl.idl  |  103 +++
 oovbaapi/ooo/vba/word/XContentControls.idl |   23 
 oovbaapi/ooo/vba/word/XDocument.idl|3 
 sw/Library_vbaswobj.mk |2 
 sw/qa/core/data/docm/testModernVBA.docm|binary
 sw/qa/core/macros-test.cxx |4 
 sw/source/ui/vba/vbacontentcontrol.cxx |  754 +
 sw/source/ui/vba/vbacontentcontrol.hxx |  142 
 sw/source/ui/vba/vbacontentcontrols.cxx|  264 
 sw/source/ui/vba/vbacontentcontrols.hxx|   44 +
 sw/source/ui/vba/vbadocument.cxx   |   27 
 sw/source/ui/vba/vbadocument.hxx   |3 
 14 files changed, 1397 insertions(+)

New commits:
commit 24d7431876e87eba700a9f141dc8e030143a92ad
Author: Justin Luth 
AuthorDate: Mon Nov 21 11:44:52 2022 -0500
Commit: Justin Luth 
CommitDate: Thu Nov 24 23:24:49 2022 +0100

tdf#151548 vba ContentControls: Add basic word::XContentControl

This adds basic VBA macro support for accessing
the modern content controls used for creating forms.

I ran out of time to make it fully functional.

TODO
-Invalidation: the screen isn't updating the modified results until
 interaction from the user (mouse click, etc.)
-Unlike FormFields, content controls really depend on having
 Range working. I didn't have time to look into that.
-I was hoping to check that my approach could accommodate the other
methods that create a filtered ContentControls object:
 * Document.SelectLinkedControls,
 * Document.SelectUnlinkedControls
 * Range.ContentControls.
 I guess it will be left up to whoever needs these to add the bits
 that will create an appropriate collection for these limited sets.
-setType: changing one type to another - both LO and Word allow
 limited use of this - depending on the text contents fitting
 the new type.

What works:
-getByIndex - which probably is the "normal" way to do it,
 since the UI doesn't provide a name/ID; just got via msgbox .ID.
-full checkbox support (minus the visual invalidation)
-VBA accepts almost all properties/methods that are requested.

make CppunitTest_sw_macros_test CPPUNIT_TEST_NAME=testVba

If Not ActiveDocument.ContentControls(1).Checked
If ActiveDocument.ContentControls(2).Checked
'If ActiveDocument.ContentControls(2).Range.Text <> "$"
ActiveDocument.SelectContentControlsByTag("checkboxes").Item(1).Checked
 = ActiveDocument.SelectContentControlsByTag("checkboxes").Item(2).Checked
ActiveDocument.SelectContentControlsByTag("checkboxes")
 .Item(2).SetUncheckedSymbol (8364) '€

With ActiveDocument.SelectContentControlsByTitle("listbox").Item(1)
  If Not .ShowingPlaceholderText
  'If .Range.Text <> "Choose an item."
  If .Type <> wdContentControlDropdownList
End With

With ActiveDocument.ContentControls.Item(5)
'If Not .Temporary Then GoTo errorhandler:
If .Temporary <> False Then GoTo errorhandler:
If .Tag <> "" Then GoTo errorhandler:
If .Title <> "" Then GoTo errorhandler:
End With

With ActiveDocument.ContentControls.Item(6)
If .Type <> wdContentControlText
If .MultiLine Then GoTo errorhandler:
If ActiveDocument.ContentControls.Count <> 7
.Delete 'Doesn't actually Delete in LO yet - unsafe
   ' If ActiveDocument.ContentControls.Count <> 6
End With

' Change to 6 when delete is working safely
With ActiveDocument.ContentControls.Item(7)
If .Type <> wdContentControlDate Then GoTo errorhandler:
.Color = wdColorBlueGray 'unknown to Word 2010
If .Color <> wdColorBlueGray Then GoTo errorhandler:
If .DateDisplayFormat <> "mm/yy/dd" Then GoTo errorhandler:
If .DateCalendarType <> wdCalendarWestern Then GoTo errorhandler:
If .LockContents <> False Then GoTo errorhandler:
End With

Change-Id: I1c636f671de81e0283c040a578838a0433ef1f5b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143080
Tested-by: Jenkins
Reviewed-by: Justin Luth 

diff --git a/oovbaapi/UnoApi_oovbaapi.mk b/oovbaapi/UnoApi_oovbaapi.mk
index 331cf4937e32..063700762e46 100644
--- a/oovbaapi/UnoApi_oovbaapi.mk
+++ b/oovbaapi/UnoApi_oovbaapi.mk
@@ -833,6 +833,7 @@ $(eval $(call gb_UnoApi_add_idlfiles,oovbaapi,ooo/vba/word,\
 WdFarEastLineBreakLevel \
 WdFieldKind \
 WdFieldShading \
+WdContentControlType \
 WdFieldType \
 WdFindMatch \
 WdFindWrap \
@@ -1057,6 +1058,8 @@ $(eval $(call 
gb_UnoApi_add_idlfiles,oovbaapi,ooo/vba/word,\
XFields \
XFind \
XFont \
+   XContentControl \
+   XContentControls \
XFormField \
XFormFields \

[Libreoffice-bugs] [Bug 152194] LibreOffice GUI Start as a very tiny window

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152194

V Stuart Foote  changed:

   What|Removed |Added

 CC||vsfo...@libreoffice.org
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||0779
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #2 from V Stuart Foote  ---
Did you clear your user profile?

This seems dupe of bug 150779, where fix was partial revert of refactoring done
for master against 7.5

Please clear profile and retest. Or test with a parallel install daily master
against 7.5

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: external/poppler

2022-11-24 Thread Stephan Bergmann (via logerrit)
 external/poppler/UnpackedTarball_poppler.mk |1 +
 external/poppler/char_traits.patch  |   11 +++
 2 files changed, 12 insertions(+)

New commits:
commit b789f54cb0bb2ae2f1d2cba3b3e5920085c8696d
Author: Stephan Bergmann 
AuthorDate: Thu Nov 24 11:39:20 2022 +0100
Commit: Stephan Bergmann 
CommitDate: Thu Nov 24 23:14:01 2022 +0100

external/poppler: Fix use of std::char_trait

...now that it is gone from libc++ 16 trunk since


"[libc++] Remove default definition of std::char_traits", causing

> In file included from sdext/source/pdfimport/xpdfwrapper/pnghelper.cxx:20:
> In file included from sdext/source/pdfimport/xpdfwrapper/pnghelper.hxx:24:
> In file included from 
sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:36:
> In file included from 
workdir/UnpackedTarball/poppler/poppler/GfxState.h:41:
> In file included from workdir/UnpackedTarball/poppler/poppler/Object.h:43:
> In file included from workdir/UnpackedTarball/poppler/goo/GooString.h:46:
> ~/llvm/inst/bin/../include/c++/v1/string:676:46: error: implicit 
instantiation of undefined template 'std::char_traits'
> static_assert(( is_same<_CharT, typename 
traits_type::char_type>::value),
>  ^
> workdir/UnpackedTarball/poppler/cpp/poppler-global.h:101:43: note: in 
instantiation of template class 'std::basic_string' requested 
here
> class POPPLER_CPP_EXPORT ustring : public std::basic_string
>   ^
> ~/llvm/inst/bin/../include/c++/v1/__fwd/string.h:22:29: note: template is 
declared here
> struct _LIBCPP_TEMPLATE_VIS char_traits;
> ^
> In file included from sdext/source/pdfimport/xpdfwrapper/pnghelper.cxx:20:
> In file included from sdext/source/pdfimport/xpdfwrapper/pnghelper.hxx:24:
> In file included from 
sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:36:
> In file included from 
workdir/UnpackedTarball/poppler/poppler/GfxState.h:41:
> In file included from workdir/UnpackedTarball/poppler/poppler/Object.h:43:
> In file included from workdir/UnpackedTarball/poppler/goo/GooString.h:46:
> In file included from ~/llvm/inst/bin/../include/c++/v1/string:576:
> ~/llvm/inst/bin/../include/c++/v1/string_view:279:45: error: implicit 
instantiation of undefined template 'std::char_traits'
> static_assert((is_same<_CharT, typename 
traits_type::char_type>::value),
> ^
> ~/llvm/inst/bin/../include/c++/v1/__type_traits/is_convertible.h:30:66: 
note: in instantiation of template class 'std::basic_string_view' requested here
> : public integral_constant {};
>  ^
> ~/llvm/inst/bin/../include/c++/v1/string:650:7: note: in instantiation of 
template class 'std::is_convertible &, 
std::basic_string_view>' requested here
>   is_convertible 
>::value &&
>   ^
> ~/llvm/inst/bin/../include/c++/v1/string:967:35: note: in instantiation 
of template class 'std::__can_be_converted_to_string_view, std::basic_string>' requested 
here
> class = 
__enable_if_t<__can_be_converted_to_string_view<_CharT, _Traits, _Tp>::value &&
>   ^
> ~/llvm/inst/bin/../include/c++/v1/string:969:93: note: in instantiation 
of default argument for 'basic_string>' 
required here
>   _LIBCPP_METHOD_TEMPLATE_IMPLICIT_INSTANTIATION_VIS 
_LIBCPP_CONSTEXPR_SINCE_CXX20 explicit basic_string(
>   
  ^
> ~/llvm/inst/bin/../include/c++/v1/string:657:7: note: while substituting 
deduced template arguments into function template 'basic_string' [with _Tp = 
std::basic_string, $1 = (no value)]
> class basic_string
>   ^
> workdir/UnpackedTarball/poppler/cpp/poppler-global.h:101:26: note: while 
declaring the implicit copy constructor for 'ustring'
> class POPPLER_CPP_EXPORT ustring : public std::basic_string
>  ^
> ~/llvm/inst/bin/../include/c++/v1/__fwd/string.h:22:29: note: template is 
declared here
> struct _LIBCPP_TEMPLATE_VIS char_traits;
> ^

Change-Id: Ia1dfda1866ffac22b1c8c99eb11412c095bcc4a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143237
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/external/poppler/UnpackedTarball_poppler.mk 
b/external/poppler/UnpackedTarball_poppler.mk
index 5726814fee82..62ed7a24ec1d 100644
--- a/external/poppler/UnpackedTarball_poppler.mk
+++ b/external/poppler/UnpackedTarball_poppler.mk
@@ -18,6 +18,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,poppler,\

[Libreoffice-bugs] [Bug 42082] [META] Make LibreOffice shine and glow on macOS

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=42082
Bug 42082 depends on bug 148221, which changed state.

Bug 148221 Summary: LibreOffice Writer hang on Apple Silicon
https://bugs.documentfoundation.org/show_bug.cgi?id=148221

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148221] LibreOffice Writer hang on Apple Silicon

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148221

Dieter  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 CC||dgp-m...@gmx.de
 Status|UNCONFIRMED |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152193] the printout of the document has sections of text missing

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152193

Dieter  changed:

   What|Removed |Added

  Component|Writer  |Printing and PDF export

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152204] Many HTML5 entity names not supported

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152204

V Stuart Foote  changed:

   What|Removed |Added

Summary|Many HTML entity names not  |Many HTML5 entity names not
   |supported   |supported
Version|4.1.0.4 release |Inherited From OOo

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152204] Many HTML entity names not supported

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152204

--- Comment #6 from V Stuart Foote  ---
(In reply to V Stuart Foote from comment #5)
> Created attachment 183759 [details]
> LO ODF text document sample with mix of named character entity values
> 
> For named character entities added at HTML5 so without LO import filter
> handling, the unrecognized entity is left in its "&  ;" format on
> import.

Oops sorry, that actually is a HTML generated from LO 7.5. Then edited a bit to
clean up the HTML formatting to put each stanza on its own row.

So when opened into LibreOffice, from Writer Web module select the HTML source
view to see what entities are missing from filter import.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152118] Dates imported erroneously from Calc to a Firebird database table

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152118

--- Comment #14 from jcs...@libreoffice.org ---
So, given that after the correction of tdf#152114 the errors in the dates
import are solved and that the results (which I thought were wrong) are correct
and according to what was expected, this bug should be closed as solved,
shouldn't it? Who does it? Eike? myself?

(In reply to Eike Rathke from comment #12)
> 
> To solve this (expectation of display being what's stored) it would need an
> option to force the proleptic Gregorian calendar for display.

I will surely make an enhancement request asking for it.
Thank you very much for your patience and quick resolution.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152204] Many HTML entity names not supported

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152204

--- Comment #5 from V Stuart Foote  ---
Created attachment 183759
  --> https://bugs.documentfoundation.org/attachment.cgi?id=183759=edit
LO ODF text document sample with mix of named character entity values

For named character entities added at HTML5 so without LO import filter
handling, the unrecognized entity is left in its "&  ;" format on import.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 36977] Improved HTML5/XHTML Import

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=36977

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||2204

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103302] [META] Writer's web layout/view bugs and enhancements

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103302

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||152204


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=152204
[Bug 152204] Many HTML entity names not supported
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152204] Many HTML entity names not supported

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152204

V Stuart Foote  changed:

   What|Removed |Added

 CC||vsfo...@libreoffice.org
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=36
   ||977
 Blocks||103302

--- Comment #4 from V Stuart Foote  ---
Confirming.

Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 651658d37bcb3f493942dd5d0b9a0d65c96f105c
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

LibreOffice filter import does not handle the additional HTML / XML named
character entities added for HTML5. Not just  or  as here. The
unhandled entities are not converted to the appropriate glyph on LibreOffice
document canvas and remain plaintext.

Dante did add the handling needed for MathML support with
https://gerrit.libreoffice.org/c/core/+/108333

But something similar is needed to support Writer Web parsing the characters
from HTML/XHTML or XML.

Attached test ODF text doc shows example of the named entities not being
handled in LibreOffice Writer Web import.

=-ref-=
https://en.wikipedia.org/wiki/List_of_XML_and_HTML_character_entity_references
https://html.spec.whatwg.org/multipage/named-characters.html#named-character-references


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103302
[Bug 103302] [META] Writer's web layout/view bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152205] New: Wayland bollixes window-switching

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152205

Bug ID: 152205
   Summary: Wayland bollixes window-switching
   Product: LibreOffice
   Version: 7.3.7.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: s...@hevanet.com

The "Window" menu item usually allows the user to switch between open
LibreOffice document windows, switching focus to the selected item.  This still
works in an X11 session, but in Wayland the focus does not shift -- the current
window stays forward.

Other methods of bringing windows forward still work fine:  Alt-Tab and the
taskbar.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151325] Show Whitespace doesn't work in this ODT

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151325

Aron Budea  changed:

   What|Removed |Added

 CC||aron.bu...@gmail.com
 Status|NEW |NEEDINFO

--- Comment #2 from Aron Budea  ---
The help says:

Hiding whitespace is only possible in Single-page view.
https://help.libreoffice.org/latest/lo/text/swriter/01/show_whitespace.html

The document is in Multiple-page view, and the setting works for me after
switching to Single-page view. Timur, does that make it work for you?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152199] Image garbled after roundtrip

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152199

Jan Holesovsky  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Jan Holesovsky  ---
Should be fixed now :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103427] [META] Styles and Formatting sidebar deck and floating window

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103427

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||152201


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=152201
[Bug 152201] Cell styles' previews are not shown in Calc's sidebar's Styles
deck
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152201] Cell styles' previews are not shown in Calc's sidebar's Styles deck

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152201

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Blocks||103427


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103427
[Bug 103427] [META] Styles and Formatting sidebar deck and floating window
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152201] Cell styles' previews are not shown in Calc's sidebar's Styles deck

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152201

--- Comment #2 from Stéphane Guillou (stragu) 
 ---
Note that the previews *are* shown in the Tabbed User Interface's style
dropdown.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152040] Table: drag column border (to resize) leaves lines

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152040

Dieter  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #3 from Dieter  ---
(In reply to LeroyG from comment #2)
> Try to toggle Skia.

Does this solve your problem? => NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152202] Copypaste adds extra space in front of word

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152202

Dieter  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||dgp-m...@gmx.de
 Resolution|--- |DUPLICATE

--- Comment #3 from Dieter  ---
(In reply to robert.be.johansson from comment #0)
I confirm it with
Version: 7.4.3.2 (x64) / LibreOffice Community
Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

But for me it's the expected result, if a word is separated by a space from
another word. Hope you agree.

> Additional Info:
> Only seems to happen when pasting at the end of a sentence?
This is bug 112011 => Duplicate

*** This bug has been marked as a duplicate of bug 112011 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112011] Pasting a word at the end of a paragraph always adds leading space

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112011

Dieter  changed:

   What|Removed |Added

 CC||robert.be.johansson@gmail.c
   ||om

--- Comment #18 from Dieter  ---
*** Bug 152202 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141738] SELECTION: It's not visible, that blank space before the word is also selected, if you double-click a word

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141738

Dieter  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||2011

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112011] Pasting a word at the end of a paragraph always adds leading space

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112011

Dieter  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||1738

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/qa writerfilter/source

2022-11-24 Thread Mike Kaganski (via logerrit)
 sw/qa/extras/ooxmlimport/data/tdf152200-bad_fldChar_end.docx |binary
 sw/qa/extras/ooxmlimport/ooxmlimport2.cxx|6 +
 writerfilter/source/dmapper/DomainMapper_Impl.cxx|   39 ++-
 3 files changed, 29 insertions(+), 16 deletions(-)

New commits:
commit 9a7945f36ce95a48e0d525bc444e722b9ec5c452
Author: Mike Kaganski 
AuthorDate: Thu Nov 24 15:05:43 2022 +0300
Commit: Mike Kaganski 
CommitDate: Thu Nov 24 22:01:13 2022 +0100

tdf#152200: tolerate begin/end fldChar context mismatch

We generate such files currently. Fixing that will be another commit.

Change-Id: I788501e346cba63c08a767c0e05e063bc1172089
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143223
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sw/qa/extras/ooxmlimport/data/tdf152200-bad_fldChar_end.docx 
b/sw/qa/extras/ooxmlimport/data/tdf152200-bad_fldChar_end.docx
new file mode 100644
index ..7f77c8d66b2b
Binary files /dev/null and 
b/sw/qa/extras/ooxmlimport/data/tdf152200-bad_fldChar_end.docx differ
diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx 
b/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx
index 1c79dbecf75f..a1110d0d287e 100644
--- a/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx
+++ b/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx
@@ -941,6 +941,12 @@ CPPUNIT_TEST_FIXTURE(Test, testTdf119039)
 // Should not crash/hang because of problematic embedded compound
 }
 
+CPPUNIT_TEST_FIXTURE(Test, testTdf152200)
+{
+createSwDoc("tdf152200-bad_fldChar_end.docx");
+// Should not crash/hang because of wrong placement of ending fldChar
+}
+
 // tests should only be added to ooxmlIMPORT *if* they fail round-tripping in 
ooxmlEXPORT
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx 
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index 3e17187b40fa..4c20cdc1bfb5 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -7535,7 +7535,6 @@ void DomainMapper_Impl::PopFieldContext()
 {
 try
 {
-uno::Reference< text::XTextCursor > xCrsr = 
xTextAppend->createTextCursorByRange(pContext->GetStartRange());
 uno::Reference< text::XTextContent > xToInsert( 
pContext->GetTOC(), uno::UNO_QUERY );
 if( xToInsert.is() )
 {
@@ -7597,30 +7596,38 @@ void DomainMapper_Impl::PopFieldContext()
 }
 else
 {
+uno::Reference< text::XTextCursor > xCrsr = 
xTextAppend->createTextCursorByRange(pContext->GetStartRange());
 FormControlHelper::Pointer_t 
pFormControlHelper(pContext->getFormControlHelper());
 if (pFormControlHelper)
 {
-uno::Reference< text::XFormField > xFormField( 
pContext->GetFormField() );
-assert(xCrsr.is());
-if (pFormControlHelper->hasFFDataHandler())
+// xCrsr may be empty e.g. when 
pContext->GetStartRange() is outside of
+// xTextAppend, like when a field started in a 
parent paragraph is being
+// closed inside an anchored text box. It could be 
possible to throw an
+// exception here, and abort import, but Word 
tolerates such invalid
+// input, so it makes sense to do the same 
(tdf#152200)
+if (xCrsr.is())
 {
-xToInsert.set(xFormField, uno::UNO_QUERY);
-if (xFormField.is() && xToInsert.is())
+uno::Reference< text::XFormField > 
xFormField(pContext->GetFormField());
+if (pFormControlHelper->hasFFDataHandler())
 {
-PopFieldmark(m_aTextAppendStack, xCrsr,
-pContext->GetFieldId());
-pFormControlHelper->processField( 
xFormField );
+xToInsert.set(xFormField, uno::UNO_QUERY);
+if (xFormField.is() && xToInsert.is())
+{
+PopFieldmark(m_aTextAppendStack, xCrsr,
+ pContext->GetFieldId());
+
pFormControlHelper->processField(xFormField);
+}
+else
+{
+
pFormControlHelper->insertControl(xCrsr);
+}
 }
  

[Libreoffice-bugs] [Bug 152199] Image garbled after roundtrip

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152199

--- Comment #3 from Commit Notification 
 ---
Jan Holesovsky committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ab080ab1ab3100d9702a745287566b78b8d59e54

tdf#152199: Don't crop twice

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152199] Image garbled after roundtrip

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152199

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.5.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: oox/source sw/qa

2022-11-24 Thread Jan Holesovsky (via logerrit)
 oox/source/drawingml/fillproperties.cxx   |6 +-
 sw/qa/extras/ooxmlexport/data/crop-roundtrip.docx |binary
 sw/qa/extras/ooxmlexport/ooxmlexport18.cxx|   15 +++
 3 files changed, 20 insertions(+), 1 deletion(-)

New commits:
commit ab080ab1ab3100d9702a745287566b78b8d59e54
Author: Jan Holesovsky 
AuthorDate: Thu Nov 24 11:22:49 2022 +0100
Commit: Jan Holesovsky 
CommitDate: Thu Nov 24 21:58:46 2022 +0100

tdf#152199: Don't crop twice

We have a "GraphicCrop" property that is supposed to roundtrip the
cropping in OOXML, but there is no core feature backing it (ie. the
image is not shown cropped when this is imported and set).

Instead, to show the image "cropped", we crop the image physically on
import (throw away pixels that are 'outside' of the cropped area).

But - the "GraphicCrop" is then saved on export, together with the image
already physically cropped, which leads to garbled DOCX on re-import.

Given that the core feature to show image cropped when the "GraphicCrop"
is set, let's avoid setting it when we physically crop the image.

Change-Id: Ia1090ea9c6d22e60c77d52bf65281f6588d07d4e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143216
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky 

diff --git a/oox/source/drawingml/fillproperties.cxx 
b/oox/source/drawingml/fillproperties.cxx
index 75da3836b6f5..329d5d3bb4b1 100644
--- a/oox/source/drawingml/fillproperties.cxx
+++ b/oox/source/drawingml/fillproperties.cxx
@@ -853,7 +853,6 @@ void FillProperties::pushToPropMap( ShapePropertyMap& 
rPropMap,
 aGraphCrop.Right = static_cast< sal_Int32 >( ( 
static_cast< double >( aOriginalSize.Width ) * aFillRect.X2 ) / 10 );
 if ( aFillRect.Y2 )
 aGraphCrop.Bottom = static_cast< sal_Int32 >( 
( static_cast< double >( aOriginalSize.Height ) * aFillRect.Y2 ) / 10 );
-rPropMap.setProperty(PROP_GraphicCrop, aGraphCrop);
 
 bool bHasCropValues = aGraphCrop.Left != 0 || 
aGraphCrop.Right !=0 || aGraphCrop.Top != 0 || aGraphCrop.Bottom != 0;
 // Negative GraphicCrop values means "crop" here.
@@ -861,12 +860,17 @@ void FillProperties::pushToPropMap( ShapePropertyMap& 
rPropMap,
 
 if(bIsCustomShape && bHasCropValues && bNeedCrop)
 {
+// Physically crop the image
+// In this case, don't set the 
PROP_GraphicCrop because that
+// would lead to applying the crop twice after 
roundtrip
 xGraphic = lclCropGraphic(xGraphic, 
CropQuotientsFromFillRect(aFillRect));
 if 
(rPropMap.supportsProperty(ShapeProperty::FillBitmapName))
 
rPropMap.setProperty(ShapeProperty::FillBitmapName, xGraphic);
 else
 
rPropMap.setProperty(ShapeProperty::FillBitmap, xGraphic);
 }
+else
+rPropMap.setProperty(PROP_GraphicCrop, 
aGraphCrop);
 }
 }
 }
diff --git a/sw/qa/extras/ooxmlexport/data/crop-roundtrip.docx 
b/sw/qa/extras/ooxmlexport/data/crop-roundtrip.docx
new file mode 100644
index ..6db60d0e8c60
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/crop-roundtrip.docx 
differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
index 71d28b313d2a..04c775fa8fcb 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
@@ -14,6 +14,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -172,6 +173,20 @@ CPPUNIT_TEST_FIXTURE(Test, testSdtDuplicatedId)
 assertXPath(pXmlDoc, "//w:sdt", 2);
 }
 
+CPPUNIT_TEST_FIXTURE(Test, testImageCropping)
+{
+loadAndReload("crop-roundtrip.docx");
+
+// the image has no cropping after roundtrip, because it has been 
physically cropped
+// NB: this test should be fixed when the core feature to show image 
cropped when it
+// has the "GraphicCrop" is set is implemented
+auto aGraphicCropStruct = getProperty(getShape(1), 
"GraphicCrop");
+CPPUNIT_ASSERT_EQUAL(sal_Int32(0), aGraphicCropStruct.Left);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(0), aGraphicCropStruct.Right);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(0), aGraphicCropStruct.Top);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(0), aGraphicCropStruct.Bottom);
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */


[Libreoffice-bugs] [Bug 152126] selecting a line and changing line style affects half of lines, which are not selected

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152126

--- Comment #2 from LeroyG  ---
Created attachment 183758
  --> https://bugs.documentfoundation.org/attachment.cgi?id=183758=edit
Sidebar styles

Maybe you must add and apply new Line Styles (F11 or menu Format - Styles -
Manage Styles).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/source

2022-11-24 Thread Bogdan B (via logerrit)
 vcl/source/gdi/pdfwriter_impl.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1e9ace4c35e4206c24ded230433915850a1f04d1
Author: Bogdan B 
AuthorDate: Thu Nov 24 20:48:06 2022 +0100
Commit: Hossein 
CommitDate: Thu Nov 24 21:56:09 2022 +0100

tdf#147906 used std::hypot for Pythagorean addition

Change-Id: Ie835faef0d66a9a34b007fdea847eb0f54da9068
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143167
Tested-by: Jenkins
Reviewed-by: Hossein 

diff --git a/vcl/source/gdi/pdfwriter_impl.cxx 
b/vcl/source/gdi/pdfwriter_impl.cxx
index fdc78dcb8422..8a2babe75631 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -6345,7 +6345,7 @@ void PDFWriterImpl::drawVerticalGlyphs(
 {
 double nOffsetX = rGlyphs[i+1].m_aPos.getX() - 
rGlyphs[i].m_aPos.getX();
 double nOffsetY = rGlyphs[i+1].m_aPos.getY() - 
rGlyphs[i].m_aPos.getY();
-nXOffset += sqrt(nOffsetX*nOffsetX + nOffsetY*nOffsetY);
+nXOffset += std::hypot(nOffsetX, nOffsetY);
 }
 if (!rGlyphs[i].m_pGlyph->glyphId())
 continue;


[Libreoffice-bugs] [Bug 147906] Use std::hypot for Pythagorean addition

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147906

--- Comment #12 from Commit Notification 
 ---
Bogdan B committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1e9ace4c35e4206c24ded230433915850a1f04d1

tdf#147906 used std::hypot for Pythagorean addition

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152204] Many HTML entity names not supported

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152204

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Summary|Unicode HTML entity a breve |Many HTML entity names not
   |(Ă) is not rendered with|supported
   | |
  Component|LibreOffice |filters and storage

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146207] UI: Slide panel too small by default (horizontal visible) and vertical scrollbar masking slide thumbnail (Windows 8.1 only)

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146207

Buovjaga  changed:

   What|Removed |Added

Summary|UI: Slide panel too small   |UI: Slide panel too small
   |by default (horizontal  |by default (horizontal
   |visible) and vertical   |visible) and vertical
   |scrollbar masking slide |scrollbar masking slide
   |thumbnail   |thumbnail (Windows 8.1
   ||only)
 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED
 OS|All |Windows (All)

--- Comment #5 from Buovjaga  ---
(In reply to Telesto from comment #4)
> It's still present for me
> Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
> Build ID: 651658d37bcb3f493942dd5d0b9a0d65c96f105c
> CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
> Locale: nl-NL (nl_NL); UI: nl-NL
> Calc: threaded
> 
> However, Windows 8.1 will be at end of support on January 10, 2023.

Ah :) But we still support even Windows 7 and based on the market share I think
we have to keep supporting it for a couple of years.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151936] Changing text color of form control (textbox) doesn't work

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151936

--- Comment #5 from Dieter  ---
I've tried again with following steps:
1. Change to Windows dark modus
2. Tools -> Options -> Personalisation -> Dark Theme
3. Tools -> Options -> Application Colours -> Scheme "LibreOffice Dark"
4. Open attachment 183733
5. In Form controls toolbar activate Design Mode
6. Select textbox -> Control properties (contect menu) -> Change background
colour to black and font colour to white
7. Deactivate Desingn Mode and write some text; text is white (expected)
8. Activate Design Mode
6. Select textbox -> Control properties (contect menu) -> font colour to a
black -> works as expected

Please correct my steps, if they're wrong.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152204] Unicode HTML entity a breve (Ă) is not rendered with

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152204

--- Comment #3 from Stéphane Guillou (stragu) 
 ---
Created attachment 183757
  --> https://bugs.documentfoundation.org/attachment.cgi?id=183757=edit
html unicode megalist

This actually extends to dozens of unicode HTML entity names (one ampersand
followed by only letters), see the list.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152126] selecting a line and changing line style affects half of lines, which are not selected

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152126

LeroyG  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #1 from LeroyG  ---
Please, upload here the .odg file. Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143754] No Help page for Tools > Options… > Language settings > English Sentence Checking in 7.2.0.2.

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143754

--- Comment #10 from Dieter  ---
(In reply to Marco A.G.Pinto from comment #9)
> A… sorry…
> 
> I don't understand this ticket.

Sorry, I thought you might could help. 

Informations about the option "English Sentence Checking" is missing in
Language settings overview:
https://help.libreoffice.org/7.4/en-GB/text/shared/optionen/0115.html?=SHARED=WIN

And there is no help page about "English Sentence Checking". Therefor error
message appears, if you press help button in "English Sentence Checking"
dialog.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 122245] [META] Icon theme issues that need coding

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122245
Bug 122245 depends on bug 152157, which changed state.

Bug 152157 Summary: Update Available icon (on menu bar) messes up ability to 
work with multiple Calc windows
https://bugs.documentfoundation.org/show_bug.cgi?id=152157

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 85811] [META] Main menu bar bugs and enhancements

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=85811
Bug 85811 depends on bug 152157, which changed state.

Bug 152157 Summary: Update Available icon (on menu bar) messes up ability to 
work with multiple Calc windows
https://bugs.documentfoundation.org/show_bug.cgi?id=152157

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: extensions/source include/vcl vcl/source

2022-11-24 Thread Caolán McNamara (via logerrit)
 extensions/source/update/ui/updatecheckui.cxx |3 
 include/vcl/menubarupdateicon.hxx |   17 ++-
 vcl/source/window/bubblewindow.cxx|  122 --
 3 files changed, 87 insertions(+), 55 deletions(-)

New commits:
commit f1d5143c2f66936104f8236cc83417853d39f873
Author: Caolán McNamara 
AuthorDate: Thu Nov 24 16:30:24 2022 +
Commit: Caolán McNamara 
CommitDate: Thu Nov 24 21:33:17 2022 +0100

Resolves: tdf#152157 show update icon on all menubars

and not just the active one, so they are of a consistent height with
eachother. BubbleWindow is only shown for the active one.

Change-Id: I157c8c8b0e2a219c20ffde01ec4a04ba93b7f0e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143241
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/extensions/source/update/ui/updatecheckui.cxx 
b/extensions/source/update/ui/updatecheckui.cxx
index 6a4a151b1a98..f7f1f011363b 100644
--- a/extensions/source/update/ui/updatecheckui.cxx
+++ b/extensions/source/update/ui/updatecheckui.cxx
@@ -163,10 +163,7 @@ void SAL_CALL UpdateCheckUI::documentEventOccured(const 
document::DocumentEvent&
 SolarMutexGuard aGuard;
 
 if( rEvent.EventName == "OnPrepareViewClosing" )
-{
 maBubbleManager.RemoveBubbleWindow();
-maBubbleManager.RemoveMenuBarIcon();
-}
 }
 
 void SAL_CALL UpdateCheckUI::disposing(const lang::EventObject&)
diff --git a/include/vcl/menubarupdateicon.hxx 
b/include/vcl/menubarupdateicon.hxx
index a426da869553..8e04c3f65a72 100644
--- a/include/vcl/menubarupdateicon.hxx
+++ b/include/vcl/menubarupdateicon.hxx
@@ -37,8 +37,10 @@ private:
 OUString maBubbleText;
 Image maBubbleImage;
 VclPtr mpBubbleWin;
-VclPtr mpIconSysWin;
-VclPtr mpIconMBar;
+VclPtr mpActiveSysWin;
+VclPtr mpActiveMBar;
+std::vector> maIconMBars;
+std::vector maIconIDs;
 
 Link maWindowEventHdl;
 Link maApplicationEventHdl;
@@ -47,8 +49,6 @@ private:
 Timer maTimeoutTimer;
 Idle maWaitIdle;
 
-sal_uInt16 mnIconID;
-
 bool mbShowMenuIcon;
 bool mbShowBubble;
 bool mbBubbleChanged;
@@ -64,6 +64,12 @@ private:
 VclPtr GetBubbleWindow();
 void SetBubbleChanged();
 
+sal_uInt16 GetIconID(MenuBar* pMenuBar) const;
+
+void AddMenuBarIcon(SystemWindow* pSysWin, bool bAddEventHdl);
+void RemoveMenuBarIcon(MenuBar* pMenuBar);
+void RemoveMenuBarIcons();
+
 public:
 MenuBarUpdateIconManager();
 ~MenuBarUpdateIconManager();
@@ -82,9 +88,6 @@ public:
 const OUString& GetBubbleText() const { return maBubbleText; }
 
 void RemoveBubbleWindow();
-
-void AddMenuBarIcon(SystemWindow* pSysWin, bool bAddEventHdl);
-void RemoveMenuBarIcon();
 };
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/source/window/bubblewindow.cxx 
b/vcl/source/window/bubblewindow.cxx
index f1fad815466a..dd11dce12ae6 100644
--- a/vcl/source/window/bubblewindow.cxx
+++ b/vcl/source/window/bubblewindow.cxx
@@ -218,7 +218,6 @@ void BubbleWindow::RecalcTextRects()
 MenuBarUpdateIconManager::MenuBarUpdateIconManager()
 : maTimeoutTimer("MenuBarUpdateIconManager")
 , maWaitIdle("vcl MenuBarUpdateIconManager maWaitIdle")
-, mnIconID (0)
 , mbShowMenuIcon(false)
 , mbShowBubble(false)
 , mbBubbleChanged( false )
@@ -235,19 +234,27 @@ MenuBarUpdateIconManager::MenuBarUpdateIconManager()
 maWindowEventHdl = LINK(this, MenuBarUpdateIconManager, WindowEventHdl);
 }
 
+sal_uInt16 MenuBarUpdateIconManager::GetIconID(MenuBar* pMenuBar) const
+{
+auto aI = std::find(maIconMBars.begin(), maIconMBars.end(), pMenuBar);
+if (aI == maIconMBars.end())
+return 0;
+return maIconIDs[std::distance(maIconMBars.begin(), aI)];
+}
+
 VclPtr MenuBarUpdateIconManager::GetBubbleWindow()
 {
-if ( !mpIconSysWin )
+if (!mpActiveSysWin)
 return nullptr;
 
-tools::Rectangle aIconRect = mpIconMBar->GetMenuBarButtonRectPixel( 
mnIconID );
+tools::Rectangle aIconRect = 
mpActiveMBar->GetMenuBarButtonRectPixel(GetIconID(mpActiveMBar));
 if( aIconRect.IsEmpty() )
 return nullptr;
 
 auto pBubbleWin = mpBubbleWin;
 
 if ( !pBubbleWin ) {
-pBubbleWin = VclPtr::Create( mpIconSysWin, maBubbleTitle,
+pBubbleWin = VclPtr::Create( mpActiveSysWin, 
maBubbleTitle,
maBubbleText, maBubbleImage );
 mbBubbleChanged = false;
 }
@@ -275,11 +282,11 @@ IMPL_LINK(MenuBarUpdateIconManager, WindowEventHdl, 
VclWindowEvent&, rEvent, voi
 
 if ( VclEventId::ObjectDying == nEventID )
 {
-if ( mpIconSysWin == rEvent.GetWindow() )
+if (mpActiveSysWin == rEvent.GetWindow())
 {
-mpIconSysWin->RemoveEventListener( maWindowEventHdl );
 RemoveBubbleWindow();
-RemoveMenuBarIcon();
+mpActiveSysWin = nullptr;
+mpActiveMBar = nullptr;
 }
 }
 

[Libreoffice-bugs] [Bug 129062] [META] Skia library bugs

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129062

Aron Budea  changed:

   What|Removed |Added

 Depends on||151328


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=151328
[Bug 151328] Skia with anti-aliasing enabled has moire in gradients in edit
mode
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151328] Skia with anti-aliasing enabled has moire in gradients in edit mode

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151328

Aron Budea  changed:

   What|Removed |Added

  Regression By||Luboš Luňák
Version|7.5.0.0 alpha0+ Master  |7.1.0.3 release
 Ever confirmed|0   |1
   Keywords||bibisected, bisected,
   ||regression
 Status|UNCONFIRMED |NEW
 Whiteboard| QA:needsComment|
 CC||aron.bu...@gmail.com
  Component|Impress |graphics stack
 Blocks||129062

--- Comment #1 from Aron Budea  ---
Confirmed, and as 7.0.0.3 is still fine, bibisected using repo win64-7.1 to the
following commit. Adding CC: to Luboš Luňák.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=6965bb07bb33429a7663a3f3ebe58ed89c4327d9
author  Luboš Luňák  2020-09-25 10:00:31
+0200
committer   Luboš Luňák  2020-09-25 19:36:26
+0200

forward axial and radial gradient types to VCL too


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=129062
[Bug 129062] [META] Skia library bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146207] UI: Slide panel too small by default (horizontal visible) and vertical scrollbar masking slide thumbnail

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146207

--- Comment #4 from Telesto  ---
(In reply to Buovjaga from comment #3)
> I'm not seeing this either, can you re-test?
> 
> Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
> Build ID: 651658d37bcb3f493942dd5d0b9a0d65c96f105c
> CPU threads: 2; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL:
> win
> Locale: fi-FI (fi_FI); UI: en-US
> Calc: threaded Jumbo

It's still present for me
Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 651658d37bcb3f493942dd5d0b9a0d65c96f105c
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: nl-NL (nl_NL); UI: nl-NL
Calc: threaded

However, Windows 8.1 will be at end of support on January 10, 2023.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152204] Unicode HTML entity a breve (Ă) is not rendered with

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152204

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   Keywords||filter:html
 CC||stephane.guillou@libreoffic
   ||e.org
Summary|a breve - does not display  |Unicode HTML entity a breve
   |correctly   |(Ă) is not rendered with
   ||
 Blocks||111951

--- Comment #2 from Stéphane Guillou (stragu) 
 ---
To make it explicit, it's the Unicode HTML entity:

CharDec Hex Entity  Name
ă   258 0103 Latin Small Letter A with Breve

https://www.compart.com/en/unicode/U+0103


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=111951
[Bug 111951] [META] HTML import bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 111951] [META] HTML import bugs and enhancements

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=111951

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||152204


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=152204
[Bug 152204] Unicode HTML entity a breve (Ă) is not rendered with 
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152116] Navigator dialog: State of outline headings is lost when navigator is closed then reopened

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152116

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Summary|Navigator: State of outline |Navigator dialog: State of
   |headings is lost when   |outline headings is lost
   |navigator is closed then|when navigator is closed
   |reopened|then reopened

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152202] Copypaste adds extra space in front of word

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152202

--- Comment #2 from LeroyG  ---
Someone wants the added space/s, some other wants no added space/s.
Maybe we need an option that can be unchecked in Tools - Options - Writer -
Formatting Aids.

Related question:
https://ask.libreoffice.org/t/copypaste-adds-unwanted-extra-space-in-front-of-word/84446

Reproducible with:

Version: 7.3.7.2 (x64) / LibreOffice Community
Build ID: e114eadc50a9ff8d8c8a0567d6da8f454beeb84f
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: es-MX (es_ES); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152202] Copypaste adds extra space in front of word

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152202

LeroyG  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||7812

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117812] Incorrect spaces are inserted before the punctuation marks (when cutting and pasting)

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117812

LeroyG  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||2202

--- Comment #7 from LeroyG  ---
If the copied word is the first of a paragraph, no space/s is/are added.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146479] Use basegfx fTools for converting the angle unit

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146479

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g

--- Comment #6 from BogdanB  ---
(In reply to Hossein from comment #4)
> Re-evaluating the EasyHack in 2022
> 
> This is still relevant, as there are many places in the code that needs
> change. For example, see these results:
> 
> git grep -F "/ 180.0" *.cxx

Hossein, with today core I found just one line needing changes. You have
mentioned many places. Is the search term wrong?
sc/source/core/opencl/op_math.cxx:ss << "return arg0 * M_PI /
180.0;\n";

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148435] LibreOffice on macOS hangs on using window snapping / window manager (BetterTouchTool, Rectangle, Raycast, Amethyst, ...) or any other redraw, context switch, etc, from

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148435

--- Comment #53 from Alex Thurgood  ---
(In reply to Peter Hagen from comment #52)
> > @Noel should we set this to fixed verified? Can others verify todays main
> > build no longer exposes the problematic behavior?
> > https://dev-builds.libreoffice.org/daily/master/current.html
> 
> I'm waiting for the M1 version to appear, to test it

Unfortunately, there aren't any that I'm aware of, only x86_64 dev builds.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148416] FILESAVE: Read-only passwords are not requested by default on save-as

2022-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148416

Justin L  changed:

   What|Removed |Added

Summary|FILESAVE XLSX Read-only |FILESAVE: Read-only
   |passwords on XLSX files are |passwords are not requested
   |not working when using Save |by default on save-as
   |as  |
Version|7.4.0.0 alpha0+ |Inherited From OOo
 Ever confirmed|0   |1
 Resolution|DUPLICATE   |---
 Status|RESOLVED|NEW
 CC||jl...@mail.com

--- Comment #5 from Justin L  ---
Using XLSX format is not ideal for this bug report. The password protection for
the provided example is only imported starting in LO 7.3 with
commit 40f38fd16dad4374543d4a7a109b3264837ce8d1
Author: Tünde Tóth on Wed Sep 1 15:47:40 2021 +0200
tdf#115933 XLSX import: fix permission for editing

For ODS format, this password-protected read-only is imported already in LO
3.6. Even back then a save-as doesn't auto-select password mode. Assuming
inherited from OOo.

Yes, this is very similar to bug 142147, but it does not use SID_PASSWORD. In
fact, I didn't see ANYTHING passing by that knew this setting was enabled.
I assume it is SID_MODIFYPASSWORDINFO.

The place to bPreselectPassword is sfx2/source/doc/objserv.cxx

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/qa

2022-11-24 Thread Xisco Fauli (via logerrit)
 sc/qa/unit/helper/qahelper.cxx  |   44 
 sc/qa/unit/helper/qahelper.hxx  |2 -
 sc/qa/unit/ucalc.cxx|2 -
 sc/qa/unit/ucalc_condformat.cxx |2 -
 sc/qa/unit/ucalc_copypaste.cxx  |4 +-
 sc/qa/unit/ucalc_datatransformation.cxx |4 +-
 sc/qa/unit/ucalc_formula.cxx|2 -
 sc/qa/unit/ucalc_parallelism.cxx|6 ++--
 sc/qa/unit/ucalc_pivottable.cxx |2 -
 sc/qa/unit/ucalc_range.cxx  |2 -
 sc/qa/unit/ucalc_rangelst.cxx   |2 -
 sc/qa/unit/ucalc_sharedformula.cxx  |2 -
 sc/qa/unit/ucalc_sort.cxx   |2 -
 sc/qa/unit/ucalc_sparkline.cxx  |2 -
 14 files changed, 39 insertions(+), 39 deletions(-)

New commits:
commit ebe151d919a454f98c36013245bca9eb41d92707
Author: Xisco Fauli 
AuthorDate: Thu Nov 24 17:39:05 2022 +0100
Commit: Xisco Fauli 
CommitDate: Thu Nov 24 20:07:36 2022 +0100

ScSimpleBootstrapFixture -> ScUcalcTestBase

Change-Id: I69def1dccf4f1f35ef1ab14436fc71493b75eb6a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143242
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sc/qa/unit/helper/qahelper.cxx b/sc/qa/unit/helper/qahelper.cxx
index 4624db43510c..27b3c49ada6f 100644
--- a/sc/qa/unit/helper/qahelper.cxx
+++ b/sc/qa/unit/helper/qahelper.cxx
@@ -447,7 +447,7 @@ bool checkOutput(
 return bResult;
 }
 
-void ScSimpleBootstrapFixture::setUp()
+void ScUcalcTestBase::setUp()
 {
 BootstrapFixture::setUp();
 
@@ -461,7 +461,7 @@ void ScSimpleBootstrapFixture::setUp()
 m_pDoc = _xDocShell->GetDocument();
 }
 
-void ScSimpleBootstrapFixture::tearDown()
+void ScUcalcTestBase::tearDown()
 {
 m_xDocShell->DoClose();
 m_xDocShell.clear();
@@ -541,7 +541,7 @@ void ScModelTestBase::miscRowHeightsTest( TestParam const * 
aTestValues, unsigne
 }
 }
 
-ScRange ScSimpleBootstrapFixture::insertRangeData(
+ScRange ScUcalcTestBase::insertRangeData(
 ScDocument* pDoc, const ScAddress& rPos, const 
std::vector>& rData )
 {
 if (rData.empty())
@@ -588,7 +588,7 @@ ScRange ScSimpleBootstrapFixture::insertRangeData(
 return aRange;
 }
 
-ScUndoCut* ScSimpleBootstrapFixture::cutToClip(ScDocShell& rDocSh, const 
ScRange& rRange, ScDocument* pClipDoc, bool bCreateUndo)
+ScUndoCut* ScUcalcTestBase::cutToClip(ScDocShell& rDocSh, const ScRange& 
rRange, ScDocument* pClipDoc, bool bCreateUndo)
 {
 ScDocument* pSrcDoc = ();
 
@@ -622,7 +622,7 @@ ScUndoCut* ScSimpleBootstrapFixture::cutToClip(ScDocShell& 
rDocSh, const ScRange
 return nullptr;
 }
 
-void ScSimpleBootstrapFixture::copyToClip(ScDocument* pSrcDoc, const ScRange& 
rRange, ScDocument* pClipDoc)
+void ScUcalcTestBase::copyToClip(ScDocument* pSrcDoc, const ScRange& rRange, 
ScDocument* pClipDoc)
 {
 ScClipParam aClipParam(rRange, false);
 ScMarkData aMark(pSrcDoc->GetSheetLimits());
@@ -630,14 +630,14 @@ void ScSimpleBootstrapFixture::copyToClip(ScDocument* 
pSrcDoc, const ScRange& rR
 pSrcDoc->CopyToClip(aClipParam, pClipDoc, , false, false);
 }
 
-void ScSimpleBootstrapFixture::pasteFromClip(ScDocument* pDestDoc, const 
ScRange& rDestRange, ScDocument* pClipDoc)
+void ScUcalcTestBase::pasteFromClip(ScDocument* pDestDoc, const ScRange& 
rDestRange, ScDocument* pClipDoc)
 {
 ScMarkData aMark(pDestDoc->GetSheetLimits());
 aMark.SetMarkArea(rDestRange);
 pDestDoc->CopyFromClip(rDestRange, aMark, InsertDeleteFlags::ALL, nullptr, 
pClipDoc);
 }
 
-ScUndoPaste* ScSimpleBootstrapFixture::createUndoPaste(ScDocShell& rDocSh, 
const ScRange& rRange, ScDocumentUniquePtr pUndoDoc)
+ScUndoPaste* ScUcalcTestBase::createUndoPaste(ScDocShell& rDocSh, const 
ScRange& rRange, ScDocumentUniquePtr pUndoDoc)
 {
 ScDocument& rDoc = rDocSh.GetDocument();
 ScMarkData aMarkData(rDoc.GetSheetLimits());
@@ -648,7 +648,7 @@ ScUndoPaste* 
ScSimpleBootstrapFixture::createUndoPaste(ScDocShell& rDocSh, const
 , rRange, aMarkData, std::move(pUndoDoc), nullptr, 
InsertDeleteFlags::ALL, std::move(pRefUndoData), false);
 }
 
-void ScSimpleBootstrapFixture::pasteOneCellFromClip(ScDocument* pDestDoc, 
const ScRange& rDestRange, ScDocument* pClipDoc, InsertDeleteFlags eFlags)
+void ScUcalcTestBase::pasteOneCellFromClip(ScDocument* pDestDoc, const 
ScRange& rDestRange, ScDocument* pClipDoc, InsertDeleteFlags eFlags)
 {
 ScMarkData aMark(pDestDoc->GetSheetLimits());
 aMark.SetMarkArea(rDestRange);
@@ -660,14 +660,14 @@ void 
ScSimpleBootstrapFixture::pasteOneCellFromClip(ScDocument* pDestDoc, const
 rDestRange.aEnd.Col(), rDestRange.aEnd.Row());
 }
 
-void ScSimpleBootstrapFixture::setCalcAsShown(ScDocument* pDoc, bool 
bCalcAsShown)
+void ScUcalcTestBase::setCalcAsShown(ScDocument* pDoc, bool bCalcAsShown)
 {
 ScDocOptions aOpt = pDoc->GetDocOptions();
 aOpt.SetCalcAsShown(bCalcAsShown);
 pDoc->SetDocOptions(aOpt);
 }
 
-ScDocShell* 

[Libreoffice-commits] core.git: sc/qa

2022-11-24 Thread Xisco Fauli (via logerrit)
 sc/qa/unit/helper/qahelper.cxx |   22 --
 sc/qa/unit/helper/qahelper.hxx |9 -
 sc/qa/unit/ucalc_formula.cxx   |9 +++--
 3 files changed, 7 insertions(+), 33 deletions(-)

New commits:
commit e8c78c9d636a1ac26a146bdf37469477f62e71f9
Author: Xisco Fauli 
AuthorDate: Thu Nov 24 17:12:08 2022 +0100
Commit: Xisco Fauli 
CommitDate: Thu Nov 24 20:07:05 2022 +0100

qahelper: drop getTokens and toString

Change-Id: I15f6af9fc6e7f90a1a404e90d5f6ceba4c78626f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143240
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sc/qa/unit/helper/qahelper.cxx b/sc/qa/unit/helper/qahelper.cxx
index bb61fb4eb119..4624db43510c 100644
--- a/sc/qa/unit/helper/qahelper.cxx
+++ b/sc/qa/unit/helper/qahelper.cxx
@@ -409,19 +409,6 @@ ScRangeList ScModelTestBase::getChartRanges(ScDocument& 
rDoc, const SdrOle2Obj&
 return aRanges;
 }
 
-ScTokenArray* getTokens(ScDocument& rDoc, const ScAddress& rPos)
-{
-ScFormulaCell* pCell = rDoc.GetFormulaCell(rPos);
-if (!pCell)
-{
-OUString aStr = rPos.Format(ScRefFlags::VALID);
-cerr << aStr << " is not a formula cell." << endl;
-return nullptr;
-}
-
-return pCell->GetCode();
-}
-
 bool checkOutput(
 const ScDocument* pDoc, const ScRange& aOutRange,
 const std::vector>& aCheck, const char* pCaption )
@@ -460,15 +447,6 @@ bool checkOutput(
 return bResult;
 }
 
-OUString toString(
-ScDocument& rDoc, const ScAddress& rPos, ScTokenArray& rArray, 
formula::FormulaGrammar::Grammar eGram)
-{
-ScCompiler aComp(rDoc, rPos, rArray, eGram);
-OUStringBuffer aBuf;
-aComp.CreateStringFromTokenArray(aBuf);
-return aBuf.makeStringAndClear();
-}
-
 void ScSimpleBootstrapFixture::setUp()
 {
 BootstrapFixture::setUp();
diff --git a/sc/qa/unit/helper/qahelper.hxx b/sc/qa/unit/helper/qahelper.hxx
index 4fb04bcf84b5..aa44f6cb1dc6 100644
--- a/sc/qa/unit/helper/qahelper.hxx
+++ b/sc/qa/unit/helper/qahelper.hxx
@@ -80,13 +80,6 @@ SCQAHELPER_DLLPUBLIC bool checkOutput(
 const ScDocument* pDoc, const ScRange& aOutRange,
 const std::vector>& aCheck, const char* pCaption 
);
 
-/**
- * Convert formula token array to a formula string.
- */
-SCQAHELPER_DLLPUBLIC OUString toString(
-ScDocument& rDoc, const ScAddress& rPos, ScTokenArray& rArray,
-formula::FormulaGrammar::Grammar eGram);
-
 inline std::string print(const ScAddress& rAddr)
 {
 std::ostringstream str;
@@ -196,6 +189,4 @@ private:
 #define ASSERT_DOUBLES_EQUAL_MESSAGE( message, expected, result )   \
 CPPUNIT_ASSERT_DOUBLES_EQUAL_MESSAGE( (message), (expected), (result), 
1e-14 )
 
-SCQAHELPER_DLLPUBLIC ScTokenArray* getTokens(ScDocument& rDoc, const 
ScAddress& rPos);
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/qa/unit/ucalc_formula.cxx b/sc/qa/unit/ucalc_formula.cxx
index dc21cb16c266..248f398b7d49 100644
--- a/sc/qa/unit/ucalc_formula.cxx
+++ b/sc/qa/unit/ucalc_formula.cxx
@@ -1322,7 +1322,11 @@ void TestFormula::testFormulaCompiler()
 std::unique_ptr pArray = compileFormula(m_pDoc, 
OUString::createFromAscii(aTests[i].pInput), aTests[i].eInputGram);
 CPPUNIT_ASSERT_MESSAGE("Token array shouldn't be NULL!", pArray);
 
-OUString aFormula = toString(*m_pDoc, ScAddress(), *pArray, 
aTests[i].eOutputGram);
+ScCompiler aComp(*m_pDoc, ScAddress(), *pArray, aTests[i].eOutputGram);
+OUStringBuffer aBuf;
+aComp.CreateStringFromTokenArray(aBuf);
+OUString aFormula = aBuf.makeStringAndClear();
+
 CPPUNIT_ASSERT_EQUAL(OUString::createFromAscii(aTests[i].pOutput), 
aFormula);
 }
 }
@@ -1837,7 +1841,8 @@ void TestFormula::testFormulaAnnotateTrimOnDoubleRefs()
 std::string aMsgStart = "TestCase#" + std::to_string(nTestIdx + 1) + " 
: ";
 CPPUNIT_ASSERT_EQUAL_MESSAGE(aMsgStart + "Incorrect formula result", 
rTestCase.fResult, m_pDoc->GetValue(ScAddress(4, 0, 0)));
 
-ScTokenArray* pCode = getTokens(*m_pDoc, ScAddress(4, 0, 0));
+ScFormulaCell* pCell = m_pDoc->GetFormulaCell(ScAddress(4, 0, 0));
+ScTokenArray* pCode = pCell->GetCode();
 sal_Int32 nLen = pCode->GetCodeLen();
 FormulaToken** pRPNArray = pCode->GetCode();
 


  1   2   3   >