[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103100

Dieter  changed:

   What|Removed |Added

 Depends on||152307


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=152307
[Bug 152307] Content of row in a table is cut after Tools → Update → Update all
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152307] Content of row in a table is cut after Tools → Update → Update all

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152307

Dieter  changed:

   What|Removed |Added

   Keywords||bibisectRequest
 Ever confirmed|0   |1
 Blocks||103100
 Status|UNCONFIRMED |NEW
 CC||dgp-m...@gmx.de
 OS|Linux (All) |All

--- Comment #1 from Dieter  ---
I confirm it with

Version: 7.4.3.2 (x64) / LibreOffice Community
Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103100
[Bug 103100] [META] Writer table bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152290] Content control with hyperlink coming from glossary document imports wrong

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152290

Dieter  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 CC||dgp-m...@gmx.de

--- Comment #1 from Dieter  ---
I confirm it with

Version: 7.5.0.0.beta1 (X86_64) / LibreOffice Community
Build ID: 3aca23eec42e9d6fbe57071d7633ae1fc4bc5fcc
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-US (de_DE); UI: en-GB
Calc: CL threaded

Vasily, can you have a look at it?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152460] Numeral to right of RTL style name in sidebar and dropdown style previews

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152460

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

  Regression By||Khaled Hosny
   Keywords|bibisectRequest |bibisected, bisected

--- Comment #3 from Stéphane Guillou (stragu) 
 ---
Apologies, in the Description, the commit is completely irrelevant, I probably
copy-pasted wrong.

Bibisected with 7.5 Linux repo, confirmed regression for the sidebar, as
expected starting with:

commit  0483fbd1d05d74c394d9274bdee77b3b2aebb495
author  Khaled Hosny   Sun Aug 21 01:49:57 2022 +0200
committer   Caolán McNamara Mon Aug 22 15:44:36
2022 +0200
tree53c6bf1b3feb33bd8504132be585a02a5cca2244
parent  044fc5c8b225732d57970d3bf0720c13a5a9e0a4

tdf#87535: Preview styles using CTL/CJK fonts in the sidebar

I assume the same issue in the dropdown was introduced by companion commit:

https://git.libreoffice.org/core/commit/044fc5c8b225732d57970d3bf0720c13a5a9e0a4

(In reply to Eyal Rozenberg from comment #2)
> Also, what about elsewhere in the UI, e.g. in the organizer?

Displayed properly in the organiser as it is not a preview. That's what I meant
with the poorly worded "does not match the style properties".

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151290] A language must not be a feature of a character/paragraph style

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151290

--- Comment #4 from Panos Stokas  ---
I like having the ability to set language to None on certain styles.

For example, the style I'm using for programming code is set to Language=none
because I want it to be exempt from spelling checks.

Some styles may have a decorative purpose (eg. those based on Symbol or
Wingdings characters) which again benefit from setting language=none.

However I can't think of a scenario where I would set a specific language to a
style. As Eyal Rozenberg points, language is really part of the content.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146985] Custom animations not working for some elements of a bulleted list

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146985

Clint  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #2 from Clint  ---
(In reply to Buovjaga from comment #1)
> What does this mean? It sounds like we should do a multi-selection of text
> in all 4 lines, but that is not possible in Impress.

I usually do a selection which starts somewhere in the middle of the bottom
line and runs back up until the middle of the first line which doesn't yet have
an animation. So the first and last lines are partially selected and anything
in between is fully selected. Then I hit the '+' button to add an animation.

It usually works fine, but often times only the first bullet point or two
contained in the selection is added to the animation list and the others are
missing. Sometimes when adding the last line of a bulleted list to the
animations in this way, the entry in the animation list will be blank (no
text). Sometimes after going to a different slide and coming back, the text of
the item will appear in the animation list. Other times (rarely) it will remain
blank.

It seems to happen at random, but I'm not sure.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152435] EMFIO: Text is not displayed

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152435

--- Comment #6 from Commit Notification 
 ---
Paris Oplopoios committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/75093a9f7fbde760a3034f41694739c7454cb7eb

tdf#152435 Revert "Make EMR_SAVEDC not UpdateClipRegion"

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152435] EMFIO: Text is not displayed

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152435

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.6.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: emfio/qa emfio/source

2022-12-12 Thread Paris Oplopoios (via logerrit)
 emfio/qa/cppunit/emf/EmfImportTest.cxx |   15 ++-
 emfio/source/reader/mtftools.cxx   |1 +
 2 files changed, 7 insertions(+), 9 deletions(-)

New commits:
commit 75093a9f7fbde760a3034f41694739c7454cb7eb
Author: Paris Oplopoios 
AuthorDate: Mon Dec 12 11:30:27 2022 +
Commit: Miklos Vajna 
CommitDate: Tue Dec 13 06:59:06 2022 +

tdf#152435 Revert "Make EMR_SAVEDC not UpdateClipRegion"

This reverts commit 1230b88055c7389d2c376c316f91549e4aaef8aa.

Reason for revert:
The reverted commit breaks the files documented in tdf#152435 (some
text is not shown in those .EMF files). The reverted commit would solve
an issue where some text was not clipped correctly, albeit in a naive
way. As it is more important that text is shown rather than some text
having correct clipping, that patch is reverted and I will look for one
that fixes both cases.

Change-Id: I42e85b802b8bf1e77e96f0016cd1d83201047032
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143970
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/emfio/qa/cppunit/emf/EmfImportTest.cxx 
b/emfio/qa/cppunit/emf/EmfImportTest.cxx
index 3d77dd95e5a0..75f2b9001a08 100644
--- a/emfio/qa/cppunit/emf/EmfImportTest.cxx
+++ b/emfio/qa/cppunit/emf/EmfImportTest.cxx
@@ -1019,19 +1019,16 @@ void Test::TestEmfPlusSave()
 
 assertXPath(pDocument, aXPathPrefix + "mask/polypolygon", "path", "m0 
0h33544v21311h-33544z");
 
-assertXPath(pDocument, aXPathPrefix + 
"mask/group/mask/polypolygoncolor[1]/polypolygon", "path",
+assertXPath(pDocument, aXPathPrefix + 
"mask/group/mask/polypolygoncolor/polypolygon", "path",
 "m327.4583 
638.h437007.1875v29.6h-437007.1875z");
-assertXPath(pDocument, aXPathPrefix + 
"mask/group/mask/polypolygoncolor[1]", "color",
-"#ff0cad");
+assertXPath(pDocument, aXPathPrefix + "mask/group/mask/polypolygoncolor", 
"color", "#ff0cad");
 
-assertXPath(pDocument, aXPathPrefix + 
"mask/group/mask/polypolygoncolor[2]/polypolygon", "path",
+assertXPath(pDocument, aXPathPrefix + "mask/polypolygoncolor/polypolygon", 
"path",
 "m10853.4145539602 
7321.41354709201h41952690v29630720h-41952690z");
-assertXPath(pDocument, aXPathPrefix + 
"mask/group/mask/polypolygoncolor[2]", "color",
-"#00ffad");
+assertXPath(pDocument, aXPathPrefix + "mask/polypolygoncolor", "color", 
"#00ffad");
 
-assertXPath(pDocument, aXPathPrefix + 
"mask/group/mask/polygonstrokearrow/line", "color",
-"#00");
-assertXPathContent(pDocument, aXPathPrefix + 
"mask/group/mask/polygonstrokearrow/polygon",
+assertXPath(pDocument, aXPathPrefix + "mask/polygonstrokearrow/line", 
"color", "#00");
+assertXPathContent(pDocument, aXPathPrefix + 
"mask/polygonstrokearrow/polygon",
"10853.4145539602,7321.41354709201 
10853.4145539602,4907.54325697157 "
"12832.6557236512,4907.54325697157");
 }
diff --git a/emfio/source/reader/mtftools.cxx b/emfio/source/reader/mtftools.cxx
index 2683151166b2..7f067e4fcd15 100644
--- a/emfio/source/reader/mtftools.cxx
+++ b/emfio/source/reader/mtftools.cxx
@@ -2365,6 +2365,7 @@ namespace emfio
 
 void MtfTools::Push()   // !! to be able to access the 
original ClipRegion it
 {   // is not allowed to use 
the MetaPushAction()
+UpdateClipRegion(); // (the original clip 
region is on top of the stack) (SJ)
 auto pSave = std::make_shared();
 
 pSave->aLineStyle = maLineStyle;


[Libreoffice-commits] core.git: sw/inc

2022-12-12 Thread Miklos Vajna (via logerrit)
 sw/inc/dpage.hxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit dabb07a77df33cc1b9732f7276f3d29b8e7e7810
Author: Miklos Vajna 
AuthorDate: Mon Dec 12 20:16:13 2022 +0100
Commit: Miklos Vajna 
CommitDate: Tue Dec 13 06:57:58 2022 +

sw: document SwDPage

That shared draw page means explicit clipping is needed at many places,
e.g. this is the reason SdrPageView::DrawLayer() has a page frame
parameter.

Change-Id: I6b36c977a30d44e449b8b3a46ac4368f34210887
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144009
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sw/inc/dpage.hxx b/sw/inc/dpage.hxx
index c5a5c45a9813..16d5b4650169 100644
--- a/sw/inc/dpage.hxx
+++ b/sw/inc/dpage.hxx
@@ -27,6 +27,9 @@ class SdrPageGridFrameList;
 class SwDrawModel;
 class SwDoc;
 
+/// SwDPage is Writer's draw page: derives from SdrPage, but has a reference 
to the Writer document
+/// via SwDrawModel. One Writer document has 1 draw page, i.e. all Writer 
pages share the same draw
+/// page.
 class SwDPage final : public FmFormPage, public SdrObjUserCall
 {
 SwDPage =(const SwDPage&) = delete;


[Libreoffice-bugs] [Bug 151758] Teg w:ins & w:del

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151758

Dieter  changed:

   What|Removed |Added

 Status|NEW |UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #26 from Dieter  ---
(In reply to Roman from comment #25)
> I think I forgot to add new

No, you can't confirm your own bug report.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/qa sw/source

2022-12-12 Thread offtkp (via logerrit)
 sw/qa/uibase/wrtsh/wrtsh.cxx  |7 +++
 sw/source/core/txtnode/attrcontentcontrol.cxx |1 -
 sw/source/uibase/wrtsh/wrtsh1.cxx |   14 ++
 sw/source/uibase/wrtsh/wrtsh3.cxx |4 
 4 files changed, 21 insertions(+), 5 deletions(-)

New commits:
commit 618cef756b87f9816d0dcbe04af163ccd06a986e
Author: offtkp 
AuthorDate: Mon Dec 12 13:03:43 2022 +0200
Commit: Miklos Vajna 
CommitDate: Tue Dec 13 06:44:03 2022 +

docx: Do not remove showingPlcHdr until edit

When a placeholder has the showingPlcHdr attribute, the entire text is
selected upon click. This is no longer removed by selecting it once but
once the text has been edited.

Change-Id: I9a4d68289c8b95ab0098e55a5fa6edb1606c7df2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143985
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sw/qa/uibase/wrtsh/wrtsh.cxx b/sw/qa/uibase/wrtsh/wrtsh.cxx
index d2adde32a179..a2d9fdc37514 100644
--- a/sw/qa/uibase/wrtsh/wrtsh.cxx
+++ b/sw/qa/uibase/wrtsh/wrtsh.cxx
@@ -399,6 +399,13 @@ CPPUNIT_TEST_FIXTURE(Test, 
testInsertPlainTextContentControl)
 // Without the accompanying fix in place, this test would have failed, 
there was no special
 // handling for plain text content controls.
 CPPUNIT_ASSERT(pContentControl->GetPlainText());
+
+CPPUNIT_ASSERT(pContentControl->GetShowingPlaceHolder());
+pWrtShell->GotoContentControl(rFormatContentControl);
+CPPUNIT_ASSERT(pContentControl->GetShowingPlaceHolder());
+pWrtShell->Insert("Foo");
+// No longer showing placeholder text, as it has been changed
+CPPUNIT_ASSERT(!pContentControl->GetShowingPlaceHolder());
 }
 
 CPPUNIT_TEST_FIXTURE(Test, testInsertComboBoxContentControl)
diff --git a/sw/source/core/txtnode/attrcontentcontrol.cxx 
b/sw/source/core/txtnode/attrcontentcontrol.cxx
index 890bf20c1376..1db39849fbe6 100644
--- a/sw/source/core/txtnode/attrcontentcontrol.cxx
+++ b/sw/source/core/txtnode/attrcontentcontrol.cxx
@@ -720,7 +720,6 @@ void SwTextContentControl::Invalidate()
 pDocShell->GetWrtShell()->Push();
 
 // visit the control in the text (which makes any necessary visual changes)
-// NOTE: simply going to a control indicates cancelling 
ShowingPlaceHolder, unless bOnlyRefresh
 // NOTE: simply going to a checkbox causes a toggle, unless bOnlyRefresh
 auto& rFormatContentControl = 
static_cast(GetAttr());
 pDocShell->GetWrtShell()->GotoContentControl(rFormatContentControl, 
/*bOnlyRefresh=*/true);
diff --git a/sw/source/uibase/wrtsh/wrtsh1.cxx 
b/sw/source/uibase/wrtsh/wrtsh1.cxx
index adf96052e8fa..b989343266cb 100644
--- a/sw/source/uibase/wrtsh/wrtsh1.cxx
+++ b/sw/source/uibase/wrtsh/wrtsh1.cxx
@@ -117,6 +117,7 @@
 #include 
 #include 
 #include 
+#include 
 
 using namespace sw::mark;
 using namespace com::sun::star;
@@ -262,6 +263,19 @@ void SwWrtShell::Insert( const OUString  )
 bCallIns ?
 SwEditShell::Insert2( rStr, bDeleted ) : SwEditShell::Overwrite( rStr 
);
 
+// Check whether node is content control
+SwTextContentControl* pTextContentControl = CursorInsideContentControl();
+if (pTextContentControl)
+{
+std::shared_ptr pContentControl =
+pTextContentControl->GetContentControl().GetContentControl();
+if (pContentControl)
+{
+// Set showingPlcHdr to false as node has been edited
+pContentControl->SetShowingPlaceHolder(false);
+}
+}
+
 if( bStarted )
 {
 EndUndo();
diff --git a/sw/source/uibase/wrtsh/wrtsh3.cxx 
b/sw/source/uibase/wrtsh/wrtsh3.cxx
index aa170d1374a4..4e80bfc1e3d1 100644
--- a/sw/source/uibase/wrtsh/wrtsh3.cxx
+++ b/sw/source/uibase/wrtsh/wrtsh3.cxx
@@ -125,10 +125,6 @@ bool SwWrtShell::GotoContentControl(const 
SwFormatContentControl& rContentContro
 (this->*m_fnKillSel)(nullptr, false);
 
 bool bRet = SwCursorShell::GotoFormatContentControl(rContentControl);
-// Assume that once the placeholder is selected, the content is no longer 
the placeholder.
-if (!bOnlyRefresh && pContentControl)
-pContentControl->SetShowingPlaceHolder(false);
-
 
 if (bRet && pContentControl && pContentControl->GetCheckbox())
 {


[Libreoffice-bugs] [Bug 152385] circular dependency calculation fails, in excel its correct

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152385

solot...@gmail.com changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152385] circular dependency calculation fails, in excel its correct

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152385

--- Comment #4 from solot...@gmail.com ---
Created attachment 184123
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184123=edit
wrong, 812 is only once, other fields still have old value

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152385] circular dependency calculation fails, in excel its correct

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152385

--- Comment #3 from solot...@gmail.com ---
Created attachment 184122
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184122=edit
correct

initial state, correct.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152490] New: YOUR A NEUWB codiena

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152490

Bug ID: 152490
   Summary: YOUR A NEUWB codiena
   Product: LibreOffice
   Version: 7.5.0.0 beta1+
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: sdk
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: cr6xpli...@gmail.com

Description:
fix templates saving improper when there's a interdividor
you know there's an issue with wonk performance or you wouldn't blue it pint

Steps to Reproduce:
1. go spend an hour making a business card template
2.
3. go save midway in keep saving all along Open it up at different times and
tell me when it has probleone side collapses into the other instead of saying
properly in its 'cell's it bed

Actual Results:
retardation of print

Expected Results:
keep displayable and not drop text bg with engrave nor resize
not cho p between pages


Reproducible: Always


User Profile Reset: No

Additional Info:
[Information automatically included from LibreOffice]
Locale: en-US
Module: TextDocument
[Information guessed from browser]
OS: Windows (All)
OS is 64bit: no

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152385] circular dependency calculation fails, in excel its correct

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152385

--- Comment #2 from solot...@gmail.com ---
i enabled it and let it be default 100 / 0.001, then 1000 / 0.001. it changed
the result that one needs to only 2-3 times enter it to get the correct result.

Version: 7.4.3.2 / LibreOffice Community
Build ID: 40(Build:2)
CPU threads: 4; OS: Linux 6.0; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
7.4.3-3
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: 2 commits - sw/source vcl/osx vcl/source

2022-12-12 Thread Patrick Luby (via logerrit)
 sw/source/core/layout/layact.cxx |   12 ++
 vcl/osx/salinst.cxx  |   44 ---
 vcl/source/gdi/print3.cxx|   10 
 3 files changed, 63 insertions(+), 3 deletions(-)

New commits:
commit 229b0ce8d8453960c213da59770b8bb7b6dca895
Author: Patrick Luby 
AuthorDate: Wed Dec 7 11:40:18 2022 -0500
Commit: Noel Grandin 
CommitDate: Tue Dec 13 06:08:54 2022 +

tdf#151700 Display native print panel even if there are no printers

Prevent the non-native LibreOffice PrintDialog from displaying by creating 
a fake printer if there are no printers. This will allow the LibreOffice 
printing code to proceed with native NSPrintOperation which will display the 
native print panel.

Change-Id: Iee13305520360b0165464889f0ee51b1207dd5ce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143794
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/vcl/osx/salinst.cxx b/vcl/osx/salinst.cxx
index 22a024bc265d..e8a4a94efc08 100644
--- a/vcl/osx/salinst.cxx
+++ b/vcl/osx/salinst.cxx
@@ -60,6 +60,7 @@
 #include 
 
 #include 
+#include 
 
 #include 
 
@@ -125,6 +126,20 @@ public:
 
 }
 
+static OUString& getFallbackPrinterName()
+{
+static OUString aFallbackPrinter;
+
+if ( aFallbackPrinter.isEmpty() )
+{
+aFallbackPrinter = VclResId( SV_PRINT_DEFPRT_TXT );
+if ( aFallbackPrinter.isEmpty() )
+aFallbackPrinter = "Printer";
+}
+
+return aFallbackPrinter;
+}
+
 void AquaSalInstance::delayedSettingsChanged( bool bInvalidate )
 {
 osl::Guard< comphelper::SolarMutex > aGuard( *GetYieldMutex() );
@@ -765,6 +780,20 @@ void AquaSalInstance::GetPrinterQueueInfo( 
ImplPrnQueueList* pList )
 pList->Add( std::move(pInfo) );
 }
 }
+
+// tdf#151700 Prevent the non-native LibreOffice PrintDialog from
+// displaying by creating a fake printer if there are no printers. This
+// will allow the LibreOffice printing code to proceed with native
+// NSPrintOperation which will display the native print panel.
+if ( !nNameCount )
+{
+std::unique_ptr pInfo(new SalPrinterQueueInfo);
+pInfo->maPrinterName= getFallbackPrinterName();
+pInfo->mnStatus = PrintQueueFlags::NONE;
+pInfo->mnJobs   = 0;
+
+pList->Add( std::move(pInfo) );
+}
 }
 
 void AquaSalInstance::GetPrinterQueueState( SalPrinterQueueInfo* )
@@ -776,7 +805,9 @@ OUString AquaSalInstance::GetDefaultPrinter()
 // #i113170# may not be the main thread if called from UNO API
 SalData::ensureThreadAutoreleasePool();
 
-if( maDefaultPrinter.isEmpty() )
+// WinSalInstance::GetDefaultPrinter() fetches current default printer
+// on every call so do the same here
+OUString aDefaultPrinter;
 {
 NSPrintInfo* pPI = [NSPrintInfo sharedPrintInfo];
 SAL_WARN_IF( !pPI, "vcl", "no print info" );
@@ -786,13 +817,20 @@ OUString AquaSalInstance::GetDefaultPrinter()
 SAL_WARN_IF( !pPr, "vcl", "no printer in default info" );
 if( pPr )
 {
+// Related: tdf#151700 Return the name of the fake printer if
+// there are no printers so that the LibreOffice printing code
+// will be able to find the the fake printer returned by
+// AquaSalInstance::GetPrinterQueueInfo()
 NSString* pDefName = [pPr name];
 SAL_WARN_IF( !pDefName, "vcl", "printer has no name" );
-maDefaultPrinter = GetOUString( pDefName );
+if ( pDefName && [pDefName length])
+aDefaultPrinter = GetOUString( pDefName );
+else
+aDefaultPrinter = getFallbackPrinterName();
 }
 }
 }
-return maDefaultPrinter;
+return aDefaultPrinter;
 }
 
 SalInfoPrinter* AquaSalInstance::CreateInfoPrinter( SalPrinterQueueInfo* 
pQueueInfo,
diff --git a/vcl/source/gdi/print3.cxx b/vcl/source/gdi/print3.cxx
index e8acbcd38297..dc2fc5e74d35 100644
--- a/vcl/source/gdi/print3.cxx
+++ b/vcl/source/gdi/print3.cxx
@@ -538,6 +538,16 @@ bool 
Printer::PreparePrintJob(std::shared_ptr xController,
 {
 }
 }
+#ifdef MACOSX
+else
+{
+// The PrintDialog updates the printer list in its constructor so do
+// the same for printers that bring up their own dialog since. Not
+// sure if this is needed or not on Windows or X11, so limit only to
+// macOS for now.
+Printer::updatePrinters();
+}
+#endif
 
 xController->pushPropertiesToPrinter();
 return true;
commit d491791dad8c3a946dac8c4dfd28ef0c4cb65ce5
Author: Patrick Luby 
AuthorDate: Sun Dec 11 14:41:15 2022 -0500
Commit: Noel Grandin 
CommitDate: Tue Dec 13 06:08:40 2022 +

Fix infinite loop in sw_ooxmlexport17 unit test on macOS Intel

When running the sw_ooxmlexport17 unit test on 

[Libreoffice-bugs] [Bug 151758] Teg w:ins & w:del

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151758

Roman  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #25 from Roman  ---
I think I forgot to add new

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152271] matching parenthesis highlighting becomes permanent when at end of cell

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152271

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150540] Add accessibility features to images

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150540

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152272] wrong properties dialog for print to file / paper size limited on print to file

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152272

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152261] Inserting a TOC in a document using UNO locks writer

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152261

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152260] Template Name Has Dark Text on Dark

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152260

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152259] Clear (and correct) syntax of address is needed on "Addresses and References, Absolute and Relative"

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152259

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 73613] UI: Poor thumbnail / preview of Calc files with wide columns in start center

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=73613

--- Comment #10 from QA Administrators  ---
Dear Andy,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 48294] EDITING: Edit >Links is always gray/deactivated & (thus) impossible break link to media file using

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=48294

--- Comment #16 from QA Administrators  ---
Dear sasha.libreoffice,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 137247] Unable to detach embedded font from base form when editing one

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137247

--- Comment #5 from QA Administrators  ---
Dear philnsicab,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117307] EDITING Comments in headers are duplicated after Row delete and Undo

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117307

--- Comment #7 from QA Administrators  ---
Dear Emil Tanev,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 116148] FILESAVE PPTX hatching in chart becomes a solid bar

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116148

--- Comment #12 from QA Administrators  ---
Dear Gerald Pfeifer,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112994] EDITING Unable to delete hyperlink from hyperlink dialog

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112994

--- Comment #4 from QA Administrators  ---
Dear Emil Tanev,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - sysui/desktop

2022-12-12 Thread galjit (via logerrit)
 dev/null|binary
 sysui/desktop/icons/base_app.ico|binary
 sysui/desktop/icons/calc_app.ico|binary
 sysui/desktop/icons/database.ico|binary
 sysui/desktop/icons/draw_app.ico|binary
 sysui/desktop/icons/drawing-template.ico|binary
 sysui/desktop/icons/drawing.ico |binary
 sysui/desktop/icons/formula.ico |binary
 sysui/desktop/icons/impress_app.ico |binary
 sysui/desktop/icons/master-document.ico |binary
 sysui/desktop/icons/math_app.ico|binary
 sysui/desktop/icons/oasis-database.ico  |binary
 sysui/desktop/icons/oasis-drawing-template.ico  |binary
 sysui/desktop/icons/oasis-drawing.ico   |binary
 sysui/desktop/icons/oasis-formula.ico   |binary
 sysui/desktop/icons/oasis-master-document.ico   |binary
 sysui/desktop/icons/oasis-presentation-template.ico |binary
 sysui/desktop/icons/oasis-presentation.ico  |binary
 sysui/desktop/icons/oasis-spreadsheet-template.ico  |binary
 sysui/desktop/icons/oasis-spreadsheet.ico   |binary
 sysui/desktop/icons/oasis-text-template.ico |binary
 sysui/desktop/icons/oasis-text.ico  |binary
 sysui/desktop/icons/oasis-web-template.ico  |binary
 sysui/desktop/icons/oxt-extension.ico   |binary
 sysui/desktop/icons/presentation-template.ico   |binary
 sysui/desktop/icons/presentation.ico|binary
 sysui/desktop/icons/soffice.ico |binary
 sysui/desktop/icons/spreadsheet-template.ico|binary
 sysui/desktop/icons/spreadsheet.ico |binary
 sysui/desktop/icons/text-template.ico   |binary
 sysui/desktop/icons/text.ico|binary
 sysui/desktop/icons/writer_app.ico  |binary
 32 files changed

New commits:
commit 2ee9bb7ce0dde890cac9971d88788c596de550cf
Author: galjit 
AuthorDate: Fri Dec 9 20:38:21 2022 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Tue Dec 13 03:05:01 2022 +

Related tdf#132398 - Update .ico files - Dec 2022

Updated .ico files based on the new hicolor icons
Also deleted those that were not listed in any WinResTarget file

Change-Id: If536ea51518d531918b4dda2d2330d7cc7487c93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143885
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Adolfo Jayme Barrientos 
(cherry picked from commit 31a953c7edb22f5fac1e81d92db24e1915b9b317)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144022
Tested-by: Jenkins

diff --git a/sysui/desktop/icons/base_app.ico b/sysui/desktop/icons/base_app.ico
index 5b4bdb30ec72..be8501076a89 100644
Binary files a/sysui/desktop/icons/base_app.ico and 
b/sysui/desktop/icons/base_app.ico differ
diff --git a/sysui/desktop/icons/calc_app.ico b/sysui/desktop/icons/calc_app.ico
index 14a8b39dd2b2..03a709f3ec20 100644
Binary files a/sysui/desktop/icons/calc_app.ico and 
b/sysui/desktop/icons/calc_app.ico differ
diff --git a/sysui/desktop/icons/database.ico b/sysui/desktop/icons/database.ico
index 5b7e091543a0..1700eab51d1b 100644
Binary files a/sysui/desktop/icons/database.ico and 
b/sysui/desktop/icons/database.ico differ
diff --git a/sysui/desktop/icons/draw_app.ico b/sysui/desktop/icons/draw_app.ico
index 52cdfe4dc92b..bde547b8e507 100644
Binary files a/sysui/desktop/icons/draw_app.ico and 
b/sysui/desktop/icons/draw_app.ico differ
diff --git a/sysui/desktop/icons/drawing-template.ico 
b/sysui/desktop/icons/drawing-template.ico
index b7f50e2b829b..d04c3cee7467 100644
Binary files a/sysui/desktop/icons/drawing-template.ico and 
b/sysui/desktop/icons/drawing-template.ico differ
diff --git a/sysui/desktop/icons/drawing.ico b/sysui/desktop/icons/drawing.ico
index 67a22ca6bce7..d04c3cee7467 100644
Binary files a/sysui/desktop/icons/drawing.ico and 
b/sysui/desktop/icons/drawing.ico differ
diff --git a/sysui/desktop/icons/empty-document.ico 
b/sysui/desktop/icons/empty-document.ico
deleted file mode 100644
index 56e1e4e00c99..
Binary files a/sysui/desktop/icons/empty-document.ico and /dev/null differ
diff --git a/sysui/desktop/icons/empty-template.ico 
b/sysui/desktop/icons/empty-template.ico
deleted file mode 100644
index 56e1e4e00c99..
Binary files a/sysui/desktop/icons/empty-template.ico and /dev/null differ
diff --git a/sysui/desktop/icons/formula.ico b/sysui/desktop/icons/formula.ico
index eac96dcbe5c0..faf46fd1b607 100644
Binary files a/sysui/desktop/icons/formula.ico and 
b/sysui/desktop/icons/formula.ico differ
diff --git a/sysui/desktop/icons/impress_app.ico 
b/sysui/desktop/icons/impress_app.ico
index 235d7cf91945..dda40831ed5e 100644
Binary files a/sysui/desktop/icons/impress_app.ico and 
b/sysui/desktop/icons/impress_app.ico differ
diff --git a/sysui/desktop/icons/master-document.ico 

[Libreoffice-bugs] [Bug 70976] SLIDESHOW: Thin white lines (or desktop color) visible on the right edge and bottom side of screen when running slideshow

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=70976

--- Comment #27 from libreofficeb...@toeai.com ---
I concur with Comment 20 that this seems to be related to fuzzy or naive
arithmetic.  I did quite a few tests and observed the results.  I won't bore
you with all the details, but in general I found:

1) I did not experience any desktop showing.  The defects are these:
a) There are black lines of various widths on the outside always affecting
bottom and right but sometimes also left side.
b) Inside the black lines, there are sometimes white lines of various
widths on the bottom and right.
c) Inside the white lines if present, or inside the black lines if there
are no white lines, there are variously colored lines always 1px thick
affecting the bottom and right sides, or sometimes just the bottom or just the
right.  When they are both present, they are not the same color as each other,
and the lines meet at a single pixel which is a different color from either
line.  The colors of these lines are related to the slide's background color
and to the presentation size (see below), but I haven't found an exact formula.
 Like the white lines, these lines are entirely inside any black lines, so if
the screen has a black line on the left, this colored horizontal line will not
extend into it.

2) The area of the screen affected (i.e. the widths and presence of the lines
described above) is dependent on the size of the presentation (i.e.
width/height in inches of the slide).  The only thing that changes by changing
the background color is the color of the variably colored 1px lines.

3) The defect is magnified by decreasing the presentation size, minimized by
increasing the presentation size.

I have not yet found a size that makes the defect go away entirely.  If your
background color is black, it may be a workaround to set a ridiculously large
presentation size, because even though the black lines will still be present,
they will be small and the white and variously colored lines don't seem to show
up then.

Here are the details from just four tests, going by orders of magnitude.  The
background color in these tests was set to Indigo (0x55308d).  Output screen
was 1366 x 768 pixels.  Colors of variable lines given in RGB hexadecimal.

User defined size: 160"x90"
results:
1px black line on bottom.
2px black line on right.

User defined size: 16"x9"
results:
1px black line on bottom.
2px black line on right.

User defined size: 1.6"x0.9"
results:
1px black line on bottom.
2px black line on right.
5px white line horizontally and 3px white line vertically just inside the black
lines.
nexus pixel (0xf3f0f7) at inside corner of white lines joining 1px vertical
line (0xe1daeb) and 1px horizontal line (0xbbacd1).

User defined size: 0.16"x0.09"
results:
2px black line on left.
1px black line on bottom.
4px black line on right.
32px white line horizontally and 58px white line vertically just inside black
lines.
nexus pixel (0xf7f5fa) at inside corner of white lines joining 1px vertical
line (0xebe7f2) and 1px horizontal line (0xbbacd1).

Screenshots or other tests available on request.

Observed on:
OS: Kubuntu
screen size: 1366x768
version info:
-
Version: 7.4.2.3 / LibreOffice Community
Build ID: 40(Build:3)
CPU threads: 4; OS: Linux 5.19; UI render: default; VCL: x11
Locale: en-US (en_US.UTF-8); UI: en-US
Ubuntu package version: 1:7.4.2~rc3-0ubuntu1
Calc: threaded
-

This might seem to some like a "minor" bug of only "medium" importance, but
it's the sort bug that makes it hard to take LibreOffice Impress seriously (and
I really want to because I work on Linux mostly and because MS PowerPoint is a
very buggy expensive piece of junk).  For a bug to go back nearly a decade now
and exist on all platforms?  Not minor.  How many people have been turned off
from using Impress just by observing that it can't even do the simplest of
things right (show me a blank screen), let alone reliably do anything
complicated or fancy?

And at ultra low presentation sizes (see above) we're not talking about a pixel
or two.  2+1+58+4 = 65 pixels!  This isn't merely an "off by one" error.  It
appears to involve someone making some super naive assumptions/calculations
about foundational geometry.

I'm not here to complain about free software.  I'm trying to help see it
improved, if possible, so please let me know if I can provide more helpful
details.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 113023] [META] MacOS performance issues

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113023
Bug 113023 depends on bug 150159, which changed state.

Bug 150159 Summary: LibreOffice Crashes/Unstable with Mac M1 Pro Apple Silicon 
with BetterTouchTool and Rectangle (accessibility tools)
https://bugs.documentfoundation.org/show_bug.cgi?id=150159

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 55571] [META] ACCESSIBILITY: Tracking bug for issues related to the macOS Accessibility API

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=55571
Bug 55571 depends on bug 150159, which changed state.

Bug 150159 Summary: LibreOffice Crashes/Unstable with Mac M1 Pro Apple Silicon 
with BetterTouchTool and Rectangle (accessibility tools)
https://bugs.documentfoundation.org/show_bug.cgi?id=150159

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148435] LibreOffice on macOS hangs on using window snapping / window manager (BetterTouchTool, Rectangle, Raycast, Amethyst, ...) or any other redraw, context switch, etc, from

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148435

steve  changed:

   What|Removed |Added

 CC||sidhush...@gmail.com

--- Comment #71 from steve  ---
*** Bug 150159 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150159] LibreOffice Crashes/Unstable with Mac M1 Pro Apple Silicon with BetterTouchTool and Rectangle (accessibility tools)

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150159

steve  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEEDINFO|RESOLVED

--- Comment #15 from steve  ---


*** This bug has been marked as a duplicate of bug 148435 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148435] LibreOffice on macOS hangs on using window snapping / window manager (BetterTouchTool, Rectangle, Raycast, Amethyst, ...) or any other redraw, context switch, etc, from

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148435

steve  changed:

   What|Removed |Added

 CC||irrevdj...@gmx.co.uk

--- Comment #70 from steve  ---
*** Bug 152489 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152489] Libre Office window management on Mac OS Ventura 13.0.1 is unstable and leads to crashes with keyboard shortcuts

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152489

steve  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from steve  ---


*** This bug has been marked as a duplicate of bug 148435 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150159] LibreOffice Crashes/Unstable with Mac M1 Pro Apple Silicon with BetterTouchTool and Rectangle (accessibility tools)

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150159

steve  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #14 from steve  ---
I still believe this to be a dupe of
https://bugs.documentfoundation.org/show_bug.cgi?id=148435

@Shaun please retry with
https://dev-builds.libreoffice.org/daily/master/current.html and let us know if
then the issue is persisting.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151753] Cannot change data range of Chart based on non-continues range of Writer table

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151753

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 OS|Windows (All)   |All
 Blocks||90486
   Keywords||bibisectRequest, regression
 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #3 from Stéphane Guillou (stragu) 
 ---
Reproduced with:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 01c9c971e43782800ebf63acc763a7e7fba096c1
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Expanding the range to include cell A1 makes the range valid again, however
saving and reopening the file modifies again the range to exclude the cell,
turns it red and disallows clicking OK or changing tabs.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=90486
[Bug 90486] [META] Chart bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 90486] [META] Chart bugs and enhancements

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90486

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||151753


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=151753
[Bug 151753] Cannot change data range of Chart based on non-continues range of
Writer table
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 136940] A thin vertical line is visible in presentation mode

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136940

libreofficeb...@toeai.com changed:

   What|Removed |Added

 CC||libreofficeb...@toeai.com

--- Comment #13 from libreofficeb...@toeai.com ---
Created attachment 184121
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184121=edit
screenshot of attachment 165745 displayed on another computer

Ha!  If you thought one line was bad, look how attachment 165745 renders on my
computer.  (Whole thing is crisscrossed with lines.  Also notice how wavy the
"brick" lines are.)
Observed on:
OS: Kubuntu 22.10
screen size: 1366x768
version info:
-
Version: 7.4.2.3 / LibreOffice Community
Build ID: 40(Build:3)
CPU threads: 4; OS: Linux 5.19; UI render: default; VCL: x11
Locale: en-US (en_US.UTF-8); UI: en-US
Ubuntu package version: 1:7.4.2~rc3-0ubuntu1
Calc: threaded
-

And yes, to the last comment, this bug is very unlike Bug 70976.

I'd guess that at least one issue is fuzzy or naive arithmetic used in piecing
together the squares of repeating pattern.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 90486] [META] Chart bugs and enhancements

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90486

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||151528


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=151528
[Bug 151528] Chart data table is placed in the horizontal axis, negative values
partially covered
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151528] Chart data table is placed in the horizontal axis, negative values partially covered

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151528

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Blocks||90486


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=90486
[Bug 90486] [META] Chart bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 90486] [META] Chart bugs and enhancements

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90486
Bug 90486 depends on bug 138833, which changed state.

Bug 138833 Summary: Impossible to save a Calc file with a chart with an invalid 
data range obtained when converting from data table
https://bugs.documentfoundation.org/show_bug.cgi?id=138833

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138833] Impossible to save a Calc file with a chart with an invalid data range obtained when converting from data table

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138833

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Version|7.0.2.2 release |6.3.6.2 release
 Resolution|--- |WORKSFORME
 CC||stephane.guillou@libreoffic
   ||e.org
 Status|NEW |RESOLVED

--- Comment #6 from Stéphane Guillou (stragu) 
 ---
I could reproduce in 6.3.6.2, but no error when saving anymore, since at least:

Version: 7.4.3.2 / LibreOffice Community
Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - configure.ac

2022-12-12 Thread Thorsten Behrens (via logerrit)
 configure.ac |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 7c09d780f9d0803935f939a489ca371318056fdc
Author: Thorsten Behrens 
AuthorDate: Sun Dec 11 23:06:34 2022 +0100
Commit: Thorsten Behrens 
CommitDate: Mon Dec 12 23:09:17 2022 +

Add oox to build side, for cross compilation

With ce4c154e8b254f3bcd59ea46b3db4bd3d5a26058, cui now depends on oox
generated headers, so we need to build oox too, for cross builds.

Change-Id: I1af3116ab35c5094c23db3ed3dccd90c80080cef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143975
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 
(cherry picked from commit 599f9836a674ec525e56fa787a800d7ed4be3383)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143963

diff --git a/configure.ac b/configure.ac
index 9e92838241e2..93e02435e639 100644
--- a/configure.ac
+++ b/configure.ac
@@ -5797,6 +5797,7 @@ if test "$cross_compiling" = "yes"; then
 LIBXSLT
 MDDS
 NATIVE
+OOX
 OPENSSL
 ORCUS
 PYTHON


[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - configure.ac

2022-12-12 Thread Thorsten Behrens (via logerrit)
 configure.ac |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit e2af567b99d61a209da21657ec6e0cf641034e86
Author: Thorsten Behrens 
AuthorDate: Sun Dec 11 00:19:53 2022 +0100
Commit: Thorsten Behrens 
CommitDate: Mon Dec 12 23:07:50 2022 +

Replace backslashes in config params before usage in cxx files

With cbfac11330882c7d0a817b6c37a08b2ace2b66f4, LOKit tries to pass
full configure line on via JSON - which, on Windows, might contain
backslashes and other nasties, so we better try to clean that up here.

Change-Id: I8314783fc6f49e9b2b374d94448ed735de39bf81
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143940
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 
(cherry picked from commit b60dfc2928ef9763452c57f06073185456310609)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143964

diff --git a/configure.ac b/configure.ac
index c2a7159ea9e5..9e92838241e2 100644
--- a/configure.ac
+++ b/configure.ac
@@ -522,7 +522,9 @@ AC_DEFINE_UNQUOTED(LIBO_VERSION_PATCH,$LIBO_VERSION_PATCH)
 LIBO_THIS_YEAR=`date +%Y`
 AC_DEFINE_UNQUOTED(LIBO_THIS_YEAR,$LIBO_THIS_YEAR)
 
-AC_DEFINE_UNQUOTED([BUILDCONFIG],[["$ac_configure_args"]],[Options passed to 
configure script])
+# replace backslashes, to get a valid c++ string
+config_args=$(echo $ac_configure_args | tr '\\' '/')
+AC_DEFINE_UNQUOTED([BUILDCONFIG],[["$config_args"]],[Options passed to 
configure script])
 
 dnl ===
 dnl Product version


[Libreoffice-bugs] [Bug 152429] Enhancement: Allow BASE to access multiple external data sources

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152429

--- Comment #2 from Carlisle Branch  ---
That looks like it will work. I'll check it out. 

Adding this functionality to the GUI to make it easier it all that is left to
do.

Much appreciated and thank you,

Carlisle

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108151] System input language is always ignored on Linux

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108151

Eyal Rozenberg  changed:

   What|Removed |Added

   Severity|minor   |normal

--- Comment #15 from Eyal Rozenberg  ---
So, assuming that this is exactly what's needed to resolve 62063, I'm raising
the importance to Normal (and it may even be higher if we consider issues such
as bug 148257 and bug 151290).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: framework/inc framework/source

2022-12-12 Thread Miklos Vajna (via logerrit)
 framework/inc/dispatch/dispatchprovider.hxx   |2 ++
 framework/inc/dispatch/interceptionhelper.hxx |2 ++
 framework/source/services/frame.cxx   |   11 +++
 3 files changed, 15 insertions(+)

New commits:
commit 4bcf6d9c905e7b5558ee8d9f7f616ce61eadb8f8
Author: Miklos Vajna 
AuthorDate: Mon Dec 12 16:10:05 2022 +0100
Commit: Miklos Vajna 
CommitDate: Mon Dec 12 22:45:11 2022 +

tdf#151376 framework: fix calling in-document macros with reused frames

The bugdoc has a macro in it, and after closing the document -> start
center -> opening it again, you could no longer trigger the macro by
clicking on the URL field in the Calc cell.

The problem is that we cache protocol handler instances since
3f768cddd28a2f04eb1ffa30bed4474deb6fbfc4 (framework: avoid re-creating
protocol handler instances all the time, 2022-05-02) in frames, but we
failed to invalidate this cache when the component of the frame changes.

Fix the problem by clearing the cache in XFrameImpl::setComponent(),
which gets called in this somewhat rare case when a frame gets reused to
host a different component.

[ No testcase, I'm not sure how to close a document without disposing
its XFrame from code. ]

Change-Id: I73ee83ec017f476803010cbf9e514315fc797371
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143998
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/framework/inc/dispatch/dispatchprovider.hxx 
b/framework/inc/dispatch/dispatchprovider.hxx
index 3b544807337c..c6656948ebee 100644
--- a/framework/inc/dispatch/dispatchprovider.hxx
+++ b/framework/inc/dispatch/dispatchprovider.hxx
@@ -88,6 +88,8 @@ class DispatchProvider final : public ::cppu::WeakImplHelper< 
css::frame::XDispa

sal_Int32   
  nSearchFlags ) override;
 virtual css::uno::Sequence< css::uno::Reference< css::frame::XDispatch 
> > SAL_CALL queryDispatches( const css::uno::Sequence< 
css::frame::DispatchDescriptor >& lDescriptions) override;
 
+void ClearProtocolHandlers() { m_aProtocolHandlers.clear(); }
+
 /* helper */
 private:
 // Let him protected! So nobody can use us as base ...
diff --git a/framework/inc/dispatch/interceptionhelper.hxx 
b/framework/inc/dispatch/interceptionhelper.hxx
index 391986ff549f..681f69c6d013 100644
--- a/framework/inc/dispatch/interceptionhelper.hxx
+++ b/framework/inc/dispatch/interceptionhelper.hxx
@@ -244,6 +244,8 @@ class InterceptionHelper final : public  
::cppu::WeakImplHelper<
  */
 virtual void SAL_CALL disposing(const css::lang::EventObject& aEvent) 
override;
 
+css::uno::Reference GetSlave() const { 
return m_xSlave; }
+
 }; // class InterceptionHelper
 
 } // namespace framework
diff --git a/framework/source/services/frame.cxx 
b/framework/source/services/frame.cxx
index 7e8ea9b8823b..b658874b865f 100644
--- a/framework/source/services/frame.cxx
+++ b/framework/source/services/frame.cxx
@@ -1473,6 +1473,17 @@ sal_Bool SAL_CALL XFrameImpl::setComponent(const 
css::uno::Reference< css::awt::
 {
 SolarMutexGuard aWriteLock;
 m_xController = nullptr;
+
+auto pInterceptionHelper = 
dynamic_cast(m_xDispatchHelper.get());
+if (pInterceptionHelper)
+{
+css::uno::Reference 
xDispatchProvider = pInterceptionHelper->GetSlave();
+auto pDispatchProvider = 
dynamic_cast(xDispatchProvider.get());
+if (pDispatchProvider)
+{
+pDispatchProvider->ClearProtocolHandlers();
+}
+}
 }
 /* } SAFE */
 


[Libreoffice-bugs] [Bug 147982] On macOS Monterey LibreOffice 7.3 crashes about every day. This was also with previous versions of LibreOffice.

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147982

--- Comment #33 from Alex Thurgood  ---
Maybe try running etrecheck to see if that pinpoints any particular problems:

https://www.etrecheck.com/en/details.html

I notice from the previous trace that the processor seems to get overwhelmed.
This seems to happen fairly frequently in low specced MacBook Air, and not just
with LibreOffice, but LO isn't known for its particular performance efficiency
on Mac, or memory management, so it could be any of these things, or a
combination of them.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 119745] Scrolling with a laptop touchpad in Libreoffice way too fast

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119745

--- Comment #50 from MEI  ---
My scroll wheel for movement in a sheet is too much per click.  Scroll slide
moves it 1 row which is better unless your rows are tall.  I looked at what was
happening and it seems the issue is with how many rows/click are moved.
The default seems to be 3 rows/click.  I am looking for a way to set this or
have it be a function of the screen rather than rows.  Rows as the resolution
fails because it it variable due to content and/or zoom.
If I am zoomed in then 3 rows can be a lot of movement and I jump over data.
If I have tall rows with a lot of content then 3 rows is too much and I jump
over data.
I would propose a simple initial fix to be the ability to set the rows per
click.  Somewhere there is a number that controls this.
A slightly better fix would be rows/click with a zoom percentage adjusted.  For
example if set for 3 rows per click and a zoom of 200% would give 3/2 or 1.5
rows.
This does not solve the issue of the row height.  
Optimal solution using native LO controls would be if the Grid could be used, 
This would solve both.  Ability to set number of grid rows per click. The grid
already has the ability to set its horizontal and vertical height. Both of
these offer a means of controlling the amount of screen that is moved per
click.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 115481] Paper size output does not match the paper size selected

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115481

johnpetter  changed:

   What|Removed |Added

   Keywords||topicDesign
URL||https://www.assistanceforal
   ||l.com/services/email-suppor
   ||t/att-email-support/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108151] System input language is always ignored on Linux

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108151

Eyal Rozenberg  changed:

   What|Removed |Added

 Blocks||62063


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=62063
[Bug 62063] FORMATTING: Font textbox ignores keyboard layout change to RTL
language
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 62063] FORMATTING: Font textbox ignores keyboard layout change to RTL language

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=62063

Eyal Rozenberg  changed:

   What|Removed |Added

 Depends on||108151

--- Comment #25 from Eyal Rozenberg  ---
(In reply to Mike Kaganski from comment #24)
> tdf#108151 makes *layout* change at least non-portable.

Ok, but - that's a bug. We can make this bug depend on that bug - which I'll go
ahead and do - and a fix for this bug will simply fail on Linux.

> However, I believe
> that it's possible to react on the entered character script uniformly; this,
> however, makes it only possible to switch on character entry, so space
> between words can't physically be part of the detection.

But we already do switch once a (non-neutral) character is entered. Perhaps I
misunderstood your comment?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108151
[Bug 108151] System input language is always ignored on Linux
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 62063] FORMATTING: Font textbox ignores keyboard layout change to RTL language

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=62063

Eyal Rozenberg  changed:

   What|Removed |Added

 Depends on||108151

--- Comment #25 from Eyal Rozenberg  ---
(In reply to Mike Kaganski from comment #24)
> tdf#108151 makes *layout* change at least non-portable.

Ok, but - that's a bug. We can make this bug depend on that bug - which I'll go
ahead and do - and a fix for this bug will simply fail on Linux.

> However, I believe
> that it's possible to react on the entered character script uniformly; this,
> however, makes it only possible to switch on character entry, so space
> between words can't physically be part of the detection.

But we already do switch once a (non-neutral) character is entered. Perhaps I
misunderstood your comment?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108151
[Bug 108151] System input language is always ignored on Linux
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 118465] RTF import does not repeat header / repeat heading / repeat as header row for table

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118465

Tracy Logan  changed:

   What|Removed |Added

 CC||bugzi...@tracylogan.com

--- Comment #21 from Tracy Logan  ---
While I am not the original author, I confirm that this bug still exists in the
current version of LO:

Version: 7.4.3.2 / LibreOffice Community
Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890
CPU threads: 8; OS: Mac OS X 12.6.1; UI render: default; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

This bug also exists in v7.4.0.3 (on Mac OS X 12.6.1) and v7.0.4.2 (on Ubuntu
20.04).

LO 3.3 will not run (an update to it is required for this OS), so I cannot
confirm the earlier assertion (in #6) that this bug is a regression -- however,
FWIW, a similar bug existed in Open Office
(https://bz.apache.org/ooo/show_bug.cgi?id=55088); the description of that Open
Office bug report is:


"The tag for table row header (\trhdr) is being ignored.
The row which is marked with the \trhdr tag should appear at the top of every
page on which the table containing the row appears.
It works in oo 1.1.5 and 1.1.4, but not in 2.0."

This is the exact behavior I'm seeing in LO, which occurs both in the GUI, and
when called with --headless to convert RTF to PDF.

Additional observations (using 7.4.3.2/Mac):

When opening an RTF document with a multi-page table that contains the \trhdr
tag, that tag is indeed ignored; Table Properties... shows the Repeat Heading
checkbox is unchecked.  Checking that box does prefix the specified header row
to each page of the table.  Saving that file in ODT format does preserve that
setting, but saving in RTF does not (no \trhdr tag is present), and emits the
warning that the document may not save correctly.  Exporting as PDF with that
box checked likewise results in the prefixed header on every page.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133092] [META] Crash bugs

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133092
Bug 133092 depends on bug 151996, which changed state.

Bug 151996 Summary: crash when clicking autofilter (macOS 13)
https://bugs.documentfoundation.org/show_bug.cgi?id=151996

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103512] [META] AutoFilter-related bugs and enhancements

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103512
Bug 103512 depends on bug 151996, which changed state.

Bug 151996 Summary: crash when clicking autofilter (macOS 13)
https://bugs.documentfoundation.org/show_bug.cgi?id=151996

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151996] crash when clicking autofilter (macOS 13)

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151996

Christopher M. Penalver  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #10 from Christopher M. Penalver  ---
Tried with latest and didn't reproduce, but I had been making changes on the
master file all along the way. Hence, marking as WORKSFORME as I'm not
investing any further time into this. If I can reproduce I'll file a new
report.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105314] EDITING autofilter mixes "…" - 'ellipsis symbol', and "..." - 'three single dots' and produces partial result | was: Filter finds not all cells

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105314

--- Comment #14 from stefan_lange...@t-online.de  
---
Hello Andreas, many thanks for your test!
I haven't watched the bug recently because it was minor important for me.
Now I have tested again too and I can confirm your results:

With these builds I can reproduce the buggy behavior:
Version: 7.4.0.3 (x64) / LibreOffice Community
Build ID: f85e47c08ddd19c015c0114a68350214f7066f5a
CPU threads: 4; OS: Windows 10.0 Build 22623; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded
and
Version: 7.4.2.3 (x64) / LibreOffice Community
Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf
CPU threads: 4; OS: Windows 10.0 Build 22623; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded

With these builds I can no longer reproduce the behavior:
Version: 7.4.3.2 (x64) / LibreOffice Community
Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL
and
Version: 7.5.0.0.beta1 (X86_64) / LibreOffice Community
Build ID: 3aca23eec42e9d6fbe57071d7633ae1fc4bc5fcc
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL threaded
and
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9b46020c262045aed0beace4708565235c2523cc
CPU threads: 4; OS: Windows 10.0 Build 22623; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded

Means for me the bug is resolved and I would close it, but I don't know what is
the correct status: Resolved fixed - or Resolved works for me because no
solving patch is known?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sd/qa

2022-12-12 Thread Xisco Fauli (via logerrit)
 sd/qa/unit/sdmodeltestbase.hxx |   19 ---
 1 file changed, 19 deletions(-)

New commits:
commit 2ef1439ae90b3621198728b4e1e67b2e72fc376c
Author: Xisco Fauli 
AuthorDate: Mon Dec 12 18:08:44 2022 +0100
Commit: Xisco Fauli 
CommitDate: Mon Dec 12 21:54:46 2022 +

SdModelTestBase: remove duplicated template

this is already defined in include/tools/gen.hxx

Change-Id: I6d837298491e92f942dad5cd49d8ef723a19356d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144008
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sd/qa/unit/sdmodeltestbase.hxx b/sd/qa/unit/sdmodeltestbase.hxx
index 08e3a8e7fbc3..f651419c776b 100644
--- a/sd/qa/unit/sdmodeltestbase.hxx
+++ b/sd/qa/unit/sdmodeltestbase.hxx
@@ -172,23 +172,4 @@ public:
 }
 };
 
-CPPUNIT_NS_BEGIN
-
-template <> struct assertion_traits
-{
-static bool equal(const tools::Rectangle& r1, const tools::Rectangle& r2) 
{ return r1 == r2; }
-
-static std::string toString(const tools::Rectangle& r)
-{
-OStringStream ost;
-ost << "Rect P: [" << r.Top() << ", " << r.Left()
-<< "] "
-   "S: ["
-<< r.GetWidth() << ", " << r.GetHeight() << "]";
-return ost.str();
-}
-};
-
-CPPUNIT_NS_END
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */


[Libreoffice-commits] core.git: chart2/qa sc/qa

2022-12-12 Thread Xisco Fauli (via logerrit)
 chart2/qa/extras/uichart.cxx   |   38 +
 sc/qa/uitest/chart/tdf98690.py |   42 -
 2 files changed, 38 insertions(+), 42 deletions(-)

New commits:
commit 0e5d89a149e86975e103270a0ff4e65776ff8f85
Author: Xisco Fauli 
AuthorDate: Mon Dec 12 17:27:12 2022 +0100
Commit: Xisco Fauli 
CommitDate: Mon Dec 12 21:54:27 2022 +

tdf#98690: move UItest to CppUnittest

Change-Id: Icb1ccc4b3d5fc16264d7700201d3884cc935e5ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144004
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sc/qa/uitest/data/tdf98690.xlsx 
b/chart2/qa/extras/data/xlsx/tdf98690.xlsx
similarity index 100%
rename from sc/qa/uitest/data/tdf98690.xlsx
rename to chart2/qa/extras/data/xlsx/tdf98690.xlsx
diff --git a/chart2/qa/extras/uichart.cxx b/chart2/qa/extras/uichart.cxx
index ec250f80bb27..877ea0ffac1e 100644
--- a/chart2/qa/extras/uichart.cxx
+++ b/chart2/qa/extras/uichart.cxx
@@ -201,6 +201,44 @@ CPPUNIT_TEST_FIXTURE(Chart2UiChartTest, testTdf62057)
 testCopyPasteToNewSheet(xChartDoc, "Object 1", 2, 6);
 }
 
+CPPUNIT_TEST_FIXTURE(Chart2UiChartTest, testTdf98690)
+{
+loadFromURL(u"xlsx/tdf98690.xlsx");
+uno::Reference xChartDoc(getChartCompFromSheet(0, 
0, mxComponent),
+uno::UNO_QUERY_THROW);
+
+CPPUNIT_ASSERT(xChartDoc.is());
+uno::Reference xChartData(xChartDoc->getData(), 
uno::UNO_QUERY_THROW);
+uno::Sequence aSeriesList = xChartData->getColumnDescriptions();
+CPPUNIT_ASSERT_EQUAL(static_cast(6), aSeriesList.getLength());
+
+uno::Sequence aPropertyValues = {
+comphelper::makePropertyValue("ToObject", OUString("Chart 2")),
+};
+dispatchCommand(mxComponent, ".uno:GoToObject", aPropertyValues);
+Scheduler::ProcessEventsToIdle();
+
+dispatchCommand(mxComponent, ".uno:Copy", {});
+Scheduler::ProcessEventsToIdle();
+
+// create a new document
+load("private:factory/scalc");
+
+dispatchCommand(mxComponent, ".uno:Paste", {});
+Scheduler::ProcessEventsToIdle();
+
+uno::Reference xChartDoc2(getChartCompFromSheet(0, 
0, mxComponent),
+ uno::UNO_QUERY_THROW);
+CPPUNIT_ASSERT(xChartDoc2.is());
+uno::Reference xChartData2(xChartDoc2->getData(), 
uno::UNO_QUERY_THROW);
+uno::Sequence aSeriesList2 = 
xChartData2->getColumnDescriptions();
+
+// Without the fix in place, this test would have failed with
+// - Expected: 12
+// - Actual  : 0
+CPPUNIT_ASSERT_EQUAL(static_cast(12), aSeriesList2.getLength());
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/qa/uitest/chart/tdf98690.py b/sc/qa/uitest/chart/tdf98690.py
deleted file mode 100644
index 8cd6b82c0359..
--- a/sc/qa/uitest/chart/tdf98690.py
+++ /dev/null
@@ -1,42 +0,0 @@
-# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
-#
-# This file is part of the LibreOffice project.
-#
-# This Source Code Form is subject to the terms of the Mozilla Public
-# License, v. 2.0. If a copy of the MPL was not distributed with this
-# file, You can obtain one at http://mozilla.org/MPL/2.0/.
-#
-from uitest.framework import UITestCase
-from libreoffice.uno.propertyvalue import mkPropertyValues
-from uitest.uihelper.common import get_url_for_data_file
-
-class tdf98690(UITestCase):
-
-  def test_tdf98690(self):
-with self.ui_test.load_file(get_url_for_data_file("tdf98690.xlsx")):
-xCalcDoc = self.xUITest.getTopFocusWindow()
-gridwin = xCalcDoc.getChild("grid_window")
-
-gridwin.executeAction("SELECT", mkPropertyValues({"OBJECT": "Chart 
2"}))
-
-self.xUITest.executeCommand(".uno:Copy")
-
-with self.ui_test.load_empty_file("calc") as calc_document:
-xCalcDoc = self.xUITest.getTopFocusWindow()
-gridwin = xCalcDoc.getChild("grid_window")
-
-self.xUITest.executeCommand(".uno:Paste")
-
-xData = calc_document.Sheets[0].Charts[0].getEmbeddedObject().Data
-
-aExpectedRowDescriptions = tuple(str(i) for i in range(1, 14))
-aExpectedColumnDescriptions = ('Column D Column D', 'cc_girder2', 
'Column S Column S',
-'Column S Column S', 'Column D Column D', 'clexrfdon', 'Column 
S Column S',
-'Column S Column S', 'Column D', 'clexrfdoff', 'Column S 
Column S', 'Column S Column S')
-
-# Without the fix in place, this test would have failed here,
-# since the pasted chart wouldn't have had any data
-self.assertEqual(aExpectedRowDescriptions, xData.RowDescriptions)
-self.assertEqual(aExpectedColumnDescriptions, xData.ColumnDescriptions)
-
-# vim: set shiftwidth=4 softtabstop=4 expandtab:


[Libreoffice-bugs] [Bug 141778] Icon style selection widget not displayed in some language versions (such as Czech and Greek)

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141778

--- Comment #17 from Adolfo Jayme Barrientos  ---
Translators can work around this issue by strategically introducing line breaks
in the dialog’s strings, but obviously we shouldn’t expect them to fix what is
inherently a UI bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: cui/uiconfig

2022-12-12 Thread Caolán McNamara (via logerrit)
 cui/uiconfig/ui/thesaurus.ui |  145 +--
 1 file changed, 71 insertions(+), 74 deletions(-)

New commits:
commit 5b2aa621ec501f580c359a79bfcb8893594ef288
Author: Caolán McNamara 
AuthorDate: Mon Dec 12 16:56:34 2022 +
Commit: Caolán McNamara 
CommitDate: Mon Dec 12 21:29:53 2022 +

resave with latest glade

Change-Id: I612ebb175344db3fe233d3e35a9cf6d98883f585
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144005
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/cui/uiconfig/ui/thesaurus.ui b/cui/uiconfig/ui/thesaurus.ui
index fbd890635d70..ea8a8ab0450e 100644
--- a/cui/uiconfig/ui/thesaurus.ui
+++ b/cui/uiconfig/ui/thesaurus.ui
@@ -1,10 +1,10 @@
 
-
+
 
   
   
 True
-False
+False
 go-previous
   
   
@@ -18,29 +18,29 @@
 
   
   
-False
-6
+False
+6
 Thesaurus
 False
 True
-0
-0
-dialog
+0
+0
+dialog
 
   
-False
+False
 vertical
 12
 
   
-False
-end
+False
+end
 
   
 _Help
 True
-True
-True
+True
+True
 True
   
   
@@ -54,11 +54,11 @@
   
 _Replace
 True
-True
-True
-True
-True
-True
+True
+True
+True
+True
+True
   
   
 False
@@ -70,9 +70,9 @@
   
 _Cancel
 True
-True
-True
-True
+True
+True
+True
 True
   
   
@@ -85,67 +85,67 @@
   
 False
 True
-end
+end
 0
   
 
 
-  
+  
   
 True
-False
-6
-12
+False
+6
+12
 
   
 True
-False
+False
 Current word:
-True
-wordcb
+True
+wordcb
 0
   
   
-1
-0
+1
+0
 2
   
 
 
   
 True
-False
+False
 Alternatives:
-True
-alternatives
+True
+alternatives
 0
   
   
-0
-2
+0
+2
 3
   
 
 
   
 True
-False
+False
 Replace with:
-True
-replaceed
+True
+replaceed
 0
   
   
-0
-4
+0
+4
 3
   
 
 
   
 True
-True
-True
+True
+True
 True
 
   
@@ -154,16 +154,16 @@
 
   
   
-0
-5
+0
+5
 3
   
 
 
   
 True
-True
-True
+True
+True
 start
 center
 image1
@@ -175,14 +175,14 @@
 
   
   
-0
-1
+0
+1
   
 
 
   
 True
-False
+False
 center
 
   
@@ -191,23 +191,23 @@
 
   
   
-2
-1
+2
+1
   
 
 
   
 True
-False
+False
 center
 True
-True
+True
 
   
 True
-True
+True
+True
 True
-  

[Libreoffice-commits] core.git: sysui/desktop

2022-12-12 Thread galjit (via logerrit)
 dev/null|binary
 sysui/desktop/icons/base_app.ico|binary
 sysui/desktop/icons/calc_app.ico|binary
 sysui/desktop/icons/database.ico|binary
 sysui/desktop/icons/draw_app.ico|binary
 sysui/desktop/icons/drawing-template.ico|binary
 sysui/desktop/icons/drawing.ico |binary
 sysui/desktop/icons/formula.ico |binary
 sysui/desktop/icons/impress_app.ico |binary
 sysui/desktop/icons/master-document.ico |binary
 sysui/desktop/icons/math_app.ico|binary
 sysui/desktop/icons/oasis-database.ico  |binary
 sysui/desktop/icons/oasis-drawing-template.ico  |binary
 sysui/desktop/icons/oasis-drawing.ico   |binary
 sysui/desktop/icons/oasis-formula.ico   |binary
 sysui/desktop/icons/oasis-master-document.ico   |binary
 sysui/desktop/icons/oasis-presentation-template.ico |binary
 sysui/desktop/icons/oasis-presentation.ico  |binary
 sysui/desktop/icons/oasis-spreadsheet-template.ico  |binary
 sysui/desktop/icons/oasis-spreadsheet.ico   |binary
 sysui/desktop/icons/oasis-text-template.ico |binary
 sysui/desktop/icons/oasis-text.ico  |binary
 sysui/desktop/icons/oasis-web-template.ico  |binary
 sysui/desktop/icons/oxt-extension.ico   |binary
 sysui/desktop/icons/presentation-template.ico   |binary
 sysui/desktop/icons/presentation.ico|binary
 sysui/desktop/icons/soffice.ico |binary
 sysui/desktop/icons/spreadsheet-template.ico|binary
 sysui/desktop/icons/spreadsheet.ico |binary
 sysui/desktop/icons/text-template.ico   |binary
 sysui/desktop/icons/text.ico|binary
 sysui/desktop/icons/writer_app.ico  |binary
 32 files changed

New commits:
commit 31a953c7edb22f5fac1e81d92db24e1915b9b317
Author: galjit 
AuthorDate: Fri Dec 9 20:38:21 2022 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Mon Dec 12 21:28:56 2022 +

Related tdf#132398 - Update .ico files - Dec 2022

Updated .ico files based on the new hicolor icons
Also deleted those that were not listed in any WinResTarget file

Change-Id: If536ea51518d531918b4dda2d2330d7cc7487c93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143885
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Adolfo Jayme Barrientos 

diff --git a/sysui/desktop/icons/base_app.ico b/sysui/desktop/icons/base_app.ico
index 5b4bdb30ec72..be8501076a89 100644
Binary files a/sysui/desktop/icons/base_app.ico and 
b/sysui/desktop/icons/base_app.ico differ
diff --git a/sysui/desktop/icons/calc_app.ico b/sysui/desktop/icons/calc_app.ico
index 14a8b39dd2b2..03a709f3ec20 100644
Binary files a/sysui/desktop/icons/calc_app.ico and 
b/sysui/desktop/icons/calc_app.ico differ
diff --git a/sysui/desktop/icons/database.ico b/sysui/desktop/icons/database.ico
index 5b7e091543a0..1700eab51d1b 100644
Binary files a/sysui/desktop/icons/database.ico and 
b/sysui/desktop/icons/database.ico differ
diff --git a/sysui/desktop/icons/draw_app.ico b/sysui/desktop/icons/draw_app.ico
index 52cdfe4dc92b..bde547b8e507 100644
Binary files a/sysui/desktop/icons/draw_app.ico and 
b/sysui/desktop/icons/draw_app.ico differ
diff --git a/sysui/desktop/icons/drawing-template.ico 
b/sysui/desktop/icons/drawing-template.ico
index b7f50e2b829b..d04c3cee7467 100644
Binary files a/sysui/desktop/icons/drawing-template.ico and 
b/sysui/desktop/icons/drawing-template.ico differ
diff --git a/sysui/desktop/icons/drawing.ico b/sysui/desktop/icons/drawing.ico
index 67a22ca6bce7..d04c3cee7467 100644
Binary files a/sysui/desktop/icons/drawing.ico and 
b/sysui/desktop/icons/drawing.ico differ
diff --git a/sysui/desktop/icons/empty-document.ico 
b/sysui/desktop/icons/empty-document.ico
deleted file mode 100644
index 56e1e4e00c99..
Binary files a/sysui/desktop/icons/empty-document.ico and /dev/null differ
diff --git a/sysui/desktop/icons/empty-template.ico 
b/sysui/desktop/icons/empty-template.ico
deleted file mode 100644
index 56e1e4e00c99..
Binary files a/sysui/desktop/icons/empty-template.ico and /dev/null differ
diff --git a/sysui/desktop/icons/formula.ico b/sysui/desktop/icons/formula.ico
index eac96dcbe5c0..faf46fd1b607 100644
Binary files a/sysui/desktop/icons/formula.ico and 
b/sysui/desktop/icons/formula.ico differ
diff --git a/sysui/desktop/icons/impress_app.ico 
b/sysui/desktop/icons/impress_app.ico
index 235d7cf91945..dda40831ed5e 100644
Binary files a/sysui/desktop/icons/impress_app.ico and 
b/sysui/desktop/icons/impress_app.ico differ
diff --git a/sysui/desktop/icons/master-document.ico 
b/sysui/desktop/icons/master-document.ico
index 7ac50c138182..07a828095ac0 100644
Binary files a/sysui/desktop/icons/master-document.ico and 

[Libreoffice-bugs] [Bug 152447] Small capitals format gives tiny numbers

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152447

--- Comment #8 from LeroyG  ---
Created attachment 184120
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184120=edit
Screenshot on Windows 10

On Windows 10.0.
Font Properties for Arial font show more options than on Windows 6.3 (aka 7).
Fraction style could be set to none.

It is possible that your file (or style) was created with a newer version of
LibreOffice?

The LibreOffice 6.4 release End of Life was two years ago. Don't expect that
anyone will fix it, if it was a 6.4 version issue. Maybe you must update to
LibreOffice 7.3.7.

Oh! I forgot to thank you for sharing the sample file. It would have been
impossible to test without it.

Version: 7.3.7.2 (x64) / LibreOffice Community
Build ID: e114eadc50a9ff8d8c8a0567d6da8f454beeb84f
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: es-MX (es_ES); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - sc/uiconfig

2022-12-12 Thread Olivier Hallot (via logerrit)
 sc/uiconfig/scalc/ui/solverdlg.ui |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e11a61b5630396f0b6d8312fbc7e12337e1f645e
Author: Olivier Hallot 
AuthorDate: Sat Dec 10 11:02:18 2022 +
Commit: Adolfo Jayme Barrientos 
CommitDate: Mon Dec 12 21:26:19 2022 +

Make extended tip more precise (after translator review)

Thanks to Tuomas Hietala.

Change-Id: I99d630d7e7086270ca76173c254cd282cbe81a5e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143915
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Adolfo Jayme Barrientos 
(cherry picked from commit cb415ed64a647fe736599bb6c4f2136aa5ec5d1b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144021

diff --git a/sc/uiconfig/scalc/ui/solverdlg.ui 
b/sc/uiconfig/scalc/ui/solverdlg.ui
index 18bbb5868caa..458a205ba5d4 100644
--- a/sc/uiconfig/scalc/ui/solverdlg.ui
+++ b/sc/uiconfig/scalc/ui/solverdlg.ui
@@ -57,7 +57,7 @@
 True
 
   
-Opens the Solver 
Options dialog.
+Opens the solver’s 
Options dialog.
   
 
   


[Libreoffice-commits] core.git: sc/uiconfig

2022-12-12 Thread Olivier Hallot (via logerrit)
 sc/uiconfig/scalc/ui/solverdlg.ui |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit cb415ed64a647fe736599bb6c4f2136aa5ec5d1b
Author: Olivier Hallot 
AuthorDate: Sat Dec 10 11:02:18 2022 +
Commit: Adolfo Jayme Barrientos 
CommitDate: Mon Dec 12 21:25:56 2022 +

Make extended tip more precise (after translator review)

Thanks to Tuomas Hietala.

Change-Id: I99d630d7e7086270ca76173c254cd282cbe81a5e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143915
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Adolfo Jayme Barrientos 

diff --git a/sc/uiconfig/scalc/ui/solverdlg.ui 
b/sc/uiconfig/scalc/ui/solverdlg.ui
index 18bbb5868caa..458a205ba5d4 100644
--- a/sc/uiconfig/scalc/ui/solverdlg.ui
+++ b/sc/uiconfig/scalc/ui/solverdlg.ui
@@ -57,7 +57,7 @@
 True
 
   
-Opens the Solver 
Options dialog.
+Opens the solver’s 
Options dialog.
   
 
   


[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - cui/source

2022-12-12 Thread Caolán McNamara (via logerrit)
 cui/source/dialogs/thesdlg.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 36651d2b51f7db243d975cc2bf3bb8975b2faa10
Author: Caolán McNamara 
AuthorDate: Mon Dec 12 16:58:46 2022 +
Commit: Adolfo Jayme Barrientos 
CommitDate: Mon Dec 12 21:16:45 2022 +

Resolves: tdf#139749 set initial focus to combobox

Change-Id: Ib8fd0dd4a4b5d4c137794c4538e61bfbf33b9a1d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144016
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/cui/source/dialogs/thesdlg.cxx b/cui/source/dialogs/thesdlg.cxx
index 1d98480973ee..ea98a44a3c9e 100644
--- a/cui/source/dialogs/thesdlg.cxx
+++ b/cui/source/dialogs/thesdlg.cxx
@@ -315,6 +315,8 @@ SvxThesaurusDialog::SvxThesaurusDialog(
 // disable controls if service is missing
 if (!xThesaurus.is())
 m_xDialog->set_sensitive(false);
+else
+m_xWordCB->grab_focus();
 }
 
 SvxThesaurusDialog::~SvxThesaurusDialog()


[Libreoffice-bugs] [Bug 145270] LO files should have a macro module by default

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145270

Rafael Lima  changed:

   What|Removed |Added

  Component|LibreOffice |BASIC

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150540] Add accessibility features to images

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150540

Rafael Lima  changed:

   What|Removed |Added

Summary|LibreOffice针对图片增加辅助功能的建议|Add accessibility features
   ||to images

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145270] LO files should have a macro module by default

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145270

--- Comment #7 from Rafael Lima  ---
Sorry for the noise... I accidentally modified the wrong bug report.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145270] LO files should have a macro module by default

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145270

Rafael Lima  changed:

   What|Removed |Added

Summary|Add accessibility features  |LO files should have a
   |to images   |macro module by default

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145270] Add accessibility features to images

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145270

Rafael Lima  changed:

   What|Removed |Added

  Component|BASIC   |LibreOffice
Summary|LO files should have a  |Add accessibility features
   |macro module by default |to images

--- Comment #6 from Rafael Lima  ---
The bug report was originally in Chinese. This is the translation:

In the document, according to the layout requirements, the picture will be
zoomed in and processed, but in actual reading, the picture needs to be
temporarily zoomed in and previewed. In response to this usage requirement, it
is recommended to add auxiliary functions, and the image auxiliary tool
"magnifying glass" can be used to zoom in and check carefully. I will give
screenshots of this function of other software (WPS2019) for reference. This
function is very useful, please add it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103182
Bug 103182 depends on bug 139749, which changed state.

Bug 139749 Summary: 'Current word' dropdown not focused upon opening Thesaurus 
(GTK3)
https://bugs.documentfoundation.org/show_bug.cgi?id=139749

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150540] LibreOffice针对图片增加辅助功能的建议

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150540

Rafael Lima  changed:

   What|Removed |Added

  Component|BASIC   |LibreOffice

--- Comment #2 from Rafael Lima  ---
The bug report was originally in Chinese. This is the translation:

In the document, according to the layout requirements, the picture will be
zoomed in and processed, but in actual reading, the picture needs to be
temporarily zoomed in and previewed. In response to this usage requirement, it
is recommended to add auxiliary functions, and the image auxiliary tool
"magnifying glass" can be used to zoom in and check carefully. I will give
screenshots of this function of other software (WPS2019) for reference. This
function is very useful, please add it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150339] Wrong type for text color: Property not convertible

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150339

--- Comment #3 from BogdanB  ---
When I open sfx2/source/appl/appuno.cxx I see a hint message in Visual Code:
"Dereference of null smart pointer 'pItem' of type 'std::unique_ptr'"

warn:legacy.osl:82145:82145:svl/source/items/custritm.cxx:70:
CntUnencodedStringItem::PutValue(): Wrong type
warn:sfx:82145:82145:sfx2/source/appl/appuno.cxx:310: Property not convertible:
Color

The same in
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 01c9c971e43782800ebf63acc763a7e7fba096c1
CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: cui/source

2022-12-12 Thread Caolán McNamara (via logerrit)
 cui/source/dialogs/thesdlg.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit d4a1d4b266a74a9adeaa84a8caab9b8b33dbb302
Author: Caolán McNamara 
AuthorDate: Mon Dec 12 16:58:46 2022 +
Commit: Caolán McNamara 
CommitDate: Mon Dec 12 20:57:58 2022 +

Resolves: tdf#139749 set initial focus to combobox

Change-Id: Ib8fd0dd4a4b5d4c137794c4538e61bfbf33b9a1d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144006
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/cui/source/dialogs/thesdlg.cxx b/cui/source/dialogs/thesdlg.cxx
index 1d98480973ee..ea98a44a3c9e 100644
--- a/cui/source/dialogs/thesdlg.cxx
+++ b/cui/source/dialogs/thesdlg.cxx
@@ -315,6 +315,8 @@ SvxThesaurusDialog::SvxThesaurusDialog(
 // disable controls if service is missing
 if (!xThesaurus.is())
 m_xDialog->set_sensitive(false);
+else
+m_xWordCB->grab_focus();
 }
 
 SvxThesaurusDialog::~SvxThesaurusDialog()


[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - cui/source

2022-12-12 Thread Caolán McNamara (via logerrit)
 cui/source/dialogs/thesdlg.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 2390c63e311497892f56e7e16a213195098c87b4
Author: Caolán McNamara 
AuthorDate: Mon Dec 12 16:58:46 2022 +
Commit: Caolán McNamara 
CommitDate: Mon Dec 12 20:58:08 2022 +

Resolves: tdf#139749 set initial focus to combobox

Change-Id: Ib8fd0dd4a4b5d4c137794c4538e61bfbf33b9a1d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144015
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/cui/source/dialogs/thesdlg.cxx b/cui/source/dialogs/thesdlg.cxx
index 1d98480973ee..ea98a44a3c9e 100644
--- a/cui/source/dialogs/thesdlg.cxx
+++ b/cui/source/dialogs/thesdlg.cxx
@@ -315,6 +315,8 @@ SvxThesaurusDialog::SvxThesaurusDialog(
 // disable controls if service is missing
 if (!xThesaurus.is())
 m_xDialog->set_sensitive(false);
+else
+m_xWordCB->grab_focus();
 }
 
 SvxThesaurusDialog::~SvxThesaurusDialog()


[Libreoffice-bugs] [Bug 145269] Simple clicking a module gives the impression that this module has the view

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145269

Rafael Lima  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||rafael.palma.l...@gmail.com

--- Comment #5 from Rafael Lima  ---
I may be a bit biased here, since I've been using the Basic IDE for a long
time. But I wouldn't expect that a module would be opened by simply clicking it
once.

Anyways, it would be nice to have the input from the UX team.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 145269] Simple clicking a module gives the impression that this module has the view

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145269

Rafael Lima  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||rafael.palma.l...@gmail.com

--- Comment #5 from Rafael Lima  ---
I may be a bit biased here, since I've been using the Basic IDE for a long
time. But I wouldn't expect that a module would be opened by simply clicking it
once.

Anyways, it would be nice to have the input from the UX team.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 150687] Simple inserting of text: too many warnings in console with debug LO

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150687

--- Comment #10 from BogdanB  ---
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 01c9c971e43782800ebf63acc763a7e7fba096c1
CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150687] Simple inserting of text: too many warnings in console with debug LO

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150687

--- Comment #9 from BogdanB  ---
The same with 7.6

warn:legacy.osl:81483:81483:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried
to open non-existent folder or stream!
warn:legacy.osl:81483:81483:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried
to open non-existent folder or stream!
warn:legacy.osl:81483:81483:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried
to open non-existent folder or stream!
warn:legacy.osl:81483:81483:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried
to open non-existent folder or stream!
warn:legacy.osl:81483:81483:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried
to open non-existent folder or stream!
warn:legacy.osl:81483:81483:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried
to open non-existent folder or stream!
warn:legacy.osl:81483:81483:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried
to open non-existent folder or stream!
warn:legacy.osl:81483:81483:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried
to open non-existent folder or stream!
warn:legacy.osl:81483:81483:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried
to open non-existent folder or stream!
warn:legacy.osl:81483:81483:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried
to open non-existent folder or stream!
warn:legacy.osl:81483:81483:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried
to open non-existent folder or stream!
warn:legacy.osl:81483:81483:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried
to open non-existent folder or stream!
warn:legacy.osl:81483:81483:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried
to open non-existent folder or stream!
warn:legacy.osl:81483:81483:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried
to open non-existent folder or stream!
warn:legacy.osl:81483:81483:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried
to open non-existent folder or stream!
warn:legacy.osl:81483:81483:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried
to open non-existent folder or stream!
warn:legacy.osl:81483:81483:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried
to open non-existent folder or stream!
warn:legacy.osl:81483:81483:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried
to open non-existent folder or stream!
warn:legacy.osl:81483:81483:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried
to open non-existent folder or stream!
warn:legacy.osl:81483:81483:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried
to open non-existent folder or stream!
warn:legacy.osl:81483:81483:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried
to open non-existent folder or stream!
warn:legacy.osl:81483:81483:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried
to open non-existent folder or stream!
warn:legacy.osl:81483:81483:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried
to open non-existent folder or stream!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152351] SF_Dictionary ReplaceItem does not accept array as value

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152351

Rafael Lima  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||j...@ledure.be,
   ||rafael.palma.l...@gmail.com
 Status|UNCONFIRMED |NEW

--- Comment #1 from Rafael Lima  ---
I can confirm the issue using the latest master.

@JPL what do you think? Can this be easily fixed?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104318] CTL, CJK, and Western Language controls in the GUI cause confusion, handling languages and script selection needs rework--comfortable for a "Global" user community

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104318

--- Comment #28 from Eyal Rozenberg  ---
At the moment, the bug title is much more expansive and general than the
opening comment. Can Toby, or others, comment on what this bug is about right
now, and adjust the title accordingly?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 62063] FORMATTING: Font textbox ignores keyboard layout change to RTL language

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=62063

--- Comment #24 from Mike Kaganski  ---
(In reply to Eyal Rozenberg from comment #23)
> Mike, Mike, wait...

:) Sorry.

> All
> that's necessary is that when LO detects a keyboard layout change, for it to
> make the combo-box switch to the language group of the new keyboard layout.

tdf#108151 makes *layout* change at least non-portable. However, I believe that
it's possible to react on the entered character script uniformly; this,
however, makes it only possible to switch on character entry, so space between
words can't physically be part of the detection.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 62063] FORMATTING: Font textbox ignores keyboard layout change to RTL language

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=62063

--- Comment #24 from Mike Kaganski  ---
(In reply to Eyal Rozenberg from comment #23)
> Mike, Mike, wait...

:) Sorry.

> All
> that's necessary is that when LO detects a keyboard layout change, for it to
> make the combo-box switch to the language group of the new keyboard layout.

tdf#108151 makes *layout* change at least non-portable. However, I believe that
it's possible to react on the entered character script uniformly; this,
however, makes it only possible to switch on character entry, so space between
words can't physically be part of the detection.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152463] AutoRecovery should be turned on by default

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152463

BogdanB  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |buzea.bog...@libreoffice.or
   |desktop.org |g
 CC||buzea.bog...@libreoffice.or
   ||g

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 62063] FORMATTING: Font textbox ignores keyboard layout change to RTL language

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=62063

--- Comment #23 from Eyal Rozenberg  ---
(In reply to Mike Kaganski from comment #19)
> 2. This is basically in the same topic as that bug 104318, bug 146910, bug
> 146928, and others that make non-Western script users the second-class
> citizens.

While I agree that these are important issues, I'm not sure the bug we see here
is even intentional. And that's because once you start typing RTL text, the
font family selection combo-box _does_ switch to tracking the RTL/CTL font. So
the developers who wrote this did want the combo-box to track the language
family used where your cursor is right now.

> There is some discussion (with Khaled expressing his opinion that the
> division to the three font categories is useless, also reflected here in
> comment 4, and which I support); there's bug 148257, and so on.
>
> A UX solution to the problem of handling different fonts for different
> scripts in the same UI (style, but also direct formatting!) is needed.

Mike, Mike, wait... those are important discussions on fundamental issues, but
this bug can be resolved perfectly well the way things stand now, without
making changes to the document model or anything like that. All that's
necessary is that when LO detects a keyboard layout change, for it to make the
combo-box switch to the language group of the new keyboard layout.

(There is the question of what to do if you don't type a space between the
Western text and intended CTL text, and then there's a clash between
representing the character just before the cursor and the keyboard layout, but
that's a finer point and is still not dependent on all of the deep
discussions.)

> (In reply to Eyal Rozenberg from comment #21)
> > is an invalid claim. The choice of language for a stretch of text is not
> > formatting (direct or otherwise).
>
> It is a valid and correct claim. However, it should change.

Ok, let me rephrase - it is incorrect in principle, and in how a reasonable
user thinks of language; but it is correct in the sense of being LO's current
approach (sort of).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 62063] FORMATTING: Font textbox ignores keyboard layout change to RTL language

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=62063

--- Comment #23 from Eyal Rozenberg  ---
(In reply to Mike Kaganski from comment #19)
> 2. This is basically in the same topic as that bug 104318, bug 146910, bug
> 146928, and others that make non-Western script users the second-class
> citizens.

While I agree that these are important issues, I'm not sure the bug we see here
is even intentional. And that's because once you start typing RTL text, the
font family selection combo-box _does_ switch to tracking the RTL/CTL font. So
the developers who wrote this did want the combo-box to track the language
family used where your cursor is right now.

> There is some discussion (with Khaled expressing his opinion that the
> division to the three font categories is useless, also reflected here in
> comment 4, and which I support); there's bug 148257, and so on.
>
> A UX solution to the problem of handling different fonts for different
> scripts in the same UI (style, but also direct formatting!) is needed.

Mike, Mike, wait... those are important discussions on fundamental issues, but
this bug can be resolved perfectly well the way things stand now, without
making changes to the document model or anything like that. All that's
necessary is that when LO detects a keyboard layout change, for it to make the
combo-box switch to the language group of the new keyboard layout.

(There is the question of what to do if you don't type a space between the
Western text and intended CTL text, and then there's a clash between
representing the character just before the cursor and the keyboard layout, but
that's a finer point and is still not dependent on all of the deep
discussions.)

> (In reply to Eyal Rozenberg from comment #21)
> > is an invalid claim. The choice of language for a stretch of text is not
> > formatting (direct or otherwise).
>
> It is a valid and correct claim. However, it should change.

Ok, let me rephrase - it is incorrect in principle, and in how a reasonable
user thinks of language; but it is correct in the sense of being LO's current
approach (sort of).

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 62063] FORMATTING: Font textbox ignores keyboard layout change to RTL language

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=62063

--- Comment #22 from Mike Kaganski  ---
(In reply to Eyal Rozenberg from comment #21)
> is an invalid claim. The choice of language for a stretch of text is not
> formatting (direct or otherwise).

It is a valid and correct claim. However, it should change.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 62063] FORMATTING: Font textbox ignores keyboard layout change to RTL language

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=62063

--- Comment #22 from Mike Kaganski  ---
(In reply to Eyal Rozenberg from comment #21)
> is an invalid claim. The choice of language for a stretch of text is not
> formatting (direct or otherwise).

It is a valid and correct claim. However, it should change.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - oox/source

2022-12-12 Thread Caolán McNamara (via logerrit)
 oox/source/helper/attributelist.cxx |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 76b923ebf17eba7d2ec13b66bf03f3ac4ea347c3
Author: Caolán McNamara 
AuthorDate: Sun Dec 11 16:42:37 2022 +
Commit: Caolán McNamara 
CommitDate: Mon Dec 12 20:14:17 2022 +

crashtesting: accept timestamp with Z suffix as valid

seen with forum-mso-en4-652977.xlsx

Change-Id: I5ca7be851c279d28e225cba1ba401a4f7fa99e87
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143945
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/oox/source/helper/attributelist.cxx 
b/oox/source/helper/attributelist.cxx
index e0bea17c22e6..c247fdb43e8d 100644
--- a/oox/source/helper/attributelist.cxx
+++ b/oox/source/helper/attributelist.cxx
@@ -250,8 +250,9 @@ OptValue< util::DateTime > AttributeList::getDateTime( 
sal_Int32 nAttrToken ) co
 {
 OUString aValue = mxAttribs->getOptionalValue( nAttrToken );
 util::DateTime aDateTime;
-bool bValid = (aValue.getLength() == 19) && (aValue[ 4 ] == '-') && 
(aValue[ 7 ] == '-') &&
-(aValue[ 10 ] == 'T') && (aValue[ 13 ] == ':') && (aValue[ 16 ] == 
':');
+bool bValid = (aValue.getLength() == 19 || (aValue.getLength() == 20 && 
aValue[19] == 'Z')) &&
+(aValue[ 4 ] == '-') && (aValue[ 7 ] == '-') && (aValue[ 10 ] == 'T') 
&&
+(aValue[ 13 ] == ':') && (aValue[ 16 ] == ':');
 if( bValid )
 {
 aDateTime.Year= static_cast< sal_uInt16 >( 
o3tl::toInt32(aValue.subView( 0, 4 )) );


[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - 2 commits - sc/source

2022-12-12 Thread Caolán McNamara (via logerrit)
 sc/source/core/tool/address.cxx  |2 +-
 sc/source/filter/oox/worksheethelper.cxx |   13 -
 2 files changed, 13 insertions(+), 2 deletions(-)

New commits:
commit b7fbb1ee9eddd4ec6099bd3677068185e5e96473
Author: Caolán McNamara 
AuthorDate: Mon Dec 12 10:19:36 2022 +
Commit: Caolán McNamara 
CommitDate: Mon Dec 12 20:13:42 2022 +

crashtesting: assert seen on loading forum-mso-en4-497867.xlsx

Change-Id: Ifa5e2711981097a648d7127d2dc777bc96b04edb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143966
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sc/source/core/tool/address.cxx b/sc/source/core/tool/address.cxx
index f704290e340d..7bd66f6402e4 100644
--- a/sc/source/core/tool/address.cxx
+++ b/sc/source/core/tool/address.cxx
@@ -2094,7 +2094,7 @@ static void lcl_Split_DocTab( const ScDocument& rDoc,  
SCTAB nTab,
 rDoc.GetName(nTab, rTabName);
 rDocName.clear();
 // External reference, same as in ScCompiler::MakeTabStr()
-if ( rTabName[0] == '\'' )
+if (!rTabName.isEmpty() && rTabName[0] == '\'')
 {   // "'Doc'#Tab"
 sal_Int32 nPos = ScCompiler::GetDocTabPos( rTabName);
 if (nPos != -1)
commit f3fb7ade7fba0c2c4c56f155c3e048d5bcc4c3e1
Author: Caolán McNamara 
AuthorDate: Mon Dec 12 09:48:39 2022 +
Commit: Caolán McNamara 
CommitDate: Mon Dec 12 20:13:30 2022 +

crashtesting: assert see on loading forum-mso-en4-489894.xlsx

Change-Id: I402705ea911ca248afb812b63a897c1df9884a22
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143962
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sc/source/filter/oox/worksheethelper.cxx 
b/sc/source/filter/oox/worksheethelper.cxx
index 010a4189cf7f..2c409e0d7b14 100644
--- a/sc/source/filter/oox/worksheethelper.cxx
+++ b/sc/source/filter/oox/worksheethelper.cxx
@@ -1378,7 +1378,18 @@ void WorksheetGlobals::finalizeDrawings()
 Needed if the imported document is inserted as "OLE object from file"
 and thus does not provide an OLE size property by itself. */
 if( (maShapeBoundingBox.Width > 0) || (maShapeBoundingBox.Height > 0) )
-extendUsedArea( getCellRangeFromRectangle( maShapeBoundingBox ) );
+{
+ScRange aRange(getCellRangeFromRectangle(maShapeBoundingBox));
+if (aRange.aStart.Col() < 0)
+aRange.aStart.SetCol(0);
+if (aRange.aStart.Row() < 0)
+aRange.aStart.SetRow(0);
+if (aRange.aEnd.Col() < 0)
+aRange.aEnd.SetCol(0);
+if (aRange.aEnd.Row() < 0)
+aRange.aEnd.SetRow(0);
+extendUsedArea(aRange);
+}
 
 // if no used area is set, default to A1
 if( maUsedArea.aStart.Col() > maUsedArea.aEnd.Col() )


[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103378
Bug 103378 depends on bug 127575, which changed state.

Bug 127575 Summary: Writer ODT with embedded scanned PDF image: image does not 
export to PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=127575

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 127575] Writer ODT with embedded scanned PDF image: image does not export to PDF

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127575

Anton Samokat  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |---

--- Comment #19 from Anton Samokat  ---
Bug reproduced on Libre Office 7.4.2.3 on Ubuntu 20.04.
Test Case:
- Import to Writer PDF document. 
- Crop and resize created image.
- Export the document as PDF.
- In result PDF images are missing.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104318] CTL, CJK, and Western Language controls in the GUI cause confusion, handling languages and script selection needs rework--comfortable for a "Global" user community

2022-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104318

Eyal Rozenberg  changed:

   What|Removed |Added

 Blocks||129661


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=129661
[Bug 129661] [META] Right-To-Left (RTL) user interface issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

  1   2   3   4   >