[Libreoffice-commits] core.git: sw/source
sw/source/ui/vba/vbalistlevel.cxx | 40 +-
sw/source/ui/vba/vbalistlevel.hxx |2 -
sw/source/ui/vba/vbalistlevels.cxx| 18 +++
sw/source/ui/vba/vbalistlevels.hxx|2 -
sw/source/ui/vba/vbalisttemplates.cxx | 12 +-
5 files changed, 37 insertions(+), 37 deletions(-)
New commits:
commit d24fc94281458b57368ff4fef1fe1182dadbea72
Author: Miklos Vajna
AuthorDate: Mon Jan 9 13:51:37 2023 +0100
Commit: Miklos Vajna
CommitDate: Mon Jan 9 19:09:00 2023 +
sw: prefix members of ListLevelsEnumWrapper, ListTemplatesEnumWrapper, ...
... SwVbaListLevel and SwVbaListLevels
See tdf#94879 for motivation.
Change-Id: I8f3b88b71ba2696179e2f48c9c6e66f5fc947553
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145187
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/sw/source/ui/vba/vbalistlevel.cxx
b/sw/source/ui/vba/vbalistlevel.cxx
index dcd06a2e998a..43f16e85243f 100644
--- a/sw/source/ui/vba/vbalistlevel.cxx
+++ b/sw/source/ui/vba/vbalistlevel.cxx
@@ -27,7 +27,7 @@
using namespace ::ooo::vba;
using namespace ::com::sun::star;
-SwVbaListLevel::SwVbaListLevel( const uno::Reference<
ooo::vba::XHelperInterface >& rParent, const uno::Reference<
uno::XComponentContext >& rContext, SwVbaListHelperRef pHelper, sal_Int32
nLevel ) : SwVbaListLevel_BASE( rParent, rContext ), pListHelper(std::move(
pHelper )), mnLevel( nLevel )
+SwVbaListLevel::SwVbaListLevel( const uno::Reference<
ooo::vba::XHelperInterface >& rParent, const uno::Reference<
uno::XComponentContext >& rContext, SwVbaListHelperRef pHelper, sal_Int32
nLevel ) : SwVbaListLevel_BASE( rParent, rContext ), m_pListHelper(std::move(
pHelper )), mnLevel( nLevel )
{
}
@@ -38,7 +38,7 @@ SwVbaListLevel::~SwVbaListLevel()
::sal_Int32 SAL_CALL SwVbaListLevel::getAlignment()
{
sal_Int16 nAlignment = 0;
-pListHelper->getPropertyValueWithNameAndLevel( mnLevel, "Adjust" ) >>=
nAlignment;
+m_pListHelper->getPropertyValueWithNameAndLevel( mnLevel, "Adjust" ) >>=
nAlignment;
switch( nAlignment )
{
case text::HoriOrientation::LEFT:
@@ -89,7 +89,7 @@ void SAL_CALL SwVbaListLevel::setAlignment( ::sal_Int32
_alignment )
throw uno::RuntimeException();
}
}
-pListHelper->setPropertyValueWithNameAndLevel( mnLevel, "Adjust",
uno::Any( nAlignment ) );
+m_pListHelper->setPropertyValueWithNameAndLevel( mnLevel, "Adjust",
uno::Any( nAlignment ) );
}
uno::Reference< ::ooo::vba::word::XFont > SAL_CALL SwVbaListLevel::getFont()
@@ -134,8 +134,8 @@ float SAL_CALL SwVbaListLevel::getNumberPosition()
// indentAt + firstlineindent
sal_Int32 nIndentAt = 0;
sal_Int32 nFirstLineIndent = 0;
-pListHelper->getPropertyValueWithNameAndLevel( mnLevel, "IndentAt" ) >>=
nIndentAt;
-pListHelper->getPropertyValueWithNameAndLevel( mnLevel, "FirstLineIndent"
) >>= nFirstLineIndent;
+m_pListHelper->getPropertyValueWithNameAndLevel( mnLevel, "IndentAt" ) >>=
nIndentAt;
+m_pListHelper->getPropertyValueWithNameAndLevel( mnLevel,
"FirstLineIndent" ) >>= nFirstLineIndent;
sal_Int32 nResult = nIndentAt + nFirstLineIndent;
@@ -147,16 +147,16 @@ void SAL_CALL SwVbaListLevel::setNumberPosition( float
_numberposition )
sal_Int32 nNumberPosition = Millimeter::getInHundredthsOfOneMillimeter(
_numberposition );
sal_Int32 nIndentAt = 0;
-pListHelper->getPropertyValueWithNameAndLevel( mnLevel, "IndentAt" ) >>=
nIndentAt;
+m_pListHelper->getPropertyValueWithNameAndLevel( mnLevel, "IndentAt" ) >>=
nIndentAt;
sal_Int32 nFirstLineIndent = nNumberPosition - nIndentAt;
-pListHelper->setPropertyValueWithNameAndLevel( mnLevel, "FirstLineIndent",
uno::Any( nFirstLineIndent ) );
+m_pListHelper->setPropertyValueWithNameAndLevel( mnLevel,
"FirstLineIndent", uno::Any( nFirstLineIndent ) );
}
::sal_Int32 SAL_CALL SwVbaListLevel::getNumberStyle()
{
sal_Int16 nNumberingType = 0;
-pListHelper->getPropertyValueWithNameAndLevel( mnLevel, "NumberingType" )
>>= nNumberingType;
+m_pListHelper->getPropertyValueWithNameAndLevel( mnLevel, "NumberingType"
) >>= nNumberingType;
switch( nNumberingType )
{
case style::NumberingType::CHAR_SPECIAL:
@@ -288,7 +288,7 @@ void SAL_CALL SwVbaListLevel::setNumberStyle( ::sal_Int32
_numberstyle )
}
}
-pListHelper->setPropertyValueWithNameAndLevel( mnLevel, "NumberingType",
uno::Any( nNumberingType ) );
+m_pListHelper->setPropertyValueWithNameAndLevel( mnLevel, "NumberingType",
uno::Any( nNumberingType ) );
}
::sal_Int32 SAL_CALL SwVbaListLevel::getResetOnHigher()
@@ -305,20 +305,20 @@ void SAL_CALL SwVbaListLevel::setResetOnHigher(
::sal_Int32 /*_resetonhigher*/ )
::sal_Int32 SAL_CALL SwVbaListLevel::getStartAt()
{
sal_Int16 nStartWith = 0;
-pListHelper->getPropertyValueWithNameAndLevel( mnLevel, "StartWith" ) >>=
[Libreoffice-commits] core.git: basic/qa
basic/qa/basic_coverage/test_converttofromurl_methods.bas | 29 +++---
1 file changed, 23 insertions(+), 6 deletions(-)
New commits:
commit 3c7cba927bb5d234d6d72f65e063754590a7b584
Author: Xisco Fauli
AuthorDate: Mon Jan 9 10:05:05 2023 +0100
Commit: Xisco Fauli
CommitDate: Mon Jan 9 19:08:03 2023 +
tdf#152917: basic_macros: Add unittest
Change-Id: I69050ae0e6607ed4a1d1da0e89b45125e2c06e3b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145190
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/basic/qa/basic_coverage/test_converttofromurl_methods.bas
b/basic/qa/basic_coverage/test_converttofromurl_methods.bas
index d1dbcfc5ff73..c17d17e631e3 100644
--- a/basic/qa/basic_coverage/test_converttofromurl_methods.bas
+++ b/basic/qa/basic_coverage/test_converttofromurl_methods.bas
@@ -7,11 +7,28 @@
Option Explicit
-Function doUnitTest as String
-' ConvertFromUrl ConvertToUrl
-If ( ConvertToUrl( ConvertFromUrl("") ) <> "") Then
-doUnitTest = "FAIL"
+Function doUnitTest() As String
+TestUtil.TestInit
+verify_testConvertToFromUrl
+doUnitTest = TestUtil.GetResult()
+End Function
+
+Sub verify_testConvertToFromUrl
+On Error GoTo errorHandler
+
+TestUtil.AssertEqual( ConvertToUrl( ConvertFromUrl("") ), "",
"ConvertToUrl( ConvertFromUrl("") )")
+
+' tdf#152917: Without the fix in place, this test would have failed with
+' Failed: ConvertFromUrl("file:///foo/bar/test.txt") returned , expected
/foo/bar/test.txt
+If (GetGUIType() <> 1) Then
+'Linux
+TestUtil.AssertEqual( ConvertFromUrl("file:///foo/bar/test.txt"),
"/foo/bar/test.txt", "ConvertFromUrl(""file:///foo/bar/test.txt"")")
Else
-doUnitTest = "OK"
+'Windows
+TestUtil.AssertEqual( ConvertFromUrl("file://foo/bar/test.txt"),
"\\foo\bar\test.txt", "ConvertFromUrl(""file://foo/bar/test.txt"")")
End If
-End Function
+
+Exit Sub
+errorHandler:
+TestUtil.ReportErrorHandler("verify_testConvertToFromUrl", Err, Error$,
Erl)
+End Sub
[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102495 Rafael Lima changed: What|Removed |Added Depends on||152849 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=152849 [Bug 152849] conditional formatting entry field exists; but is not visible -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152849] conditional formatting entry field exists; but is not visible
https://bugs.documentfoundation.org/show_bug.cgi?id=152849 Rafael Lima changed: What|Removed |Added Blocks||102495 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102495 [Bug 102495] [META] KDE VCL backend bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152849] conditional formatting entry field exists; but is not visible
https://bugs.documentfoundation.org/show_bug.cgi?id=152849 Rafael Lima changed: What|Removed |Added CC||rafael.palma.l...@gmail.com --- Comment #3 from Rafael Lima --- I'd say this is a duplicate of bug 150451. Although it complains about dark mode, I believe it is the same root cause. Both bug reports are related to kf5. Apparently the outline of text boxes is not being drawn correctly in kf5. Maybe this is related to how LO integrates with the system theme in KDE. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150451] Some text boxes in dialogs do not have borders in dark mode (Dark mode + kf5)
https://bugs.documentfoundation.org/show_bug.cgi?id=150451 Rafael Lima changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||2849 --- Comment #5 from Rafael Lima --- I guess this issue affects light mode as well. See bug 152849. It seems to be related to kf5 only. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152849] conditional formatting entry field exists; but is not visible
https://bugs.documentfoundation.org/show_bug.cgi?id=152849 Rafael Lima changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||0451 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152849] conditional formatting entry field exists; but is not visible
https://bugs.documentfoundation.org/show_bug.cgi?id=152849 Rafael Lima changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||7097 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147097] Text boxes in Basic dialogs are being rendered without borders
https://bugs.documentfoundation.org/show_bug.cgi?id=147097 Rafael Lima changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||2849 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/osx
vcl/osx/salframeview.mm |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 9cc91e17172709c65742c092d3f312bce48ac6d9
Author: Stephan Bergmann
AuthorDate: Mon Jan 9 15:48:27 2023 +0100
Commit: Stephan Bergmann
CommitDate: Mon Jan 9 18:54:13 2023 +
loplugin:fakebool
Change-Id: Idf69f13c3e8ab94ac04d83c9a0d171cddc399a10
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145213
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/vcl/osx/salframeview.mm b/vcl/osx/salframeview.mm
index c5136b9359bc..4833af8fda9e 100644
--- a/vcl/osx/salframeview.mm
+++ b/vcl/osx/salframeview.mm
@@ -323,7 +323,7 @@ static AquaSalFrame* getMouseContainerFrame()
mpFrame->UpdateFrameGeometry();
mpFrame->CallCallback( SalEvent::Resize, nullptr );
-BOOL bInLiveResize = [self inLiveResize];
+bool bInLiveResize = [self inLiveResize];
if ( bInLiveResize || mbInLiveResize )
{
mbInLiveResize = bInLiveResize;
[Libreoffice-bugs] [Bug 152860] Find toolbar's "placeholder for message" (.uno:SearchLabel tooltip / label) makes it sound like something is missing
https://bugs.documentfoundation.org/show_bug.cgi?id=152860 Rafael Lima changed: What|Removed |Added CC||rafael.palma.l...@gmail.com Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #2 from Rafael Lima --- We can simply add a new "TooltipLabel" property to the command. Since it only has a "Label" property, the label is being used as the tooltip. The fix would look like this: [placeholder for message] Search results Not that the "[placeholder for message]" is replaced as the string content of the command and the newly added "TooltipLabel" is then used as tooltip. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 152860] Find toolbar's "placeholder for message" (.uno:SearchLabel tooltip / label) makes it sound like something is missing
https://bugs.documentfoundation.org/show_bug.cgi?id=152860 Rafael Lima changed: What|Removed |Added CC||rafael.palma.l...@gmail.com Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #2 from Rafael Lima --- We can simply add a new "TooltipLabel" property to the command. Since it only has a "Label" property, the label is being used as the tooltip. The fix would look like this: [placeholder for message] Search results Not that the "[placeholder for message]" is replaced as the string content of the command and the newly added "TooltipLabel" is then used as tooltip. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 148402] Presentation does not refresh if it's not visible
https://bugs.documentfoundation.org/show_bug.cgi?id=148402 --- Comment #2 from Kuba Orlik --- Sure thing. When `org.openoffice.Office.PresenterScreen` is set to `StartAlways`, the Presenter Console will be started even when using a single display. This is super useful when presenting over Zoom, as I can just share the window with the fullscreen slide to the audience, but keep my speaker notes visible on my display at home, all on one screen. So with the `StartAlways` option, start the presentation, alt+tab to the presenter console, go to Zoom or any other screensharing app, share the window with the fullscreen presentation, alt+tab to the presenter console, change to next slide, and see that the audience still sees the first slide. Only after you alt+tab to the window with the fullscreen slide, will the audience see the next slide. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152905] "Modify..." in Styles sidebar should be "Edit Style..." to match rest of UI
https://bugs.documentfoundation.org/show_bug.cgi?id=152905 Rafael Lima changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 152905] "Modify..." in Styles sidebar should be "Edit Style..." to match rest of UI
https://bugs.documentfoundation.org/show_bug.cgi?id=152905 Rafael Lima changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 152905] "Modify..." in Styles sidebar should be "Edit Style..." to match rest of UI
https://bugs.documentfoundation.org/show_bug.cgi?id=152905 Rafael Lima changed: What|Removed |Added CC||rafael.palma.l...@gmail.com --- Comment #1 from Rafael Lima --- I had never noticed this... but IMO this request makes sense. Let's CC the UX team. The fix would be very simple. Code pointer: https://opengrok.libreoffice.org/xref/core/sfx2/uiconfig/ui/stylecontextmenu.ui -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152949] New: error #1327 after hard drive failure
https://bugs.documentfoundation.org/show_bug.cgi?id=152949 Bug ID: 152949 Summary: error #1327 after hard drive failure Product: LibreOffice Version: 7.4.3.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Installation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: childp...@proton.me while computing space requirements, it throws the error... no previous options since all i did was run the installer. i had a big hard drive on F: but it broke. i probably installed libreoffice on it before, and maybe it's checking to repair it or something. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 152537] No obvious UI to set the document default font used e.g. in Line Numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=152537 --- Comment #17 from Mike Kaganski --- Created attachment 184545 --> https://bugs.documentfoundation.org/attachment.cgi?id=184545=edit Screencast (In reply to Heiko Tietze from comment #16) > Stylist > right click > font... does it matter? Yes is does; and doing that through stylist (F11) exactly *shows* the issue of line numbering *not* following the font change. It would follow the change, *if* you used Tools > Options > Writer > Basic Fonts: Default again for #3. So are you really sure you don't repro in your comment 14, when #3 uses your comment 16? -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 152537] No obvious UI to set the document default font used e.g. in Line Numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=152537 --- Comment #17 from Mike Kaganski --- Created attachment 184545 --> https://bugs.documentfoundation.org/attachment.cgi?id=184545=edit Screencast (In reply to Heiko Tietze from comment #16) > Stylist > right click > font... does it matter? Yes is does; and doing that through stylist (F11) exactly *shows* the issue of line numbering *not* following the font change. It would follow the change, *if* you used Tools > Options > Writer > Basic Fonts: Default again for #3. So are you really sure you don't repro in your comment 14, when #3 uses your comment 16? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152553] Spell Check Dialog Box Fails to Automatically Close When Done
https://bugs.documentfoundation.org/show_bug.cgi?id=152553 kit...@tutanota.com changed: What|Removed |Added CC||kit...@tutanota.com Status|RESOLVED|REOPENED Resolution|NOTABUG |--- --- Comment #3 from kit...@tutanota.com --- The so-called "fix" appears to be short-sighted. The proposal assumes that a programmer cannot think of another way to do the job. As one example, there are already flaws in the existing dialog box, such as a pop-up that asks if one wished to start at the beginning of the document. When that closes, the focus of the dialog box is lost. Oops. No, the whole thing deserves a re-think and re-program. The basic assumption is that the buttons all work the same. That is incorrect. I was selecting the Spelling Check button; not a Grammar Check button. These are two separate and distinct functions. I could go on, but there is no point. If the idea of separate functions is not understood, then the whole issue cannot be corrected. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 109527] [META] Spell check dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109527 Bug 109527 depends on bug 152553, which changed state. Bug 152553 Summary: Spell Check Dialog Box Fails to Automatically Close When Done https://bugs.documentfoundation.org/show_bug.cgi?id=152553 What|Removed |Added Status|RESOLVED|REOPENED Resolution|NOTABUG |--- -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 152553] Spell Check Dialog Box Fails to Automatically Close When Done
https://bugs.documentfoundation.org/show_bug.cgi?id=152553 kit...@tutanota.com changed: What|Removed |Added CC||kit...@tutanota.com Status|RESOLVED|REOPENED Resolution|NOTABUG |--- --- Comment #3 from kit...@tutanota.com --- The so-called "fix" appears to be short-sighted. The proposal assumes that a programmer cannot think of another way to do the job. As one example, there are already flaws in the existing dialog box, such as a pop-up that asks if one wished to start at the beginning of the document. When that closes, the focus of the dialog box is lost. Oops. No, the whole thing deserves a re-think and re-program. The basic assumption is that the buttons all work the same. That is incorrect. I was selecting the Spelling Check button; not a Grammar Check button. These are two separate and distinct functions. I could go on, but there is no point. If the idea of separate functions is not understood, then the whole issue cannot be corrected. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - vcl/qa vcl/source
vcl/qa/cppunit/pdfexport/data/ref-to-kids.pdf |binary
vcl/qa/cppunit/pdfexport/pdfexport.cxx| 61 ++
vcl/source/gdi/pdfwriter_impl.cxx | 29 ++--
3 files changed, 85 insertions(+), 5 deletions(-)
New commits:
commit d9cab7dc6dbbbe3d80aa765cfd0b3c9f85d73c06
Author: Dennis Francis
AuthorDate: Thu Dec 1 11:47:12 2022 +0530
Commit: Xisco Fauli
CommitDate: Mon Jan 9 17:08:24 2023 +
vcl: use /MediaBox origin in the ctm...
of the inner XObject, else the clip polypolygon may clip out partly or
whole contents. Adjusting the clip polypolygon is not straightforward.
Change-Id: If3b208ba850c3579c9e16c15e4fb2f947dad4406
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143561
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Miklos Vajna
(cherry picked from commit a67dcc248a103098de883a4dd2fa9ff2e1cc1f90)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144436
Tested-by: Jenkins
Signed-off-by: Xisco Fauli
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145202
diff --git a/vcl/qa/cppunit/pdfexport/data/ref-to-kids.pdf
b/vcl/qa/cppunit/pdfexport/data/ref-to-kids.pdf
index 598358a636aa..0390ccad8410 100644
Binary files a/vcl/qa/cppunit/pdfexport/data/ref-to-kids.pdf and
b/vcl/qa/cppunit/pdfexport/data/ref-to-kids.pdf differ
diff --git a/vcl/qa/cppunit/pdfexport/pdfexport.cxx
b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
index 428f9d5a132a..ce070a711911 100644
--- a/vcl/qa/cppunit/pdfexport/pdfexport.cxx
+++ b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
@@ -4186,6 +4186,67 @@ CPPUNIT_TEST_FIXTURE(PdfExportTest,
testRexportFilterSingletonArray)
CPPUNIT_ASSERT(it != pEnd);
}
+CPPUNIT_TEST_FIXTURE(PdfExportTest, testRexportMediaBoxOrigin)
+{
+// We need to enable PDFium import (and make sure to disable after the
test)
+bool bResetEnvVar = false;
+if (getenv("LO_IMPORT_USE_PDFIUM") == nullptr)
+{
+bResetEnvVar = true;
+osl_setEnvironment(OUString("LO_IMPORT_USE_PDFIUM").pData,
OUString("1").pData);
+}
+comphelper::ScopeGuard aPDFiumEnvVarGuard([&]() {
+if (bResetEnvVar)
+osl_clearEnvironment(OUString("LO_IMPORT_USE_PDFIUM").pData);
+});
+
+// Load the PDF and save as PDF
+vcl::filter::PDFDocument aDocument;
+load(u"ref-to-kids.pdf", aDocument);
+
+std::vector aPages = aDocument.GetPages();
+CPPUNIT_ASSERT_EQUAL(size_t(5), aPages.size());
+
+// Directly go to the inner XObject Im10 that contains the rectangle
drawings in page 2.
+auto pInnerIm = aDocument.LookupObject(10);
+CPPUNIT_ASSERT(pInnerIm);
+
+constexpr sal_Int32 aOrigin[2] = { -800, -600 };
+sal_Int32 aSize[2] = { 0, 0 };
+
+auto pBBox =
dynamic_cast(pInnerIm->Lookup("BBox"));
+CPPUNIT_ASSERT(pBBox);
+const auto& rElements2 = pBBox->GetElements();
+CPPUNIT_ASSERT_EQUAL(static_cast(4), rElements2.size());
+for (sal_Int32 nIdx = 0; nIdx < 4; ++nIdx)
+{
+const auto* pNumElement =
dynamic_cast(rElements2[nIdx]);
+CPPUNIT_ASSERT(pNumElement);
+if (nIdx < 2)
+CPPUNIT_ASSERT_EQUAL(aOrigin[nIdx],
static_cast(pNumElement->GetValue()));
+else
+aSize[nIdx - 2] = static_cast(pNumElement->GetValue())
- aOrigin[nIdx - 2];
+}
+
+auto pMatrix =
dynamic_cast(pInnerIm->Lookup("Matrix"));
+CPPUNIT_ASSERT(pMatrix);
+const auto& rElements = pMatrix->GetElements();
+CPPUNIT_ASSERT_EQUAL(static_cast(6), rElements.size());
+sal_Int32 aMatTranslate[6]
+= { // Rotation by $\theta$ $cos(\theta), sin(\theta), -sin(\theta),
cos(\theta)$
+0, -1, 1, 0,
+// Translate x,y
+-aOrigin[1] - aSize[1] / 2 + aSize[0] / 2, aOrigin[0] + aSize[0] /
2 + aSize[1] / 2
+ };
+
+for (sal_Int32 nIdx = 0; nIdx < 6; ++nIdx)
+{
+const auto* pNumElement =
dynamic_cast(rElements[nIdx]);
+CPPUNIT_ASSERT(pNumElement);
+CPPUNIT_ASSERT_EQUAL(aMatTranslate[nIdx],
static_cast(pNumElement->GetValue()));
+}
+}
+
} // end anonymous namespace
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx
b/vcl/source/gdi/pdfwriter_impl.cxx
index f4a3145c5085..d95a74aeb6af 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -8873,6 +8873,21 @@ void PDFWriterImpl::writeReferenceXObject(const
ReferenceXObjectEmit& rEmit)
return;
}
+double aOrigin[2] = { 0.0, 0.0 };
+if (auto* pArray =
dynamic_cast(pPage->Lookup("MediaBox")))
+{
+const auto& rElements = pArray->GetElements();
+if (rElements.size() >= 4)
+{
+// get x1, y1 of the rectangle.
+for (sal_Int32 nIdx = 0; nIdx < 2; ++nIdx)
+{
+if (const auto* pNumElement =
dynamic_cast(rElements[nIdx]))
+
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - sw/qa sw/source
sw/qa/filter/ww8/ww8.cxx | 30
sw/source/filter/ww8/attributeoutputbase.hxx |2 -
sw/source/filter/ww8/docxattributeoutput.cxx | 33 ++-
sw/source/filter/ww8/docxattributeoutput.hxx |2 -
sw/source/filter/ww8/rtfattributeoutput.cxx |3 +-
sw/source/filter/ww8/rtfattributeoutput.hxx |3 +-
sw/source/filter/ww8/wrtw8nds.cxx| 31 ++---
sw/source/filter/ww8/ww8atr.cxx |2 -
sw/source/filter/ww8/ww8attributeoutput.hxx |2 -
9 files changed, 89 insertions(+), 19 deletions(-)
New commits:
commit ae1e1d0910f4724d661cb6be26773ae51fac33e2
Author: Szymon Kłos
AuthorDate: Tue Nov 29 10:09:10 2022 +0100
Commit: Xisco Fauli
CommitDate: Mon Jan 9 16:45:50 2023 +
docx: export symbol characters correctly
Previously we had:
after save:
original content:
This patch checks if paragraph has symbol font used and exports
content using w:sym mark in that case
Change-Id: I74f4bb0d249cbf5dfc930e931f7d91bd0d2e9821
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143455
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Mike Kaganski
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144949
Tested-by: Jenkins
Reviewed-by: Szymon Kłos
(cherry picked from commit 87e82f80e87bb4a216ea83383864d494f3e92eea)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145219
Reviewed-by: Xisco Fauli
diff --git a/sw/qa/filter/ww8/ww8.cxx b/sw/qa/filter/ww8/ww8.cxx
index 8a2f97438d7b..611d63259ae8 100644
--- a/sw/qa/filter/ww8/ww8.cxx
+++ b/sw/qa/filter/ww8/ww8.cxx
@@ -9,6 +9,7 @@
#include
+#include
#include
#include
@@ -159,6 +160,35 @@ CPPUNIT_TEST_FIXTURE(Test,
testDocxContentControlDropdownEmptyDisplayText)
// i.e. we wrote an empty attribute instead of omitting it.
assertXPathNoAttribute(pXmlDoc,
"//w:sdt/w:sdtPr/w:dropDownList/w:listItem", "displayText");
}
+
+CPPUNIT_TEST_FIXTURE(Test, testDocxSymbolFontExport)
+{
+// Create document with symbol character and font Wingdings
+mxComponent = loadFromDesktop("private:factory/swriter");
+uno::Reference xMSF(mxComponent,
uno::UNO_QUERY);
+uno::Reference xTextDocument(mxComponent,
uno::UNO_QUERY);
+uno::Reference xText = xTextDocument->getText();
+uno::Reference xCursor = xText->createTextCursor();
+
+xText->insertString(xCursor, u"", true);
+
+uno::Reference xRange = xCursor;
+uno::Reference xTextProps(xRange, uno::UNO_QUERY);
+xTextProps->setPropertyValue("CharFontName",
uno::Any(OUString("Wingdings")));
+xTextProps->setPropertyValue("CharFontNameAsian",
uno::Any(OUString("Wingdings")));
+xTextProps->setPropertyValue("CharFontNameComplex",
uno::Any(OUString("Wingdings")));
+xTextProps->setPropertyValue("CharFontCharSet",
uno::Any(awt::CharSet::SYMBOL));
+
+// When exporting to DOCX:
+save("Office Open XML Text");
+
+// Then make sure the expected markup is used:
+xmlDocUniquePtr pXmlDoc = parseExport("word/document.xml");
+
+assertXPath(pXmlDoc, "//w:p/w:r/w:sym", 1);
+assertXPath(pXmlDoc, "//w:p/w:r/w:sym[1]", "font", "Wingdings");
+assertXPath(pXmlDoc, "//w:p/w:r/w:sym[1]", "char", "f0e0");
+}
}
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sw/source/filter/ww8/attributeoutputbase.hxx
b/sw/source/filter/ww8/attributeoutputbase.hxx
index ac3164ae2de6..99cae10812cc 100644
--- a/sw/source/filter/ww8/attributeoutputbase.hxx
+++ b/sw/source/filter/ww8/attributeoutputbase.hxx
@@ -191,7 +191,7 @@ public:
virtual void WritePostitFieldReference() {};
/// Output text (inside a run).
-virtual void RunText( const OUString& rText, rtl_TextEncoding eCharSet =
RTL_TEXTENCODING_UTF8 ) = 0;
+virtual void RunText( const OUString& rText, rtl_TextEncoding eCharSet =
RTL_TEXTENCODING_UTF8, const OUString& rSymbolFont = OUString() ) = 0;
/// Output text (without markup).
virtual void RawText(const OUString& rText, rtl_TextEncoding eCharSet) = 0;
diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx
b/sw/source/filter/ww8/docxattributeoutput.cxx
index 4f527862bf0a..80f09a85562f 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -3425,7 +3425,8 @@ bool DocxAttributeOutput::FootnoteEndnoteRefTag()
the switch in DocxAttributeOutput::RunText() nicer ;-)
*/
static bool impl_WriteRunText( FSHelperPtr const & pSerializer, sal_Int32
nTextToken,
-const sal_Unicode* , const sal_Unicode* pEnd, bool bMove = true
)
+const sal_Unicode* , const sal_Unicode* pEnd, bool bMove = true,
+const OUString& rSymbolFont = OUString() )
{
const sal_Unicode *pBegin = rBegin;
@@ -3436,22 +3437,34 @@ static bool impl_WriteRunText( FSHelperPtr const &
pSerializer, sal_Int32 nTextT
if ( pBegin >= pEnd )
return false; // we want to
[Libreoffice-bugs] [Bug 152919] LO Writer: user input fields not updating automatically
https://bugs.documentfoundation.org/show_bug.cgi?id=152919 --- Comment #10 from Detlef Girke --- (In reply to m.a.riosv from comment #9) > Ok I see, I was doing double-click to open the box to edit. > > Reproducible. > Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community > Build ID: 12e8d57e791bb1befc0716d4d02af7d1d1ccb4ae > CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: > win > Locale: es-ES (es_ES); UI: en-US > Calc: CL threaded Jumbo Ah good to know you can reproduce it. Please note that this bug affects all versions of LO since 7.3. Another hint: this bug leads to 152920 (https://bugs.documentfoundation.org/show_bug.cgi?id=152920), which corresponds with this bug but is much more severe: User Input fields in headers or footers are not visible at all when opening a document in LO 7.3 and above. But I think when 152919 is fixed, 152920 will automatically be fixed too :-) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147616] LibreCalc - taskbar icon graphic not working
https://bugs.documentfoundation.org/show_bug.cgi?id=147616 --- Comment #2 from csyu@gmail.com --- I was unable to reproduce with stable and unstable builds on my Windows 10. Version: 7.4.3.2 (x64) / LibreOffice Community Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 5a1f41a0d3aab15c113651f2edc9d4137ae99063 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135834] Page style > Area: Reset to None
https://bugs.documentfoundation.org/show_bug.cgi?id=135834 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||6345 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103223] [META] Area fill tab bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103223 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||136345 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=136345 [Bug 136345] UI: "Reset" in a dialog's Transparency tab resets to the last applied Area value, which creates confusion -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107642] [META] Paragraph dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107642 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||136345 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=136345 [Bug 136345] UI: "Reset" in a dialog's Transparency tab resets to the last applied Area value, which creates confusion -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 94722] [META] Object fill bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=94722 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||136345 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=136345 [Bug 136345] UI: "Reset" in a dialog's Transparency tab resets to the last applied Area value, which creates confusion -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136345] UI: "Reset" in a dialog's Transparency tab resets to the last applied Area value, which creates confusion
https://bugs.documentfoundation.org/show_bug.cgi?id=136345 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||5834 Summary|UI: "Reset" in Transparency |UI: "Reset" in a dialog's |tab of Paragraph Style |Transparency tab resets to |dialog resets to the last |the last applied Area |applied Area value, which |value, which creates |creates confusion. |confusion Blocks||107642, 94722, 103223 --- Comment #3 from Stéphane Guillou (stragu) --- Reproduced as described in description and comment 1 (although I don't have an Apply button), with: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 8ae84bb5566e12df64236a116b9d1889d6f5f052 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded This same "resetting of settings outside the transparency tab" is seen elsewhere, e.g. in the Area dialog for a shape, the Page style dialog, etc. Hard to pick a couple of meta bugs... Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=94722 [Bug 94722] [META] Object fill bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=103223 [Bug 103223] [META] Area fill tab bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=107642 [Bug 107642] [META] Paragraph dialog bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147538] Style Deleting Problem
https://bugs.documentfoundation.org/show_bug.cgi?id=147538 csyu@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||csyu@gmail.com Ever confirmed|0 |1 --- Comment #2 from csyu@gmail.com --- Could you attach a visual example? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151395] EPS is not rendered if Ghostscript not installed
https://bugs.documentfoundation.org/show_bug.cgi?id=151395 --- Comment #8 from Jean-Baptiste Faure --- If I remember correctly, OOo and LibreOffice have never been able to interpret PS/EPS files. What you see is the preview that is embedded in the EPS file. So I guess that the change was about the support of the format of the preview. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151395] EPS is not rendered if Ghostscript not installed
https://bugs.documentfoundation.org/show_bug.cgi?id=151395 Stéphane Guillou (stragu) changed: What|Removed |Added Summary|eps is not rendered |EPS is not rendered if ||Ghostscript not installed --- Comment #7 from Stéphane Guillou (stragu) --- Thanks Stuart! Sorry I missed that important bit. Installing ImageMagick (ImageMagick-7.1.0-57-Q16-HDRI-x64-dll), making sure it is added to the path by ticking the option during install, made no difference. With Ghostscript version 10.0.0 (2022-08-21) installed (and _without_ ImageMagick), the image is rendered on Windows 10 in LO 7.6 alpha0+, 7.5.0.1 and 7.4.3.2. Do you know what change since 7.4 branching made it so users need an extra library to be installed alongside LO for it to render EPS? Most users would see this as a regression, given that it used to work without that extra step, and given that inserting an image is perceived as a simple feature (even though EPS is much more than a raster). I couldn't find any documentation about it, and Regina is right in that if built-in support was dropped, the users should be informed somehow (via message, banner or visual on the element itself). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - basctl/source
basctl/source/dlged/dlged.cxx |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit 555dfdd35f662489df481485e5cd866f67e27a70
Author: Rafael Lima
AuthorDate: Tue Dec 20 13:37:53 2022 +
Commit: Adolfo Jayme Barrientos
CommitDate: Mon Jan 9 15:57:45 2023 +
tdf#152531 Fix background color of Dialog Editor in dark mode
Change-Id: I7006ff472dae5ce8d4b52c108f742c3c6d9b0b61
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144603
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
(cherry picked from commit 9c6aa7f2918819af670c6d6ed25645c725c91667)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145220
Tested-by: Adolfo Jayme Barrientos
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/basctl/source/dlged/dlged.cxx b/basctl/source/dlged/dlged.cxx
index 306555489df5..77ed2e8042db 100644
--- a/basctl/source/dlged/dlged.cxx
+++ b/basctl/source/dlged/dlged.cxx
@@ -550,8 +550,9 @@ void DlgEditor::Paint(vcl::RenderContext& rRenderContext,
const tools::Rectangle
// #i79128# ...and use correct OutDev for that
if (pTargetPaintWindow)
{
+Color maBackColor =
rRenderContext.GetSettings().GetStyleSettings().GetLightColor();
OutputDevice& rTargetOutDev =
pTargetPaintWindow->GetTargetOutputDevice();
-rTargetOutDev.DrawWallpaper(aPaintRect, Wallpaper(COL_WHITE));
+rTargetOutDev.DrawWallpaper(aPaintRect, Wallpaper(maBackColor));
}
// do paint (unbuffered) and mark repaint end
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/shells/textfld.cxx |3 +++
1 file changed, 3 insertions(+)
New commits:
commit 8336c61ba059551cb74df5ec53d2b45a3cf41814
Author: Miklos Vajna
AuthorDate: Mon Jan 9 09:52:32 2023 +0100
Commit: Miklos Vajna
CommitDate: Mon Jan 9 15:48:35 2023 +
sw: document FN_UPDATE_TEXT_FORMFIELD and FN_UPDATE_TEXT_FORMFIELDS
If you don't read the commit message or the code, it wasn't really
obvious that FN_UPDATE_TEXT_FORMFIELD works based on the current cursor.
Change-Id: Icd8bc856e5d50b995fa92559c873a50b48b98ba8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145189
Tested-by: Jenkins
Reviewed-by: Miklos Vajna
diff --git a/sw/source/uibase/shells/textfld.cxx
b/sw/source/uibase/shells/textfld.cxx
index dffea8e924ee..71e57ba0ae47 100644
--- a/sw/source/uibase/shells/textfld.cxx
+++ b/sw/source/uibase/shells/textfld.cxx
@@ -862,6 +862,8 @@ FIELD_INSERT:
break;
case FN_UPDATE_TEXT_FORMFIELDS:
{
+// This updates multiple fieldmarks in a document, based on their
field name & field command
+// prefix.
OUString aFieldType;
const SfxStringItem* pFieldType =
rReq.GetArg(FN_PARAM_1);
if (pFieldType)
@@ -1013,6 +1015,7 @@ FIELD_INSERT:
break;
case FN_UPDATE_TEXT_FORMFIELD:
{
+// This updates a single fieldmarks under the current cursor.
OUString aFieldType;
const SfxStringItem* pFieldType =
rReq.GetArg(FN_PARAM_1);
if (pFieldType)
[Libreoffice-bugs] [Bug 152944] "Freeze First Column" does not work when file was exported by Gnumeric
https://bugs.documentfoundation.org/show_bug.cgi?id=152944 Stéphane Guillou (stragu) changed: What|Removed |Added Resolution|--- |NOTABUG Status|UNCONFIRMED |RESOLVED --- Comment #3 from Stéphane Guillou (stragu) --- Hi David This is not a bug, the frozen rows / columns are only about what is always visible when editing the sheet. For printing something on every page, please see Format > Print ranges > Edit. Help: https://help.libreoffice.org/7.4/en-US/text/scalc/guide/line_fix.html -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151395] eps is not rendered
https://bugs.documentfoundation.org/show_bug.cgi?id=151395 --- Comment #6 from V Stuart Foote --- Created attachment 184544 --> https://bugs.documentfoundation.org/attachment.cgi?id=184544=edit Win10 Dark theme mode with ghostscript and imagemagik *on path* Again, can not confirm on a properly configured system, i.e. ghostscript and imagemagick helper programs *on path*! Attached from 7.5.0.1 release build shows the eps on canvas. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: include/toolkit toolkit/source
include/toolkit/awt/vclxaccessiblecomponent.hxx | 10 --
toolkit/source/awt/vclxaccessiblecomponent.cxx | 14 +++---
2 files changed, 3 insertions(+), 21 deletions(-)
New commits:
commit a58abb4296c50228ebd5510e50363072e9a96774
Author: Stephan Bergmann
AuthorDate: Mon Jan 9 11:43:36 2023 +0100
Commit: Stephan Bergmann
CommitDate: Mon Jan 9 15:15:41 2023 +
Clean up VCLXAccessibleComponent::getAccessibleParent
...after 21e0d8162a0e683558c4d042ce688fc9a6833809 "loplugin:unusedfields"
had
dropped the base class
OAccessibleImplementationAccess::implGetForeignControlledParent
Change-Id: I753aad41baaa0ac1d1f7eb0a6084993df5a58d5f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145197
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/include/toolkit/awt/vclxaccessiblecomponent.hxx
b/include/toolkit/awt/vclxaccessiblecomponent.hxx
index 7c299edf6d65..b69f62b6871f 100644
--- a/include/toolkit/awt/vclxaccessiblecomponent.hxx
+++ b/include/toolkit/awt/vclxaccessiblecomponent.hxx
@@ -117,16 +117,6 @@ public:
protected:
// base class overridables
css::awt::Rectangle implGetBounds( ) override;
-
-private:
-/** we may be reparented (if external components use
OAccessibleImplementationAccess base class),
-so this method here returns the parent in the VCL world, in opposite
to the parent
-an external component gave us
-@precond
-the caller must ensure thread safety, i.e. our mutex must be locked
-*/
-css::uno::Reference< css::accessibility::XAccessible >
-getVclParent() const;
};
/* --
diff --git a/toolkit/source/awt/vclxaccessiblecomponent.cxx
b/toolkit/source/awt/vclxaccessiblecomponent.cxx
index aef0eb1c3852..666ba75bde6a 100644
--- a/toolkit/source/awt/vclxaccessiblecomponent.cxx
+++ b/toolkit/source/awt/vclxaccessiblecomponent.cxx
@@ -553,8 +553,10 @@ uno::Reference< accessibility::XAccessible >
VCLXAccessibleComponent::getAccessi
return xAcc;
}
-uno::Reference< accessibility::XAccessible >
VCLXAccessibleComponent::getVclParent() const
+uno::Reference< accessibility::XAccessible >
VCLXAccessibleComponent::getAccessibleParent( )
{
+OExternalLockGuard aGuard( this );
+
uno::Reference< accessibility::XAccessible > xAcc;
if ( GetWindow() )
{
@@ -565,16 +567,6 @@ uno::Reference< accessibility::XAccessible >
VCLXAccessibleComponent::getVclPare
return xAcc;
}
-uno::Reference< accessibility::XAccessible >
VCLXAccessibleComponent::getAccessibleParent( )
-{
-OExternalLockGuard aGuard( this );
-
-// we do _not_ have a foreign-controlled parent -> default to our VCL
parent
-uno::Reference< accessibility::XAccessible > xAcc = getVclParent();
-
-return xAcc;
-}
-
sal_Int64 VCLXAccessibleComponent::getAccessibleIndexInParent( )
{
OExternalLockGuard aGuard( this );
[Libreoffice-commits] core.git: i18npool/source
i18npool/source/localedata/data/en_US.xml |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 2570eb7265fbae840bf9f2d83463b0bee09beaef Author: Justin Luth AuthorDate: Fri Jan 6 12:20:55 2023 -0500 Commit: Justin Luth CommitDate: Mon Jan 9 15:06:12 2023 + tdf#56258 i18npool en-US: document ISO 2145 compliant outline list format Change-Id: I27c2c3621434a4dbbcdd032672c668632494 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145158 Tested-by: Jenkins Reviewed-by: Vernon, Stuart Foote Reviewed-by: Justin Luth diff --git a/i18npool/source/localedata/data/en_US.xml b/i18npool/source/localedata/data/en_US.xml index 154c8791a9d2..fed97bfa97f1 100644 --- a/i18npool/source/localedata/data/en_US.xml +++ b/i18npool/source/localedata/data/en_US.xml @@ -616,7 +616,7 @@ - +
[Libreoffice-commits] core.git: i18npool/source
i18npool/source/localedata/data/en_US.xml | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) New commits: commit 5297528b85652d3f5a85e75ff6bcb406ba9b34d3 Author: Justin Luth AuthorDate: Fri Jan 6 10:31:41 2023 -0500 Commit: Justin Luth CommitDate: Mon Jan 9 15:05:27 2023 + tdf#56258 i18npool en-US: replace illogical outline 1.(a).i.A Change 1.(a).i.A. -> A.1.a.1. This is intended as a clean, modern style of outline that has good visual spacing in LibreOffice. It provides a simple alternative to the second style, reversing the order while still keeping a logical suffix pattern. This design will easily allow large/long lists to fit in the allotted space before the tabstop. There was no attempt to match the theme of the previous definition, since it neither looked good in LO's default spacing, nor was it consistent/logical. Change-Id: If7de1302110a3c97922bd2eeba7a917444110b27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145156 Tested-by: Jenkins Reviewed-by: Justin Luth Reviewed-by: Vernon, Stuart Foote diff --git a/i18npool/source/localedata/data/en_US.xml b/i18npool/source/localedata/data/en_US.xml index 40d86de5bcf3..154c8791a9d2 100644 --- a/i18npool/source/localedata/data/en_US.xml +++ b/i18npool/source/localedata/data/en_US.xml @@ -584,11 +584,11 @@ - - - - - + + + + +
[Libreoffice-commits] core.git: i18npool/source
i18npool/source/localedata/data/en_US.xml |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit c3964de14cb14099b49e1c55370a5f98e773e03d Author: Justin Luth AuthorDate: Fri Jan 6 09:05:39 2023 -0500 Commit: Justin Luth CommitDate: Mon Jan 9 15:04:57 2023 + tdf#56258 i18npool en-US: change outline order to match MLA style Changed I.A.i.a) -> I.A.1.a.i. The overwhelming result of a google search for "official/correct outline list format" indicates that the third level should be a 1, not an i. MLA Handbook (according to wikipedia) uses the order I.A.1.a.i. (a) (1) i) Chicago Mode of Style is usually interpreted as I.A.1.a) or I.A.1.a. with varying lower sublevels/suffixes. Wikipedia also suggest the logical order of I.A.1.a.i.I) A) 1) a) i) (I) (A) (1) (a) (i) Change-Id: I7fcc8a1ee727d6cddca4bf0c6a8461538769cf5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145147 Tested-by: Justin Luth Reviewed-by: Justin Luth diff --git a/i18npool/source/localedata/data/en_US.xml b/i18npool/source/localedata/data/en_US.xml index aaf853353985..40d86de5bcf3 100644 --- a/i18npool/source/localedata/data/en_US.xml +++ b/i18npool/source/localedata/data/en_US.xml @@ -600,12 +600,12 @@ - + - - - + + +
[Libreoffice-bugs] [Bug 152948] Calc Function Wizard incorrectly displays 2 ISEVEN() and 2 ISODD()
https://bugs.documentfoundation.org/show_bug.cgi?id=152948 Eike Rathke changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |er...@redhat.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152948] Calc Function Wizard incorrectly displays 2 ISEVEN() and 2 ISODD()
https://bugs.documentfoundation.org/show_bug.cgi?id=152948 Eike Rathke changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - translations
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 75d3c2d855182dfdbd2a9319f09fbd2326dbd146 Author: Martin Srebotnjak AuthorDate: Mon Jan 9 15:51:08 2023 +0100 Commit: Gerrit Code Review CommitDate: Mon Jan 9 14:51:08 2023 + Update git submodules * Update translations from branch 'libreoffice-7-5' to 8b465b54d8bb3a9bfb75f93ed628f2f6097cde56 - Updated Slovenian translation Change-Id: Iec474d1c3da3531eba722e6a6b4f9a146883e52f diff --git a/translations b/translations index 8ffb49605e95..8b465b54d8bb 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit 8ffb49605e9526ddbea8c0735a2c350d5e908f40 +Subproject commit 8b465b54d8bb3a9bfb75f93ed628f2f6097cde56
[Libreoffice-commits] translations.git: Branch 'libreoffice-7-5' - source/sl
source/sl/cui/messages.po | 18 +-- source/sl/extensions/messages.po |8 - source/sl/extras/source/gallery/share.po |4 source/sl/formula/messages.po |4 source/sl/helpcontent2/source/auxiliary.po | 16 +-- source/sl/helpcontent2/source/text/sbasic/shared.po| 12 +- source/sl/helpcontent2/source/text/sbasic/shared/03.po | 90 +++-- source/sl/helpcontent2/source/text/scalc/01.po |4 source/sl/helpcontent2/source/text/shared.po |4 source/sl/helpcontent2/source/text/shared/01.po|4 source/sl/helpcontent2/source/text/shared/02.po| 16 +-- source/sl/helpcontent2/source/text/shared/guide.po | 10 - source/sl/helpcontent2/source/text/swriter/01.po |6 - source/sl/helpcontent2/source/text/swriter/02.po |4 source/sl/helpcontent2/source/text/swriter/guide.po| 10 - source/sl/sd/messages.po |4 source/sl/sfx2/messages.po | 18 +-- source/sl/svtools/messages.po |4 source/sl/svx/messages.po |4 source/sl/sysui/desktop/share.po |4 20 files changed, 98 insertions(+), 146 deletions(-) New commits: commit 8b465b54d8bb3a9bfb75f93ed628f2f6097cde56 Author: Martin Srebotnjak AuthorDate: Mon Jan 9 15:51:02 2023 +0100 Commit: Andras Timar CommitDate: Mon Jan 9 15:51:02 2023 +0100 Updated Slovenian translation Change-Id: Iec474d1c3da3531eba722e6a6b4f9a146883e52f diff --git a/source/sl/cui/messages.po b/source/sl/cui/messages.po index 07111366ebe..cac94e5f101 100644 --- a/source/sl/cui/messages.po +++ b/source/sl/cui/messages.po @@ -3,14 +3,14 @@ msgid "" msgstr "" "Project-Id-Version: LibreOffice 7.5\n" "Report-Msgid-Bugs-To: https://bugs.libreoffice.org/enter_bug.cgi?product=LibreOffice_status=UNCONFIRMED=UI\n; -"POT-Creation-Date: 2022-12-23 13:23+0100\n" -"PO-Revision-Date: 2022-12-18 22:38+0200\n" +"POT-Creation-Date: 2023-01-09 09:30+0100\n" +"PO-Revision-Date: 2023-01-09 10:36+0200\n" "Last-Translator: Martin Srebotnjak \n" "Language-Team: sl.libreoffice.org\n" +"Language: sl\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" "Content-Transfer-Encoding: 8bit\n" -"Language: sl\n" "Plural-Forms: nplurals=4; plural=(n%100==1 ? 0 : n%100==2 ? 1 : n%100==3 || n%100==4 ? 2 : 3);\n" "X-Generator: Virtaal 0.7.1\n" "X-Accelerator-Marker: ~\n" @@ -714,7 +714,7 @@ msgstr "Tipka pritisnjena" #: cui/inc/strings.hrc:150 msgctxt "RID_SVXSTR_EVENT_KEYUP" msgid "Key released" -msgstr "Tipka spuščena" +msgstr "Tipka sproščena" #: cui/inc/strings.hrc:151 msgctxt "RID_SVXSTR_EVENT_LOADED" @@ -759,7 +759,7 @@ msgstr "Miškin gumb pritisnjen" #: cui/inc/strings.hrc:159 msgctxt "RID_SVXSTR_EVENT_MOUSERELEASED" msgid "Mouse button released" -msgstr "Miškin gumb spuščen" +msgstr "Miškin gumb sproščen" #: cui/inc/strings.hrc:160 msgctxt "RID_SVXSTR_EVENT_POSITIONING" @@ -1669,8 +1669,8 @@ msgstr "Naslova URL <%1> ni mogoče pretvoriti v pot datotečnega sistema." #: cui/inc/strings.hrc:368 msgctxt "aboutdialog|copyright" -msgid "Copyright © 2000–2022 LibreOffice contributors." -msgstr "Copyright © 2000 – 2022 avtorji prispevkov LibreOffice." +msgid "Copyright © 2000–2023 LibreOffice contributors." +msgstr "Copyright © 2000 – 2023 avtorji prispevkov LibreOffice." #: cui/inc/strings.hrc:369 msgctxt "aboutdialog|vendor" @@ -8247,8 +8247,8 @@ msgstr "Vnesite navpični odmik za preliv, pri čemer 0 % ustreza trenutnemu nav #: cui/uiconfig/ui/gradientpage.ui:393 msgctxt "gradientpage|borderft" -msgid "Mid_point:" -msgstr "_Srednja točka:" +msgid "_Border:" +msgstr "O_broba:" #: cui/uiconfig/ui/gradientpage.ui:427 msgctxt "gradientpage|extended_tip|bordermtr" diff --git a/source/sl/extensions/messages.po b/source/sl/extensions/messages.po index 3029f954376..c4117c94557 100644 --- a/source/sl/extensions/messages.po +++ b/source/sl/extensions/messages.po @@ -3,8 +3,8 @@ msgid "" msgstr "" "Project-Id-Version: LibreOffice 7.4\n" "Report-Msgid-Bugs-To: https://bugs.libreoffice.org/enter_bug.cgi?product=LibreOffice_status=UNCONFIRMED=UI\n; -"POT-Creation-Date: 2022-06-07 09:29+0200\n" -"PO-Revision-Date: 2022-06-06 19:27+0200\n" +"POT-Creation-Date: 2023-01-06 18:18+0100\n" +"PO-Revision-Date: 2022-12-27 01:28+0200\n" "Last-Translator: Martin Srebotnjak \n" "Language-Team: sl.libreoffice.org\n" "MIME-Version: 1.0\n" @@ -1252,7 +1252,7 @@ msgstr "Tipka pritisnjena" #: extensions/inc/strings.hrc:141 msgctxt "RID_STR_EVT_KEYUP" msgid "Key released" -msgstr "Tipka spuščena" +msgstr "Tipka sproščena" #: extensions/inc/strings.hrc:142 msgctxt "RID_STR_EVT_LOADED" @@ -1297,7 +1297,7 @@ msgstr "Miškin gumb pritisnjen" #: extensions/inc/strings.hrc:150 msgctxt "RID_STR_EVT_MOUSERELEASED"
[Libreoffice-bugs] [Bug 152945] PDF export of docx which include MS Visio objects
https://bugs.documentfoundation.org/show_bug.cgi?id=152945 Achim Stadter changed: What|Removed |Added Version|unspecified |7.5.0.1 rc -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - sw/qa sw/source
sw/qa/extras/uiwriter/data/cursor_position_after_undo.odt |binary
sw/qa/extras/uiwriter/uiwriter8.cxx | 41 ++
sw/source/core/edit/edundo.cxx|4 -
sw/source/uibase/inc/wrtsh.hxx| 12 +++-
sw/source/uibase/shells/basesh.cxx|2
5 files changed, 53 insertions(+), 6 deletions(-)
New commits:
commit 8aa39da7f223f38474b4f7e2b22f6c54f019c433
Author: Jim Raykowski
AuthorDate: Tue Dec 27 10:00:01 2022 -0900
Commit: Xisco Fauli
CommitDate: Mon Jan 9 14:45:05 2023 +
Outline folding: Fix cursor position after undo redo
This patch makes the cursor position to be the same after undo redo as
when outline folding is not active.
Change-Id: I9e1f827455afb2675f3085c1560b1e2a246f4524
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144873
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
(cherry picked from commit 156fd06dbca2fcca3246dba964a58a7ef698cf21)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145133
Reviewed-by: Xisco Fauli
diff --git a/sw/qa/extras/uiwriter/data/cursor_position_after_undo.odt
b/sw/qa/extras/uiwriter/data/cursor_position_after_undo.odt
new file mode 100644
index ..d6c300be61c0
Binary files /dev/null and
b/sw/qa/extras/uiwriter/data/cursor_position_after_undo.odt differ
diff --git a/sw/qa/extras/uiwriter/uiwriter8.cxx
b/sw/qa/extras/uiwriter/uiwriter8.cxx
index a5f41319c65f..42eaad1fb53a 100644
--- a/sw/qa/extras/uiwriter/uiwriter8.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter8.cxx
@@ -2547,6 +2547,47 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest8, testTdf151801)
CPPUNIT_ASSERT_EQUAL(sReplaced, getParagraph(1)->getString());
}
+CPPUNIT_TEST_FIXTURE(SwUiWriterTest8, testCursorPositionAfterUndo)
+{
+createSwDoc("cursor_position_after_undo.odt");
+SwDoc* pDoc = getSwDoc();
+SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+
+// switch on "Outline Folding" mode
+dispatchCommand(mxComponent, ".uno:ShowOutlineContentVisibilityButton",
{});
+
CPPUNIT_ASSERT(pWrtShell->GetViewOptions()->IsShowOutlineContentVisibilityButton());
+
+// move the cursor to the beginning of the 3rd word in the 3rd paragraph,
"tincidunt"
+pWrtShell->FwdPara();
+pWrtShell->FwdPara();
+pWrtShell->Right(SwCursorSkipMode::Chars, /*bSelect=*/false, 16,
/*bBasicCall=*/false);
+
+// select the word
+dispatchCommand(mxComponent, ".uno:SelectWord", {});
+
+// check the word is select
+SwShellCursor* pShellCursor = pWrtShell->getShellCursor(false);
+CPPUNIT_ASSERT_EQUAL(OUString("tincidunt"), pShellCursor->GetText());
+
+// remember the cursor position for comparsion
+SwPosition aCursorPos(*pWrtShell->GetCursor()->GetPoint());
+
+// delete the selected word
+pWrtShell->Delete();
+
+// undo delete
+dispatchCommand(mxComponent, ".uno:Undo", {});
+
+// without the fix in place, the cursor would have been set to the start
of the outline node
+// - Expected: SwPosition (node 11, offset 25)
+// - Actual : SwPosition (node 9, offset 0)
+CPPUNIT_ASSERT_EQUAL(aCursorPos, *pWrtShell->GetCursor()->GetPoint());
+
+// switch off "Outline Folding" mode
+dispatchCommand(mxComponent, ".uno:ShowOutlineContentVisibilityButton",
{});
+
CPPUNIT_ASSERT(!pWrtShell->GetViewOptions()->IsShowOutlineContentVisibilityButton());
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/edit/edundo.cxx b/sw/source/core/edit/edundo.cxx
index 9516488cbc61..576b092214df 100644
--- a/sw/source/core/edit/edundo.cxx
+++ b/sw/source/core/edit/edundo.cxx
@@ -104,7 +104,7 @@ void
SwEditShell::HandleUndoRedoContext(::sw::UndoRedoContext & rContext)
void SwEditShell::Undo(sal_uInt16 const nCount, sal_uInt16 nOffset)
{
-MakeAllOutlineContentTemporarilyVisible a(GetDoc());
+MakeAllOutlineContentTemporarilyVisible a(GetDoc(), true);
CurrShell aCurr( this );
@@ -161,7 +161,7 @@ void SwEditShell::Undo(sal_uInt16 const nCount, sal_uInt16
nOffset)
void SwEditShell::Redo(sal_uInt16 const nCount)
{
-MakeAllOutlineContentTemporarilyVisible a(GetDoc());
+MakeAllOutlineContentTemporarilyVisible a(GetDoc(), true);
CurrShell aCurr( this );
diff --git a/sw/source/uibase/inc/wrtsh.hxx b/sw/source/uibase/inc/wrtsh.hxx
index 98b3d9038204..801e52bef7ab 100644
--- a/sw/source/uibase/inc/wrtsh.hxx
+++ b/sw/source/uibase/inc/wrtsh.hxx
@@ -681,9 +681,10 @@ class MakeAllOutlineContentTemporarilyVisible
private:
SwWrtShell* m_pWrtSh = nullptr;
bool m_bDone = false;
+bool m_bScrollToCursor = false;
public:
static sal_uInt32 nLock;
-MakeAllOutlineContentTemporarilyVisible(SwDoc* pDoc)
+MakeAllOutlineContentTemporarilyVisible(SwDoc* pDoc, bool bScrollToCursor
= false)
{
++nLock;
if (nLock > 1)
@@ -692,8 +693,10 @@
[Libreoffice-bugs] [Bug 108253] [META] Calc cell formula bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108253 Bug 108253 depends on bug 80347, which changed state. Bug 80347 Summary: Enhancement request: change Arguments and Outputs to English when Formulas are set to English names https://bugs.documentfoundation.org/show_bug.cgi?id=80347 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 80347] Enhancement request: change Arguments and Outputs to English when Formulas are set to English names
https://bugs.documentfoundation.org/show_bug.cgi?id=80347 Eike Rathke changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||1886 Resolution|FIXED |--- Status|RESOLVED|REOPENED --- Comment #4 from Eike Rathke --- Reopening because that new behaviour has been reverted for bug 151886. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151395] eps is not rendered
https://bugs.documentfoundation.org/show_bug.cgi?id=151395 Stéphane Guillou (stragu) changed: What|Removed |Added Version|7.5.0.0 alpha0+ |7.4.3.2 release Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Keywords||bibisectRequest CC||stephane.guillou@libreoffic ||e.org --- Comment #5 from Stéphane Guillou (stragu) --- Reproduced this Windows-only issue like Regina and Miguel Angel, no image displayed in: Version: 7.5.0.1 (X86_64) / LibreOffice Community Build ID: 77cd3d7ad4445740a0c6cf977992dafd8ebad8df CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: en-GB (en_GB); UI: en-GB Calc: threaded Version: 7.4.3.2 (x64) / LibreOffice Community Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: en-GB (en_GB); UI: en-GB Calc: threaded But EPS rendered in: Version: 7.3.0.0.alpha1 (x64) / LibreOffice Community Build ID: a3c29ae3d906f4692090bd4e5dab29623c66014a CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: en-GB (en_GB); UI: en-GB Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152676] Writer: Compatibility options no longer saved as default
https://bugs.documentfoundation.org/show_bug.cgi?id=152676 --- Comment #4 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/73cd20ec950f631a5ddfb73ee57f49a5ad2beb0a tdf#152676 Writer: Compatibility options no longer saved as default It will be available in 7.4.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152676] Writer: Compatibility options no longer saved as default
https://bugs.documentfoundation.org/show_bug.cgi?id=152676 Commit Notification changed: What|Removed |Added Whiteboard|target:7.6.0|target:7.6.0 target:7.4.5 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120201] [META] Update or add link to help page
https://bugs.documentfoundation.org/show_bug.cgi?id=120201 Bug 120201 depends on bug 129726, which changed state. Bug 129726 Summary: The help button (and F1 for individual items) in the "Edit Index Entry" dialog opens the help for "Insert Index Entry" https://bugs.documentfoundation.org/show_bug.cgi?id=129726 What|Removed |Added Status|VERIFIED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - include/unotools sw/source unotools/source
include/unotools/compatibility.hxx | 11 ---
sw/source/ui/config/optcomp.cxx | 10 --
unotools/source/config/compatibility.cxx |2 --
3 files changed, 8 insertions(+), 15 deletions(-)
New commits:
commit 73cd20ec950f631a5ddfb73ee57f49a5ad2beb0a
Author: Noel Grandin
AuthorDate: Sat Dec 31 08:52:53 2022 +0200
Commit: Xisco Fauli
CommitDate: Mon Jan 9 14:31:47 2023 +
tdf#152676 Writer: Compatibility options no longer saved as default
regression from
commit 78adf246d5e99d0f5d91d2e03c1379b154289d8d
Date: Mon Jul 26 10:54:36 2021 +0200
return SvtCompatibilityEntry from SvtCompatibilityOptions::GetList
where I mistakenly assumed that the bIsDefault flag in
SvtCompatibilityEntry was being set by the SvtCompatibilityOptions
code. Rather remove this field if it is not going to be maintained
properly.
Change-Id: I23963ae885563d5abc8a99cfd144d7fe00c6f192
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144882
Tested-by: Jenkins
Reviewed-by: Noel Grandin
(cherry picked from commit c6f756e968bbb72522bd01dea283288a61a286a7)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145217
Reviewed-by: Xisco Fauli
diff --git a/include/unotools/compatibility.hxx
b/include/unotools/compatibility.hxx
index c5dc3fb14746..b929771b5744 100644
--- a/include/unotools/compatibility.hxx
+++ b/include/unotools/compatibility.hxx
@@ -130,19 +130,8 @@ class SvtCompatibilityEntry
setValue(rIdx, css::uno::Any(rValue));
}
-bool isDefaultEntry() const
-{
-return m_bDefaultEntry;
-}
-
-void setDefaultEntry( bool rValue )
-{
-m_bDefaultEntry = rValue;
-}
-
private:
std::vector m_aPropertyValue;
-bool m_bDefaultEntry;
};
/*-
diff --git a/sw/source/ui/config/optcomp.cxx b/sw/source/ui/config/optcomp.cxx
index 663faf7be2c6..ec8ac3ddfb33 100644
--- a/sw/source/ui/config/optcomp.cxx
+++ b/sw/source/ui/config/optcomp.cxx
@@ -209,10 +209,11 @@ void SwCompatibilityOptPage::InitControls( const
SfxItemSet& rSet )
{
const OUString sEntryName = rEntry.getValue(
SvtCompatibilityEntry::Index::Name );
const bool bIsUserEntry= ( sEntryName ==
SvtCompatibilityEntry::USER_ENTRY_NAME );
+const bool bIsDefaultEntry = ( sEntryName ==
SvtCompatibilityEntry::DEFAULT_ENTRY_NAME );
m_pImpl->m_aList.push_back( rEntry );
-if ( rEntry.isDefaultEntry() )
+if ( bIsDefaultEntry )
continue;
OUString sNewEntry;
@@ -265,7 +266,12 @@ IMPL_LINK_NOARG(SwCompatibilityOptPage, UseAsDefaultHdl,
weld::Button&, void)
return;
auto pItem = std::find_if(m_pImpl->m_aList.begin(), m_pImpl->m_aList.end(),
-[](const SvtCompatibilityEntry& rItem) { return
rItem.isDefaultEntry(); });
+[](const SvtCompatibilityEntry& rItem)
+{
+const OUString sEntryName = rItem.getValue(
SvtCompatibilityEntry::Index::Name );
+const bool bIsDefaultEntry = ( sEntryName ==
SvtCompatibilityEntry::DEFAULT_ENTRY_NAME );
+return bIsDefaultEntry;
+});
if (pItem != m_pImpl->m_aList.end())
{
const sal_Int32 nCount = m_xOptionsLB->n_children();
diff --git a/unotools/source/config/compatibility.cxx
b/unotools/source/config/compatibility.cxx
index affcaf5a38e0..95bcc2dc59b6 100644
--- a/unotools/source/config/compatibility.cxx
+++ b/unotools/source/config/compatibility.cxx
@@ -66,8 +66,6 @@ SvtCompatibilityEntry::SvtCompatibilityEntry()
setValue( Index::SubtractFlysAnchoredAtFlys, false );
setValue( Index::EmptyDbFieldHidesPara, true );
setValue( Index::AddTableLineSpacing, false );
-
-setDefaultEntry( false );
}
OUString SvtCompatibilityEntry::getName( const Index rIdx )
[Libreoffice-bugs] [Bug 152948] Calc Function Wizard incorrectly displays 2 ISEVEN() and 2 ISODD()
https://bugs.documentfoundation.org/show_bug.cgi?id=152948 Buovjaga changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||5993 Keywords||bibisected, bisected, ||regression OS|Windows (All) |All CC||er...@redhat.com, ||ilmari.lauhakangas@libreoff ||ice.org Regression By||Eike Rathke Version|7.4.3.2 release |7.5.0.0 alpha0+ --- Comment #1 from Buovjaga --- Bibisected with linux-64-7.4 repo to https://git.libreoffice.org/core/commit/32019fae7730fc8d94f14d47ebaccbdc6775340a Resolves: tdf#135993 Create ScFunctionList and ScFuncDesc with English names That commit was a backport of d778c6fd5c2ba8e27df46ec9e183a61ad29e30d5 originally for 7.5 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/source
vcl/source/treelist/svtabbx.cxx | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
New commits:
commit aff880740311e37740b8b0231bb7a7947ad922d7
Author: Szymon Kłos
AuthorDate: Wed Jan 4 15:28:34 2023 +0100
Commit: Szymon Kłos
CommitDate: Mon Jan 9 14:14:47 2023 +
jsdialog: don't export collapsed/expanded icons when empty
Change-Id: Iec56c11fdba066f9b62b2d5d56ad011a821e4087
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145040
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Szymon Kłos
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145066
Tested-by: Jenkins
diff --git a/vcl/source/treelist/svtabbx.cxx b/vcl/source/treelist/svtabbx.cxx
index f766cde70559..9ef0e145ed6d 100644
--- a/vcl/source/treelist/svtabbx.cxx
+++ b/vcl/source/treelist/svtabbx.cxx
@@ -75,9 +75,16 @@ static void lcl_DumpEntryAndSiblings(tools::JsonWriter&
rJsonWriter,
const SvLBoxContextBmp* pBmpItem = dynamic_cast();
if (pBmpItem)
{
-auto aColumn = rJsonWriter.startStruct();
-rJsonWriter.put("collapsed",
pBmpItem->GetBitmap1().GetStock());
-rJsonWriter.put("expanded",
pBmpItem->GetBitmap2().GetStock());
+const OUString& rCollapsed =
pBmpItem->GetBitmap1().GetStock();
+const OUString& rExpanded =
pBmpItem->GetBitmap2().GetStock();
+if (!rCollapsed.trim().isEmpty() ||
!rExpanded.trim().isEmpty())
+{
+auto aColumn = rJsonWriter.startStruct();
+if (!rCollapsed.trim().isEmpty())
+rJsonWriter.put("collapsed", rCollapsed);
+if (!rExpanded.trim().isEmpty())
+rJsonWriter.put("expanded", rExpanded);
+}
}
}
}
[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-4' - sw/uiconfig
sw/uiconfig/sglobal/popupmenu/table.xml |1 + sw/uiconfig/sweb/popupmenu/table.xml|1 + sw/uiconfig/swform/popupmenu/table.xml |1 + sw/uiconfig/swriter/popupmenu/table.xml |1 + sw/uiconfig/swxform/popupmenu/table.xml |1 + 5 files changed, 5 insertions(+) New commits: commit c6eef4b7a9849d5aa8dfeab0bf9dada833fee01d Author: Gabor Kelemen AuthorDate: Mon Jan 9 15:11:16 2023 +0100 Commit: Gabor Kelemen CommitDate: Mon Jan 9 15:11:16 2023 +0100 tdf#131046 Add back Number Format item to Writer table context menus Change-Id: I9b7ed2ebe808f05c778b8a993b4df4fdd4f6a151 diff --git a/sw/uiconfig/sglobal/popupmenu/table.xml b/sw/uiconfig/sglobal/popupmenu/table.xml index 7f3cbb6ebe6e..3ae9ad5f688e 100644 --- a/sw/uiconfig/sglobal/popupmenu/table.xml +++ b/sw/uiconfig/sglobal/popupmenu/table.xml @@ -135,6 +135,7 @@ + diff --git a/sw/uiconfig/sweb/popupmenu/table.xml b/sw/uiconfig/sweb/popupmenu/table.xml index 7f3cbb6ebe6e..3ae9ad5f688e 100644 --- a/sw/uiconfig/sweb/popupmenu/table.xml +++ b/sw/uiconfig/sweb/popupmenu/table.xml @@ -135,6 +135,7 @@ + diff --git a/sw/uiconfig/swform/popupmenu/table.xml b/sw/uiconfig/swform/popupmenu/table.xml index 7f3cbb6ebe6e..3ae9ad5f688e 100644 --- a/sw/uiconfig/swform/popupmenu/table.xml +++ b/sw/uiconfig/swform/popupmenu/table.xml @@ -135,6 +135,7 @@ + diff --git a/sw/uiconfig/swriter/popupmenu/table.xml b/sw/uiconfig/swriter/popupmenu/table.xml index 7d501545f160..1f8ca8ee499c 100644 --- a/sw/uiconfig/swriter/popupmenu/table.xml +++ b/sw/uiconfig/swriter/popupmenu/table.xml @@ -138,6 +138,7 @@ + diff --git a/sw/uiconfig/swxform/popupmenu/table.xml b/sw/uiconfig/swxform/popupmenu/table.xml index 7f3cbb6ebe6e..3ae9ad5f688e 100644 --- a/sw/uiconfig/swxform/popupmenu/table.xml +++ b/sw/uiconfig/swxform/popupmenu/table.xml @@ -135,6 +135,7 @@ +
[Libreoffice-bugs] [Bug 152648] Hang pressing Calc button in Start Center with Voice Over enabled (macOS)
https://bugs.documentfoundation.org/show_bug.cgi?id=152648 --- Comment #3 from Patrick Luby --- (In reply to Alex Thurgood from comment #1) > Enclosing Apple Trace. > > Looks very similar to previous aqua ally callbacks which caused crashing and > which Patrick fixed elsewhere ? I can also reproduce this hang. Like in your stack trace, I see a hang in the following LibreOffice accessiblity function in the middle of the stack trace: -[AquaA11yTableWrapper rowsAttribute] Everything below that is adding an NSView to the window. A quick look at that code and it looks like it is adding a separate NSView to the window for every cell in a spreadsheet. Adding NSViews is slow so it looks like LibreOffice is working through a huge list of cells. I will have to look deeper at the code as there is a hardcoded 1000 cell limit which would slow, but eventually LibreOffice would unhang. Maybe that limit needs to be drastically lower. I'll post when I have some more data. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152890] No Insert/Edit Index Entry help page with Help ID modules/swriter/ui/indexentry/frame
https://bugs.documentfoundation.org/show_bug.cgi?id=152890 Stéphane Guillou (stragu) changed: What|Removed |Added Version|7.4.3.2 release |7.5.0.1 rc -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152942] All help links in dialog windows do not work
https://bugs.documentfoundation.org/show_bug.cgi?id=152942 Stéphane Guillou (stragu) changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=15 | |2890| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152733] [ HELP ] button on Fields' dialog's Functions page leads to an Error URL in 7.5 RC1
https://bugs.documentfoundation.org/show_bug.cgi?id=152733 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org --- Comment #2 from Stéphane Guillou (stragu) --- *** Bug 152890 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120201] [META] Update or add link to help page
https://bugs.documentfoundation.org/show_bug.cgi?id=120201 Bug 120201 depends on bug 152890, which changed state. Bug 152890 Summary: No Insert/Edit Index Entry help page with Help ID modules/swriter/ui/indexentry/frame https://bugs.documentfoundation.org/show_bug.cgi?id=152890 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152890] No Insert/Edit Index Entry help page with Help ID modules/swriter/ui/indexentry/frame
https://bugs.documentfoundation.org/show_bug.cgi?id=152890 Stéphane Guillou (stragu) changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=15 | |2942| --- Comment #1 from Stéphane Guillou (stragu) --- Now works as expected for 7.4. Could have been a temporary documentation build issue. Still broken for 7.5, but that is probably another documentation build issue reported elsewhere: bug 152733. The wrong Help ID for the Edit dialog is an older issue, already reported in bug 129726, which should have been fixed but commits were only made to the documentation repository, not to core. Marking as a duplicate and reopening there. *** This bug has been marked as a duplicate of bug 152733 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103341 V Stuart Foote changed: What|Removed |Added Depends on||152936 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=152936 [Bug 152936] Feature Request: Consider adding autocomplete (with full-text search) to cell validation -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145198] Bash like autocompletion for Calc's autoinput
https://bugs.documentfoundation.org/show_bug.cgi?id=145198 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||2936 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152936] Feature Request: Consider adding autocomplete (with full-text search) to cell validation
https://bugs.documentfoundation.org/show_bug.cgi?id=152936 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||5198 Blocks||103341 CC||dennisfrancis...@gmail.com, ||libreoffice-ux-advise@lists ||.freedesktop.org, ||vsfo...@libreoffice.org Keywords||needsUXEval --- Comment #1 from V Stuart Foote --- I guess possibly perform full text "search" finding target midspan and at endings of cell contents. But the progressive "bash like" auto complete of bug 145198 is pretty functional already. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103341 [Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 152936] Feature Request: Consider adding autocomplete (with full-text search) to cell validation
https://bugs.documentfoundation.org/show_bug.cgi?id=152936 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||5198 Blocks||103341 CC||dennisfrancis...@gmail.com, ||libreoffice-ux-advise@lists ||.freedesktop.org, ||vsfo...@libreoffice.org Keywords||needsUXEval --- Comment #1 from V Stuart Foote --- I guess possibly perform full text "search" finding target midspan and at endings of cell contents. But the progressive "bash like" auto complete of bug 145198 is pretty functional already. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103341 [Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 152948] New: Calc Function Wizard incorrectly displays 2 ISEVEN() and 2 ISODD()
https://bugs.documentfoundation.org/show_bug.cgi?id=152948 Bug ID: 152948 Summary: Calc Function Wizard incorrectly displays 2 ISEVEN() and 2 ISODD() Product: LibreOffice Version: 7.4.3.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: adylo811...@gmail.com Description: Searching for ISEVEN in the Function Wizard, shows 2 results: ISEVEN(Value) and ISEVEN(Number). One of those should be ISEVEN_ADD. Same goes for ISODD. When unchecking the option to "Use English function names", the "_ADD" functions are shown, but not when the option is checked. Steps to Reproduce: Set the option to use English function names, start the Function Wizard, type ISEVEN, see the list of functions. Set the option NOT to use English function names, start the Function Wizard, type ISEVEN, see the list of functions. The same goes for ISODD. Actual Results: 2 ISEVEN (or 2 ISODD). Users cannot distinguish between the two. Expected Results: Two distinctive functions should be listed: ISEVEN and ISEVEN_ADD (or ISODD and ISODD_ADD). Reproducible: Always User Profile Reset: No Additional Info: Version: 7.4.3.2 (x64) / LibreOffice Community Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: default; VCL: win Locale: en-US (es_AR); UI: en-US Calc: CL It can be replicated in Safe Mode too. Reported in irc #libreoffice-qa -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152537] No obvious UI to set the document default font used e.g. in Line Numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=152537 --- Comment #16 from Heiko Tietze --- (In reply to Mike Kaganski from comment #15) > (In reply to Heiko Tietze from comment #14) > > 3. Change Default Paragraph Style back to Liberation Sans, or the like => > > line numbering follows (I read the discussion as if it doesn't) > No idea, because you chose not to explain how you performed #3. Stylist > right click > font... does it matter? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 152537] No obvious UI to set the document default font used e.g. in Line Numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=152537 --- Comment #16 from Heiko Tietze --- (In reply to Mike Kaganski from comment #15) > (In reply to Heiko Tietze from comment #14) > > 3. Change Default Paragraph Style back to Liberation Sans, or the like => > > line numbering follows (I read the discussion as if it doesn't) > No idea, because you chose not to explain how you performed #3. Stylist > right click > font... does it matter? -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 150760] Help button in Row Height/Column Width dialogs do not have a target
https://bugs.documentfoundation.org/show_bug.cgi?id=150760 Stéphane Guillou (stragu) changed: What|Removed |Added Version|7.4.0.3 release |7.1.0.3 release Blocks||120201 OS|macOS (All) |All CC||stephane.guillou@libreoffic ||e.org --- Comment #3 from Stéphane Guillou (stragu) --- Still the case in a master build from today: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 8ae84bb5566e12df64236a116b9d1889d6f5f052 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded and since: Version: 7.1.0.3 / LibreOffice Community Build ID: f6099ecf3d29644b5008cc8f48f42f4a40986e4c CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Help ID for row height is: dbaccess/ui/rowheightdialog/grid2 Help ID for column width is: dbaccess/ui/colwidthdialog/grid2 Version 7.0 would redirect to the generic Base main help page: Version: 7.0.6.2 Build ID: 144abb84a525d8e30c9dbbefa69cbbf2d8d4ae3b CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=120201 [Bug 120201] [META] Update or add link to help page -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120201] [META] Update or add link to help page
https://bugs.documentfoundation.org/show_bug.cgi?id=120201 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||150760 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=150760 [Bug 150760] Help button in Row Height/Column Width dialogs do not have a target -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152943] GetErrCode() doesn't work as expected on RISC-V due to floating-point NaN payload not being propagated
https://bugs.documentfoundation.org/show_bug.cgi?id=152943 Eike Rathke changed: What|Removed |Added Summary|GetErrCode() doesn't work |GetErrCode() doesn't work |as expected on RISC-V due |as expected on RISC-V due |to invalid floating-point |to floating-point NaN |operation in KahanSum |payload not being ||propagated -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152712] Support setting style attributes relative to parent style
https://bugs.documentfoundation.org/show_bug.cgi?id=152712 --- Comment #7 from Eyal Rozenberg --- (In reply to Mike Kaganski from comment #5) > This is not fair. This is not a real use case I personally do this with every... say, third multi-page document I write. Except I have to manually tweak the spacing of styles. I also do this for font sizes, and there we do the ability to specify sizes relatively, so it's better. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 152712] Support setting style attributes relative to parent style
https://bugs.documentfoundation.org/show_bug.cgi?id=152712 --- Comment #7 from Eyal Rozenberg --- (In reply to Mike Kaganski from comment #5) > This is not fair. This is not a real use case I personally do this with every... say, third multi-page document I write. Except I have to manually tweak the spacing of styles. I also do this for font sizes, and there we do the ability to specify sizes relatively, so it's better. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 152943] GetErrCode() doesn't work as expected on RISC-V due to invalid floating-point operation in KahanSum
https://bugs.documentfoundation.org/show_bug.cgi?id=152943 --- Comment #3 from Eike Rathke --- https://groups.google.com/a/groups.riscv.org/g/isa-dev/c/g79dHlV4B_k/m/dtlPNaq8AwAJ from 2016: "We considered supporting payloads but frankly could not find any example of this being used portably in practice." "we’d like to see some compelling portable use cases before mandating extra hardware on every RISC-V FPU implementation" /me wonders if meanwhile they'd heard of LibreOffice. So this just rules out RISC-V as a supported platform I guess? And we maybe should add a test to sal/qa/rtl/math/test-rtl-math.cxx or even a static_assert() in sal/rtl/math.cxx to fail early in the build process. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152712] Support setting style attributes relative to parent style
https://bugs.documentfoundation.org/show_bug.cgi?id=152712 --- Comment #6 from Eyal Rozenberg --- (In reply to Heiko Tietze from comment #4) > Programmatically creating styles is not a common use case to me but could be > done per macro anyway. I didn't talk about doing anything programmatically. When considering - and experimenting with - a document's styles, which happens in any new document that's not in an exact same style you used before - you want to make some changes that affect multiple (or all) styles. Right now, you can only do that for very few attributes, like the direction for example. But it is quite common to want to play with/change the spacing before and after heading paragraphs. With this feature, you would not have to change N heading styles to see the effect of a 20% relative increase for all headings (or perhaps even - for all paragraphs). This spacing tweaking is also frequent when a document's content is ready: You want to control how many pages it will occupy, and so tweak various spacing settings (inter-line, after, before paragraph, as well as maybe margins etc.) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 152712] Support setting style attributes relative to parent style
https://bugs.documentfoundation.org/show_bug.cgi?id=152712 --- Comment #6 from Eyal Rozenberg --- (In reply to Heiko Tietze from comment #4) > Programmatically creating styles is not a common use case to me but could be > done per macro anyway. I didn't talk about doing anything programmatically. When considering - and experimenting with - a document's styles, which happens in any new document that's not in an exact same style you used before - you want to make some changes that affect multiple (or all) styles. Right now, you can only do that for very few attributes, like the direction for example. But it is quite common to want to play with/change the spacing before and after heading paragraphs. With this feature, you would not have to change N heading styles to see the effect of a 20% relative increase for all headings (or perhaps even - for all paragraphs). This spacing tweaking is also frequent when a document's content is ready: You want to control how many pages it will occupy, and so tweak various spacing settings (inter-line, after, before paragraph, as well as maybe margins etc.) -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 87040] Floating toolbar feature request aka "mini toolbar"
https://bugs.documentfoundation.org/show_bug.cgi?id=87040 V Stuart Foote changed: What|Removed |Added CC||domen.b...@zohomail.eu --- Comment #12 from V Stuart Foote --- *** Bug 152934 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152934] "Mini Toolbar": after text selection (Writter, Calc, Impress) a mini toolbar should automaticaly appear with icons to set fonts, alignment, text color, indenting, and b
https://bugs.documentfoundation.org/show_bug.cgi?id=152934 V Stuart Foote changed: What|Removed |Added CC||vsfo...@libreoffice.org Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from V Stuart Foote --- *** This bug has been marked as a duplicate of bug 87040 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152935] LibreOffice crashing on keyboard-shortcut (QUOTELEFT_MOD1) for changing documents within an application on Mac OS
https://bugs.documentfoundation.org/show_bug.cgi?id=152935 V Stuart Foote changed: What|Removed |Added CC||vsfo...@libreoffice.org Summary|LibreOffice crashing on |LibreOffice crashing on |keyboard-shortcut for |keyboard-shortcut |changing documents within |(QUOTELEFT_MOD1) for |an application on Mac OS|changing documents within ||an application on Mac OS Blocks||115280 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115280 [Bug 115280] [META] Grave (QUOTELEFT) shortcut bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 115280] [META] Grave (QUOTELEFT) shortcut bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=115280 V Stuart Foote changed: What|Removed |Added Depends on||152935 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=152935 [Bug 152935] LibreOffice crashing on keyboard-shortcut (QUOTELEFT_MOD1) for changing documents within an application on Mac OS -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152947] Icon (Document saved / not yet) not suitable for color blinds
https://bugs.documentfoundation.org/show_bug.cgi?id=152947 Buovjaga changed: What|Removed |Added Keywords||accessibility Summary|Icon (Document saved / not |Icon (Document saved / not |jet) not suitable for color |yet) not suitable for color |blinds |blinds OS|Windows (All) |All Status|UNCONFIRMED |NEW CC||ilmari.lauhakangas@libreoff ||ice.org Ever confirmed|0 |1 --- Comment #1 from Buovjaga --- Good point -> NEW -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152947] Icon (Document saved / not jet) not suitable for color blinds
https://bugs.documentfoundation.org/show_bug.cgi?id=152947 Harald Freunbichler changed: What|Removed |Added Severity|normal |minor -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152947] Icon (Document saved / not jet) not suitable for color blinds
https://bugs.documentfoundation.org/show_bug.cgi?id=152947 Harald Freunbichler changed: What|Removed |Added Summary|Icon (saved / not jet) not |Icon (Document saved / not |suitable for color blinds |jet) not suitable for color ||blinds -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152947] Icon (saved / not jet) not suitable for color blinds
https://bugs.documentfoundation.org/show_bug.cgi?id=152947 Harald Freunbichler changed: What|Removed |Added Summary|Icon "saved / not jet) not |Icon (saved / not jet) not |suitable for color blinds |suitable for color blinds -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148829] open new install and immediately quitting leads to hanging document recovery screen
https://bugs.documentfoundation.org/show_bug.cgi?id=148829 ksdav...@gmail.com changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #7 from ksdav...@gmail.com --- (In reply to Buovjaga from comment #6) > Recently there were many fixes to hang issues. Could you try with a fresh > unstable build from > https://dev-builds.libreoffice.org/daily/master/current.html ? > https://support.apple.com/guide/mac-help/open-a-mac-app-from-an-unidentified- > developer-mh40616/mac > > Set to NEEDINFO. > Change back to UNCONFIRMED, if the problem persists. Change to RESOLVED > WORKSFORME, if the problem went away. I am sorry to report that this did not resolve the problem. The first file I opened crashed as follows: * I opened the file * It had what appeared as corrupted images in it. * I turned show images on and off * I then went to some other programs. * When I returned I got the "Libreofficedev will attempt recover" screen. I reopened the file. then tried to open another file from file explorer and got the same recovery screen (for both files). Closed and reopened app. I opened the file one more time. Tried to close it, and it crashed with the "due to an error, LibreOffice crashed. the followign files will be recovered, except no files were listed. In addition, I got the spinning wheel... got apple error report screen. will attach if requested. reopened. closed, and same, got the empty libreoffice crashed screen. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152947] New: Icon "saved / not jet) not suitable for color blinds
https://bugs.documentfoundation.org/show_bug.cgi?id=152947 Bug ID: 152947 Summary: Icon "saved / not jet) not suitable for color blinds Product: LibreOffice Version: 7.3.2.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: harald.freunbich...@sbg.at Description: In the left bottom corner the diskette icon has RED as signal for NOT SAVED. Color Blinds (not me) are not able to see the difference! Please use a icon changing to crossed out. (example) Actual Results: no action required Expected Results: no action required Reproducible: Always User Profile Reset: No Additional Info: no action required for this. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152942] All help links in dialog windows do not work
https://bugs.documentfoundation.org/show_bug.cgi?id=152942 V Stuart Foote changed: What|Removed |Added CC||vsfo...@libreoffice.org --- Comment #3 from V Stuart Foote --- The 404 not found error is also manifesting with the helppack for local Help installed. LibreOffice_7.5.0.1_Win_x86-64_helppack_en-US.msi Version: 7.5.0.1 (X86_64) / LibreOffice Community Build ID: 77cd3d7ad4445740a0c6cf977992dafd8ebad8df CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152845] no visible AutoText preview in high contrast mode (Windows)
https://bugs.documentfoundation.org/show_bug.cgi?id=152845 Caolán McNamara changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | Status|NEW |ASSIGNED --- Comment #3 from Caolán McNamara --- Yeah, I'm looking into it. Basically the font is always black unless there is a "Window" attached to the document and there isn't in this case, which requires a bit of restructuring to get this working without accidentally making printing/pdf export use the on-screen font color which we don't want to happen. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152942] All help links in dialog windows do not work
https://bugs.documentfoundation.org/show_bug.cgi?id=152942 --- Comment #2 from Stéphane Guillou (stragu) --- (Well, I'm saying "regression" but it might just be the online ressource that's not available currently...) There has been documentation build issues for 7.5 lately, we'll wait for a new build after this is merged and see: https://gerrit.libreoffice.org/c/core/+/145132 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103459] [META] Sidebar UI and UX bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103459 V Stuart Foote changed: What|Removed |Added Depends on||152921 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=152921 [Bug 152921] Sidebar deck is shown as "selected active" when closing with grey cross -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152921] Sidebar deck is shown as "selected active" when closing with grey cross
https://bugs.documentfoundation.org/show_bug.cgi?id=152921 V Stuart Foote changed: What|Removed |Added CC||qui...@gmail.com, ||rayk...@gmail.com, ||vsfo...@libreoffice.org Ever confirmed|0 |1 Blocks||103459 Status|UNCONFIRMED |NEW Summary|Sidebar deck is shown as|Sidebar deck is shown as |open when closing with grey |"selected active" when |cross |closing with grey cross --- Comment #1 from V Stuart Foote --- Confirmed Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: b9e3e20bfd102880d12384892eaeca094c38a519 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded The "selected" state for the tabbar button does not track with the deck opened or closed state. Using the "cross" button on the SB deck to collapse/close the deck should not affect the selection on the SB tabbar--and otherwise should not show a deck without a SB tabbar tab showing selected. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103459 [Bug 103459] [META] Sidebar UI and UX bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152537] No obvious UI to set the document default font used e.g. in Line Numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=152537 --- Comment #15 from Mike Kaganski --- (In reply to Heiko Tietze from comment #14) > To recap STR: > 1. Tools > Options > Writer > Basic Fonts: Default = something ridiculous > 2. Some text, line number on => line numbers follow the paragraph default > 3. Change Default Paragraph Style back to Liberation Sans, or the like => > line numbering follows (I read the discussion as if it doesn't) > > What am I doing differently? No idea, because you chose not to explain how you performed #3. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 152537] No obvious UI to set the document default font used e.g. in Line Numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=152537 --- Comment #15 from Mike Kaganski --- (In reply to Heiko Tietze from comment #14) > To recap STR: > 1. Tools > Options > Writer > Basic Fonts: Default = something ridiculous > 2. Some text, line number on => line numbers follow the paragraph default > 3. Change Default Paragraph Style back to Liberation Sans, or the like => > line numbering follows (I read the discussion as if it doesn't) > > What am I doing differently? No idea, because you chose not to explain how you performed #3. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 152919] LO Writer: user input fields not updating automatically
https://bugs.documentfoundation.org/show_bug.cgi?id=152919 m.a.riosv changed: What|Removed |Added Ever confirmed|0 |1 Keywords||regression Status|UNCONFIRMED |NEW --- Comment #9 from m.a.riosv --- Ok I see, I was doing double-click to open the box to edit. Reproducible. Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 12e8d57e791bb1befc0716d4d02af7d1d1ccb4ae CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Jumbo -- You are receiving this mail because: You are the assignee for the bug.
Re: Files hid2file.js and /bookmark.js not delivered in 'libreoffice-7-5' branch
On 9/1/23 12:37, Christian Lohmaier wrote: On Sat, Dec 31, 2022 at 11:00 AM Olivier Hallot wrote: Note: no build issue with master branch 7-5 is missing the change that made xargs an optional argument to the wrapper call https://gerrit.libreoffice.org/c/core/+/145132 should fix it. ciao Christian Could this be related to why many dialog help links lead to a 404 currently for 7.5, or am I way off? Couple of reports on Bugzilla: https://bugs.documentfoundation.org/show_bug.cgi?id=152733 https://bugs.documentfoundation.org/show_bug.cgi?id=152942 Cheers -- Stéphane Guillou Quality Assurance Analyst | The Document Foundation Email: stephane.guil...@libreoffice.org Mobile (France): +33 7 79 67 18 72 Matrix: @stragu:matrix.org Fediverse: @str...@mastodon.indie.host Web: https://stragu.gitlab.io/
[Libreoffice-bugs] [Bug 152943] GetErrCode() doesn't work as expected on RISC-V due to invalid floating-point operation in KahanSum
https://bugs.documentfoundation.org/show_bug.cgi?id=152943 --- Comment #2 from Mike Kaganski --- https://groups.google.com/a/groups.riscv.org/g/isa-dev/c/g79dHlV4B_k?pli=1 meaning that the "optional support" means that a given CPU may or may not implement such propagation. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104719] Include archive with help images with helppacks on all platforms
https://bugs.documentfoundation.org/show_bug.cgi?id=104719 Buovjaga changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #4 from Buovjaga --- This seems irrelevant after the move to HTML help -- You are receiving this mail because: You are the assignee for the bug.
