[Libreoffice-bugs] [Bug 153166] Ods saved from xls has issue with images in cells

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153166

--- Comment #5 from MB  ---
Thank you all for giving feedback on this so fast!
I'll try with the 7.x versions

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 153171] suggestion: add option to add x number of rows/columns in the menu

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153171

Heiko Tietze  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #3 from Heiko Tietze  ---
I don't buy the use case to insert exactly 125 rows. What scenario requires
this and why should we bother not only development but also users with another
function? Question to OP/Maximums...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 153171] suggestion: add option to add x number of rows/columns in the menu

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153171

Heiko Tietze  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #3 from Heiko Tietze  ---
I don't buy the use case to insert exactly 125 rows. What scenario requires
this and why should we bother not only development but also users with another
function? Question to OP/Maximums...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153180] FILESAVE: ODP: graphic is completely white after RT

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153180

Sarper Akdemir  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |sarper.akde...@collabora.co
   |desktop.org |m
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152841] FILEOPEN RTF/DOCX Paragraph height is defined by hidden characters even in Print mode

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152841

--- Comment #3 from Gabor Kelemen (allotropia)  ---
Created attachment 184900
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184900=edit
Formatting marks hidden - table moves closer to border only in Word

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152841] FILEOPEN RTF/DOCX Paragraph height is defined by hidden characters even in Print mode

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152841

--- Comment #2 from Gabor Kelemen (allotropia)  ---
Created attachment 184899
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184899=edit
Formatting marks visible

Sorry, forgot the screenshots here.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112765] [META] RTF (text) table bugs and enhancements

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112765
Bug 112765 depends on bug 123008, which changed state.

Bug 123008 Summary: text in table wasn't aligned when opening a RTF file
https://bugs.documentfoundation.org/show_bug.cgi?id=123008

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 123008] text in table wasn't aligned when opening a RTF file

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123008

Dieter  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #5 from Dieter  ---
Alignment is OK in

Version: 7.5.0.2 (X86_64) / LibreOffice Community
Build ID: c0dd1bc3f1a385d110b88e26ece634da94921f58
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL threaded

but wrong distibution of table cells in one row (but that might be a different
bug)

=> RESOLVED WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103494] [META] Textbox bugs and enhancements

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103494
Bug 103494 depends on bug 153161, which changed state.

Bug 153161 Summary: FILESAVE: Data cannot save successfully if I open an old 
presentation, add some text in it, save it and close it.
https://bugs.documentfoundation.org/show_bug.cgi?id=153161

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sd/qa xmloff/source

2023-01-24 Thread Mike Kaganski (via logerrit)
 sd/qa/uitest/data/tdf153161_FlushToSave.odp |binary
 sd/qa/uitest/impress_tests2/tdf153161.py|   37 
 xmloff/source/draw/shapeexport.cxx  |   12 +
 3 files changed, 49 insertions(+)

New commits:
commit d183daea1abbd7b564d083298874dd7c40d5a5b3
Author: Mike Kaganski 
AuthorDate: Wed Jan 25 01:37:00 2023 +0300
Commit: Mike Kaganski 
CommitDate: Wed Jan 25 07:25:16 2023 +

tdf#153161: (Ab)use a call to XTextRange::getString to flush edits

Restore the call (without checking its returned value), removed in commit
d194474aabd699806cb3631bc8641dd0548b8026 ("tdf#151100: xText->getString()
may be empty for content needing export", 2022-09-22), side effects of
which obviously allow some object's changes to get flushed and saved.

Change-Id: I62f27cd056c32ad76f79a4862e2f4a0964eaadef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146106
Tested-by: Mike Kaganski 
Reviewed-by: Mike Kaganski 

diff --git a/sd/qa/uitest/data/tdf153161_FlushToSave.odp 
b/sd/qa/uitest/data/tdf153161_FlushToSave.odp
new file mode 100644
index ..1fd5c20c2a52
Binary files /dev/null and b/sd/qa/uitest/data/tdf153161_FlushToSave.odp differ
diff --git a/sd/qa/uitest/impress_tests2/tdf153161.py 
b/sd/qa/uitest/impress_tests2/tdf153161.py
new file mode 100644
index ..db14d7986f5b
--- /dev/null
+++ b/sd/qa/uitest/impress_tests2/tdf153161.py
@@ -0,0 +1,37 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+from libreoffice.uno.propertyvalue import mkPropertyValues
+from uitest.framework import UITestCase
+from uitest.uihelper.common import get_url_for_data_file
+
+class TestTdf153161(UITestCase):
+
+def testTdf153161(self):
+url = get_url_for_data_file('tdf153161_FlushToSave.odp')
+
+with self.ui_test.load_file(url) as document:
+oldText = document.DrawPages[0].getByIndex(1).String
+self.assertTrue(oldText.startswith('在没有版本控制系统的时期'))
+
+xImpressDoc = self.xUITest.getTopFocusWindow()
+xEditWin = xImpressDoc.getChild('impress_win')
+xEditWin.executeAction('SELECT', 
mkPropertyValues({'OBJECT':'Unnamed Drawinglayer object 1'}))
+
+# Type something, getting into text editing mode (appending) 
automatically
+xEditWin.executeAction('TYPE', mkPropertyValues({'TEXT': 'Foo 
Bar'}))
+xToolkit = 
self.xContext.ServiceManager.createInstance('com.sun.star.awt.Toolkit')
+xToolkit.processEventsToIdle()
+self.xUITest.executeCommand('.uno:Save')
+
+# Reload and check that the edit was saved
+with self.ui_test.load_file(url) as document:
+self.assertEqual(oldText + 'Foo Bar', 
document.DrawPages[0].getByIndex(1).String)
+
+# vim: set shiftwidth=4 softtabstop=4 expandtab:
diff --git a/xmloff/source/draw/shapeexport.cxx 
b/xmloff/source/draw/shapeexport.cxx
index 39d9eabb5971..3e0786e6ea77 100644
--- a/xmloff/source/draw/shapeexport.cxx
+++ b/xmloff/source/draw/shapeexport.cxx
@@ -310,6 +310,18 @@ void XMLShapeExport::collectShapeAutoStyles(const 
uno::Reference< drawing::XShap
 uno::Reference< text::XText > xText(xShape, uno::UNO_QUERY);
 if (xText.is())
 {
+try
+{
+// tdf#153161: it seems that the call to XTextRange::getString 
flushes the changes
+// for some objects, that otherwise fail to get exported 
correctly. Maybe at some
+// point it would make sense to find a better place for more 
targeted flush.
+xText->getString();
+}
+catch (uno::RuntimeException const&)
+{
+// E.g., SwXTextFrame that contains only a table will throw; 
this is not an error
+}
+
 uno::Reference< beans::XPropertySetInfo > xPropSetInfo( 
xPropSet->getPropertySetInfo() );
 
 if( xPropSetInfo.is() && 
xPropSetInfo->hasPropertyByName("IsEmptyPresentationObject") )


[Libreoffice-bugs] [Bug 153187] It would be great, in Writer, if the Character and Paragraph dialogs had an Apply button

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153187

--- Comment #1 from Heiko Tietze  ---
The style modification dialog that opens from the Stylist at the sidebar does
have apply/reset functions. If you change the paragraph style directly (right
click in the document) it is still direct formatting and affects only this
particular paragraph. My take: WF.

See also bug 130264 and bug 130261.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152957] FILEOPEN DOCX/RTF Text field default placeholder should be more like in Word

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152957

Dieter  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de
 Ever confirmed|0   |1
 Whiteboard| QA:needsComment|
 Status|UNCONFIRMED |NEW

--- Comment #1 from Dieter  ---
Placeholders always invisible (with and without formatting marks active)

Version: 7.5.0.2 (X86_64) / LibreOffice Community
Build ID: c0dd1bc3f1a385d110b88e26ece634da94921f58
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL threaded

Don't understand, why this is an enhancement request and not a bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143138] Pasting unformatted text should advance table cells

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143138

--- Comment #9 from Josh Triplett  ---
I've run into this as well, quite regularly.

I have a Writer document that I use as a template, copying and filling it out
regularly, with a table in it. I generate data for different columns of that
table via the command-line, putting it in the clipboard.

What I'd *like* to do is paste directly into that table and have the data
spread across rows.

What I end up doing instead is opening Libreoffice Calc, pasting there which
*does* default to automatically splitting across rows, then copying the
resulting rows and pasting into Writer, which spreads across rows there.

That's a cumbersome workflow, and I'd love to *just* use Writer for this.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150280] After pasting image 3x, save, close and reopen, middle Image not appearing

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150280

Dieter  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||2970

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 118920] [META] Additional blank pages

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118920

Dieter  changed:

   What|Removed |Added

 Depends on||152970


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=152970
[Bug 152970] Empty page (without paragraph mark) is added at beginning of
document
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152970] Empty page (without paragraph mark) is added at beginning of document

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152970

Dieter  changed:

   What|Removed |Added

Summary|Difference layout when  |Empty page (without
   |editing & saving &  |paragraph mark) is added at
   |reopening   |beginning of document
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||0280
 Status|UNCONFIRMED |NEW
 Blocks||118920
 Whiteboard| QA:needsComment|
 Ever confirmed|0   |1
 CC||dgp-m...@gmx.de

--- Comment #3 from Dieter  ---
I confirm it with

Version: 7.5.0.2 (X86_64) / LibreOffice Community
Build ID: c0dd1bc3f1a385d110b88e26ece634da94921f58
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL threaded

But what happens is, that an extra page is added at beginning of the document

Steps:
1. Open attachment 184567
2. On page 1 add text frame, shape or something similar above text area (this
makes bug more obvious)
3. Delete empty paragraph on first page

Actual result
Image jumps one page above (expected), but empty page without any paragraph
mark is inserted as a new first page.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=118920
[Bug 118920] [META] Additional blank pages
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: accessibility/inc accessibility/source include/toolkit toolkit/source

2023-01-24 Thread Stephan Bergmann (via logerrit)
 accessibility/inc/standard/vclxaccessibletabcontrol.hxx|1 
 accessibility/inc/standard/vclxaccessibletoolbox.hxx   |1 
 accessibility/source/extended/accessibleiconchoicectrl.cxx |2 -
 include/toolkit/awt/vclxaccessiblecomponent.hxx|   14 ++---
 toolkit/source/awt/vclxaccessiblecomponent.cxx |   10 -
 5 files changed, 6 insertions(+), 22 deletions(-)

New commits:
commit 5c312c986eac570af1c8c3210bdcbde213aae6dc
Author: Stephan Bergmann 
AuthorDate: Mon Jan 23 16:31:25 2023 +0100
Commit: Stephan Bergmann 
CommitDate: Wed Jan 25 06:44:18 2023 +

Use ImplInheritanceHelper in VCLXAccessibleComponent

Change-Id: I300f033054bddc2c0ee1973dbafc108c477bf09a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146103
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/accessibility/inc/standard/vclxaccessibletabcontrol.hxx 
b/accessibility/inc/standard/vclxaccessibletabcontrol.hxx
index 233e7277cb27..9827f9ba6b67 100644
--- a/accessibility/inc/standard/vclxaccessibletabcontrol.hxx
+++ b/accessibility/inc/standard/vclxaccessibletabcontrol.hxx
@@ -21,6 +21,7 @@
 
 #include 
 #include 
+#include 
 #include 
 #include 
 
diff --git a/accessibility/inc/standard/vclxaccessibletoolbox.hxx 
b/accessibility/inc/standard/vclxaccessibletoolbox.hxx
index 0b2908d1dc32..352c3c07edfa 100644
--- a/accessibility/inc/standard/vclxaccessibletoolbox.hxx
+++ b/accessibility/inc/standard/vclxaccessibletoolbox.hxx
@@ -22,6 +22,7 @@
 #include 
 #include 
 #include 
+#include 
 
 
 
diff --git a/accessibility/source/extended/accessibleiconchoicectrl.cxx 
b/accessibility/source/extended/accessibleiconchoicectrl.cxx
index f9f3599bb4b4..18835b50b95d 100644
--- a/accessibility/source/extended/accessibleiconchoicectrl.cxx
+++ b/accessibility/source/extended/accessibleiconchoicectrl.cxx
@@ -168,7 +168,7 @@ namespace accessibility
 throw RuntimeException("getAccessibleChild: Entry "
+ OUString::number(i) + " not found",
 static_cast(
-static_cast(this)));
+static_cast(this)));
 
 return new AccessibleIconChoiceCtrlEntry( *pCtrl, i, this );
 }
diff --git a/include/toolkit/awt/vclxaccessiblecomponent.hxx 
b/include/toolkit/awt/vclxaccessiblecomponent.hxx
index 24003d5500f5..d3aaa30f5646 100644
--- a/include/toolkit/awt/vclxaccessiblecomponent.hxx
+++ b/include/toolkit/awt/vclxaccessiblecomponent.hxx
@@ -22,7 +22,7 @@
 
 #include 
 #include 
-#include 
+#include 
 #include 
 
 
@@ -41,12 +41,9 @@ class AccessibleRelationSetHelper;
 
 
 
-typedef ::cppu::ImplHelper1<
-css::lang::XServiceInfo > VCLXAccessibleComponent_BASE;
-
 class TOOLKIT_DLLPUBLIC SAL_LOPLUGIN_ANNOTATE("crosscast") 
VCLXAccessibleComponent
-:public comphelper::OAccessibleExtendedComponentHelper
-,public VCLXAccessibleComponent_BASE
+:public cppu::ImplInheritanceHelper<
+ comphelper::OAccessibleExtendedComponentHelper, 
css::lang::XServiceInfo>
 {
 private:
 rtl::Reference  m_xVCLXWindow;
@@ -77,11 +74,6 @@ public:
 
 virtual void SAL_CALL disposing() override;
 
-// css::uno::XInterface
-DECLARE_XINTERFACE()
-// css::lang::XTypeProvider
-DECLARE_XTYPEPROVIDER()
-
 // XServiceInfo
 virtual OUString SAL_CALL getImplementationName() override;
 virtual sal_Bool SAL_CALL supportsService( const OUString& rServiceName ) 
override;
diff --git a/toolkit/source/awt/vclxaccessiblecomponent.cxx 
b/toolkit/source/awt/vclxaccessiblecomponent.cxx
index 26dcde5e1b01..2c9565fec9a7 100644
--- a/toolkit/source/awt/vclxaccessiblecomponent.cxx
+++ b/toolkit/source/awt/vclxaccessiblecomponent.cxx
@@ -79,16 +79,6 @@ VCLXAccessibleComponent::~VCLXAccessibleComponent()
 DisconnectEvents();
 }
 
-IMPLEMENT_FORWARD_XINTERFACE2( VCLXAccessibleComponent, 
OAccessibleExtendedComponentHelper, VCLXAccessibleComponent_BASE )
-css::uno::Sequence< css::uno::Type > SAL_CALL 
VCLXAccessibleComponent::getTypes()
-{
-return ::comphelper::concatSequences(
-OAccessibleExtendedComponentHelper::getTypes(),
-VCLXAccessibleComponent_BASE::getTypes()
-);
-}
-IMPLEMENT_GET_IMPLEMENTATION_ID( VCLXAccessibleComponent )
-
 OUString VCLXAccessibleComponent::getImplementationName()
 {
 return "com.sun.star.comp.toolkit.AccessibleWindow";


[Libreoffice-commits] core.git: download.lst external/skia vcl/skia

2023-01-24 Thread Noel Grandin (via logerrit)
 download.lst |4 
 external/skia/Library_skia.mk|  109 ---
 external/skia/UnpackedTarball_skia.mk|5 
 external/skia/clang11-flax-vector-conversion.patch.0 |4 
 external/skia/constexpr-template.patch.0 |   34 +
 external/skia/fix-graphite-ifdef.patch.1 |   48 
 external/skia/fix-pch.patch.1|   30 -
 external/skia/fix-warnings.patch.1   |4 
 external/skia/inc/pch/precompiled_skia.hxx   |   44 ---
 external/skia/make-api-visible.patch.1   |   12 +-
 external/skia/missing-include.patch.0|   20 ---
 external/skia/share-grcontext.patch.1|   20 +--
 external/skia/tdf148624.patch.1  |   60 --
 vcl/skia/SkiaHelper.cxx  |2 
 vcl/skia/gdiimpl.cxx |1 
 15 files changed, 92 insertions(+), 305 deletions(-)

New commits:
commit aef70869b0fae3001648ec2a2651ffc9c507678f
Author: Noel Grandin 
AuthorDate: Tue Jan 24 13:24:05 2023 +0200
Commit: Noel Grandin 
CommitDate: Wed Jan 25 06:39:05 2023 +

Update skia to m110

Removing those bits of the patches that appear to have been
upstreamed.

Change-Id: Ia7683c26af4c622ca4fccb828df023ae30e724a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146069
Tested-by: Noel Grandin 
Reviewed-by: Noel Grandin 

diff --git a/download.lst b/download.lst
index 6d77206cfec3..6c1af18404b5 100644
--- a/download.lst
+++ b/download.lst
@@ -501,8 +501,8 @@ RHINO_TARBALL := 
798b2ffdc8bcfe7bca2cf92b62caf685-rhino1_5R5.zip
 # three static lines
 # so that git cherry-pick
 # will not run into conflicts
-SKIA_SHA256SUM := 
c094a6247e44104beaaa0d00c825beb6baf1a8e532dc22214747495317a65bd9
-SKIA_TARBALL := skia-m103-b301ff025004c9cd82816c86c547588e6c24b466.tar.xz
+SKIA_SHA256SUM := 
878112f9693be12292d5fad5e73367fa11c96909ae27d1d7d2e2cb5d01011ea7
+SKIA_TARBALL := skia-m110-aab9fb4100da797d25fe340e9a2fcb2ae30fc2e1.tar.xz
 # three static lines
 # so that git cherry-pick
 # will not run into conflicts
diff --git a/external/skia/Library_skia.mk b/external/skia/Library_skia.mk
index c0f91e1a463a..447a223592f1 100644
--- a/external/skia/Library_skia.mk
+++ b/external/skia/Library_skia.mk
@@ -112,7 +112,7 @@ $(eval $(call gb_Library_use_libraries,skia,\
 $(eval $(call gb_Library_set_include,skia,\
 $$(INCLUDE) \
 -I$(call gb_UnpackedTarball_get_dir,skia) \
--I$(call gb_UnpackedTarball_get_dir,skia)/include/third_party/skcms/ \
+-I$(call gb_UnpackedTarball_get_dir,skia)/modules/skcms/ \
 -I$(call 
gb_UnpackedTarball_get_dir,skia)/third_party/vulkanmemoryallocator/ \
 -I$(call gb_UnpackedTarball_get_dir,skia)/include/third_party/vulkan/ \
 -I$(SRCDIR)/external/skia/inc/ \
@@ -145,7 +145,6 @@ $(eval $(call 
gb_Library_add_generated_exception_objects,skia,\
 UnpackedTarball/skia/src/codec/SkPngCodec \
 UnpackedTarball/skia/src/codec/SkSampledCodec \
 UnpackedTarball/skia/src/codec/SkSampler \
-UnpackedTarball/skia/src/codec/SkStreamBuffer \
 UnpackedTarball/skia/src/codec/SkSwizzler \
 UnpackedTarball/skia/src/codec/SkWbmpCodec \
 UnpackedTarball/skia/src/core/SkAAClip \
@@ -168,7 +167,6 @@ $(eval $(call 
gb_Library_add_generated_exception_objects,skia,\
 UnpackedTarball/skia/src/core/SkBlitter_ARGB32 \
 UnpackedTarball/skia/src/core/SkBlitter_A8 \
 UnpackedTarball/skia/src/core/SkBlitter \
-UnpackedTarball/skia/src/core/SkBlitter_RGB565 \
 UnpackedTarball/skia/src/core/SkBlitter_Sprite \
 UnpackedTarball/skia/src/core/SkBlockAllocator \
 UnpackedTarball/skia/src/core/SkBlurMask \
@@ -177,6 +175,7 @@ $(eval $(call 
gb_Library_add_generated_exception_objects,skia,\
 UnpackedTarball/skia/src/core/SkCachedData \
 UnpackedTarball/skia/src/core/SkCanvas \
 UnpackedTarball/skia/src/core/SkCanvasPriv \
+UnpackedTarball/skia/src/core/SkCapabilities \
 UnpackedTarball/skia/src/core/SkChromeRemoteGlyphCache \
 UnpackedTarball/skia/src/core/SkClipStack \
 UnpackedTarball/skia/src/core/SkClipStackDevice \
@@ -186,6 +185,7 @@ $(eval $(call 
gb_Library_add_generated_exception_objects,skia,\
 UnpackedTarball/skia/src/core/SkColorSpace \
 UnpackedTarball/skia/src/core/SkColorSpaceXformSteps \
 UnpackedTarball/skia/src/core/SkCompressedDataUtils \
+UnpackedTarball/skia/src/core/SkContainers \
 UnpackedTarball/skia/src/core/SkContourMeasure \
 UnpackedTarball/skia/src/core/SkConvertPixels \
 UnpackedTarball/skia/src/core/SkCpu \
@@ -224,7 +224,6 @@ $(eval $(call 
gb_Library_add_generated_exception_objects,skia,\
 UnpackedTarball/skia/src/core/SkGlobalInitialization_core \
 UnpackedTarball/skia/src/core/SkGlyph \
 UnpackedTarball/skia/src/core/SkGlyphBuffer \
-

[Libreoffice-commits] core.git: svtools/source

2023-01-24 Thread Andrea Gelmini (via logerrit)
 svtools/source/config/colorcfg.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 81ced283de2d0da377225afeb589b793716238bd
Author: Andrea Gelmini 
AuthorDate: Tue Jan 24 21:10:29 2023 +0100
Commit: Julien Nabet 
CommitDate: Wed Jan 25 06:08:34 2023 +

Fix typo

Change-Id: I4f60a62492b8e0b92c805dd5f4db43193a5d2288
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146104
Tested-by: Julien Nabet 
Reviewed-by: Julien Nabet 

diff --git a/svtools/source/config/colorcfg.cxx 
b/svtools/source/config/colorcfg.cxx
index 2d584d9c5d95..452104361729 100644
--- a/svtools/source/config/colorcfg.cxx
+++ b/svtools/source/config/colorcfg.cxx
@@ -403,7 +403,7 @@ Color ColorConfig::GetDefaultColor(ColorConfigEntry eEntry)
 COL_BLACK, // CALCTEXT
 COL_LIGHTGRAY, // CALCPROTECTEDBACKGROUND
 COL_GRAY7, // DRAWGRID
-COL_WHITE, // BASICIEDITOR,
+COL_WHITE, // BASICEDITOR,
 COL_GREEN, // BASICIDENTIFIER,
 COL_GRAY, // BASICCOMMENT,
 COL_LIGHTRED, // BASICNUMBER,


[Libreoffice-bugs] [Bug 153199] New: writer and impress freeze after closing other program adobe illustrator

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153199

Bug ID: 153199
   Summary: writer and impress freeze after closing other program
adobe illustrator
   Product: LibreOffice
   Version: 7.4.4.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: fadil.fikril...@gmail.com

Description:
both writer and impress freeze in the same time after closing other program
adobe illustrator. it come back if only the files i'm working are empty. but
the larger the files, longer it takes, freezing indefinitely on project i often
work with.

Steps to Reproduce:
1. open writer
2. open impress
3. open adobe illustrator
4. close adobe illustrator
5. both writer and impress freeze

Actual Results:
both writer and impress freeze

Expected Results:
both writer and impress work uninterrupted 


Reproducible: Always


User Profile Reset: No

Additional Info:
windows 11, already tried both libreoffice fresh and still, adobe illustrator
cc2015

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153198] New: 6.4 libreoffice word issues

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153198

Bug ID: 153198
   Summary: 6.4 libreoffice word issues
   Product: LibreOffice
   Version: 6.4.1.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: danaria...@gmail.com

Description:
When I right click to bring up page style, I then open the options to switch
from default to landscape I confirm accept and ok. The software doesn't do
anything it remains in default. Mildly frustrated for a very it illiterate
person with only a basic understanding of computers.

Steps to Reproduce:
1. Open new document in libre 6.4
2. Without writing anything right click the page to navigate to the page style
option
3. on first page with out selecting any other options tab change from default
to landscape.
4. see nothing happened and that it happens every time you repeat the process. 

Actual Results:
you have options but then nothing happens

Expected Results:
the empty page to visually switch from portrait to landscape


Reproducible: Always


User Profile Reset: Yes

Additional Info:
should have gone to landscape?

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Upgrading mdds and orcus coming soon

2023-01-24 Thread Kohei Yoshida

On 17.01.2023 16:55, Kohei Yoshida wrote:

Hi there,

I'll be working on upgrading the mdds and orcus libraries to versions
2.1.0 and 0.18.0 respectively.  Not sure how long the process will
take, but hopefully it will be finished with a week.


Turns out one week was a bit too optimistic.  It will take a little 
while longer.


Kohei


[Libreoffice-bugs] [Bug 91180] Cannot find Philippine Peso in Special Characters

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=91180

--- Comment #24 from Bamm  ---
> It should be possible to identify, if someone is bothered enough to bibisect
> it (https://wiki.documentfoundation.org/QA/Bibisect).

I get it now. Thanks for the explanation. I'm fine now with WORKSFORME.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152493] FILESAVE WebDAV upload fails with Calc spreadsheet in 7.4

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152493

QA Administrators  changed:

   What|Removed |Added

   Keywords||bibisectRequest

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152970] Difference layout when editing & saving & reopening

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152970

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152897] Left arrow key press in a multiple selection Treeview should clear tree entry selections before selecting parent (Gtk3 is correct)

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152897

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152957] FILEOPEN DOCX/RTF Text field default placeholder should be more like in Word

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152957

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152954] Default Printer not recognised

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152954

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149746] Crash in: SfxApplication::GetAppDispatcher_Impl()

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149746

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149746] Crash in: SfxApplication::GetAppDispatcher_Impl()

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149746

--- Comment #4 from QA Administrators  ---
Dear Ainhoa,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149720] Crash in: SwLayoutFrame::IsAnLower(SwFrame const *)

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149720

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149720] Crash in: SwLayoutFrame::IsAnLower(SwFrame const *)

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149720

--- Comment #3 from QA Administrators  ---
Dear Ainhoa,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149504] incorrect import/insertion of datetime value into Calc using ctrl-shift-alt-v (Date (YMD) format is selected)

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149504

--- Comment #6 from QA Administrators  ---
Dear kabilo,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149982] If Basic Fonts (Western) = Noto Serif then "Condensed" is forced

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149982

--- Comment #2 from QA Administrators  ---
Dear David Snow,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 70961] Other: Send document as e-mail doesn't work with webmail

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=70961

--- Comment #5 from QA Administrators  ---
Dear Geoffrey,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 122104] FILEOPEN XLSX, Conditional formatting with a gradient background changes to a single color background in LO

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122104

--- Comment #6 from QA Administrators  ---
Dear NISZ LibreOffice Team,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145803] LibreOffice from 7.2 only opens in Safe Mode, UI render default no Skia on Windows 10 and 11

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145803

--- Comment #20 from QA Administrators  ---
Dear nightwriter99.9,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139181] Empty frame names in navigator for DOCX

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139181

--- Comment #5 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150591] Calc Segmentation Fault Segfault Crash Coredump Upon Close After Changes

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150591

--- Comment #6 from Doug Doubt  ---
Cannot reproduce on version: LibreOffice 7.4.4.2 40(Build:2)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153197] FILEOPEN RTF Paragraph style tabulator deleted by DF is not removed

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153197

--- Comment #1 from Gabor Kelemen (allotropia)  ---
Created attachment 184898
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184898=edit
The example file in Word 2016 and Writer

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153197] New: FILEOPEN RTF Paragraph style tabulator deleted by DF is not removed

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153197

Bug ID: 153197
   Summary: FILEOPEN RTF Paragraph style tabulator deleted by DF
is not removed
   Product: LibreOffice
   Version: 3.5.0 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kelem...@ubuntu.com
Blocks: 113340

Created attachment 184897
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184897=edit
Example file from Word

Attached example RTF file has tabulators set in the paragraph style at 8 and 16
cm.
In the paragraphs of the document these are removed by direct formatting.
In Writer the tabulators are still visible, changing document layout a bit.

1. Open attached document

Observe the right side of the paragraphs is aligned to the tabulator at 8 cm,
instead of just the default tab distance.

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: f1830bff71847a9c17715cff52383956719847fe
CPU threads: 14; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: de-DE (hu_HU); UI: en-US
Calc: threaded

and all the way back to 3.5


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113340
[Bug 113340] [META] RTF (text) paragraph-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 113340] [META] RTF (text) paragraph-related issues

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113340

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Depends on||153197


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=153197
[Bug 153197] FILEOPEN RTF Paragraph style tabulator deleted by DF is not
removed
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153196] FILEOPEN RTF/DOCX Extra footer appears when section break is in the middle of page

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153196

--- Comment #2 from Gabor Kelemen (allotropia)  ---
Created attachment 184896
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184896=edit
The example file saved as docx in Word 2016

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153196] FILEOPEN RTF/DOCX Extra footer appears when section break is in the middle of page

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153196

--- Comment #1 from Gabor Kelemen (allotropia)  ---
Created attachment 184895
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184895=edit
The example file in Word 2016 and Writer

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153196] New: FILEOPEN RTF/DOCX Extra footer appears when section break is in the middle of page

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153196

Bug ID: 153196
   Summary: FILEOPEN RTF/DOCX Extra footer appears when section
break is in the middle of page
   Product: LibreOffice
   Version: 4.4.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: bibisected, regression
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kelem...@ubuntu.com
Blocks: 113423

Created attachment 184894
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184894=edit
Example file from Word

Attached example RTF file has a Next Page type section break at the middle of
the second page.
Word shows the footer of the section at the bottom of the first page, but not
at the second. It shows a different footer at the bottom of the third page,
which is a new section.
Writer shows the first sections footer at the bottom of the second page too.
The same happens if the example file is saved as DOCX in Word.

1. Open attached file

Observe the "Hello world" footer is visible at the bottom of the second page,
but there should not be any footer.

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: f1830bff71847a9c17715cff52383956719847fe
CPU threads: 14; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: de-DE (hu_HU); UI: en-US
Calc: threaded

This was good until 4.3, got broken in 4.4 in range:

https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=fad62d928a4b4cd3aa96e16d7ab8f8db0331b8c0..a107bdfdfc1baf73f14055262d64bf616fc0a889

of which, this looks relevant:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=b32881b6723072c8d1a652ea147d12e75766d504

fix reading even/odd page breaks from .docx (bnc#519228)


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113423
[Bug 113423] [META] RTF (text) header and footer-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 113423] [META] RTF (text) header and footer-related issues

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113423

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Depends on||153196


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=153196
[Bug 153196] FILEOPEN RTF/DOCX Extra footer appears when section break is in
the middle of page
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153195] FILEOPEN RTF Table with negative indent in footer moved to the right

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153195

--- Comment #1 from Gabor Kelemen (allotropia)  ---
Created attachment 184893
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184893=edit
Table settings in Word and Writer

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153195] New: FILEOPEN RTF Table with negative indent in footer moved to the right

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153195

Bug ID: 153195
   Summary: FILEOPEN RTF Table with negative indent in footer
moved to the right
   Product: LibreOffice
   Version: 4.0.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kelem...@ubuntu.com
Blocks: 112765

Created attachment 184892
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184892=edit
Example document from Word 2016

Attached RTF example file has two tables with negative indent, so they start in
the left margin.
When opened in Writer the table in the footer has its indent set to 0, moving
it to the right.

1. Open attached file

Notice the horizontal position of the table in the footer.

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: f1830bff71847a9c17715cff52383956719847fe
CPU threads: 14; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: de-DE (hu_HU); UI: en-US
Calc: threaded

and all the way back to 4.0


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=112765
[Bug 112765] [META] RTF (text) table bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112765] [META] RTF (text) table bugs and enhancements

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112765

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Depends on||153195


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=153195
[Bug 153195] FILEOPEN RTF Table with negative indent in footer moved to the
right
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153194] FILEOPEN RTF Empty paragraph after page break moves to previous page

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153194

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |kelem...@ubuntu.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153194] FILEOPEN RTF Empty paragraph after page break moves to previous page

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153194

--- Comment #1 from Gabor Kelemen (allotropia)  ---
Created attachment 184891
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184891=edit
Screenshot of the other example in Word 2016 and Writer

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153194] New: FILEOPEN RTF Empty paragraph after page break moves to previous page

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153194

Bug ID: 153194
   Summary: FILEOPEN RTF Empty paragraph after page break moves to
previous page
   Product: LibreOffice
   Version: 7.4.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: bibisected, bisected, regression
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kelem...@ubuntu.com
Blocks: 113340

Created attachment 184890
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184890=edit
Example file from Word 2016

Attached RTF example file has a page break followed by an empty paragraph.
When opened in Writer the empty paragraph is moved to the previous page,
changing the layout of the second page.

1. Open attached file

Notice the "4. BBB..." paragraph is directly at the top of the second page,
instead of quite some distance below it.

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: f1830bff71847a9c17715cff52383956719847fe
CPU threads: 14; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: de-DE (hu_HU); UI: en-US
Calc: threaded

This was good in 7.4.0, broke only recently:

https://git.libreoffice.org/core/+/3c610336a58f644525d5e4d2566c35eee6f7a618

author  Miklos Vajna Thu Sep 08 20:14:27 2022 +0200
committer   Miklos Vajna Fri Sep 09 08:18:28
2022 +0200

tdf#148214 RTF import: avoid fake paragraph for \page when possible


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113340
[Bug 113340] [META] RTF (text) paragraph-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 113340] [META] RTF (text) paragraph-related issues

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113340

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Depends on||153194


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=153194
[Bug 153194] FILEOPEN RTF Empty paragraph after page break moves to previous
page
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153013] Rendering regression in Writer 7.5rc1: Text/font is rendered sometimes blury, sometimes sharp

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153013

Gerry  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #3 from Gerry  ---
This bug seems to be resolved in LO 7.5.rc2. --> WORKSFORME

Version: 7.5.0.2 (X86_64) / LibreOffice Community
Build ID: c0dd1bc3f1a385d110b88e26ece634da94921f58
CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153193] FILEOPEN RTF Table layout falls apart after showing/hiding formatting marks

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153193

--- Comment #3 from Gabor Kelemen (allotropia)  ---
Created attachment 184889
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184889=edit
The example file in docx format, this one works in Writer

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153193] FILEOPEN RTF Table layout falls apart after showing/hiding formatting marks

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153193

--- Comment #2 from Gabor Kelemen (allotropia)  ---
Created attachment 184888
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184888=edit
The example file in Writer after showing/hiding formatting marks

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153193] FILEOPEN RTF Table layout falls apart after showing/hiding formatting marks

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153193

--- Comment #1 from Gabor Kelemen (allotropia)  ---
Created attachment 184887
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184887=edit
The example file in Word 2016 and Writer after opening

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 81234] [META] RTF filter issues

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=81234

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Depends on||153193


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=153193
[Bug 153193] FILEOPEN RTF Table layout falls apart after showing/hiding
formatting marks
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153193] New: FILEOPEN RTF Table layout falls apart after showing/hiding formatting marks

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153193

Bug ID: 153193
   Summary: FILEOPEN RTF Table layout falls apart after
showing/hiding formatting marks
   Product: LibreOffice
   Version: 7.4.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kelem...@ubuntu.com
Blocks: 81234

Created attachment 184886
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184886=edit
Example file from Word 2016

Attached RTF example file has two tables and a lot of hidden paragraphs.
In Word this is laid out on two pages, and in Writer at opening time as well.
Showing formatting marks and hiding them makes the second table being laid out
on two pages.

1. Open attached file in Writer. Make sure Options - Writer - Formatting Aids
-> Hidden characters box is checked.
2. Press the Toggle Formatting marks button on the Standard bar.

-> Second table is now displayed on two pages instead of one.

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: f1830bff71847a9c17715cff52383956719847fe
CPU threads: 14; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: de-DE (hu_HU); UI: en-US
Calc: threaded

Before 7.4 the hidden paragraphs were not collapsed, so the tables layout did
not change. But this likely just uncovers something underlying.
Also if the original is saved to DOCX, that survives the formatting marks
hiding in Writer.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=81234
[Bug 81234] [META] RTF filter issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153192] FILEOPEN RTF Read-only protection not imported

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153192

--- Comment #2 from Gabor Kelemen (allotropia)  ---
Created attachment 184885
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184885=edit
The example file in Writer

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153192] FILEOPEN RTF Read-only protection not imported

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153192

--- Comment #1 from Gabor Kelemen (allotropia)  ---
Created attachment 184884
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184884=edit
The example file in Word 2016

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153192] New: FILEOPEN RTF Read-only protection not imported

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153192

Bug ID: 153192
   Summary: FILEOPEN RTF Read-only protection not imported
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kelem...@ubuntu.com
Blocks: 81234

Created attachment 184883
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184883=edit
Example file from Word

Attached RTF file has the Read-only protection enabled in Word, and one can not
edit it until the protection is removed.
In Writer the file is writable.

1. Open attached file

You can instantly edit it, without going to Edit - Edit mode.
In Word you need to go to the Restrict Editing sidebar and press Stop
Protection (there is no password on this file).

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: f1830bff71847a9c17715cff52383956719847fe
CPU threads: 14; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: de-DE (hu_HU); UI: en-US
Calc: threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=81234
[Bug 81234] [META] RTF filter issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 81234] [META] RTF filter issues

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=81234

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Depends on||153192


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=153192
[Bug 153192] FILEOPEN RTF Read-only protection not imported
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153191] FILEOPEN RTF 'Auto' table cell padding opens as 0.19 cm

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153191

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

  Regression By||Michael Stahl

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153191] FILEOPEN RTF 'Auto' table cell padding opens as 0.19 cm

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153191

--- Comment #1 from Gabor Kelemen (allotropia)  ---
Created attachment 184882
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184882=edit
The example file in Word 2016 and Writer

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153191] New: FILEOPEN RTF 'Auto' table cell padding opens as 0.19 cm

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153191

Bug ID: 153191
   Summary: FILEOPEN RTF 'Auto' table cell padding opens as 0.19
cm
   Product: LibreOffice
   Version: 7.1.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: bibisected, bisected, regression
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kelem...@ubuntu.com
Blocks: 112765

Created attachment 184881
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184881=edit
Example file from Word 2016

Attached example file has a table with left and right cell margin set as 'Auto'
according to Word.
Visually this looks like 0 cm in Word but Writer opens it as 0.19 cm, changing
cell contents layout a bit.

1. Open attached file
2. Observe the text and the image have a bit of gap to the left cell borders,
unlike in Word.

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: f1830bff71847a9c17715cff52383956719847fe
CPU threads: 14; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: de-DE (hu_HU); UI: en-US
Calc: threaded

This was good in 7.0 and before, broke in 7.1 with

https://git.libreoffice.org/core/+/fc872146845e4d77ff404d0929f28abf2d3a1c51

author  Michael Stahl Wed Oct 21 17:53:07 2020 +0200
committer   Michael Stahl Thu Oct 22 09:38:19
2020 +0200

tdf#137085 writerfilter: RTF import: \trpaddfl and \trpaddl are row...


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=112765
[Bug 112765] [META] RTF (text) table bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112765] [META] RTF (text) table bugs and enhancements

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112765

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Depends on||153191


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=153191
[Bug 153191] FILEOPEN RTF 'Auto' table cell padding opens as 0.19 cm
-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Consider changing version numbering scheme

2023-01-24 Thread Thorsten Behrens
Hi y'all,

Italo Vignoli wrote:
> The so called marketing tribe at TDF has asked to change the
> numbering scheme to someting similar to Ubuntu several years ago,
> but the suggestion was completely ignored.
>
Not completely ignored, I'd say. There was the 2020/2025 MarCom plan
[1], plus the discussions around moving to a rolling release model,
that also IIRC included CalVer naming. One of the things many people
considered very important for that model though, was auto-updating
binaries. That part is still stuck, since it needs some decent amount
of engineering (both inside LibreOffice, as well as for infra).

But I don't see a reason not to decouple the two aspects, besides the
fact that the messaging is presumably easier when bundled.

[1] https://nextcloud.documentfoundation.org/s/Z6Y2YeDKHoRW3s8

Cheers,

-- Thorsten


signature.asc
Description: PGP signature


[Libreoffice-bugs] [Bug 151548] No access to FormField controls in StarBASIC/VBA

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151548

--- Comment #31 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e125e6623fa1c0f39d927bb37547ca6d1e299cb1

related tdf#151548 formfield navigation: loop to beginning/end

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/inc sw/qa sw/source

2023-01-24 Thread Justin Luth (via logerrit)
 sw/inc/IDocumentMarkAccess.hxx  |4 ++--
 sw/inc/crsrsh.hxx   |4 ++--
 sw/qa/extras/uiwriter/uiwriter4.cxx |2 +-
 sw/source/core/crsr/crbm.cxx|8 
 sw/source/core/doc/docbm.cxx|   27 ---
 sw/source/core/inc/MarkManager.hxx  |4 ++--
 sw/source/ui/vba/vbaformfield.cxx   |   10 ++
 sw/source/uibase/docvw/edtwin.cxx   |6 --
 sw/source/uibase/wrtsh/wrtsh1.cxx   |4 ++--
 9 files changed, 43 insertions(+), 26 deletions(-)

New commits:
commit e125e6623fa1c0f39d927bb37547ca6d1e299cb1
Author: Justin Luth 
AuthorDate: Mon Jan 23 11:18:44 2023 -0500
Commit: Justin Luth 
CommitDate: Tue Jan 24 22:22:11 2023 +

related tdf#151548 formfield navigation: loop to beginning/end

When reaching the end of the form using keyboard navigation,
the next tabstop should return the user to the beginning of
the form.

This patch adds that to the existing legacy formfield navigation.
I'll wait with a unit test until I have added
activeX/contentControls into the mix.

Change-Id: I24a15a60f5a0a2721f512cca50397efddcbf7e4b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146035
Tested-by: Jenkins
Reviewed-by: Justin Luth 

diff --git a/sw/inc/IDocumentMarkAccess.hxx b/sw/inc/IDocumentMarkAccess.hxx
index 391be58a077a..b1317993dfb7 100644
--- a/sw/inc/IDocumentMarkAccess.hxx
+++ b/sw/inc/IDocumentMarkAccess.hxx
@@ -328,8 +328,8 @@ class IDocumentMarkAccess
 /// get Fieldmark for CH_TXT_ATR_FIELDSTART/CH_TXT_ATR_FIELDEND at rPos
 virtual ::sw::mark::IFieldmark* getFieldmarkAt(const SwPosition& rPos) 
const =0;
 virtual ::sw::mark::IFieldmark* getFieldmarkFor(const SwPosition& pos) 
const =0;
-virtual ::sw::mark::IFieldmark* getFieldmarkBefore(const SwPosition& 
pos) const =0;
-virtual ::sw::mark::IFieldmark* getFieldmarkAfter(const SwPosition& 
pos) const =0;
+virtual sw::mark::IFieldmark* getFieldmarkBefore(const SwPosition& 
pos, bool bLoop) const =0;
+virtual sw::mark::IFieldmark* getFieldmarkAfter(const SwPosition& pos, 
bool bLoop) const =0;
 
 virtual ::sw::mark::IFieldmark* getDropDownFor(const SwPosition& pos) 
const=0;
 virtual std::vector<::sw::mark::IFieldmark*> 
getNoTextFieldmarksIn(const SwPaM ) const=0;
diff --git a/sw/inc/crsrsh.hxx b/sw/inc/crsrsh.hxx
index 2e9a9f0f1e62..31cad2cd6e71 100644
--- a/sw/inc/crsrsh.hxx
+++ b/sw/inc/crsrsh.hxx
@@ -579,8 +579,8 @@ public:
 
 bool IsFormProtected();
 ::sw::mark::IFieldmark* GetCurrentFieldmark();
-::sw::mark::IFieldmark* GetFieldmarkAfter();
-::sw::mark::IFieldmark* GetFieldmarkBefore();
+sw::mark::IFieldmark* GetFieldmarkAfter(bool bLoop);
+sw::mark::IFieldmark* GetFieldmarkBefore(bool bLoop);
 bool GotoFieldmark( const ::sw::mark::IFieldmark* const pMark );
 
 // update Cursr, i.e. reset it into content should only be called when the
diff --git a/sw/qa/extras/uiwriter/uiwriter4.cxx 
b/sw/qa/extras/uiwriter/uiwriter4.cxx
index 77b42667ee87..b7f05b3960e6 100644
--- a/sw/qa/extras/uiwriter/uiwriter4.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter4.cxx
@@ -1486,7 +1486,7 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest4, testTdf95699)
 pMarkAccess = aClipboard.getIDocumentMarkAccess();
 CPPUNIT_ASSERT_EQUAL(sal_Int32(1), pMarkAccess->getAllMarksCount());
 ::sw::mark::IFieldmark* pFieldMark
-= 
pMarkAccess->getFieldmarkAfter(SwPosition(pDoc->GetNodes().GetEndOfExtras()));
+= 
pMarkAccess->getFieldmarkAfter(SwPosition(pDoc->GetNodes().GetEndOfExtras()), 
false);
 CPPUNIT_ASSERT_EQUAL(OUString("vnd.oasis.opendocument.field.FORMCHECKBOX"),
  pFieldMark->GetFieldname());
 }
diff --git a/sw/source/core/crsr/crbm.cxx b/sw/source/core/crsr/crbm.cxx
index 4e0b808c7fba..53d2538538d8 100644
--- a/sw/source/core/crsr/crbm.cxx
+++ b/sw/source/core/crsr/crbm.cxx
@@ -290,16 +290,16 @@ bool SwCursorShell::IsFormProtected()
 return getIDocumentMarkAccess()->getFieldmarkFor(pos);
 }
 
-::sw::mark::IFieldmark* SwCursorShell::GetFieldmarkAfter()
+sw::mark::IFieldmark* SwCursorShell::GetFieldmarkAfter(bool bLoop)
 {
 SwPosition pos(*GetCursor()->GetPoint());
-return getIDocumentMarkAccess()->getFieldmarkAfter(pos);
+return getIDocumentMarkAccess()->getFieldmarkAfter(pos, bLoop);
 }
 
-::sw::mark::IFieldmark* SwCursorShell::GetFieldmarkBefore()
+sw::mark::IFieldmark* SwCursorShell::GetFieldmarkBefore(bool bLoop)
 {
 SwPosition pos(*GetCursor()->GetPoint());
-return getIDocumentMarkAccess()->getFieldmarkBefore(pos);
+return getIDocumentMarkAccess()->getFieldmarkBefore(pos, bLoop);
 }
 
 bool SwCursorShell::GotoFieldmark(::sw::mark::IFieldmark const * const pMark)
diff --git a/sw/source/core/doc/docbm.cxx b/sw/source/core/doc/docbm.cxx
index 56a34fb72a3a..cd6afc472350 100644
--- a/sw/source/core/doc/docbm.cxx
+++ b/sw/source/core/doc/docbm.cxx
@@ -312,7 +312,8 @@ 

DFF_Prop_xyz vs. ESCHER_Prop_xyz ?

2023-01-24 Thread Regina Henschel

Hi all,

why there are both the defines DFF_Prop_xyz in msdffdef.hxx and the 
defines ESCHER_Prop_xyz in escherex.hxx ?
Both seems to be mainly based on the PIDs in Microsoft Office Drawing 
97-2007 Binary Format Specification.


Kind regards,
Regina


[Libreoffice-bugs] [Bug 153189] Libre froze while using Find and Replace, to the point that it's only Task Manager to the rescue.

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153189

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #2 from m.a.riosv  ---
Please test with a clean profile, Menu/Help/Restart in Safe Mode

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153188] suggestion: AutoSave on lose focus; see additional more sophisticated suggestion in comments

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153188

m.a.riosv  changed:

   What|Removed |Added

   Severity|normal  |enhancement
 Status|UNCONFIRMED |NEEDINFO
 CC||miguelangelrv@libreoffice.o
   ||rg
 Ever confirmed|0   |1

--- Comment #1 from m.a.riosv  ---
Do you known the option for Menu/Tools/Options/Load/Save/General - Save
AutoRecovery information every ...

https://help.libreoffice.org/7.6/en-US/text/shared/optionen/01010200.html?=WRITER=WIN

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-5-0' - officecfg/registry

2023-01-24 Thread Rafael Lima (via logerrit)
 officecfg/registry/data/org/openoffice/Office/UI.xcu |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit bb5371bc7e05a9f2ae4baa73f618babe732272a3
Author: Rafael Lima 
AuthorDate: Thu Jan 19 18:25:18 2023 +
Commit: Xisco Fauli 
CommitDate: Tue Jan 24 21:37:39 2023 +

tdf#152622 Fix color of Object Boundaries in dark mode

In the "LibreOffice" color scheme (the light one) the color used for Text 
Boundaries and Object Boundaries is the same.

This patch makes it so that in the "LibreOffice Dark" scheme these colors 
are the same as well.

This is important to better highlight objects over a dark background, which 
was the case reported in the bug ticket. In Impress the object boundaries were 
not visible because the color used is too dark.

Change-Id: I31e2876b14bca10fcf2c077da46e4541bb9f3ca4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145800
Tested-by: Jenkins
Reviewed-by: Heiko Tietze 
Reviewed-by: Caolán McNamara 
(cherry picked from commit cd20a17ab703e97191b4e3421527267ef82a704f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145950
Reviewed-by: Adolfo Jayme Barrientos 
(cherry picked from commit e6b93b66aee8184da05d7d45443693438f4d4eea)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146025
Tested-by: Adolfo Jayme Barrientos 
Reviewed-by: Michael Stahl 
Reviewed-by: Rafael Lima 
Reviewed-by: Xisco Fauli 

diff --git a/officecfg/registry/data/org/openoffice/Office/UI.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI.xcu
index f2c763c4d024..ec29706fd030 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI.xcu
@@ -459,7 +459,7 @@
 true
   
   
-1842204
+8421504
   
 
 


[Libreoffice-commits] core.git: Branch 'libreoffice-7-5-0' - dbaccess/source

2023-01-24 Thread Julien Nabet (via logerrit)
 dbaccess/source/ui/uno/copytablewizard.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f5ef2945d1af500c80d831ee09c1c34c766b0a54
Author: Julien Nabet 
AuthorDate: Fri Jan 13 22:05:35 2023 +0100
Commit: Xisco Fauli 
CommitDate: Tue Jan 24 21:36:46 2023 +

Related tdf#153003: Copying a query and pasting as table in same DB 
impossible

It might be a regression from ca82061c2cad00aeddb17b766063776fee0ee41a
"make ValueTransfer easier to understand

storing references to local variables makes it harder to figure out what
the control flow is doing.
"
in peculiar:
-sal_Int32 nDestColumn( 0 );
-sal_Int32 nSourceColumn( 1 );
-ValueTransfer aTransfer( nSourceColumn, nDestColumn, 
std::vector(aSourceColTypes), xRow, xStatementParams );
+sal_Int32 nSourceColumn( 0 );
+ValueTransfer aTransfer( aSourceColTypes, xRow, 
xStatementParams );

Change-Id: Iaa27c4f46fcc51ec12fff08f8e99f862c8b4ac2b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145499
Tested-by: Jenkins
Reviewed-by: Julien Nabet 
(cherry picked from commit c9b0eacae71f111209cb77f14f2693d73e5e8d90)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145440
Reviewed-by: Xisco Fauli 
(cherry picked from commit aaa072e736a45be6ca942abd20be19935334124f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145574
Reviewed-by: Michael Stahl 
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/dbaccess/source/ui/uno/copytablewizard.cxx 
b/dbaccess/source/ui/uno/copytablewizard.cxx
index fab5e3966cbd..c886995398a7 100644
--- a/dbaccess/source/ui/uno/copytablewizard.cxx
+++ b/dbaccess/source/ui/uno/copytablewizard.cxx
@@ -1141,7 +1141,7 @@ void CopyTableWizard::impl_copyRows_throw( const 
Reference< XResultSet >& _rxSou
 // notify listeners
 m_aCopyTableListeners.notifyEach( ::copyingRow, 
aCopyEvent );
 
-sal_Int32 nSourceColumn( 0 );
+sal_Int32 nSourceColumn( 1 );
 ValueTransfer aTransfer( aSourceColTypes, xRow, xStatementParams );
 
 for ( auto const& rColumnPos : aColumnPositions )


[Libreoffice-commits] core.git: vcl/unx vcl/win

2023-01-24 Thread Caolán McNamara (via logerrit)
 vcl/unx/gtk3/gtkframe.cxx   |   10 ++
 vcl/win/window/salframe.cxx |4 ++--
 2 files changed, 12 insertions(+), 2 deletions(-)

New commits:
commit d8b60e66bf1847989f6ff3c06ea214cef059ecaf
Author: Caolán McNamara 
AuthorDate: Tue Jan 24 12:33:45 2023 +
Commit: Caolán McNamara 
CommitDate: Tue Jan 24 21:16:13 2023 +

tdf#152404 crash with ibus-mozc with ctrl+alt+c during ExtTextInput

Change-Id: I86e19387d93a57c3ad263f0c2dc9222a5f3480be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146065
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/gtkframe.cxx b/vcl/unx/gtk3/gtkframe.cxx
index e9127b23e659..0a030c83b14b 100644
--- a/vcl/unx/gtk3/gtkframe.cxx
+++ b/vcl/unx/gtk3/gtkframe.cxx
@@ -451,6 +451,16 @@ bool GtkSalFrame::doKeyCallback( guint state,
 bool bStopProcessingKey;
 if (bDown)
 {
+// tdf#152404 Commit uncommitted text before dispatching key 
shortcuts. In
+// certain cases such as pressing Control-Alt-C in a Writer document 
while
+// there is uncommitted text will call GtkSalFrame::EndExtTextInput() 
which
+// will dispatch a SalEvent::EndExtTextInput event. Writer's handler 
for that
+// event will delete the uncommitted text and then insert the 
committed text
+// but LibreOffice will crash when deleting the uncommitted text 
because
+// deletion of the text also removes and deletes the newly inserted 
comment.
+if (m_pIMHandler && !m_pIMHandler->m_aInputEvent.maText.isEmpty() && 
(aEvent.mnCode & (KEY_MOD1 | KEY_MOD2)))
+m_pIMHandler->doCallEndExtTextInput();
+
 bStopProcessingKey = CallCallbackExc(SalEvent::KeyInput, );
 // #i46889# copy AlternateKeyCode handling from generic plugin
 if (!bStopProcessingKey)
diff --git a/vcl/win/window/salframe.cxx b/vcl/win/window/salframe.cxx
index 4a1a7f1a88d6..474e48560fb9 100644
--- a/vcl/win/window/salframe.cxx
+++ b/vcl/win/window/salframe.cxx
@@ -3417,8 +3417,8 @@ static void UnsetAltIfAltGr(SalKeyEvent& rKeyEvt, 
sal_uInt16 nModCode)
 }
 
 // tdf#152404 Commit uncommitted text before dispatching key shortcuts. In
-// certain cases such as pressing Command-Option-C in a Writer document while
-// there is uncommitted text will call AquaSalFrame::EndExtTextInput() which
+// certain cases such as pressing Control-Alt-C in a Writer document while
+// there is uncommitted text will call WinSalFrame::EndExtTextInput() which
 // will dispatch a SalEvent::EndExtTextInput event. Writer's handler for that
 // event will delete the uncommitted text and then insert the committed text
 // but LibreOffice will crash when deleting the uncommitted text because


[Libreoffice-bugs] [Bug 146201] Improper formatting of "frac" in Formula object ignores brackets

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146201

--- Comment #3 from gaex1...@posteo.de ---
How is this not a valid command if there's a button for it?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: include/xmloff

2023-01-24 Thread Mike Kaganski (via logerrit)
 include/xmloff/xmlprcon.hxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 639d092bc258f079f0c1655265347c94d0c51ab1
Author: Mike Kaganski 
AuthorDate: Tue Jan 24 19:32:30 2023 +0300
Commit: Mike Kaganski 
CommitDate: Tue Jan 24 20:55:58 2023 +

Fix build

... failed locally with

  C:\lo\src\core\include\rtl/ref.hxx(129): error C2027: use of undefined 
type 'SvXMLImportPropertyMapper'
  C:\lo\src\core\include\xmloff/shapeimport.hxx(46): note: see declaration 
of 'SvXMLImportPropertyMapper'
  C:\lo\src\core\include\rtl/ref.hxx(127): note: while compiling class 
template member function 
'rtl::Reference::~Reference(void)'
  C:\lo\src\core\include\xmloff/xmlprcon.hxx(64): note: see reference to 
function template instantiation 
'rtl::Reference::~Reference(void)' being compiled
  C:\lo\src\core\include\xmloff/xmlprcon.hxx(37): note: see reference to 
class template instantiation 'rtl::Reference' being 
compiled

Change-Id: I08211c58ca61d2bc81062d0b104d8ce47ffccd91
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146098
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/include/xmloff/xmlprcon.hxx b/include/xmloff/xmlprcon.hxx
index 26f94e08295e..62b5f49ebb60 100644
--- a/include/xmloff/xmlprcon.hxx
+++ b/include/xmloff/xmlprcon.hxx
@@ -45,6 +45,7 @@ public:
 ::std::vector< XMLPropertyState > ,
 rtl::Reference < SvXMLImportPropertyMapper > xMap,
   sal_Int32 nStartIdx = -1, sal_Int32 nEndIdx = -1 );
+SvXMLPropertySetContext(SvXMLPropertySetContext&&) = delete;
 
 virtual ~SvXMLPropertySetContext() override;
 


[Libreoffice-commits] core.git: include/xmloff

2023-01-24 Thread Stephan Bergmann (via logerrit)
 include/xmloff/xmlprcon.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 880117f74343087ff6a162426683378c9510ede6
Author: Stephan Bergmann 
AuthorDate: Tue Jan 24 15:00:06 2023 +0100
Commit: Stephan Bergmann 
CommitDate: Tue Jan 24 20:45:54 2023 +

Missing include

> include\rtl/ref.hxx(129): error C2027: use of undefined type 
'SvXMLImportPropertyMapper'
> include\xmloff/shapeimport.hxx(46): note: see declaration of 
'SvXMLImportPropertyMapper'
> include\rtl/ref.hxx(127): note: while compiling class template member 
function 'rtl::Reference::~Reference(void)'
> include\xmloff/xmlprcon.hxx(64): note: see reference to function template 
instantiation 'rtl::Reference::~Reference(void)' 
being compiled
> include\xmloff/xmlprcon.hxx(37): note: see reference to class template 
instantiation 'rtl::Reference' being compiled

Change-Id: I77083e021ae16bce8b2f749b96b6c6607c22ff87
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146072
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/include/xmloff/xmlprcon.hxx b/include/xmloff/xmlprcon.hxx
index 4dd39f94f9cd..26f94e08295e 100644
--- a/include/xmloff/xmlprcon.hxx
+++ b/include/xmloff/xmlprcon.hxx
@@ -21,10 +21,10 @@
 #define INCLUDED_XMLOFF_XMLPRCON_HXX
 
 #include 
+#include 
 
 #include 
 
-class SvXMLImportPropertyMapper;
 struct XMLPropertyState;
 
 class XMLOFF_DLLPUBLIC SvXMLPropertySetContext : public SvXMLImportContext


[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - svx/qa svx/source

2023-01-24 Thread Miklos Vajna (via logerrit)
 svx/qa/unit/data/page-view-draw-layer-clip.docx |binary
 svx/qa/unit/svdraw.cxx  |   37 
 svx/source/svdraw/svdpagv.cxx   |2 -
 3 files changed, 38 insertions(+), 1 deletion(-)

New commits:
commit 870c39cc6a4c16f135ebaf990011a7705649efb9
Author: Miklos Vajna 
AuthorDate: Mon Oct 10 20:38:40 2022 +0200
Commit: Andras Timar 
CommitDate: Tue Jan 24 20:40:04 2023 +

tdf#151060 sw PDF export: don't paint off-page part of drawing object

Reported to be a regression from
c12358166a9bd88fe10feabca45a6ad3f65dff8e (DOCX import: fix lost objects
anchored to an empty linked header, 2020-01-10), the 3rd page of the PDF
export result contains an unexpected line shape.

This was "working" before as all objects anchored to the empty header
were lost.

Fix the problem by clipping the rendering to the page frame when
handling shapes, similar to what
689cead9e0837dc932e3a4cd765f7d319b529018 (tdf#91260 svx, sw: don't paint
off-page part of drawing object, 2016-12-06) did to fix the normal
rendering of the document.

The testcase document just has 2 pages, so there the unexpected shape
was on the 2nd page.

Change-Id: Ica24cd15717a1ee97dff448d385a10536671103e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141167
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 
(cherry picked from commit bab44a97d21d0ac8a8a06678e71024c1a830943f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141180
Reviewed-by: Xisco Fauli 
(cherry picked from commit 475e698826e2103bdc78ac286e1fc8970363638e)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146050
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Andras Timar 

diff --git a/svx/qa/unit/data/page-view-draw-layer-clip.docx 
b/svx/qa/unit/data/page-view-draw-layer-clip.docx
new file mode 100644
index ..7136a800f01f
Binary files /dev/null and b/svx/qa/unit/data/page-view-draw-layer-clip.docx 
differ
diff --git a/svx/qa/unit/svdraw.cxx b/svx/qa/unit/svdraw.cxx
index 58d01e7f8905..04cdb43f0584 100644
--- a/svx/qa/unit/svdraw.cxx
+++ b/svx/qa/unit/svdraw.cxx
@@ -15,6 +15,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -37,6 +38,8 @@
 #include 
 #include 
 #include 
+#include 
+#include 
 
 #include 
 
@@ -500,6 +503,40 @@ CPPUNIT_TEST_FIXTURE(SvdrawTest, testVideoSnapshot)
 // i.e. ~25% crop from left and right should result in half width, but it 
was not reduced.
 CPPUNIT_ASSERT_EQUAL(static_cast(321), 
rBitmap.GetSizePixel().getWidth());
 }
+
+CPPUNIT_TEST_FIXTURE(SvdrawTest, testPageViewDrawLayerClip)
+{
+// Given a document with 2 pages, first page footer has an off-page line 
shape:
+OUString aURL = 
m_directories.getURLFromSrc(u"svx/qa/unit/data/page-view-draw-layer-clip.docx");
+mxComponent = loadFromDesktop(aURL);
+
+// When saving that document to PDF:
+utl::TempFile aTempFile;
+uno::Reference xStorable(mxComponent, uno::UNO_QUERY);
+utl::MediaDescriptor aMediaDescriptor;
+aMediaDescriptor["FilterName"] <<= OUString("writer_pdf_Export");
+xStorable->storeToURL(aTempFile.GetURL(), 
aMediaDescriptor.getAsConstPropertyValueList());
+
+// Then make sure that line shape gets clipped:
+SvFileStream aFile(aTempFile.GetURL(), StreamMode::READ);
+SvMemoryStream aMemory;
+aMemory.WriteStream(aFile);
+std::shared_ptr pPDFium = vcl::pdf::PDFiumLibrary::get();
+if (!pPDFium)
+{
+return;
+}
+std::unique_ptr pDoc
+= pPDFium->openDocument(aMemory.GetData(), aMemory.GetSize(), 
OString());
+std::unique_ptr pPage1 = pDoc->openPage(0);
+CPPUNIT_ASSERT_EQUAL(3, pPage1->getObjectCount());
+std::unique_ptr pPage2 = pDoc->openPage(1);
+// Without the accompanying fix in place, this test would have failed with:
+// - Expected: 2
+// - Actual  : 3
+// i.e. the 2nd page had a line shape from the first page's footer.
+CPPUNIT_ASSERT_EQUAL(2, pPage2->getObjectCount());
+}
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/svx/source/svdraw/svdpagv.cxx b/svx/source/svdraw/svdpagv.cxx
index 791a1fc30e70..496e57382322 100644
--- a/svx/source/svdraw/svdpagv.cxx
+++ b/svx/source/svdraw/svdpagv.cxx
@@ -262,7 +262,7 @@ void SdrPageView::DrawLayer(SdrLayerID nID, OutputDevice* 
pGivenTarget,
 if(pKnownTarget)
 {
 // paint known target
-pKnownTarget->RedrawLayer(, pRedirector, nullptr);
+pKnownTarget->RedrawLayer(, pRedirector, pPageFrame);
 }
 else
 {


[Libreoffice-commits] core.git: helpcontent2

2023-01-24 Thread Olivier Hallot (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 74d3d85dc523dbb37326db7146d195e3b9b95fce
Author: Olivier Hallot 
AuthorDate: Tue Jan 24 17:26:03 2023 -0300
Commit: Gerrit Code Review 
CommitDate: Tue Jan 24 20:26:03 2023 +

Update git submodules

* Update helpcontent2 from branch 'master'
  to 366cd93675b556c330ca6f1146f6bd67e09e8647
  - tdf#118008 (part) Format menu update

* Include align and number format menu entries
* collected default number formats in one help file

Change-Id: I01db0099ec0b4c421a717656ff3957f190501f53
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/146094
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 0b9ab742651f..366cd93675b5 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 0b9ab742651f4014540723356720507edc2ec3ac
+Subproject commit 366cd93675b556c330ca6f1146f6bd67e09e8647


[Libreoffice-bugs] [Bug 118008] [LOCALHELP] Review Format menu help page

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118008

--- Comment #8 from Commit Notification 
 ---
Olivier Hallot committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/366cd93675b556c330ca6f1146f6bd67e09e8647

tdf#118008 (part) Format menu update

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] help.git: AllLangHelp_scalc.mk AllLangHelp_shared.mk source/text

2023-01-24 Thread Olivier Hallot (via logerrit)
 AllLangHelp_scalc.mk|6 
 AllLangHelp_shared.mk   |3 
 source/text/scalc/01/default_number_formats.xhp |  182 
 source/text/scalc/02/0213.xhp   |   51 --
 source/text/scalc/02/0214.xhp   |   59 ---
 source/text/scalc/02/0215.xhp   |   50 --
 source/text/scalc/02/0216.xhp   |   49 --
 source/text/scalc/02/0217.xhp   |   49 --
 source/text/scalc/main0105.xhp  |6 
 source/text/scalc/main0202.xhp  |   24 +--
 source/text/shared/01/05070400.xhp  |2 
 source/text/shared/01/05070410.xhp  |   38 +
 source/text/shared/01/05070510.xhp  |   40 +
 source/text/shared/01/05070610.xhp  |   40 +
 source/text/shared/01/0508.xhp  |   21 +-
 source/text/shared/01/05080100.xhp  |   10 -
 source/text/shared/01/05080200.xhp  |   10 -
 source/text/shared/01/05080300.xhp  |   12 -
 source/text/shared/01/05080400.xhp  |   15 -
 19 files changed, 345 insertions(+), 322 deletions(-)

New commits:
commit 366cd93675b556c330ca6f1146f6bd67e09e8647
Author: Olivier Hallot 
AuthorDate: Tue Jan 24 11:27:21 2023 -0300
Commit: Olivier Hallot 
CommitDate: Tue Jan 24 20:26:03 2023 +

tdf#118008 (part) Format menu update

* Include align and number format menu entries
* collected default number formats in one help file

Change-Id: I01db0099ec0b4c421a717656ff3957f190501f53
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/146094
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/AllLangHelp_scalc.mk b/AllLangHelp_scalc.mk
index 452e16fd57..7cb0cf5f03 100644
--- a/AllLangHelp_scalc.mk
+++ b/AllLangHelp_scalc.mk
@@ -191,6 +191,7 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,scalc,\
 helpcontent2/source/text/scalc/01/data_form \
 helpcontent2/source/text/scalc/01/data_provider \
 helpcontent2/source/text/scalc/01/databar_more_options \
+helpcontent2/source/text/scalc/01/default_number_formats \
 helpcontent2/source/text/scalc/01/ex_data_stat_func \
 helpcontent2/source/text/scalc/01/format_graphic \
 helpcontent2/source/text/scalc/01/formula2value \
@@ -307,11 +308,6 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,scalc,\
 helpcontent2/source/text/scalc/01/ODFF \
 helpcontent2/source/text/scalc/01/text2columns \
 helpcontent2/source/text/scalc/01/xml_source \
-helpcontent2/source/text/scalc/02/0213 \
-helpcontent2/source/text/scalc/02/0214 \
-helpcontent2/source/text/scalc/02/0215 \
-helpcontent2/source/text/scalc/02/0216 \
-helpcontent2/source/text/scalc/02/0217 \
 helpcontent2/source/text/scalc/02/0601 \
 helpcontent2/source/text/scalc/02/0603 \
 helpcontent2/source/text/scalc/02/0604 \
diff --git a/AllLangHelp_shared.mk b/AllLangHelp_shared.mk
index b4bf2eadf7..8eca82202f 100644
--- a/AllLangHelp_shared.mk
+++ b/AllLangHelp_shared.mk
@@ -185,8 +185,11 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,shared,\
 helpcontent2/source/text/shared/01/05070200 \
 helpcontent2/source/text/shared/01/05070300 \
 helpcontent2/source/text/shared/01/05070400 \
+helpcontent2/source/text/shared/01/05070410 \
 helpcontent2/source/text/shared/01/05070500 \
+helpcontent2/source/text/shared/01/05070510 \
 helpcontent2/source/text/shared/01/05070600 \
+helpcontent2/source/text/shared/01/05070610 \
 helpcontent2/source/text/shared/01/0508 \
 helpcontent2/source/text/shared/01/05080100 \
 helpcontent2/source/text/shared/01/05080200 \
diff --git a/source/text/scalc/01/default_number_formats.xhp 
b/source/text/scalc/01/default_number_formats.xhp
new file mode 100644
index 00..330f9e7900
--- /dev/null
+++ b/source/text/scalc/01/default_number_formats.xhp
@@ -0,0 +1,182 @@
+
+
+
+
+
+
+Default Number Formats
+/text/scalc/01/default_number_formats.xhp
+
+
+
+
+
+Number Format
+Default number 
formats
+
+
+
+
+Number format: 
General
+Applies the default number 
format to the selected cells.
+
+
+
+Icon General Number Format
+
+
+Number Format: General
+
+
+
+
+
+
+Number format: 
Number
+Applies the 
default decimal number format to the selected cells.
+
+
+
+
+Icon Number format: Number
+
+
+
+Number format: Number
+
+
+
+
+
+
+
+  

[Libreoffice-bugs] [Bug 118008] [LOCALHELP] Review Format menu help page

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118008

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.2.0 target:7.2.0   |target:6.2.0 target:7.2.0
   ||target:7.6.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: helpcontent2

2023-01-24 Thread Rafael Lima (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 882a39e9099bf555c42da313e5127c5f31433701
Author: Rafael Lima 
AuthorDate: Tue Jan 24 20:23:58 2023 +
Commit: Gerrit Code Review 
CommitDate: Tue Jan 24 20:23:58 2023 +

Update git submodules

* Update helpcontent2 from branch 'master'
  to 0b9ab742651f4014540723356720507edc2ec3ac
  - Document new RemoveDuplicates method in SF Calc service

This patch also updates the method SortRange to remove the original 
limit of 3 row/column as keys (see commit 
40bc1b275324f9a730960fe5d4d8982cdfbc7b03)

Change-Id: If2f3e6cc97f3effdde34ee44330335ae85fef226
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/146028
Tested-by: Jenkins
Reviewed-by: Jean-Pierre Ledure 
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 40d7045493a7..0b9ab742651f 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 40d7045493a707ba164779fc506e2825b8c0909d
+Subproject commit 0b9ab742651f4014540723356720507edc2ec3ac


[Libreoffice-commits] help.git: source/text

2023-01-24 Thread Rafael Lima (via logerrit)
 source/text/sbasic/shared/03/sf_calc.xhp |   44 ---
 1 file changed, 41 insertions(+), 3 deletions(-)

New commits:
commit 0b9ab742651f4014540723356720507edc2ec3ac
Author: Rafael Lima 
AuthorDate: Mon Jan 23 22:16:43 2023 +
Commit: Olivier Hallot 
CommitDate: Tue Jan 24 20:23:58 2023 +

Document new RemoveDuplicates method in SF Calc service

This patch also updates the method SortRange to remove the original limit 
of 3 row/column as keys (see commit 40bc1b275324f9a730960fe5d4d8982cdfbc7b03)

Change-Id: If2f3e6cc97f3effdde34ee44330335ae85fef226
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/146028
Tested-by: Jenkins
Reviewed-by: Jean-Pierre Ledure 
Reviewed-by: Olivier Hallot 

diff --git a/source/text/sbasic/shared/03/sf_calc.xhp 
b/source/text/sbasic/shared/03/sf_calc.xhp
index 94c8fbdb07..fb0e17a216 100644
--- a/source/text/sbasic/shared/03/sf_calc.xhp
+++ b/source/text/sbasic/shared/03/sf_calc.xhp
@@ -584,6 +584,7 @@
  OpenRangeSelector
  PrintOut
  Printf
+ RemoveDuplicates
  RemoveSheet
  RenameSheet
  SetArray
@@ -594,7 +595,7 @@
  ShiftLeft
  ShiftRight
  ShiftUp
- SortRange
+ SortRange



@@ -1688,6 +1689,43 @@
   
 
 
+
+   RemoveDuplicates 
-
 
+  
+  Calc service;RemoveDuplicates
+  
+  RemoveDuplicates
+  Removes duplicate 
rows from a specified range. The comparison to determine if a given row is a 
duplicate is done based on a subset of columns in the range.
+  This method returns a 
string containing the resulting range.
+  The removal of duplicate rows is done 
starting at the first row in the range moving downwards, meaning that if two or 
more rows are duplicates then only the first one is kept.
+  
+  
+svc.RemoveDuplicates(range: str, opt columns: int[0..*], header: 
bool = False, casesensitive: bool = False, mode: str = "COMPACT"): str
+  
+  
+  range: 
The range from which duplicates will be removed, as a string.
+  columns: 
An array containing column numbers indicating which columns will be considered 
to determine if a row is a duplicate or not. If this argument is left blank, 
then only the first column is used. Items in this array must be in the interval 
between 1 and the range width.
+  header: 
Specifies whether the first row is a header row (Default = 
False).
+  casesensitive: Specifies whether string 
comparisons are case-senstive (Default = False).
+  mode: 
Specifies what to do with duplicate rows. If mode = "CLEAR" 
then duplicates are simply removed from the sheet leaving the cells blank. If 
mode = "COMPACT" then duplicates are removed and empty rows 
are compacted up (Default = "COMPACT").
+  
+  
+  
+' Removes duplicate 
rows where values in column A are duplicate
+' Note that all 
optional arguments use their default value
+oDoc.RemoveDuplicates("A1:B10")
+' Removes duplicate 
rows conidering that the first row contains headers
+' Columns A and B are 
used to determine if a row is a duplicate
+' Cells containing 
duplicate values are left blank
+oDoc.RemoveDuplicates("A1:D10", columns := Array(1, 
2), header := True, mode := "CLEAR")
+  
+  
+  
+myDoc.RemoveDuplicates("A1:B10")
+myDoc.RemoveDuplicates("A1:D10", columns = (1, 2), 
header = True, mode = "CLEAR")
+  
+
+
 
RemoveSheet 
--
 
   
@@ -2049,14 +2087,14 @@
   Calc service;SortRange
   
   SortRange
-  Sorts the given range 
based on up to 3 columns/rows. The sorting order may vary by column/row. It 
returns a string representing the modified range of cells. The size of the 
modified area is fully determined by the size of the source area.
+  Sorts the given range 
based on a set of columns/rows that are considered as keys. The sorting order 
may vary by column/row. It returns a string representing the modified range of 
cells. The size of the modified area is fully determined by the size of the 
source area.
   
   
 svc.SortRange(range: str, sortkeys: any, sortorder: any = "ASC", 
destinationcell: str = "", containsheader: bool = False, casesensitive: bool = 
False, sortcolumns: bool = False): str
   
   
   range: 
The range to be sorted, as a string.
-  sortkeys: A scalar (if 1 column/row) or 
an array of column/row numbers starting from 1. The maximum number of keys is 
3.
+  sortkeys: A scalar (if 1 column/row) or 
an array of column/row numbers starting from 1.
   sortorder: A scalar or an array of 
strings containing the values "ASC" (ascending), "DESC" (descending) or "" 
(which defaults to ascending). Each item is paired with the corresponding item 
in sortkeys. If the sortorder array is 

[Libreoffice-bugs] [Bug 152887] Online/automatic accessibility check needs new icons for the status bar

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152887

Dieter  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|
 Blocks||86066
 CC||dgp-m...@gmx.de

--- Comment #1 from Dieter  ---
Can't see any new icons in status bar after activating Automatic Accessibility
Checking. If there is a way to custmise statusbar, I don't know it.

Version: 7.5.0.2 (X86_64) / LibreOffice Community
Build ID: c0dd1bc3f1a385d110b88e26ece634da94921f58
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=86066
[Bug 86066] [META] Bugs and improvements to the status bar
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 86066] [META] Bugs and improvements to the status bar

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=86066

Dieter  changed:

   What|Removed |Added

 Depends on||152887


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=152887
[Bug 152887] Online/automatic accessibility check needs new icons for the
status bar
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: helpcontent2

2023-01-24 Thread Rafael Lima (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a53825419aa23297f19d1ff436e771f19177824d
Author: Rafael Lima 
AuthorDate: Tue Jan 24 20:19:03 2023 +
Commit: Gerrit Code Review 
CommitDate: Tue Jan 24 20:19:03 2023 +

Update git submodules

* Update helpcontent2 from branch 'master'
  to 40d7045493a707ba164779fc506e2825b8c0909d
  - Improve ScriptForge TOC help page

This patch also fixes the Basic service help page by classifying 
ThisComponent and ThisDatabaseDocument as properties instead of methods.

Change-Id: Ia3937b0ea3fb057dacfc31ead1db512ddd951d64
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/146023
Tested-by: Jenkins
Reviewed-by: Jean-Pierre Ledure 
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 1a892431e8d4..40d7045493a7 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 1a892431e8d42b0488af3e9bffd4924cd3e06ad1
+Subproject commit 40d7045493a707ba164779fc506e2825b8c0909d


[Libreoffice-commits] help.git: source/text

2023-01-24 Thread Rafael Lima (via logerrit)
 source/text/sbasic/shared/03/sf_basic.xhp |   80 --
 source/text/sbasic/shared/03/sf_toc.xhp   |   56 ++---
 2 files changed, 51 insertions(+), 85 deletions(-)

New commits:
commit 40d7045493a707ba164779fc506e2825b8c0909d
Author: Rafael Lima 
AuthorDate: Mon Jan 23 14:51:17 2023 +
Commit: Olivier Hallot 
CommitDate: Tue Jan 24 20:19:03 2023 +

Improve ScriptForge TOC help page

This patch also fixes the Basic service help page by classifying 
ThisComponent and ThisDatabaseDocument as properties instead of methods.

Change-Id: Ia3937b0ea3fb057dacfc31ead1db512ddd951d64
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/146023
Tested-by: Jenkins
Reviewed-by: Jean-Pierre Ledure 
Reviewed-by: Olivier Hallot 

diff --git a/source/text/sbasic/shared/03/sf_basic.xhp 
b/source/text/sbasic/shared/03/sf_basic.xhp
index 2dbd3a0292..bb4f814a7b 100644
--- a/source/text/sbasic/shared/03/sf_basic.xhp
+++ b/source/text/sbasic/shared/03/sf_basic.xhp
@@ -112,7 +112,35 @@
UNOobject


-   StarDesktop 
object represents %PRODUCTNAME Start Center.
+   Returns 
the StarDesktop 
object that represents the %PRODUCTNAME application.
+   
+
+
+   
+   ThisComponent
+   
+   
+   Yes
+   
+   
+   UNOobject
+   
+   
+   If the 
current component refers to a %PRODUCTNAME document, this method returns the 
UNO object representing the document. This property returns 
None when the current component does not correspond to a 
document.
+   
+
+
+   
+   ThisDatabaseDocument
+   
+   
+   Yes
+   
+   
+   UNOobject
+   
+   
+   If the 
script is being executed from a Base document or any of its subcomponents this 
method returns the main component of the Base instance. This property returns 
None otherwise.

 
   
@@ -135,11 +163,11 @@
  CreateUnoService
  CreateUnoStruct
  DateAdd
- DateDiff




+ DateDiff
  DatePart
  DateValue
  Format
@@ -147,19 +175,17 @@
  GetGuiType
  GetPathSeparator
  GetSystemTicks
- GlobalScope.BasicLibraries
- GlobalScope.DialogLibraries




+ GlobalScope.BasicLibraries
+ GlobalScope.DialogLibraries
  InputBox
  MsgBox
  Now
  RGB
- ThisComponent
- ThisDatabaseDocument
- Xray
+ Xray



@@ -609,46 +635,6 @@
   
 
 
-
-   ThisComponent -- 

-  
-Basic service;ThisComponent
-  
-  ThisComponent
-  If the current 
component refers to a %PRODUCTNAME document, this method returns the UNO object 
representing the document.
-  The method will 
return None when the current component does not correspond 
to a document.
-  
-  
-svc.ThisComponent(): uno
-  
-  
-  
-comp = 
bas.ThisComponent
-bas.MsgBox("\n".join(comp.getSupportedServiceNames()))
-  
-
-
-
-   ThisDatabaseDocument -- 

-  
-Basic service;ThisDatabaseDocument
-  
-  ThisDatabaseDocument
-  If the script is 
being executed from a Base document or any of its subcomponents this method 
returns the main component of the Base instance.
-  This method returns 
None otherwise.
-  
-  
-svc.ThisDatabaseDocument(): uno
-  
-  
-  
-db_doc = bas.ThisDatabaseDocument
-table_names = 
db_doc.DataSource.getTables().getElementNames()
-bas.MsgBox("\n".join(table_names))
-  
-  Visit the https://api.libreoffice.org/docs/idl/ref/servicecom_1_1sun_1_1star_1_1sdb_1_1OfficeDatabaseDocument.html;>OfficeDatabaseDocument
 API page to learn more about Base's main component structure.
-
-
 
Xray  

   
diff --git a/source/text/sbasic/shared/03/sf_toc.xhp 
b/source/text/sbasic/shared/03/sf_toc.xhp
index d63dccfa36..d74a25c9bb 100644
--- a/source/text/sbasic/shared/03/sf_toc.xhp
+++ b/source/text/sbasic/shared/03/sf_toc.xhp
@@ -23,14 +23,16 @@
   
   List of all 
ScriptForge methods and properties
   This help page shows 
all methods and properties available in the ScriptForge 
library by service with links to the corresponding documentation.
+  The Basic source code for all 
ScriptForge services is available via Application Macros and 
Dialogs and is distributed in multiple libraries: 
ScriptForge, SFDatabases, 
SFDialogs, SFDocuments, 
SFUnitTests and SFWidgets. The 
Python portion of the source code is available in the 
program\scriptforge.py file under the %PRODUCTNAME installation 
directory.
 
   ScriptForge.Array
 service
  

[Libreoffice-bugs] [Bug 153190] Compressing tool calculates compression rate wrong on large images

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153190

--- Comment #1 from CaCO3  ---
Created attachment 184880
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184880=edit
Screenshot

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153190] New: Compressing tool calculates compression rate wrong on large images

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153190

Bug ID: 153190
   Summary: Compressing tool calculates compression rate wrong on
large images
   Product: LibreOffice
   Version: 7.3.7.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ca...@ruinelli.ch

Description:
Uint16 Overflow on the compression rate calculation

Steps to Reproduce:
1. Load a large png image (eg. 70 MB) into impress
2. Call the compression tool
3. Let it calculate the compression rate

Actual Results:
Compression Rate: -18%

Expected Results:
Compression Rate: 98%


Reproducible: Always


User Profile Reset: No

Additional Info:
There is an UNIT16 overflow since the image is larger than 65535

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152885] FILEOPEN RTF Page break and section break result in extra paragraph

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152885

Dieter  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|
 Status|UNCONFIRMED |NEW
 CC||dgp-m...@gmx.de
 Ever confirmed|0   |1

--- Comment #3 from Dieter  ---
I confirm it with

Version: 7.5.0.2 (X86_64) / LibreOffice Community
Build ID: c0dd1bc3f1a385d110b88e26ece634da94921f58
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152874] FILEOPEN RTF Paragraph shading from style, overridden by DF is still visible in Writer

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152874

Dieter  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||dgp-m...@gmx.de
 Whiteboard| QA:needsComment|
 Status|UNCONFIRMED |NEW

--- Comment #2 from Dieter  ---
I confirm it with

Version: 7.5.0.2 (X86_64) / LibreOffice Community
Build ID: c0dd1bc3f1a385d110b88e26ece634da94921f58
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: comphelper/source include/comphelper toolkit/inc

2023-01-24 Thread Stephan Bergmann (via logerrit)
 comphelper/source/misc/accessiblecomponenthelper.cxx |5 -
 include/comphelper/accessiblecomponenthelper.hxx |   18 --
 toolkit/inc/controls/accessiblecontrolcontext.hxx|1 +
 3 files changed, 9 insertions(+), 15 deletions(-)

New commits:
commit 5747634948fcb0f3430a2ce7647e128712cbba66
Author: Stephan Bergmann 
AuthorDate: Mon Jan 23 17:09:52 2023 +0100
Commit: Stephan Bergmann 
CommitDate: Tue Jan 24 19:57:25 2023 +

Use ImplInheritanceHelper in OAccessibleExtendedComponentHelper

(Explicitly deleting the special member functions is needed to avoid MSVC

> include\cppuhelper/implbase.hxx(152): error C2280: 
'comphelper::OCommonAccessibleComponent::OCommonAccessibleComponent(const 
comphelper::OCommonAccessibleComponent &)': attempting to reference a deleted 
function
> include\comphelper/accessiblecomponenthelper.hxx(176): note: compiler has 
generated 'comphelper::OCommonAccessibleComponent::OCommonAccessibleComponent' 
here
> include\comphelper/accessiblecomponenthelper.hxx(176): note: 
'comphelper::OCommonAccessibleComponent::OCommonAccessibleComponent(const 
comphelper::OCommonAccessibleComponent &)': function was implicitly deleted 
because a base class invokes a deleted or inaccessible function 
'cppu::BaseMutex::BaseMutex(const cppu::BaseMutex &)'
> include\cppuhelper/basemutex.hxx(43): note: 
'cppu::BaseMutex::BaseMutex(const cppu::BaseMutex &)': function was implicitly 
deleted because a data member invokes a deleted or inaccessible function 
'osl::Mutex::Mutex(const osl::Mutex &)'
> include\osl/mutex.hxx(107): note: 'osl::Mutex::Mutex(const osl::Mutex 
&)': function was explicitly deleted
> include\comphelper/accessiblecomponenthelper.hxx(228): note: see 
reference to function template instantiation 
'cppu::ImplInheritanceHelper::ImplInheritanceHelper>(cppu::ImplInheritanceHelper
 &&)' being compiled
> include\comphelper/accessiblecomponenthelper.hxx(228): note: see 
reference to function template instantiation 
'cppu::ImplInheritanceHelper::ImplInheritanceHelper>(cppu::ImplInheritanceHelper
 &&)' being compiled

)

Change-Id: Ia5a7b244dd018c1a63cc2940dba197c43827d563
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146062
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/comphelper/source/misc/accessiblecomponenthelper.cxx 
b/comphelper/source/misc/accessiblecomponenthelper.cxx
index cb49bdb52199..816b3b69ee0c 100644
--- a/comphelper/source/misc/accessiblecomponenthelper.cxx
+++ b/comphelper/source/misc/accessiblecomponenthelper.cxx
@@ -337,11 +337,6 @@ namespace comphelper
 }
 
 
-IMPLEMENT_FORWARD_XINTERFACE2( OAccessibleExtendedComponentHelper, 
OCommonAccessibleComponent, OAccessibleExtendedComponentHelper_Base )
-IMPLEMENT_FORWARD_XTYPEPROVIDER2( OAccessibleExtendedComponentHelper, 
OCommonAccessibleComponent, OAccessibleExtendedComponentHelper_Base )
-// (order matters: the first is the class name, the second is the 
class doing the ref counting)
-
-
 sal_Bool SAL_CALL OAccessibleExtendedComponentHelper::containsPoint( const 
awt::Point& _rPoint )
 {
 return OCommonAccessibleComponent::containsPoint( _rPoint );
diff --git a/include/comphelper/accessiblecomponenthelper.hxx 
b/include/comphelper/accessiblecomponenthelper.hxx
index def0b9e2fecb..2a840ea9e36e 100644
--- a/include/comphelper/accessiblecomponenthelper.hxx
+++ b/include/comphelper/accessiblecomponenthelper.hxx
@@ -28,7 +28,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 
@@ -209,24 +208,23 @@ namespace comphelper
 //= OAccessibleExtendedComponentHelper
 
 
-typedef ::cppu::ImplHelper1 <   
css::accessibility::XAccessibleExtendedComponent
->   OAccessibleExtendedComponentHelper_Base;
-
 /** a helper class for implementing an AccessibleContext which at the same 
time
 supports an XAccessibleExtendedComponent interface.
 */
 class COMPHELPER_DLLPUBLIC OAccessibleExtendedComponentHelper
-:public OCommonAccessibleComponent
-,public OAccessibleExtendedComponentHelper_Base
+:public cppu::ImplInheritanceHelper<
+ OCommonAccessibleComponent, 
css::accessibility::XAccessibleExtendedComponent>
 {
+private:
+OAccessibleExtendedComponentHelper(OAccessibleExtendedComponentHelper 
const &) = delete;
+OAccessibleExtendedComponentHelper(OAccessibleExtendedComponentHelper 
&&) = delete;
+void operator =(OAccessibleExtendedComponentHelper const &) = delete;
+void operator =(OAccessibleExtendedComponentHelper &&) = delete;
+
 protected:
 OAccessibleExtendedComponentHelper( );
 
 public:
-// XInterface
-DECLARE_XINTERFACE( )
-DECLARE_XTYPEPROVIDER( )
-
 // XAccessibleComponent - default implementations
 virtual sal_Bool SAL_CALL containsPoint( const 

[Libreoffice-bugs] [Bug 153189] Libre froze while using Find and Replace, to the point that it's only Task Manager to the rescue.

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153189

--- Comment #1 from Steve-oh  ---
Pardon me for quoting myself.
"I don't understand why you need a Summery that's so remarkably detailed then
you've a Description area as well, however - AS I've already said when using
Find and Replace, and Specifically clicking the central 'Format' button - it's
Frozen solid..."

Again I apologize. The '...it's Frozen' meant simply that the entire program
was frozen solid. I realize that this is no doubt implied however it is
lacking.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153189] New: Libre froze while using Find and Replace, to the point that it's only Task Manager to the rescue.

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153189

Bug ID: 153189
   Summary: Libre froze while using Find and Replace, to the point
that it's only Task Manager to the rescue.
   Product: LibreOffice
   Version: 7.4.3.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: steve...@twc.com

Description:
I don't understand why you need a Summery that's so remarkably detailed then
you've a Description area as well, however - AS I've already said when using
Find and Replace, and Specifically clicking the central 'Format' button - it's
Frozen solid.
Sadly this is far from the first editing option that I've chosen, and had this
happen. Fortunately today I felt like creating yet again, another acct.
someplace w/ log-in information that I've had to record.
I do not recall the last 'couple' of things that produced the Exact same
result, only I Know that in each case it was something different that I was
attempting to do/use. I believe the last time it was (only a few days ago)
changing margins perhaps. I'm not sure. I trained on Quark years ago. Text
editing is peaceful tbh. TMI.
FYI and all that... it's a real issue - all this freezing. About ready to just
toss it back. 0.o
SteveBob

Steps to Reproduce:
1.Open a fresh document, and paste in some text.
2.Access Edit/Find and Replace
3.Click on Format...  button center-low on the window

Actual Results:
Frozen

Expected Results:
I expected it to freeze.
When a given function manages to freeze in LibreOffice, it seems to be rather
consistent.


Reproducible: Sometimes


User Profile Reset: No

Additional Info:
n/a

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153171] suggestion: add option to add x number of rows/columns in the menu

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153171

Rafael Lima  changed:

   What|Removed |Added

 CC||rafael.palma.l...@gmail.com

--- Comment #2 from Rafael Lima  ---
I personally never felt the need for such a feature. But maybe some users want
to insert exactly f.i. 125 lines above/below and then this request might be
valid. In summary, this feature would be interesting when the number of rows to
be created is large enough, so that the workaround in Comment #1 is
impractical.

The main problem is how/where to add this new command? Currently the poppup
menu is very crowded with 15 commands.

Should we the 16th? It could be called "Insert Rows..." and would open a simple
dialog allowing the user to insert the number of rows to insert and select
whether they'll be inserted "Above" or "Below".

If we implement this, then we should create the same command for columns as
well.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 153171] suggestion: add option to add x number of rows/columns in the menu

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153171

Rafael Lima  changed:

   What|Removed |Added

 CC||rafael.palma.l...@gmail.com

--- Comment #2 from Rafael Lima  ---
I personally never felt the need for such a feature. But maybe some users want
to insert exactly f.i. 125 lines above/below and then this request might be
valid. In summary, this feature would be interesting when the number of rows to
be created is large enough, so that the workaround in Comment #1 is
impractical.

The main problem is how/where to add this new command? Currently the poppup
menu is very crowded with 15 commands.

Should we the 16th? It could be called "Insert Rows..." and would open a simple
dialog allowing the user to insert the number of rows to insert and select
whether they'll be inserted "Above" or "Below".

If we implement this, then we should create the same command for columns as
well.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-ux-advise] [Bug 129905] Cannot turn off section boundaries with Options-Application Colors

2023-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129905

--- Comment #13 from Rafael Lima  ---
I proposed a patch that implements option (a). It's available for review in
Gerrit.

https://gerrit.libreoffice.org/c/core/+/146077

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  1   2   3   4   >