[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - vcl/Module_vcl.mk

2023-02-23 Thread Tor Lillqvist (via logerrit)
 vcl/Module_vcl.mk |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 5c0044c81649a5fa239b8d97edda8bbfa371a282
Author: Tor Lillqvist 
AuthorDate: Wed Jan 11 12:56:04 2023 +0200
Commit: Tor Lillqvist 
CommitDate: Fri Feb 24 07:59:20 2023 +

Don't bother building the vcldemo executable for WASM unless using Qt5

Reduces build time a bit.

Sadly, we do need to build soffice.wasm also when not using Qt5,
because wasm/Makefile.am in online uses its .linkdeps file.

Change-Id: I48f67598050208220e63e3a0ff627f6420ff837f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145353
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147566
Tested-by: Tor Lillqvist 

diff --git a/vcl/Module_vcl.mk b/vcl/Module_vcl.mk
index 596ed5b8c03a..b6d06a6bc351 100644
--- a/vcl/Module_vcl.mk
+++ b/vcl/Module_vcl.mk
@@ -37,7 +37,9 @@ $(eval $(call gb_Module_add_targets,vcl,\
 $(if $(filter DESKTOP FUZZERS,$(BUILD_TYPE)), \
 StaticLibrary_vclmain \
 $(if $(or $(DISABLE_GUI),$(DISABLE_DYNLOADING)), \
-$(if $(filter EMSCRIPTEN,$(OS)),Executable_vcldemo) \
+$(if $(filter EMSCRIPTEN,$(OS)), \
+$(if $(ENABLE_QT5),Executable_vcldemo) \
+) \
 , \
 $(if $(filter LINUX MACOSX SOLARIS WNT %BSD,$(OS)), \
 Executable_vcldemo \


[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - vcl/source

2023-02-23 Thread Tor Lillqvist (via logerrit)
 vcl/source/window/builder.cxx |   40 +++-
 1 file changed, 39 insertions(+), 1 deletion(-)

New commits:
commit 031be329f6a64e56002ebb10e2e660333dd4667a
Author: Tor Lillqvist 
AuthorDate: Tue Jan 10 17:55:01 2023 +0200
Commit: Tor Lillqvist 
CommitDate: Fri Feb 24 07:58:49 2023 +

Make the "custom widgets" for the notebookbar work in COWASM

Because building for WASM for some reason doesn't use the
native-code.py approach, we need to duplicate part of what that script
would produce.

Change-Id: Iecb200b4b0d693914f57f6f73d5025626f15dcf8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145283
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147565
Tested-by: Tor Lillqvist 

diff --git a/vcl/source/window/builder.cxx b/vcl/source/window/builder.cxx
index 9c6e8d97881a..047fd6e4ae9c 100644
--- a/vcl/source/window/builder.cxx
+++ b/vcl/source/window/builder.cxx
@@ -9,6 +9,7 @@
 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -1478,7 +1479,42 @@ void VclBuilderPreload()
 }
 
 #if defined DISABLE_DYNLOADING && !HAVE_FEATURE_DESKTOP
+
+// This ifdef branch is mainly for building for the Collabora Online
+// -based mobile apps for Android and iOS.
+
 extern "C" VclBuilder::customMakeWidget lo_get_custom_widget_func(const char* 
name);
+
+#elif defined EMSCRIPTEN && !ENABLE_QT5
+
+// This branch is mainly for building for WASM, and especially for
+// Collabora Online in the browser, where code from core and Collabora
+// Online is compiled to WASM and linked into a single WASM binary.
+// (Not for Allotropia's Qt-based LibreOffice in the browser.)
+
+// When building core for WASM it doesn't use the same
+// solenv/bin/native-code.py thing as the mobile apps, even if in both
+// cases everything is linked statically. So there is no generated
+// native-code.h, and we can't use lo_get_custom_widget_func() from
+// that. So cheat and duplicate the code from an existing generated
+// native-code.h. It's just a handful of lines anyway.
+
+extern "C" void makeNotebookbarTabControl(VclPtr , const 
VclPtr , VclBuilder::stringmap );
+extern "C" void makeNotebookbarToolBox(VclPtr , const 
VclPtr , VclBuilder::stringmap );
+
+static struct { const char *name; VclBuilder::customMakeWidget func; } 
custom_widgets[] = {
+{ "makeNotebookbarTabControl", makeNotebookbarTabControl },
+{ "makeNotebookbarToolBox", makeNotebookbarToolBox },
+};
+
+static VclBuilder::customMakeWidget lo_get_custom_widget_func(const char* name)
+{
+for (size_t i = 0; i < sizeof(custom_widgets) / sizeof(custom_widgets[0]); 
i++)
+if (strcmp(name, custom_widgets[i].name) == 0)
+return custom_widgets[i].func;
+return nullptr;
+}
+
 #endif
 
 namespace
@@ -1538,7 +1574,9 @@ VclBuilder::customMakeWidget GetCustomMakeWidget(const 
OString& rName)
 else
 pFunction = reinterpret_cast(
 aI->second->getFunctionSymbol(sFunction));
-#elif !HAVE_FEATURE_DESKTOP
+#elif !HAVE_FEATURE_DESKTOP || (defined EMSCRIPTEN && !ENABLE_QT5)
+// This ifdef branch is mainly for building for either the
+// Android or iOS apps, or the Collabora Online as WASM thing.
 pFunction = lo_get_custom_widget_func(sFunction.toUtf8().getStr());
 SAL_WARN_IF(!pFunction, "vcl.builder", "Could not find " << sFunction);
 assert(pFunction);


[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - tools/source

2023-02-23 Thread Tor Lillqvist (via logerrit)
 tools/source/misc/extendapplicationenvironment.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 7a0d7d6834ad5efd879968f706b75954e76acfa8
Author: Tor Lillqvist 
AuthorDate: Fri Dec 30 12:55:31 2022 +0200
Commit: Tor Lillqvist 
CommitDate: Fri Feb 24 07:58:22 2023 +

I get "warning: unsupported syscall: __sys_prlimit64" in WASM so avoid that

Change-Id: I8a9a19d3c7757e1b7e1d194c439280a9d4824c3a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144876
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147564
Tested-by: Tor Lillqvist 

diff --git a/tools/source/misc/extendapplicationenvironment.cxx 
b/tools/source/misc/extendapplicationenvironment.cxx
index ce2237a88c70..07f9779ccc26 100644
--- a/tools/source/misc/extendapplicationenvironment.cxx
+++ b/tools/source/misc/extendapplicationenvironment.cxx
@@ -38,7 +38,7 @@ namespace tools
 {
 void extendApplicationEnvironment()
 {
-#if defined UNX
+#if defined UNX && !defined EMSCRIPTEN
 // Try to set RLIMIT_NOFILE as large as possible (failure is harmless):
 rlimit lim;
 if (getrlimit(RLIMIT_NOFILE, ) == 0)


[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - sal/osl

2023-02-23 Thread Tor Lillqvist (via logerrit)
 sal/osl/unx/process_impl.cxx |8 
 1 file changed, 8 insertions(+)

New commits:
commit 701f0037383d9e10befec710d2a59e9adc91e588
Author: Tor Lillqvist 
AuthorDate: Tue Dec 13 10:47:15 2022 +0200
Commit: Tor Lillqvist 
CommitDate: Fri Feb 24 07:57:46 2023 +

Add Emscripten ifdef to bootstrap_getExecutableFile()

Change-Id: I15d31873a27ace544a76a64fe354edb97b144424
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144039
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147563
Tested-by: Tor Lillqvist 

diff --git a/sal/osl/unx/process_impl.cxx b/sal/osl/unx/process_impl.cxx
index 5d7f7644feb0..a61df87c2cff 100644
--- a/sal/osl/unx/process_impl.cxx
+++ b/sal/osl/unx/process_impl.cxx
@@ -97,6 +97,13 @@ oslProcessError bootstrap_getExecutableFile(rtl_uString ** 
ppFileURL)
 {
 oslProcessError result = osl_Process_E_NotFound;
 
+#ifdef EMSCRIPTEN
+// Just return some dummy file: URL for now to see what happens
+OUString fileURL = "vnd.sun.star.pathname:/instdir/program/soffice";
+rtl_uString_acquire(fileURL.pData);
+*ppFileURL = fileURL.pData;
+return osl_Process_E_None;
+#else
 #ifdef ANDROID
 /* Now with just a single DSO, this one from lo-bootstrap.c is as good as
  * any */
@@ -136,6 +143,7 @@ oslProcessError bootstrap_getExecutableFile(rtl_uString ** 
ppFileURL)
 }
 
 return result;
+#endif
 }
 
 }


[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - static/README.wasm.md

2023-02-23 Thread Tor Lillqvist (via logerrit)
 static/README.wasm.md |   15 +--
 1 file changed, 5 insertions(+), 10 deletions(-)

New commits:
commit b7bcd8b77006922e2df5388b67c0d73f3db72ce3
Author: Tor Lillqvist 
AuthorDate: Wed Dec 14 21:38:08 2022 +0200
Commit: Tor Lillqvist 
CommitDate: Fri Feb 24 07:56:40 2023 +

Update Qt5 build instructions to use Allotropia's pre-patched repo

Change-Id: I4b739e36a008940705b32a2c83757520e2ae1add
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144196
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147562
Tested-by: Tor Lillqvist 

diff --git a/static/README.wasm.md b/static/README.wasm.md
index c0fe6354e1a5..2a8727a1a5aa 100644
--- a/static/README.wasm.md
+++ b/static/README.wasm.md
@@ -54,19 +54,14 @@ generally the Qt6 WASM documentation is much better, 
because it incorporated man
 information from the Qt Wiki.
 
 FWIW: Qt 5.15 LTS is not maintained publicly and Qt WASM has quite a few bugs. 
Most
-WASM fixes from Qt 6 are needed for Qt 5.15 too. They can mainly be 
cherry-picked from:
-- git log origin/dev src/plugins/platforms/wasm/
-- git log --grep wasm origin/dev
+WASM fixes from Qt 6 are needed for Qt 5.15 too. Allotropia offers a Qt 
repository
+with the necessary patches cherry-picked.
 
-We will probably offer our own Qt repository clone at some point.
-
-But even the public Qt 5.15 branch is still broken, so better start with the 
v5.15.2 tag.
-
-git clone https://github.com/qt/qt5.git
+git clone https://github.com/allotropia/qt5.git
 cd qt5
-git checkout v5.15.2
+git checkout v5.15.2+wasm
 ./init-repository --module-subset=qtbase
-./configure -xplatform wasm-emscripten -feature-thread -prefix 
$PWD/install-5.15.2
+./configure -xplatform wasm-emscripten -feature-thread -prefix 
 make -j module-qtbase
 
 Optionally you can add the configure flag "-compile-examples". But then you 
also have to


[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - external/fontconfig

2023-02-23 Thread Tor Lillqvist (via logerrit)
 external/fontconfig/ExternalProject_fontconfig.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 05ae7910448a46aa7bb5698244db83d86ed9f1f9
Author: Tor Lillqvist 
AuthorDate: Wed Dec 14 21:50:09 2022 +0200
Commit: Tor Lillqvist 
CommitDate: Fri Feb 24 07:56:25 2023 +

Need to mention libxml2 here, too, when building for Emscripten

Forgot this in 563c28b6508ac836fbe46369a4d2d300cda650cf.

Change-Id: I8675273c461f1b83b4dbe8bb7f9f58130a1d77fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144200
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147561
Tested-by: Tor Lillqvist 

diff --git a/external/fontconfig/ExternalProject_fontconfig.mk 
b/external/fontconfig/ExternalProject_fontconfig.mk
index ed01c04aaf2f..3bbecf1d672a 100644
--- a/external/fontconfig/ExternalProject_fontconfig.mk
+++ b/external/fontconfig/ExternalProject_fontconfig.mk
@@ -10,7 +10,7 @@
 $(eval $(call gb_ExternalProject_ExternalProject,fontconfig))
 
 $(eval $(call gb_ExternalProject_use_externals,fontconfig,\
-   expat \
+   $(if $(filter EMSCRIPTEN,$(OS)),libxml2,expat) \
freetype \
 ))
 


[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - solenv/gbuild

2023-02-23 Thread Tor Lillqvist (via logerrit)
 solenv/gbuild/platform/unxgcc.mk |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 55b095abcb655a9199be10243e2c6cf74d7e57f5
Author: Tor Lillqvist 
AuthorDate: Fri Dec 23 12:41:09 2022 +0200
Commit: Tor Lillqvist 
CommitDate: Fri Feb 24 07:56:02 2023 +

Don't use symlinks for the Emscripten soffice.data and 
soffice.data.js.metadata

Symlinks just complicate things. Disk space is cheap. soffice.data is
under 100 megs even with Qt5.

Note that after this you will need to clean out the existing
soffice.data and soffice.data.js.metadata symlinks before you run
make, otherwise you will get errors.

As such, it is a bit weird that we unconditionally play around with
soffice.data for *all* (non-CppunitTest) Executable targets. (Thus,
for instance also for vcldemo and unoidl-read.) We should do this
dance only for the soffice executable. And we should reduce the number
of executables we build for Emscripten. Probably none other than
soffice itself makes sense?

Change-Id: I75f6719b92d83e88bf59d65c38aeeab47e0b29e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144781
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147560
Tested-by: Tor Lillqvist 

diff --git a/solenv/gbuild/platform/unxgcc.mk b/solenv/gbuild/platform/unxgcc.mk
index f1cb77a63054..bfb860a41fc2 100644
--- a/solenv/gbuild/platform/unxgcc.mk
+++ b/solenv/gbuild/platform/unxgcc.mk
@@ -183,8 +183,8 @@ $(if $(filter TRUE,$(ENABLE_QT5)), \
 sed -e 's/@APPNAME@/$(subst $(gb_Executable_EXT),,$(notdir $(1)))/' 
$(QT5_PLATFORMS_SRCDIR)/wasm_shell.html > $(dir $(1))qt_$(notdir $(1)); \
 cp $(QT5_PLATFORMS_SRCDIR)/qtlogo.svg $(QT5_PLATFORMS_SRCDIR)/qtloader.js 
$(dir $(1)) ; \
 ) \
-ln -sf $(call 
gb_CustomTarget_get_workdir,static/emscripten_fs_image)/soffice.data $(dir 
$(1))/soffice.data ; \
-ln -sf $(call 
gb_CustomTarget_get_workdir,static/emscripten_fs_image)/soffice.data.js.metadata
 $(dir $(1))/soffice.data.js.metadata \
+cp $(call 
gb_CustomTarget_get_workdir,static/emscripten_fs_image)/soffice.data $(dir 
$(1))/soffice.data ; \
+cp $(call 
gb_CustomTarget_get_workdir,static/emscripten_fs_image)/soffice.data.js.metadata
 $(dir $(1))/soffice.data.js.metadata \
 )
 endef
 


[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - solenv/gbuild

2023-02-23 Thread Tor Lillqvist (via logerrit)
 solenv/gbuild/platform/unxgcc.mk |8 +---
 1 file changed, 5 insertions(+), 3 deletions(-)

New commits:
commit b7d19c5f2538507a0abae4e3b7c301b6f66f
Author: Tor Lillqvist 
AuthorDate: Fri Dec 23 12:23:32 2022 +0200
Commit: Tor Lillqvist 
CommitDate: Fri Feb 24 07:55:38 2023 +

Un-confuse Emscripten and Qt5 conditionals

The embedded file system that we construct when building for
Emscripten is not related to whether we use Qt5 or not.

Change-Id: Ibf65cae06093d9130a19780c1116f8b9997c664b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144780
Reviewed-by: Tor Lillqvist 
Tested-by: Tor Lillqvist 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147559

diff --git a/solenv/gbuild/platform/unxgcc.mk b/solenv/gbuild/platform/unxgcc.mk
index 461d1f048390..f1cb77a63054 100644
--- a/solenv/gbuild/platform/unxgcc.mk
+++ b/solenv/gbuild/platform/unxgcc.mk
@@ -178,11 +178,13 @@ $(if $(filter Library,$(TARGETTYPE)), $(call 
gb_Helper_abbreviate_dirs,\
 | cut -d' ' -f1-2 >> $(WORKDIR)/LinkTarget/$(2).exports.tmp && \
 $(call 
gb_Helper_replace_if_different_and_touch,$(WORKDIR)/LinkTarget/$(2).exports.tmp,
 \
 $(WORKDIR)/LinkTarget/$(2).exports,$(1
-$(if $(and $(filter CppunitTest Executable,$(TARGETTYPE)),$(filter 
EMSCRIPTEN,$(OS)),$(filter TRUE,$(ENABLE_QT5))), \
+$(if $(and $(filter CppunitTest Executable,$(TARGETTYPE)),$(filter 
EMSCRIPTEN,$(OS))), \
+$(if $(filter TRUE,$(ENABLE_QT5)), \
+sed -e 's/@APPNAME@/$(subst $(gb_Executable_EXT),,$(notdir $(1)))/' 
$(QT5_PLATFORMS_SRCDIR)/wasm_shell.html > $(dir $(1))qt_$(notdir $(1)); \
 cp $(QT5_PLATFORMS_SRCDIR)/qtlogo.svg $(QT5_PLATFORMS_SRCDIR)/qtloader.js 
$(dir $(1)) ; \
-sed -e 's/@APPNAME@/$(subst $(gb_Executable_EXT),,$(notdir $(1)))/' 
$(QT5_PLATFORMS_SRCDIR)/wasm_shell.html > $(dir $(1))qt_$(notdir $(1)) ; \
+) \
 ln -sf $(call 
gb_CustomTarget_get_workdir,static/emscripten_fs_image)/soffice.data $(dir 
$(1))/soffice.data ; \
-ln -sf $(call 
gb_CustomTarget_get_workdir,static/emscripten_fs_image)/soffice.data.js.metadata
 $(dir $(1))/soffice.data.js.metadata ; \
+ln -sf $(call 
gb_CustomTarget_get_workdir,static/emscripten_fs_image)/soffice.data.js.metadata
 $(dir $(1))/soffice.data.js.metadata \
 )
 endef
 


[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - desktop/source i18nlangtag/source include/osl Repository.mk sal/emscripten sal/Library_lo-bootstrap.mk sal/Library_sal.mk sal/Modul

2023-02-23 Thread Tor Lillqvist (via logerrit)
 Repository.mk  |6 +
 desktop/source/lib/init.cxx|8 ---
 i18nlangtag/source/languagetag/languagetag.cxx |6 -
 include/osl/detail/emscripten-bootstrap.h  |   26 +
 sal/Library_lo-bootstrap.mk|9 
 sal/Library_sal.mk |2 -
 sal/Module_sal.mk  |2 -
 sal/emscripten/lo-bootstrap.c  |   19 ++
 sal/rtl/bootstrap.cxx  |6 -
 solenv/clang-format/excludelist|2 +
 unotools/source/i18n/resmgr.cxx|   10 ++---
 11 files changed, 86 insertions(+), 10 deletions(-)

New commits:
commit cae91e5b77c35e8b5cb9b0e543ae049dd0f72fd1
Author: Tor Lillqvist 
AuthorDate: Wed Dec 28 13:47:26 2022 +0200
Commit: Tor Lillqvist 
CommitDate: Fri Feb 24 07:55:10 2023 +

Introduce lo_get_app_data_dir() for Emscripten, too

And not just Android. Hardcoded to return "/instdir" to match what is
in the emscripten_fs_image.

Change-Id: I26d4ec5e02ec9900e35ca47f1565a13ad2b723b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144849
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147558
Tested-by: Tor Lillqvist 

diff --git a/Repository.mk b/Repository.mk
index 8f3ff83ab181..80e511671626 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -335,6 +335,12 @@ $(eval $(call 
gb_Helper_register_libraries_for_install,OOOLIBS,ogltrans, \
OGLTrans \
 ))
 
+ifeq ($(OS),EMSCRIPTEN)
+$(eval $(call gb_Helper_register_libraries_for_install,OOOLIBS,ooo, \
+   lo-bootstrap \
+))
+endif
+
 ifneq ($(ENABLE_WASM_STRIP_CANVAS),TRUE)
 $(eval $(call gb_Helper_register_libraries_for_install,OOOLIBS,ooo, \
canvastools \
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 72fab196c38a..452ae0b60a64 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -34,6 +34,10 @@
 #include 
 #endif
 
+#ifdef EMSCRIPTEN
+#include 
+#endif
+
 #include 
 #include 
 #include 
@@ -7534,10 +7538,8 @@ static int lo_initialize(LibreOfficeKit* pThis, const 
char* pAppPath, const char
 }
 else
 {
-#ifdef ANDROID
+#if defined ANDROID || defined EMSCRIPTEN
 aAppPath = OUString::fromUtf8(lo_get_app_data_dir()) + "/program";
-#elif defined __EMSCRIPTEN__
-aAppPath = OUString::fromUtf8("instdir/program");
 #else
 // Fun conversion dance back and forth between URLs and system paths...
 OUString aAppURL;
diff --git a/i18nlangtag/source/languagetag/languagetag.cxx 
b/i18nlangtag/source/languagetag/languagetag.cxx
index 92b9b5807e99..b54c2614e7f2 100644
--- a/i18nlangtag/source/languagetag/languagetag.cxx
+++ b/i18nlangtag/source/languagetag/languagetag.cxx
@@ -36,6 +36,10 @@
 #include 
 #endif
 
+#ifdef EMSCRIPTEN
+#include 
+#endif
+
 using namespace com::sun::star;
 
 namespace {
@@ -215,7 +219,7 @@ void LiblangtagDataRef::teardown()
 
 void LiblangtagDataRef::setupDataPath()
 {
-#if defined(ANDROID)
+#if defined(ANDROID) || defined(EMSCRIPTEN)
 maDataPath = OString(lo_get_app_data_dir()) + "/share/liblangtag";
 #else
 // maDataPath is assumed to be empty here.
diff --git a/include/osl/detail/emscripten-bootstrap.h 
b/include/osl/detail/emscripten-bootstrap.h
new file mode 100644
index ..580964253377
--- /dev/null
+++ b/include/osl/detail/emscripten-bootstrap.h
@@ -0,0 +1,26 @@
+/* -*- Mode: C; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#pragma once
+
+#if defined(EMSCRIPTEN)
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+const char *lo_get_app_data_dir(void);
+
+#ifdef __cplusplus
+}
+#endif
+
+#endif // EMSCRIPTEN
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sal/Library_lo-bootstrap.mk b/sal/Library_lo-bootstrap.mk
index 3dc4bf9dfeaa..1e727cdee427 100644
--- a/sal/Library_lo-bootstrap.mk
+++ b/sal/Library_lo-bootstrap.mk
@@ -10,6 +10,8 @@
 
 $(eval $(call gb_Library_Library,lo-bootstrap))
 
+ifeq (ANDROID,$(OS))
+
 # We explicitly *don't* want gb_STDLIBS to be linked here
 $(eval $(call gb_Library_disable_standard_system_libs,lo-bootstrap))
 
@@ -22,6 +24,13 @@ $(eval $(call gb_Library_add_cobjects,lo-bootstrap,\
sal/android/libreofficekit-jni \
sal/android/lo-bootstrap \
 ))
+endif
+
+ifeq (EMSCRIPTEN,$(OS))
+$(eval $(call gb_Library_add_cobjects,lo-bootstrap,\
+   sal/emscripten/lo-bootstrap \
+))
+endif
 
 $(eval $(call gb_Library_set_include,lo-bootstrap,\
$$(INCLUDE) \
diff --git a/sal/Library_sal.mk b/sal/Library_sal.mk

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - desktop/source include/LibreOfficeKit

2023-02-23 Thread Tor Lillqvist (via logerrit)
 desktop/source/lib/init.cxx |   10 ++
 include/LibreOfficeKit/LibreOfficeKitInit.h |4 ++--
 2 files changed, 8 insertions(+), 6 deletions(-)

New commits:
commit 9b59231edf524e359ae5bb92517c9f9a98b86030
Author: Tor Lillqvist 
AuthorDate: Mon Dec 12 17:59:30 2022 +0200
Commit: Tor Lillqvist 
CommitDate: Fri Feb 24 07:54:12 2023 +

Attempt to add ifdefs for WASM (Emscripten) for LOKit-based code

Change-Id: I5b2556d1be61fa3a1d7996ce8d61958fbe7984c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144002
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147557
Tested-by: Tor Lillqvist 

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 399a42159cc3..72fab196c38a 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -7142,7 +7142,7 @@ static void lo_runLoop(LibreOfficeKit* /*pThis*/,
LibreOfficeKitWakeCallback pWakeCallback,
void* pData)
 {
-#if defined(IOS) || defined(ANDROID)
+#if defined(IOS) || defined(ANDROID) || defined(__EMSCRIPTEN__)
 Application::GetSolarMutex().acquire();
 #endif
 
@@ -7153,7 +7153,7 @@ static void lo_runLoop(LibreOfficeKit* /*pThis*/,
 Application::UpdateMainThread();
 soffice_main();
 }
-#if defined(IOS) || defined(ANDROID)
+#if defined(IOS) || defined(ANDROID) || defined(__EMSCRIPTEN__)
 vcl::lok::unregisterPollCallbacks();
 Application::ReleaseSolarMutex();
 #endif
@@ -7536,6 +7536,8 @@ static int lo_initialize(LibreOfficeKit* pThis, const 
char* pAppPath, const char
 {
 #ifdef ANDROID
 aAppPath = OUString::fromUtf8(lo_get_app_data_dir()) + "/program";
+#elif defined __EMSCRIPTEN__
+aAppPath = OUString::fromUtf8("instdir/program");
 #else
 // Fun conversion dance back and forth between URLs and system paths...
 OUString aAppURL;
@@ -7732,8 +7734,8 @@ static int lo_initialize(LibreOfficeKit* pThis, const 
char* pAppPath, const char
 comphelper::ThreadPool::getSharedOptimalPool().shutdown();
 }
 
-// Turn off quick editing on IOS and ANDROID
-#if defined IOS || defined ANDROID
+// Turn off quick editing on iOS, Android and Emscripten
+#if defined IOS || defined ANDROID || defined __EMSCRIPTEN__
 if (officecfg::Office::Impress::Misc::TextObject::QuickEditing::get())
 {
 std::shared_ptr 
batch(comphelper::ConfigurationChanges::create());
diff --git a/include/LibreOfficeKit/LibreOfficeKitInit.h 
b/include/LibreOfficeKit/LibreOfficeKitInit.h
index 08feb42c1e18..506f373c5108 100644
--- a/include/LibreOfficeKit/LibreOfficeKitInit.h
+++ b/include/LibreOfficeKit/LibreOfficeKitInit.h
@@ -259,13 +259,13 @@ typedef int (LokHookPreInit)  ( const char 
*install_path, const char
 
 typedef int (LokHookPreInit2) ( const char *install_path, const 
char *user_profile_url, LibreOfficeKit** kit);
 
-#if defined(IOS) || defined(ANDROID)
+#if defined(IOS) || defined(ANDROID) || defined(__EMSCRIPTEN__)
 LibreOfficeKit *libreofficekit_hook_2(const char* install_path, const char* 
user_profile_path);
 #endif
 
 static LibreOfficeKit *lok_init_2( const char *install_path,  const char 
*user_profile_url )
 {
-#if !defined(IOS) && !defined(ANDROID)
+#if !defined(IOS) && !defined(ANDROID) && !defined(__EMSCRIPTEN__)
 void *dlhandle;
 char *imp_lib;
 LokHookFunction *pSym;


[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - desktop/qa desktop/source include/LibreOfficeKit

2023-02-23 Thread Tor Lillqvist (via logerrit)
 desktop/qa/desktop_lib/test_desktop_lib.cxx |   16 ++
 desktop/source/lib/init.cxx |  175 
 include/LibreOfficeKit/LibreOfficeKit.h |   10 +
 include/LibreOfficeKit/LibreOfficeKit.hxx   |   10 +
 4 files changed, 208 insertions(+), 3 deletions(-)

New commits:
commit ac1de680ae7f7d3ac71b73d3ebf2311a7f9e5451
Author: Tor Lillqvist 
AuthorDate: Tue Feb 21 13:19:42 2023 +0200
Commit: Tor Lillqvist 
CommitDate: Fri Feb 24 07:52:53 2023 +

Extend LOKit API with functionality to extract a request and paint 
thumbnails

Original author was Mert Tümer.

Change-Id: I181a9955bcce1d5ee4c81e2a52445ef318dc4823
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147432
Tested-by: Tor Lillqvist 
Reviewed-by: Tor Lillqvist 

diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx 
b/desktop/qa/desktop_lib/test_desktop_lib.cxx
index 3908829f1918..4348da15a68b 100644
--- a/desktop/qa/desktop_lib/test_desktop_lib.cxx
+++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx
@@ -3554,6 +3554,15 @@ void DesktopLOKTest::testABI()
 CPPUNIT_ASSERT_EQUAL(classOffset(9), offsetof(struct _LibreOfficeKitClass, 
getVersionInfo));
 CPPUNIT_ASSERT_EQUAL(classOffset(10), offsetof(struct 
_LibreOfficeKitClass, runMacro));
 CPPUNIT_ASSERT_EQUAL(classOffset(11), offsetof(struct 
_LibreOfficeKitClass, signDocument));
+CPPUNIT_ASSERT_EQUAL(classOffset(12), offsetof(struct 
_LibreOfficeKitClass, runLoop));
+CPPUNIT_ASSERT_EQUAL(classOffset(13), offsetof(struct 
_LibreOfficeKitClass, sendDialogEvent));
+CPPUNIT_ASSERT_EQUAL(classOffset(14), offsetof(struct 
_LibreOfficeKitClass, setOption));
+CPPUNIT_ASSERT_EQUAL(classOffset(15), offsetof(struct 
_LibreOfficeKitClass, dumpState));
+CPPUNIT_ASSERT_EQUAL(classOffset(16), offsetof(struct 
_LibreOfficeKitClass, extractRequest));
+
+// When extending LibreOfficeKit with a new function pointer,  add new 
assert for the offsetof the
+// new function pointer and bump this assert for the size of the class.
+CPPUNIT_ASSERT_EQUAL(classOffset(17), sizeof(struct _LibreOfficeKitClass));
 
 CPPUNIT_ASSERT_EQUAL(documentClassOffset(0), offsetof(struct 
_LibreOfficeKitDocumentClass, destroy));
 CPPUNIT_ASSERT_EQUAL(documentClassOffset(1), offsetof(struct 
_LibreOfficeKitDocumentClass, saveAs));
@@ -3631,10 +3640,11 @@ void DesktopLOKTest::testABI()
 CPPUNIT_ASSERT_EQUAL(documentClassOffset(67), offsetof(struct 
_LibreOfficeKitDocumentClass, getEditMode));
 CPPUNIT_ASSERT_EQUAL(documentClassOffset(68),
  offsetof(struct _LibreOfficeKitDocumentClass, 
setViewTimezone));
+CPPUNIT_ASSERT_EQUAL(documentClassOffset(69), offsetof(struct 
_LibreOfficeKitDocumentClass, paintThumbnail));
+
 
-// Extending is fine, update this, and add new assert for the offsetof the
-// new method
-CPPUNIT_ASSERT_EQUAL(documentClassOffset(69), sizeof(struct 
_LibreOfficeKitDocumentClass));
+// As above
+CPPUNIT_ASSERT_EQUAL(documentClassOffset(70), sizeof(struct 
_LibreOfficeKitDocumentClass));
 }
 
 CPPUNIT_TEST_SUITE_REGISTRATION(DesktopLOKTest);
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index d0e899b124f4..399a42159cc3 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -63,6 +63,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -175,6 +176,7 @@
 // Needed for getUndoManager()
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -395,6 +397,97 @@ std::vector 
desktop::jsonToPropertyValuesVector(const char
 return aArguments;
 }
 
+static bool extractLinks(const uno::Reference< container::XNameAccess >& 
xLinks, bool subcontent, OUStringBuffer& jsonText)
+{
+const uno::Sequence< OUString > aNames( xLinks->getElementNames() );
+
+const sal_uLong nLinks = aNames.getLength();
+const OUString* pNames = aNames.getConstArray();
+const OUString aProp_LinkDisplayName( "LinkDisplayName" );
+const OUString aProp_LinkTarget( "com.sun.star.document.LinkTarget" );
+bool bIsTarget = false;
+for( sal_uLong i = 0; i < nLinks; i++ )
+{
+uno::Any aAny;
+OUString aLink( *pNames++ );
+
+bool bError = false;
+try
+{
+aAny = xLinks->getByName( aLink );
+}
+catch(const uno::Exception&)
+{
+// if the name of the target was invalid (like empty headings)
+// no object can be provided
+bError = true;
+}
+if(bError)
+continue;
+
+uno::Reference< beans::XPropertySet > xTarget;
+if( aAny >>= xTarget )
+{
+try
+{
+// get name to display
+aAny = xTarget->getPropertyValue( aProp_LinkDisplayName );
+OUString aDisplayName;
+aAny >>= aDisplayName;
+OUString aStrDisplayname ( 

[Libreoffice-bugs] [Bug 151253] [UI] drag-and-drop handles in sub-toolbar dropdowns look bad in KF5 and QT5

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151253

--- Comment #4 from Heiko Tietze  ---
(In reply to Stéphane Guillou (stragu) from comment #3)
> Heiko, what are your thoughts on the odd look for KF5 and QT5? Some kind of
> implementation error?

The big white bar is there for me with gtk3 too (gtk4 does not expand the
widget), qt5 and qt6. It is white independent from dark/light system theme. The
fact that it look particular awkward on qt5 results from the double line
indicator.

I could imagine that making it transparent solves the problem. Maybe we need to
ensure the visibility of the drag handler, currently black lines on white
background.

(In reply to Stéphane Guillou (stragu) from comment #3)
> Bibisected to f9da0b8d72753664d9fb342db244d8014515ea43... 
> Resolves tdf#143688 - Allow detaching of sub-toolbars when locked

The widgets were always the same AFAIR. The mentioned patch is unrelated and
just made these floating widgets detachable even when the parent toolbar is
locked.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/inc sw/source

2023-02-23 Thread Bjoern Michaelsen (via logerrit)
 sw/inc/IDocumentFieldsAccess.hxx |3 ++-
 sw/source/core/doc/DocumentFieldsManager.cxx |   12 +++-
 sw/source/core/inc/DocumentFieldsManager.hxx |2 +-
 sw/source/core/layout/newfrm.cxx |3 +--
 sw/source/core/layout/pagechg.cxx|9 +++--
 sw/source/core/layout/tabfrm.cxx |3 +--
 sw/source/core/layout/wsfrm.cxx  |3 +--
 sw/source/core/view/viewsh.cxx   |3 +--
 8 files changed, 17 insertions(+), 21 deletions(-)

New commits:
commit b4b3f281443fc64b420156eed11af773f80a4e2a
Author: Bjoern Michaelsen 
AuthorDate: Sun Feb 19 17:45:41 2023 +0100
Commit: Bjoern Michaelsen 
CommitDate: Fri Feb 24 07:33:59 2023 +

Use just plain straight-forward params for UpdatePageFields

- dont wrap parameters in a useless hint as superfluous indirection
- note: SwDocPosUpdate receives a special kind of abuse here:
  * it is used as pNew with pOld being nullptr when send to the
document field manager
  * it is sneakily modified to be the pOld when it is forwarded by
the field to the frame via the node
- full path of the message before this change:
  -> passed to the UpdatePageFields as parameter
  -> wrapped as the pNew there and send to the field types
  -> passed by the fieldtypes to the fields
  -> tweaked to be the pOld with pNew being the field itselfby the
 fields when passed from the field to the node
  -> passed from the node to the frames

Change-Id: I084c3a1abe6871abdb82655cc413902dd16071cf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147302
Tested-by: Jenkins
Reviewed-by: Bjoern Michaelsen 

diff --git a/sw/inc/IDocumentFieldsAccess.hxx b/sw/inc/IDocumentFieldsAccess.hxx
index ee3e2536b921..c31e6a646ed0 100644
--- a/sw/inc/IDocumentFieldsAccess.hxx
+++ b/sw/inc/IDocumentFieldsAccess.hxx
@@ -23,6 +23,7 @@
 
 #include 
 #include 
+#include "swtypes.hxx"
 #include "nodeoffset.hxx"
 
 class SwFieldTypes;
@@ -100,7 +101,7 @@ namespace com::sun::star::uno { class Any; }
 
 virtual void UpdateUsrFields() = 0;
 
-virtual void UpdatePageFields(SfxPoolItem*) = 0;
+virtual void UpdatePageFields(const SwTwips) = 0;
 
 virtual void LockExpFields() = 0;
 
diff --git a/sw/source/core/doc/DocumentFieldsManager.cxx 
b/sw/source/core/doc/DocumentFieldsManager.cxx
index 79852fa52ce0..4d6486bca262 100644
--- a/sw/source/core/doc/DocumentFieldsManager.cxx
+++ b/sw/source/core/doc/DocumentFieldsManager.cxx
@@ -1335,18 +1335,20 @@ sal_Int32 
DocumentFieldsManager::GetRecordsPerDocument() const
 return nRecords;
 }
 
-void DocumentFieldsManager::UpdatePageFields( SfxPoolItem* pMsgHint )
+void DocumentFieldsManager::UpdatePageFields(const SwTwips nDocPos)
 {
-for( SwFieldTypes::size_type i = 0; i < INIT_FLDTYPES; ++i )
+SwDocPosUpdate aDosPosUpdate(nDocPos);
+sw::LegacyModifyHint aHint(nullptr, );
+for(SwFieldTypes::size_type i = 0; i < INIT_FLDTYPES; ++i)
 {
-SwFieldType* pFieldType = (*mpFieldTypes)[ i ].get();
-switch( pFieldType->Which() )
+SwFieldType* pFieldType = (*mpFieldTypes)[i].get();
+switch(pFieldType->Which())
 {
 case SwFieldIds::PageNumber:
 case SwFieldIds::Chapter:
 case SwFieldIds::GetExp:
 case SwFieldIds::RefPageGet:
-pFieldType->CallSwClientNotify(sw::LegacyModifyHint(nullptr, 
pMsgHint));
+pFieldType->CallSwClientNotify(aHint);
 break;
 case SwFieldIds::DocStat:
 pFieldType->CallSwClientNotify(sw::LegacyModifyHint(nullptr, 
nullptr));
diff --git a/sw/source/core/inc/DocumentFieldsManager.hxx 
b/sw/source/core/inc/DocumentFieldsManager.hxx
index 2b661604b8de..0f1aede584cb 100644
--- a/sw/source/core/inc/DocumentFieldsManager.hxx
+++ b/sw/source/core/inc/DocumentFieldsManager.hxx
@@ -48,7 +48,7 @@ public:
 virtual void UpdateTableFields(SfxPoolItem* pHt) override;
 virtual void UpdateExpFields(SwTextField* pField, bool bUpdateRefFields) 
override;
 virtual void UpdateUsrFields() override;
-virtual void UpdatePageFields(SfxPoolItem*) override;
+virtual void UpdatePageFields(const SwTwips) override;
 virtual void LockExpFields() override;
 virtual void UnlockExpFields() override;
 virtual bool IsExpFieldsLocked() const override;
diff --git a/sw/source/core/layout/newfrm.cxx b/sw/source/core/layout/newfrm.cxx
index 5ca11e34138b..95af08baa6e3 100644
--- a/sw/source/core/layout/newfrm.cxx
+++ b/sw/source/core/layout/newfrm.cxx
@@ -512,8 +512,7 @@ void SwRootFrame::Init( SwFrameFormat* pFormat )
 //b6433357: Update page fields after loading
 if ( !mpCurrShell || !mpCurrShell->Imp()->IsUpdateExpFields() )
 {
-SwDocPosUpdate aMsgHint( pPage->getFrameArea().Top() );
-rFieldsAccess.UpdatePageFields(  );
+rFieldsAccess.UpdatePageFields(pPage->getFrameArea().Top());
 }
 
 

[Libreoffice-bugs] [Bug 78510] FILEOPEN: MSO ODT - Bullet points in wrong location

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=78510

--- Comment #14 from Commit Notification 
 ---
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/db115bec9254417ef7a3faf687478fe5424ab378

tdf#78510 sw,cui: split SvxLRSpaceItem for SwTextNode, SwTextFormatColl

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 78510] FILEOPEN: MSO ODT - Bullet points in wrong location

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=78510

--- Comment #15 from Commit Notification 
 ---
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0168e1eb65103afde24d4a2a62175946b1c0d33e

tdf#78510 sw: combine items from SwTextNode and SwNumFormat

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 78510] FILEOPEN: MSO ODT - Bullet points in wrong location

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=78510

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|odf |odf target:7.6.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/inc sw/qa sw/source

2023-02-23 Thread Michael Stahl (via logerrit)
 sw/inc/fmtcol.hxx |3 
 sw/inc/ndtxt.hxx  |   10 -
 sw/inc/paratr.hxx |9 +
 sw/qa/extras/odfexport/data/WordTest_edit.odt |binary
 sw/qa/extras/odfexport/odfexport2.cxx |  163 ++
 sw/source/core/doc/docfmt.cxx |   13 +-
 sw/source/core/doc/fmtcol.cxx |   20 ++-
 sw/source/core/layout/frmtool.cxx |1 
 sw/source/core/text/itrcrsr.cxx   |   10 -
 sw/source/core/txtnode/ndtxt.cxx  |   94 ++
 sw/source/core/txtnode/thints.cxx |   17 +-
 sw/source/filter/ww8/wrtw8nds.cxx |   14 +-
 sw/source/filter/ww8/ww8par6.cxx  |3 
 sw/source/uibase/app/docstyle.cxx |   17 +-
 14 files changed, 312 insertions(+), 62 deletions(-)

New commits:
commit 0168e1eb65103afde24d4a2a62175946b1c0d33e
Author: Michael Stahl 
AuthorDate: Thu Feb 16 19:39:33 2023 +0100
Commit: Michael Stahl 
CommitDate: Fri Feb 24 07:32:30 2023 +

tdf#78510 sw: combine items from SwTextNode and SwNumFormat

Tweak SwTextFormatColl::AreListLevelIndentsApplicable() and
SwTextNode::AreListLevelIndentsApplicable() to return a bitmask
so that SvxFirstLineIndentItem and SvxTextLeftMarginItem from paragraph
or numbering can be freely combined.

Particularly confusing was SwTextNode::GetLeftMarginWithNum()
and its baffling usage in SwTextMargin::CtorInitTextMargin(); it
appears easiest (if unintuitive) to interpret its return value as a
delta to be added to the paragraph's items.

This fixes the ODF interop problem.

It looks like no compat setting is needed because every OOo/LO generated
document should have either both fo:text-indent and fo:margin-left on a
paragraph style/list level, or neither.

Change-Id: If20b2556bb5ab5d915a2aa6633525bb44a9be33b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147166
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/sw/inc/fmtcol.hxx b/sw/inc/fmtcol.hxx
index 6a477e1f5ca3..c914a6058ccf 100644
--- a/sw/inc/fmtcol.hxx
+++ b/sw/inc/fmtcol.hxx
@@ -143,7 +143,8 @@ public:
 return mbStayAssignedToListLevelOfOutlineStyle;
 }
 
-bool AreListLevelIndentsApplicable() const;
+::sw::ListLevelIndents AreListLevelIndentsApplicable() const;
+bool AreListLevelIndentsApplicableImpl(sal_uInt16 nWhich) const;
 
 void dumpAsXml(xmlTextWriterPtr pWriter) const;
 virtual void FormatDropNotify(const SwFormatDrop& rDrop) override
diff --git a/sw/inc/ndtxt.hxx b/sw/inc/ndtxt.hxx
index 0ea123233d69..4b15545b41bc 100644
--- a/sw/inc/ndtxt.hxx
+++ b/sw/inc/ndtxt.hxx
@@ -516,9 +516,10 @@ public:
 /**
Returns the additional indents of this text node and its numbering.
 
-   @param bTextLeft  ???
+   @param bTextLeft return text-left-margin instead of left-margin
+(include negative first-line-indent, see lrspitem.hxx)
 
-   @return additional indents
+   @return additional num indents - a delta to be added to node's items
  */
  tools::Long GetLeftMarginWithNum( bool bTextLeft = false ) const;
 
@@ -693,9 +694,10 @@ public:
   style hierarchy from the paragraph to the paragraph style with the
   list style no indent attributes are found.
 
-@return boolean
+@return bitmask
 */
-bool AreListLevelIndentsApplicable() const;
+::sw::ListLevelIndents AreListLevelIndentsApplicable() const;
+bool AreListLevelIndentsApplicableImpl(sal_uInt16 nWhich) const;
 
 /** Retrieves the list tab stop position, if the paragraph's list level 
defines
 one and this list tab stop has to merged into the tap stops of the 
paragraph
diff --git a/sw/inc/paratr.hxx b/sw/inc/paratr.hxx
index c6848491f8e9..9b5f2b156430 100644
--- a/sw/inc/paratr.hxx
+++ b/sw/inc/paratr.hxx
@@ -38,6 +38,7 @@
 #include 
 #include 
 #include 
+#include 
 
 class SwTextNode;
 class IntlWrapper;
@@ -47,6 +48,9 @@ class IntlWrapper;
 class SwFormatDrop;
 
 namespace sw {
+
+enum class ListLevelIndents { No, FirstLine, LeftMargin };
+
 class SW_DLLPUBLIC FormatDropDefiner {
 protected:
 virtual ~FormatDropDefiner() {};
@@ -55,6 +59,11 @@ namespace sw {
 };
 }
 
+namespace o3tl
+{
+template<> struct typed_flags : 
is_typed_flags {};
+}
+
 /** If SwFormatDrop is a Client, it is the CharFormat that describes the font 
for the
DropCaps. If it is not a Client, formatting uses the CharFormat of the 
paragraph.
If the CharFormat is modified, this change is propagated to the paragraphs
diff --git a/sw/qa/extras/odfexport/data/WordTest_edit.odt 
b/sw/qa/extras/odfexport/data/WordTest_edit.odt
new file mode 100644
index ..4c14295e930d
Binary files /dev/null and b/sw/qa/extras/odfexport/data/WordTest_edit.odt 
differ
diff --git 

[Libreoffice-commits] core.git: 2 commits - cui/source editeng/source include/editeng sw/inc sw/qa sw/source

2023-02-23 Thread Michael Stahl (via logerrit)
 cui/source/inc/paragrph.hxx |3 
 cui/source/tabpages/paragrph.cxx|  230 +
 editeng/source/items/frmitems.cxx   |  953 
 include/editeng/lrspitem.hxx|  256 ++
 sw/inc/format.hxx   |6 
 sw/inc/frmatr.hxx   |   24 
 sw/inc/hintids.hxx  |  185 ++--
 sw/inc/ndtxt.hxx|7 
 sw/inc/swatrset.hxx |   12 
 sw/qa/extras/uiwriter/uiwriter2.cxx |   12 
 sw/source/core/access/accpara.cxx   |7 
 sw/source/core/attr/BorderCacheOwner.cxx|3 
 sw/source/core/bastyp/init.cxx  |   12 
 sw/source/core/crsr/crstrvl.cxx |   13 
 sw/source/core/doc/DocumentStylePoolManager.cxx |  112 +-
 sw/source/core/doc/dbgoutsw.cxx |6 
 sw/source/core/doc/docfmt.cxx   |   14 
 sw/source/core/doc/docnum.cxx   |   10 
 sw/source/core/doc/fmtcol.cxx   |   90 +-
 sw/source/core/edit/autofmt.cxx |   38 
 sw/source/core/inc/frmtool.hxx  |4 
 sw/source/core/layout/fly.cxx   |   11 
 sw/source/core/layout/frmtool.cxx   |   45 -
 sw/source/core/layout/wsfrm.cxx |6 
 sw/source/core/text/EnhancedPDFExportHelper.cxx |6 
 sw/source/core/text/frmcrsr.cxx |   10 
 sw/source/core/text/frmpaint.cxx|   10 
 sw/source/core/text/itratr.cxx  |   11 
 sw/source/core/text/itrcrsr.cxx |   13 
 sw/source/core/text/porfld.cxx  |2 
 sw/source/core/text/porrst.cxx  |4 
 sw/source/core/text/txtfrm.cxx  |2 
 sw/source/core/tox/ToxTabStopTokenHandler.cxx   |   18 
 sw/source/core/txtnode/ndtxt.cxx|   37 
 sw/source/core/txtnode/thints.cxx   |8 
 sw/source/core/unocore/unomapproperties.hxx |   28 
 sw/source/core/unocore/unosrch.cxx  |   12 
 sw/source/filter/html/css1atr.cxx   |   70 +
 sw/source/filter/html/htmlatr.cxx   |   50 -
 sw/source/filter/html/htmlcss1.cxx  |   97 +-
 sw/source/filter/html/htmlctxt.cxx  |   62 +
 sw/source/filter/html/htmldrawreader.cxx|   17 
 sw/source/filter/html/htmlflywriter.cxx |8 
 sw/source/filter/html/htmlform.cxx  |   17 
 sw/source/filter/html/htmlnumreader.cxx |4 
 sw/source/filter/html/htmlplug.cxx  |   17 
 sw/source/filter/html/svxcss1.cxx   |  105 --
 sw/source/filter/html/swhtml.cxx|  125 ++-
 sw/source/filter/html/swhtml.hxx|4 
 sw/source/filter/html/wrthtml.cxx   |2 
 sw/source/filter/ww8/attributeoutputbase.hxx|7 
 sw/source/filter/ww8/docxattributeoutput.cxx|   94 +-
 sw/source/filter/ww8/docxattributeoutput.hxx|8 
 sw/source/filter/ww8/rtfattributeoutput.cxx |   42 -
 sw/source/filter/ww8/rtfattributeoutput.hxx |7 
 sw/source/filter/ww8/wrtw8nds.cxx   |   47 -
 sw/source/filter/ww8/ww8atr.cxx |   81 +-
 sw/source/filter/ww8/ww8attributeoutput.hxx |7 
 sw/source/filter/ww8/ww8par.cxx |   90 +-
 sw/source/filter/ww8/ww8par.hxx |   11 
 sw/source/filter/ww8/ww8par2.cxx|   10 
 sw/source/filter/ww8/ww8par3.cxx|   73 +
 sw/source/filter/ww8/ww8par6.cxx|   55 -
 sw/source/filter/xml/xmlexpit.cxx   |5 
 sw/source/filter/xml/xmlimpit.cxx   |8 
 sw/source/filter/xml/xmlitemm.cxx   |1 
 sw/source/ui/envelp/envfmt.cxx  |5 
 sw/source/uibase/app/docstyle.cxx   |   21 
 sw/source/uibase/shells/textsh1.cxx |   16 
 sw/source/uibase/shells/txtattr.cxx |   13 
 sw/source/uibase/uiview/viewsrch.cxx|3 
 sw/source/uibase/uiview/viewtab.cxx |   77 +
 sw/source/uibase/wrtsh/delete.cxx   |   22 
 73 files changed, 2814 insertions(+), 687 deletions(-)

New commits:
commit db115bec9254417ef7a3faf687478fe5424ab378
Author: Michael Stahl 
AuthorDate: Tue Feb 14 18:03:55 2023 +0100
Commit: Michael Stahl 
CommitDate: Fri Feb 24 07:32:23 2023 +

tdf#78510 sw,cui: split SvxLRSpaceItem for SwTextNode, SwTextFormatColl

Leave editengine and non-paragraph usages of SvxLRSpaceItem as-is for now.

Add new items RES_MARGIN_LEFT etc., order them so that paragraphs can
have 3 consecutive items RES_MARGIN_FIRSTLINE..RES_MARGIN_RIGHT and
non-paragraphs also have 2-4 consecutive items
RES_MARGIN_RIGHT..RES_MARGIN_LEFT (only the 3 paragraph ones are
actually used now).

The HTML import filter is particularly annoying 

[Libreoffice-bugs] [Bug 153784] Changing inputwin of Formula bar height / line count

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153784

Heiko Tietze  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org
   Keywords|needsUXEval |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 153784] Changing inputwin of Formula bar height / line count

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153784

Heiko Tietze  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org
   Keywords|needsUXEval |

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 31481] [RFE] Split pane in same window for side-by-side proof reading/ translating of 2 different files

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=31481

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||3509

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 53895] Distraction-free writing extension or functionality (UI)

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=53895

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||j.a.sw...@gmail.com

--- Comment #7 from Stéphane Guillou (stragu) 
 ---
*** Bug 153509 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153509] Offer easy-to-invoke split screens with a minimally visible user interface in Writer, using already existing LO functionality

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153509

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=31
   ||481
 Resolution|--- |DUPLICATE
 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #3 from Stéphane Guillou (stragu) 
 ---
In summary, it would be a combination of a "distraction-free" mode (like some
writing applications have, to entirely focus on the content and rely on a
handful of needed shortcuts) and a split-window feature.

The most "distraction-free" we have currently is the fullscreen view, but we
can't use two views side-by-side. The most minimal built-in UIs we have are
"single toolbar" and "contextual single".

To get what you want, I think we already have the relevant enhancement requests
open:

- Split window is requested in bug 31481
- Distraction-free mode is requested in bug 53895

Given that there already is the workaround you described, and existing
enhancement requests that would cover your use-case, I don't think it makes
sense to keep this open.
Most effort is in removing the UI elements, so I'm marking this as a duplicate
of bug 53895.

Unless this can be turned into a request for an extra "Minimal" UI choice in
View > User Interface, which wouldn't apply exclusively to Writer?

*** This bug has been marked as a duplicate of bug 53895 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133541] Image Control seems to be the wrong label for a control, which could also select all files

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133541

--- Comment #6 from Robert Großkopf  ---
Still the same: The control is called "Image control", but you could also could
select other files. It would be better to show this possibility, because it is
a good feature we hide at this moment.

Tested with LO 7.4.5.1 on OpenSUSE 15.3 64bit rpm Linux.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153606] macOS app icon is not properly integrated

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153606

--- Comment #32 from Heiko Tietze  ---
Taking the screenshot from c28 you could argue that we still "squircle" the
symbol. All edges are round except the pointy paper clip. And compare this with
the XCode icon (blue with a hammer).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: 2 commits - slideshow/source svx/inc

2023-02-23 Thread Noel Grandin (via logerrit)
 slideshow/source/engine/eventmultiplexer.cxx |   22 +-
 svx/inc/AccessibleTableShape.hxx |3 +--
 2 files changed, 10 insertions(+), 15 deletions(-)

New commits:
commit afdee56418182b7250eb61269dd26cbacc56f87f
Author: Noel Grandin 
AuthorDate: Thu Feb 23 15:44:16 2023 +0200
Commit: Noel Grandin 
CommitDate: Fri Feb 24 07:13:01 2023 +

BaseMutex in AccessibleTableHeaderShape is unused

Change-Id: I1ec01aa72446891aaacd9309ea6c67cc323b0d32
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147588
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/svx/inc/AccessibleTableShape.hxx b/svx/inc/AccessibleTableShape.hxx
index 12d7756e924b..1a13ec36e610 100644
--- a/svx/inc/AccessibleTableShape.hxx
+++ b/svx/inc/AccessibleTableShape.hxx
@@ -142,8 +142,7 @@ typedef ::cppu::WeakImplHelper<
 css::accessibility::XAccessibleTableSelection >
 AccessibleTableHeaderShape_BASE;
 
-class AccessibleTableHeaderShape final : public cppu::BaseMutex,
-public AccessibleTableHeaderShape_BASE
+class AccessibleTableHeaderShape final : public AccessibleTableHeaderShape_BASE
 {
 public:
 // bRow, true means rowheader, false means columnheader
commit 336cebd61de9d2b0f07d246a772098d01c305c60
Author: Noel Grandin 
AuthorDate: Thu Feb 23 11:08:36 2023 +0200
Commit: Noel Grandin 
CommitDate: Fri Feb 24 07:12:50 2023 +

BaseMutex->std::mutex in slideshow::EventMultiplexerListener

Change-Id: Icdb38eb85a93cc285489372bbd80605bfcd36249
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147582
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/slideshow/source/engine/eventmultiplexer.cxx 
b/slideshow/source/engine/eventmultiplexer.cxx
index 022db58f8d3c..4921f6aff8fb 100644
--- a/slideshow/source/engine/eventmultiplexer.cxx
+++ b/slideshow/source/engine/eventmultiplexer.cxx
@@ -21,8 +21,7 @@
 #include 
 
 #include 
-#include 
-#include 
+#include 
 
 #include 
 #include 
@@ -161,7 +160,7 @@ public:
 
 }
 
-typedef cppu::WeakComponentImplHelper<
+typedef comphelper::WeakComponentImplHelper<
 awt::XMouseListener,
 awt::XMouseMotionListener > Listener_UnoBase;
 
@@ -173,13 +172,11 @@ namespace {
 XSlideViews, and passes on the events to the EventMultiplexer (via
 EventQueue indirection, to force the events into the main thread)
  */
-class EventMultiplexerListener : private cppu::BaseMutex,
- public Listener_UnoBase
+class EventMultiplexerListener : public Listener_UnoBase
 {
 public:
 EventMultiplexerListener( EventQueue&   rEventQueue,
   EventMultiplexerImpl& rEventMultiplexer ) :
-Listener_UnoBase( m_aMutex ),
 mpEventQueue(  ),
 mpEventMultiplexer(  )
 {
@@ -189,7 +186,7 @@ public:
 EventMultiplexerListener& operator=( const EventMultiplexerListener& ) = 
delete;
 
 // WeakComponentImplHelperBase::disposing
-virtual void SAL_CALL disposing() override;
+virtual void disposing(std::unique_lock& rGuard) override;
 
 private:
 virtual void SAL_CALL disposing( const lang::EventObject& Source ) 
override;
@@ -362,9 +359,8 @@ struct EventMultiplexerImpl
 };
 
 
-void SAL_CALL EventMultiplexerListener::disposing()
+void EventMultiplexerListener::disposing(std::unique_lock& 
/*rGuard*/)
 {
-osl::MutexGuard const guard( m_aMutex );
 mpEventQueue = nullptr;
 mpEventMultiplexer = nullptr;
 }
@@ -384,7 +380,7 @@ void SAL_CALL EventMultiplexerListener::disposing(
 void SAL_CALL EventMultiplexerListener::mousePressed(
 const awt::MouseEvent& e )
 {
-osl::MutexGuard const guard( m_aMutex );
+std::unique_lock const guard( m_aMutex );
 
 // notify mouse press. Don't call handlers directly, this
 // might not be the main thread!
@@ -399,7 +395,7 @@ void SAL_CALL EventMultiplexerListener::mousePressed(
 void SAL_CALL EventMultiplexerListener::mouseReleased(
 const awt::MouseEvent& e )
 {
-osl::MutexGuard const guard( m_aMutex );
+std::unique_lock const guard( m_aMutex );
 
 // notify mouse release. Don't call handlers directly,
 // this might not be the main thread!
@@ -427,7 +423,7 @@ void SAL_CALL EventMultiplexerListener::mouseExited(
 void SAL_CALL EventMultiplexerListener::mouseDragged(
 const awt::MouseEvent& e )
 {
-osl::MutexGuard const guard( m_aMutex );
+std::unique_lock const guard( m_aMutex );
 
 // notify mouse drag. Don't call handlers directly, this
 // might not be the main thread!
@@ -442,7 +438,7 @@ void SAL_CALL EventMultiplexerListener::mouseDragged(
 void SAL_CALL EventMultiplexerListener::mouseMoved(
 const awt::MouseEvent& e )
 {
-osl::MutexGuard const guard( m_aMutex );
+std::unique_lock const guard( m_aMutex );
 
 // notify mouse move. Don't call handlers directly, this
 // might not be the main thread!


[Libreoffice-commits] core.git: 2 commits - chart2/source filter/source

2023-02-23 Thread Noel Grandin (via logerrit)
 chart2/source/controller/chartapiwrapper/MinMaxLineWrapper.cxx |   10 
 chart2/source/controller/chartapiwrapper/MinMaxLineWrapper.hxx |9 
 filter/source/xsltdialog/xmlfilterdialogcomponent.cxx  |  102 
+-
 3 files changed, 26 insertions(+), 95 deletions(-)

New commits:
commit 8b31341d9382b62d99a4c1f801d63d031a47ffc3
Author: Noel Grandin 
AuthorDate: Thu Feb 23 11:05:40 2023 +0200
Commit: Noel Grandin 
CommitDate: Fri Feb 24 07:12:40 2023 +

BaseMutex->std::mutex in MinMaxLineWrapper

Change-Id: Ibd03c7f736e9b2fdf97a7b3177d7d12fd85394fa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147581
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/chart2/source/controller/chartapiwrapper/MinMaxLineWrapper.cxx 
b/chart2/source/controller/chartapiwrapper/MinMaxLineWrapper.cxx
index 3d61e81a371f..925c85834fa0 100644
--- a/chart2/source/controller/chartapiwrapper/MinMaxLineWrapper.cxx
+++ b/chart2/source/controller/chartapiwrapper/MinMaxLineWrapper.cxx
@@ -118,7 +118,6 @@ namespace chart::wrapper
 
 MinMaxLineWrapper::MinMaxLineWrapper(std::shared_ptr 
spChart2ModelContact)
 : m_spChart2ModelContact(std::move( spChart2ModelContact ))
-, m_aEventListenerContainer( m_aMutex )
 , m_aWrappedLineJointProperty( "LineJoint", uno::Any( 
drawing::LineJoint_NONE ))
 {
 }
@@ -130,20 +129,23 @@ MinMaxLineWrapper::~MinMaxLineWrapper()
 //  XComponent 
 void SAL_CALL MinMaxLineWrapper::dispose()
 {
+std::unique_lock g(m_aMutex);
 Reference< uno::XInterface > xSource( static_cast< ::cppu::OWeakObject* >( 
this ) );
-m_aEventListenerContainer.disposeAndClear( lang::EventObject( xSource ) );
+m_aEventListenerContainer.disposeAndClear( g, lang::EventObject( xSource ) 
);
 }
 
 void SAL_CALL MinMaxLineWrapper::addEventListener(
 const Reference< lang::XEventListener >& xListener )
 {
-m_aEventListenerContainer.addInterface( xListener );
+std::unique_lock g(m_aMutex);
+m_aEventListenerContainer.addInterface( g, xListener );
 }
 
 void SAL_CALL MinMaxLineWrapper::removeEventListener(
 const Reference< lang::XEventListener >& aListener )
 {
-m_aEventListenerContainer.removeInterface( aListener );
+std::unique_lock g(m_aMutex);
+m_aEventListenerContainer.removeInterface( g, aListener );
 }
 
 //XPropertySet
diff --git a/chart2/source/controller/chartapiwrapper/MinMaxLineWrapper.hxx 
b/chart2/source/controller/chartapiwrapper/MinMaxLineWrapper.hxx
index 3c5c9afdcb4c..337ca8bdebd7 100644
--- a/chart2/source/controller/chartapiwrapper/MinMaxLineWrapper.hxx
+++ b/chart2/source/controller/chartapiwrapper/MinMaxLineWrapper.hxx
@@ -19,9 +19,8 @@
 #pragma once
 
 #include 
-#include 
+#include 
 
-#include 
 #include 
 #include 
 #include 
@@ -37,8 +36,7 @@ namespace chart::wrapper
 
 class Chart2ModelContact;
 
-class MinMaxLineWrapper : public cppu::BaseMutex
-, public ::cppu::WeakImplHelper
+class MinMaxLineWrapper : public ::cppu::WeakImplHelper
 < css::lang::XComponent
 , css::lang::XServiceInfo
 , css::beans::XPropertySet
@@ -93,8 +91,9 @@ public:
 virtual css::uno::Sequence< css::uno::Any > SAL_CALL getPropertyDefaults( 
const css::uno::Sequence< OUString >& aPropertyNames ) override;
 
 private: //member
+std::mutex m_aMutex;
 std::shared_ptr< Chart2ModelContact >   m_spChart2ModelContact;
-::comphelper::OInterfaceContainerHelper3 
m_aEventListenerContainer;
+::comphelper::OInterfaceContainerHelper4 
m_aEventListenerContainer;
 
 WrappedIgnoreProperty   m_aWrappedLineJointProperty;
 };
commit ce32856bfe51ee844f6374ba2161eae821f9df61
Author: Noel Grandin 
AuthorDate: Thu Feb 23 10:33:51 2023 +0200
Commit: Noel Grandin 
CommitDate: Fri Feb 24 07:12:29 2023 +

drop OComponentHelper in XMLFilterDialogComponent

nothing seems to be using the aggregation here - as expected, this is
not the kind of thing that is aggregated

Change-Id: I8abc4f4db0dc9447e4018330bba86f3579bb21c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147503
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/filter/source/xsltdialog/xmlfilterdialogcomponent.cxx 
b/filter/source/xsltdialog/xmlfilterdialogcomponent.cxx
index 6f4b1db3453b..5cf047d07e41 100644
--- a/filter/source/xsltdialog/xmlfilterdialogcomponent.cxx
+++ b/filter/source/xsltdialog/xmlfilterdialogcomponent.cxx
@@ -17,11 +17,9 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include 
-
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
@@ -44,33 +42,19 @@ using namespace ::com::sun::star::frame;
 
 namespace {
 
-class XMLFilterDialogComponentBase
-{
-protected:
-::osl::Mutex maMutex;
-};
-
 
-class XMLFilterDialogComponent :public XMLFilterDialogComponentBase,
-public 

[Libreoffice-bugs] [Bug 153797] firstname field is accepting special characters in create new Facebook account

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153797

Julien Nabet  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153797] firstname field is accepting special characters in create new Facebook account

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153797

Julien Nabet  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|UNCONFIRMED |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/source

2023-02-23 Thread Miklos Vajna (via logerrit)
 sw/source/core/inc/rootfrm.hxx  |2 +
 sw/source/core/layout/wsfrm.cxx |   48 
 sw/source/core/text/xmldump.cxx |   48 
 3 files changed, 50 insertions(+), 48 deletions(-)

New commits:
commit 78a158211b68a020512cd63a1f357f901f879e53
Author: Miklos Vajna 
AuthorDate: Thu Feb 23 20:01:43 2023 +0100
Commit: Miklos Vajna 
CommitDate: Fri Feb 24 07:01:23 2023 +

sw layout xml dump: extract SwRootFrame::dumpAsXml() from SwFrame

Avoids an ugly static downcast.

Change-Id: I6c6d3bc224d584b3102da1ba3980c83b67521ce7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147578
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sw/source/core/inc/rootfrm.hxx b/sw/source/core/inc/rootfrm.hxx
index 32344bf0d9c0..2243759d4dda 100644
--- a/sw/source/core/inc/rootfrm.hxx
+++ b/sw/source/core/inc/rootfrm.hxx
@@ -426,6 +426,8 @@ public:
 void SetFieldmarkMode(sw::FieldmarkMode, sw::ParagraphBreakMode);
 sw::ParagraphBreakMode GetParagraphBreakMode() const { return 
m_ParagraphBreakMode; }
 bool HasMergedParas() const;
+
+void dumpAsXml(xmlTextWriterPtr writer = nullptr) const override;
 };
 
 inline tools::Long SwRootFrame::GetBrowseWidth() const
diff --git a/sw/source/core/layout/wsfrm.cxx b/sw/source/core/layout/wsfrm.cxx
index f753a993aceb..5a31c3c0a2d5 100644
--- a/sw/source/core/layout/wsfrm.cxx
+++ b/sw/source/core/layout/wsfrm.cxx
@@ -24,6 +24,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -63,6 +64,7 @@
 #include 
 #include 
 #include 
+#include 
 
 // RotateFlyFrame3
 #include 
@@ -4754,4 +4756,50 @@ bool SwRootFrame::HasMergedParas() const
 || GetParagraphBreakMode() == sw::ParagraphBreakMode::Hidden;
 }
 
+namespace {
+xmlTextWriterPtr lcl_createDefaultWriter()
+{
+xmlTextWriterPtr writer = xmlNewTextWriterFilename( "layout.xml", 0 );
+xmlTextWriterSetIndent(writer,1);
+(void)xmlTextWriterSetIndentString(writer, BAD_CAST("  "));
+(void)xmlTextWriterStartDocument( writer, nullptr, nullptr, nullptr );
+return writer;
+}
+
+void lcl_freeWriter( xmlTextWriterPtr writer )
+{
+(void)xmlTextWriterEndDocument( writer );
+xmlFreeTextWriter( writer );
+}
+}
+
+void SwRootFrame::dumpAsXml(xmlTextWriterPtr writer) const
+{
+bool bCreateWriter = (nullptr == writer);
+if (bCreateWriter)
+writer = lcl_createDefaultWriter();
+
+(void)xmlTextWriterStartElement(writer, reinterpret_cast("root"));
+dumpAsXmlAttributes(writer);
+
+(void)xmlTextWriterStartElement(writer, BAD_CAST("sfxViewShells"));
+SwView* pView = static_cast(SfxViewShell::GetFirst(true, 
checkSfxViewShell));
+while (pView)
+{
+if (GetCurrShell()->GetSfxViewShell() && pView->GetObjectShell() == 
GetCurrShell()->GetSfxViewShell()->GetObjectShell())
+pView->dumpAsXml(writer);
+pView = static_cast(SfxViewShell::GetNext(*pView, true, 
checkSfxViewShell));
+}
+(void)xmlTextWriterEndElement(writer);
+
+(void)xmlTextWriterStartElement(writer, BAD_CAST("infos"));
+dumpInfosAsXml(writer);
+(void)xmlTextWriterEndElement(writer);
+dumpChildrenAsXml(writer);
+(void)xmlTextWriterEndElement(writer);
+
+if (bCreateWriter)
+lcl_freeWriter(writer);
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/text/xmldump.cxx b/sw/source/core/text/xmldump.cxx
index 3fc64f1be7a2..f9f3f8a757eb 100644
--- a/sw/source/core/text/xmldump.cxx
+++ b/sw/source/core/text/xmldump.cxx
@@ -157,23 +157,6 @@ const char* sw::PortionTypeToString(PortionType nType)
 }
 }
 
-namespace {
-xmlTextWriterPtr lcl_createDefaultWriter()
-{
-xmlTextWriterPtr writer = xmlNewTextWriterFilename( "layout.xml", 0 );
-xmlTextWriterSetIndent(writer,1);
-(void)xmlTextWriterSetIndentString(writer, BAD_CAST("  "));
-(void)xmlTextWriterStartDocument( writer, nullptr, nullptr, nullptr );
-return writer;
-}
-
-void lcl_freeWriter( xmlTextWriterPtr writer )
-{
-(void)xmlTextWriterEndDocument( writer );
-xmlFreeTextWriter( writer );
-}
-}
-
 void SwFrame::dumpTopMostAsXml(xmlTextWriterPtr writer) const
 {
 const SwFrame* pFrame = this;
@@ -187,17 +170,10 @@ void SwFrame::dumpTopMostAsXml(xmlTextWriterPtr writer) 
const
 
 void SwFrame::dumpAsXml( xmlTextWriterPtr writer ) const
 {
-bool bCreateWriter = ( nullptr == writer );
-if ( bCreateWriter )
-writer = lcl_createDefaultWriter();
-
 const char *name = nullptr;
 
 switch ( GetType(  ) )
 {
-case SwFrameType::Root:
-name = "root";
-break;
 case SwFrameType::Page:
 name = "page";
 break;
@@ -249,20 +225,6 @@ void SwFrame::dumpAsXml( xmlTextWriterPtr writer ) const
 
 dumpAsXmlAttributes( writer );
 
-

[Libreoffice-bugs] [Bug 152033] Memory leakage when using Writer

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152033

--- Comment #5 from James Sheehan  ---
Apparently, as you suggested, this is a special Windows bug. I booted up my
Linux Mint (20.3) machine (Dell Inspiron 3847 Intel Core i5-4460 with 12GB
memory) and could not duplicate the issue. I went back to my windows machine
and with the same original sample file and a copy of it I was able to duplicate
it right away. The key seemed to be having TWO files open at the same time and
then scrolling through one of the files. I might start to spend more time with
my Linux machine. :)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153797] New: firstname field is accepting special characters in create new Facebook account

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153797

Bug ID: 153797
   Summary: firstname field is accepting special characters in
create new Facebook account
   Product: Impress Remote
   Version: 1.0.3
  Hardware: PowerPC
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: General
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: deepajoth...@gmail.com

Description:
when I opened create new Facebook account and entered my firstname it accepts
special characters.

Steps to Reproduce:
1.open create new Facebook account
2.enter firstname 

Actual Results:
accepts special characters

Expected Results:
should not accept special characters


Reproducible: Sometimes


User Profile Reset: No

Additional Info:
Build ID: 167

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153779] FILESAVE Calc takes 4 minutes to save a file

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153779

--- Comment #2 from christothemagnific...@aussiebroadband.com.au ---
Thankyou for your reply, further testing;

Saves perform faster after running PROPERTIES
Running in safe mode made no difference
Resetting properties made no difference
Navigator shows 3 OLE objects, aside from SHEETS, all other options are greyed
out.

The file is my household budget with accounts numbers and transaction details.
It will take time to sanitise it before submitting for testing.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153692] Table layout split differently after undoing delete row

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153692

Ezinne  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||nnamani.ezi...@collabora.co
   ||m
 Ever confirmed|0   |1

--- Comment #2 from Ezinne  ---
Reproducible in:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 4a0d671706306661c4a5072ce4769dc47bc65f71
CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153742] Page with back drawing hide text

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153742

Ezinne  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||nnamani.ezi...@collabora.co
   ||m
 Status|UNCONFIRMED |NEW

--- Comment #4 from Ezinne  ---
Reproducible in:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 4a0d671706306661c4a5072ce4769dc47bc65f71
CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 113209] [META] UI bugs and enhancements

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113209

Ezinne  changed:

   What|Removed |Added

 Depends on||153446


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=153446
[Bug 153446] Tabbed UI - Hidden button don't work when displayed then used
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153446] Tabbed UI - Hidden button don't work when displayed then used

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153446

Ezinne  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||nnamani.ezi...@collabora.co
   ||m
 Status|UNCONFIRMED |NEW
 Blocks||107237, 113209

--- Comment #2 from Ezinne  ---
Reproduible in:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 4a0d671706306661c4a5072ce4769dc47bc65f71
CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107237
[Bug 107237] [META] Notebookbar Tabbed
https://bugs.documentfoundation.org/show_bug.cgi?id=113209
[Bug 113209] [META] UI bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107237] [META] Notebookbar Tabbed

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107237

Ezinne  changed:

   What|Removed |Added

 Depends on||153446


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=153446
[Bug 153446] Tabbed UI - Hidden button don't work when displayed then used
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 153784] Changing inputwin of Formula bar height / line count

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153784

QA Administrators  changed:

   What|Removed |Added

   Keywords||bibisectRequest

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 153469] LibreOffice Impress user interface will stop responding when opening a presentation slide containing a video clip.

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153469

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153784] Changing inputwin of Formula bar height / line count

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153784

QA Administrators  changed:

   What|Removed |Added

   Keywords||bibisectRequest

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153488] The "Separator" field in the "Numbering by Chapter" section in the AutoCaption Dialog should only allow one character to be entered

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153488

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153443] Scrolling stutters in Writer as soon as a page is filled with characters

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153443

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153482] Adding to dictionary should remove squiggles from other occurrences

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153482

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150106] using link external data fails after upgrade to 7.3

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150106

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149612] LibreOffice Writer stops working after 15-120 minutes

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149612

--- Comment #4 from QA Administrators  ---
Dear lanedvt,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150106] using link external data fails after upgrade to 7.3

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150106

--- Comment #5 from QA Administrators  ---
Dear rqu...@gmail.com,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150630] After opening Libre Office it's not possible to work with the program

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150630

--- Comment #2 from QA Administrators  ---
Dear Jens,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 87746] Slide Design should be disabled when in Master View

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=87746

--- Comment #11 from QA Administrators  ---
Dear Yousuf Philips (jay) (retired),

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 35954] styles not imported thoroughly: with paragraph style associated bullet list is not imported when List styles are not selected with Import (see comment #12)

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=35954

--- Comment #22 from QA Administrators  ---
Dear Paolo Benvenuto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 47787] B Spline interpolation is broken

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=47787

--- Comment #12 from QA Administrators  ---
Dear Markus Mohrhard,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140146] font in HTML in numbered list wrong

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140146

--- Comment #3 from QA Administrators  ---
Dear amyekut,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140059] Libreoffice not pasting graphs from Calc to Writer properly

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140059

--- Comment #7 from QA Administrators  ---
Dear Baland Rabayah,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135258] Cannot export slides to PNG when Master contains a transparent object

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135258

--- Comment #6 from QA Administrators  ---
Dear Florian,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133541] Image Control seems to be the wrong label for a control, which could also select all files

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133541

--- Comment #5 from QA Administrators  ---
Dear Robert Großkopf,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 122001] Delete key is not transparently assigned to shortcut

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122001

--- Comment #7 from QA Administrators  ---
Dear Heiko Tietze,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 123657] Fr: Month item predictive input when stretch border selection is running provides abbreviated month

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123657

--- Comment #6 from QA Administrators  ---
Dear Regis Perdreau,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153499] Index Entry dialog needs UI/HIG review

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153499

--- Comment #17 from Commit Notification 
 ---
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6d9b9d1228cdee69e767833202442a1fed6174a6

tdf#153499   revise tooltip; correct extended tip for "Index level"

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/uiconfig

2023-02-23 Thread Seth Chaiklin (via logerrit)
 sw/uiconfig/swriter/ui/indexentry.ui |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 6d9b9d1228cdee69e767833202442a1fed6174a6
Author: Seth Chaiklin 
AuthorDate: Fri Feb 24 00:56:45 2023 +
Commit: Seth Chaiklin 
CommitDate: Fri Feb 24 01:54:16 2023 +

tdf#153499   revise tooltip; correct extended tip for "Index level"

Change-Id: If7541390c8ee42ab3bf177e12670c9f983fd3e02
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147553
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin 

diff --git a/sw/uiconfig/swriter/ui/indexentry.ui 
b/sw/uiconfig/swriter/ui/indexentry.ui
index 78c286226764..bfc11ebc7231 100644
--- a/sw/uiconfig/swriter/ui/indexentry.ui
+++ b/sw/uiconfig/swriter/ui/indexentry.ui
@@ -277,10 +277,10 @@
 True
 True
 adjustment1
-Enter the index level for the entry.
+Enter the index level for the entry, which 
determines the appearance of the entry in the generated index.
 
   
-Entries using a 
“Heading X” paragraph style (X = [1–10]) can be automatically added to the 
Table of Contents. The level of the entry in the index corresponds to the 
outline level of the heading.
+Enter the index 
level for the entry. The index level determines the appearance of the entry, 
according to the settings for that level in the “Entries” tab and the “Styles” 
tab in the “Table of Contents, Index, or Bibliography” dialog. With default 
settings, a higher index level results in a greater indent for the entry in the 
generated index.
   
 
   


[Libreoffice-bugs] [Bug 153344] The size of icons in the status bar should be increased to at least 16px and the height of the status bar adjusted to allow this.

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153344

--- Comment #12 from Rizal Muttaqin  ---
(In reply to Heiko Tietze from comment #11)
> Played with 18px icon size and it works nicely.

Please attach a capture

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153796] New: RULER APPEARS ONLY ON PAGE WHEN CURSOR IS ON PAGE;

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153796

Bug ID: 153796
   Summary: RULER APPEARS ONLY ON PAGE WHEN CURSOR IS ON PAGE;
   Product: LibreOffice
   Version: 7.3.7.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gppatn...@comcast.net

Description:
I HAVE A TABLE, 2 COLUMNS, 2" HIGH X 3.5" WIDE, WHICH FILLS A FULL PAGE OF
BUSINESS CARD STOCK, AND IS 2 PAGES LONG, THE FIRST PAGE IS THE FRONT OF THE
BUSINESS CARD; THE SECOND PAGE IS THE BACK OF THE CARD [DOUBLE-SIDED CARD].
WHEN THE RULERS ARE "ON" THEY ARE DISPLAYED ONLY ON THE FIRST PAGE IF THE
CURSOR IS NOT IN THE SECOND PAGE; THE SECOND PAGE IS OTHERWISE CORRECT.
NOT SURE IF THIS IS A BUG OR AN ENHANCEMENT; PERSONALLY, I THINK IT'S A BUG!!!

Steps to Reproduce:
1.  OPEN NEW DOCUMENT
SET PAGE MARGINS TO 0.50 TOP, BOTTOM, LEFT AND RIGHT MARGINS
2.  CREATE TABLE WITH 2 COLUMNS AND 10 ROWS
3.  SET DIMENSION OF COLUMN HEIGHT TO 2 INCHES
4.  SET VIEW TO 'RULERS ON'
5.  SCROLL TO PAGE 2

Actual Results:
AS I DESCRIBED, TABLE IS 2 PAGES, AND LEFT MARGIN RULE IS ONLY VISIBLE WHEN
CURSOR IS ON THE PAGE BEING VIEWED.

Expected Results:
HOPED THAT RULER WOULD BE VISIBLE


Reproducible: Always


User Profile Reset: No

Additional Info:
RULER SHOULD APPEAR AT ALL TIMES WHEN SIMPLY SCROLLING PAGES TO VIEW BUT NOT
TYPE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153769] error playing animations and transitions in libreoffice impress

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153769

Michael FA  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105957] [META] Scrollbar-related bugs and enhancements

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105957
Bug 105957 depends on bug 148601, which changed state.

Bug 148601 Summary: Missing scrollbars in menus (interface bug since 7.0)
https://bugs.documentfoundation.org/show_bug.cgi?id=148601

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148601] Missing scrollbars in menus (interface bug since 7.0)

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148601

Michael FA  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 136901] Unintuitive dragging of tabs in RTL UI

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136901

ady  changed:

   What|Removed |Added

Summary|Unintuitive dragging of |Unintuitive dragging of
   |tabs|tabs in RTL UI

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153784] Changing inputwin of Formula bar height / line count

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153784

V Stuart Foote  changed:

   What|Removed |Added

Summary|Inputwin of Formula bar |Changing inputwin of
   |changing height |Formula bar height / line
   ||count

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 153784] Changing inputwin of Formula bar height / line count

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153784

V Stuart Foote  changed:

   What|Removed |Added

Summary|Inputwin of Formula bar |Changing inputwin of
   |changing height |Formula bar height / line
   ||count

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 153795] "Illustration Index" is now "Table of Figures", which requires updating this label in 5 help pages

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153795

--- Comment #1 from Commit Notification 
 ---
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/a7c1500a74c7f5e136da4a70656d19c54f758092

tdf#153795  "Illustration Index" -> "Table of Figures"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153795] "Illustration Index" is now "Table of Figures", which requires updating this label in 5 help pages

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153795

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.6.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: helpcontent2

2023-02-23 Thread Seth Chaiklin (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1750cc99ccdca1ee9e5e25cc6ad9891d08f1e758
Author: Seth Chaiklin 
AuthorDate: Fri Feb 24 00:23:59 2023 +
Commit: Gerrit Code Review 
CommitDate: Fri Feb 24 00:23:59 2023 +

Update git submodules

* Update helpcontent2 from branch 'master'
  to a7c1500a74c7f5e136da4a70656d19c54f758092
  - tdf#153795  "Illustration Index" -> "Table of Figures"

   also some corrections in menu names in the Type tab
   and updating of example to refer to "Figure".

Change-Id: I4529eeb821051a669ec0bfaeeadaa2c69f74
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147551
Reviewed-by: Seth Chaiklin 
Tested-by: Jenkins

diff --git a/helpcontent2 b/helpcontent2
index ac82657672e6..a7c1500a74c7 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit ac82657672e6d9867e4d8560536e241ca4814da6
+Subproject commit a7c1500a74c7f5e136da4a70656d19c54f758092


[Libreoffice-commits] help.git: source/text

2023-02-23 Thread Seth Chaiklin (via logerrit)
 source/text/swriter/00/0404.xhp |8 +++---
 source/text/swriter/01/04120213.xhp |   43 
 source/text/swriter/01/04120223.xhp |9 +++
 3 files changed, 28 insertions(+), 32 deletions(-)

New commits:
commit a7c1500a74c7f5e136da4a70656d19c54f758092
Author: Seth Chaiklin 
AuthorDate: Thu Feb 23 22:01:44 2023 +
Commit: Seth Chaiklin 
CommitDate: Fri Feb 24 00:23:59 2023 +

tdf#153795  "Illustration Index" -> "Table of Figures"

   also some corrections in menu names in the Type tab
   and updating of example to refer to "Figure".

Change-Id: I4529eeb821051a669ec0bfaeeadaa2c69f74
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147551
Reviewed-by: Seth Chaiklin 
Tested-by: Jenkins

diff --git a/source/text/swriter/00/0404.xhp 
b/source/text/swriter/00/0404.xhp
index d841ac9a14..b032e577cf 100644
--- a/source/text/swriter/00/0404.xhp
+++ b/source/text/swriter/00/0404.xhp
@@ -203,7 +203,7 @@
 
 Choose Insert - Table of Contents and Index - Table of 
Contents, Index or Bibliography - Type tab (when Alphabetical Index is 
the selected type)
 
-Choose Insert - Table of Contents and Index - Table of 
Contents, Index or Bibliography - Type tab (when Illustration Index is 
the selected type)
+Choose Insert - Table of Contents and Index - Table of 
Contents, Index or Bibliography - Type tab (when Table of Figures is 
the selected type)
 
 Choose Insert - Table of Contents and Index - Table of 
Contents, Index or Bibliography - Type tab (when Index of Tables is the 
selected type)
 
@@ -221,7 +221,7 @@
 
 Choose Insert - Table of Contents and Index - Table of 
Contents, Index or Bibliography - Entries tab (when Alphabetical Index 
is the selected type)
 
-Choose Insert - Table of Contents and Index - Table of 
Contents, Index or Bibliography - Entries tab (when Illustration Index 
is the selected type)
+Choose Insert - Table of Contents and Index - Table of 
Contents, Index or Bibliography - Entries tab (when Table of Figures 
is the selected type)
 
 Choose Insert - Table of Contents and Index - Table of 
Contents, Index or Bibliography - Entries tab (when Index of Tables is 
the selected type)
 
@@ -275,7 +275,7 @@
 
 
 
-Icon
+Icon

 
 
@@ -297,7 +297,7 @@
 
 
 
-Icon
+Icon

 
 
diff --git a/source/text/swriter/01/04120213.xhp 
b/source/text/swriter/01/04120213.xhp
index 5480ef9ca8..5447a6efcd 100644
--- a/source/text/swriter/01/04120213.xhp
+++ b/source/text/swriter/01/04120213.xhp
@@ -1,6 +1,5 @@
 
-
-
+
 
 
-
 
 
-Index
+Index (table of figures)
 /text/swriter/01/04120213.xhp
 
 
@@ -30,17 +28,16 @@
 
 
 
-Index
+Index (table of figures)
 
-The following options are available when you select 
the Illustration Index as the index type.
-
+The following options are available when you select 
Table of Figures as the index type.
 
   
 
 
 
 
-Create 
from
+Create from
 Specify the 
information to be combined to form an index.
 
 Captions
@@ -49,44 +46,44 @@
 Category
 Select the caption category that 
you want to use for the index entries.
 
-Display
-Select the part of the caption 
that you want to use for index entries. The following table lists the 
caption options that can be selected, based on the caption text "Illustration 
24: The Sun", where "Illustration 24" was automatically generated, and "The 
Sun" was added by the user.
+Display
+Select the part of the caption 
that you want to display in the index entries. The following table 
illustrates the options that can be selected, based on the caption “Figure 24: 
The Sun”, where “Figure 24” was generated automatically when the caption was 
inserted, while “The Sun” is the caption text added by the user.
 
 
-
+
 Selections in 
the Display list box
 
-
+
 Entry in the 
Index
 
 
 
-
-Reference 
Text
+
+Reference
 
-
-Illustration 
24: The Sun
+
+Figure 24: The 
Sun
 
 
 
-
+
 Category and 
Number
 
-
-Illustration 
24
+
+Figure 
24
 
 
 
-
-Caption
+
+Caption 
Text
 
-
+
 The 
Sun
 
 
 
 
-If you select 
"Caption Text", the punctuation and the space at the beginning of the caption 
does not appear in the index entry.
+If you select 
“Caption Text”, the punctuation and the space at the beginning of the caption 
are not included in the index entry.
 
 Object 
names
 Creates index entries from 
object names. You can view object names in the Navigator, for example, 
and change them in the context menu.
diff --git a/source/text/swriter/01/04120223.xhp 
b/source/text/swriter/01/04120223.xhp
index d341f717ed..e9b5523f09 100644
--- a/source/text/swriter/01/04120223.xhp
+++ b/source/text/swriter/01/04120223.xhp
@@ -20,19 +20,18 @@
 
 
 
-Entries (illustration index)
+Entries (table of figures)
 /text/swriter/01/04120223.xhp
 
 
 
-Entries (illustration index)
-Specify the format for the illustration index entries. 
-
+Entries (table of figures)
+Specify the format for the Table of Figures index 
entries.
 
 
 
 
-Illustration 

[Libreoffice-bugs] [Bug 148597] Provide fields "Chapter No"/E# and "Entry Text"/E for Table of Figures

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148597

--- Comment #9 from sdc.bla...@youmail.dk ---
(In reply to ajlittoz from comment #8)
> What is requested is an E# *entry number* containing the label (Figure
> Table, Drawing, …) and the number. And it looks it is already available
> because we can vary what is inserted in the table with the Display menu:
On the "Type" tab.

> So E# could collect what is designated by Category and Number, E be
> restricted to Caption Text instead of present References.
But now you are referring to the Entries tab, no?  

At present, if there is no "E" on the Entries tab, then the settings in Display
(on the Type tab) have no effect (i.e., nothing is displayed).  In other words,
at present "E" simply displays whatever is selected on the Type tab.

It seems preferable to collect all the formatting onto the Entries tab, for
example with:

CT = Caption Text
C  = Category
C# = Category Number
(plus CI = Chapter Info)

Then E is not needed (and "Display" on "Type" is not needed).  

A predefined structure would probably have a common configuration: 
C C# CT  [e.g., Figure (C) 1 (C#): My figure here (CT) ]

and then users can edit/configure according to their needs.

This description seems to be what is needed in the OP. 
And it would also be a solution to bug 94966.

(Alternatively, adding a "Number only" to the Display dropdown would also be a
solution).

For now, these proposals are meant only to clarify what capabilities are
desired in the UI. 

(Side comment: this seems "bad" to have structure design both on the Type tab
and Entries tab -- hard to keep track.  And as you pointed out in bug 134781,
it is rather pointless to have both Index of Tables and Index of Figures in the
UI, given that each can be created from the other.  While the "from Objects" is
a different story, providing a "predefined" version of what can be achieved in
User-defined).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 134781] Harmonize entries structure for index of tables and figures

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134781

--- Comment #22 from sdc.bla...@youmail.dk ---
NB. User-defined is intentionally not included in comment 21 as a kind of
index.
Rather, as the structure in comment 21 shows, all the indices are
"user-defined", where the structure in comment 21 gives the "elements" from
which an index is defined.  It would be easy enough to make some guide pages in
help (could also be tooltip or extended tip).

To Make TOC
---
1. Select Paragraph Styles and Index Marks
2. Select Headings.
3  Press OK. 
4. Use Entries and Styles tab to modify appearance of result.

Again, not advocating this solution. Just trying to show some potentially
useful possibilities.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 134781] Harmonize entries structure for index of tables and figures

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134781

--- Comment #21 from sdc.bla...@youmail.dk ---
Producing comment 20 inspired further reflection about the (complicated)
structure of the Insert Index dialog.

I notice: 

(a) The User-defined,  "Create From" section allows indices from Tables,
Graphics, Text Frames and OLE Objects.  These options are functionally
equivalent to selecting "Object Names" in Table of Figures, Index of Tables,
and the checkboxes in Table of Objects.

(b) afaict (have not tested systematically), the "Styles" and "Index Marks"
options in "Create From" for "User-defined" replicates the same functions
offered in "Table of Contents"

This suggests the following two-step process for an Insert Dialog.

1. Opening the Insert Index dialog gives 5 radio buttons:

( ) Paragraph Styles and Index Marks 

(Use for Table of Contents and User-defined Indexes)

( ) Caption Categories

(Use for Table of Figures and Table Index)

( ) Objects

( ) Alphabetical Index

( ) Bibliography


B. After selecting one of these radio buttons.

(alphabetical Index and Bibliography would then appear as they currently do
with the dropdown menu)

If "Objects" is selected, then all the checkboxes from the right side of
User-defined and the checkboxes in OLE Objects would appear.

If "Caption Categories" is selected, then "Category" dropdown box appears (or
even more flexible, a set of checkboxes corresponding to all category names)
(along with additional styles)

If "Paragraph Styles and Index Marks" is checked, then the choices are:

[ ] Headings
[ ] Styles  
[ ] Index Marks


Comments:
1. Have focused on functionality here (not label choices).
2. The important point is: this structure will allow you to produce all the
indices that can be produced with the current (complicated) interface, and does
not mix up different possibilities (objects and styles) in the same dialog.
3. I put the parenthetical comments about which choice to use for which purpose
as a quick-and-dirty way to illustrate how one could "guide" users toward what
to choose (given that the dialog box has lots of room).

Not necessarily trying to promote this design -- but I believe it (a) gives a 
comprehensive overview of the functional capabilities/possibilities in the
current interface, and (b) highlights a number of overlaps/redundancies between
different types, which might help think further about improving the UI/UX.

Add salt and pepper to taste...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141478] Calc crashes on any copy or cut operation when Croatian language used

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141478

ady  changed:

   What|Removed |Added

 Resolution|FIXED   |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 134781] Harmonize entries structure for index of tables and figures

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134781

--- Comment #20 from sdc.bla...@youmail.dk ---
(In reply to Heiko Tietze from comment #14)
> Let's keep one topic per ticket, the request here is to have the same
> configuration of entries for table of figures and index of tables. Don't see
> much benefit beyond consistency which is a goal per se. So +1.
I do not think that this statement summarizes the request accurately.

Rather -- "Index of Tables" and "Table of Figures" provide the same (identical)
interface and functional possibilities (with the one minor difference that the
former preselects "Table" for the Category, while the latter preselects
"Figure").  (ignoring the "from objects" part for now)

=>  Why keep the same functionality in an already complicated interface?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153606] macOS app icon is not properly integrated

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153606

--- Comment #31 from Galdam Jitsu  ---
But dropping the 'squircle' as I say for 3rd time worsens 'conformance' to the
Apple Icon Guidelines. That squircle just has to be there in some form or
other. I know not everything can be solved with 1 option but I insist on simply
adding a drop shadow and removing some other shadow and nothing more.

I don't see why it's bad that "white is not evenly distributed" ( amongst
edges?? not sure what is meant here ). The content part remains the same in
both scenarios which is the important part of the icon. The background is there
because of "consistency". I don't care a lot about MacOS, I just tried to
follow their guidelines, but I remember people complaining about not having
that squircle before the release.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: ESC meeting minutes: 2023-02-23

2023-02-23 Thread Patrick Luby



On 2/23/23 10:34 AM, Miklos Vajna wrote:
     + langpack install on macOS: 
   + spotlight is just the messenger here (Cloph)

     + integrating the langpacks into the installer is problematic
     + including the help as well would mean it's too large
     + some regions want offline help
     + perhaps a compromise: bundle UI translations
   + would be the same as we do it on Windows


Just wanted to add some data so you can estimate how much bandwidth 
increase a Universal + all languages installer would cause.


Below is the size of the Universal .dmg installer download for 
NeoOffice's non-Mac App Store version on GitHub:


-r--r--r--@ 1 root  wheel  519299873 Nov  6 16:59 
NeoOffice-2022.5_Professional_Edition-Universal.dmg


This includes localizations and local help files for the following 
subset of languages:


ar ca cs da de el en-GB en-US es fi fr he hu it ja ko nb nl pl pt pt-BR 
ro ru sk sv th tr uk zh-CN zh-TW


ossible hacky solution: maybe the language pack installer just needs to 
have the Contents/MacOS/soffice executable included.


I have used small "patch installers" for many years to let users install 
a fix before doing a full release. It is a regular macOS installer that, 
like LibreOffice's language pack installer, unzips a bunch of 
application files in a temporary folder and then copies the files into 
an existing installation.


The one difference in my patch installer is that I include binaries 
(usually a few .dylibs) so I had to also include the soffice executable 
for codesigning to work.


Apparently, macOS won't notice that some of the application's files 
changed because including the executable causes codesigning to create a 
new Contents/_CodeSignature and that folder overwrites the existing 
Contents/_CodeSignature folder. Amazingly, macOS still doesn't complain 
that most of the .dylibs and resource files aren't in the list of 
codesigned files.


I don't know if this is a good solution but maybe it could buy a few 
more years before LibreOffice has to switch to one big installer for 
everybody.


Patrick


[Libreoffice-bugs] [Bug 153538] Writer freezes and crashes without any error message

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153538

--- Comment #2 from Steve Benting  ---
I just updated to 7.5.0.3 and found this same behavior.  Occasional crashes on
Windows while writing a doc.  The issues I've found have been in much smaller
documents than the initial report (one and two pages).  There's no obvious
trigger -- in both cases I was just typing.

Version: 7.5.0.3 (X86_64) / LibreOffice Community
Build ID: c21113d003cd3efa8c53188764377a8272d9d6de
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

Just noticed the "please try" comment below so will review/try that.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153795] New: "Illustration Index" is now "Table of Figures", which requires updating this label in 5 help pages

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153795

Bug ID: 153795
   Summary: "Illustration Index" is now "Table of Figures", which
requires updating this label in 5 help pages
   Product: LibreOffice
   Version: 7.6.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sdc.bla...@youmail.dk
CC: olivier.hal...@libreoffice.org

The summary says it all.  Here is a hypothesis of where updates are needed.

https://help.libreoffice.org/7.6/en-US/search?P=%22Illustration+Index%22

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sd/qa

2023-02-23 Thread Xisco Fauli (via logerrit)
 sd/qa/unit/export-tests.cxx |  213 ++--
 1 file changed, 52 insertions(+), 161 deletions(-)

New commits:
commit ab20dba30769a5a52830220daa347772485db6a2
Author: Xisco Fauli 
AuthorDate: Thu Feb 23 17:16:34 2023 +0100
Commit: Xisco Fauli 
CommitDate: Thu Feb 23 21:54:10 2023 +

CppunitTest_sd_export_tests: use CPPUNIT_TEST_FIXTURE()

This suite is large enough so that avoiding the
declaration/registration/definition of each test manually saves a lot of
space.

Change-Id: I5b7ef05e16ec0d81acfc7288296849ab3b3973ce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147576
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sd/qa/unit/export-tests.cxx b/sd/qa/unit/export-tests.cxx
index 1878bf11e706..370f08564b22 100644
--- a/sd/qa/unit/export-tests.cxx
+++ b/sd/qa/unit/export-tests.cxx
@@ -53,119 +53,12 @@ public:
 {
 }
 
-void testBackgroundImage();
-void testMediaEmbedding();
-void testFillBitmapUnused();
-void testFdo84043();
-void testTdf97630();
-void testImpressPasswordExport();
-void testDrawPasswordExport();
-void testSwappedOutImageExport();
-void testOOoXMLAnimations();
-void testBnc480256();
-void testUnknownAttributes();
-void testTdf80020();
-void testTdf128985();
-void testLinkedGraphicRT();
-void testTdf79082();
-void testImageWithSpecialID();
-void testTdf62176();
-void testTransparentBackground();
-void testTdf142716();
-void testEmbeddedPdf();
-void testEmbeddedText();
-void testTransparenText();
-void testDefaultSubscripts();
-void testTdf98477();
-void testAuthorField();
-void testTdf50499();
-void testTdf100926();
-void testPageWithTransparentBackground();
-void testTextRotation();
-void testTdf115394PPT();
-void testBulletsAsImage();
-void testTdf113818();
-void testTdf119629();
-void testTdf141269();
-void testTdf123557();
-void testTdf113822();
-void testTdf126761();
-void testGlow();
-void testSoftEdges();
-void testShadowBlur();
-void testRhbz1870501();
-void testTdf152606();
-void testTdf91060();
-void testTdf128550();
-void testTdf140714();
-void testMasterPageBackgroundFullSize();
-void testColumnsODG();
-void testTdf112126();
-void testCellProperties();
-void testUserTableStyles();
-void testTdf153179();
-
-CPPUNIT_TEST_SUITE(SdExportTest);
-
-CPPUNIT_TEST(testBackgroundImage);
-CPPUNIT_TEST(testMediaEmbedding);
-CPPUNIT_TEST(testFillBitmapUnused);
-CPPUNIT_TEST(testFdo84043);
-CPPUNIT_TEST(testTdf97630);
-CPPUNIT_TEST(testImpressPasswordExport);
-CPPUNIT_TEST(testDrawPasswordExport);
-CPPUNIT_TEST(testSwappedOutImageExport);
-CPPUNIT_TEST(testOOoXMLAnimations);
-CPPUNIT_TEST(testBnc480256);
-CPPUNIT_TEST(testUnknownAttributes);
-CPPUNIT_TEST(testTdf80020);
-CPPUNIT_TEST(testTdf128985);
-CPPUNIT_TEST(testLinkedGraphicRT);
-CPPUNIT_TEST(testTdf79082);
-CPPUNIT_TEST(testImageWithSpecialID);
-CPPUNIT_TEST(testTdf62176);
-CPPUNIT_TEST(testTransparentBackground);
-CPPUNIT_TEST(testTdf142716);
-CPPUNIT_TEST(testEmbeddedPdf);
-CPPUNIT_TEST(testEmbeddedText);
-CPPUNIT_TEST(testTransparenText);
-CPPUNIT_TEST(testDefaultSubscripts);
-CPPUNIT_TEST(testTdf98477);
-CPPUNIT_TEST(testAuthorField);
-CPPUNIT_TEST(testTdf50499);
-CPPUNIT_TEST(testTdf100926);
-CPPUNIT_TEST(testPageWithTransparentBackground);
-CPPUNIT_TEST(testTextRotation);
-CPPUNIT_TEST(testTdf115394PPT);
-CPPUNIT_TEST(testBulletsAsImage);
-CPPUNIT_TEST(testTdf113818);
-CPPUNIT_TEST(testTdf119629);
-CPPUNIT_TEST(testTdf141269);
-CPPUNIT_TEST(testTdf123557);
-CPPUNIT_TEST(testTdf113822);
-CPPUNIT_TEST(testTdf126761);
-CPPUNIT_TEST(testGlow);
-CPPUNIT_TEST(testSoftEdges);
-CPPUNIT_TEST(testShadowBlur);
-CPPUNIT_TEST(testRhbz1870501);
-CPPUNIT_TEST(testTdf152606);
-CPPUNIT_TEST(testTdf91060);
-CPPUNIT_TEST(testTdf128550);
-CPPUNIT_TEST(testTdf140714);
-CPPUNIT_TEST(testMasterPageBackgroundFullSize);
-CPPUNIT_TEST(testColumnsODG);
-CPPUNIT_TEST(testTdf112126);
-CPPUNIT_TEST(testCellProperties);
-CPPUNIT_TEST(testUserTableStyles);
-CPPUNIT_TEST(testTdf153179);
-CPPUNIT_TEST_SUITE_END();
-
 virtual void registerNamespaces(xmlXPathContextPtr& pXmlXPathCtx) override
 {
 XmlTestTools::registerODFNamespaces(pXmlXPathCtx);
 }
 
-private:
+protected:
 uno::Reference getBitmapFromTable(OUString const& rName);
 };
 
@@ -192,7 +85,7 @@ uno::Reference 
SdExportTest::getBitmapFromTable(OUString const& rN
 return xBitmap;
 }
 
-void SdExportTest::testBackgroundImage()
+CPPUNIT_TEST_FIXTURE(SdExportTest, testBackgroundImage)
 {
 // Initial bug: N821567
 
@@ -297,7 +190,7 @@ void 

[Libreoffice-bugs] [Bug 134781] Harmonize entries structure for index of tables and figures

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134781

--- Comment #19 from sdc.bla...@youmail.dk ---
(In reply to Mike Kaganski from comment #9)
> question about having hyperlinks for table lists by default is a
> separate, with no clear reason not to have them.
I believe the reason (for now) might be bug 37608.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151310] Bullets and Numbering dialog is not wide enough to fit preview

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151310

--- Comment #7 from Rafael Lima  ---
Code pointers:

In the .ui file the size is fixed at 150, which is the initial size we get in
the preview. Notice the "width-request" of 150 for the widget.
https://opengrok.libreoffice.org/xref/core/cui/uiconfig/ui/bulletandposition.ui?r=3170799c#1071

And the reason why the preview is resized is here:
https://opengrok.libreoffice.org/xref/core/sd/source/ui/dlg/BulletAndPositionDlg.cxx?r=c91ec113#1188

Notice an apparent hack that explicitly uses 300 as a fixed size after changing
the spin buttons.

m_aPreviewWIN.set_size_request(aLastLevelLSpace, 300);

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Changes to 'refs/tags/cp-22.05.10-6'

2023-02-23 Thread Andras Timar (via logerrit)
Tag 'cp-22.05.10-6' created by Andras Timar  at 
2023-02-23 21:25 +

cp-22.05.10-6

Changes since co-22.05.10-5-10:
---
 0 files changed
---


[Libreoffice-commits] core.git: Changes to 'refs/tags/co-22.05.10-6'

2023-02-23 Thread Andras Timar (via logerrit)
Tag 'co-22.05.10-6' created by Andras Timar  at 
2023-02-23 21:25 +

co-22.05.10-6

Changes since co-22.05.10-5-10:
---
 0 files changed
---


[Libreoffice-commits] translations.git: Changes to 'refs/tags/co-22.05.10-6'

2023-02-23 Thread Andras Timar (via logerrit)
Tag 'co-22.05.10-6' created by Andras Timar  at 
2023-02-23 21:25 +

co-22.05.10-6

Changes since cp-22.05.10-1-1:
---
 0 files changed
---


[Libreoffice-commits] translations.git: Changes to 'refs/tags/cp-22.05.10-6'

2023-02-23 Thread Andras Timar (via logerrit)
Tag 'cp-22.05.10-6' created by Andras Timar  at 
2023-02-23 21:25 +

cp-22.05.10-6

Changes since cp-22.05.10-1-1:
---
 0 files changed
---


[Libreoffice-commits] help.git: Changes to 'refs/tags/co-22.05.10-6'

2023-02-23 Thread Olivier Hallot (via logerrit)
Tag 'co-22.05.10-6' created by Andras Timar  at 
2023-02-23 21:25 +

co-22.05.10-6

Changes since cp-22.05.6-1-1:
---
 0 files changed
---


[Libreoffice-commits] help.git: Changes to 'refs/tags/cp-22.05.10-6'

2023-02-23 Thread Olivier Hallot (via logerrit)
Tag 'cp-22.05.10-6' created by Andras Timar  at 
2023-02-23 21:25 +

cp-22.05.10-6

Changes since cp-22.05.6-1-1:
---
 0 files changed
---


[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/co-22.05.10-6'

2023-02-23 Thread Aron Budea (via logerrit)
Tag 'co-22.05.10-6' created by Andras Timar  at 
2023-02-23 21:25 +

co-22.05.10-6

Changes since cp-22.05.5-2:
Aron Budea (1):
  Add Persian (fa-IR) dictionary

---
 Dictionary_fa.mk  |   21 
 Module_dictionaries.mk|1 
 fa_IR/LICENSE |   15 
 fa_IR/META-INF/manifest.xml   |6 
 fa_IR/README_fa_IR.txt|   26 
 fa_IR/description.xml |   22 
 fa_IR/dictionaries.xcu|   19 
 fa_IR/fa-IR.aff   |  217 
 fa_IR/fa-IR.dic   |104025 
++
 fa_IR/icon.png|binary
 fa_IR/package-description.txt |4 
 11 files changed, 104356 insertions(+)
---


[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/cp-22.05.10-6'

2023-02-23 Thread Aron Budea (via logerrit)
Tag 'cp-22.05.10-6' created by Andras Timar  at 
2023-02-23 21:25 +

cp-22.05.10-6

Changes since cp-22.05.5-2:
Aron Budea (1):
  Add Persian (fa-IR) dictionary

---
 Dictionary_fa.mk  |   21 
 Module_dictionaries.mk|1 
 fa_IR/LICENSE |   15 
 fa_IR/META-INF/manifest.xml   |6 
 fa_IR/README_fa_IR.txt|   26 
 fa_IR/description.xml |   22 
 fa_IR/dictionaries.xcu|   19 
 fa_IR/fa-IR.aff   |  217 
 fa_IR/fa-IR.dic   |104025 
++
 fa_IR/icon.png|binary
 fa_IR/package-description.txt |4 
 11 files changed, 104356 insertions(+)
---


[Libreoffice-bugs] [Bug 153794] New: Crash on file open because theme without name was written to file

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153794

Bug ID: 153794
   Summary: Crash on file open because theme without name was
written to file
   Product: LibreOffice
   Version: 7.6.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de
CC: qui...@gmail.com

Created attachment 185558
  --> https://bugs.documentfoundation.org/attachment.cgi?id=185558=edit
Produced file that gives crash on opening

I have worked with a file in Impress, that has theme color. So my 'Recent
colors' contains theme colors (e.g. accent3) and the Area tab of Area dialog
has the selection "Theme colors".
Then I started a new file in Impress. I have inserted a rectangle and filled it
with a gradient. I have used the Area dialog to set start and end color of the
gradient. The Area dialog opens with Area tab and selection "Theme colors". Of
case there were no theme colors, because the document template on which the new
file was based has no theme colors. But I have used colors from the 'Recent
colors'. Those have still tooltips saying 'accent3' for example. Then I saved
the file.
When I reopen the file LibreOffice crashes. The produced file is attached.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151310] Bullets and Numbering dialog is not wide enough to fit preview

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151310

--- Comment #6 from Rafael Lima  ---
BTW the problem also happens in gen and in gtk3, but in a different way.

In gtk3 the dialog is not wide enough to fit the preview, but pressing Tab
won't change the dialog layout as in kf5.

In gen the problem is identical to what happens in kf5. Pressing Tab will try
to resize the columns to fit the preview.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151310] Bullets and Numbering dialog is not wide enough to fit preview

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151310

Rafael Lima  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #5 from Rafael Lima  ---
(In reply to Buovjaga from comment #4)
> I don't repro the change in the video. I also tried in 7.5 bibisect repo
> with a commit from Nov 2022, but no change. Do you still see this?

Still repro with:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 29d795b772cb75ee1d12cc6bcd4d905f1c520a79
CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL threaded

I can also reproduce the problem with:

Version: 7.5.0.3 (X86_64) / LibreOffice Community
Build ID: 50(Build:3)
CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Ubuntu package version: 1:7.5.0~rc3-0ubuntu0.22.10.1~lo1
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104450] [META] DOCX (OOXML) file opening issues

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104450

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||152982


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=152982
[Bug 152982] FILEOPEN DOCX LibreOffice Writer hangs while opening certain docx
files
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152982] FILEOPEN DOCX LibreOffice Writer hangs while opening certain docx files

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152982

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru
 Blocks||104450


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104450
[Bug 104450] [META] DOCX (OOXML) file opening issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153217] Pivot grouping expands to all pivots

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153217

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

   Keywords|bibisectRequest |notBibisectable
Version|6.1.0.3 release |4.0.6.2 release
 CC||79045_79...@mail.ru

--- Comment #4 from Roman Kuznetsov <79045_79...@mail.ru> ---
Repro in

Версия 4.0.6.2 (ID сборки: 2e2573268451a50806fcd60ae2d9fe01dd0ce24) also

Looks like not bibisectable

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153793] The Groupedbar works on 7.1.7.2 using Big Sur, but every single update since has broken it.

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153793

MalcG  changed:

   What|Removed |Added

 CC||info@classicsiliconehoses.c
   ||om

--- Comment #1 from MalcG  ---
Created attachment 185557
  --> https://bugs.documentfoundation.org/attachment.cgi?id=185557=edit
Screen grab

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153793] New: The Groupedbar works on 7.1.7.2 using Big Sur, but every single update since has broken it.

2023-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153793

Bug ID: 153793
   Summary: The Groupedbar works on 7.1.7.2 using Big Sur, but
every single update since has broken it.
   Product: LibreOffice
   Version: 7.2.0.0.alpha0+
  Hardware: x86-64 (AMD64)
OS: macOS (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: i...@classicsiliconehoses.com

Description:
Partial failure of 'Groupedbar' when opening a new file.

Steps to Reproduce:
1.Open file
2.Open another file - the first window looses part of the 'groupedbar'
3.Open another file - the first window looses part of the 'groupedbar'

Actual Results:
Partial groupedbar

Expected Results:
Full groupedbar


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Mac OSX Big Sur - 11.6

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - sc/source

2023-02-23 Thread Caolán McNamara (via logerrit)
 sc/source/core/tool/interpr1.cxx |   34 +++---
 1 file changed, 19 insertions(+), 15 deletions(-)

New commits:
commit 0f305c976c4a619f53154d13be134d3bbe6f3302
Author: Caolán McNamara 
AuthorDate: Sun Feb 19 17:33:20 2023 +
Commit: Eike Rathke 
CommitDate: Thu Feb 23 19:29:11 2023 +

crashtesting: crash on import of forum-mso-en4-702161.xlsx

vConditions is empty at this point for row 5

git show -w

Change-Id: I05d984d73d4dd5a0ece894f854263528c9c00be9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147303
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
(cherry picked from commit 35e3c499cb64ed647fc8cc0a42a2d83948abcbdf)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147287
Reviewed-by: Eike Rathke 

diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx
index 405d9fe00023..5673bb7ecda2 100644
--- a/sc/source/core/tool/interpr1.cxx
+++ b/sc/source/core/tool/interpr1.cxx
@@ -6491,25 +6491,29 @@ void ScInterpreter::IterateParametersIfs( 
double(*ResultFunc)( const sc::ParamIf
 if (nRefArrayMainPos < vRefArrayConditions.size())
 vConditions = vRefArrayConditions[nRefArrayMainPos];
 
-std::vector::const_iterator itRes = 
vConditions.begin();
-for (SCCOL nCol = 0; nCol < nDimensionCols; ++nCol)
+SAL_WARN_IF(nDimensionCols && nDimensionRows && 
vConditions.empty(), "sc",  "ScInterpreter::IterateParametersIfs vConditions is 
empty");
+if (!vConditions.empty())
 {
-for (SCROW nRow = 0; nRow < nDimensionRows; ++nRow, 
++itRes)
+std::vector::const_iterator itRes = 
vConditions.begin();
+for (SCCOL nCol = 0; nCol < nDimensionCols; ++nCol)
 {
-if (*itRes == nQueryCount)
+for (SCROW nRow = 0; nRow < nDimensionRows; 
++nRow, ++itRes)
 {
-aAdr.SetCol( nCol + nMainCol1);
-aAdr.SetRow( nRow + nMainRow1);
-ScRefCellValue aCell(mrDoc, aAdr);
-if (aCell.hasNumeric())
+if (*itRes == nQueryCount)
 {
-fVal = GetCellValue(aAdr, aCell);
-++aRes.mfCount;
-aRes.mfSum += fVal;
-if ( aRes.mfMin > fVal )
-aRes.mfMin = fVal;
-if ( aRes.mfMax < fVal )
-aRes.mfMax = fVal;
+aAdr.SetCol( nCol + nMainCol1);
+aAdr.SetRow( nRow + nMainRow1);
+ScRefCellValue aCell(mrDoc, aAdr);
+if (aCell.hasNumeric())
+{
+fVal = GetCellValue(aAdr, aCell);
+++aRes.mfCount;
+aRes.mfSum += fVal;
+if ( aRes.mfMin > fVal )
+aRes.mfMin = fVal;
+if ( aRes.mfMax < fVal )
+aRes.mfMax = fVal;
+}
 }
 }
 }


  1   2   3   4   >