[Libreoffice-commits] core.git: sc/source
sc/source/ui/vba/vbaapplication.cxx |5 ++---
sc/source/ui/vba/vbaapplication.hxx |2 +-
2 files changed, 3 insertions(+), 4 deletions(-)
New commits:
commit 20c7df24b2df57f4bbd62d08cc759ad62d6512ce
Author: Baole Fang
AuthorDate: Tue Mar 14 11:13:59 2023 -0400
Commit: Mike Kaganski
CommitDate: Wed Mar 15 05:38:20 2023 +
Refactor InchesToPoints in Calc
Change-Id: I379e41ce0a16e1e02b2e4426525657c751e945dc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148890
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sc/source/ui/vba/vbaapplication.cxx
b/sc/source/ui/vba/vbaapplication.cxx
index 59088788b4d7..d9e5ba984f5a 100644
--- a/sc/source/ui/vba/vbaapplication.cxx
+++ b/sc/source/ui/vba/vbaapplication.cxx
@@ -1329,11 +1329,10 @@ uno::Reference< excel::XRange > SAL_CALL
ScVbaApplication::Union(
return lclCreateVbaRange( mxContext, getCurrentDocument(), aList );
}
-double
+double SAL_CALL
ScVbaApplication::InchesToPoints( double Inches )
{
- double result = Inches * 72.0;
- return result;
+ return o3tl::convert(Inches, o3tl::Length::in, o3tl::Length::pt);
}
double SAL_CALL
diff --git a/sc/source/ui/vba/vbaapplication.hxx
b/sc/source/ui/vba/vbaapplication.hxx
index 3c0ed903f9d1..4a049100b608 100644
--- a/sc/source/ui/vba/vbaapplication.hxx
+++ b/sc/source/ui/vba/vbaapplication.hxx
@@ -143,7 +143,7 @@ public:
virtual css::uno::Reference< ov::excel::XRange > SAL_CALL Intersect( const
css::uno::Reference< ov::excel::XRange >& Arg1, const css::uno::Reference<
ov::excel::XRange >& Arg2, const css::uno::Any& Arg3, const css::uno::Any&
Arg4, const css::uno::Any& Arg5, const css::uno::Any& Arg6, const
css::uno::Any& Arg7, const css::uno::Any& Arg8, const css::uno::Any& Arg9,
const css::uno::Any& Arg10, const css::uno::Any& Arg11, const css::uno::Any&
Arg12, const css::uno::Any& Arg13, const css::uno::Any& Arg14, const
css::uno::Any& Arg15, const css::uno::Any& Arg16, const css::uno::Any& Arg17,
const css::uno::Any& Arg18, const css::uno::Any& Arg19, const css::uno::Any&
Arg20, const css::uno::Any& Arg21, const css::uno::Any& Arg22, const
css::uno::Any& Arg23, const css::uno::Any& Arg24, const css::uno::Any& Arg25,
const css::uno::Any& Arg26, const css::uno::Any& Arg27, const css::uno::Any&
Arg28, const css::uno::Any& Arg29, const css::uno::Any& Arg30 ) override;
virtual css::uno::Reference< ov::excel::XRange > SAL_CALL Union( const
css::uno::Reference< ov::excel::XRange >& Arg1, const css::uno::Reference<
ov::excel::XRange >& Arg2, const css::uno::Any& Arg3, const css::uno::Any&
Arg4, const css::uno::Any& Arg5, const css::uno::Any& Arg6, const
css::uno::Any& Arg7, const css::uno::Any& Arg8, const css::uno::Any& Arg9,
const css::uno::Any& Arg10, const css::uno::Any& Arg11, const css::uno::Any&
Arg12, const css::uno::Any& Arg13, const css::uno::Any& Arg14, const
css::uno::Any& Arg15, const css::uno::Any& Arg16, const css::uno::Any& Arg17,
const css::uno::Any& Arg18, const css::uno::Any& Arg19, const css::uno::Any&
Arg20, const css::uno::Any& Arg21, const css::uno::Any& Arg22, const
css::uno::Any& Arg23, const css::uno::Any& Arg24, const css::uno::Any& Arg25,
const css::uno::Any& Arg26, const css::uno::Any& Arg27, const css::uno::Any&
Arg28, const css::uno::Any& Arg29, const css::uno::Any& Arg30 ) override;
virtual double SAL_CALL CentimetersToPoints( double Centimeters ) override;
-virtual double SAL_CALL InchesToPoints( double InchesToPoints ) override;
+virtual double SAL_CALL InchesToPoints( double Inches ) override;
virtual void SAL_CALL Volatile( const css::uno::Any& Volatile ) override;
virtual css::uno::Any SAL_CALL MenuBars( const css::uno::Any& aIndex )
override;
virtual css::uno::Any SAL_CALL Rows( const css::uno::Any& aIndex )
override;
[Libreoffice-bugs] [Bug 153591] Spellchecking can not be disabled
https://bugs.documentfoundation.org/show_bug.cgi?id=153591 QA Administrators changed: What|Removed |Added Whiteboard|QA:needsComment | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153877] vertical Unicode SMP chars not displayed correctly when exported as PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=153877 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153840] [Calc] Copying huge(?) data by Ctrl-C caused BSOD in Win11 with hardware acceleration on
https://bugs.documentfoundation.org/show_bug.cgi?id=153840 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153793] The Groupedbar works on 7.1.7.2 using Big Sur, but every single update since has broken it.
https://bugs.documentfoundation.org/show_bug.cgi?id=153793 --- Comment #7 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150330] Impress: Document template window stays open on Impress crash (GTK3?)
https://bugs.documentfoundation.org/show_bug.cgi?id=150330 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150330] Impress: Document template window stays open on Impress crash (GTK3?)
https://bugs.documentfoundation.org/show_bug.cgi?id=150330 --- Comment #8 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150410] Insert picture to table change picture
https://bugs.documentfoundation.org/show_bug.cgi?id=150410 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150410] Insert picture to table change picture
https://bugs.documentfoundation.org/show_bug.cgi?id=150410 --- Comment #4 from QA Administrators --- Dear Jonas Högberg, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150381] LibreOffice 7.3.5.2 started giving a warning when clicking link to HTML file
https://bugs.documentfoundation.org/show_bug.cgi?id=150381 --- Comment #11 from QA Administrators --- Dear JIM7, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150381] LibreOffice 7.3.5.2 started giving a warning when clicking link to HTML file
https://bugs.documentfoundation.org/show_bug.cgi?id=150381 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150978] Calc randomly replacing Chart Data Ranges with Data Tables
https://bugs.documentfoundation.org/show_bug.cgi?id=150978 --- Comment #2 from QA Administrators --- Dear didrey, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 119165] UI: Autocompletion tooltip doesn't disappear when scrolling
https://bugs.documentfoundation.org/show_bug.cgi?id=119165 --- Comment #3 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 123193] Turning Smooth scroll on or off causes unwanted zoom change
https://bugs.documentfoundation.org/show_bug.cgi?id=123193 --- Comment #3 from QA Administrators --- Dear Buovjaga, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153109] Use all_of, any_of or none_of from STD instead of looping to check a condition over a range
https://bugs.documentfoundation.org/show_bug.cgi?id=153109 --- Comment #3 from Mike Kaganski --- Note that a common sense should apply: this change should not be applied when it doesn't improve things: sometimes the loop is optimal both in terms of performance and readability. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153683] CLI: Show the module which is used in --convert-to
https://bugs.documentfoundation.org/show_bug.cgi?id=153683 Baole Fang changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |baole.f...@gmail.com |desktop.org | Status|NEW |ASSIGNED --- Comment #1 from Baole Fang --- Reproduced: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 008488789092ce980ae9ba029ae375556cfca78f CPU threads: 12; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded Start working on this. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154189] Opening an xlsx in 7.5.1 removes color and border formatting which used to show in 7.3.5 and shows in Excel
https://bugs.documentfoundation.org/show_bug.cgi?id=154189 --- Comment #7 from simpson.sc...@icloud.com --- By template I just mean we have a master version of the file that we copy and rename for the week. Not sure what version of excel it was created with originally but we currently use Excel 19 to edit and save so this file was saved with Excel ‘19. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: writerfilter/source
writerfilter/source/dmapper/DomainMapper_Impl.cxx | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
New commits:
commit 44837a12d12be3e525fa48b37c3dd2553cc97d94
Author: Justin Luth
AuthorDate: Sat Mar 11 18:26:22 2023 -0500
Commit: Justin Luth
CommitDate: Wed Mar 15 01:51:31 2023 +
tdf#154129 writerfilter framePr: check whole style inheritance: wrap
This patch depends on HAnchor, which created vProps.
A style can inherit its properties from another style,
but the code was naively just checking the first paragraph style,
and not any of the parents.
There were no existing sw.check tests where the old and new method
produced different values.
Change-Id: Ifdd4b5f9eefdc1f53e472c1bb5d19b526e00ee38
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148717
Reviewed-by: Justin Luth
Tested-by: Jenkins
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index f33d3c390afb..5d9906ee97b1 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -1772,13 +1772,16 @@ void
DomainMapper_Impl::CheckUnregisteredFrameConversion( )
aFrameProperties.push_back(comphelper::makePropertyValue(
getPropertyName(PROP_VERT_ORIENT_RELATION), nVAnchor));
-
aFrameProperties.push_back(comphelper::makePropertyValue(getPropertyName(PROP_SURROUND),
-rAppendContext.pLastParagraphProperties->GetWrap() !=
text::WrapTextMode::WrapTextMode_MAKE_FIXED_SIZE
-? rAppendContext.pLastParagraphProperties->GetWrap()
-: pStyleProperties->props().GetWrap()
- != text::WrapTextMode::WrapTextMode_MAKE_FIXED_SIZE
- ? pStyleProperties->props().GetWrap()
- : text::WrapTextMode_NONE ));
+text::WrapTextMode nWrap = text::WrapTextMode_NONE;
+for (const auto pProp : vProps)
+{
+if (pProp->GetWrap() ==
text::WrapTextMode::WrapTextMode_MAKE_FIXED_SIZE)
+continue;
+nWrap = pProp->GetWrap();
+break;
+}
+aFrameProperties.push_back(
+comphelper::makePropertyValue(getPropertyName(PROP_SURROUND),
nWrap));
/** FDO#73546 : distL & distR should be unsigned integers
Swapped the array elements 11,12 & 13,14 since 11 & 12 are
[Libreoffice-bugs] [Bug 154189] Opening an xlsx in 7.5.1 removes color and border formatting which used to show in 7.3.5 and shows in Excel
https://bugs.documentfoundation.org/show_bug.cgi?id=154189 --- Comment #6 from Tex2002ans --- Yep, opened attached XLSX in Excel 2016. Formatting is all there. Verified missing colors/lines in: Version: 7.5.1.2 (X86_64) / LibreOffice Community Build ID: fcbaee479e84c6cd81291587d2ee68cba099e129 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded Definitely a strange one. - - - > I’ve been using libreoffice to open these rotas that are made in Excel but > always based on the same template. Which version of Excel did you use to make this XLSX? And how did you set the template? - - - QA/Devs: Think it may be related to Bug #91276? (Accidentally[???] closed as "NOTABUG" back in 2015?) I was wondering where this bug's attached XLSX was getting colors from, saw the 2 files: - styles.xml --- Looks like THIS is what controls this file's fill/border colors. - theme1.xml Then randomly stumbled upon that closed 2015 bug while looking up: - fgColor site:https://bugs.documentfoundation.org/ - fills indexed xlsx site:https://bugs.documentfoundation.org/ (There was only 1 or 3 hits on the LO Bugzilla using those search terms.) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146984] Lost page break: Image in frame jump to second page on DOCX export (fine with DOC)
https://bugs.documentfoundation.org/show_bug.cgi?id=146984 Commit Notification changed: What|Removed |Added Whiteboard||target:7.6.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108771] [META] DOCX (OOXML) page-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=108771 Justin L changed: What|Removed |Added Depends on||146984 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=146984 [Bug 146984] Lost page break: Image in frame jump to second page on DOCX export (fine with DOC) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146984] Lost page break: Image in frame jump to second page on DOCX export (fine with DOC)
https://bugs.documentfoundation.org/show_bug.cgi?id=146984 Justin L changed: What|Removed |Added Resolution|DUPLICATE |--- Status|RESOLVED|NEW Blocks||108771 Keywords||filter:docx Summary|Image in frame jump to |Lost page break: Image in |second page on DOCX export |frame jump to second page |(fine with DOC) |on DOCX export (fine with ||DOC) CC||jl...@mail.com --- Comment #6 from Justin L --- In 7.6+, everything has jumped to the first page. The export is fine, since it opens nicely in MS Word. The problem is a missing page break. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108771 [Bug 108771] [META] DOCX (OOXML) page-related issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108771] [META] DOCX (OOXML) page-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=108771 Bug 108771 depends on bug 146984, which changed state. Bug 146984 Summary: Lost page break: Image in frame jump to second page on DOCX export (fine with DOC) https://bugs.documentfoundation.org/show_bug.cgi?id=146984 What|Removed |Added Status|RESOLVED|NEW Resolution|DUPLICATE |--- -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa writerfilter/source
sw/qa/extras/ooxmlexport/data/tdf153613_textboxAfterPgBreak3.docx |binary
sw/qa/extras/ooxmlexport/ooxmlexport18.cxx| 10
writerfilter/source/dmapper/DomainMapper.cxx |5 +++-
writerfilter/source/dmapper/DomainMapper_Impl.cxx | 12
++
writerfilter/source/dmapper/DomainMapper_Impl.hxx |3 ++
5 files changed, 29 insertions(+), 1 deletion(-)
New commits:
commit 828fde37632a5bb0542b6925454690a5287d6490
Author: Justin Luth
AuthorDate: Tue Mar 14 14:20:58 2023 -0400
Commit: Justin Luth
CommitDate: Wed Mar 15 01:38:29 2023 +
tdf#153613 tdf#146984 writerfilter: split para after anchors
Even though the w:br occurs in the paragraph before the anchors,
the anchors stay on the first page, and don't move to the second page
(unless it is the last paragraph in the section/document,
which is not yet handled.)
make CppunitTest_sw_ooxmlexport18 \
CPPUNIT_TEST_NAME=testTdf153613_textboxAfterPgBreak3
Change-Id: Icfc7e2a5d7657f1eb8f94263a4bfc8dcca7e52de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148897
Tested-by: Jenkins
Reviewed-by: Justin Luth
diff --git a/sw/qa/extras/ooxmlexport/data/tdf153613_textboxAfterPgBreak3.docx
b/sw/qa/extras/ooxmlexport/data/tdf153613_textboxAfterPgBreak3.docx
new file mode 100644
index ..a282deaa0ad7
Binary files /dev/null and
b/sw/qa/extras/ooxmlexport/data/tdf153613_textboxAfterPgBreak3.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
index 460f4098e837..c30e555ae15e 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
@@ -217,6 +217,16 @@
DECLARE_OOXMLEXPORT_TEST(testTdf153613_textboxAfterPgBreak2, "tdf153613_textboxA
assertXPathContent(pLayout, "//page[2]/body/txt", "There should be no
prior carriage return.");
}
+DECLARE_OOXMLEXPORT_TEST(testTdf153613_textboxAfterPgBreak3,
"tdf153613_textboxAfterPgBreak3.docx")
+{
+// All anchored TO-character shapes stay on the first page, before the
page break.
+CPPUNIT_ASSERT_EQUAL(2, getPages());
+CPPUNIT_ASSERT_EQUAL(3, getParagraphs());
+
+const auto& pLayout = parseLayoutDump();
+assertXPath(pLayout, "//page[2]//anchored", 0);
+}
+
DECLARE_OOXMLEXPORT_TEST(testTdf153613_sdtAfterPgBreak,
"tdf153613_sdtAfterPgBreak.docx")
{
CPPUNIT_ASSERT_EQUAL(2, getPages());
diff --git a/writerfilter/source/dmapper/DomainMapper.cxx
b/writerfilter/source/dmapper/DomainMapper.cxx
index c526968fc8c0..800ae2525060 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -3635,7 +3635,7 @@ void
DomainMapper::lcl_startShape(uno::Reference const& xShape)
{
// If there is a deferred page break, handle it now, so that the
// started shape will be on the correct page.
-if (m_pImpl->isBreakDeferred(PAGE_BREAK))
+if (m_pImpl->isBreakDeferred(PAGE_BREAK) &&
!m_pImpl->IsBreakDeferredByAnchor())
{
// RTF doesn't properly report IsFirstRun, so in order to prevent
regressions
// always split the paragraph for RTF since that is the way it has
been done lately.
@@ -3645,6 +3645,9 @@ void
DomainMapper::lcl_startShape(uno::Reference const& xShape)
finishParagraph();
lcl_startParagraphGroup();
}
+else
+m_pImpl->SetIsBreakDeferredByAnchor();
+
}
m_pImpl->PushShapeContext( xShape );
lcl_startParagraphGroup();
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index 62dda7d02ac2..f33d3c390afb 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -1477,6 +1477,7 @@ void DomainMapper_Impl::clearDeferredBreak(BreakType
deferredBreakType)
break;
case PAGE_BREAK:
m_bIsPageBreakDeferred = false;
+m_bIsBreakDeferredByAnchor = false;
break;
default:
break;
@@ -1488,6 +1489,17 @@ void DomainMapper_Impl::clearDeferredBreaks()
m_nLineBreaksDeferred = 0;
m_bIsColumnBreakDeferred = false;
m_bIsPageBreakDeferred = false;
+m_bIsBreakDeferredByAnchor = false;
+}
+
+bool DomainMapper_Impl::IsBreakDeferredByAnchor()
+{
+return m_bIsBreakDeferredByAnchor;
+}
+
+void DomainMapper_Impl::SetIsBreakDeferredByAnchor()
+{
+m_bIsBreakDeferredByAnchor = true;
}
void DomainMapper_Impl::setSdtEndDeferred(bool bSdtEndDeferred)
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.hxx
b/writerfilter/source/dmapper/DomainMapper_Impl.hxx
index 234ae9416eb1..050a510353a8 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.hxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.hxx
@@ -487,6 +487,7 @@
[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=71732 V Stuart Foote changed: What|Removed |Added Depends on||154191 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=154191 [Bug 154191] Letters drawing outside the margin -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154191] Letters drawing outside the margin
https://bugs.documentfoundation.org/show_bug.cgi?id=154191 V Stuart Foote changed: What|Removed |Added Blocks||71732 --- Comment #5 from V Stuart Foote --- I think swash decoration extending beyond Paragraph, Cell, and draw Text object margins is the expected/desired behavior. IIUC for normal fonts the swash would be an alternate via gsub/salt lookup. But that would not change the font metric as here when the glyph strokes extend into -X values before the 0 edge. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=71732 [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148410] content of formula bar placed too low (kf5)
https://bugs.documentfoundation.org/show_bug.cgi?id=148410 Bug 148410 depends on bug 150664, which changed state. Bug 150664 Summary: Calc Input Line in Formula Bar is moved down and cropped https://bugs.documentfoundation.org/show_bug.cgi?id=150664 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108660] [META] Formula bar (input line) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108660 Bug 108660 depends on bug 150664, which changed state. Bug 150664 Summary: Calc Input Line in Formula Bar is moved down and cropped https://bugs.documentfoundation.org/show_bug.cgi?id=150664 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133092] [META] Crash bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=133092 Bug 133092 depends on bug 150135, which changed state. Bug 150135 Summary: Accessing uninitialized TextInputStream methods crashes https://bugs.documentfoundation.org/show_bug.cgi?id=150135 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153710] "Evaluate up to level" for Chapter Info for User-Defined Index shows only top level or all levels
https://bugs.documentfoundation.org/show_bug.cgi?id=153710 --- Comment #5 from sdc.bla...@youmail.dk --- The updated help pages are online now. See how Autocaption [1] in comment 4 gives a description of "typical" behavior, while the "note" gives the full picture. In contrast, "Alphabetical Index" [2] in comment 4 only gives "typical" behavior, with no indication of the complete rule. (The same text would be used for "User-defined", which is the focus of this ticket). I can see arguments for both approaches, so would be happy to hear another opinion. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153890] Rename "Apply to all similar texts" to "Apply to all other occurrences" in Insert - Index Entry dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=153890 sdc.bla...@youmail.dk changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #5 from sdc.bla...@youmail.dk --- (In reply to Heiko Tietze from comment #2) > No objection; but I also see not much benefit. Ok. When I first used this option, I was uncertain whether it was exact match or similarity match. Discovered post facto that the help page also describes it as "Automatically marks all other occurrences of the selected text...", so at least now the label matches the help. (-: Added tooltip as well. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 122497] [META] Table of Contents and Indexes dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=122497 Bug 122497 depends on bug 153890, which changed state. Bug 153890 Summary: Rename "Apply to all similar texts" to "Apply to all other occurrences" in Insert - Index Entry dialog https://bugs.documentfoundation.org/show_bug.cgi?id=153890 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148410] content of formula bar placed too low (kf5)
https://bugs.documentfoundation.org/show_bug.cgi?id=148410 Bug 148410 depends on bug 150664, which changed state. Bug 150664 Summary: Calc Input Line in Formula Bar is moved down and cropped https://bugs.documentfoundation.org/show_bug.cgi?id=150664 What|Removed |Added Status|VERIFIED|UNCONFIRMED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108660] [META] Formula bar (input line) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108660 Bug 108660 depends on bug 150664, which changed state. Bug 150664 Summary: Calc Input Line in Formula Bar is moved down and cropped https://bugs.documentfoundation.org/show_bug.cgi?id=150664 What|Removed |Added Status|VERIFIED|UNCONFIRMED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153890] Rename "Apply to all similar texts" to "Apply to all other occurrences" in Insert - Index Entry dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=153890 --- Comment #4 from Commit Notification --- Seth Chaiklin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/help/commit/87ab9fc48e05a39caf563be8f171d0ed737c50f7 tdf#153890 "apply to all similar texts" -> "apply to all other occurrences" -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 5da513c1f34f657f910d2a9d1af7761cf649574f Author: Seth Chaiklin AuthorDate: Wed Mar 15 00:23:53 2023 + Commit: Gerrit Code Review CommitDate: Wed Mar 15 00:23:53 2023 + Update git submodules * Update helpcontent2 from branch 'master' to 87ab9fc48e05a39caf563be8f171d0ed737c50f7 - tdf#153890 "apply to all similar texts" -> "apply to all other occurrences" plus remove Change-Id: Id2a01e490cbae4c7a378d0d7834a0c7edbac97d3 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148868 Tested-by: Jenkins Reviewed-by: Seth Chaiklin diff --git a/helpcontent2 b/helpcontent2 index 9309d69eab4f..87ab9fc48e05 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 9309d69eab4f5bedc266b2286a9b0e5f0a06e295 +Subproject commit 87ab9fc48e05a39caf563be8f171d0ed737c50f7
[Libreoffice-commits] help.git: source/text
source/text/swriter/01/04120100.xhp | 66 ++-- source/text/swriter/guide/indices_enter.xhp | 22 - 2 files changed, 44 insertions(+), 44 deletions(-) New commits: commit 87ab9fc48e05a39caf563be8f171d0ed737c50f7 Author: Seth Chaiklin AuthorDate: Wed Mar 15 00:00:10 2023 + Commit: Seth Chaiklin CommitDate: Wed Mar 15 00:23:52 2023 + tdf#153890 "apply to all similar texts" -> "apply to all other occurrences" plus remove Change-Id: Id2a01e490cbae4c7a378d0d7834a0c7edbac97d3 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148868 Tested-by: Jenkins Reviewed-by: Seth Chaiklin diff --git a/source/text/swriter/01/04120100.xhp b/source/text/swriter/01/04120100.xhp index f03c5d2d88..31e7a0edc0 100644 --- a/source/text/swriter/01/04120100.xhp +++ b/source/text/swriter/01/04120100.xhp @@ -19,7 +19,7 @@ -Insert or Edit Index Entry +Insert or Edit Index Entry /text/swriter/01/04120100.xhp @@ -33,7 +33,7 @@ Insert or Edit Index Entry -Marks the selected text as index or table of contents entry or edits the selected index entry. +Marks the selected text as index or table of contents entry or edits the selected index entry. Insert: @@ -41,77 +41,77 @@ Edit: -You can leave the Insert Index Entry and Edit Index Entries dialogs open while you select and insert or edit entries. +You can leave the Insert Index Entry and Edit Index Entries dialogs open while you select and insert or edit entries. Selection Index -Select the index that you want to add the entry to. +Select the index that you want to add the entry to. When editing an index entry, displays the type of index that the selected entry belongs to. You cannot change the index type of an index entry in this dialog. Instead, you must delete the index entry from the document, and then insert it again in a different index type. Entry -Displays the text that is selected in the document. If you want, you can enter a different word for the index entry. The selected text in the document is not changed. +Displays the text that is selected in the document. If you want, you can enter a different word for the index entry. The selected text in the document is not changed. Or, edit the index entry if necessary. When you modify the index entry, the new text only appears in the index, and not at the index entry anchor in the document. For example, you can enter an index with comments such as "Basics, see also General". 1st key -Makes the current selection a subentry of the word that you enter here. For example, if you select "cold", and enter "weather" as the 1st key, the index entry is "weather, cold". +Makes the current selection a subentry of the word that you enter here. For example, if you select "cold", and enter "weather" as the 1st key, the index entry is "weather, cold". 2nd key -Makes the current selection a sub-subentry of the 1st key. For example, if you select "cold", and enter "weather" as the 1st key and "winter" as the 2nd key, the index entry is "weather, winter, cold". +Makes the current selection a sub-subentry of the 1st key. For example, if you select "cold", and enter "weather" as the 1st key and "winter" as the 2nd key, the index entry is "weather, winter, cold". Phonetic reading -Enter the phonetic reading for the corresponding entry. For example, if a Japanese Kanji word has more than one pronunciation, enter the correct pronunciation as a Katakana word. The Kanji word is then sorted according to the phonetic reading entry. This option is only available if Asian language support is enabled. +Enter the phonetic reading for the corresponding entry. For example, if a Japanese Kanji word has more than one pronunciation, enter the correct pronunciation as a Katakana word. The Kanji word is then sorted according to the phonetic reading entry. This option is only available if Asian language support is enabled. Main Entry -Makes the selected text the main entry in an alphabetical index. $[officename] displays the page number of the main entry in a different format than the other entries in the index. +Makes the selected text the main entry in an alphabetical index. $[officename] displays the page number of the main entry in a different format than the other entries in the index. Level -Entries using the paragraph format "Heading X" (X = 1-10) can be automatically added to the table of contents. The level of the entry in the index corresponds to the outline level of the heading style. +Entries using the paragraph format "Heading X" (X = 1-10) can be automatically added to the table of contents. The level of the entry in the index corresponds to the outline level of the heading style. This option is available only for table of contents and user-defined index entries. -Apply to all similar texts -Automatically marks all other
[Libreoffice-ux-advise] [Bug 153903] "Category and Number" and "Caption Text" in Cross-reference variable dialog are limited to fixed structural relations
https://bugs.documentfoundation.org/show_bug.cgi?id=153903 sdc.bla...@youmail.dk changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #3 from sdc.bla...@youmail.dk --- Asking for UXEval, because of comment 1. And in relation to the following: 1. Main "problem" is that there is no markup for "Caption text". This issue is already raised somewhat in bug 148597, and according to bug 148597, comment 19 this issue is already on the UXEval agenda. Attachment 185881 in bug 148597, comment 20 elaborates the issues even further. But cross-referencing is not mentioned in bug 148597 or the attachment, so maybe a note about cross-referencing could be added in an appropriate place? 2. Main purpose of the present ticket was to highlight this current behavior/limitation in cross-references. If that limitation is added somewhere in the previous tickets, then this ticket could be converted into a documentation ticket, which could be easily resolved and closed. Slight changes in the documentation [1] can give accurate information about "expected" behavior (without mentioning the structural requirement explicitly). There are three changes in particular. Current text between dashed lines, followed by proposed change. - Category and Number Inserts the category (caption type) and the number of the reference target. This option is only available when the reference target is an object with a caption. - Propose: Inserts the caption category and caption number (or number range variable name and value). Any text between the category and number (or variable name and value) is also inserted. This option is available for all number range variables, which includes caption numbers. -- Caption Text Inserts the caption label of the reference target. This option is only available when the reference target is an object with a caption. Propose: Insert all text that follows the caption category and caption number until end of paragraph. This option is available for all number range variables, which includes caption numbers. Numbering Inserts the caption number of the reference target. This option is only available when the reference target is an object with a caption. --- Propose: "Numbering" -> "Number" Inserts number range value. This option is available for all number range variables, which includes caption numbers. About name change: 1. A little more in parallel with "Category and Number" and "Caption Text", as well as ... 2. ... "Caption Number", which was considered and rejected, because the critical feature is "number range" variable, which does not have to be used only in captions. 3. Perhaps someone thought "Numbering" should be different for "Number" (which appears for Headings and Numbered Paragraphs)? But use context should disambiguate, similarly for help page, where the context is explicitly mentioned. [1] https://help.libreoffice.org/7.6/en-US/text/swriter/01/04090002.html -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 153903] "Category and Number" and "Caption Text" in Cross-reference variable dialog are limited to fixed structural relations
https://bugs.documentfoundation.org/show_bug.cgi?id=153903 sdc.bla...@youmail.dk changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #3 from sdc.bla...@youmail.dk --- Asking for UXEval, because of comment 1. And in relation to the following: 1. Main "problem" is that there is no markup for "Caption text". This issue is already raised somewhat in bug 148597, and according to bug 148597, comment 19 this issue is already on the UXEval agenda. Attachment 185881 in bug 148597, comment 20 elaborates the issues even further. But cross-referencing is not mentioned in bug 148597 or the attachment, so maybe a note about cross-referencing could be added in an appropriate place? 2. Main purpose of the present ticket was to highlight this current behavior/limitation in cross-references. If that limitation is added somewhere in the previous tickets, then this ticket could be converted into a documentation ticket, which could be easily resolved and closed. Slight changes in the documentation [1] can give accurate information about "expected" behavior (without mentioning the structural requirement explicitly). There are three changes in particular. Current text between dashed lines, followed by proposed change. - Category and Number Inserts the category (caption type) and the number of the reference target. This option is only available when the reference target is an object with a caption. - Propose: Inserts the caption category and caption number (or number range variable name and value). Any text between the category and number (or variable name and value) is also inserted. This option is available for all number range variables, which includes caption numbers. -- Caption Text Inserts the caption label of the reference target. This option is only available when the reference target is an object with a caption. Propose: Insert all text that follows the caption category and caption number until end of paragraph. This option is available for all number range variables, which includes caption numbers. Numbering Inserts the caption number of the reference target. This option is only available when the reference target is an object with a caption. --- Propose: "Numbering" -> "Number" Inserts number range value. This option is available for all number range variables, which includes caption numbers. About name change: 1. A little more in parallel with "Category and Number" and "Caption Text", as well as ... 2. ... "Caption Number", which was considered and rejected, because the critical feature is "number range" variable, which does not have to be used only in captions. 3. Perhaps someone thought "Numbering" should be different for "Number" (which appears for Headings and Numbered Paragraphs)? But use context should disambiguate, similarly for help page, where the context is explicitly mentioned. [1] https://help.libreoffice.org/7.6/en-US/text/swriter/01/04090002.html -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152873] Help Writer → Variables → Numbering by Chapter: Wrong description
https://bugs.documentfoundation.org/show_bug.cgi?id=152873 --- Comment #10 from sdc.bla...@youmail.dk --- The revised help is online now https://help.libreoffice.org/7.6/en-US/text/swriter/01/04090005.html?System=UNIX=WRITER, where "Numbering by Chapter" is now "With Heading Number" (as seen in this help file). If you think there are still problems, then you are welcome to write here. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153721] Rename "Move Chapter Up/Down" to "Move Heading+Text Up/Down" in Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=153721 --- Comment #9 from sdc.bla...@youmail.dk --- How about: Heading and Text Up Heading and Text Down Delete Heading and Text -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: writerfilter/source
writerfilter/source/dmapper/DomainMapper_Impl.cxx | 12
1 file changed, 8 insertions(+), 4 deletions(-)
New commits:
commit 6f1052da8d145b1176186024dc4745cbd561fe36
Author: Justin Luth
AuthorDate: Sat Mar 11 17:55:06 2023 -0500
Commit: Justin Luth
CommitDate: Tue Mar 14 22:46:00 2023 +
tdf#154129 writerfilter framePr: check whole style inheritance: hRule
This patch depends on HAnchor, which created vProps.
A style can inherit its properties from another style,
but the code was naively just checking the first paragraph style,
and not any of the parents.
There were no existing ooxmlexport tests where the old and new method
produced different values.
Change-Id: I8648ec7abce5943be4850ec0f2dd054cd9ce1a8b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148716
Reviewed-by: Justin Luth
Tested-by: Jenkins
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index e3baf350b5f9..62dda7d02ac2 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -1651,10 +1651,14 @@ void
DomainMapper_Impl::CheckUnregisteredFrameConversion( )
aFrameProperties.push_back(
comphelper::makePropertyValue(getPropertyName(PROP_HEIGHT),
nHeight));
-sal_Int16 nhRule = sal_Int16(
-rAppendContext.pLastParagraphProperties->GethRule() >= 0 ?
-rAppendContext.pLastParagraphProperties->GethRule() :
-pStyleProperties->props().GethRule());
+sal_Int16 nhRule = -1;
+for (const auto pProp : vProps)
+{
+if (pProp->GethRule() < 0)
+continue;
+nhRule = pProp->GethRule();
+break;
+}
if ( nhRule < 0 )
{
if ( rAppendContext.pLastParagraphProperties->Geth() >= 0 ||
[Libreoffice-commits] core.git: Changes to 'refs/tags/cp-22.05.11-1'
Tag 'cp-22.05.11-1' created by Andras Timar at 2023-03-14 22:38 + cp-22.05.11-1 Changes since co-22.05.10-5-46: --- 0 files changed ---
[Libreoffice-commits] translations.git: Changes to 'refs/tags/cp-22.05.11-1'
Tag 'cp-22.05.11-1' created by Andras Timar at 2023-03-14 22:38 + cp-22.05.11-1 Changes since cp-22.05.10-1-1: --- 0 files changed ---
[Libreoffice-commits] help.git: Changes to 'refs/tags/cp-22.05.11-1'
Tag 'cp-22.05.11-1' created by Andras Timar at 2023-03-14 22:38 + cp-22.05.11-1 Changes since cp-22.05.6-1-1: --- 0 files changed ---
[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/cp-22.05.11-1'
Tag 'cp-22.05.11-1' created by Andras Timar at 2023-03-14 22:38 + cp-22.05.11-1 Changes since cp-22.05.5-2: Aron Budea (1): Add Persian (fa-IR) dictionary --- Dictionary_fa.mk | 21 Module_dictionaries.mk|1 fa_IR/LICENSE | 15 fa_IR/META-INF/manifest.xml |6 fa_IR/README_fa_IR.txt| 26 fa_IR/description.xml | 22 fa_IR/dictionaries.xcu| 19 fa_IR/fa-IR.aff | 217 fa_IR/fa-IR.dic |104025 ++ fa_IR/icon.png|binary fa_IR/package-description.txt |4 11 files changed, 104356 insertions(+) ---
[Libreoffice-commits] core.git: sw/uiconfig
sw/uiconfig/swriter/ui/indexentry.ui |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit fc389f6bfb524c6e7a3aedbe4c4ff1bb8ec1ec40 Author: Seth Chaiklin AuthorDate: Tue Mar 14 12:33:57 2023 + Commit: Adolfo Jayme Barrientos CommitDate: Tue Mar 14 22:34:59 2023 + tdf#153890 "similar texts" -> "other occurrences" + tooltip Change-Id: I95e7fa7334093e5358d1191e42328367e7e8df74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148861 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/sw/uiconfig/swriter/ui/indexentry.ui b/sw/uiconfig/swriter/ui/indexentry.ui index 5c22a9e41119..da80004a4d8f 100644 --- a/sw/uiconfig/swriter/ui/indexentry.ui +++ b/sw/uiconfig/swriter/ui/indexentry.ui @@ -480,8 +480,9 @@ -Apply to all similar texts +Apply to all other occurrences True + Add an index entry to any other occurences of the selected text specified in “Entry”. False True start
[Libreoffice-bugs] [Bug 153890] Rename "Apply to all similar texts" to "Apply to all other occurrences" in Insert - Index Entry dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=153890 Commit Notification changed: What|Removed |Added Whiteboard||target:7.6.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154194] Charts Exported as PNG have misplaced Titles and Labels
https://bugs.documentfoundation.org/show_bug.cgi?id=154194 --- Comment #3 from Thorsten --- Created attachment 185966 --> https://bugs.documentfoundation.org/attachment.cgi?id=185966=edit Another example for correct Titles, Labels and Legend in 7.4.6 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154194] Charts Exported as PNG have misplaced Titles and Labels
https://bugs.documentfoundation.org/show_bug.cgi?id=154194 --- Comment #2 from Thorsten --- Created attachment 185965 --> https://bugs.documentfoundation.org/attachment.cgi?id=185965=edit Another example for misplaced Titles, Labels and Legend in 7.5.1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154194] Charts Exported as PNG have misplaced Titles and Labels
https://bugs.documentfoundation.org/show_bug.cgi?id=154194 --- Comment #1 from Thorsten --- Created attachment 185964 --> https://bugs.documentfoundation.org/attachment.cgi?id=185964=edit Correct Titles, Labels and Legend in 7.4.6 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154194] New: Charts Exported as PNG have misplaced Titles and Labels
https://bugs.documentfoundation.org/show_bug.cgi?id=154194 Bug ID: 154194 Summary: Charts Exported as PNG have misplaced Titles and Labels Product: LibreOffice Version: 7.5.1.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: t...@gmx.net Created attachment 185963 --> https://bugs.documentfoundation.org/attachment.cgi?id=185963=edit Misplaced Titles, Labels and Legend in 7.5.1 In the lastest version (7.5.1) exporting a chart from Calc as PNG renders the graph and the grid correctly, but all texts (titles, axis labels and legend) are misplaced. It worked correctly in the previous version (7.4.6), see attached exemples. -- You are receiving this mail because: You are the assignee for the bug.
Re: Offset uniqueness in vector of ColorSteps
Hi Armin,
Armin Le Grand schrieb am 14.03.2023 um 15:08:
Hi Regina,
good to hear from you, wanted to contact you already anyways, but we
were just moving, so I was pretty busy :-)
On 3/14/23 14:09, Regina Henschel wrote:
Hi Armin,
you put the ColorSteps into a sorted vector with unique offsets of the
ColorSteps.
I see a problem with "unique". Both OOXML and SVG allow several color
stops to have the same offset. Users need it in OOXML and SVG
gradients to create stepped gradients like those from ODF draw:gradient.
Thus forcing uniqueness in our core will give problems in import
filter and in implementing the and
from ODF.
Very good hints, thanks for that.
Indeed I thought about having two (or more) identical ColorStops to
allow a 'rapid' color change at the same offset. I abandoned that by
thinking that a very small step could be used that will never get
visible, so e.g.
0.5
0.501
But allowing multiple identical may express that indeed better.
The problem is and why I chose uniqueness is also/mainly the UI - how to
represent equal ColorSteps in a UI trying to visualize the ColorSteps...?
The UI could have a sorted list (drop-down?) of gradient stops, so that
it is possible to select a gradient stop without using the mouse. Then
fields for position, color and maybe transparency will act on the
selected gradient stop.
But that would be a question for the UX-team.
Export to OOXML writes 0.5 as 5, thus 0.501 would be written as
5 too. If you want uniqueness, the import filter would need to
consider that. I have not looked what conversion from and to SVG does.
So:
- It should then be OK to have a maximum of *two* ColorStops with
identical offset?
I think that could work in common use cases. But the gradient stops will
be available for macros and I don't know what funny things users do in
macros. And I do not know enough about SMIL in ODF to say what
animations are theoretically possible.
- When correcting that, and there are more than two, delete all but 1st
and last? So the in-between ones?
MS Office keeps them. You can traverse the gradient stops with the arrow
keys in the UI of MS Office.
- Also dependent of used colors: if all the same color, identicals can
be deleted, so go to uniqueness.
That would indeed not be visible in rendering and might ease searching.
But here too, how react on using gradient stops in macros?
And Questions for ODF format:
I see e.g. in SVG something like
so I would just add elements like
to our ODF, is that OK from your POV? I remember we once discussed that
already, so should be no problem to do that I guess?
For ODF you need to distinguish from
and .
The relationship between and
to your ColorSteps vector is indeed straight forward. Only the
com::sun::star::util::Color has to be split in svg:stop-color with
#RRGGBB and svg:opacity calculated from alpha.
Using your concept with a stop containing {double Offset,
com::sun::star::util::Color Color} does not work well for
because StartColor and EndColor in are
without alpha. To get transparency you always need parallel a
element.
Having separate and elements in ODF
allows to have gradients with e.g. color change from left to right and
transparency changing from top to bottom. That cannot be expressed with
one sequence of your new ColorSteps vector.
Further problems are the relationship between your ColorSteps vector and
the attributes draw:border and draw:step-count.
I would take out from this the StartColor (AKA offset == 0.0) and the
EndColor (AKA offset == 1.0), so in the normal case there would be no
change at all. >
If there are ColorSteps with offset != 0.0 or 1.0 I would create that
extra-entries for these.
What do you mean by "take out"?
Currently we have something like
draw:display-name="Gradient 2" draw:style="radial" draw:cx="50%"
draw:cy="50%"
draw:start-color="#bf0041"
draw:end-color="#127622"
draw:start-intensity="100%" draw:end-intensity="100%"
draw:border="0%"/>
which would then be something like
draw:display-name="Gradient 2" draw:style="radial" draw:cx="50%"
draw:cy="50%"
draw:start-color="#bf0041"
draw:end-color="#127622"
draw:start-intensity="100%" draw:end-intensity="100%"
draw:border="0%"/>
That do not work for formal reason: You cannot mix attributes and elements.
But in a first step, the line is
not needed at all. On writing the markup the values of draw:start-color
and draw:end-color are calculated from the first and last gradient stop.
These gradient stops need not be at 0% or 100% respectively, because the
colors are continued to 0% or 100%. On reading the markup the gradient
stops at 0% and 100% are calculated from start-color and end-color.
The main task should be to use multi-color gradients to implement the
two svg-gradient types. And change the import and export
[Libreoffice-bugs] [Bug 129547] Default shortcut key for insert current time doesn't work (French)
https://bugs.documentfoundation.org/show_bug.cgi?id=129547 --- Comment #35 from Julien Nabet --- I've submitted a patch here: https://gerrit.libreoffice.org/c/core/+/148903 As I commented in the patch, this one concerns only French UI with azerty keyboard. IMHO the patch should be ok for French people but feel free to comment if we can improve it and make "insert time" command work for other UI with other keyboard layout. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 153740] Writer's Navigator should distinguish between intra-document, filesystem and network hyperlinks
https://bugs.documentfoundation.org/show_bug.cgi?id=153740 Eyal Rozenberg changed: What|Removed |Added Summary|In Writer, there should be |Writer's Navigator should |3 types of hyperlinks |distinguish between ||intra-document, filesystem ||and network hyperlinks -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 153740] Writer's Navigator should distinguish between intra-document, filesystem and network hyperlinks
https://bugs.documentfoundation.org/show_bug.cgi?id=153740 Eyal Rozenberg changed: What|Removed |Added Summary|In Writer, there should be |Writer's Navigator should |3 types of hyperlinks |distinguish between ||intra-document, filesystem ||and network hyperlinks -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 153740] In Writer, there should be 3 types of hyperlinks
https://bugs.documentfoundation.org/show_bug.cgi?id=153740 --- Comment #7 from Eyal Rozenberg --- (In reply to Heiko Tietze from comment #3) > Some ideas: We could use underline to identify three variants: without, > single, double. Would be hard to understand, has no room for more > differentiation and clashes with the customization. So, not such a great idea. > Splitting the Hyperlinks section of the Navigator sounds wrong. I disagree. Or rather - I think both ways of arranging the links have merit - are useful in different scenarios. Perhaps we could have some toggle to switch between them? > I > could imagine nice design-wise and effective is an icon next to the entry > that indicates what type it is. Hmmm. Maybe. I don't know if I like the extra cluttering. Also, when I look at a link, I can tell what kind of destination it has by hovering over it. So will this be that useful? -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 153740] In Writer, there should be 3 types of hyperlinks
https://bugs.documentfoundation.org/show_bug.cgi?id=153740 --- Comment #7 from Eyal Rozenberg --- (In reply to Heiko Tietze from comment #3) > Some ideas: We could use underline to identify three variants: without, > single, double. Would be hard to understand, has no room for more > differentiation and clashes with the customization. So, not such a great idea. > Splitting the Hyperlinks section of the Navigator sounds wrong. I disagree. Or rather - I think both ways of arranging the links have merit - are useful in different scenarios. Perhaps we could have some toggle to switch between them? > I > could imagine nice design-wise and effective is an icon next to the entry > that indicates what type it is. Hmmm. Maybe. I don't know if I like the extra cluttering. Also, when I look at a link, I can tell what kind of destination it has by hovering over it. So will this be that useful? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/ios vcl/source
vcl/ios/iOSTransferable.cxx | 10 ++
vcl/source/window/dialog.cxx | 13 +
2 files changed, 23 insertions(+)
New commits:
commit b0b8815fffcd1d3862a4784fe93bb7c9d66b7d1c
Author: Patrick Luby
AuthorDate: Fri Mar 10 12:11:25 2023 -0500
Commit: Patrick Luby
CommitDate: Tue Mar 14 21:42:24 2023 +
Handle pasting disallowed clipboard contents on iOS
When another app owns the current clipboard contents, pasting
will display a "allow or disallow" dialog. If the disallow
option is selected, the data from the UIPasteboard will be
garbage and GetLOKNotifier() will return a nullptr. Since calling
SetLOKNotifier() with a nullptr aborts in an assert(), fix the
crash by failing gracefully.
Also, throw an exception if the -[UIPasteboard dataForPasteboardType:]
returns nil. By throwing an exception, the "allow or disallow"
dialog will display again the next time the user tries to paste.
Change-Id: I05d689b679a7643a8478e3ce0f416205fdf8ec23
Reference-to: https://github.com/CollaboraOnline/online/issues/5908
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148655
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Andras Timar
(cherry picked from commit 1dd68786a927a23e5465589025abd90b8c9f4e7b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148627
Tested-by: Jenkins
Reviewed-by: Patrick Luby
diff --git a/vcl/ios/iOSTransferable.cxx b/vcl/ios/iOSTransferable.cxx
index ece771e7f60b..bfbc8a9afa82 100644
--- a/vcl/ios/iOSTransferable.cxx
+++ b/vcl/ios/iOSTransferable.cxx
@@ -109,6 +109,16 @@ Any SAL_CALL iOSTransferable::getTransferData(const
DataFlavor& aFlavor)
DataProviderPtr_t dp;
NSData* sysData = [[UIPasteboard generalPasteboard]
dataForPasteboardType:sysFormat];
+if (!sysData)
+{
+// Related: gh#5908 throw an exception if the data flavor is nil
+// If nil is returned, it can mean that the user has selected the
+// "disallow" option and so we can't access the current clipboard
+// contents. Also, by throwing an exception, the "allow or disallow"
+// dialog will display again the next time the user tries to paste.
+throw UnsupportedFlavorException("Data flavor is nil",
static_cast(this));
+}
+
dp = DataFlavorMapper::getDataProvider(sysFormat, sysData);
if (dp.get() == nullptr)
diff --git a/vcl/source/window/dialog.cxx b/vcl/source/window/dialog.cxx
index a255ed4b9a47..3327e371e6c1 100644
--- a/vcl/source/window/dialog.cxx
+++ b/vcl/source/window/dialog.cxx
@@ -926,7 +926,20 @@ bool Dialog::ImplStartExecute()
if (bModal)
{
if (bKitActive && !GetLOKNotifier())
+{
+#ifdef IOS
+// gh#5908 handle pasting disallowed clipboard contents on iOS
+// When another app owns the current clipboard contents, pasting
+// will display a "allow or disallow" dialog. If the disallow
+// option is selected, the data from the UIPasteboard will be
+// garbage and we will find ourselves here. Since calling
+// SetLOKNotifier() with a nullptr aborts in an assert(), fix
+// the crash by failing gracefully.
+return false;
+#else
SetLOKNotifier(mpDialogImpl->m_aInstallLOKNotifierHdl.Call(nullptr));
+#endif
+}
switch ( Application::GetDialogCancelMode() )
{
[Libreoffice-bugs] [Bug 153793] The Groupedbar works on 7.1.7.2 using Big Sur, but every single update since has broken it.
https://bugs.documentfoundation.org/show_bug.cgi?id=153793 --- Comment #6 from MalcG --- Created attachment 185962 --> https://bugs.documentfoundation.org/attachment.cgi?id=185962=edit Screen grab -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153793] The Groupedbar works on 7.1.7.2 using Big Sur, but every single update since has broken it.
https://bugs.documentfoundation.org/show_bug.cgi?id=153793 --- Comment #5 from MalcG --- Looks sorted, thank you, I'll add a screengrab -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154191] Letters drawing outside the margin
https://bugs.documentfoundation.org/show_bug.cgi?id=154191 --- Comment #4 from Jonathan Roy --- I'm no expert on any of this, just an end user, but if the font is designed intentionally to let parts of letters overlap other letters (which it is I'm sure because of how this font works), that still shouldn't let it exceed the edges of the margin through, right? I assumed the margin would be the final authority on where a font is allowed to draw onto. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154189] Opening an xlsx in 7.5.1 removes color and border formatting which used to show in 7.3.5 and shows in Excel
https://bugs.documentfoundation.org/show_bug.cgi?id=154189 --- Comment #5 from simpson.sc...@icloud.com --- I’ve been using libreoffice to open these rotas that are made in Excel but always based on the same template. The only thing I can think of that’s changed has been I e updated to 7.5.1 from 7.3.5 but I’m not sure if it’s been entirely since updating. I don’t think there have been any other changes to libreoffice. Thanks -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154071] Request: Rename "Square" gradient to "Rectangular" gradient in the UI
https://bugs.documentfoundation.org/show_bug.cgi?id=154071
--- Comment #3 from Eyal Rozenberg ---
> The term "quadratic" means mathematically "power 2", e.g. 5^2.
Actually, it means "square-ish" or "square-related". Quadratic equations, while
involving powers of 2, are named after squares.
That being said...
* I agree that the changes Regina suggested are a clear improvement over the
current choice of names.
* I don't like most of the existing names. They are not sufficiently
descriptive; their semantics don't agree ("axial" is not the opposite of
"radial") and it's probably not even possible to properly describe the
gradiants with just a single word. We also have a lot of drop-down box
real-estate for a longer phrase, so maybe that should be considered.
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 154071] Request: Rename "Square" gradient to "Rectangular" gradient in the UI
https://bugs.documentfoundation.org/show_bug.cgi?id=154071
--- Comment #3 from Eyal Rozenberg ---
> The term "quadratic" means mathematically "power 2", e.g. 5^2.
Actually, it means "square-ish" or "square-related". Quadratic equations, while
involving powers of 2, are named after squares.
That being said...
* I agree that the changes Regina suggested are a clear improvement over the
current choice of names.
* I don't like most of the existing names. They are not sufficiently
descriptive; their semantics don't agree ("axial" is not the opposite of
"radial") and it's probably not even possible to properly describe the
gradiants with just a single word. We also have a lot of drop-down box
real-estate for a longer phrase, so maybe that should be considered.
--
You are receiving this mail because:
You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 115121] [META] Heading numbering dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=115121 Dieter changed: What|Removed |Added Alias|Chapter-Numbering-Dialog|Heading-Numbering-Dialog Summary|[META] Chapter numbering|[META] Heading numbering |dialog bugs and |dialog bugs and |enhancements|enhancements --- Comment #1 from Dieter --- Since LO 7.6 chapter numbering is renamed to heading numbering, so I've changed Alias. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 117818] CHAPTER NUMBERING DIALOG: Preview doesn't work as expected for Position (steps in comment 1)
https://bugs.documentfoundation.org/show_bug.cgi?id=117818 --- Comment #16 from Dieter --- Still present in Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: d7c609dbb1bd08865b43719d2fb7c316d30bcde5 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: en-US (de_DE); UI: en-GB Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154191] Letters drawing outside the margin
https://bugs.documentfoundation.org/show_bug.cgi?id=154191 V Stuart Foote changed: What|Removed |Added CC||kha...@aliftype.com, ||vsfo...@libreoffice.org --- Comment #3 from V Stuart Foote --- I don't own the font. But that and similar would be font metric issue where the swashes extend beyond em space by design. I believe it is expected. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153912] software changes and adds bookmarks
https://bugs.documentfoundation.org/show_bug.cgi?id=153912 Dieter changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 CC||dgp-m...@gmx.de --- Comment #1 from Dieter --- Thank you for reporting the bug. Please add a sample document, that shows the bug. If possible, please narrow down the problem to some steps, that reproduces the problem. Thank you. => NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153892] icons for "Insert Table of Contents, Index, or Bibliography" and "Insert Index Entry" should be differentiated
https://bugs.documentfoundation.org/show_bug.cgi?id=153892 Dieter changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Severity|normal |minor CC||dgp-m...@gmx.de, ||riz...@libreoffice.org --- Comment #2 from Dieter --- (In reply to sdc.blanco from comment #1) > (In reply to sdc.blanco from comment #0) > > 1. View - Toolbars - Tools, click on dropdown arrow for first icon. > Even easier: View - Toolbars - Insert (see last two icons) I confirm it with Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: d7c609dbb1bd08865b43719d2fb7c316d30bcde5 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: en-US (de_DE); UI: en-GB Calc: CL threaded Rizal, any ideas about a good solution? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 149015] Impress: Improve search for animations
https://bugs.documentfoundation.org/show_bug.cgi?id=149015 --- Comment #4 from Eyal Rozenberg --- (In reply to Caolán McNamara from comment #3) > The other cases are using a SvTreeListBox and it does look like it just > searches for an entry that starts with the last pressed character, unlike > the ComboBox above Above what? > which will show Exit if you type Ex. So acting like the > ComboBox makes sense to me Do you mean generally, or just this "tree list box"? I'd support both, especially the former :-P -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 149015] Impress: Improve search for animations
https://bugs.documentfoundation.org/show_bug.cgi?id=149015 --- Comment #4 from Eyal Rozenberg --- (In reply to Caolán McNamara from comment #3) > The other cases are using a SvTreeListBox and it does look like it just > searches for an entry that starts with the last pressed character, unlike > the ComboBox above Above what? > which will show Exit if you type Ex. So acting like the > ComboBox makes sense to me Do you mean generally, or just this "tree list box"? I'd support both, especially the former :-P -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154193] New: Inserted SVG is distorted after exporting to PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=154193 Bug ID: 154193 Summary: Inserted SVG is distorted after exporting to PDF Product: LibreOffice Version: 7.5.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: med.medin.2...@gmail.com Created attachment 185961 --> https://bugs.documentfoundation.org/attachment.cgi?id=185961=edit Inserted SVG is distorted after exporting to PDF If I import an SVG image inside Writer then export the odt file to PDF, the paths of SVG are distorted. See attached files for more info. Version: 7.5.0.3 (X86_64) / LibreOffice Community Build ID: 50(Build:3) CPU threads: 2; OS: Linux 6.1; UI render: default; VCL: kf5 (cairo+xcb) Locale: en-US (en_US.UTF-8); UI: en-US 7.5.0-1 Calc: threaded Operating System: Manjaro Linux KDE Plasma Version: 5.26.5 KDE Frameworks Version: 5.103.0 Qt Version: 5.15.8 Kernel Version: 6.1.12-1-MANJARO (64-bit) Graphics Platform: X11 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154192] New: FILEOPEN DOCX: import fails special case for anchor-after-break in last paragraph of the document
https://bugs.documentfoundation.org/show_bug.cgi?id=154192 Bug ID: 154192 Summary: FILEOPEN DOCX: import fails special case for anchor-after-break in last paragraph of the document Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Keywords: filter:docx Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jl...@mail.com CC: jl...@mail.com Blocks: 108771 Created attachment 185960 --> https://bugs.documentfoundation.org/attachment.cgi?id=185960=edit shapeAnchorPageBreak3c.docx: I guess you could call it a regression because anchoring was wrong before 7.6, but it worked in this special situation. In any case, the difference here is simply adding a at the end of the document causes the shapes to move before the break. LO has never identified the last paragraph of the document during import, so this is really inherited from OOo. Compare this to ooxmlexport18's tdf153613_textboxAfterPgBreak3.docx (which is not the last paragraph). [I used Word 2010.] Steps to reproduce 1- open the document in LO. Notice that the two shapes on the first page. In Word, they are on the second page - the first page is blank. As a code pointer, see 7.6 commit a9bc19c2d4a35606668aa2dcc53355651b71ee78 Author: Justin Luth on Wed Feb 15 13:54:31 2023 -0500 tdf#153613 writerfilter: don't always split para for shape w/ pagebreak Before this commit it accidentally looked good. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108771 [Bug 108771] [META] DOCX (OOXML) page-related issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108771] [META] DOCX (OOXML) page-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=108771 Justin L changed: What|Removed |Added Depends on||154192 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=154192 [Bug 154192] FILEOPEN DOCX: import fails special case for anchor-after-break in last paragraph of the document -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 117037] localc does not understand unicode minus
https://bugs.documentfoundation.org/show_bug.cgi?id=117037 Commit Notification changed: What|Removed |Added Whiteboard||target:7.6.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 117037] localc does not understand unicode minus
https://bugs.documentfoundation.org/show_bug.cgi?id=117037 --- Comment #13 from Commit Notification --- Andreas Heinisch committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/34510e6e57e58fb27071564f546bbd420404e66d tdf#117037 - Support Unicode minus (0x2212) in the number scanner It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: svl/source
svl/source/numbers/zforfind.cxx |3 +++
1 file changed, 3 insertions(+)
New commits:
commit 34510e6e57e58fb27071564f546bbd420404e66d
Author: Andreas Heinisch
AuthorDate: Tue Mar 7 16:02:22 2023 +0100
Commit: Eike Rathke
CommitDate: Tue Mar 14 20:39:33 2023 +
tdf#117037 - Support Unicode minus (0x2212) in the number scanner
Change-Id: I5b2cd4f3d6ac23e10dc0745819c7955d0a8ff170
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148432
Tested-by: Jenkins
Reviewed-by: Eike Rathke
diff --git a/svl/source/numbers/zforfind.cxx b/svl/source/numbers/zforfind.cxx
index de5aacf69d2b..da993232e677 100644
--- a/svl/source/numbers/zforfind.cxx
+++ b/svl/source/numbers/zforfind.cxx
@@ -906,6 +906,7 @@ inline bool ImpSvNumberInputScan::GetTime100SecSep(
std::u16string_view rString,
* Read a sign including brackets
* '+' => 1
* '-' => -1
+ * u'−' => -1
* '(' => -1, bNegCheck = 1
* else => 0
*/
@@ -921,6 +922,8 @@ int ImpSvNumberInputScan::GetSign( std::u16string_view
rString, sal_Int32& nPos
bNegCheck = true;
[[fallthrough]];
case '-':
+// tdf#117037 - unicode minus (0x2212)
+case u'−':
nPos++;
return -1;
default:
[Libreoffice-bugs] [Bug 153793] The Groupedbar works on 7.1.7.2 using Big Sur, but every single update since has broken it.
https://bugs.documentfoundation.org/show_bug.cgi?id=153793 --- Comment #4 from Stéphane Guillou (stragu) --- Yes, same thing. The latest version in the 7.5 series is 7.5.1.2. It's the top one on our download page: https://www.libreoffice.org/download/download-libreoffice/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150330] Impress: Document template window stays open on Impress crash (GTK3?)
https://bugs.documentfoundation.org/show_bug.cgi?id=150330 --- Comment #7 from BDF --- I just saw your comment and I will re test it as soon as possible -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108252] [META] Cell-related bugs and enhancements (including formatting)
https://bugs.documentfoundation.org/show_bug.cgi?id=108252 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||154189 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=154189 [Bug 154189] Opening an xlsx in 7.5.1 removes color and border formatting which used to show in 7.3.5 and shows in Excel -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154189] Opening an xlsx in 7.5.1 removes color and border formatting which used to show in 7.3.5 and shows in Excel
https://bugs.documentfoundation.org/show_bug.cgi?id=154189 Stéphane Guillou (stragu) changed: What|Removed |Added Blocks||108252 Version|7.5.1.2 release |Inherited From OOo Keywords||filter:xlsx CC||stephane.guillou@libreoffic ||e.org Hardware|x86 (IA32) |All OS|Windows (All) |All --- Comment #4 from Stéphane Guillou (stragu) --- No formatting either in: OpenOffice.org 3.3.0 OOO330m20 (Build:9567) I also tested a recent trunk build on Linux and Windows 10, and 7.3.0.3 on Windows 10, but could never see the formatting. I can confirm the sheet is formatted with borders and cell background colours throughout in: Microsoft® Excel® for Microsoft 365 MSO (Version 2302 Build 16.0.16130.20186) 64-bit simpson.scott, are you sure you ever saw LibreOffice display the formatting on that file? Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108252 [Bug 108252] [META] Cell-related bugs and enhancements (including formatting) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit bc9bbb2967333e95cd61c169469ddec710f63001 Author: Olivier Hallot AuthorDate: Tue Mar 14 20:15:28 2023 + Commit: Gerrit Code Review CommitDate: Tue Mar 14 20:15:28 2023 + Update git submodules * Update helpcontent2 from branch 'libreoffice-7-5' to 2e20831fd6dc0312f040feecef2224292b6b6690 - Mute l10n or string. Change-Id: I1ecfc8a5bf6b64060a92be1a48cd0cf877671236 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148866 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos (cherry picked from commit bb8d72b1f2339d1f5df72ae49f4bd93f7d53c02c) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148867 diff --git a/helpcontent2 b/helpcontent2 index 4faac784e3d9..2e20831fd6dc 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 4faac784e3d903aae9169cad23bb064037205f1f +Subproject commit 2e20831fd6dc0312f040feecef2224292b6b6690
[Libreoffice-commits] help.git: Branch 'libreoffice-7-5' - source/text
source/text/scalc/01/05120100.xhp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 2e20831fd6dc0312f040feecef2224292b6b6690 Author: Olivier Hallot AuthorDate: Tue Mar 14 19:57:06 2023 + Commit: Adolfo Jayme Barrientos CommitDate: Tue Mar 14 20:15:28 2023 + Mute l10n or string. Change-Id: I1ecfc8a5bf6b64060a92be1a48cd0cf877671236 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148866 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos (cherry picked from commit bb8d72b1f2339d1f5df72ae49f4bd93f7d53c02c) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148867 diff --git a/source/text/scalc/01/05120100.xhp b/source/text/scalc/01/05120100.xhp index 7328fa20f0..4e4f78fff3 100644 --- a/source/text/scalc/01/05120100.xhp +++ b/source/text/scalc/01/05120100.xhp @@ -262,7 +262,7 @@ A cell that references another cell with an error condition is not in error itself. - +
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 411dbbe8117eefe4166dd5f75525b25fa58d3fb9 Author: Olivier Hallot AuthorDate: Tue Mar 14 20:14:17 2023 + Commit: Gerrit Code Review CommitDate: Tue Mar 14 20:14:17 2023 + Update git submodules * Update helpcontent2 from branch 'master' to 9309d69eab4f5bedc266b2286a9b0e5f0a06e295 - Mute l10n or string. Change-Id: I1ecfc8a5bf6b64060a92be1a48cd0cf877671236 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148866 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/helpcontent2 b/helpcontent2 index 36f71cb8d29f..9309d69eab4f 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 36f71cb8d29fde0c8b42238ba59bc1d73b042cc6 +Subproject commit 9309d69eab4f5bedc266b2286a9b0e5f0a06e295
[Libreoffice-commits] help.git: source/text
source/text/scalc/01/05120100.xhp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 9309d69eab4f5bedc266b2286a9b0e5f0a06e295 Author: Olivier Hallot AuthorDate: Tue Mar 14 19:57:06 2023 + Commit: Adolfo Jayme Barrientos CommitDate: Tue Mar 14 20:14:17 2023 + Mute l10n or string. Change-Id: I1ecfc8a5bf6b64060a92be1a48cd0cf877671236 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148866 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/source/text/scalc/01/05120100.xhp b/source/text/scalc/01/05120100.xhp index 48d5c91184..bd604b64b7 100644 --- a/source/text/scalc/01/05120100.xhp +++ b/source/text/scalc/01/05120100.xhp @@ -262,7 +262,7 @@ A cell that references another cell with an error condition is not in error itself. - +
[Libreoffice-bugs] [Bug 154191] Letters drawing outside the margin
https://bugs.documentfoundation.org/show_bug.cgi?id=154191 --- Comment #2 from Jonathan Roy --- Created attachment 185959 --> https://bugs.documentfoundation.org/attachment.cgi?id=185959=edit Screenshot showing right justified text outside the margin -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154191] Letters drawing outside the margin
https://bugs.documentfoundation.org/show_bug.cgi?id=154191 --- Comment #1 from Jonathan Roy --- Created attachment 185958 --> https://bugs.documentfoundation.org/attachment.cgi?id=185958=edit Screenshot showing left justified text outside the margin -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154191] New: Letters drawing outside the margin
https://bugs.documentfoundation.org/show_bug.cgi?id=154191 Bug ID: 154191 Summary: Letters drawing outside the margin Product: LibreOffice Version: 7.5.1.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jonr...@gmail.com Description: Using the Akira font from Ikiiko Type, I find that some letters (easiest to see on the letter j) if it's the first letter in the word on a line, will be drawn beyond the margins instead of the letter being moved further to the right. It doesn't happen in other word processors, so I'm guessing it isn't an error within the font itself? I don't know how I'd even check something like that. Here's a screenshot of a fresh document, font set to Akira, wrote some text at default 12 point size, then highlighted it all. You can see how the 'j', 'J', and 'A' draw slightly outside the margin. It will render this way when exporting to PDF, so it isn't simple a display issue. https://puu.sh/JBCnI/84857492bb.png It also happens with right justified text, such as on the 't' and 'n': http://puu.sh/JBCpg/22bdbbd6fd.png Steps to Reproduce: 1. Write some words in Akira font 2. Certain letters, such as J and j, will draw outside the left margin Actual Results: Leftmost letters, such as those listed, draw beyond the margin. Expected Results: The lines should have been moved far enough to the right so that nothing is drawn outside the margin. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.5.1.2 (X86_64) / LibreOffice Community Build ID: fcbaee479e84c6cd81291587d2ee68cba099e129 CPU threads: 16; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: bin/create-dmg-from-merged-app-bundle solenv/bin
bin/create-dmg-from-merged-app-bundle | 77 -- solenv/bin/macosx-codesign-app-bundle | 10 ++-- 2 files changed, 79 insertions(+), 8 deletions(-) New commits: commit b355f4e88998cc953b135933f554d773964badc2 Author: Patrick Luby AuthorDate: Wed Mar 8 14:59:59 2023 -0500 Commit: Patrick Luby CommitDate: Tue Mar 14 20:04:59 2023 + Improve scripts that codesign and create a .dmg from a Universal bundle This change adds the following: - The solenv/bin/macosx-codesign-app-bundle script now uses "--timestamp" wherever "--options runtime" is used in order to pass Apple's notarization process. - A second, required argument has been added to the bin/create-dmg-from-merged-app-bundle script that specifies one of the following types: "release", "dev", or "collabora". Only the .DS_Store is different for each as no product set a volume icon currently. - Upon success, the bin/create-dmg-from-merged-app-bundle script will print a warning that the .dmg is not notarized as well as the commands to use to manually notarize the .dmg. Change-Id: I7c3f2d60dbb16b25bd6088b7e0af8c82284702d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148490 Tested-by: Jenkins CollaboraOffice Reviewed-by: Patrick Luby Reviewed-by: Andras Timar (cherry picked from commit 86e612db56be2d1934275de021b3213875e9301d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148508 Tested-by: Jenkins diff --git a/bin/create-dmg-from-merged-app-bundle b/bin/create-dmg-from-merged-app-bundle index 8f32e4d24b3e..483b1298d7c9 100755 --- a/bin/create-dmg-from-merged-app-bundle +++ b/bin/create-dmg-from-merged-app-bundle @@ -20,8 +20,9 @@ if [ `uname` != Darwin ]; then exit 1 fi -if [ $# != 1 ]; then -echo Usage: $0 signed-app-bundle +if [ $# != 2 ]; then +echo Usage: $0 signed-app-bundle type +echo " where type is 'release', 'dev', or 'collabora'" exit 1 fi @@ -35,12 +36,29 @@ if [[ "$1" != *.app ]]; then exit 1 fi +DSSTOREFILE= +VOLUMEICON= +if [ "$2" = "release" ];then +DSSTOREFILE=DS_Store +elif [ "$2" = "dev" ];then +DSSTOREFILE=DS_Store_Dev +elif [ "$2" = "collabora" ];then +DSSTOREFILE=DS_Store +# Collabora is not currently using a volume icon +#VOLUMEICON=main.icns +else +echo "type argument $2 is not equal to 'release', 'dev', or 'collabora'" >&2 +exit 1 +fi + IN=$(cd "$1" && /bin/pwd) INAPP=$(basename "$IN") INDIR=$(dirname "$IN") OUTVOLUME=$(basename "$IN" .app) +OUTVOLUMEMOUNT=/Volumes/"$OUTVOLUME" OUTTMPDIR=$(dirname "$IN")/"$OUTVOLUME" OUTFILE="$OUTTMPDIR".dmg +OUTFILETMP="$OUTTMPDIR".tmp.dmg SRCDIR=$(cd `dirname "$0"`/.. && /bin/pwd) # Create $OUTTMPDIR directory in the same directory as the output .dmg and @@ -56,6 +74,16 @@ if [ -d "$OUTFILE" ]; then exit 1 fi +if [ -f "$OUTFILETMP" ]; then +echo The file $OUTFILETMP exists already >&2 +exit 1 +fi + +if [ -d "$OUTFILETMP" ]; then +echo $OUTFILETMP exists and is a directory >&2 +exit 1 +fi + if [ -d "$OUTTMPDIR" ]; then echo The directory $OUTTMPDIR exists already >&2 exit 1 @@ -66,16 +94,59 @@ if [ -f "$OUTTMPDIR" ]; then exit 1 fi +if [ -d "$OUTVOLUMEMOUNT" ]; then +echo The directory $OUTVOLUMEMOUNT exists already >&2 +exit 1 +fi + +if [ -f "$OUTVOLUMEMOUNT" ]; then +echo $OUTVOLUMEMOUNT exists and is a file >&2 +exit 1 +fi + mkdir "$OUTTMPDIR" mkdir "$OUTTMPDIR"/.background tar cf - "$INAPP" -C "$INDIR" | tar xvpf - -C "$OUTTMPDIR" ln -s /Applications "$OUTTMPDIR"/Applications cp "$SRCDIR"/setup_native/source/packinfo/DS_Store "$OUTTMPDIR"/.DS_Store -cp "$SRCDIR"/setup_native/source/packinfo/VolumeIcon.icns "$OUTTMPDIR"/.VolumeIcon.icns +if [ ! -z "$VOLUMEICON" ]; then +cp "$SRCDIR"/sysui/desktop/icons/"$VOLUMEICON" "$OUTTMPDIR"/.VolumeIcon.icns +fi cp "$SRCDIR"/setup_native/source/packinfo/osxdndinstall.png "$OUTTMPDIR"/.background/background.png # Create and mount empty .dmg +sync + +if [ -z "$VOLUMEICON" ]; then # Copied and adapted to bash from solenv/bin/modules/installer/simplepackage.pm # tdf#151341 Use lzfse compression instead of bzip2 hdiutil create -srcfolder "$OUTTMPDIR" "$OUTFILE" -ov -fs HFS+ -volname "$OUTVOLUME" -format ULFO +else +# To set a volume icon, we need to create a writable .dmg, mount it, set the +# volume icon, unmount it, and then convert it to a read-only .dmg +hdiutil create -srcfolder "$OUTTMPDIR" "$OUTFILETMP" -ov -fs HFS+ -volname "$OUTVOLUME" -format UDRW +sync +hdiutil attach "$OUTFILETMP" +if [ -f "$OUTVOLUMEMOUNT"/.VolumeIcon.icns ]; then +# TODO: SetFile is deprecated so we will eventually need to find another +# way to set the volume icon or stop trying to set the volume icon +SetFile -a C "$OUTVOLUMEMOUNT" +fi +hdiutil detach "$OUTVOLUMEMOUNT" +sync +hdiutil convert "$OUTFILETMP" -format ULFO -o "$OUTFILE" +fi +
[Libreoffice-bugs] [Bug 153949] dialogs unreadable in dark mode after some time on mac
https://bugs.documentfoundation.org/show_bug.cgi?id=153949 --- Comment #4 from Caolán McNamara --- wrt https://bugs.documentfoundation.org/show_bug.cgi?id=153416#c20 I wonder if this is still reproducible with a recent daily build to see if the change mentioned there made any difference. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153416] Some buttons are white-on-white on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=153416 --- Comment #21 from Caolán McNamara --- ah yes, forgot about that recent change, provides some hope. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: 2 commits - sc/qa
sc/qa/unit/scshapetest.cxx | 176 ++---
1 file changed, 56 insertions(+), 120 deletions(-)
New commits:
commit 189bd2fee8d5cf0ae7189b3f1fb64471a42831d2
Author: Xisco Fauli
AuthorDate: Tue Mar 14 12:43:34 2023 +0100
Commit: Xisco Fauli
CommitDate: Tue Mar 14 19:51:29 2023 +
CppunitTest_sc_shapetest: pass parent path to ScModelTestBase
So it can use other file formats
Change-Id: Id8c3e3bd185f6e01d3e375c24c063a9f897c0b5a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148851
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sc/qa/unit/scshapetest.cxx b/sc/qa/unit/scshapetest.cxx
index 41c5db0a965a..465e69693b3e 100644
--- a/sc/qa/unit/scshapetest.cxx
+++ b/sc/qa/unit/scshapetest.cxx
@@ -40,7 +40,7 @@ class ScShapeTest : public ScModelTestBase
{
public:
ScShapeTest()
-: ScModelTestBase("sc/qa/unit/data/ods")
+: ScModelTestBase("sc/qa/unit/data")
{
}
};
@@ -135,7 +135,7 @@ CPPUNIT_TEST_FIXTURE(ScShapeTest,
testTdf144242_Line_noSwapWH)
CPPUNIT_TEST_FIXTURE(ScShapeTest, testTdf143619_validation_circle_pos)
{
// Load a document, which has validation circle around cell E6.
-createScDoc("tdf143619_validationCirclePos.ods");
+createScDoc("ods/tdf143619_validationCirclePos.ods");
// Get document
ScDocument* pDoc = getScDoc();
@@ -163,7 +163,7 @@ CPPUNIT_TEST_FIXTURE(ScShapeTest,
testTdf140252_DragCreateFormControl)
// Error was, that drag-created form controls were initially not on layer
'controls' and thus
// other shapes could be placed in front of form controls.
// Load an empty document.
-createScDoc("ManualColWidthRowHeight.ods");
+createScDoc("ods/ManualColWidthRowHeight.ods");
// Get ScTabViewShell
ScTabViewShell* pTabViewShell = getViewShell();
@@ -209,7 +209,7 @@ CPPUNIT_TEST_FIXTURE(ScShapeTest,
testTdf134355_DragCreateCustomShape)
// layer is exclusively for form controls. Effect was, that other shapes
could not be brought in
// front of custom shapes.
// Load an empty document.
-createScDoc("ManualColWidthRowHeight.ods");
+createScDoc("ods/ManualColWidthRowHeight.ods");
// Get ScTabView
ScTabViewShell* pTabViewShell = getViewShell();
@@ -248,7 +248,7 @@ CPPUNIT_TEST_FIXTURE(ScShapeTest,
testTdf140252_LayerOfControl)
// Error was, that a newly inserted control shape was put on layer
// "vorne" instead of layer "control".
// Load an empty document.
-createScDoc("ManualColWidthRowHeight.ods");
+createScDoc("ods/ManualColWidthRowHeight.ods");
// Create default push button
SfxUInt16Item aIdentifierItem(SID_FM_CONTROL_IDENTIFIER,
@@ -277,7 +277,7 @@ CPPUNIT_TEST_FIXTURE(ScShapeTest, testTdf137082_LTR_to_RTL)
// mirrored. Graphics are still not mirrored but shifted. This test makes
sure a shape is mirrored
// and an image is not mirrored.
-createScDoc("tdf137082_LTR_arrow_image.ods");
+createScDoc("ods/tdf137082_LTR_arrow_image.ods");
// Get document
ScDocument* pDoc = getScDoc();
@@ -306,7 +306,7 @@ CPPUNIT_TEST_FIXTURE(ScShapeTest,
testTdf137082_RTL_cell_anchored)
{
// Error was, that cell anchored custom shapes wrote wrong offsets to file
and thus were wrong on
// reloading. The file contains one custom shape with "resize" and another
one without.
-createScDoc("tdf137082_RTL_cell_anchored.ods");
+createScDoc("ods/tdf137082_RTL_cell_anchored.ods");
// Get document
ScDocument* pDoc = getScDoc();
@@ -341,7 +341,7 @@ CPPUNIT_TEST_FIXTURE(ScShapeTest,
testTdf137081_RTL_page_anchored)
{
// Error was, that page anchored lines and custom shapes were mirrored on
opening. The document
// contains measure line, polyline and transformed custom shape.
-createScDoc("tdf137081_RTL_page_anchored.ods");
+createScDoc("ods/tdf137081_RTL_page_anchored.ods");
// Get document
ScDocument* pDoc = getScDoc();
@@ -398,7 +398,7 @@ CPPUNIT_TEST_FIXTURE(ScShapeTest,
testTdf137081_RTL_page_anchored)
CPPUNIT_TEST_FIXTURE(ScShapeTest, testTdf139583_Rotate180deg)
{
// Load an empty document.
-createScDoc("ManualColWidthRowHeight.ods");
+createScDoc("ods/ManualColWidthRowHeight.ods");
// Get document and draw page
ScDocument* pDoc = getScDoc();
@@ -433,7 +433,7 @@ CPPUNIT_TEST_FIXTURE(ScShapeTest,
testTdf137033_FlipHori_Resize)
{
// Load a document, which has a rotated custom shape, which is horizontal
flipped. Error was, that
// if such shape was anchored "resize with cell", then after save and
reload it was distorted.
-createScDoc("tdf137033_FlipHoriRotCustomShape.ods");
+createScDoc("ods/tdf137033_FlipHoriRotCustomShape.ods");
// Get document and shape
ScDocument* pDoc = getScDoc();
@@ -464,7 +464,7 @@ CPPUNIT_TEST_FIXTURE(ScShapeTest,
testTdf137033_RotShear_ResizeHide)
// of the full sized shape were
[Libreoffice-commits] core.git: sc/qa
sc/qa/unit/data/functions/spreadsheet/fods/error.type.fods | 20 - 1 file changed, 19 insertions(+), 1 deletion(-) New commits: commit 6e6020d01cfc373c6117164d112f59fdbfe2463d Author: Xisco Fauli AuthorDate: Tue Mar 14 10:55:17 2023 +0100 Commit: Xisco Fauli CommitDate: Tue Mar 14 19:50:48 2023 + tdf#154167: sc_spreadsheet_functions_test: Add unittest Change-Id: Iec3de72c0742d0817aaec037ffd234ab05c090c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148840 Tested-by: Jenkins Reviewed-by: Xisco Fauli diff --git a/sc/qa/unit/data/functions/spreadsheet/fods/error.type.fods b/sc/qa/unit/data/functions/spreadsheet/fods/error.type.fods index 3173ba189db2..19b0473aa93f 100644 --- a/sc/qa/unit/data/functions/spreadsheet/fods/error.type.fods +++ b/sc/qa/unit/data/functions/spreadsheet/fods/error.type.fods @@ -6951,6 +6951,24 @@ + + + 1 + + + 1 + + + TRUE + + + =ERROR.TYPE(#NULL!) + + + + + + @@ -7146,4 +7164,4 @@ - \ No newline at end of file +
[Libreoffice-bugs] [Bug 154055] "Name and Path of HTML Documents" needs critical review
https://bugs.documentfoundation.org/show_bug.cgi?id=154055 Olivier Hallot changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153793] The Groupedbar works on 7.1.7.2 using Big Sur, but every single update since has broken it.
https://bugs.documentfoundation.org/show_bug.cgi?id=153793 --- Comment #3 from MalcG --- Where do I find 7.5.1.2 ? The latest I can find is 7.5 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153416] Some buttons are white-on-white on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=153416 --- Comment #20 from Patrick Luby --- (In reply to Caolán McNamara from comment #18) > It's certainly plausible there some "Auto" related problem wrt comment #16 > and buttons in normal dialogs, doesn't happen for me if I manually toggle > the system from dark to light while it is open, but maybe there is some > notification we miss if Auto is enabled and that triggers. I wonder if there > is a way to control the "Auto" so that can be freely tested at any time > rather than waiting for sunrise :-) I think that my fix in the following patch may possible be a fix for comment #16: https://gerrit.libreoffice.org/c/core/+/148570 LibreOffice uses macOS' HITheme functions to draw native buttons, comboboxes, listboxes, etc. It seems that HITheme doesn't always properly sense that the window's dark/light mode setting has changed so I added code to forcefully update the data/light mode setting when a window becomes the focus window. I never did find a notification for "auto" dark/light mode in my NeoOffice work but I am curious if the above patch will fix this bug. The patch should already be in the LibreOffice 7.6 (master) nightly build if you want to try my fix. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154188] Document "Run Graphics Tests" feature found in Options dialog's View pane
https://bugs.documentfoundation.org/show_bug.cgi?id=154188 Olivier Hallot changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151423] Unintended zoom in or out on command key press if Calc is still scrolling.
https://bugs.documentfoundation.org/show_bug.cgi?id=151423 steve changed: What|Removed |Added Whiteboard| QA:needsComment| CC||l...@disr.it Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #2 from steve --- Confirmed: new This has been bothering me for years. Thanks for filing this issue. macOS 13.2.1 Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 5f20f4ff21f597e55d899f5ea4dfe1c1fa5824bc CPU threads: 8; OS: Mac OS X 13.2.1; UI render: Skia/Raster; VCL: osx Locale: en-US (en_DE.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118017] [META] macOS Dark Mode bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=118017 steve changed: What|Removed |Added Depends on||153949 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=153949 [Bug 153949] dialogs unreadable in dark mode after some time on mac -- You are receiving this mail because: You are the assignee for the bug.
