[Libreoffice-commits] core.git: helpcontent2

[Olivier Hallot (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0e5b5237d62422d152c4d54be5e5d2de2fa2f6e4
Author: Olivier Hallot 
AuthorDate: Tue May 2 08:54:45 2023 -0300
Commit: Gerrit Code Review 
CommitDate: Tue May 2 13:54:45 2023 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to 8526bfa2d6570e05906ab96b195dc1c773a734d7
  - tdf#147105 Fix inconsistencies in pdf param descriptions

Change-Id: I30962fef0bf0ec88d24eb6df19207ba52ad51c15
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151234
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/helpcontent2 b/helpcontent2
index 4e66412d1c72..8526bfa2d657 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 4e66412d1c72a51d6548c02baf8de9b4bbcfb92e
+Subproject commit 8526bfa2d6570e05906ab96b195dc1c773a734d7

[Libreoffice-commits] help.git: source/text

[Olivier Hallot (via logerrit)]

 source/text/shared/guide/pdf_params.xhp |   20 ++--
 1 file changed, 10 insertions(+), 10 deletions(-)

New commits:
commit 8526bfa2d6570e05906ab96b195dc1c773a734d7
Author: Olivier Hallot 
AuthorDate: Mon May 1 13:33:17 2023 -0300
Commit: Miklos Vajna 
CommitDate: Tue May 2 13:54:45 2023 +0200

tdf#147105 Fix inconsistencies in pdf param descriptions

Change-Id: I30962fef0bf0ec88d24eb6df19207ba52ad51c15
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151234
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/source/text/shared/guide/pdf_params.xhp 
b/source/text/shared/guide/pdf_params.xhp
index e543d8cd76..8f7353b121 100644
--- a/source/text/shared/guide/pdf_params.xhp
+++ b/source/text/shared/guide/pdf_params.xhp
@@ -62,8 +62,8 @@
 
 
  If this 
property is set, it indicates the range of pages to be printed. 
-If you 
want to print all the pages, leave this property unset.
-If you 
want to export a selection, leave this property unset, setting only the 
property Selection.
+To print 
all the pages, leave this property unset.
+To 
export a selection, leave this property unset and set only the property 
Selection.
 
 
 string
@@ -90,7 +90,7 @@
 UseLosslessCompression
 
 
- 
Specifies if graphics are exported to PDF using a lossless compression eg. 
PNG or if they are compressed using the JPEG format. 

+ 
Specifies if graphics are exported to PDF using a lossless compression like 
PNG or compressed using the JPEG format.
 
 
 boolean
@@ -104,9 +104,9 @@
 Quality
 
 
-Specifies quality of the JPG export. A higher value results 
in higher quality and file.
-Minimum 
inclusive value: 1. Represents lowest value that can be used. The lower the 
value, the less good is the compression quality and the bigger is be the file 
size.
-Maximum 
inclusive value:100. Represents highest value that can be used. The higher the 
value, the better is the compression quality and the smaller is the file size. 

+Specifies quality of the JPG export. A higher value results 
in higher image quality and file.
+Minimum 
inclusive value: 1. Represents lowest value that can be used. The lower the 
value, the less good is the image quality and the smaller is be the file 
size.
+Maximum 
inclusive value:100. Represents highest value that can be used. The higher the 
value, the better is the image quality and the bigger is the file 
size.
 
 
 long
@@ -149,7 +149,7 @@
 
 
 Specifies the version of PDF to emit. Possible values are: 

-0 = PDF 1.7 (default selection).
+0 = PDF 1.7 
(default selection).
 1 = PDF/A-1b
 2 = PDF/A-2b
 3 = PDF/A-3b
@@ -158,10 +158,10 @@
 17 = PDF 1.7
 
 
-long
+long
 
 
-0
+0
 
 
 
@@ -509,7 +509,7 @@
 
 
 
-InitialView
+InitialView
 
 
 Specifies how the PDF document should be displayed when 
opened. Possible values:

[Libreoffice-commits] core.git: vcl/source

[Caolán McNamara (via logerrit)]

 vcl/source/gdi/pdfwriter_impl.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 4ec8787b41fa366182cc97e165943d6af130f304
Author: Caolán McNamara 
AuthorDate: Tue May 2 10:47:53 2023 +0100
Commit: Caolán McNamara 
CommitDate: Tue May 2 13:53:50 2023 +0200

ofz#58551 Conditional jump or move depends on uninitialised value

Change-Id: Iee5d82fff5edf14dd4f8adeabc305e96dd0ddd8d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151260
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/source/gdi/pdfwriter_impl.cxx 
b/vcl/source/gdi/pdfwriter_impl.cxx
index ce70dedc8b21..7d51e3d916d1 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -2872,7 +2872,7 @@ sal_Int32 PDFWriterImpl::createToUnicodeCMap( sal_uInt8 
const * pEncoding,
 {
 int nMapped = 0;
 for (auto n = 0u; n < nGlyphs; ++n)
-if( pCodeUnits[pEncToUnicodeIndex[n]] && pCodeUnitsPerGlyph[n] )
+if (pCodeUnitsPerGlyph[n] && pCodeUnits[pEncToUnicodeIndex[n]])
 nMapped++;
 
 if( nMapped == 0 )
@@ -2900,7 +2900,7 @@ sal_Int32 PDFWriterImpl::createToUnicodeCMap( sal_uInt8 
const * pEncoding,
 int nCount = 0;
 for (auto n = 0u; n < nGlyphs; ++n)
 {
-if( pCodeUnits[pEncToUnicodeIndex[n]] && pCodeUnitsPerGlyph[n] )
+if (pCodeUnitsPerGlyph[n] && pCodeUnits[pEncToUnicodeIndex[n]])
 {
 if( (nCount % 100) == 0 )
 {

[Libreoffice-bugs] [Bug 80430] [META] Documentation gap for new features

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80430

Olivier Hallot  changed:

   What|Removed |Added

 Depends on||154996


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=154996
[Bug 154996] Help pages about dialogs should provide instructions for the
Tabbed UI
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154996] Help pages about dialogs should provide instructions for the Tabbed UI

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=154996

Olivier Hallot  changed:

   What|Removed |Added

 Blocks||80430


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=80430
[Bug 80430] [META] Documentation gap for new features
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154996] Help pages about dialogs should provide instructions for the Tabbed UI

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=154996

Olivier Hallot  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 86630] MENU: Easily insert page number into header/footer with extended menu Insert

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86630

--- Comment #45 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6dfa1fc2fa9a7cdbbaf5ecd27528c95f744e0db4

tdf#86630 sw page number wizard: allow wizard to be re-run

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/source

[Justin Luth (via logerrit)]

 sw/source/uibase/shells/textfld.cxx |   49 +++-
 1 file changed, 48 insertions(+), 1 deletion(-)

New commits:
commit 6dfa1fc2fa9a7cdbbaf5ecd27528c95f744e0db4
Author: Justin Luth 
AuthorDate: Thu Apr 27 17:03:48 2023 -0400
Commit: Miklos Vajna 
CommitDate: Tue May 2 13:48:17 2023 +0200

tdf#86630 sw page number wizard: allow wizard to be re-run

First delete what a previous run of the wizard inserted,
then re-insert the page number.

Change-Id: I1cbf1a7a40e71a13a06a174fd662eccfe8298e28
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151148
Tested-by: Jenkins
Reviewed-by: Justin Luth 
Reviewed-by: Miklos Vajna 

diff --git a/sw/source/uibase/shells/textfld.cxx 
b/sw/source/uibase/shells/textfld.cxx
index 2c0474cf4f6a..64694b0ab07b 100644
--- a/sw/source/uibase/shells/textfld.cxx
+++ b/sw/source/uibase/shells/textfld.cxx
@@ -1050,10 +1050,24 @@ FIELD_INSERT:
 
 const size_t nPageDescIndex = rSh.GetCurPageDesc();
 const SwPageDesc& rDesc = rSh.GetPageDesc(nPageDescIndex);
+const bool bHeader = !pDlg->GetPageNumberPosition();
 const bool bHeaderAlreadyOn = 
rDesc.GetMaster().GetHeader().IsActive();
 const bool bFooterAlreadyOn = 
rDesc.GetMaster().GetFooter().IsActive();
 const bool bIsSinglePage = rDesc.GetFollow() != 
 const size_t nMirrorPagesNeeded = rDesc.IsFirstShared() ? 2 : 
3;
+const OUString sBookmarkName = 
OUString::Concat("PageNumWizard_")
++ (bHeader ? "HEADER" : "FOOTER") + "_" + rDesc.GetName();
+IDocumentMarkAccess& rIDMA = *rSh.getIDocumentMarkAccess();
+
+// Allow wizard to be re-run: delete previously 
wizard-inserted page number.
+// Try before creating non-shared header: avoid coping ODD 
bookmark onto EVEN page.
+IDocumentMarkAccess::const_iterator_t ppMark = rIDMA.findMark(
+sBookmarkName + OUString::number(rSh.GetVirtPageNum()));
+if (ppMark != rIDMA.getAllMarksEnd() && *ppMark)
+{
+SwPaM aDeleteOldPageNum((*ppMark)->GetMarkStart(), 
(*ppMark)->GetMarkEnd());
+
rDoc->getIDocumentContentOperations().DeleteAndJoin(aDeleteOldPageNum);
+}
 
 SvxPageItem aPageItem(SID_ATTR_PAGE);
 aPageItem.SetNumType(pDlg->GetPageNumberType());
@@ -1068,7 +1082,6 @@ FIELD_INSERT:
   {  });
 
 // Insert header/footer
-const bool bHeader = !pDlg->GetPageNumberPosition();
 if (bHeader && !bHeaderAlreadyOn)
 rSh.ChangeHeaderOrFooter(rDesc.GetName(), bHeader, 
/*On=*/true, /*Warn=*/false);
 else if (!bHeader && !bFooterAlreadyOn)
@@ -1145,6 +1158,15 @@ FIELD_INSERT:
 assert(bInHF && "shouldn't have a problem going to text 
when no mirroring");
 }
 
+// Allow wizard to be re-run: delete previously 
wizard-inserted page number.
+// Now that the cursor may have moved to a different page, try 
delete again.
+ppMark = rIDMA.findMark(sBookmarkName + 
OUString::number(rSh.GetVirtPageNum()));
+if (ppMark != rIDMA.getAllMarksEnd() && *ppMark)
+{
+SwPaM aDeleteOldPageNum((*ppMark)->GetMarkStart(), 
(*ppMark)->GetMarkEnd());
+
rDoc->getIDocumentContentOperations().DeleteAndJoin(aDeleteOldPageNum);
+}
+
 SwTextNode* pTextNode = 
rSh.GetCursor()->GetPoint()->GetNode().GetTextNode();
 
 // Insert new line if there is already text in header/footer
@@ -1188,11 +1210,27 @@ FIELD_INSERT:
 OUString(), OUString(), SVX_NUM_PAGEDESC);
 aMgr.InsertField(aData);
 
+SwPaM aNewBookmarkPaM(*rSh.GetCursor()->Start());
+aNewBookmarkPaM.SetMark();
+rSh.GetCursor()->Left(1);
+*aNewBookmarkPaM.Start() = *rSh.GetCursor()->Start();
+rIDMA.makeMark(aNewBookmarkPaM,
+   sBookmarkName + 
OUString::number(rSh.GetVirtPageNum()),
+   IDocumentMarkAccess::MarkType::BOOKMARK,
+   sw::mark::InsertMode::New);
+
 // Mirror on the even pages
 if (!bSkipMirror && bCreateMirror
 && rSh.SetCursorInHdFt(nPageDescIndex, bHeader, 
/*Even=*/true))
 {
 assert(nEvenPage && "what? no even page and yet we got 
here?");
+ppMark = rIDMA.findMark(sBookmarkName + 
OUString::number(rSh.GetVirtPageNum()));
+if (ppMark != rIDMA.getAllMarksEnd() && *ppMark)
+

[Libreoffice-bugs] [Bug 80430] [META] Documentation gap for new features

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80430

Olivier Hallot  changed:

   What|Removed |Added

 Depends on||155100


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=155100
[Bug 155100] Documenting that LibreOffice treats 1900 as a common year, not
leap, is needed
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155100] Documenting that LibreOffice treats 1900 as a common year, not leap, is needed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155100

Olivier Hallot  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 Blocks||80430


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=80430
[Bug 80430] [META] Documentation gap for new features
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155120] LO eats up 100% of system resources just for processing mouse movement

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155120

--- Comment #1 from birnb...@posteo.de  ---
The same LO version on a Mac mini M2 and a MacBook Air M2 (both with Apple
silicon) do not show this problem.

On the problematic Intel iMac, all users are affected, including a new user
without LO user profile.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/qa

[Xisco Fauli (via logerrit)]

 sc/qa/unit/data/functions/spreadsheet/fods/lookup.fods |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 20b82690cdf58ae3ad9415d552fb924c51cdafd6
Author: Xisco Fauli 
AuthorDate: Tue May 2 11:48:25 2023 +0200
Commit: Xisco Fauli 
CommitDate: Tue May 2 13:33:56 2023 +0200

sc: extend conditional format range in test

Change-Id: Ie857bc22f0340659612eb407975679953c538822
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151259
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sc/qa/unit/data/functions/spreadsheet/fods/lookup.fods 
b/sc/qa/unit/data/functions/spreadsheet/fods/lookup.fods
index db9728fa07e3..85bbf27a60cd 100644
--- a/sc/qa/unit/data/functions/spreadsheet/fods/lookup.fods
+++ b/sc/qa/unit/data/functions/spreadsheet/fods/lookup.fods
@@ -19131,17 +19131,17 @@
   
   
  
- 
+ 
   
   
   
  
- 
+ 
   
   
   
  
- 
+ 
   
   
   

[Libreoffice-bugs] [Bug 147291] macOS: Digital Signatures > Start Certificate Manager (OpenPGP) results in error instead of opening GPG Keychain

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147291

Luc Lalonde  changed:

   What|Removed |Added

   Hardware|x86-64 (AMD64)  |All

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147291] macOS: Digital Signatures > Start Certificate Manager (OpenPGP) results in error instead of opening GPG Keychain

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147291

Luc Lalonde  changed:

   What|Removed |Added

Version|7.4.0.0 alpha0+ |7.5.2.2 release

--- Comment #11 from Luc Lalonde  ---
Still not working for me

LibreOffice 7.5.2.2
GPG Keychain 1.12

Start certificate Manager button is till dead.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155126] Tooltip in Writer's Formula Bar is "Formula Type" when it should be "Name Box" (or other)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155126

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Summary|Tooltip in Writer's Formula |Tooltip in Writer's Formula
   |Bar is "Formula Type" when  |Bar is "Formula Type" when
   |it should be "Name Box" |it should be "Name Box" (or
   ||other)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155126] New: Tooltip in Writer's Formula Bar is "Formula Type" when it should be "Name Box"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155126

Bug ID: 155126
   Summary: Tooltip in Writer's Formula Bar is "Formula Type" when
it should be "Name Box"
   Product: LibreOffice
   Version: 6.0.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: needsDevEval
  Severity: trivial
  Priority: lowest
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: stephane.guil...@libreoffice.org
CC: hoss...@libreoffice.org
Blocks: 122755

Steps to reproduce:
1. Open Writer
2. Press F2 or use menu Table > Edit Formula: tooltip for the first field that
contains "Text formula" is "Formula Type" (correct)
3. Press F2 to close the formula bar, insert a table, press F2

Result: tooltip for first field is also "Formula Type", but it should either be
"Name Box" (like in Calc) or something else as named ranges are not relevant
here (maybe "Cell (Range)" or "Coordinate"...)

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: dd15364793401e41bae45cdeb410808c9f94fa93
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Already in:

Version: 6.0.0.3
Build ID: 64a0f66915f38c6217de274f0aa8e15618924765
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk2; 
Locale: en-AU (en_AU.UTF-8); Calc: group

Same with gen VCL.

Hossein, easyHack?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=122755
[Bug 122755] [META] Formulae in Writer tables bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 122755] [META] Formulae in Writer tables bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122755

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||155126


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=155126
[Bug 155126] Tooltip in Writer's Formula Bar is "Formula Type" when it should
be "Name Box"
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155070] An easier way to access the skia.log

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155070

Buovjaga  changed:

   What|Removed |Added

 Status|REOPENED|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: bash script for downloading and installation of libreoffice

[Ilmari Lauhakangas]

On 27.4.2023 17.04, Richard Demattio wrote:

On 25.04.23 13:54, Eike Rathke wrote:

Hi Richard,

On Saturday, 2023-04-22 16:56:57 +0200, Richard Demattio wrote:


I would like to provide my script to the community,

Nice.


but don't know how to do it and over what channel I can do it.

Can we see your script at some public place?
In general I'd recommend some git repository or git hosting like
https://codeberg.org/


Hi Eike,
you invited me to provide an address to the bash script.
Here it is.

https://codeberg.org/demattio/LibreOffice_Package_Download_Script.git


You might want to check the code with https://www.shellcheck.net/

Ilmari

[Libreoffice-bugs] [Bug 129062] [META] Skia library bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129062
Bug 129062 depends on bug 155070, which changed state.

Bug 155070 Summary: An easier way to access the skia.log
https://bugs.documentfoundation.org/show_bug.cgi?id=155070

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WONTFIX |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155070] An easier way to access the skia.log

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155070

Heiko Tietze  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|RESOLVED|REOPENED
 Resolution|WONTFIX |---

--- Comment #8 from Heiko Tietze  ---
Alternatively to About: Version I could imagine a tiny hyperlink "Copy Log
file" next to Tools > Options > View > Skia, ideally disabled if there is no
log file to copy. Could be accomplished with a tooltip "Copy the content from
skia.log to the clipboard", and on click it does this.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155028] Crash in: `anonymous namespace'::lcl_PasteFlyOrDrawFormat

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155028

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.6.0|target:7.6.0 target:7.5.4

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - sw/inc sw/source

[Noel Grandin (via logerrit)]

 sw/inc/doc.hxx   |2 +-
 sw/source/core/doc/doclay.cxx|4 ++--
 sw/source/core/draw/dcontact.cxx |7 ---
 sw/source/core/frmedt/fecopy.cxx |   33 -
 4 files changed, 23 insertions(+), 23 deletions(-)

New commits:
commit 07162ef2102552eb2572a8aba7e690108a99d4a0
Author: Noel Grandin 
AuthorDate: Thu Apr 27 18:45:46 2023 +0200
Commit: Xisco Fauli 
CommitDate: Tue May 2 13:02:50 2023 +0200

tdf#155028 Crash in: `anonymous namespace'::lcl_PasteFlyOrDrawFormat

since
commit 8611f6e259b807b4f19c8dc0eab86ca648891ce3
Author: Noel Grandin 
Date:   Thu May 27 10:27:46 2021 +0200
ref-count SdrObject
The CloneSdrObj() call needs to return a rtl::Reference or the
created object might get destroyed before we return a (now stale)
pointer to it.

Change-Id: I3de46b025887e6d460860b37677d2b18b90fb3e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151137
Tested-by: Jenkins
Reviewed-by: Noel Grandin 
(cherry picked from commit ea5c846fd5630acef26a3ee96d47c4a43fb5c24d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151120
Reviewed-by: Xisco Fauli 

diff --git a/sw/inc/doc.hxx b/sw/inc/doc.hxx
index 428e64bcd9c7..31292e1cc5cb 100644
--- a/sw/inc/doc.hxx
+++ b/sw/inc/doc.hxx
@@ -1533,7 +1533,7 @@ public:
 void Unchain( SwFrameFormat  );
 
 // For Copy/Move from FrameShell.
-SdrObject* CloneSdrObj( const SdrObject&, bool bMoveWithinDoc = false,
+rtl::Reference CloneSdrObj( const SdrObject&, bool 
bMoveWithinDoc = false,
 bool bInsInPage = true );
 
 // FeShell - Interface end
diff --git a/sw/source/core/doc/doclay.cxx b/sw/source/core/doc/doclay.cxx
index 457ff80b517b..ca9ff1c82ed9 100644
--- a/sw/source/core/doc/doclay.cxx
+++ b/sw/source/core/doc/doclay.cxx
@@ -105,7 +105,7 @@ static bool lcl_IsItemSet(const SwContentNode & rNode, 
sal_uInt16 which)
 return bResult;
 }
 
-SdrObject* SwDoc::CloneSdrObj( const SdrObject& rObj, bool bMoveWithinDoc,
+rtl::Reference SwDoc::CloneSdrObj( const SdrObject& rObj, bool 
bMoveWithinDoc,
 bool bInsInPage )
 {
 // #i52858# - method name changed
@@ -150,7 +150,7 @@ SdrObject* SwDoc::CloneSdrObj( const SdrObject& rObj, bool 
bMoveWithinDoc,
 }
 pObj->SetLayer( nLayerIdForClone );
 
-return pObj.get();
+return pObj;
 }
 
 SwFlyFrameFormat* SwDoc::MakeFlySection_( const SwPosition& rAnchPos,
diff --git a/sw/source/core/draw/dcontact.cxx b/sw/source/core/draw/dcontact.cxx
index 3cebc41c06ba..ad2a6fe37bc0 100644
--- a/sw/source/core/draw/dcontact.cxx
+++ b/sw/source/core/draw/dcontact.cxx
@@ -1567,11 +1567,12 @@ void SwDrawContact::SwClientNotify(const SwModify& 
rMod, const SfxHint& rHint)
 {
 auto pDrawFormatLayoutCopyHint = static_cast();
 const SwDrawFrameFormat& rFormat = static_cast(rMod);
-new SwDrawContact(
->m_rDestFormat,
+rtl::Reference xNewObj =
 pDrawFormatLayoutCopyHint->m_rDestDoc.CloneSdrObj(
 *GetMaster(),
-pDrawFormatLayoutCopyHint->m_rDestDoc.IsCopyIsMove() 
&& >m_rDestDoc == rFormat.GetDoc()));
+pDrawFormatLayoutCopyHint->m_rDestDoc.IsCopyIsMove() 
&& >m_rDestDoc == rFormat.GetDoc());
+new SwDrawContact(
+>m_rDestFormat, xNewObj.get() );
 // #i49730# - notify draw frame format that position attributes are
 // already set, if the position attributes are already set at the
 // source draw frame format.
diff --git a/sw/source/core/frmedt/fecopy.cxx b/sw/source/core/frmedt/fecopy.cxx
index 961c64d12bc9..d18f76921384 100644
--- a/sw/source/core/frmedt/fecopy.cxx
+++ b/sw/source/core/frmedt/fecopy.cxx
@@ -188,11 +188,10 @@ void SwFEShell::Copy( SwDoc& rClpDoc, const OUString* 
pNewClpText )
 aAnchor.SetAnchor(  );
 aSet.Put( aAnchor );
 
-SdrObject *const pNew =
-rClpDoc.CloneSdrObj( *pObj );
+rtl::Reference xNew = rClpDoc.CloneSdrObj( *pObj );
 
 SwPaM aTemp(aPos);
-rClpDoc.getIDocumentContentOperations().InsertDrawObj(aTemp, 
*pNew, aSet );
+rClpDoc.getIDocumentContentOperations().InsertDrawObj(aTemp, 
*xNew, aSet );
 }
 else
 {
@@ -311,10 +310,10 @@ bool SwFEShell::CopyDrawSel( SwFEShell& rDestShell, const 
Point& rSttPt,
 (RndStdIds::FLY_AS_CHAR != rAnchor.GetAnchorId()) )
 
 {
-SdrObject* pNew = pDestDoc->CloneSdrObj( *pObj, bIsMove &&
+rtl::Reference xNew = pDestDoc->CloneSdrObj( *pObj, 
bIsMove &&
 GetDoc() == pDestDoc, false );
-pNew->NbcMove( aSiz );
-pDestDrwView->InsertObjectAtView( pNew, *pDestPgView );
+

[Libreoffice-bugs] [Bug 155125] New: "Encrypt with GPG key" option missing when using System File Dialogue on MacOS

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155125

Bug ID: 155125
   Summary: "Encrypt with GPG key" option missing when using
System File Dialogue on MacOS
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+
  Hardware: All
OS: macOS (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: notinterest...@gmx.com

Description:
There is no "Encrypt with GPG key" check-box in "Save As ..." dialog box when
UseSystemFileDialog is True (i.e. when using MacOS Save dialogue boxes).

Steps to Reproduce:
1. Select Preferences>LibreOffice>Advanced>Open Expert Configuration.
2. Search for "UseSystemFileDialog"
3. Ensure value is set to false (possibly by double-clicking to toggle the
Boolean).
4. Click "OK" to close Expert Configuration window.
5. Click "OK" to close Preferences window.
6. Select File>New>Text Document
7. Enter any text.
8. Select "File>Save As ..."
9. Observe that LO "Save As" window has an "Encrypt with GPG key" option (lower
left).
10. Click "Cancel".
11. Select Preferences>LibreOffice>Advanced>Open Expert Configuration.
12. Search for "UseSystemFileDialog".
13. Double click to change value to "true".
14. Click "OK" to close Expert Configuration window.
15. Click "OK" to close Preferences window.
16. Select "File>Save As ..."
17. Observe that Mac OS system "Save As" window does not have an "Encrypt with
GPG key" option.

Actual Results:
Mac OS system "Save As ..." window does not have an "Encrypt with GPG key"
option.

Expected Results:
Mac OS system "Save As ..." window should have an "Encrypt with GPG key"
option.


Reproducible: Always


User Profile Reset: No

Additional Info:
Bug observed in both:

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: beb6c62e990599d91ac5d9183164c94d269027d3
CPU threads: 4; OS: Mac OS X 10.14.6; UI render: Skia/Metal; VCL: osx
Locale: en-GB (en_GB.UTF-8); UI: en-US
Calc: threaded

-- AND --

Version: 7.4.6.2 / LibreOffice Community
Build ID: 5b1f5509c2decdade7fda905e3e1429a67acd63d
CPU threads: 4; OS: Mac OS X 10.14.6; UI render: default; VCL: osx
Locale: en-GB (en_GB.UTF-8); UI: en-GB
Calc: threaded

(See previous note of this bug in Comment 50 on Bug 115538, dated 2022-02-01
14:19:00 UTC).

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: bash script for downloading and installation of libreoffice

[Eike Rathke]

Hi Richard,

On Thursday, 2023-04-27 16:04:01 +0200, Richard Demattio wrote:

> https://codeberg.org/demattio/LibreOffice_Package_Download_Script.git

I didn't inspect it in detail, but I think it'll live best at the place
it currently is at. Kudos for choosing Codeberg.

  Eike

-- 
GPG key 0x6A6CD5B765632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A


signature.asc
Description: PGP signature

Re: Compilation failed when linking

[Eike Rathke]

Hi Regis,

On Tuesday, 2023-05-02 07:50:31 +0200, Regis Perdreau wrote:

> Compilation and linking failure with LibreOffice master (Linux)
> clang version 10.0.0-4ubuntu1
> 
> 
> ld.lld: error: undefined symbol: icu_72::UnicodeString::UnicodeString(char
> const*)
> >>> referenced by xmlparse.cxx:1069 (l10ntools/source/xmlparse.cxx:1069)
> 
> What could be wrong?

You probably somehow managed to compile against the internal ICU 72.1
but link against the Ubuntu system ICU whatever.version.

More context of the build log what it pulls in exactly where might be
helpful.

  Eike

-- 
GPG key 0x6A6CD5B765632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A


signature.asc
Description: PGP signature

[Libreoffice-commits] core.git: lotuswordpro/source

[Caolán McNamara (via logerrit)]

 lotuswordpro/source/filter/lwprowlayout.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 81e8cc7aa3d97ecc42f2592a2f6075f7f1ba74ff
Author: Caolán McNamara 
AuthorDate: Tue May 2 09:04:59 2023 +0100
Commit: Caolán McNamara 
CommitDate: Tue May 2 12:54:04 2023 +0200

ofz#58529 Null-dereference READ

Change-Id: I9d8ea7d40429faee94889e4d2d9df7440b18e65f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151255
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/lotuswordpro/source/filter/lwprowlayout.cxx 
b/lotuswordpro/source/filter/lwprowlayout.cxx
index b5583d19e6d4..d63a06fe9e38 100644
--- a/lotuswordpro/source/filter/lwprowlayout.cxx
+++ b/lotuswordpro/source/filter/lwprowlayout.cxx
@@ -192,6 +192,8 @@ void LwpRowLayout::ConvertRow(rtl::Reference const 
& pXFTable,sal_uInt8
 if (!pTableLayout)
 throw std::runtime_error("missing TableLayout");
 LwpTable* pTable = pTableLayout->GetTable();
+if (!pTable)
+throw std::runtime_error("missing Table");
 
 //calculate the connected cell position
 sal_Int32 nMarkConnCell = FindMarkConnCell(nStartCol,nEndCol);

[Libreoffice-bugs] [Bug 127174] Search dialog doesn't support "whole word only" option

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127174

--- Comment #18 from Mike Kaganski  ---
(In reply to BogdanB from comment #17)
> The discussion blocked from the placement of the option.

Note that that's not a blocker. This feature can be implemented in two steps:
first, the functionality (a flag that is passed to the implementation that does
the actual search, and the search that honors that flag itself); then the UI
part can be implemented, with the control defining that flag in the dialog
decided. Additionally, the first step would already enable using it in macros.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155070] An easier way to access the skia.log

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155070

--- Comment #7 from Telesto  ---
Bug 155084 is proto-typical example why would like some quick way to access the
skia.log

I currently tend to point to Menu -> Tools -> Options -> View -> Check 'Force
Skia Software Rendering' if I expect it to be Skia Vulkan related. See bug
155084 comment 3.

However if I do that, and it solved the problem, people don't tend to turn skia
Vulkan back on again the retrieve the skia.log. Which needed for blacklisting
drivers.

It's rather clumsy to ask people for the dig out the skia.log in advance (which
is little time consuming). Turning on Skia Software Rendering and next
concluding, well it wasn't skia at all..


--
Adding it to Help About is something to consider. I doubted it a bit because it
adds some excess in quite number of cases (it's trivial in >85% of the cases).
OTOH, the 'ordinary users' will report more relevant information Skia Vulkan
cases with the initial report. So it would make stuff easier for Skia Vulkan
issues :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155124] macOS print options do not provide page size settings to export as PDF.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155124

--- Comment #10 from M-Rick  ---
Created attachment 187059
  --> https://bugs.documentfoundation.org/attachment.cgi?id=187059=edit
macOS result (any versions)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155124] macOS print options do not provide page size settings to export as PDF.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155124

--- Comment #9 from M-Rick  ---
Created attachment 187058
  --> https://bugs.documentfoundation.org/attachment.cgi?id=187058=edit
Windows result

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155124] macOS print options do not provide page size settings to export as PDF.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155124

--- Comment #8 from M-Rick  ---
Created attachment 187057
  --> https://bugs.documentfoundation.org/attachment.cgi?id=187057=edit
Linux result

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155124] macOS print options do not provide page size settings to export as PDF.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155124

--- Comment #7 from M-Rick  ---
Created attachment 187056
  --> https://bugs.documentfoundation.org/attachment.cgi?id=187056=edit
Windows print settings

It is possible to set the paper size, unlike in macOS.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155124] macOS print options do not provide page size settings to export as PDF.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155124

--- Comment #6 from M-Rick  ---
Created attachment 187055
  --> https://bugs.documentfoundation.org/attachment.cgi?id=187055=edit
Linux print settings

It is possible to set the paper size, unlike in macOS.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 115538] GnuPG / OpenPGP keys not found on macOS unless from command line (fixed for Intel macs, persisting on Apple Silicon see comment #56)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115538

--- Comment #61 from Andrew Watson  ---
Works for me too (on Intel MacOS):

LibreOffice
---
Version: 7.4.6.2 / LibreOffice Community
Build ID: 5b1f5509c2decdade7fda905e3e1429a67acd63d
CPU threads: 4; OS: Mac OS X 10.14.6; UI render: default; VCL: osx
Locale: en-GB (en_GB.UTF-8); UI: en-GB
Calc: threaded

OS
--
% /usr/bin/sw_vers
ProductName:Mac OS X
ProductVersion: 10.14.6
BuildVersion:   18G9323

Hardware:
-
% uname -m
x86_64

% machine
x86_64h

% /usr/sbin/system_profiler SPHardwareDataType | grep "Model Name"
  Model Name: MacBook Air

% /usr/sbin/system_profiler SPHardwareDataType | grep "Model Identifier"
  Model Identifier: MacBookAir7,2

GPG Suite
-
GPG Suite 2022.2
GPG Keychain Version 1.7 (1653)

https://gpgtools.org/releases/gpgsuite/release-notes.html


However, there is still no "Encrypt with GPG key" check-box in "Save As ..."
dialog box when UseSystemFileDialog is True (i.e. when using MacOS Save
dialogue boxes). One has to set UseSystemFileDialog to False (via
Preferences>LibreOffice>Advanced>Open Expert Configuration, then seaching for
"UseSystemFileDialog" and toggling the Boolean) before it's actually possible
to save an encryted document. I'll file a separate bug report for this.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155124] macOS print options do not provide page size settings to export as PDF.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155124

--- Comment #5 from M-Rick  ---
Created attachment 187054
  --> https://bugs.documentfoundation.org/attachment.cgi?id=187054=edit
macOS settings in other macOS softwares

It is possible to choose the paper size unlike LibreOffice.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155124] macOS print options do not provide page size settings to export as PDF.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155124

--- Comment #4 from M-Rick  ---
Created attachment 187053
  --> https://bugs.documentfoundation.org/attachment.cgi?id=187053=edit
macOS settings in previous macOS versions

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155124] macOS print options do not provide page size settings to export as PDF.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155124

--- Comment #3 from M-Rick  ---
Created attachment 187052
  --> https://bugs.documentfoundation.org/attachment.cgi?id=187052=edit
macOS settings in Ventura (2)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: i18npool/Library_localedata_others.mk i18npool/source

[Eike Rathke (via logerrit)]

 i18npool/Library_localedata_others.mk  |1 
 i18npool/source/localedata/data/sat_IN.xml |  180 +
 i18npool/source/localedata/localedata.cxx  |3 
 3 files changed, 183 insertions(+), 1 deletion(-)

New commits:
commit d5565b70bc6d3d263e1cc50fa1f343f4e1a428fe
Author: Eike Rathke 
AuthorDate: Tue Apr 25 00:25:51 2023 +0200
Commit: Eike Rathke 
CommitDate: Tue May 2 12:37:20 2023 +0200

Resolves: tdf#154987 Add Santali {sat-IN} locale data

Change-Id: I9da3003a4db91bfa432bb68edcf577b73df5ee2d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150949
Tested-by: Jenkins
Reviewed-by: Eike Rathke 

diff --git a/i18npool/Library_localedata_others.mk 
b/i18npool/Library_localedata_others.mk
index 2c0c4e9bf928..1e9bce721a3e 100644
--- a/i18npool/Library_localedata_others.mk
+++ b/i18npool/Library_localedata_others.mk
@@ -121,6 +121,7 @@ $(eval $(call 
gb_Library_add_generated_exception_objects,localedata_others,\
CustomTarget/i18npool/localedata/localedata_pui_CO \
CustomTarget/i18npool/localedata/localedata_puu_CG \
CustomTarget/i18npool/localedata/localedata_rw_RW \
+   CustomTarget/i18npool/localedata/localedata_sat_IN \
CustomTarget/i18npool/localedata/localedata_sdj_CG \
CustomTarget/i18npool/localedata/localedata_sg_CF \
CustomTarget/i18npool/localedata/localedata_shs_CA \
diff --git a/i18npool/source/localedata/data/sat_IN.xml 
b/i18npool/source/localedata/data/sat_IN.xml
new file mode 100644
index ..8291dbfd534f
--- /dev/null
+++ b/i18npool/source/localedata/data/sat_IN.xml
@@ -0,0 +1,180 @@
+
+
+
+
+  
+
+  sat
+  Santali
+
+
+  IN
+  India
+
+  
+  
+  
+  
+  
+  
+ᱚ-ᱷ
+14 
+p.
+pp.
+  
+  
+
+  
+
+  sun
+  ᱥᱤᱸ
+  ᱥᱤᱸᱜᱮ
+
+
+  mon
+  ᱚᱛ
+  ᱚᱛᱮ
+
+
+  tue
+  ᱵᱟ
+  ᱵᱟᱞᱮ
+
+
+  wed
+  ᱥᱟᱹᱜ
+  ᱥᱟᱹᱜᱩᱱ
+
+
+  thu
+  ᱥᱟᱹᱨ
+  ᱥᱟᱹᱨᱫᱤ
+
+
+  fri
+  ᱡᱟᱹᱨ
+  ᱡᱟᱹᱨᱩᱢ
+
+
+  sat
+  ᱧᱩᱦ
+  ᱧᱩᱦᱩᱢ
+
+  
+  
+
+  jan
+  ᱢᱟᱜᱽ
+  ᱢᱟᱜᱽ
+
+
+  feb
+  ᱯᱷᱟ.ᱜᱩᱱ
+  ᱯᱷᱟ.ᱜᱩᱱ
+
+
+  mar
+  ᱪᱟ.ᱛ
+  ᱪᱟ.ᱛ
+
+
+  apr
+  ᱵᱟ.ᱭᱥᱟ.ᱠ
+  ᱵᱟ.ᱭᱥᱟ.ᱠ
+
+
+  may
+  ᱡᱷᱮᱸᱴ
+  ᱡᱷᱮᱸᱴ
+
+
+  jun
+  ᱟᱥᱟᱲ
+  ᱟᱥᱟᱲ
+
+
+  jul
+  ᱥᱟᱱ
+  ᱥᱟᱱ
+
+
+  aug
+  ᱵᱷᱟᱫᱚᱨ
+  ᱵᱷᱟᱫᱚᱨ
+
+
+  sep
+  ᱫᱟᱥᱟᱸᱭ
+  ᱫᱟᱥᱟᱸᱭ
+
+
+  oct
+  ᱥᱚᱦᱨᱟᱭ
+  ᱥᱚᱦᱨᱟᱭ
+
+
+  nov
+  ᱟᱜᱷᱟᱬ
+  ᱟᱜᱷᱟᱬ
+
+
+  dec
+  ᱯᱩᱥ
+  ᱯᱩᱥ
+
+  
+  
+
+  bc
+  ᱡᱤ ᱢᱟ
+  ᱡᱤᱥᱩ ᱢᱟᱲᱟᱝ
+
+
+  ad
+  ᱥᱚᱱ
+  ᱥᱚᱱ
+
+  
+  
+sun
+  
+  1
+
+  
+  
+  
+  
+
+  ᱥᱟᱹᱨᱤ
+  ᱵᱷᱩᱞ
+  ᱯᱩᱭᱞᱩ ᱯᱮ ᱪᱟᱸᱫᱚ
+  ᱫᱚᱥᱟᱨ ᱯᱮ ᱪᱟᱸᱫᱚ
+  ᱛᱮᱥᱟᱨ ᱯᱮ ᱪᱟᱸᱫᱚ
+  ᱯᱩᱱᱟᱹᱜ ᱯᱮ ᱪᱟᱸᱫᱚ
+  ᱪᱮᱛᱟᱱ
+  ᱞᱟᱛᱟᱨ
+  Q1
+  Q2
+  Q3
+  Q4
+
+  
+  
+  
+
diff --git a/i18npool/source/localedata/localedata.cxx 
b/i18npool/source/localedata/localedata.cxx
index 8f3d39c768d1..01f527a731d0 100644
--- a/i18npool/source/localedata/localedata.cxx
+++ b/i18npool/source/localedata/localedata.cxx
@@ -337,7 +337,8 @@ const struct {
 { "en_IL",  lcl_DATA_OTHERS },  // needs to be in OTHERS instead of EN 
because inherits from he_IL
 { "pdc_US", lcl_DATA_OTHERS },
 { "dv_MV",  lcl_DATA_OTHERS },
-{ "mfe_MU", lcl_DATA_OTHERS }
+{ "mfe_MU", lcl_DATA_OTHERS },
+{ "sat_IN", lcl_DATA_OTHERS }
 };
 
 #else

[Libreoffice-bugs] [Bug 155124] macOS print options do not provide page size settings to export as PDF.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155124

--- Comment #2 from M-Rick  ---
Created attachment 187051
  --> https://bugs.documentfoundation.org/attachment.cgi?id=187051=edit
macOS settings in Ventura (1)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155087] Autocorrection in Romanian applies to existing words

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155087

--- Comment #14 from cipricus  ---
I HAVE READ THE WHOLE LIST!

I am mentioning below most if not all cases that I think should be taken out. I
have already tried to articulate the reason for that. 

Although bringing case-by-case examples and arguments should not the way to go
about this, and the decision whether to correct or not existing words should
only be made on a general principle (that is: NO VALID FORMS SHOULD EVER BE
CORRECTED), the problematic entries can also be treated one by one because they
are not that many after all.

The replacement of articulated nouns just because they are not frequent enough
(based on subjective and inconsistent criteria) is always wrong, but in certain
cases it is more strikingly so, when the articulated form is obviously equally
frequent. 

That happens based on specific rules of Romanian. For example, an adjective can
be “substantived” – that is, made to act like a noun and become the subject,
like in English (dead – the dead):

moarta>moartă (the dead woman > dead, adj., fem.)
(Moarta era întinsă pe pat.= The dead woman was laying on the bed.)

prevenita-prevenită
the arrested woman>warned, arrested person, adj., fem.
Prevenita nu era de față=The arrested woman was not present.

negativa>negativă
the negative form/one>negative, adj., fem.
Negativa nu este valabilă= The negative form is not valid.  

ridicata > ridicată
a ridica=to raise up, ridicată=raised up, adj., fem.
”cu ridicata”=wholsale

That happens often in the case of colors, where the form of the adjective is
articulated and acts as a short-hand or generic noun ("the black"):

alba>albă (the white [one]>white, adj. fem.)
neagra>neagră (the black [one].>black adj., fem.,)
"Neagra/alba e mai scumpă"= the black/white [one] (e.g. the black or white car)
is more expensive.
- the same with other colors: albastra - ”the blue [one]”, which the corrector
changes to albastră=blue! (But then it ignores other colors.) 

It is a common rule in Romanian for adjectives to change  word order and be
articulated when a possessive pronoun (my, mine, his, hers) is used. One can
indifferently say “trista mea situație” or ”situația mea tristă” (”my sad
situation”), ”blonda mea soție” or ”soția mea blondă” (my blonde wife).  – I
wonder why the corrector is not correcting ”trista” to ”tristă”, and ”blonda”
to ”blondă”, given that is doing it for alba>albă  and
neagra>neagră, as well as for other forms – see below!

As I said in another comment: not only these corrections are wrong, but they
are inconsistent – they are unexpected, but, IF ACCEPTED, they are also
unexpectedly absent in other cases. – ”Alba” and ”neagra” are no different from
something like ”blonda” (blonde girl/woman), which is (rightly so) NOT
corrected to ”blondă” (blonde, adjective).

absoluta>absolută
the absolute [one], fem.>absolute, adj., fem.
Absoluta lui încredere=his absolute confidence

singuratica > singuratică
the lonely [one], fem. > lonely, adj., fem.
Singuratica lui viață=His lonely life.

temeinica > temeinică (steadfast, well-founded, adj., fem.)
Temeinica lui decizie=his steadfast decision

vaga > vagă (vague, adj., fem.)
Vaga ta propunere=your vague proposition

valabila > valabilă (valid, adj., fem.)
Valabila ta depoziție = your valid statement

multa>multă (numerous, big/adj., fem)
Often rather archaic but very frequent in the Bible, and in religious and other
literary  speech: "Multa mea durere" (my big sorrow)

amoroasa>amoroasă
Amoroasa sa soție=his loving/amorous wife

regala>regală
the royal [one]>royal, adj., fem.
Regala sa prezență=His/her royal stature
This ”correction” is doubly wrong because ”regala” is also a verb: to feast,
treat royally, cf. French: ”(se) régaler”

ciudata>ciudată (odd, bizarre, adj., fem.)
Ciudata sa atitudine=his bizarre atitude

This word order/articulation change also happens with the “demonstrative
pronouns” (this, that):

Ciudata asta nu vorbește cu mine.=This bizarre girl/woman won’t speak to me.

toleranta (tolerant, adj. fem., definite article) >"toleranța" (tolerance, n.,
fem.)
Toleranta sa poziție=his tolerant position

While the corrector erroneously replaces “ciudata”, because of inconsistency
(within this erroneous trend) it doesn’t replace “frumoasa” (the beautiful
[one, fem.]), “proasta” (the stupid one), ”drogata” (the drugged one) etc, –
but arbitrarily DOES (and IT SHOULDN’T) replace ”contagioasa" (the contagious
[one, fem.]), ”religioasa” (the religious one), ”rezolvata” (the
resolved/solutioned one), ”ridicata” (the raised/upper one), ”salvata” (the
saved one), ”zoologica” (the zoologic one) with their non-articulated forms!

That such correct words are replaced just because they have the feminine
definite article is beyond comprehension. Some of these articulated forms set
to be replaced are not very frequent  (e.g. ”greceasca”=”the Greek [thing,
fem.]”, or ”ruseasca”=the Russian [thing, fem.]), but THAT IS NOT A REASON to

[Libreoffice-bugs] [Bug 155124] macOS print options do not provide page size settings to export as PDF.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155124

--- Comment #1 from M-Rick  ---
Created attachment 187050
  --> https://bugs.documentfoundation.org/attachment.cgi?id=187050=edit
Test file

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Prasanta Hembram license statement

[Eike Rathke]

Hi Prasanta,

On Monday, 2023-05-01 17:20:33 +0530, Prasanta Hembram wrote:

> All of my past & future contributions to LibreOffice may be
> licensed under the MPLv2/LGPLv3+ dual license.

Thanks! Put on file at
https://wiki.documentfoundation.org/Development/Developers#H
with
https://wiki.documentfoundation.org/index.php?title=Development/Developers=667847=658126

  Eike

-- 
GPG key 0x6A6CD5B765632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A


signature.asc
Description: PGP signature

[Libreoffice-bugs] [Bug 155124] New: macOS print options do not provide page size settings to export as PDF.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155124

Bug ID: 155124
   Summary: macOS print options do not provide page size settings
to export as PDF.
   Product: LibreOffice
   Version: 7.5.2.2 release
  Hardware: All
OS: macOS (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: m.rick@gmail.com

Description:
In macOS, it is possible to export natively a document as PDF and set the
document size in the print settings. Unfortunately, this option isn't available
in LibreOffice mac.
I want to export a document in A3 by associating A4 pages. It is a very great
feature available only in LibreOffice. It's work perfactly in Linux or Windows,
but in macOS it is impossible to change the final document size that will be A4
by defaut.

Steps to Reproduce:
1. Create a new Calc spreadsheet and make several printing areas equivalent to
a single A4 page (or American letter for imperial). 

2. Print the document, in the settings, enable 2 pages by documents and set as
A3 to keep the original A4 size.

3. Save as PDF or print on a printer that supports A3 size.

Actual Results:
In macOS, LibreOffice reduce the page and add a large margin.

Expected Results:
Should have 2 A4 pages side-by-side on a single A3 sheet.


Reproducible: Always


User Profile Reset: No

Additional Info:
I indicated the latest LibreOffice release, but it happens in every versions.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 114441] Convert use of sal_uLong to better integer types

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114441

--- Comment #66 from Commit Notification 
 ---
Aman Jha committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/53c641702a280be8b80976301f3427b41d2e0b74

tdf#114441 Convert sal_uLong to better integer types

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: basctl/source

[Aman Jha (via logerrit)]

 basctl/source/basicide/baside2b.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 53c641702a280be8b80976301f3427b41d2e0b74
Author: Aman Jha 
AuthorDate: Mon Jan 9 19:34:40 2023 +0530
Commit: Ilmari Lauhakangas 
CommitDate: Tue May 2 12:30:27 2023 +0200

tdf#114441 Convert sal_uLong to better integer types

* Use tools::Long for nY as it stores calculations with result values
  that can be sometimes negative
* Cast nLine to sal_uInt16 as rModulWindow.ToggleBreakPoint() takes
  parameter of type sal_uInt16

Change-Id: Ibfdee40f37714406ee0f089c9a87f8b9a650e492
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145210
Tested-by: Jenkins
Reviewed-by: Hossein 
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 

diff --git a/basctl/source/basicide/baside2b.cxx 
b/basctl/source/basicide/baside2b.cxx
index a82cf2ae4e4b..cf7e7388dd52 100644
--- a/basctl/source/basicide/baside2b.cxx
+++ b/basctl/source/basicide/baside2b.cxx
@@ -1476,7 +1476,7 @@ void BreakPointWindow::ShowMarker(vcl::RenderContext& 
rRenderContext)
 aMarkerOff.setX( (aOutSz.Width() - aMarkerSz.Width()) / 2 );
 aMarkerOff.setY( (nLineHeight - aMarkerSz.Height()) / 2 );
 
-sal_uLong nY = nMarkerPos * nLineHeight - nCurYOffset;
+tools::Long nY = nMarkerPos * nLineHeight - nCurYOffset;
 Point aPos(0, nY);
 aPos += aMarkerOff;
 
@@ -1531,7 +1531,7 @@ void BreakPointWindow::MouseButtonDown( const MouseEvent& 
rMEvt )
 {
 tools::Long nYPos = aMousePos.Y() + nCurYOffset;
 tools::Long nLine = nYPos / nLineHeight + 1;
-rModulWindow.ToggleBreakPoint( static_cast(nLine) );
+rModulWindow.ToggleBreakPoint( static_cast(nLine) );
 Invalidate();
 }
 }

[Libreoffice-bugs] [Bug 115538] GnuPG / OpenPGP keys not found on macOS unless from command line (fixed for Intel macs, persisting on Apple Silicon see comment #56)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115538

--- Comment #60 from Alex Thurgood  ---
(In reply to Sierk Bornemann from comment #59)
> Works for me. For me this bug seems to be fixed also on Apple Silicon since
> several months. I see both in LibreOffice's Preferences – User Data –
> Encryption  section: my GPG encryption keys and my GPG signing keys, whereas
> my preferred one has been preselected by me manually. As it should be. I see
> no problem, also not on my MacBook Pro Apple Silicon (M1 Pro).
> 

Somewhat annoyingly, I can't see any GPG signatures within LO on either my
macMini M1 or my Macbook Pro M1.

I even tried creating a new signature within GPG Keychain to test, in case it
was a problem with my old, but still valid GPG signatures, but unfortunately
still no luck, which is rather frustrating.

I should note that these old signatures were migrated from gpgmac pre-2.1, so
maybe that has got something to do with it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153626] Unable to sign with existing digital signature, and inconsistent UI for digital signature in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153626

--- Comment #8 from Alex Thurgood  ---
(In reply to Stéphane Guillou (stragu) from comment #6)


> Also, did you see Dieter's comment in bug 115538, who says they are now also
> displayed on aarch64 M1 Silicon?

I saw that, but unfortunately I still can't see any GPG sigs under the General
Preferences dropdown menus, nor are they displayed in the digital signature
dialog.

Anyway, will comment on that over there, rather than here.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105605] [META] Digital signatures bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105605
Bug 105605 depends on bug 153626, which changed state.

Bug 153626 Summary: Unable to sign with existing digital signature, and 
inconsistent UI for digital signature in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=153626

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|DUPLICATE   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153626] Unable to sign with existing digital signature, and inconsistent UI for digital signature in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153626

Alex Thurgood  changed:

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Ever confirmed|1   |0
 Resolution|DUPLICATE   |---

--- Comment #7 from Alex Thurgood  ---
@Stéphane, sorry my bad, reset to UNCONF

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147291] macOS: Digital Signatures > Start Certificate Manager (OpenPGP) results in error instead of opening GPG Keychain

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147291

--- Comment #10 from Andrew Watson  ---
Further note: thew "Help" button on the "Digital Signatures" window opens this
web page:

file:///Applications/LibreOffice.app/Contents/Resources/help/en-GB/text/shared/01/digitalsignatures.html?System=MAC=WRITER=xmlsec/ui/digitalsignaturesdialog/dialog-action_area1#bm_@@nowidget@@

 ... which includes the text:

--- START QUOTE ---

Start Certificate Manager

Opens the installed certificate manager of your system.

On macOS, the default certificate manager is Keychain Access.

--- END QUOTE ---

AFAIK MacOS's "Keychain Access" can store X.509 certificates, but not GPG keys.
GPG Keychain can store GPG keys, but not X.509 certificates. It look as though
LO on other platforms supports signing ODT documents with either X.509
certificates or GPG keys (?), so it would seem that for full interoperability,
ODT document signing on MacOS has to interface to two separete two
key/certificate management systems (??).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: svx/inc svx/source

[Noel Grandin (via logerrit)]

 svx/inc/sdr/properties/oleproperties.hxx|4 
 svx/source/sdr/properties/oleproperties.cxx |9 -
 2 files changed, 13 deletions(-)

New commits:
commit dbcf188d39ff70ac87312dd28444df97e3cea993
Author: Noel Grandin 
AuthorDate: Mon May 1 21:10:52 2023 +0200
Commit: Noel Grandin 
CommitDate: Tue May 2 12:15:50 2023 +0200

remove unnecessary method

the call to GetObjectItemSet() in
OleProperties::ForceDefaultAttributes() is unnecessary, because
it is always called before ForceDefaultAttributes is called, and
having removed that, the rest of the method becomes unnecessary too.

Change-Id: Ibb09020837d47cb9eb1fb8b5deca1defc1465108
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151237
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/svx/inc/sdr/properties/oleproperties.hxx 
b/svx/inc/sdr/properties/oleproperties.hxx
index abd321ba7cdf..2a35c3ad0ec4 100644
--- a/svx/inc/sdr/properties/oleproperties.hxx
+++ b/svx/inc/sdr/properties/oleproperties.hxx
@@ -42,10 +42,6 @@ namespace sdr::properties
 
 // Clone() operator, normally just calls the local copy constructor
 virtual std::unique_ptr Clone(SdrObject& rObj) 
const override;
-
-// force default attributes for a specific object type, called from
-// DefaultProperties::GetObjectItemSet() if a new ItemSet is 
created
-virtual void ForceDefaultAttributes() override;
 };
 } // end of namespace sdr::properties
 
diff --git a/svx/source/sdr/properties/oleproperties.cxx 
b/svx/source/sdr/properties/oleproperties.cxx
index da599428c97b..a0e0e82d37d7 100644
--- a/svx/source/sdr/properties/oleproperties.cxx
+++ b/svx/source/sdr/properties/oleproperties.cxx
@@ -60,15 +60,6 @@ namespace sdr::properties
 {
 return std::unique_ptr(new OleProperties(*this, 
rObj));
 }
-
-void OleProperties::ForceDefaultAttributes()
-{
-// call parent
-RectangleProperties::ForceDefaultAttributes();
-
-// force ItemSet
-GetObjectItemSet();
-}
 } // end of namespace
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

[Libreoffice-commits] core.git: svx/inc svx/source

[Noel Grandin (via logerrit)]

 svx/inc/sdr/properties/cellproperties.hxx |   81 ++
 svx/source/inc/cell.hxx   |8 +-
 svx/source/table/cell.cxx |   69 +++--
 svx/source/table/tablecolumn.cxx  |1 
 svx/source/table/tablemodel.cxx   |1 
 svx/source/table/tablerow.cxx |1 
 svx/source/table/tableundo.cxx|   16 ++---
 svx/source/table/tableundo.hxx|6 +-
 8 files changed, 106 insertions(+), 77 deletions(-)

New commits:
commit 7a1f2f0b9906228ce970d48fef29dd25cd4cc55b
Author: Noel Grandin 
AuthorDate: Mon May 1 21:43:32 2023 +0200
Commit: Noel Grandin 
CommitDate: Tue May 2 12:15:35 2023 +0200

use more specific class in sdr::table::Cell

mpProperties always points at a CellProperties object.

Change-Id: Ie78d015a23b48c5b40cbf3564974870e49a0b2af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151239
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/svx/inc/sdr/properties/cellproperties.hxx 
b/svx/inc/sdr/properties/cellproperties.hxx
new file mode 100644
index ..ce8dd062bb66
--- /dev/null
+++ b/svx/inc/sdr/properties/cellproperties.hxx
@@ -0,0 +1,81 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ * This file incorporates work covered by the following license notice:
+ *
+ *   Licensed to the Apache Software Foundation (ASF) under one or more
+ *   contributor license agreements. See the NOTICE file distributed
+ *   with this work for additional information regarding copyright
+ *   ownership. The ASF licenses this file to you under the Apache
+ *   License, Version 2.0 (the "License"); you may not use this file
+ *   except in compliance with the License. You may obtain a copy of
+ *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
+ */
+#pragma once
+
+#include "textproperties.hxx"
+#include 
+#include 
+
+namespace sdr::table
+{
+class Cell;
+typedef rtl::Reference CellRef;
+}
+
+namespace sdr::properties
+{
+class CellTextProvider : public svx::ITextProvider
+{
+public:
+explicit CellTextProvider(sdr::table::CellRef xCell);
+virtual ~CellTextProvider();
+
+private:
+virtual sal_Int32 getTextCount() const override;
+virtual SdrText* getText(sal_Int32 nIndex) const override;
+
+private:
+const sdr::table::CellRef m_xCell;
+};
+
+class CellProperties : public TextProperties
+{
+protected:
+// create a new itemset
+SfxItemSet CreateObjectSpecificItemSet(SfxItemPool& rPool) override;
+
+const svx::ITextProvider& getTextProvider() const override;
+
+public:
+// basic constructor
+CellProperties(SdrObject& rObj, ::sdr::table::Cell* pCell);
+
+// constructor for copying, but using new object
+CellProperties(const CellProperties& rProps, SdrObject& rObj, 
sdr::table::Cell* pCell);
+~CellProperties();
+
+// Clone() operator, normally just calls the local copy constructor
+std::unique_ptr Clone(SdrObject& rObj) const override;
+
+void ForceDefaultAttributes() override;
+
+void ItemSetChanged(o3tl::span aChangedItems,
+sal_uInt16 nDeletedWhich) override;
+
+void ItemChange(const sal_uInt16 nWhich, const SfxPoolItem* pNewItem = 
nullptr) override;
+
+sdr::table::CellRef mxCell;
+
+private:
+const CellTextProvider maTextProvider;
+};
+
+} // namespace sdr::properties
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/svx/source/inc/cell.hxx b/svx/source/inc/cell.hxx
index 34ae09223ce5..b70c683ddde1 100644
--- a/svx/source/inc/cell.hxx
+++ b/svx/source/inc/cell.hxx
@@ -37,7 +37,7 @@
 class SfxItemSet;
 class OutlinerParaObject;
 class SdrObject;
-namespace sdr::properties { class TextProperties; }
+namespace sdr::properties { class CellProperties; }
 
 
 namespace sdr::table {
@@ -173,9 +173,7 @@ public:
 using SvxUnoTextRangeBase::setPropertyValue;
 using SvxUnoTextRangeBase::getPropertyValue;
 
-SVX_DLLPRIVATE sdr::properties::TextProperties* CloneProperties( 
SdrObject& rNewObj, Cell& rNewCell );
-
-SVX_DLLPRIVATE static sdr::properties::TextProperties* CloneProperties( 
sdr::properties::TextProperties const * pProperties, SdrObject& rNewObj, Cell& 
rNewCell );
+SVX_DLLPRIVATE sdr::properties::CellProperties* CloneProperties( 
SdrObject& rNewObj, Cell& rNewCell );
 
 SVX_DLLPRIVATE void notifyModified();
 
@@ -196,7 +194,7 @@ private:
 
 const SvxItemPropertySet* mpPropSet;
 
-std::unique_ptr mpProperties;
+std::unique_ptr mpProperties;
 
 css::table::CellContentType mnCellContentType;
 
diff --git a/svx/source/table/cell.cxx b/svx/source/table/cell.cxx
index 

[Libreoffice-bugs] [Bug 109178] [META] Named Cell Ranges and Formula Expressions bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109178

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Summary|[META] Cell names bugs and  |[META] Named Cell Ranges
   |enhancements|and Formula Expressions
   ||bugs and enhancements
Version|unspecified |Inherited From OOo

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
Named ranges can also be set and accessed via the Name Box in the Calc formula
bar.
https://help.libreoffice.org/7.5/en-US/text/scalc/02/0601.html

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155070] An easier way to access the skia.log

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155070

--- Comment #6 from Heiko Tietze  ---
If the log is not too long we could copy it with the version button in the
about box.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154386] [META] XML Form

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=154386

Robert Großkopf  changed:

   What|Removed |Added

 Depends on||155121, 155123


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=155121
[Bug 155121] XML Form Document: Impossible to create a user defined data type
and set field as "not required"
https://bugs.documentfoundation.org/show_bug.cgi?id=155123
[Bug 155123] XML Form Document: Deleting parts of user defined data type
impossible.
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155121] XML Form Document: Impossible to create a user defined data type and set field as "not required"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155121

Robert Großkopf  changed:

   What|Removed |Added

 Blocks||154386


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=154386
[Bug 154386] [META] XML Form
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155123] XML Form Document: Deleting parts of user defined data type impossible.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155123

Robert Großkopf  changed:

   What|Removed |Added

 Blocks||154386


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=154386
[Bug 154386] [META] XML Form
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155123] New: XML Form Document: Deleting parts of user defined data type impossible.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155123

Bug ID: 155123
   Summary: XML Form Document: Deleting parts of user defined data
type impossible.
   Product: LibreOffice
   Version: 7.6.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rob...@familiegrosskopf.de

Have a look at 
https://bugs.documentfoundation.org/attachment.cgi?id=187049

There are two fields with user defined data types.
Take the first field an let you show the properties for this field. Design mode
has to be set to 'on' in the toolbar "form design".
Try to delete the entry for "Length (at most)", because it isn't needed.
It is impossible to delete the entry. '5' will always reappear. You could set
it to '4' (which does conflict with the other entries …). But you couldn't set
it blank. If you try to set it '0' the '0' will disappear and '5' will
reappear.

Only possibility I found: Delete the user defined data type and create a new
one.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155122] Assertion failed when terminating headless soffice process using Ctrl+C in console on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155122

Mike Kaganski  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |ASSIGNED
   Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com
   |desktop.org |

--- Comment #1 from Mike Kaganski  ---
https://gerrit.libreoffice.org/c/core/+/151261

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155122] New: Assertion failed when terminating headless soffice process using Ctrl+C in console on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155122

Bug ID: 155122
   Summary: Assertion failed when terminating headless soffice
process using Ctrl+C in console on Windows
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mikekagan...@hotmail.com

On Windows, using a debug build:

1. In console, start 'soffice --headless'
2. Press Ctrl+C

==> an application error dialog appears.
The failing assertion is in RequestHandler::~RequestHandler
(desktop/source/app/officeipcthread.cxx), mIpcThread is not empty.

Expected result: the process must exit cleanly.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155121] New: XML Form Document: Impossible to create a user defined data type and set field as "not required"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155121

Bug ID: 155121
   Summary: XML Form Document: Impossible to create a user defined
data type and set field as "not required"
   Product: LibreOffice
   Version: 7.6.0.0 alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rob...@familiegrosskopf.de

Created attachment 187049
  --> https://bugs.documentfoundation.org/attachment.cgi?id=187049=edit
XML form document with two fields, user defined data

Open the attached XML form document.
There are 2 form fields.
Both fields haven't filled with content.
Both fields will appear with red border.
First field will change color with 5 digits, second field will need 5
characters (also digits possible).

Now have a look at the properties for this fields. You could get them from the
bindings, the entry in Instance 1 or direct from the properties of the form
control.
Data → Required isn't set.
But there is set for both field a user create data type.
The control will always react as if Data → Required is set.

So it is impossible to set something like "let it blank or put 5 digits for a
postcode".

Bug appears in all LO versions here.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 115775] [META] Database Range and Consolidate bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115775

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Summary|[META] Data range and   |[META] Database Range and
   |consolidate bugs and|Consolidate bugs and
   |enhancements|enhancements
Version|unspecified |Inherited From OOo

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154696] No chapter type in function types

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=154696

--- Comment #9 from Bernard Choppy  ---
Well, thanks to all. I feel a bit idiot because I already used this elsewhere,
but the doc puzzled me apparently.
Glad to have been able to enhance LO with your help.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 101876] UI: resizing function wizard only resize the formula field, not the structure and parameter fields width

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101876

Heiko Tietze  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |heiko.tietze@documentfounda
   |desktop.org |tion.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155034] Cannot open or create file in Impress / Draw on Ubuntu 18.04 or 20.04 after Update libxmlsec to 1.3.0

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155034

Timur  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #32 from Timur  ---
Fine now, thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140559] FILEOPEN DOCX page layout "Bookfold" needs "mirrored" in LibreOffice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140559

--- Comment #3 from Regina Henschel  ---
Import of brochure is still wrong in Version: 7.6.0.0.alpha0+ (X86_64) /
LibreOffice Community
Build ID: 4829a85d0753c93419bd46b1d50bcfa6f0f3f1da
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (en_US); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147291] macOS: Digital Signatures > Start Certificate Manager (OpenPGP) results in error instead of opening GPG Keychain

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147291

--- Comment #9 from Andrew Watson  ---
Bug still present in:

Version: 7.4.6.2 / LibreOffice Community
Build ID: 5b1f5509c2decdade7fda905e3e1429a67acd63d
CPU threads: 4; OS: Mac OS X 10.14.6; UI render: default; VCL: osx
Locale: en-GB (en_GB.UTF-8); UI: en-GB
Calc: threaded

GPG Suite 2020.2 installed, including GPG Keychain 1.7, and seemingly fully
functional.

https://gpgtools.org/releases/gpgsuite/release-notes.html

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 129062] [META] Skia library bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129062

Hossein  changed:

   What|Removed |Added

 Depends on||153554


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=153554
[Bug 153554] Crash when closing LibreOffice opened via SDK (debug)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153554] Crash when closing LibreOffice opened via SDK (debug)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153554

Hossein  changed:

   What|Removed |Added

  Component|sdk |graphics stack
 Blocks||129062

--- Comment #14 from Hossein  ---
The problem is from Skia, as the surface is not disposed in
SkiaSalGraphicsImpl::~SkiaSalGraphicsImpl() for some reason. By disabling Skia,
the problem is no longer there.

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: bcd233e45f1d793555e29522d1c30b67c574b628
CPU threads: 32; OS: Windows 10.0 Build 19044; UI render: default; VCL: win
Locale: en-US (en_DE); UI: en-US
Calc: threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=129062
[Bug 129062] [META] Skia library bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153554] Crash when closing LibreOffice opened via SDK (debug)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153554

Hossein  changed:

   What|Removed |Added

   Keywords||haveBacktrace

--- Comment #13 from Hossein  ---
The problem seems to be from LibreOffice Skia code. This is the backtrace I
have created by attaching the VS debugger to the soffice.bin process:

vcl/skia/gdiimpl.cxx:290
---
SkiaSalGraphicsImpl::~SkiaSalGraphicsImpl()
{
assert(!mSurface); <- Exception thrown from here
assert(!mWindowContext);
}

---
ucrtbased.dll!7ffa7f037475()Unknown
ucrtbased.dll!7ffa7f037613()Unknown
ucrtbased.dll!7ffa7f04d86d()Unknown
ucrtbased.dll!7ffa7f0530bf()Unknown
ucrtbased.dll!7ffa7f0510b8()Unknown
ucrtbased.dll!7ffa7f053a1f()Unknown
>   vcllo.dll!SkiaSalGraphicsImpl::~SkiaSalGraphicsImpl() Line 290  C++
[External Code] 
vclplug_winlo.dll!WinSalGraphics::~WinSalGraphics() Line 668C++
[External Code] 
vclplug_winlo.dll!WinSalFrame::~WinSalFrame() Line 969  C++
[External Code] 
vclplug_winlo.dll!SalComWndProc(HWND__ * __formal, unsigned int nMsg,
unsigned __int64 wParam, __int64 lParam, bool & rDef) Line 666C++
vclplug_winlo.dll!SalComWndProcW(HWND__ * hWnd, unsigned int nMsg,
unsigned __int64 wParam, __int64 lParam) Line 723C++
[External Code] 
vclplug_winlo.dll!WinSalInstance::DestroyFrame(SalFrame * pFrame) Line
805  C++
vcllo.dll!vcl::Window::dispose() Line 537   C++
vcllo.dll!ImplBorderWindow::dispose() Line 1607 C++
vcllo.dll!VclReferenceBase::disposeOnce() Line 39   C++
vcllo.dll!VclPtr::disposeAndClear() Line 207   C++
vcllo.dll!vcl::Window::dispose() Line 509   C++
vcllo.dll!SystemWindow::dispose() Line 115  C++
vcllo.dll!WorkWindow::dispose() Line 128C++
vcllo.dll!VclReferenceBase::disposeOnce() Line 39   C++
tklo.dll!VclPtr::disposeAndClear() Line 207C++
tklo.dll!VCLXWindow::dispose() Line 927 C++
fwklo.dll!`anonymous namespace'::XFrameImpl::disposing() Line 2199 
C++
cppuhelper3MSC.dll!cppu::WeakComponentImplHelperBase::dispose() Line
104C++
   
fwklo.dll!cppu::PartialWeakComponentImplHelper::dispose()
Line 90   C++
fwklo.dll!`anonymous namespace'::XFrameImpl::close(unsigned char
bDeliverOwnership) Line 1733   C++
fwklo.dll!framework::pattern::frame::closeIt(const
com::sun::star::uno::Reference & xResource)
Line 57 C++
fwklo.dll!framework::CloseDispatcher::implts_closeFrame() Line 500 
C++
fwklo.dll!framework::CloseDispatcher::impl_asyncCallback(LinkParamNone
* __formal) Line 379 C++
fwklo.dll!framework::CloseDispatcher::LinkStubimpl_asyncCallback(void *
instance, LinkParamNone * data) Line 246C++
vcllo.dll!Link::Call(LinkParamNone * data) Line
111   C++
vcllo.dll!vcl::EventPoster::DoEvent_Impl(void * __formal) Line 53  
C++
vcllo.dll!vcl::EventPoster::LinkStubDoEvent_Impl(void * instance, void
* data) Line 48  C++
vcllo.dll!Link::Call(void * data) Line 111 C++
vcllo.dll!ImplHandleUserEvent(ImplSVEvent * pSVEvent) Line 2290 C++
vcllo.dll!ImplWindowFrameProc(vcl::Window * _pWindow, SalEvent nEvent,
const void * pEvent) Line 2858   C++
vcllo.dll!SalFrame::CallCallback(SalEvent nEvent, const void * pEvent)
Line 309 C++
vclplug_winlo.dll!ImplHandleUserEvent(HWND__ * hWnd, __int64 lParam)
Line 4252  C++
vclplug_winlo.dll!SalFrameWndProc(HWND__ * hWnd, unsigned int nMsg,
unsigned __int64 wParam, __int64 lParam, bool & rDef) Line 5903 C++
vclplug_winlo.dll!SalFrameWndProcW(HWND__ * hWnd, unsigned int nMsg,
unsigned __int64 wParam, __int64 lParam) Line 6010 C++
[External Code] 
vclplug_winlo.dll!ImplSalDispatchMessage(const tagMSG * pMsg) Line 474 
C++
vclplug_winlo.dll!ImplSalYield(bool bWait, bool
bHandleAllCurrentEvents) Line 505   C++
vclplug_winlo.dll!WinSalInstance::DoYield(bool bWait, bool
bHandleAllCurrentEvents) Line 580C++
vcllo.dll!ImplYield(bool i_bWait, bool i_bAllEvents) Line 385   C++
vcllo.dll!Application::Yield() Line 470 C++
vcllo.dll!Application::Execute() Line 363   C++
sofficeapp.dll!desktop::Desktop::Main() Line 1593   C++
vcllo.dll!ImplSVMain() Line 203 C++
vcllo.dll!SVMain() Line 236 C++
sofficeapp.dll!soffice_main() Line 94   C++
soffice.bin!sal_main() Line 51  C
soffice.bin!main(int argc, char * * argv) Line 49   C
[External Code]

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 121140] Misleading GPG encryption option

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121140

--- Comment #6 from Andrew Watson  ---
Bug still present in:

Version: 7.4.6.2 / LibreOffice Community
Build ID: 5b1f5509c2decdade7fda905e3e1429a67acd63d
CPU threads: 4; OS: Mac OS X 10.14.6; UI render: default; VCL: osx
Locale: en-GB (en_GB.UTF-8); UI: en-GB
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Crash test update

[Miklos Vajna]

Hi,

On Mon, Apr 24, 2023 at 10:37:25PM +, crashtest 
 wrote:
> New crashtest update available at 
> .
> 
> 94 files have crashed during import.

I see that 67 of these are DOCX/DOC/RTF files, I'll take a look at those
to address split fly problems.

Regards,

Miklos

[Libreoffice-bugs] [Bug 155111] LibreOffice Start impossible on Win 11 for 7.4.6, 7.5.2.2 and 7.6.0.0

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155111

--- Comment #3 from Rolf Suessbrich  ---
Strange!

This morning after restarting the PC the problem still exixts.

I've started to find any useful additional information. The only quirky issue
is the output starting soffice.exe in a cmd-window with the parameter --help.
After a while a new window is presented which contains only the last part of
the messages, see attached screenprint. It is possible to see in sysinternals
process-explorer that this new terminal window is launched by soffice.bin. 

I looked at all entries in the registry referring LibreOffice but none of the
numerous entries found seemed to be irregular. 

Finally, I started LIBO again by double clicking the icon and 7.4.6.2 started
as expected. Oh wonder! Such the problem is currently no longer reproducible.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155120] New: LO eats up 100% of system resources just for processing mouse movement

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155120

Bug ID: 155120
   Summary: LO eats up 100% of system resources just for
processing mouse movement
   Product: LibreOffice
   Version: 7.5.2.2 release
  Hardware: x86-64 (AMD64)
OS: macOS (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: birnb...@posteo.de

Description:
Draw has become very hard to use as mouse click and mouse release take ~0.5 s
to process. A CPU meter shows that LO keeps the whole machine busy just by
processing mouse movement (no click).

Writer feels slowish too. Here it is WindowServer with ~20% and soffice with
15% just for processing mouse movement (no click). 

Steps to Reproduce:
1. open an empty drawing in LibreOffice
2. in parallel, open a CPU gauge tool (e.g. 'top -s1' in a terminal)
3. move the mouse in the SO window while observing CPU readouts

Actual Results:
process 'soffice' consumes 100% of available CPU resources while mouse cursor
is in the LO window

Expected Results:
very low load on CPU


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Version: 7.5.2.2 (X86_64) / LibreOffice Community
Build ID: 53bb9681a964705cf672590721dbc85eb4d0c3a2
CPU threads: 6; OS: Mac OS X 13.3.1; UI render: default; VCL: osx
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Calc: threaded

My machine is a 27" iMac with 5G display and Intel processor:
3 GHz 6-Core Intel Core i5
Radeon Pro 570X 4 GB
OS: 13.3.1 (22E261)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155049] "X.509" in dialog title when signing or encrypting ODF file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155049

Andrew Watson  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from Andrew Watson  ---
Bug confirmed present in:

Version: 7.4.6.2 / LibreOffice Community
Build ID: 5b1f5509c2decdade7fda905e3e1429a67acd63d
CPU threads: 4; OS: Mac OS X 10.14.6; UI render: default; VCL: osx
Locale: en-GB (en_GB.UTF-8); UI: en-GB
Calc: threaded

Set status to NEW.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sc/source

[Eike Rathke (via logerrit)]

 sc/source/core/tool/interpr1.cxx |9 -
 1 file changed, 8 insertions(+), 1 deletion(-)

New commits:
commit ade4e5cc9bb5a2026d8a9bdccd18c1645a7dd032
Author: Eike Rathke 
AuthorDate: Sat Apr 29 18:59:30 2023 +0200
Commit: Xisco Fauli 
CommitDate: Tue May 2 11:09:28 2023 +0200

Resolves: tdf#119659 Check found position for result vector

Change-Id: Idc454462c47b6c7b7b7cb6c86b08650d059221c7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151186
Reviewed-by: Eike Rathke 
Tested-by: Jenkins
(cherry picked from commit 6b6b83b43fcae13e30a9ca67b421187a5e0d7142)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151191
Reviewed-by: Xisco Fauli 

diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx
index eb77bf07e514..94964b1a081c 100644
--- a/sc/source/core/tool/interpr1.cxx
+++ b/sc/source/core/tool/interpr1.cxx
@@ -7063,7 +7063,8 @@ void ScInterpreter::ScLookup()
 if (pResMat)
 {
 VectorMatrixAccessor aResMatAcc(*pResMat, bVertical);
-// result array is matrix.
+// Result array is matrix.
+// Note this does not replicate the other dimension.
 if (o3tl::make_unsigned(nDelta) >= aResMatAcc.GetElementCount())
 {
 PushNA();
@@ -7197,6 +7198,12 @@ void ScInterpreter::ScLookup()
 {
 VectorMatrixAccessor aResMatAcc(*pResMat, bVertical);
 // Use the matrix result array.
+// Note this does not replicate the other dimension.
+if (o3tl::make_unsigned(nDelta) >= aResMatAcc.GetElementCount())
+{
+PushNA();
+return;
+}
 if (aResMatAcc.IsValue(nDelta))
 PushDouble(aResMatAcc.GetDouble(nDelta));
 else

[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - sc/source

[Eike Rathke (via logerrit)]

 sc/source/core/tool/interpr1.cxx |9 -
 1 file changed, 8 insertions(+), 1 deletion(-)

New commits:
commit 700e918ba7c481034a4629fbbf95e829e2a2786a
Author: Eike Rathke 
AuthorDate: Sat Apr 29 18:59:30 2023 +0200
Commit: Xisco Fauli 
CommitDate: Tue May 2 11:09:40 2023 +0200

Resolves: tdf#119659 Check found position for result vector

Change-Id: Idc454462c47b6c7b7b7cb6c86b08650d059221c7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151186
Reviewed-by: Eike Rathke 
Tested-by: Jenkins
(cherry picked from commit 89e725dc3236f6f8ad226adf6508f7fc753b5572)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151190
Reviewed-by: Xisco Fauli 

diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx
index ac0fb22b6231..b833e3f48f24 100644
--- a/sc/source/core/tool/interpr1.cxx
+++ b/sc/source/core/tool/interpr1.cxx
@@ -7072,7 +7072,8 @@ void ScInterpreter::ScLookup()
 if (pResMat)
 {
 VectorMatrixAccessor aResMatAcc(*pResMat, bVertical);
-// result array is matrix.
+// Result array is matrix.
+// Note this does not replicate the other dimension.
 if (o3tl::make_unsigned(nDelta) >= aResMatAcc.GetElementCount())
 {
 PushNA();
@@ -7206,6 +7207,12 @@ void ScInterpreter::ScLookup()
 {
 VectorMatrixAccessor aResMatAcc(*pResMat, bVertical);
 // Use the matrix result array.
+// Note this does not replicate the other dimension.
+if (o3tl::make_unsigned(nDelta) >= aResMatAcc.GetElementCount())
+{
+PushNA();
+return;
+}
 if (aResMatAcc.IsValue(nDelta))
 PushDouble(aResMatAcc.GetDouble(nDelta));
 else

[Libreoffice-bugs] [Bug 151841] LO Calc Conditional Formatting Not Saved on Pivot Table When Saving to .xlsx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151841

--- Comment #11 from Gabor Kelemen (allotropia)  ---
Created attachment 187048
  --> https://bugs.documentfoundation.org/attachment.cgi?id=187048=edit
The 7.6-master saved xlsx version of the example file

Made with the fresh nightly:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: fb3a6b82b55a298eabf8f431f1451dc826642acd
CPU threads: 14; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: threaded

I also can confirm the bibisect points to the correct change.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151841] LO Calc Conditional Formatting Not Saved on Pivot Table When Saving to .xlsx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151841

--- Comment #10 from Gabor Kelemen (allotropia)  ---
Created attachment 187047
  --> https://bugs.documentfoundation.org/attachment.cgi?id=187047=edit
The 6.1-saved xlsx version of the example file

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155075] ~ triggers the side panel in French localisation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155075

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 Blocks||107244

--- Comment #3 from Stéphane Guillou (stragu) 
 ---
Setting to new because I see it reported in bug 145170 comment 2. 

Somewhat similar issue in bug 146906 comment 26. There are various issues with
Alt Gr vs Ctrl + Alt shortcuts depending on keyboard layouts, see bug 107244.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107244
[Bug 107244] [META] Ctrl+Alt (aka AltGR) keyboard shortcut issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107244] [META] Ctrl+Alt (aka AltGR) keyboard shortcut issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107244

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||155075


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=155075
[Bug 155075] ~ triggers the side panel in French localisation
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151841] LO Calc Conditional Formatting Not Saved on Pivot Table When Saving to .xlsx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151841

--- Comment #9 from Gabor Kelemen (allotropia)  ---
Created attachment 187046
  --> https://bugs.documentfoundation.org/attachment.cgi?id=187046=edit
XLSX versions of the example file opened in Excel 13

Interestingly Excel 13 can read both xlsx files well.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155111] LibreOffice Start impossible on Win 11 for 7.4.6, 7.5.2.2 and 7.6.0.0

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155111

--- Comment #2 from Rolf Suessbrich  ---
Created attachment 187045
  --> https://bugs.documentfoundation.org/attachment.cgi?id=187045=edit
irregular output using the --help parameter while starting soffice

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151841] LO Calc Conditional Formatting Not Saved on Pivot Table When Saving to .xlsx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151841

--- Comment #8 from Gabor Kelemen (allotropia)  ---
Created attachment 187044
  --> https://bugs.documentfoundation.org/attachment.cgi?id=187044=edit
XLSX versions of the example file opened in LO 7.6 master

If the same files are reloaded in current master the CF is not visible in case
the 7.6-saved file, but works with the 6.1-made one.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151841] LO Calc Conditional Formatting Not Saved on Pivot Table When Saving to .xlsx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151841

--- Comment #7 from Gabor Kelemen (allotropia)  ---
Created attachment 187043
  --> https://bugs.documentfoundation.org/attachment.cgi?id=187043=edit
XLSX versions of the example file opened in LO 6.1.0

When the example file is saved as xlsx in 6.1 and 7.6, and opened in 6.1 the CF
is not visible with the one made by 7.6.
So the roundtrip was indeed good before the bibisected change in 6.3.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151841] LO Calc Conditional Formatting Not Saved on Pivot Table When Saving to .xlsx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151841

--- Comment #6 from Gabor Kelemen (allotropia)  ---
Created attachment 187042
  --> https://bugs.documentfoundation.org/attachment.cgi?id=187042=edit
Example file with Pivot table and CF applied on it

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155097] Glyph replacement for foreign digits

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155097

sh.ya...@gmail.com  changed:

   What|Removed |Added

 CC||sh.ya...@gmail.com

--- Comment #1 from sh.ya...@gmail.com  ---
Created attachment 187041
  --> https://bugs.documentfoundation.org/attachment.cgi?id=187041=edit
The numbers are incorrect

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155119] Text format selection is unusable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155119

sh.ya...@gmail.com  changed:

   What|Removed |Added

 CC||sh.ya...@gmail.com

--- Comment #1 from sh.ya...@gmail.com  ---
Created attachment 187040
  --> https://bugs.documentfoundation.org/attachment.cgi?id=187040=edit
The actual garbled section in red

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155119] New: Text format selection is unusable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155119

Bug ID: 155119
   Summary: Text format selection is unusable
   Product: LibreOffice
   Version: 7.6.0.0 alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sh.ya...@gmail.com

Description:
In the NotebookBar there's an option to selection text format (Body, Headers,
etc.), this box is completely garbled and there's no way to select the
appropriate style.

Steps to Reproduce:
1.Switch to NotebookBar
2.Make sure that the Home tab is selected
3.Observer the text formatting section

Actual Results:
Completely garbled text

Expected Results:
Table showing all the different options


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Version: 7.5.2.2 (X86_64) / LibreOffice Community
Build ID: 53bb9681a964705cf672590721dbc85eb4d0c3a2
CPU threads: 8; OS: Linux 6.3; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-IL (en_IL); UI: he-IL
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: include/xmloff xmloff/source

[Miklos Vajna (via logerrit)]

 include/xmloff/xmlimp.hxx|2 
 include/xmloff/xmlimppr.hxx  |4 
 include/xmloff/xmlnumfi.hxx  |   74 +++---
 xmloff/source/core/xmlimp.cxx|4 
 xmloff/source/style/xmlimppr.cxx |   10 
 xmloff/source/style/xmlnumfi.cxx |  450 +++
 6 files changed, 272 insertions(+), 272 deletions(-)

New commits:
commit 41e3d2c936f008d010a64c00904539eed2392551
Author: Miklos Vajna 
AuthorDate: Tue May 2 08:22:40 2023 +0200
Commit: Miklos Vajna 
CommitDate: Tue May 2 10:51:55 2023 +0200

sw: prefix members of SvXMLImport, SvXMLImportPropertyMapper, ...

... SvXMLNumFmtHelper and SvXMLNumFormatContext

See tdf#94879 for motivation.

Change-Id: I1942fae05f2df1f23e0b05f8cb0eaa1f6df73f18
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151252
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/include/xmloff/xmlimp.hxx b/include/xmloff/xmlimp.hxx
index 3e1d8966b47b..3287911f1112 100644
--- a/include/xmloff/xmlimp.hxx
+++ b/include/xmloff/xmlimp.hxx
@@ -227,7 +227,7 @@ class XMLOFF_DLLPUBLIC SAL_LOPLUGIN_ANNOTATE("crosscast") 
SvXMLImport : public c
 SAL_DLLPRIVATE void InitCtor_();
 
 SvXMLImportFlags  mnImportFlags;
-std::set< OUString > embeddedFontUrlsKnown;
+std::set< OUString > m_embeddedFontUrlsKnown;
 css::uno::Reference< css::xml::sax::XFastParser > mxParser;
 rtl::Reference< SvXMLImportFastNamespaceHandler > maNamespaceHandler;
 rtl::Reference < comphelper::AttributeList > maNamespaceAttrList;
diff --git a/include/xmloff/xmlimppr.hxx b/include/xmloff/xmlimppr.hxx
index 4419c91783a2..adfba4eadc60 100644
--- a/include/xmloff/xmlimppr.hxx
+++ b/include/xmloff/xmlimppr.hxx
@@ -65,7 +65,7 @@ class XMLOFF_DLLPUBLIC SvXMLImportPropertyMapper : public 
salhelper::SimpleRefer
 {
 rtl::Reference< SvXMLImportPropertyMapper> mxNextMapper;
 
-SvXMLImport& rImport;   // access to error handling
+SvXMLImport& m_rImport;   // access to error handling
 
 SvXMLImportPropertyMapper(SvXMLImportPropertyMapper const &) = delete;
 SvXMLImportPropertyMapper& operator =(SvXMLImportPropertyMapper const &) = 
delete;
@@ -73,7 +73,7 @@ class XMLOFF_DLLPUBLIC SvXMLImportPropertyMapper : public 
salhelper::SimpleRefer
 protected:
 
 rtl::Reference< XMLPropertySetMapper > maPropMapper;
-SvXMLImport& GetImport() const { return rImport;}
+SvXMLImport& GetImport() const { return m_rImport;}
 
 public:
 
diff --git a/include/xmloff/xmlnumfi.hxx b/include/xmloff/xmlnumfi.hxx
index 9a18893df3c6..bebc580a937b 100644
--- a/include/xmloff/xmlnumfi.hxx
+++ b/include/xmloff/xmlnumfi.hxx
@@ -69,7 +69,7 @@ class LocaleDataWrapper;
 
 class SvXMLNumFmtHelper
 {
-std::unique_ptr pData;
+std::unique_ptr m_pData;
 
 public:
 SvXMLNumFmtHelper(
@@ -87,7 +87,7 @@ public:
 const css::uno::Reference< css::xml::sax::XFastAttributeList 
>& xAttrList,
 SvXMLStylesContext& rStyles);
 
-SvXMLNumImpData* getData() { return pData.get(); }
+SvXMLNumImpData* getData() { return m_pData.get(); }
 
 LanguageType GetLanguageForKey(sal_Int32 nKey) const;
 
@@ -127,40 +127,40 @@ public:
 
 private:
 
-SvXMLNumImpData*pData;
-SvXMLStylesContext* pStyles;
-std::vectoraMyConditions;
-SvXMLStylesTokens nType;
-sal_Int32   nKey;
+SvXMLNumImpData*m_pData;
+SvXMLStylesContext* m_pStyles;
+std::vectorm_aMyConditions;
+SvXMLStylesTokens m_nType;
+sal_Int32   m_nKey;
 //  OUString   sFormatName;
-OUString   sFormatTitle;
+OUString   m_sFormatTitle;
 //  OUString   sMapName;
-OUString   sCalendar;
-OUString   aImplicitCalendar[2];
-ImplicitCalendar eImplicitCalendar;
-LanguageType   nFormatLang;
-boolbAutoOrder;
-boolbFromSystem;
-boolbTruncate;
-boolbAutoDec;   // set in AddNumber
-boolbAutoInt;   // set in AddNumber
-boolbHasExtraText;
-boolbHasTrailingEmptyText;
-OUStringBuffer aFormatCode{64};
-OUStringBuffer aConditions{32};
-boolbHasLongDoW;
-boolbHasDateTime;
-boolbRemoveAfterUse;
+OUString   m_sCalendar;
+OUString   m_aImplicitCalendar[2];
+ImplicitCalendar m_eImplicitCalendar;
+LanguageType   m_nFormatLang;
+boolm_bAutoOrder;
+boolm_bFromSystem;
+boolm_bTruncate;
+boolm_bAutoDec;   // set in AddNumber
+boolm_bAutoInt;   // set in AddNumber
+boolm_bHasExtraText;
+boolm_bHasTrailingEmptyText;
+OUStringBuffer m_aFormatCode{64};
+OUStringBuffer m_aConditions{32};
+boolm_bHasLongDoW;
+boolm_bHasDateTime;
+boolm_bRemoveAfterUse;
 
 //  

[Libreoffice-bugs] [Bug 155070] An easier way to access the skia.log

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155070

--- Comment #5 from Stéphane Guillou (stragu) 
 ---
We could perhaps add the text to the log produced by the Run Graphics Tests
tool? That way, people have an install-agnostic way to get it within the UI,
while adding nothing new to the UI.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155070] An easier way to access the skia.log

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155070

--- Comment #4 from Telesto  ---
(In reply to Heiko Tietze from comment #3)
> QA people and developers shouldn't struggle to find the user profile and
> read the log file. And ordinary users should not face crashes anyway. So -1
> to make it easier to access.

The whole point being that we have to ask ordinary users for feedback. Unsure
if we can call bug reporters at bugzilla 'ordinary users', though. 

The Skia Vulkan crashes are - so it seems - highly dependent on driver +
graphic chipset. QA has only limited access. Even developers unable to
reproduce those crashes, which makes them pretty much unsolvable.

Also keep in mind: the causes are in multiple layers. Driver issue, Skia
backend-issue, implementation issue at LibreOffice. And obviously mostly some
combination of all three.

--
Ordinary users should not face crashes anyway. 

Fully agree. 

My personal preference would be to make Skia Vulkan opt-in. So default being
Skia Raster. Performance is decent. Not as fast as Vulkan, but not prone to
crashes either as far I'm aware.

Arguments:
* There is no developer activity at the Skia front for a while. 
* The Skia Vulkan has known crashing issues - like Bug 149527 and bug 153922
* See the crash reporter stats. dll's major crashes point to dll's of graphic
cards. Likely crashing once, and activating fall-back to Skia-Raster
(https://crashreport.libreoffice.org/stats/) igc64.dll / igvk64.dll
* The sudden crashes are causing dataloss left and right; maybe indirectly
exposing some issue with document system. 
* People who need the extra performance can still opt for Vulkan, but usage is
at their own risk. 
* It makes the access to the skia.log less problematic. Less users will rely on
Skia Vulkan, less crashes...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 83066] [META] CJK (Chinese, Japanese, Korean, and Vietnamese) language issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83066

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||155074


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=155074
[Bug 155074] libreoffice with qt5 frontend fcitx5-qt5 in plasma X11
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155074] libreoffice with qt5 frontend fcitx5-qt5 in plasma X11

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155074

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Blocks||83066
 CC||stephane.guillou@libreoffic
   ||e.org
 Ever confirmed|1   |0
 Status|NEW |UNCONFIRMED

--- Comment #6 from Stéphane Guillou (stragu) 
 ---
Thanks for the report, iclementine!
Please don't set your own reports to "new" as others have to confirm they also
see the issue.
Did this issue start with LibreOffice 7.5, or was it present before?

Could you please test running LibreOffice with the qt5 VCL, with the following
commande:

SAL_USE_VCLPLUGIN=qt5 libreoffice

Does the issue remain?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=83066
[Bug 83066] [META] CJK (Chinese, Japanese, Korean, and Vietnamese) language
issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sal/osl

[Noel Grandin (via logerrit)]

 sal/osl/w32/backtrace.cxx |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit bcd233e45f1d793555e29522d1c30b67c574b628
Author: Noel Grandin 
AuthorDate: Tue May 2 09:52:43 2023 +0200
Commit: Noel Grandin 
CommitDate: Tue May 2 10:37:53 2023 +0200

improve windows backtrace_to_string

I want to know the symbol address we actually capture, since
we seem to getting duplicates in the output of SymFromAddr, I
want to know if the fault is in SymFromAddr, or the backtrace
capture call.

Change-Id: Iece9c204abb780ae6b67a11e6ba77db816351e8b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151254
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sal/osl/w32/backtrace.cxx b/sal/osl/w32/backtrace.cxx
index 8d55c6485a12..0b38d1962bc1 100644
--- a/sal/osl/w32/backtrace.cxx
+++ b/sal/osl/w32/backtrace.cxx
@@ -74,10 +74,11 @@ OUString sal::backtrace_to_string(BacktraceState* 
backtraceState)
 OUStringBuffer aBuf;
 for( int i = 0; i < nFrames; i++ )
 {
-SymFromAddr( hProcess, 
reinterpret_cast(backtraceState->buffer[ i ]), nullptr, pSymbol );
+auto pSymAddr = reinterpret_cast(backtraceState->buffer[ i ]);
+SymFromAddr( hProcess, pSymAddr, nullptr, pSymbol );
 aBuf.append( OUString::number(nFrames - i - 1) + ": " );
 aBuf.appendAscii( pSymbol->Name );
-aBuf.append( " - 0x" + OUString::number(pSymbol->Address, 16) + "\n" );
+aBuf.append( " - 0x" + OUString::number(pSymAddr, 16) + "\n" );
 }
 
 free( pSymbol );

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - 2 commits - desktop/source include/rtl include/vcl sd/source sw/source vcl/source

[Szymon Kłos (via logerrit)]

 desktop/source/deployment/registry/configuration/dp_configuration.cxx |   36 
--
 include/rtl/xmlencode.hxx |   55 
++
 include/vcl/pdfwriter.hxx |2 
 sd/source/filter/html/htmlex.cxx  |5 
 sw/source/filter/html/css1atr.cxx |3 
 sw/source/filter/html/htmlfldw.cxx|3 
 sw/source/ui/dialog/uiregionsw.cxx|   13 ++
 vcl/source/gdi/pdfwriter_impl.cxx |   39 
---
 8 files changed, 81 insertions(+), 75 deletions(-)

New commits:
commit c7fffb9ff3a0d0636d86bf68086d5ae3fd3f8ae6
Author: Szymon Kłos 
AuthorDate: Fri Apr 7 19:03:55 2023 +0200
Commit: Szymon Kłos 
CommitDate: Tue May 2 10:33:50 2023 +0200

lok: Hide file linking in section

this is followup for 6f56317

Change-Id: I87227b3e665a6d15378ee294556bcd2f95801e6b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151231
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Szymon Kłos 

diff --git a/sw/source/ui/dialog/uiregionsw.cxx 
b/sw/source/ui/dialog/uiregionsw.cxx
index afe90adc6c21..37a7ab66fa9c 100644
--- a/sw/source/ui/dialog/uiregionsw.cxx
+++ b/sw/source/ui/dialog/uiregionsw.cxx
@@ -415,6 +415,19 @@ SwEditRegionDlg::SwEditRegionDlg(weld::Window* pParent, 
SwWrtShell& rWrtSh)
 
 m_xTree->show();
 m_bDontCheckPasswd = false;
+
+if(comphelper::LibreOfficeKit::isActive())
+{
+m_xBuilder->weld_label("label8")->hide(); // Link
+m_xFileCB->hide();
+m_xDDECB->hide();
+m_xDDECommandFT->hide();
+m_xFileNameFT->hide();
+m_xFileNameED->hide();
+m_xFilePB->hide();
+m_xSubRegionFT->hide();
+m_xSubRegionED->hide();
+}
 }
 
 bool SwEditRegionDlg::CheckPasswd(weld::Toggleable* pBox)
commit 69e5b9a7d95a481aae23e651729cceb618abd00c
Author: Szymon Kłos 
AuthorDate: Fri Apr 7 09:48:41 2023 +0200
Commit: Szymon Kłos 
CommitDate: Tue May 2 10:33:38 2023 +0200

Make encodeForXml accessible for other modules

and share similar code

Change-Id: I7729a46d40845893f577c273c1ab340f69ebb51b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151230
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Szymon Kłos 

diff --git 
a/desktop/source/deployment/registry/configuration/dp_configuration.cxx 
b/desktop/source/deployment/registry/configuration/dp_configuration.cxx
index 1f4ba053ec55..5baa4127ad26 100644
--- a/desktop/source/deployment/registry/configuration/dp_configuration.cxx
+++ b/desktop/source/deployment/registry/configuration/dp_configuration.cxx
@@ -31,6 +31,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -566,39 +567,6 @@ BackendImpl::PackageImpl::isRegistered_(
 }
 
 
-OUString encodeForXml( std::u16string_view text )
-{
-// encode conforming xml:
-size_t len = text.size();
-OUStringBuffer buf;
-for ( size_t pos = 0; pos < len; ++pos )
-{
-sal_Unicode c = text[ pos ];
-switch (c) {
-case '<':
-buf.append( "" );
-break;
-case '>':
-buf.append( "" );
-break;
-case '&':
-buf.append( "" );
-break;
-case '\'':
-buf.append( "" );
-break;
-case '\"':
-buf.append( "" );
-break;
-default:
-buf.append( c );
-break;
-}
-}
-return buf.makeStringAndClear();
-}
-
-
 OUString replaceOrigin(
 OUString const & url, std::u16string_view destFolder, Reference< 
XCommandEnvironment > const & xCmdEnv, Reference< XComponentContext > const & 
xContext, bool & out_replaced)
 {
@@ -651,7 +619,7 @@ OUString replaceOrigin(
 if (origin.isEmpty()) {
 // encode only once
 origin = OUStringToOString(
-encodeForXml( url.subView( 0, url.lastIndexOf( '/' ) ) ),
+rtl::encodeForXml( url.subView( 0, url.lastIndexOf( '/' ) 
) ),
 // xxx todo: encode always for UTF-8? => lookup doc-header?
 RTL_TEXTENCODING_UTF8 );
 }
diff --git a/include/rtl/xmlencode.hxx b/include/rtl/xmlencode.hxx
new file mode 100644
index ..487c4ee94749
--- /dev/null
+++ b/include/rtl/xmlencode.hxx
@@ -0,0 +1,55 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#ifndef INCLUDED_RTL_XMLENCODE_HXX
+#define INCLUDED_RTL_XMLENCODE_HXX
+
+#include 

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - sw/qa writerfilter/qa writerfilter/source

[Miklos Vajna (via logerrit)]

 sw/qa/extras/ooxmlexport/ooxmlexport8.cxx|
7 +-
 writerfilter/qa/cppunittests/dmapper/DomainMapperTableHandler.cxx|   
28 +++---
 writerfilter/qa/cppunittests/dmapper/data/floattable-nested-3tables.docx 
|binary
 writerfilter/source/dmapper/DomainMapperTableHandler.cxx |   
11 +--
 4 files changed, 27 insertions(+), 19 deletions(-)

New commits:
commit d161c6693039bbddeab447834c4cba271d5426d9
Author: Miklos Vajna 
AuthorDate: Fri Apr 28 08:28:22 2023 +0200
Commit: Miklos Vajna 
CommitDate: Tue May 2 10:32:17 2023 +0200

sw floattable, crashtesting: fix PDF export of tdf114111-3.docx

Converting the bugdoc to PDF crashed Writer layout since commit
ce3308a926f036b87515b8cd97d2b197063dc77a (tdf#61594 sw floattable:
import floating tables as split flys by default, 2023-04-12).

The stripped down document has 3 tables: a toplevel, a middle and an
inner one. The middle one is floating. SwFrame::GetNextFlyLeaf() doesn't
support nested tables, so we move an inner table frame to a next page,
causing a frame to have the in-table flag, without a table frame parent,
leading to a crash.

Fix the problem by just disabling floating tables for nested tables for
now.

It can be enabled later, and not supporting inner floating tables was
the intent of 8818dd359fbf0f37e1b318de89ab2ea7d735f58 (sw floattable:
fix handling of nested non-floating tables at cell start, 2023-03-20)
anyway.

(cherry picked from commit 1795d5183d5371a24e8dcb15f8671c78b2c94665)

Change-Id: I75db01c6c0fdd803130fbb2a8f2f90c6180051ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151253
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 

diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport8.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport8.cxx
index 9528639f894d..720087ae01ec 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport8.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport8.cxx
@@ -513,9 +513,10 @@ DECLARE_OOXMLEXPORT_TEST(testTDF91260, "tdf91260.docx")
 
 DECLARE_OOXMLEXPORT_TEST(testFdo74357, "fdo74357.docx")
 {
-// Floating table wasn't converted to a textframe.
-// This was 0.
-CPPUNIT_ASSERT_EQUAL(1, getShapes());
+// Normal outer table, floating inner table.
+uno::Reference xTextTablesSupplier(mxComponent, 
uno::UNO_QUERY);
+uno::Reference 
xIndexAccess(xTextTablesSupplier->getTextTables(), uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(2), xIndexAccess->getCount());
 
 // Bottom margin of the first paragraph was too large, causing a layout 
problem.
 // This was 494.
diff --git a/writerfilter/qa/cppunittests/dmapper/DomainMapperTableHandler.cxx 
b/writerfilter/qa/cppunittests/dmapper/DomainMapperTableHandler.cxx
index 0650e48fe607..803f2cd938b6 100644
--- a/writerfilter/qa/cppunittests/dmapper/DomainMapperTableHandler.cxx
+++ b/writerfilter/qa/cppunittests/dmapper/DomainMapperTableHandler.cxx
@@ -50,14 +50,11 @@ CPPUNIT_TEST_FIXTURE(Test, test1cellInsidevRightborder)
 CPPUNIT_TEST_FIXTURE(Test, testNestedFloatingTable)
 {
 loadFromURL(u"nested-floating-table.docx");
-uno::Reference xDrawPageSupplier(mxComponent, 
uno::UNO_QUERY);
-uno::Reference xDrawPage = 
xDrawPageSupplier->getDrawPage();
-uno::Reference xFrame(xDrawPage->getByIndex(0), 
uno::UNO_QUERY);
-bool bIsFollowingTextFlow = false;
-xFrame->getPropertyValue("IsFollowingTextFlow") >>= bIsFollowingTextFlow;
-// Without the accompanying fix in place, this test would have failed, the 
nested floating table
-// was partly positioned outside the table cell, leading to overlapping 
text.
-CPPUNIT_ASSERT(bIsFollowingTextFlow);
+// Normal outer table, floating inner tables.
+uno::Reference xTextTablesSupplier(mxComponent, 
uno::UNO_QUERY);
+uno::Reference 
xIndexAccess(xTextTablesSupplier->getTextTables(),
+ uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(3), xIndexAccess->getCount());
 }
 
 CPPUNIT_TEST_FIXTURE(Test, testFloatingTableBreakBefore)
@@ -82,6 +79,21 @@ CPPUNIT_TEST_FIXTURE(Test, testFloatingTableBreakBefore)
 // i.e. the page break was lost.
 CPPUNIT_ASSERT_EQUAL(style::BreakType_PAGE_BEFORE, eBreakType);
 }
+
+CPPUNIT_TEST_FIXTURE(Test, test3NestedFloatingTables)
+{
+// Given a document with nested tables: outer and inner one is normal, 
middle one is floating:
+// When laying out that document:
+loadFromURL(u"floattable-nested-3tables.docx");
+
+// Then make sure we don't crash and create the 3 tables:
+// Without the accompanying fix in place, this would have crashed, layout 
can't handle nested
+// floating tables currently.
+uno::Reference xTextTablesSupplier(mxComponent, 
uno::UNO_QUERY);
+uno::Reference 
xIndexAccess(xTextTablesSupplier->getTextTables(),
+ 

[Libreoffice-bugs] [Bug 151841] LO Calc Conditional Formatting Not Saved on Pivot Table When Saving to .xlsx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151841

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||1612

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/source

[Caolán McNamara (via logerrit)]

 sc/source/ui/view/gridwin2.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 7e74f2260b7d093c1b3bb6e362de1c52b5068cc6
Author: Caolán McNamara 
AuthorDate: Mon May 1 20:58:00 2023 +0100
Commit: Caolán McNamara 
CommitDate: Tue May 2 10:01:47 2023 +0200

cid#1528432 Argument cannot be negative

Change-Id: Ic55c524a9ec8ae9a4df7f96d284d822616fa3b54
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151241
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sc/source/ui/view/gridwin2.cxx b/sc/source/ui/view/gridwin2.cxx
index 94d90443da26..01f5f39dd7d3 100644
--- a/sc/source/ui/view/gridwin2.cxx
+++ b/sc/source/ui/view/gridwin2.cxx
@@ -746,6 +746,9 @@ void ScGridWindow::UpdateDPPopupMenuForFieldChange()
 return;
 
 tools::Long nIndex = mpDPFieldPopup->getField();
+if (nIndex < 0)
+return;
+
 tools::Long nDimIndex = pDPData->maFieldIndices[nIndex];
 if (nDimIndex == pDPData->mnDim)
 return;