[Libreoffice-commits] core.git: xmlsecurity/source
xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx | 18 ++---
1 file changed, 7 insertions(+), 11 deletions(-)
New commits:
commit 66e25cfe4f50c142077a54f005d09cee2bb63dab
Author: Arnaud VERSINI
AuthorDate: Sun Jun 25 20:13:36 2023 +0200
Commit: Noel Grandin
CommitDate: Mon Jun 26 07:56:01 2023 +0200
xmlsecurity : remove unneccessary static variables
Change-Id: Ie7ecba234f33cc09ebd4cf5a390919acb4bc7e08
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153567
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx
b/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx
index ed73366234df..2a3cd3049a13 100644
--- a/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx
+++ b/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx
@@ -19,6 +19,7 @@
#include
+#include
#include
#include
@@ -115,7 +116,8 @@ namespace
m_nODF = nTmp;
}
-const std::vector aGUIServersWindows = {
u"Gpg4win\\kleopatra.exe",
+#ifdef _WIN32
+constexpr std::array aGUIServers = {
u"Gpg4win\\kleopatra.exe",
u"Gpg4win\\bin\\kleopatra.exe",
u"GNU\\GnuPG\\kleopatra.exe",
u"GNU\\GnuPG\\launch-gpa.exe",
@@ -124,7 +126,10 @@ namespace
u"GNU\\GnuPG\\bin\\kleopatra.exe",
u"GNU\\GnuPG\\bin\\launch-gpa.exe",
u"GNU\\GnuPG\\bin\\gpa.exe"};
-const std::vector aGUIServersNix = { u"kleopatra",
u"seahorse", u"gpa", u"kgpg" };
+#else
+constexpr std::array aGUIServers = { u"kleopatra",
u"seahorse", u"gpa", u"kgpg" };
+#endif
+
}
DigitalSignaturesDialog::DigitalSignaturesDialog(
@@ -490,7 +495,6 @@ IMPL_LINK_NOARG(DigitalSignaturesDialog, RemoveButtonHdl,
weld::Button&, void)
bool DigitalSignaturesDialog::IsThereCertificateMgr()
{
-static std::vector aGUIServers;
#ifdef _WIN32
static const OUString aPath = [] {
sal::systools::CoTaskMemAllocated sPath;
@@ -502,18 +506,13 @@ bool DigitalSignaturesDialog::IsThereCertificateMgr()
}();
if (aPath.isEmpty())
return false;
-aGUIServers = aGUIServersWindows;
#else
const char* cPath = getenv("PATH");
if (!cPath)
return false;
OUString aPath(cPath, strlen(cPath), osl_getThreadTextEncoding());
-aGUIServers = aGUIServersNix;
#endif
-if (aGUIServers.empty())
-return false;
-
OUString sFoundGUIServer, sExecutable;
for ( auto const : aGUIServers )
@@ -531,7 +530,6 @@ bool DigitalSignaturesDialog::IsThereCertificateMgr()
IMPL_LINK_NOARG(DigitalSignaturesDialog, CertMgrButtonHdl, weld::Button&, void)
{
-static std::vector aGUIServers;
#ifdef _WIN32
// FIXME: call GpgME::dirInfo("bindir") somewhere in
// SecurityEnvironmentGpg or whatnot
@@ -546,13 +544,11 @@ IMPL_LINK_NOARG(DigitalSignaturesDialog,
CertMgrButtonHdl, weld::Button&, void)
}();
if (aPath.isEmpty())
return;
-aGUIServers = aGUIServersWindows;
#else
const char* cPath = getenv("PATH");
if (!cPath)
return;
OUString aPath(cPath, strlen(cPath), osl_getThreadTextEncoding());
-aGUIServers = aGUIServersNix;
#endif
if (aGUIServers.empty())
[Libreoffice-commits] core.git: sc/inc sc/qa sc/source
sc/inc/patattr.hxx | 16
sc/qa/unit/helper/qahelper.cxx |4 ++--
sc/source/core/data/patattr.cxx | 18 +-
sc/source/filter/excel/xecontent.cxx |2 +-
sc/source/filter/excel/xehelper.cxx |6 +++---
sc/source/filter/excel/xestyle.cxx |2 +-
sc/source/ui/view/output2.cxx|6 +++---
sc/source/ui/view/printfun.cxx |4 ++--
8 files changed, 29 insertions(+), 29 deletions(-)
New commits:
commit f55792eed4d2e0f6891a2bdd8639f8e962d95c5b
Author: Noel Grandin
AuthorDate: Sun Jun 25 15:41:37 2023 +0200
Commit: Noel Grandin
CommitDate: Mon Jun 26 07:53:06 2023 +0200
convert ScAutoFontColorMode to scoped enum
Change-Id: Id34bac78719943bd4c4cbfa60e0cb86b4ca570f2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153562
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sc/inc/patattr.hxx b/sc/inc/patattr.hxx
index 4d7df0c6ac23..1df3a31d6fac 100644
--- a/sc/inc/patattr.hxx
+++ b/sc/inc/patattr.hxx
@@ -39,15 +39,15 @@ enum class ScRotateDir : sal_uInt8;
/// how to treat COL_AUTO in GetFont:
-enum ScAutoFontColorMode
+enum class ScAutoFontColorMode
{
-SC_AUTOCOL_RAW, ///< COL_AUTO is returned
-SC_AUTOCOL_BLACK, ///< always use black
-SC_AUTOCOL_PRINT, ///< black or white, depending on background
-SC_AUTOCOL_DISPLAY, ///< from style settings, or black/white if needed
-SC_AUTOCOL_IGNOREFONT, ///< like DISPLAY, but ignore stored font color
(assume COL_AUTO)
-SC_AUTOCOL_IGNOREBACK, ///< like DISPLAY, but ignore stored background
color (use configured color)
-SC_AUTOCOL_IGNOREALL///< like DISPLAY, but ignore stored font and
background colors
+Raw, ///< COL_AUTO is returned
+Black, ///< always use black
+Print, ///< black or white, depending on background
+Display, ///< from style settings, or black/white if needed
+IgnoreFont, ///< like DISPLAY, but ignore stored font color (assume
COL_AUTO)
+IgnoreBack, ///< like DISPLAY, but ignore stored background color (use
configured color)
+IgnoreAll///< like DISPLAY, but ignore stored font and background
colors
};
class SC_DLLPUBLIC ScPatternAttr final : public SfxSetItem
diff --git a/sc/qa/unit/helper/qahelper.cxx b/sc/qa/unit/helper/qahelper.cxx
index efb2e68c4fbc..890a330f147d 100644
--- a/sc/qa/unit/helper/qahelper.cxx
+++ b/sc/qa/unit/helper/qahelper.cxx
@@ -179,7 +179,7 @@ void ScModelTestBase::testFormats(ScDocument*
pDoc,std::u16string_view sFormat)
Color aColor;
pPattern->fillFontOnly(aFont);
-pPattern->fillColor(aColor, SC_AUTOCOL_RAW);
+pPattern->fillColor(aColor, ScAutoFontColorMode::Raw);
CPPUNIT_ASSERT_EQUAL_MESSAGE("font size should be 10", tools::Long(200),
aFont.GetFontSize().getHeight());
CPPUNIT_ASSERT_EQUAL_MESSAGE("font color should be black", COL_AUTO,
aColor);
pPattern = pDoc->GetPattern(0,1,1);
@@ -193,7 +193,7 @@ void ScModelTestBase::testFormats(ScDocument*
pDoc,std::u16string_view sFormat)
CPPUNIT_ASSERT_EQUAL_MESSAGE("font should be bold", WEIGHT_BOLD,
aFont.GetWeight());
pPattern = pDoc->GetPattern(1,0,1);
pPattern->fillFontOnly(aFont);
-pPattern->fillColor(aColor, SC_AUTOCOL_RAW);
+pPattern->fillColor(aColor, ScAutoFontColorMode::Raw);
CPPUNIT_ASSERT_EQUAL_MESSAGE("font should be blue", COL_BLUE, aColor);
pPattern = pDoc->GetPattern(1,1,1);
pPattern->fillFontOnly(aFont);
diff --git a/sc/source/core/data/patattr.cxx b/sc/source/core/data/patattr.cxx
index 199d41ab25f1..1bb2e50daf4d 100644
--- a/sc/source/core/data/patattr.cxx
+++ b/sc/source/core/data/patattr.cxx
@@ -448,11 +448,11 @@ void ScPatternAttr::fillColor(Color& rColor, const
SfxItemSet& rItemSet, ScAutoF
aColor = pColorItem->GetValue();
-if ((aColor == COL_AUTO && eAutoMode != SC_AUTOCOL_RAW)
-|| eAutoMode == SC_AUTOCOL_IGNOREFONT
-|| eAutoMode == SC_AUTOCOL_IGNOREALL)
+if ((aColor == COL_AUTO && eAutoMode != ScAutoFontColorMode::Raw)
+|| eAutoMode == ScAutoFontColorMode::IgnoreFont
+|| eAutoMode == ScAutoFontColorMode::IgnoreAll)
{
-if ( eAutoMode == SC_AUTOCOL_BLACK )
+if ( eAutoMode == ScAutoFontColorMode::Black )
aColor = COL_BLACK;
else
{
@@ -472,12 +472,12 @@ void ScPatternAttr::fillColor(Color& rColor, const
SfxItemSet& rItemSet, ScAutoF
// if background color attribute is transparent, use window color
for brightness comparisons
if (aBackColor == COL_TRANSPARENT
-|| eAutoMode == SC_AUTOCOL_IGNOREBACK
-|| eAutoMode == SC_AUTOCOL_IGNOREALL)
+|| eAutoMode == ScAutoFontColorMode::IgnoreBack
+|| eAutoMode == ScAutoFontColorMode::IgnoreAll)
{
if (!comphelper::LibreOfficeKit::isActive())
{
-
Re: test failures with new fonts-crosextra-carlito
Hi,
Am 25.06.23 um 13:29 schrieb Rene Engelhard:
my beta1 (didn't try 7.5 yet) builds fail with a new verson of the
fonts-crosextra-carlito fonts (used for Calibri). LibreOffice itself ships
My 7.5.4 builds needs the following in addition to the already posted
(where applicable):
rene@frodo:~/Debian/Pakete/LibreOffice/libreoffice/libreoffice-7.5.4.2$
diff -u sw/qa/extras/ooxmlexport/ooxmlexport14.cxx-old
sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
--- sw/qa/extras/ooxmlexport/ooxmlexport14.cxx-old 2023-06-26
06:30:09.119195022 +0200
+++ sw/qa/extras/ooxmlexport/ooxmlexport14.cxx 2023-06-26
06:30:18.891263759 +0200
@@ -1346,8 +1346,7 @@
#if !defined(MACOSX)
DECLARE_OOXMLEXPORT_TEST(testTdf146346, "tdf146346.docx")
{
-// This was 2 (by bad docDefault vertical margins around tables in
footnotes)
-CPPUNIT_ASSERT_EQUAL(1, getPages());
+CPPUNIT_ASSERT_EQUAL(2, getPages());
}
#endif
(sorry, overwrite the log, but should be obvious)
I know it said 2 was the failure before, but that's what the new font
gives me. Here even downgrading the font just makes it work, too, but
that is no option unfortunately.
This makes
https://salsa.debian.org/libreoffice-team/libreoffice/libreoffice/-/blob/debian-experimental-7.6/patches/adapt-for-new-carlito.diff
for 7.6+
and
https://salsa.debian.org/libreoffice-team/libreoffice/libreoffice/-/blob/master/patches/adapt-for-new-carlito.diff?ref_type=heads
for 7.5
so far
Regards,
Rene
[Libreoffice-bugs] [Bug 106228] [META] Icon theme issues
https://bugs.documentfoundation.org/show_bug.cgi?id=106228 Rizal Muttaqin changed: What|Removed |Added Depends on|146062 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=146062 [Bug 146062] UI gets blocked while downloading new icon theme -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146062] UI gets blocked while downloading new icon theme
https://bugs.documentfoundation.org/show_bug.cgi?id=146062 Rizal Muttaqin changed: What|Removed |Added CC||riz...@libreoffice.org Blocks|106228 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=106228 [Bug 106228] [META] Icon theme issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152222] Unsupported features saved to xlsx formatted file
https://bugs.documentfoundation.org/show_bug.cgi?id=15 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155774] [Impress][new feature] masters hierarchy / inheritance
https://bugs.documentfoundation.org/show_bug.cgi?id=155774 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145544] Newly created lists should utilize "List 1" paragrapsh style
https://bugs.documentfoundation.org/show_bug.cgi?id=145544 --- Comment #6 from QA Administrators --- Dear John, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152222] Unsupported features saved to xlsx formatted file
https://bugs.documentfoundation.org/show_bug.cgi?id=15 --- Comment #6 from QA Administrators --- Dear markballew, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145544] Newly created lists should utilize "List 1" paragrapsh style
https://bugs.documentfoundation.org/show_bug.cgi?id=145544 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152692] Show Text Variables does not work in LO Writer 7.4 (FILEOPEN, EDITING, FORMATTING)
https://bugs.documentfoundation.org/show_bug.cgi?id=152692 --- Comment #3 from QA Administrators --- Dear Michael H, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148694] i liked 7.3.1.3 on Mac (intel) until I got to inserting page numbers in a book in docx format.
https://bugs.documentfoundation.org/show_bug.cgi?id=148694 --- Comment #3 from QA Administrators --- Dear Bruce Dickson, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 91862] Format changes in DOC files are not displayed as tracked changes
https://bugs.documentfoundation.org/show_bug.cgi?id=91862 --- Comment #10 from QA Administrators --- Dear Pedro, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 53501] Wrong line spacing when mixing large fonts with small ones near a box
https://bugs.documentfoundation.org/show_bug.cgi?id=53501 --- Comment #15 from QA Administrators --- Dear Ingo Ruhnke, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 55956] FILESAVE: Circular Arrow broken after save as PPT/PPTX & reopening
https://bugs.documentfoundation.org/show_bug.cgi?id=55956 --- Comment #21 from QA Administrators --- Dear Pierre Martineau, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137111] Header has fixed minimum spacing on DOCX import
https://bugs.documentfoundation.org/show_bug.cgi?id=137111 --- Comment #12 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135261] UI: Manage changes dialog is resizing for few seconds after every reject/clear formatting button press
https://bugs.documentfoundation.org/show_bug.cgi?id=135261 --- Comment #10 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108621] Form-Navigation: CTRL+TAB only works right with Design-Mode switched off
https://bugs.documentfoundation.org/show_bug.cgi?id=108621 --- Comment #12 from QA Administrators --- Dear Robert Großkopf, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 116967] Textshape with "Rotated" transform from a Draw export to .svg -- valid SVG 1.2 transform syntax or not?
https://bugs.documentfoundation.org/show_bug.cgi?id=116967 --- Comment #7 from QA Administrators --- Dear Robert Helmkamp, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108727] sub bullet list point not indented on export to xhtml
https://bugs.documentfoundation.org/show_bug.cgi?id=108727 --- Comment #9 from QA Administrators --- Dear Robert Orzanna, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 105350] Writer doesn't correctly open DOC with images from WPS (OK if first saved in MSO)
https://bugs.documentfoundation.org/show_bug.cgi?id=105350 --- Comment #24 from QA Administrators --- Dear Maxim, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 92311] raise the limit of collected entries for Word Completion
https://bugs.documentfoundation.org/show_bug.cgi?id=92311 Baole Fang changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |baole.f...@gmail.com |desktop.org | --- Comment #18 from Baole Fang --- Please -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156056] Assertion failure when double-clicking element in master slide (debug build)
https://bugs.documentfoundation.org/show_bug.cgi?id=156056 Aron Budea changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 105537] [META] Assertion failed crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=105537 Aron Budea changed: What|Removed |Added Depends on||156056 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=156056 [Bug 156056] Assertion failure when double-clicking element in master slide (debug build) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156056] New: Assertion failure when double-clicking element in master slide (debug build)
https://bugs.documentfoundation.org/show_bug.cgi?id=156056 Bug ID: 156056 Summary: Assertion failure when double-clicking element in master slide (debug build) Product: LibreOffice Version: 24.2.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: aron.bu...@gmail.com Blocks: 102341, 105537 Created attachment 188085 --> https://bugs.documentfoundation.org/attachment.cgi?id=188085=edit Backtrace This can only be reproduced in a debug build. - Start an empty presentation, - Switch to master view eg. using Master View button on Properties sidebar, - In Footer Area, click at the beginning of the place holder. => Crash (assertion failure) with the following: xmloff/source/core/namespacemap.cxx:253: rtl::OUString SvXMLNamespaceMap::GetQNameByKey(sal_uInt16, const rtl::OUString&, bool) const: Assertion `false' failed Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102341 [Bug 102341] [META] Master slide view/mode bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=105537 [Bug 105537] [META] Assertion failed crashes -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102341] [META] Master slide view/mode bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102341 Aron Budea changed: What|Removed |Added Depends on||156056 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=156056 [Bug 156056] Assertion failure when double-clicking element in master slide (debug build) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103370] [META] Heading Numbering bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103370 Bug 103370 depends on bug 152605, which changed state. Bug 152605 Summary: Change "heading level" to "outline level" in UI and help pages for Writer (see comment 14) https://bugs.documentfoundation.org/show_bug.cgi?id=152605 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155471] Edit Index Entry dialog: Replace "Apply" button with "Reset" button and make "Close" apply automatically
https://bugs.documentfoundation.org/show_bug.cgi?id=155471 sdc.bla...@youmail.dk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||6055 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 155471] Edit Index Entry dialog: Replace "Apply" button with "Reset" button and make "Close" apply automatically
https://bugs.documentfoundation.org/show_bug.cgi?id=155471 sdc.bla...@youmail.dk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||6055 -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 156055] Edit Index Entry dialog: Ask for Save on "Close". Remove "Apply" button. Add "Reset" button.
https://bugs.documentfoundation.org/show_bug.cgi?id=156055 sdc.bla...@youmail.dk changed: What|Removed |Added Blocks||122497 See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||4186, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||5471 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=122497 [Bug 122497] [META] Table of Contents and Indexes dialog bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 122497] [META] Table of Contents and Indexes dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=122497 sdc.bla...@youmail.dk changed: What|Removed |Added Depends on||156055 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=156055 [Bug 156055] Edit Index Entry dialog: Ask for Save on "Close". Remove "Apply" button. Add "Reset" button. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156055] New: Edit Index Entry dialog: Ask for Save on "Close". Remove "Apply" button. Add "Reset" button.
https://bugs.documentfoundation.org/show_bug.cgi?id=156055 Bug ID: 156055 Summary: Edit Index Entry dialog: Ask for Save on "Close". Remove "Apply" button. Add "Reset" button. Product: LibreOffice Version: 24.2.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sdc.bla...@youmail.dk Building further on bug 155471 and bug 154186 - The issue is the "Edit Index Entry" dialog. Proposal 1. Modify the "Close" button functionality so that when it is applied, and the current modification in the dialog has not been saved, then a warning message would appear, asking whether to "save" or "not save" the current entry before closing. (and no message if nothing needs to be saved.) Proposal 2. If Proposal 1 is implemented, then the "Apply" button can be removed, because it would have no practical or necessary function. Proposal 3. Add a "Reset" button that returns the current entry in the dialog to its initial values when the entry was opened. (The purpose: If a change is accidently made, or a change was started, but then regretted, it provides an easy way to return to the initial state. Alternatively (but less convenient), if Proposal 1 is implemented, then one could "close" (answer "no save"), and then reopen the dialog. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156050] Multiple squiggly lines under misspelled words in text boxes
https://bugs.documentfoundation.org/show_bug.cgi?id=156050 Hossein changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||1968 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156050] Multiple squiggly lines under misspelled words in text boxes
https://bugs.documentfoundation.org/show_bug.cgi?id=156050 Hossein changed: What|Removed |Added Keywords||bibisected, regression Regression By||Khaled Hosny --- Comment #3 from Hossein --- Result of my bisect on Linux: 74b6c5ea3c333de7c5e7ef8636732edadd9083f2 is the first bad commit commit 74b6c5ea3c333de7c5e7ef8636732edadd9083f2 Author: Khaled Hosny Date: Thu Jun 8 16:41:18 2023 +0300 tdf#151968: Fix vertical position of RTL spelling wavy line -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156054] Word count should also consider text boxes
https://bugs.documentfoundation.org/show_bug.cgi?id=156054 Hossein changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Hossein --- Confirming as per user's request in Ask LO: Include text boxes in Word Count https://ask.libreoffice.org/t/include-text-boxes-in-word-count/25929 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156054] New: Word count should also consider text boxes
https://bugs.documentfoundation.org/show_bug.cgi?id=156054 Bug ID: 156054 Summary: Word count should also consider text boxes Product: LibreOffice Version: 24.2.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: hoss...@libreoffice.org Description: LibreOffice Writer does not count the text inside text boxes. In the possible implementation, it would be good to make it optional as described in tdf#99189. Steps to Reproduce: 1. Open LibreOffice writer 2. Add a text box using "Insert > Text Box" 3. Enter some text in the text box Actual Results: Word count in the status bar is all zero (words / characters). Also in "File > Properties > Statistics", everything (except number of pages) is zero. Expected Results: Word count should also consider the text boxes in the document Reproducible: Always User Profile Reset: No Additional Info: Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: bea05a79c8ed565909e341a24b298d8deab7e042 CPU threads: 12; OS: Linux 5.19; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 95433] EDITING autocorrect option "Apply styles" causes Default Style paragraphs to change to "Text Body" paragraph style while typing
https://bugs.documentfoundation.org/show_bug.cgi?id=95433 sdc.bla...@youmail.dk changed: What|Removed |Added CC||sdc.bla...@youmail.dk --- Comment #15 from sdc.bla...@youmail.dk --- may be fixed in 7.6 -- possibly by bug 90507 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103341 Bug 103341 depends on bug 59036, which changed state. Bug 59036 Summary: EDITING AutoCorrect: "Remove blank paragraphs" will work for all styles, other "[M]" options only for Default https://bugs.documentfoundation.org/show_bug.cgi?id=59036 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 59036] EDITING AutoCorrect: "Remove blank paragraphs" will work for all styles, other "[M]" options only for Default
https://bugs.documentfoundation.org/show_bug.cgi?id=59036 sdc.bla...@youmail.dk changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #11 from sdc.bla...@youmail.dk --- This limitation was removed by commit 1cff5c9db7e0d7cf7ae45b306deb963d95926d99 for bug 128192. Tested with the test document attachment 72524 and Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 069c7dc4e9706b40ca12d83d83f90f41cec948f8 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: da-DK (da_DK); UI: en-US Calc: CL threaded The initial capitals are corrected and the first letter of the sentence is capitalized, so closing this ticket as FIXED. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155912] Rendering problems in conversion of internal vcl bitmap formats transparency->alpha
https://bugs.documentfoundation.org/show_bug.cgi?id=155912 --- Comment #7 from Patrick Luby --- Created attachment 188084 --> https://bugs.documentfoundation.org/attachment.cgi?id=188084=edit Sample file with overlapping, multi-colored transparent gradients -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103341 Bug 103341 depends on bug 59034, which changed state. Bug 59034 Summary: EDITING AutoCorrect's "Replace while modifying existing text" works only for Default style https://bugs.documentfoundation.org/show_bug.cgi?id=59034 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 59034] EDITING AutoCorrect's "Replace while modifying existing text" works only for Default style
https://bugs.documentfoundation.org/show_bug.cgi?id=59034 sdc.bla...@youmail.dk changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #6 from sdc.bla...@youmail.dk --- This limitation was removed by commit 1cff5c9db7e0d7cf7ae45b306deb963d95926d99 for bug 128192, so closing this ticket as FIXED. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139951] Some "replace dashes" options do not work with Tools -AutoCorrect - Apply
https://bugs.documentfoundation.org/show_bug.cgi?id=139951 sdc.bla...@youmail.dk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||6046 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156046] Autocorrect replaces " - " with " – " instead of " — " (en-dash instead of em-dash)
https://bugs.documentfoundation.org/show_bug.cgi?id=156046 sdc.bla...@youmail.dk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||9951 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 94b7fe6b2499cfd3d9021352a873d0a7ac67e266 Author: Seth Chaiklin AuthorDate: Mon Jun 26 01:03:31 2023 +0200 Commit: Gerrit Code Review CommitDate: Mon Jun 26 01:03:31 2023 +0200 Update git submodules * Update helpcontent2 from branch 'libreoffice-7-6' to 2c6962858e4e4a5018940456a30fa2bd716313e5 - (related) tdf#128192 remove mention of "Default PS" limitation Change-Id: I8c53745039d14e0d43debdd6aeaf37311ccb750f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153592 Tested-by: Jenkins Reviewed-by: Seth Chaiklin (cherry picked from commit d49f14d334bea6b07526087d099068ef27b0940c) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153593 diff --git a/helpcontent2 b/helpcontent2 index a12f65df843f..2c6962858e4e 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit a12f65df843f2cd8f2c6a04e41c981c753c3d5bf +Subproject commit 2c6962858e4e4a5018940456a30fa2bd716313e5
[Libreoffice-commits] help.git: Branch 'libreoffice-7-6' - source/text
source/text/shared/01/06040100.xhp | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) New commits: commit 2c6962858e4e4a5018940456a30fa2bd716313e5 Author: Seth Chaiklin AuthorDate: Mon Jun 26 00:57:32 2023 +0200 Commit: Seth Chaiklin CommitDate: Mon Jun 26 01:03:31 2023 +0200 (related) tdf#128192 remove mention of "Default PS" limitation Change-Id: I8c53745039d14e0d43debdd6aeaf37311ccb750f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153592 Tested-by: Jenkins Reviewed-by: Seth Chaiklin (cherry picked from commit d49f14d334bea6b07526087d099068ef27b0940c) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153593 diff --git a/source/text/shared/01/06040100.xhp b/source/text/shared/01/06040100.xhp index 31bd032c11..2d7764a072 100644 --- a/source/text/shared/01/06040100.xhp +++ b/source/text/shared/01/06040100.xhp @@ -44,27 +44,27 @@ paragraphs; joining joining; paragraphs removed two bookmarks "automatic..." and two more entries about quotes and 1/2 replacement - - - - -Options - Select the options for automatically correcting errors as you type, and then click OK. + + + + +Options + Select the options for automatically correcting errors as you type, and then click OK. -In text documents, you can choose to apply [T] AutoCorrect options while you type. Enable this feature by using Tools - AutoCorrect - While Typing. -You can also apply [M] AutoCorrect options to a selection or a whole document of existing text by using Tools - AutoCorrect - Apply. In general, [M] options are applied only to paragraphs with Default Paragraph Style. +In text documents, you can choose to apply [T] AutoCorrect options while you type. Enable this feature by using Tools - AutoCorrect - While Typing. +You can also apply [M] AutoCorrect options to a selection or a whole document of existing text by using Tools - AutoCorrect - Apply. see i72339Don't use inline switches for notes, tips and warnings. The icon will still show up. [M] and [T] options -Use replacement table - If you type a letter combination that matches a shortcut in the replacement table, the letter combination is replaced with the replacement text. - Correct TWo INitial CApitals +Use replacement table + If you type a letter combination that matches a shortcut in the replacement table, the letter combination is replaced with the replacement text. + Correct TWo INitial CApitals If you type two uppercase letters at the beginning of a "WOrd", the second uppercase letter is automatically replaced with a lowercase letter. No corrections are made to entries found in an applicable spelling dictionary. Capitalize first letter of every sentence.
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 9fc0b2b9b96d87eb642a3b29e9dcb5d6273265eb Author: Seth Chaiklin AuthorDate: Mon Jun 26 01:02:11 2023 +0200 Commit: Gerrit Code Review CommitDate: Mon Jun 26 01:02:11 2023 +0200 Update git submodules * Update helpcontent2 from branch 'master' to d380411c947e8fcc3887889497349f45f01c28ac - (related) tdf#128192 remove mention of "Default PS" limitation Change-Id: I8c53745039d14e0d43debdd6aeaf37311ccb750f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153592 Tested-by: Jenkins Reviewed-by: Seth Chaiklin diff --git a/helpcontent2 b/helpcontent2 index 62a280c3b288..d380411c947e 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 62a280c3b288b30ac34f68e4665c76369336cda1 +Subproject commit d380411c947e8fcc3887889497349f45f01c28ac
[Libreoffice-commits] help.git: source/text
source/text/shared/01/06040100.xhp | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) New commits: commit d380411c947e8fcc3887889497349f45f01c28ac Author: Seth Chaiklin AuthorDate: Mon Jun 26 00:57:32 2023 +0200 Commit: Seth Chaiklin CommitDate: Mon Jun 26 01:02:11 2023 +0200 (related) tdf#128192 remove mention of "Default PS" limitation Change-Id: I8c53745039d14e0d43debdd6aeaf37311ccb750f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153592 Tested-by: Jenkins Reviewed-by: Seth Chaiklin diff --git a/source/text/shared/01/06040100.xhp b/source/text/shared/01/06040100.xhp index 31bd032c11..2d7764a072 100644 --- a/source/text/shared/01/06040100.xhp +++ b/source/text/shared/01/06040100.xhp @@ -44,27 +44,27 @@ paragraphs; joining joining; paragraphs removed two bookmarks "automatic..." and two more entries about quotes and 1/2 replacement - - - - -Options - Select the options for automatically correcting errors as you type, and then click OK. + + + + +Options + Select the options for automatically correcting errors as you type, and then click OK. -In text documents, you can choose to apply [T] AutoCorrect options while you type. Enable this feature by using Tools - AutoCorrect - While Typing. -You can also apply [M] AutoCorrect options to a selection or a whole document of existing text by using Tools - AutoCorrect - Apply. In general, [M] options are applied only to paragraphs with Default Paragraph Style. +In text documents, you can choose to apply [T] AutoCorrect options while you type. Enable this feature by using Tools - AutoCorrect - While Typing. +You can also apply [M] AutoCorrect options to a selection or a whole document of existing text by using Tools - AutoCorrect - Apply. see i72339Don't use inline switches for notes, tips and warnings. The icon will still show up. [M] and [T] options -Use replacement table - If you type a letter combination that matches a shortcut in the replacement table, the letter combination is replaced with the replacement text. - Correct TWo INitial CApitals +Use replacement table + If you type a letter combination that matches a shortcut in the replacement table, the letter combination is replaced with the replacement text. + Correct TWo INitial CApitals If you type two uppercase letters at the beginning of a "WOrd", the second uppercase letter is automatically replaced with a lowercase letter. No corrections are made to entries found in an applicable spelling dictionary. Capitalize first letter of every sentence.
[Libreoffice-ux-advise] [Bug 140024] "replace custom styles" option in AutoCorrect should be removed
https://bugs.documentfoundation.org/show_bug.cgi?id=140024 sdc.bla...@youmail.dk changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval Summary|"replace custom styles" |"replace custom styles" |option in AutoCorrect needs |option in AutoCorrect |critical review |should be removed --- Comment #6 from sdc.bla...@youmail.dk --- Now that bug 90507 is fixed and Tools - AutoCorrect - Apply no longer converts "Default Paragraph Style" to "Body Text", it seems time to also remove "Replace Custom Styles" from the [M] options. Will ask UXEval -- also because maybe it is an EasyHack. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 140024] "replace custom styles" option in AutoCorrect should be removed
https://bugs.documentfoundation.org/show_bug.cgi?id=140024 sdc.bla...@youmail.dk changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval Summary|"replace custom styles" |"replace custom styles" |option in AutoCorrect needs |option in AutoCorrect |critical review |should be removed --- Comment #6 from sdc.bla...@youmail.dk --- Now that bug 90507 is fixed and Tools - AutoCorrect - Apply no longer converts "Default Paragraph Style" to "Body Text", it seems time to also remove "Replace Custom Styles" from the [M] options. Will ask UXEval -- also because maybe it is an EasyHack. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 99649] [META] Improve Connector handling
https://bugs.documentfoundation.org/show_bug.cgi?id=99649 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on|154345 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=154345 [Bug 154345] Lines are displayed differently than MS Office -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154345] Lines are displayed differently than MS Office
https://bugs.documentfoundation.org/show_bug.cgi?id=154345 Stéphane Guillou (stragu) changed: What|Removed |Added Version|7.5.1.2 release |7.4.0.0 alpha0+ CC||stephane.guillou@libreoffic ||e.org Status|NEW |RESOLVED Blocks|99649 | Keywords|bibisectRequest |bibisected, bisected Resolution|--- |DUPLICATE --- Comment #8 from Stéphane Guillou (stragu) --- Bibisected with linux-64-7.4 repo to first bad commit f0f89cb5c7211e1a166266b7b7a083d685005230 which points to core commit: commit cbf66ec3e60d07efb7c3cceed9b4f0fb4f0510c8 author Tibor Nagy Thu Mar 10 08:42:12 2022 +0100 committer László NémethTue Mar 29 16:12:45 2022 +0200 tdf#89449 PPTX import: fix line connectors Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131303 Regression by same commit as bug 152211. Fixed by 5308d68a7cc0a4b38216438150adba2ac62e2bbe (checked with linux-64-7.5 bibisect repo). Same fix as for bug 149756. Let's mark as a duplicate. (Kalkulator, if you really still see the issue in a recent version, please report the full version info, including last commit, and attach a screenshot.) *** This bug has been marked as a duplicate of bug 149756 *** Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=99649 [Bug 99649] [META] Improve Connector handling -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156053] New: CTRL + MouseWheel not targeting cursor location
https://bugs.documentfoundation.org/show_bug.cgi?id=156053 Bug ID: 156053 Summary: CTRL + MouseWheel not targeting cursor location Product: LibreOffice Version: 7.5.2.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jonco...@gmail.com Description: CTRL + Mouse wheel to zoom and unZoom in Calc is not centering on cursor location. Actual Results: Create a large sheet that is larger than your screen size so you have to use the scroll bars. Zoom out and back in using CTRL and the Mouse Wheel and it prefers the upper left corner instead of cursor location. Expected Results: The zoom is centered on the upper left visible area Reproducible: Always User Profile Reset: No Additional Info: Zoomed in with the center being the cursor location. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154933] Rename "Text body" to "Body text"
https://bugs.documentfoundation.org/show_bug.cgi?id=154933 --- Comment #17 from Commit Notification --- Seth Chaiklin committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/help/commit/a12f65df843f2cd8f2c6a04e41c981c753c3d5bf (related) tdf#90507,tdf#154933 Text Body -> Body Text -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 5fe18d03aaab29dbfd5f83dfc1a37d1d1d195340 Author: Seth Chaiklin AuthorDate: Mon Jun 26 00:13:29 2023 +0200 Commit: Gerrit Code Review CommitDate: Mon Jun 26 00:13:29 2023 +0200 Update git submodules * Update helpcontent2 from branch 'libreoffice-7-6' to a12f65df843f2cd8f2c6a04e41c981c753c3d5bf - (related) tdf#90507,tdf#154933 Text Body -> Body Text Change-Id: If7e84952f10d081747d690e7120c9d43b44aba4e Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153529 Tested-by: Jenkins Reviewed-by: Seth Chaiklin (cherry picked from commit 7176d5b0f256bc3114c1d665df038f41fe9c7800) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153590 diff --git a/helpcontent2 b/helpcontent2 index 480fe02b9f1b..a12f65df843f 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 480fe02b9f1b4a31b9f474f79b321ec524954857 +Subproject commit a12f65df843f2cd8f2c6a04e41c981c753c3d5bf
[Libreoffice-commits] help.git: Branch 'libreoffice-7-6' - source/text
source/text/shared/01/06040100.xhp | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) New commits: commit a12f65df843f2cd8f2c6a04e41c981c753c3d5bf Author: Seth Chaiklin AuthorDate: Sun Jun 25 23:26:13 2023 +0200 Commit: Seth Chaiklin CommitDate: Mon Jun 26 00:13:28 2023 +0200 (related) tdf#90507,tdf#154933 Text Body -> Body Text Change-Id: If7e84952f10d081747d690e7120c9d43b44aba4e Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153529 Tested-by: Jenkins Reviewed-by: Seth Chaiklin (cherry picked from commit 7176d5b0f256bc3114c1d665df038f41fe9c7800) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153590 diff --git a/source/text/shared/01/06040100.xhp b/source/text/shared/01/06040100.xhp index 7871b5ee14..31bd032c11 100644 --- a/source/text/shared/01/06040100.xhp +++ b/source/text/shared/01/06040100.xhp @@ -58,7 +58,7 @@ In text documents, you can choose to apply [T] AutoCorrect options while you type. Enable this feature by using Tools - AutoCorrect - While Typing. You can also apply [M] AutoCorrect options to a selection or a whole document of existing text by using Tools - AutoCorrect - Apply. In general, [M] options are applied only to paragraphs with Default Paragraph Style. - All non-empty paragraphs with "Default Paragraph Style" are converted to "Text Body" paragraph style when Tools - AutoCorrect - Apply is used. see i72339Don't use inline switches for notes, tips and warnings. The icon will still show up. +see i72339Don't use inline switches for notes, tips and warnings. The icon will still show up. [M] and [T] options @@ -180,7 +180,7 @@ -The automatic numbering option is only applied to paragraphs that are formatted with the "Default", "Text body", or "Text body indent" paragraph style. +The automatic numbering option is only applied to paragraphs formatted with “Default Paragraph Style”, “Body Text” or “Body Text, Indented” paragraph styles. @@ -267,16 +267,16 @@ Automatically apply a Heading 1 to Heading 8 paragraph style to a text that starts with an uppercase letter and does not end with a period. To get a Heading 1 paragraph style, type the text that you want to use as a heading, then press Enter twice. For other Heading N styles, press the Tab key N-1 times before typing the text to get the desired level. For example, to get a "Heading 4" paragraph style press the Tab key three times, type something, then press Enter twice. - This feature works only with "Default Paragraph Style", "Text Body" and "Text Body Indent" paragraph styles, and there must be one empty paragraph before the text, if the text is not at the top of a page. + This feature works only with “Default Paragraph Style”, “Body Text” or “Body Text, Indented” paragraph styles, and there must be one empty paragraph before the text, if the text is not at the top of a page. [M] options only Remove blank paragraphs Removes empty paragraphs and paragraphs that contain only spaces or tabs from the current document. This option works for any paragraph style. - Replace Custom Styles + Replace Custom Styles - Replaces custom paragraph styles applied in the current document to "Text Body", "Text Body Indent", "First Line Indent" or "Hanging Indent" paragraph style. + Replaces custom paragraph styles applied in the current document to “Body Text”, “Body Text, Indented”, “First Line Indent” or “Hanging Indent” paragraph style. Replace bullets with
[Libreoffice-bugs] [Bug 154933] Rename "Text body" to "Body text"
https://bugs.documentfoundation.org/show_bug.cgi?id=154933 --- Comment #16 from Commit Notification --- Seth Chaiklin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/help/commit/62a280c3b288b30ac34f68e4665c76369336cda1 (related) tdf#90507,tdf#154933 Text Body -> Body Text -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit d7587e96f9769d856657d78b2e262442298aed52 Author: Seth Chaiklin AuthorDate: Mon Jun 26 00:10:27 2023 +0200 Commit: Gerrit Code Review CommitDate: Mon Jun 26 00:10:27 2023 +0200 Update git submodules * Update helpcontent2 from branch 'master' to 62a280c3b288b30ac34f68e4665c76369336cda1 - (related) tdf#90507,tdf#154933 Text Body -> Body Text Change-Id: If7e84952f10d081747d690e7120c9d43b44aba4e Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153529 Tested-by: Jenkins Reviewed-by: Seth Chaiklin diff --git a/helpcontent2 b/helpcontent2 index 9615cb2ed027..62a280c3b288 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 9615cb2ed0275615f853c027087fa5ef46f72eae +Subproject commit 62a280c3b288b30ac34f68e4665c76369336cda1
[Libreoffice-commits] help.git: source/text
source/text/shared/01/06040100.xhp | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) New commits: commit 62a280c3b288b30ac34f68e4665c76369336cda1 Author: Seth Chaiklin AuthorDate: Sun Jun 25 23:26:13 2023 +0200 Commit: Seth Chaiklin CommitDate: Mon Jun 26 00:10:27 2023 +0200 (related) tdf#90507,tdf#154933 Text Body -> Body Text Change-Id: If7e84952f10d081747d690e7120c9d43b44aba4e Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153529 Tested-by: Jenkins Reviewed-by: Seth Chaiklin diff --git a/source/text/shared/01/06040100.xhp b/source/text/shared/01/06040100.xhp index 7871b5ee14..31bd032c11 100644 --- a/source/text/shared/01/06040100.xhp +++ b/source/text/shared/01/06040100.xhp @@ -58,7 +58,7 @@ In text documents, you can choose to apply [T] AutoCorrect options while you type. Enable this feature by using Tools - AutoCorrect - While Typing. You can also apply [M] AutoCorrect options to a selection or a whole document of existing text by using Tools - AutoCorrect - Apply. In general, [M] options are applied only to paragraphs with Default Paragraph Style. - All non-empty paragraphs with "Default Paragraph Style" are converted to "Text Body" paragraph style when Tools - AutoCorrect - Apply is used. see i72339Don't use inline switches for notes, tips and warnings. The icon will still show up. +see i72339Don't use inline switches for notes, tips and warnings. The icon will still show up. [M] and [T] options @@ -180,7 +180,7 @@ -The automatic numbering option is only applied to paragraphs that are formatted with the "Default", "Text body", or "Text body indent" paragraph style. +The automatic numbering option is only applied to paragraphs formatted with “Default Paragraph Style”, “Body Text” or “Body Text, Indented” paragraph styles. @@ -267,16 +267,16 @@ Automatically apply a Heading 1 to Heading 8 paragraph style to a text that starts with an uppercase letter and does not end with a period. To get a Heading 1 paragraph style, type the text that you want to use as a heading, then press Enter twice. For other Heading N styles, press the Tab key N-1 times before typing the text to get the desired level. For example, to get a "Heading 4" paragraph style press the Tab key three times, type something, then press Enter twice. - This feature works only with "Default Paragraph Style", "Text Body" and "Text Body Indent" paragraph styles, and there must be one empty paragraph before the text, if the text is not at the top of a page. + This feature works only with “Default Paragraph Style”, “Body Text” or “Body Text, Indented” paragraph styles, and there must be one empty paragraph before the text, if the text is not at the top of a page. [M] options only Remove blank paragraphs Removes empty paragraphs and paragraphs that contain only spaces or tabs from the current document. This option works for any paragraph style. - Replace Custom Styles + Replace Custom Styles - Replaces custom paragraph styles applied in the current document to "Text Body", "Text Body Indent", "First Line Indent" or "Hanging Indent" paragraph style. + Replaces custom paragraph styles applied in the current document to “Body Text”, “Body Text, Indented”, “First Line Indent” or “Hanging Indent” paragraph style. Replace bullets with
[Libreoffice-commits] core.git: svgio/qa
svgio/qa/cppunit/SvgImportTest.cxx |4
svgio/qa/cppunit/data/tdf156034.svg | 16 +++-
2 files changed, 19 insertions(+), 1 deletion(-)
New commits:
commit ab094c4b7e5c0914dcc3d378c08129c5be2108ef
Author: Xisco Fauli
AuthorDate: Sun Jun 25 20:02:59 2023 +0200
Commit: Xisco Fauli
CommitDate: Sun Jun 25 23:06:05 2023 +0200
tdf#156034: improve test a bit
Change-Id: I164103c92cfb53c4f1ce48dd1ca39dbd9a1efb1d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153566
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/svgio/qa/cppunit/SvgImportTest.cxx
b/svgio/qa/cppunit/SvgImportTest.cxx
index 651e1341521f..abef91413077 100644
--- a/svgio/qa/cppunit/SvgImportTest.cxx
+++ b/svgio/qa/cppunit/SvgImportTest.cxx
@@ -338,6 +338,10 @@ CPPUNIT_TEST_FIXTURE(Test, testTdf156034)
assertXPath(pDocument, "/primitive2D/transform/polypolygoncolor[2]",
"color", "#008000");
assertXPath(pDocument, "/primitive2D/transform/polypolygoncolor[3]",
"color", "#008000");
assertXPath(pDocument, "/primitive2D/transform/polypolygoncolor[4]",
"color", "#008000");
+assertXPath(pDocument, "/primitive2D/transform/polypolygoncolor[5]",
"color", "#008000");
+assertXPath(pDocument, "/primitive2D/transform/polypolygoncolor[6]",
"color", "#008000");
+assertXPath(pDocument, "/primitive2D/transform/polypolygoncolor[7]",
"color", "#008000");
+assertXPath(pDocument, "/primitive2D/transform/polypolygoncolor[8]",
"color", "#008000");
}
CPPUNIT_TEST_FIXTURE(Test, testTdf156018)
diff --git a/svgio/qa/cppunit/data/tdf156034.svg
b/svgio/qa/cppunit/data/tdf156034.svg
index ed14c5fe4aaf..1cd3a82b78e2 100644
--- a/svgio/qa/cppunit/data/tdf156034.svg
+++ b/svgio/qa/cppunit/data/tdf156034.svg
@@ -1,8 +1,10 @@
-http://www.w3.org/2000/svg;
xmlns:xlink="http://www.w3.org/1999/xlink; viewBox="-0 0 300 300">
+http://www.w3.org/2000/svg;
xmlns:xlink="http://www.w3.org/1999/xlink; viewBox="-0 0 800 800">
.g1 rect {fill:green;}
#g3 rect {fill:green;}
+.g4 #r1 {fill:green;}
+#g3 .r5 {fill:green;}
@@ -17,4 +19,16 @@
+
+
+
+
+
+
+
+
+
+
+
+
[Libreoffice-commits] core.git: basegfx/source basegfx/test
basegfx/source/color/bcolormodifier.cxx |1 + basegfx/test/BColorModifierTest.cxx | 11 +++ 2 files changed, 12 insertions(+) New commits: commit 99b1459dbbe5faa47b5fc9b4ed767932d46a02cb Author: Xisco Fauli AuthorDate: Sun Jun 25 19:45:33 2023 +0200 Commit: Xisco Fauli CommitDate: Sun Jun 25 23:05:34 2023 +0200 tdf#155735: use 4x4 matrices in tests Change-Id: I7258443036eb89e7a67fce2a683f3212972a7395 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153565 Tested-by: Jenkins Reviewed-by: Xisco Fauli diff --git a/basegfx/source/color/bcolormodifier.cxx b/basegfx/source/color/bcolormodifier.cxx index 52f34a69f205..1ed19a4003eb 100644 --- a/basegfx/source/color/bcolormodifier.cxx +++ b/basegfx/source/color/bcolormodifier.cxx @@ -183,6 +183,7 @@ namespace basegfx aColorMatrix.set(0, 0, aSourceColor.getRed()); aColorMatrix.set(1, 0, aSourceColor.getGreen()); aColorMatrix.set(2, 0, aSourceColor.getBlue()); +// TODO: add support for alpha aColorMatrix = maMatrix * aColorMatrix; return ::basegfx::BColor(aColorMatrix.get(0, 0), aColorMatrix.get(1, 0), aColorMatrix.get(2, 0)); diff --git a/basegfx/test/BColorModifierTest.cxx b/basegfx/test/BColorModifierTest.cxx index 5a4b941e1c44..5ada0a33ddf9 100755 --- a/basegfx/test/BColorModifierTest.cxx +++ b/basegfx/test/BColorModifierTest.cxx @@ -285,6 +285,10 @@ public: aMatrix.set(2, 1, 0.0); aMatrix.set(2, 2, 0.0); aMatrix.set(2, 3, 0.0); +aMatrix.set(3, 0, 0.0); +aMatrix.set(3, 1, 0.0); +aMatrix.set(3, 2, 0.0); +aMatrix.set(3, 3, 1.0); const basegfx::BColorModifierSharedPtr aBColorModifier = std::make_shared(aMatrix); @@ -321,12 +325,19 @@ public: aMatrix.set(0, 0, 1.0); aMatrix.set(0, 1, 0.0); aMatrix.set(0, 2, 0.0); +aMatrix.set(0, 3, 0.0); aMatrix.set(1, 0, 0.0); aMatrix.set(1, 1, 1.0); aMatrix.set(1, 2, 0.0); +aMatrix.set(1, 3, 0.0); aMatrix.set(2, 0, 0.0); aMatrix.set(2, 1, 0.0); aMatrix.set(2, 2, 1.0); +aMatrix.set(2, 3, 0.0); +aMatrix.set(3, 0, 0.0); +aMatrix.set(3, 1, 0.0); +aMatrix.set(3, 2, 0.0); +aMatrix.set(3, 3, 1.0); const basegfx::BColorModifierSharedPtr aBColorModifier = std::make_shared(aMatrix);
[Libreoffice-bugs] [Bug 155834] Unnumbered entries do not move together with their main entry, when list's "move item up / down" commands are used
https://bugs.documentfoundation.org/show_bug.cgi?id=155834 --- Comment #15 from Mike Kaganski --- (In reply to Heiko Tietze from comment #13) > MSO behaves the same as LibreOffice. I have tested this, and yes, using Move Up/Down function in MS Word 2016 does behave the same way. However, it is completely unrelated. In Word (and in its file format), there is no proper notion of *list item*, which would include several paragraphs. The list like 1. a 2. b c 3. d 4. e would be represented by this OOXML markup: a b c d e so the "list item" feature of Writer doesn't exist in Word, and so it's incorrect to consider how Word behaves in this regard. The "unnumbered entries" in Word are ordinary paragraphs, just having the same paragraph style as numbered entries, to have the same indentation. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 155834] Unnumbered entries do not move together with their main entry, when list's "move item up / down" commands are used
https://bugs.documentfoundation.org/show_bug.cgi?id=155834 --- Comment #15 from Mike Kaganski --- (In reply to Heiko Tietze from comment #13) > MSO behaves the same as LibreOffice. I have tested this, and yes, using Move Up/Down function in MS Word 2016 does behave the same way. However, it is completely unrelated. In Word (and in its file format), there is no proper notion of *list item*, which would include several paragraphs. The list like 1. a 2. b c 3. d 4. e would be represented by this OOXML markup: a b c d e so the "list item" feature of Writer doesn't exist in Word, and so it's incorrect to consider how Word behaves in this regard. The "unnumbered entries" in Word are ordinary paragraphs, just having the same paragraph style as numbered entries, to have the same indentation. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 156052] NEW Chapter Number Using Followed by Newline is not persistent
https://bugs.documentfoundation.org/show_bug.cgi?id=156052 --- Comment #8 from Doug --- Well excussseee me! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156052] NEW Chapter Number Using Followed by Newline is not persistent
https://bugs.documentfoundation.org/show_bug.cgi?id=156052 --- Comment #7 from Mike Kaganski --- When you save as DOCX, it warns you that not all formatting may be saved in that format. Of course, you may disable this warning, if you know what you do, but then it's not a question why it happens. Writer allows you to use all features, no matter what was the original format from which current document was imported. Writer doesn't try to read user's mind, guessing which file format they will be using for save; if user wants this feature, it is here; if user then wants to save in an external format, being warned about consequences - user is the master. Again: what would be your expectation when opening TXT? Would you expect Writer to disable Bold/Italics/font selector? please try to find a word processor that behaves like that. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - sw/qa sw/source
sw/qa/extras/layout/data/tdf152983-1-min.docx |binary
sw/qa/extras/layout/layout.cxx|6 ++
sw/source/core/layout/wsfrm.cxx |5 +++--
3 files changed, 9 insertions(+), 2 deletions(-)
New commits:
commit 5fd62052499be565c2649e6cf3dccaad25a66575
Author: Michael Stahl
AuthorDate: Thu Jun 1 20:19:36 2023 +0200
Commit: Andras Timar
CommitDate: Sun Jun 25 21:29:38 2023 +0200
tdf#152983 sw: layout: fix crash in SwContentFrame::Cut()
Surprisingly, SwContentFrame::Cut() is called in a situation where the
frame is not connected to any SwPageFrame yet - it is in a follow fly of
a fly chain that is anchored in a footer, and SwFlyFrame::ChainFrames()
removes it.
(regression from commit b9ef71476fd70bc13f50ebe80390e0730d1b7afb)
Change-Id: Iad84b7b422126e050493dc3b181d47c4dca2fae2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152510
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit d3b64de9581bd5e36ced007ff2e9139bd0343a35)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152533
Reviewed-by: Caolán McNamara
diff --git a/sw/qa/extras/layout/data/tdf152983-1-min.docx
b/sw/qa/extras/layout/data/tdf152983-1-min.docx
new file mode 100644
index ..804e8fefe68f
Binary files /dev/null and b/sw/qa/extras/layout/data/tdf152983-1-min.docx
differ
diff --git a/sw/qa/extras/layout/layout.cxx b/sw/qa/extras/layout/layout.cxx
index eb6b36254276..c88d698ebc95 100644
--- a/sw/qa/extras/layout/layout.cxx
+++ b/sw/qa/extras/layout/layout.cxx
@@ -1267,6 +1267,12 @@ CPPUNIT_TEST_FIXTURE(SwLayoutWriter, TestTdf150606)
}
#endif
+CPPUNIT_TEST_FIXTURE(SwLayoutWriter, TestTdf152983)
+{
+//just care it doesn't crash/assert
+createSwDoc("tdf152983-1-min.docx");
+}
+
CPPUNIT_TEST_FIXTURE(SwLayoutWriter, TestTdf137025)
{
// Check the padding of the textbox
diff --git a/sw/source/core/layout/wsfrm.cxx b/sw/source/core/layout/wsfrm.cxx
index f753a993aceb..c59717f94901 100644
--- a/sw/source/core/layout/wsfrm.cxx
+++ b/sw/source/core/layout/wsfrm.cxx
@@ -1227,10 +1227,11 @@ void SwContentFrame::Cut()
// RemoveSuperfluous can only remove empty pages at the end;
// find if there are pages without content following pPage
// and if so request a call to CheckPageDescs()
-SwPageFrame const* pNext(pPage);
SwViewShell *pSh = pRoot->GetCurrShell();
-if (pSh && pSh->Imp()->IsAction())
+// tdf#152983 pPage is null when called from SwHeadFootFrame
ctor
+if (pPage && pSh && pSh->Imp()->IsAction())
{
+SwPageFrame const* pNext(pPage);
while ((pNext = static_cast(pNext->GetNext(
{
if (!sw::IsPageFrameEmpty(*pNext) &&
!pNext->IsFootnotePage())
[Libreoffice-bugs] [Bug 156052] NEW Chapter Number Using Followed by Newline is not persistent
https://bugs.documentfoundation.org/show_bug.cgi?id=156052 --- Comment #6 from Doug --- The option to use newlines in chapter numbering was available to me in the menu without any warning that .docx doesn't support it. Why wasn't it greyed out if i couldn't/shouldn't use it? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156052] NEW Chapter Number Using Followed by Newline is not persistent
https://bugs.documentfoundation.org/show_bug.cgi?id=156052 --- Comment #5 from Mike Kaganski --- I do not understand your question. What specifically is available? DOCX? Or newline? And would you expect Writer to keep this formatting, if you chose TXT as save format? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156052] NEW Chapter Number Using Followed by Newline is not persistent
https://bugs.documentfoundation.org/show_bug.cgi?id=156052 --- Comment #4 from Doug --- OK, then why is it available as an option? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156052] NEW Chapter Number Using Followed by Newline is not persistent
https://bugs.documentfoundation.org/show_bug.cgi?id=156052 Mike Kaganski changed: What|Removed |Added Resolution|--- |NOTABUG Status|UNCONFIRMED |RESOLVED --- Comment #3 from Mike Kaganski --- DOCX is a file format that does not support this kind of chapter formatting. It only supports what MS Word supports. This is not a bug. Please use native file format (ODT) to be able to store all features that Writer supports. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156052] NEW Chapter Number Using Followed by Newline is not persistent
https://bugs.documentfoundation.org/show_bug.cgi?id=156052 --- Comment #2 from Doug --- .docx -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156052] NEW Chapter Number Using Followed by Newline is not persistent
https://bugs.documentfoundation.org/show_bug.cgi?id=156052 --- Comment #1 from Mike Kaganski --- Which file format do you use for saving? -- You are receiving this mail because: You are the assignee for the bug.
GSoC'23 - Week 3 Report
--- title: "Week 3" date: 2023-06-15 --- ### Model training Basic [model training]( https://github.com/baolef/libreoffice-ci/blob/main/train.py) pipeline is completed with [testselect]( https://github.com/baolef/libreoffice-ci/blob/main/models/testselect.py) model. Further optimization is needed to reduce memory and time cost, together with performance. Currently, [testselect]( https://github.com/baolef/libreoffice-ci/blob/main/models/testselect.py) is trained on a subset of size 16384 (containing training and testing set) of the full dataset of size 122019 due to memory cost, and it has reached a failure recall of 91.4% and saving 90% of unit test computational cost. Its detailed confusion matrix is shown below: | | Fail (Predicted) | Pass (Predicted) | |---|--|--| | Fail (Actual) | 480 | 45 | | Pass (Actual) | 556910 | 5045893 |
[Libreoffice-bugs] [Bug 156046] Autocorrect replaces " - " with " – " instead of " — " (en-dash instead of em-dash)
https://bugs.documentfoundation.org/show_bug.cgi?id=156046 --- Comment #4 from Eyal Rozenberg --- (In reply to V Stuart Foote from comment #3) > Hmm, but when is it a minus vs. a dash? That is a bit of a red herring. We are already replacing it with a dash; this bug is about the question of _which_ dash... > Folks writing text runs as in-line formulas won't appreciate an U+2014 EM > DASH when they really need a U+2212 MINUS They don't need that, because: 1. We are talking about runs of text. When we are in something which is in some way designated as math formula, then we can talk. If you suggest we use some heuristic to detect that - please open a bug and we'll discuss it :-) 2. There are no spaces before and after minuses in a proper formula. > so not converting the - is probably more helpful. No > unexpected conversion, and they have to adjust the U+002d. Absolutely disagree. That is a niche use case, and even for that niche, using a formula editor (or a TeX add-on etc.) is the more appropriate thing to do. > IMHO the -- conversion to U+2013 EN DASH while keeping the > spaces is probably incorrect. Suggest we should instead be droping the > spaces and convert the run to a single EM DASH? No. Why? Because both the with-spaces and without-spaces styles are common. See this question on Writing.SX: https://writing.stackexchange.com/q/8555 > ... Chicago Style dictates that you must not have spaces before and > after the em dash, while AP Style dictates that you should have > spaces before and after... > Folks needing an EM DASH with surrounding white space can use the :---: > emoji syntax? We should be thinking about people who don't type syntax aiming for replacement, but about the typical author, who just writes using a single dash/hyphen and are not thinking about it. That is the typical use case we need to cater to. Nobody will know about this syntax nor use it. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: svgio/source
svgio/source/svgreader/svgtools.cxx |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
New commits:
commit a013911b8661daff2cdd58f0bf233ee7116f3029
Author: Xisco Fauli
AuthorDate: Sun Jun 25 18:57:02 2023 +0200
Commit: Xisco Fauli
CommitDate: Sun Jun 25 19:50:43 2023 +0200
tdf#155735: cid#1532475 Out-of-bounds access
Change-Id: Ifb3153cc492d042098398695642cd2530bc3b4b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153564
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/svgio/source/svgreader/svgtools.cxx
b/svgio/source/svgreader/svgtools.cxx
index f885086497c1..c45f4c5e9c61 100644
--- a/svgio/source/svgreader/svgtools.cxx
+++ b/svgio/source/svgreader/svgtools.cxx
@@ -855,9 +855,8 @@ namespace svgio::svgreader
SvgNumber aVal;
-// create a 3x5 matrix using the first 15 values from the list of
20 matrix values.
-// FIXME: support alpha (the last 5 values)
-for (sal_uInt16 nRow = 0; nRow < 3; ++nRow)
+// create a 4x4 matrix from the list of 20 matrix values.
+for (sal_uInt16 nRow = 0; nRow < 4; ++nRow)
{
for (sal_uInt16 nColumn = 0; nColumn < 5; ++nColumn)
{
@@ -869,7 +868,9 @@ namespace svgio::svgreader
if(readNumberAndUnit(rCandidate, nPos, aVal, nLen))
{
-aMatrix.set(nRow, nColumn, aVal.solve(rInfoProvider));
+// ignore the last column
+if (nColumn < 4)
+aMatrix.set(nRow, nColumn,
aVal.solve(rInfoProvider));
skip_char(rCandidate, ' ', ',', nPos, nLen);
}
}
[Libreoffice-bugs] [Bug 154266] Files not visible in LibreOffice's own file dialogs (gtk3)
https://bugs.documentfoundation.org/show_bug.cgi?id=154266 --- Comment #10 from Stéphane Guillou (stragu) --- Thanks Caolán. Pierre and Buovjaga, regarding the UI issue, are you able to five us the OS / Desktop Environment / Theme combination that makes the non-selected items disappear in that dialog? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156046] Autocorrect replaces " - " with " – " instead of " — " (en-dash instead of em-dash)
https://bugs.documentfoundation.org/show_bug.cgi?id=156046 --- Comment #3 from V Stuart Foote --- Hmm, but when is it a minus vs. a dash? Folks writing text runs as in-line formulas won't appreciate an U+2014 EM DASH when they really need a U+2212 MINUS, so not converting the - is probably more helpful. No unexpected conversion, and they have to adjust the U+002d. IMHO the -- conversion to U+2013 EN DASH while keeping the spaces is probably incorrect. Suggest we should instead be droping the spaces and convert the run to a single EM DASH? Closing the whitespace gap (catch a leading but no closing, or closing but no leading, along with the bracketed spaces). Folks needing an EM DASH with surrounding white space can use the :---: emoji syntax? Otherwise our "no spaces" conversion of two keyboard U+002d HYPHEN-DASH to EM DASH is appropriate. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 155745] In Libre Writer the 'typing cursor' and 'I bar' need improved contrast to Application Color "Document background"
https://bugs.documentfoundation.org/show_bug.cgi?id=155745 V Stuart Foote changed: What|Removed |Added OS|Windows (All) |All Summary|In Libre Writer make the|In Libre Writer the 'typing |'typing cursor' and 'I bar' |cursor' and 'I bar' need |more visible. |improved contrast to ||Application Color "Document ||background" CC||vsfo...@libreoffice.org --- Comment #2 from V Stuart Foote --- The text cursor does toggle color in response Application Colors 'Document background' set. Easier to see the effect if the document background is selected across the range of the Standard palette's gray scale. It is not the size or shape of the text cursor (and do not think we need to follow any os/DE settings cross platform). Rather, issue is that the transition of text cursor's gray scale color against background color does not auto-adjust well and you *can* end up with "invisible" Grey cursor on Grey 'Document background' and similar low contrast values around the gray-scale mid-range. Suggests there should be a test of text cursor contrast against document background for auto-adjust. Also in addition to contrast testing for automatic values, I would love to be able to directly set the text cursor and pointer color as Application color elements. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 155745] In Libre Writer the 'typing cursor' and 'I bar' need improved contrast to Application Color "Document background"
https://bugs.documentfoundation.org/show_bug.cgi?id=155745 V Stuart Foote changed: What|Removed |Added OS|Windows (All) |All Summary|In Libre Writer make the|In Libre Writer the 'typing |'typing cursor' and 'I bar' |cursor' and 'I bar' need |more visible. |improved contrast to ||Application Color "Document ||background" CC||vsfo...@libreoffice.org --- Comment #2 from V Stuart Foote --- The text cursor does toggle color in response Application Colors 'Document background' set. Easier to see the effect if the document background is selected across the range of the Standard palette's gray scale. It is not the size or shape of the text cursor (and do not think we need to follow any os/DE settings cross platform). Rather, issue is that the transition of text cursor's gray scale color against background color does not auto-adjust well and you *can* end up with "invisible" Grey cursor on Grey 'Document background' and similar low contrast values around the gray-scale mid-range. Suggests there should be a test of text cursor contrast against document background for auto-adjust. Also in addition to contrast testing for automatic values, I would love to be able to directly set the text cursor and pointer color as Application color elements. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156052] New: NEW Chapter Number Using Followed by Newline is not persistent
https://bugs.documentfoundation.org/show_bug.cgi?id=156052 Bug ID: 156052 Summary: NEW Chapter Number Using Followed by Newline is not persistent Product: LibreOffice Version: 7.5.3.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: douglas.mar...@gmail.com Description: I am writing a book using LibreOffice Writer 7.5.3.2 X86_64. I have to use the chapter number followed by newline since I'm using a narrow page size and sometimes chapter titles are too long to fit the page width with the chapter number too. The new line works for a while, then like after a save or something, it reverts back to a tab stop. Steps to Reproduce: 1.Chapter numbering using English numbers and newline separator 2. I believe it resets after a save. 3. Actual Results: Chapter numbering uses tab stop Expected Results: Chapter numbering continues to use newline Reproducible: Always User Profile Reset: No Additional Info: ? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154266] Files not visible in LibreOffice's own file dialogs (gtk3)
https://bugs.documentfoundation.org/show_bug.cgi?id=154266 --- Comment #9 from Caolán McNamara --- Oh good, so it does look like the scenario was the same as mine then. Headless mode switching on this internal file dialog and some crash or other failure making the reset to "normal" not happen. So that trigger is fixed at least. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156046] Autocorrect replaces " - " with " – " instead of " — " (en-dash instead of em-dash)
https://bugs.documentfoundation.org/show_bug.cgi?id=156046 --- Comment #2 from Eyal Rozenberg --- (In reply to V Stuart Foote from comment #1) > Not clear we are doing it incorrectly. ... > A single keyboard hyphen dash (U+002d) with spaces is converted to a single > U+2013 (EN DASH). This is the bug. A user that's not well aware of dashes and their importance is likely to use a space hyphen space sequence, and we should interpret that as "I don't know what kind of dash I want", and enter an Em dash. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: svx/source
svx/source/sidebar/area/AreaPropertyPanelBase.cxx |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit 4acf48b99804be712d2bd6e3e73c1f030ec637d5 Author: Caolán McNamara AuthorDate: Sun Jun 25 14:25:07 2023 +0100 Commit: Caolán McNamara CommitDate: Sun Jun 25 17:40:46 2023 +0200 cid#1532451 silence Iterator container mismatch Change-Id: I8560f3e5c7820fef8e27433321c97fc3a0b29746 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153552 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/svx/source/sidebar/area/AreaPropertyPanelBase.cxx b/svx/source/sidebar/area/AreaPropertyPanelBase.cxx index 582d4536d981..3659110f16db 100644 --- a/svx/source/sidebar/area/AreaPropertyPanelBase.cxx +++ b/svx/source/sidebar/area/AreaPropertyPanelBase.cxx @@ -519,8 +519,7 @@ void AreaPropertyPanelBase::FillStyleChanged(bool bUpdateModel) // MCGR: preserve ColorStops if given // tdf#155901 We need offset of first and last stop, so include them. if (aGradient.GetColorStops().size() >= 2) -maColorStops = basegfx::BColorStops(aGradient.GetColorStops().begin(), - aGradient.GetColorStops().end()); +maColorStops = aGradient.GetColorStops(); else maColorStops.clear();
[Libreoffice-commits] core.git: sc/inc sc/source solenv/clang-format
sc/inc/CommonProperties.hxx | 20
sc/source/ui/unoobj/cellsuno.cxx | 37 +
sc/source/ui/unoobj/styleuno.cxx |7 +++
solenv/clang-format/excludelist |1 +
4 files changed, 37 insertions(+), 28 deletions(-)
New commits:
commit bcd3ca80cd1f59c4b94660daa8c3e66944caf58f
Author: Tomaž Vajngerl
AuthorDate: Fri Jun 23 17:13:44 2023 +0900
Commit: Tomaž Vajngerl
CommitDate: Sun Jun 25 17:36:00 2023 +0200
sc: simplify and fix prop. mapping for cell BG and char theme color
Change-Id: I461106200d37f0c605c07095c6b5871ea89e0e20
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153501
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/sc/inc/CommonProperties.hxx b/sc/inc/CommonProperties.hxx
new file mode 100644
index ..2c7d1e0a080b
--- /dev/null
+++ b/sc/inc/CommonProperties.hxx
@@ -0,0 +1,20 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#pragma once
+
+#define CELL_BACKGROUND_COLOR_PROPERTIES \
+{ SC_UNONAME_CELLBACK, ATTR_BACKGROUND, cppu::UnoType::get(),
0, MID_BACK_COLOR }, \
+{ SC_UNONAME_CELL_BACKGROUND_COMPLEX_COLOR, ATTR_BACKGROUND,
cppu::UnoType::get(), 0, MID_BACKGROUND_COMPLEX_COLOR
}, \
+
+#define CHAR_COLOR_PROPERTIES \
+{ SC_UNONAME_CCOLOR, ATTR_FONT_COLOR, cppu::UnoType::get(), 0,
MID_COLOR_RGB }, \
+{ SC_UNONAME_CHAR_COMPLEX_COLOR, ATTR_FONT_COLOR,
cppu::UnoType::get(), 0, MID_COMPLEX_COLOR }, \
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/ui/unoobj/cellsuno.cxx b/sc/source/ui/unoobj/cellsuno.cxx
index 371ea346d364..d6a836fdc8d9 100644
--- a/sc/source/ui/unoobj/cellsuno.cxx
+++ b/sc/source/ui/unoobj/cellsuno.cxx
@@ -137,6 +137,7 @@
#include
#include
#include
+#include
#include
@@ -156,12 +157,10 @@ static const SfxItemPropertySet* lcl_GetCellsPropertySet()
{ SC_UNONAME_ASIANVERT,ATTR_VERTICAL_ASIAN,cppu::UnoType::get(),
0, 0 },
{ SC_UNONAME_BOTTBORDER,ATTR_BORDER,
::cppu::UnoType::get(), 0, BOTTOM_BORDER | CONVERT_TWIPS },
{ SC_UNONAME_BOTTBORDER2,ATTR_BORDER,
::cppu::UnoType::get(), 0, BOTTOM_BORDER | CONVERT_TWIPS },
-{ SC_UNONAME_CELLBACK, ATTR_BACKGROUND,
cppu::UnoType::get(),0, MID_BACK_COLOR },
-{ SC_UNONAME_CELL_BACKGROUND_COMPLEX_COLOR, ATTR_BACKGROUND,
cppu::UnoType::get(), 0, MID_BACKGROUND_COMPLEX_COLOR
},
+CELL_BACKGROUND_COLOR_PROPERTIES
{ SC_UNONAME_CELLPRO, ATTR_PROTECTION,
cppu::UnoType::get(), 0, 0 },
{ SC_UNONAME_CELLSTYL,
SC_WID_UNO_CELLSTYL,cppu::UnoType::get(),0, 0 },
-{ SC_UNONAME_CCOLOR, ATTR_FONT_COLOR,
cppu::UnoType::get(),0, 0 },
-{ SC_UNONAME_CHAR_COMPLEX_COLOR, ATTR_FONT_COLOR,
cppu::UnoType::get(), 0, MID_BACKGROUND_COMPLEX_COLOR
},
+CHAR_COLOR_PROPERTIES
{ SC_UNONAME_COUTL,ATTR_FONT_CONTOUR, cppu::UnoType::get(),
0, 0 },
{ SC_UNONAME_CCROSS,
ATTR_FONT_CROSSEDOUT,cppu::UnoType::get(), 0,
MID_CROSSED_OUT },
{ SC_UNONAME_CEMPHAS,
ATTR_FONT_EMPHASISMARK,cppu::UnoType::get(), 0, MID_EMPHASIS
},
@@ -267,12 +266,10 @@ static const SfxItemPropertySet* lcl_GetRangePropertySet()
{ SC_UNONAME_ASIANVERT,ATTR_VERTICAL_ASIAN,cppu::UnoType::get(),
0, 0 },
{ SC_UNONAME_BOTTBORDER,ATTR_BORDER,
::cppu::UnoType::get(), 0, BOTTOM_BORDER | CONVERT_TWIPS },
{ SC_UNONAME_BOTTBORDER2,ATTR_BORDER,
::cppu::UnoType::get(), 0, BOTTOM_BORDER | CONVERT_TWIPS },
-{ SC_UNONAME_CELLBACK, ATTR_BACKGROUND,
cppu::UnoType::get(),0, MID_BACK_COLOR },
-{ SC_UNONAME_CELL_BACKGROUND_COMPLEX_COLOR, ATTR_BACKGROUND,
cppu::UnoType::get(), 0, MID_BACKGROUND_COMPLEX_COLOR
},
+CELL_BACKGROUND_COLOR_PROPERTIES
{ SC_UNONAME_CELLPRO, ATTR_PROTECTION,
cppu::UnoType::get(), 0, 0 },
{ SC_UNONAME_CELLSTYL,
SC_WID_UNO_CELLSTYL,cppu::UnoType::get(),0, 0 },
-{ SC_UNONAME_CCOLOR, ATTR_FONT_COLOR,
cppu::UnoType::get(),0, 0 },
-{ SC_UNONAME_CHAR_COMPLEX_COLOR, ATTR_FONT_COLOR,
cppu::UnoType::get(), 0, MID_BACKGROUND_COMPLEX_COLOR
},
+CHAR_COLOR_PROPERTIES
{ SC_UNONAME_COUTL,ATTR_FONT_CONTOUR, cppu::UnoType::get(),
0, 0 },
{ SC_UNONAME_CCROSS,
ATTR_FONT_CROSSEDOUT,cppu::UnoType::get(), 0,
MID_CROSSED_OUT },
{ SC_UNONAME_CEMPHAS,
ATTR_FONT_EMPHASISMARK,cppu::UnoType::get(), 0, MID_EMPHASIS
},
@@ -379,12 +376,10 @@
[Libreoffice-commits] core.git: 2 commits - oox/source sc/source
oox/source/drawingml/color.cxx | 36 +++
sc/source/ui/theme/ThemeColorChanger.cxx | 36 +++
2 files changed, 59 insertions(+), 13 deletions(-)
New commits:
commit 95d199e3d1a04a469e1d22896ffd967c7a06c3f0
Author: Tomaž Vajngerl
AuthorDate: Fri Jun 23 13:49:24 2023 +0900
Commit: Tomaž Vajngerl
CommitDate: Sun Jun 25 17:35:50 2023 +0200
sc: ThemeColorChanger - change theme color for borders
Change-Id: Id6b08ad48b496d2f1138aeea8d024a5f61bee633
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153500
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/sc/source/ui/theme/ThemeColorChanger.cxx
b/sc/source/ui/theme/ThemeColorChanger.cxx
index 2211aa67b554..a245f7b0c1c0 100644
--- a/sc/source/ui/theme/ThemeColorChanger.cxx
+++ b/sc/source/ui/theme/ThemeColorChanger.cxx
@@ -16,6 +16,8 @@
#include
#include
#include
+#include
+#include
#include
#include
@@ -35,6 +37,26 @@ ThemeColorChanger::~ThemeColorChanger() = default;
namespace
{
+bool changeBorderLine(editeng::SvxBorderLine* pBorderLine, model::ColorSet
const& rColorSet)
+{
+if (!pBorderLine)
+return false;
+
+model::ComplexColor const& rComplexColor = pBorderLine->getComplexColor();
+if (rComplexColor.meType == model::ColorType::Scheme)
+{
+auto eThemeType = rComplexColor.meSchemeType;
+
+if (eThemeType != model::ThemeColorType::Unknown)
+{
+Color aColor = rColorSet.resolveColor(rComplexColor);
+pBorderLine->SetColor(aColor);
+return true;
+}
+}
+return false;
+}
+
void changeCellItems(SfxItemSet& rItemSet, model::ColorSet const& rColorSet)
{
const SfxPoolItem* pItem = nullptr;
@@ -75,6 +97,20 @@ void changeCellItems(SfxItemSet& rItemSet, model::ColorSet
const& rColorSet)
}
}
}
+if (rItemSet.HasItem(ATTR_BORDER, ))
+{
+auto const* pBoxItem = static_cast(pItem);
+SvxBoxItem rNewItem(*pBoxItem);
+bool bChanged = false;
+
+bChanged = changeBorderLine(rNewItem.GetBottom(), rColorSet) ||
bChanged;
+bChanged = changeBorderLine(rNewItem.GetTop(), rColorSet) || bChanged;
+bChanged = changeBorderLine(rNewItem.GetLeft(), rColorSet) || bChanged;
+bChanged = changeBorderLine(rNewItem.GetRight(), rColorSet) ||
bChanged;
+
+if (bChanged)
+rItemSet.Put(rNewItem);
+}
}
} // end anonymous ns
commit 163ad701b61af6888bb9fbaaf2d8a49054f9a846
Author: Tomaž Vajngerl
AuthorDate: Fri Jun 23 21:58:22 2023 +0900
Commit: Tomaž Vajngerl
CommitDate: Sun Jun 25 17:35:40 2023 +0200
oox: map color transforms direct to create model::Transform
Change-Id: I82382f8d0936e90218fefe889ea5bfdd04c3e82b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153507
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/oox/source/drawingml/color.cxx b/oox/source/drawingml/color.cxx
index 4d2ee2afbbce..b653458300f4 100644
--- a/oox/source/drawingml/color.cxx
+++ b/oox/source/drawingml/color.cxx
@@ -840,21 +840,31 @@ model::ComplexColor Color::createComplexColor(const
GraphicHelper& /*rGraphicHel
return aNewComplexColor;
}
-if (getLumMod() != 1)
-aNewComplexColor.addTransformation({model::TransformationType::LumMod,
getLumMod()});
-
-if (getLumOff() != 0)
-aNewComplexColor.addTransformation({model::TransformationType::LumOff,
getLumOff()});
-
-if (getTintOrShade() > 0)
-{
-aNewComplexColor.addTransformation({model::TransformationType::Tint,
getTintOrShade()});
-}
-else if (getTintOrShade() < 0)
+for(auto const& aTransform : maTransforms)
{
-sal_Int16 nShade = o3tl::narrowing(-getTintOrShade());
-aNewComplexColor.addTransformation({model::TransformationType::Shade,
nShade});
+sal_Int16 nValue = sal_Int16(aTransform.mnValue / 10);
+
+switch(aTransform.mnToken)
+{
+case XML_lumMod:
+if (nValue != 10'000)
+
aNewComplexColor.addTransformation({model::TransformationType::LumMod, nValue});
+break;
+case XML_lumOff:
+if (nValue != 0)
+
aNewComplexColor.addTransformation({model::TransformationType::LumOff, nValue});
+break;
+case XML_tint:
+if (nValue != 0)
+
aNewComplexColor.addTransformation({model::TransformationType::Tint, nValue});
+break;
+case XML_shade:
+if (nValue != 0)
+
aNewComplexColor.addTransformation({model::TransformationType::Shade, nValue});
+break;
+}
}
+
return aNewComplexColor;
}
[Libreoffice-bugs] [Bug 156050] Multiple squiggly lines under misspelled words in text boxes
https://bugs.documentfoundation.org/show_bug.cgi?id=156050 --- Comment #2 from Hossein --- Two notes: 1. The problem is not reproducible with LO 7.5, so it is a regression. Version: 7.5.1.2 (X86_64) / LibreOffice Community Build ID: fcbaee479e84c6cd81291587d2ee68cba099e129 CPU threads: 12; OS: Linux 5.19; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: CL threaded 2. To test LO dev, you need to have spell checker for Persian, or other languages you want to test. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148006] Export to SVG broken, when exporting rotated objects with multiple lines of text
https://bugs.documentfoundation.org/show_bug.cgi?id=148006 --- Comment #6 from Galuxttor --- Confirm in Version: 7.5.4.2 (x86) / LibreOffice Community Build ID: 36ccfdc35048b057fd9854c757a8b67ec53977b6 CPU threads: 4; OS: Windows; UI render: default; VCL: win Locale: it-IT (it_IT); UI: it-IT Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156003] In bugzilla search option will be not working.
https://bugs.documentfoundation.org/show_bug.cgi?id=156003 Julien Nabet changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156003] In bugzilla search option will be not working.
https://bugs.documentfoundation.org/show_bug.cgi?id=156003 Julien Nabet changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156051] libreoffice-gtk3 package impairs SLIDESHOW of imported MPEG4 and AVI videos by IMPRESS
https://bugs.documentfoundation.org/show_bug.cgi?id=156051 --- Comment #1 from Dave Poole --- Created attachment 188083 --> https://bugs.documentfoundation.org/attachment.cgi?id=188083=edit Screen capture of slideshow showing the effect of libreoffice-gtk3 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156051] New: libreoffice-gtk3 package impairs SLIDESHOW of imported MPEG4 and AVI videos by IMPRESS
https://bugs.documentfoundation.org/show_bug.cgi?id=156051 Bug ID: 156051 Summary: libreoffice-gtk3 package impairs SLIDESHOW of imported MPEG4 and AVI videos by IMPRESS Product: LibreOffice Version: 7.3.7.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: dlpoole.i...@gmail.com Description: Mint 21.1 by default installs LibreOffice with libreoffice-gtk3 1:7.3.7-0ubuntu0.22. As long as this package is present, IMPRESS slideshows MPEG4 and AVI videos in left-justified monochrome, even though the default Celluloid viewer and VLC display them perfectly. Removing the subject package changes Impress' UI’s as expected, then mpeg4 and avi videos in the same presentation SLIDESHOW display and play properly. Steps to Reproduce: 1.Install libreoffice-gtk3 1:7.3.7-0ubuntu0.22 if not already present 2.Attempt slideshow of a presentation with an imported mpeg4 or avi video 3.Remove the subject package with APT, etc. 4.Restart Impress, load presentation with video, and repeat Actual Results: While libreoffice-gtk3 1:7.3.7-0ubuntu0.22 is present, IMPRESS slideshows imported MPEG4 and AVI videos in left-justified monochrome, sometimes over a color still of the first frame as shown prior to starting the SLIDESHOW. Expected Results: After the subject package is removed and Impress is restarted, the same presentation file with imported videos slideshows perfectly. Reproducible: Always User Profile Reset: Yes Additional Info: 7.3.7.2 / LibreOffice Community CPU threads:4;OS:Linux 5.15 UI render:default; VCL:gtk3 en-US(en_US.UTF-8;UI:en-US Ubuntu package version: 1:7.3.7-0ubuntu0.22.04.3 Calc:threaded Same with the subject package removed except VCL:x11 -- You are receiving this mail because: You are the assignee for the bug.
Re: test failures with new fonts-crosextra-carlito
Hi,
Am 25.06.23 um 13:29 schrieb Rene Engelhard:
Anyways, this breaks some of sds import tests (I tried this in a
actual beta1 "release" build, not on master - which worked before):
Also:
[build CUT] sw_layoutwriter3
S=/data/ssd/rene/libreoffice-7.6.0~beta1 && I=$S/instdir && W=$S/workdir
&& mkdir -p $W/CppunitTest/ && rm -fr
$W/CppunitTest/sw_layoutwriter3.test.user && cp -r $W/unittest
$W/CppunitTest/sw_layoutwriter3.test.user && rm -fr
$W/CppunitTest/sw_layoutwriter3.test.core && mkdir
$W/CppunitTest/sw_layoutwriter3.test.core && cd
$W/CppunitTest/sw_layoutwriter3.test.core && ( MAX_CONCURRENCY=4
MOZILLA_CERTIFICATE_FOLDER=dbm:
SAL_DISABLE_SYNCHRONOUS_PRINTER_DETECTION=1 SAL_USE_VCLPLUGIN=svp
LIBO_LANG=C
LD_LIBRARY_PATH=${LD_LIBRARY_PATH:+$LD_LIBRARY_PATH:}"$I/program:$I/program":$W/UnpackedTarball/cppunit/src/cppunit/.libs
$W/LinkTarget/Executable/cppunittester
$W/LinkTarget/CppunitTest/libtest_sw_layoutwriter3.so --headless
"-env:BRAND_BASE_DIR=file://$S/instdir" "-env:BRAND_SHARE_SUBDIR=share"
"-env:BRAND_SHARE_RESOURCE_SUBDIR=program/resource"
"-env:UserInstallation=file://$W/CppunitTest/sw_layoutwriter3.test.user"
"-env:CONFIGURATION_LAYERS=xcsxcu:file://$I/share/registry
xcsxcu:file://$W/unittest/registry-common
xcsxcu:file://$W/unittest/registry-user-ui"
"-env:UNO_TYPES=file://$I/program/types.rdb
file://$I/program/types/offapi.rdb file://$I/program/types/oovbaapi.rdb"
"-env:UNO_SERVICES=file://$W/Rdb/ure/services.rdb
file://$W/Rdb/services.rdb" -env:URE_BIN_DIR=file://$I/program
-env:URE_INTERNAL_LIB_DIR=file://$I/program
-env:LO_LIB_DIR=file://$I/program
-env:LO_JAVA_DIR=file://$I/program/classes --protector
$W/LinkTarget/Library/unoexceptionprotector.so unoexceptionprotector
--protector $W/LinkTarget/Library/unobootstrapprotector.so
unobootstrapprotector --protector
$W/LinkTarget/Library/libvclbootstrapprotector.so vclbootstrapprotector
"-env:CPPUNITTESTTARGET=$W/CppunitTest/sw_layoutwriter3.test" ) 2>&1
[_RUN_] TestTdf150616::TestBody
TestTdf150616::TestBody finished in: 1322ms
[_RUN_] testAbi11870::TestBody
file:///data/ssd/rene/libreoffice-7.6.0~beta1//sw/qa/extras/layout/data//abi11870-2.odt:
testAbi11870::TestBody finished in: 1043ms
[_RUN_] testBtlrCell::TestBody
file:///data/ssd/rene/libreoffice-7.6.0~beta1//sw/qa/extras/layout/data//btlr-cell.odt:
./test/source/xmltesttools.cxx:170:testBtlrCell::TestBody
equality assertion failed
- Expected: 1915
- Actual : 1911
- In <>, attribute 'x' of '//textarray[1]' incorrect value.
testBtlrCell::TestBody finished in: 232ms
[…]
Regards,
Rene
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - sw/qa sw/source
sw/qa/extras/layout/data/tdf150606-1-min.odt |binary
sw/qa/extras/layout/layout.cxx | 65 +++
sw/source/core/layout/fly.cxx|6 ++
3 files changed, 70 insertions(+), 1 deletion(-)
New commits:
commit 647b491ac838a8f679bc00229886efdd0ff97077
Author: Michael Stahl
AuthorDate: Thu Jun 1 12:45:20 2023 +0200
Commit: Andras Timar
CommitDate: Sun Jun 25 14:41:06 2023 +0200
tdf#150606 sw: layout: leave follow SwTabFrame invalid in columns
With the minimised bugdoc, on Undo, some 12 or so pages are created, and
the end of the deleted table is shown in the document view.
So first the last pages are layouted, and then once those are done
layout proceeds from page 1.
The problem is that on page 9, a table remains in the 2nd column of the
section, and there is nothing in the 1st column and on pages 5-8.
This is because ::CalcContent() is the last thing that formats the table
on page 9, and it explicitly disables MoveBwd() for follow tables via
m_bLockBackMove.
That appears to be intentional but because it's already been there since
initial CVS import it's unclear why; it might be based on the assumption
that a previous column would have moved over rows from the follow table
already.
Try to encourage the table to try to MoveBwd() at a later time, when
it's being formatted from the SwLayAction::FormatContent_() loop, which
appears to help.
(somehow regression from commit 723728cd358693b8f4bc9d913541aa4479f2bd48)
Change-Id: I421525269948aa5f5302e6db234c89230f00
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152485
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 5a739d98d0efa5be2130b7d758d494012abc87b3)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152446
Reviewed-by: Caolán McNamara
diff --git a/sw/qa/extras/layout/data/tdf150606-1-min.odt
b/sw/qa/extras/layout/data/tdf150606-1-min.odt
new file mode 100644
index ..63bd1ceb0a5b
Binary files /dev/null and b/sw/qa/extras/layout/data/tdf150606-1-min.odt differ
diff --git a/sw/qa/extras/layout/layout.cxx b/sw/qa/extras/layout/layout.cxx
index ff5cc4b764af..eb6b36254276 100644
--- a/sw/qa/extras/layout/layout.cxx
+++ b/sw/qa/extras/layout/layout.cxx
@@ -1202,6 +1202,71 @@ CPPUNIT_TEST_FIXTURE(SwLayoutWriter,
testRedlineFlysInHeader)
}
}
+#if !defined(MACOSX)
+CPPUNIT_TEST_FIXTURE(SwLayoutWriter, TestTdf150606)
+{
+createSwDoc("tdf150606-1-min.odt");
+
+SwXTextDocument* pTextDoc =
dynamic_cast(mxComponent.get());
+CPPUNIT_ASSERT(pTextDoc);
+SwWrtShell* pWrtShell = pTextDoc->GetDocShell()->GetWrtShell();
+
+xmlDocUniquePtr pXmlDoc = parseLayoutDump();
+
+assertXPath(pXmlDoc, "/root/page[1]/body/section/column[1]/body/tab", 1);
+assertXPath(pXmlDoc, "/root/page[1]/body/section/column[2]/body/tab", 1);
+assertXPath(pXmlDoc, "/root/page[1]/body/section/column", 2);
+assertXPath(pXmlDoc, "/root/page[2]/body/section/column[1]/body/tab", 1);
+assertXPath(pXmlDoc, "/root/page[2]/body/section/column[2]/body/tab", 1);
+assertXPath(pXmlDoc, "/root/page[2]/body/section/column", 2);
+assertXPath(pXmlDoc, "/root/page[3]/body/section/column[1]/body/tab", 1);
+assertXPath(pXmlDoc, "/root/page[3]/body/section/column[2]/body/tab", 1);
+assertXPath(pXmlDoc, "/root/page[3]/body/section/column", 2);
+assertXPath(pXmlDoc, "/root/page[4]/body/section/column[1]/body/tab", 1);
+assertXPath(pXmlDoc, "/root/page[4]/body/section/column[2]/body/tab", 1);
+assertXPath(pXmlDoc, "/root/page[4]/body/section/column", 2);
+// on page 5 the table is split across balanced columns
+assertXPath(pXmlDoc, "/root/page[5]/body/section/column[1]/body/tab", 1);
+assertXPath(pXmlDoc, "/root/page[5]/body/section/column[2]/body/tab", 1);
+assertXPath(pXmlDoc, "/root/page[5]/body/section/column", 2);
+assertXPath(pXmlDoc, "/root/page", 5);
+
+pWrtShell->Down(false, 1);
+dispatchCommand(mxComponent, ".uno:DeleteTable", {});
+
+discardDumpedLayout();
+pXmlDoc = parseLayoutDump();
+
+assertXPath(pXmlDoc, "/root/page[1]/body/section/column/body/tab", 0);
+assertXPath(pXmlDoc, "/root/page", 1);
+
+pWrtShell->Undo();
+Scheduler::ProcessEventsToIdle();
+
+discardDumpedLayout();
+pXmlDoc = parseLayoutDump();
+
+assertXPath(pXmlDoc, "/root/page[1]/body/section/column[1]/body/tab", 1);
+assertXPath(pXmlDoc, "/root/page[1]/body/section/column[2]/body/tab", 1);
+assertXPath(pXmlDoc, "/root/page[1]/body/section/column", 2);
+assertXPath(pXmlDoc, "/root/page[2]/body/section/column[1]/body/tab", 1);
+assertXPath(pXmlDoc, "/root/page[2]/body/section/column[2]/body/tab", 1);
+assertXPath(pXmlDoc, "/root/page[2]/body/section/column", 2);
+assertXPath(pXmlDoc, "/root/page[3]/body/section/column[1]/body/tab", 1);
+
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - i18npool/source sw/qa sw/source
i18npool/source/characterclassification/cclass_unicode_parser.cxx | 10 +-
sw/qa/extras/uiwriter/data/tdf125154.odt |binary
sw/qa/extras/uiwriter/uiwriter.cxx| 47
++
sw/source/core/bastyp/calc.cxx|2
4 files changed, 57 insertions(+), 2 deletions(-)
New commits:
commit 3e330549f4d580c7443d5e9de6ae14bdb9dae064
Author: Michael Stahl
AuthorDate: Tue Jun 13 17:15:07 2023 +0200
Commit: Andras Timar
CommitDate: Sun Jun 25 14:30:40 2023 +0200
tdf#125154 i18npool,sw: fix group separators in numbers in formulas
Commit 776f7e7463de3e97f3056712ee567f49a314829d changed cclass_Unicode
to reject group separators in numbers by default, but users are
complaining that the neat "5.000" numbers in their existing documents
are now considered invalid.
* in SwCalc, use GROUP_SEPARATOR_IN_NUMBER
* in cclass_Unicode::parseText(), reject a group separator if it is not
followed by at least 3 digits
With this, a number from tdf#42518 "0.19" is still considered invalid,
while "5.000" is now valid again.
Change-Id: If86f2ed4c27be16f866d7f4cee00789344e9ee2e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153047
Tested-by: Michael Stahl
Reviewed-by: Michael Stahl
(cherry picked from commit 29f5742bc8ff36741baac5b71082b3daee70ac18)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153146
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/i18npool/source/characterclassification/cclass_unicode_parser.cxx
b/i18npool/source/characterclassification/cclass_unicode_parser.cxx
index 313e42a0f2fe..f1b2e9bd7c17 100644
--- a/i18npool/source/characterclassification/cclass_unicode_parser.cxx
+++ b/i18npool/source/characterclassification/cclass_unicode_parser.cxx
@@ -827,8 +827,16 @@ void cclass_Unicode::parseText( ParseResult& r, const
OUString& rText, sal_Int32
{
if (current == cGroupSep)
{
-if (getFlags(nextChar, eState) &
ParserFlags::VALUE_DIGIT)
+// accept only if it is followed by 3 digits
+sal_Int32 tempIndex(index);
+sal_uInt32 const nextChar2((tempIndex <
rText.getLength()) ? rText.iterateCodePoints() : 0);
+sal_uInt32 const nextChar3((tempIndex <
rText.getLength()) ? rText.iterateCodePoints() : 0);
+if (getFlags(nextChar, eState) &
ParserFlags::VALUE_DIGIT
+&& getFlags(nextChar2, eState) &
ParserFlags::VALUE_DIGIT
+&& getFlags(nextChar3, eState) &
ParserFlags::VALUE_DIGIT)
+{
nParseTokensType |=
KParseTokens::GROUP_SEPARATOR_IN_NUMBER;
+}
else
{
// Trailing group separator character is not a
diff --git a/sw/qa/extras/uiwriter/data/tdf125154.odt
b/sw/qa/extras/uiwriter/data/tdf125154.odt
new file mode 100644
index ..81dee2be72cf
Binary files /dev/null and b/sw/qa/extras/uiwriter/data/tdf125154.odt differ
diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx
b/sw/qa/extras/uiwriter/uiwriter.cxx
index 0e45204f25db..363a6cf06c4c 100644
--- a/sw/qa/extras/uiwriter/uiwriter.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter.cxx
@@ -375,6 +375,53 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest, testBookmarkCopy)
}
}
+CPPUNIT_TEST_FIXTURE(SwUiWriterTest, testFormulaNumberWithGroupSeparator)
+{
+createSwDoc("tdf125154.odt");
+dispatchCommand(mxComponent, ".uno:UpdateAll", {});
+SwDoc* pDoc = getSwDoc();
+SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+pWrtShell->SttEndDoc(true);
+SwField const* pField;
+
+pField = pWrtShell->GetCurField();
+CPPUNIT_ASSERT_EQUAL(OUString("1000"), pField->GetFormula());
+CPPUNIT_ASSERT_EQUAL(OUString("1.000"), pField->ExpandField(true,
nullptr));
+pWrtShell->GoNextCell();
+CPPUNIT_ASSERT_EQUAL(OUString("1"),
pWrtShell->GetCursor()->GetPoint()->nNode.GetNode().GetTextNode()->GetText());
+pWrtShell->GoNextCell();
+pField = pWrtShell->GetCurField();
+CPPUNIT_ASSERT_EQUAL(OUString("test"), pField->GetFormula());
+CPPUNIT_ASSERT_EQUAL(OUString("1.000"), pField->ExpandField(true,
nullptr));
+pWrtShell->GoNextCell();
+// the problem was that this was 0
+CPPUNIT_ASSERT_EQUAL(OUString("1"),
pWrtShell->GetCursor()->GetPoint()->nNode.GetNode().GetTextNode()->GetText());
+pWrtShell->Down(false);
+pWrtShell->SttPara(false);
+pField = pWrtShell->GetCurField();
+CPPUNIT_ASSERT_EQUAL(OUString("1000*10%"), pField->GetFormula());
+CPPUNIT_ASSERT_EQUAL(OUString("100"), pField->ExpandField(true, nullptr));
+pWrtShell->Down(false);
+pField =
[Libreoffice-bugs] [Bug 89466] [META] SIDEBAR: Slide content panel in Properties tab in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=89466 Regina Henschel changed: What|Removed |Added Depends on||145130 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=145130 [Bug 145130] Changing an LO Draw's background gradient color resets its gradient type, angle, and other properties -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145130] Changing an LO Draw's background gradient color resets its gradient type, angle, and other properties
https://bugs.documentfoundation.org/show_bug.cgi?id=145130 Regina Henschel changed: What|Removed |Added Blocks||89466 --- Comment #8 from Regina Henschel --- The problem is not solved with multicolor gradient (MCGR). Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=89466 [Bug 89466] [META] SIDEBAR: Slide content panel in Properties tab in Impress -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - svx/source
svx/source/tbxctrls/PaletteManager.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit 6a7bfd512e7ff00d8a4caadd9edcf3299bfa35c6 Author: Tomaž Vajngerl AuthorDate: Fri Jun 23 00:01:19 2023 +0900 Commit: Caolán McNamara CommitDate: Sun Jun 25 14:13:27 2023 +0200 fix crash in PaletteManager triggered by the color picker The code expects the SfxObjectShell::GetThemeColors() always returns a current set of theme colors, but then for some modules we return nullptr. Change-Id: I4096b75942d818965cedf43f35444faeb870cb74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153424 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl (cherry picked from commit f4867086c8498ef168f7d2e8d94b872e516a9d4d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153429 Reviewed-by: Caolán McNamara diff --git a/svx/source/tbxctrls/PaletteManager.cxx b/svx/source/tbxctrls/PaletteManager.cxx index 141938d145d7..7735e09d44e8 100644 --- a/svx/source/tbxctrls/PaletteManager.cxx +++ b/svx/source/tbxctrls/PaletteManager.cxx @@ -209,6 +209,9 @@ void PaletteManager::ReloadColorSet(SvxColorValueSet ) rColorSet.Clear(); sal_uInt16 nItemId = 0; +if (!pColorSet) +return; + svx::ThemeColorPaletteManager aThemeColorManager(pColorSet); moThemePaletteCollection = aThemeColorManager.generate();
[Libreoffice-bugs] [Bug 66241] FILEOPEN: cannot open file
https://bugs.documentfoundation.org/show_bug.cgi?id=66241 --- Comment #10 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f95c213cc9107e25f78e25c6a1bdfb8a5a61be2a crashtesting: crash seen on exporting fdo66241-1.ods to xlsx It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 66241] FILEOPEN: cannot open file
https://bugs.documentfoundation.org/show_bug.cgi?id=66241 Commit Notification changed: What|Removed |Added Whiteboard|target:4.2.0|target:4.2.0 target:24.2.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/source
sc/source/filter/inc/XclExpChangeTrack.hxx |7 +++
sc/source/filter/xcl97/XclExpChangeTrack.cxx | 23 ++-
2 files changed, 29 insertions(+), 1 deletion(-)
New commits:
commit f95c213cc9107e25f78e25c6a1bdfb8a5a61be2a
Author: Caolán McNamara
AuthorDate: Sun Jun 25 11:54:07 2023 +0100
Commit: Caolán McNamara
CommitDate: Sun Jun 25 14:09:35 2023 +0200
crashtesting: crash seen on exporting fdo66241-1.ods to xlsx
Change-Id: I730bd782ddf67555c40651aed1442465574a1c01
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153560
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sc/source/filter/inc/XclExpChangeTrack.hxx
b/sc/source/filter/inc/XclExpChangeTrack.hxx
index 9d007ba368f3..9701ba6e29f5 100644
--- a/sc/source/filter/inc/XclExpChangeTrack.hxx
+++ b/sc/source/filter/inc/XclExpChangeTrack.hxx
@@ -28,6 +28,7 @@
#include "xestring.hxx"
#include "excrecds.hxx"
#include "xlformula.hxx"
+#include "xllink.hxx"
#include "xeformula.hxx"
class ExcXmlRecord : public ExcRecord
@@ -365,6 +366,7 @@ protected:
static inline void Write2DAddress( XclExpStream& rStrm, const
ScAddress& rAddress );
static inline void Write2DRange( XclExpStream& rStrm, const
ScRange& rRange );
inline sal_uInt16 GetTabId( SCTAB nTabId ) const;
+inline bool IsDeletedTab( SCTAB nTab ) const;
inline void WriteTabId( XclExpStream& rStrm, SCTAB nTabId
) const;
// save header data, call SaveActionData()
@@ -421,6 +423,11 @@ inline void XclExpChTrAction::Write2DRange( XclExpStream&
rStrm, const ScRange&
<< static_cast(rRange.aEnd.Col());
}
+inline bool XclExpChTrAction::IsDeletedTab(SCTAB nTab) const
+{
+return rTabInfo.GetXclTab(nTab) == EXC_TAB_DELETED;
+}
+
inline sal_uInt16 XclExpChTrAction::GetTabId( SCTAB nTab ) const
{
return rIdBuffer.GetId( rTabInfo.GetXclTab( nTab ) );
diff --git a/sc/source/filter/xcl97/XclExpChangeTrack.cxx
b/sc/source/filter/xcl97/XclExpChangeTrack.cxx
index 57fd143bf659..71156df08e04 100644
--- a/sc/source/filter/xcl97/XclExpChangeTrack.cxx
+++ b/sc/source/filter/xcl97/XclExpChangeTrack.cxx
@@ -573,7 +573,7 @@ void XclExpChTrTabIdBuffer::InitFillup()
sal_uInt16 XclExpChTrTabIdBuffer::GetId( sal_uInt16 nIndex ) const
{
-OSL_ENSURE( nIndex < nBufSize, "XclExpChTrTabIdBuffer::GetId - out of
range" );
+assert(nIndex < nBufSize && "XclExpChTrTabIdBuffer::GetId - out of range");
return pBuffer[ nIndex ];
}
@@ -1025,6 +1025,13 @@ static void lcl_WriteCell( XclExpXmlStream& rStrm,
sal_Int32 nElement, const ScA
void XclExpChTrCellContent::SaveXml( XclExpXmlStream& rRevisionLogStrm )
{
+if (IsDeletedTab(aPosition.Tab()))
+{
+// seen on attempt to export tdf66241-1.ods to xlsx
+SAL_WARN("sc", "XclExpChTrCellContent: unable to export position with
tab of EXC_TAB_DELETED");
+return;
+}
+
sax_fastparser::FSHelperPtr pStream = rRevisionLogStrm.GetCurrentStream();
pStream->startElement( XML_rcc,
XML_rId,OString::number(GetActionNumber()),
@@ -1155,6 +1162,13 @@ static const char* lcl_GetAction( sal_uInt16 nOpCode )
void XclExpChTrInsert::SaveXml( XclExpXmlStream& rRevisionLogStrm )
{
+if (IsDeletedTab(aRange.aStart.Tab()))
+{
+// seen on attempt to export tdf66241-1.ods to xlsx
+SAL_WARN("sc", "XclExpChTrCellContent: unable to export position with
tab of EXC_TAB_DELETED");
+return;
+}
+
sax_fastparser::FSHelperPtr pStream = rRevisionLogStrm.GetCurrentStream();
pStream->startElement( XML_rrc,
XML_rId,OString::number(GetActionNumber()),
@@ -1279,6 +1293,13 @@ std::size_t XclExpChTrMoveRange::GetActionByteCount()
const
void XclExpChTrMoveRange::SaveXml( XclExpXmlStream& rRevisionLogStrm )
{
+if (IsDeletedTab(aDestRange.aStart.Tab()) ||
IsDeletedTab(aSourceRange.aStart.Tab()))
+{
+// seen on attempt to export tdf66241-1.ods to xlsx
+SAL_WARN("sc", "XclExpChTrCellContent: unable to export position with
tab of EXC_TAB_DELETED");
+return;
+}
+
sax_fastparser::FSHelperPtr pStream = rRevisionLogStrm.GetCurrentStream();
pStream->startElement( XML_rm,
