[Libreoffice-bugs] [Bug 144256] Missing destruction of FirebirdDriver::~FirebirdDriver, OSDBCDriverManager::~OSDBCDriverManager, OPoolCollection::~OPoolCollection opening and closing an ODB

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144256

--- Comment #8 from Commit Notification 
 ---
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1c15934170341bbcfb4671fdbb01c2259265b3e1

Related tdf#144256: remove m_pSharedConnectionManager

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144256] Missing destruction of FirebirdDriver::~FirebirdDriver, OSDBCDriverManager::~OSDBCDriverManager, OPoolCollection::~OPoolCollection opening and closing an ODB

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144256

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:24.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: dbaccess/source

[Julien Nabet (via logerrit)]

 dbaccess/source/core/dataaccess/ModelImpl.cxx  |3 -
 dbaccess/source/core/dataaccess/datasource.cxx |   73 -
 dbaccess/source/core/inc/ModelImpl.hxx |   70 ++-
 3 files changed, 68 insertions(+), 78 deletions(-)

New commits:
commit 1c15934170341bbcfb4671fdbb01c2259265b3e1
Author: Julien Nabet 
AuthorDate: Wed Oct 18 10:45:36 2023 +0200
Commit: Mike Kaganski 
CommitDate: Thu Oct 19 07:45:34 2023 +0200

Related tdf#144256: remove m_pSharedConnectionManager

to only use "m_xSharedConnectionManager".
For this, it required some refactoring but except the removing, logic 
hasn't been changed.

Change-Id: Iccfe5c45381f31019a0751a61cea6661c88188f1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158107
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/dbaccess/source/core/dataaccess/ModelImpl.cxx 
b/dbaccess/source/core/dataaccess/ModelImpl.cxx
index 3e21289dbe9a..66f8309ac657 100644
--- a/dbaccess/source/core/dataaccess/ModelImpl.cxx
+++ b/dbaccess/source/core/dataaccess/ModelImpl.cxx
@@ -370,7 +370,6 @@ ODatabaseModelImpl::ODatabaseModelImpl( const Reference< 
XComponentContext >& _r
 ,m_bModified(false)
 ,m_bDocumentReadOnly(false)
 ,m_bMacroCallsSeenWhileLoading(false)
-,m_pSharedConnectionManager(nullptr)
 ,m_nControllerLockCount(0)
 {
 // some kind of default
@@ -401,7 +400,6 @@ ODatabaseModelImpl::ODatabaseModelImpl(
 ,m_bModified(false)
 ,m_bDocumentReadOnly(false)
 ,m_bMacroCallsSeenWhileLoading(false)
-,m_pSharedConnectionManager(nullptr)
 ,m_nControllerLockCount(0)
 {
 impl_construct_nothrow();
@@ -624,7 +622,6 @@ void ODatabaseModelImpl::clearConnections()
 }
 }
 
-m_pSharedConnectionManager = nullptr;
 m_xSharedConnectionManager = nullptr;
 }
 
diff --git a/dbaccess/source/core/dataaccess/datasource.cxx 
b/dbaccess/source/core/dataaccess/datasource.cxx
index e2c02d49c818..55c161b854d1 100644
--- a/dbaccess/source/core/dataaccess/datasource.cxx
+++ b/dbaccess/source/core/dataaccess/datasource.cxx
@@ -62,7 +62,6 @@
 #include 
 #include 
 #include 
-#include 
 
 #include 
 #include 
@@ -250,69 +249,6 @@ void SAL_CALL 
OAuthenticationContinuation::setRememberAccount( RememberAuthentic
 SAL_WARN("dbaccess","OAuthenticationContinuation::setRememberAccount: not 
supported!");
 }
 
-namespace {
-
-/** The class OSharedConnectionManager implements a structure to share 
connections.
-It owns the master connections which will be disposed when the last 
connection proxy is gone.
-*/
-// need to hold the digest
-struct TDigestHolder
-{
-sal_uInt8 m_pBuffer[RTL_DIGEST_LENGTH_SHA1];
-TDigestHolder()
-{
-m_pBuffer[0] = 0;
-}
-
-};
-
-}
-
-class OSharedConnectionManager : public ::cppu::WeakImplHelper< XEventListener 
>
-{
-
- // contains the currently used master connections
-struct TConnectionHolder
-{
-Reference< XConnection >xMasterConnection;
-oslInterlockedCount nALiveCount;
-};
-
-// the less-compare functor, used for the stl::map
-struct TDigestLess
-{
-bool operator() (const TDigestHolder& x, const TDigestHolder& y) const
-{
-sal_uInt32 i;
-for(i=0;i < RTL_DIGEST_LENGTH_SHA1 && (x.m_pBuffer[i] >= 
y.m_pBuffer[i]); ++i)
-;
-return i < RTL_DIGEST_LENGTH_SHA1;
-}
-};
-
-typedef std::map< TDigestHolder,TConnectionHolder,TDigestLess>
TConnectionMap;  // holds the master connections
-typedef std::map< Reference< XConnection >,TConnectionMap::iterator>  
TSharedConnectionMap;// holds the shared connections
-
-::osl::Mutexm_aMutex;
-TConnectionMap  m_aConnections; // remember the master 
connection in conjunction with the digest
-TSharedConnectionMapm_aSharedConnection;// the shared 
connections with conjunction with an iterator into the connections map
-Reference< XProxyFactory >  m_xProxyFactory;
-
-protected:
-virtual ~OSharedConnectionManager() override;
-
-public:
-explicit OSharedConnectionManager(const Reference< XComponentContext >& 
_rxContext);
-
-void SAL_CALL disposing( const css::lang::EventObject& Source ) override;
-Reference getConnection(   const OUString& url,
-const OUString& user,
-const OUString& password,
-const Sequence< PropertyValue >& 
_aInfo,
-ODatabaseSource* _pDataSource);
-void addEventListener(const Reference& _rxConnection, 
TConnectionMap::iterator const & _rIter);
-};
-
 OSharedConnectionManager::OSharedConnectionManager(const Reference< 
XComponentContext >& _rxContext)
 {
 

[Libreoffice-bugs] [Bug 157818] Background color not visible in sidebar-styles-preview

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157818

--- Comment #7 from fed...@gmail.com ---
Created attachment 190289
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190289=edit
version 7.6 - the same problem

version 7.6 the same problem

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157818] Background color not visible in sidebar-styles-preview

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157818

--- Comment #6 from fed...@gmail.com ---
(In reply to Dieter from comment #1)
> fedfue, could you please retest with LO 7.6 and in SafeMode?
> Thank you.
> => NEEDINFO

Version 7.6.2_Win_x86-64, the same problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 157482] Turn Security Warnings popup windows into infobars

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157482

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g
 Status|RESOLVED|VERIFIED

--- Comment #12 from BogdanB  ---
Thanks, Balazs Varga, it works for all 4 cases.

Verified with
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 0875594b381e2765f2b6413074c470f9eec33201
CPU threads: 16; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 157820] Command line argument does not accept Windows \\?\ path prefix

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157820

--- Comment #6 from Federico Gallo  ---
I actually don't know if Libreoffice provide the dialog or just call the file
explorer (that seems to be the right thing to do nowadays at least on linux).
I'm not even using Windows. 
You don't have to provide that information if you don't want to, I'm not the
person that will work on this

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: xmloff/inc

[Aml-Hassan-Abd-El-hamid (via logerrit)]

 xmloff/inc/XMLEmbeddedObjectExportFilter.hxx |5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

New commits:
commit e0fd924cb3446f2c707ea173adc5b1aa81ac81c5
Author: Aml-Hassan-Abd-El-hamid 
AuthorDate: Tue Oct 17 07:42:13 2023 +0300
Commit: Ilmari Lauhakangas 
CommitDate: Thu Oct 19 06:39:35 2023 +0200

tdf#143148 Use pragma once instead of include guards

Change-Id: I6f6f69cc97fada3ca3bbdead24c10f9099ff28b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158068
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 

diff --git a/xmloff/inc/XMLEmbeddedObjectExportFilter.hxx 
b/xmloff/inc/XMLEmbeddedObjectExportFilter.hxx
index c21321321af6..cfbe5d9e7572 100644
--- a/xmloff/inc/XMLEmbeddedObjectExportFilter.hxx
+++ b/xmloff/inc/XMLEmbeddedObjectExportFilter.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef XMLOFF_INC_XMLEMBEDDEDOBJECTEXPORTFILTER_HXX
-#define XMLOFF_INC_XMLEMBEDDEDOBJECTEXPORTFILTER_HXX
+#pragma once
 
 #include 
 #include 
@@ -66,6 +65,4 @@ public:
 
 };
 
-#endif // XMLOFF_INC_XMLEMBEDDEDOBJECTEXPORTFILTER_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

[Libreoffice-bugs] [Bug 143148] Use pragma once instead of include guards (Episode 2: Endgame)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143148

--- Comment #106 from Commit Notification 
 ---
Aml-Hassan-Abd-El-hamid committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e0fd924cb3446f2c707ea173adc5b1aa81ac81c5

tdf#143148 Use pragma once instead of include guards

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157820] Command line argument does not accept Windows \\?\ path prefix

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157820

--- Comment #5 from Federico Gallo  ---
I see. But again it was just a suggestion. That's all (I might be wrong).

Can you reproduce this also using the Open File dialog provided by Libreoffice?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157818] Background color not visible in sidebar-styles-preview

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157818

Dieter  changed:

   What|Removed |Added

 Status|REOPENED|NEEDINFO

--- Comment #5 from Dieter  ---
So there is still the question, if it works with 7.6.? Could you please test
and provide Feedback?
=> NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157802] Extra heading number when recording changes and copying headings

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157802

--- Comment #6 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157605] Table rows are split into several lines when copying the table from Writer to another program

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157605

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157600] Feature request: Ability to selectively show and hide keys in legend

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157600

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157802] Extra heading number when recording changes and copying headings

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157802

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153149] LibreOffice Writer and Calc buttons group is mixed in taskbar of Debian 11.6 KDE

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153149

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154291] I'm editing a doc. then sudenly the pgm freeze, then quit, no saving of the work pending

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=154291

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154291] I'm editing a doc. then sudenly the pgm freeze, then quit, no saving of the work pending

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=154291

--- Comment #3 from QA Administrators  ---
Dear Luc,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153149] LibreOffice Writer and Calc buttons group is mixed in taskbar of Debian 11.6 KDE

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153149

--- Comment #6 from QA Administrators  ---
Dear dragospacher,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153139] Incorrect calculation of times

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153139

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152856] Problem in editing Hindi Text in Writer.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152856

--- Comment #10 from QA Administrators  ---
Dear Premdayal Gupta,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152856] Problem in editing Hindi Text in Writer.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152856

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153139] Incorrect calculation of times

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153139

--- Comment #8 from QA Administrators  ---
Dear apprendista.programmatore+Bugzilla,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154948] The color gradation in objects does not function.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=154948

--- Comment #2 from QA Administrators  ---
Dear Ito,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154944] [ feature request ] please improve the tabbed interface

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=154944

--- Comment #5 from QA Administrators  ---
Dear yogilok,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151304] Cursor position error.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151304

--- Comment #15 from QA Administrators  ---
Dear Frants,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 96672] Outgoing mail server password in clear text inside the registrymodifications.xcu file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96672

--- Comment #9 from QA Administrators  ---
Dear michele,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 46959] PRINTING: Combination of Narrow Coloured Cell Border and Grid does not print correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46959

--- Comment #13 from QA Administrators  ---
Dear Jeff Evans,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142749] Animation effect settings don't default to/persist the last chosen values

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142749

--- Comment #4 from QA Administrators  ---
Dear Eyal Rozenberg,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145186] Base Form can not access hidden filtered table when 'Content type' is a table and form is set "Analyze SQL" → 'yes'

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145186

--- Comment #12 from QA Administrators  ---
Dear intmail01,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 130704] Auto-correct punctuation change alters character style to its left

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130704

--- Comment #2 from QA Administrators  ---
Dear Luke Kendall,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 111949] MAILMERGE: Wizards 3rd step page should change title according to the document type selected in 2nd step

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111949

--- Comment #6 from QA Administrators  ---
Dear Gabor Kelemen (allotropia),

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157820] Command line argument does not accept Windows \\?\ path prefix

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157820

--- Comment #4 from Bernd Wechner  ---
But it can be replicated.  Create a path longer than 256 chars, drop a CSV file
there. Right-click in Windows explorer and click Open With and from there click
wherever you need to, to browse for an exe, and find LibreOfficeCalc.exe,
select that. 

You will find on Windows 11 (and probably older versions too) LibreOffice Calc
will not open the CSV.

Move the CSV file to a path less than 255 chars long, and repeat. You will find
it does open CSV.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140202] [META] Issues with files in MS Office formats created by external producers (not MS Office)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140202
Bug 140202 depends on bug 140910, which changed state.

Bug 140910 Summary: Blank XLSX file generated with OpenXML SDK
https://bugs.documentfoundation.org/show_bug.cgi?id=140910

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|NOTOURBUG   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140910] Blank XLSX file generated with OpenXML SDK

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140910

Aron Budea  changed:

   What|Removed |Added

 Ever confirmed|0   |1
   Priority|medium  |low
 OS|Windows (All)   |All
 Resolution|NOTOURBUG   |---
 Status|RESOLVED|NEW

--- Comment #17 from Aron Budea  ---
Excel opens the file and shows it as expected, and since that is the reference
for OOXML files, Calc should do the same, regardless whether the file conforms
to the standard or not.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157821] New: Non-continous lines are not right rendered in SVG(Z) files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157821

Bug ID: 157821
   Summary: Non-continous lines are not right rendered in SVG(Z)
files
   Product: LibreOffice
   Version: 7.6.2.1 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: adonis...@gmail.com

Created attachment 190288
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190288=edit
Here, three lines shouldn't be continuous, but pointed/discontinuous

When I try to export some draw(s) made in LibreOffice Draw, non-continous lines
are rendered as continous lines. This was tested with SVG and SVGZ formats. The
problem doesn't affect EPS, PDF neither EMF formats.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157820] Command line argument does not accept Windows \\?\ path prefix

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157820

--- Comment #3 from Federico Gallo  ---
If this issue cannot be replicated, I would suggest to highlight it's not a
standard installation. Just a suggestion

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157818] Background color not visible in sidebar-styles-preview

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157818

--- Comment #4 from fed...@gmail.com ---
Created attachment 190287
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190287=edit
Example on version 7472 (ok) and 7571 (error)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157820] Command line argument does not accept Windows \\?\ path prefix

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157820

--- Comment #2 from Bernd Wechner  ---
I should add this prefix and its meaning is discussed here, with references to
MS source docs:

https://stackoverflow.com/questions/21194530/what-does-mean-when-prepended-to-a-file-path

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157820] Command line argument does not accept Windows \\?\ path prefix

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157820

Bernd Wechner  changed:

   What|Removed |Added

Version|7.3.4.2 release |7.6.2.1 release

--- Comment #1 from Bernd Wechner  ---
Confirmed the bug exists in 7.6.2.1 as well. No surprise.

It reports as:

LibreOffice 7.6.2.1 56f7684011345957bbf33a7ee678afaf4d2ba333

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157820] New: Command line argument does not accept Windows \\?\ path prefix

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157820

Bug ID: 157820
   Summary: Command line argument does not accept Windows \\?\
path prefix
   Product: LibreOffice
   Version: 7.3.4.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bwech...@yahoo.com

Description:
I have used Libre Calc on Windows 11 as the default app for opening .csv files
for some while. Out of the blue, it stopped working. 

I looked the command up in the Windows registry and tried to duplicate it in a
PowerShell using the path that a right-click>Copy as path gets me from the
Windows explorer. Turns out, the file path was prepended with \\?\. Running
Calc with that as an argument sees Calc end silently and do nothing. If I
remove this prefix, Calc opens the CSV file and all is good. 

Turns out this prefix is used (as is \\?\UNC\) by the Windows API when paths
are longer than some erstwhile path length limit to flag to users that it's a
long one.

Alas, LibreOffice is unaware of the convention. No surprise there. But given
any cross-platform app has to accommodate filesystem idiosyncrasies across
those systems. And it seems this is any easy thing to accommodate and arguably
should for smooth cross-platform functioning (i.e helping me overcome internal
resistance to using LibreOffice here - but alas it is simply way better than
excel in so many subtle ways I am always drawn to it).

Steps to Reproduce:
1. Try top open a file in LibreOffice from the command line by using a long
path that Windows Copy as path provides with a \\?\ prefix.
2. Try again, removing that prefix.


Actual Results:
The file is not opened. 

Expected Results:
The file opens.


Reproducible: Always


User Profile Reset: No

Additional Info:
I clearly don't have the latest version, but am constrained to use portable
versions (thanks to PortableApps). I will see if they have a later one and be
back and close this if it happens to be fixed of course. Opted for file first
as I searched Bugzilla for "\\?\" and found nothing so I doubt this has ever
been spotted to be honest. It arises only with very long paths. I don't know
the exact length, but the one I'm using has 278 chars so I imagine this prefix
kicks in at 256 and longer.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157818] Background color not visible in sidebar-styles-preview

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157818

fed...@gmail.com changed:

   What|Removed |Added

 Resolution|DUPLICATE   |---
 Status|RESOLVED|REOPENED

--- Comment #3 from fed...@gmail.com ---
(In reply to m.a.riosv from comment #2)
> 
> *** This bug has been marked as a duplicate of bug 119729 ***

Bug 119729 seems to talk about "drawing styles", I mean 'styles' [Ctrl Alt 2]
-> 'a' icon ('Character styles') (similar to CSS class styles).
It works in version 7.4.7.2, it stopped working in 7.5.7.1 (and I think it
happened a few years ago too, and then they fixed it).

-- 
You are receiving this mail because:
You are the assignee for the bug.

Aml license statement

[Aml Hassan]

 All of my past & future contributions to LibreOffice may be
   licensed under the MPLv2/LGPLv3+ dual license.

[Libreoffice-bugs] [Bug 119729] Drawing styles at the sidebar lack of background and border color

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=119729

m.a.riosv  changed:

   What|Removed |Added

 CC||fed...@gmail.com

--- Comment #7 from m.a.riosv  ---
*** Bug 157818 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157818] Background color not visible in sidebar-styles-preview

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157818

m.a.riosv  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||miguelangelrv@libreoffice.o
   ||rg
 Status|NEEDINFO|RESOLVED

--- Comment #2 from m.a.riosv  ---


*** This bug has been marked as a duplicate of bug 119729 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: desktop/source sfx2/source

[Pranam Lashkari (via logerrit)]

 desktop/source/lib/init.cxx  |3 ++-
 sfx2/source/control/unoctitm.cxx |3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

New commits:
commit b83f069101f1e6d8aaac09a805f02bbc4c619e7a
Author: Pranam Lashkari 
AuthorDate: Wed Jul 26 16:39:49 2023 +0700
Commit: Pranam Lashkari 
CommitDate: Wed Oct 18 23:57:18 2023 +0200

LOK: send state of protected cells

Change-Id: I432a3af50b6089faa80a28804d95d816af6cd278
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154936
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Szymon Kłos 
Reviewed-by: Pranam Lashkari 
(cherry picked from commit 5f13751cefd725cb2a38e66c9484046e6141c6c2)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158150
Tested-by: Jenkins

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 6d9697d60aed..416265df4099 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -3842,7 +3842,8 @@ static void doc_iniUnoCommands ()
 OUString(".uno:InsertDropdownContentControl"),
 OUString(".uno:InsertPlainTextContentControl"),
 OUString(".uno:InsertPictureContentControl"),
-OUString(".uno:DataFilterAutoFilter")
+OUString(".uno:DataFilterAutoFilter"),
+OUString(".uno:CellProtection")
 };
 
 util::URL aCommandURL;
diff --git a/sfx2/source/control/unoctitm.cxx b/sfx2/source/control/unoctitm.cxx
index 89e94caff794..1f3f37f5fc1b 100644
--- a/sfx2/source/control/unoctitm.cxx
+++ b/sfx2/source/control/unoctitm.cxx
@@ -935,7 +935,8 @@ static void InterceptLOKStateChangeEvent(sal_uInt16 nSID, 
SfxViewFrame* pViewFra
 aEvent.FeatureURL.Path == "SpacePara1" ||
 aEvent.FeatureURL.Path == "SpacePara15" ||
 aEvent.FeatureURL.Path == "SpacePara2" ||
-aEvent.FeatureURL.Path == "DataFilterAutoFilter")
+aEvent.FeatureURL.Path == "DataFilterAutoFilter" ||
+aEvent.FeatureURL.Path == "CellProtection")
 {
 bool bTemp = false;
 aEvent.State >>= bTemp;

[Libreoffice-bugs] [Bug 157301] Writer: repeat first column of a table on subsequent pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157301

--- Comment #3 from Eyal Rozenberg  ---
(In reply to Stéphane Guillou (stragu) from comment #1)
> I understand such a feature would depend on the ability of a table splitting
> columns across pages as opposed to splitting rows

Well, not necessarily. One could image a user doing the column-splitting
themselves, apriori, but wanting the first column repeated.

Example: A daily itinerary table, with different days on different pages. First
column(s) should an hour range.


Also, if this is implemented, remember the directions:

* Of the table
* Of the page
* Of the paragraph

and decide which of these should affect which column gets repeated. Probably
the table direction.

Also remember that, currently, the direction property of the table is labeled
"Text direction" - even though it's not just the text direction (bug 157819).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 157301] Writer: repeat first column of a table on subsequent pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157301

--- Comment #3 from Eyal Rozenberg  ---
(In reply to Stéphane Guillou (stragu) from comment #1)
> I understand such a feature would depend on the ability of a table splitting
> columns across pages as opposed to splitting rows

Well, not necessarily. One could image a user doing the column-splitting
themselves, apriori, but wanting the first column repeated.

Example: A daily itinerary table, with different days on different pages. First
column(s) should an hour range.


Also, if this is implemented, remember the directions:

* Of the table
* Of the page
* Of the paragraph

and decide which of these should affect which column gets repeated. Probably
the table direction.

Also remember that, currently, the direction property of the table is labeled
"Text direction" - even though it's not just the text direction (bug 157819).

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 157819] New: Table direction labeled "text direction", even though it's not just that

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157819

Bug ID: 157819
   Summary: Table direction labeled "text direction", even though
it's not just that
   Product: LibreOffice
   Version: 6.0.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: trivial
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: eyalr...@gmx.com

The Table pane of the Table | Properties... dialog has a "Properties" section,
with the control:

Text Direction: [  ...   ]


That control doesn't only control the superordinate-object direction for table
cells. It is the _table_ direction, controlling for example which side of the
table the first column is placed at, and in which direction the columns
progress. If you flip the direction - the entire table flips, i.e. the first
column is exchanged with the last etc.

So, it's a mis-labeling.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157608] FORMATTING: In the Table of Contents, style switches to italic after an accentuated character.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157608

Dieter  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #2 from Dieter  ---
Tjank you for reporting the bug. It seems you are using an old Version of LO.
Could you please retest with LO 7.6?
=> NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157818] Background color not visible in sidebar-styles-preview

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157818

Dieter  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157818] Background color not visible in sidebar-styles-preview

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157818

Dieter  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de

--- Comment #1 from Dieter  ---
fedfue, could you please retest with LO 7.6 and in SafeMode?
Thank you.
=> NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: LLVM exit code 139 building git master on Xubuntu 22.04

[David Gerard]

On Tue, 17 Oct 2023 at 21:33, David Gerard  wrote:

> I pulled from git master today to build LO and got LLVM exit code 139
> - an error code I can't find the meaning of, but it's apparently an
> internal error.

I just tried again from a completely fresh git clone, and it's still
happening. Any ideas? Is there anything in the new C++20 conf that's
too new for llvm 14.0.0 Ubuntu version?


- d.

[Libreoffice-bugs] [Bug 151514] Sounds attached to Impress slides are shortened during presentation if MP3 audio quality is low

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151514

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #12 from Stéphane Guillou (stragu) 
 ---
David, were you able to test again with version 7.5 or 7.6, and with the codecs
recommended by Buovjaga?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - desktop/source sfx2/source

[Pranam Lashkari (via logerrit)]

 desktop/source/lib/init.cxx  |3 ++-
 sfx2/source/control/unoctitm.cxx |3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

New commits:
commit f3c956ae8825abab59e7dbc1e39da4f5d4a1658c
Author: Pranam Lashkari 
AuthorDate: Wed Jul 26 16:39:49 2023 +0700
Commit: Pranam Lashkari 
CommitDate: Wed Oct 18 22:54:06 2023 +0200

LOK: send state of protected cells

Change-Id: I432a3af50b6089faa80a28804d95d816af6cd278
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154936
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Szymon Kłos 
Reviewed-by: Pranam Lashkari 

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 5b50b0d8181c..d4b507004a9d 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -3846,7 +3846,8 @@ static void doc_iniUnoCommands ()
 OUString(".uno:InsertDropdownContentControl"),
 OUString(".uno:InsertPlainTextContentControl"),
 OUString(".uno:InsertPictureContentControl"),
-OUString(".uno:DataFilterAutoFilter")
+OUString(".uno:DataFilterAutoFilter"),
+OUString(".uno:CellProtection")
 };
 
 util::URL aCommandURL;
diff --git a/sfx2/source/control/unoctitm.cxx b/sfx2/source/control/unoctitm.cxx
index fad61699db90..73d2d88ddc1b 100644
--- a/sfx2/source/control/unoctitm.cxx
+++ b/sfx2/source/control/unoctitm.cxx
@@ -951,7 +951,8 @@ static void InterceptLOKStateChangeEvent(sal_uInt16 nSID, 
SfxViewFrame* pViewFra
 aEvent.FeatureURL.Path == "SpacePara1" ||
 aEvent.FeatureURL.Path == "SpacePara15" ||
 aEvent.FeatureURL.Path == "SpacePara2" ||
-aEvent.FeatureURL.Path == "DataFilterAutoFilter")
+aEvent.FeatureURL.Path == "DataFilterAutoFilter" ||
+aEvent.FeatureURL.Path == "CellProtection")
 {
 bool bTemp = false;
 aEvent.State >>= bTemp;

[Libreoffice-bugs] [Bug 157818] New: Background color not visible in sidebar-styles-preview

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157818

Bug ID: 157818
   Summary: Background color not visible in sidebar-styles-preview
   Product: LibreOffice
   Version: 7.5.7.1 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: fed...@gmail.com

Description:
In 'sidebar > Syles > Character styles', with 'Show previews' checked, the
styles with a background color do not show it in the preview of this sidebar
(in 'Paragraph style' it works fine) (in previous versions it worked fine). 

Steps to Reproduce:
1.Open LibreOffice Writer.
2.open the sidebar.
3.go to the 'Character style' tab.
4.check 'show previews' at the bottom of the sidebar.
5.Create a style and assign it a background color. 
6. apply that style to a text.

Actual Results:
On the page, the text will be displayed with background color, but in the
sidebar it will not.

Expected Results:
You should see the background color in the (as in previous versions) 


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.5.7.1 (X86_64) / LibreOffice Community
Build ID: 47eb0cf7efbacdee9b19ae25d6752381ede23126
CPU threads: 6; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win
Locale: en-GB (en_GB); UI: en-GB
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157746] Multi-column text frame in footnote at end of document will not wrap or break text to the second column

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157746

--- Comment #6 from bianca.chior...@altom.com ---
Hello William, I was able to reproduce the bug using the steps you described,
also on MacOS: 

Version: 7.6.2.1 (X86_64) / LibreOffice Community
Build ID: 56f7684011345957bbf33a7ee678afaf4d2ba333
CPU threads: 8; OS: Mac OS X 14.0; UI render: Skia/Metal; VCL: osx
Locale: en-US (en_RO.UTF-8); UI: en-US
Calc: threaded


Besides your steps I did some further investigations that might be helpful for
having a better overview of this bug.  (The following tests except the last
one, were executed on the configurations listed above)

1. Instead of ‘Relative to Entire paragraph area’ width (step 3)
   a. I did set it to ‘Relative to Entire page with an 80% percentage  ->  The 
  behavior was the same 
   b. I also left the ‘Relative to’ unchecked -> the result was the same  
   c. And I also checked the AutoSize checkbox and created the Frame in that
way - 
  > The behavior was the same —> Which means that these variables(‘Relative 
  to’ and ‘AutoSize’) are not influencing the results nor does the value of 
  the width. 

2. I did try to reproduce the bug with a Frame that has 3 columns instead of
two -> The behavior was the same -> Any number of columns greater than one
returns the same result 

3. I added data in both columns before changing the Position of the Footbar
from ‘End of the Page’ to ‘End of the Document’ and what I observed was that
the data from column2 is transferred on a new row to the colum1, and even if
the cursor is able to go to column 2 area, once the user types some characters,
the characters are displayed in column 1 so the column 2 becomes unusable and
the frame acts like it has just one column even if 2 columns can be seen.
Please check the screenshot attached. ('Before', 'After')

4. Regarding the documentation, I read the Footnote & Endnote chapter but I
couldn’t find anything related to the Footnotes having any limitations on
Frames. The documentation that I read can be found at this link:
https://documentation.libreoffice.org/assets/Uploads/Documentation/en/WG7.6/WG76-WriterGuide.pdf

5. Tried to reproduce the bug on other types of documents in LibreOffice (Calc
Spreadsheet, Impress Presentation, Draw Drawing, Math Formula and Base
Database) but none of them offers the possibility of adding a footnote or a
frame so the bug is Writer Document specific

6. I wanted to see if this issue is a new one or it can be found also on older
versions of the app and it seems like it can be reproduced also on version:
6.4.5.2  - 2020 —--> So it doesn’t seem to be a new issue. I also tried older
versions (4.0.0.1, 5.0.0.1 and 6.0.0.1 but they are not compatible with my OS
and the app didn’t open so I can’t say if the issue is not older than 6.0.0.1)


Hope my additions are helpful and let me know if something is unclear and needs
clarification.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157746] Multi-column text frame in footnote at end of document will not wrap or break text to the second column

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157746

--- Comment #5 from bianca.chior...@altom.com ---
Created attachment 190286
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190286=edit
After

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157746] Multi-column text frame in footnote at end of document will not wrap or break text to the second column

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157746

--- Comment #4 from bianca.chior...@altom.com ---
Created attachment 190285
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190285=edit
Before

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143602] Read only from DropBox

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143602

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #6 from Stéphane Guillou (stragu) 
 ---
Josef, do you use AVG or Avast? Does the issue resolve if you deactivate it?
Have you tried a recent version of LibreOffice?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157817] PAC gives "Invalid use of a "P" structure element" with title of multi page TOC

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157817

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

  Regression By||Michael Stahl
 CC||michael.st...@allotropia.de

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157817] PAC gives "Invalid use of a "P" structure element" with title of multi page TOC

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157817

--- Comment #1 from Gabor Kelemen (allotropia)  ---
Created attachment 190284
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190284=edit
Screenshot of the PAC error message and the example file in Writer

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139007] [META] PDF accessibility

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139007

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Depends on||157817


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157817
[Bug 157817] PAC gives "Invalid use of a "P" structure element" with title of
multi page TOC
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157817] New: PAC gives "Invalid use of a "P" structure element" with title of multi page TOC

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157817

Bug ID: 157817
   Summary: PAC gives "Invalid use of a "P" structure element"
with title of multi page TOC
   Product: LibreOffice
   Version: 24.2.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: bibisected, bisected, regression
  Severity: normal
  Priority: medium
 Component: Printing and PDF export
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kelem...@ubuntu.com
Blocks: 139007

Created attachment 190283
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190283=edit
Example file from Writer

Attached example document has a simple TOC that spans two pages.

When exported as a PDF/UA document the PAC tool gives the Logical Structure -
Structure Tree - "P" structure elements - Invalid use of a "P" structure
element
error message. Not if all of the TOC is displayed on the same page.

1. Open attached file
2. Save as PDF, make sure to check the PDF/UA option
3. Open it in the PAC 2021 tool
-> error message

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: e9374f74385d7dfe77d1902d3d82af20143bc775
CPU threads: 15; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: threaded

Seems to have started with

https://git.libreoffice.org/core/+/033e37b49b5712df19dbfd2c307a102bce620de1

author  Michael Stahl  Thu Aug 31 19:50:55
2023 +0200
committer   Caolán McNamara  Tue Sep 26
21:13:18 2023 +0200
tree1abc64b331189c3cadb29faa1c930f731a47d569
parent  8c94442fab9588dd0793a1792979f50a600c4c65 [diff]

sw: PDF/UA export: produce nested Sect SEs for nested sections


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=139007
[Bug 139007] [META] PDF accessibility
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142863] Complete reset of the program to initial default settings, no history

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142863

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||stephane.guillou@libreoffic
   ||e.org
 Resolution|--- |INSUFFICIENTDATA

--- Comment #4 from Stéphane Guillou (stragu) 
 ---
Given the difficulty to reproduce the issue (depending on Windows refusing to
unlock) and the lack of simpler steps, I think we have to close the report as
"insufficient data".
However, if you encounter the issue again in a recent version of LibreOffice
(updating preferably to 7.6) and can provide more information / more precise
steps, please set the report back to "unconfirmed".
Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - vcl/source

[Michael Stahl (via logerrit)]

 vcl/source/pdf/XmpMetadata.cxx |   83 -
 1 file changed, 82 insertions(+), 1 deletion(-)

New commits:
commit 72163db77aa1c160a63e64d5637de4a383966c76
Author: Michael Stahl 
AuthorDate: Wed Oct 18 14:23:48 2023 +0200
Commit: Caolán McNamara 
CommitDate: Wed Oct 18 22:26:36 2023 +0200

tdf#157517 vcl: PDF/UA export: add PDF/A extension schema to XMP

... if PDF/A is also enabled.  Thanks to Peter Wyatt for the example
document.

Change-Id: I2a5951e102ae28a4c998adafe8ab51caa2788e4b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158118
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit a4971aab4d57bf9177c55c3fb0e163e0db7c48fd)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158046
Reviewed-by: Caolán McNamara 

diff --git a/vcl/source/pdf/XmpMetadata.cxx b/vcl/source/pdf/XmpMetadata.cxx
index d4c58c23348b..bbe337de4146 100644
--- a/vcl/source/pdf/XmpMetadata.cxx
+++ b/vcl/source/pdf/XmpMetadata.cxx
@@ -107,8 +107,89 @@ void XmpMetadata::write()
 }
 
 // PDF/UA
-if (mbPDF_UA && mnPDF_A == 0) // veraPDF says this is not allowed in 
PDF/A-[123][ab]
+if (mbPDF_UA)
 {
+if (mnPDF_A != 0)
+{ // tdf#157517 PDF/A extension schema is required
+aXmlWriter.startElement("rdf:Description");
+aXmlWriter.attribute("rdf:about", OString(""));
+aXmlWriter.attribute("xmlns:pdfaExtension",
+ 
OString("http://www.aiim.org/pdfa/ns/extension/;));
+aXmlWriter.attribute("xmlns:pdfaSchema",
+ 
OString("http://www.aiim.org/pdfa/ns/schema#;));
+aXmlWriter.attribute("xmlns:pdfaProperty",
+ 
OString("http://www.aiim.org/pdfa/ns/property#;));
+aXmlWriter.startElement("pdfaExtension:schemas");
+aXmlWriter.startElement("rdf:Bag");
+aXmlWriter.startElement("rdf:li");
+aXmlWriter.attribute("rdf:parseType", OString("Resource"));
+aXmlWriter.startElement("pdfaSchema:namespaceURI");
+aXmlWriter.content("http://www.aiim.org/pdfua/ns/id/;);
+aXmlWriter.endElement();
+aXmlWriter.startElement("pdfaSchema:prefix");
+aXmlWriter.content("pdfuaid");
+aXmlWriter.endElement();
+aXmlWriter.startElement("pdfaSchema:schema");
+aXmlWriter.content("PDF/UA identification schema");
+aXmlWriter.endElement();
+aXmlWriter.startElement("pdfaSchema:property");
+aXmlWriter.startElement("rdf:Seq");
+
+aXmlWriter.startElement("rdf:li");
+aXmlWriter.attribute("rdf:parseType", OString("Resource"));
+aXmlWriter.startElement("pdfaProperty:category");
+aXmlWriter.content("internal");
+aXmlWriter.endElement();
+aXmlWriter.startElement("pdfaProperty:description");
+aXmlWriter.content("PDF/UA version identifier");
+aXmlWriter.endElement();
+aXmlWriter.startElement("pdfaProperty:name");
+aXmlWriter.content("part");
+aXmlWriter.endElement();
+aXmlWriter.startElement("pdfaProperty:valueType");
+aXmlWriter.content("Integer");
+aXmlWriter.endElement();
+aXmlWriter.endElement(); // rdf:li
+
+aXmlWriter.startElement("rdf:li");
+aXmlWriter.attribute("rdf:parseType", OString("Resource"));
+aXmlWriter.startElement("pdfaProperty:category");
+aXmlWriter.content("internal");
+aXmlWriter.endElement();
+aXmlWriter.startElement("pdfaProperty:description");
+aXmlWriter.content("PDF/UA amendment identifier");
+aXmlWriter.endElement();
+aXmlWriter.startElement("pdfaProperty:name");
+aXmlWriter.content("amd");
+aXmlWriter.endElement();
+aXmlWriter.startElement("pdfaProperty:valueType");
+aXmlWriter.content("Text");
+aXmlWriter.endElement();
+aXmlWriter.endElement(); // rdf:li
+
+aXmlWriter.startElement("rdf:li");
+aXmlWriter.attribute("rdf:parseType", OString("Resource"));
+aXmlWriter.startElement("pdfaProperty:category");
+aXmlWriter.content("internal");
+aXmlWriter.endElement();
+aXmlWriter.startElement("pdfaProperty:description");
+aXmlWriter.content("PDF/UA corrigenda identifier");
+aXmlWriter.endElement();
+aXmlWriter.startElement("pdfaProperty:name");
+

[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - sw/source

[Michael Weghorn (via logerrit)]

 sw/source/uibase/uiview/view2.cxx |   17 ++---
 1 file changed, 14 insertions(+), 3 deletions(-)

New commits:
commit 16940dc248068133363153a1c2d41cd2d0102460
Author: Michael Weghorn 
AuthorDate: Wed Oct 18 10:59:33 2023 +0200
Commit: Caolán McNamara 
CommitDate: Wed Oct 18 22:26:15 2023 +0200

tdf#156033 sw: Don't capture mouse when executing file dlg

When the mouse is captured in
`SwView::InsertGraphicDlg`, temporarily
release it while executing the file dialog,
so the user can use the mouse to interact with
the file dialog.

At least with qt5/qt6/kf5, this would otherwise
not work in the file dialog shown after clicking
on a previously inserted Picture Content Control,
because `QWidget::grabMouse()`'s "other widgets
get no mouse events at all" [1] apparently applies
for the file dialog and other running applications
as well.

[1] https://doc.qt.io/qt-6/qwidget.html#grabMouse

Change-Id: I80a81c57c80debc716a1b111a9c07eef0c005c65
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158109
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 
(cherry picked from commit 680ae3e989c3b665b29f536c2e30dd86bbc3edac)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158045
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/sw/source/uibase/uiview/view2.cxx 
b/sw/source/uibase/uiview/view2.cxx
index f7cfb6563803..585f38b7cae1 100644
--- a/sw/source/uibase/uiview/view2.cxx
+++ b/sw/source/uibase/uiview/view2.cxx
@@ -441,11 +441,22 @@ bool SwView::InsertGraphicDlg( SfxRequest& rReq )
 
 const SfxStringItem* pName = 
rReq.GetArg(SID_INSERT_GRAPHIC);
 bool bShowError = !pName;
-if( pName
+
+bool bHaveName = pName != nullptr;
 #if HAVE_FEATURE_DESKTOP
-|| (!Application::IsHeadlessModeEnabled() && ERRCODE_NONE == 
pFileDlg->Execute())
+if (!bHaveName && !Application::IsHeadlessModeEnabled())
+{
+// execute file dialog, without capturing mouse (tdf#156033)
+vcl::Window* pWin = GetWindow();
+const bool bMouseCaptured = pWin && pWin->IsMouseCaptured();
+if (bMouseCaptured)
+pWin->ReleaseMouse();
+bHaveName =  ERRCODE_NONE == pFileDlg->Execute();
+if (bMouseCaptured)
+pWin->CaptureMouse();
+}
 #endif
-)
+if (bHaveName)
 {
 
 OUString aFileName, aFilterName;

[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - drawinglayer/source include/drawinglayer svx/source vcl/qa

[Michael Stahl (via logerrit)]

 drawinglayer/source/primitive2d/controlprimitive2d.cxx |4 
 drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx |   20 
 include/drawinglayer/primitive2d/controlprimitive2d.hxx|8 +
 svx/source/sdr/contact/viewcontactofunocontrol.cxx |9 +
 svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx   |   10 +-
 vcl/qa/cppunit/pdfexport/pdfexport.cxx |   63 +
 6 files changed, 109 insertions(+), 5 deletions(-)

New commits:
commit 2dbbc200e87b472e7a6daf1e1f658496fd569813
Author: Michael Stahl 
AuthorDate: Wed Oct 11 19:13:53 2023 +0200
Commit: Caolán McNamara 
CommitDate: Wed Oct 18 22:23:44 2023 +0200

drawinglayer,svx: PDF/UA export: put Form SE into anchor paragraph SE

This is like commit d467f1aa3d028f399826c97e2eecedcd79efcf65
and commit 6e5d59c2ca6969e9491f97cd7a00d094fc62cfb3 but for the
form controls, which have their own special ControlPrimitive2D.

Change-Id: I4b4ac45e81f490a7b625acd9e8753300d10bf119
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157847
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit d5c19ef9d30cde052e8cd2486ac9395e62d9c9a9)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157874
Reviewed-by: Caolán McNamara 

diff --git a/drawinglayer/source/primitive2d/controlprimitive2d.cxx 
b/drawinglayer/source/primitive2d/controlprimitive2d.cxx
index 372fb61244a0..c8448efa981f 100644
--- a/drawinglayer/source/primitive2d/controlprimitive2d.cxx
+++ b/drawinglayer/source/primitive2d/controlprimitive2d.cxx
@@ -243,10 +243,12 @@ namespace drawinglayer::primitive2d
 uno::Reference< awt::XControlModel > xControlModel,
 uno::Reference xXControl,
 ::std::u16string_view const rTitle,
-::std::u16string_view const rDescription)
+::std::u16string_view const rDescription,
+void const*const pAnchorKey)
 :   maTransform(std::move(aTransform)),
 mxControlModel(std::move(xControlModel)),
 mxXControl(std::move(xXControl))
+, m_pAnchorStructureElementKey(pAnchorKey)
 {
 ::rtl::OUStringBuffer buf(rTitle);
 if (!rTitle.empty() && !rDescription.empty())
diff --git a/drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx 
b/drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
index a5882e8b95cb..5b853d8152c1 100644
--- a/drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
+++ b/drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
@@ -1101,6 +1101,18 @@ void VclMetafileProcessor2D::processControlPrimitive2D(
 if (!bIsPrintableControl)
 return;
 
+::std::optional oAnchorParent;
+if (mpPDFExtOutDevData)
+{
+if (rControlPrimitive.GetAnchorStructureElementKey())
+{
+sal_Int32 const id = mpPDFExtOutDevData->EnsureStructureElement(
+rControlPrimitive.GetAnchorStructureElementKey());
+
oAnchorParent.emplace(mpPDFExtOutDevData->GetCurrentStructureElement());
+mpPDFExtOutDevData->SetCurrentStructureElement(id);
+}
+}
+
 const bool bPDFExport(mpPDFExtOutDevData && 
mpPDFExtOutDevData->GetIsExportFormFields());
 bool bDoProcessRecursively(true);
 
@@ -1153,6 +1165,10 @@ void VclMetafileProcessor2D::processControlPrimitive2D(
 }
 mpPDFExtOutDevData->CreateControl(*pPDFControl);
 mpPDFExtOutDevData->EndStructureElement();
+if (oAnchorParent)
+{
+mpPDFExtOutDevData->SetCurrentStructureElement(*oAnchorParent);
+}
 
 // no normal paint needed (see original 
UnoControlPDFExportContact::do_PaintObject);
 // do not process recursively
@@ -1235,6 +1251,10 @@ void VclMetafileProcessor2D::processControlPrimitive2D(
 if (mpPDFExtOutDevData)
 {
 mpPDFExtOutDevData->EndStructureElement();
+if (oAnchorParent)
+{
+mpPDFExtOutDevData->SetCurrentStructureElement(*oAnchorParent);
+}
 }
 }
 
diff --git a/include/drawinglayer/primitive2d/controlprimitive2d.hxx 
b/include/drawinglayer/primitive2d/controlprimitive2d.hxx
index e33c26886cd9..a7128b7f7322 100644
--- a/include/drawinglayer/primitive2d/controlprimitive2d.hxx
+++ b/include/drawinglayer/primitive2d/controlprimitive2d.hxx
@@ -58,6 +58,9 @@ private:
 /// yet another special snowflake way to generate PDF Alt text
 OUString m_AltText;
 
+/// anchor structure element (Writer)
+void const* const m_pAnchorStructureElementKey;
+
 /** used from getXControl() to create a local awt::XControl which is 
remembered in mxXControl
 and from thereon always used and returned by getXControl()
  */
@@ -81,7 +84,8 @@ public:
 ControlPrimitive2D(basegfx::B2DHomMatrix aTransform,
css::uno::Reference 
xControlModel,
 

[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - vcl/qa vcl/source

[Michael Stahl (via logerrit)]

 vcl/qa/cppunit/pdfexport/data/PDF_export_with_formcontrol.fodt |  174 ++
 vcl/qa/cppunit/pdfexport/pdfexport.cxx |  258 
++
 vcl/source/gdi/pdfextoutdevdata.cxx|   20 
 3 files changed, 448 insertions(+), 4 deletions(-)

New commits:
commit 04dbdc1949e60f4dc674c2e728982af371f2f4da
Author: Michael Stahl 
AuthorDate: Tue Oct 10 18:20:04 2023 +0200
Commit: Caolán McNamara 
CommitDate: Wed Oct 18 22:22:58 2023 +0200

tdf#157397 vcl: PDF export: fix CreateControl replay

The problem is that the CreateLink and CreateControl actions are
replayed in a different order than they are recorded, because CreateLink
is a global action, and CreateControl a page action.

This means that the mCurId at the time when
PDFExtOutDevData::CreateControl() is called does not correspond to a
position in mParaIds when CreateControl is replayed; it will be inserted
too early and bump all the CreateLink ones to later indexes.

Avoid this by adding another global action CreateControlLink that is
added when CreateControl is being replayed, which appears to work.

(Another subtle problem is that, in case of PDF/A-1, the page actions
could be discarded completely; this should work in that case too.)

(regression from commit d4d471fc88fe4fd14f44dfccdfe360dec327d4f0)

Change-Id: I92d89ac08db6548e9f0d1480d984aeacb4d22262
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157767
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit 2e32aa1e9fc240c9cd9854655106d0decbd3694a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157873
Reviewed-by: Caolán McNamara 

diff --git a/vcl/qa/cppunit/pdfexport/data/PDF_export_with_formcontrol.fodt 
b/vcl/qa/cppunit/pdfexport/data/PDF_export_with_formcontrol.fodt
new file mode 100644
index ..4aa4a92b6710
--- /dev/null
+++ b/vcl/qa/cppunit/pdfexport/data/PDF_export_with_formcontrol.fodt
@@ -0,0 +1,174 @@
+
+http://www.w3.org/TR/css3-text/; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:office="urn:oasis:names:tc:opendocument:xmlns:office:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0" 
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:xlink="http://www.w3.org/1999/xlink; 
xmlns:drawooo="http://openoffice.org/2010/draw; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dc="http://purl.org/dc/elements/1.1/; xmlns:c
 alcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0" 
xmlns:style="urn:oasis:names:tc:opendocument:xmlns:style:1.0" 
xmlns:text="urn:oasis:names:tc:opendocument:xmlns:text:1.0" 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:tableooo="http://openoffice.org/2009/table; 
xmlns:draw="urn:oasis:names:tc:opendocument:xmlns:drawing:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:rpt="http://openoffice.org/2005/report; 
xmlns:formx="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0"
 xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:officeooo="http://openoffice.org/2009/office; 
xmlns:table="urn:oasis:names:tc:opendocument:xmlns:table:1.0" 
xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:
 meta:1.0" 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 office:version="1.3" office:mimetype="application/vnd.oasis.opendocument.text">
+ A. 
Spielhoff2020-09-12T10:51:34.4381175712023-10-11T12:40:15.543658302PT7H23M50S98LibreOfficeDev/7.5.7.0.0$Linux_X86_64
 
LibreOffice_project/0325c0aa2d3e6df97ff554ca540d316273fd149a2023-09-23T14:07:35.317591779PDF-Dateien:
 A Spielhoff
+ 
+  
+  
+  
+  
+ 
+  
+   
+   
+
+   
+   
+  
+  
+   
+   
+  
+  
+   
+  
+  
+   
+  
+  
+  
+   
+  
+  
+  
+   
+  
+  
+   
+  
+  
+   
+  
+  
+   
+
+ 
+
+   
+   
+
+ 
+
+   
+   
+
+ 
+
+   
+   
+
+ 
+
+   
+   
+
+ 
+
+   
+   
+
+ 
+
+   
+   
+
+ 
+
+   
+   
+
+ 
+
+   
+   
+
+ 
+
+   
+   
+
+ 
+
+   
+  
+  
+  
+  
+ 
+ 
+  
+   
+  
+  
+   
+  
+  
+   
+  
+  
+   
+   
+  

[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - sw/source

[Michael Stahl (via logerrit)]

 sw/source/core/crsr/crsrsh.cxx |   16 
 sw/source/core/crsr/swcrsr.cxx |   14 +++---
 2 files changed, 27 insertions(+), 3 deletions(-)

New commits:
commit 92d75686181349f4b79aef413a070ab8335f97b9
Author: Michael Stahl 
AuthorDate: Wed Oct 18 15:17:29 2023 +0200
Commit: Caolán McNamara 
CommitDate: Wed Oct 18 22:22:06 2023 +0200

sw: fix stack overflow on kde45196-1.html

Previously, the shell cursor was put onto a SwGrfNode in the top left
corner, which is invalid, but didn't crash immediately.

With commit b20ca8d951e8205c8b963c6b7407f984053b4094 the cursor is
instead put onto the first SwTextNode in the body, which happens to be
in a table, and the entire table is hidden; this causes an infinite
recursion in SwCursorShell::UpdateCursorPos() because
GetModelPositionForViewPoint() no longer moves it to SwGrfNode.

So try to move the cursor out of a hidden node, which requires an
additional change in SwCursor::IsSelOvr() to allow moving from a node
without a frame to another node without a frame.

Change-Id: Ia33c7b558755f7e8b65ea3ff2c46aea20be577dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158119
Tested-by: Michael Stahl 
Reviewed-by: Michael Stahl 
(cherry picked from commit fa4fe53aa775cdc50eec715f4bd88469fe5e0d32)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158048
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sw/source/core/crsr/crsrsh.cxx b/sw/source/core/crsr/crsrsh.cxx
index 84f0ba59072a..04b263cda754 100644
--- a/sw/source/core/crsr/crsrsh.cxx
+++ b/sw/source/core/crsr/crsrsh.cxx
@@ -1803,6 +1803,22 @@ void SwCursorShell::UpdateCursorPos()
 GetLayout()->GetModelPositionForViewPoint( pShellCursor->GetPoint(), 
pShellCursor->GetPtPos(),
   );
 pShellCursor->DeleteMark();
+// kde45196-1.html: try to get to a non-hidden paragraph, there must
+// be one in the document body
+while (isInHiddenTextFrame(pShellCursor))
+{
+if (!pShellCursor->MovePara(GoNextPara, fnParaStart))
+{
+break;
+}
+}
+while (isInHiddenTextFrame(pShellCursor))
+{
+if (!pShellCursor->MovePara(GoPrevPara, fnParaStart))
+{
+break;
+}
+}
 }
 auto* pDoc = GetDoc();
 if (pDoc)
diff --git a/sw/source/core/crsr/swcrsr.cxx b/sw/source/core/crsr/swcrsr.cxx
index 4349fac21b2f..8d0246bed14f 100644
--- a/sw/source/core/crsr/swcrsr.cxx
+++ b/sw/source/core/crsr/swcrsr.cxx
@@ -331,6 +331,7 @@ bool SwCursor::IsSelOvr(SwCursorSelOverFlags const eFlags)
 if( pNd->IsContentNode() && !dynamic_cast(this) )
 {
 const SwContentFrame* pFrame = static_cast(pNd)->getLayoutFrame( 
rDoc.getIDocumentLayoutAccess().GetCurrentLayout() );
+// ^ null
 if ( (SwCursorSelOverFlags::ChangePos & eFlags)   //allowed to change 
position if it's a bad one
 && pFrame && pFrame->isFrameAreaDefinitionValid()
 && !pFrame->getFrameArea().Height() //a bad zero height 
position
@@ -400,9 +401,16 @@ bool SwCursor::IsSelOvr(SwCursorSelOverFlags const eFlags)
 
 if( !pFrame )
 {
-DeleteMark();
-RestoreSavePos();
-return true; // we need a frame
+assert(!m_vSavePos.empty());
+SwContentNode const*const 
pSaveNode(rNds[m_vSavePos.back().nNode]->GetContentNode());
+// if the old position already didn't have a frame, allow moving
+// anyway, hope the caller can handle that
+if (pSaveNode && 
pSaveNode->getLayoutFrame(rDoc.getIDocumentLayoutAccess().GetCurrentLayout()))
+{
+DeleteMark();
+RestoreSavePos();
+return true; // we need a frame
+}
 }
 }
 

[Libreoffice-commits] core.git: cui/source

[Caolán McNamara (via logerrit)]

 cui/source/dialogs/SpellDialog.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e7e5b43c4906d9f0e199f689addc29aa98916e6e
Author: Caolán McNamara 
AuthorDate: Wed Oct 18 16:47:20 2023 +0100
Commit: Caolán McNamara 
CommitDate: Wed Oct 18 22:02:37 2023 +0200

crashreporting: svx::SentenceEditWindow_Impl::CreateSpellPortions()

cui/source/dialogs/SpellDialog.cxx:2005
aRet[ aRet.size() - 1 ].sText += aLeftOverText;

presumably aRet is empty() here

a) don't bother appending if aLeftOverText is empty()
b) don't crah if aRet is empty() and aLeftOverText is not

Change-Id: Ie9a9585f572d8afb17183b479fb6f2cce5952aa7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158124
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/cui/source/dialogs/SpellDialog.cxx 
b/cui/source/dialogs/SpellDialog.cxx
index 1e52d4e2aed3..67de5235d1ad 100644
--- a/cui/source/dialogs/SpellDialog.cxx
+++ b/cui/source/dialogs/SpellDialog.cxx
@@ -2066,7 +2066,7 @@ svx::SpellPortions 
SentenceEditWindow_Impl::CreateSpellPortions() const
 aPortion2.sText = aLeftOverText.makeStringAndClear();
 aRet.push_back( aPortion2 );
 }
-else
+else if (!aLeftOverText.isEmpty() && !aRet.empty())
 {   // we just need to append the left-over text to the last 
portion (which had no errors)
 aRet[ aRet.size() - 1 ].sText += aLeftOverText;
 }

[Libreoffice-bugs] [Bug 157816] PAC gives >"Link" annotation is not nested inside a "Link" structure element< error with references and caption frame

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157816

--- Comment #1 from Gabor Kelemen (allotropia)  ---
Created attachment 190282
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190282=edit
The example file in Writer and its PDF version in PAC tool

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157816] New: PAC gives >"Link" annotation is not nested inside a "Link" structure element< error with references and caption frame

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157816

Bug ID: 157816
   Summary: PAC gives >"Link" annotation is not nested inside a
"Link" structure element< error with references and
caption frame
   Product: LibreOffice
   Version: 24.2.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: bibisected, bisected, regression
  Severity: normal
  Priority: medium
 Component: Printing and PDF export
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kelem...@ubuntu.com
Blocks: 139007

Created attachment 190281
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190281=edit
Example file from Writer 7.6

Attached minimized document contains some text, an image in caption frame and
some cross-references.

When exported as PDF/UA, and checked in PAC 2021 tool there is a "Structure
elements - Annotations" error reported: 
"Link" annotation is not nested inside a "Link" structure element

1. Open attached file 
2. Export as PDF, make sure to enable the PDF/UA option
3. Verify the resulting file in the PAC 2021 tool
-> Error message

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: e9374f74385d7dfe77d1902d3d82af20143bc775
CPU threads: 15; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: threaded

Seems to have started with:

https://git.libreoffice.org/core/+/8497b2f5837bcd7a047d0bd2de842d4b2ef1101b

author  Khaled HosnyThu Sep 07 07:59:49 2023 +0300
committer   Michael Stahl  Thu Sep 14
18:33:51 2023 +0200
treeeba17f106af6642b21e17c813d901b7f08aff4fa
parent  5623a25541925b7389ac8203eb35e3d68485b064 [diff]

tdf#157112: fix off-by-one error in /LastChar of PDF Type 3 fonts


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=139007
[Bug 139007] [META] PDF accessibility
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139007] [META] PDF accessibility

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139007

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Depends on||157816


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157816
[Bug 157816] PAC gives >"Link" annotation is not nested inside a "Link"
structure element< error with references and caption frame
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157748] Macros are not executed.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157748

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO
 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
Do you execute any action between starting the recording and ending it?
Or do you end it right after starting it?

Please also paste here the full version info copied from Help > About
LibreOffice.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107659] [META] Macro bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107659

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||135628


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=135628
[Bug 135628] SendSimpleMailMessage bodytext ends up as multiple recipients
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154755] [META] Thunderbird interoperability and integration

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=154755

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||135628


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=135628
[Bug 135628] SendSimpleMailMessage bodytext ends up as multiple recipients
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135628] SendSimpleMailMessage bodytext ends up as multiple recipients

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=135628

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

  Alias|vancedapp   |
   Keywords||bibisectRequest, regression
 Status|UNCONFIRMED |NEW
 Blocks||154755, 107659
 Ever confirmed|0   |1
 CC||stephane.guillou@libreoffic
   ||e.org
Version|5.4.7.2 release |5.2.7.2 release
URL|https://vancedapp.net/  |

--- Comment #18 from Stéphane Guillou (stragu) 
 ---
Setting to new as per comment 10.
Version and regression keywords as per comment 6.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107659
[Bug 107659] [META] Macro bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=154755
[Bug 154755] [META] Thunderbird interoperability and integration
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157815] New: LibreOffice becomes an unkillable process after loading a file with embedded fonts.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157815

Bug ID: 157815
   Summary: LibreOffice becomes an unkillable process after
loading a file with embedded fonts.
   Product: LibreOffice
   Version: 6.4.0.3 release
  Hardware: x86-64 (AMD64)
OS: other
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: constantini...@infopreserve.com

This problem only seems to occur when LibreOffice is started from a service on
Windows Server 2016.

Steps to reproduce:
1. Create a new .odt file with embedded fonts by going to File -> Properties ->
checking "Embed fonts in the document"
2. Create a new .NET Windows service.  (It might apply to non-.NET services as
well, I haven't tried)
3. In the OnStart() method of the service, start the LibreOffice process with
the "--convert-to pdf" argument and passing in the file path of the embedded
fonts document from step 1.  I'm using .NET 4.6.1 and have included sample code
below.

Expected Result: LibreOffice converts the ODT file to a PDF file.
Actual Result: LibreOffice doesn't create the PDF file and hangs.  Any attempts
to kill the process fail, even with admin rights.

Other Notes:
1. This bug was introduced with version 6.4.0.1.  Version 6.3.6.2 works fine.
2. This also happens when trying to convert from .docx to .odt, so it doesn't
seem to be related to the file formats.
3. The code below works fine when run from a normal program (not a service), or
when run from a service on Windows Server 2019.

---
-- C# code in the Windows service OnStart() method
---

const string inputFilePath =
@"C:\Temp\FileConverterTest\Files_Input\TestEmbeddedFonts.odt";
const string outputFolderPath = @"C:\Temp\FileConverterTest\Files_Output";

ProcessStartInfo info = new ProcessStartInfo(
@"C:\Program Files\LibreOffice\program\soffice.exe", 
"--convert-to pdf \"" + inputFilePath + "\" --outdir \"" +
outputFolderPath + "\"");
info.WindowStyle = ProcessWindowStyle.Hidden;
info.CreateNoWindow = false;
info.UseShellExecute = false;
Process.Start(info);

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: include/vcl

[Andrea Gelmini (via logerrit)]

 include/vcl/accessibility/AccessibleTextAttributeHelper.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit fdad35d096dc642c80998ae8f832ebca183f545e
Author: Andrea Gelmini 
AuthorDate: Wed Oct 18 17:59:02 2023 +0200
Commit: Julien Nabet 
CommitDate: Wed Oct 18 21:11:17 2023 +0200

Fix typo

Change-Id: Ie54bc5f012d2de46363da9d19278736a732a1a25
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158125
Tested-by: Julien Nabet 
Reviewed-by: Julien Nabet 

diff --git a/include/vcl/accessibility/AccessibleTextAttributeHelper.hxx 
b/include/vcl/accessibility/AccessibleTextAttributeHelper.hxx
index 8c4b43b99e11..c5e02a04e85c 100644
--- a/include/vcl/accessibility/AccessibleTextAttributeHelper.hxx
+++ b/include/vcl/accessibility/AccessibleTextAttributeHelper.hxx
@@ -38,7 +38,7 @@ public:
 
 /**
  * Get the IAccessible2 text attributes and the span of the attributes at 
the given index.
- * @param xText The interace to query for the information.
+ * @param xText The interface to query for the information.
  * @param nOffset Character offset for which to retrieve the information.
  * @param rStartOffset Out param that is set to the start index of the 
attribute run.
  * @param rEndOffset Out param that is set to the end index of the 
attribute run.

[Libreoffice-bugs] [Bug 152571] Very slow save (macOS, ARM)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152571

--- Comment #11 from Alex Thurgood  ---
(In reply to Stéphane Guillou (stragu) from comment #10)
> Hm, wondering now if there are two issues here.
> 
> - Jeff, have things improved in 7.5.7?
> - Alex, do you think you are seeing the same in 7.6.2 as in bug 157582?

@Stéphane: for me, the problem isn't on first save. Every save operation causes
the spinning beach all, even after minor changes to a Draw file.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 114912] [META] Clone formatting (aka Format Paintbrush) bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114912

BogdanB  changed:

   What|Removed |Added

 Depends on||157796


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157796
[Bug 157796] Clone Formatting gets disabled in Single Toolbar UI
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157796] Clone Formatting gets disabled in Single Toolbar UI

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157796

BogdanB  changed:

   What|Removed |Added

 Blocks||114912
 CC||buzea.bog...@libreoffice.or
   ||g


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=114912
[Bug 114912] [META] Clone formatting (aka Format Paintbrush) bugs and
enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157801] Direct formatting is applied opening Character properties dialog (Highlighting tab) and pressing OK

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157801

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g

--- Comment #3 from BogdanB  ---
This is Character highlight. So, if you select first some characters, and
choose Highlight, the selected characters changes.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/source

[Michael Stahl (via logerrit)]

 sw/source/core/crsr/crsrsh.cxx |   16 
 sw/source/core/crsr/swcrsr.cxx |   14 +++---
 2 files changed, 27 insertions(+), 3 deletions(-)

New commits:
commit adef72f8411a49920a75d3ceee7c1dc61ca0a470
Author: Michael Stahl 
AuthorDate: Wed Oct 18 15:17:29 2023 +0200
Commit: Michael Stahl 
CommitDate: Wed Oct 18 20:18:03 2023 +0200

sw: fix stack overflow on kde45196-1.html

Previously, the shell cursor was put onto a SwGrfNode in the top left
corner, which is invalid, but didn't crash immediately.

With commit b20ca8d951e8205c8b963c6b7407f984053b4094 the cursor is
instead put onto the first SwTextNode in the body, which happens to be
in a table, and the entire table is hidden; this causes an infinite
recursion in SwCursorShell::UpdateCursorPos() because
GetModelPositionForViewPoint() no longer moves it to SwGrfNode.

So try to move the cursor out of a hidden node, which requires an
additional change in SwCursor::IsSelOvr() to allow moving from a node
without a frame to another node without a frame.

Change-Id: Ia33c7b558755f7e8b65ea3ff2c46aea20be577dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158119
Tested-by: Michael Stahl 
Reviewed-by: Michael Stahl 

diff --git a/sw/source/core/crsr/crsrsh.cxx b/sw/source/core/crsr/crsrsh.cxx
index 84f0ba59072a..04b263cda754 100644
--- a/sw/source/core/crsr/crsrsh.cxx
+++ b/sw/source/core/crsr/crsrsh.cxx
@@ -1803,6 +1803,22 @@ void SwCursorShell::UpdateCursorPos()
 GetLayout()->GetModelPositionForViewPoint( pShellCursor->GetPoint(), 
pShellCursor->GetPtPos(),
   );
 pShellCursor->DeleteMark();
+// kde45196-1.html: try to get to a non-hidden paragraph, there must
+// be one in the document body
+while (isInHiddenTextFrame(pShellCursor))
+{
+if (!pShellCursor->MovePara(GoNextPara, fnParaStart))
+{
+break;
+}
+}
+while (isInHiddenTextFrame(pShellCursor))
+{
+if (!pShellCursor->MovePara(GoPrevPara, fnParaStart))
+{
+break;
+}
+}
 }
 auto* pDoc = GetDoc();
 if (pDoc)
diff --git a/sw/source/core/crsr/swcrsr.cxx b/sw/source/core/crsr/swcrsr.cxx
index 4349fac21b2f..8d0246bed14f 100644
--- a/sw/source/core/crsr/swcrsr.cxx
+++ b/sw/source/core/crsr/swcrsr.cxx
@@ -331,6 +331,7 @@ bool SwCursor::IsSelOvr(SwCursorSelOverFlags const eFlags)
 if( pNd->IsContentNode() && !dynamic_cast(this) )
 {
 const SwContentFrame* pFrame = static_cast(pNd)->getLayoutFrame( 
rDoc.getIDocumentLayoutAccess().GetCurrentLayout() );
+// ^ null
 if ( (SwCursorSelOverFlags::ChangePos & eFlags)   //allowed to change 
position if it's a bad one
 && pFrame && pFrame->isFrameAreaDefinitionValid()
 && !pFrame->getFrameArea().Height() //a bad zero height 
position
@@ -400,9 +401,16 @@ bool SwCursor::IsSelOvr(SwCursorSelOverFlags const eFlags)
 
 if( !pFrame )
 {
-DeleteMark();
-RestoreSavePos();
-return true; // we need a frame
+assert(!m_vSavePos.empty());
+SwContentNode const*const 
pSaveNode(rNds[m_vSavePos.back().nNode]->GetContentNode());
+// if the old position already didn't have a frame, allow moving
+// anyway, hope the caller can handle that
+if (pSaveNode && 
pSaveNode->getLayoutFrame(rDoc.getIDocumentLayoutAccess().GetCurrentLayout()))
+{
+DeleteMark();
+RestoreSavePos();
+return true; // we need a frame
+}
 }
 }
 

[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103100

BogdanB  changed:

   What|Removed |Added

 Depends on||155673


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=155673
[Bug 155673] Unbordered table cells become bordered when changing their border
style via toolbar (see comment 11)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155673] Unbordered table cells become bordered when changing their border style via toolbar (see comment 11)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155673

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g
 Blocks||103100


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103100
[Bug 103100] [META] Writer table bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103341

BogdanB  changed:

   What|Removed |Added

 Depends on||156949


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=156949
[Bug 156949] Incorrect capitalization after number
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156949] Incorrect capitalization after number

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=156949

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g
 Blocks||103341


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103341
[Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/source

[Xisco Fauli (via logerrit)]

 sc/source/ui/app/inputhdl.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 51678d9cf57085bac3c7eba998e0a6d364d36cb2
Author: Xisco Fauli 
AuthorDate: Wed Oct 18 17:28:37 2023 +0200
Commit: Noel Grandin 
CommitDate: Wed Oct 18 20:08:47 2023 +0200

fix crash in ScInputHandler::ImplCreateEditEngine()

See 
https://crashreport.libreoffice.org/stats/crash_details/1b2c45b0-6053-4628-94cc-f639899ceb39

Regression from 5484657d2b1677b7e385ab6ef87ad64dcb9934e4
"tdf#156209 Font size increases when copying from cell in edit mode"

Change-Id: I84cac26087b0c8908c22bbb45056e309cd66a016
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158123
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sc/source/ui/app/inputhdl.cxx b/sc/source/ui/app/inputhdl.cxx
index b4d56988ca0f..de6a7f47a8bc 100644
--- a/sc/source/ui/app/inputhdl.cxx
+++ b/sc/source/ui/app/inputhdl.cxx
@@ -3080,7 +3080,8 @@ void ScInputHandler::EnterHandler( ScEnterMode 
nBlockMode, bool bBeforeSavingInL
 bInOwnChange = true; // disable ModifyHdl (reset below)
 mbPartialPrefix = false;
 
-ImplCreateEditEngine();
+if (pActiveViewSh)
+ImplCreateEditEngine();
 
 bool bMatrix = ( nBlockMode == ScEnterMode::MATRIX );
 

[Libreoffice-commits] core.git: 2 commits - include/svx svx/source sw/source

[Noel Grandin (via logerrit)]

 include/svx/svdpage.hxx|2 
 svx/source/dialog/connctrl.cxx |   11 --
 svx/source/engine3d/scene3d.cxx|   29 +++---
 svx/source/engine3d/view3d.cxx |   17 +--
 svx/source/engine3d/view3d1.cxx|4 
 svx/source/form/fmview.cxx |5 -
 svx/source/form/navigatortreemodel.cxx |5 -
 svx/source/sdr/contact/objectcontactofpageview.cxx |4 
 svx/source/sdr/properties/e3dsceneproperties.cxx   |   86 --
 svx/source/sdr/properties/groupproperties.cxx  |   88 +++
 svx/source/svdraw/sdrpagewindow.cxx|6 -
 svx/source/svdraw/svdmark.cxx  |   15 +--
 svx/source/svdraw/svdmrkv.cxx  |   21 +---
 svx/source/svdraw/svdobj.cxx   |   12 --
 svx/source/svdraw/svdogrp.cxx  |   97 +
 svx/source/svdraw/svdotext.cxx |   11 --
 svx/source/svdraw/svdpage.cxx  |   56 
 svx/source/svdraw/svdpagv.cxx  |5 -
 svx/source/svdraw/svdpntv.cxx  |6 -
 svx/source/svdraw/svdundo.cxx  |   11 --
 sw/source/core/access/accmap.cxx   |   13 +-
 sw/source/core/doc/docdraw.cxx |4 
 sw/source/core/doc/doclay.cxx  |6 -
 sw/source/core/doc/textboxhelper.cxx   |   25 ++---
 sw/source/core/draw/dcontact.cxx   |8 -
 sw/source/core/draw/drawdoc.cxx|4 
 sw/source/core/frmedt/fefly1.cxx   |8 -
 sw/source/core/frmedt/feshview.cxx |9 +
 sw/source/core/model/ModelTraverser.cxx|   10 --
 sw/source/core/model/SearchResultLocator.cxx   |   18 +--
 sw/source/core/undo/undraw.cxx |   19 +---
 sw/source/core/view/vdraw.cxx  |8 -
 sw/source/uibase/uiview/viewdraw.cxx   |6 -
 sw/source/uibase/uno/unotxdoc.cxx  |   15 +--
 sw/source/uibase/utlui/content.cxx |   25 +
 sw/source/uibase/wrtsh/move.cxx|6 -
 36 files changed, 255 insertions(+), 420 deletions(-)

New commits:
commit 6dc53be7d2eabc23e3d96bae94d38e56d37b2bb5
Author: Noel Grandin 
AuthorDate: Wed Oct 18 12:28:37 2023 +0200
Commit: Noel Grandin 
CommitDate: Wed Oct 18 20:08:31 2023 +0200

use more SdrObjList::begin/end in sw

Change-Id: If882c1c7863618a313b2e06abacdbfa756dfff3e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158114
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sw/source/core/access/accmap.cxx b/sw/source/core/access/accmap.cxx
index 3babe9e879d0..9b3ac84876eb 100644
--- a/sw/source/core/access/accmap.cxx
+++ b/sw/source/core/access/accmap.cxx
@@ -1998,13 +1998,12 @@ void SwAccessibleMap::RemoveGroupContext(const 
SdrObject *pParentObj)
 // but also by visibility checks in svx, then it doesn't return children.
 if (mpShapeMap && pParentObj && pParentObj->IsGroupObject())
 {
-SdrObjList *const pChildren(pParentObj->GetSubList());
-for (size_t i = 0; pChildren && i < pChildren->GetObjCount(); ++i)
-{
-SdrObject *const pChild(pChildren->GetObj(i));
-assert(pChild);
-RemoveContext(pChild);
-}
+if (SdrObjList *const pChildren = pParentObj->GetSubList())
+for (const rtl::Reference& pChild : *pChildren)
+{
+assert(pChild);
+RemoveContext(pChild.get());
+}
 }
 }
 //End
diff --git a/sw/source/core/doc/docdraw.cxx b/sw/source/core/doc/docdraw.cxx
index cd1883ee346b..aecbe2ac824f 100644
--- a/sw/source/core/doc/docdraw.cxx
+++ b/sw/source/core/doc/docdraw.cxx
@@ -307,8 +307,8 @@ static void 
lcl_CollectTextBoxesForSubGroupObj(SwFrameFormat* pTargetFormat, std
SdrObject* pSourceObjs)
 {
 if (auto pChildrenObjs = pSourceObjs->getChildrenOfSdrObject())
-for (size_t i = 0; i < pChildrenObjs->GetObjCount(); ++i)
-lcl_CollectTextBoxesForSubGroupObj(pTargetFormat, pTextBoxNode, 
pChildrenObjs->GetObj(i));
+for (const rtl::Reference& pSubObj : *pChildrenObjs)
+lcl_CollectTextBoxesForSubGroupObj(pTargetFormat, pTextBoxNode, 
pSubObj.get());
 else
 {
 if (auto pTextBox = pTextBoxNode->GetTextBox(pSourceObjs))
diff --git a/sw/source/core/doc/doclay.cxx b/sw/source/core/doc/doclay.cxx
index c9881b848d29..ea643f042fe4 100644
--- a/sw/source/core/doc/doclay.cxx
+++ b/sw/source/core/doc/doclay.cxx
@@ -1303,12 +1303,8 @@ static void lcl_collectUsedNums(std::vector& rSetFlags, sal_Int32
 
 const SdrObjList* pSub(rObj.GetSubList());
 assert(pSub && "IsGroupObject is implemented as GetSubList 

[Libreoffice-commits] core.git: include/rtl

[Stephan Bergmann (via logerrit)]

 include/rtl/strbuf.hxx  |2 +-
 include/rtl/string.hxx  |2 +-
 include/rtl/stringutils.hxx |2 +-
 include/rtl/ustrbuf.hxx |2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit ca58f649196ed6b4ce15d0db3935f7de4cb0f2ea
Author: Stephan Bergmann 
AuthorDate: Wed Oct 18 17:04:26 2023 +0200
Commit: Stephan Bergmann 
CommitDate: Wed Oct 18 19:33:52 2023 +0200

Extend /clr /std:c++20 char8_t workaround to old versions of VS 2022

On IRC, pppregin now reported that she ran into the issue addressed by
3c6de7e20e35e37cbddd2d35e065525616deac00 "Fix build against VS 2022 17.7.5" 
when
using (a presumably old version of) VS 2022.  And


suggests that older versions of VS 2022 used _MSV_VER values 1930...1936, so
cover those too here.

Change-Id: Ifee80114c5cd39aeabc31907adafb03eb2f388e9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158122
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/include/rtl/strbuf.hxx b/include/rtl/strbuf.hxx
index e4e4eda1fecd..56f3e2abcc38 100644
--- a/include/rtl/strbuf.hxx
+++ b/include/rtl/strbuf.hxx
@@ -122,7 +122,7 @@ public:
 explicit OStringBuffer(bool) = delete;
 explicit OStringBuffer(char) = delete;
 explicit OStringBuffer(wchar_t) = delete;
-#if !(defined _MSC_VER && _MSC_VER >= 1937 && _MSC_VER <= 1938 && defined 
_MANAGED)
+#if !(defined _MSC_VER && _MSC_VER >= 1930 && _MSC_VER <= 1938 && defined 
_MANAGED)
 explicit OStringBuffer(char8_t) = delete;
 #endif
 explicit OStringBuffer(char16_t) = delete;
diff --git a/include/rtl/string.hxx b/include/rtl/string.hxx
index a2be12ab320d..62bf0530e819 100644
--- a/include/rtl/string.hxx
+++ b/include/rtl/string.hxx
@@ -104,7 +104,7 @@ public:
 }
 }
 
-#if !(defined _MSC_VER && _MSC_VER >= 1937 && _MSC_VER <= 1938 && defined 
_MANAGED)
+#if !(defined _MSC_VER && _MSC_VER >= 1930 && _MSC_VER <= 1938 && defined 
_MANAGED)
 #if HAVE_CPP_CONSTEVAL
 consteval
 #else
diff --git a/include/rtl/stringutils.hxx b/include/rtl/stringutils.hxx
index 0239505be0d2..3cd66ee6c146 100644
--- a/include/rtl/stringutils.hxx
+++ b/include/rtl/stringutils.hxx
@@ -247,7 +247,7 @@ struct ConstCharArrayDetector< const char[ 1 ], T >
 #endif
 
 #if defined LIBO_INTERNAL_ONLY \
-&& !(defined _MSC_VER && _MSC_VER >= 1937 && _MSC_VER <= 1938 && defined 
_MANAGED)
+&& !(defined _MSC_VER && _MSC_VER >= 1930 && _MSC_VER <= 1938 && defined 
_MANAGED)
 template
 struct ConstCharArrayDetector {
 using Type = T;
diff --git a/include/rtl/ustrbuf.hxx b/include/rtl/ustrbuf.hxx
index cd868b0c6d7b..f41e34aa9d5d 100644
--- a/include/rtl/ustrbuf.hxx
+++ b/include/rtl/ustrbuf.hxx
@@ -124,7 +124,7 @@ public:
 explicit OUStringBuffer(bool) = delete;
 explicit OUStringBuffer(char) = delete;
 explicit OUStringBuffer(wchar_t) = delete;
-#if !(defined _MSC_VER && _MSC_VER >= 1937 && _MSC_VER <= 1938 && defined 
_MANAGED)
+#if !(defined _MSC_VER && _MSC_VER >= 1930 && _MSC_VER <= 1938 && defined 
_MANAGED)
 explicit OUStringBuffer(char8_t) = delete;
 #endif
 explicit OUStringBuffer(char16_t) = delete;

[Libreoffice-commits] core.git: connectivity/source

[Stephan Bergmann (via logerrit)]

 connectivity/source/drivers/macab/MacabAddressBook.cxx |4 ++--
 connectivity/source/drivers/macab/MacabCatalog.cxx |2 +-
 connectivity/source/drivers/macab/MacabDriver.cxx  |2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit f8ad36a2ec1d60b96653cb5538ef6f6c34084583
Author: Stephan Bergmann 
AuthorDate: Wed Oct 18 16:57:34 2023 +0200
Commit: Stephan Bergmann 
CommitDate: Wed Oct 18 18:56:16 2023 +0200

loplugin:stringstatic

Change-Id: I008c48a315841a2fb642410f210d770bd14bfef5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158121
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/connectivity/source/drivers/macab/MacabAddressBook.cxx 
b/connectivity/source/drivers/macab/MacabAddressBook.cxx
index 02d4faf74290..7ade1ac0a830 100644
--- a/connectivity/source/drivers/macab/MacabAddressBook.cxx
+++ b/connectivity/source/drivers/macab/MacabAddressBook.cxx
@@ -113,8 +113,8 @@ MacabAddressBook::~MacabAddressBook()
 const OUString & MacabAddressBook::getDefaultTableName()
 {
 /* This string probably needs to be localized. */
-static const OUString aDefaultTableName
-(OUString("Address Book"));
+static constexpr OUString aDefaultTableName
+(u"Address Book"_ustr);
 
 return aDefaultTableName;
 }
diff --git a/connectivity/source/drivers/macab/MacabCatalog.cxx 
b/connectivity/source/drivers/macab/MacabCatalog.cxx
index 96ff62fd5b6a..d6485ab1c971 100644
--- a/connectivity/source/drivers/macab/MacabCatalog.cxx
+++ b/connectivity/source/drivers/macab/MacabCatalog.cxx
@@ -80,7 +80,7 @@ void MacabCatalog::refreshUsers()
 
 const OUString& MacabCatalog::getDot()
 {
-static const OUString sDot = ".";
+static constexpr OUString sDot = u"."_ustr;
 return sDot;
 }
 
diff --git a/connectivity/source/drivers/macab/MacabDriver.cxx 
b/connectivity/source/drivers/macab/MacabDriver.cxx
index f4527bc6094b..9c68e48f12a7 100644
--- a/connectivity/source/drivers/macab/MacabDriver.cxx
+++ b/connectivity/source/drivers/macab/MacabDriver.cxx
@@ -115,7 +115,7 @@ bool MacabImplModule::impl_loadModule()
 OSL_ENSURE( !m_hConnectorModule && !m_pConnectionFactoryFunc,
 "MacabImplModule::impl_loadModule: inconsistence: inconsistency (never 
attempted load before, but some values already set)!");
 
-const OUString sModuleName( SAL_MODULENAME( "macabdrv1" ) );
+constexpr OUString sModuleName( u"" SAL_MODULENAME( "macabdrv1" ) ""_ustr 
);
 m_hConnectorModule = osl_loadModuleRelative( , 
sModuleName.pData, SAL_LOADMODULE_NOW );   // LAZY! #i61335#
 OSL_ENSURE( m_hConnectorModule, "MacabImplModule::impl_loadModule: could 
not load the implementation library!" );
 if ( !m_hConnectorModule )

[Libreoffice-commits] core.git: sc/source

[Noel Grandin (via logerrit)]

 sc/source/ui/inc/output.hxx   |9 +-
 sc/source/ui/view/output.cxx  |4 +
 sc/source/ui/view/output2.cxx |  148 --
 3 files changed, 94 insertions(+), 67 deletions(-)

New commits:
commit c546b33dde8760cdc8d9990e672cc8cb344e470e
Author: Noel Grandin 
AuthorDate: Fri Oct 13 09:49:57 2023 +0200
Commit: Noel Grandin 
CommitDate: Wed Oct 18 18:52:08 2023 +0200

cool#6893 cache the EditEngine for rendering

to avoid re-allocating one constantly

Change-Id: I7d6c97a7f68126979bd8a5c12cfd6e680a789d3b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157906
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sc/source/ui/inc/output.hxx b/sc/source/ui/inc/output.hxx
index 1a445f9e14e4..e4763767b7f5 100644
--- a/sc/source/ui/inc/output.hxx
+++ b/sc/source/ui/inc/output.hxx
@@ -240,6 +240,7 @@ private:
 // #i74769# use SdrPaintWindow direct, remember it during 
BeginDrawLayers/EndDrawLayers
 SdrPaintWindow* mpTargetPaintWindow;
 const sc::SpellCheckContext* mpSpellCheckCxt;
+std::unique_ptr mxOutputEditEngine;
 
 // private methods
 
@@ -278,7 +279,7 @@ private:
 void DrawEditStacked(DrawEditParam& rParam);
 void DrawEditAsianVertical(DrawEditParam& rParam);
 
-std::unique_ptr CreateOutputEditEngine();
+void InitOutputEditEngine();
 
 void SetClipMarks( OutputAreaParam , ScCellInfo* pClipMarkCell,
SvxCellHorJustify eOutHorJust, tools::Long nLayoutSign 
);
@@ -318,14 +319,14 @@ public:
 voidSetSpellCheckContext( const sc::SpellCheckContext* pCxt );
 voidSetContentDevice( OutputDevice* pContentDev );
 
-voidSetRefDevice( OutputDevice* pRDev ) { mpRefDevice = pFmtDevice = 
pRDev; }
-voidSetFmtDevice( OutputDevice* pRDev ) { pFmtDevice = pRDev; }
+voidSetRefDevice( OutputDevice* pRDev );
+voidSetFmtDevice( OutputDevice* pRDev );
 voidSetViewShell( ScTabViewShell* pSh ) { pViewShell = pSh; }
 
 voidSetDrawView( FmFormView* pNew ) { pDrawView = pNew; }
 
 voidSetSolidBackground( bool bSet ) { bSolidBackground = bSet; }
-voidSetUseStyleColor( bool bSet )   { mbUseStyleColor = bSet; }
+voidSetUseStyleColor( bool bSet );
 
 voidSetEditCell( SCCOL nCol, SCROW nRow );
 voidSetSyntaxMode( bool bNewMode );
diff --git a/sc/source/ui/view/output.cxx b/sc/source/ui/view/output.cxx
index f3b4b3ca9be2..8461c446 100644
--- a/sc/source/ui/view/output.cxx
+++ b/sc/source/ui/view/output.cxx
@@ -61,6 +61,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -212,6 +213,7 @@ ScOutputData::ScOutputData( OutputDevice* pNewDev, 
ScOutputType eNewType,
 
 // always needed, so call at the end of the constructor
 SetCellRotations();
+InitOutputEditEngine();
 }
 
 ScOutputData::~ScOutputData()
@@ -262,6 +264,8 @@ void ScOutputData::SetShowFormulas( bool bSet )
 void ScOutputData::SetShowSpellErrors( bool bSet )
 {
 bShowSpellErrors = bSet;
+// reset EditEngine because it depends on bShowSpellErrors
+mxOutputEditEngine.reset();
 }
 
 void ScOutputData::SetSnapPixel()
diff --git a/sc/source/ui/view/output2.cxx b/sc/source/ui/view/output2.cxx
index 6dbd218caf61..c80c6483bc5e 100644
--- a/sc/source/ui/view/output2.cxx
+++ b/sc/source/ui/view/output2.cxx
@@ -2177,27 +2177,56 @@ void ScOutputData::LayoutStrings(bool bPixelToLogic)
 ScProgress::DeleteInterpretProgress();
 }
 
-std::unique_ptr ScOutputData::CreateOutputEditEngine()
+void ScOutputData::SetRefDevice( OutputDevice* pRDev )
 {
-std::unique_ptr pEngine(new ScFieldEditEngine(mpDoc, 
mpDoc->GetEnginePool()));
-pEngine->SetUpdateLayout( false );
-pEngine->EnableUndo( false ); // don't need undo for painting purposes
-// a RefDevice always has to be set, otherwise EditEngine would create a 
VirtualDevice
-pEngine->SetRefDevice( pFmtDevice );
-EEControlBits nCtrl = pEngine->GetControlWord();
-if ( bShowSpellErrors )
-nCtrl |= EEControlBits::ONLINESPELLING;
-if ( eType == OUTTYPE_PRINTER )
-nCtrl &= ~EEControlBits::MARKFIELDS;
+mpRefDevice = pFmtDevice = pRDev;
+// reset EditEngine because it depends on pFmtDevice and mpRefDevice
+mxOutputEditEngine.reset();
+}
+
+void ScOutputData::SetFmtDevice( OutputDevice* pRDev )
+{
+pFmtDevice = pRDev;
+// reset EditEngine because it depends on pFmtDevice
+mxOutputEditEngine.reset();
+}
+
+void ScOutputData::SetUseStyleColor( bool bSet )
+{
+mbUseStyleColor = bSet;
+// reset EditEngine because it depends on mbUseStyleColor
+mxOutputEditEngine.reset();
+}
+
+void ScOutputData::InitOutputEditEngine()
+{
+if (!mxOutputEditEngine)
+{
+mxOutputEditEngine = std::make_unique(mpDoc, 
mpDoc->GetEnginePool());
+mxOutputEditEngine->SetUpdateLayout( false );
+mxOutputEditEngine->EnableUndo( false ); 

[Libreoffice-bugs] [Bug 156949] Incorrect capitalization after number

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=156949

--- Comment #8 from frances.med...@orangeandbronze.com ---
Created attachment 190280
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190280=edit
document test data for incorrect capitalization after a number

document test data for incorrect capitalization after a number

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156949] Incorrect capitalization after number

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=156949

--- Comment #7 from frances.med...@orangeandbronze.com ---
Able to replicate the issue based on the recent repro steps/comment by steveja
2023-09-16 19, 

I am using Mac OS
Version: 7.6.2.1 (X86_64) / LibreOffice Community
Build ID: 56f7684011345957bbf33a7ee678afaf4d2ba333
CPU threads: 8; OS: Mac OS X 13.5.2; UI render: Skia/Metal; VCL: osx
Locale: en-PH (en_PH.UTF-8); UI: en-US
Calc: threaded

I dont have the lightproof grammar checker – but i can still replicate the
issue. 

The letter beside the number is  capitalized when enter key or space key is
pressed after the letters/word input.

- First attempt was successful using the specified data - Hey. 8Am 
- Created a document to test all data wherein the bug could appear.

1. Tested if all the letters after the number will be capitalized. (For the
sake of checking if this only happens to the time format.)
Data range from Hey. 8Am to Hey. 8Zm 

2. Replicated in data with End of sentence punctuations -  exclamation point
and question mark
ex: hoy! 12Am, hello. 09Abc 

3. Replicated on data with more than 3 character words before the End of
sentence punctuations (. ! ?)
ex:
- qwertyuiop! 12345Pm 
- asdfghjklzxcvbnm,qwertyuiop? 12Zz

4. Replicated on data with more than 2 digit number after the  End of sentence
punctuations (. ! ?)
ex:
- hey! 12345678909876543256As
- qwertyu? 1234567890987654321234567890987654323456789Bd

5. Replicated on data with more than 2letters at the end of the number
ex:
- hoy! 12Qwerty
- hoy? 45Asdfghhjkl
- pop. 12Xcvbnmasdfghjklqwertyuiop

6. Combination of conditions mentioned above
ex: 
- qwerty! 123456Asdfghjkl
- asdfghjk? 0987654321234567890Asdfghjklqwertyuiopzxcvbnm
- thequickbrownfoxjumpedoverthelazydog.
1234567890Thequickbrownfoxjumpsoverthelazydog 

Also tried replicating on Microsoft Word Version 16.78 and Google Documents but
wasnt able to reproduce it there.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: stoc/source

[Stephan Bergmann (via logerrit)]

 stoc/source/javavm/javavm.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 871c37f782a53cec13bed724b90495197348aa29
Author: Stephan Bergmann 
AuthorDate: Wed Oct 18 16:57:14 2023 +0200
Commit: Stephan Bergmann 
CommitDate: Wed Oct 18 18:34:01 2023 +0200

loplugin:indentation

Change-Id: If81844107209c3fb04d39c9f2b826b623068fc30
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158120
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/stoc/source/javavm/javavm.cxx b/stoc/source/javavm/javavm.cxx
index fa5883ae3fa7..a41dde50f1ef 100644
--- a/stoc/source/javavm/javavm.cxx
+++ b/stoc/source/javavm/javavm.cxx
@@ -474,9 +474,9 @@ public:
 // current thread" calls to the JVM.
 if (CFRunLoopGetCurrent() != CFRunLoopGetMain())
 #endif
-if (m_jvm->DetachCurrentThread() != 0) {
-OSL_ASSERT(false);
-}
+if (m_jvm->DetachCurrentThread() != 0) {
+OSL_ASSERT(false);
+}
 }
 
 DetachCurrentThread(const DetachCurrentThread&) = delete;

[Libreoffice-bugs] [Bug 157814] New: Word track changes makes the erasing to the end of the paragraph after saving

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157814

Bug ID: 157814
   Summary: Word track changes makes the erasing to the end of the
paragraph after saving
   Product: LibreOffice
   Version: 7.6.2.1 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: documentfoundat...@jvm.mozmail.com

Description:
I have some documents (doc and rtf) most likely created with MS Office (they
were given to me). In one, there were changes already tracked, while in the
other, I started tracking changes. After saving and opening again, I see that
when there was some text removal in a tracked change, now the text removal has
extended to the end of the paragraph. For instance (I will mark the removal of
text with ~~ characters, and added text with ++).

Before saving and reopening the document I had:

In ++this++~~that~~ case, I can remember that blah blah blah blah.

Next paragraph bla bla bla.

After saving and reopening the document I have:

In ++this++~~that case, I can remember that blah blah blah blah.~~

Next paragraph bla bla bla.

So the removal has "extended" to the end of the paragraph.

My version is 7.6.2.1 x86_64 / Libreoffice Community on Linux (Opensuse
Tumbleweed).

Steps to Reproduce:
1.Get a document (rtf or doc, maybe created with MS Office) with tracked
changes (particularly some removal of text).
2. Change something and save the document.
3. Open again and you will see the difference in tracked changes

Actual Results:
You get the tracked changes that are removal of text "extended" to the end of
the paragraph where they belonged.

Expected Results:
The tracked changes should be the same all the time


Reproducible: Didn't try


User Profile Reset: Yes

Additional Info:
With the save mode, I saved it and it worked correctly (once), but I should try
several times to see if resetting the userprofile solves the problem

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - sc/source

[Henry Castro (via logerrit)]

 sc/source/ui/view/output2.cxx |   14 +++---
 1 file changed, 11 insertions(+), 3 deletions(-)

New commits:
commit c9319cdfa269ff3e043f012731406bf3fd4e1810
Author: Henry Castro 
AuthorDate: Wed Oct 11 08:59:59 2023 -0400
Commit: Henry Castro 
CommitDate: Wed Oct 18 18:17:51 2023 +0200

sc: ui: fix cell bidi layout strings

The default constructor OutputDevice set the
layout text to "vcl::text::ComplexTextLayoutFlags::BiDiRtl"
for all strings, however the each cell string can be
mixed LTR and RTL.

Set the defaults to auto detect the correct text layout mode.
.

Signed-off-by: Henry Castro 
Change-Id: I0c451e8014fd13490db4213adca3d83ea4572819
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157831
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Caolán McNamara 
(cherry picked from commit f63e02b99691a0d8c8addba2518ecdf6b4319c52)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157952

diff --git a/sc/source/ui/view/output2.cxx b/sc/source/ui/view/output2.cxx
index 302f2db07a01..e944eb0e0a08 100644
--- a/sc/source/ui/view/output2.cxx
+++ b/sc/source/ui/view/output2.cxx
@@ -1521,14 +1521,22 @@ tools::Rectangle ScOutputData::LayoutStrings(bool 
bPixelToLogic, bool bPaint, co
 {
 bool bOrigIsInLayoutStrings = mpDoc->IsInLayoutStrings();
 mpDoc->SetLayoutStrings(true);
-comphelper::ScopeGuard g([this, bOrigIsInLayoutStrings] {
-mpDoc->SetLayoutStrings(bOrigIsInLayoutStrings);
-});
 
 OSL_ENSURE( mpDev == mpRefDevice ||
 mpDev->GetMapMode().GetMapUnit() == 
mpRefDevice->GetMapMode().GetMapUnit(),
 "LayoutStrings: different MapUnits ?!?!" );
 
+vcl::text::ComplexTextLayoutFlags eTextLayout = mpDev->GetLayoutMode();
+comphelper::ScopeGuard g([this, bOrigIsInLayoutStrings, eTextLayout] {
+mpDoc->SetLayoutStrings(bOrigIsInLayoutStrings);
+
+if (mpDev->GetLayoutMode() != eTextLayout)
+mpDev->SetLayoutMode(eTextLayout);
+});
+
+if (mpDev->GetLayoutMode() != vcl::text::ComplexTextLayoutFlags::Default)
+mpDev->SetLayoutMode(vcl::text::ComplexTextLayoutFlags::Default);
+
 sc::IdleSwitch aIdleSwitch(*mpDoc, false);
 
 // Try to limit interpreting to only visible cells. Calling e.g. IsValue()

[Libreoffice-commits] core.git: basctl/source

[Hossein (via logerrit)]

 basctl/source/basicide/brkdlg.cxx |7 +--
 1 file changed, 1 insertion(+), 6 deletions(-)

New commits:
commit e94cbd7dbf4a8c82f17522806a9011c89bf20865
Author: Hossein 
AuthorDate: Wed Oct 18 10:29:22 2023 +0200
Commit: Hossein 
CommitDate: Wed Oct 18 17:41:52 2023 +0200

Remove obsolete comments in basctl

First comment was last updated with USHORT -> sal_uInt16 in
a2242be9c3551310027b341db53164ebd78bc6c8 but with the newer commit
68ec95b3f80408ae50897b043eed69a07d084df9 there is no remaining sal_uInt16
left, and thus the comment is no longer relevant.

Second comment was added in 1fac87f84723a3d6e7e13c091e39b09e0dea1aa5,
but with changes in 444c242c51e6b049598359ea6cf98e34f611838b it is no
longer relevant.

Third comment was also last updated with USHORT -> sal_uInt16 in
a2242be9c3551310027b341db53164ebd78bc6c8 but with the newer commit
444c242c51e6b049598359ea6cf98e34f611838b it is no longer relevant.

Change-Id: I9ed383f15a5b403740c0b8bcdd153d04bb1a2b0c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158111
Tested-by: Jenkins
Reviewed-by: Hossein 

diff --git a/basctl/source/basicide/brkdlg.cxx 
b/basctl/source/basicide/brkdlg.cxx
index 37ba1dbb60ae..48522d11ac37 100644
--- a/basctl/source/basicide/brkdlg.cxx
+++ b/basctl/source/basicide/brkdlg.cxx
@@ -28,15 +28,11 @@
 
 namespace basctl
 {
-// FIXME  Why does BreakPointDialog allow only sal_uInt16 for break-point line
-// numbers, whereas BreakPoint supports sal_uLong?
-
 namespace
 {
 bool lcl_ParseText(OUString const& rText, size_t& rLineNr)
 {
-// aText should look like "# n" where
-// n > 0 && n < std::numeric_limits< sal_uInt16 >::max().
+// aText should look like "# n" where n > 0
 // All spaces are ignored, so there can even be spaces within the
 // number n.  (Maybe it would be better to ignore all whitespace instead
 // of just spaces.)
@@ -48,7 +44,6 @@ bool lcl_ParseText(OUString const& rText, size_t& rLineNr)
 return false;
 if (cFirst == '#')
 aText = aText.copy(1);
-// XXX Assumes that sal_uInt16 is contained within sal_Int32:
 sal_Int32 n = aText.toInt32();
 if (n <= 0)
 return false;