date:20231026

[Libreoffice-bugs] [Bug 157915] Error UNO type of C++ when running a Basic macro with instruction commitChanges for org.openoffice.Office.Commands/Execute/Disabled

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157915

--- Comment #6 from Celia Palacios  ---
Version: 7.6.2.1 (X86_64) / LibreOffice Community
Build ID: 56f7684011345957bbf33a7ee678afaf4d2ba333
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

I ran the macro from the IDE, no messages at all. But the menus freezed and
LibreOffice crashed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157940] The exported PDF document has incorrect links.

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157940

BogdanB  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO
 CC||buzea.bog...@libreoffice.or
   ||g

--- Comment #1 from BogdanB  ---
Recently, a bug with wrong hyperlinks was solved. Could you attach a demo
document in order to test it?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: svgio/inc svgio/source

2023-10-26 Thread Mike Kaganski (via logerrit)

 svgio/inc/svganode.hxx   |2 +-
 svgio/inc/svgcirclenode.hxx  |2 +-
 svgio/inc/svgclippathnode.hxx|2 +-
 svgio/inc/svgellipsenode.hxx |2 +-
 svgio/inc/svgfecolormatrixnode.hxx   |3 +--
 svgio/inc/svgfedropshadownode.hxx|3 +--
 svgio/inc/svgfefloodnode.hxx |3 +--
 svgio/inc/svgfegaussianblurnode.hxx  |3 +--
 svgio/inc/svgfeimagenode.hxx |3 +--
 svgio/inc/svgfeoffsetnode.hxx|3 +--
 svgio/inc/svggnode.hxx   |2 +-
 svgio/inc/svggradientnode.hxx|2 +-
 svgio/inc/svggradientstopnode.hxx|2 +-
 svgio/inc/svgimagenode.hxx   |2 +-
 svgio/inc/svglinenode.hxx|2 +-
 svgio/inc/svgmarkernode.hxx  |2 +-
 svgio/inc/svgmasknode.hxx|2 +-
 svgio/inc/svgnode.hxx|2 +-
 svgio/inc/svgpathnode.hxx|2 +-
 svgio/inc/svgpatternnode.hxx |2 +-
 svgio/inc/svgpolynode.hxx|2 +-
 svgio/inc/svgrectnode.hxx|2 +-
 svgio/inc/svgstylenode.hxx   |2 +-
 svgio/inc/svgsvgnode.hxx |2 +-
 svgio/inc/svgsymbolnode.hxx  |2 +-
 svgio/inc/svgtextnode.hxx|2 +-
 svgio/inc/svgtextpathnode.hxx|2 +-
 svgio/inc/svgtrefnode.hxx|2 +-
 svgio/inc/svgtspannode.hxx   |2 +-
 svgio/inc/svgusenode.hxx |2 +-
 svgio/source/svgreader/svganode.cxx  |4 ++--
 svgio/source/svgreader/svgcirclenode.cxx |4 ++--
 svgio/source/svgreader/svgclippathnode.cxx   |4 ++--
 svgio/source/svgreader/svgdocumenthandler.cxx|2 +-
 svgio/source/svgreader/svgellipsenode.cxx|4 ++--
 svgio/source/svgreader/svgfecolormatrixnode.cxx  |3 +--
 svgio/source/svgreader/svgfedropshadownode.cxx   |3 +--
 svgio/source/svgreader/svgfefloodnode.cxx|3 +--
 svgio/source/svgreader/svgfegaussianblurnode.cxx |3 +--
 svgio/source/svgreader/svgfeimagenode.cxx|3 +--
 svgio/source/svgreader/svgfeoffsetnode.cxx   |3 +--
 svgio/source/svgreader/svggnode.cxx  |4 ++--
 svgio/source/svgreader/svggradientnode.cxx   |4 ++--
 svgio/source/svgreader/svggradientstopnode.cxx   |4 ++--
 svgio/source/svgreader/svgimagenode.cxx  |4 ++--
 svgio/source/svgreader/svglinenode.cxx   |4 ++--
 svgio/source/svgreader/svgmarkernode.cxx |4 ++--
 svgio/source/svgreader/svgmasknode.cxx   |4 ++--
 svgio/source/svgreader/svgnode.cxx   |4 ++--
 svgio/source/svgreader/svgpathnode.cxx   |4 ++--
 svgio/source/svgreader/svgpatternnode.cxx|4 ++--
 svgio/source/svgreader/svgpolynode.cxx   |4 ++--
 svgio/source/svgreader/svgrectnode.cxx   |4 ++--
 svgio/source/svgreader/svgstylenode.cxx  |4 ++--
 svgio/source/svgreader/svgsvgnode.cxx|4 ++--
 svgio/source/svgreader/svgsymbolnode.cxx |4 ++--
 svgio/source/svgreader/svgtextnode.cxx   |4 ++--
 svgio/source/svgreader/svgtextpathnode.cxx   |4 ++--
 svgio/source/svgreader/svgtrefnode.cxx   |4 ++--
 svgio/source/svgreader/svgtspannode.cxx  |4 ++--
 svgio/source/svgreader/svgusenode.cxx|4 ++--
 61 files changed, 85 insertions(+), 97 deletions(-)

New commits:
commit 48ff87e100b7aa3a519937a73076f5c38cb919da
Author: Mike Kaganski 
AuthorDate: Thu Oct 26 12:10:14 2023 +0300
Commit: Mike Kaganski 
CommitDate: Fri Oct 27 06:35:41 2023 +0200

Drop rTokenName argument from SvgNode::parseAttribute

It was never used.

Change-Id: I8bc7d625977a6cdc8fe6863037e72577dbfc46c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158493
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/svgio/inc/svganode.hxx b/svgio/inc/svganode.hxx
index 1590421c5a11..34bc551a54dd 100644
--- a/svgio/inc/svganode.hxx
+++ b/svgio/inc/svganode.hxx
@@ -41,7 +41,7 @@ namespace svgio::svgreader
 virtual ~SvgANode() override;
 
 virtual const SvgStyleAttributes* getSvgStyleAttributes() const 
override;
-virtual void parseAttribute(const OUString& rTokenName, SVGToken 
aSVGToken, const OUString& aContent) override;
+virtual void parseAttribute(SVGToken aSVGToken, const OUString& 
aContent) override;
 virtual void 
decomposeSvgNode(drawinglayer::primitive2d::Primitive2DContainer& rTarget, bool 
bReferenced) const override;
 
 /// transform content
diff --git

[Libreoffice-commits] core.git: svgio/inc svgio/source

2023-10-26 Thread Mike Kaganski (via logerrit)

 svgio/inc/svgtoken.hxx  |2 
 svgio/source/svgreader/svgtoken.cxx |  206 ++--
 2 files changed, 18 insertions(+), 190 deletions(-)

New commits:
commit 009ea6f786e5a7fd1e08d768e33b5b7af30e5765
Author: Mike Kaganski 
AuthorDate: Fri Jul 7 12:46:24 2023 +0300
Commit: Mike Kaganski 
CommitDate: Fri Oct 27 06:35:26 2023 +0200

Commit 04c78e1a46a423071d7ea68724525ec7ef92e0e8 follow-up

Drops duplicating map, and uses std::find_if with case-insensitive
comparison. Likely to have some performance impact, but avoids the
maintenance penalty of two maps.

Change-Id: I7144556488aa134d9b9214b00ba9d7c4e0fb68a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154159
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/svgio/inc/svgtoken.hxx b/svgio/inc/svgtoken.hxx
index 3a4a89f285e2..3927a27d1db5 100644
--- a/svgio/inc/svgtoken.hxx
+++ b/svgio/inc/svgtoken.hxx
@@ -192,7 +192,7 @@ namespace svgio::svgreader
 DominantBaseline
 };
 
-SVGToken StrToSVGToken(const OUString& rStr, bool bCaseIndependent);
+SVGToken StrToSVGToken(std::u16string_view rStr, bool bIgnoreCase);
 OUString SVGTokenToStr(const SVGToken& rToken);
 
 } // end of namespace svgio::svgreader
diff --git a/svgio/source/svgreader/svgtoken.cxx 
b/svgio/source/svgreader/svgtoken.cxx
index 492c78623f14..fa28c8647cea 100644
--- a/svgio/source/svgreader/svgtoken.cxx
+++ b/svgio/source/svgreader/svgtoken.cxx
@@ -21,11 +21,12 @@
 #include 
 #include 
 #include 
+#include 
 
 namespace svgio::svgreader
 {
 
-constexpr auto aSVGTokenMapperList = 
frozen::make_unordered_map(
+constexpr auto aSVGTokenMap = frozen::make_unordered_map(
 {
 { u"width", SVGToken::Width },
 { u"height", SVGToken::Height },
@@ -181,203 +182,30 @@ constexpr auto aSVGTokenMapperList = 
frozen::make_unordered_map(
+SVGToken StrToSVGToken(std::u16string_view rStr, bool bIgnoreCase)
 {
-{ u"width", SVGToken::Width },
-{ u"height", SVGToken::Height },
-{ u"viewbox", SVGToken::ViewBox },
-{ u"transform", SVGToken::Transform },
-{ u"style", SVGToken::Style },
-{ u"display", SVGToken::Display }, // #i121656#
-{ u"d", SVGToken::D },
-{ u"x", SVGToken::X },
-{ u"y", SVGToken::Y },
-{ u"xmlns", SVGToken::Xmlns },
-{ u"version", SVGToken::Version },
-{ u"id", SVGToken::Id },
-{ u"in", SVGToken::In },
-{ u"rx", SVGToken::Rx },
-{ u"ry", SVGToken::Ry },
-{ u"points", SVGToken::Points },
-{ u"dx", SVGToken::Dx },
-{ u"dy", SVGToken::Dy },
-{ u"rotate", SVGToken::Rotate },
-{ u"textlength", SVGToken::TextLength },
-{ u"lengthadjust", SVGToken::LengthAdjust },
-{ u"font", SVGToken::Font },
-{ u"font-family", SVGToken::FontFamily },
-{ u"font-size", SVGToken::FontSize },
-{ u"font-size-adjust", SVGToken::FontSizeAdjust },
-{ u"font-stretch", SVGToken::FontStretch },
-{ u"font-style", SVGToken::FontStyle },
-{ u"font-variant", SVGToken::FontVariant },
-{ u"font-weight", SVGToken::FontWeight },
-{ u"direction", SVGToken::Direction },
-{ u"letter-spacing", SVGToken::LetterSpacing },
-{ u"text-decoration", SVGToken::TextDecoration },
-{ u"unicode-bidi", SVGToken::UnicodeBidi },
-{ u"word-spacing", SVGToken::WordSpacing },
-{ u"tspan", SVGToken::Tspan },
-{ u"tref", SVGToken::Tref },
-{ u"textpath", SVGToken::TextPath },
-{ u"startoffset", SVGToken::StartOffset },
-{ u"method", SVGToken::Method },
-{ u"spacing", SVGToken::Spacing },
-{ u"stddeviation", SVGToken::StdDeviation },
-{ u"text-align", SVGToken::TextAlign },
-{ u"pathlength", SVGToken::PathLength },
-{ u"type", SVGToken::Type },
-{ u"class", SVGToken::Class },
-{ u"text-anchor", SVGToken::TextAnchor },
-{ u"xml:space", SVGToken::XmlSpace },
-{ u"color", SVGToken::Color },
-{ u"clippath", SVGToken::ClipPathNode },
-{ u"clip-path", SVGToken::ClipPathProperty },
-{ u"fecolormatrix", SVGToken::FeColorMatrix },
-{ u"fedropshadow", SVGToken::FeDropShadow },
-{ u"feflood", SVGToken::FeFlood },
-{ u"feimage", SVGToken::FeImage },
-{ u"fegaussianblur", SVGToken::FeGaussianBlur },
-{ u"feoffset", SVGToken::FeOffset },
-{ u"filter", SVGToken::Filter },
-{ u"flood-color", SVGToken::FloodColor },
-{ u"flood-opacity", SVGToken::FloodOpacity },
-{ u"mask", SVGToken::Mask },
-{ u"clippathunits", SVGToken::ClipPathUnits },
-{ u"maskunits", SVGToken::MaskUnits },
-{ u"maskcontentunits", SVGToken::MaskContentUnits },
-{ u"clip-rule", SVGToken::ClipRule },
-{ u"marker", SVGToken::Marker },
-{ u"marker-start", SVGToken::MarkerStart },
-{ u"marker-mid", SVGToken::MarkerMid },
-{ u"marker-end", SVGToken::MarkerEnd },
-{ u"refx", SVGToken::RefX },
-{ u"refy", SVGToken::RefY },
-{ u"markerunits", SVGToken::MarkerUnits },
-{ u"markerwidth",

[Libreoffice-bugs] [Bug 157940] New: The exported PDF document has incorrect links.

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157940

Bug ID: 157940
   Summary: The exported PDF document has incorrect links.
   Product: LibreOffice
   Version: 7.5.7.1 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: pingtao.w...@qq.com

Description:
In the exported PDF document, some links are lost or some links are wrong. 
The result of exporting the same document may be different each time.

Actual Results:
Add some web links to the document.
Export to pdf document.
Check that the pdf document is linked correctly.

Expected Results:
Some of these web links are incorrect or missing.


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.5.7.1 (X86_64) / LibreOffice Community
Build ID: 47eb0cf7efbacdee9b19ae25d6752381ede23126
CPU threads: 4; OS: Windows 10.0 Build 22635; UI render: Skia/Raster; VCL: win
Locale: zh-CN (zh_CN); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/source

2023-10-26 Thread Chris Sherlock (via logerrit)

 vcl/source/outdev/bitmap.cxx |   64 ++-
 1 file changed, 28 insertions(+), 36 deletions(-)

New commits:
commit 4a6492e155d44ef51fc9a89271f857a6f987182e
Author: Chris Sherlock 
AuthorDate: Sun Sep 24 00:42:07 2023 +1000
Commit: Tomaž Vajngerl 
CommitDate: Fri Oct 27 05:52:56 2023 +0200

vcl: flatten OutputDevice::BlendBitmap()

Change-Id: Idb0c21dd37af81fae0fd4152f0556edb20e63b80
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157190
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/vcl/source/outdev/bitmap.cxx b/vcl/source/outdev/bitmap.cxx
index d95c97e8633c..1806635593d2 100644
--- a/vcl/source/outdev/bitmap.cxx
+++ b/vcl/source/outdev/bitmap.cxx
@@ -909,8 +909,6 @@ Bitmap OutputDevice::BlendBitmap(
 if( !pP || !pA )
 return aBmp;
 
-Bitmap  res;
-
 if( GetBitCount() <= 8 )
 {
 Bitmap aDither(aBmp.GetSizePixel(), vcl::PixelFormat::N8_BPP);
@@ -949,53 +947,47 @@ Bitmap OutputDevice::BlendBitmap(
 
 pB.reset();
 pW.reset();
-res = aDither;
+return aDither;
 }
-else
+
+BitmapScopedWriteAccess pB(aBmp);
+
+bool bFastBlend = false;
+if (!bHMirr && !bVMirr)
 {
-BitmapScopedWriteAccess pB(aBmp);
+SalTwoRect aTR(aBmpRect.Left(), aBmpRect.Top(), aBmpRect.GetWidth(), 
aBmpRect.GetHeight(),
+nOffX, nOffY, aOutSz.Width(), aOutSz.Height());
 
-bool bFastBlend = false;
-if( !bHMirr && !bVMirr )
+bFastBlend = ImplFastBitmapBlending(*pB, *pP, *pA, aTR);
+}
+
+if (!bFastBlend)
+{
+for (int nY = 0; nY < nDstHeight; nY++)
 {
-SalTwoRect aTR(aBmpRect.Left(), aBmpRect.Top(), 
aBmpRect.GetWidth(), aBmpRect.GetHeight(),
-nOffX, nOffY, aOutSz.Width(), aOutSz.Height());
+tools::Long  nMapY = pMapY[nY];
 
-bFastBlend = ImplFastBitmapBlending( *pB,*pP,*pA, aTR );
-}
+if (bVMirr)
+nMapY = aBmpRect.Bottom() - nMapY;
 
-if( !bFastBlend )
-{
-for( int nY = 0; nY < nDstHeight; nY++ )
+Scanline pAScan = pA->GetScanline(nMapY);
+Scanline pBScan = pB->GetScanline(nY);
+for(int nX = 0; nX < nDstWidth; nX++)
 {
-tools::Long  nMapY = pMapY[ nY ];
+tools::Long nMapX = pMapX[nX];
 
-if ( bVMirr )
-{
-nMapY = aBmpRect.Bottom() - nMapY;
-}
-Scanline pAScan = pA->GetScanline( nMapY );
-Scanline pBScan = pB->GetScanline(nY);
-for( int nX = 0; nX < nDstWidth; nX++ )
-{
-tools::Long nMapX = pMapX[ nX ];
+if (bHMirr)
+nMapX = aBmpRect.Right() - nMapX;
 
-if ( bHMirr )
-{
-nMapX = aBmpRect.Right() - nMapX;
-}
-BitmapColor aDstCol = pB->GetPixelFromData( pBScan, nX );
-aDstCol.Merge( pP->GetColor( nMapY, nMapX ), pAScan[ nMapX 
] );
-pB->SetPixelOnData( pBScan, nX, aDstCol );
-}
+BitmapColor aDstCol = pB->GetPixelFromData(pBScan, nX);
+aDstCol.Merge(pP->GetColor(nMapY, nMapX), pAScan[nMapX]);
+pB->SetPixelOnData(pBScan, nX, aDstCol);
 }
 }
-
-pB.reset();
-res = aBmp;
 }
 
-return res;
+pB.reset();
+return aBmp;
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

[Libreoffice-commits] core.git: vcl/source

2023-10-26 Thread Chris Sherlock (via logerrit)

 vcl/source/outdev/bitmapex.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit d35236adb3fc561f49134a88c7468411527ee3d5
Author: Chris Sherlock 
AuthorDate: Sun Sep 24 00:58:17 2023 +1000
Commit: Tomaž Vajngerl 
CommitDate: Fri Oct 27 05:50:44 2023 +0200

vcl: flatten OutputDevice::GetBitmapEx()

Change-Id: I85e7767cd2665febd289cc1fd023d30ab80cfe5d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157191
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/vcl/source/outdev/bitmapex.cxx b/vcl/source/outdev/bitmapex.cxx
index e849f4b73181..b4fa9641a1e5 100644
--- a/vcl/source/outdev/bitmapex.cxx
+++ b/vcl/source/outdev/bitmapex.cxx
@@ -160,8 +160,8 @@ BitmapEx OutputDevice::GetBitmapEx( const Point& rSrcPt, 
const Size& rSize ) con
 
 return BitmapEx(GetBitmap( rSrcPt, rSize ), AlphaMask( aAlphaBitmap ) 
);
 }
-else
-return BitmapEx(GetBitmap( rSrcPt, rSize ));
+
+return BitmapEx(GetBitmap( rSrcPt, rSize ));
 }
 
 void OutputDevice::DrawDeviceBitmapEx( const Point& rDestPt, const Size& 
rDestSize,

[Libreoffice-commits] core.git: solenv/clang-format vcl/Library_vcl.mk vcl/source

2023-10-26 Thread Chris Sherlock (via logerrit)

 solenv/clang-format/excludelist |2 +-
 vcl/Library_vcl.mk  |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 60abfe9e514d71a14b388f0156b31a4be5896686
Author: Chris Sherlock 
AuthorDate: Sat Sep 30 12:08:32 2023 +1000
Commit: Tomaž Vajngerl 
CommitDate: Fri Oct 27 05:49:53 2023 +0200

vcl: move textlayout.cxx from gdi to text directory

Change-Id: Ia8efd1d984c94b4fa6d77759fa8c8ec8834ac140
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157415
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/solenv/clang-format/excludelist b/solenv/clang-format/excludelist
index 0b81e5a560d5..5e334c0cbcfd 100644
--- a/solenv/clang-format/excludelist
+++ b/solenv/clang-format/excludelist
@@ -14764,7 +14764,6 @@ vcl/source/gdi/salgdilayout.cxx
 vcl/source/gdi/sallayout.cxx
 vcl/source/gdi/salmisc.cxx
 vcl/source/gdi/scrptrun.cxx
-vcl/source/gdi/textlayout.cxx
 vcl/source/gdi/vectorgraphicdata.cxx
 vcl/source/gdi/virdev.cxx
 vcl/source/gdi/wall.cxx
@@ -14817,6 +14816,7 @@ vcl/source/outdev/transparent.cxx
 vcl/source/outdev/vclreferencebase.cxx
 vcl/source/outdev/wallpaper.cxx
 vcl/source/text/ImplLayoutRuns.cxx
+vcl/source/text/textlayout.cxx
 vcl/source/toolkit/group.cxx
 vcl/source/toolkit/morebtn.cxx
 vcl/source/treelist/headbar.cxx
diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk
index e15b54c4e918..4c8162459835 100644
--- a/vcl/Library_vcl.mk
+++ b/vcl/Library_vcl.mk
@@ -244,6 +244,7 @@ $(eval $(call gb_Library_add_exception_objects,vcl,\
 vcl/source/outdev/map \
 vcl/source/text/ImplLayoutArgs \
 vcl/source/text/TextLayoutCache \
+vcl/source/text/textlayout \
 vcl/source/treelist/headbar \
 vcl/source/treelist/iconview \
 vcl/source/treelist/iconviewimpl \
@@ -303,7 +304,6 @@ $(eval $(call gb_Library_add_exception_objects,vcl,\
 vcl/source/gdi/sallayout \
 vcl/source/gdi/salmisc \
 vcl/source/gdi/vectorgraphicdata \
-vcl/source/gdi/textlayout \
 vcl/source/gdi/virdev \
 vcl/source/gdi/wall \
 vcl/source/gdi/scrptrun \
diff --git a/vcl/source/gdi/textlayout.cxx b/vcl/source/text/textlayout.cxx
similarity index 100%
rename from vcl/source/gdi/textlayout.cxx
rename to vcl/source/text/textlayout.cxx

[Libreoffice-commits] core.git: vcl/source

2023-10-26 Thread Chris Sherlock (via logerrit)

 vcl/source/gdi/textlayout.cxx |  182 ++
 1 file changed, 96 insertions(+), 86 deletions(-)

New commits:
commit adba3022f14d28090a668da10fc3311633535ae8
Author: Chris Sherlock 
AuthorDate: Thu Sep 28 21:14:15 2023 +1000
Commit: Tomaž Vajngerl 
CommitDate: Fri Oct 27 05:48:33 2023 +0200

vcl: flatten TextLayoutCommon::GetEllipsisString()

Change-Id: I04a5eed7a6fbd2d4c7f31006c73729cf79a2ed02
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157367
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/vcl/source/gdi/textlayout.cxx b/vcl/source/gdi/textlayout.cxx
index 2eaf5746f30b..a1597c69793e 100644
--- a/vcl/source/gdi/textlayout.cxx
+++ b/vcl/source/gdi/textlayout.cxx
@@ -75,117 +75,127 @@ namespace vcl
 OUString aStr = rOrigStr;
 sal_Int32 nIndex = GetTextBreak( aStr, nMaxWidth, 0, aStr.getLength() 
);
 
-if ( nIndex != -1 )
+if (nIndex == -1)
+return aStr;
+
+if( (nStyle & DrawTextFlags::CenterEllipsis) == 
DrawTextFlags::CenterEllipsis )
 {
-if( (nStyle & DrawTextFlags::CenterEllipsis) == 
DrawTextFlags::CenterEllipsis )
+OUStringBuffer aTmpStr( aStr );
+// speed it up by removing all but 1.33x as many as the break pos.
+sal_Int32 nEraseChars = std::max(4, aStr.getLength() - 
(nIndex*4)/3);
+while( nEraseChars < aStr.getLength() && GetTextWidth( 
aTmpStr.toString(), 0, aTmpStr.getLength() ) > nMaxWidth )
 {
-OUStringBuffer aTmpStr( aStr );
-// speed it up by removing all but 1.33x as many as the break 
pos.
-sal_Int32 nEraseChars = std::max(4, 
aStr.getLength() - (nIndex*4)/3);
-while( nEraseChars < aStr.getLength() && GetTextWidth( 
aTmpStr.toString(), 0, aTmpStr.getLength() ) > nMaxWidth )
-{
-aTmpStr = aStr;
-sal_Int32 i = (aTmpStr.getLength() - nEraseChars)/2;
-aTmpStr.remove(i, nEraseChars++);
-aTmpStr.insert(i, "...");
-}
-aStr = aTmpStr.makeStringAndClear();
+aTmpStr = aStr;
+sal_Int32 i = (aTmpStr.getLength() - nEraseChars)/2;
+aTmpStr.remove(i, nEraseChars++);
+aTmpStr.insert(i, "...");
 }
-else if ( nStyle & DrawTextFlags::EndEllipsis )
+aStr = aTmpStr.makeStringAndClear();
+}
+else if ( nStyle & DrawTextFlags::EndEllipsis )
+{
+aStr = aStr.copy(0, nIndex);
+if ( nIndex > 1 )
 {
-aStr = aStr.copy(0, nIndex);
-if ( nIndex > 1 )
+aStr += "...";
+while ( !aStr.isEmpty() && ( GetTextWidth( aStr, 0, 
aStr.getLength() ) > nMaxWidth) )
 {
-aStr += "...";
-while ( !aStr.isEmpty() && ( GetTextWidth( aStr, 0, 
aStr.getLength() ) > nMaxWidth) )
-{
-if ( (nIndex > 1) || (nIndex == aStr.getLength()) )
-nIndex--;
-aStr = aStr.replaceAt( nIndex, 1, u"");
-}
+if ( (nIndex > 1) || (nIndex == aStr.getLength()) )
+nIndex--;
+aStr = aStr.replaceAt( nIndex, 1, u"");
 }
+}
 
-if ( aStr.isEmpty() && (nStyle & DrawTextFlags::Clip) )
-aStr += OUStringChar(rOrigStr[ 0 ]);
+if ( aStr.isEmpty() && (nStyle & DrawTextFlags::Clip) )
+aStr += OUStringChar(rOrigStr[ 0 ]);
+}
+else if ( nStyle & DrawTextFlags::PathEllipsis )
+{
+OUString aPath( rOrigStr );
+OUString aAbbreviatedPath;
+osl_abbreviateSystemPath( aPath.pData, , 
nIndex, nullptr );
+aStr = aAbbreviatedPath;
+}
+else if ( nStyle & DrawTextFlags::NewsEllipsis )
+{
+static char const   pSepChars[] = ".";
+// Determine last section
+sal_Int32 nLastContent = aStr.getLength();
+while ( nLastContent )
+{
+nLastContent--;
+if ( ImplIsCharIn( aStr[ nLastContent ], pSepChars ) )
+break;
 }
-else if ( nStyle & DrawTextFlags::PathEllipsis )
+while ( nLastContent &&
+ImplIsCharIn( aStr[ nLastContent-1 ], pSepChars ) )
+nLastContent--;
+
+OUString aLastStr = aStr.copy(nLastContent);
+OUString aTempLastStr1 = "..." + aLastStr;
+if ( GetTextWidth( aTempLastStr1, 0, aTempLastStr1.getLength() ) > 
nMaxWidth )
 {
-OUString aPath( rOrigStr );
-OUString aAbbreviatedPath;
-

[Libreoffice-bugs] [Bug 157930] MENU: Easily insert commonly used conditional formatting rules

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157930

--- Comment #3 from Tomaz Vajngerl  ---
Similar dialogs that have an entry to select a range usually have a button next
to the range entry to switch to the spreadsheet range selection view, which I
think Heiko is referring to. See any of the Data -> Statistics dialogs. Without
that in some cases the range selection doesn't work properly.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 157930] MENU: Easily insert commonly used conditional formatting rules

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157930

--- Comment #3 from Tomaz Vajngerl  ---
Similar dialogs that have an entry to select a range usually have a button next
to the range entry to switch to the spreadsheet range selection view, which I
think Heiko is referring to. See any of the Data -> Statistics dialogs. Without
that in some cases the range selection doesn't work properly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 157725] Signing a PDF has no visible effect, signature is not listed

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157725

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154441] Unstable - regular crashes

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=154441

--- Comment #5 from QA Administrators  ---
Dear david.c.day,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154204] Vertical alignment "center" only works for first cell

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=154204

--- Comment #4 from QA Administrators  ---
Dear Konrad Marek,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 77999] [META] Autosave/Autorecovery/Backup copy issues

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=77999
Bug 77999 depends on bug 154153, which changed state.

Bug 154153 Summary: [WRITER] [EDITING] copy-paste content with many tables into 
new file makes Writer crash (autorecovery maybe involved)
https://bugs.documentfoundation.org/show_bug.cgi?id=154153

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154153] [WRITER] [EDITING] copy-paste content with many tables into new file makes Writer crash (autorecovery maybe involved)

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=154153

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154153] [WRITER] [EDITING] copy-paste content with many tables into new file makes Writer crash (autorecovery maybe involved)

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=154153

--- Comment #12 from QA Administrators  ---
Dear loic_dupont,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153902] In DATA VALIDITY, list selection has a conflict between mouse and keyboard.

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=153902

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153902] In DATA VALIDITY, list selection has a conflict between mouse and keyboard.

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=153902

--- Comment #4 from QA Administrators  ---
Dear Juan Perez,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152718] Curve auto numbering on merged cells

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=152718

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152718] Curve auto numbering on merged cells

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=152718

--- Comment #8 from QA Administrators  ---
Dear Ruslan,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155053] Low resolution while inserting animated GIF

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=155053

--- Comment #6 from QA Administrators  ---
Dear mauricio.misraji,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147688] Scroll (rolagem com dois dedos) do touchpad do notebook lenovo não funciona

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147688

--- Comment #2 from QA Administrators  ---
Dear pedro160901,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146855] UI: The ability to set spellchecking language on a per-cell basis is difficult to discover

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146855

--- Comment #3 from QA Administrators  ---
Dear hexagon-recursion,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 92381] Tooltips for Styles Pane wrong with GB locale

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92381

Aron Budea  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 92381] Tooltips for Styles Pane wrong with GB locale

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92381

--- Comment #13 from polinkuer12  ---
I encountered this situation. need to fix it immediately!
https://super-mario.io

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157939] SVG import/boxes instead of text (regression)

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157939

--- Comment #2 from Dave Gilbert  ---

trying 359190cb6ae2c76356de7f9368abc849c7696415 - good 
   5127b1961b762643d47a26704556fd9b8664c6fc - bad
   b9ffee3074d8eb0e95b3d8f78cb7aac10b41c279 - bad  
   af83536685cf50a564d9c8290bf6ea5982de73b7 - bad  
   211c4df7656bc81617e98ec89466c12f998a6130   bad  
   dc748d7dbd114fbf663752258dbaf003af2926c3 - bad  
   e64d85c9eb18642ed3a0526f3dd8db9a4b88e629 - bad  

Got further to go; but I'm suspicious I've only had that one good version; so
I'm a bit worried where the bisect will lead.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: cui/source

2023-10-26 Thread Justin Luth (via logerrit)

 cui/source/tabpages/chardlg.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 7ac066438f6d029fd0be2f0c72207805b0ca8153
Author: Justin Luth 
AuthorDate: Thu Oct 26 15:48:30 2023 -0400
Commit: Justin Luth 
CommitDate: Fri Oct 27 02:38:36 2023 +0200

tdf#156988 chardlg: default to AUTO escapement

As of 24.2, the default value for a superscript or subscript
is automatic placement since d384ccdb04ebeb8b094e6d9a2ddf4e5aea5327c8.

Therefore, it makes sense for the character properties
dialog to also default to automatic.

Normally this happens - since normally there is some kind of context,
and in that case m_xNormalPosBtn was set with AUTO (m_xHighLowRB).
However, in the case of finding a formating, there is no context
for the very first run. That is what this patch intended to fix,
since in that case too we want m_xHighLowRB to be set to true.

For any other similar situation where there is no context,
assuming DFLT_ESC_AUTO_SUPER or DFLT_ESC_AUTO_SUB
should be appropriate.

Change-Id: I1ee78c72bbb1c3d23fa39da29322436632f12b14
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158514
Tested-by: Jenkins
Reviewed-by: Justin Luth 

diff --git a/cui/source/tabpages/chardlg.cxx b/cui/source/tabpages/chardlg.cxx
index 3075f3fc4258..d8ea76e9a9d4 100644
--- a/cui/source/tabpages/chardlg.cxx
+++ b/cui/source/tabpages/chardlg.cxx
@@ -2748,6 +2748,8 @@ void SvxCharPositionPage::Reset( const SfxItemSet* rSet )
 m_xHighPosBtn->set_active(false);
 m_xNormalPosBtn->set_active(false);
 m_xLowPosBtn->set_active(false);
+
+m_xHighLowRB->set_active(true);
 }
 
 // set BspFont

[Libreoffice-bugs] [Bug 157939] SVG import/boxes instead of text (regression)

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157939

--- Comment #1 from Dave Gilbert  ---
Created attachment 190444
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190444=edit
Screen crop of bad import

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157939] New: SVG import/boxes instead of text (regression)

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157939

Bug ID: 157939
   Summary: SVG import/boxes instead of text (regression)
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: filters and storage
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: freedesk...@treblig.org

I first noticed this on master with a test failure of:

/discs/fast/core/test/source/xmltesttools.cxx:95:testTdf97542_2::TestBody
equality assertion failed
- Expected: 1
- Actual  : 0
- In <>, XPath '/primitive2D/transform/objectinfo/svgradialgradient' number of
nodes is incorrect

so I tried loading the test file and it's misrendering it.
That is;

a) Start LO
b) Create  a writer doc
c) Insert image from file
d) Insert the ./svgio/qa/cppunit/data/tdf97542_1.svg or
./svgio/qa/cppunit/data/tdf97542_2.svg file
e) Expected: word 'Text' on shaded background
   Actual: 4 boxes in the correct foreground colour instead of the 'text'

Currently bisecting:
359190cb6ae2c76356de7f9368abc849c7696415  good
e64d85c9eb18642ed3a0526f3dd8db9a4b88e629  bad

Fedora 39 x86-64 host.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Zachary Yona license statement

2023-10-26 Thread Zachary Yona


   All of my past & future contributions to LibreOffice may be
   licensed under the MPLv2/LGPLv3+ dual license.

[Libreoffice-bugs] [Bug 144021] Character transparency should apply to objects anchored as character

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=144021

--- Comment #7 from Dieter  ---
(In reply to Dieter from comment #6)
> So I would like to gibe this question back to you heko and perhaps
> design-team.

Heiko, any reactions on my comment?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149432] Weird Hebrew font used by default on Windows 7

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149432

Dieter  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #18 from Dieter  ---
Salomo, nobody could confirm the bug for more than 1 1/2 years. Is it still
present unser Windows 7 and with the latest version of LO?
NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157921] Collaboration feature missing in Libreoffice: offline enhancement suggestion with user registration and peer to peer document updates

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157921

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||stephane.guillou@libreoffic
   ||e.org
 Status|UNCONFIRMED |NEEDINFO

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
See the following relevant reports:
- Bug 88127 - [RFE] Ability to collaborate on documents over GIT
. Bug 85660 - FILESAVE: Improve source control compatibility of flat ODF files
- Bug 97282 - Enhanced Change Tracking/collaboration proposal - immutable XML
- Bug 133984 - Enhancement: Support for real-time and offline collaborative
editing in LibreOffice (desktop)

Maybe your request is already covered by some / all of them? Please see the
discussions there.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157934] v7.6 crashes when saving a file in Ubuntu 22.04

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157934

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1
 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
Can you please check with these packages installed?

sudo apt install libcanberra-gtk-module libcanberra-gtk3-module

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 45261] EDITING: unbalanced distribution of text between columns

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=45261

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org
   Hardware|Other   |All

--- Comment #21 from Stéphane Guillou (stragu) 
 ---
(In reply to Buovjaga from comment #11)
> Confirmed.
> If I go to Format - Columns, uncheck the Evenly distribute option, ok, then
> go back and check it, it works ok. Saving & reloading brings it back to the
> non-even state.

Reproduced the same in recent master build:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: fd69b546ad36452560cb11ccb28e78632d65f045
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

However, note that this method doesn't even fix it temporarily for attachment
190443 from duplicate bug 157727.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157938] New: possible missing font for %kappa in pdf with embedded fonts

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157938

Bug ID: 157938
   Summary: possible missing font for %kappa in pdf with embedded
fonts
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Formula Editor
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: banjo5...@att.net

With fonts embedded and exporting to pdf, any equation that uses %kappa will
result in the Greek kappa being dropped from the equation when uploading the
pdf to Kindle Direct Publishing (KDP). All other Greek letters in equations are
recognized by KDP just fine, but not kappa. However, if the kappa is entered in
a text line as a Basic Greek character then KDP recognizes it. It is only with
the equation editor that kappa is not recognized by KDP. The temporary solution
to this problem is to never use Greek kappa in any equations that are to be
published through KDP.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157727] distribution of text in columns inside sections can be unstable

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157727

--- Comment #15 from Stéphane Guillou (stragu) 
 ---
Created attachment 190443
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190443=edit
smaller sample ODT based on original

See this smaller reproduced:

1. See uneven distribution in one of the chapters (different depending on
version used)
2. Format > Columns > untick "Evenly distribute contents to all columns", click
OK
3. Turn it back on again

In 7.5 and 7.6, it fixes it, but is bad again after save + reload, like in bug
45261 comment 11 (tested in Chapter 45 for 7.5.7.1, and in chapter 44 for
7.6.2.1)
In a recent master build, the turning off then back on does not even fix it
temporarily (tested in Chapter 46).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 45261] EDITING: unbalanced distribution of text between columns

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=45261

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||traceyad2...@gmail.com

--- Comment #20 from Stéphane Guillou (stragu) 
 ---
*** Bug 157727 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157727] distribution of text in columns inside sections can be unstable

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157727

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Summary|column format in sections   |distribution of text in
   |can be unstable |columns inside sections can
   ||be unstable
 Resolution|--- |DUPLICATE
 CC||stephane.guillou@libreoffic
   ||e.org
 Status|UNCONFIRMED |RESOLVED
 OS|Windows (All)   |All

--- Comment #14 from Stéphane Guillou (stragu) 
 ---
(In reply to Tracey from comment #12)
> Created attachment 190439 [details]
> Attached pdf shows an issue at the bottom of page 719 (mid-column break)
> It should NOT break at his point.

I can see that issue in and around "Psa 046 mid-break": uneven column
distribution in chapters 44, 46, 47.

Version: 7.5.7.1 (X86_64) / LibreOffice Community
Build ID: 47eb0cf7efbacdee9b19ae25d6752381ede23126
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

This is the same issue as in bug 45261, marking as duplicate.

*** This bug has been marked as a duplicate of bug 45261 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156988] Find cannot find superscripted or subscripted text

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=156988

Justin L  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |jl...@mail.com
   |desktop.org |
 Status|NEW |ASSIGNED

--- Comment #9 from Justin L  ---
proposed fix at https://gerrit.libreoffice.org/c/core/+/158514

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Changes to 'refs/tags/cp-23.05.5-3'

2023-10-26 Thread Andras Timar (via logerrit)

Tag 'cp-23.05.5-3' created by Andras Timar  at 
2023-10-26 20:43 +

cp-23.05.5-3

Changes since cp-23.05.5-2-38:
---
 0 files changed
---

[Libreoffice-commits] translations.git: Changes to 'refs/tags/cp-23.05.5-3'

2023-10-26 Thread Andras Timar (via logerrit)

Tag 'cp-23.05.5-3' created by Andras Timar  at 
2023-10-26 20:43 +

cp-23.05.5-3

Changes since cp-23.05.5-2-1:
---
 0 files changed
---

[Libreoffice-commits] help.git: Changes to 'refs/tags/cp-23.05.5-3'

2023-10-26 Thread Andras Timar (via logerrit)

Tag 'cp-23.05.5-3' created by Andras Timar  at 
2023-10-26 20:43 +

cp-23.05.5-3

Changes since cp-23.05.4-2-9:
---
 0 files changed
---

[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/cp-23.05.5-3'

2023-10-26 Thread Andras Timar (via logerrit)

Tag 'cp-23.05.5-3' created by Andras Timar  at 
2023-10-26 20:43 +

cp-23.05.5-3

Changes since co-23.05-branch-point:
Andras Timar (1):
  On Linux dictionaries are packaged separately

---
 Module_dictionaries.mk |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
---

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - configure.ac

2023-10-26 Thread Andras Timar (via logerrit)

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e7921fedb8b5615b0dc7cd3ec8b91c9b4e06d002
Author: Andras Timar 
AuthorDate: Thu Oct 26 22:43:25 2023 +0200
Commit: Andras Timar 
CommitDate: Thu Oct 26 22:43:25 2023 +0200

Bump version to 23.05.5.3

Change-Id: I1b535bb0a6dcd43866ef9f278249d75b9c31c3d8

diff --git a/configure.ac b/configure.ac
index f785e0dd8d43..27d297d7056b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([Collabora Office],[23.05.5.2],[],[],[https://collaboraoffice.com/])
+AC_INIT([Collabora Office],[23.05.5.3],[],[],[https://collaboraoffice.com/])
 
 dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just 
fine if it is installed
 dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails 
hard

[Libreoffice-bugs] [Bug 157721] SimpleCommandMail: subject and body truncated at the comma (Ubuntu + Thunderbird)

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157721

--- Comment #7 from TISSENDIER Pierre  ---
(In reply to TISSENDIER Pierre from comment #6)
> Created attachment 190442 [details]
> With SHELL ans thunderbird commandline with hyphen

 Sorry  Not hyphen, I mean simple quote !

The suject and bodytext shoulde be framed by simple quote !

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 83946] [META] Tracking changes issues

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=83946

László Németh  changed:

   What|Removed |Added

 Depends on||157937


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157937
[Bug 157937] EDITING Cycle case with change tracking freezes Writer
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157937] EDITING Cycle case with change tracking freezes Writer

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157937

László Németh  changed:

   What|Removed |Added

 CC||nem...@numbertext.org
   Severity|normal  |major
 Ever confirmed|0   |1
   Assignee|libreoffice-b...@lists.free |nem...@numbertext.org
   |desktop.org |
 Blocks||83946
 Status|UNCONFIRMED |ASSIGNED


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=83946
[Bug 83946] [META] Tracking changes issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - 5 commits - configure.ac vcl/osx vcl/qa vcl/source vcl/unx

2023-10-26 Thread Caolán McNamara (via logerrit)

 configure.ac   |   15 
 vcl/osx/salframe.cxx   |   25 
 vcl/qa/cppunit/pdfexport/data/PDF_export_with_formcontrol.fodt |  174 ++
 vcl/qa/cppunit/pdfexport/pdfexport.cxx |  258 
++
 vcl/source/gdi/impgraph.cxx|   11 
 vcl/source/gdi/pdfextoutdevdata.cxx|   20 
 vcl/source/gdi/pdfwriter_impl.cxx  |   18 
 vcl/unx/gtk3/gtkinst.cxx   |   11 
 8 files changed, 518 insertions(+), 14 deletions(-)

New commits:
commit 47989d35a5ed3736ca3d30b0a34fc74c48755ddc
Author: Caolán McNamara 
AuthorDate: Fri Oct 20 14:38:29 2023 +0100
Commit: Andras Timar 
CommitDate: Thu Oct 26 22:40:42 2023 +0200

Resolves: tdf#157849 gtk_spin_button_update callback can delete widget

so later GtkInstanceEditable::signal_activate is on deleted widget

Change-Id: I9bb9848b4554792db11fc7b0e2d3491a94975b3f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158168
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index 70930a1267c0..badf271e9521 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -17257,6 +17257,12 @@ IMPL_LINK_NOARG(GtkInstanceIconView, 
async_signal_selection_changed, void*, void
 
 namespace {
 
+void signalDestroyFlag(GtkWidget*, gpointer destroyed)
+{
+bool* pDestroyed = static_cast(destroyed);
+*pDestroyed = true;
+}
+
 class GtkInstanceSpinButton : public GtkInstanceEditable, public virtual 
weld::SpinButton
 {
 private:
@@ -17311,7 +17317,12 @@ private:
 
 virtual void signal_activate() override
 {
+bool bActivateDestroy(false);
+gulong nDestroySignalId = g_signal_connect(m_pButton, "destroy", 
G_CALLBACK(signalDestroyFlag), );
 gtk_spin_button_update(m_pButton);
+if (bActivateDestroy)
+return;
+g_signal_handler_disconnect(m_pButton, nDestroySignalId);
 GtkInstanceEditable::signal_activate();
 }
 
commit 7c556b9385d503fb9d03a274e4add54537b7ac9e
Author: Michael Stahl 
AuthorDate: Tue Oct 10 18:20:04 2023 +0200
Commit: Andras Timar 
CommitDate: Thu Oct 26 22:40:42 2023 +0200

tdf#157397 vcl: PDF export: fix CreateControl replay

The problem is that the CreateLink and CreateControl actions are
replayed in a different order than they are recorded, because CreateLink
is a global action, and CreateControl a page action.

This means that the mCurId at the time when
PDFExtOutDevData::CreateControl() is called does not correspond to a
position in mParaIds when CreateControl is replayed; it will be inserted
too early and bump all the CreateLink ones to later indexes.

Avoid this by adding another global action CreateControlLink that is
added when CreateControl is being replayed, which appears to work.

(Another subtle problem is that, in case of PDF/A-1, the page actions
could be discarded completely; this should work in that case too.)

(regression from commit d4d471fc88fe4fd14f44dfccdfe360dec327d4f0)

Change-Id: I92d89ac08db6548e9f0d1480d984aeacb4d22262
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157767
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit 2e32aa1e9fc240c9cd9854655106d0decbd3694a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157863
Reviewed-by: Miklos Vajna 

diff --git a/vcl/qa/cppunit/pdfexport/data/PDF_export_with_formcontrol.fodt 
b/vcl/qa/cppunit/pdfexport/data/PDF_export_with_formcontrol.fodt
new file mode 100644
index ..4aa4a92b6710
--- /dev/null
+++ b/vcl/qa/cppunit/pdfexport/data/PDF_export_with_formcontrol.fodt
@@ -0,0 +1,174 @@
+
+http://www.w3.org/TR/css3-text/; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:office="urn:oasis:names:tc:opendocument:xmlns:office:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0" 
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:xlink="http://www.w3.org/1999/xlink; 
xmlns:drawooo="http://openoffice.org/2010/draw; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dc="http://purl.org/dc/elements/1.1/; xmlns:c
 alcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - desktop/source

2023-10-26 Thread Marco Cecchetti (via logerrit)

 desktop/source/lib/init.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e5481fdaf33a3921ef0624e8a62e28e2f68086da
Author: Marco Cecchetti 
AuthorDate: Thu Oct 26 20:22:17 2023 +0200
Commit: Andras Timar 
CommitDate: Thu Oct 26 22:36:34 2023 +0200

lok a11y: calc: make possible to enable accessibility for spreadsheets

Change-Id: I462b2d386b58a895bd4c45d4bd61a049404d3848
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158512
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 17535c7cb3b2..aff6e4954a45 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -7185,7 +7185,7 @@ static void 
doc_setAccessibilityState(SAL_UNUSED_PARAMETER LibreOfficeKitDocumen
 SolarMutexGuard aGuard;
 
 int nDocType = getDocumentType(pThis);
-if (!(nDocType == LOK_DOCTYPE_TEXT || nDocType == 
LOK_DOCTYPE_PRESENTATION))
+if (!(nDocType == LOK_DOCTYPE_TEXT || nDocType == LOK_DOCTYPE_PRESENTATION 
|| nDocType == LOK_DOCTYPE_SPREADSHEET))
 return;
 
 SfxLokHelper::setAccessibilityState(nId, nEnabled);

[Libreoffice-bugs] [Bug 157916] MySQL/MariaDB direct Connection: Impossible to input data in a query created by GUI for more than one table

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157916

Julien Nabet  changed:

   What|Removed |Added

 CC|serval2...@yahoo.fr |

--- Comment #7 from Julien Nabet  ---
After having spent several hours, I give up.
Each time I thought I was on the right way, I finally looped on an already
encountered method.
=> uncc myself.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157936] Calc EDITING: pressing context menu key in a cell causes context menus of calc as well as the cell to popup at same time with focus on calc context menu

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157936

VincentYu  changed:

   What|Removed |Added

   Hardware|All |x86-64 (AMD64)
 OS|All |Windows (All)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157937] New: EDITING Cycle case with change tracking freezes Writer

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157937

Bug ID: 157937
   Summary: EDITING Cycle case with change tracking freezes Writer
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: nem...@numbertext.org

Cycle case can freeze LibreOffice.

Test case:

1. Open https://bugs.documentfoundation.org/attachment.cgi?id=190256 (test
document of https://bugs.documentfoundation.org/show_bug.cgi?id=119908#c15);

2. Select the first paragraph e.g. by clicking 3 times before it;

3. Enable Record Track Changes;

4. Press Shift-F3 3 times to change cycle case. Writer freezes immediately.

Likely regression since commit 2d3c77e9b10f20091ef338e262ba7756eb280ce9
"tdf#109266 sw change tracking: track transliteration".

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157936] New: Calc EDITING: pressing context menu key in a cell causes context menus of calc as well as the cell to popup at same time with focus on calc context menu

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157936

Bug ID: 157936
   Summary: Calc EDITING: pressing context menu key in a cell
causes context menus of calc as well as the cell to
popup at same time with focus on calc context menu
   Product: LibreOffice
   Version: 7.5.6.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: vincent_hy...@hotmail.com

Description:
Click any cell then press context menu key on keyboard causes context menus of
both calc(at upper left corner) and the cell(at the cell) to popup. The input
focus is at the context menu of calc at upper left corner.
Expect only menu of the cell to popup.

Steps to Reproduce:
1.launch calc
2.click any cell to put input focus there
3.press context menu key on keyboard

Actual Results:
both context menu of calc application at upper left corner and context menu for
the cell clicked poped up. The input focus is at the context menu of calc
application at upper left corner.

Expected Results:
only the context menu for the cell click should appear and had the input focus.


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Version: 7.5.7.1 (X86_64) / LibreOffice Community
Build ID: 47eb0cf7efbacdee9b19ae25d6752381ede23126
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - sc/CppunitTest_sc_theme_import_export_test.mk

2023-10-26 Thread Mike Kaganski (via logerrit)

 sc/CppunitTest_sc_theme_import_export_test.mk |1 +
 1 file changed, 1 insertion(+)

New commits:
commit aac3bbcd5cb904672f735713d42e21f6049d
Author: Mike Kaganski 
AuthorDate: Thu Oct 26 09:00:25 2023 +0200
Commit: Mike Kaganski 
CommitDate: Thu Oct 26 22:26:40 2023 +0200

Missing dependency

[build LNK] CppunitTest/test_sc_theme_import_export_test.dll
ThemeImportExportTest.o : error LNK2019: unresolved external symbol 
"__declspec(dllimport) public: class editeng::SvxBorderLine const * __cdecl 
SvxBoxItem::GetT
op(void)const " 
(__imp_?GetTop@SvxBoxItem@@QEBAPEBVSvxBorderLine@editeng@@XZ) referenced in 
function "void __cdecl `anonymous namespace'::checkCellBorderThemeCo
lor(class ScDocument *)" 
(?checkCellBorderThemeColor@?A0x620fdfa5@@YAXPEAVScDocument@@@Z)
ThemeImportExportTest.o : error LNK2019: unresolved external symbol 
"__declspec(dllimport) public: class editeng::SvxBorderLine const * __cdecl 
SvxBoxItem::GetB
ottom(void)const " 
(__imp_?GetBottom@SvxBoxItem@@QEBAPEBVSvxBorderLine@editeng@@XZ) referenced in 
function "void __cdecl `anonymous namespace'::checkCellBorderT
hemeColor(class ScDocument *)" 
(?checkCellBorderThemeColor@?A0x620fdfa5@@YAXPEAVScDocument@@@Z)
ThemeImportExportTest.o : error LNK2019: unresolved external symbol 
"__declspec(dllimport) public: class editeng::SvxBorderLine const * __cdecl 
SvxBoxItem::GetL
eft(void)const " 
(__imp_?GetLeft@SvxBoxItem@@QEBAPEBVSvxBorderLine@editeng@@XZ) referenced in 
function "void __cdecl `anonymous namespace'::checkCellBorderTheme
Color(class ScDocument *)" 
(?checkCellBorderThemeColor@?A0x620fdfa5@@YAXPEAVScDocument@@@Z)
ThemeImportExportTest.o : error LNK2019: unresolved external symbol 
"__declspec(dllimport) public: class editeng::SvxBorderLine const * __cdecl 
SvxBoxItem::GetR
ight(void)const " 
(__imp_?GetRight@SvxBoxItem@@QEBAPEBVSvxBorderLine@editeng@@XZ) referenced in 
function "void __cdecl `anonymous namespace'::checkCellBorderThe
meColor(class ScDocument *)" 
(?checkCellBorderThemeColor@?A0x620fdfa5@@YAXPEAVScDocument@@@Z)
ThemeImportExportTest.o : error LNK2019: unresolved external symbol 
"__declspec(dllimport) public: class Color const & __cdecl 
SvxBrushItem::GetColor(void)const
 " (__imp_?GetColor@SvxBrushItem@@QEBAAEBVColor@@XZ) referenced in function 
"void __cdecl `anonymous namespace'::checkCellBackgroundThemeColor(class 
ScDocument
*)" (?checkCellBackgroundThemeColor@?A0x620fdfa5@@YAXPEAVScDocument@@@Z)
ThemeImportExportTest.o : error LNK2019: unresolved external symbol 
"__declspec(dllimport) public: class model::ComplexColor __cdecl 
SvxBrushItem::getComplexCol
or(void)const " 
(__imp_?getComplexColor@SvxBrushItem@@QEBA?AVComplexColor@model@@XZ) referenced 
in function "void __cdecl `anonymous namespace'::checkCellBackgr
oundThemeColor(class ScDocument *)" 
(?checkCellBackgroundThemeColor@?A0x620fdfa5@@YAXPEAVScDocument@@@Z)
ThemeImportExportTest.o : error LNK2019: unresolved external symbol 
"__declspec(dllimport) public: class Color const & __cdecl 
SvxColorItem::getColor(void)const
 " (__imp_?getColor@SvxColorItem@@QEBAAEBVColor@@XZ) referenced in function 
"void __cdecl `anonymous namespace'::checkCellTextThemeColor(class ScDocument 
*)" (?
checkCellTextThemeColor@?A0x620fdfa5@@YAXPEAVScDocument@@@Z)
ThemeImportExportTest.o : error LNK2019: unresolved external symbol 
"__declspec(dllimport) public: class model::ComplexColor const & __cdecl 
SvxColorItem::getCo
mplexColor(void)const " 
(__imp_?getComplexColor@SvxColorItem@@QEBAAEBVComplexColor@model@@XZ) 
referenced in function "void __cdecl `anonymous namespace'::checkC
ellTextThemeColor(class ScDocument *)" 
(?checkCellTextThemeColor@?A0x620fdfa5@@YAXPEAVScDocument@@@Z)
ThemeImportExportTest.o : error LNK2019: unresolved external symbol 
"__declspec(dllimport) public: class Color const & __cdecl 
editeng::SvxBorderLine::GetColor(
void)const " (__imp_?GetColor@SvxBorderLine@editeng@@QEBAAEBVColor@@XZ) 
referenced in function "void __cdecl `anonymous 
namespace'::checkCellBorderThemeColor(cl
ass ScDocument *)" 
(?checkCellBorderThemeColor@?A0x620fdfa5@@YAXPEAVScDocument@@@Z)
ThemeImportExportTest.o : error LNK2019: unresolved external symbol 
"__declspec(dllimport) public: class model::ComplexColor const & __cdecl 
editeng::SvxBorderL
ine::getComplexColor(void)const " 
(__imp_?getComplexColor@SvxBorderLine@editeng@@QEBAAEBVComplexColor@model@@XZ) 
referenced in function "void __cdecl `anonymous
 namespace'::checkCellBorderThemeColor(class ScDocument *)" 
(?checkCellBorderThemeColor@?A0x620fdfa5@@YAXPEAVScDocument@@@Z)

C:\lo\src\core2\workdir\LinkTarget\CppunitTest\test_sc_theme_import_export_test.dll
 : fatal error LNK1120: 10 unresolved externals
make[1]: *** [C:/lo/src/core2/solenv/gbuild/LinkTarget.mk:841: 
C:/lo/src/core2/workdir/LinkTarget/CppunitTest/test_sc_theme_import_export_test.dll]
 Error 96

[Libreoffice-bugs] [Bug 157721] SimpleCommandMail: subject and body truncated at the comma (Ubuntu + Thunderbird)

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157721

--- Comment #6 from TISSENDIER Pierre  ---
Created attachment 190442
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190442=edit
With SHELL ans thunderbird commandline with hyphen

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157721] SimpleCommandMail: subject and body truncated at the comma (Ubuntu + Thunderbird)

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157721

--- Comment #5 from TISSENDIER Pierre  ---
hello
I do not have the point problem in the Thunderbird command line if the subject
and the text are framed by apostrophes! see my new attached routine.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157920] Terminology: "Table Header" or "Table Heading" ?

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157920

--- Comment #1 from Adolfo Jayme Barrientos  ---
I agree with Michael.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 157920] Terminology: "Table Header" or "Table Heading" ?

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157920

--- Comment #1 from Adolfo Jayme Barrientos  ---
I agree with Michael.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 148010] Large ODS open 100% slower compared to XLSX format

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=148010

Michael Meeks  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #12 from Michael Meeks  ---
This is quite a technical issue about file-format problems with ODS that make
it somewhat slower as a format. If there is some un-related printer issue -
please split that to another ticket to continue the discussion.
Thanks; and CC Regina who might be interested :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-5-8' - vcl/source

2023-10-26 Thread Patrick Luby (via logerrit)

 vcl/source/gdi/impgraph.cxx   |   11 +++
 vcl/source/gdi/pdfwriter_impl.cxx |   18 ++
 2 files changed, 21 insertions(+), 8 deletions(-)

New commits:
commit 13e85421e58c2eb15bd5eb3b37af85abacdecb7e
Author: Patrick Luby 
AuthorDate: Wed Oct 11 19:53:18 2023 -0400
Commit: Thorsten Behrens 
CommitDate: Thu Oct 26 20:27:09 2023 +0200

tdf#157680 scale down size and adjust size and scale factor for /BBox

The size of an embedded PDF files is multiplied by
PDF_INSERT_MAGIC_SCALE_FACTOR for platforms like macOS so undo that
by adjusting the size and scale factor.

For some unknown reason, when exporting the following PDF, the
estimated size of embedded PDF charts are 20x larger than expected.
This only occurs on macOS so possibly there is some special conversion
from MapUnit::MapPoint to MapUnit::MapTwip elsewhere in the code:

  https://bugs.documentfoundation.org/attachment.cgi?id=190109

Change-Id: Id0563466fea3d7a3a0419787ec9da45f0c1d2e0a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158157
Reviewed-by: Christian Lohmaier 
Reviewed-by: Patrick Luby 
Reviewed-by: Ilmari Lauhakangas 
Tested-by: Thorsten Behrens 
Reviewed-by: Thorsten Behrens 

diff --git a/vcl/source/gdi/impgraph.cxx b/vcl/source/gdi/impgraph.cxx
index ca63d8645063..36b9b7ffef1b 100644
--- a/vcl/source/gdi/impgraph.cxx
+++ b/vcl/source/gdi/impgraph.cxx
@@ -793,6 +793,17 @@ Size ImpGraphic::getPrefSize() const
 // svg not yet buffered in maBitmapEx, return size 
derived from range
 const basegfx::B2DRange& rRange = 
maVectorGraphicData->getRange();
 
+#ifdef MACOSX
+// tdf#157680 scale down estimated size of embedded PDF
+// For some unknown reason, the embedded PDF sizes
+// are 20x larger than expected. This only occurs on
+// macOS so possibly there is some special conversion
+// from MapUnit::MapPoint to MapUnit::MapTwip elsewhere
+// in the code.
+if (maVectorGraphicData->getType() == 
VectorGraphicDataType::Pdf)
+   aSize = Size(basegfx::fround(rRange.getWidth() / 
20.0f), basegfx::fround(rRange.getHeight() / 20.0f));
+else
+#endif
 aSize = Size(basegfx::fround(rRange.getWidth()), 
basegfx::fround(rRange.getHeight()));
 }
 else
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx 
b/vcl/source/gdi/pdfwriter_impl.cxx
index 28935f59a5a5..9f2f75be6d93 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -68,6 +68,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -8970,6 +8971,7 @@ void PDFWriterImpl::writeReferenceXObject(const 
ReferenceXObjectEmit& rEmit)
 // vcl::ImportPDF() uses getDefaultPdfResolutionDpi to set the desired
 // rendering DPI so we have to take into account that here too.
 static const double fResolutionDPI = 
vcl::pdf::getDefaultPdfResolutionDpi();
+static const double fMagicScaleFactor = PDF_INSERT_MAGIC_SCALE_FACTOR;
 
 sal_Int32 nOldDPIX = GetDPIX();
 sal_Int32 nOldDPIY = GetDPIY();
@@ -8984,15 +8986,13 @@ void PDFWriterImpl::writeReferenceXObject(const 
ReferenceXObjectEmit& rEmit)
 sal_Int32 nWrappedFormObject = 0;
 if (!m_aContext.UseReferenceXObject)
 {
-#ifdef MACOSX
 // tdf#156842 increase scale for external PDF data
-// For some unknown reason, the scale is 8 times larger than for
-// non-external PDF XObjects.
+// Multiply PDF_INSERT_MAGIC_SCALE_FACTOR for platforms like macOS
+// that scale all images by this number.
 // This fix also allows the CppunitTest_vcl_pdfexport to run
 // successfully on macOS.
-fScaleX = 8.0 / aSize.Width();
-fScaleY = 8.0 / aSize.Height();
-#endif
+fScaleX = fMagicScaleFactor / aSize.Width();
+fScaleY = fMagicScaleFactor / aSize.Height();
 
 // Parse the PDF data, we need that to write the PDF dictionary of our
 // object.
@@ -9234,9 +9234,11 @@ void PDFWriterImpl::writeReferenceXObject(const 
ReferenceXObjectEmit& rEmit)
 appendDouble(fScaleY, aLine);
 aLine.append(" 0 0 ]");
 aLine.append(" /BBox [ 0 0 ");
-aLine.append(aSize.Width());
+// tdf#157680 reduce size by magic scale factor in /BBox
+aLine.append(aSize.Width() / fMagicScaleFactor);
 aLine.append(" ");
-aLine.append(aSize.Height());
+// tdf#157680 reduce size by magic scale factor in /BBox
+aLine.append(aSize.Height() / fMagicScaleFactor);
 aLine.append(" ]\n");
 
 if (m_aContext.UseReferenceXObject && rEmit.m_nEmbeddedObject > 0)

[Libreoffice-bugs] [Bug 148010] Large ODS open 100% slower compared to XLSX format

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=148010

--- Comment #11 from peterho0...@yahoo.com.hk ---
I have reproduced the problem. Let me provide the system information first.

Version: 7.6.2.1 (X86_64) / LibreOffice Community
Build ID: 56f7684011345957bbf33a7ee678afaf4d2ba333
CPU threads: 12; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win
Locale: zh-HK (zh_HK); UI: zh-TW
Calc: CL threaded

I have also found that some people have discussed the problem in the forum.
https://ask.libreoffice.org/t/slow-loading-first-spredsheet/95202

Someone found that the loading time could be affected by the system default
printer setting. When the default printer is offline, the files require a very
long time to be loaded. Some solutions have been provided in that page but only
1 of them is working for me. Here is my findings:
1. Changing the default printer to an online printer or 'Microsoft Print to
PDF' solves the problem.
2. Unchecking the box 'Load printer settings with the document' in the options
doesn't solves the problem.
3. The problem occurs on ODS files but not XLSX files, even when the files are
small. On my computer, opening an ODS file is much much slower (>1 munite) than
opening a XLSX file (<1 second).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: comphelper/source

2023-10-26 Thread Noel Grandin (via logerrit)

 comphelper/source/processfactory/processfactory.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit b5b50c1fe3bec22a0061d118be1ba3757ce765b0
Author: Noel Grandin 
AuthorDate: Thu Oct 26 14:49:29 2023 +0200
Commit: Noel Grandin 
CommitDate: Thu Oct 26 19:55:42 2023 +0200

cool#6893 cache the process component context

which we look up rather a lot

Change-Id: Ie8bcf161a1d7a299a404f749cf08a13f33f7f1cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158506
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/comphelper/source/processfactory/processfactory.cxx 
b/comphelper/source/processfactory/processfactory.cxx
index fc8586471db1..c503b8ff1e88 100644
--- a/comphelper/source/processfactory/processfactory.cxx
+++ b/comphelper/source/processfactory/processfactory.cxx
@@ -109,7 +109,8 @@ Reference< XComponentContext > getComponentContext(
 
 Reference< XComponentContext > getProcessComponentContext()
 {
-return getComponentContext( getProcessServiceFactory() );
+static const uno::Reference processComponentContext = 
getComponentContext( getProcessServiceFactory() );
+return processComponentContext;
 }
 
 } // namespace comphelper

[Libreoffice-commits] core.git: helpcontent2

2023-10-26 Thread Stéphane Guillou (via logerrit)

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5a59e6bf5a2590e93ec520b5d736b15d981804fe
Author: Stéphane Guillou 
AuthorDate: Thu Oct 26 19:39:37 2023 +0200
Commit: Gerrit Code Review 
CommitDate: Thu Oct 26 19:39:37 2023 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to bcef222378f8d2225596ea624f9c82e9cb48a01d
  - add link to langpack downloads

Change-Id: I237e89e0263cdf27105cf4395d2272f9d96e2235
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158444
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 3ae6c825415c..bcef222378f8 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 3ae6c825415ce74ed8f0487acc043fd3a41c46e4
+Subproject commit bcef222378f8d2225596ea624f9c82e9cb48a01d

[Libreoffice-commits] help.git: source/text

2023-10-26 Thread Stéphane Guillou (via logerrit)

 source/text/shared/optionen/0114.xhp |1 +
 1 file changed, 1 insertion(+)

New commits:
commit bcef222378f8d2225596ea624f9c82e9cb48a01d
Author: Stéphane Guillou 
AuthorDate: Thu Oct 26 15:43:53 2023 +0200
Commit: Olivier Hallot 
CommitDate: Thu Oct 26 19:39:37 2023 +0200

add link to langpack downloads

Change-Id: I237e89e0263cdf27105cf4395d2272f9d96e2235
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158444
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/shared/optionen/0114.xhp 
b/source/text/shared/optionen/0114.xhp
index 27f7f0dcab..3834c503bc 100644
--- a/source/text/shared/optionen/0114.xhp
+++ b/source/text/shared/optionen/0114.xhp
@@ -53,6 +53,7 @@
 User interface
   Select the language used for the user interface, for example menus, 
dialogs, help files. You must have installed at least one additional language 
pack or a multi-language version of %PRODUCTNAME.
   The "Default" entry selects the language of the user interface 
for the operating system. If this language is not available in the %PRODUCTNAME 
installation, the language of the %PRODUCTNAME installation is the default 
language.
+ If the language you are after is not in 
the list, download the corresponding language pack from the https://www.libreoffice.org/download/download-libreoffice/?lang=pick;>%PRODUCTNAME
 website.
 
 Locale setting
   Specifies the locale setting of the 
country setting. This influences settings for numbering, currency and units of 
measure.

[Libreoffice-bugs] [Bug 153176] Improving tab handling in pasting

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=153176

Vincent Boudry  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #3 from Vincent Boudry  ---
Version: 7.6.2.1 (X86_64) / LibreOffice Community
Build ID: 56f7684011345957bbf33a7ee678afaf4d2ba333
CPU threads: 4; OS: Mac OS X 13.6; UI render: default; VCL: osx
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157927] Header formatting is off when docx file is opened and converted to pdf in LO Writer

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157927

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||miguelangelrv@libreoffice.o
   ||rg
 Ever confirmed|0   |1

--- Comment #2 from m.a.riosv  ---
Reproducible
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 926826e40955175a8c115472e0d2f6c7f2f1a453
CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL threaded

and I can't find any version working fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157915] Error UNO type of C++ when running a Basic macro with instruction commitChanges for org.openoffice.Office.Commands/Execute/Disabled

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157915

--- Comment #5 from elmau  ---
I can reproduced the problem in:

Version: 7.5.7.1 (X86_64) / LibreOffice Community
Build ID: 50(Build:1)
CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: es-MX (en_US.UTF-8); UI: en-US
7.5.7-3
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: chart2/qa

2023-10-26 Thread Stephan Bergmann (via logerrit)

 chart2/qa/extras/xshape/data/ods/tdf90839-4.ods   |binary
 chart2/qa/extras/xshape/data/pptx/tdf149204.pptx  |binary
 chart2/qa/extras/xshape/data/reference/tdf149204.xml  |  174 +-
 chart2/qa/extras/xshape/data/reference/tdf90839-1.xml |  142 +++---
 chart2/qa/extras/xshape/data/reference/tdf90839-2.xml |  148 +++
 chart2/qa/extras/xshape/data/reference/tdf90839-3.xml |  148 +++
 chart2/qa/extras/xshape/data/reference/tdf90839-4.xml |   96 -
 chart2/qa/extras/xshape/data/xlsx/tdf90839-1.xlsx |binary
 chart2/qa/extras/xshape/data/xlsx/tdf90839-2.xlsx |binary
 chart2/qa/extras/xshape/data/xlsx/tdf90839-3.xlsx |binary
 10 files changed, 354 insertions(+), 354 deletions(-)

New commits:
commit fa91d0a3e82899290104b06ad1c8f2519d67fa1c
Author: Stephan Bergmann 
AuthorDate: Tue Oct 24 10:34:55 2023 +0200
Commit: Stephan Bergmann 
CommitDate: Thu Oct 26 19:08:47 2023 +0200

Replace use of "Calibri" and "Calibri Light" with "Noto Sans"

...in CppunitTest_chart2_xshape, which had caused
 to fail with

> diff.cxx:324:Assertion
> Test name: Chart2XShapeTest::testTdf149204
> assertion failed
> - Expression: valInTolerance
> - 3511; Found Value: 3485; Tolerance: 1; Relative: 0
>
> diff.cxx:265:Assertion
> Test name: Chart2XShapeTest::testPieChartLabels1
> double equality assertion failed
> - Expected: 8383
> - Actual  : 8399
> - Delta   : 1e-08
> - Reference: 
/run/build/libreoffice/chart2/qa/extras/xshape/data/reference/tdf90839-1.xml
> - Node: /XShapes/XShape[2]/XShapes/XShape[3]/XShapes/XShape[2]
> - Attr: positionX
>
> diff.cxx:324:Assertion
> Test name: Chart2XShapeTest::testPieChartLabels2
> assertion failed
> - Expression: valInTolerance
> - 3124; Found Value: 2966; Tolerance: 1; Relative: 0
>
> diff.cxx:324:Assertion
> Test name: Chart2XShapeTest::testPieChartLabels3
> assertion failed
> - Expression: valInTolerance
> - 3124; Found Value: 2966; Tolerance: 1; Relative: 0
>
> diff.cxx:324:Assertion
> Test name: Chart2XShapeTest::testPieChartLabels4
> assertion failed
> - Expression: valInTolerance
> - 2768; Found Value: 2531; Tolerance: 1; Relative: 0

Change-Id: I518d37bedf7d8738396e05011223bd970786a45a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158377
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/chart2/qa/extras/xshape/data/ods/tdf90839-4.ods 
b/chart2/qa/extras/xshape/data/ods/tdf90839-4.ods
index fe9950f2797f..3126ac1759e3 100644
Binary files a/chart2/qa/extras/xshape/data/ods/tdf90839-4.ods and 
b/chart2/qa/extras/xshape/data/ods/tdf90839-4.ods differ
diff --git a/chart2/qa/extras/xshape/data/pptx/tdf149204.pptx 
b/chart2/qa/extras/xshape/data/pptx/tdf149204.pptx
index a5c1a96a0d04..60d006547a2a 100644
Binary files a/chart2/qa/extras/xshape/data/pptx/tdf149204.pptx and 
b/chart2/qa/extras/xshape/data/pptx/tdf149204.pptx differ
diff --git a/chart2/qa/extras/xshape/data/reference/tdf149204.xml 
b/chart2/qa/extras/xshape/data/reference/tdf149204.xml
index 6dc03b770eb1..5e157983d0d8 100644
--- a/chart2/qa/extras/xshape/data/reference/tdf149204.xml
+++ b/chart2/qa/extras/xshape/data/reference/tdf149204.xml
@@ -47,15 +47,15 @@

 
  
- 
+ 
   
-   
+   
 
- 
+ 
   
-   
+   
 
- 
+ 
   
   
   
@@ -64,30 +64,30 @@
   
   
   
-   
-   
+   
+   

   
  
 
 
- 
- 
+ 
+ 
  
 

   
   
-   
-   
+   
+   

   
  
- 
+ 
   
-   
+   
 
- 
+ 
   
   
   
@@ -96,30 +96,30 @@
   
   
   
-   
-   
+   
+   

   
  
 
 
- 
- 
+ 
+ 
  
 

   
   
-   
-   
+   
+   

   
  
- 
+ 
   
-   
+   
 
- 
+ 
   
   
   
@@ -128,36 +128,36 @@
   
   
   
-   
-   
+   
+

[Libreoffice-commits] core.git: xmlhelp/source

2023-10-26 Thread Stephan Bergmann (via logerrit)

 xmlhelp/source/cxxhelp/provider/db.cxx |   15 +--
 1 file changed, 5 insertions(+), 10 deletions(-)

New commits:
commit b36b24ecfbb7e9fc6c5d5d0a789fabd2a0cb18b3
Author: Stephan Bergmann 
AuthorDate: Thu Oct 26 08:54:31 2023 +0200
Commit: Stephan Bergmann 
CommitDate: Thu Oct 26 19:08:08 2023 +0200

Use std::from_chars

(which also makes readInt32 report failure, instead of running into UB, 
when the
read value is out of range)

Change-Id: I8449e4fe696c9b0ab5b868127ef517dc080c31ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158489
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/xmlhelp/source/cxxhelp/provider/db.cxx 
b/xmlhelp/source/cxxhelp/provider/db.cxx
index bf3c269b99ca..d60bff78ee63 100644
--- a/xmlhelp/source/cxxhelp/provider/db.cxx
+++ b/xmlhelp/source/cxxhelp/provider/db.cxx
@@ -20,28 +20,23 @@
 
 #include "db.hxx"
 
+#include 
+#include 
 #include 
+#include 
 #include 
 
 #include 
-#include 
 
 using namespace com::sun::star::uno;
 using namespace com::sun::star::io;
 
 namespace {
 
-//TODO: Replace with C++17 std::from_chars once available:
 std::pair readInt32(char const * begin, char const * 
end) {
 sal_Int32 n = 0;
-for (; begin != end; ++begin) {
-auto const w = INetMIME::getHexWeight(static_cast(*begin));
-if (w == -1) {
-break;
-}
-n = 16 * n + w;
-}
-return {n, begin};
+auto const [ptr, ec] = std::from_chars(begin, end, n, 16);
+return {std::max(n, sal_Int32(0)), ec == std::errc{} && n >= 0 ? ptr : 
begin};
 }
 
 }

[Libreoffice-commits] core.git: sfx2/source

2023-10-26 Thread Noel Grandin (via logerrit)

 sfx2/source/doc/sfxbasemodel.cxx |  106 ---
 1 file changed, 56 insertions(+), 50 deletions(-)

New commits:
commit d2fccf0117a37f8aab8bb50ece419987f06af6b9
Author: Noel Grandin 
AuthorDate: Thu Oct 26 13:36:46 2023 +0200
Commit: Noel Grandin 
CommitDate: Thu Oct 26 19:02:53 2023 +0200

cool#6893 improve listeners in SfxBaseModel

reduces CPU spent in UNO query'ing, and adds type-safety, which exposed
a bug in SfxBaseModel::disposing

Change-Id: I4b973f7dc38f491ce7a6281ad378e439b5450add
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158500
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sfx2/source/doc/sfxbasemodel.cxx b/sfx2/source/doc/sfxbasemodel.cxx
index b085342b1912..03a511fc2fe4 100644
--- a/sfx2/source/doc/sfxbasemodel.cxx
+++ b/sfx2/source/doc/sfxbasemodel.cxx
@@ -62,6 +62,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 #include 
@@ -202,7 +203,13 @@ struct IMPL_SfxBaseModel_DataContainer : public 
::sfx2::IModifiableDocument
 OUString   m_sURL  
 ;
 OUString   m_sRuntimeUID   
 ;
 OUString   
m_aPreusedFilterName ;
-comphelper::OMultiTypeInterfaceContainerHelper2
m_aInterfaceContainer;
+comphelper::OInterfaceContainerHelper3  
m_aPrintJobListeners;
+comphelper::OInterfaceContainerHelper3  
m_aEventListeners;
+comphelper::OInterfaceContainerHelper3  
m_aModifyListeners;
+comphelper::OInterfaceContainerHelper3  
m_aDocumentEventListeners1;
+comphelper::OInterfaceContainerHelper3  
m_aDocumentEventListeners2;
+comphelper::OInterfaceContainerHelper3  
m_aStorageChangeListeners;
+comphelper::OInterfaceContainerHelper3  
m_aCloseListeners;
 std::unordered_map,
std::vector>> maShapeListeners;
 Reference< XInterface >m_xParent   
 ;
@@ -234,8 +241,14 @@ struct IMPL_SfxBaseModel_DataContainer : public 
::sfx2::IModifiableDocument
 
 IMPL_SfxBaseModel_DataContainer( ::osl::Mutex& rMutex, SfxObjectShell* 
pObjectShell )
 :   m_pObjectShell  ( pObjectShell  )
-,   m_aInterfaceContainer   ( rMutex)
-,   m_nControllerLockCount  ( 0 )
+,   m_aPrintJobListeners( rMutex)
+,   m_aEventListeners   ( rMutex)
+,   m_aModifyListeners  ( rMutex)
+,   m_aDocumentEventListeners1( rMutex  )
+,   m_aDocumentEventListeners2( rMutex  )
+,   m_aStorageChangeListeners ( rMutex  )
+,   m_aCloseListeners   ( rMutex)
+,   m_nControllerLockCount  ( 0 )
 ,   m_bClosed   ( false )
 ,   m_bClosing  ( false )
 ,   m_bSaving   ( false )
@@ -354,12 +367,9 @@ void SAL_CALL SfxPrintHelperListener_Impl::disposing( 
const lang::EventObject& )
 
 void SAL_CALL SfxPrintHelperListener_Impl::printJobEvent( const 
view::PrintJobEvent& rEvent )
 {
-::comphelper::OInterfaceContainerHelper2* pContainer = 
m_pData->m_aInterfaceContainer.getContainer( 
cppu::UnoType::get());
-if ( pContainer!=nullptr )
+if ( m_pData->m_aPrintJobListeners.getLength() )
 {
-::comphelper::OInterfaceIteratorHelper2 pIterator(*pContainer);
-while (pIterator.hasMoreElements())
-
static_cast(pIterator.next())->printJobEvent( rEvent 
);
+
m_pData->m_aPrintJobListeners.notifyEach(::XPrintJobListener::printJobEvent,
 rEvent);
 }
 }
 
@@ -763,7 +773,13 @@ void SAL_CALL SfxBaseModel::dispose()
 }
 
 lang::EventObject aEvent( static_cast(this) );
-m_pData->m_aInterfaceContainer.disposeAndClear( aEvent );
+m_pData->m_aPrintJobListeners.disposeAndClear( aEvent );
+m_pData->m_aEventListeners.disposeAndClear( aEvent );
+m_pData->m_aModifyListeners.disposeAndClear( aEvent );
+m_pData->m_aDocumentEventListeners1.disposeAndClear( aEvent );
+m_pData->m_aDocumentEventListeners2.disposeAndClear( aEvent );
+m_pData->m_aStorageChangeListeners.disposeAndClear( aEvent );
+m_pData->m_aCloseListeners.disposeAndClear( aEvent );
 
 m_pData->m_xDocumentProperties.clear();
 
@@ -790,7 +806,7 @@ void SAL_CALL SfxBaseModel::dispose()
 void SAL_CALL SfxBaseModel::addEventListener( const Reference< 
lang::XEventListener >& aListener )
 {
 SfxModelGuard aGuard( *this, SfxModelGuard::E_INITIALIZING );
-m_pData->m_aInterfaceContainer.addInterface( 
cppu::UnoType::get(), aListener );
+m_pData->m_aEventListeners.addInterface( aListener );
 }
 
 
@@ -800,7 +816,7 @@ void SAL_CALL SfxBaseModel::addEventListener( const 
Reference< lang::XEventListe
 void SAL_CALL SfxBaseModel::removeEventListener(

[Libreoffice-commits] core.git: sc/qa sc/source

2023-10-26 Thread Andreas Heinisch (via logerrit)

 sc/qa/unit/uicalc/data/tdf157897_linked.ods |binary
 sc/qa/unit/uicalc/data/tdf157897_main.ods   |binary
 sc/qa/unit/uicalc/uicalc.cxx|   18 ++
 sc/source/core/data/documen2.cxx|2 ++
 4 files changed, 20 insertions(+)

New commits:
commit 96b91357fb93028d35d70bdb52b4bac3ecbfbf57
Author: Andreas Heinisch 
AuthorDate: Mon Oct 23 23:13:51 2023 +0200
Commit: Andreas Heinisch 
CommitDate: Thu Oct 26 18:41:49 2023 +0200

tdf#157897 - Clear print ranges before adding additional ones

Otherwise, additional print ranges will be added for linked files after
the external link will be updated.

Change-Id: I0556fda6609d3e18f1ca992dc6a0399be01bc841
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158365
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch 

diff --git a/sc/qa/unit/uicalc/data/tdf157897_linked.ods 
b/sc/qa/unit/uicalc/data/tdf157897_linked.ods
new file mode 100755
index ..bb75c31d82ae
Binary files /dev/null and b/sc/qa/unit/uicalc/data/tdf157897_linked.ods differ
diff --git a/sc/qa/unit/uicalc/data/tdf157897_main.ods 
b/sc/qa/unit/uicalc/data/tdf157897_main.ods
new file mode 100755
index ..1e1af575145f
Binary files /dev/null and b/sc/qa/unit/uicalc/data/tdf157897_main.ods differ
diff --git a/sc/qa/unit/uicalc/uicalc.cxx b/sc/qa/unit/uicalc/uicalc.cxx
index 4259f56a..15795baceaa1 100644
--- a/sc/qa/unit/uicalc/uicalc.cxx
+++ b/sc/qa/unit/uicalc/uicalc.cxx
@@ -1395,6 +1395,24 @@ CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testTdf146994)
 CPPUNIT_ASSERT_EQUAL(OUString("Sheet1.D3:Sheet1.D4"), aMarkedAreaString);
 }
 
+CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testTdf157897_duplicated_print_ranges)
+{
+createScDoc("tdf157897_main.ods");
+ScDocument* pDoc = getScDoc();
+
+const sal_uInt16 nPos = 0;
+const SCTAB nFirstTab = 0;
+// Ensure that there exists a print range in the first documents tab
+CPPUNIT_ASSERT_EQUAL(static_cast(1), 
pDoc->GetPrintRangeCount(nFirstTab));
+
+// Reload all links and check if the print range was not duplicated
+const auto initialPrintRange = pDoc->GetPrintRange(nFirstTab, nPos);
+pDoc->GetDocumentShell()->ReloadAllLinks();
+
+// Without the fix in place, the print range in the linked tab will be 
duplicated
+CPPUNIT_ASSERT_EQUAL(initialPrintRange, pDoc->GetPrintRange(nFirstTab, 
nPos));
+}
+
 CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testTdf154991)
 {
 createScDoc("tdf154991.ods");
diff --git a/sc/source/core/data/documen2.cxx b/sc/source/core/data/documen2.cxx
index 4b07b0d33ff5..c53dc6b3e305 100644
--- a/sc/source/core/data/documen2.cxx
+++ b/sc/source/core/data/documen2.cxx
@@ -1040,6 +1040,8 @@ sal_uLong ScDocument::TransferTab( ScDocument& rSrcDoc, 
SCTAB nSrcPos,
 maTabs[nDestPos]->SetPrintEntireSheet();
 else
 {
+// tdf#157897 - clear print ranges before adding additional ones
+maTabs[nDestPos]->ClearPrintRanges();
 const auto nPrintRangeCount = 
rSrcDoc.maTabs[nSrcPos]->GetPrintRangeCount();
 for (auto nPos = 0; nPos < nPrintRangeCount; nPos++)
 {

[Libreoffice-bugs] [Bug 157935] After installation of 7.6.2, first form opening of .odb file freezes LO

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157935

w...@sorha-consulting.be changed:

   What|Removed |Added

Version|unspecified |7.6.2.1 release

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157935] After installation of 7.6.2, first form opening of .odb file freezes LO

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157935

--- Comment #1 from w...@sorha-consulting.be ---
Created attachment 190441
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190441=edit
"LibreOffice" folder (created with LO 7.1.4.1)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157935] New: After installation of 7.6.2, first form opening of .odb file freezes LO

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157935

Bug ID: 157935
   Summary: After installation of 7.6.2, first form opening of
.odb file freezes LO
   Product: LibreOffice
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: macOS (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Installation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: w...@sorha-consulting.be

Created attachment 190440
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190440=edit
"LibreOffice" folder (created with LO 7.6.2)

System:
MacBook Pro (Retina, 13-inch, Early 2015)
MacOS 12.7 (Monterey)

After installation of LO 7.6.2, I open an .odb (Base) file.
A "LibreOffice" folder is created within /users/XXX/Library/Application Support
This folder includes a folder named "4" which includes 2 folders : "cache" &
"user" (which is the user profile, I suppose)
This .odb file has a startup macro displaying a pop-up with user/pwd fields.
This macro works well (login is properly checked) and access is allowed to the
database.
A second macro, immediately following the login, displays a form with several
buttons.

Here is the bug: the form is displayed but remains blank (no button) and LO
freezes.

Workaround (and possibly a source to look at to solve the problem):
Uninstall LO 7.6.2
Delete the folder /users/Library/Application Support/Libreoffice/4
Install an older version of LO (I've tried LO 7.1.4.1)
Open it (it creates a "/users/Library/Application Support/Libreoffice/4" file)
Open the .odb file.
It works (form is well displayed and all buttons are functional)
Quit LO
Install LO 7.6.2
Open it, open the .odb file. It works !

First guess: LO 7.6.2 creates a corrupted profile. When the profile already
exists (not corrupted), it uses it and it works

Attachments: both profiles (created with LO 7.1.4.1 & 7.6.2)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 119352] [META] Language issues

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=119352

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||157704


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157704
[Bug 157704] language settings for document are not applied to existing text
boxes
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 34141] Functionality request: Impress language identification similar to Writer's status bar

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=34141

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||7704

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103494] [META] Textbox bugs and enhancements

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103494

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||157704


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157704
[Bug 157704] language settings for document are not applied to existing text
boxes
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157704] language settings for document are not applied to existing text boxes

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157704

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Summary|language settings for   |language settings for
   |document are not applied|document are not applied to
   ||existing text boxes
 Blocks||103494, 119352
 Status|UNCONFIRMED |NEW
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=34
   ||141
 CC||stephane.guillou@libreoffic
   ||e.org
 Ever confirmed|0   |1

--- Comment #17 from Stéphane Guillou (stragu) 
 ---
In Writer, changing the document language in the Options dialog will change the
language of all paragraphs, but it will not change it inside text boxes. I
think we are seeing the same issue here: because Impress uses text boxes for
all text, then it looks like changing the document language changes nothing.

Plus, we have the status bar not updating accordingly, which is bug 34141.

However, new text boxes will use the new document language as expected.
But I agree that this issue makes it very cumbersome to change a whole
slideshow at once: it would have to be done in the Character dialog for each
text box.

Design/UX team: I couldn't find a duplicate report about that. It would make
sense for the document language to be applied to all existing text boxes,
right?

Version: 7.6.2.1 (X86_64) / LibreOffice Community
Build ID: 56f7684011345957bbf33a7ee678afaf4d2ba333
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103494
[Bug 103494] [META] Textbox bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=119352
[Bug 119352] [META] Language issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/unx

2023-10-26 Thread Michael Weghorn (via logerrit)

 vcl/unx/gtk4/a11y.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 69b50eee1cf103229d4d774fd54b46d0ff767472
Author: Michael Weghorn 
AuthorDate: Thu Oct 26 14:24:43 2023 +0200
Commit: Michael Weghorn 
CommitDate: Thu Oct 26 18:10:10 2023 +0200

gtk4 a11y: Map checkbox role to gtk equivalent

This makes a checkbox form control in a Writer document
show up with the proper role in Accerciser, no longer
as a filler.

Change-Id: I5566d27ecfbe9ec54dcfbf20693899b72d3af738
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158505
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/vcl/unx/gtk4/a11y.cxx b/vcl/unx/gtk4/a11y.cxx
index 418037027f48..cbc2f853feaf 100644
--- a/vcl/unx/gtk4/a11y.cxx
+++ b/vcl/unx/gtk4/a11y.cxx
@@ -77,6 +77,9 @@ map_accessible_role(const 
css::uno::Reference&
 case css::accessibility::AccessibleRole::SEPARATOR:
 eRole = GTK_ACCESSIBLE_ROLE_SEPARATOR;
 break;
+case css::accessibility::AccessibleRole::CHECK_BOX:
+eRole = GTK_ACCESSIBLE_ROLE_CHECKBOX;
+break;
 case css::accessibility::AccessibleRole::CHECK_MENU_ITEM:
 eRole = GTK_ACCESSIBLE_ROLE_MENU_ITEM_CHECKBOX;
 break;

[Libreoffice-bugs] [Bug 157823] Text disappearing from bullet list in Impress

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157823

--- Comment #12 from Mike Kaganski  ---
(In reply to BogdanB from comment #10)
> Seems fixed already in Version: 7.4.0.0.alpha0+ / LibreOffice Community

No, in 7.4.0 it wasn't yet introduced, as well as in 7.3.6 - the change that
you mentioned was created for 7.5, and backported to 7.4.2 and 7.3.7 (see bug
151100). The fix for that arrived in 7.6, 7.5.0, and 7.4.6.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157930] MENU: Easily insert commonly used conditional formatting rules

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157930

--- Comment #2 from Paris Oplopoios  ---
The range should be selectable the same way in other similar dialogs (just
reselect the range in the spreadsheet and it will update in the dialog)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 157930] MENU: Easily insert commonly used conditional formatting rules

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157930

--- Comment #2 from Paris Oplopoios  ---
The range should be selectable the same way in other similar dialogs (just
reselect the range in the spreadsheet and it will update in the dialog)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 157823] Text disappearing from bullet list in Impress

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157823

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||3161

--- Comment #11 from Mike Kaganski  ---
(In reply to Pavel Hok from comment #6)
> I prefer using the version provided with Ubuntu due to updates

There is a PPA by Ubuntu LibreOffice packaging team:

https://launchpad.net/~libreoffice/+archive/ubuntu/ppa

Installing it upgrades your installed version (*if* you installed using apt).
It also updates automatically.

> and currently have no capacity to install a new version.

If you mean that you can't upgrade Ubuntu, then the PPA above does not require
that.

This bug is most likely a dupe for bug 153161.
Note that if you prefer to stay with old version, you would have to stay with
old bugs ;)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 119352] [META] Language issues

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=119352

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||34141


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=34141
[Bug 34141] Functionality request: Impress language identification similar to
Writer's status bar
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 34142] Calc language identification should be similar to Writer's

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=34142

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=34
   ||141

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 34141] Functionality request: Impress language identification similar to Writer's status bar

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=34141

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Blocks||119352, 103407
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=34
   ||142


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103407
[Bug 103407] [META] Unify behaviour and functions across apps
https://bugs.documentfoundation.org/show_bug.cgi?id=119352
[Bug 119352] [META] Language issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103407] [META] Unify behaviour and functions across apps

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103407

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||34141


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=34141
[Bug 34141] Functionality request: Impress language identification similar to
Writer's status bar
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157823] Text disappearing from bullet list in Impress

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157823

--- Comment #10 from BogdanB  ---
Seems fixed already in Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 10981fb2fa26474f432e85165b1babbca6d74e16
CPU threads: 16; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149948] Frozen logo on first start when "The Bat" email program started before

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149948

raal  changed:

   What|Removed |Added

 CC||1880-5...@onlinehome.de

--- Comment #9 from raal  ---
*** Bug 154841 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154841] Libre Office will not started, after start my PC

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=154841

raal  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #12 from raal  ---


*** This bug has been marked as a duplicate of bug 149948 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154841] Libre Office will not started, after start my PC

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=154841

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #11 from raal  ---
https://www.mail-archive.com/tbbeta@thebat.dutaint.com/msg115813.html

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157727] column format in sections can be unstable

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157727

--- Comment #13 from Tracey  ---
New insight(2of2):
I am unable to pin-point a specific page of a 2-column section because I can't
:-(

The reason I cannot do this is because every time I [open or up-date] the
document, LibreOffice appears to re-form the column section boundaries :-o

I deleted (1) 2-column section and reformed it as (22) 2-column sections.
3 of the 22 (about 13%) of the 2-column sections are malformed at the
bottom/end of the section.

While I cannot "pin-point" any page (because of dynamic column section
formation), I can guarantee anyone who opens the ODT document (just previously
attached) and monitors the formation of each section will discover the
malformation problem.

LibreOffice appears to intermittently (about 13% of the time) stops formatting
a 2-column section prematurely.

Did I just make your day or what?

I know I am not as stressed out or frustrated now.

Now it is up to the developers to squash that mean nasty bug :-)
Thanks, Tracey
BTW Word 2000 and Word 2002 DO NOT have the same issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/source

2023-10-26 Thread Caolán McNamara (via logerrit)

 sc/source/ui/view/viewdata.cxx |   34 ++
 1 file changed, 30 insertions(+), 4 deletions(-)

New commits:
commit ce8920448c05594f37f09c7a42ae3f3c7ccb7a1e
Author: Caolán McNamara 
AuthorDate: Thu Oct 26 12:47:21 2023 +0100
Commit: Caolán McNamara 
CommitDate: Thu Oct 26 17:41:02 2023 +0200

null-deref seen in ScTabView::UpdateEditView

 #0  0x7f2bcc41df63 in ScViewData::GetCurYForTab 
(this=this@entry=0x3502d0b8, nTabIndex=nTabIndex@entry=6)
 at libreoffice/sc/source/ui/view/viewdata.cxx:1443
 #1  0x7f2bcc3ebf02 in ScTabView::UpdateEditView 
(this=this@entry=0x3502d0b0) at libreoffice/sc/source/ui/view/tabview3.cxx:2185
 #2  0x7f2bcc3ec636 in ScTabView::UpdateFormulas 
(this=this@entry=0x3502d0b0, nStartCol=nStartCol@entry=-1, 
nStartRow=nStartRow@entry=-1, nEndCol=nEndCol@entry=-1,
 nEndRow=nEndRow@entry=-1) at 
libreoffice/sc/source/ui/view/tabview3.cxx:2327
 #3  0x7f2bcc40735c in ScTabViewShell::Notify (this=0x3502cf20, 
rBC=..., rHint=...) at libreoffice/sc/source/ui/view/tabvwsh5.cxx:216
 #4  0x7f2bdc1885a9 in SfxBroadcaster::Broadcast 
(this=this@entry=0x31e31430, rHint=...)
 at libreoffice/svl/source/notify/SfxBroadcaster.cxx:40
 #5  0x7f2bcc022e6d in ScDocShell::PostDataChanged 
(this=this@entry=0x31e31430) at libreoffice/sc/source/ui/docshell/docsh3.cxx:95
 #6  0x7f2bcc0101aa in ScDocShell::SetDocumentModified 
(this=0x31e31430) at libreoffice/sc/source/ui/docshell/docsh.cxx:3015
 #7  0x7f2bcc010df3 in ScDocShellModificator::SetDocumentModified 
(this=this@entry=0x7fff2d168da0)
 at libreoffice/sc/source/ui/docshell/docsh.cxx:3330
 #8  0x7f2bcc040c1a in ScDocShell::MoveTable 
(this=this@entry=0x31e31430, nSrcTab=, nDestTab=, 
bCopy=bCopy@entry=false, bRecord=bRecord@entry=false)
 at libreoffice/sc/source/ui/docshell/docsh5.cxx:1010
 #9  0x7f2bcc441a41 in ScViewFunc::MoveTable 
(this=this@entry=0x333d0fe0, nDestDocNo=nDestDocNo@entry=0, 
nDestTab=nDestTab@entry=7, bCopy=bCopy@entry=false,
 pNewTabName=pNewTabName@entry=0x7fff2d169068) at 
libreoffice/sc/source/ui/view/viewfun2.cxx:3117
 #10 0x7f2bcc418459 in ScTabViewShell::ExecuteTable (this=0x333d0e50, 
rReq=...) at libreoffice/sc/source/ui/view/tabvwshf.cxx:593
 #11 0x7f2bdbd3d96f in SfxDispatcher::Call_Impl 
(this=this@entry=0x33379ed0, rShell=..., rSlot=..., rReq=..., 
bRecord=)
 at libreoffice/sfx2/source/control/dispatch.cxx:254
 #12 0x7f2bdbd427ee in SfxDispatcher::Execute_ 
(this=this@entry=0x33379ed0, rShell=..., rSlot=..., rReq=..., 
eCallMode=eCallMode@entry=SfxCallMode::RECORD)
 at libreoffice/sfx2/source/control/dispatch.cxx:753
 #13 0x7f2bdbd45a33 in SfxDispatcher::Execute (this=0x33379ed0, 
nSlot=, nCall=nCall@entry=SfxCallMode::RECORD, 
pArgs=pArgs@entry=0x7fff2d1694a0,
 pInternalArgs=pInternalArgs@entry=0x7fff2d169460, nModi=nModi@entry=0) 
at libreoffice/sfx2/source/control/dispatch.cxx:813
 #14 0x7f2bdbd83c0f in SfxDispatchController_Impl::dispatch 
(this=, aURL=..., aArgs=..., rListener=...)

we have nulls in here for hidden sheets

Change-Id: I8f1295e67552f3ec9306a031aaecd0838e18d98d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158502
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sc/source/ui/view/viewdata.cxx b/sc/source/ui/view/viewdata.cxx
index 511051d6f49c..332356dd794f 100644
--- a/sc/source/ui/view/viewdata.cxx
+++ b/sc/source/ui/view/viewdata.cxx
@@ -1433,7 +1433,13 @@ SCCOL ScViewData::GetCurXForTab( SCTAB nTabIndex ) const
 if (!ValidTab(nTabIndex) || (nTabIndex >= 
static_cast(maTabData.size())) || !maTabData[nTabIndex])
 return -1;
 
-return maTabData[nTabIndex]->nCurX;
+ScViewDataTable* pTabData = maTabData[nTabIndex].get();
+if (!pTabData)
+{
+SAL_WARN("sc.viewdata", "ScViewData::GetCurXForTab : hidden sheet = " 
<< nTabIndex);
+return -1;
+}
+return pTabData->nCurX;
 }
 
 SCROW ScViewData::GetCurYForTab( SCTAB nTabIndex ) const
@@ -1441,7 +1447,13 @@ SCROW ScViewData::GetCurYForTab( SCTAB nTabIndex ) const
 if (!ValidTab(nTabIndex) || (nTabIndex >= 
static_cast(maTabData.size(
 return -1;
 
-return maTabData[nTabIndex]->nCurY;
+ScViewDataTable* pTabData = maTabData[nTabIndex].get();
+if (!pTabData)
+{
+SAL_WARN("sc.viewdata", "ScViewData::GetCurYForTab : hidden sheet = " 
<< nTabIndex);
+return -1;
+}
+return pTabData->nCurY;
 }
 
 void ScViewData::SetCurXForTab( SCCOL nNewCurX, SCTAB nTabIndex )
@@ -1449,7 +1461,14 @@ void ScViewData::SetCurXForTab( SCCOL nNewCurX, SCTAB 
nTabIndex )
 if (!ValidTab(nTabIndex) || (nTabIndex >= 
static_cast(maTabData.size(
 return;
 
-maTabData[nTabIndex]->nCurX = nNewCurX;
+ScViewDataTable* pTabData = maTabData[nTabIndex].get();
+if (!pTabData)
+{

[Libreoffice-bugs] [Bug 157823] Text disappearing from bullet list in Impress

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157823

BogdanB  changed:

   What|Removed |Added

   Hardware|x86-64 (AMD64)  |All

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157823] Text disappearing from bullet list in Impress

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157823

BogdanB  changed:

   What|Removed |Added

 CC||mikekagan...@hotmail.com
   Keywords||bibisected, bisected,
   ||regression

--- Comment #9 from BogdanB  ---

author  Mike Kaganski  2022-09-21 11:11:47
+0300
committer   Xisco Fauli 2022-09-22
13:21:33 +0200
commit  d194474aabd699806cb3631bc8641dd0548b8026 (patch)
tree99434055a8224674e470ce49e89cc8112c4f9303
parent  84210c97d3d41f50f82d1b0747020283c844c808 (diff)
tdf#151100: xText->getString() may be empty for content needing export
The check that is removed prevents collecting the table data.
Assume that it's the performance optimization, and that processing
empty text objects would be fast anyway.

This basically reverts commit 73fcb052edf1a21d785583bc53e8b4323b577bb1
  Author Christian Lippka 
  Date   Thu Nov 22 12:26:35 2001 +
#90330# only export text autostyles for shapes with text

and commit 7661bbbaef31adfdb298b1447301b24a70f85834
  Author Michael Stahl 
  Date   Fri Nov 25 22:46:34 2016 +0100
tdf#102479 ODF export: ignore exceptions when checking shape text

that becomes unnecessary after the former change is reverted.

Change-Id: I709a7b4c5ac1cc0621d3a1b18f2eb74feb987efb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140313
Tested-by: Mike Kaganski 
Reviewed-by: Mike Kaganski 
Signed-off-by: Xisco Fauli 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140352
Tested-by: Jenkins
(cherry picked from commit 226b1c2006e936e4b32748b810624c5d655c4a98)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140378
Reviewed-by: Michael Stahl 

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157727] column format in sections can be unstable

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157727

--- Comment #12 from Tracey  ---
Created attachment 190439
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190439=edit
sample file

New insight(1of2):
Attached pdf shows an issue at the bottom of page 719 (mid-column break)
It should NOT break at his point.

Thanks, Tracey
BTW Word 2000 and Word 2002 have the same issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157823] Text disappearing from bullet list in Impress

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157823

BogdanB  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #8 from BogdanB  ---
Repro with
Version: 7.3.8.0.0+ / LibreOffice Community
Build ID: e1ad83ddb2f39419fb5d7c69eba51e2b9f49c788
CPU threads: 16; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded

On this file, if I add some text, the text is lost on save and reload.
I will bibisect it now.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157823] Text disappearing from bullet list in Impress

2023-10-26 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157823

--- Comment #7 from BogdanB  ---
If I'm opening your .odp file with 7.3, 7.4, 24.2 the text already is missing,
so I can test the missing bug, text is not here when opening. My file looks
like your second PDF already on opening.

-- 
You are receiving this mail because:
You are the assignee for the bug.

1 2 3 >

1 - 100 of 267 matches

Mail list logo