[Libreoffice-bugs] [Bug 150036] [Feature Request] Line connecting legend and chart (improving chart readability)

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150036

--- Comment #5 from Heiko Tietze  ---
(In reply to Stéphane Guillou (stragu) from comment #4)
> See my sample ODS for my suggested workaround.
Now I understand, you abuse the last data label as legend. This will very
likely fail for many reasons (last data points are very close, inappropriate y
scaling like logarithmic hides the last data point, reverse x direction, RTL,
other chart types). But as you said, it's a workaround.

(In reply to Stéphane Guillou (stragu) from comment #4)
> [X] Display legend
We are talking about Legend > Properties > Position?
>  ° Left, Top, Right, Bottom
>  ° Label the series
It might be very welcome by the users but I don't see how we label series in a
callout style for every type of chart and all situations.

And again: what do you think, Arthur? Is Insert > Data Labels sufficient for
you?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 150036] [Feature Request] Line connecting legend and chart (improving chart readability)

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150036

--- Comment #5 from Heiko Tietze  ---
(In reply to Stéphane Guillou (stragu) from comment #4)
> See my sample ODS for my suggested workaround.
Now I understand, you abuse the last data label as legend. This will very
likely fail for many reasons (last data points are very close, inappropriate y
scaling like logarithmic hides the last data point, reverse x direction, RTL,
other chart types). But as you said, it's a workaround.

(In reply to Stéphane Guillou (stragu) from comment #4)
> [X] Display legend
We are talking about Legend > Properties > Position?
>  ° Left, Top, Right, Bottom
>  ° Label the series
It might be very welcome by the users but I don't see how we label series in a
callout style for every type of chart and all situations.

And again: what do you think, Arthur? Is Insert > Data Labels sufficient for
you?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 136082] FILEOPEN DOTX/DOCX: Area fill bitmap incorrectly set to Stretched in grouped shapes

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136082

--- Comment #7 from Buovjaga  ---
Still the same

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9602f8a9318dd4d3409856e2ae06abe96e72b51b
CPU threads: 2; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: writerfilter/qa writerfilter/source

2023-11-22 Thread Jaume Pujantell (via logerrit)
 writerfilter/qa/cppunittests/dmapper/DomainMapper.cxx   |6 ++
 writerfilter/qa/cppunittests/dmapper/data/fdo78333-1-minimized.docx |binary
 writerfilter/source/dmapper/DomainMapper.cxx|   26 
+++---
 writerfilter/source/dmapper/SdtHelper.cxx   |1 
 4 files changed, 16 insertions(+), 17 deletions(-)

New commits:
commit 7c4dba1deffd81f647a4a3be7a79f68f3bf9f1ba
Author: Jaume Pujantell 
AuthorDate: Wed Nov 22 11:59:09 2023 +0100
Commit: Miklos Vajna 
CommitDate: Thu Nov 23 08:27:57 2023 +0100

fix a regression crash from commit 5082d50

The commit generated crashes in the crashtest documents
7711 bugtrackers/docx/fdo78333-1.docx and
695 forums/docx/forum-mso-en-4096.docx.
This was due to "m_xFieldStartRange", the start of the text
portion of the block SDT, being recorded too early. This led to
including characters that shouldn't be there in the generated
content control.
This patch moves the calls to setFieldStartRange to just before
the first appendTextPortion call.

Change-Id: I7230346fee9a37ebac70beb9bcafd9d7b612eb00
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159816
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/writerfilter/qa/cppunittests/dmapper/DomainMapper.cxx 
b/writerfilter/qa/cppunittests/dmapper/DomainMapper.cxx
index 7cafcd19f280..ec771ba0f1b4 100644
--- a/writerfilter/qa/cppunittests/dmapper/DomainMapper.cxx
+++ b/writerfilter/qa/cppunittests/dmapper/DomainMapper.cxx
@@ -149,6 +149,12 @@ CPPUNIT_TEST_FIXTURE(Test, testSdtBlockText)
 xContentControlProps->getPropertyValue("Alias") >>= aAlias;
 CPPUNIT_ASSERT_EQUAL(OUString("myalias"), aAlias);
 }
+
+CPPUNIT_TEST_FIXTURE(Test, testFdo78333)
+{
+// just care that it doesn't crash/assert
+loadFromURL(u"fdo78333-1-minimized.docx");
+}
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git 
a/writerfilter/qa/cppunittests/dmapper/data/fdo78333-1-minimized.docx 
b/writerfilter/qa/cppunittests/dmapper/data/fdo78333-1-minimized.docx
new file mode 100644
index ..0c4a5bc67288
Binary files /dev/null and 
b/writerfilter/qa/cppunittests/dmapper/data/fdo78333-1-minimized.docx differ
diff --git a/writerfilter/source/dmapper/DomainMapper.cxx 
b/writerfilter/source/dmapper/DomainMapper.cxx
index e2ef4ec4a4b2..70fc7820844c 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -1192,9 +1192,6 @@ void DomainMapper::lcl_attribute(Id nName, Value & val)
 m_pImpl->PushSdt();
 break;
 }
-if (m_pImpl->m_pSdtHelper->getControlType() == 
SdtControlType::plainText
-&& GetCurrentTextRange().is())
-
m_pImpl->m_pSdtHelper->setFieldStartRange(GetCurrentTextRange()->getEnd());
 m_pImpl->SetSdt(true);
 }
 break;
@@ -4229,7 +4226,6 @@ void DomainMapper::lcl_utext(const sal_Unicode *const 
data_, size_t len)
 {
 m_pImpl->m_pSdtHelper->createPlainTextControl();
 finishParagraph();
-
m_pImpl->m_pSdtHelper->setFieldStartRange(GetCurrentTextRange()->getEnd());
 return;
 }
 }
@@ -4487,10 +4483,9 @@ void DomainMapper::lcl_utext(const sal_Unicode *const 
data_, size_t len)
 m_pImpl->clearDeferredBreaks();
 }
 
-bool bSdtBlockUnusedText
-= m_pImpl->m_pSdtHelper->GetSdtType() != 
NS_ooxml::LN_CT_SdtRun_sdtContent
-  && m_pImpl->m_pSdtHelper->getControlType() == 
SdtControlType::plainText
-  && m_pImpl->m_pSdtHelper->hasUnusedText();
+bool bInSdtBlockText
+= m_pImpl->m_pSdtHelper->GetSdtType() == 
NS_ooxml::LN_CT_SdtBlock_sdtContent
+  && m_pImpl->m_pSdtHelper->getControlType() == 
SdtControlType::plainText;
 if (pContext && pContext->GetFootnote().is())
 {
 pContext->GetFootnote()->setLabel( sText );
@@ -4500,32 +4495,29 @@ void DomainMapper::lcl_utext(const sal_Unicode *const 
data_, size_t len)
 }
 else if (m_pImpl->IsOpenFieldCommand() && 
!m_pImpl->IsForceGenericFields())
 {
-if (bSdtBlockUnusedText)
+if (bInSdtBlockText && m_pImpl->m_pSdtHelper->hasUnusedText())
 m_pImpl->m_pSdtHelper->createPlainTextControl();
 m_pImpl->AppendFieldCommand(sText);
-if (bSdtBlockUnusedText)
-
m_pImpl->m_pSdtHelper->setFieldStartRange(GetCurrentTextRange()->getEnd());
 }
 else if( m_pImpl->IsOpenField() && 
m_pImpl->IsFieldResultAsString())
 {
-if (bSdtBlockUnusedText)
+if (bInSdtBlockText && m_pImpl->m_pSdtHelper->hasUnusedText())
 

[Libreoffice-bugs] [Bug 158301] Calc Function Wizard: Make searching in descriptions optional, not forced

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158301

Heiko Tietze  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #5 from Heiko Tietze  ---
You sound a bit angry, don't be. We obviously have different opinions - you ask
for a checkbox, I doubt it's needed. Accepting the control is not a big deal
for me, just one of many places where we make the application _feel_ heavy,
dated, inefficient.

I think your arguments are not really strong, well the objection is but I don't
see the wide-ranging evidence. Anyway, you need to convince volunteers, and
Andreas is usually open for ideas.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/CppunitTest_sw_txtexport.mk sw/CppunitTest_sw_txtimport.mk sw/CppunitTest_sw_uwriter.mk sw/CppunitTest_sw_xhtmlexport.mk

2023-11-22 Thread Miklos Vajna (via logerrit)
 sw/CppunitTest_sw_txtexport.mk   |2 ++
 sw/CppunitTest_sw_txtimport.mk   |2 ++
 sw/CppunitTest_sw_uwriter.mk |2 ++
 sw/CppunitTest_sw_xhtmlexport.mk |2 ++
 4 files changed, 8 insertions(+)

New commits:
commit 85852ad0d96bfd71413aef94edc1b6e2e6052e1a
Author: Miklos Vajna 
AuthorDate: Wed Nov 22 20:07:25 2023 +0100
Commit: Miklos Vajna 
CommitDate: Thu Nov 23 08:23:38 2023 +0100

CppunitTest_sw_txtexport: turn on 
gb_CppunitTest_set_non_application_font_use

And the same for 3 other tests.

Similar to commit dc4d7500c9d283e26d1553ce11366a217cf1f69d (Fix
CppunitTest_sd_import_tests-smartart non_application_font_use,
2023-10-23), though this didn't find anything so far.

Change-Id: Iceed164c7c171daad2dd20d4e5d809ed05d9ead9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159837
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sw/CppunitTest_sw_txtexport.mk b/sw/CppunitTest_sw_txtexport.mk
index 45b831a67c3d..c0e716a9ccdc 100644
--- a/sw/CppunitTest_sw_txtexport.mk
+++ b/sw/CppunitTest_sw_txtexport.mk
@@ -61,4 +61,6 @@ $(eval $(call gb_CppunitTest_use_rdb,sw_txtexport,services))
 
 $(eval $(call gb_CppunitTest_use_configuration,sw_txtexport))
 
+$(eval $(call gb_CppunitTest_set_non_application_font_use,sw_txtexport,abort))
+
 # vim: set noet sw=4 ts=4:
diff --git a/sw/CppunitTest_sw_txtimport.mk b/sw/CppunitTest_sw_txtimport.mk
index dfd464b11175..fc9955eb596d 100644
--- a/sw/CppunitTest_sw_txtimport.mk
+++ b/sw/CppunitTest_sw_txtimport.mk
@@ -61,4 +61,6 @@ $(eval $(call gb_CppunitTest_use_rdb,sw_txtimport,services))
 
 $(eval $(call gb_CppunitTest_use_configuration,sw_txtimport))
 
+$(eval $(call gb_CppunitTest_set_non_application_font_use,sw_txtimport,abort))
+
 # vim: set noet sw=4 ts=4:
diff --git a/sw/CppunitTest_sw_uwriter.mk b/sw/CppunitTest_sw_uwriter.mk
index 40e6db025fc6..80bf14a8195c 100644
--- a/sw/CppunitTest_sw_uwriter.mk
+++ b/sw/CppunitTest_sw_uwriter.mk
@@ -108,4 +108,6 @@ $(eval $(call gb_CppunitTest_use_components,sw_uwriter,\
 
 $(eval $(call gb_CppunitTest_use_configuration,sw_uwriter))
 
+$(eval $(call gb_CppunitTest_set_non_application_font_use,sw_uwriter,abort))
+
 # vim: set noet sw=4 ts=4:
diff --git a/sw/CppunitTest_sw_xhtmlexport.mk b/sw/CppunitTest_sw_xhtmlexport.mk
index 44c9018bf706..b9532c69bf13 100644
--- a/sw/CppunitTest_sw_xhtmlexport.mk
+++ b/sw/CppunitTest_sw_xhtmlexport.mk
@@ -69,4 +69,6 @@ $(eval $(call gb_CppunitTest_use_uiconfigs,sw_xhtmlexport, \
 svx \
 ))
 
+$(eval $(call 
gb_CppunitTest_set_non_application_font_use,sw_xhtmlexport,abort))
+
 # vim: set noet sw=4 ts=4:


[Libreoffice-bugs] [Bug 157975] close XLS spreadsheet and all the data is lost

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157975

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1
   Keywords||dataLoss

--- Comment #19 from Stéphane Guillou (stragu) 
 ---
I see from bug 158095  that you use Skia/Vulkan. Might be worth it to:
1. Share with us the Skia log copied from: Tools ▸ Options... ▸ LibreOffice ▸
View
2. In the same menu, use "Force Skia software rendering" and see if you still
have issues

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: compilerplugins/clang framework/inc framework/source

2023-11-22 Thread Noel Grandin (via logerrit)
 compilerplugins/clang/fieldcast.results  |3 ---
 framework/inc/services/layoutmanager.hxx |3 ++-
 framework/source/layoutmanager/layoutmanager.cxx |   14 +-
 3 files changed, 7 insertions(+), 13 deletions(-)

New commits:
commit baafd5aca2fd8cbc9d1d5ae8d0b4b8c8a6b68812
Author: Noel Grandin 
AuthorDate: Wed Nov 22 22:07:01 2023 +0200
Commit: Noel Grandin 
CommitDate: Thu Nov 23 08:14:10 2023 +0100

loplugin:fieldcast in LayoutManager

Change-Id: I3fc7a2c690344ee6934111cdffc0b23ff2537b44
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159841
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/fieldcast.results 
b/compilerplugins/clang/fieldcast.results
index aa36df627b34..c794886ec751 100644
--- a/compilerplugins/clang/fieldcast.results
+++ b/compilerplugins/clang/fieldcast.results
@@ -88,9 +88,6 @@ editeng/source/editeng/impedit.hxx:506
 extensions/source/update/check/updatecheck.hxx:164
 UpdateCheck m_pThread WorkerThread *
 (anonymous namespace)::UpdateCheckThread
-framework/inc/services/layoutmanager.hxx:256
-framework::LayoutManager m_xProgressBarBackup 
css::uno::Reference
-framework::ProgressBarWrapper
 framework/inc/uielement/uielement.hxx:89
 framework::UIElement m_xUIElement css::uno::Reference
 framework::AddonsToolBarWrapper
diff --git a/framework/inc/services/layoutmanager.hxx 
b/framework/inc/services/layoutmanager.hxx
index 6675737d4b15..f2f32a53a12f 100644
--- a/framework/inc/services/layoutmanager.hxx
+++ b/framework/inc/services/layoutmanager.hxx
@@ -46,6 +46,7 @@ class MenuBar;
 namespace framework
 {
 class MenuBarWrapper;
+class ProgressBarWrapper;
 class ToolbarLayoutManager;
 class GlobalSettings;
 namespace detail
@@ -254,7 +255,7 @@ namespace framework
 rtl::Reference< MenuBarWrapper >   
m_xMenuBar;
 UIElement  
m_aStatusBarElement;
 UIElement  
m_aProgressBarElement;
-css::uno::Reference< css::ui::XUIElement > 
m_xProgressBarBackup;
+rtl::Reference< ProgressBarWrapper >   
m_xProgressBarBackup;
 css::uno::Reference< css::frame::XModuleManager2 > 
m_xModuleManager;
 css::uno::Reference< css::ui::XUIElementFactoryManager >   
m_xUIElementFactoryManager;
 css::uno::Reference< css::container::XNameAccess > 
m_xPersistentWindowState;
diff --git a/framework/source/layoutmanager/layoutmanager.cxx 
b/framework/source/layoutmanager/layoutmanager.cxx
index 3b5a0af3017c..b915e3f82a26 100644
--- a/framework/source/layoutmanager/layoutmanager.cxx
+++ b/framework/source/layoutmanager/layoutmanager.cxx
@@ -868,7 +868,7 @@ void LayoutManager::implts_createProgressBar()
 {
 Reference< XUIElement > xStatusBar;
 Reference< XUIElement > xProgressBar;
-Reference< XUIElement > xProgressBarBackup;
+rtl::Reference< ProgressBarWrapper > xProgressBarBackup;
 Reference< awt::XWindow > xContainerWindow;
 
 SolarMutexResettableGuard aWriteLock;
@@ -879,10 +879,10 @@ void LayoutManager::implts_createProgressBar()
 xContainerWindow = m_xContainerWindow;
 aWriteLock.clear();
 
-boolbRecycled = xProgressBarBackup.is();
+bool bRecycled = xProgressBarBackup.is();
 rtl::Reference pWrapper;
 if ( bRecycled )
-pWrapper = static_cast(xProgressBarBackup.get());
+pWrapper = xProgressBarBackup.get();
 else if ( xProgressBar.is() )
 pWrapper = static_cast(xProgressBar.get());
 else
@@ -931,17 +931,13 @@ void LayoutManager::implts_backupProgressBarWrapper()
 // safe a backup copy of the current progress!
 // This copy will be used automatically inside createProgressBar() which 
is called
 // implicitly from implts_doLayout() .-)
-m_xProgressBarBackup = m_aProgressBarElement.m_xUIElement;
+m_xProgressBarBackup = 
static_cast(m_aProgressBarElement.m_xUIElement.get());
 
 // remove the relation between this old progress bar and our old status 
bar.
 // Otherwise we work on disposed items ...
 // The internal used ProgressBarWrapper can handle a NULL reference.
 if ( m_xProgressBarBackup.is() )
-{
-ProgressBarWrapper* pWrapper = 
static_cast(m_xProgressBarBackup.get());
-if ( pWrapper )
-pWrapper->setStatusBar( Reference< awt::XWindow >() );
-}
+m_xProgressBarBackup->setStatusBar( Reference< awt::XWindow >() );
 
 // prevent us from dispose() the m_aProgressBarElement.m_xUIElement inside 
implts_reset()
 m_aProgressBarElement.m_xUIElement.clear();


[Libreoffice-commits] core.git: 2 commits - compilerplugins/clang forms/source framework/inc framework/source

2023-11-22 Thread Noel Grandin (via logerrit)
 compilerplugins/clang/fieldcast.results  |6 -
 forms/source/xforms/binding.cxx  |   76 ++-
 forms/source/xforms/binding.hxx  |   11 +--
 forms/source/xforms/model_helper.hxx |4 -
 framework/inc/services/layoutmanager.hxx |5 -
 framework/source/layoutmanager/layoutmanager.cxx |   68 
 6 files changed, 72 insertions(+), 98 deletions(-)

New commits:
commit 89945d719282ba83d6a06be899a1320c40daee12
Author: Noel Grandin 
AuthorDate: Wed Nov 22 22:03:34 2023 +0200
Commit: Noel Grandin 
CommitDate: Thu Nov 23 08:14:02 2023 +0100

loplugin:fieldcast in LayoutManager

Change-Id: Ib0b56703cd6782d850ab5960a7fa53d15eb443a8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159840
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/fieldcast.results 
b/compilerplugins/clang/fieldcast.results
index e803723cd774..aa36df627b34 100644
--- a/compilerplugins/clang/fieldcast.results
+++ b/compilerplugins/clang/fieldcast.results
@@ -88,9 +88,6 @@ editeng/source/editeng/impedit.hxx:506
 extensions/source/update/check/updatecheck.hxx:164
 UpdateCheck m_pThread WorkerThread *
 (anonymous namespace)::UpdateCheckThread
-framework/inc/services/layoutmanager.hxx:253
-framework::LayoutManager m_xMenuBar 
css::uno::Reference
-framework::MenuBarWrapper
 framework/inc/services/layoutmanager.hxx:256
 framework::LayoutManager m_xProgressBarBackup 
css::uno::Reference
 framework::ProgressBarWrapper
diff --git a/framework/inc/services/layoutmanager.hxx 
b/framework/inc/services/layoutmanager.hxx
index 28f78d5bdc0f..6675737d4b15 100644
--- a/framework/inc/services/layoutmanager.hxx
+++ b/framework/inc/services/layoutmanager.hxx
@@ -42,9 +42,10 @@
 #include 
 
 class MenuBar;
+
 namespace framework
 {
-
+class MenuBarWrapper;
 class ToolbarLayoutManager;
 class GlobalSettings;
 namespace detail
@@ -250,7 +251,7 @@ namespace framework
 css::awt::Rectangle
m_aDockingArea;
 css::uno::Reference< css::ui::XDockingAreaAcceptor >   
m_xDockingAreaAcceptor;
 rtl::Reference< MenuBarManager >   
m_xInplaceMenuBar;
-css::uno::Reference< css::ui::XUIElement > 
m_xMenuBar;
+rtl::Reference< MenuBarWrapper >   
m_xMenuBar;
 UIElement  
m_aStatusBarElement;
 UIElement  
m_aProgressBarElement;
 css::uno::Reference< css::ui::XUIElement > 
m_xProgressBarBackup;
diff --git a/framework/source/layoutmanager/layoutmanager.cxx 
b/framework/source/layoutmanager/layoutmanager.cxx
index d4d30416ad26..3b5a0af3017c 100644
--- a/framework/source/layoutmanager/layoutmanager.cxx
+++ b/framework/source/layoutmanager/layoutmanager.cxx
@@ -154,7 +154,7 @@ void LayoutManager::implts_createMenuBar(const OUString& 
rMenuBarName)
 if (m_bInplaceMenuSet || m_xMenuBar.is())
 return;
 
-m_xMenuBar = implts_createElement( rMenuBarName );
+m_xMenuBar.set( static_cast< MenuBarWrapper* >(implts_createElement( 
rMenuBarName ).get()) );
 if ( !m_xMenuBar.is() )
 return;
 
@@ -164,19 +164,15 @@ void LayoutManager::implts_createMenuBar(const OUString& 
rMenuBarName)
 
 Reference< awt::XMenuBar > xMenuBar;
 
-Reference< XPropertySet > xPropSet( m_xMenuBar, UNO_QUERY );
-if ( xPropSet.is() )
+try
+{
+m_xMenuBar->getPropertyValue("XMenuBar") >>= xMenuBar;
+}
+catch (const beans::UnknownPropertyException&)
+{
+}
+catch (const lang::WrappedTargetException&)
 {
-try
-{
-xPropSet->getPropertyValue("XMenuBar") >>= xMenuBar;
-}
-catch (const beans::UnknownPropertyException&)
-{
-}
-catch (const lang::WrappedTargetException&)
-{
-}
 }
 
 if ( !xMenuBar.is() )
@@ -215,12 +211,11 @@ void LayoutManager::impl_clearUpMenuBar()
 {
 Reference< awt::XMenuBar > xMenuBar;
 
-Reference< XPropertySet > xPropSet( m_xMenuBar, UNO_QUERY );
-if ( xPropSet.is() )
+if ( m_xMenuBar.is() )
 {
 try
 {
-xPropSet->getPropertyValue("XMenuBar") >>= xMenuBar;
+m_xMenuBar->getPropertyValue("XMenuBar") >>= xMenuBar;
 }
 catch (const beans::UnknownPropertyException&)
 {
@@ -252,10 +247,11 @@ void LayoutManager::impl_clearUpMenuBar()
 pMenuBar.disposeAndClear();
 m_bInplaceMenuSet = false;
 
-Reference< XComponent > xComp( m_xMenuBar, UNO_QUERY );
-if ( 

[Libreoffice-bugs] [Bug 157386] Writer crash when try to open a DOC file

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157386

Buovjaga  changed:

   What|Removed |Added

 CC||ilmari.lauhakangas@libreoff
   ||ice.org
  Regression By||Attila Szűcs
   Severity|normal  |major
   Priority|medium  |high

--- Comment #11 from Buovjaga  ---
I verified the bibisect with Win 7.3 repo with attachment 189787. The good
result does not ask for a password, though.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146348] FILEOPEN: DOCX: Incorrect footnote with columns

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146348

Steven Casey  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||7386

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157386] Writer crash when try to open a DOC file

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157386

Steven Casey  changed:

   What|Removed |Added

Version|7.4.7.2 release |7.3.0.0.alpha1+
   Keywords|bibisectRequest |bibisected, bisected,
   ||filter:doc
 CC||attila.sz...@collabora.com,
   ||stca...@csumb.edu
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||9336,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||6348

--- Comment #10 from Steven Casey  ---
Regression introduced by:

https://git.libreoffice.org/core/+/4c31b4ef2083087a822c3ae648fd09acc67d2f88%5E%21

author  Attila Szűcs Wed Sep 08 15:51:16 2021 +0200
committer   László NémethTue Nov 02 16:31:24
2021 +0100
tree9dd046549b87431e4cab702cb183b54390908898
parent  83298077a4cd577860e2114b429a2d413c3ea10c 

Bisected with: Win64-7.3

Adding CC: to Attila Szűcs

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157975] close XLS spreadsheet and all the data is lost

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157975

--- Comment #18 from simon.j.hun...@gmail.com ---
i have also had the "close XLS spreadsheet and all the data is lost" problem,
same as before (was with a .xls file).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - sw/source

2023-11-22 Thread Gökay Şatır (via logerrit)
 sw/source/core/edit/edlingu.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 4c6c60d44b0056cbe08b6e75baacbc0df0cd1742
Author: Gökay Şatır 
AuthorDate: Thu Nov 2 13:37:46 2023 +0300
Commit: Gökay ŞATIR 
CommitDate: Thu Nov 23 07:29:38 2023 +0100

Proof reading suggestions:

* When user right clicks an underlined part of the sentence, we are 
checking if there is a suggestion list.
* Then we show the suggestions.

Sometimes spell checker algorithms send 2 lists for the same part of the 
sentence.
And we saw that one of these lists can be empty (no suggestions).
But since we check if there is a list, the empty list is shown to the user.

I updated the checks here and added a new condition:
Now we take the list if the list is not empty.
This way, we can find the not-empty list which may come after an empty list 
(for the same part of the sentence).

Signed-off-by: Gökay Şatır 
Change-Id: Ib3b498b98a8d44f8a7ead99593a71adcefa87a82
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158832
Reviewed-by: Mike Kaganski 
Tested-by: Jenkins CollaboraOffice 

diff --git a/sw/source/core/edit/edlingu.cxx b/sw/source/core/edit/edlingu.cxx
index ab89fc5b7241..923a70c3cb72 100644
--- a/sw/source/core/edit/edlingu.cxx
+++ b/sw/source/core/edit/edlingu.cxx
@@ -1031,7 +1031,8 @@ bool SwEditShell::GetGrammarCorrection(
 auto pError = std::find_if(std::cbegin(rResult.aErrors), 
std::cend(rResult.aErrors),
 [rErrorPosInText, nLen](const 
linguistic2::SingleProofreadingError ) {
 return rError.nErrorStart <= rErrorPosInText
-&& rErrorPosInText + nLen <= rError.nErrorStart + 
rError.nErrorLength; });
+&& rErrorPosInText + nLen <= rError.nErrorStart + 
rError.nErrorLength
+&& rError.aSuggestions.size() > 0; });
 if (pError != std::cend(rResult.aErrors))
 {
 rSuggestions = pError->aSuggestions;


[Libreoffice-bugs] [Bug 153373] FILEOPEN LibreOffice doesn't open MS Office templates correctly

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153373

Buovjaga  changed:

   What|Removed |Added

 Resolution|FIXED   |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158326] FILTER autofilter seems to convert ß in ss and ignores value

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158326

--- Comment #3 from BogdanB  ---
7.3.0.0.alpha0+ is working well for me
Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 9df0e11c48071fb5ed98d474ea036a3f7d10e7ba
CPU threads: 16; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded

Also in
Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 10981fb2fa26474f432e85165b1babbca6d74e16
CPU threads: 16; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded

Also in
Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: b419eb4bd407c26ee813a347fdf14424908379e1
CPU threads: 16; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded


NOT WORKING in
Version: 7.6.2.1 (X86_64) / LibreOffice Community
Build ID: 56f7684011345957bbf33a7ee678afaf4d2ba333
CPU threads: 16; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded

NOT working in
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 94d2d9a59450fa4bccd0a3a450d8b273271d2ff2
CPU threads: 16; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158326] FILTER autofilter seems to convert ß in ss and ignores value

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158326

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g

--- Comment #2 from BogdanB  ---
Created attachment 190983
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190983=edit
Demo document

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138787] Add application/msword-template as MimeType for libreoffice-writer.desktop

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138787

Frank Reibold  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=15 |
   |3373|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153373] FILEOPEN LibreOffice doesn't open MS Office templates correctly

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153373

Frank Reibold  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=13 |
   |8787|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153373] FILEOPEN LibreOffice doesn't open MS Office templates correctly

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153373

Frank Reibold  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #24 from Frank Reibold  ---
The bug has been fixed.

Both documents look good with LibreOffice Writer 7.6.3.1.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152418] Print on #10 envelope not legible

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152418

Dieter  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152418] Print on #10 envelope not legible

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152418

BogdanB  changed:

   What|Removed |Added

Summary|Print on #10 envelope not   |Print on #10 envelope not
   |legible.|legible

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152418] Print on #10 envelope not legible.

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152418

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g
 Whiteboard| QA:needsComment|

--- Comment #2 from BogdanB  ---
Meanwhile, were released many new versions of LibreOffice, and also Windows 11
was getting new updates. Can you test on a new version of LibreOffice, like
7.6?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158330] .otp file extension no longer causes 'template' behaviour?

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158330

--- Comment #1 from Mike Kaganski  ---
Now save as OTP (so not only "rename to .otp" - because OTP has a different
MIME), and repeat the test.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158331] Android Viewer: "Save as" creates 0 byte file (with Experimentation Mode turned off)

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158331

--- Comment #1 from Kira Tubo  ---
Created attachment 190982
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190982=edit
Video - zero byte file created

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158331] New: Android Viewer: "Save as" creates 0 byte file (with Experimentation Mode turned off)

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158331

Bug ID: 158331
   Summary: Android Viewer: "Save as" creates 0 byte file (with
Experimentation Mode turned off)
   Product: LibreOffice
   Version: 7.6.3.2 rc
  Hardware: All
OS: Android
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Android Viewer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kira.t...@gmail.com

Description:
If Experimentation is turned off, the "Save as" functionality creates a 0 byte
file with no data

Steps to Reproduce:
Prerequisite: Experimental Mode is turned off
1. Open Android Viewer
2. Open any file that has data in it (ex: writer odt file)
3. Tap 3 dot menu
4. Tap "Save as"
5. Save the file
6. Return to the previous screen
7. Tap "Select file to open"
8. Check the size of the file that was created
9. Tap on the file
10. Check the contents of the file 

Actual Results:
The "Save as" function creates 0 byte file with no data with Experimentation
Mode turned off. Note: if Experimentation Mode is turned on, this issue does
not occur. 

Expected Results:
The user should be able to create a copy of the file using the "Save as"
functionality. OR the "Save as" functionality should be removed if
"Experimentation Mode" is turned off. 


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.6.3.2.0+
Build ID: 0e982fe4db35
Device: Google Pixel 6
Android version: 13

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155013] LibreOffice crashed

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155013

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158266] Writer: problem opening a .docx file (normal text, no video or audio involved)

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158266

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158286] FILEOPEN -Windows10- LibreOffice doesn't start at all after a power outage incidence

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158286

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158286] FILEOPEN -Windows10- LibreOffice doesn't start at all after a power outage incidence

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158286

--- Comment #8 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158266] Writer: problem opening a .docx file (normal text, no video or audio involved)

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158266

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158212] Crash on M1 Silicon Mac when using Zoom Accessibility on Mac

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158212

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155013] LibreOffice crashed

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155013

--- Comment #4 from QA Administrators  ---
Dear ah919208,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158212] Crash on M1 Silicon Mac when using Zoom Accessibility on Mac

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158212

--- Comment #7 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 47052] Recovery fails because no access to AppData Temp folder

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=47052

--- Comment #12 from dossierstate  ---
It'd be great to get the registrymodifications.xcu file from both the old and
new settings directories, to see if we can compare them & see what's up there.
http://wiki.documentfoundation.org/BugReport https://happy-wheels.co
Thanks !

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Writer colourspaces

2023-11-22 Thread Patrick Luby
What happens when you zoom out the Preview window something like 10x and 
set Digital Color Meter to "Display in sRGB"?


I tested a simple PDF that I created by putting red text in a Writer 
document. Export to PDF. Open in Preview. Digital Color Meter says the 
text is varying shades of nearly red. Zoom way, way in so that a letter 
a few inches tall and now I see pure sRGB red (i.e. 255, 0, 0).


Patrick


On 2023-11-22 3:35 a.m., Chris Tapp wrote:

On 21 Nov 2023, at 16:29, Thorsten Behrens  wrote:

Noel Grandin wrote:

But the code is not doing anything clever, there is no active color space
management in LO.
The macOS code is largely in vcl/osx/ and the color space constants we seem
to use are kCGColorSpaceSRGB and kCGColorSpaceGenericGrayGamma2_2


Though presumably then we could make sure that an sRGB colour space
also set for outputting all PDF colours (it is already apparently set
for rendering text & solid colours inside LibreOffice, on OSX)?


I’m also seeing color changes within images that I do not see when they are 
used in other MacOS apps.

For example, I have a logo that shows as having a color of #5A1C24 (using 
Digital Color Meter / Display native values) when open in Preview, Word, and 
others, but it shows as #6E when inserted into LO and in a PDF exported 
from it (the original is s JPEG, and it shows as #5A1C24 when opened in 
Preview).

Chris


PDF export is here:
vcl/source/gdi/pdfwriter*.cxx

Cheers,

-- Thorsten




[Libreoffice-bugs] [Bug 158286] FILEOPEN -Windows10- LibreOffice doesn't start at all after a power outage incidence

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158286

--- Comment #7 from Besbin  ---
Great ! Great !
 S U C C E S S S S S S ..! :-)

Thank you so much sir Julien.
My LO is completely back on. I'm so happy right now because I'm able to access
all my LO files again.

Thank you once again for your technical guidance. I have learned some new stuff
from you.

Have a nice day.

~Besbin

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158330] New: .otp file extension no longer causes 'template' behaviour?

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158330

Bug ID: 158330
   Summary: .otp file extension no longer causes 'template'
behaviour?
   Product: LibreOffice
   Version: 7.5.8.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: j...@curioussymbols.com

Description:
.otp, .ott etc extensions used to cause LibreOffice to open new files based on
a template. That behaviour seems to have gone away, and an .otp file on my
system behaves exactly the same as the .odp file that I started with. 

This open-as-template behaviour (which I believe was supported in the past) is
useful, since one can have per-project presentation templates that need to be
followed. It is not convenient for templates to be filed away in a mysterious
internal folder by LO, given that working on projects files need to be saved in
shared-access project folder.

Steps to Reproduce:
1.create .odp file
2.rename to .otp file
3.open the file

Actual Results:
file opens and can be edited and saved as normal

Expected Results:
expected a 'new' file that, if saved, would prompt a filename for where to save
it.
(if I wanted to edit the template itself, I would use the file-open menu in LO
itself)


Reproducible: Always


User Profile Reset: No

Additional Info:
this behaviour pattern follows what is done in Word with .dot files for
example.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155092] UI: Erratic behaviour after resizing spreadsheet window size

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155092

--- Comment #17 from Patrick Luby  ---
OK. I have upgraded LibreOffice to use the newer "tracking areas" selectors in
the following patch. I will commit it once it passes unit tests:

https://gerrit.libreoffice.org/c/core/+/159845

In the meantime, I will continue testing as I suspect that my patch is not a
complete fix and only eliminates the bug ~95% of the time.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158329] (RTL: Arabic, Hebrew)Exported PDF is not searchable in certain languages

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158329

--- Comment #3 from Saburo  ---
Created attachment 190981
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190981=edit
exported242

Sample file exported to PDF using LibO24.2

The same thing happens with [attachments
file](https://bugs.documentfoundation.org/attachment.cgi?id=134028) in [Bug
91764](https://bugs.documentfoundation.org/show_bug.cgi?id=91764).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158329] (RTL: Arabic, Hebrew)Exported PDF is not searchable in certain languages

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158329

--- Comment #2 from Saburo  ---
Created attachment 190980
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190980=edit
exported747

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158329] (RTL: Arabic, Hebrew)Exported PDF is not searchable in certain languages

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158329

--- Comment #1 from Saburo  ---
Created attachment 190979
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190979=edit
sample file

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158329] New: (RTL: Arabic, Hebrew)Exported PDF is not searchable in certain languages

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158329

Bug ID: 158329
   Summary: (RTL: Arabic, Hebrew)Exported PDF is not searchable in
certain languages
   Product: LibreOffice
   Version: 7.5.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Printing and PDF export
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: yosi3260+li...@gmail.com

Description:
PDFs exported with LibO7.4 can be found by searching for Hebrew in a PDF
reader, but PDFs exported with LibO7.5 and later cannot be found by searching
for Hebrew.
Posted on ask
https://ask.libreoffice.org/t/writer-pdf/98051

It seems that the characters are stored separately and cannot be recognized as
words.

Steps to Reproduce:
1.Export sample files to PDF 
2.Open that PDF in a reader
3.Search for וַיְהִ֥י

Actual Results:
Not found.

Expected Results:
will hit


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: ff3fb42b48c70ba5788507a6177bf0a9f3b50fdb
CPU threads: 12; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: ja-JP (ja_JP); UI: ja-JP
Calc: CL threaded

Version: 7.4.7.2 (x64) / LibreOffice Community
Build ID: 723314e595e8007d3cf785c16538505a1c878ca5
CPU threads: 12; OS: Windows 10.0 Build 22621; UI render: Skia/Vulkan; VCL: win
Locale: ja-JP (ja_JP); UI: ja-JP
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158328] Android Viewer: Keyboard disappears when table cell expands to new line while typing

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158328

--- Comment #1 from Kira Tubo  ---
Created attachment 190978
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190978=edit
Video - keyboard disappears typing in table cell

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158328] New: Android Viewer: Keyboard disappears when table cell expands to new line while typing

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158328

Bug ID: 158328
   Summary: Android Viewer: Keyboard disappears when table cell
expands to new line while typing
   Product: LibreOffice
   Version: 7.6.3.2 rc
  Hardware: All
OS: Android
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Android Viewer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kira.t...@gmail.com

Description:
In Android Viewer, the keyboard disappears while typing when the table cell
expands to a new line. 

Steps to Reproduce:
Prerequisite: On home page > 3 dot menu > Settings > enable Experimental Mode
to allow for edits
1. Open Android Viewer
2. Open Impress odp file or Draw odg file (note: Writer odt files do not have
this issue)
3. Tap on document to display editing options
4. Tap on 'A' icon
5. Tap on Insert tab
6. Tap on Table icon
7. Choose to Insert Table
8. Tap OK
9. Tap on a table cell (also tap on keyboard icon to display keyboard if
needed)
10. Type continuously until table cell expands to a new line

Actual Results:
When the table cell expands to a new line, the keyboard disappears. Note: this
issue has occurred for Impress odp and Draw odg files, but not Writer odt
files. 

Expected Results:
If the table cell expands to a new line, the keyboard should remain on the
screen. 


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.6.3.2.0+
Build ID: 0e982fe4db35
Device: Google Pixel 6
Android version: 13

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158327] Android Viewer: Cannot select/reposition/resize inserted line/shape/image

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158327

--- Comment #1 from Kira Tubo  ---
Created attachment 190977
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190977=edit
Video - adjust position and size of shape

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158327] New: Android Viewer: Cannot select/reposition/resize inserted line/shape/image

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158327

Bug ID: 158327
   Summary: Android Viewer: Cannot select/reposition/resize
inserted line/shape/image
   Product: LibreOffice
   Version: 7.6.3.2 rc
  Hardware: All
OS: Android
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Android Viewer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kira.t...@gmail.com

Description:
In Android Viewer, the user can insert lines, rectangles, and images, but
cannot adjust (select, reposition, resize) them once inserted 

Steps to Reproduce:
Prerequisite: On home page > 3 dot menu > Settings > enable Experimental Mode
to allow for edits
1. Open Android Viewer
2. Open any file (ex: Impress odp file or Draw odg file)
3. Tap on page to display editing options
4. Tap on 'A' icon 
5. Tap on Insert tab
6. Tap on Line, Rectangle or insert an image
7. Single tap on inserted line/rectangle/image
8. Hold and drag the selected shape
9. Hold and drag the endpoint of the shape

Actual Results:
Users cannot adjust (select, reposition, resize) the line, shape, or image that
are inserted. Single tap shows a small circle at the edge of the screen, but it
isn't clear if this means the shape is selected. Attempting to drag with one
finger only adjusts the view of the screen, not the position/size of the shape. 

Expected Results:
Users should be able to adjust inserted lines, shapes, images. Single tap
should select the shape/image. Holding and dragging selected shape with one
finger should adjust the position of the shape. Holding and dragging selected
shape with one finger at the endpoint (corner) of the shape should adjust the
size. 



Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.6.3.2.0+
Build ID: 0e982fe4db35
Device: Google Pixel 6
Android version: 13

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158325] Option to start row at 0

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158325

m.a.riosv  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158325] Option to start row at 0

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158325

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m.a.riosv  ---
About what headers are you referring?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158326] FILTER autofilter seems to convert ß in ss and ignores value

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158326

m.a.riosv  changed:

   What|Removed |Added

 Ever confirmed|0   |1
   Severity|minor   |normal
 CC||miguelangelrv@libreoffice.o
   ||rg
 Status|UNCONFIRMED |NEW
   Keywords||bibisectRequest, regression

--- Comment #1 from m.a.riosv  ---
Reproducible:
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: bc5c767e9aebadf12aa6a181a6ce066cbfff71ad
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: default; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL threaded
Version: 7.4.7.2 (x64) / LibreOffice Community
Build ID: 723314e595e8007d3cf785c16538505a1c878ca5
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: es-ES Calc: CL


Last working for me:
Version: 7.2.7.2 (x64) / LibreOffice Community
Build ID: 8d71d29d553c0f7dcbfa38fbfda25ee34cce99a2
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: es-ES Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145461] + Sign not Visible in Styles Deck Hierarchical View when a Style is Highlighted (Windows 7 only)

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145461

Dieter  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

--- Comment #7 from Dieter  ---
(In reply to Radish from comment #6)
> I can't reproduce any more as I have moved from Windows 7 to Windows 10.

Since we have no information, if it is still present in Windows 7 and perhaps
we won't get that information, let's close it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150120] FILEOPEN DOCX Embededd OLE object (XLSX spreadsheet) is missing

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150120

jindam, vani  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #8 from jindam, vani  ---
* repro_ opensuse tumbleweed 20231120
Version: 7.6.3.1 (ARM_EABI) / LibreOffice Community
Build ID: 60(Build:1)
CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: x11
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158300] ods file closed by Viewer if experimental mode is enabled

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158300

Michael Weghorn  changed:

   What|Removed |Added

Summary|ods file closed by Viewer   |ods file closed by Viewer
   ||if experimental mode is
   ||enabled

--- Comment #10 from Michael Weghorn  ---
(In reply to Sophie Sipasseuth from comment #9)
> Yes, I confirm it is related to the experimental mode.

Great, thanks for the confirmation. While crashes are always bad, that at least
makes it less critical.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158054] Pivot tables messed up

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158054

--- Comment #5 from Luca A.  ---
(In reply to Stéphane Guillou (stragu) from comment #4)
> Luca, are you able to provide steps that trigger the issue?
> I can see the end result in the attached file, but I don't know how to
> reproduce such mangling of pivot tables.

Dear Stéphane,
first of all, thank you for your kind attention!
I turned back my LibrOffice version from 7.6 back to 7.5.
Then I erased and rebuilt the single pivot tables, that were not working
everytime I tried to update them.
I don't know if the issue regards the latest version or something wrong in the
pivot tables themselves (anyway, every time they were built by copying the
previous one and modifying dates in the main filter, and that method had always
worked for more than 24 months...).
The good news is that now these recent new tables work correctly as usual, so I
cannot reproduce the issue.
THank you all again for the cooperation.
L.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158054] Pivot tables messed up

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158054

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #4 from Stéphane Guillou (stragu) 
 ---
Luca, are you able to provide steps that trigger the issue?
I can see the end result in the attached file, but I don't know how to
reproduce such mangling of pivot tables.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104780] Impossible to copy and paste a Pivot Tables

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104780

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||7418

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108912] [META] Sheet-level bugs and enhancements

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108912

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||157418


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157418
[Bug 157418] EDITING: when you copy sheets with a Pivot table to another
spreadsheet, the copy is not a Pivot table
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157418] EDITING: when you copy sheets with a Pivot table to another spreadsheet, the copy is not a Pivot table

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157418

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||4780
Version|7.6.0.3 release |Inherited From OOo
 Blocks||108912

--- Comment #3 from Stéphane Guillou (stragu) 
 ---
Same in OOo 3.3, so inherited.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108912
[Bug 108912] [META] Sheet-level bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/qa

2023-11-22 Thread Xisco Fauli (via logerrit)
 sc/qa/unit/data/ods/tdf125580.ods   |binary
 sc/qa/unit/subsequent_filters_test4.cxx |   19 +++
 2 files changed, 19 insertions(+)

New commits:
commit 9602f8a9318dd4d3409856e2ae06abe96e72b51b
Author: Xisco Fauli 
AuthorDate: Wed Nov 22 16:37:44 2023 +0100
Commit: Xisco Fauli 
CommitDate: Wed Nov 22 21:57:28 2023 +0100

tdf#125580: sc_subsequent_filters_test4: Add unittest

Change-Id: Ia7be1c4dd1f4d748bb70fdc43c52825b4dade1b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159836
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sc/qa/unit/data/ods/tdf125580.ods 
b/sc/qa/unit/data/ods/tdf125580.ods
new file mode 100644
index ..4ca1000efa93
Binary files /dev/null and b/sc/qa/unit/data/ods/tdf125580.ods differ
diff --git a/sc/qa/unit/subsequent_filters_test4.cxx 
b/sc/qa/unit/subsequent_filters_test4.cxx
index 4a7401e84337..aa3dc5ab7adf 100644
--- a/sc/qa/unit/subsequent_filters_test4.cxx
+++ b/sc/qa/unit/subsequent_filters_test4.cxx
@@ -1946,6 +1946,25 @@ CPPUNIT_TEST_FIXTURE(ScFiltersTest4, testTdf142905)
 CPPUNIT_ASSERT_EQUAL(OUString(" 3M   "), pDoc->GetString(2, 0, 0));
 }
 
+CPPUNIT_TEST_FIXTURE(ScFiltersTest4, testTdf125580)
+{
+createScDoc("ods/tdf125580.ods");
+ScDocument* pDoc = getScDoc();
+ScDocShell* pDocSh = getScDocShell();
+pDocSh->DoHardRecalc();
+
+// Without the fix in place, this test would have failed with
+// - Expected: 11/22/23 04:30 PM
+// - Actual  : 11/22/23 04:29 PM
+// - At row 19
+for (SCROW i = 0; i <= 40; ++i)
+{
+OString sMessage = "At row " + OString::number(i + 1);
+CPPUNIT_ASSERT_EQUAL_MESSAGE(sMessage.getStr(), pDoc->GetString(0, i, 
0),
+ pDoc->GetString(1, i, 0));
+}
+}
+
 CPPUNIT_TEST_FIXTURE(ScFiltersTest4, testRowImportCellStyleIssue)
 {
 // Test checks that the correct cell style is imported for the first 6 
rows and then the rest of the rows.


[Libreoffice-bugs] [Bug 158326] New: FILTER autofilter seems to convert ß in ss and ignores value

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158326

Bug ID: 158326
   Summary: FILTER autofilter seems to convert ß in ss and ignores
value
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bugzilla-libreoff...@cs.stachelkaktus.net

If a dataset contains following values:

...
Strasser
Straßer

and an autofilter is applied, the value Straßer is ignored and not visible in
the filter list.

If the dataset changes to 
...
Strasser
Straßer <--- with space

the value "Straßer " is in the filter list, but the values will still be not
shown after selection.

If the dataset changes to 
...
Strasser
 Straßer

with space on the beginning it works as it should.

Thank you very much for your great work.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 109232] [META] Special character dialog and toolbar group button bugs and enhancements

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=109232
Bug 109232 depends on bug 154088, which changed state.

Bug 154088 Summary: The implementation of drawing the grid of the characters 
should be unified
https://bugs.documentfoundation.org/show_bug.cgi?id=154088

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: include/svx svx/source

2023-11-22 Thread AmosAidoo (via logerrit)
 include/svx/charmap.hxx |3 
 include/svx/searchcharmap.hxx   |2 
 svx/source/dialog/charmap.cxx   |   13 ++-
 svx/source/dialog/searchcharmap.cxx |  152 +---
 4 files changed, 20 insertions(+), 150 deletions(-)

New commits:
commit 94d2d9a59450fa4bccd0a3a450d8b273271d2ff2
Author: AmosAidoo 
AuthorDate: Tue Nov 21 03:17:12 2023 +0100
Commit: Andreas Heinisch 
CommitDate: Wed Nov 22 21:49:57 2023 +0100

tdf#154088 Merge code snippets for character retrieval and string 
construction

The DrawChars_Impl method has been unified since the duplicates were 
identical
and only differed in how they retrieved characters from a separate source. 
Each
class now has its own implentation of GetCharFromIndex as a solution.

Change-Id: Ic2d10a46a91ea8dee2c94b620e6745bf77ae9eab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159773
Tested-by: Jenkins
Reviewed-by: Hossein 

diff --git a/include/svx/charmap.hxx b/include/svx/charmap.hxx
index 8057eae3c1bd..1c440b6ee2c1 100644
--- a/include/svx/charmap.hxx
+++ b/include/svx/charmap.hxx
@@ -66,6 +66,7 @@ public:
 
 voidSelectCharacter( sal_UCS4 cNew );
 virtual sal_UCS4GetSelectCharacter() const;
+virtual sal_UCS4GetCharFromIndex(int index) const;
 voidcreateContextMenu(const Point& rPosition);
 
 voidSetDoubleClickHdl( const Link& rLink 
) { aDoubleClkHdl = rLink; }
@@ -148,7 +149,7 @@ protected:
 
 protected:
 virtual bool KeyInput(const KeyEvent&) override;
-virtual voidDrawChars_Impl(vcl::RenderContext& rRenderContext, 
int n1, int n2);
+voidDrawChars_Impl(vcl::RenderContext& rRenderContext, int n1, 
int n2);
 voidInitSettings(vcl::RenderContext& rRenderContext);
 // abstraction layers are: Unicode<->MapIndex<->Pixel
 Point   MapIndexToPixel( int) const;
diff --git a/include/svx/searchcharmap.hxx b/include/svx/searchcharmap.hxx
index d05f3ea82728..b07d58a4c8ad 100644
--- a/include/svx/searchcharmap.hxx
+++ b/include/svx/searchcharmap.hxx
@@ -44,6 +44,7 @@ public:
 
 voidSelectCharacter( const Subset* sub);
 virtual sal_UCS4GetSelectCharacter() const override;
+virtual sal_UCS4GetCharFromIndex(int index) const 
override;
 
 virtual svx::SvxShowCharSetItem*ImplGetItem( int _nPos ) override;
 virtual int LastInView() const override;
@@ -59,7 +60,6 @@ private:
 //to uniquely identify each appended element
 std::unordered_map m_aItemList;
 private:
-virtual void DrawChars_Impl(vcl::RenderContext& rRenderContext, int n1, 
int n2) override;
 virtual void Paint(vcl::RenderContext& rRenderContext, const 
tools::Rectangle& rRect) override;
 virtual bool KeyInput(const KeyEvent& rKEvt) override;
 };
diff --git a/svx/source/dialog/charmap.cxx b/svx/source/dialog/charmap.cxx
index be2d991977b5..dcb1205584d7 100644
--- a/svx/source/dialog/charmap.cxx
+++ b/svx/source/dialog/charmap.cxx
@@ -534,12 +534,17 @@ void SvxShowCharSet::DrawChars_Impl(vcl::RenderContext& 
rRenderContext, int n1,
 tools::Rectangle aBoundRect;
 for (i = n1; i <= n2; ++i)
 {
+sal_UCS4 charValue = GetCharFromIndex(i);
+
+if (charValue == 0)
+continue;
+
+OUString aCharStr(, 1);
+
 Point pix = MapIndexToPixel(i);
 int x = pix.X();
 int y = pix.Y();
 
-sal_UCS4 nChar = mxFontCharMap->GetCharFromIndex(i);
-OUString aCharStr(, 1);
 int nTextWidth = rRenderContext.GetTextWidth(aCharStr);
 int tx = x + (nX - nTextWidth + 1) / 2;
 int ty = y + (nY - nTextHeight + 1) / 2;
@@ -672,6 +677,10 @@ sal_UCS4 SvxShowCharSet::GetSelectCharacter() const
 return getSelectedChar();
 }
 
+sal_UCS4 SvxShowCharSet::GetCharFromIndex(int index) const
+{
+return mxFontCharMap->GetCharFromIndex(index);
+}
 
 void SvxShowCharSet::RecalculateFont(vcl::RenderContext& rRenderContext)
 {
diff --git a/svx/source/dialog/searchcharmap.cxx 
b/svx/source/dialog/searchcharmap.cxx
index dc3ef7bcecab..2a770eac57de 100644
--- a/svx/source/dialog/searchcharmap.cxx
+++ b/svx/source/dialog/searchcharmap.cxx
@@ -140,6 +140,12 @@ void SvxSearchCharSet::SelectCharacter( const Subset* sub )
 Invalidate();
 }
 
+sal_UCS4 SvxSearchCharSet::GetCharFromIndex(int index) const
+{
+std::unordered_map::const_iterator got = 
m_aItemList.find(index);
+return (got != m_aItemList.end()) ? got->second : 0;
+}
+
 void SvxSearchCharSet::Paint(vcl::RenderContext& rRenderContext, const 
tools::Rectangle&)
 {
 InitSettings(rRenderContext);
@@ -147,152 +153,6 @@ void SvxSearchCharSet::Paint(vcl::RenderContext& 
rRenderContext, const tools::Re
 DrawChars_Impl(rRenderContext, FirstInView(), LastInView());
 }
 
-void 

[Libreoffice-bugs] [Bug 158072] Fails to apply AutoFilter or Standard Filter in Mail Merge dialog after it was applied once successfully (Writer+Calc)

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158072

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

  Regression By||Noel Grandin
Version|7.6.2.1 release |7.6.0.0 alpha0+
   Keywords|bibisectRequest |bibisected, bisected

--- Comment #2 from Stéphane Guillou (stragu) 
 ---
Bibisected with comment 1 steps and linux-64-7.6 repo to first bad build commit
[72f0cb3c4944426945266c1dab48e09e9768c0c0] which points to:

commit  66b0bc55854ba13b92b6c39b95f3f2d4ef76bf20
author  Noel GrandinFri Mar 10 10:35:33 2023 +0200
committer   Noel GrandinFri Mar 10 09:50:16 2023 +
simplify initialisation in *DatabaseMetaData
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148594

Noel, can you please have a look?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158322] Numbered list sign wont disappear and is not deletable when used in heading and is deactivated through button

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158322

Julien Nabet  changed:

   What|Removed |Added

Summary|Numbered list sign wont |Numbered list sign wont
   |disapear and is not |disappear and is not
   |deletable when used in  |deletable when used in
   |heading and is deactivated  |heading and is deactivated
   |through button  |through button

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-qa] Minutes from the UX/design meeting 2023-Nov-22

2023-11-22 Thread Heiko Tietze

Present: Maija, Sahil, Julia, Eyal, John, Cor, Heiko
Comments: LeroyG, Mike, Ady, Rafael, Werner, Tomaz, Csongor

Tickets/Topics

 * Conducting a survey around LibreOffice
   + How often would you accept a nag screen?
   + Would you appreciate a welcome screen with some initial questions?
   + ...
   + to bring the results into something actionable is challenging
 but expected by the participants (Cor)

 * Inconsistent behavior of "New style from selection" in Styles list
   and Styles menu
   + https://bugs.documentfoundation.org/show_bug.cgi?id=151563
   + works as expected in the Stylist but not anywhere else
   + add the "paragraph" to the string, at least (LeroyG)
   + alternative commands for every individual style (Mike)
   + not obvious that the command uno:StyleNewByExample is needed
 in menu/toolbar/shortcut (Eyal)
 + not so important (Cor, John)
   + drop customizability and access in the UI except the Stylist (Heiko)
 + drawback is that one needs to activate the Stylist
 + extra UNO commands would be needed for the Notebookbars too (John)
   + change just the title for now (Cor, Eyal)
   + PS can be added by directly adding the name to the styles toolbar
 control and we could provide an analogue control for CS (Cor)
   => change command title


 * add UNO command for Hidden font effect of characters in Writer
   + https://bugs.documentfoundation.org/show_bug.cgi?id=158168
   + easy to customize via user-defined character style (Heiko)
   + disagree since it means to multiply CS (Eyal)
   + suggest to add it as DF (Eyal, John)
   + depending on the use case it be necessary to add the attribute
 on top of any format; example workflow is to have words in different
 language next to each other and hide one or the other (Cor)
   + but tend to agree with WF/NAB (Cor)
   => add UNO command (but dont show on the UI by default)

 * Sidebar pane shortcuts conflict with Alt+NumPad input
   + https://bugs.documentfoundation.org/show_bug.cgi?id=158112
   + alt+num code is used to insert characters not on the keyboard (Ady)
   + make it depending on the OS/DE (Eyal)
   + use alt+shift+ (Heiko)
 + Acceptable (Eyal)
   + remove shortcuts, or make it so users can customize it
 + no so good (Eyal)
   + involve a11y into the discussion (Eyal)
   + ctrl+alt+ is available for customization!
   => comment

 * Add 'shuffle' or 'random' option to 'Sort' dialog
   + https://bugs.documentfoundation.org/show_bug.cgi?id=158196
   + functionality not available in Excel too
   + agree to the need for UNO command to shuffling cell range,
 rows, columns (Rafael)
   + better suited for Sheet > Fill Cells (Werner)
 + definitely not (Tomaz)
   + frequently needed; best suited for the sort dialog as another
 option after ascending/descending (Csongor)
   + wonder if randomization needs to have a start value to get
 the same result repeatedly (Eyal)
 + should not (Cor)
   + expect it as extra command under Data among Sort (John)
   + bloats the dialog (Cor)
   + would rather like to see it in the dialog; would be more
 visible (Eyal)
   + hard to wrap the mind around sort first by col A, the
 by random B, and finally by C (Heiko)
   => UNO command might be the best choice


OpenPGP_signature.asc
Description: OpenPGP digital signature


Minutes from the UX/design meeting 2023-Nov-22

2023-11-22 Thread Heiko Tietze

Present: Maija, Sahil, Julia, Eyal, John, Cor, Heiko
Comments: LeroyG, Mike, Ady, Rafael, Werner, Tomaz, Csongor

Tickets/Topics

 * Conducting a survey around LibreOffice
   + How often would you accept a nag screen?
   + Would you appreciate a welcome screen with some initial questions?
   + ...
   + to bring the results into something actionable is challenging
 but expected by the participants (Cor)

 * Inconsistent behavior of "New style from selection" in Styles list
   and Styles menu
   + https://bugs.documentfoundation.org/show_bug.cgi?id=151563
   + works as expected in the Stylist but not anywhere else
   + add the "paragraph" to the string, at least (LeroyG)
   + alternative commands for every individual style (Mike)
   + not obvious that the command uno:StyleNewByExample is needed
 in menu/toolbar/shortcut (Eyal)
 + not so important (Cor, John)
   + drop customizability and access in the UI except the Stylist (Heiko)
 + drawback is that one needs to activate the Stylist
 + extra UNO commands would be needed for the Notebookbars too (John)
   + change just the title for now (Cor, Eyal)
   + PS can be added by directly adding the name to the styles toolbar
 control and we could provide an analogue control for CS (Cor)
   => change command title


 * add UNO command for Hidden font effect of characters in Writer
   + https://bugs.documentfoundation.org/show_bug.cgi?id=158168
   + easy to customize via user-defined character style (Heiko)
   + disagree since it means to multiply CS (Eyal)
   + suggest to add it as DF (Eyal, John)
   + depending on the use case it be necessary to add the attribute
 on top of any format; example workflow is to have words in different
 language next to each other and hide one or the other (Cor)
   + but tend to agree with WF/NAB (Cor)
   => add UNO command (but dont show on the UI by default)

 * Sidebar pane shortcuts conflict with Alt+NumPad input
   + https://bugs.documentfoundation.org/show_bug.cgi?id=158112
   + alt+num code is used to insert characters not on the keyboard (Ady)
   + make it depending on the OS/DE (Eyal)
   + use alt+shift+ (Heiko)
 + Acceptable (Eyal)
   + remove shortcuts, or make it so users can customize it
 + no so good (Eyal)
   + involve a11y into the discussion (Eyal)
   + ctrl+alt+ is available for customization!
   => comment

 * Add 'shuffle' or 'random' option to 'Sort' dialog
   + https://bugs.documentfoundation.org/show_bug.cgi?id=158196
   + functionality not available in Excel too
   + agree to the need for UNO command to shuffling cell range,
 rows, columns (Rafael)
   + better suited for Sheet > Fill Cells (Werner)
 + definitely not (Tomaz)
   + frequently needed; best suited for the sort dialog as another
 option after ascending/descending (Csongor)
   + wonder if randomization needs to have a start value to get
 the same result repeatedly (Eyal)
 + should not (Cor)
   + expect it as extra command under Data among Sort (John)
   + bloats the dialog (Cor)
   + would rather like to see it in the dialog; would be more
 visible (Eyal)
   + hard to wrap the mind around sort first by col A, the
 by random B, and finally by C (Heiko)
   => UNO command might be the best choice


OpenPGP_signature.asc
Description: OpenPGP digital signature


[Libreoffice-bugs] [Bug 133092] [META] Crash bugs

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133092

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||158323


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=158323
[Bug 158323] CRASH when switch back from HTML View to Normal View after edit in
HTML source code
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158323] CRASH when switch back from HTML View to Normal View after edit in HTML source code

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158323

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   Severity|normal  |critical
 CC||stephane.guillou@libreoffic
   ||e.org
 Status|UNCONFIRMED |NEW
   Keywords||bibisectRequest, regression
 Blocks||133092
 Ever confirmed|0   |1
 OS|Windows (All)   |All

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
Thank you for the report!

(In reply to Rainer Bielefeld Retired from comment #0)
> 1. Open sample document "own.HTML"
> 2. HTM Source View
I had to use the command "create HTML document" (.uno:NewHtmlDoc) before being
able to use that source view (.uno:SourceView).

Reproduced the crash:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 7d357628d6e8ce3f9e3c3a567ada21f02bce8d42
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Without sample doc:
1. Open Writer
2. File > New > HTML document
3. Write "Test"
4. Switch to Source View, save document as prompted
5. Remove "Test" from the source
6. Turn Source View off

No repro in:

Version: 7.6.3.1 (X86_64) / LibreOffice Community
Build ID: c4af5b1259bceea6e979e6fe2435dbee7a5a87c2
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=133092
[Bug 133092] [META] Crash bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 122245] [META] Icon theme issues that need coding

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122245
Bug 122245 depends on bug 158126, which changed state.

Bug 158126 Summary: UI: Scalable buttons for Impress navigation bar
https://bugs.documentfoundation.org/show_bug.cgi?id=158126

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: icon-themes/colibre icon-themes/colibre_dark icon-themes/colibre_dark_svg icon-themes/colibre_svg include/vcl officecfg/registry sd/inc sd/source sd/uiconfig slideshow/

2023-11-22 Thread Irgaliev Amin (via logerrit)
 dev/null |binary
 icon-themes/colibre/sd/res/nextslide_extralarge.png  |binary
 icon-themes/colibre/sd/res/nextslide_large.png   |binary
 icon-themes/colibre/sd/res/prevslide_extralarge.png  |binary
 icon-themes/colibre/sd/res/prevslide_large.png   |binary
 icon-themes/colibre/sd/res/slideshowmenu_extralarge.png  |binary
 icon-themes/colibre/sd/res/slideshowmenu_large.png   |binary
 icon-themes/colibre_dark/sd/res/nextslide_extralarge.png |binary
 icon-themes/colibre_dark/sd/res/nextslide_large.png  |binary
 icon-themes/colibre_dark/sd/res/prevslide_extralarge.png |binary
 icon-themes/colibre_dark/sd/res/prevslide_large.png  |binary
 icon-themes/colibre_dark/sd/res/slideshowmenu_extralarge.png |binary
 icon-themes/colibre_dark/sd/res/slideshowmenu_large.png  |binary
 icon-themes/colibre_dark_svg/sd/res/nextslide_extralarge.svg |   47 +++
 icon-themes/colibre_dark_svg/sd/res/nextslide_large.svg  |   47 +++
 icon-themes/colibre_dark_svg/sd/res/nextslide_mouseover.svg  |1 
 icon-themes/colibre_dark_svg/sd/res/prevslide_extralarge.svg |   47 +++
 icon-themes/colibre_dark_svg/sd/res/prevslide_large.svg  |   47 +++
 icon-themes/colibre_dark_svg/sd/res/prevslide_mouseover.svg  |1 
 icon-themes/colibre_dark_svg/sd/res/slideshowmenu_extralarge.svg |   62 
++
 icon-themes/colibre_dark_svg/sd/res/slideshowmenu_large.svg  |   62 
++
 icon-themes/colibre_dark_svg/sd/res/slideshowmenu_mouseover.svg  |1 
 icon-themes/colibre_svg/sd/res/nextslide_extralarge.svg  |   47 +++
 icon-themes/colibre_svg/sd/res/nextslide_large.svg   |   47 +++
 icon-themes/colibre_svg/sd/res/nextslide_mouseover.svg   |1 
 icon-themes/colibre_svg/sd/res/prevslide_extralarge.svg  |   47 +++
 icon-themes/colibre_svg/sd/res/prevslide_large.svg   |   47 +++
 icon-themes/colibre_svg/sd/res/prevslide_mouseover.svg   |1 
 icon-themes/colibre_svg/sd/res/slideshowmenu_extralarge.svg  |   62 
++
 icon-themes/colibre_svg/sd/res/slideshowmenu_large.svg   |   62 
++
 icon-themes/colibre_svg/sd/res/slideshowmenu_mouseover.svg   |1 
 include/vcl/vclenum.hxx  |9 +
 officecfg/registry/schema/org/openoffice/Office/Impress.xcs  |   30 
 sd/inc/bitmaps.hlst  |   14 +-
 sd/source/ui/dlg/present.cxx |   21 +++
 sd/source/ui/inc/present.hxx |2 
 sd/source/ui/slideshow/slideshowimpl.cxx |   36 +
 sd/uiconfig/simpress/ui/presentationdialog.ui|   39 +-
 slideshow/source/engine/slideshowimpl.cxx|4 
 39 files changed, 768 insertions(+), 17 deletions(-)

New commits:
commit 847001ffbbcaf6d2657a5cce18f6c58151efbd2c
Author: Irgaliev Amin 
AuthorDate: Wed Nov 22 22:43:18 2023 +0400
Commit: Samuel Mehrbrodt 
CommitDate: Wed Nov 22 21:20:09 2023 +0100

tdf#158126 UI: Scalable buttons for Impress navigation bar

On some panels, small icons of navigation bar are not
convenient to use. Currently there are 4 sizes available
for other icons: automatic, small, large and extra large.
It is useful to implement support for scalable buttons in
the Impress navigation bar. This setting can be located in
Slide show -> Slide Show Settings (Display section)

Change-Id: Ief8cc0cbf4eac98ee90bf3e993e4fc44cea0165e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159294
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt 

diff --git a/icon-themes/colibre/sd/res/nextslide_extralarge.png 
b/icon-themes/colibre/sd/res/nextslide_extralarge.png
new file mode 100644
index ..4b86301c93cc
Binary files /dev/null and 
b/icon-themes/colibre/sd/res/nextslide_extralarge.png differ
diff --git a/icon-themes/colibre/sd/res/nextslide_large.png 
b/icon-themes/colibre/sd/res/nextslide_large.png
new file mode 100644
index ..4138f3d8bd8b
Binary files /dev/null and b/icon-themes/colibre/sd/res/nextslide_large.png 
differ
diff --git a/icon-themes/colibre/sd/res/nextslide_mouseover.png 
b/icon-themes/colibre/sd/res/nextslide_mouseover.png
deleted file mode 100644
index 56b105438d58..
Binary files a/icon-themes/colibre/sd/res/nextslide_mouseover.png and /dev/null 
differ
diff --git a/icon-themes/colibre/sd/res/nextslide.png 
b/icon-themes/colibre/sd/res/nextslide_small.png
similarity index 100%
rename from icon-themes/colibre/sd/res/nextslide.png
rename to icon-themes/colibre/sd/res/nextslide_small.png
diff --git a/icon-themes/colibre/sd/res/prevslide_extralarge.png 

[Libreoffice-bugs] [Bug 136372] [META] PPTX shape related issues

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136372
Bug 136372 depends on bug 148000, which changed state.

Bug 148000 Summary: FILEOPEN PPTX: curved text doesn't line break properly and 
becomes too wide
https://bugs.documentfoundation.org/show_bug.cgi?id=148000

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: svx/qa

2023-11-22 Thread Andrea Gelmini (via logerrit)
 svx/qa/unit/svdraw.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3709a8e5f03a6498a6f3ac7c6671d4b08fc46ea3
Author: Andrea Gelmini 
AuthorDate: Wed Nov 22 16:20:01 2023 +0100
Commit: Julien Nabet 
CommitDate: Wed Nov 22 21:05:44 2023 +0100

Fix typo in code

Change-Id: I2e9ba39aeb838b019464363612505edb5a7c6353
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159832
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/svx/qa/unit/svdraw.cxx b/svx/qa/unit/svdraw.cxx
index 2a7b7950c998..b670a59ba6fc 100644
--- a/svx/qa/unit/svdraw.cxx
+++ b/svx/qa/unit/svdraw.cxx
@@ -427,7 +427,7 @@ CPPUNIT_TEST_FIXTURE(SvdrawTest, 
testTdf148000_EOLinCurvedText)
 }
 }
 
-CPPUNIT_TEST_FIXTURE(SvdrawTest, testTdf148000_CurvedTextEidth)
+CPPUNIT_TEST_FIXTURE(SvdrawTest, testTdf148000_CurvedTextWidth)
 {
 std::vector aFilenames
 = { u"tdf148000_CurvedTextWidth.pptx"_ustr, 
u"tdf148000_CurvedTextWidth_New.odp"_ustr,


[Libreoffice-commits] core.git: svx/source

2023-11-22 Thread Andrea Gelmini (via logerrit)
 svx/source/customshapes/EnhancedCustomShapeFontWork.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit f17b89b9e4d1e5c1cf608a2ce1ed218917e3447b
Author: Andrea Gelmini 
AuthorDate: Wed Nov 22 16:16:49 2023 +0100
Commit: Julien Nabet 
CommitDate: Wed Nov 22 21:04:58 2023 +0100

Fix typo

Change-Id: I66cb84da082a7498b1c6a79e989dd94d9f7b1b56
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159828
Tested-by: Julien Nabet 
Reviewed-by: Julien Nabet 

diff --git a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx 
b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
index 2d86e99073c2..2e19aa344ec4 100644
--- a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
+++ b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
@@ -832,8 +832,8 @@ static void FitTextOutlinesToShapeOutlines(const 
tools::PolyPolygon& aOutlines2d
 sal_uInt16 i;
 for (i = 0; i < nPointCount; i++)
 {
-//Normal vector for a point will be calculated 
from its neightbour points
-//except if is in the start/end of the vector
+//Normal vector for a point will be calculated 
from its neighbour points
+//except if it is in the start/end of the vector
 sal_uInt16 nPointIdx1 = i == 0 ? i : i - 1;
 sal_uInt16 nPointIdx2 = i == nPointCount - 1 ? i : 
i + 1;
 


[Libreoffice-commits] core.git: 2 commits - svx/source

2023-11-22 Thread Andrea Gelmini (via logerrit)
 svx/source/customshapes/EnhancedCustomShapeFontWork.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit be262b04ff0e7b85c508975914d77086878155ef
Author: Andrea Gelmini 
AuthorDate: Wed Nov 22 16:15:39 2023 +0100
Commit: Julien Nabet 
CommitDate: Wed Nov 22 21:04:07 2023 +0100

Fix typo

Change-Id: I786d7873f1aa4921bae81cbbecca01959db3866b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159824
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx 
b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
index 4332329994cc..2d86e99073c2 100644
--- a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
+++ b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
@@ -894,7 +894,7 @@ static void FitTextOutlinesToShapeOutlines(const 
tools::PolyPolygon& aOutlines2d
 }
 
 // if the current outline is longer then the text 
to fit in,
-// then we have to divide the bonus space betweeen 
the
+// then we have to divide the bonus space between 
the
 // before-/after- text area.
 // fAdjust means how much space we put before the 
text.
 if (fCurWidth > rParagraph.aBoundRect.GetWidth())
commit c8403d2b83f30a977f1a0eaabeddeeb2d7ac7059
Author: Andrea Gelmini 
AuthorDate: Wed Nov 22 16:18:48 2023 +0100
Commit: Julien Nabet 
CommitDate: Wed Nov 22 21:03:54 2023 +0100

Fix typo

Change-Id: Ic297e251d58cc29c00c6dcc1add85b52bafa190c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159831
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx 
b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
index a51e93588582..4332329994cc 100644
--- a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
+++ b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
@@ -931,7 +931,7 @@ static void FitTextOutlinesToShapeOutlines(const 
tools::PolyPolygon& aOutlines2d
 // if fAdjust<0, then it means, the text 
was longer, as
 // the current outline, so we will skip 
the text scaling, and
 // the text horizontal alignment adjustment
-// so the text will be rendered just as 
long as the cureve is.
+// so the text will be rendered just as 
long as the curve is.
 if (fAdjust >= 0)
 {
 fM1 = (fM1 * fParaRectWidth + fAdjust) 
/ fCurWidth;


[Libreoffice-commits] core.git: svx/source

2023-11-22 Thread Andrea Gelmini (via logerrit)
 svx/source/customshapes/EnhancedCustomShapeFontWork.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 8b6e497a3a9c0d3ce054d3516a2646576a5c8247
Author: Andrea Gelmini 
AuthorDate: Wed Nov 22 16:20:36 2023 +0100
Commit: Julien Nabet 
CommitDate: Wed Nov 22 21:03:10 2023 +0100

Fix typo

Change-Id: I6e6955b18078685ebbe215e496a0b459afb33f27
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159833
Tested-by: Julien Nabet 
Reviewed-by: Julien Nabet 

diff --git a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx 
b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
index ff6903d1f181..a51e93588582 100644
--- a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
+++ b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
@@ -828,7 +828,7 @@ static void FitTextOutlinesToShapeOutlines(const 
tools::PolyPolygon& aOutlines2d
 vCurOutline.reserve(nPointCount);
 vNorm.reserve(nPointCount);
 
-// Calculate Normal vectors, and allocate curve datas
+// Calculate Normal vectors, and allocate curve data
 sal_uInt16 i;
 for (i = 0; i < nPointCount; i++)
 {


[Libreoffice-commits] core.git: svx/source

2023-11-22 Thread Andrea Gelmini (via logerrit)
 svx/source/customshapes/EnhancedCustomShapeFontWork.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d2cfc1cbcb70954951a7bd95a95da26233552733
Author: Andrea Gelmini 
AuthorDate: Wed Nov 22 16:15:08 2023 +0100
Commit: Julien Nabet 
CommitDate: Wed Nov 22 21:02:50 2023 +0100

Fix typo

Change-Id: I034c3b76a8f35700d528b06d7816c0062fe16b86
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159822
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx 
b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
index 8a2984cbdd10..ff6903d1f181 100644
--- a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
+++ b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
@@ -930,7 +930,7 @@ static void FitTextOutlinesToShapeOutlines(const 
tools::PolyPolygon& aOutlines2d
 
 // if fAdjust<0, then it means, the text 
was longer, as
 // the current outline, so we will skip 
the text scaling, and
-// the text horizontal alignment ajustment
+// the text horizontal alignment adjustment
 // so the text will be rendered just as 
long as the cureve is.
 if (fAdjust >= 0)
 {


[Libreoffice-commits] core.git: include/tools

2023-11-22 Thread Andrea Gelmini (via logerrit)
 include/tools/poly.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c6dfe5abe3f4a4361cb8169cf20a9d1cf00ae52a
Author: Andrea Gelmini 
AuthorDate: Wed Nov 22 16:18:25 2023 +0100
Commit: Julien Nabet 
CommitDate: Wed Nov 22 21:02:33 2023 +0100

Fix typo

Change-Id: Id95dc2bc578d98894ab73b1a9b9f7b0e69de3d7d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159830
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/include/tools/poly.hxx b/include/tools/poly.hxx
index 24705f6c9e3c..36aea7a11a6b 100644
--- a/include/tools/poly.hxx
+++ b/include/tools/poly.hxx
@@ -114,7 +114,7 @@ public:
 
 voidSetSize( sal_uInt16 nNewSize );
 sal_uInt16  GetSize() const;
-sal_uInt16  size() const { return GetSize(); } //for vector 
compability
+sal_uInt16  size() const { return GetSize(); } //for vector 
compatibility
 
 voidClear();
 


[Libreoffice-commits] core.git: svx/source

2023-11-22 Thread Andrea Gelmini (via logerrit)
 svx/source/customshapes/EnhancedCustomShapeFontWork.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ac2839458c5f497b907506da07dcd1b451b62372
Author: Andrea Gelmini 
AuthorDate: Wed Nov 22 16:16:24 2023 +0100
Commit: Julien Nabet 
CommitDate: Wed Nov 22 21:02:11 2023 +0100

Fix typo

Change-Id: I3201adc92bec156014b8044371a79a8255c58aa0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159827
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx 
b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
index 733483e4a75e..8a2984cbdd10 100644
--- a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
+++ b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
@@ -903,7 +903,7 @@ static void FitTextOutlinesToShapeOutlines(const 
tools::PolyPolygon& aOutlines2d
 = nAdjust * (fCurWidth - 
rParagraph.aBoundRect.GetWidth()) / 2;
 }
 else
-fAdjust = -1;   // we neet tho shrink the text 
to fit the curve
+fAdjust = -1;   // we need to shrink the text 
to fit the curve
 
 for ( auto& rCharacter : rParagraph.vCharacters )
 {


[Libreoffice-commits] core.git: svx/source

2023-11-22 Thread Andrea Gelmini (via logerrit)
 svx/source/customshapes/EnhancedCustomShapeFontWork.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 99ef89ba4cd2497f3a46448692a71d98c721ae9e
Author: Andrea Gelmini 
AuthorDate: Wed Nov 22 16:15:56 2023 +0100
Commit: Julien Nabet 
CommitDate: Wed Nov 22 21:01:54 2023 +0100

Fix typo

Change-Id: Id19012a207b6df24188e424414e103c7c3dc3d5c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159825
Tested-by: Julien Nabet 
Reviewed-by: Julien Nabet 

diff --git a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx 
b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
index ba7b2890f905..733483e4a75e 100644
--- a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
+++ b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
@@ -784,7 +784,7 @@ static void FitTextOutlinesToShapeOutlines(const 
tools::PolyPolygon& aOutlines2d
 
 if ( !vDistances.empty() )
 {
-// horizontal aligment: how much we have to move text to 
the right.
+// horizontal alignment: how much we have to move text to 
the right.
 int nAdjust = -1;
 switch (eHorzAdjust)
 {


[Libreoffice-commits] core.git: 2 commits - svx/source

2023-11-22 Thread Andrea Gelmini (via logerrit)
 svx/source/customshapes/EnhancedCustomShapeFontWork.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 34636bb5f6c6d2b31515451d42aac841a14bd7aa
Author: Andrea Gelmini 
AuthorDate: Wed Nov 22 16:20:55 2023 +0100
Commit: Julien Nabet 
CommitDate: Wed Nov 22 21:01:31 2023 +0100

Fix typo

Change-Id: Id83a613432117cbf7f20eb9dd0cfa8eaf60b103d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159834
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx 
b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
index d2071da34c8a..ba7b2890f905 100644
--- a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
+++ b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
@@ -863,7 +863,7 @@ static void FitTextOutlinesToShapeOutlines(const 
tools::PolyPolygon& aOutlines2d
 double fAdjust;
 double fCurWidth;
 
-// distance between the original an the current 
curve
+// distance between the original and the current 
curve
 double fCurvesDist = 
rTextArea.aBoundRect.GetHeight() / 2.0
  + rTextArea.aBoundRect.Top()
  - 
rParagraph.aBoundRect.Center().Y();
commit e763acfa9b643595794a9afd2ac196fe0497990e
Author: Andrea Gelmini 
AuthorDate: Wed Nov 22 16:17:17 2023 +0100
Commit: Julien Nabet 
CommitDate: Wed Nov 22 21:01:16 2023 +0100

Fix typo

Change-Id: Id451921ddcefb71f9c46a11e5150fa1b864d4281
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159829
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx 
b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
index 0bbf501835aa..d2071da34c8a 100644
--- a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
+++ b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
@@ -795,7 +795,7 @@ static void FitTextOutlinesToShapeOutlines(const 
tools::PolyPolygon& aOutlines2d
 nAdjust = 1; // 1 half of the possible
 break;
 case SDRTEXTHORZADJUST_BLOCK:
-nAdjust = -1; // don't know what it is, so dont 
even align
+nAdjust = -1; // don't know what it is, so don't 
even align
 break;
 case SDRTEXTHORZADJUST_LEFT:
 nAdjust = 0; // no need to move


[Libreoffice-commits] core.git: svx/source

2023-11-22 Thread Andrea Gelmini (via logerrit)
 svx/source/customshapes/EnhancedCustomShapeFontWork.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c49d688d212fd89daee5563b67b55f687f6d901a
Author: Andrea Gelmini 
AuthorDate: Wed Nov 22 16:16:06 2023 +0100
Commit: Julien Nabet 
CommitDate: Wed Nov 22 21:01:01 2023 +0100

Fix typo

Change-Id: I15170c332c7b9943433fc7113c3b3e8c44c765cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159826
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx 
b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
index 47d2c0830e3f..0bbf501835aa 100644
--- a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
+++ b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
@@ -867,7 +867,7 @@ static void FitTextOutlinesToShapeOutlines(const 
tools::PolyPolygon& aOutlines2d
 double fCurvesDist = 
rTextArea.aBoundRect.GetHeight() / 2.0
  + rTextArea.aBoundRect.Top()
  - 
rParagraph.aBoundRect.Center().Y();
-// verical alignment adjust
+// vertical alignment adjust
 fCurvesDist -= rTextArea.nHAlignMove;
 
 for (i = 0; i < nPointCount; i++)


[Libreoffice-commits] core.git: svx/source

2023-11-22 Thread Andrea Gelmini (via logerrit)
 svx/source/customshapes/EnhancedCustomShapeFontWork.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 84d8a1caf124a25fb081562e4db32acf19e0f301
Author: Andrea Gelmini 
AuthorDate: Wed Nov 22 16:15:24 2023 +0100
Commit: Julien Nabet 
CommitDate: Wed Nov 22 21:00:37 2023 +0100

Fix typo

Change-Id: I76ea5af4ec21ca55a2b88f48e6d476feec065349
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159823
Tested-by: Julien Nabet 
Reviewed-by: Julien Nabet 

diff --git a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx 
b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
index 8f2896109e9e..47d2c0830e3f 100644
--- a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
+++ b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
@@ -939,7 +939,7 @@ static void FitTextOutlinesToShapeOutlines(const 
tools::PolyPolygon& aOutlines2d
 }
 // 0 <= fM1,fM2 <= 1 should be true, but 
rounding errors can
 // make a small mistake.
-// make sure they are >0 becuase 
GetPoint() need that
+// make sure they are >0 because 
GetPoint() need that
 if (fM1 < 0) fM1 = 0;
 if (fM2 < 0) fM2 = 0;
 


[Libreoffice-bugs] [Bug 158325] New: Option to start row at 0

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158325

Bug ID: 158325
   Summary: Option to start row at 0
   Product: LibreOffice
   Version: 7.6.2.1 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: simact...@yahoo.ca

Description:
Please add ability to start row at 0. I found convoluted instructions on how to
do this in Excel but not for Calc. I understand why people or businesses may
not want to start at 0 because most already start at 1. But for home users who
are not sharing with others it would be good to be able to see how many rows
there are at a glance without having to -1 when you see the bottom. I am not
talk about using ROW() but just dragging down and visually seeing. It is more
convenient to have the rows match the content. Headers should be at 0. Thank
you

Actual Results:
There is no 0 row

Expected Results:
have a 0 row for headers


Reproducible: Always


User Profile Reset: No

Additional Info:
na

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158198] My macro changes the bookmark text and the bookmark disappears

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158198

Michael Stahl (allotropia)  changed:

   What|Removed |Added

  Component|BASIC   |Writer
 CC||michael.st...@allotropia.de
   ||, mikekagan...@hotmail.com

--- Comment #7 from Michael Stahl (allotropia)  ---
thinking the basic problem here is that the API only has this "setString"
method, but no way to indicate whether the intent is to *delete* or to
*replace* text.

these are different operations: deleting means that things like objects
anchored in the deletion range and bookmarks should be deleted too, while
replacing means that the current text should be deleted but the anchored
objects should remain.

so the best idea i had is that setString("") would be interpreted as *delete*
and any other setString call as *replace*.

the behavior when selecting an entire paragraph was changed in commit
baf8d2c1c16cb3bdc4edad2560f95fea807a034f because in this situation it was
actually quite difficult to get rid of the bookmark if the user does want to
delete it, as no selection that is larger than the bookmark is possible inside
the paragraph (and there may be no preceding or following paragraph).

so i'm going to call the new behavior a feature not a bug, but of course i'm
biased...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 109239] [META] CSV / TSV / Text Import and export / Text to Columns dialogs bugs and enhancements

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=109239

ady  changed:

   What|Removed |Added

 Depends on||158297


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=158297
[Bug 158297] Pasting unformatted text over existing values - an empty line will
not handle the last column value (STR comment 8)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157698] [META] Unify lockdown UX in the Options dialog

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157698
Bug 157698 depends on bug 158147, which changed state.

Bug 158147 Summary: Unify lockdown behavior of Options dialog page Math - 
Settings
https://bugs.documentfoundation.org/show_bug.cgi?id=158147

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: starmath/inc starmath/source starmath/uiconfig

2023-11-22 Thread Balazs Varga (via logerrit)
 starmath/inc/dialog.hxx |9 
 starmath/source/dialog.cxx  |   53 +++
 starmath/uiconfig/smath/ui/smathsettings.ui |  455 
 3 files changed, 393 insertions(+), 124 deletions(-)

New commits:
commit 278c5d22928a05cbfe887e38bc93a5051d0f59d4
Author: Balazs Varga 
AuthorDate: Wed Nov 22 14:21:00 2023 +0100
Commit: Balazs Varga 
CommitDate: Wed Nov 22 19:18:23 2023 +0100

tdf#158147 - UI: Part 38 - Unify lockdown behavior of Options dialog

for Math - Settings Page.

Change-Id: I05170a6c7edb6160e0e7804fa04325d329499854
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159819
Tested-by: Jenkins
Reviewed-by: Balazs Varga 

diff --git a/starmath/inc/dialog.hxx b/starmath/inc/dialog.hxx
index 66db01d295f4..3b4f80b8e61c 100644
--- a/starmath/inc/dialog.hxx
+++ b/starmath/inc/dialog.hxx
@@ -40,17 +40,26 @@ void SetFontStyle(std::u16string_view rStyleName, vcl::Font 
);
 class SmPrintOptionsTabPage final : public SfxTabPage
 {
 std::unique_ptr  m_xTitle;
+std::unique_ptr  m_xTitleImg;
 std::unique_ptr  m_xText;
+std::unique_ptr  m_xTextImg;
 std::unique_ptr  m_xFrame;
+std::unique_ptr  m_xFrameImg;
 std::unique_ptr  m_xSizeNormal;
 std::unique_ptr  m_xSizeScaled;
 std::unique_ptr  m_xSizeZoomed;
+std::unique_ptr  m_xLockPrintImg;
 std::unique_ptr m_xZoom;
 std::unique_ptr  m_xEnableInlineEdit;
+std::unique_ptr  m_xEnableInlineEditImg;
 std::unique_ptr  m_xNoRightSpaces;
+std::unique_ptr  m_xNoRightSpacesImg;
 std::unique_ptr  m_xSaveOnlyUsedSymbols;
+std::unique_ptr  m_xSaveOnlyUsedSymbolsImg;
 std::unique_ptr  m_xAutoCloseBrackets;
+std::unique_ptr  m_xAutoCloseBracketsImg;
 std::unique_ptr m_xSmZoom;
+std::unique_ptr m_xSmZoomImg;
 
 DECL_LINK(SizeButtonClickHdl, weld::Toggleable&, void);
 
diff --git a/starmath/source/dialog.cxx b/starmath/source/dialog.cxx
index f96f43cfebba..1ad8376e5a7f 100644
--- a/starmath/source/dialog.cxx
+++ b/starmath/source/dialog.cxx
@@ -42,6 +42,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -179,17 +180,26 @@ IMPL_LINK_NOARG(SmPrintOptionsTabPage, 
SizeButtonClickHdl, weld::Toggleable&, vo
 SmPrintOptionsTabPage::SmPrintOptionsTabPage(weld::Container* pPage, 
weld::DialogController* pController, const SfxItemSet& rOptions)
 : SfxTabPage(pPage, pController, "modules/smath/ui/smathsettings.ui", 
"SmathSettings", )
 , m_xTitle(m_xBuilder->weld_check_button("title"))
+, m_xTitleImg(m_xBuilder->weld_widget("locktitle"))
 , m_xText(m_xBuilder->weld_check_button("text"))
+, m_xTextImg(m_xBuilder->weld_widget("locktext"))
 , m_xFrame(m_xBuilder->weld_check_button("frame"))
+, m_xFrameImg(m_xBuilder->weld_widget("lockframe"))
 , m_xSizeNormal(m_xBuilder->weld_radio_button("sizenormal"))
 , m_xSizeScaled(m_xBuilder->weld_radio_button("sizescaled"))
 , m_xSizeZoomed(m_xBuilder->weld_radio_button("sizezoomed"))
+, m_xLockPrintImg(m_xBuilder->weld_widget("lockprintformat"))
 , m_xZoom(m_xBuilder->weld_metric_spin_button("zoom", FieldUnit::PERCENT))
 , m_xEnableInlineEdit(m_xBuilder->weld_check_button("enableinlineedit"))
+, m_xEnableInlineEditImg(m_xBuilder->weld_widget("lockenableinlineedit"))
 , m_xNoRightSpaces(m_xBuilder->weld_check_button("norightspaces"))
+, m_xNoRightSpacesImg(m_xBuilder->weld_widget("locknorightspaces"))
 , 
m_xSaveOnlyUsedSymbols(m_xBuilder->weld_check_button("saveonlyusedsymbols"))
+, 
m_xSaveOnlyUsedSymbolsImg(m_xBuilder->weld_widget("locksaveonlyusedsymbols"))
 , m_xAutoCloseBrackets(m_xBuilder->weld_check_button("autoclosebrackets"))
+, m_xAutoCloseBracketsImg(m_xBuilder->weld_widget("lockautoclosebrackets"))
 , m_xSmZoom(m_xBuilder->weld_metric_spin_button("smzoom", 
FieldUnit::PERCENT))
+, m_xSmZoomImg(m_xBuilder->weld_widget("locksmzoom"))
 {
 m_xSizeNormal->connect_toggled(LINK(this, SmPrintOptionsTabPage, 
SizeButtonClickHdl));
 m_xSizeScaled->connect_toggled(LINK(this, SmPrintOptionsTabPage, 
SizeButtonClickHdl));
@@ -271,21 +281,58 @@ void SmPrintOptionsTabPage::Reset(const SfxItemSet* rSet)
 m_xSizeNormal->set_active(ePrintSize == PRINT_SIZE_NORMAL);
 m_xSizeScaled->set_active(ePrintSize == PRINT_SIZE_SCALED);
 m_xSizeZoomed->set_active(ePrintSize == PRINT_SIZE_ZOOMED);
+bool bReadOnly = officecfg::Office::Math::Print::Size::isReadOnly();
+if (bReadOnly)
+{
+m_xSizeNormal->set_sensitive(false);
+m_xSizeScaled->set_sensitive(false);
+m_xSizeZoomed->set_sensitive(false);
+m_xLockPrintImg->set_visible(true);
+}
 
-m_xZoom->set_sensitive(m_xSizeZoomed->get_active());
-
+bReadOnly = officecfg::Office::Math::Print::ZoomFactor::isReadOnly();
 m_xZoom->set_value(rSet->Get(SID_PRINTZOOM).GetValue(), 

[Libreoffice-bugs] [Bug 158222] Unify lockdown behavior of Options dialog page Impress - General

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158222

Balázs Varga (allotropia)  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |balazs.varga...@gmail.com
   |desktop.org |
 Status|UNCONFIRMED |ASSIGNED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146076] [META] Find & Replace Regular Expressions

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146076
Bug 146076 depends on bug 138931, which changed state.

Bug 138931 Summary: FIND & REPLACE DIALOG: \\n in the regex Replace is same 
like \n (escaping not working)
https://bugs.documentfoundation.org/show_bug.cgi?id=138931

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|DUPLICATE   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 38261] Better Find with regular expressions

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=38261
Bug 38261 depends on bug 138931, which changed state.

Bug 138931 Summary: FIND & REPLACE DIALOG: \\n in the regex Replace is same 
like \n (escaping not working)
https://bugs.documentfoundation.org/show_bug.cgi?id=138931

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|DUPLICATE   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138931] FIND & REPLACE DIALOG: \\n in the regex Replace is same like \n (escaping not working)

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138931

Buovjaga  changed:

   What|Removed |Added

 Resolution|DUPLICATE   |---
 Status|RESOLVED|NEW
Summary|FIND & REPLACE DIALOG: \\n  |FIND & REPLACE DIALOG: \\n
   |in the regex Replace is |in the regex Replace is
   |same like \n|same like \n (escaping not
   ||working)
 CC||ilmari.lauhakangas@libreoff
   ||ice.org

--- Comment #5 from Buovjaga  ---
(In reply to kdub from comment #4)
> 
> *** This bug has been marked as a duplicate of bug 128999 ***

bug 128999 is about \n string being present in the document while this report
is about escaping \n in the replace field.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: compilerplugins/clang sw/source

2023-11-22 Thread Noel Grandin (via logerrit)
 compilerplugins/clang/fieldcast.results |3 ---
 sw/source/uibase/dochdl/swdtflvr.cxx|6 +-
 sw/source/uibase/inc/swdtflvr.hxx   |4 +++-
 3 files changed, 4 insertions(+), 9 deletions(-)

New commits:
commit 68a2e50726e2f16354ff45d6768790e076989cb6
Author: Noel Grandin 
AuthorDate: Wed Nov 22 11:41:26 2023 +0200
Commit: Noel Grandin 
CommitDate: Wed Nov 22 18:38:45 2023 +0100

loplugin:fieldcast in SwTransferable

Change-Id: I8e9f157a399f1b305d2e6b6e63da837f0090fd8b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159814
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/fieldcast.results 
b/compilerplugins/clang/fieldcast.results
index e65cc5123250..0bdabb345340 100644
--- a/compilerplugins/clang/fieldcast.results
+++ b/compilerplugins/clang/fieldcast.results
@@ -565,9 +565,6 @@ sw/source/ui/dialog/swdlgfact.hxx:562
 sw/source/uibase/inc/fldmgr.hxx:103
 SwFieldMgr m_pCurField SwField *
 SwPageNumberField
-sw/source/uibase/inc/swdtflvr.hxx:81
-SwTransferable m_xDdeLink tools::SvRef
-(anonymous namespace)::SwTransferDdeLink
 sw/source/uibase/inc/swuiccoll.hxx:35
 SwCondCollPage m_pFormat SwFormat *
 SwConditionTextFormatColl
diff --git a/sw/source/uibase/dochdl/swdtflvr.cxx 
b/sw/source/uibase/dochdl/swdtflvr.cxx
index 91eb38e0f45c..cb96c08527c6 100644
--- a/sw/source/uibase/dochdl/swdtflvr.cxx
+++ b/sw/source/uibase/dochdl/swdtflvr.cxx
@@ -173,8 +173,6 @@ void collectUIInformation(const OUString& rAction, const 
OUString& aParameters)
 
 }
 
-namespace {
-
 class SwTransferDdeLink : public ::sfx2::SvBaseLink
 {
 OUString m_sName;
@@ -204,8 +202,6 @@ public:
 void Disconnect( bool bRemoveDataAdvise );
 };
 
-}
-
 /// Tracks the boundaries of pasted content and notifies listeners.
 class SwPasteContext
 {
@@ -393,7 +389,7 @@ void SwTransferable::DisconnectDDE()
 {
 if( m_xDdeLink.is() )
 {
-static_cast( m_xDdeLink.get() )->Disconnect( true 
);
+m_xDdeLink->Disconnect( true );
 m_xDdeLink.clear();
 }
 }
diff --git a/sw/source/uibase/inc/swdtflvr.hxx 
b/sw/source/uibase/inc/swdtflvr.hxx
index e7e1849a0dc9..6234bd37294b 100644
--- a/sw/source/uibase/inc/swdtflvr.hxx
+++ b/sw/source/uibase/inc/swdtflvr.hxx
@@ -73,12 +73,14 @@ enum class PasteTableType
 PASTE_TABLE// paste table as nested table
 };
 
+class SwTransferDdeLink;
+
 class SW_DLLPUBLIC SwTransferable final : public TransferableHelper
 {
 friend class SwView_Impl;
 SfxObjectShellLock  m_aDocShellRef;
 TransferableObjectDescriptorm_aObjDesc;
-tools::SvRef  m_xDdeLink;
+tools::SvRef  m_xDdeLink;
 
 SwWrtShell  *m_pWrtShell;
 /* #96392# Added pCreatorView to distinguish SwFrameShell from


[Libreoffice-bugs] [Bug 155812] Open file with many page numbers spend too much time

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155812

--- Comment #16 from eric li  ---
(In reply to Michael Weghorn from comment #13)
> (In reply to eric li from comment #12)
> > I went through the source code,,looks like every time Libreoffice would
> > loaded and rendered all the pages of the file ,,that could be the major
> > issue of this..How can we change it?
> 
> Are all pages actually rendered or is the loading of the document (parsing
> of the XML content etc.) what takes so much time?
> IIUC, the general idea is to only render what's necessary, so if rendering
> for all pages is done, maybe it's possible to only request rendering of
> (approximately) the part that's visible?

Hi,Michael I did more test

Log.i(LOGTAG, "> before load");
mDocument = mOffice.documentLoad(
(new
File(fileToBeEncoded.getParent(),encodedFileName)).getPath()
);
Log.i(LOGTAG, "> after load");

what I found is this completedly libreoffice C code issue,,
below is the results
2023-11-23 01:17:54.536 29487-29735 LOKitTileProvider   com.test.paper 
> before load

2023-11-23 01:18:23.315 29487-29735 LOKitTileProvider   com.test.paper 
I  > after load

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 35847] [UI] Wrong page style name in status bar after page preview

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=35847

--- Comment #18 from Laurent Balland  ---
Confirmed with Version: 7.6.3.1 (X86_64) / LibreOffice Community
Build ID: c4af5b1259bceea6e979e6fe2435dbee7a5a87c2
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: fr-FR (fr_FR); UI: fr-FR
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158235] Spell check not working in LibreOffice Writer

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158235

Buovjaga  changed:

   What|Removed |Added

 CC||ilmari.lauhakangas@libreoff
   ||ice.org

--- Comment #2 from Buovjaga  ---
bnp2012: just to check, did you have the text language set to the appropriate
one?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158301] Calc Function Wizard: Make searching in descriptions optional, not forced

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158301

--- Comment #4 from ady  ---
(In reply to Heiko Tietze from comment #3)
> If it's for the advanced users, how about wildcards to switch from full to
> name-only search? "lar*" would return only LARGE() "*lar*" DOLLAR, DOLLARDE,
> DOLLARFR, LARGE (and nothing else).
> 
> I hesitate to agree with too many controls in the UI.

That sentence shows that you might only use Calc sporadically at best; and I
don't mean as part of the UX Team but as an actual spreadsheet "builder/user"
focused on real use of Calc. If you were building formulas frequently,
especially with the FW, you would have noticed the difference in user's
performance already.

So your proposal would be to be less efficient for users that were more
efficient before the change? No, I have to disagree. The process should improve
efficiency while users gain experience.

I repeat; the original proposal was to _optionally_ include the functions'
descriptions in the search. The current result of tdf#146781 makes the process
less-efficient while users are supposed to improve in their experience. That's
not really an improvement, especially in the long run for users.

One thing is to make Calc easier to use for newbies; another one is to make it
harder for experienced users. That is not an acceptable cost for Calc users.
Please don't push experienced users to leave Calc for other spreadsheet tools.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158324] New: FILEOPEN DOCX Floating table with Repeat heading property imported with repeating headers

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158324

Bug ID: 158324
   Summary: FILEOPEN DOCX Floating table with Repeat heading
property imported with repeating headers
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kelem...@ubuntu.com
Blocks: 139532

Created attachment 190975
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190975=edit
Example file from Word 2016

Attached document contains a floating table with the first row set as "Repeat
as header row at the top of each page".
This property is imported correctly and the first row is repeated at the top of
the second page, but Word actually does not repeat it.

1. Open attached document
-> Notice the first row is repeated on the top of the second page.

In Word, this is not the case.

Below the first table is the same table as a non-floating one with the same
"Repeat as header row at the top of each page" set. This works as expected in
both.


Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 5fe2bf914c251009ec4709fa8fdc45c3b53f676b
CPU threads: 15; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: threaded

and the same in 7.0, 6.0, 5.0 etc, not a recent regression.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=139532
[Bug 139532] [META] DOCX Floating table related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139532] [META] DOCX Floating table related issues

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139532

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Depends on||158324


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=158324
[Bug 158324] FILEOPEN DOCX Floating table with Repeat heading property imported
with repeating headers
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158324] FILEOPEN DOCX Floating table with Repeat heading property imported with repeating headers

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158324

--- Comment #1 from Gabor Kelemen (allotropia)  ---
Created attachment 190976
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190976=edit
Screenshot of the document in Word 2016 and Writer master

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158292] Header background (area) image in ODT not saved into DOCX

2023-11-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158292

--- Comment #6 from Justin L  ---
I'm sure it will not be easy to translate "image as background" into "properly
sized/tiled anchor-image" during export.

-- 
You are receiving this mail because:
You are the assignee for the bug.

  1   2   3   4   >