[Libreoffice-bugs] [Bug 156662] Always using direct connection to api.languagetool.org

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=156662

Mike Kaganski  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #6 from Mike Kaganski  ---
(In reply to Stéphane Guillou (stragu) from comment #4)
> Sounds similar to bug 158093.

But not using proxy is different, and a real bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - sd/source

[Caolán McNamara (via logerrit)]

 sd/source/ui/app/sdmod1.cxx |   29 ++---
 1 file changed, 18 insertions(+), 11 deletions(-)

New commits:
commit 569fa7f755718a06f23d25b2132bf0400cec7a0f
Author: Caolán McNamara 
AuthorDate: Wed Nov 22 21:14:41 2023 +
Commit: Miklos Vajna 
CommitDate: Fri Nov 24 08:52:35 2023 +0100

reuse AllowedLinkProtocolFromDocument in impress/draw

Change-Id: I73ca4f087946a45dbf92d69a0dc1e769de9b5690
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159843
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
(cherry picked from commit f0942eed2eb328b04856f20613f5226d66b66a20)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159759
Reviewed-by: Michael Stahl 
Signed-off-by: Xisco Fauli 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159884
Reviewed-by: Miklos Vajna 

diff --git a/sd/source/ui/app/sdmod1.cxx b/sd/source/ui/app/sdmod1.cxx
index 573ee853069b..b22feb2d1f21 100644
--- a/sd/source/ui/app/sdmod1.cxx
+++ b/sd/source/ui/app/sdmod1.cxx
@@ -33,6 +33,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 #include 
@@ -192,26 +193,32 @@ void SdModule::Execute(SfxRequest& rReq)
 {
 bool bIntercept = false;
 ::sd::DrawDocShell* pDocShell = dynamic_cast< ::sd::DrawDocShell 
*>( SfxObjectShell::Current() );
-if (pDocShell)
+::sd::ViewShell* pViewShell = pDocShell ? 
pDocShell->GetViewShell() : nullptr;
+if (pViewShell)
 {
-::sd::ViewShell* pViewShell = pDocShell->GetViewShell();
-if (pViewShell)
+if( sd::SlideShow::IsRunning( pViewShell->GetViewShellBase() ) 
)
 {
-if( sd::SlideShow::IsRunning( 
pViewShell->GetViewShellBase() ) )
+// Prevent documents from opening while the slide
+// show is running, except when this request comes
+// from a shape interaction.
+if (rReq.GetArgs() == nullptr)
 {
-// Prevent documents from opening while the slide
-// show is running, except when this request comes
-// from a shape interaction.
-if (rReq.GetArgs() == nullptr)
-{
-bIntercept = true;
-}
+bIntercept = true;
 }
 }
 }
 
 if (!bIntercept)
 {
+if (const SfxStringItem* pURLItem = 
rReq.GetArg(SID_FILE_NAME))
+{
+if (!pViewShell || 
!SfxObjectShell::AllowedLinkProtocolFromDocument(pURLItem->GetValue(),
+   
 pViewShell->GetObjectShell(),
+   
 pViewShell->GetFrameWeld()))
+{
+return;
+}
+}
 SfxGetpApp()->ExecuteSlot(rReq, SfxGetpApp()->GetInterface());
 }
 else

[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - 2 commits - dbaccess/source include/sfx2 sc/source sfx2/source sw/source

[Caolán McNamara (via logerrit)]

 dbaccess/source/core/dataaccess/ModelImpl.cxx |3 +-
 include/sfx2/docmacromode.hxx |4 ++
 include/sfx2/objsh.hxx|6 
 sc/source/core/data/global.cxx|5 ++-
 sfx2/source/doc/docmacromode.cxx  |8 -
 sfx2/source/doc/objmisc.cxx   |   35 +++
 sfx2/source/doc/objxtor.cxx   |1 
 sfx2/source/inc/objshimp.hxx  |3 +-
 sw/source/uibase/shells/drwtxtex.cxx  |8 +
 sw/source/uibase/wrtsh/wrtsh2.cxx |   38 --
 10 files changed, 84 insertions(+), 27 deletions(-)

New commits:
commit 6d29ee15039a567ad5f70a3e51289fea93c1f64e
Author: Caolán McNamara 
AuthorDate: Wed Nov 15 11:39:24 2023 +
Commit: Miklos Vajna 
CommitDate: Fri Nov 24 08:52:21 2023 +0100

reuse AllowedLinkProtocolFromDocument in writer

reorg calc hyperlink check to reuse elsewhere

Change-Id: I20ae3c5df15502c3a0a366fb4a2924c06ffac3d0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159487
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
(cherry picked from commit e6a7537762e19fde446441edd10d301f9b37ce75)

reuse AllowedLinkProtocolFromDocument in writer

Change-Id: Iacf5e313fc6ca5f7d69ca6986a036f0e1ab1f2a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159488
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 
(cherry picked from commit 32535dfa82200b54296838b52285c054fbe5e51d)

combine these hyperlink dispatchers into one call

Change-Id: Icb7822e811013de648ccf2fbb23a5f0be9e29bb0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159489
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 
(cherry picked from commit 0df175ccc6ea542bc5801f631ff72bed187042eb)

we can have just one LoadURL for writer

Change-Id: Ia0162ee1c275292fcf200bad4662e4c2c6b7b972
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159557
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
(cherry picked from commit 521ca9cf6acbae96cf95d9740859c9682212013d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159858
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 
(cherry picked from commit e32b8601dbd63cf01497889601d6c9c1241106d6)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159883

diff --git a/include/sfx2/objsh.hxx b/include/sfx2/objsh.hxx
index fde0dba3d7c9..79f22c978dcb 100644
--- a/include/sfx2/objsh.hxx
+++ b/include/sfx2/objsh.hxx
@@ -200,6 +200,9 @@ private:
 
 SAL_DLLPRIVATE bool SaveTo_Impl(SfxMedium , const SfxItemSet* pSet 
);
 
+// true if the document had macros (or similar) on load to trigger warning 
user
+SAL_DLLPRIVATE bool  GetHadCheckedMacrosOnLoad() const;
+
 protected:
 SfxObjectShell(SfxObjectCreateMode);
 SfxObjectShell(SfxModelFlags);// see 
sfxmodelfactory.hxx
@@ -427,8 +430,8 @@ public:
 voidSetMacroCallsSeenWhileLoading();
 boolGetMacroCallsSeenWhileLoading() const;
 
-// true if the document had macros (or similar) on load to trigger warning 
user
-boolGetHadCheckedMacrosOnLoad() const;
+// true if this type of link, from a document, is allowed by the user to 
be passed to uno:OpenDoc
+static bool AllowedLinkProtocolFromDocument(const 
OUString& rUrl, SfxObjectShell* pObjShell, weld::Window* pDialogParent);
 
 const css::uno::Sequence< css::beans::PropertyValue >& 
GetModifyPasswordInfo() const;
 boolSetModifyPasswordInfo( const 
css::uno::Sequence< css::beans::PropertyValue >& aInfo );
diff --git a/sc/source/core/data/global.cxx b/sc/source/core/data/global.cxx
index 92caea1ea459..27c5a51a46c1 100644
--- a/sc/source/core/data/global.cxx
+++ b/sc/source/core/data/global.cxx
@@ -29,9 +29,7 @@
 #include 
 #include 
 #include 
-#include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -856,34 +854,8 @@ void ScGlobal::OpenURL(const OUString& rURL, const 
OUString& rTarget, bool bIgno
 aUrlName = aNewUrlName;
 }
 
-if (INetURLObject(aUrlName).IsExoticProtocol())
-{
-// Default to ignoring exotic protocols
-bool bAllow = false;
-if (pObjShell)
-{
-// If the document had macros when loaded then follow the allowed 
macro-mode
-if (pObjShell->GetHadCheckedMacrosOnLoad())
-bAllow = pObjShell->AdjustMacroMode();
-else // otherwise ask the user, defaulting to cancel
-{
-assert(pFrame && "if we have pObjShell we have pFrame");
-//Reuse URITools::onOpenURI warning string
-std::unique_ptr 
xQueryBox(Application::CreateMessageDialog(pFrame->GetFrameWeld(),
- 

[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - sw/source tools/source xmloff/source

[Caolán McNamara (via logerrit)]

 sw/source/filter/html/htmlplug.cxx |2 +-
 sw/source/filter/xml/xmltexti.cxx  |2 +-
 tools/source/fsys/urlobj.cxx   |3 ++-
 xmloff/source/draw/ximpshap.cxx|2 +-
 4 files changed, 5 insertions(+), 4 deletions(-)

New commits:
commit 9198322d9b4ed87e0e176fbfc712751a5f9b886f
Author: Caolán McNamara 
AuthorDate: Sat Nov 4 19:57:51 2023 +
Commit: Miklos Vajna 
CommitDate: Fri Nov 24 08:51:07 2023 +0100

warn about exotic protocols as well

Change-Id: I50dcf4f36cd20d75f5ad3876353143268740a50f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151834
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
(cherry picked from commit 1305f70cff8a81a58a5a6d9c96c5bb032005389e)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159034
Reviewed-by: Eike Rathke 
Signed-off-by: Xisco Fauli 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159881
Reviewed-by: Miklos Vajna 

diff --git a/sw/source/filter/html/htmlplug.cxx 
b/sw/source/filter/html/htmlplug.cxx
index 1aec184d8a6c..1c1f5f49f13e 100644
--- a/sw/source/filter/html/htmlplug.cxx
+++ b/sw/source/filter/html/htmlplug.cxx
@@ -1121,7 +1121,7 @@ void SwHTMLParser::InsertFloatingFrame()
 
 OUString sHRef = aFrameDesc.GetURL().GetMainURL( 
INetURLObject::DecodeMechanism::NONE );
 
-if (INetURLObject(sHRef).GetProtocol() == INetProtocol::Macro)
+if (INetURLObject(sHRef).IsExoticProtocol())
 NotifyMacroEventRead();
 
 xSet->setPropertyValue("FrameURL", uno::Any( sHRef ) );
diff --git a/sw/source/filter/xml/xmltexti.cxx 
b/sw/source/filter/xml/xmltexti.cxx
index 7ec4616f76dd..4bbed6bb8ff8 100644
--- a/sw/source/filter/xml/xmltexti.cxx
+++ b/sw/source/filter/xml/xmltexti.cxx
@@ -826,7 +826,7 @@ uno::Reference< XPropertySet > 
SwXMLTextImportHelper::createAndInsertFloatingFra
 OUString sHRef = URIHelper::SmartRel2Abs(
 INetURLObject( GetXMLImport().GetBaseURL() ), 
rHRef );
 
-if (INetURLObject(sHRef).GetProtocol() == INetProtocol::Macro)
+if (INetURLObject(sHRef).IsExoticProtocol())
 GetXMLImport().NotifyMacroEventRead();
 
 xSet->setPropertyValue("FrameURL",
diff --git a/tools/source/fsys/urlobj.cxx b/tools/source/fsys/urlobj.cxx
index 2a9f7bc3d7dc..36a8af31a0fb 100644
--- a/tools/source/fsys/urlobj.cxx
+++ b/tools/source/fsys/urlobj.cxx
@@ -4834,7 +4834,8 @@ bool INetURLObject::IsExoticProtocol() const
 return m_eScheme == INetProtocol::Slot ||
m_eScheme == INetProtocol::Macro ||
m_eScheme == INetProtocol::Uno ||
-   isSchemeEqualTo(u"vnd.sun.star.script");
+   isSchemeEqualTo(u"vnd.sun.star.script") ||
+   isSchemeEqualTo(u"service");
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/xmloff/source/draw/ximpshap.cxx b/xmloff/source/draw/ximpshap.cxx
index 113f3a3ffc2a..263b4b937608 100644
--- a/xmloff/source/draw/ximpshap.cxx
+++ b/xmloff/source/draw/ximpshap.cxx
@@ -3177,7 +3177,7 @@ void SdXMLFloatingFrameShapeContext::startFastElement 
(sal_Int32 /*nElement*/,
 
 if( !maHref.isEmpty() )
 {
-if (INetURLObject(maHref).GetProtocol() == INetProtocol::Macro)
+if (INetURLObject(maHref).IsExoticProtocol())
 GetImport().NotifyMacroEventRead();
 
 xProps->setPropertyValue("FrameURL", Any(maHref) );

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - sd/source

[Caolán McNamara (via logerrit)]

 sd/source/ui/app/sdmod1.cxx |   29 ++---
 1 file changed, 18 insertions(+), 11 deletions(-)

New commits:
commit bfa12f692e0738a0ff10a1d65f91376bb251b774
Author: Caolán McNamara 
AuthorDate: Wed Nov 22 21:14:41 2023 +
Commit: Miklos Vajna 
CommitDate: Fri Nov 24 08:50:18 2023 +0100

reuse AllowedLinkProtocolFromDocument in impress/draw

Change-Id: I73ca4f087946a45dbf92d69a0dc1e769de9b5690
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159843
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
(cherry picked from commit f0942eed2eb328b04856f20613f5226d66b66a20)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159759
Reviewed-by: Michael Stahl 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159859
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 
(cherry picked from commit 402fd49351123c476650c7280471d05d4de85d5d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159880

diff --git a/sd/source/ui/app/sdmod1.cxx b/sd/source/ui/app/sdmod1.cxx
index f3ec8b3df514..aec7a3dcb2d8 100644
--- a/sd/source/ui/app/sdmod1.cxx
+++ b/sd/source/ui/app/sdmod1.cxx
@@ -33,6 +33,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 #include 
@@ -193,26 +194,32 @@ void SdModule::Execute(SfxRequest& rReq)
 {
 bool bIntercept = false;
 ::sd::DrawDocShell* pDocShell = dynamic_cast< ::sd::DrawDocShell 
*>( SfxObjectShell::Current() );
-if (pDocShell)
+::sd::ViewShell* pViewShell = pDocShell ? 
pDocShell->GetViewShell() : nullptr;
+if (pViewShell)
 {
-::sd::ViewShell* pViewShell = pDocShell->GetViewShell();
-if (pViewShell)
+if( sd::SlideShow::IsRunning( pViewShell->GetViewShellBase() ) 
)
 {
-if( sd::SlideShow::IsRunning( 
pViewShell->GetViewShellBase() ) )
+// Prevent documents from opening while the slide
+// show is running, except when this request comes
+// from a shape interaction.
+if (rReq.GetArgs() == nullptr)
 {
-// Prevent documents from opening while the slide
-// show is running, except when this request comes
-// from a shape interaction.
-if (rReq.GetArgs() == nullptr)
-{
-bIntercept = true;
-}
+bIntercept = true;
 }
 }
 }
 
 if (!bIntercept)
 {
+if (const SfxStringItem* pURLItem = 
rReq.GetArg(SID_FILE_NAME))
+{
+if (!pViewShell || 
!SfxObjectShell::AllowedLinkProtocolFromDocument(pURLItem->GetValue(),
+   
 pViewShell->GetObjectShell(),
+   
 pViewShell->GetFrameWeld()))
+{
+return;
+}
+}
 SfxGetpApp()->ExecuteSlot(rReq, SfxGetpApp()->GetInterface());
 }
 else

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - include/sfx2 sc/source sfx2/source sw/source

[Caolán McNamara (via logerrit)]

 include/sfx2/objsh.hxx   |7 --
 sc/source/core/data/global.cxx   |   32 +
 sfx2/source/doc/objmisc.cxx  |   27 
 sw/source/uibase/shells/drwtxtex.cxx |8 +--
 sw/source/uibase/wrtsh/wrtsh2.cxx|   38 ++-
 5 files changed, 60 insertions(+), 52 deletions(-)

New commits:
commit e969ea39b13a9fbebfbe1e3b989ec7aa2623a4ea
Author: Caolán McNamara 
AuthorDate: Wed Nov 15 11:39:24 2023 +
Commit: Miklos Vajna 
CommitDate: Fri Nov 24 08:49:56 2023 +0100

reuse AllowedLinkProtocolFromDocument in writer

reorg calc hyperlink check to reuse elsewhere

Change-Id: I20ae3c5df15502c3a0a366fb4a2924c06ffac3d0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159487
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
(cherry picked from commit e6a7537762e19fde446441edd10d301f9b37ce75)

reuse AllowedLinkProtocolFromDocument in writer

Change-Id: Iacf5e313fc6ca5f7d69ca6986a036f0e1ab1f2a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159488
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 
(cherry picked from commit 32535dfa82200b54296838b52285c054fbe5e51d)

combine these hyperlink dispatchers into one call

Change-Id: Icb7822e811013de648ccf2fbb23a5f0be9e29bb0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159489
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 
(cherry picked from commit 0df175ccc6ea542bc5801f631ff72bed187042eb)

we can have just one LoadURL for writer

Change-Id: Ia0162ee1c275292fcf200bad4662e4c2c6b7b972
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159557
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
(cherry picked from commit 521ca9cf6acbae96cf95d9740859c9682212013d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159858
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 
(cherry picked from commit e32b8601dbd63cf01497889601d6c9c1241106d6)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159879
Tested-by: Miklos Vajna 

diff --git a/include/sfx2/objsh.hxx b/include/sfx2/objsh.hxx
index 34f9ecf5bc90..eb95982be025 100644
--- a/include/sfx2/objsh.hxx
+++ b/include/sfx2/objsh.hxx
@@ -200,6 +200,9 @@ private:
 
 SAL_DLLPRIVATE bool SaveTo_Impl(SfxMedium , const SfxItemSet* pSet 
);
 
+// true if the document had macros (or similar) on load to trigger warning 
user
+SAL_DLLPRIVATE bool  GetHadCheckedMacrosOnLoad() const;
+
 protected:
 SfxObjectShell(SfxObjectCreateMode);
 SfxObjectShell(SfxModelFlags);// see 
sfxmodelfactory.hxx
@@ -427,8 +430,8 @@ public:
 voidSetMacroCallsSeenWhileLoading();
 boolGetMacroCallsSeenWhileLoading() const;
 
-// true if the document had macros (or similar) on load to trigger warning 
user
-boolGetHadCheckedMacrosOnLoad() const;
+// true if this type of link, from a document, is allowed by the user to 
be passed to uno:OpenDoc
+static bool AllowedLinkProtocolFromDocument(const 
OUString& rUrl, SfxObjectShell* pObjShell, weld::Window* pDialogParent);
 
 const css::uno::Sequence< css::beans::PropertyValue >& 
GetModifyPasswordInfo() const;
 boolSetModifyPasswordInfo( const 
css::uno::Sequence< css::beans::PropertyValue >& aInfo );
diff --git a/sc/source/core/data/global.cxx b/sc/source/core/data/global.cxx
index 22d957b54ea2..440990ccac8c 100644
--- a/sc/source/core/data/global.cxx
+++ b/sc/source/core/data/global.cxx
@@ -27,9 +27,7 @@
 #include 
 #include 
 #include 
-#include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -808,34 +806,8 @@ void ScGlobal::OpenURL(const OUString& rURL, const 
OUString& rTarget, bool bIgno
 aUrlName = aNewUrlName;
 }
 
-if (INetURLObject(aUrlName).IsExoticProtocol())
-{
-// Default to ignoring exotic protocols
-bool bAllow = false;
-if (pObjShell)
-{
-// If the document had macros when loaded then follow the allowed 
macro-mode
-if (pObjShell->GetHadCheckedMacrosOnLoad())
-bAllow = pObjShell->AdjustMacroMode();
-else // otherwise ask the user, defaulting to cancel
-{
-assert(pFrame && "if we have pObjShell we have pFrame");
-//Reuse URITools::onOpenURI warning string
-std::unique_ptr 
xQueryBox(Application::CreateMessageDialog(pFrame->GetFrameWeld(),
-   
VclMessageType::Warning, VclButtonsType::YesNo,
-   
SfxResId(STR_DANGEROUS_TO_OPEN)));
-

[Libreoffice-bugs] [Bug 158225] Incorrect encoding while opening cyrillic document created in MS Word 5.1 for Macintosh FILEOPEN

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158225

--- Comment #16 from Mikhail Kukharenko  ---
(In reply to osnola from comment #9)
> (In reply to Mikhail Kukharenko from comment #5)
> libmwaw only converts Mac Word 1.0 to 5.0 files and older PowerPoint formats
> (Mac and PC): I didn't write any other filters because LibreOffice already
> had filters to open other Office formats. 

What filter (library) is used by LO to open Mac Excel 4 documents?
We will try to add there support for cyrillic excel files. Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - dbaccess/source include/sfx2 sc/source sfx2/source

[Caolán McNamara (via logerrit)]

 dbaccess/source/core/dataaccess/ModelImpl.cxx |3 +-
 include/sfx2/docmacromode.hxx |4 ++-
 include/sfx2/objsh.hxx|3 ++
 sc/source/core/data/global.cxx|   34 +-
 sfx2/source/doc/docmacromode.cxx  |8 --
 sfx2/source/doc/objmisc.cxx   |8 +-
 sfx2/source/doc/objxtor.cxx   |1 
 sfx2/source/inc/objshimp.hxx  |3 +-
 8 files changed, 57 insertions(+), 7 deletions(-)

New commits:
commit 19cd01aaf2a14151f5629c054140bcef432f4df1
Author: Caolán McNamara 
AuthorDate: Fri Nov 3 17:26:25 2023 +
Commit: Miklos Vajna 
CommitDate: Fri Nov 24 08:45:32 2023 +0100

default to ignoring libreoffice special-purpose protocols in calc hyperlink

Change-Id: Ib9f62be3acc05f24ca234dec0fec21e24579e9de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158911
Tested-by: Jenkins
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 
(cherry picked from commit b6062623b4d69c79e90e9365ac7c5e7f11986793)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159046
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 
(cherry picked from commit 113e16674e94955702edde514a9fb86fbe70b3ae)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159878

diff --git a/dbaccess/source/core/dataaccess/ModelImpl.cxx 
b/dbaccess/source/core/dataaccess/ModelImpl.cxx
index 49a74717e559..ffa91c19924e 100644
--- a/dbaccess/source/core/dataaccess/ModelImpl.cxx
+++ b/dbaccess/source/core/dataaccess/ModelImpl.cxx
@@ -1123,7 +1123,8 @@ bool ODatabaseModelImpl::checkMacrosOnLoading()
 {
 Reference< XInteractionHandler > xInteraction;
 xInteraction = m_aMediaDescriptor.getOrDefault( "InteractionHandler", 
xInteraction );
-return m_aMacroMode.checkMacrosOnLoading( xInteraction );
+const bool bHasMacros = m_aMacroMode.hasMacros();
+return m_aMacroMode.checkMacrosOnLoading(xInteraction, false 
/*HasValidContentSignature*/, bHasMacros);
 }
 
 void ODatabaseModelImpl::resetMacroExecutionMode()
diff --git a/include/sfx2/docmacromode.hxx b/include/sfx2/docmacromode.hxx
index 7ed42f6a14dd..0acb44cbfbb1 100644
--- a/include/sfx2/docmacromode.hxx
+++ b/include/sfx2/docmacromode.hxx
@@ -264,6 +264,8 @@ namespace sfx2
 */
 static bool storageHasMacros( const css::uno::Reference< 
css::embed::XStorage >& _rxStorage );
 
+bool hasMacros() const;
+
 static bool containerHasBasicMacros( const css::uno::Reference< 
css::script::XLibraryContainer >& xContainer );
 /** checks the macro execution mode while loading the document.
 
@@ -291,7 +293,7 @@ namespace sfx2
 bool
 checkMacrosOnLoading(
 const css::uno::Reference< css::task::XInteractionHandler 
>& _rxInteraction,
-bool bHasValidContentSignature = false
+bool bHasValidContentSignature, bool bHasMacros
 );
 
 private:
diff --git a/include/sfx2/objsh.hxx b/include/sfx2/objsh.hxx
index 7440674d6656..34f9ecf5bc90 100644
--- a/include/sfx2/objsh.hxx
+++ b/include/sfx2/objsh.hxx
@@ -427,6 +427,9 @@ public:
 voidSetMacroCallsSeenWhileLoading();
 boolGetMacroCallsSeenWhileLoading() const;
 
+// true if the document had macros (or similar) on load to trigger warning 
user
+boolGetHadCheckedMacrosOnLoad() const;
+
 const css::uno::Sequence< css::beans::PropertyValue >& 
GetModifyPasswordInfo() const;
 boolSetModifyPasswordInfo( const 
css::uno::Sequence< css::beans::PropertyValue >& aInfo );
 
diff --git a/sc/source/core/data/global.cxx b/sc/source/core/data/global.cxx
index e29fccf5c1b2..22d957b54ea2 100644
--- a/sc/source/core/data/global.cxx
+++ b/sc/source/core/data/global.cxx
@@ -27,7 +27,9 @@
 #include 
 #include 
 #include 
+#include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -37,6 +39,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -771,7 +774,7 @@ void ScGlobal::OpenURL(const OUString& rURL, const 
OUString& rTarget, bool bIgno
 
 OUString aUrlName( rURL );
 SfxViewFrame* pFrame = nullptr;
-const SfxObjectShell* pObjShell = nullptr;
+SfxObjectShell* pObjShell = nullptr;
 OUString aReferName;
 if ( pScActiveViewShell )
 {
@@ -805,6 +808,35 @@ void ScGlobal::OpenURL(const OUString& rURL, const 
OUString& rTarget, bool bIgno
 aUrlName = aNewUrlName;
 }
 
+if (INetURLObject(aUrlName).IsExoticProtocol())
+{
+// Default to ignoring exotic protocols
+bool bAllow = false;
+if (pObjShell)
+{
+// If the document had macros when loaded then follow the allowed 
macro-mode
+if (pObjShell->GetHadCheckedMacrosOnLoad())
+bAllow = 

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - sw/source tools/source xmloff/source

[Caolán McNamara (via logerrit)]

 sw/source/filter/html/htmlplug.cxx |2 +-
 sw/source/filter/xml/xmltexti.cxx  |2 +-
 tools/source/fsys/urlobj.cxx   |3 ++-
 xmloff/source/draw/ximpshap.cxx|2 +-
 4 files changed, 5 insertions(+), 4 deletions(-)

New commits:
commit 38a7f67f26143b99fbb7dfb4fee4c7ca919fac4e
Author: Caolán McNamara 
AuthorDate: Sat Nov 4 19:57:51 2023 +
Commit: Miklos Vajna 
CommitDate: Fri Nov 24 08:45:07 2023 +0100

warn about exotic protocols as well

Change-Id: I50dcf4f36cd20d75f5ad3876353143268740a50f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158902
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 
(cherry picked from commit 1f5371361875629065a22560e39b9253eb87a23b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159877

diff --git a/sw/source/filter/html/htmlplug.cxx 
b/sw/source/filter/html/htmlplug.cxx
index 46b1b8952b45..ab2f04a43471 100644
--- a/sw/source/filter/html/htmlplug.cxx
+++ b/sw/source/filter/html/htmlplug.cxx
@@ -1105,7 +1105,7 @@ void SwHTMLParser::InsertFloatingFrame()
 
 OUString sHRef = aFrameDesc.GetURL().GetMainURL( 
INetURLObject::DecodeMechanism::NONE );
 
-if (INetURLObject(sHRef).GetProtocol() == INetProtocol::Macro)
+if (INetURLObject(sHRef).IsExoticProtocol())
 NotifyMacroEventRead();
 
 xSet->setPropertyValue("FrameURL", uno::makeAny( sHRef ) );
diff --git a/sw/source/filter/xml/xmltexti.cxx 
b/sw/source/filter/xml/xmltexti.cxx
index c14bd16e80e2..9a34b547f5af 100644
--- a/sw/source/filter/xml/xmltexti.cxx
+++ b/sw/source/filter/xml/xmltexti.cxx
@@ -826,7 +826,7 @@ uno::Reference< XPropertySet > 
SwXMLTextImportHelper::createAndInsertFloatingFra
 OUString sHRef = URIHelper::SmartRel2Abs(
 INetURLObject( GetXMLImport().GetBaseURL() ), 
rHRef );
 
-if (INetURLObject(sHRef).GetProtocol() == INetProtocol::Macro)
+if (INetURLObject(sHRef).IsExoticProtocol())
 GetXMLImport().NotifyMacroEventRead();
 
 xSet->setPropertyValue("FrameURL",
diff --git a/tools/source/fsys/urlobj.cxx b/tools/source/fsys/urlobj.cxx
index 187190b0dfe3..bcedfe4ff973 100644
--- a/tools/source/fsys/urlobj.cxx
+++ b/tools/source/fsys/urlobj.cxx
@@ -4834,7 +4834,8 @@ bool INetURLObject::IsExoticProtocol() const
 return m_eScheme == INetProtocol::Slot ||
m_eScheme == INetProtocol::Macro ||
m_eScheme == INetProtocol::Uno ||
-   isSchemeEqualTo(u"vnd.sun.star.script");
+   isSchemeEqualTo(u"vnd.sun.star.script") ||
+   isSchemeEqualTo(u"service");
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/xmloff/source/draw/ximpshap.cxx b/xmloff/source/draw/ximpshap.cxx
index fb5cda0901a8..84fbbd4f0e1f 100644
--- a/xmloff/source/draw/ximpshap.cxx
+++ b/xmloff/source/draw/ximpshap.cxx
@@ -3167,7 +3167,7 @@ void SdXMLFloatingFrameShapeContext::startFastElement 
(sal_Int32 /*nElement*/,
 
 if( !maHref.isEmpty() )
 {
-if (INetURLObject(maHref).GetProtocol() == INetProtocol::Macro)
+if (INetURLObject(maHref).IsExoticProtocol())
 GetImport().NotifyMacroEventRead();
 
 xProps->setPropertyValue("FrameURL", Any(maHref) );

[Libreoffice-commits] core.git: 2 commits - helpcontent2

[Mike Kaganski (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3e83fd3507b79b371443dee9c581a1058acaf995
Author: Mike Kaganski 
AuthorDate: Fri Nov 24 08:43:08 2023 +0100
Commit: Gerrit Code Review 
CommitDate: Fri Nov 24 08:43:08 2023 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to d85fa4e10f1156978c2f21aeab4e7d6ad7f80ab0
  - Clarify the default --outdir path

Change-Id: I696164fe7c08179e6968f8b1ad694d4dab508af0
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159891
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/helpcontent2 b/helpcontent2
index 330b000f3da5..d85fa4e10f11 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 330b000f3da52d482a62ae5b726f91eecccaf4f2
+Subproject commit d85fa4e10f1156978c2f21aeab4e7d6ad7f80ab0
commit 8d8877f3badd536a5e1ebecd79191d69b1848fd4
Author: Mike Kaganski 
AuthorDate: Fri Nov 24 08:43:00 2023 +0100
Commit: Gerrit Code Review 
CommitDate: Fri Nov 24 08:43:00 2023 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 330b000f3da52d482a62ae5b726f91eecccaf4f2
  - Add info about required write access to profile directory

Change-Id: Ife9416d25b7768682652525eec9f66f693785d27
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159890
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/helpcontent2 b/helpcontent2
index 65a60febbc9f..330b000f3da5 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 65a60febbc9f5a4e293977d357228f5504847b7f
+Subproject commit 330b000f3da52d482a62ae5b726f91eecccaf4f2

[Libreoffice-commits] help.git: 2 commits - source/text

[Mike Kaganski (via logerrit)]

 source/text/shared/guide/start_parameters.xhp |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit d85fa4e10f1156978c2f21aeab4e7d6ad7f80ab0
Author: Mike Kaganski 
AuthorDate: Fri Nov 24 08:40:34 2023 +0100
Commit: Mike Kaganski 
CommitDate: Fri Nov 24 08:43:07 2023 +0100

Clarify the default --outdir path

Change-Id: I696164fe7c08179e6968f8b1ad694d4dab508af0
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159891
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/source/text/shared/guide/start_parameters.xhp 
b/source/text/shared/guide/start_parameters.xhp
index 79f69a87a3..4b8cc8e1bd 100644
--- a/source/text/shared/guide/start_parameters.xhp
+++ b/source/text/shared/guide/start_parameters.xhp
@@ -545,7 +545,7 @@
 
 
 
-If --convert-to is used more than once, last 
value of 
OutputFileExtension[:OutputFilterName[:OutputFilterParams]] is 
effective. If --outdir is used more than once, only its last value 
is effective. For example:
+If --convert-to is used more than once, last 
value of 
OutputFileExtension[:OutputFilterName[:OutputFilterParams]] is 
effective. If --outdir is used more than once, only its last value 
is effective. In absence of --outdir, current working directory is 
used for the result. For example:
 --convert-to pdf 
*.doc
 --convert-to pdf:writer_pdf_Export --outdir /home/user 
*.doc
 --convert-to "html:XHTML Writer File:UTF8" 
*.doc
commit 330b000f3da52d482a62ae5b726f91eecccaf4f2
Author: Mike Kaganski 
AuthorDate: Fri Nov 24 08:37:18 2023 +0100
Commit: Mike Kaganski 
CommitDate: Fri Nov 24 08:42:59 2023 +0100

Add info about required write access to profile directory

Change-Id: Ife9416d25b7768682652525eec9f66f693785d27
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159890
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/source/text/shared/guide/start_parameters.xhp 
b/source/text/shared/guide/start_parameters.xhp
index b92b78d84c..79f69a87a3 100644
--- a/source/text/shared/guide/start_parameters.xhp
+++ b/source/text/shared/guide/start_parameters.xhp
@@ -63,6 +63,7 @@
 
 
 
+$[officename] requires write access to its user profile 
directory.
 Valid Command Line Parameters
 Using without special arguments
 Using 
without any arguments opens the start center.

[Libreoffice-commits] core.git: sw/source

[Miklos Vajna (via logerrit)]

 sw/source/core/inc/sectfrm.hxx|1 +
 sw/source/core/layout/sectfrm.cxx |   10 +-
 sw/source/core/text/xmldump.cxx   |6 --
 3 files changed, 10 insertions(+), 7 deletions(-)

New commits:
commit 40309da824a6d370aaeae4169c44f237387ec427
Author: Miklos Vajna 
AuthorDate: Thu Nov 23 20:03:48 2023 +0100
Commit: Miklos Vajna 
CommitDate: Fri Nov 24 08:27:23 2023 +0100

sw: extract SwSectionFrame::dumpAsXmlAttributes() from SwFrame

Allows getting rid of a static cast.

Change-Id: Iaba2a328399dacad3e16efa15df4f23abec6f883
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159869
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sw/source/core/inc/sectfrm.hxx b/sw/source/core/inc/sectfrm.hxx
index 82a41d4e3167..c07d78b12ba9 100644
--- a/sw/source/core/inc/sectfrm.hxx
+++ b/sw/source/core/inc/sectfrm.hxx
@@ -156,6 +156,7 @@ public:
 bool IsBalancedSection() const;
 
 virtual void dumpAsXml(xmlTextWriterPtr writer = nullptr) const override;
+void dumpAsXmlAttributes(xmlTextWriterPtr writer) const override;
 
 bool IsFootnoteAtEnd() const { return m_bFootnoteAtEnd; }
 bool IsEndnAtEnd() const { return m_bEndnAtEnd;   }
diff --git a/sw/source/core/layout/sectfrm.cxx 
b/sw/source/core/layout/sectfrm.cxx
index fdbcb5a57092..a1fd849ec495 100644
--- a/sw/source/core/layout/sectfrm.cxx
+++ b/sw/source/core/layout/sectfrm.cxx
@@ -2962,7 +2962,7 @@ bool SwSectionFrame::IsBalancedSection() const
 void SwSectionFrame::dumpAsXml(xmlTextWriterPtr writer) const
 {
 (void)xmlTextWriterStartElement(writer, BAD_CAST("section"));
-SwFrame::dumpAsXmlAttributes( writer );
+dumpAsXmlAttributes( writer );
 if ( HasFollow() )
 (void)xmlTextWriterWriteFormatAttribute( writer, BAD_CAST( "follow" ), 
"%" SAL_PRIuUINT32, GetFollow()->GetFrameId() );
 
@@ -2977,4 +2977,12 @@ void SwSectionFrame::dumpAsXml(xmlTextWriterPtr writer) 
const
 (void)xmlTextWriterEndElement(writer);
 }
 
+void SwSectionFrame::dumpAsXmlAttributes(xmlTextWriterPtr writer) const
+{
+SwLayoutFrame::dumpAsXmlAttributes(writer);
+
+SwSectionNode const*const pNode(GetSection() ? 
GetSection()->GetFormat()->GetSectionNode() : nullptr);
+(void)xmlTextWriterWriteFormatAttribute(writer, 
BAD_CAST("sectionNodeIndex"), "%" SAL_PRIdINT32, pNode ? 
sal_Int32(pNode->GetIndex()) : -1);
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/text/xmldump.cxx b/sw/source/core/text/xmldump.cxx
index b5cde782775f..245a1aa96945 100644
--- a/sw/source/core/text/xmldump.cxx
+++ b/sw/source/core/text/xmldump.cxx
@@ -207,12 +207,6 @@ void SwFrame::dumpAsXmlAttributes( xmlTextWriterPtr writer 
) const
 if (pFF->GetFollow())
 (void)xmlTextWriterWriteFormatAttribute( writer, 
BAD_CAST("follow"), "%" SAL_PRIuUINT32, pFF->GetFollow()->GetFrameId() );
 }
-if (IsSctFrame())
-{
-SwSectionFrame const*const pFrame(static_cast(this));
-SwSectionNode const*const pNode(pFrame->GetSection() ? 
pFrame->GetSection()->GetFormat()->GetSectionNode() : nullptr);
-(void)xmlTextWriterWriteFormatAttribute(writer, 
BAD_CAST("sectionNodeIndex"), "%" SAL_PRIdINT32, pNode ? 
sal_Int32(pNode->GetIndex()) : -1);
-}
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

[Libreoffice-bugs] [Bug 157936] Calc EDITING: pressing context menu key in a cell causes context menus of calc as well as the cell to popup at same time with focus on calc context menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157936

Buovjaga  changed:

   What|Removed |Added

Version|7.6.3.2 release |7.5.6.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157936] Calc EDITING: pressing context menu key in a cell causes context menus of calc as well as the cell to popup at same time with focus on calc context menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157936

VincentYu  changed:

   What|Removed |Added

Version|7.5.6.2 release |7.6.3.2 release

--- Comment #2 from VincentYu  ---
Reproduced on new install of 7.6.3.
Disappeared after the following procedure:
1. create new empty calc doc
2. copy & paste sheet causing problem to new doc
3. problem disappeared in new sheet.
Version: 7.6.3.2 (X86_64) / LibreOffice Community
Build ID: 29d686fea9f6705b262d369fede658f824154cc0
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 101912] [META] Accessibility (a11y) bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101912
Bug 101912 depends on bug 158338, which changed state.

Bug 158338 Summary: Opening file with image when JAWS is running causes endless 
loop
https://bugs.documentfoundation.org/show_bug.cgi?id=158338

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158338] Opening file with image when JAWS is running causes endless loop

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158338

Noel Grandin  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158338] Opening file with image when JAWS is running causes endless loop

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158338

--- Comment #3 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1e51005a2413457a9030c565d627e39670785b56

tdf#158338 Opening file with image when JAWS is running causes endless loop

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158338] Opening file with image when JAWS is running causes endless loop

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158338

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:24.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/source

[Noel Grandin (via logerrit)]

 sw/source/core/access/accfrmobj.cxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 1e51005a2413457a9030c565d627e39670785b56
Author: Noel Grandin 
AuthorDate: Thu Nov 23 17:47:24 2023 +0100
Commit: Noel Grandin 
CommitDate: Fri Nov 24 07:46:07 2023 +0100

tdf#158338 Opening file with image when JAWS is running causes endless loop

Revert "tdf#112865 assigning to mpDrawObj here is unnecessary"

This reverts commit 1c1647e6ee252fe68d7406d01043e88f1721590f.

Change-Id: I056123a90850989436dadf2d4504230550b9ae2b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159768
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sw/source/core/access/accfrmobj.cxx 
b/sw/source/core/access/accfrmobj.cxx
index d8e78836b2a1..f78dc2d155db 100644
--- a/sw/source/core/access/accfrmobj.cxx
+++ b/sw/source/core/access/accfrmobj.cxx
@@ -106,7 +106,9 @@ void SwAccessibleChild::Init( const SdrObject* pDrawObj )
 void SwAccessibleChild::Init( const SwFrame* pFrame )
 {
 mpFrame = pFrame;
-mpDrawObj = nullptr;
+mpDrawObj = mpFrame && mpFrame->IsFlyFrame()
+? static_cast < const SwFlyFrame * >( mpFrame 
)->GetVirtDrawObj()
+: nullptr;
 mpWindow = nullptr;
 }
 

[Libreoffice-bugs] [Bug 158345] Opening Hyperlink dialog leads to crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158345

--- Comment #1 from Andreas Heinisch  ---
Could you reproduce it under windows, too?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/vector/vector-7.5' - 2 commits - include/svtools sw/qa sw/source

[Mike Kaganski (via logerrit)]

 include/svtools/parhtml.hxx  |1 
 sw/qa/extras/htmlexport/data/test_no_space_preserve.fodt |   25 ++
 sw/qa/extras/htmlexport/htmlexport.cxx   |  147 +++
 sw/qa/extras/tiledrendering/data/multiline.odt   |binary
 sw/qa/extras/tiledrendering/tiledrendering.cxx   |   40 
 sw/source/filter/html/htmlatr.cxx|   83 ++--
 sw/source/filter/html/swhtml.cxx |2 
 sw/source/filter/html/wrthtml.cxx|   14 +
 sw/source/filter/html/wrthtml.hxx|4 
 sw/source/uibase/dochdl/swdtflvr.cxx |2 
 10 files changed, 298 insertions(+), 20 deletions(-)

New commits:
commit ea2c1bf8b48070b3869ba35fdf9c84aec57cf678
Author: Mike Kaganski 
AuthorDate: Tue Nov 14 11:05:05 2023 +0300
Commit: Mike Kaganski 
CommitDate: Thu Nov 23 22:57:50 2023 +0300

Limit PreserveSpaces HTML/ReqIF export option to proper space characters

We only need to care about SPACE, TAB, LF, and CR. We don't need to care
about LF in some cases, because it gets converted to a  element, and
handled specially. And we don't need to care about other "whitespace"
characters, like control characters and Unicode space.

Our own object placeholder characters were treated as "space", which was
wrong.

One peculiarity needs to be noted. In ReqIF case, a SPACE before LF needs
no 'xml:space="preserve"', but an LF before SPACE needs one, because it
needs to disambiguate between a  followed by a significant space vs.
a  followed by a pretty-printed newline.

Change-Id: I74273592df05bb94d8e4ecaea2c069c0e086b7d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159853
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/include/svtools/parhtml.hxx b/include/svtools/parhtml.hxx
index a6a15b93e3c1..1a17e98b2997 100644
--- a/include/svtools/parhtml.hxx
+++ b/include/svtools/parhtml.hxx
@@ -189,6 +189,7 @@ protected:
 
 void SetNamespace(std::u16string_view rNamespace);
 
+bool GetPreserveSpaces() const { return m_bPreserveSpaces; }
 void SetPreserveSpaces(bool val) { m_bPreserveSpaces = val; }
 
 public:
diff --git a/sw/qa/extras/htmlexport/data/test_no_space_preserve.fodt 
b/sw/qa/extras/htmlexport/data/test_no_space_preserve.fodt
new file mode 100644
index ..e0d9a3506e9f
--- /dev/null
+++ b/sw/qa/extras/htmlexport/data/test_no_space_preserve.fodt
@@ -0,0 +1,25 @@
+
+
+
+ 
+  
+   No special spaces
+   Leading space
+   Trailing space 
+   Double space
+   Leading/trailing breaks
+Leading break + space
+   Trailing space + break 
+   Middlebreak
+   Middle space + break
+   Middle break + space
+   Trailing space and SVG 
+  
PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiPz4KPHN2ZyB4bWxucz0iaHR0
+   cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZlcnNpb249IjEuMSIgdmlld0JveD0iMCAwIDIw
+   IDIwIiBzdHJva2U9ImJsYWNrIj4KPHBhdGggZD0iTTEsMUwxOSwxOSIvPgo8L3N2Zz4=
+  
+ 
+
+  
+ 
+
\ No newline at end of file
diff --git a/sw/qa/extras/htmlexport/htmlexport.cxx 
b/sw/qa/extras/htmlexport/htmlexport.cxx
index 6b8de215d27c..d72e2b1daf9e 100644
--- a/sw/qa/extras/htmlexport/htmlexport.cxx
+++ b/sw/qa/extras/htmlexport/htmlexport.cxx
@@ -2816,6 +2816,153 @@ CPPUNIT_TEST_FIXTURE(SwHtmlDomExportTest, 
testReqIF_PreserveSpaces)
 CPPUNIT_ASSERT_EQUAL(paraText, getParagraph(1)->getString());
 }
 
+CPPUNIT_TEST_FIXTURE(SwHtmlDomExportTest, testHTML_NoPreserveSpaces)
+{
+// Test cases where "PreserveSpaces" should not introduce respective markup
+
+const auto assertXPath_NoWhiteSpaceInStyle
+= [this](const xmlDocUniquePtr& pDoc, const OString& rXPath) {
+  xmlXPathObjectPtr pXmlObj = getXPathNode(pDoc, rXPath);
+  xmlNodeSetPtr pXmlNodes = pXmlObj->nodesetval;
+  CPPUNIT_ASSERT_EQUAL_MESSAGE(rXPath.getStr(), 1, 
xmlXPathNodeSetGetLength(pXmlNodes));
+  xmlNodePtr pXmlNode = pXmlNodes->nodeTab[0];
+  if (xmlChar* prop = xmlGetProp(pXmlNode, BAD_CAST("style")))
+  {
+  OUString style = OUString::fromUtf8(reinterpret_cast(prop));
+  CPPUNIT_ASSERT_MESSAGE(rXPath.getStr(), 
style.indexOf("white-space:") < 0);
+  }
+  xmlXPathFreeObject(pXmlObj);
+  };
+const auto assertXPath_HasWhiteSpaceInStyle
+= [this](const xmlDocUniquePtr& pDoc, const OString& rXPath) {
+  const OUString style = getXPath(pDoc, rXPath, "style");
+  CPPUNIT_ASSERT_MESSAGE(rXPath.getStr(), 
style.indexOf("white-space: pre-wrap") >= 0);
+  };
+
+createSwDoc("test_no_space_preserve.fodt");
+
+// Export to plain HTML, using PreserveSpaces:
+uno::Reference xStorable(mxComponent, 
uno::UNO_QUERY_THROW);
+css::uno::Sequence aStoreProperties = {
+

[Libreoffice-bugs] [Bug 157975] close XLS spreadsheet and all the data is lost

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157975

--- Comment #20 from simon.j.hun...@gmail.com ---
went into safe mode and turned hardware accelerate off.
waited a few hours and opened a xlsx. edited it and do file - close.
crash. no data lost from sheet.

went into safe mode and left hardware accelerate alone  (??  use hardware
acceleration checkbox is checked and disabled).
checked use skia for rendering.  restart.
waited a few hours and opened a xlsx. edited it and do  file - close.
crash. no data lost from sheet.

this is all there is in the skia log:

RenderMethod: vulkan
Vendor: 0x8086
Device: 0x3e92
API: 1.3.211
Driver: 0.404.1960
DeviceType: integrated
DeviceName: Intel(R) UHD Graphics 630
Denylisted: no

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156662] Always using direct connection to api.languagetool.org

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=156662

--- Comment #5 from Mike Kaganski  ---
(In reply to Stéphane Guillou (stragu) from comment #4)
> Sounds similar to bug 158093.

... and both not repro with master. I even provided a link to the commit that
changed how the service obtains the language list, which is what could be the
problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158350] oii

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158350

Werner Tietz  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|UNCONFIRMED |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: compilerplugins/clang sc/source

[Noel Grandin (via logerrit)]

 compilerplugins/clang/fieldcast.results   |3 ---
 sc/source/filter/inc/pivottablebuffer.hxx |4 +++-
 sc/source/filter/oox/pivottablebuffer.cxx |   15 +--
 3 files changed, 8 insertions(+), 14 deletions(-)

New commits:
commit b9312a055ab7759fba68a9353ae64d37b460a2d3
Author: Noel Grandin 
AuthorDate: Thu Nov 23 20:27:35 2023 +0200
Commit: Noel Grandin 
CommitDate: Fri Nov 24 06:27:18 2023 +0100

loplugin:fieldcast in oox::xls::PivotTable

Change-Id: Ie50626b2e24bba2ee67827afcdf42c1c0ed2c9d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159870
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/fieldcast.results 
b/compilerplugins/clang/fieldcast.results
index 6b16aeb370f9..b3a206434484 100644
--- a/compilerplugins/clang/fieldcast.results
+++ b/compilerplugins/clang/fieldcast.results
@@ -298,9 +298,6 @@ sc/source/filter/excel/xeformula.cxx:60
 sc/source/filter/inc/eeimport.hxx:43
 ScEEImport mpParser std::unique_ptr
 ScHTMLParser
-sc/source/filter/inc/pivottablebuffer.hxx:382
-oox::xls::PivotTable mxDPDescriptor 
css::uno::Reference
-ScDataPilotDescriptorBase
 sc/source/filter/xml/xmlimprt.hxx:156
 ScXMLImport xSheetCellRanges 
css::uno::Reference
 ScCellRangesObj
diff --git a/sc/source/filter/inc/pivottablebuffer.hxx 
b/sc/source/filter/inc/pivottablebuffer.hxx
index 04db017bfefc..a4ba60022dea 100644
--- a/sc/source/filter/inc/pivottablebuffer.hxx
+++ b/sc/source/filter/inc/pivottablebuffer.hxx
@@ -21,6 +21,7 @@
 
 #include "pivotcachebuffer.hxx"
 #include "stylesbuffer.hxx"
+#include 
 
 namespace com::sun::star {
 namespace sheet { class XDataPilotDescriptor; }
@@ -28,6 +29,7 @@ namespace com::sun::star {
 }
 
 class ScDPObject;
+class ScDataPilotDescriptorBase;
 
 namespace oox::xls {
 
@@ -378,7 +380,7 @@ private:
 PTDefinitionModel maDefModel; /// Global pivot table settings.
 PTLocationModel   maLocationModel;/// Location settings of the 
pivot table.
 PivotCache*   mpPivotCache;   /// The pivot cache this table 
is based on.
-css::uno::Reference< css::sheet::XDataPilotDescriptor >
+rtl::Reference< ScDataPilotDescriptorBase > // 
css::sheet::XDataPilotDescriptor
   mxDPDescriptor; /// Descriptor of the DataPilot 
object.
 std::map maInteropGrabBag;
 
diff --git a/sc/source/filter/oox/pivottablebuffer.cxx 
b/sc/source/filter/oox/pivottablebuffer.cxx
index 637637eb378c..252b4773ccf2 100644
--- a/sc/source/filter/oox/pivottablebuffer.cxx
+++ b/sc/source/filter/oox/pivottablebuffer.cxx
@@ -1247,7 +1247,7 @@ void PivotTable::finalizeImport()
 // create a new data pilot descriptor based on the source data
 Reference< XDataPilotTablesSupplier > xDPTablesSupp( getSheetFromDoc( 
maLocationModel.maRange.aStart.Tab() ), UNO_QUERY_THROW );
 Reference< XDataPilotTables > xDPTables( 
xDPTablesSupp->getDataPilotTables(), UNO_SET_THROW );
-mxDPDescriptor.set( xDPTables->createDataPilotDescriptor(), 
UNO_SET_THROW );
+mxDPDescriptor = static_cast( 
xDPTables->createDataPilotDescriptor().get() );
 ScRange aRange = mpPivotCache->getSourceRange();
 CellRangeAddress aCellRangeAddress( aRange.aStart.Tab(),
 aRange.aStart.Col(), 
aRange.aStart.Row(),
@@ -1255,17 +1255,12 @@ void PivotTable::finalizeImport()
 mxDPDescriptor->setSourceRange( aCellRangeAddress );
 mxDPDescriptor->setTag( maDefModel.maTag );
 
-// TODO: This is a hack. Eventually we need to convert the whole thing 
to the internal API.
-auto pImpl = 
dynamic_cast(mxDPDescriptor.get());
-if (!pImpl)
-return;
-
-mpDPObject = pImpl->GetDPObject();
+mpDPObject = mxDPDescriptor->GetDPObject();
 if (!mpDPObject)
 return;
 
 // global data pilot properties
-PropertySet aDescProp( mxDPDescriptor );
+PropertySet aDescProp(( css::uno::Reference< css::beans::XPropertySet 
>(mxDPDescriptor) ));
 aDescProp.setProperty( PROP_ColumnGrand, maDefModel.mbColGrandTotals );
 aDescProp.setProperty( PROP_RowGrand, maDefModel.mbRowGrandTotals );
 aDescProp.setProperty( PROP_ShowFilterButton, false );
@@ -1411,8 +1406,8 @@ Reference< XDataPilotField > 
PivotTable::getDataLayoutField() const
 Reference< XDataPilotField > xDPField;
 try
 {
-Reference< XDataPilotDataLayoutFieldSupplier > xDPDataFieldSupp( 
mxDPDescriptor, UNO_QUERY_THROW );
-xDPField = xDPDataFieldSupp->getDataLayoutField();
+if (mxDPDescriptor)
+xDPField = mxDPDescriptor->getDataLayoutField();
 }
 catch( Exception& )
 {

[Libreoffice-bugs] [Bug 157386] Writer crash when try to open a DOC file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157386

--- Comment #12 from wind_wu  ---
The latest version 7.6.3.2 crashed while trying to open this DOC file. I'm
expecting the regression to be fixed before the new year.

Version: 7.6.3.2 (X86_64) / LibreOffice Community
Build ID: 29d686fea9f6705b262d369fede658f824154cc0
CPU threads: 8; OS: Windows 10.0 Build 17763; UI render: Skia/Raster; VCL: win
Locale: zh-CN (en_US); UI: en-GB
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158350] New: oii

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158350

Bug ID: 158350
   Summary: oii
   Product: cppunit
   Version: 1.14
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: General
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: af6826...@gmail.com
CC: markus.mohrh...@googlemail.com

Created attachment 191018
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191018=edit
ahahhaa

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149100] LibreOffice crashes on startup in Fedora

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149100

--- Comment #10 from QA Administrators  ---
Dear Piotr Dobrogost,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158150] Native WebDav from Chrome/Safari with no plugin exactly like MS-WORD supports

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158150

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158128] Writer - Changes tab saves the Mark configuration incorrectly compared to documentation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158128

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158127] INDEX should use em dash (not hyphen) for number ranges

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158127

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158119] Alphabetical index: allow adjacent page numbers to combine (such as 15-16, 267-68 etc.)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158119

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145577] Crash in: xrhkbczd.dll

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145577

--- Comment #9 from QA Administrators  ---
Dear Alx,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 59424] undefined: I/O Error while opening file from WebDAV over GVFS from Nautilus

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=59424

--- Comment #22 from QA Administrators  ---
Dear Philipp Gassmann,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 130763] Strange character counting in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130763

--- Comment #8 from QA Administrators  ---
Dear Dirk Stumpe,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145592] Moving image up with one key press jumps image to new page below without actual overlap (to character anchoring/wrap involved)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145592

--- Comment #4 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 123079] Libreoffice leave tmp files in with new version

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123079

--- Comment #8 from QA Administrators  ---
Dear Gaurav Arora,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158349] FILEOPEN "General Error. General input/output error." when opening .docx files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158349

--- Comment #1 from Dario  ---
Created attachment 191017
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191017=edit
DOCX file that triggers the error

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158349] New: FILEOPEN "General Error. General input/output error." when opening .docx files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158349

Bug ID: 158349
   Summary: FILEOPEN "General Error. General input/output error."
when opening .docx files
   Product: LibreOffice
   Version: 7.6.2.1 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: dario...@gmail.com

Description:
The attached .docx files give the error when trying to open them.
The files are common word forms that can be downloaded from a government
website.

Steps to Reproduce:
1.Access the file from the link provided
2.Click to open
3.Error appears

Actual Results:
Error window
General Error.
General input/output error.

Expected Results:
Open the file properly to edit


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Here is the link to the file:

https://www.landgate.wa.gov.au/siteassets/forms/strata-titles-forms/approved/application-to-register-strata-titles-scheme-2020-43934-1.docx

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158152] Make Presenter Console window be renamed from "file" to "Console: file"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158152

Hossein  changed:

   What|Removed |Added

   Keywords|needsDevEval|difficultyMedium, skillCpp,
   ||topicUI

--- Comment #2 from Hossein  ---
(In reply to Stéphane Guillou (stragu) from comment #1)
> Makes perfect sense, thanks Timur.
> Hossein, I assume "difficultyBeginner"?

This is an EasyHack, but I should say difficultyMedium is better suited.

As the improvement is described as being similar to choosing the title
"Presenting: file" while presenting, it is good to start from that string.
Searching for a string literal starting with "Presenting, leads to a few
results:

$ git grep -F "\"Presenting"
sd/inc/strings.hrc:#define STR_FULLSCREEN_SLIDESHOW   
NC_("STR_FULLSCREEN_SLIDESHOW", "Presenting: %s")
...

It is clear that STR_FULLSCREEN_SLIDESHOW is the symbolic constant used to set
the title in this case. Searching for it leads to the function
SlideShow::StartFullscreenPresentation() in
sd/source/ui/slideshow/slideshow.cxx source code:

$ git grep STR_FULLSCREEN_SLIDESHOW
...
sd/source/ui/slideshow/slideshow.cxx:OUString
Title(SdResId(STR_FULLSCREEN_SLIDESHOW));

This function handles creation of extra window for presentation, and setting
its title and other attributes. Setting the title is done via the SetText()
function of the window object:

pWorkWindow->SetText(Title);

The source code for Console is inside sd/source/console folder. There are
various C++ files inside this folder. But, searching for the SetText() function
only returns another file, which is FullScreenPane.cxx.

$ git grep -i "window->SetText" sd
sd/source/ui/framework/factories/FullScreenPane.cxx:   
mpWorkWindow->SetText(pSystemWindow->GetText());
sd/source/ui/slideshow/slideshow.cxx:pWorkWindow->SetText(Title);

The console is displayed in a FullScreenPane. The title of the Window is taken
from the parent window, as described in FullScreenPane constructor. This should
be changed to achieve the desired improvement here. 

Note:
As described in LibreOffice help, one needs 2 displays to see the presenter
console on the auxiliary display. Also, it is important to make sure that the
appropriate option is activated via "Tools > Options > LibreOffice Impress >
General". There, "Enable Presenter Console" should be checked.
https://help.libreoffice.org/latest/en-US/text/simpress/guide/presenter_console.html

It is also possible to use a specific configuration inside
/org.openoffice.Office.PresenterScreen/ section of the LibreOffice expert
configuration to force the console to be always activated.
To enable this option, one has to go to "Tools > Options > LibreOffice >
Advanced > Open Expert Configuration", search for "StartAlways", and then
change the option to "true". After clicking on "OK", the console will be always
displayed, even if there is only 1 display available. This behavior is handled
in sd/source/console/PresenterScreen.cxx.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158270] LibreOffice.app crashes upon attempted start in macOS 14 Sonoma

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158270

--- Comment #7 from Patrick Luby  ---
(In reply to n6ac from comment #5)
> I am not sure how to get a macOS crash log.
> And I started Activity Monitor, attempted stat LibreOffice, do not see any
> "Recovery" info ...
> I do see SystemDiagnostics, would that do?

Sorry for the confusion. Sometimes when LibreOffice crashes, it can sometimes
save itself. That's when you see a "Recovery" dialog.

Soon after LibreOffice crashes, are you seeing a "Problem Report for
LibreOffice" window appear? If yes, that window is displaying the crash log
that we want.

The crash log is plain text so the easiest way to post it this bug is to click
in the middle of that window, press Command-a to select all of the text, press
Command-v to copy, and paste into your reply.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158293] Image in PDF is imported inverted (aka negative)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158293

--- Comment #8 from Patrick Luby  ---
After some debugging, I no longer think that we are missing a custom grayscale
palette in the embedded JPEG. Instead, my new theory is that LibreOffice is
failing to read the /ColorSpace object for image.

Specifically, in attachment
https://bugs.documentfoundation.org/attachment.cgi?id=190928, object 23 (regex
'^23 0') is the problematic JPEG image. It's colorspace is object 22 which
contains a '/DeviceCMYK' that is defined in object 21.

So I inverted the values in the object 21's '/Range' array. macOS Preview
renders some random black pixels and LibreOffice renders the same.

Not sure where to look next.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158347] Incorrect table rendering if in merged cell split across pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158347

--- Comment #11 from m.a.riosv  ---
No issue for me with 
Version: 7.6.4.0.0+ (X86_64) / LibreOffice Community
Build ID: 3e180c01f0d304c7b19b623c083a1634079d5c87
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: default; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL threaded
Version: 7.5.9.1 (X86_64) / LibreOffice Community
Build ID: 2f04f73a0f4ebfe9735ca11da23d6ed8f830fe34
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL threaded
with or without skia.

Please test with skia enable. Menu/Tools/Options/LibreOffice/View
or updating LibreOffice version
or updating the graphics driver.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158348] text in shape on drawing canvas in table cell has wrong place

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158348

--- Comment #1 from Regina Henschel  ---
Created attachment 191016
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191016=edit
tdf158348 screenshot left LO right Word

In case you have an idea about the reason please tell me.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158348] New: text in shape on drawing canvas in table cell has wrong place

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158348

Bug ID: 158348
   Summary: text in shape on drawing canvas in table cell has
wrong place
   Product: LibreOffice
   Version: 24.2.0.0 alpha0+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: implementationError
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de

Created attachment 191015
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191015=edit
document to reproduce the error

Open attached document in master. It has a table with two cells. The left cell
contains a drawing canvas and therein two shapes with text. Notice that the
text is at totally wrong place.

I have no idea yet, what here happens. The frames themselves are inside the
shape but the text is not inside the frames.

This belongs to the change to import drawing canvas instead of VML fallback
from commit https://gerrit.libreoffice.org/c/core/+/156629

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158270] LibreOffice.app crashes upon attempted start in macOS 14 Sonoma

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158270

--- Comment #6 from n6ac  ---
One odd thing I see –
in SystemInformation/Software/Applications, 
 LibreOffice is listed as Version 7.6.2.1 9/27/23
While in /Applications, 
 LibreOffice is listed as Version 7.6.3.2 11/17/23

???

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158270] LibreOffice.app crashes upon attempted start in macOS 14 Sonoma

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158270

n6ac  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #5 from n6ac  ---
I am not sure how to get a macOS crash log.
And I started Activity Monitor, attempted stat LibreOffice, do not see any
"Recovery" info ...
I do see SystemDiagnostics, would that do?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158347] Incorrect table rendering if in merged cell split across pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158347

--- Comment #10 from Alexander Kurakin  ---
Screenshot 1: thick extra line, thin extra line
Screenshot 2: the same
Screenshot 3: thick extra line, thin extra line, thick extra line
Screenshot 4: thin "line" instead of real thick line
Screenshot 5: the same

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158347] Incorrect table rendering if in merged cell split across pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158347

--- Comment #9 from Alexander Kurakin  ---
(In reply to m.a.riosv from comment #8)
> Looks like a duplicate of tdff#154312

Bug #154312 is about selection.
This bug #158347 is about lines.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158347] Incorrect table rendering if in merged cell split across pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158347

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #8 from m.a.riosv  ---
Looks like a duplicate of tdff#154312

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158347] Incorrect table rendering if in merged cell split across pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158347

--- Comment #7 from Alexander Kurakin  ---
Created attachment 191014
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191014=edit
Screenshot 5 (PDF exported)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158347] Incorrect table rendering if in merged cell split across pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158347

--- Comment #6 from Alexander Kurakin  ---
Created attachment 191013
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191013=edit
Screenshot 4

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158347] Incorrect table rendering if in merged cell split across pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158347

--- Comment #5 from Alexander Kurakin  ---
Created attachment 191012
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191012=edit
Screenshot 3

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158347] Incorrect table rendering if in merged cell split across pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158347

--- Comment #4 from Alexander Kurakin  ---
Created attachment 191011
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191011=edit
Screenshot 2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158347] Incorrect table rendering if in merged cell split across pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158347

--- Comment #3 from Alexander Kurakin  ---
Created attachment 191010
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191010=edit
Screenshot 1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158347] Incorrect table rendering if in merged cell split across pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158347

--- Comment #2 from Alexander Kurakin  ---
Created attachment 191009
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191009=edit
Test case file

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158347] Incorrect table rendering if in merged cell split across pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158347

--- Comment #1 from Alexander Kurakin  ---
Reproduced in:

Version: 7.5.6.2 (X86_64) / LibreOffice Community
Build ID: 50(Build:2)
CPU threads: 4; OS: Linux 6.1; UI render: default; VCL: gtk3
Locale: ru-RU (ru_RU.UTF-8); UI: ru-RU
Gentoo official package
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158347] New: Incorrect table rendering if in merged cell split across pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158347

Bug ID: 158347
   Summary: Incorrect table rendering if in merged cell split
across pages
   Product: LibreOffice
   Version: 7.5.6.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kuraga...@mail.ru
CC: kuraga...@mail.ru

I made a table like:

-
|   |   |   |   |
| A | B | C |
| D | E | F |   |   |   |
--
| G | H | I | J | K | L |
  . . .
|---|

(The  first two lines are header.)

If I put a page break inside the table, I see the artifacts.
Also there are artifacts on PDF export.

See the test case file and the screenshots.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158346] New: The ScriptForge library has crashed. The reason is unknow.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158346

Bug ID: 158346
   Summary: The ScriptForge library has crashed. The reason is
unknow.
   Product: LibreOffice
   Version: 7.6.3.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: phamxt...@gmail.com

Description:
It runs smooth with 7.5.8
After upgrade to 7.6.3~rc2-0ubuntu0.23.04.1~lo3
I got message when run python script
---
Library: ScriptForge
Service: Session
Method: ExecutePythonScript

The ScriptForge library has crashed. The reason is unknow.
Maybe a bug that could be report on https://bugs.documentfoundation.org/

More details:

Location: Session.ExecutePythonScript/300
An exception occured
Type: com.sun.star.script.provider.ScriptFrameworkErrorException
Message: : No module named 'scriptforge' (or
'scriptforge.CreateScriptService' is unknown)
File "usr/lib/libreoffice/program/pythonscript.py" line 1058, in getScript.
...
---

Steps to Reproduce:
1.From Ubuntu 23.04, upgrade from 7.5.8 to 7.6.3 rc2
2.Run any python macro

Actual Results:
Macro not run, it return an error 
---
Library: ScriptForge
Service: Session
Method: ExecutePythonScript

The ScriptForge library has crashed. The reason is unknow.
Maybe a bug that could be report on https://bugs.documentfoundation.org/

More details:

Location: Session.ExecutePythonScript/300
An exception occured
Type: com.sun.star.script.provider.ScriptFrameworkErrorException
Message: : No module named 'scriptforge' (or
'scriptforge.CreateScriptService' is unknown)
File "usr/lib/libreoffice/program/pythonscript.py" line 1058, in getScript.
...

Expected Results:
Python macro runs


Reproducible: Always


User Profile Reset: No

Additional Info:
Python macro runs

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158270] LibreOffice.app crashes upon attempted start in macOS 14 Sonoma

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158270

steve  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158345] New: Opening Hyperlink dialog leads to crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158345

Bug ID: 158345
   Summary: Opening Hyperlink dialog leads to crash
   Product: LibreOffice
   Version: 24.2.0.0 alpha0+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: bibisected, bisected, haveBacktrace, regression
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kelem...@ubuntu.com
CC: andreas.heini...@yahoo.de
Blocks: 112125

Created attachment 191008
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191008=edit
backtrace from my own build

When the Hyperlink dialog is opened right after starting the machine, leads to
a crash.

1. Turn off / hibernate your computer/VM. This is needed to empty the
clipboard.
2. Turn on the computer/VM
3. Start Writer or Calc
4. Insert - Hyperlink
-> crash.

This does not happen if there is anything already on the clipboard. But if
that's empty, it always crashes with non-GTK3 backends. Checked with gen and
Windows.

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: a91892ec4942fc875820ea02dfbe74e986548142
CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: x11
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded

Seems to have started with:
https://git.libreoffice.org/core/+/89d3735e05b98223a49a387421386fd736fc3de6

author  Andreas Heinisch Wed Jul 26 10:31:56
2023 +0200
committer   Andreas Heinisch Thu Jul 27
09:01:57 2023 +0200

tdf#146576 - Propose clipboard content when inserting a hyperlink

Adding CC to: Andreas Heinisch


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=112125
[Bug 112125] [META] Hyperlink dialog bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112125] [META] Hyperlink dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112125

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Depends on||158345


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=158345
[Bug 158345] Opening Hyperlink dialog leads to crash
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146497] Crash in: std::_Tree, std::allocator, 0> >::erase

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146497

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||7357
 CC||stephane.guillou@libreoffic
   ||e.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147357] Crash in: unsigned __int64 std::_Tree, std::allocator, 0> >::erase(class ScFormulaCell *

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147357

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||6497

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158344] FILEOPEN DOCX Crash on opening file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158344

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

  Regression By||Michael Stahl

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 106609] Inserting a note or a comment, after sharing an .ODS file, greyed out...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106609

--- Comment #35 from Maja James  ---
Use SHEIN promo codes to get amazing discounts and savings. All of SHEINs
discounts are available to you if you consistently check Couponsexperts.com.
Don't wait any longer if you want to save money
visit:https://www.couponsexperts.com/stores/shein-coupon-codes and start taking
advantage of the deals right now!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158343] FILEOPEN DOCX Crash on opening file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158343

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||8344

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158344] New: FILEOPEN DOCX Crash on opening file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158344

Bug ID: 158344
   Summary: FILEOPEN DOCX Crash on opening file
   Product: LibreOffice
   Version: 24.2.0.0 alpha0+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: bibisected, bisected, regression
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kelem...@ubuntu.com
CC: michael.st...@allotropia.de

Created attachment 191006
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191006=edit
Example file from Word 2016

Attached file crashes LO upon opening.

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9602f8a9318dd4d3409856e2ae06abe96e72b51b
CPU threads: 15; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: threaded

Seems to have started with:

https://git.libreoffice.org/core/+/8c24bc5baa1f501943bf955e07787d80cb7a5763

author  Michael Stahl  Fri Aug 25 18:31:42
2023 +0200
committer   Michael Stahl  Mon Aug 28
13:48:54 2023 +0200

(related? tdf#155177) sw: layout: fix another RemoveFollowFlowLine SNAFU

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158343] New: FILEOPEN DOCX Crash on opening file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158343

Bug ID: 158343
   Summary: FILEOPEN DOCX Crash on opening file
   Product: LibreOffice
   Version: 24.2.0.0 alpha0+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: bibisected, bisected, regression
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kelem...@ubuntu.com

Created attachment 191005
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191005=edit
Example file from Word 2016

Attached example file crashes LO when opened.

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9602f8a9318dd4d3409856e2ae06abe96e72b51b
CPU threads: 15; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: threaded

Seems to have started with:

https://git.libreoffice.org/core/+/9057641f678b8e36c9dbc41960b182c6ecfdda15

author  Khaled HosnyWed Jul 19 05:53:09 2023 +0300
committer   خالد حسني   Sun Jul 23 06:03:29
2023 +0200

vcl: SalLayout::GetTextWidth() returns double

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133092] [META] Crash bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=133092

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||149079


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=149079
[Bug 149079] EDITING Calc crashes when editing cell content in inserted rows
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143376] Crash in: vcl::unohelper::DragAndDropWrapper::dragGestureRecognized(com::sun::star::datatransfer::dnd::DragGestureEvent const &)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143376

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Resolution|INSUFFICIENTDATA|DUPLICATE

--- Comment #4 from Stéphane Guillou (stragu) 
 ---


*** This bug has been marked as a duplicate of bug 149079 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144186] Crash in: vcl::unohelper::DragAndDropWrapper::dragGestureRecognized(com::sun::star::datatransfer::dnd::DragGestureEvent const &)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144186

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Resolution|INSUFFICIENTDATA|DUPLICATE

--- Comment #5 from Stéphane Guillou (stragu) 
 ---


*** This bug has been marked as a duplicate of bug 149079 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147116] Crash in: vcl::unohelper::DragAndDropWrapper::dragGestureRecognized(com::sun::star::datatransfer::dnd::DragGestureEvent const &)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147116

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Version|unspecified |7.2.5.2 release
 Resolution|INSUFFICIENTDATA|DUPLICATE

--- Comment #4 from Stéphane Guillou (stragu) 
 ---


*** This bug has been marked as a duplicate of bug 149079 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143827] Two Calc crashes when editing a comment box that is half in a frozen row and half not. (text selected)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143827

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
Crash report or||["vcl::unohelper::DragAndDr
crash signature||opWrapper::dragGestureRecog
   ||nized(com::sun::star::datat
   ||ransfer::dnd::DragGestureEv
   ||ent const &)"]
 CC||stephane.guillou@libreoffic
   ||e.org
 Status|UNCONFIRMED |RESOLVED

--- Comment #5 from Stéphane Guillou (stragu) 
 ---
Crash signature last seen in 7.3.3.2
Corresponding crash signature for Linux is
vcl::unohelper::DragAndDropWrapper::dragGestureRecognized(com::sun::star::datatransfer::dnd::DragGestureEvent
const&), also last seen in 7.3.3.2.
Linux signature seen in bug 149079, matches the version fixed. Marking as
duplicate.

*** This bug has been marked as a duplicate of bug 149079 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157924] It opens almost all documents with distorted fonts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157924

Max  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156466] FILESAVE DOC: Saved file made Word hang

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=156466

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   Keywords||needsDevAdvice
 Status|UNCONFIRMED |NEEDINFO
 Whiteboard| QA:needsComment|
 Ever confirmed|0   |1
 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #2 from Stéphane Guillou (stragu) 
 ---
(In reply to Regina Henschel from comment #0)
> I was told by an employee of Microsoft, that OpenOffice produces a file
> which made Word hang. Because I know no better place, I report it here, so
> that our developers can look, whether the problem exists in LibreOffice too.
Is there any extra information on how OpenOffice would create such a corrupt
DOC file? Or does it apply to all DOC files created with AOO?

In any case, the attached file open fine in LO, Office 365 and OnlyOffice.

Maybe something to mention on IRC.

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 7d357628d6e8ce3f9e3c3a567ada21f02bce8d42
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155314] [META] LanguageTool integration

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155314

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||156662


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=156662
[Bug 156662] Always using direct connection to api.languagetool.org
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158093] LibreOffice hangs at startup if LanguageTool Server is not reachable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158093

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||6662

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156662] Always using direct connection to api.languagetool.org

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=156662

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Blocks||155314
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||8093
 CC||mikekagan...@hotmail.com,
   ||stephane.guillou@libreoffic
   ||e.org
 Whiteboard| QA:needsComment|

--- Comment #4 from Stéphane Guillou (stragu) 
 ---
Thanks for the report.
Mike, what do you think? Sounds similar to bug 158093.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=155314
[Bug 155314] [META] LanguageTool integration
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: lingucomponent/source

[Mike Kaganski (via logerrit)]

 lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx |   14 
+-
 1 file changed, 7 insertions(+), 7 deletions(-)

New commits:
commit 05d5181e2c19aca7e6098217ddb7065e02819a53
Author: Mike Kaganski 
AuthorDate: Thu Nov 23 13:21:02 2023 +0100
Commit: Mike Kaganski 
CommitDate: Thu Nov 23 22:30:29 2023 +0100

tdf#158117: encode the username sent to LanguageTool

Change-Id: I762ebb7487b3bcb80cd88b265b4e75c0d8b7c639
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159764
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx 
b/lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx
index 599bb01c6194..fe912cb6b341 100644
--- a/lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx
+++ b/lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx
@@ -86,15 +86,16 @@ PropertyValue lcl_GetLineColorPropertyFromErrorId(const 
std::string& rErrorId)
 return comphelper::makePropertyValue("LineColor", aColor);
 }
 
-OString encodeTextForLanguageTool(const OUString& text)
+OString encodeTextForLT(const OUString& text)
 {
 // Let's be a bit conservative. I don't find a good description what needs 
encoding (and in
 // which way) at https://languagetool.org/http-api/; the "Try it out!" 
function shows that
 // different cases are handled differently by the demo; some 
percent-encode the UTF-8
 // representation, like %D0%90 (for cyrillic А); some turn into entities 
like  (for
-// exclamation mark !); some other to things like \u0027 (for apostrophe 
').
+// exclamation mark !); some other to things like \u0027 (for apostrophe 
'). So only keep
+// RFC 3986's "Unreserved Characters" set unencoded, use UTF-8 
percent-encoding for the rest.
 static constexpr auto myCharClass = rtl::createUriCharClass(
-u8"0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz");
+
u8"-._~0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz");
 return OUStringToOString(
 rtl::Uri::encode(text, myCharClass.data(), rtl_UriEncodeStrict, 
RTL_TEXTENCODING_UTF8),
 RTL_TEXTENCODING_ASCII_US);
@@ -196,10 +197,9 @@ std::string makeHttpRequest(std::u16string_view aURL, 
HTTP_METHOD method, const
 {
 OString apiKey
 = OUStringToOString(LanguageToolCfg::ApiKey::get().value_or(""), 
RTL_TEXTENCODING_UTF8);
-OString username = 
OUStringToOString(LanguageToolCfg::Username::get().value_or(""),
- RTL_TEXTENCODING_UTF8);
+OUString username = LanguageToolCfg::Username::get().value_or("");
 if (!apiKey.isEmpty() && !username.isEmpty())
-realPostData += "=" + username + "=" + apiKey;
+realPostData += "=" + encodeTextForLT(username) + 
"=" + apiKey;
 }
 
 return makeHttpRequest_impl(aURL, method, realPostData, nullptr, 
nStatusCode);
@@ -440,7 +440,7 @@ ProofreadingResult SAL_CALL 
LanguageToolGrammarChecker::doProofreading(
 }
 else
 {
-postData = "text=" + encodeTextForLanguageTool(aText) + "=" + 
langTag;
+postData = "text=" + encodeTextForLT(aText) + "=" + langTag;
 }
 
 if (auto cachedResult = mCachedResults.find(postData); cachedResult != 
mCachedResults.end())

[Libreoffice-bugs] [Bug 156089] When the dialog customizes the Numbering type to "None", it still keeps the prefix/suffix, which need to be removed separately

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=156089

--- Comment #14 from Justin L  ---
(In reply to Eyal Rozenberg from comment #13)
> Let's quote the design meeting comments supporting this conclusion:
> >   + works like in MSO, WF (Justin)
> Justin has changed his opinion
I think comment 5 and comment 7 show that I never considered this a WF once the
issue was clarified, so the meeting's assessment of my opinion was wrong. I
even provided a patch that solves the problem...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 156089] When the dialog customizes the Numbering type to "None", it still keeps the prefix/suffix, which need to be removed separately

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=156089

--- Comment #14 from Justin L  ---
(In reply to Eyal Rozenberg from comment #13)
> Let's quote the design meeting comments supporting this conclusion:
> >   + works like in MSO, WF (Justin)
> Justin has changed his opinion
I think comment 5 and comment 7 show that I never considered this a WF once the
issue was clarified, so the meeting's assessment of my opinion was wrong. I
even provided a patch that solves the problem...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 157924] It opens almost all documents with distorted fonts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157924

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTOURBUG

--- Comment #12 from Stéphane Guillou (stragu) 
 ---
(In reply to Max from comment #10)
> /usr/local/share/fonts/a/arachnid___arachnid___arachnid.ttf: arachnid,Times
> New
> Roman:style=arachnid,Normal,obyčejné,Standard,Κανονικά,Normaali,Normál,
> Normale,Standaard,Normalny,Обычный,Normálne,Navadno,thường,Arrunta,Regular
So your arachnid somehow had the font family "Times New Roman" as well.
Removing that font would be the solution, yes.
Closing as "not our bug".
Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 113117] [META] Windows installer/uninstaller bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113117

Jérôme  changed:

   What|Removed |Added

 Depends on||158342


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=158342
[Bug 158342] applications launched at user session startup : quick start
appears several times
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158342] applications launched at user session startup : quick start appears several times

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158342

Jérôme  changed:

   What|Removed |Added

 Blocks||113117


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113117
[Bug 113117] [META] Windows installer/uninstaller bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158342] New: applications launched at user session startup : quick start appears several times

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158342

Bug ID: 158342
   Summary: applications launched at user session startup : quick
start appears several times
   Product: LibreOffice
   Version: 7.3.7.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jerome.bo...@laposte.net

Created attachment 191003
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191003=edit
applications launched at user session startup

After installing LibreOffice, previous versions of quickstart are still saved
in the applications that are launched when the user's session is started. I had
to disable quickstart of previous versions by hand.

Version: 7.3.7.2.M5 (x64) / LibreOffice Community
Build ID: cf0a4747cef76399d7acd30c4dcda7a78e7973c2
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: fr-FR (fr_FR); UI: fr-FR
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158335] Bad rendering, with zoom-in, of any change in the ODS files.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158335

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
 CC||stephane.guillou@libreoffic
   ||e.org
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=96
   ||769

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
I reproduce in a new ODS file, but only when adding text in the formula bar
(rather than directly in the cell). Is that the same for you?

Using:
Version: 7.6.3.2.0+
Build ID: 0e982fe4db35
Android 9, Galaxy A20e

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 96769] ANDROID VIEWER: view does not update when undoing changes in Writer file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96769

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||8335

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158282] FILEOPEN Incorrect encoding opening MS Excel 4.0 for Macintosh files with cyrillic text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158282

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
 CC||79045_79...@mail.ru

--- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> ---
confirm in

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: d7a5e7643f3540b1490c1e2f1a91ff86c721d7b6
CPU threads: 16; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143781] [META] Development- and code-related bug reports and tasks

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143781

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||158337


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=158337
[Bug 158337] Use C++20 std::erase instead of std::removed followed by erase
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158337] Use C++20 std::erase instead of std::removed followed by erase

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158337

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Ever confirmed|0   |1
   Keywords||difficultyBeginner,
   ||easyHack, skillCpp
 Blocks||143781
 Status|UNCONFIRMED |NEW

--- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> ---
Set to NEW as EasyHack


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=143781
[Bug 143781] [META] Development- and code-related bug reports and tasks
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 115121] [META] Heading numbering dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115121
Bug 115121 depends on bug 156089, which changed state.

Bug 156089 Summary: When the dialog customizes the Numbering type to "None", it 
still keeps the prefix/suffix, which need to be removed separately
https://bugs.documentfoundation.org/show_bug.cgi?id=156089

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|NOTABUG |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103370] [META] Heading Numbering bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103370
Bug 103370 depends on bug 156089, which changed state.

Bug 156089 Summary: When the dialog customizes the Numbering type to "None", it 
still keeps the prefix/suffix, which need to be removed separately
https://bugs.documentfoundation.org/show_bug.cgi?id=156089

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|NOTABUG |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 156089] When the dialog customizes the Numbering type to "None", it still keeps the prefix/suffix, which need to be removed separately

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=156089

Eyal Rozenberg  changed:

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|NOTABUG |---
   Keywords||needsUXEval
 CC||hoss...@libreoffice.org,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org

--- Comment #13 from Eyal Rozenberg  ---
I'm returning to this bug after several months, so let me add a bit more info,
plus reply to multiple comments. 

So, first piece of info: We get this undesirable behavior when pressing the
(already-pressed) numbering button on the toolbar. It's one thing not to clear
the Prefix and Suffix values in the dialog - but when the user presses the
already-pressed numbering button, they express a clear intent of wanting to
remove the numbering completely - certainly not to leave behind a suffix and
prefix.

So, it turns out that the prefix and suffix do disappear, if you choose
"Graphic" or "Bullet" for example, accept, then open the dialog again. That
means that we don't strongly hold on to these settings anyway.


(In reply to Justin L from comment #1)
> I assume this document expresses what you are describing.

Only in the sense that it has Heading numbering with a suffix. But the text of
the document doesn't.

(In reply to Heiko Tietze from comment #11)
> We discussed the topic in the design meeting. Following the comments here we
> agree on the WF/NAB verdict.

Let's quote the design meeting comments supporting this conclusion:

>   + works like in MSO, WF (Justin)
>   + no reason to block, WF (Heiko)
>   + behavior existing for years shouldn't change without
> good reasons (Hossein)
>   + list style is something you shouldn't change multiple times
>   => resolve WF 

Justin has changed his opinion (making it a draw in terms of people involved in
the discussion).

I didn't understand Heiko's comment - block what?

Re Hossein's comment: It's a long-standing bug, which has annoyed users for all
this time, at least in the toolbar button use-case I mentioned above.

Re the last comment: That argument works both ways: If you don't do this a lot,
you shouldn't mind typing in your suffixes or prefixes. Also, we actually do
remove numbering multiple times using the toolbar button (as opposed to
fiddling with list style specifics).


So I am un-resolving. Also, we now have a third possible resolution: Different
behavior when selecting None in the dialog and when pressing the numbering
button on the toolbar. We can have the former maintain and the latter drop the
prefix and suffix.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 156089] When the dialog customizes the Numbering type to "None", it still keeps the prefix/suffix, which need to be removed separately

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=156089

Eyal Rozenberg  changed:

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|NOTABUG |---
   Keywords||needsUXEval
 CC||hoss...@libreoffice.org,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org

--- Comment #13 from Eyal Rozenberg  ---
I'm returning to this bug after several months, so let me add a bit more info,
plus reply to multiple comments. 

So, first piece of info: We get this undesirable behavior when pressing the
(already-pressed) numbering button on the toolbar. It's one thing not to clear
the Prefix and Suffix values in the dialog - but when the user presses the
already-pressed numbering button, they express a clear intent of wanting to
remove the numbering completely - certainly not to leave behind a suffix and
prefix.

So, it turns out that the prefix and suffix do disappear, if you choose
"Graphic" or "Bullet" for example, accept, then open the dialog again. That
means that we don't strongly hold on to these settings anyway.


(In reply to Justin L from comment #1)
> I assume this document expresses what you are describing.

Only in the sense that it has Heading numbering with a suffix. But the text of
the document doesn't.

(In reply to Heiko Tietze from comment #11)
> We discussed the topic in the design meeting. Following the comments here we
> agree on the WF/NAB verdict.

Let's quote the design meeting comments supporting this conclusion:

>   + works like in MSO, WF (Justin)
>   + no reason to block, WF (Heiko)
>   + behavior existing for years shouldn't change without
> good reasons (Hossein)
>   + list style is something you shouldn't change multiple times
>   => resolve WF 

Justin has changed his opinion (making it a draw in terms of people involved in
the discussion).

I didn't understand Heiko's comment - block what?

Re Hossein's comment: It's a long-standing bug, which has annoyed users for all
this time, at least in the toolbar button use-case I mentioned above.

Re the last comment: That argument works both ways: If you don't do this a lot,
you shouldn't mind typing in your suffixes or prefixes. Also, we actually do
remove numbering multiple times using the toolbar button (as opposed to
fiddling with list style specifics).


So I am un-resolving. Also, we now have a third possible resolution: Different
behavior when selecting None in the dialog and when pressing the numbering
button on the toolbar. We can have the former maintain and the latter drop the
prefix and suffix.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158152] Make Presenter Console window be renamed from "file" to "Console: file"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158152

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   Keywords||needsDevEval
 Ever confirmed|0   |1
 CC||hoss...@libreoffice.org,
   ||stephane.guillou@libreoffic
   ||e.org
 Status|UNCONFIRMED |NEW

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
Confirmed in:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 7d357628d6e8ce3f9e3c3a567ada21f02bce8d42
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Makes perfect sense, thanks Timur.
Hossein, I assume "difficultyBeginner"?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158270] LibreOffice.app crashes upon attempted start in macOS 14 Sonoma

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158270

Patrick Luby  changed:

   What|Removed |Added

 CC||plub...@neooffice.org

--- Comment #4 from Patrick Luby  ---
I don't see any crashing when launching LibreOffice 7.6.2 or later with macOS
14.1.1 on a Silicon MacBook Pro.

Can anyone who is expreriencing this crash attach a macOS crash log?

If LibreOffice does not generate a crash log, can you get a sample when the
Recovery dialog appears using the /Applications/Utilities/Activity Monitor
application?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158341] FILEOPEN DOCX Endless loop on opening file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158341

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
Version|24.2.0.0 alpha0+|7.6.3.1 rc
 Ever confirmed|0   |1
  Regression By||Miklos Vajna
   Keywords||bisected
 CC||stephane.guillou@libreoffic
   ||e.org
   Severity|normal  |major
   Priority|medium  |high

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
Thanks Gabor.

Repro in:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 7d357628d6e8ce3f9e3c3a567ada21f02bce8d42
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

and:

Version: 7.6.3.1 (X86_64) / LibreOffice Community
Build ID: c4af5b1259bceea6e979e6fe2435dbee7a5a87c2
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

(was cherrypicked as 60e2fdf1d7e8346e5a3835369c47e582c737ce20)

No repro in:

Version: 7.5.8.2 (X86_64) / LibreOffice Community
Build ID: f718d63693263970429a68f568db6046aaa9df01
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141886] Removed text from Impress/Draw table comes back after save and reopen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141886

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED
   Keywords||bisected, regression
 CC||stephane.guillou@libreoffic
   ||e.org
Version|7.1.2.2 release |7.1.0.3 release
Summary|Data saving error in latest |Removed text from
   |updates 7.1.2 & 7.1.1 & |Impress/Draw table comes
   |7.1.8.1 |back after save and reopen
 Whiteboard||target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 113092] [META] Impress/Draw table dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113092

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on|141688  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=141688
[Bug 141688] FILESAVE ODP Merged table cells contents duplicated
-- 
You are receiving this mail because:
You are the assignee for the bug.