[Bug 159097] New: Enhancement - recognize three letter extensions on files
https://bugs.documentfoundation.org/show_bug.cgi?id=159097 Bug ID: 159097 Summary: Enhancement - recognize three letter extensions on files Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: puckchase...@gmail.com Description: When using Recent Documents selection in file pulldown menu, as default please only show files with three letter extensions appropriate to the app - e.g. *.doc or *.txt for LibreOffice Word, or *.xls for LibreOffice Calc., etc. As it is, the selection list is so cluttered it is almost unusable. There may be occasions where a file has no extension so you can always have an option to show all files. Steps to Reproduce: 1. Select Recent Documents under File pulldown 2. 3. Actual Results: If you do a lot of work using a mix of Word, Calc, and Draw, you see a long list of files - many or most not relevant to the active application Expected Results: See only files relevant to the active application unless I specifically enable list all files Reproducible: Always User Profile Reset: No Additional Info: List only files relevant to the active application. -- You are receiving this mail because: You are the assignee for the bug.
core.git: editeng/source sc/qa
editeng/source/editeng/impedit3.cxx | 52 +-
sc/qa/extras/scpdfexport.cxx | 60 +++
sc/qa/extras/testdocuments/tdf159065.ods |binary
3 files changed, 94 insertions(+), 18 deletions(-)
New commits:
commit 4202218af61573825edfe5ec5a1bba710d7df1f7
Author: Tibor Nagy
AuthorDate: Tue Jan 9 23:54:43 2024 +0100
Commit: Nagy Tibor
CommitDate: Wed Jan 10 08:49:29 2024 +0100
tdf#159065 sc: fix PDF/UA link annotation
Change-Id: I1586608780cc82908eaef62158887afee69c148f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161843
Tested-by: Jenkins
Reviewed-by: Nagy Tibor
diff --git a/editeng/source/editeng/impedit3.cxx
b/editeng/source/editeng/impedit3.cxx
index d50c2eb1338e..bc93802694fd 100644
--- a/editeng/source/editeng/impedit3.cxx
+++ b/editeng/source/editeng/impedit3.cxx
@@ -3855,6 +3855,25 @@ void ImpEditEngine::Paint( OutputDevice& rOutDev,
tools::Rectangle aClipRect, Po
' ' == aText[nTextStart +
nTextLen - 1] )
--nTextLen;
+// PDF export:
+const SvxFieldData* pFieldData =
nullptr;
+if (pPDFExtOutDevData)
+{
+if (rTextPortion.GetKind() ==
PortionKind::FIELD)
+{
+const EditCharAttrib* pAttr =
pPortion->GetNode()->GetCharAttribs().FindFeature(nIndex);
+const SvxFieldItem* pFieldItem
= dynamic_cast(pAttr->GetItem());
+if (pFieldItem)
+{
+pFieldData =
pFieldItem->GetField();
+auto pUrlField =
dynamic_cast(pFieldData);
+if (pUrlField)
+if
(pPDFExtOutDevData->GetIsExportTaggedPDF())
+
pPDFExtOutDevData->WrapBeginStructureElement(vcl::PDFWriter::Link, "Link");
+}
+}
+}
+
// output directly
aTmpFont.QuickDrawText( ,
aRealOutPos, aText, nTextStart, nTextLen, pDXArray, pKashidaArray );
@@ -3869,27 +3888,24 @@ void ImpEditEngine::Paint( OutputDevice& rOutDev,
tools::Rectangle aClipRect, Po
}
// PDF export:
-if ( pPDFExtOutDevData )
+if (pPDFExtOutDevData)
{
-if ( rTextPortion.GetKind() ==
PortionKind::FIELD )
+if (auto pUrlField =
dynamic_cast(pFieldData))
{
-const EditCharAttrib* pAttr =
pPortion->GetNode()->GetCharAttribs().FindFeature(nIndex);
-const SvxFieldItem* pFieldItem
= dynamic_cast(pAttr->GetItem());
-if( pFieldItem )
+Point aTopLeft(aTmpPos);
+
aTopLeft.AdjustY(-(pLine->GetMaxAscent()));
+
+tools::Rectangle
aRect(aTopLeft, rTextPortion.GetSize());
+vcl::PDFExtOutDevBookmarkEntry
aBookmark;
+aBookmark.nLinkId =
pPDFExtOutDevData->CreateLink(aRect, pUrlField->GetRepresentation());
+aBookmark.aBookmark =
pUrlField->GetURL();
+std::vector<
vcl::PDFExtOutDevBookmarkEntry >& rBookmarks =
pPDFExtOutDevData->GetBookmarks();
+
rBookmarks.push_back(aBookmark);
+
+if
(pPDFExtOutDevData->GetIsExportTaggedPDF())
{
-const SvxFieldData*
pFieldData = pFieldItem->GetField();
-if ( auto pUrlField =
dynamic_cast< const SvxURLField* >( pFieldData ) )
-{
-
[Bug 159096] New: Comment indicator in Calc should be red, not magenta
https://bugs.documentfoundation.org/show_bug.cgi?id=159096 Bug ID: 159096 Summary: Comment indicator in Calc should be red, not magenta Product: LibreOffice Version: 24.8.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Comment indicator in Calc should be red, not magenta Steps to Reproduce: 1. Open Calc 2. Insert a comment 3. Close the comment box Actual Results: Magenta Expected Results: Red A) I'm unable to find the rationale behind the change, if this being a design decision on purpose B) Some arguments against * It's changing a long established default in LO * It doesn't match competition * Is inconsistent: red is used the accentuate something. Like - the red squiggly lines under misspelled words. - The red arrow indicator if text frame containing more (hidden) text because smaller frame size (Frame with AutoSize turned off) A comment act the same way, but needs a different color? * The contrast of purple against white is less. Red pops out. The current color doesn't (more eye strain finding comments) * Color tends appears to shift visually (yellow cell background + comment indicator at zoom 65% appears more reddish to me) * It doesn't really match with various cell background colors (in my opinion) * The magenta color rendering more affected by variation from display to display. Hue, brightness, contrast. Reproducible: Always User Profile Reset: No Additional Info: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 40617d867346956588ac023511f31210107217f4 CPU threads: 8; OS: macOS 13.6.3; UI render: default; VCL: osx Locale: nl-NL (nl_NL.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
core.git: sw/inc sw/source
sw/inc/numrule.hxx|2 +-
sw/source/core/attr/swatrset.cxx |2 +-
sw/source/core/doc/DocumentSettingManager.cxx |2 +-
sw/source/core/doc/docfmt.cxx |2 +-
sw/source/core/doc/docnum.cxx |8
sw/source/core/doc/number.cxx |6 +++---
sw/source/core/docnode/node.cxx |2 +-
sw/source/core/docnode/nodes.cxx |2 +-
sw/source/filter/html/htmlgrin.cxx|2 +-
sw/source/filter/html/htmlnumreader.cxx |4 ++--
10 files changed, 16 insertions(+), 16 deletions(-)
New commits:
commit 8aeddf624dca4a34a4f2cf84c32cab0c99ef4db8
Author: Mike Kaganski
AuthorDate: Wed Jan 10 11:13:05 2024 +0600
Commit: Mike Kaganski
CommitDate: Wed Jan 10 08:27:04 2024 +0100
SwNumRule: SetInvalidRule(bool) -> Invalidate()
It should only be validated using Validate().
In SwHTMLParser::SetNodeNum, it was setting the "invalid" flag to false,
while the comment was telling the opposite. It was this way since commit
7b0b5cdfeed656b279bc32cd929630d5fc25878b (initial import, 2000-09-18).
It seems that the call could be safely removed (it looks wrong to set it
valid forcefully; but then, if it worked, why change it?); but first,
let's change it to what the comment says, and see if something fixes
magically.
In fact, it also seems wrong to invalidate it explicitly from outer code:
other setters should do it automatically; TODO/LATER.
Change-Id: I0efb01434f77a53494272745e93482bb21612351
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161849
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sw/inc/numrule.hxx b/sw/inc/numrule.hxx
index af0655272936..aaa09236c8e4 100644
--- a/sw/inc/numrule.hxx
+++ b/sw/inc/numrule.hxx
@@ -232,7 +232,7 @@ public:
void SetAutoRule( bool bFlag ) { mbAutoRuleFlag = bFlag; }
bool IsInvalidRule() const { return mbInvalidRuleFlag; }
-void SetInvalidRule(bool bFlag) { mbInvalidRuleFlag = bFlag; }
+void Invalidate() { mbInvalidRuleFlag = true; }
bool IsContinusNum() const { return mbContinusNum; }
void SetContinusNum( bool bFlag ) { mbContinusNum = bFlag; }
diff --git a/sw/source/core/attr/swatrset.cxx b/sw/source/core/attr/swatrset.cxx
index fc4612757dcc..c0155317c76e 100644
--- a/sw/source/core/attr/swatrset.cxx
+++ b/sw/source/core/attr/swatrset.cxx
@@ -396,7 +396,7 @@ void SwAttrSet::CopyToModify( sw::BroadcastingModify& rMod
) const
{
SwNumRule* pDestRule = pDstDoc->FindNumRulePtr( rNm );
if( pDestRule )
-pDestRule->SetInvalidRule( true );
+pDestRule->Invalidate();
else
pDstDoc->MakeNumRule( rNm, pSrcDoc->FindNumRulePtr(
rNm ) );
}
diff --git a/sw/source/core/doc/DocumentSettingManager.cxx
b/sw/source/core/doc/DocumentSettingManager.cxx
index 355b704a3a05..81079008b023 100644
--- a/sw/source/core/doc/DocumentSettingManager.cxx
+++ b/sw/source/core/doc/DocumentSettingManager.cxx
@@ -300,7 +300,7 @@ void sw::DocumentSettingManager::set(/*[in]*/
DocumentSettingId id, /*[in]*/ boo
const SwNumRuleTable& rNmTable = m_rDoc.GetNumRuleTable();
for( SwNumRuleTable::size_type n = 0; n < rNmTable.size(); ++n
)
-rNmTable[n]->SetInvalidRule(true);
+rNmTable[n]->Invalidate();
m_rDoc.UpdateNumRule();
diff --git a/sw/source/core/doc/docfmt.cxx b/sw/source/core/doc/docfmt.cxx
index 21a4da06dc6b..26a9e2a5f69a 100644
--- a/sw/source/core/doc/docfmt.cxx
+++ b/sw/source/core/doc/docfmt.cxx
@@ -1229,7 +1229,7 @@ SwTextFormatColl* SwDoc::CopyTextColl( const
SwTextFormatColl& rColl )
{
SwNumRule* pDestRule = FindNumRulePtr( rName );
if( pDestRule )
-pDestRule->SetInvalidRule( true );
+pDestRule->Invalidate();
else
MakeNumRule( rName, pRule );
}
diff --git a/sw/source/core/doc/docnum.cxx b/sw/source/core/doc/docnum.cxx
index 0735380e5dc2..1c7d1792abe5 100644
--- a/sw/source/core/doc/docnum.cxx
+++ b/sw/source/core/doc/docnum.cxx
@@ -156,7 +156,7 @@ void SwDoc::SetOutlineNumRule( const SwNumRule& rRule )
}
PropagateOutlineRule();
-mpOutlineRule->SetInvalidRule(true);
+mpOutlineRule->Invalidate();
UpdateNumRule();
// update if we have foot notes && numbering by chapter
@@ -825,7 +825,7 @@ static void lcl_ChgNumRule( SwDoc& rDoc, const SwNumRule&
rRule )
if ( bInvalidateNumRule )
{
-pOld->SetInvalidRule(true);
+pOld->Invalidate();
}
return ;
@@ -852,7 +852,7 @@ static void lcl_ChgNumRule(
[Bug 155364] Forms - Table controls: Buttons in the Navigation bar get smaller when zooming form
https://bugs.documentfoundation.org/show_bug.cgi?id=155364 --- Comment #5 from Robert Großkopf --- Created attachment 191835 --> https://bugs.documentfoundation.org/attachment.cgi?id=191835=edit Open the form. Switch Zoom by Ctrl+Mousewheel Form shows the different navigation bar bugs. This bug is for tablecontrol only: have a look at the buttons at the button of the tablecontrol. Zooming in will show them higher and higher, but the width won't be zoomed. This bug doesn't happen in LO 7.0.5.2 on OpenSUSE here. The other bug, not mentioned here and not a regression: Navigation bar of the navigation bar control will always show the graphic buttons with the same height. Zooming wont show any changing here, so sometimes buttons are very small (zooming greater than 100%) ore aren't available, because the control is to small (zooming less than 80%). -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159089] Changing an object color in Draw or Impress crashes LO
https://bugs.documentfoundation.org/show_bug.cgi?id=159089 --- Comment #6 from Telesto --- *** Bug 159090 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159090] Changing a slide layout using the toolbar crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=159090 Telesto changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #3 from Telesto --- The crash log suggests the same cause as for bug 159089. Lets close this as duplicate for now *** This bug has been marked as a duplicate of bug 159089 *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159095] Extremely Slow
https://bugs.documentfoundation.org/show_bug.cgi?id=159095 Buovjaga changed: What|Removed |Added CC||ilmari.lauhakangas@libreoff ||ice.org Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from Buovjaga --- Please copy and paste here the contents of your Help - About (LibreOffice - About on macOS) by clicking the copy button. This allows us to know more about your system. Set to NEEDINFO. Change back to UNCONFIRMED after you have provided the information. -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'distro/vector/vector-7.5.9' - sw/qa sw/source
sw/qa/uitest/writer_tests7/tdf144439.py | 22
sw/source/core/doc/number.cxx | 35 +---
2 files changed, 37 insertions(+), 20 deletions(-)
New commits:
commit 6ecf8fbb2c2422df78b55acaa436ee14a3dca4b6
Author: Noel Grandin
AuthorDate: Tue Dec 19 11:40:24 2023 +0200
Commit: Mike Kaganski
CommitDate: Wed Jan 10 10:29:36 2024 +0600
tdf#154864 Changing starting number of numbered list does nothing
regression from
commit cd3c16fbcb4f8e5e4c4448bc7cda96e8476d6aec
Author: Noel Grandin
Date: Fri Oct 14 15:14:13 2022 +0200
tdf#129101 CTRL+A & Cut very slow
avoid repeated invalidation of number tree, shaves 90% time off
The problem is that, after the above change, InvalidateListTree is not
called late enough to force invalidation of all necessary stuff.
So simply delay that until we do re-validation in SwNumRule::Validate.
Change-Id: I796cc34fe7d66d4876ee06286a8af7029a759eca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160974
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/qa/uitest/writer_tests7/tdf144439.py
b/sw/qa/uitest/writer_tests7/tdf144439.py
index 34911ee4c542..4d0ce465d5ac 100644
--- a/sw/qa/uitest/writer_tests7/tdf144439.py
+++ b/sw/qa/uitest/writer_tests7/tdf144439.py
@@ -40,6 +40,28 @@ class tdf144439(UITestCase):
self.assertEqual(Para1.String, "List item")
self.assertEqual(Para1.getPropertyValue("ListLabelString"), "1.1.")
+# this section is checking tdf#154864 - Changing starting number
of numbered list does nothing
+#
+
+with
self.ui_test.execute_dialog_through_command(".uno:BulletsAndNumberingDialog")
as xDialog:
+# Select custom tab
+xTabs = xDialog.getChild("tabcontrol")
+select_pos(xTabs, "5")
+
+# Select numbering
+xNumFmt = xDialog.getChild("numfmtlb")
+select_by_text(xNumFmt, "1, 2, 3, ...")
+
+# Increase "start at"
+xStartAt = xDialog.getChild("startat")
+xStartAt.executeAction("UP", tuple())
+xStartAt.executeAction("UP", tuple())
+
+Paragraphs = document.Text.createEnumeration()
+Para1 = Paragraphs.nextElement()
+self.assertEqual(Para1.String, "List item")
+self.assertEqual(Para1.getPropertyValue("ListLabelString"), "1.3.")
+
def test_tdf144439_outline(self):
with self.ui_test.create_doc_in_start_center("writer") as document:
xWriterDoc = self.xUITest.getTopFocusWindow()
diff --git a/sw/source/core/doc/number.cxx b/sw/source/core/doc/number.cxx
index f953a93dbde4..2753bc44b26c 100644
--- a/sw/source/core/doc/number.cxx
+++ b/sw/source/core/doc/number.cxx
@@ -153,10 +153,17 @@ void SwNumRule::RemoveTextNode( SwTextNode& rTextNode )
{
tTextNodeList::iterator aIter =
std::find( maTextNodeList.begin(), maTextNodeList.end(), );
+if ( aIter == maTextNodeList.end() )
+return;
-if ( aIter != maTextNodeList.end() )
+maTextNodeList.erase( aIter );
+
+// Just in case we remove a node after we have marked the rule invalid,
but before we have validated the tree
+if (mbInvalidRuleFlag)
{
-maTextNodeList.erase( aIter );
+SwList* pList =
rTextNode.GetDoc().getIDocumentListsAccess().getListByName(
rTextNode.GetListId() );
+if (pList)
+pList->InvalidateListTree();
}
}
@@ -960,23 +967,6 @@ void SwNumRule::SetInvalidRule(bool bFlag)
if (mbInvalidRuleFlag == bFlag)
return;
-if (bFlag)
-{
-o3tl::sorted_vector< SwList* > aLists;
-for ( const SwTextNode* pTextNode : maTextNodeList )
-{
-// #i111681# - applying patch from cmc
-SwList* pList =
pTextNode->GetDoc().getIDocumentListsAccess().getListByName(
pTextNode->GetListId() );
-OSL_ENSURE( pList, " - list at
which the text node is registered at does not exist. This is a serious issue.");
-if ( pList )
-{
-aLists.insert( pList );
-}
-}
-for ( auto aList : aLists )
-aList->InvalidateListTree();
-}
-
mbInvalidRuleFlag = bFlag;
}
@@ -1077,8 +1067,13 @@ void SwNumRule::Validate(const SwDoc& rDoc)
o3tl::sorted_vector< SwList* > aLists;
for ( const SwTextNode* pTextNode : maTextNodeList )
{
-aLists.insert(
pTextNode->GetDoc().getIDocumentListsAccess().getListByName(
pTextNode->GetListId() ) );
+SwList* pList =
pTextNode->GetDoc().getIDocumentListsAccess().getListByName(
pTextNode->GetListId() );
+aLists.insert( pList );
}
+
+for ( auto aList : aLists )
+aList->InvalidateListTree();
+
for ( auto aList : aLists )
core.git: sw/inc sw/source
sw/inc/numrule.hxx|2 +-
sw/source/core/doc/number.cxx |8
2 files changed, 1 insertion(+), 9 deletions(-)
New commits:
commit a924532c27d6b745ebf4d6959083fb02ad3493b0
Author: Mike Kaganski
AuthorDate: Wed Jan 10 10:35:47 2024 +0600
Commit: Mike Kaganski
CommitDate: Wed Jan 10 06:48:02 2024 +0100
Simplify a bit
Change-Id: I62ed68b943584b647c9e1ea78720151f26424665
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161848
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sw/inc/numrule.hxx b/sw/inc/numrule.hxx
index 20ac33bbfc60..af0655272936 100644
--- a/sw/inc/numrule.hxx
+++ b/sw/inc/numrule.hxx
@@ -232,7 +232,7 @@ public:
void SetAutoRule( bool bFlag ) { mbAutoRuleFlag = bFlag; }
bool IsInvalidRule() const { return mbInvalidRuleFlag; }
-void SetInvalidRule( bool bFlag );
+void SetInvalidRule(bool bFlag) { mbInvalidRuleFlag = bFlag; }
bool IsContinusNum() const { return mbContinusNum; }
void SetContinusNum( bool bFlag ) { mbContinusNum = bFlag; }
diff --git a/sw/source/core/doc/number.cxx b/sw/source/core/doc/number.cxx
index 93265bca2fa2..8b7b22059467 100644
--- a/sw/source/core/doc/number.cxx
+++ b/sw/source/core/doc/number.cxx
@@ -1053,14 +1053,6 @@ SvxNumRule SwNumRule::MakeSvxNumRule() const
return aRule;
}
-void SwNumRule::SetInvalidRule(bool bFlag)
-{
-if (mbInvalidRuleFlag == bFlag)
-return;
-
-mbInvalidRuleFlag = bFlag;
-}
-
/// change indent of all list levels by given difference
void SwNumRule::ChangeIndent( const sal_Int32 nDiff )
{
[Bug 159095] New: Extremely Slow
https://bugs.documentfoundation.org/show_bug.cgi?id=159095 Bug ID: 159095 Summary: Extremely Slow Product: LibreOffice Version: 7.6.4.1 release Hardware: Other OS: macOS (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: macleansem...@gmail.com Description: The last two updates to LibreOffice have been extremely slow; not just slow, but almost ot responding. It does finally go. This applies to loading the code as well as clicking menus or selecting actions or cells. The most current version with this problem is 7.6.4.1 running on my 2019 Mac M1 Mini. I had the same problem with the last "stable" release before this version. Previous versions (not sure how many updates I missed) were fine. If this is not fixed, LibreOffice will be of no use to me. Steps to Reproduce: 1.Start the LibreOffice application. 2. 3. Actual Results: Extremeley slow (long time) to open. Expected Results: Quick start. Reproducible: Always User Profile Reset: Yes Additional Info: Not useable in current state. -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'distro/collabora/co-23.05' - sc/source
sc/source/core/data/column2.cxx |2 ++
sc/source/ui/view/output2.cxx |4 +++-
2 files changed, 5 insertions(+), 1 deletion(-)
New commits:
commit 606537da38eca6077a0c6ec7d82ca31c92b7e3a6
Author: Caolán McNamara
AuthorDate: Fri Jan 5 13:23:31 2024 +
Commit: Tomaž Vajngerl
CommitDate: Wed Jan 10 05:17:33 2024 +0100
Resolves: tdf#158997 optimal col width too narrow to render text
optimal is measured with kerning on, while text is rendered with
kerning off
possibly a problem since:
commit 36eed54d3dfed6551fd2ad944feff7e217c56e82
Date: Tue Jul 3 15:00:26 2018 +0200
Resolves: tdf#118221 whole cell kerning default is off
Change-Id: I0e6de75a89823f6ed58a74782e47feb0a44014e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161678
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Tomaž Vajngerl
diff --git a/sc/source/core/data/column2.cxx b/sc/source/core/data/column2.cxx
index 3abb568befbc..f4b0ce18410f 100644
--- a/sc/source/core/data/column2.cxx
+++ b/sc/source/core/data/column2.cxx
@@ -283,6 +283,7 @@ tools::Long ScColumn::GetNeededSize(
{
Fraction aFontZoom = ( eOrient == SvxCellOrientation::Standard ) ?
rZoomX : rZoomY;
vcl::Font aFont;
+aFont.SetKerning(FontKerning::NONE); // like
ScDrawStringsVars::SetPattern
// font color doesn't matter here
pPattern->fillFontOnly(aFont, pDev, , pCondSet, nScript);
pDev->SetFont(aFont);
@@ -754,6 +755,7 @@ sal_uInt16 ScColumn::GetOptimalColWidth(
SCROW nRow = 0;
const ScPatternAttr* pPattern = GetPattern( nRow );
vcl::Font aFont;
+aFont.SetKerning(FontKerning::NONE); // like
ScDrawStringsVars::SetPattern
// font color doesn't matter here
pPattern->fillFontOnly(aFont, pDev, );
pDev->SetFont(aFont);
diff --git a/sc/source/ui/view/output2.cxx b/sc/source/ui/view/output2.cxx
index 9b325a5dbe82..8f59a529fa93 100644
--- a/sc/source/ui/view/output2.cxx
+++ b/sc/source/ui/view/output2.cxx
@@ -407,7 +407,9 @@ void ScDrawStringsVars::SetPattern(
// There is no cell attribute for kerning, default is kerning OFF, all
// kerning is stored at an EditText object that is drawn using EditEngine.
-aFont.SetKerning( FontKerning::NONE);
+// See also matching kerning cases in ScColumn::GetNeededSize and
+// ScColumn::GetOptimalColWidth.
+aFont.SetKerning(FontKerning::NONE);
pDev->SetFont( aFont );
if ( pFmtDevice != pDev )
[Bug 159076] Invalid database range if data filtered
https://bugs.documentfoundation.org/show_bug.cgi?id=159076 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159074] Page Style does not get saved
https://bugs.documentfoundation.org/show_bug.cgi?id=159074 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159076] Invalid database range if data filtered
https://bugs.documentfoundation.org/show_bug.cgi?id=159076 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158874] Want MS-Word like auto-formatting of beginning of list item
https://bugs.documentfoundation.org/show_bug.cgi?id=158874 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159074] Page Style does not get saved
https://bugs.documentfoundation.org/show_bug.cgi?id=159074 --- Comment #7 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Bug 61963] UI: 'Group and Outline' impossible with active Filter
https://bugs.documentfoundation.org/show_bug.cgi?id=61963 --- Comment #13 from QA Administrators --- Dear Rainer Bielefeld Retired, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158840] In libreoffice writer, i want to insert cross reference of a numbered paragraph with out the before and after fields
https://bugs.documentfoundation.org/show_bug.cgi?id=158840 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158840] In libreoffice writer, i want to insert cross reference of a numbered paragraph with out the before and after fields
https://bugs.documentfoundation.org/show_bug.cgi?id=158840 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156259] LibreOffice Writer sometimes creates blank pages at the end of a file
https://bugs.documentfoundation.org/show_bug.cgi?id=156259 --- Comment #3 from QA Administrators --- Dear lanedvt, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Bug 145789] PDF import: Kaplan-Meier survival curves not properly captured
https://bugs.documentfoundation.org/show_bug.cgi?id=145789 --- Comment #3 from QA Administrators --- Dear Alberto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 116828] edit comments are done in place when there are frozen columns, making it invisible
https://bugs.documentfoundation.org/show_bug.cgi?id=116828 --- Comment #8 from QA Administrators --- Dear pajaro, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158112] Sidebar pane shortcuts conflict with Alt+NumPad input (comment 5, comment 9)
https://bugs.documentfoundation.org/show_bug.cgi?id=158112 Shantanu changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||0847 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158556] DOCX Document That Opens/Loads Extremely Slowly
https://bugs.documentfoundation.org/show_bug.cgi?id=158556 --- Comment #11 from Mike Kaganski --- (In reply to Tex2002ans from comment #10) > On 24.8.0.0alpha0 (2024-01-06 02:53:39), it took: > > - 7 mins 49 secs > > for first paint... so about 25% better load speed for me. Heh, it basically matches my findings - from the commit message: LibreOffice 7.6.0.3 (TDF build): real8m37.386s Current master (my no-debug build): real10m6.776s Current master with this patch (my no-debug build): real5m41.524s ... so when I wrote "almost twice as fast", I only compared "immediately before the patch vs. after the patch", and something additionally slowed down the things between 7.6.0.3 and master ... > > I guess, that that aspect (unrelated to the opening time regression) needs > > an own report, where it could be handled independently. > > Should we treat Ctrl+End (then Page Up) as 2 separate performance bugs? Or > just submit them as 1? Please file it as a single bug. If that proves later to be different things, of course it might require a third one - but that's never a problem to do later :-D -- You are receiving this mail because: You are the assignee for the bug.
core.git: editeng/source
editeng/source/editeng/editdoc.cxx |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
New commits:
commit 89b9302ccf870c4fdbc1071751536b80429a7d27
Author: Tomaž Vajngerl
AuthorDate: Fri Jan 5 11:59:46 2024 +0900
Commit: Tomaž Vajngerl
CommitDate: Wed Jan 10 03:40:40 2024 +0100
editeng: move for loop to range based
Change-Id: I6d997d6315f8d5043de33fe43b6aaabf5bef7cdd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161820
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/editeng/source/editeng/editdoc.cxx
b/editeng/source/editeng/editdoc.cxx
index efc95b944833..7dbee3890a6c 100644
--- a/editeng/source/editeng/editdoc.cxx
+++ b/editeng/source/editeng/editdoc.cxx
@@ -892,11 +892,10 @@ void EditDoc::CreateDefFont( bool bUseStyles )
maDefFont.SetVertical( IsEffectivelyVertical() );
maDefFont.SetOrientation( Degree10(IsEffectivelyVertical() ?
(IsTopToBottom() ? 2700 : 900) : 0) );
-for ( sal_Int32 nNode = 0; nNode < Count(); nNode++ )
+for (std::unique_ptr& pNode : maContents)
{
-ContentNode* pNode = GetObject( nNode );
pNode->GetCharAttribs().GetDefFont() = maDefFont;
-if ( bUseStyles )
+if (bUseStyles)
pNode->CreateDefFont();
}
}
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
5 new defect(s) introduced to LibreOffice found with Coverity Scan.
147 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 5 of 5 defect(s)
** CID 1583748:(FORWARD_NULL)
*** CID 1583748:(FORWARD_NULL)
/sc/source/ui/app/inputhdl.cxx: 3864 in ScInputHandler::KeyInput(const KeyEvent
&, bool)()
3858
3859 if (pActiveViewSh)
3860 pActiveViewSh->MoveCursorEnter( bShift &&
!bControl );
3861
3862 ScModule* pScMod = SC_MOD();
3863 const ScInputOptions& rOpt = pScMod->GetInputOptions();
>>> CID 1583748:(FORWARD_NULL)
>>> Passing null pointer "this->pActiveViewSh" to "GetMoveKeepEdit", which
>>> dereferences it.
3864 if ( (rOpt.GetMoveKeepEdit() &&
!comphelper::LibreOfficeKit::isActive())
3865 || (pActiveViewSh->GetMoveKeepEdit() &&
comphelper::LibreOfficeKit::isActive()) )
3866 pScMod->SetInputMode( SC_INPUT_TABLE );
3867
3868 bUsed = true;
3869 }
/sc/source/ui/app/inputhdl.cxx: 3818 in ScInputHandler::KeyInput(const KeyEvent
&, bool)()
3812 if (pActiveViewSh)
3813 pActiveViewSh->FindNextUnprot( bShift, true );
3814
3815 ScModule* pScMod = SC_MOD();
3816 const ScInputOptions& rOpt = pScMod->GetInputOptions();
3817
>>> CID 1583748:(FORWARD_NULL)
>>> Passing null pointer "this->pActiveViewSh" to "GetMoveKeepEdit", which
>>> dereferences it.
3818 if ( (rOpt.GetMoveKeepEdit() &&
!comphelper::LibreOfficeKit::isActive())
3819 || (pActiveViewSh->GetMoveKeepEdit() &&
comphelper::LibreOfficeKit::isActive()) )
3820 pScMod->SetInputMode( SC_INPUT_TABLE );
3821
3822 return true;
3823 }
** CID 1583747: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/basctl/source/basicide/baside2.cxx: 1559 in
basctl::ModulWindowLayout::ApplyColorSchemeToCurrentWindow(rtl::OUString)()
*** CID 1583747: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/basctl/source/basicide/baside2.cxx: 1559 in
basctl::ModulWindowLayout::ApplyColorSchemeToCurrentWindow(rtl::OUString)()
1553
1554 // Applies the color scheme to the current window and updates color
definitions;
1555 // note that other ModulWindow instances are not affected by calling
this method
1556 void ModulWindowLayout::ApplyColorSchemeToCurrentWindow(OUString
aSchemeId)
1557 {
1558 // Apply new color scheme to the UI
>>> CID 1583747: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "aSchemeId" is copied in a call to copy assignment "operator =", when
>>> it could be moved instead.
1559 m_sColorSchemeId = aSchemeId;
1560 aSyntaxColors.ApplyColorScheme(m_sColorSchemeId, false);
1561 }
1562
1563 ModulWindowLayout::SyntaxColors::SyntaxColors ()
1564 : pEditor(nullptr)
** CID 1583746: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/basctl/source/basicide/ColorSchemeDialog.cxx: 37 in
basctl::ColorSchemeDialog::ColorSchemeDialog(weld::Window *,
VclPtr)()
*** CID 1583746: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/basctl/source/basicide/ColorSchemeDialog.cxx: 37 in
basctl::ColorSchemeDialog::ColorSchemeDialog(weld::Window *,
VclPtr)()
31
32 namespace basctl
33 {
34 ColorSchemeDialog::ColorSchemeDialog(weld::Window* pParent,
35 VclPtr
pModulWinLayout)
36 : GenericDialogController(pParent,
"modules/BasicIDE/ui/colorscheme.ui", "ColorSchemeDialog")
>>> CID 1583746: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "pModulWinLayout" is copied in call to copy constructor
>>> "VclPtr", when it could be moved instead.
37 , m_pModulWinLayout(pModulWinLayout)
38 , m_xSchemeList(m_xBuilder->weld_tree_view("schemelist"))
39 , m_xUseAppCollors(m_xBuilder->weld_radio_button("opt_appcolors"))
40 , m_xUseScheme(m_xBuilder->weld_radio_button("opt_usescheme"))
41 , m_xOk(m_xBuilder->weld_button("btn_ok"))
42 {
** CID 1583745: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/basctl/source/basicide/baside2.hxx: 451 in
basctl::ModulWindowLayout::SyntaxColors::SetActiveColorSchemeId(rtl::OUString)()
[Bug 36310] [EDITING]"Insert cross-reference" drag-n-drop mode for navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=36310 --- Comment #28 from Jim Raykowski --- Created attachment 191834 --> https://bugs.documentfoundation.org/attachment.cgi?id=191834=edit Demo of cross-reference drag-n-drop popup approach for heading, bookmark, footnote and endnote content Attached is a demo of patchset 4: https://gerrit.libreoffice.org/c/core/+/161575/4 Still to be done, is to make it work for content objects with captions. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 159090] Changing a slide layout using the toolbar crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=159090 Patrick Luby changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #2 from Patrick Luby --- I can reproduce the crash in my local master build. My crash log is in attachment https://bugs.documentfoundation.org/attachment.cgi?id=191833 but I will need to do more debugging to see if I can find the cause of this crash. Version: 24.8.0.0.alpha0+ (AARCH64) / LibreOffice Community Build ID: ef6ff2df2e1286974da2f344aa3b8e3ae9093a79 CPU threads: 8; OS: macOS 14.2.1; UI render: Skia/Metal; VCL: osx Locale: en-CA (en_CA.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159090] Changing a slide layout using the toolbar crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=159090 Patrick Luby changed: What|Removed |Added CC||plub...@libreoffice.org --- Comment #1 from Patrick Luby --- Created attachment 191833 --> https://bugs.documentfoundation.org/attachment.cgi?id=191833=edit macOS crash log -- You are receiving this mail because: You are the assignee for the bug.
[Bug 155364] Forms - Table controls: Buttons in the Navigation bar get smaller when zooming form
https://bugs.documentfoundation.org/show_bug.cgi?id=155364 --- Comment #4 from George --- (In reply to raal from comment #3) > Please can you attach some test base file? Thank you. My Base attachment (Breaker box.odb) was not accepted. Either I'm not sure exactly what you are asking for, or I'm doing it incorrectly. A more detailed request would be helpful. Thank you. George Turner -- You are receiving this mail because: You are the assignee for the bug.
questions regarding of-pie chart work
I've been working on support for bar-of-pie and pie-of-pie charts. Related bug is here: https://bugs.documentfoundation.org/show_bug.cgi?id=50934 and gerrit page for my preliminary implementation is here: https://gerrit.libreoffice.org/c/core/+/160742 (feedback welcome!) I have several questions about how to take this further. It seems like the bug page and gerrit aren't the right places for discussing these, so I'm raising them here. - I've implemented OOXML import/export, but not ODF import/export because ODF doesn't support of-pie charts. The spec [19.15] does say: "Additional chart types may be supported by using a different namespace." But I'm not sure what that really means. Are there examples of this already? - I made various UI choices that may not be best. For instance, I added pie-of-pie and bar-of-pie as subtypes of pie in the chart selection matrix (widening it to 6 columns). It might be preferable to keep of-pie as a different chart type (adding a row instead of two columns). I also made arbitrary decisions about sizes and separation of the two chart parts in the rendering. It appears there's a UI group that meets. Are these choices the kind of things that could be put on their agenda? - In the selection matrix mentioned above I added crude placeholder graphics that I created just by taking a screenshot of representative of-pie charts. But they look nothing like the graphics for the other chart types. Is there some prescribed process (or person) for creating uniform-looking UI graphics? Thanks for any input you can provide. Kurt Nordback
[Bug 159076] Invalid database range if data filtered
https://bugs.documentfoundation.org/show_bug.cgi?id=159076 --- Comment #3 from haribarusemangatb...@gmail.com --- (In reply to m_a_riosv from comment #1) > Please attach your sample file. How to attach an xlsx file? If copying to *.txt format, there will be no database range -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159076] Invalid database range if data filtered
https://bugs.documentfoundation.org/show_bug.cgi?id=159076 --- Comment #2 from haribarusemangatb...@gmail.com --- How to attach an xlsx file? If copying to *.txt format, there will be no database range -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159089] Changing an object color in Draw or Impress crashes LO
https://bugs.documentfoundation.org/show_bug.cgi?id=159089 Patrick Luby changed: What|Removed |Added CC||plub...@libreoffice.org Status|NEEDINFO|NEW --- Comment #5 from Patrick Luby --- I can reproduce the crash in my local master build. My crash log is in attachment https://bugs.documentfoundation.org/attachment.cgi?id=191832 but I will need to do more debugging to see if I can find the cause of this crash. Version: 24.8.0.0.alpha0+ (AARCH64) / LibreOffice Community Build ID: ef6ff2df2e1286974da2f344aa3b8e3ae9093a79 CPU threads: 8; OS: macOS 14.2.1; UI render: Skia/Metal; VCL: osx Locale: en-CA (en_CA.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159089] Changing an object color in Draw or Impress crashes LO
https://bugs.documentfoundation.org/show_bug.cgi?id=159089 --- Comment #4 from Patrick Luby --- Created attachment 191832 --> https://bugs.documentfoundation.org/attachment.cgi?id=191832=edit macOS crash log -- You are receiving this mail because: You are the assignee for the bug.
[Bug 57128] 3D Slide Transitions are broken.
https://bugs.documentfoundation.org/show_bug.cgi?id=57128 --- Comment #26 from Petr Valach --- (In reply to Lucas J from comment #24) > Can confirm this problem is still reproducable in 7.4.1.2 on both Windows 10 > and Linux Mint (X11). All of the 3D animations are broken, but 2D ones seem > to be fine. I disagree with other comments that the feature should be turned > off. It is a critical feature that needs to be fixed and removing it would > be a huge step backwards. If anything, let it remain on the todo list until > there is proper funding or someone who understands the code steps in. > > Version: 7.4.1.2 / LibreOffice Community > Build ID: 3c58a8f3a960df8bc8fd77b461821e42c061c5f0 > CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: kf5 (cairo+xcb) > Locale: en-US (en_US.UTF-8); UI: en-US > Calc: threaded Confirm this situation and agree with LucasJ. Version: 7.6.4.1 (X86_64) / LibreOffice Community Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1 CPU threads: 12; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: CL threaded Operating System: Linux Mint 21.2 KDE Plasma Version: 5.24.7 KDE Frameworks Version: 5.92.0 Qt Version: 5.15.3 Kernel Version: 5.15.0-91-generic (64-bit) Graphics Platform: X11 Processors: 12 × AMD Ryzen 5 3600 6-Core Processor Memory: 15.5 GiB of RAM Graphics Processor: NVIDIA GeForce GTX 970/PCIe/SSE2 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158937] Crash when pressing cancel in the insert password dialog when recovering a file (swlo!SwDocShell::SetModified+4b)
https://bugs.documentfoundation.org/show_bug.cgi?id=158937 Matt K changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |matt...@gmail.com |desktop.org | Status|NEW |ASSIGNED --- Comment #4 from Matt K --- Fix is posted at: https://gerrit.libreoffice.org/c/core/+/161844 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159094] FILESAVE PDF Tagged PDF export of media file fails to create PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=159094 Gabor Kelemen (allotropia) changed: What|Removed |Added Keywords||bibisected, bisected, ||regression Regression By||Michael Stahl CC||tibor.nagy.extern@allotropi ||a.de -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159094] FILESAVE PDF Tagged PDF export of media file fails to create PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=159094 --- Comment #1 from Gabor Kelemen (allotropia) --- Created attachment 191831 --> https://bugs.documentfoundation.org/attachment.cgi?id=191831=edit PDF export settings to trigger the bug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 139007] [META] PDF accessibility
https://bugs.documentfoundation.org/show_bug.cgi?id=139007 Gabor Kelemen (allotropia) changed: What|Removed |Added Depends on||159094 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=159094 [Bug 159094] FILESAVE PDF Tagged PDF export of media file fails to create PDF -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159094] New: FILESAVE PDF Tagged PDF export of media file fails to create PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=159094 Bug ID: 159094 Summary: FILESAVE PDF Tagged PDF export of media file fails to create PDF Product: LibreOffice Version: 7.6.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Printing and PDF export Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kelem...@ubuntu.com Blocks: 139007 Created attachment 191830 --> https://bugs.documentfoundation.org/attachment.cgi?id=191830=edit Example file from Calc with media object Attached simple example file has a media file. When this is exported to tagged PDF, the export process fails to produce a PDF file. 1. Open attached file 2. Go to File - Export as PDF 3. Disable the Archival, PDF/UA, Create PDF Form and the Structure options (they are not necessary for this to happen, but seems like enabling Archival, PDF/UA, Create PDF Form makes LO also crash, or successfully export the PDF... unsure yet what triggers these) 4. Enable "View PDF after export" box 5. Press OK, give it some name, press OK -> the file is not exported, does not open in PDF viewer. The "Export as PDF" progress bar is also not removed from the status bar. Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 55e97eaabf6cce91f424e440af392143f11f3343 CPU threads: 15; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: hu-HU (hu_HU); UI: en-US Calc: threaded Seems to have first started in 7.6 with: https://git.libreoffice.org/core/+/a5225ba82e94a549f44420f56a7cb9d7906561cc a5225ba82e94a549f44420f56a7cb9d7906561cc[log] author Michael Stahl Wed Apr 05 11:50:44 2023 +0200 committer Michael Stahl Wed Apr 05 14:34:51 2023 +0200 avmedia,*: guess the mime type of media files based on file name Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=139007 [Bug 139007] [META] PDF accessibility -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158556] DOCX Document That Opens/Loads Extremely Slowly
https://bugs.documentfoundation.org/show_bug.cgi?id=158556 --- Comment #10 from Tex2002ans --- On 24.8.0.0alpha0 (2024-01-06 02:53:39), it took: - 7 mins 49 secs for first paint... so about 25% better load speed for me. - - - This was the daily I used to test: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 25276df12abd9d002f7f899900434617b256f745 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded - - - > I guess, that that aspect (unrelated to the opening time regression) needs an > own report, where it could be handled independently. Should we treat Ctrl+End (then Page Up) as 2 separate performance bugs? Or just submit them as 1? Side Note: And while this document is still a tiny bit faster to paint... it's still *extremely* slow. (And the second I moved the mouse after load, I got another big white screen/freeze.) -- You are receiving this mail because: You are the assignee for the bug.
core.git: sc/qa
sc/qa/unit/uicalc/uicalc2.cxx | 25 +
1 file changed, 25 insertions(+)
New commits:
commit ef6ff2df2e1286974da2f344aa3b8e3ae9093a79
Author: Xisco Fauli
AuthorDate: Tue Jan 9 16:24:50 2024 +0100
Commit: Xisco Fauli
CommitDate: Tue Jan 9 23:39:25 2024 +0100
tdf#158254: sc_uicalc2: Add unittest
Change-Id: Ifc2bac24958cc0330d8174079886851ff1c0c990
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161834
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sc/qa/unit/uicalc/uicalc2.cxx b/sc/qa/unit/uicalc/uicalc2.cxx
index 9be6d83840bb..a488749e9835 100644
--- a/sc/qa/unit/uicalc/uicalc2.cxx
+++ b/sc/qa/unit/uicalc/uicalc2.cxx
@@ -13,6 +13,7 @@
#include
#include
#include
+#include
#include
#include
@@ -87,6 +88,30 @@ CPPUNIT_TEST_FIXTURE(ScUiCalcTest2, testTdf150499)
CPPUNIT_ASSERT_EQUAL(static_cast(1), pDoc->GetTableCount());
}
+CPPUNIT_TEST_FIXTURE(ScUiCalcTest2, testTdf158254)
+{
+createScDoc();
+ScDocument* pDoc = getScDoc();
+
+goToCell("A:G");
+dispatchCommand(mxComponent,
+
".uno:StyleApply?Style:string=Accent%201:string=CellStyles", {});
+
+const ScPatternAttr* pPattern = pDoc->GetPattern(5, 0, 0);
+ScStyleSheet* pStyleSheet =
const_cast(pPattern->GetStyleSheet());
+
+// Without the fix in place, this test would have failed with
+// - Expected: Accent 1
+// - Actual : Default
+CPPUNIT_ASSERT_EQUAL(OUString("Accent 1"), pStyleSheet->GetName());
+
+dispatchCommand(mxComponent, ".uno:Undo", {});
+
+pPattern = pDoc->GetPattern(5, 0, 0);
+pStyleSheet = const_cast(pPattern->GetStyleSheet());
+CPPUNIT_ASSERT_EQUAL(OUString("Default"), pStyleSheet->GetName());
+}
+
CPPUNIT_TEST_FIXTURE(ScUiCalcTest2, testTdf133326)
{
createScDoc("tdf133326.ods");
[Bug 158276] Since version 7.5.8.2 (x86_64) bookmarks in LO Writer do not hold alpha sort
https://bugs.documentfoundation.org/show_bug.cgi?id=158276 --- Comment #16 from BrianH --- (In reply to raal from comment #15) > (In reply to BrianH from comment #14) > > Any idea when this fix will become part of a "normal" update. I can't seem > > to figure out how to use the daily build > > Just click on the link provided is sufficient. Anyway Whiteboard: > target:24.8.0 target:24.2.0.0.beta2 means that this fix is part of 24.2 > release (February 2024) When I click on that link I get a series of CRDOWNLOAD files. What do I do with those please? If I have to open them what program do I use? Thanks, sorry this is all so unknown for me. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159087] Original table column widths of docx file are not preserved but changed in evenly sized column widths
https://bugs.documentfoundation.org/show_bug.cgi?id=159087 m_a_riosv changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #4 from m_a_riosv --- I can reproduce open directly your sample file with: Version: 7.6.4.1 (X86_64) / LibreOffice Community Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Seems the file was created with python. But if I open with: Microsoft® Word para Microsoft 365 MSO (versión 2312 compilación 16.0.17126.20126) de 64 bits the first column has a different width. But, doing a minimal modification on the first column width, and saving, then It opens fine with LibreOffice. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 155381] Basic IDE should remember status of visible UI components
https://bugs.documentfoundation.org/show_bug.cgi?id=155381 Rafael Lima changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |rafael.palma.l...@gmail.com |desktop.org | --- Comment #2 from Rafael Lima --- Proposed patch here: https://gerrit.libreoffice.org/c/core/+/161852 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158722] assertion failure on 24.2.0.0 beta1 for DesktopLOKTest::testPaintPartTileDifferentSchemes in test_desktop_lib.cxx
https://bugs.documentfoundation.org/show_bug.cgi?id=158722 --- Comment #9 from Gwyn Ciesla --- s390x failure persists with 24.2.0.1 final. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159093] Formatting is AWKWARD
https://bugs.documentfoundation.org/show_bug.cgi?id=159093 ady changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from ady --- @nik, In which way this report is different than the report tdf#159060 that you just opened? Do you have any intention of answering to the question that was asked in bug 159060 comment 4? If this report 159093 is essentially the same as tdf# 159060, then you have done this kind of thing before (opening the same report more than once). Moreover, all this sounds the same as tdf#153527, which ATM has been set as fixed and verified in master, but not yet back-ported for the next release. Please clarify the differences between these 2 reports you started (and the third, already fixed), and please provide the information that was requested, in order for other users to be able to replicate the problem. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158620] TRANSPOSE() should generate a #SPILL! error if cells available are not sufficient to write the result, i.e. Spill range is too big
https://bugs.documentfoundation.org/show_bug.cgi?id=158620 Óvári changed: What|Removed |Added Status|NEEDINFO|NEW -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158620] TRANSPOSE() should generate a #SPILL! error if cells available are not sufficient to write the result, i.e. Spill range is too big
https://bugs.documentfoundation.org/show_bug.cgi?id=158620 --- Comment #12 from Óvári --- Created attachment 191829 --> https://bugs.documentfoundation.org/attachment.cgi?id=191829=edit Excel TRANSPOSE array defective (In reply to ady from comment #9) > (In reply to Óvári from comment #8) > > #SPILL! > > > > Spill range it too big > > The question is (or should be) what happens (in Excel) when you use the > TRANSPOSE() function as a normal array function (introduced with CSE), as > oppose to using it as a dynamic array function. Calc does not support > dynamic arrays features. > > Would you please test the case with TRANSPOSE() function as normal array? > What error (if any) Excel shows in such case? Microsoft Excel normal array function is defective. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159093] New: Formatting is AWKWARD
https://bugs.documentfoundation.org/show_bug.cgi?id=159093 Bug ID: 159093 Summary: Formatting is AWKWARD Product: LibreOffice Version: 3.3.0 release Hardware: All OS: macOS (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: n...@grumpie.ca Description: In CALC, I CAN only fORMAT Text in Cells with an Entry. CANNOT Format the ENTIRE Spreadsheet. Any NEW Cell entry REVERTS to the UNWANTED Format; NOT the SAME as ALL Previously Filled Cells. Steps to Reproduce: 1.Enter data in a few cells 2.Format these to a desired FORMAT 3.Enter data into a Blank Cell: Reault is the DEFAUJLT FORMAT (NOT Necessarily the Format of Previous Entries! Actual Results: See Above Expected Results: Text Format shoule apply to the WHOLE Spreadsheet; NOT just those with an current Entry. Reproducible: Always User Profile Reset: No Additional Info: MS Excell Formats the WHOLE Spreadsheet! I have NO idea what “Version” signifies or where to find it!! NO Idea as How to Reset my PROFILE. I just use the Software ‘As Downloaded”! -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159049] Line break is missing in RTF in clipboard when copying text from shape
https://bugs.documentfoundation.org/show_bug.cgi?id=159049 Regina Henschel changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |rb.hensc...@t-online.de |desktop.org | --- Comment #2 from Regina Henschel --- Start is in https://gerrit.libreoffice.org/c/core/+/161842 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158101] Disabled popup menu items are visible with non-gtk backend
https://bugs.documentfoundation.org/show_bug.cgi?id=158101 sdc.bla...@youmail.dk changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #4 from sdc.bla...@youmail.dk --- (In reply to Jim Raykowski from comment #1) > Here is a patch that provides gtk context menu behavior for non-gtk backends > while preserving the intent of the regression causing patch: > https://gerrit.libreoffice.org/c/core/+/159192 Seems like UXEval is needed here to facilitate a way forward -- You are receiving this mail because: You are on the CC list for the bug.
core.git: chart2/qa oox/source
chart2/qa/extras/chart2export3.cxx |2 +-
oox/source/export/chartexport.cxx |7 +--
2 files changed, 6 insertions(+), 3 deletions(-)
New commits:
commit 0bf4338cfe406a0d527ac78ce76ff7dd3837df03
Author: Justin Luth
AuthorDate: Mon Jan 8 13:52:03 2024 -0500
Commit: Justin Luth
CommitDate: Tue Jan 9 21:35:10 2024 +0100
tdf#137691 chart2 export: preserve NumberFormat of DataSeries
make CppunitTest_chart2_export3 CPPUNIT_TEST_NAME=tdf137691
tdf116163.pptx is a good example if you look at the DataTable.
Prior to this patch, the DataTable lost the number formatting.
TODO:
/chart2/qa/extras/data/docx/testSeriesIdxOrder.docx
is exporting General in this case, which was unexpected.
It appears to be an import problem though, not an export one.
TODO:
The fixme in testPPTXPercentageNumberFormats
is still needed. Page 2's axis should LinkToSource
and ignore the specified style.
(It too is an example of this export patch working good.)
Change-Id: I28730ba49ac2929bbc1c3be50f0d4819a5a205dc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161806
Tested-by: Jenkins
Reviewed-by: Justin Luth
diff --git a/chart2/qa/extras/chart2export3.cxx
b/chart2/qa/extras/chart2export3.cxx
index 70bcc8fdfb18..838da77191b7 100644
--- a/chart2/qa/extras/chart2export3.cxx
+++ b/chart2/qa/extras/chart2export3.cxx
@@ -668,7 +668,7 @@ CPPUNIT_TEST_FIXTURE(Chart2ExportTest3, tdf137691)
{
// given a doc where the banana negative data formats as ($123) and the
pineapple data as $(123)
loadFromFile(u"pptx/tdf137691_dataTable.pptx");
-// saveAndReload("Impress MS PowerPoint 2007 XML"); // Always exports as
key 0 (General)
+saveAndReload("Impress MS PowerPoint 2007 XML");
Reference xChartDoc(getChartDocFromDrawImpress(0,
0), uno::UNO_QUERY);
diff --git a/oox/source/export/chartexport.cxx
b/oox/source/export/chartexport.cxx
index 0265c2b7db8d..7de4cee0c4c0 100644
--- a/oox/source/export/chartexport.cxx
+++ b/oox/source/export/chartexport.cxx
@@ -2958,8 +2958,11 @@ void ChartExport::exportSeriesValues( const Reference<
chart2::data::XDataSequen
sal_Int32 ptCount = aValues.size();
pFS->startElement(FSNS(XML_c, XML_numCache));
pFS->startElement(FSNS(XML_c, XML_formatCode));
-// TODO: what format code?
-pFS->writeEscaped( "General" );
+OUString sNumberFormatString("General");
+const sal_Int32 nKey = xValueSeq->getNumberFormatKeyByIndex(-1);
+if (nKey > 0)
+sNumberFormatString = getNumberFormatCode(nKey);
+pFS->writeEscaped(sNumberFormatString);
pFS->endElement( FSNS( XML_c, XML_formatCode ) );
pFS->singleElement(FSNS(XML_c, XML_ptCount), XML_val,
OString::number(ptCount));
[Bug 137691] FILEOPEN: Data table is missing number formatting: shows "250000" instead of "$250,000"
https://bugs.documentfoundation.org/show_bug.cgi?id=137691 --- Comment #13 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0bf4338cfe406a0d527ac78ce76ff7dd3837df03 tdf#137691 chart2 export: preserve NumberFormat of DataSeries It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 137691] FILEOPEN: Data table is missing number formatting: shows "250000" instead of "$250,000"
https://bugs.documentfoundation.org/show_bug.cgi?id=137691 Commit Notification changed: What|Removed |Added Whiteboard||target:24.8.0 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 137691] FILEOPEN: Data table is missing number formatting: shows "250000" instead of "$250,000"
https://bugs.documentfoundation.org/show_bug.cgi?id=137691 --- Comment #12 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0dd3df9400cebeb7cf24887a8640d07a3f9eb4b2 tdf#137691 chart2 import: provide NumberFormat to DataSeries It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
core.git: chart2/qa oox/inc oox/source
chart2/qa/extras/chart2export3.cxx | 21 +++
chart2/qa/extras/data/pptx/tdf137691_dataTable.pptx |binary
oox/inc/drawingml/chart/objectformatter.hxx |3 ++
oox/source/drawingml/chart/datasourceconverter.cxx |5
oox/source/drawingml/chart/objectformatter.cxx | 22
oox/source/token/properties.txt |1
6 files changed, 52 insertions(+)
New commits:
commit 0dd3df9400cebeb7cf24887a8640d07a3f9eb4b2
Author: Justin Luth
AuthorDate: Fri Jan 5 21:20:02 2024 -0500
Commit: Justin Luth
CommitDate: Tue Jan 9 21:33:38 2024 +0100
tdf#137691 chart2 import: provide NumberFormat to DataSeries
make CppunitTest_chart2_export3 CPPUNIT_TEST_NAME=tdf137691
This patch provides some very foundational support
to importing a chart. It will open up a lot of doors
to improve LinkToSource - since now the Source key is defined.
Likely the source key should default to -1 instead of 0,
so that LinkToSource can know whether or not the source is defined.
/chart2/qa/extras/data/docx/testSeriesIdxOrder.docx
is an example of where this patchset SHOULD have worked,
but somehow it is losing its key during import...
Unfortunately I have run out of time and can not follow
these rabbit trails. Well, at least not until this change
is considered a regression for some particular document...
Change-Id: Ieddf2103002616aca2a408bde1f86d45c08dfc85
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161702
Tested-by: Jenkins
Reviewed-by: Justin Luth
diff --git a/chart2/qa/extras/chart2export3.cxx
b/chart2/qa/extras/chart2export3.cxx
index 59416198ce0f..70bcc8fdfb18 100644
--- a/chart2/qa/extras/chart2export3.cxx
+++ b/chart2/qa/extras/chart2export3.cxx
@@ -664,6 +664,27 @@ CPPUNIT_TEST_FIXTURE(Chart2ExportTest3, testTableOnPage3)
CPPUNIT_ASSERT_EQUAL(OUString("If oversubscription relative to allowance
holds steady at average oversubscription level B15-B17"), aColumnDesc[3]);
}
+CPPUNIT_TEST_FIXTURE(Chart2ExportTest3, tdf137691)
+{
+// given a doc where the banana negative data formats as ($123) and the
pineapple data as $(123)
+loadFromFile(u"pptx/tdf137691_dataTable.pptx");
+// saveAndReload("Impress MS PowerPoint 2007 XML"); // Always exports as
key 0 (General)
+
+Reference xChartDoc(getChartDocFromDrawImpress(0,
0), uno::UNO_QUERY);
+
+Reference< chart2::data::XDataSequence > xDataSeq;
+xDataSeq.set(getDataSequenceFromDocByRole(xChartDoc, u"values-y", 0));
+const sal_Int32 nKey_bananas = xDataSeq->getNumberFormatKeyByIndex(-1);
+// This should not be General format (0), but a defined format (129)
+CPPUNIT_ASSERT(nKey_bananas);
+
+xDataSeq.set(getDataSequenceFromDocByRole(xChartDoc, u"values-y", 1));
+const sal_Int32 nKey_pineapples = xDataSeq->getNumberFormatKeyByIndex(-1);
+// This should not be General format (0), but a defined format (130)
+CPPUNIT_ASSERT(nKey_pineapples);
+CPPUNIT_ASSERT(nKey_pineapples != nKey_bananas);
+}
+
CPPUNIT_TEST_FIXTURE(Chart2ExportTest3, testMultipleAxisXLSX)
{
loadFromFile(u"ods/multiple_axis.ods");
diff --git a/chart2/qa/extras/data/pptx/tdf137691_dataTable.pptx
b/chart2/qa/extras/data/pptx/tdf137691_dataTable.pptx
new file mode 100644
index ..edb465d729af
Binary files /dev/null and
b/chart2/qa/extras/data/pptx/tdf137691_dataTable.pptx differ
diff --git a/oox/inc/drawingml/chart/objectformatter.hxx
b/oox/inc/drawingml/chart/objectformatter.hxx
index 9498f0484d50..4ba0d51f4119 100644
--- a/oox/inc/drawingml/chart/objectformatter.hxx
+++ b/oox/inc/drawingml/chart/objectformatter.hxx
@@ -142,6 +142,9 @@ public:
/** Returns true, if the passed shape properties have automatic fill mode.
*/
static bool isAutomaticFill( const ModelRef< Shape >& rxShapeProp
);
+/** Returns the index lookup key given for this number formatting code **/
+sal_Int32 getNumberFormatKey(const OUString& sNumberFormat);
+
private:
std::shared_ptr< ObjectFormatterData > mxData;
};
diff --git a/oox/source/drawingml/chart/datasourceconverter.cxx
b/oox/source/drawingml/chart/datasourceconverter.cxx
index 92cacb4286bf..c07ea397d537 100644
--- a/oox/source/drawingml/chart/datasourceconverter.cxx
+++ b/oox/source/drawingml/chart/datasourceconverter.cxx
@@ -78,6 +78,11 @@ Reference< XDataSequence >
DataSequenceConverter::createDataSequence( const OUSt
// set sequence role
PropertySet aSeqProp( xDataSeq );
aSeqProp.setProperty( PROP_Role, rRole );
+
+const sal_Int32 nKey =
getFormatter().getNumberFormatKey(mrModel.maFormatCode);
+if (nKey >= 0)
+aSeqProp.setProperty(PROP_NumberFormatKey, nKey);
+
return xDataSeq;
}
diff --git a/oox/source/drawingml/chart/objectformatter.cxx
b/oox/source/drawingml/chart/objectformatter.cxx
index ff52053c97c9..2013ea461753 100644
---
[Bug 157253] Repaint: padding covers end of last word when changing alignment in table cell (steps in comment 7)
https://bugs.documentfoundation.org/show_bug.cgi?id=157253 --- Comment #9 from Armin Le Grand --- f06b48a5dddab20fd1bbf9b5f3e8543593f5e590 is from Aug 2017 - are you sure...? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159089] Changing an object color in Draw or Impress crashes LO
https://bugs.documentfoundation.org/show_bug.cgi?id=159089 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr Keywords||wantBacktrace --- Comment #3 from Julien Nabet --- Would it be possible you retrieve extra information? (see https://wiki.documentfoundation.org/QA/BugReport/Debug_Information#macOS:_How_to_get_debug_information) -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'libreoffice-7-6' - sfx2/source
sfx2/source/control/itemdel.cxx | 47
1 file changed, 34 insertions(+), 13 deletions(-)
New commits:
commit 6a0d4247b73d16d7e70ab146aadfbed75721f8bd
Author: Xisco Fauli
AuthorDate: Tue Jan 9 12:29:52 2024 +0100
Commit: Noel Grandin
CommitDate: Tue Jan 9 20:40:49 2024 +0100
Revert "simplify SfxItemDisruptor_Impl, just use Application::PostUserEvent"
This reverts commit 57145acf9ec47c23e307b7a5c0029d21d937cc35.
According to 789a737ac92c4f2b0eb9820b99c43cc8253c8b29
"Remove DeleteItemOnIdlex"
There are some CrashReports in 7.6 which have
DeleteItemOnIdle on the stack... DeleteItemOnIdle
exists since 1st import, but was
changed to AsyncEvent ca. 4 months ago (see
57145acf9ec47c23e307b7a5c0029d21d937cc35), so that may
have caused it.
Reverting this patch in libreoffice-7-6 only to see if
it fixes
https://crashreport.libreoffice.org/stats/signature/static%20bool%20cppu::idefaultConstructElements(struct%20_sal_Sequence%20*%20*,%20struct%20_typelib_TypeDescriptionReference%20*,%20long,%20long,%20long)
Change-Id: Ic6d1046e43295d719a928615a1be921ab5596326
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161823
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sfx2/source/control/itemdel.cxx b/sfx2/source/control/itemdel.cxx
index c96a9d0f4ba3..2b8e7db73fc6 100644
--- a/sfx2/source/control/itemdel.cxx
+++ b/sfx2/source/control/itemdel.cxx
@@ -22,35 +22,56 @@
#include
#include
#include
-#include
#include
class SfxItemDisruptor_Impl
{
+std::unique_ptr pItem;
+Idle m_Idle;
+
+private:
+DECL_LINK(Delete, Timer*, void);
+
public:
-static void DeleteItemOnIdle(std::unique_ptr pItem)
-{
-pItem->SetKind(SfxItemKind::DeleteOnIdle);
-Application::PostUserEvent(LINK(nullptr, SfxItemDisruptor_Impl,
Delete), pItem.release());
-// coverity[leaked_storage] - pDisruptor takes care of its own
destruction at idle time
-}
-
-DECL_STATIC_LINK(SfxItemDisruptor_Impl, Delete, void*, void);
+explicit SfxItemDisruptor_Impl(std::unique_ptr
pItemToDesrupt);
+void LaunchDeleteOnIdle();
+~SfxItemDisruptor_Impl();
+SfxItemDisruptor_Impl(const SfxItemDisruptor_Impl&) = delete;
+SfxItemDisruptor_Impl& operator=(const SfxItemDisruptor_Impl&) = delete;
};
-IMPL_STATIC_LINK(SfxItemDisruptor_Impl, Delete, void*, p, void)
+SfxItemDisruptor_Impl::SfxItemDisruptor_Impl(std::unique_ptr
pItemToDisrupt)
+: pItem(std::move(pItemToDisrupt))
+, m_Idle("sfx::SfxItemDisruptor_Impl m_Idle")
+{
+m_Idle.SetInvokeHandler(LINK(this, SfxItemDisruptor_Impl, Delete));
+m_Idle.SetPriority(TaskPriority::DEFAULT_IDLE);
+
+DBG_ASSERT(0 == pItem->GetRefCount(), "disrupting pooled item");
+pItem->SetKind(SfxItemKind::DeleteOnIdle);
+}
+
+void SfxItemDisruptor_Impl::LaunchDeleteOnIdle() { m_Idle.Start(); }
+
+SfxItemDisruptor_Impl::~SfxItemDisruptor_Impl()
{
-SfxPoolItem* pItem = static_cast(p);
+m_Idle.Stop();
+
// reset RefCount (was set to SFX_ITEMS_SPECIAL before!)
pItem->SetRefCount(0);
-delete pItem;
+
+pItem.reset();
}
+IMPL_LINK_NOARG(SfxItemDisruptor_Impl, Delete, Timer*, void) { delete this; }
+
void DeleteItemOnIdle(std::unique_ptr pItem)
{
DBG_ASSERT(0 == pItem->GetRefCount(), "deleting item in use");
-SfxItemDisruptor_Impl::DeleteItemOnIdle(std::move(pItem));
+SfxItemDisruptor_Impl* pDesruptor = new
SfxItemDisruptor_Impl(std::move(pItem));
+pDesruptor->LaunchDeleteOnIdle();
+// coverity[leaked_storage] - pDesruptor takes care of its own destruction
at idle time
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
[Bug 70976] SLIDESHOW: Thin white lines (or desktop color) visible on the right edge and bottom side of screen when running slideshow
https://bugs.documentfoundation.org/show_bug.cgi?id=70976 V Stuart Foote changed: What|Removed |Added CC||bongomatteo...@gmail.com --- Comment #36 from V Stuart Foote --- *** Bug 159092 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159092] IMPRESS Presentation mode- WHITE LINES ON BOTTOM AND RIGHT
https://bugs.documentfoundation.org/show_bug.cgi?id=159092 V Stuart Foote changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||vsfo...@libreoffice.org Resolution|--- |DUPLICATE --- Comment #2 from V Stuart Foote --- *** This bug has been marked as a duplicate of bug 70976 *** -- You are receiving this mail because: You are the assignee for the bug.
core.git: sc/source
sc/source/ui/docshell/docsh4.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 2bafeb5835d1c11b3e217c0de3f9f430824079de Author: Caolán McNamara AuthorDate: Sun Jan 7 21:01:19 2024 + Commit: Caolán McNamara CommitDate: Tue Jan 9 20:24:30 2024 +0100 fix swapped CJK/CTL SvxLanguageItem types Change-Id: I213d6bac9d08734a7bd771f72540d1783a3a0115 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161776 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/sc/source/ui/docshell/docsh4.cxx b/sc/source/ui/docshell/docsh4.cxx index 3e316ce9420f..bfe14b6aa138 100644 --- a/sc/source/ui/docshell/docsh4.cxx +++ b/sc/source/ui/docshell/docsh4.cxx @@ -1309,10 +1309,10 @@ void ScDocShell::Execute( SfxRequest& rReq ) rOldSet.GetPool()->GetWhich(SID_ATTR_CHAR_LANGUAGE))); if (nScriptType == SvtScriptType::COMPLEX) pNewSet->Put(SvxLanguageItem(nLangType, - rOldSet.GetPool()->GetWhich(SID_ATTR_CHAR_CJK_LANGUAGE))); + rOldSet.GetPool()->GetWhich(SID_ATTR_CHAR_CTL_LANGUAGE))); if (nScriptType == SvtScriptType::ASIAN) pNewSet->Put(SvxLanguageItem(nLangType, - rOldSet.GetPool()->GetWhich(SID_ATTR_CHAR_CTL_LANGUAGE))); + rOldSet.GetPool()->GetWhich(SID_ATTR_CHAR_CJK_LANGUAGE))); pViewShell->ApplyAttributes(*pNewSet, rOldSet); }
[Bug 107830] [META] DOCX (OOXML) paragraph-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=107830 Bug 107830 depends on bug 159085, which changed state. Bug 159085 Summary: soft hyphen triggers bad smart justify https://bugs.documentfoundation.org/show_bug.cgi?id=159085 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 131304] [META] MS Word compatibilityMode = 15
https://bugs.documentfoundation.org/show_bug.cgi?id=131304 Bug 131304 depends on bug 159085, which changed state. Bug 159085 Summary: soft hyphen triggers bad smart justify https://bugs.documentfoundation.org/show_bug.cgi?id=159085 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159085] soft hyphen triggers bad smart justify
https://bugs.documentfoundation.org/show_bug.cgi?id=159085 László Németh changed: What|Removed |Added Status|ASSIGNED|RESOLVED Assignee|nem...@numbertext.org |libreoffice-b...@lists.free ||desktop.org Resolution|--- |FIXED --- Comment #1 from László Németh --- László Németh committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d511367c102ef2ada0f73dbe81744d39865d58ba tdf#195085 sw smart justify: fix bad shrinking at soft hyphen It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Change has been successfully cherry-picked as -- You are receiving this mail because: You are the assignee for the bug.
core.git: sw/qa sw/source
sw/qa/extras/layout/data/tdf159085.fodt | 61
sw/qa/extras/layout/layout3.cxx | 24
sw/source/core/text/portxt.cxx |9
3 files changed, 93 insertions(+), 1 deletion(-)
New commits:
commit d511367c102ef2ada0f73dbe81744d39865d58ba
Author: László Németh
AuthorDate: Tue Jan 9 13:35:23 2024 +0100
Commit: László Németh
CommitDate: Tue Jan 9 20:03:00 2024 +0100
tdf#195085 sw smart justify: fix bad shrinking at soft hyphen
Soft hyphen in the word could result too much shrinking,
calculating with an extra (non-existing) space.
Change-Id: If8b7af40ff50d12c0f2428a6f2475e261fbd0f42
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161827
Tested-by: Jenkins
Reviewed-by: László Németh
diff --git a/sw/qa/extras/layout/data/tdf159085.fodt
b/sw/qa/extras/layout/data/tdf159085.fodt
new file mode 100644
index ..efd0e98e9213
--- /dev/null
+++ b/sw/qa/extras/layout/data/tdf159085.fodt
@@ -0,0 +1,61 @@
+
+
+http://www.w3.org/TR/css3-text/;
xmlns:grddl="http://www.w3.org/2003/g/data-view#;
xmlns:xhtml="http://www.w3.org/1999/xhtml;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xmlns:xsd="http://www.w3.org/2001/XMLSchema;
xmlns:xforms="http://www.w3.org/2002/xforms;
xmlns:dom="http://www.w3.org/2001/xml-events;
xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0"
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0"
xmlns:math="http://www.w3.org/1998/Math/MathML;
xmlns:office="urn:oasis:names:tc:opendocument:xmlns:office:1.0"
xmlns:ooo="http://openoffice.org/2004/office;
xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0"
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0"
xmlns:ooow="http://openoffice.org/2004/writer;
xmlns:xlink="http://www.w3.org/1999/xlink;
xmlns:drawooo="http://openoffice.org/2010/draw;
xmlns:oooc="http://openoffice.org/2004/calc;
xmlns:dc="http://purl.org/dc/elements/1.1/; xmlns:c
alcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
xmlns:style="urn:oasis:names:tc:opendocument:xmlns:style:1.0"
xmlns:text="urn:oasis:names:tc:opendocument:xmlns:text:1.0"
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2"
xmlns:tableooo="http://openoffice.org/2009/table;
xmlns:draw="urn:oasis:names:tc:opendocument:xmlns:drawing:1.0"
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0"
xmlns:rpt="http://openoffice.org/2005/report;
xmlns:formx="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0"
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0"
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0"
xmlns:officeooo="http://openoffice.org/2009/office;
xmlns:table="urn:oasis:names:tc:opendocument:xmlns:table:1.0"
xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0"
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0"
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:
meta:1.0"
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
office:version="1.3" office:mimetype="application/vnd.oasis.opendocument.text">
+
+
+ true
+ high-resolution
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ venenatis, quis commodo dolor posuere. Curabitur dignissim
sapien quis cursus egestas.
+ venenatis, quis commodo dolor posuere. Curabitur dignissim
sapien quis cursus
egestas.
+
+
+
diff --git a/sw/qa/extras/layout/layout3.cxx b/sw/qa/extras/layout/layout3.cxx
index da882cba559d..e4bfc5195b4b 100644
--- a/sw/qa/extras/layout/layout3.cxx
+++ b/sw/qa/extras/layout/layout3.cxx
@@ -246,6 +246,30 @@ CPPUNIT_TEST_FIXTURE(SwLayoutWriter3, testTdf158333)
"venenatis, quis commodo dolor posuere. Curabitur dignissim
sapien quis ");
}
+CPPUNIT_TEST_FIXTURE(SwLayoutWriter3, testTdf159085)
+{
+createSwDoc("tdf159085.fodt");
+// Ensure that all text portions are calculated before testing.
+SwXTextDocument* pTextDoc =
dynamic_cast(mxComponent.get());
+CPPUNIT_ASSERT(pTextDoc);
+SwViewShell* pViewShell
+=
pTextDoc->GetDocShell()->GetDoc()->getIDocumentLayoutAccess().GetCurrentViewShell();
+CPPUNIT_ASSERT(pViewShell);
+pViewShell->Reformat();
+
+xmlDocUniquePtr pXmlDoc = parseLayoutDump();
+
+// This was "... cursus" instead of breaking the word at soft hyphen
+assertXPath(
+pXmlDoc, "/root/page/body/txt[1]/SwParaPortion/SwLineLayout[1]"_ostr,
"portion"_ostr,
+u"venenatis, quis commodo dolor posuere. Curabitur dignissim sapien
quis cur"_ustr);
+
+// This was "... cursus" instead of breaking the word at soft hyphen
+assertXPath(
+pXmlDoc, "/root/page/body/txt[2]/SwParaPortion/SwLineLayout[1]"_ostr,
"portion"_ostr,
[Bug 114441] Convert use of sal_uLong to better integer types
https://bugs.documentfoundation.org/show_bug.cgi?id=114441 --- Comment #80 from Commit Notification --- sahil committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0decafad011cf84cf9cc7d8bdcad6d7ebfba6073 tdf#114441 - Convert sal_uLong to better integer types It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
core.git: sc/inc sc/qa sc/source
sc/inc/document.hxx |4 +-- sc/inc/table.hxx |2 - sc/qa/unit/ucalc_condformat.cxx | 38 +++--- sc/source/core/data/documen4.cxx | 10 +++ sc/source/core/data/table1.cxx|2 - sc/source/filter/excel/xicontent.cxx |2 - sc/source/filter/oox/condformatbuffer.cxx |2 - sc/source/filter/xml/xmlcondformat.cxx|2 - sc/source/filter/xml/xmlstyli.cxx |2 - sc/source/ui/docshell/docfunc.cxx |2 - sc/source/ui/docshell/docsh6.cxx |2 - 11 files changed, 34 insertions(+), 34 deletions(-) New commits: commit 0decafad011cf84cf9cc7d8bdcad6d7ebfba6073 Author: sahil AuthorDate: Wed Aug 23 18:05:53 2023 +0530 Commit: Hossein CommitDate: Tue Jan 9 19:56:26 2024 +0100 tdf#114441 - Convert sal_uLong to better integer types Change-Id: I55c758f6391cecb261adca79ae1b93006bcae806 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155979 Tested-by: Jenkins Reviewed-by: Hossein diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx index 5a92140973a5..55d0b57cd914 100644 --- a/sc/inc/document.hxx +++ b/sc/inc/document.hxx @@ -1886,11 +1886,11 @@ public: voidClearSelectionItems( const sal_uInt16* pWhich, const ScMarkData& rMark ); voidChangeSelectionIndent( bool bIncrement, const ScMarkData& rMark ); -SC_DLLPUBLIC sal_uLong AddCondFormat( std::unique_ptr pNew, SCTAB nTab ); +SC_DLLPUBLIC sal_uInt32 AddCondFormat( std::unique_ptr pNew, SCTAB nTab ); voidDeleteConditionalFormat( sal_uLong nIndex, SCTAB nTab ); voidSetCondFormList( ScConditionalFormatList* pList, SCTAB nTab ); -SC_DLLPUBLIC sal_uLong AddValidationEntry( const ScValidationData& rNew ); +SC_DLLPUBLIC sal_uInt32 AddValidationEntry( const ScValidationData& rNew ); SC_DLLPUBLIC const ScValidationData*GetValidationEntry( sal_uInt32 nIndex ) const; SC_DLLPUBLIC ScConditionalFormatList* GetCondFormList( SCTAB nTab ) const; diff --git a/sc/inc/table.hxx b/sc/inc/table.hxx index 8f749a273707..1761d0cdeed4 100644 --- a/sc/inc/table.hxx +++ b/sc/inc/table.hxx @@ -1065,7 +1065,7 @@ public: void DeleteConditionalFormat(sal_uLong nOldIndex); -sal_uLong AddCondFormat( std::unique_ptr pNew ); +sal_uInt32 AddCondFormat( std::unique_ptr pNew ); SvtScriptType GetScriptType( SCCOL nCol, SCROW nRow ) const; void SetScriptType( SCCOL nCol, SCROW nRow, SvtScriptType nType ); diff --git a/sc/qa/unit/ucalc_condformat.cxx b/sc/qa/unit/ucalc_condformat.cxx index 7a0abc7cf026..a9c289c0aca8 100644 --- a/sc/qa/unit/ucalc_condformat.cxx +++ b/sc/qa/unit/ucalc_condformat.cxx @@ -188,7 +188,7 @@ CPPUNIT_TEST_FIXTURE(TestCondformat, testCondFormatInsertDeleteSheets) pFormat->SetRange(ScRange(1,1,0,1,3,0)); auto pFormatTmp = pFormat.get(); -sal_uLong nKey = m_pDoc->AddCondFormat(std::move(pFormat), 0); +sal_uInt32 nKey = m_pDoc->AddCondFormat(std::move(pFormat), 0); // Add condition in which if the value equals 2, set the "Result" style. ScCondFormatEntry* pEntry = new ScCondFormatEntry( @@ -305,7 +305,7 @@ CPPUNIT_TEST_FIXTURE(TestCondformat, testDataBarCondCopyPaste) pDatabar->SetDataBarData(pFormatData); pFormat->AddEntry(pDatabar); -sal_uLong nIndex = m_pDoc->AddCondFormat(std::move(pFormat), 0); +sal_uInt32 nIndex = m_pDoc->AddCondFormat(std::move(pFormat), 0); ScDocument aClipDoc(SCDOCMODE_CLIP); copyToClip(m_pDoc, aCondFormatRange, ); @@ -324,14 +324,14 @@ CPPUNIT_TEST_FIXTURE(TestCondformat, testDataBarCondCopyPaste) CPPUNIT_ASSERT(pPastedFormat); CPPUNIT_ASSERT_EQUAL(aRangeList, pPastedFormat->GetRange()); -sal_uLong nPastedKey = pPastedFormat->GetKey(); +sal_uInt32 nPastedKey = pPastedFormat->GetKey(); CPPUNIT_ASSERT_EQUAL(nIndex, nPastedKey); const SfxPoolItem* pItem = m_pDoc->GetAttr(nCol, 3, 0, ATTR_CONDITIONAL); const ScCondFormatItem* pCondFormatItem = static_cast(pItem); CPPUNIT_ASSERT(pCondFormatItem); CPPUNIT_ASSERT_EQUAL(size_t(1), pCondFormatItem->GetCondFormatData().size()); -CPPUNIT_ASSERT_EQUAL(sal_uInt32(nIndex), pCondFormatItem->GetCondFormatData().front()); +CPPUNIT_ASSERT_EQUAL(nIndex, pCondFormatItem->GetCondFormatData().front()); } m_pDoc->DeleteTab(0); @@ -346,7 +346,7 @@ CPPUNIT_TEST_FIXTURE(TestCondformat, testColorScaleInMergedCell) auto pFormat = std::make_unique(1, m_pDoc); pFormat->SetRange(ScRange(0, 0, 0, 0, 0, 0)); auto pFormatTmp = pFormat.get(); -sal_uLong nKey = m_pDoc->AddCondFormat(std::move(pFormat), 0); +sal_uInt32 nKey = m_pDoc->AddCondFormat(std::move(pFormat), 0); // Add color scale entries. //
[Bug 158276] Since version 7.5.8.2 (x86_64) bookmarks in LO Writer do not hold alpha sort
https://bugs.documentfoundation.org/show_bug.cgi?id=158276 --- Comment #15 from raal --- (In reply to BrianH from comment #14) > Any idea when this fix will become part of a "normal" update. I can't seem > to figure out how to use the daily build Just click on the link provided is sufficient. Anyway Whiteboard: target:24.8.0 target:24.2.0.0.beta2 means that this fix is part of 24.2 release (February 2024) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159075] Comment triangle is not drawn correctly when zoom factor is not a multiple of 50%
https://bugs.documentfoundation.org/show_bug.cgi?id=159075 Rafael Lima changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |rafael.palma.l...@gmail.com |desktop.org | Status|NEW |ASSIGNED --- Comment #5 from Rafael Lima --- This patch fixes the triangle: https://gerrit.libreoffice.org/c/core/+/161768 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159074] Page Style does not get saved
https://bugs.documentfoundation.org/show_bug.cgi?id=159074 --- Comment #6 from Martin --- PS: When i create another style and try to put it to the third page, it alters the style of the first page, but not of the third page. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159074] Page Style does not get saved
https://bugs.documentfoundation.org/show_bug.cgi?id=159074 --- Comment #5 from Martin --- Excuse me, I already tried what you suggest. As the video shows, I tried to use the style of the first page in the third page. The same thing happens when i try to create a style with the same background for the third page. -- You are receiving this mail because: You are the assignee for the bug.
core.git: external/firebird
external/firebird/ubsan.patch | 11 +++
1 file changed, 11 insertions(+)
New commits:
commit 345f8cc9de49f573b60f9dc63e7df17ce3c2f93c
Author: Stephan Bergmann
AuthorDate: Tue Jan 9 15:39:23 2024 +0100
Commit: Stephan Bergmann
CommitDate: Tue Jan 9 19:10:33 2024 +0100
New UBSan failure with Firebird 3.0.11
While building ExternalProject_firebird:
> workdir/UnpackedTarball/firebird/temp/Debug/jrd/scl.cpp:1171:38: runtime
error: member access within null pointer of type 'const SecurityClass'
Change-Id: I7f20495879da9b64a18ba8bd8673c42da8b483af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161833
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/external/firebird/ubsan.patch b/external/firebird/ubsan.patch
index 7c6af106829b..78c45ed6b1bd 100644
--- a/external/firebird/ubsan.patch
+++ b/external/firebird/ubsan.patch
@@ -250,6 +250,17 @@
}
+--- src/jrd/scl.epp
src/jrd/scl.epp
+@@ -218,8 +218,6 @@
+ if ((tdbb->tdbb_flags & TDBB_trusted_ddl) && (mask != SCL_references))
+ return true;
+
+- const MetaName& userName = s_class->sclClassUser.second;
+-
+ if (s_class && (s_class->scl_flags & SCL_corrupt))
+ {
+ Arg::StatusVector status;
--- src/lock/lock.cpp
+++ src/lock/lock.cpp
@@ -441,7 +441,7 @@
[Bug 159091] UI: The function of the Automatic recovery dialog was interrupted dialog is obscure
https://bugs.documentfoundation.org/show_bug.cgi?id=159091 --- Comment #1 from Telesto --- Created attachment 191828 --> https://bugs.documentfoundation.org/attachment.cgi?id=191828=edit Screenshot -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158937] Crash when pressing cancel in the insert password dialog when recovering a file (swlo!SwDocShell::SetModified+4b)
https://bugs.documentfoundation.org/show_bug.cgi?id=158937 Julien Nabet changed: What|Removed |Added CC|serval2...@yahoo.fr | --- Comment #3 from Julien Nabet --- I used kill -9 but it doesn't launch recovery afterwards so can't reproduce this. -- You are receiving this mail because: You are the assignee for the bug.
core.git: basctl/source
basctl/source/basicide/BasicColorConfig.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 6a0dc770f8e288b88c00517e04c10777e2cb1b2f
Author: Andrea Gelmini
AuthorDate: Mon Jan 8 20:52:01 2024 +0100
Commit: Julien Nabet
CommitDate: Tue Jan 9 18:46:46 2024 +0100
Fix typo
Change-Id: I75bcd6459f0bb8d0dcaf4d5646e31da2b71fb78f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161804
Tested-by: Julien Nabet
Reviewed-by: Julien Nabet
diff --git a/basctl/source/basicide/BasicColorConfig.cxx
b/basctl/source/basicide/BasicColorConfig.cxx
index 1a650fd8c433..21ff95bc0f8e 100644
--- a/basctl/source/basicide/BasicColorConfig.cxx
+++ b/basctl/source/basicide/BasicColorConfig.cxx
@@ -28,7 +28,7 @@ namespace basctl
BasicColorConfig::BasicColorConfig()
: ConfigItem("Office.BasicIDE/IDEColorSchemes")
{
-// Innitially the active color scheme is the one defined in the registry
+// Initially the active color scheme is the one defined in the registry
m_sCurrentColorScheme =
officecfg::Office::BasicIDE::EditorSettings::ColorScheme::get();
// Initialize all available scheme names
core.git: basctl/source
basctl/source/inc/BasicColorConfig.hxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 833b8bd3d19d0e1fb02bb5cb419d7076567527d9
Author: Andrea Gelmini
AuthorDate: Mon Jan 8 20:51:41 2024 +0100
Commit: Julien Nabet
CommitDate: Tue Jan 9 18:46:20 2024 +0100
Fix typo
Change-Id: Icf3d2feb84f287e3e75f1eab488ec2804cd22a40
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161803
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/basctl/source/inc/BasicColorConfig.hxx
b/basctl/source/inc/BasicColorConfig.hxx
index 9d66925e952a..a393f5aedb6a 100644
--- a/basctl/source/inc/BasicColorConfig.hxx
+++ b/basctl/source/inc/BasicColorConfig.hxx
@@ -61,7 +61,7 @@ private:
{ "COLORSCHEME_SOLARIZED_DARK", RID_STR_COLORSCHEME_SOLARIZED_DARK },
};
-// Used to get colors defined in the Appliation Colors dialog
+// Used to get colors defined in the Application Colors dialog
const svtools::ColorConfig aColorConfig;
virtual void ImplCommit() override;
[Bug 159087] Original table column widths of docx file are not preserved but changed in evenly sized column widths
https://bugs.documentfoundation.org/show_bug.cgi?id=159087 --- Comment #3 from Freek de Poel --- Created attachment 191827 --> https://bugs.documentfoundation.org/attachment.cgi?id=191827=edit Docx with table with different column widths Attached file has been created on a MacOs. When converting the file from docx to pdf in Python script through LibreOffice the column sizes are evenly displayed. This happens when opening the file in LibreOffice. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158745] Image becomes invisible, when it's automatically shifted on the next page
https://bugs.documentfoundation.org/show_bug.cgi?id=158745 raal changed: What|Removed |Added Status|NEEDINFO|NEW Regression By|Miklos Vajna|Michael Stahl CC||michael.st...@allotropia.de --- Comment #7 from raal --- (In reply to Miklos Vajna from comment #6) > raal: I'm a bit confused, your bisect result points to > 689cead9e0837dc932e3a4cd765f7d319b529018, a commit from 2016. My later > commit is bab44a97d21d0ac8a8a06678e71024c1a830943f, from 2022. > > Did you mean to ping Michael S instead? Thanks. Hi Miklos, yes, sorry, my mistake. Michael, please can you take a look? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159092] IMPRESS Presentation mode- WHITE LINES ON BOTTOM AND RIGHT
https://bugs.documentfoundation.org/show_bug.cgi?id=159092 --- Comment #1 from BoingoBat --- This problem has been reported in community forums since 2015! CAN YOU FIX IT FINALLY? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159092] New: IMPRESS Presentation mode- WHITE LINES ON BOTTOM AND RIGHT
https://bugs.documentfoundation.org/show_bug.cgi?id=159092 Bug ID: 159092 Summary: IMPRESS Presentation mode- WHITE LINES ON BOTTOM AND RIGHT Product: LibreOffice Version: 7.5.3.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: bongomatteo...@gmail.com Description: White lines on bottom and right side are obvious on dark backgrounds. No way to get rid of them. The solutions proposed in community posts DO NOT WORK on 2 different Windows based laptops I have been using, WIN10 & WIN 11. Using 7.3.5.2 of Libre Office Impress on both. Behavior: Initially no lines were apparant, but after 2 months of occaisional use, the lines appeared. Priority: This problem has been reported as far back as 2015 Steps to Reproduce: 1.make a presentation with a dark background 2.run presentation 3.notice the horrible white lines on bottom & right side Actual Results: 1.make a presentation with a dark background 2.run presentation 3.notice the horrible white lines on bottom & right side Expected Results: no white lines Reproducible: Always User Profile Reset: Yes Additional Info: The software should not display ugly white lines at bottom and right sides -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158276] Since version 7.5.8.2 (x86_64) bookmarks in LO Writer do not hold alpha sort
https://bugs.documentfoundation.org/show_bug.cgi?id=158276 --- Comment #14 from BrianH --- Any idea when this fix will become part of a "normal" update. I can't seem to figure out how to use the daily build -- You are receiving this mail because: You are the assignee for the bug.
[Bug 107739] [META] Field bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107739 BogdanB changed: What|Removed |Added Depends on||159057 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=159057 [Bug 159057] DOCX month fields get a different interpretation -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159057] DOCX month fields get a different interpretation
https://bugs.documentfoundation.org/show_bug.cgi?id=159057 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g Blocks||107739 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107739 [Bug 107739] [META] Field bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'distro/allotropia/zeta-7-4' - 2 commits - sfx2/source
sfx2/source/doc/sfxbasemodel.cxx | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
New commits:
commit a7fa60410667da4cecd571652b12da0e4909a6f8
Author: Michael Stahl
AuthorDate: Tue Jan 9 16:44:50 2024 +0100
Commit: Michael Stahl
CommitDate: Tue Jan 9 18:08:58 2024 +0100
sfx2: reorder the checks in SfxBaseModel::postEvent_Impl()
It doesn't make sense to copy m_pData after impl_isDisposed() checks if
it's null (not sure if this makes a difference in practice).
Change-Id: I5c6db0bd3e09f92acef346115a4fee44ae4c0a89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161835
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 79e8f18f635dfd094485ed18166fd8b04c37862c)
diff --git a/sfx2/source/doc/sfxbasemodel.cxx b/sfx2/source/doc/sfxbasemodel.cxx
index b83fb2f07d56..0236fe929dbf 100644
--- a/sfx2/source/doc/sfxbasemodel.cxx
+++ b/sfx2/source/doc/sfxbasemodel.cxx
@@ -3236,18 +3236,19 @@ public:
void SfxBaseModel::postEvent_Impl( const OUString& aName, const Reference<
frame::XController2 >& xController, const Any& supplement )
{
-// object already disposed?
-if ( impl_isDisposed() )
+if (aName.isEmpty())
+{
+SAL_WARN("sfx.doc", "postEvent_Impl: Empty event name!");
return;
-
-// keep m_pData alive, if notified target would dispose the document
-std::shared_ptr xKeepAlive(m_pData);
+}
// also make sure this object doesn't self-destruct while notifying
rtl::Reference xHoldAlive(this);
+// keep m_pData alive, if notified target would dispose the document
+std::shared_ptr xKeepAlive(m_pData);
-DBG_ASSERT( !aName.isEmpty(), "Empty event name!" );
-if (aName.isEmpty())
+// object already disposed?
+if ( impl_isDisposed() )
return;
comphelper::OInterfaceContainerHelper2* pIC =
@@ -3276,7 +3277,6 @@ void SfxBaseModel::postEvent_Impl( const OUString& aName,
const Reference< frame
::XEventListener::notifyEvent,
aEvent ) );
}
-
}
Reference < container::XIndexAccess > SAL_CALL SfxBaseModel::getViewData()
commit 5e488787312a2f42bdc080accda6d04dc2e6496d
Author: Armin Le Grand (allotropia)
AuthorDate: Fri Dec 16 16:57:46 2022 +0100
Commit: Michael Stahl
CommitDate: Tue Jan 9 18:08:36 2024 +0100
Use xKeepAlive instead of m_pData
There is already an instance to keep the incarnation
alive, but it was not used. Instead m_pData can indeed
get deleted (nullptr), so better use the alive one.
Change-Id: Icdb6c841408254142561db408f876618adbc0b76
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144340
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
(cherry picked from commit 8635c9aa8c6f1078a9e220076d5a08daf30077e8)
diff --git a/sfx2/source/doc/sfxbasemodel.cxx b/sfx2/source/doc/sfxbasemodel.cxx
index dc9a056e31bb..b83fb2f07d56 100644
--- a/sfx2/source/doc/sfxbasemodel.cxx
+++ b/sfx2/source/doc/sfxbasemodel.cxx
@@ -3251,7 +3251,7 @@ void SfxBaseModel::postEvent_Impl( const OUString& aName,
const Reference< frame
return;
comphelper::OInterfaceContainerHelper2* pIC =
-m_pData->m_aInterfaceContainer.getContainer(
cppu::UnoType::get());
+xKeepAlive->m_aInterfaceContainer.getContainer(
cppu::UnoType::get());
if ( pIC )
{
SAL_INFO("sfx.doc", "SfxDocumentEvent: " + aName);
@@ -3264,7 +3264,7 @@ void SfxBaseModel::postEvent_Impl( const OUString& aName,
const Reference< frame
aDocumentEvent ) );
}
-pIC = m_pData->m_aInterfaceContainer.getContainer(
cppu::UnoType::get());
+pIC = xKeepAlive->m_aInterfaceContainer.getContainer(
cppu::UnoType::get());
if ( pIC )
{
SAL_INFO("sfx.doc", "SfxEvent: " + aName);
[Bug 158276] Since version 7.5.8.2 (x86_64) bookmarks in LO Writer do not hold alpha sort
https://bugs.documentfoundation.org/show_bug.cgi?id=158276 --- Comment #13 from BrianH --- (In reply to raal from comment #11) > https://dev-builds.libreoffice.org/daily/master/Win-x86_64@tb77-TDF/current/ > is folder with builds > Try this one > https://dev-builds.libreoffice.org/daily/master/Win-x86_64@tb77-TDF/current/ > LibreOfficeDev_24.8.0.0.alpha0_Win_x86-64.msi That generates a series of CRDOWNLOAD files in my downloads folder but nothing beyond that? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 103378] [META] PDF export bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103378 BogdanB changed: What|Removed |Added Depends on||159069 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=159069 [Bug 159069] Slow converting from docx to pdf when there's some table (comment 10) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159069] Slow converting from docx to pdf when there's some table (comment 10)
https://bugs.documentfoundation.org/show_bug.cgi?id=159069 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g Blocks||103378 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103378 [Bug 103378] [META] PDF export bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 108254] [META] File format filters (import/export) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108254 BogdanB changed: What|Removed |Added Depends on||159078 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=159078 [Bug 159078] Support for Apache Parquet input for Calc and Base -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159078] Support for Apache Parquet input for Calc and Base
https://bugs.documentfoundation.org/show_bug.cgi?id=159078 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g Blocks||108254 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108254 [Bug 108254] [META] File format filters (import/export) bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159079] With NumLock off in Numpad, then with Alt pressed the Num Pad arrow keys should not operate
https://bugs.documentfoundation.org/show_bug.cgi?id=159079 BogdanB changed: What|Removed |Added Blocks||98259 CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=98259 [Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=98259 BogdanB changed: What|Removed |Added Depends on||159079 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=159079 [Bug 159079] With NumLock off in Numpad, then with Alt pressed the Num Pad arrow keys should not operate -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'feature/cib_contract57d' - 2 commits - sfx2/source
sfx2/source/doc/sfxbasemodel.cxx | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
New commits:
commit 3746235c671d044e1b5662bcfb36560415b28711
Author: Michael Stahl
AuthorDate: Tue Jan 9 16:44:50 2024 +0100
Commit: Michael Stahl
CommitDate: Tue Jan 9 17:57:58 2024 +0100
sfx2: reorder the checks in SfxBaseModel::postEvent_Impl()
It doesn't make sense to copy m_pData after impl_isDisposed() checks if
it's null (not sure if this makes a difference in practice).
Change-Id: I5c6db0bd3e09f92acef346115a4fee44ae4c0a89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161835
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 79e8f18f635dfd094485ed18166fd8b04c37862c)
diff --git a/sfx2/source/doc/sfxbasemodel.cxx b/sfx2/source/doc/sfxbasemodel.cxx
index 8dda903183a3..d68830211d5d 100644
--- a/sfx2/source/doc/sfxbasemodel.cxx
+++ b/sfx2/source/doc/sfxbasemodel.cxx
@@ -3136,18 +3136,19 @@ public:
void SfxBaseModel::postEvent_Impl( const OUString& aName, const Reference<
frame::XController2 >& xController )
{
-// object already disposed?
-if ( impl_isDisposed() )
+if (aName.isEmpty())
+{
+SAL_WARN("sfx.doc", "postEvent_Impl: Empty event name!");
return;
-
-// keep m_pData alive, if notified target would dispose the document
-std::shared_ptr xKeepAlive(m_pData);
+}
// also make sure this object doesn't self-destruct while notifying
rtl::Reference xHoldAlive(this);
+// keep m_pData alive, if notified target would dispose the document
+std::shared_ptr xKeepAlive(m_pData);
-DBG_ASSERT( !aName.isEmpty(), "Empty event name!" );
-if (aName.isEmpty())
+// object already disposed?
+if ( impl_isDisposed() )
return;
::cppu::OInterfaceContainerHelper* pIC =
@@ -3176,7 +3177,6 @@ void SfxBaseModel::postEvent_Impl( const OUString& aName,
const Reference< frame
::XEventListener::notifyEvent,
aEvent ) );
}
-
}
Reference < container::XIndexAccess > SAL_CALL SfxBaseModel::getViewData()
commit 9d5f1b02b0d349f86a8b8b3c54b525bf9fe98f0d
Author: Armin Le Grand (allotropia)
AuthorDate: Fri Dec 16 16:57:46 2022 +0100
Commit: Michael Stahl
CommitDate: Tue Jan 9 17:57:58 2024 +0100
Use xKeepAlive instead of m_pData
There is already an instance to keep the incarnation
alive, but it was not used. Instead m_pData can indeed
get deleted (nullptr), so better use the alive one.
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144340
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
(cherry picked from commit 8635c9aa8c6f1078a9e220076d5a08daf30077e8)
Plus this file's part of commit b9fe4f26eaf1099b8d0907b8d9cbf52c86914466
"rename some local variables".
Change-Id: Icdb6c841408254142561db408f876618adbc0b76
diff --git a/sfx2/source/doc/sfxbasemodel.cxx b/sfx2/source/doc/sfxbasemodel.cxx
index 353161ef9a8e..8dda903183a3 100644
--- a/sfx2/source/doc/sfxbasemodel.cxx
+++ b/sfx2/source/doc/sfxbasemodel.cxx
@@ -3141,17 +3141,17 @@ void SfxBaseModel::postEvent_Impl( const OUString&
aName, const Reference< frame
return;
// keep m_pData alive, if notified target would dispose the document
-std::shared_ptr pData(m_pData);
+std::shared_ptr xKeepAlive(m_pData);
// also make sure this object doesn't self-destruct while notifying
-rtl::Reference self(this);
+rtl::Reference xHoldAlive(this);
DBG_ASSERT( !aName.isEmpty(), "Empty event name!" );
if (aName.isEmpty())
return;
::cppu::OInterfaceContainerHelper* pIC =
-m_pData->m_aInterfaceContainer.getContainer(
cppu::UnoType::get());
+xKeepAlive->m_aInterfaceContainer.getContainer(
cppu::UnoType::get());
if ( pIC )
{
SAL_INFO("sfx.doc", "SfxDocumentEvent: " + aName);
@@ -3164,7 +3164,7 @@ void SfxBaseModel::postEvent_Impl( const OUString& aName,
const Reference< frame
aDocumentEvent ) );
}
-pIC = m_pData->m_aInterfaceContainer.getContainer(
cppu::UnoType::get());
+pIC = xKeepAlive->m_aInterfaceContainer.getContainer(
cppu::UnoType::get());
if ( pIC )
{
SAL_INFO("sfx.doc", "SfxEvent: " + aName);
[Bug 158840] In libreoffice writer, i want to insert cross reference of a numbered paragraph with out the before and after fields
https://bugs.documentfoundation.org/show_bug.cgi?id=158840 --- Comment #2 from Mahmoud Alnaanah --- Created attachment 191826 --> https://bugs.documentfoundation.org/attachment.cgi?id=191826=edit Example on inserting cross-reference to a numbered paragrph Version: 7.6.3.2 (X86_64) / LibreOffice Community Build ID: 60(Build:2) CPU threads: 4; OS: Linux 5.19; UI render: default; VCL: kf5 (cairo+xcb) Locale: en-US (en_US.UTF-8); UI: en-US Ubuntu package version: 4:7.6.3~rc2-0ubuntu0.22.04.1~lo3 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
core.git: sfx2/source
sfx2/source/doc/sfxbasemodel.cxx | 16
1 file changed, 8 insertions(+), 8 deletions(-)
New commits:
commit 79e8f18f635dfd094485ed18166fd8b04c37862c
Author: Michael Stahl
AuthorDate: Tue Jan 9 16:44:50 2024 +0100
Commit: Michael Stahl
CommitDate: Tue Jan 9 17:43:18 2024 +0100
sfx2: reorder the checks in SfxBaseModel::postEvent_Impl()
It doesn't make sense to copy m_pData after impl_isDisposed() checks if
it's null (not sure if this makes a difference in practice).
Change-Id: I5c6db0bd3e09f92acef346115a4fee44ae4c0a89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161835
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/sfx2/source/doc/sfxbasemodel.cxx b/sfx2/source/doc/sfxbasemodel.cxx
index 985af531358d..a996259f3598 100644
--- a/sfx2/source/doc/sfxbasemodel.cxx
+++ b/sfx2/source/doc/sfxbasemodel.cxx
@@ -3303,18 +3303,19 @@ public:
void SfxBaseModel::postEvent_Impl( const OUString& aName, const Reference<
frame::XController2 >& xController, const Any& supplement )
{
-// object already disposed?
-if ( impl_isDisposed() )
+if (aName.isEmpty())
+{
+SAL_WARN("sfx.doc", "postEvent_Impl: Empty event name!");
return;
-
-// keep m_pData alive, if notified target would dispose the document
-std::shared_ptr xKeepAlive(m_pData);
+}
// also make sure this object doesn't self-destruct while notifying
rtl::Reference xHoldAlive(this);
+// keep m_pData alive, if notified target would dispose the document
+std::shared_ptr xKeepAlive(m_pData);
-DBG_ASSERT( !aName.isEmpty(), "Empty event name!" );
-if (aName.isEmpty())
+// object already disposed?
+if ( impl_isDisposed() )
return;
if ( xKeepAlive->m_aDocumentEventListeners2.getLength() )
@@ -3340,7 +3341,6 @@ void SfxBaseModel::postEvent_Impl( const OUString& aName,
const Reference< frame
::XEventListener::notifyEvent,
aEvent ) );
}
-
}
Reference < container::XIndexAccess > SAL_CALL SfxBaseModel::getViewData()
[Bug 159081] SPELL CHECK FOR CAPITAL WORDS DOES NOT WORK
https://bugs.documentfoundation.org/show_bug.cgi?id=159081 V Stuart Foote changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 CC||vsfo...@libreoffice.org --- Comment #2 from V Stuart Foote --- Can not confirm. The lowercase and uppercase spelling errors are checked. Version: 7.6.4.1 (X86_64) / LibreOffice Community Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded Please check your settings. In the Tools -> Spelling... () dialog open its Options... dialog. There is a "Check uppercase words" checkbox, what is its status? Alternatively, reset do a default user profile where it is checked enabled by default. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159074] Page Style does not get saved
https://bugs.documentfoundation.org/show_bug.cgi?id=159074 --- Comment #4 from m_a_riosv --- Then you need to create a third style with the same background of the firs page, or use the first page style. Please ask this kind of questions in https://ask.libreoffice.org/ -- You are receiving this mail because: You are the assignee for the bug.
