Re: no JDK found

[Ilmari Lauhakangas]

On 13.1.2024 19.24, y27p6e3vu...@web.de wrote:

Hi,
I am trying to compile LO for the first time on windows and do follow 
the official guide

https://wiki.documentfoundation.org/Development/BuildingOnWindows
Nevertheless I am runnning into several issues while configuring the build.
Running autogen.sh gives errors,
it is not finding C++ build tools (Win 10 SDK), even if Visual Studio is 
available. I have to use the option "--with-visual-studio=2022"
it is not finding JDK, even if it is available. Option 
"--with-jdk-home=/cygdrive/c/jdk-21.0.1/bin" is not solving the issue.
The JDK was downloaded from Microsoft server as 64bit version and the 
PATH is set correctly.
There are hints in the documentation given above for Java installation 
and to eventually modify the "--with-jdk-home" in "autogen.input". There 
is no file "autogen.input"!
What is going wrong? Is the documentaion not up-to-date or do I am 
missing some details?


You have apparently skipped the green note that is under the Cygwin 
section and reads:


"The Easiest way to perform the following is to use LODE, which 
automates all that is necessary, beyond installing Visual Studio and Java.


If you want to do it the hard way, continue reading."

If you had used the LODE method, an autogen.input file would have been 
created. Now you have to create it yourself. More about the file: 
https://wiki.documentfoundation.org/Development/GenericBuildingHints#autogen_help


Ilmari

[Bug 159174] CRASH pasting bitmap of empty Calc selection

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159174

Mike Kaganski  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |ASSIGNED
   Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com
   |desktop.org |

--- Comment #1 from Mike Kaganski  ---
https://gerrit.libreoffice.org/c/core/+/162041

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159174] New: CRASH pasting bitmap of empty Calc selection

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159174

Bug ID: 159174
   Summary: CRASH pasting bitmap of empty Calc selection
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mikekagan...@hotmail.com

With a recent master build (including commit
3b10bbacb8a12a00c35683eeaae4a75046a84aac, to not interfere with tdf#159171 and
tdf#151752):

1. Create a new empty Calc document;
2. Edit->Select->Select Unprotected Cells;
3. Ctrl+C;
4. Click on the small drop-down arrow of the Paste toolbar button;
5. Choose "Bitmap Image (BMP)"

=> Assertion failed, crash.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 107450] [META] Cell and sheet protection bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107450
Bug 107450 depends on bug 151752, which changed state.

Bug 151752 Summary: Calc: Crash after copy and paste all unprotected cells
https://bugs.documentfoundation.org/show_bug.cgi?id=151752

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 133092] [META] Crash bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=133092
Bug 133092 depends on bug 151752, which changed state.

Bug 151752 Summary: Calc: Crash after copy and paste all unprotected cells
https://bugs.documentfoundation.org/show_bug.cgi?id=151752

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 108844] [META] Cut/copy bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108844
Bug 108844 depends on bug 151752, which changed state.

Bug 151752 Summary: Calc: Crash after copy and paste all unprotected cells
https://bugs.documentfoundation.org/show_bug.cgi?id=151752

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: sc/source

[Matt K (via logerrit)]

 sc/source/ui/app/transobj.cxx |   46 +++---
 1 file changed, 26 insertions(+), 20 deletions(-)

New commits:
commit 3b10bbacb8a12a00c35683eeaae4a75046a84aac
Author: Matt K 
AuthorDate: Sat Jan 13 18:12:16 2024 -0600
Commit: Mike Kaganski 
CommitDate: Sun Jan 14 05:43:00 2024 +0100

tdf#159171 Prevent crash after selecting unprotected cells 2 times

The problem is that the code tries to check for a table on a clip-
board doc, but doesn't find any so it propagates nullptr back to
the caller, which is then used without being checked thereby
leading to a crash.  The fix is to check the result of the table
check of clipboard doc before doing any operations with it, thus
preventing the crash.

Change-Id: Ieb4a52d0c1cb713d5c14930e5e559e5bf520b330
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162033
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sc/source/ui/app/transobj.cxx b/sc/source/ui/app/transobj.cxx
index 6a1ef6a04650..5f0599c888b3 100644
--- a/sc/source/ui/app/transobj.cxx
+++ b/sc/source/ui/app/transobj.cxx
@@ -312,28 +312,34 @@ bool ScTransferObj::GetData( const 
datatransfer::DataFlavor& rFlavor, const OUSt
 ScAddress aPos(nCol, nRow, nTab);
 
 const ScPatternAttr* pPattern = m_pDoc->GetPattern( nCol, nRow, 
nTab );
-ScTabEditEngine aEngine( *pPattern, m_pDoc->GetEditPool(), 
m_pDoc.get() );
-ScRefCellValue aCell(*m_pDoc, aPos);
-if (aCell.getType() == CELLTYPE_EDIT)
+if (pPattern)
 {
-const EditTextObject* pObj = aCell.getEditText();
-aEngine.SetTextCurrentDefaults(*pObj);
-}
-else
-{
-SvNumberFormatter* pFormatter = m_pDoc->GetFormatTable();
-sal_uInt32 nNumFmt = pPattern->GetNumberFormat(pFormatter);
-const Color* pColor;
-OUString aText = ScCellFormat::GetString(aCell, nNumFmt, 
, *pFormatter, *m_pDoc);
-if (!aText.isEmpty())
-aEngine.SetTextCurrentDefaults(aText);
-}
+ScTabEditEngine aEngine(*pPattern, m_pDoc->GetEditPool(), 
m_pDoc.get());
+ScRefCellValue aCell(*m_pDoc, aPos);
+if (aCell.getType() == CELLTYPE_EDIT)
+{
+const EditTextObject* pObj = aCell.getEditText();
+aEngine.SetTextCurrentDefaults(*pObj);
+}
+else
+{
+SvNumberFormatter* pFormatter = m_pDoc->GetFormatTable();
+sal_uInt32 nNumFmt = pPattern->GetNumberFormat(pFormatter);
+const Color* pColor;
+OUString aText
+= ScCellFormat::GetString(aCell, nNumFmt, , 
*pFormatter, *m_pDoc);
+if (!aText.isEmpty())
+aEngine.SetTextCurrentDefaults(aText);
+}
 
-bOK = SetObject( ,
-((nFormat == SotClipboardFormatId::RTF) ? 
SCTRANS_TYPE_EDIT_RTF :
- ((nFormat == 
SotClipboardFormatId::EDITENGINE_ODF_TEXT_FLAT) ?
-  SCTRANS_TYPE_EDIT_ODF_TEXT_FLAT : 
SCTRANS_TYPE_EDIT_BIN)),
-rFlavor );
+bOK = SetObject(,
+((nFormat == SotClipboardFormatId::RTF)
+ ? SCTRANS_TYPE_EDIT_RTF
+ : ((nFormat == 
SotClipboardFormatId::EDITENGINE_ODF_TEXT_FLAT)
+? SCTRANS_TYPE_EDIT_ODF_TEXT_FLAT
+: SCTRANS_TYPE_EDIT_BIN)),
+rFlavor);
+}
 }
 else if ( ScImportExport::IsFormatSupported( nFormat ) || nFormat == 
SotClipboardFormatId::RTF
 || nFormat == SotClipboardFormatId::RICHTEXT )

core.git: sc/source

[Matt K (via logerrit)]

 sc/source/core/data/document.cxx |   14 +-
 1 file changed, 9 insertions(+), 5 deletions(-)

New commits:
commit 59927dedc31eb5d51b417a02ae927eb578b90bd6
Author: Matt K 
AuthorDate: Sat Jan 13 17:30:59 2024 -0600
Commit: Mike Kaganski 
CommitDate: Sun Jan 14 05:40:39 2024 +0100

tdf#151752 Fix crash when selecting unprotected cells and copy/pasting

The problem is that the code attemps to index into maTabs when looping
through clipboard ranges, but maTabs.size() can be 0 at that point
thus resulting in a crash.  The fix is to first check if maTabs.size()
is greater than 0 before doing the looping.

Change-Id: Ib2fc4c9f847f87f44a68ad6d73c2745d79b5caa5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162032
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sc/source/core/data/document.cxx b/sc/source/core/data/document.cxx
index c44672048b39..71ea5bfc20a1 100644
--- a/sc/source/core/data/document.cxx
+++ b/sc/source/core/data/document.cxx
@@ -3259,12 +3259,16 @@ bool ScDocument::HasClipFilteredRows()
 if ( rClipRanges.empty() )
 return false;
 
-for ( size_t i = 0, n = rClipRanges.size(); i < n; ++i )
+if (maTabs.size() > 0)
 {
-ScRange & rRange = rClipRanges[ i ];
-bool bAnswer = maTabs[nCountTab]->HasFilteredRows(rRange.aStart.Row(), 
rRange.aEnd.Row());
-if (bAnswer)
-return true;
+for (size_t i = 0, n = rClipRanges.size(); i < n; ++i)
+{
+ScRange& rRange = rClipRanges[i];
+bool bAnswer
+= maTabs[nCountTab]->HasFilteredRows(rRange.aStart.Row(), 
rRange.aEnd.Row());
+if (bAnswer)
+return true;
+}
 }
 return false;
 }

[outreachy] Project progress (week 6)

[khushi gautam]

Hi Folks,

Here comes the 6 weeks report of my project progress. I feel proud to
mention that I am all going according to my project timeline. My mentors
Jim and Heiko are ones who are always available to resolve any issue and
make working in the LO environment much more fun. Learning new things and
encountering such a big codebase is itself a task whenever I initiate any
new milestone per week in the project.

I started this project by making a UI layout of a quick find panel on glade
(using a virtual box for that). Next I integrated the ui with the code to
make the Find Deck icon appear on the sidebar panel. Following up with
that, I spent some more time on glade in figuring out how to expand the
treeview component. This is all about making a structure.

Consequently, I first made the search bar track the keywords on entering
the search field. I connected the entry control to the source and to add an
activate handler for it. Made functions named as FillSearchFindsList().
Sequencing, I built a functionality similar to "Find all" in the quick
search bar. On entering the keyword it highlights corresponding words in
the document. Currently, I am half way on accomplishing the task of
fetching a string of words from the right hand side and left hand side of
the selected word. Once make build stops giving the errors I think I will
be good to go. As Jim said in LO we make change, test it out, think, think,
make change, test until we get a successful outcome.

Here is the link to my current blog that I am maintaining during my whole
outreachy journey : https://khushishikhu.hashnode.dev/outreachy-week-6

Happy Hacking!!

Thank You!!

Khushi Gautam

[Bug 158928] Blurring of Calc cells when the curser goes from one cell to a group of cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158928

--- Comment #4 from kdub  ---
I saw the images you sent me through email. Can you provide that file or a
similar file? I want to try to replicate it on my system. If I manage to
replicate it with your file, I can then find when this bug was introduced to
the code base for the developers to take a look at it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: no JDK found

[Mike Kaganski]

On 1/13/2024 11:24 PM, y27p6e3vu...@web.de wrote:
it is not finding C++ build tools (Win 10 SDK), even if Visual Studio is 
available. I have to use the option "--with-visual-studio=2022"


Yes, it is expected and normal. We keep the baseline at VS 2019 level 
[1] (IIUC, this is what the official builds are created with), and so VS 
2022 requires explicit choice (which is documented in the wiki [2], 
which is up-to-date in this regard).


it is not finding JDK, even if it is available. Option 
"--with-jdk-home=/cygdrive/c/jdk-21.0.1/bin" is not solving the issue.


The documentation does not say to use path to the bin directory. It 
should be like '--with-jdk-home=c:/jdk-21.0.1' (of course, 'cygdrive' 
syntax will also work, just don't understand why it's still suggested 
(beside the only place where it's relevant - in Unix-style PATH) - I 
have just dropped it from wiki).


[1] https://opengrok.libreoffice.org/xref/core/README.md?r=d6d4cae1
[2] 
https://wiki.documentfoundation.org/Development/BuildingOnWindows#Switching_to_non-default_compiler


--
Best regards,
Mike Kaganski

[Bug 158914] Calc leaks RAM in response to any action

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158914

--- Comment #6 from kdub  ---
> Mine appears identical to @kdub's except that he's using a better Mac ;-)
> 
> Still looks like something about my environment must be triggering the
> behavior.

Lol, yes, our Macs are almost identical.

Honestly, this is probably pretty obvious, but I would look into anything that
captures mouse input. For example, do you have a mouse settings program running
in the background or something similar?

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: editeng/CppunitTest_editeng_core.mk editeng/qa

[Tomaž Vajngerl (via logerrit)]

 editeng/CppunitTest_editeng_core.mk |1 
 editeng/qa/unit/core-test.cxx   |   74 
 2 files changed, 75 insertions(+)

New commits:
commit 67abfa11b611dc4ed98a660ec238fe76475200fa
Author: Tomaž Vajngerl 
AuthorDate: Fri Jan 12 12:56:00 2024 +0900
Commit: Tomaž Vajngerl 
CommitDate: Sun Jan 14 04:51:36 2024 +0100

editeng: add simple test for CreateLines method

Change-Id: I4fd13727a1edc20220a95dd4899b91bdef088111
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162011
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/editeng/CppunitTest_editeng_core.mk 
b/editeng/CppunitTest_editeng_core.mk
index 3fc6d9bde688..9352ddbd83e2 100644
--- a/editeng/CppunitTest_editeng_core.mk
+++ b/editeng/CppunitTest_editeng_core.mk
@@ -56,6 +56,7 @@ $(eval $(call gb_CppunitTest_use_externals,editeng_core,\
 
 $(eval $(call gb_CppunitTest_set_include,editeng_core,\
 -I$(SRCDIR)/editeng/inc \
+-I$(SRCDIR)/editeng/source/editeng \
 $$(INCLUDE) \
 ))
 
diff --git a/editeng/qa/unit/core-test.cxx b/editeng/qa/unit/core-test.cxx
index c17fccf1caef..e0fb7ada253c 100644
--- a/editeng/qa/unit/core-test.cxx
+++ b/editeng/qa/unit/core-test.cxx
@@ -14,6 +14,7 @@
 #include 
 
 #include 
+#include 
 
 #include 
 #include 
@@ -114,6 +115,7 @@ public:
 
 void testSingleLine();
 void testMoveParagraph();
+void testCreateLines();
 
 DECL_STATIC_LINK( Test, CalcFieldValueHdl, EditFieldInfo*, void );
 
@@ -141,6 +143,7 @@ public:
 CPPUNIT_TEST(testTdf148148);
 CPPUNIT_TEST(testSingleLine);
 CPPUNIT_TEST(testMoveParagraph);
+CPPUNIT_TEST(testCreateLines);
 CPPUNIT_TEST_SUITE_END();
 
 private:
@@ -2073,6 +2076,77 @@ void Test::testMoveParagraph()
 CPPUNIT_ASSERT_EQUAL(OUString("Paragraph 5"), aEditEngine.GetText(4));
 }
 
+void Test::testCreateLines()
+{
+ScopedVclPtrInstance 
pVirtualDevice(DeviceFormat::WITHOUT_ALPHA);
+
+EditEngine aEditEngine(mpItemPool.get());
+aEditEngine.SetRefDevice(pVirtualDevice.get());
+aEditEngine.SetPaperSize(Size(500, 500));
+aEditEngine.SetText("ABC
ABC DEF ABC DEFGH");
+
+CPPUNIT_ASSERT_EQUAL(true, aEditEngine.IsFormatted());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(2), aEditEngine.GetParagraphCount());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(1), aEditEngine.GetLineCount(0));
+CPPUNIT_ASSERT_EQUAL(sal_Int32(5), aEditEngine.GetLineCount(1));
+
+ParaPortionList& rParagraphPortionList = aEditEngine.GetParaPortions();
+CPPUNIT_ASSERT_EQUAL(sal_Int32(2), rParagraphPortionList.Count());
+
+{
+EditLineList& rLines = rParagraphPortionList[0]->GetLines();
+CPPUNIT_ASSERT_EQUAL(sal_Int32(1), rLines.Count());
+EditLine const& rLine = rLines[0];
+
+CPPUNIT_ASSERT_EQUAL(sal_Int32(0), rLine.GetStart());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(3), rLine.GetEnd());
+
+std::vector const& rArray = rLine.GetCharPosArray();
+CPPUNIT_ASSERT_EQUAL(size_t(3), rArray.size());
+
+CPPUNIT_ASSERT_EQUAL(sal_Int32(173), rArray[0]);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(333), rArray[1]);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(493), rArray[2]);
+}
+
+{
+EditLineList& rLines = rParagraphPortionList[1]->GetLines();
+CPPUNIT_ASSERT_EQUAL(sal_Int32(5), rLines.Count());
+
+{
+EditLine const& rLine = rLines[0];
+CPPUNIT_ASSERT_EQUAL(sal_Int32(0), rLine.GetStart());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(4), rLine.GetEnd());
+}
+
+{
+EditLine const& rLine = rLines[1];
+CPPUNIT_ASSERT_EQUAL(sal_Int32(4), rLine.GetStart());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(8), rLine.GetEnd());
+}
+
+{
+EditLine const& rLine = rLines[2];
+CPPUNIT_ASSERT_EQUAL(sal_Int32(8), rLine.GetStart());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(12), rLine.GetEnd());
+}
+
+{
+EditLine const& rLine = rLines[3];
+CPPUNIT_ASSERT_EQUAL(sal_Int32(12), rLine.GetStart());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(15), rLine.GetEnd());
+}
+
+{
+EditLine const& rLine = rLines[4];
+CPPUNIT_ASSERT_EQUAL(sal_Int32(15), rLine.GetStart());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(17), rLine.GetEnd());
+}
+}
+
+// CPPUNIT_ASSERT_MESSAGE("INTENTIONALLY FALSE", false);
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(Test);
 
 }

core.git: 2 commits - editeng/inc editeng/source

[Tomaž Vajngerl (via logerrit)]

 editeng/inc/EditLineList.hxx|7 +-
 editeng/source/editeng/impedit.hxx  |6 +-
 editeng/source/editeng/impedit3.cxx |  101 
 editeng/source/editeng/impedit4.cxx |5 -
 4 files changed, 69 insertions(+), 50 deletions(-)

New commits:
commit bf82669bf76428d00cc2c6041daf2c7a4812ceae
Author: Tomaž Vajngerl 
AuthorDate: Fri Jan 12 12:54:15 2024 +0900
Commit: Tomaž Vajngerl 
CommitDate: Sun Jan 14 04:51:27 2024 +0100

editeng: use unique_ptr for Append and Insert into a EditLineList

We can better handle the lifecycle of the EditLine this way.

Change-Id: I6fa3834bfdc19576158370a2c82da0771529a7f2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162010
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/editeng/inc/EditLineList.hxx b/editeng/inc/EditLineList.hxx
index a3a547d7ce24..e28ce6692764 100644
--- a/editeng/inc/EditLineList.hxx
+++ b/editeng/inc/EditLineList.hxx
@@ -64,10 +64,11 @@ public:
 const EditLine& operator[](sal_Int32 nPos) const { return *maLines[nPos]; }
 EditLine& operator[](sal_Int32 nPos) { return *maLines[nPos]; }
 
-void Append(EditLine* p) { 
maLines.push_back(std::unique_ptr(p)); }
-void Insert(sal_Int32 nPos, EditLine* p)
+void Append(std::unique_ptr pEditLine) { 
maLines.push_back(std::move(pEditLine)); }
+
+void Insert(sal_Int32 nPos, std::unique_ptr pEditLine)
 {
-maLines.insert(maLines.begin() + nPos, std::unique_ptr(p));
+maLines.insert(maLines.begin() + nPos, std::move(pEditLine));
 }
 };
 
diff --git a/editeng/source/editeng/impedit3.cxx 
b/editeng/source/editeng/impedit3.cxx
index 6dcf3fcdbff6..49e0015280f1 100644
--- a/editeng/source/editeng/impedit3.cxx
+++ b/editeng/source/editeng/impedit3.cxx
@@ -702,8 +702,7 @@ bool ImpEditEngine::CreateLines( sal_Int32 nPara, 
sal_uInt32 nStartPosY )
 
 if ( pParaPortion->GetLines().Count() == 0 )
 {
-EditLine* pLine = new EditLine;
-pParaPortion->GetLines().Append(pLine);
+pParaPortion->GetLines().Append(std::make_unique());
 }
 
 // Get Paragraph attributes...
@@ -1725,7 +1724,7 @@ bool ImpEditEngine::CreateLines( sal_Int32 nPara, 
sal_uInt32 nStartPosY )
 if ( nIndex < pNode->Len() )
 {
 pLine = new EditLine;
-pParaPortion->GetLines().Insert(++nLine, pLine);
+pParaPortion->GetLines().Insert(++nLine, 
std::unique_ptr(pLine));
 }
 else if ( nIndex && bLineBreak && GetTextRanger() )
 {
@@ -1734,7 +1733,7 @@ bool ImpEditEngine::CreateLines( sal_Int32 nPara, 
sal_uInt32 nStartPosY )
 TextPortion* pDummyPortion = new TextPortion( 0 );
 pParaPortion->GetTextPortions().Append(pDummyPortion);
 pLine = new EditLine;
-pParaPortion->GetLines().Insert(++nLine, pLine);
+pParaPortion->GetLines().Insert(++nLine, 
std::unique_ptr(pLine));
 bForceOneRun = true;
 bProcessingEmptyLine = true;
 }
@@ -1775,7 +1774,7 @@ void ImpEditEngine::CreateAndInsertEmptyLine( 
ParaPortion* pParaPortion )
 EditLine* pTmpLine = new EditLine;
 pTmpLine->SetStart( pParaPortion->GetNode()->Len() );
 pTmpLine->SetEnd( pParaPortion->GetNode()->Len() );
-pParaPortion->GetLines().Append(pTmpLine);
+pParaPortion->GetLines().Append(std::unique_ptr(pTmpLine));
 
 bool bLineBreak = pParaPortion->GetNode()->Len() > 0;
 sal_Int32 nSpaceBefore = 0;
diff --git a/editeng/source/editeng/impedit4.cxx 
b/editeng/source/editeng/impedit4.cxx
index 337d30b096df..6140fc9a7250 100644
--- a/editeng/source/editeng/impedit4.cxx
+++ b/editeng/source/editeng/impedit4.cxx
@@ -1148,8 +1148,7 @@ std::unique_ptr 
ImpEditEngine::CreateTextObject( EditSelection a
 for ( n = 0; n < nCount; n++ )
 {
 const EditLine& rLine = pParaPortion->GetLines()[n];
-EditLine* pNew = rLine.Clone();
-pX->aLines.Append(pNew);
+pX->aLines.Append(std::unique_ptr(rLine.Clone()));
 }
 #ifdef DBG_UTIL
 sal_uInt16 nTest;
@@ -1348,7 +1347,7 @@ EditSelection ImpEditEngine::InsertTextObject( const 
EditTextObject& rTextObject
 const EditLine& rLine = rXP.aLines[m];
 EditLine* pNew = rLine.Clone();
 pNew->SetInvalid(); // Paint again!
-pParaPortion->GetLines().Append(pNew);
+
pParaPortion->GetLines().Append(std::unique_ptr(pNew));
 }
 #ifdef DBG_UTIL
 sal_uInt16 nTest;
commit c00f1227d3b9086c94aacea1c25496b73d32dc93
Author: Tomaž Vajngerl 
AuthorDate: Mon Jan 8 17:08:11 2024 +0900
Commit: Tomaž Vajngerl 
CommitDate: Sun Jan 14 04:51:18 2024 +0100

editeng: split up some 

[Bug 159160] Typing freezes and Command Bar Drop down commands disappear

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159160

--- Comment #5 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 156335] Word -> Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=156335

--- Comment #2 from QA Administrators  ---
Dear Michael,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 156326] :

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=156326

--- Comment #2 from QA Administrators  ---
Dear w.morrison194,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 123972] UI menu disappears before submenu can open (GTK3 and Wayland)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123972

--- Comment #27 from QA Administrators  ---
Dear Nick Levinson,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 102046] Split and group buttons not exposed correctly on Linux

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102046

--- Comment #9 from QA Administrators  ---
Dear Yousuf Philips (jay) (retired),

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 77428] EDITING: Link field is corrupted with H2 JDBC

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=77428

--- Comment #7 from QA Administrators  ---
Dear vdenberg+bugzilla,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 76278] [EDITING][FIELD][UNDO] Updated user field does not respond to undo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=76278

--- Comment #13 from QA Administrators  ---
Dear Gergely Rácz,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 146720] UI: List in context menu for ordered list doesn't change the existing list style, but starts a new list

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146720

--- Comment #4 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 142824] New animation effect not the only one selected upon creation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142824

--- Comment #3 from QA Administrators  ---
Dear Eyal Rozenberg,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 146307] Full Accessibility Hierarchy of Cell in Calc Being Announced by NVDA after entering values

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146307

--- Comment #5 from QA Administrators  ---
Dear Richard B. McDonald,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 107648] CHARTS: Filtering makes subcategories disappear from graph display if there remains only one element

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107648

--- Comment #7 from QA Administrators  ---
Dear bureautiquelibre,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 123348] FILEOPEN DOCX Angular arrow’s head points in the wrong direction

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123348

--- Comment #7 from QA Administrators  ---
Dear NISZ LibreOffice Team,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158891] VIEWING: make cell cursor more accessible to colourblind users

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158891

--- Comment #24 from Sahil Gautam  ---
>From what I understand, the user should be able to change the color
configuration settings for 
a) accent color, which is used by both the active cell frame (the blue box),
and the highlight (both the selection and the column/row highlighting)

b) background color of the cell in edit mode (where we are typing something
[sah|<- cursor  ])

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159172] New: LO crashes on Raun macro, if extension installed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159172

Bug ID: 159172
   Summary: LO crashes on Raun macro, if extension installed
   Product: LibreOffice
   Version: 24.8.0.0 alpha0+ Master
  Hardware: All
   URL: https://github.com/antoniofaccioli/PortraitOrLandscape
/issues/5
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ti...@libreoffice.org

LO crashes on "Run macro", if extension PortraitOrLandscape installed for user
"Only for me". Not "For all users".

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158740] Crash at undo after pasting table in footnote

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158740

Patrick Luby  changed:

   What|Removed |Added

 CC||plub...@libreoffice.org

--- Comment #9 from Patrick Luby  ---
I have uploaded the following patch that stops the crashing described in
comment https://bugs.documentfoundation.org/show_bug.cgi?id=158740#c0 in my
local build on macOS Sonoma:

https://gerrit.libreoffice.org/c/core/+/162035

I don't know anything about the code surrounding this fix so I will wait for
the patch to be tested and/or reviewed by someone who is familiar with that
part of the Writer code. My worry is that, while LibreOffice will no longer
crash, adjusting the end node might leave the current Writer document in a
corrupted state.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159159] Mouse scrolling issues for v7.5.9 on Mac (intel)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159159

steve  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #3 from steve  ---


*** This bug has been marked as a duplicate of bug 155266 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

no JDK found

[y27p6e3vuNQx]

Hi,

 

I am trying to compile LO for the first time on windows and do follow the official guide

 

https://wiki.documentfoundation.org/Development/BuildingOnWindows

 

Nevertheless I am runnning into several issues while configuring the build.

 

Running autogen.sh gives errors,

 

it is not finding C++ build tools (Win 10 SDK), even if Visual Studio is available. I have to use the option "--with-visual-studio=2022"

it is not finding JDK, even if it is available. Option "--with-jdk-home=/cygdrive/c/jdk-21.0.1/bin" is not solving the issue.

 

The JDK was downloaded from Microsoft server as 64bit version and the PATH is set correctly.

 

There are hints in the documentation given above for Java installation and to eventually modify the "--with-jdk-home" in "autogen.input". There is no file "autogen.input"!

 

What is going wrong? Is the documentaion not up-to-date or do I am missing some details?

 

Greets

 

Joachim

 

[Bug 159171] Calc: crash after Edit->Select->Select Unprotected Cells upon a second time

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159171

Matt K  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |matt...@gmail.com
   |desktop.org |
 Status|UNCONFIRMED |ASSIGNED
 Ever confirmed|0   |1

--- Comment #2 from Matt K  ---
Fix is tracked in: https://gerrit.libreoffice.org/c/core/+/162033

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158891] VIEWING: make cell cursor more accessible to colourblind users

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158891

Sahil Gautam  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 151752] Calc: Crash after copy and paste all unprotected cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151752

Matt K  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |matt...@gmail.com
   |desktop.org |

--- Comment #11 from Matt K  ---
Fix is posted at: https://gerrit.libreoffice.org/c/core/+/162032

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 36310] [EDITING]"Insert cross-reference" drag-n-drop mode for navigator

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=36310

--- Comment #31 from Jim Raykowski  ---
Created attachment 191924
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191924=edit
Demo of inserting cross-references to captions by dragging from navigator

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 151752] Calc: Crash after copy and paste all unprotected cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151752

Matt K  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||9171

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159171] Calc: crash after Edit->Select->Select Unprotected Cells upon a second time

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159171

Matt K  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||1752

--- Comment #1 from Matt K  ---
Note this bug depends on tdf#151752 being fixed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159171] New: Calc: crash after Edit->Select->Select Unprotected Cells upon a second time

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159171

Bug ID: 159171
   Summary: Calc: crash after Edit->Select->Select Unprotected
Cells upon a second time
   Product: LibreOffice
   Version: 24.8.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: matt...@gmail.com

Description:
Calc: crash after Edit->Select->Select Unprotected Cells upon a second time

Steps to Reproduce:
1.Open Calc, select Edit->Select->Select Unprotected Cells
2.CTRL+C,CTRL+V
3.Type "f"
4.Select Edit->Select->Select Unprotected Cells
5.CTRL+C,CTRL+V

Actual Results:
Crash

Expected Results:
No crash


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 06b1d611dad281162a6a0a8fc495e51737687276
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: default; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159025] Crash in: SwTableNode::DelFrames(SwRootFrame const*) after pasting a table in footnote and undoing twice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159025

--- Comment #10 from Patrick Luby  ---
I have uploaded the following patch that stops the crashing in my local build
on macOS Sonoma:

https://gerrit.libreoffice.org/c/core/+/162031

I don't know anything about the code surrounding this fix so I will wait for
the patch to be tested and/or reviewed by someone who is familiar with that
part of the Writer code. My worry is that, while LibreOffice will no longer
crash, skipping an undo might leave the current Writer document in a corrupted
state.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159158] FILEOPEN DOCX: relativeHeight last-one-wins, and zOrders 0/1 are the maximum, while 2 is the lowest, then 3 up to 251658240

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159158

Justin L  changed:

   What|Removed |Added

 Attachment #191919|gradient-fill-preservation- |gradient-fill-preservation-
description|yellowBehindBlueH0.docx:|yellowBehindBlueH0.docx:
   |Yellow=0x0F00   |Yellow=0x0F00  Blue=1
   | Blue=1 |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159158] FILEOPEN DOCX: relativeHeight last-one-wins, and zOrders 0/1 are the maximum, while 2 is the lowest, then 3 up to 251658240

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159158

Justin L  changed:

   What|Removed |Added

 Attachment #191921|gradient-fill-preservation- |gradient-fill-preservation-
description|yellowBehindBlue0H.docx:|yellowBehindBlue0H.docx:
   |yellow=0, blue=0F00 |yellow=0, blue=0F00 
   |    |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159158] FILEOPEN DOCX: relativeHeight last-one-wins, and zOrders 0/1 are the maximum, while 2 is the lowest, then 3 up to 251658240

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159158

Justin L  changed:

   What|Removed |Added

 Attachment #191922|gradient-fill-preservation- |gradient-fill-preservation-
description|blueBehindYellow0G.docx:|blueBehindYellow0G.docx:
   |Yellow=0 Blue=0EFF  |Yellow=0 Blue=0EFF 
   |    |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159158] FILEOPEN DOCX: relativeHeight last-one-wins, and zOrders 0/1 are the maximum, while 2 is the lowest, then 3 up to 251658240

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159158

Justin L  changed:

   What|Removed |Added

 Attachment #191923|gradient-fill-preservation- |gradient-fill-preservation-
description|yellowBehindBlueI1.docx:|yellowBehindBlueI1.docx:
   |Yellow = 0F00   |Yellow = 0F00 0001 Blue = 1
   |0001 Blue = 1   |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159158] FILEOPEN DOCX: relativeHeight last-one-wins, and zOrders 0/1 are the maximum, while 2 is the lowest, then 3 up to 251658240

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159158

--- Comment #8 from Justin L  ---
OOPS: I got carried away in the Hex stuff.  It is 32bit, so only 0F00 .

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159158] FILEOPEN DOCX: relativeHeight last-one-wins, and zOrders 0/1 are the maximum, while 2 is the lowest, then 3 up to 251658240

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159158

Justin L  changed:

   What|Removed |Added

Summary|FILEOPEN DOCX:  |FILEOPEN DOCX:
   |relativeHeight zOrders of   |relativeHeight
   |0/1 apparently are rather   |last-one-wins, and zOrders
   |high, while 2 is the|0/1 are the maximum, while
   |lowest, then 3...   |2 is the lowest, then 3 up
   ||to 251658240

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159158] FILEOPEN DOCX: relativeHeight zOrders of 0/1 apparently are rather high, while 2 is the lowest, then 3...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159158

--- Comment #7 from Justin L  ---
Created attachment 191923
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191923=edit
gradient-fill-preservation-yellowBehindBlueI1.docx: Yellow = 0F00  
0001 Blue = 1

Another surprise! Since yellow is a higher number than the value of 0/1, I
expected blue to be behind. But it is in front - as it is for all larger
numbers. So 0 and 1 really are the maximum after all...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159158] FILEOPEN DOCX: relativeHeight zOrders of 0/1 apparently are rather high, while 2 is the lowest, then 3...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159158

--- Comment #6 from Justin L  ---
Created attachment 191922
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191922=edit
gradient-fill-preservation-blueBehindYellow0G.docx: Yellow=0 Blue=0EFF 
 

This one wasn't really necessary, but I included it for completeness. It shows
that 0 is greater than 251658239

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: sdext/source

[Thorsten Behrens (via logerrit)]

 sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx |   12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 1637610478c4493c29a29286b66250ef47507681
Author: Thorsten Behrens 
AuthorDate: Sat Jan 13 21:40:09 2024 +0100
Commit: Thorsten Behrens 
CommitDate: Sat Jan 13 23:52:08 2024 +0100

Fix obscure xpdfimport crash on missing fonts

Invert logic, such that the case WMode == 0 and no font set now run
the former else branch. Happened here for an obscure pdf I was missing
some fonts for.

Change-Id: I2825c914a04f6a95d459eeeffb8091ed8f1819dc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162029
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx 
b/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx
index 3ad139b65fa3..2517618e1019 100644
--- a/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx
+++ b/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx
@@ -956,18 +956,18 @@ void PDFOutDev::drawChar(GfxState *state, double x, 
double y,
 
 double csdx = 0.0;
 double csdy = 0.0;
-if (state->getFont()->getWMode())
+if (!state->getFont() || !state->getFont()->getWMode())
 {
-csdy = state->getCharSpace();
+csdx = state->getCharSpace();
 if (*u == ' ')
-csdy += state->getWordSpace();
+csdx += state->getWordSpace();
+csdx *= state->getHorizScaling();
 }
 else
 {
-csdx = state->getCharSpace();
+csdy = state->getCharSpace();
 if (*u == ' ')
-csdx += state->getWordSpace();
-csdx *= state->getHorizScaling();
+csdy += state->getWordSpace();
 }
 
 double cstdx = 0.0;

[Bug 137316] Under X the middle mouse button usually pastes which is super nice but LO asks about language which is horrible

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137316

Sahil Gautam  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159158] FILEOPEN DOCX: relativeHeight zOrders of 0/1 apparently are rather high, while 2 is the lowest, then 3...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159158

--- Comment #5 from Justin L  ---
Created attachment 191921
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191921=edit
gradient-fill-preservation-yellowBehindBlue0H.docx: yellow=0, blue=0F00 
 

and of course, since they are the same value, switching them around makes no
difference since the last always wins. It proves they are the same value, if
not then the yellow would have come to the top.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159167] Conditional formatting of cells based on rules for checking values greater than or less than

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159167

m_a_riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #8 from m_a_riosv  ---
Created attachment 191920
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191920=edit
Modified file

If I have interpreted fine, what is required.

Instead of the second row range in the condition, put
$Tabelle1.A$2
Having a relative column, it is adapted by CFF as it evolves on the range with
the condition.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159158] FILEOPEN DOCX: relativeHeight zOrders of 0/1 apparently are rather high, while 2 is the lowest, then 3...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159158

--- Comment #4 from Justin L  ---
Created attachment 191919
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191919=edit
gradient-fill-preservation-yellowBehindBlueH0.docx: Yellow=0x0F00  
 Blue=1

So, we already have determined that 0 and 1 are the same zOrder value. I
calculated that value to be 251658240.

In this example, Blue=0, but since it is defined last, it wins and is in front.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159165] Bad rendering in presentation mode

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159165

m_a_riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #2 from m_a_riosv  ---
Created attachment 191918
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191918=edit
Screenshot of presentation

I think it's fine for me:
Version: 7.6.4.1 (X86_64) / LibreOffice Community
Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: default; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: chart2/source connectivity/source framework/source include/oox oox/source sc/source ucb/source vcl/inc writerfilter/source xmlhelp/source

[Caolán McNamara (via logerrit)]

 chart2/source/model/main/ChartModel.cxx  |   21 ---
 chart2/source/model/main/Diagram.cxx |4 +-
 chart2/source/view/charttypes/CandleStickChart.cxx   |4 --
 connectivity/source/manager/mdrivermanager.cxx   |4 +-
 framework/source/services/frame.cxx  |   18 +++-
 include/oox/helper/refvector.hxx |6 ++--
 oox/source/ole/vbaproject.cxx|4 +-
 sc/source/core/data/column.cxx   |8 +++--
 sc/source/core/data/table3.cxx   |   12 +---
 ucb/source/core/ucbstore.cxx |2 -
 vcl/inc/jsdialog/jsdialogbuilder.hxx |6 ++--
 writerfilter/source/dmapper/DomainMapperTableHandler.cxx |5 ++-
 writerfilter/source/ooxml/OOXMLDocumentImpl.cxx  |8 ++---
 xmlhelp/source/cxxhelp/provider/databases.cxx|3 --
 14 files changed, 57 insertions(+), 48 deletions(-)

New commits:
commit 0cfb4aa2623b1606bbc66ef16256315778143227
Author: Caolán McNamara 
AuthorDate: Sat Jan 13 19:13:00 2024 +
Commit: Caolán McNamara 
CommitDate: Sat Jan 13 22:53:50 2024 +0100

cid#1546354 COPY_INSTEAD_OF_MOVE

and

cid#1546319 COPY_INSTEAD_OF_MOVE
cid#1546286 COPY_INSTEAD_OF_MOVE
cid#1546283 COPY_INSTEAD_OF_MOVE
cid#1546191 COPY_INSTEAD_OF_MOVE
cid#1545953 COPY_INSTEAD_OF_MOVE
cid#1545874 COPY_INSTEAD_OF_MOVE
cid#1545857 COPY_INSTEAD_OF_MOVE
cid#1545781 COPY_INSTEAD_OF_MOVE
cid#1545765 COPY_INSTEAD_OF_MOVE
cid#1545546 COPY_INSTEAD_OF_MOVE
cid#1545338 COPY_INSTEAD_OF_MOVE
cid#1545190 COPY_INSTEAD_OF_MOVE
cid#1545272 COPY_INSTEAD_OF_MOVE
cid#1545242 COPY_INSTEAD_OF_MOVE
cid#1545229 COPY_INSTEAD_OF_MOVE

Change-Id: I88813d9dbd87ce10375db8198028f8b70e23f0fa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162027
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/chart2/source/model/main/ChartModel.cxx 
b/chart2/source/model/main/ChartModel.cxx
index 19fccff373e9..6c4fe2dfa658 100644
--- a/chart2/source/model/main/ChartModel.cxx
+++ b/chart2/source/model/main/ChartModel.cxx
@@ -159,17 +159,20 @@ ChartModel::ChartModel( const ChartModel & rOther )
 if (rOther.m_xDiagram.is())
 xNewDiagram = new ::chart::Diagram( *rOther.m_xDiagram );
 rtl::Reference< ::chart::PageBackground > xNewPageBackground = new 
PageBackground( *rOther.m_xPageBackground );
-rtl::Reference< ::chart::ChartTypeManager > xChartTypeManager; // does 
not implement XCloneable
-rtl::Reference< ::chart::NameContainer > xXMLNamespaceMap = new 
NameContainer( *rOther.m_xXMLNamespaceMap );
 
 {
-MutexGuard aGuard( m_aModelMutex );
-xListener = this;
-m_xTitle = xNewTitle;
-m_xDiagram = xNewDiagram;
-m_xPageBackground = xNewPageBackground;
-m_xChartTypeManager = xChartTypeManager;
-m_xXMLNamespaceMap = xXMLNamespaceMap;
+rtl::Reference< ::chart::ChartTypeManager > xChartTypeManager; // 
does not implement XCloneable
+rtl::Reference< ::chart::NameContainer > xXMLNamespaceMap = new 
NameContainer( *rOther.m_xXMLNamespaceMap );
+
+{
+MutexGuard aGuard( m_aModelMutex );
+xListener = this;
+m_xTitle = xNewTitle;
+m_xDiagram = xNewDiagram;
+m_xPageBackground = std::move(xNewPageBackground);
+m_xChartTypeManager = std::move(xChartTypeManager);
+m_xXMLNamespaceMap = std::move(xXMLNamespaceMap);
+}
 }
 
 ModifyListenerHelper::addListener( xNewTitle, xListener );
diff --git a/chart2/source/model/main/Diagram.cxx 
b/chart2/source/model/main/Diagram.cxx
index 99065d8910c5..2a4b63c73401 100644
--- a/chart2/source/model/main/Diagram.cxx
+++ b/chart2/source/model/main/Diagram.cxx
@@ -1098,11 +1098,11 @@ static bool lcl_moveSeriesOrCheckIfMoveIsAllowed(
 std::vector< rtl::Reference< 
DataSeries > > aOtherSeriesList = xOtherChartType->getDataSeries2();
 if( !aOtherSeriesList.empty() )
 {
-rtl::Reference< DataSeries > 
xExchangeSeries( aOtherSeriesList[0] );
+rtl::Reference 
xExchangeSeries(aOtherSeriesList[0]);
 aOtherSeriesList[0] = 
xGivenDataSeries;
 
xOtherChartType->setDataSeries(aOtherSeriesList);
 
-
aSeriesList[nOldSeriesIndex]=xExchangeSeries;
+aSeriesList[nOldSeriesIndex] = 
std::move(xExchangeSeries);
 

[Bug 143249] Improve configuration of table borders

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143249

Telesto  changed:

   What|Removed |Added

 CC||jens.d...@live.de

--- Comment #45 from Telesto  ---
*** Bug 159098 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159098] Have to click twice for (second and next) border

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159098

Telesto  changed:

   What|Removed |Added

 CC||tele...@surfxs.nl
 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #3 from Telesto  ---
This is covered by bug 143249, I think

*** This bug has been marked as a duplicate of bug 143249 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159144] Writer freezes/crashes when changing page style to landscape

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159144

Telesto  changed:

   What|Removed |Added

   Keywords|bibisected  |bibisectRequest

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: vcl/unx

[Julien Nabet (via logerrit)]

 vcl/unx/gtk3/gtksalmenu.cxx |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit d3963918544888608da149c3f0206d7a96828361
Author: Julien Nabet 
AuthorDate: Sat Jan 13 18:03:53 2024 +0100
Commit: Caolán McNamara 
CommitDate: Sat Jan 13 22:29:03 2024 +0100

Add missing g_object_unref (vcl/gtksalmenu)

Change-Id: I07db3d7a03da94b53ad49188c229c134dc2f663c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162017
Reviewed-by: Julien Nabet 
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/gtksalmenu.cxx b/vcl/unx/gtk3/gtksalmenu.cxx
index 804c1d017ac9..ddfa5ef36b48 100644
--- a/vcl/unx/gtk3/gtksalmenu.cxx
+++ b/vcl/unx/gtk3/gtksalmenu.cxx
@@ -125,6 +125,7 @@ static void RemoveDisabledItemsFromNativeMenu(GLOMenu* 
pMenu, GList** pOldComman
 g_free(pSubCommand);
 }
 }
+g_object_unref(pSubMenuModel);
 }
 }
 
@@ -1362,7 +1363,8 @@ bool GtkSalMenu::NativeSetItemCommand( unsigned nSection,
 
 if ( aCurrentCommand == nullptr || g_strcmp0( aCurrentCommand, aCommand ) 
!= 0 )
 {
-bool bOldHasSubmenu = 
g_lo_menu_get_submenu_from_item_in_section(pMenu, nSection, nItemPos) != 
nullptr;
+GLOMenu* pSubMenuModel = 
g_lo_menu_get_submenu_from_item_in_section(pMenu, nSection, nItemPos);
+bool bOldHasSubmenu = pSubMenuModel != nullptr;
 bSubMenuAddedOrRemoved = bOldHasSubmenu != bIsSubmenu;
 if (bSubMenuAddedOrRemoved)
 {
@@ -1386,6 +1388,8 @@ bool GtkSalMenu::NativeSetItemCommand( unsigned nSection,
 g_lo_menu_set_action_and_target_value_to_item_in_section( pMenu, 
nSection, nItemPos, aItemCommand, pTarget );
 pTarget = nullptr;
 }
+if (bOldHasSubmenu)
+g_object_unref(pSubMenuModel);
 
 g_free( aItemCommand );
 }

core.git: Branch 'libreoffice-24-2' - vcl/unx

[Julien Nabet (via logerrit)]

 vcl/unx/gtk3/gtkinst.cxx |   16 
 1 file changed, 16 insertions(+)

New commits:
commit f2155b5c6051d68659bea45c0331b53eaaced45d
Author: Julien Nabet 
AuthorDate: Sat Jan 13 15:38:28 2024 +0100
Commit: Caolán McNamara 
CommitDate: Sat Jan 13 22:28:45 2024 +0100

Add missing gdk_event_free (vcl/gtkinst)

Change-Id: I8bef4c3303f8f2fd89c1cf7cec35536c38d9d4d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162001
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index 1dafaa04d595..8bdeb8621549 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -11097,10 +11097,16 @@ private:
 gtk_main_do_event(pKeyEvent);
 
 GdkEvent *pTriggerEvent = gtk_get_current_event();
+bool bEventOwnership = true;
 if (!pTriggerEvent)
+{
 pTriggerEvent = pKeyEvent;
+bEventOwnership = false;
+}
 
 gtk_menu_popup_at_widget(m_pMenu, pWidget, GDK_GRAVITY_SOUTH_WEST, 
GDK_GRAVITY_NORTH_WEST, pTriggerEvent);
+if (bEventOwnership)
+gdk_event_free(pTriggerEvent);
 
 gdk_event_free(pKeyEvent);
 }
@@ -8,6 +11124,7 @@ private:
 {
 gdk_event_get_button(pEvent, );
 nTime = gdk_event_get_time(pEvent);
+gdk_event_free(pEvent);
 }
 else
 {
@@ -11459,8 +11466,12 @@ public:
 gtk_main_do_event(pKeyEvent);
 
 GdkEvent *pTriggerEvent = gtk_get_current_event();
+bool bEventOwnership = true;
 if (!pTriggerEvent)
+{
 pTriggerEvent = pKeyEvent;
+bEventOwnership = false;
+}
 
 bool bSwapForRTL = SwapForRTL(pWidget);
 
@@ -11478,6 +11489,8 @@ public:
 else
 gtk_menu_popup_at_rect(m_pMenu, 
widget_get_surface(pWidget), , GDK_GRAVITY_NORTH_EAST, 
GDK_GRAVITY_NORTH_WEST, pTriggerEvent);
 }
+if (bEventOwnership)
+gdk_event_free(pTriggerEvent);
 
 gdk_event_free(pKeyEvent);
 }
@@ -11500,6 +11513,7 @@ public:
 if (!gdk_event_get_button(pEvent, ))
 nButton = 0;
 nTime = gdk_event_get_time(pEvent);
+gdk_event_free(pEvent);
 }
 else
 {
@@ -14136,6 +14150,8 @@ private:
 #if !GTK_CHECK_VERSION(4, 0, 0)
 GdkEvent *pEvent = gtk_get_current_event();
 m_bChangedByMouse = pEvent && categorizeEvent(pEvent) == 
VclInputFlags::MOUSE;
+if (pEvent)
+gdk_event_free(pEvent);
 #else
 //TODO maybe iterate over gtk_widget_observe_controllers looking for a 
motion controller
 #endif

core.git: 2 commits - dbaccess/source editeng/source

[Caolán McNamara (via logerrit)]

 dbaccess/source/core/api/KeySet.cxx |3 +--
 editeng/source/editeng/impedit4.cxx |   12 +---
 2 files changed, 10 insertions(+), 5 deletions(-)

New commits:
commit aff6d3aa461b737130606ed1271568b94f4733a7
Author: Caolán McNamara 
AuthorDate: Sat Jan 13 19:33:30 2024 +
Commit: Caolán McNamara 
CommitDate: Sat Jan 13 22:09:28 2024 +0100

cid#1545795 silence Using invalid iterator

Change-Id: I5fc75150ce38a960fab092b2e7ac9a0fe642b26a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162026
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/editeng/source/editeng/impedit4.cxx 
b/editeng/source/editeng/impedit4.cxx
index 7fa5389475e3..337d30b096df 100644
--- a/editeng/source/editeng/impedit4.cxx
+++ b/editeng/source/editeng/impedit4.cxx
@@ -467,7 +467,9 @@ ErrCode ImpEditEngine::WriteRTF( SvStream& rOutput, 
EditSelection aSel )
 SfxStyleSheet* pParent = 
static_cast(GetStyleSheetPool()->Find( pStyle->GetParent(), 
pStyle->GetFamily() ));
 DBG_ASSERT( pParent, "Parent not found!" );
 rOutput.WriteOString( OOO_STRING_SVTOOLS_RTF_SBASEDON );
-nNumber = aStyleSheetToIdMap.find(pParent)->second;
+auto iter = aStyleSheetToIdMap.find(pParent);
+assert(iter != aStyleSheetToIdMap.end());
+nNumber = iter->second;
 rOutput.WriteNumberAsString( nNumber );
 }
 
@@ -479,7 +481,9 @@ ErrCode ImpEditEngine::WriteRTF( SvStream& rOutput, 
EditSelection aSel )
 
 DBG_ASSERT( pNext, "Next not found!" );
 rOutput.WriteOString( OOO_STRING_SVTOOLS_RTF_SNEXT );
-nNumber = aStyleSheetToIdMap.find(pNext)->second;
+auto iter = aStyleSheetToIdMap.find(pNext);
+assert(iter != aStyleSheetToIdMap.end());
+nNumber = iter->second;
 rOutput.WriteNumberAsString( nNumber );
 
 // Name of the template...
@@ -526,7 +530,9 @@ ErrCode ImpEditEngine::WriteRTF( SvStream& rOutput, 
EditSelection aSel )
 {
 // Number of template
 rOutput.WriteOString( OOO_STRING_SVTOOLS_RTF_S );
-sal_uInt32 nNumber = 
aStyleSheetToIdMap.find(pNode->GetStyleSheet())->second;
+auto iter = aStyleSheetToIdMap.find(pNode->GetStyleSheet());
+assert(iter != aStyleSheetToIdMap.end());
+sal_uInt32 nNumber = iter->second;
 rOutput.WriteNumberAsString( nNumber );
 
 // All Attribute
commit 44d77f760cdac0c4a1c89421f8e02514f57d411c
Author: Caolán McNamara 
AuthorDate: Sat Jan 13 19:22:58 2024 +
Commit: Caolán McNamara 
CommitDate: Sat Jan 13 22:09:21 2024 +0100

cid#1546059 xRow is always empty

Change-Id: Ic5c6b2463600cd449bf2e0fed829ce199172578c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162025
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/dbaccess/source/core/api/KeySet.cxx 
b/dbaccess/source/core/api/KeySet.cxx
index cfbec6afecef..d137dc9ab16b 100644
--- a/dbaccess/source/core/api/KeySet.cxx
+++ b/dbaccess/source/core/api/KeySet.cxx
@@ -539,7 +539,6 @@ void OKeySet::executeUpdate(const ORowSetRow& _rInsertRow 
,const ORowSetRow& _rO
 Reference< XParameters > xParameter(xPrep,UNO_QUERY);
 
 bool bRefetch = true;
-Reference xRow;
 sal_Int32 i = 1;
 // first the set values
 for (auto const& columnName : *m_pColumnNames)
@@ -585,7 +584,7 @@ void OKeySet::executeUpdate(const ORowSetRow& _rInsertRow 
,const ORowSetRow& _rO
 m_aKeyIter = m_aKeyMap.find(nBookmark);
 assert(m_aKeyIter != m_aKeyMap.end());
 m_aKeyIter->second.second.first = 2;
-m_aKeyIter->second.second.second = xRow;
+m_aKeyIter->second.second.second.clear();
 copyRowValue(_rInsertRow,m_aKeyIter->second.first,nBookmark);
 tryRefetch(_rInsertRow,bRefetch);
 }

core.git: 2 commits - chart2/source sw/source

[Caolán McNamara (via logerrit)]

 chart2/source/view/charttypes/VSeriesPlotter.cxx |6 +++---
 sw/source/ui/dialog/swdlgfact.cxx|2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit d68d45102948ac6d54584f60ba5e493036438d0d
Author: Caolán McNamara 
AuthorDate: Sat Jan 13 19:11:14 2024 +
Commit: Caolán McNamara 
CommitDate: Sat Jan 13 22:09:11 2024 +0100

cid#1546488 COPY_INSTEAD_OF_MOVE

Change-Id: I80b843351641e38af6b9f9d6001b89206e37991c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162024
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/sw/source/ui/dialog/swdlgfact.cxx 
b/sw/source/ui/dialog/swdlgfact.cxx
index daf0dd6ff3f1..66ac1ec21a25 100644
--- a/sw/source/ui/dialog/swdlgfact.cxx
+++ b/sw/source/ui/dialog/swdlgfact.cxx
@@ -599,7 +599,7 @@ void AbstractSwFieldDlg_Impl::SetText( const OUString& rStr 
)
 bool AbstractSwFieldDlg_Impl::StartExecuteAsync(AsyncContext )
 {
 auto xDlg = m_xDlg;
-return SfxTabDialogController::runAsync(m_xDlg, [=](sal_Int32 nResult){
+return SfxTabDialogController::runAsync(m_xDlg, [rCtx, 
xDlg=std::move(xDlg)](sal_Int32 nResult){
 xDlg->Close();
 if (rCtx.isSet())
 rCtx.maEndDialogFn(nResult);
commit 26c375988a913684320ef32ec85afb829913e687
Author: Caolán McNamara 
AuthorDate: Sat Jan 13 19:04:24 2024 +
Commit: Caolán McNamara 
CommitDate: Sat Jan 13 22:09:00 2024 +0100

cid#1585307 Out-of-bounds read

sizeof should probably have been std::size, but just replace with
range iteration anyway

Change-Id: I60d9d7d74a5c039ad49387b114d1142ca27b032a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162023
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/chart2/source/view/charttypes/VSeriesPlotter.cxx 
b/chart2/source/view/charttypes/VSeriesPlotter.cxx
index 34a702d7b696..948d5ef33f1f 100644
--- a/chart2/source/view/charttypes/VSeriesPlotter.cxx
+++ b/chart2/source/view/charttypes/VSeriesPlotter.cxx
@@ -2340,9 +2340,9 @@ const ROrderPair pairList[] = {
 sal_Int32 VSeriesPlotter::getRenderOrder() const
 {
 OUString aChartType = m_xChartTypeModel->getChartType();
-for (size_t n = 0; n < sizeof(pairList); ++n) {
-if (aChartType.equalsIgnoreAsciiCase(pairList[n].chartName)) {
-return pairList[n].renderOrder;
+for (const auto& elem : pairList) {
+if (aChartType.equalsIgnoreAsciiCase(elem.chartName)) {
+return elem.renderOrder;
 }
 }
 SAL_WARN("chart2", "Unsupported chart type in getRenderOrder()");

core.git: 2 commits - sc/source svl/source

[Caolán McNamara (via logerrit)]

 sc/source/ui/cctrl/tbzoomsliderctrl.cxx |   11 ++-
 svl/source/items/itemset.cxx|2 +-
 2 files changed, 7 insertions(+), 6 deletions(-)

New commits:
commit 2da65b3c04e35a293cd2e630ffd9bc24b3453814
Author: Caolán McNamara 
AuthorDate: Sat Jan 13 19:01:42 2024 +
Commit: Caolán McNamara 
CommitDate: Sat Jan 13 22:08:50 2024 +0100

cid#1585309 Dereference before null check

Change-Id: I49ab7a48e74055264037d6930692fdae8be6d3ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162022
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/svl/source/items/itemset.cxx b/svl/source/items/itemset.cxx
index 41051a981aa4..673cbea84c50 100644
--- a/svl/source/items/itemset.cxx
+++ b/svl/source/items/itemset.cxx
@@ -329,7 +329,7 @@ SfxPoolItem const* implCreateItemEntry(SfxItemPool& rPool, 
SfxPoolItem const* pS
 SfxItemPool* pMasterPool(rPool.GetMasterPool());
 assert(nullptr != pMasterPool);
 SfxItemPool* pTargetPool(pMasterPool);
-while (!pTargetPool->IsInRange(nWhich))
+while (pTargetPool && !pTargetPool->IsInRange(nWhich))
 pTargetPool = pTargetPool->GetSecondaryPool();
 
 // if this goes wrong, an Item with invalid ID for this pool is
commit 49cc32842a039ab6b8e180df5b24ae8a5b1bd27b
Author: Caolán McNamara 
AuthorDate: Sat Jan 13 18:59:32 2024 +
Commit: Caolán McNamara 
CommitDate: Sat Jan 13 22:08:38 2024 +0100

cid#1585306 Uninitialized scalar field

Change-Id: I3fa54356865f7f0cf322745c254eeb0867e6f422
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162021
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/sc/source/ui/cctrl/tbzoomsliderctrl.cxx 
b/sc/source/ui/cctrl/tbzoomsliderctrl.cxx
index d14dd1cb08c0..31eb73b0a8e5 100644
--- a/sc/source/ui/cctrl/tbzoomsliderctrl.cxx
+++ b/sc/source/ui/cctrl/tbzoomsliderctrl.cxx
@@ -216,11 +216,12 @@ void ScZoomSliderWnd::dispose()
 
 ScZoomSlider::ScZoomSlider(css::uno::Reference< css::frame::XDispatchProvider> 
xDispatchProvider,
sal_uInt16 nCurrentZoom)
-: mnCurrentZoom( nCurrentZoom ),
-  mnMinZoom( 10 ),
-  mnMaxZoom( 400 ),
-  mbOmitPaint( false ),
-  m_xDispatchProvider(std::move(xDispatchProvider))
+: mnSliderLength(0)
+, mnCurrentZoom(nCurrentZoom)
+, mnMinZoom(10)
+, mnMaxZoom(400)
+, mbOmitPaint(false)
+, m_xDispatchProvider(std::move(xDispatchProvider))
 {
 maSliderButton  = Image(StockImage::Yes, RID_SVXBMP_SLIDERBUTTON);
 maIncreaseButton= Image(StockImage::Yes, RID_SVXBMP_SLIDERINCREASE);

[Bug 159158] FILEOPEN DOCX: relativeHeight zOrders of 0/1 apparently are rather high, while 2 is the lowest, then 3...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159158

Justin L  changed:

   What|Removed |Added

Summary|FILEOPEN DOCX:  |FILEOPEN DOCX:
   |relativeHeight zOrder of 0  |relativeHeight zOrders of
   |apparently is the highest,  |0/1 apparently are rather
   |while 1 is the lowest, then |high, while 2 is the
   |2...|lowest, then 3...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159158] FILEOPEN DOCX: relativeHeight zOrder of 0 apparently is the highest, while 1 is the lowest, then 2...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159158

--- Comment #3 from Justin L  ---
Created attachment 191917
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191917=edit
gradient-fill-preservation-yellowBehindBlue22.docx: yellow=2, blue=2

Our zOrder generally says "first come, highest zOrder".

Sanity check: if I made Yellow=3, Blue=2, then yellow is in front? Yes. 

We do have a flag for "oldStyle" and this is compatibilityMode=12 (2007).
However, changing to 15 doesn't make any difference. So, I have to assume that
we have a conflict between z-Index doing first-wins and relativeHeight where
last-wins.

It is worth noting that MS Word 2019 replaced these conflicting 2's with new,
randomized positions. (Sanity check - verify that non-conflicting 3,2 was not
change? Correct - no change.)

Conclusion?
I guess that when we hit NS_ooxml::LN_CT_Anchor_relativeHeight, we need to
check if that zOrder is already registered. If so, bump up by 1.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: configure.ac

[Thorsten Behrens (via logerrit)]

 configure.ac |5 +
 1 file changed, 5 insertions(+)

New commits:
commit 0b4510c060dc881fdc7d95379b06a02c413ae051
Author: Thorsten Behrens 
AuthorDate: Sat Jan 13 19:42:18 2024 +0100
Commit: Thorsten Behrens 
CommitDate: Sat Jan 13 21:43:12 2024 +0100

system poppler cannot be used with dbgutil

Change-Id: I88d68e85c25bdaf6f4a06e00e812ac31cd125dfe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162019
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/configure.ac b/configure.ac
index 299fcba5b011..7bc3f5d65f0a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -4696,6 +4696,11 @@ if test -n "$enable_dbgutil" -a "$enable_dbgutil" != 
"no"; then
 else
 with_system_zxing=no
 fi
+if test "$with_system_poppler" = "yes"; then
+AC_MSG_ERROR([--with-system-poppler conflicts with --enable-dbgutil])
+else
+with_system_poppler=no
+fi
 # As mixing system libwps and non-system libnumbertext or vice versa 
likely causes trouble (see
 # 603074c5f2b84de8a24593faf807da784b040625 "Pass _GLIBCXX_DEBUG into 
external/libwps" and the
 # mail thread starting at 
 "libstdc++: ODR

core.git: sw/source

[Caolán McNamara (via logerrit)]

 sw/source/uibase/misc/swruler.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 5f7496ddce65f20a09807a394ae986905b999698
Author: Caolán McNamara 
AuthorDate: Sat Jan 13 18:56:18 2024 +
Commit: Caolán McNamara 
CommitDate: Sat Jan 13 21:40:34 2024 +0100

cid#1585308 Uninitialized scalar field

Change-Id: Ia10f386a0ddb84dd1e3f8dd018cc5744185f0665
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162020
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sw/source/uibase/misc/swruler.cxx 
b/sw/source/uibase/misc/swruler.cxx
index aeed7ea677c5..7d9f6f1aba84 100644
--- a/sw/source/uibase/misc/swruler.cxx
+++ b/sw/source/uibase/misc/swruler.cxx
@@ -85,6 +85,7 @@ SwCommentRuler::SwCommentRuler(SwViewShell* pViewSh, 
vcl::Window* pParent, SwEdi
 : SvxRuler(pParent, pWin, nRulerFlags, rBindings, nWinStyle | WB_HSCROLL)
 , mpViewShell(pViewSh)
 , mpSwWin(pWin)
+, mbIsDrag(false)
 , mbIsHighlighted(false)
 , maFadeTimer("sw::SwCommentRuler maFadeTimer")
 , mnFadeRate(0)

[Bug 148857] Handle is not initialized exception when bootstrapping with .Net (but not in .Net Framework)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148857

--- Comment #7 from eins99  ---
Since .NET Framework and .NET Core are now merged to .NET and will not see new
development anymore, it would make sense to take in consideration to go this
way also with LO. Otherwise coming releases of LO will not work with .NET.

How to deal with backward compatibility is another question.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'distro/collabora/co-24.04' - download.lst external/more_fonts Makefile.fetch readlicense_oo/license Repository.mk

[Andras Timar (via logerrit)]

 Makefile.fetch  |1 
 Repository.mk   |1 
 download.lst|5 ++
 external/more_fonts/ExternalPackage_opensans.mk |   51 
 external/more_fonts/Module_more_fonts.mk|2 
 external/more_fonts/UnpackedTarball_opensans.mk |   14 ++
 readlicense_oo/license/license.xml  |4 +
 7 files changed, 78 insertions(+)

New commits:
commit 80614e39db1fa91e88a3412749035b1a3c087185
Author: Andras Timar 
AuthorDate: Mon Mar 6 23:58:26 2023 +0100
Commit: Andras Timar 
CommitDate: Sat Jan 13 21:24:03 2024 +0100

[cp] Bundle Open Sans font

Change-Id: I28b5514bc2f23a2aebd901af564fcb85aa7449a8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148370
Tested-by: Andras Timar 
Reviewed-by: Andras Timar 

diff --git a/Makefile.fetch b/Makefile.fetch
index 6a3f993264fd..05463aaec76c 100644
--- a/Makefile.fetch
+++ b/Makefile.fetch
@@ -203,6 +203,7 @@ $(WORKDIR)/download: $(BUILDDIR)/config_$(gb_Side).mk 
$(SRCDIR)/download.lst $(S
$(call fetch_Optional,MORE_FONTS,FONT_AMIRI_TARBALL) \
$(call fetch_Optional,MORE_FONTS,FONT_REEM_TARBALL) \
$(call fetch_Optional,MORE_FONTS,FONT_SCHEHERAZADE_TARBALL) \
+   $(call fetch_Optional,MORE_FONTS,FONT_OPEN_SANS_TARBALL) \
$(call fetch_Optional,MSPUB,MSPUB_TARBALL) \
$(call fetch_Optional,MWAW,MWAW_TARBALL) \
$(call fetch_Optional,MYTHES,MYTHES_TARBALL) \
diff --git a/Repository.mk b/Repository.mk
index 38b0529cde4d..a56d9f33571c 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -1056,6 +1056,7 @@ $(eval $(call 
gb_Helper_register_packages_for_install,ooo_fonts,\
fonts_libre_hebrew \
fonts_noto \
fonts_opendyslexic \
+   fonts_opensans \
fonts_reem \
fonts_scheherazade \
) \
diff --git a/download.lst b/download.lst
index bf4075fcd7e3..c1bde8be9ab8 100644
--- a/download.lst
+++ b/download.lst
@@ -320,6 +320,11 @@ FONT_OPENDYSLEXIC_TARBALL := 
opendyslexic-0.910.12-rc2-2019.10.17.zip
 # three static lines
 # so that git cherry-pick
 # will not run into conflicts
+FONT_OPEN_SANS_TARBALL := Open_Sans.zip
+FONT_OPEN_SANS_SHA256SUM := 
85d79a39d26acb207ba13fb1007189d55355a0faf2cf7ccfe6a2edf2abac06d9
+# three static lines
+# so that git cherry-pick
+# will not run into conflicts
 FREEHAND_SHA256SUM := 
0e422d1564a6dbf22a9af598535425271e583514c0f7ba7d9091676420de34ac
 FREEHAND_TARBALL := libfreehand-0.1.2.tar.xz
 # three static lines
diff --git a/external/more_fonts/ExternalPackage_opensans.mk 
b/external/more_fonts/ExternalPackage_opensans.mk
new file mode 100644
index ..8a6b8d775eb7
--- /dev/null
+++ b/external/more_fonts/ExternalPackage_opensans.mk
@@ -0,0 +1,51 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call gb_ExternalPackage_ExternalPackage,fonts_opensans,font_opensans))
+
+$(eval $(call 
gb_ExternalPackage_add_unpacked_files,fonts_opensans,$(LIBO_SHARE_FOLDER)/fonts/truetype,\
+   static/OpenSans_Condensed/OpenSans_Condensed-Bold.ttf \
+   static/OpenSans_Condensed/OpenSans_Condensed-BoldItalic.ttf \
+   static/OpenSans_Condensed/OpenSans_Condensed-ExtraBold.ttf \
+   static/OpenSans_Condensed/OpenSans_Condensed-ExtraBoldItalic.ttf \
+   static/OpenSans_Condensed/OpenSans_Condensed-Italic.ttf \
+   static/OpenSans_Condensed/OpenSans_Condensed-Light.ttf \
+   static/OpenSans_Condensed/OpenSans_Condensed-LightItalic.ttf \
+   static/OpenSans_Condensed/OpenSans_Condensed-Medium.ttf \
+   static/OpenSans_Condensed/OpenSans_Condensed-MediumItalic.ttf \
+   static/OpenSans_Condensed/OpenSans_Condensed-Regular.ttf \
+   static/OpenSans_Condensed/OpenSans_Condensed-SemiBold.ttf \
+   static/OpenSans_Condensed/OpenSans_Condensed-SemiBoldItalic.ttf \
+   static/OpenSans_SemiCondensed/OpenSans_SemiCondensed-Bold.ttf \
+   static/OpenSans_SemiCondensed/OpenSans_SemiCondensed-BoldItalic.ttf \
+   static/OpenSans_SemiCondensed/OpenSans_SemiCondensed-ExtraBold.ttf \
+   
static/OpenSans_SemiCondensed/OpenSans_SemiCondensed-ExtraBoldItalic.ttf \
+   static/OpenSans_SemiCondensed/OpenSans_SemiCondensed-Italic.ttf \
+   static/OpenSans_SemiCondensed/OpenSans_SemiCondensed-Light.ttf \
+   static/OpenSans_SemiCondensed/OpenSans_SemiCondensed-LightItalic.ttf \
+   static/OpenSans_SemiCondensed/OpenSans_SemiCondensed-Medium.ttf \
+   static/OpenSans_SemiCondensed/OpenSans_SemiCondensed-MediumItalic.ttf \
+   

[Bug 159158] FILEOPEN DOCX: relativeHeight zOrder of 0 apparently is the highest, while 1 is the lowest, then 2...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159158

--- Comment #2 from Justin L  ---
Created attachment 191916
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191916=edit
gradient-fill-preservation-yellowBehindBlue01.docx: Yellow=0, Blue=1, and blue
wins

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159158] FILEOPEN DOCX: relativeHeight zOrder of 0 apparently is the highest, while 1 is the lowest, then 2...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159158

--- Comment #1 from Justin L  ---
Created attachment 191915
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191915=edit
gradient-fill-preservation-yellowBehindBlue10.docx: Yellow=1, Blue=0, but blue
wins?!?

The plot thickens. Both 0 and 1 are relatively high, and changed into arbitrary
numbers when round-tripped by MSO, while values of 2+ are preserved.

ooxmlexport6's gradient-fill-preservation.docx triggered a unit test failure on
my exploratory patch at https://gerrit.libreoffice.org/c/core/+/161989. It has
been useful in trying to tease out the specifics of what is happening here.

Current theory - both 0 and 1 have a equivalent relativeHeight value of
0x0EFF. Last one wins in this case (which is the opposite to what our
zOrder handler is very deliberately doing).

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'distro/collabora/co-24.04' - scp2/source

[Andras Timar (via logerrit)]

 scp2/source/python/module_python_librelogo.scp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a6b885d191b8831518f9cc2e3d62e13d11c37498
Author: Andras Timar 
AuthorDate: Mon May 14 16:02:08 2018 +0200
Commit: Andras Timar 
CommitDate: Sat Jan 13 21:21:53 2024 +0100

[cp] MSI: do not install LibreLogo by default

Change-Id: Ibde24b2045497aca4ea37845fc42c327d22d3d42

diff --git a/scp2/source/python/module_python_librelogo.scp 
b/scp2/source/python/module_python_librelogo.scp
index a056d49acc3e..021425f06dd5 100644
--- a/scp2/source/python/module_python_librelogo.scp
+++ b/scp2/source/python/module_python_librelogo.scp
@@ -18,7 +18,7 @@ Module gid_Module_Optional_Pyuno_LibreLogo
 Sortkey = "810";
 Files = (auto_python_librelogo_ALL,
  gid_File_Share_Registry_LibreLogo_Xcd);
-Default = YES;
+Default = NO;
 Styles = ( );
 End
 #endif

core.git: Branch 'libreoffice-24-2' - vcl/unx

[Julien Nabet (via logerrit)]

 vcl/unx/gtk3/gtksalmenu.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit ef21e36ee580c098a92e493795c412adf8562743
Author: Julien Nabet 
AuthorDate: Sat Jan 13 18:06:14 2024 +0100
Commit: Caolán McNamara 
CommitDate: Sat Jan 13 21:19:55 2024 +0100

Add missing g_bytes_unref in GtkSalMenu::AddMenuBarButton

Change-Id: I00b8a73cfe02abc561ddf67c0e6e4ad612c27422
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162004
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/gtksalmenu.cxx b/vcl/unx/gtk3/gtksalmenu.cxx
index 699e0097b358..ddfa5ef36b48 100644
--- a/vcl/unx/gtk3/gtksalmenu.cxx
+++ b/vcl/unx/gtk3/gtksalmenu.cxx
@@ -831,6 +831,7 @@ bool GtkSalMenu::AddMenuBarButton(const SalMenuButtonItem& 
rNewItem)
 pImage = gtk_image_new_from_gicon(pIcon);
 #endif
 g_object_unref(pIcon);
+g_bytes_unref(pBytes);
 }
 
 GtkWidget* pButton = AddButton(pImage);

[Bug 159167] Conditional formatting of cells based on rules for checking values greater than or less than

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159167

--- Comment #7 from Rafael Lima  ---
Here are 2 good sources for my answer. I'll leave them here for future
reference.

https://superuser.com/questions/1562267/conditional-formatting-with-libreoffice-calc-activated-with-a-letter-and-the-con

https://superuser.com/questions/900618/how-to-color-rows-based-on-two-cell-values-in-open-libre-office

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'distro/collabora/co-24.04' - 2 commits - basctl/uiconfig chart2/uiconfig dbaccess/uiconfig extensions/uiconfig framework/uiconfig reportdesign/uiconfig sc/uiconfig sd/uiconfig sfx2/s

[Andras Timar (via logerrit)]

 basctl/uiconfig/basicide/menubar/menubar.xml  |3 
 chart2/uiconfig/menubar/menubar.xml   |3 
 dbaccess/uiconfig/dbapp/menubar/menubar.xml   |3 
 dbaccess/uiconfig/dbquery/menubar/menubar.xml |3 
 dbaccess/uiconfig/dbrelation/menubar/menubar.xml  |3 
 dbaccess/uiconfig/dbtable/menubar/menubar.xml |3 
 dbaccess/uiconfig/dbtdata/menubar/menubar.xml |3 
 extensions/uiconfig/sbibliography/menubar/menubar.xml |3 
 framework/uiconfig/startmodule/menubar/menubar.xml|3 
 reportdesign/uiconfig/dbreport/menubar/menubar.xml|3 
 sc/uiconfig/scalc/menubar/menubar.xml |3 
 sd/uiconfig/sdraw/menubar/menubar.xml |3 
 sd/uiconfig/simpress/menubar/menubar.xml  |3 
 sfx2/source/view/viewfrm.cxx  |   58 --
 starmath/uiconfig/smath/menubar/menubar.xml   |3 
 sw/uiconfig/sglobal/menubar/menubar.xml   |3 
 sw/uiconfig/sweb/menubar/menubar.xml  |3 
 sw/uiconfig/swform/menubar/menubar.xml|3 
 sw/uiconfig/swreport/menubar/menubar.xml  |3 
 sw/uiconfig/swriter/menubar/menubar.xml   |3 
 sw/uiconfig/swxform/menubar/menubar.xml   |3 
 21 files changed, 118 deletions(-)

New commits:
commit 7160baa8883410fe63ab3f7e8885763617034b05
Author: Andras Timar 
AuthorDate: Sun Jul 14 20:28:13 2019 +0200
Commit: Andras Timar 
CommitDate: Sat Jan 13 21:15:04 2024 +0100

[cp] remove donate and community involvement infobars

Change-Id: I37c9c76eb88dea4effa786b62755ea8738efc3e0
Reviewed-on: https://gerrit.libreoffice.org/75600
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Andras Timar 

diff --git a/sfx2/source/view/viewfrm.cxx b/sfx2/source/view/viewfrm.cxx
index fe0dc0adc7fc..abb616ce5505 100644
--- a/sfx2/source/view/viewfrm.cxx
+++ b/sfx2/source/view/viewfrm.cxx
@@ -1520,63 +1520,6 @@ void SfxViewFrame::Notify( SfxBroadcaster& /*rBC*/, 
const SfxHint& rHint )
 GetDispatcher()->ExecuteList(SID_TIPOFTHEDAY, 
SfxCallMode::SLOT, {}, {  });
 }
 
-// inform about the community involvement
-const auto t0 = 
std::chrono::system_clock::now().time_since_epoch();
-const sal_Int64 nLastGetInvolvedShown = 
officecfg::Setup::Product::LastTimeGetInvolvedShown::get();
-const sal_Int64 nNow = 
std::chrono::duration_cast(t0).count();
-const sal_Int64 nPeriodSec(60 * 60 * 24 * 180); // 180 days in 
seconds
-bool bUpdateLastTimeGetInvolvedShown = false;
-
-if (nLastGetInvolvedShown == 0)
-bUpdateLastTimeGetInvolvedShown = true;
-else if (nPeriodSec < nNow && nLastGetInvolvedShown < (nNow + 
nPeriodSec/2) - nPeriodSec) // 90d alternating with donation
-{
-bUpdateLastTimeGetInvolvedShown = true;
-
-VclPtr pInfoBar = 
AppendInfoBar("getinvolved", "", SfxResId(STR_GET_INVOLVED_TEXT), 
InfobarType::INFO);
-
-if (pInfoBar)
-{
-weld::Button& rGetInvolvedButton = 
pInfoBar->addButton();
-
rGetInvolvedButton.set_label(SfxResId(STR_GET_INVOLVED_BUTTON));
-rGetInvolvedButton.connect_clicked(LINK(this, 
SfxViewFrame, GetInvolvedHandler));
-}
-}
-
-if (bUpdateLastTimeGetInvolvedShown
-&& 
!officecfg::Setup::Product::LastTimeGetInvolvedShown::isReadOnly())
-{
-std::shared_ptr 
batch(comphelper::ConfigurationChanges::create());
-
officecfg::Setup::Product::LastTimeGetInvolvedShown::set(nNow, batch);
-batch->commit();
-}
-
-// inform about donations
-const sal_Int64 nLastDonateShown = 
officecfg::Setup::Product::LastTimeDonateShown::get();
-bool bUpdateLastTimeDonateShown = false;
-
-if (nLastDonateShown == 0)
-bUpdateLastTimeDonateShown = true;
-else if (nPeriodSec < nNow && nLastDonateShown < nNow - 
nPeriodSec) // 90d alternating with getinvolved
-{
-bUpdateLastTimeDonateShown = true;
-
-VclPtr pInfoBar = 
AppendInfoBar("donate", "", SfxResId(STR_DONATE_TEXT), InfobarType::INFO);
-if (pInfoBar)
-{
-weld::Button& rDonateButton = pInfoBar->addButton();
-rDonateButton.set_label(SfxResId(STR_DONATE_BUTTON));
-rDonateButton.connect_clicked(LINK(this, SfxViewFrame, 
DonationHandler));
-}
-}
-
-if 

core.git: Branch 'libreoffice-24-2' - vcl/unx

[Julien Nabet (via logerrit)]

 vcl/unx/gtk3/gtkinst.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit f1e45b80c396f90d763d3e2e5bcd3baf12383127
Author: Julien Nabet 
AuthorDate: Sat Jan 13 17:26:34 2024 +0100
Commit: Caolán McNamara 
CommitDate: Sat Jan 13 21:14:10 2024 +0100

Add missing g_object_thaw_notify before an early return (vcl/gtkinst)

Change-Id: I3ba4bfd9a302e03dd25e4635dfbb0a41d265349e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162002
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index df54b50368f6..1dafaa04d595 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -15500,7 +15500,10 @@ public:
 GtkTreePath* end_path;
 
 if (!gtk_tree_view_get_visible_range(m_pTreeView, _path, 
_path))
+{
+g_object_thaw_notify(G_OBJECT(m_pTreeModel));
 return;
+}
 
 GtkInstanceTreeIter aGtkIter(nullptr);
 gtk_tree_model_get_iter(m_pTreeModel, , start_path);

[Bug 159167] Conditional formatting of cells based on rules for checking values greater than or less than

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159167

--- Comment #6 from Rafael Lima  ---
Actually Excel offers a way to achieve this:

https://techcommunity.microsoft.com/t5/excel/conditional-formatting-row-by-row/m-p/3966290

In Calc the same can be achieved by setting up a Color Scale (Format -
Conditional - Color Scale).

Then in "Condition" you must choose "Formula is". Then you write "A1<=A2" in
the formula and choose the style. Then do the same for the ">" rule.

Let me know if this works for you.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'distro/collabora/co-24.04' - 4 commits - filter/source officecfg/registry writerperfect/qa

[Miklos Vajna (via logerrit)]

 filter/source/config/fragments/filters/BroadBand_eBook.xcu   |2 +-
 filter/source/config/fragments/filters/ClarisWorks.xcu   |2 +-
 filter/source/config/fragments/filters/ClarisWorks_Calc.xcu  |2 +-
 filter/source/config/fragments/filters/ClarisWorks_Draw.xcu  |2 +-
 filter/source/config/fragments/filters/ClarisWorks_Impress.xcu   |2 +-
 filter/source/config/fragments/filters/Claris_Resolve_Calc.xcu   |2 +-
 filter/source/config/fragments/filters/CorelDrawDocument.xcu |2 +-
 filter/source/config/fragments/filters/CorelPresentationExchange.xcu |2 +-
 filter/source/config/fragments/filters/DIF.xcu   |2 +-
 filter/source/config/fragments/filters/DXF___AutoCAD_Interchange.xcu |2 +-
 filter/source/config/fragments/filters/DocBook_File.xcu  |2 +-
 filter/source/config/fragments/filters/DosWord.xcu   |2 +-
 filter/source/config/fragments/filters/FictionBook_2.xcu |2 +-
 filter/source/config/fragments/filters/FreehandDocument.xcu  |2 +-
 filter/source/config/fragments/filters/Lotus.xcu |2 +-
 filter/source/config/fragments/filters/LotusWordPro.xcu  |2 +-
 filter/source/config/fragments/filters/MacWrite.xcu  |2 +-
 filter/source/config/fragments/filters/Mac_Word.xcu  |2 +-
 filter/source/config/fragments/filters/Mac_Works.xcu |2 +-
 filter/source/config/fragments/filters/Mac_Works_Calc.xcu|2 +-
 filter/source/config/fragments/filters/Mariner_Write.xcu |2 +-
 filter/source/config/fragments/filters/PageMakerDocument.xcu |2 +-
 filter/source/config/fragments/filters/PalmDoc.xcu   |2 +-
 filter/source/config/fragments/filters/Palm_Text_Document.xcu|2 +-
 filter/source/config/fragments/filters/Plucker_eBook.xcu |2 +-
 filter/source/config/fragments/filters/QPro.xcu  |2 +-
 filter/source/config/fragments/filters/QXPDocument.xcu   |2 +-
 filter/source/config/fragments/filters/StarOffice_Drawing.xcu|2 +-
 filter/source/config/fragments/filters/StarOffice_Presentation.xcu   |2 +-
 filter/source/config/fragments/filters/StarOffice_Spreadsheet.xcu|2 +-
 filter/source/config/fragments/filters/StarOffice_Writer.xcu |2 +-
 filter/source/config/fragments/filters/StarOffice_XML__Base_.xcu |2 +-
 filter/source/config/fragments/filters/StarOffice_XML__Writer_.xcu   |2 +-
 filter/source/config/fragments/filters/UOF_presentation.xcu  |2 +-
 filter/source/config/fragments/filters/UOF_spreadsheet.xcu   |2 +-
 filter/source/config/fragments/filters/UOF_text.xcu  |2 +-
 filter/source/config/fragments/filters/WPS_Lotus_Calc.xcu|2 +-
 filter/source/config/fragments/filters/WPS_QPro_Calc.xcu |2 +-
 filter/source/config/fragments/filters/WordPerfect.xcu   |2 +-
 filter/source/config/fragments/filters/WordPerfectGraphics.xcu   |2 +-
 filter/source/config/fragments/filters/WriteNow.xcu  |2 +-
 filter/source/config/fragments/filters/ZMFDocument.xcu   |2 +-
 officecfg/registry/schema/org/openoffice/Office/Common.xcs   |2 +-
 writerperfect/qa/unit/EPUBExportTest.cxx |3 +++
 44 files changed, 46 insertions(+), 43 deletions(-)

New commits:
commit a37e056b968ad555de13d44ccd584577f5a903a6
Author: Miklos Vajna 
AuthorDate: Thu May 14 10:19:21 2020 +0200
Commit: Andras Timar 
CommitDate: Sat Jan 13 21:13:09 2024 +0100

[cp] CppunitTest_writerperfect_epubexport: don't try to load flagged abw 
format

master opens this as-is, this branch would first show you a dialog, we
cancel that in headless mode, and then loading fails, but that's not an
interesting failure.

Change-Id: I6ff83e320738fb33ee88d10f9b2cfabff91de8ed

diff --git a/writerperfect/qa/unit/EPUBExportTest.cxx 
b/writerperfect/qa/unit/EPUBExportTest.cxx
index f9780b42ab0b..a7f4f7a51944 100644
--- a/writerperfect/qa/unit/EPUBExportTest.cxx
+++ b/writerperfect/qa/unit/EPUBExportTest.cxx
@@ -855,9 +855,12 @@ CPPUNIT_TEST_FIXTURE(EPUBExportTest, testSimpleRuby)
 
 CPPUNIT_TEST_FIXTURE(EPUBExportTest, testAbi11105)
 {
+// Disable the test on this branch, .abw is flagged as EXOTIC, so loading 
would fail.
+#if 0
 // This crashed because the paragraph style "P5" which had a 
master-page-name
 // appeared in a table cell messed up page spans.
 createDoc(u"abi11105.abw", {});
+#endif
 }
 }
 
commit 95d256b7e618a781c9ab71fff0025c2bf80c4411
Author: Andras Timar 
AuthorDate: Wed Apr 25 15:30:38 2018 +0200
Commit: Andras Timar 
CommitDate: Sat Jan 13 21:12:46 2024 +0100

[cp] StarOffice XML is not exotic, old binary format 

core.git: Branch 'distro/collabora/co-24.04' - sfx2/source

[Andras Timar (via logerrit)]

 sfx2/source/appl/appserv.cxx |6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

New commits:
commit e5bf1f77e1b5e40ce0c7ba04f6b28f4270960792
Author: Andras Timar 
AuthorDate: Tue Apr 17 14:06:38 2018 +0200
Commit: Andras Timar 
CommitDate: Sat Jan 13 21:10:45 2024 +0100

[cp] Send feedback to he...@collaboraoffice.com

Change-Id: Ic734235426001e4aa7119476c1e6884b7c39776d

diff --git a/sfx2/source/appl/appserv.cxx b/sfx2/source/appl/appserv.cxx
index 2abc1a57..f1a6227e23e1 100644
--- a/sfx2/source/appl/appserv.cxx
+++ b/sfx2/source/appl/appserv.cxx
@@ -508,10 +508,8 @@ void SfxApplication::MiscExec_Impl( SfxRequest& rReq )
 case SID_SEND_FEEDBACK:
 {
 OUString module = SfxHelp::GetCurrentModuleIdentifier();
-OUString 
sURL(officecfg::Office::Common::Menus::SendFeedbackURL::get() + 
//officecfg/registry/data/org/openoffice/Office/Common.xcu => 
https://hub.libreoffice.org/send-feedback/
-"?LOversion=" + 
utl::ConfigManager::getAboutBoxProductVersion() +
-"=" + utl::ConfigManager::getUILocale() +
-"=" + module.subView(module.lastIndexOf('.') + 1 )  );
+OUString 
sURL("mailto:he...@collaboraoffice.com?Subject=Version:%20; + 
utl::ConfigManager::getAboutBoxProductVersion() +
+",%20Locale:%20" + utl::ConfigManager::getUILocale() + 
",%20Module:%20" + module.subView(module.lastIndexOf('.') + 1 )  );
 sfx2::openUriExternally(sURL, false, rReq.GetFrameWeld());
 break;
 }

core.git: Branch 'libreoffice-24-2' - vcl/unx

[Julien Nabet (via logerrit)]

 vcl/unx/gtk3/gtksalmenu.cxx |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit d7e4bb5acd38f4827a8f0d0aade8b44d18a1a2ba
Author: Julien Nabet 
AuthorDate: Sat Jan 13 18:03:53 2024 +0100
Commit: Caolán McNamara 
CommitDate: Sat Jan 13 21:01:05 2024 +0100

Add missing g_object_unref (vcl/gtksalmenu)

Change-Id: I07db3d7a03da94b53ad49188c229c134dc2f663c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162003
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/gtksalmenu.cxx b/vcl/unx/gtk3/gtksalmenu.cxx
index a510473650d6..699e0097b358 100644
--- a/vcl/unx/gtk3/gtksalmenu.cxx
+++ b/vcl/unx/gtk3/gtksalmenu.cxx
@@ -125,6 +125,7 @@ static void RemoveDisabledItemsFromNativeMenu(GLOMenu* 
pMenu, GList** pOldComman
 g_free(pSubCommand);
 }
 }
+g_object_unref(pSubMenuModel);
 }
 }
 
@@ -1361,7 +1362,8 @@ bool GtkSalMenu::NativeSetItemCommand( unsigned nSection,
 
 if ( aCurrentCommand == nullptr || g_strcmp0( aCurrentCommand, aCommand ) 
!= 0 )
 {
-bool bOldHasSubmenu = 
g_lo_menu_get_submenu_from_item_in_section(pMenu, nSection, nItemPos) != 
nullptr;
+GLOMenu* pSubMenuModel = 
g_lo_menu_get_submenu_from_item_in_section(pMenu, nSection, nItemPos);
+bool bOldHasSubmenu = pSubMenuModel != nullptr;
 bSubMenuAddedOrRemoved = bOldHasSubmenu != bIsSubmenu;
 if (bSubMenuAddedOrRemoved)
 {
@@ -1385,6 +1387,8 @@ bool GtkSalMenu::NativeSetItemCommand( unsigned nSection,
 g_lo_menu_set_action_and_target_value_to_item_in_section( pMenu, 
nSection, nItemPos, aItemCommand, pTarget );
 pTarget = nullptr;
 }
+if (bOldHasSubmenu)
+g_object_unref(pSubMenuModel);
 
 g_free( aItemCommand );
 }

New Defects reported by Coverity Scan for LibreOffice

[scan-admin]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found 
with Coverity Scan.

4 new defect(s) introduced to LibreOffice found with Coverity Scan.
40 defect(s), reported by Coverity Scan earlier, were marked fixed in the 
recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)


** CID 1585309:  Null pointer dereferences  (REVERSE_INULL)
/svl/source/items/itemset.cxx: 339 in implCreateItemEntry(SfxItemPool &, const 
SfxPoolItem *, unsigned short, bool)()



*** CID 1585309:  Null pointer dereferences  (REVERSE_INULL)
/svl/source/items/itemset.cxx: 339 in implCreateItemEntry(SfxItemPool &, const 
SfxPoolItem *, unsigned short, bool)()
333 pTargetPool = pTargetPool->GetSecondaryPool();
334 
335 // if this goes wrong, an Item with invalid ID for this pool is
336 // processed. This is not allowed (and should not happen, e.g.
337 // ItemSets already have WhichRanges that are checked against
338 // their Pool)
>>> CID 1585309:  Null pointer dereferences  (REVERSE_INULL)
>>> Null-checking "pTargetPool" suggests that it may be null, but it has 
>>> already been dereferenced on all paths leading to the check.
339 if (nullptr == pTargetPool)
340 {
341 assert(false);
342 return pSource;
343 }
344 

** CID 1585308:  Uninitialized members  (UNINIT_CTOR)
/sw/source/uibase/misc/swruler.cxx: 101 in 
SwCommentRuler::SwCommentRuler(SwViewShell *, vcl::Window *, SwEditWin *, 
SvxRulerSupportFlags, SfxBindings &, long)()



*** CID 1585308:  Uninitialized members  (UNINIT_CTOR)
/sw/source/uibase/misc/swruler.cxx: 101 in 
SwCommentRuler::SwCommentRuler(SwViewShell *, vcl::Window *, SwEditWin *, 
SvxRulerSupportFlags, SfxBindings &, long)()
95 maFadeTimer.SetInvokeHandler(LINK(this, SwCommentRuler, 
FadeHandler));
96 
97 // we have a little bit more space, as we don't draw ruler ticks
98 vcl::Font aFont(maVirDev->GetFont());
99 aFont.SetFontHeight(aFont.GetFontHeight() + 1);
100 maVirDev->SetFont(aFont);
>>> CID 1585308:  Uninitialized members  (UNINIT_CTOR)
>>> Non-static class member "mbIsDrag" is not initialized in this 
>>> constructor nor in any functions that it calls.
101 }
102 
103 SwCommentRuler::~SwCommentRuler() { disposeOnce(); }
104 
105 void SwCommentRuler::dispose()
106 {

** CID 1585307:(OVERRUN)
/chart2/source/view/charttypes/VSeriesPlotter.cxx: 2344 in 
chart::VSeriesPlotter::getRenderOrder() const()
/chart2/source/view/charttypes/VSeriesPlotter.cxx: 2345 in 
chart::VSeriesPlotter::getRenderOrder() const()



*** CID 1585307:(OVERRUN)
/chart2/source/view/charttypes/VSeriesPlotter.cxx: 2344 in 
chart::VSeriesPlotter::getRenderOrder() const()
2338 } // unnamed
2339 
2340 sal_Int32 VSeriesPlotter::getRenderOrder() const
2341 {
2342 OUString aChartType = m_xChartTypeModel->getChartType();
2343 for (size_t n = 0; n < sizeof(pairList); ++n) {
>>> CID 1585307:(OVERRUN)
>>> Overrunning array "chartpairList" of 10 16-byte elements 
>>> at element index 159 (byte offset 2559) using index "n" (which evaluates to 
>>> 159).
2344 if (aChartType.equalsIgnoreAsciiCase(pairList[n].chartName)) {
2345 return pairList[n].renderOrder;
2346 }
2347 }
2348 SAL_WARN("chart2", "Unsupported chart type in getRenderOrder()");
2349 return 0;
/chart2/source/view/charttypes/VSeriesPlotter.cxx: 2345 in 
chart::VSeriesPlotter::getRenderOrder() const()
2339 
2340 sal_Int32 VSeriesPlotter::getRenderOrder() const
2341 {
2342 OUString aChartType = m_xChartTypeModel->getChartType();
2343 for (size_t n = 0; n < sizeof(pairList); ++n) {
2344 if (aChartType.equalsIgnoreAsciiCase(pairList[n].chartName)) {
>>> CID 1585307:(OVERRUN)
>>> Overrunning array "chartpairList" of 10 16-byte elements 
>>> at element index 159 (byte offset 2559) using index "n" (which evaluates to 
>>> 159).
2345 return pairList[n].renderOrder;
2346 }
2347 }
2348 SAL_WARN("chart2", "Unsupported chart type in getRenderOrder()");
2349 return 0;
2350 }

** CID 1585306:  Uninitialized members  (UNINIT_CTOR)
/sc/source/ui/cctrl/tbzoomsliderctrl.cxx: 228 in 
ScZoomSlider::ScZoomSlider(com::sun::star::uno::Reference,
 unsigned short)()



*** CID 1585306:  Uninitialized members  (UNINIT_CTOR)

core.git: Branch 'distro/collabora/co-24.04' - setup_native/source

[Andras Timar (via logerrit)]

 setup_native/source/packinfo/spellchecker_selection.txt |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b0fc93dc895ef856d20c6793ec447ca716fcc8dc
Author: Andras Timar 
AuthorDate: Mon Sep 12 08:19:08 2022 +0200
Commit: Andras Timar 
CommitDate: Sat Jan 13 20:58:42 2024 +0100

[cp] Add Persian dictionary to install set this way

Change-Id: I86e0eeb68120b311759a6cef0b13740bb152

diff --git a/setup_native/source/packinfo/spellchecker_selection.txt 
b/setup_native/source/packinfo/spellchecker_selection.txt
index 602bf0b51603..6fccc46e43a3 100644
--- a/setup_native/source/packinfo/spellchecker_selection.txt
+++ b/setup_native/source/packinfo/spellchecker_selection.txt
@@ -27,7 +27,7 @@
 # be used as first entry.
 
 af = "af"
-ar = "ar"
+ar = "ar,fa"
 be = "be"
 bg = "bg"
 bn = "bn"

core.git: Branch 'distro/collabora/co-24.04' - 2 commits - qadevOOo/qa test/user-template

[Andras Timar (via logerrit)]

 qadevOOo/qa/registrymodifications.xcu|1 +
 test/user-template/registry-common/modifications.xcd |   11 +++
 2 files changed, 12 insertions(+)

New commits:
commit 4eef3419a1ba8fa135ccf3a81985c848ebbb3396
Author: Andras Timar 
AuthorDate: Fri Mar 18 15:06:23 2022 +0100
Commit: Andras Timar 
CommitDate: Sat Jan 13 20:55:14 2024 +0100

Disable ViewPDFAfterExport for unit tests - part 2 (UITests)

Change-Id: I39d2be986c99ed107a59fd72a62730ece66c3d1b

diff --git a/qadevOOo/qa/registrymodifications.xcu 
b/qadevOOo/qa/registrymodifications.xcu
index 0a4fccf18c88..7819396e78bd 100644
--- a/qadevOOo/qa/registrymodifications.xcu
+++ b/qadevOOo/qa/registrymodifications.xcu
@@ -9,4 +9,5 @@
 en-US
 en
 en-US
+false
 
commit 574e107f811dc73d3ddee96a2e3d95d2098ab5e3
Author: Andras Timar 
AuthorDate: Wed Mar 16 09:03:11 2022 +0100
Commit: Andras Timar 
CommitDate: Sat Jan 13 20:55:04 2024 +0100

Disable ViewPDFAfterExport for unit tests

Change-Id: I3e6ab03abf213a191cfcbb1f868bd658635a2bd2

diff --git a/test/user-template/registry-common/modifications.xcd 
b/test/user-template/registry-common/modifications.xcd
index a212242785ea..2d4107d4c0fb 100644
--- a/test/user-template/registry-common/modifications.xcd
+++ b/test/user-template/registry-common/modifications.xcd
@@ -144,4 +144,15 @@
 
   
  
+ 
+  
+
+  
+
+  false
+
+  
+
+  
+ 
 

core.git: Branch 'distro/collabora/co-24.04' - 7 commits - configure.ac download.lst external/Module_external.mk external/more_fonts external/noto_font Makefile.fetch officecfg/registry readlicense_oo

[Andras Timar (via logerrit)]

 Makefile.fetch |   15 +
 Repository.mk  |   13 +
 configure.ac   |   18 +
 download.lst   |   58 +
 external/Module_external.mk|1 
 external/more_fonts/ExternalPackage_karla.mk   |   19 +
 external/more_fonts/ExternalPackage_opendyslexic.mk|   19 +
 external/more_fonts/Module_more_fonts.mk   |4 
 external/more_fonts/UnpackedTarball_karla.mk   |   14 +
 external/more_fonts/UnpackedTarball_opendyslexic.mk|   14 +
 external/noto_font/ExternalPackage_noto.mk |  134 +
 external/noto_font/ExternalPackage_notosansjp.mk   |   17 +
 external/noto_font/ExternalPackage_notosanskr.mk   |   17 +
 external/noto_font/ExternalPackage_notosanssc.mk   |   17 +
 external/noto_font/ExternalPackage_notosanstc.mk   |   17 +
 external/noto_font/ExternalPackage_notoserifjp.mk  |   17 +
 external/noto_font/ExternalPackage_notoserifkr.mk  |   17 +
 external/noto_font/ExternalPackage_notoserifsc.mk  |   17 +
 external/noto_font/ExternalPackage_notoseriftc.mk  |   17 +
 external/noto_font/Makefile|7 
 external/noto_font/Module_noto_font.mk |   33 +++
 external/noto_font/README  |1 
 external/noto_font/UnpackedTarball_noto.mk |   46 
 external/noto_font/UnpackedTarball_notosansjp.mk   |   14 +
 external/noto_font/UnpackedTarball_notosanskr.mk   |   14 +
 external/noto_font/UnpackedTarball_notosanssc.mk   |   14 +
 external/noto_font/UnpackedTarball_notosanstc.mk   |   14 +
 external/noto_font/UnpackedTarball_notoserifjp.mk  |   14 +
 external/noto_font/UnpackedTarball_notoserifkr.mk  |   14 +
 external/noto_font/UnpackedTarball_notoserifsc.mk  |   14 +
 external/noto_font/UnpackedTarball_notoseriftc.mk  |   14 +
 officecfg/registry/data/org/openoffice/Office/Common.xcu   |2 
 officecfg/registry/schema/org/openoffice/Office/Common.xcs |2 
 readlicense_oo/license/license.xml |   14 +
 sc/source/filter/oox/workbookhelper.cxx|2 
 setup_native/source/packinfo/packinfo_brand.txt|7 
 setup_native/source/packinfo/packinfo_office.txt   |2 
 solenv/flatpak-manifest.in |6 
 38 files changed, 676 insertions(+), 3 deletions(-)

New commits:
commit b90970f80f6433e00d4d7582288bece775e22853
Author: Andras Timar 
AuthorDate: Thu Apr 18 12:38:11 2019 +0200
Commit: Andras Timar 
CommitDate: Sat Jan 13 20:54:41 2024 +0100

[cp] ViewPDFAfterExport default true

Change-Id: I2c054ba672c7ab52a6e3f3f085823fd5015f0d62
Reviewed-on: https://gerrit.libreoffice.org/75233
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Andras Timar 

diff --git a/officecfg/registry/schema/org/openoffice/Office/Common.xcs 
b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
index 558711497328..daf3dac31758 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Common.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
@@ -4609,7 +4609,7 @@
 
   Specifies if PDF automatically opens after export.
 
-false
+true
   
   
 
commit d1e13a4f5415db4101e68fcfd687dba46fc0d69a
Author: Aron Budea 
AuthorDate: Fri Oct 19 20:56:35 2018 +0200
Commit: Andras Timar 
CommitDate: Sat Jan 13 20:52:56 2024 +0100

[cp] Add another known good generator.

Change-Id: I05a9aff0d1bddf0efd2491f09fe0fbf7144e8b4d

diff --git a/sc/source/filter/oox/workbookhelper.cxx 
b/sc/source/filter/oox/workbookhelper.cxx
index 855c7dab40b0..45105946e40a 100644
--- a/sc/source/filter/oox/workbookhelper.cxx
+++ b/sc/source/filter/oox/workbookhelper.cxx
@@ -565,7 +565,7 @@ void WorkbookGlobals::initialize()
 aCalcConfig.SetStringRefSyntax( formula::FormulaGrammar::CONV_XL_A1 ) ;
 mpDoc->SetCalcConfig(aCalcConfig);
 }
-else if (aGenerator.startsWithIgnoreAsciiCase("LibreOffice"))
+else if (aGenerator.startsWithIgnoreAsciiCase("LibreOffice") || 
aGenerator.startsWithIgnoreAsciiCase("Collabora"))
 {
 mbGeneratorKnownGood = true;
 }
commit c708f998f2b0de445b22ddd06e387bc4b6056e04
Author: Andras Timar 
AuthorDate: Fri Oct 2 14:18:26 2015 +0200
Commit: Andras Timar 
CommitDate: Sat Jan 13 20:52:10 2024 +0100

[cp] provide libreoffice-writer, libreoffice-calc etc. metapackages

(cherry picked from commit d151f43cdb0e7735d267115868a9dac9f45bb6b2)
(cherry picked from commit ddb987c79a3852cfb552f10b1beca03f419879c2)

Change-Id: 

[Bug 159167] Conditional formatting of cells based on rules for checking values greater than or less than

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159167

Rafael Lima  changed:

   What|Removed |Added

 CC||rafael.palma.l...@gmail.com

--- Comment #5 from Rafael Lima  ---
AFAIK it is not possible to define a conditional formatting rule where the
condition is a range. It has to be either a single cell or the result of a
formula.

In Excel it is not possible as well. The difference is that Excel throws an
error, making it clearer that this is not possible.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'distro/collabora/co-24.04' - officecfg/registry

[Andras Timar (via logerrit)]

 officecfg/registry/data/org/openoffice/Office/Accelerators.xcu |6 ++
 1 file changed, 6 insertions(+)

New commits:
commit d3dae121cdcc714402b58e7bcbe40a79e436a57e
Author: Andras Timar 
AuthorDate: Sat Nov 28 17:09:59 2015 +0100
Commit: Andras Timar 
CommitDate: Sat Jan 13 20:49:23 2024 +0100

[cp] Ctrl+3 keyboard shortcut for Set Optimal Column Width in Calc

(cherry picked from commit fc53041c0387388f1275abf7beefea4d80d5ee3b)
(cherry picked from commit 895e91d8aeaf77dc38fe14ad165b6f7ad5272491)

Change-Id: I1e218a429b509fda35accc832d01fc1f12e8

diff --git a/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu 
b/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu
index 231d10612750..2b3581a76168 100644
--- a/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu
@@ -653,6 +653,12 @@ Ctrl+Shift+e aka E_SHIFT_MOD1 under GTK/IBUS is for some 
emoji thing
 .uno:NumberFormatScientific
   
 
+
+  
+I10N SHORTCUTS - NO 
TRANSLATE
+.uno:SetOptimalColumnWidthDirect
+  
+
 
   
 I10N SHORTCUTS - NO 
TRANSLATE

core.git: Branch 'distro/collabora/co-24.04' - configure.ac connectivity/source external/iODBC external/unixODBC readlicense_oo/license RepositoryExternal.mk solenv/clang-format

[Andras Timar (via logerrit)]

 RepositoryExternal.mk   |2 
 configure.ac|1 
 connectivity/source/drivers/odbc/OPreparedStatement.cxx |2 
 connectivity/source/drivers/odbc/OTools.cxx |4 
 external/iODBC/README   |1 
 external/iODBC/inc/odbc/iodbcunix.h |  160 
 external/iODBC/inc/odbc/sql.h   | 1187 +++
 external/iODBC/inc/odbc/sqlext.h| 2573 
 external/iODBC/inc/odbc/sqltypes.h  |  429 ++
 external/iODBC/inc/odbc/sqlucode.h  |  818 +
 external/unixODBC/README|1 
 external/unixODBC/inc/odbc/sql.h|  824 -
 external/unixODBC/inc/odbc/sqlext.h | 2122 -
 external/unixODBC/inc/odbc/sqltypes.h   |  470 --
 external/unixODBC/inc/odbc/sqlucode.h   |  789 
 readlicense_oo/license/license.xml  |   37 
 solenv/clang-format/excludelist |8 
 17 files changed, 5210 insertions(+), 4218 deletions(-)

New commits:
commit a9434ec5758e59e2dba766e4ff84b8040ca43f47
Author: Andras Timar 
AuthorDate: Tue Nov 30 12:45:40 2021 +0100
Commit: Andras Timar 
CommitDate: Sat Jan 13 20:47:09 2024 +0100

Replace unixODBC to iODBC that is BSD licensed

Change-Id: Ia794fd97bb70b1e33385517971a174430d11cab7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126117
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Michael Meeks 

diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index 60499758de40..4d40129c0ab7 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -50,7 +50,7 @@ else # !SYSTEM_ODBC_HEADERS
 
 define gb_LinkTarget__use_odbc_headers
 $(call gb_LinkTarget_set_include,$(1),\
-   -I$(SRCDIR)/external/unixODBC/inc \
+   -I$(SRCDIR)/external/iODBC/inc \
$$(INCLUDE) \
 )
 
diff --git a/configure.ac b/configure.ac
index 18f2900fbd39..5511ab5c8371 100644
--- a/configure.ac
+++ b/configure.ac
@@ -10709,6 +10709,7 @@ elif test "$enable_database_connectivity" = no; then
 else
 AC_MSG_RESULT([internal])
 SYSTEM_ODBC_HEADERS=
+BUILD_TYPE="$BUILD_TYPE IODBC"
 fi
 AC_SUBST(SYSTEM_ODBC_HEADERS)
 
diff --git a/connectivity/source/drivers/odbc/OPreparedStatement.cxx 
b/connectivity/source/drivers/odbc/OPreparedStatement.cxx
index d5852c9ea407..c9ad477a70b8 100644
--- a/connectivity/source/drivers/odbc/OPreparedStatement.cxx
+++ b/connectivity/source/drivers/odbc/OPreparedStatement.cxx
@@ -306,7 +306,7 @@ void OPreparedStatement::setParameter(const sal_Int32 
parameterIndex, const sal_
  * ODBC Programmer's reference > Developing Applications > Programming 
Considerations > Unicode >  Unicode Function Arguments
  *http://support.microsoft.com/kb/294169
  *
- * UnixODBC can be configured at compile-time so that the "W" variants 
expect
+ * iODBC can be configured at compile-time so that the "W" variants 
expect
  * UTF-16 or UTF-32 encoded strings, and character lengths are number 
of codepoints.
  * However, UTF-16 is the default, what all/most distributions do
  * and the established API that most drivers implement.
diff --git a/connectivity/source/drivers/odbc/OTools.cxx 
b/connectivity/source/drivers/odbc/OTools.cxx
index 4781415de474..e65da53c20cf 100644
--- a/connectivity/source/drivers/odbc/OTools.cxx
+++ b/connectivity/source/drivers/odbc/OTools.cxx
@@ -65,7 +65,7 @@ size_t sqlTypeLen ( SQLSMALLINT _nType )
 return sizeof(SQLBIGINT);
 case SQL_C_UBIGINT:
 return sizeof(SQLUBIGINT);
-/* UnixODBC gives this the same value as SQL_C_UBIGINT
+/* iODBC gives this the same value as SQL_C_UBIGINT
 case SQL_C_BOOKMARK:
 return sizeof(BOOKMARK); */
 case SQL_C_TYPE_DATE:
@@ -99,7 +99,7 @@ size_t sqlTypeLen ( SQLSMALLINT _nType )
 case SQL_C_CHAR:
 case SQL_C_WCHAR:
 case SQL_C_BINARY:
-// UnixODBC gives this the same value as SQL_C_BINARY
+// iODBC gives this the same value as SQL_C_BINARY
 //case SQL_C_VARBOOKMARK:
 // Unknown datatype -> cannot predict length
 default:
diff --git a/external/iODBC/README b/external/iODBC/README
new file mode 100644
index ..df189dcd88e7
--- /dev/null
+++ b/external/iODBC/README
@@ -0,0 +1 @@
+iODBC is an open-source ODBC driver manager and SDK that facilitates the 
development of database-independent applications on Linux, FreeBSD, Unix and 
macOS platforms.  [http://www.iodbc.org/]
diff --git a/external/iODBC/inc/odbc/iodbcunix.h 
b/external/iODBC/inc/odbc/iodbcunix.h
new file mode 100644
index ..22e1518ba44a
--- /dev/null
+++ b/external/iODBC/inc/odbc/iodbcunix.h
@@ -0,0 +1,160 @@
+/*
+ *  iodbcunix.h
+ *
+ *  $Id$
+ *
+ *  ODBC defines for Unix
+ 

core.git: Branch 'distro/collabora/co-24.04' - 6 commits - instsetoo_native/inc_ooohelppack instsetoo_native/inc_openoffice instsetoo_native/inc_sdkoo officecfg/registry postprocess/signing

[Thais Vieira (via logerrit)]

 instsetoo_native/inc_ooohelppack/windows/msi_templates/Property.idt  |
8 
 instsetoo_native/inc_openoffice/windows/msi_templates/Property.idt   |
8 
 instsetoo_native/inc_sdkoo/windows/msi_templates/Property.idt|
8 
 officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu |
2 +-
 officecfg/registry/schema/org/openoffice/Office/Common.xcs   |
4 ++--
 officecfg/registry/schema/org/openoffice/Office/Linguistic.xcs   |
1 -
 postprocess/signing/signing.pl   |
1 +
 7 files changed, 16 insertions(+), 16 deletions(-)

New commits:
commit bbfa2264e58fcba76ec7929855b81347ed2201e6
Author: Thais Vieira 
AuthorDate: Fri Sep 4 08:21:28 2020 -0300
Commit: Andras Timar 
CommitDate: Sat Jan 13 20:46:34 2024 +0100

Loleaflet:fix menu entry

replacing the 'Select...' to 'Select Table'
to it be consistent with the pattern.

Change-Id: I17ce12fb6dd51256d68c735b7934e4e2bf643fff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102044
Reviewed-by: Tor Lillqvist 
Tested-by: Jenkins CollaboraOffice 

diff --git 
a/officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu
index 6de8e0058a52..af2e7cb9fbd5 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu
@@ -2076,7 +2076,7 @@
   Select Table
 
 
-  ~Select...
+  ~Select Table
 
 
   Select Table
commit 8bdcda095ae39718945def78929a659b4bce0e69
Author: Andras Timar 
AuthorDate: Fri Apr 18 02:36:57 2014 -0700
Commit: Andras Timar 
CommitDate: Sat Jan 13 20:45:12 2024 +0100

[cp] Collabora Office ARP data

Change-Id: I83d28b9bc7985f34303d3c3343f976b5a87009e1

diff --git 
a/instsetoo_native/inc_ooohelppack/windows/msi_templates/Property.idt 
b/instsetoo_native/inc_ooohelppack/windows/msi_templates/Property.idt
index ca9abc8110e1..c051543688fd 100644
--- a/instsetoo_native/inc_ooohelppack/windows/msi_templates/Property.idt
+++ b/instsetoo_native/inc_ooohelppack/windows/msi_templates/Property.idt
@@ -7,10 +7,10 @@ AgreeToLicenseNo
 ApplicationUsers   AllUsers
 ALLUSERS   1
 ARPCOMMENTSARPCOMMENTSTEMPLATE
-ARPCONTACT OOO_ARPCONTACTTEMPLATE
-ARPHELPLINKOOO_ARPHELPLINKTEMPLATE
-ARPURLINFOABOUTOOO_ARPURLINFOABOUTTEMPLATE
-ARPURLUPDATEINFO   OOO_ARPURLUPDATEINFOTEMPLATE
+ARPCONTACT Collabora Productivity Ltd.
+ARPHELPLINKhttps://CollaboraOffice.com
+ARPURLINFOABOUThttps://CollaboraOffice.com
+ARPURLUPDATEINFO   https://CollaboraOffice.com
 DefaultUIFont  DialogDefault
 DialogCaption  Windows Installer
 DiskPrompt [1]
diff --git a/instsetoo_native/inc_openoffice/windows/msi_templates/Property.idt 
b/instsetoo_native/inc_openoffice/windows/msi_templates/Property.idt
index e528cac384ec..5a5b6e6ae2db 100644
--- a/instsetoo_native/inc_openoffice/windows/msi_templates/Property.idt
+++ b/instsetoo_native/inc_openoffice/windows/msi_templates/Property.idt
@@ -7,10 +7,10 @@ AgreeToLicenseNo
 ApplicationUsers   AllUsers
 ALLUSERS   1
 ARPCOMMENTSARPCOMMENTSTEMPLATE
-ARPCONTACT OOO_ARPCONTACTTEMPLATE
-ARPHELPLINKOOO_ARPHELPLINKTEMPLATE
-ARPURLINFOABOUTOOO_ARPURLINFOABOUTTEMPLATE
-ARPURLUPDATEINFO   OOO_ARPURLUPDATEINFOTEMPLATE
+ARPCONTACT Collabora Productivity Ltd.
+ARPHELPLINKhttps://CollaboraOffice.com
+ARPURLINFOABOUThttps://CollaboraOffice.com
+ARPURLUPDATEINFO   https://CollaboraOffice.com
 DefaultUIFont  DialogDefault
 DialogCaption  Windows Installer
 DiskPrompt [1]
diff --git a/instsetoo_native/inc_sdkoo/windows/msi_templates/Property.idt 
b/instsetoo_native/inc_sdkoo/windows/msi_templates/Property.idt
index bd9065fd92b5..9883f9bdf146 100644
--- a/instsetoo_native/inc_sdkoo/windows/msi_templates/Property.idt
+++ b/instsetoo_native/inc_sdkoo/windows/msi_templates/Property.idt
@@ -6,10 +6,10 @@ _IsSetupTypeMin   Typical
 AgreeToLicense No
 ApplicationUsers   AllUsers
 ARPCOMMENTSARPCOMMENTSTEMPLATE
-ARPCONTACT OOO_ARPCONTACTTEMPLATE
-ARPHELPLINKOOO_ARPHELPLINKTEMPLATE
-ARPURLINFOABOUTOOO_ARPURLINFOABOUTTEMPLATE
-ARPURLUPDATEINFO   OOO_ARPURLUPDATEINFOTEMPLATE
+ARPCONTACT Collabora Productivity Ltd.
+ARPHELPLINKhttps://CollaboraOffice.com
+ARPURLINFOABOUThttps://CollaboraOffice.com
+ARPURLUPDATEINFO   https://CollaboraOffice.com
 ARPNOREPAIR1
 ARPNOMODIFY1
 DefaultUIFont  Tahoma8
commit dce0227150c21117849abd873ecc1cc921d06fe8
Author: Andras Timar 
AuthorDate: Wed Apr 18 07:19:00 2018 -0700
Commit: Andras Timar 
CommitDate: Sat Jan 13 20:44:57 2024 +0100

[cp] HACK: sleep before sign

On Windows, with 16x parallel 

[Bug 159144] Writer freezes/crashes when changing page style to landscape

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159144

--- Comment #7 from BogdanB  ---
(In reply to Federico Castellani from comment #6)
>  14e8b050b60849b0367e85b94faa4b85ebed38e3 is the first bad commit
> commit 14e8b050b60849b0367e85b94faa4b85ebed38e3
> Author: Jenkins Build User 
> Date:   Fri Jun 16 19:08:16 2023 +0200
> 
> source 1c60f18de581d42c200e119aa5efc72fc7ee0bcd
> 
> source 1c60f18de581d42c200e119aa5efc72fc7ee0bcd
> 
> Bisected with: linux-64-24.2

Your bibisect is not correct. The problem is old. So the bibisect should result
in something 3-4 years old.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'libreoffice-24-2' - helpcontent2

[Stéphane Guillou (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 054541f449f1d131b2aa50e1d6e35080d388a164
Author: Stéphane Guillou 
AuthorDate: Sat Jan 13 20:17:55 2024 +0100
Commit: Gerrit Code Review 
CommitDate: Sat Jan 13 20:17:55 2024 +0100

Update git submodules

* Update helpcontent2 from branch 'libreoffice-24-2'
  to d529ecdee07d04f261fd13d05ecf2e0ee9f18a4b
  - tdf#156156: add Slide Transition sidebar deck help button's HID

and document how to access it.

Change-Id: I3f5c8e0f65f704389ed27989b29cca2cf0279302
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161107
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 
(cherry picked from commit c8244945b9d36822a2a35edca7bb9111f39ef282)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161636
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/helpcontent2 b/helpcontent2
index 8a46af6d1523..d529ecdee07d 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 8a46af6d1523f0092c0a000cce688ec4916b9ef9
+Subproject commit d529ecdee07d04f261fd13d05ecf2e0ee9f18a4b

help.git: Branch 'libreoffice-24-2' - source/text

[Stéphane Guillou (via logerrit)]

 source/text/simpress/00/0407.xhp |   12 +++-
 source/text/simpress/01/0604.xhp |3 ++-
 2 files changed, 13 insertions(+), 2 deletions(-)

New commits:
commit d529ecdee07d04f261fd13d05ecf2e0ee9f18a4b
Author: Stéphane Guillou 
AuthorDate: Thu Dec 21 16:29:40 2023 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Sat Jan 13 20:17:54 2024 +0100

tdf#156156: add Slide Transition sidebar deck help button's HID

and document how to access it.

Change-Id: I3f5c8e0f65f704389ed27989b29cca2cf0279302
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161107
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 
(cherry picked from commit c8244945b9d36822a2a35edca7bb9111f39ef282)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161636
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/source/text/simpress/00/0407.xhp 
b/source/text/simpress/00/0407.xhp
index 3457731645..7f755eb388 100644
--- a/source/text/simpress/00/0407.xhp
+++ b/source/text/simpress/00/0407.xhp
@@ -28,7 +28,17 @@
 
 
 Slide Show Menu
-Choose 
View - Slide Transition.
+
+  
+  OptionAlt
 + 6
+  
+  Choose View - 
Slide Transition.
+  
+  Choose 
Slide Show - Slide Transition.
+  In the 
Slide Show menu of the Slide Show 
tab, choose Slide Transition.
+  
+Open the 
Slide Transition deck.
+
   
 Choose Insert - 
Animated Image.
   
diff --git a/source/text/simpress/01/0604.xhp 
b/source/text/simpress/01/0604.xhp
index 1bfd3838ba..aaec1ea5ad 100644
--- a/source/text/simpress/01/0604.xhp
+++ b/source/text/simpress/01/0604.xhp
@@ -37,12 +37,13 @@
 
 
 
+
 
   Slide 
Transition
   Defines the special effect that plays when you display a slide during a 
slide show.
 
 
-  
+  
 
 To apply the same 
transition effect to more than one slide, switch to the Slide Sorter, select the slides, 
and then choose Slide - Slide Transition.
 

core.git: Branch 'libreoffice-24-2' - helpcontent2

[Rafael Lima (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b3d64e6fbdaccf558cdbd1ac4da8d53c623ebb56
Author: Rafael Lima 
AuthorDate: Sat Jan 13 20:14:15 2024 +0100
Commit: Gerrit Code Review 
CommitDate: Sat Jan 13 20:14:15 2024 +0100

Update git submodules

* Update helpcontent2 from branch 'libreoffice-24-2'
  to 8a46af6d1523f0092c0a000cce688ec4916b9ef9
  - Silence strings for translation in sf_dataset.xhp

Change-Id: I62754d87b3feef4b54f7de43ec041c20c9ad07b2
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161940
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 
(cherry picked from commit e464f139740062a8da409d74c2942205dbe99aa0)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161999

diff --git a/helpcontent2 b/helpcontent2
index 4a851d785063..8a46af6d1523 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 4a851d785063f7286f134810ef87ee5e945a3ba7
+Subproject commit 8a46af6d1523f0092c0a000cce688ec4916b9ef9

help.git: Branch 'libreoffice-24-2' - source/text

[Rafael Lima (via logerrit)]

 source/text/sbasic/shared/03/sf_dataset.xhp |   30 ++--
 1 file changed, 15 insertions(+), 15 deletions(-)

New commits:
commit 8a46af6d1523f0092c0a000cce688ec4916b9ef9
Author: Rafael Lima 
AuthorDate: Thu Jan 11 22:12:05 2024 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Sat Jan 13 20:14:14 2024 +0100

Silence strings for translation in sf_dataset.xhp

Change-Id: I62754d87b3feef4b54f7de43ec041c20c9ad07b2
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161940
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 
(cherry picked from commit e464f139740062a8da409d74c2942205dbe99aa0)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161999

diff --git a/source/text/sbasic/shared/03/sf_dataset.xhp 
b/source/text/sbasic/shared/03/sf_dataset.xhp
index 47158a535e..8f3d509b0e 100644
--- a/source/text/sbasic/shared/03/sf_dataset.xhp
+++ b/source/text/sbasic/shared/03/sf_dataset.xhp
@@ -515,11 +515,11 @@
 
 
 
-  currId = 
oDataset.GetValue(FieldName := "ID")
+  currId = oDataset.GetValue(FieldName := 
"ID")
 
 
 
-  curr_id = 
dataset.GetValue(fieldname = "ID")
+  curr_id = dataset.GetValue(fieldname = 
"ID")
 
   
 
@@ -559,7 +559,7 @@
 
   dataset = 
database.CreateDataset("Customers")
   new_data = {"Name": 
"John", "Age": 30, "City": "Chicago"}
-  new_id = 
dataset.Insert(new_data)
+  new_id = dataset.Insert(new_data)
 
 The following calls 
are accepted in Python:
 
@@ -588,11 +588,11 @@
 
 
 
-  oDataset.MoveFirst()
+  oDataset.MoveFirst()
 
 
 
-  dataset.MoveFirst()
+  dataset.MoveFirst()
 
   
 
@@ -618,13 +618,13 @@
 
 
 
-  oDataset.MoveNext()
-  oDataset.MoveNext(5)
+  oDataset.MoveNext()
+  oDataset.MoveNext(5)
 
 
 
-  dataset.MoveNext()
-  dataset.MoveNext(5)
+  dataset.MoveNext()
+  dataset.MoveNext(5)
 
   
 
@@ -647,13 +647,13 @@
 
 
 
-  oDataset.Reload()
+  oDataset.Reload()
   oDataset.Reload(Filter := "[Name] = 'John'", OrderBy 
:= "Age")
 
 
 
-  dataset.Reload()
-  dataset.Reload(Filter = "[Name] = 'John'", OrderBy = 
"Age"
+  dataset.Reload()
+  dataset.Reload(Filter = "[Name] = 'John'", OrderBy = 
"Age")
 
   
 
@@ -675,10 +675,10 @@
 
 The example below 
updates the current record using a Dictionary.
 
-  oNewValues = 
CreateScriptService("Dictionary")
+  oNewValues = 
CreateScriptService("Dictionary")
   oNewValues.Add("Age", 51)
   oNewValues.Add("City", "New York")
-  oDataset.Update(oNewValues)
+  oDataset.Update(oNewValues)
 
 The same result can 
be achieved by passing all pairs of fields and values as arguments:
 
@@ -687,7 +687,7 @@
 
 
   new_values = {"Age": 
51, "City": "New York"}
-  dataset.Update(new_values)
+  dataset.Update(new_values)
 
 
   dataset.Update("Age", 51, "City", "New 
York")

[Bug 122886] [META] Bugs with textboxes in shapes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122886
Bug 122886 depends on bug 132810, which changed state.

Bug 132810 Summary: Gallery: Crash swlo!SwFEShell::SelectObj+0x46a when 
inserting a new shape with cursor still in textbox 
SwFrame::AppendDrawObj(SwAnchoredObject &)
https://bugs.documentfoundation.org/show_bug.cgi?id=132810

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 105537] [META] Assertion failed crashes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105537
Bug 105537 depends on bug 132810, which changed state.

Bug 132810 Summary: Gallery: Crash swlo!SwFEShell::SelectObj+0x46a when 
inserting a new shape with cursor still in textbox 
SwFrame::AppendDrawObj(SwAnchoredObject &)
https://bugs.documentfoundation.org/show_bug.cgi?id=132810

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 99671] [META] Gallery bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99671
Bug 99671 depends on bug 132810, which changed state.

Bug 132810 Summary: Gallery: Crash swlo!SwFEShell::SelectObj+0x46a when 
inserting a new shape with cursor still in textbox 
SwFrame::AppendDrawObj(SwAnchoredObject &)
https://bugs.documentfoundation.org/show_bug.cgi?id=132810

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: vcl/unx

[Julien Nabet (via logerrit)]

 vcl/unx/gtk3/gtksalmenu.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 4718a8e7af6df95c143179c7161a19aecade0701
Author: Julien Nabet 
AuthorDate: Sat Jan 13 18:06:14 2024 +0100
Commit: Caolán McNamara 
CommitDate: Sat Jan 13 19:53:32 2024 +0100

Add missing g_bytes_unref in GtkSalMenu::AddMenuBarButton

Change-Id: I00b8a73cfe02abc561ddf67c0e6e4ad612c27422
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162018
Reviewed-by: Julien Nabet 
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/gtksalmenu.cxx b/vcl/unx/gtk3/gtksalmenu.cxx
index a510473650d6..804c1d017ac9 100644
--- a/vcl/unx/gtk3/gtksalmenu.cxx
+++ b/vcl/unx/gtk3/gtksalmenu.cxx
@@ -830,6 +830,7 @@ bool GtkSalMenu::AddMenuBarButton(const SalMenuButtonItem& 
rNewItem)
 pImage = gtk_image_new_from_gicon(pIcon);
 #endif
 g_object_unref(pIcon);
+g_bytes_unref(pBytes);
 }
 
 GtkWidget* pButton = AddButton(pImage);

core.git: vcl/unx

[Julien Nabet (via logerrit)]

 vcl/unx/gtk3/gtkinst.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit f021d5eb645efaf749d97ad26471ef8ddf607db9
Author: Julien Nabet 
AuthorDate: Sat Jan 13 17:26:34 2024 +0100
Commit: Caolán McNamara 
CommitDate: Sat Jan 13 19:49:10 2024 +0100

Add missing g_object_thaw_notify before an early return (vcl/gtkinst)

Change-Id: I3ba4bfd9a302e03dd25e4635dfbb0a41d265349e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162015
Reviewed-by: Julien Nabet 
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index 7f79efee094b..3288b635f0ef 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -15517,7 +15517,10 @@ public:
 GtkTreePath* end_path;
 
 if (!gtk_tree_view_get_visible_range(m_pTreeView, _path, 
_path))
+{
+g_object_thaw_notify(G_OBJECT(m_pTreeModel));
 return;
+}
 
 GtkInstanceTreeIter aGtkIter(nullptr);
 gtk_tree_model_get_iter(m_pTreeModel, , start_path);

core.git: vcl/unx

[Julien Nabet (via logerrit)]

 vcl/unx/gtk3/gtkinst.cxx |   16 
 1 file changed, 16 insertions(+)

New commits:
commit dcf778c85c84edea74e71c11faed9a5c22557a80
Author: Julien Nabet 
AuthorDate: Sat Jan 13 15:38:28 2024 +0100
Commit: Caolán McNamara 
CommitDate: Sat Jan 13 19:48:16 2024 +0100

Add missing gdk_event_free (vcl/gtkinst)

Change-Id: I8bef4c3303f8f2fd89c1cf7cec35536c38d9d4d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162014
Reviewed-by: Julien Nabet 
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index e80098630919..7f79efee094b 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -11098,10 +11098,16 @@ private:
 gtk_main_do_event(pKeyEvent);
 
 GdkEvent *pTriggerEvent = gtk_get_current_event();
+bool bEventOwnership = true;
 if (!pTriggerEvent)
+{
 pTriggerEvent = pKeyEvent;
+bEventOwnership = false;
+}
 
 gtk_menu_popup_at_widget(m_pMenu, pWidget, GDK_GRAVITY_SOUTH_WEST, 
GDK_GRAVITY_NORTH_WEST, pTriggerEvent);
+if (bEventOwnership)
+gdk_event_free(pTriggerEvent);
 
 gdk_event_free(pKeyEvent);
 }
@@ -9,6 +11125,7 @@ private:
 {
 gdk_event_get_button(pEvent, );
 nTime = gdk_event_get_time(pEvent);
+gdk_event_free(pEvent);
 }
 else
 {
@@ -11460,8 +11467,12 @@ public:
 gtk_main_do_event(pKeyEvent);
 
 GdkEvent *pTriggerEvent = gtk_get_current_event();
+bool bEventOwnership = true;
 if (!pTriggerEvent)
+{
 pTriggerEvent = pKeyEvent;
+bEventOwnership = false;
+}
 
 bool bSwapForRTL = SwapForRTL(pWidget);
 
@@ -11479,6 +11490,8 @@ public:
 else
 gtk_menu_popup_at_rect(m_pMenu, 
widget_get_surface(pWidget), , GDK_GRAVITY_NORTH_EAST, 
GDK_GRAVITY_NORTH_WEST, pTriggerEvent);
 }
+if (bEventOwnership)
+gdk_event_free(pTriggerEvent);
 
 gdk_event_free(pKeyEvent);
 }
@@ -11501,6 +11514,7 @@ public:
 if (!gdk_event_get_button(pEvent, ))
 nButton = 0;
 nTime = gdk_event_get_time(pEvent);
+gdk_event_free(pEvent);
 }
 else
 {
@@ -14137,6 +14151,8 @@ private:
 #if !GTK_CHECK_VERSION(4, 0, 0)
 GdkEvent *pEvent = gtk_get_current_event();
 m_bChangedByMouse = pEvent && categorizeEvent(pEvent) == 
VclInputFlags::MOUSE;
+if (pEvent)
+gdk_event_free(pEvent);
 #else
 //TODO maybe iterate over gtk_widget_observe_controllers looking for a 
motion controller
 #endif

core.git: vcl/unx

[Julien Nabet (via logerrit)]

 vcl/unx/gtk3/gtkinst.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 154573770de9658de828ea3b666c0a0a64ed249b
Author: Julien Nabet 
AuthorDate: Sat Jan 13 17:43:03 2024 +0100
Commit: Caolán McNamara 
CommitDate: Sat Jan 13 19:45:16 2024 +0100

Add missing g_list_free in GtkInstanceComboBox ctr

Change-Id: I1cb70afb229036209c635e52c9b22f619025f368
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162016
Reviewed-by: Julien Nabet 
Tested-by: Jenkins
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index 760c95b00543..e80098630919 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -20343,6 +20343,7 @@ public:
 bFindButtonTextRenderer = false;
 }
 }
+g_list_free(cells);
 
 // Seeing as GtkCellRendererPixbuf no longer takes a surface, then 
insert our own replacement
 // to render that instead here

core.git: helpcontent2

[Rafael Lima (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f21fb5f530d40b4decdb5b9c153412f195293df2
Author: Rafael Lima 
AuthorDate: Sat Jan 13 19:42:21 2024 +0100
Commit: Gerrit Code Review 
CommitDate: Sat Jan 13 19:42:21 2024 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to b8c6c19ab2fac10cdade1ae96721422814b19be3
  - Silence strings for translation in sf_dataset.xhp

Change-Id: I62754d87b3feef4b54f7de43ec041c20c9ad07b2
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161940
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/helpcontent2 b/helpcontent2
index 2039fbabf053..b8c6c19ab2fa 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 2039fbabf053a19c9eaeee3db95dc8d710dfeb69
+Subproject commit b8c6c19ab2fac10cdade1ae96721422814b19be3