[Bug 159679] pdf digital signature, fails to access to the list of my openpgp signature in kleopatra

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159679

promeneur  changed:

   What|Removed |Added

 OS|All |Linux (All)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159679] pdf digital signature, fails to access to the list of my openpgp signature in kleopatra

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159679

promeneur  changed:

   What|Removed |Added

Version|unspecified |7.6.4.1 release

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159679] New: pdf digital signature, fails to access to the list of my openpgp signature in kleopatra

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159679

Bug ID: 159679
   Summary: pdf digital signature, fails to access to the list of
my openpgp signature in kleopatra
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: epistemepromen...@free.fr

openSUSE Tumbleweed
LibreOffice 7.6.4.1

With Draw I try to digital sign a pdf with 

digital signature > signing an existing pdf > sign the document > select the
document > start the certificate manager > sign the document > select the
certificate

The window of the list of the certificates from kleopatra is empty.

Thus, I can't select a certificate.


The option "digital signature > digital signature" for a .dot file works well.

The windows "select the certicate" supplies all the Kleopatra certificates.

Thus, I can select a certificate and sign the document.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159678] New: heading fields in headers and footers do not track heading content through the document

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159678

Bug ID: 159678
   Summary: heading fields in headers and footers do not track
heading content through the document
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: v+li...@nevcal.com

Created attachment 192503
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192503=edit
basic document to demonstrate bug.

Based on the recommendation at the link, this seems to be a regression bug.
https://ask.libreoffice.org/t/header-fields-not-tracking-header-values/101951/2
At the above link, the claim is made by mikekaganski that this was working in
version 7.6. I appreciate his help.

LibreOffice 24.2.0.3 on Windows 10 64-bit

I’ve done a bunch of searching trying to figure out how to have a field in my
header track the headings in my data, and I had set up some styles I thought
would work, and nothing worked, so finally I made what I think is a basic file,
using default styles, and it doesn’t work either, so now I’m wondering if I’ve
been reading the wrong documentation, if the documentation is wrong or
insufficient, or if there is a bug.

Below is the simple file, containing a header and a footer with the field for
heading 9 content. Then there are some pairs of heading 9 styles and a default
paragraph followed by a bunch of blanks. to get me to two pages.

The Heading seems to pick up the first instance (CAT) of the heading 9 content,
but doesn’t switch to a later one on page 2. The footer also picks up the first
instance (CAT) of the heading 9 content, but since there are two of them on
page 2, and from my research, I thought it should display the last heading 9
content on page 1 (DOG). I thought the header of page 2 should have (DOG), and
the foot of page 2 should have (GOPHER). But the CAT is everywhere!

So what basic feature have I misunderstood or isn’t working in this very simple
file? While I’ve been using Writer for a while, this is the first attempt at
using these fields and headers, and I’m stumped, in spite of finding lots of
similar questions, and attempting to follow the similar answers in my more
complex format, but now I see I don’t even understand how to get dynamic field
values using the very most basic format.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 141776] Shown mnemonic/accelerators in Start Center require + key on Windows

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141776

--- Comment #22 from Wally  ---
I just tested and it finally now works without the ALT key.  
Thank you

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 141776] Shown mnemonic/accelerators in Start Center require + key on Windows

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141776

--- Comment #22 from Wally  ---
I just tested and it finally now works without the ALT key.  
Thank you

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 159234] Format - Align text - Align Left/Center/Right Align does not always work

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159234

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INSUFFICIENTDATA

--- Comment #6 from Stéphane Guillou (stragu) 
 ---
Thanks for the reply. Let's close as "insufficient data" for now but please set
back to "unconfirmed" if you can reproduce again and provide more information.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 92389] Writer: Comment text not accessible with screen reader

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=92389

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org
Version|4.2.5.2 release |Inherited From OOo

--- Comment #18 from Stéphane Guillou (stragu) 
 ---
Same in OOo 3.3: characters read aloud by Orca when entered, but not when
navigating existing text with cursor.

Still current in recent trunk build:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 4d381b54d1c598c181b4a21a8bf0db86eb4668d1
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159230] Shortcuts are not available for Find and replace dialog in Mac

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159230

Mike Kaganski  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=15 |
   |2379|

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 102054] Allow access and modifying of comment with keyboard

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=102054

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #8 from Stéphane Guillou (stragu) 
 ---
(In reply to Yousuf Philips (jay) (retired) from comment #6)
> Patch that Gulsah previously submitted -
> https://gerrit.libreoffice.org/#/c/30332/
... and a follow-up attempt by Yousuf, also abandoned:
https://gerrit.libreoffice.org/c/core/+/31449/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 152379] Shortcut keys in Paste Special dialog in Calc 7.4.3 does not work any more

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152379

Mike Kaganski  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=15 |
   |9230|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159230] Shortcuts are not available for Find and replace dialog in Mac

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159230

Mike Kaganski  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=15 |
   |2379|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159230] Shortcuts are not available for Find and replace dialog in Mac

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159230

Mike Kaganski  changed:

   What|Removed |Added

 CC||mitja.mas...@gmail.com

--- Comment #11 from Mike Kaganski  ---
*** Bug 152379 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 152379] Shortcut keys in Paste Special dialog in Calc 7.4.3 does not work any more

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152379

--- Comment #5 from Mike Kaganski  ---
Bug 159230 has detailed discussion / explanation of the macOS behavior.

*** This bug has been marked as a duplicate of bug 159230 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159230] Shortcuts are not available for Find and replace dialog in Mac

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159230

Mike Kaganski  changed:

   What|Removed |Added

 CC||mitja.mas...@gmail.com

--- Comment #11 from Mike Kaganski  ---
*** Bug 152379 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 152379] Shortcut keys in Paste Special dialog in Calc 7.4.3 does not work any more

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152379

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||9230

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159230] Shortcuts are not available for Find and replace dialog in Mac

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159230

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||2379

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159230] Shortcuts are not available for Find and replace dialog in Mac

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159230

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||2379

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 152379] Shortcut keys in Paste Special dialog in Calc 7.4.3 does not work any more

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152379

--- Comment #4 from Mike Kaganski  ---
If this (Cmd+mnemonic) is a standard behavior on macOS, this is an own bug, and
not a dupe for an issue on another OS (even if caused by the same commit).
Needs investigating and resolving on per-OS basis.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159625] Can NOT un-check [allow to split paragraph]

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159625

Telesto  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #6 from Telesto  ---
(In reply to Julien Nabet from comment #5)
I'm able to reproduce comment 5
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: ba8f4bff6015013013df652efbfaf4d9ae10c881
CPU threads: 8; OS: macOS 14.3; UI render: Skia/Raster; VCL: osx
Locale: nl-NL (nl_NL.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159467] XLOOKUP does not work if embedded in another XLOOKUP

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159467

ady  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #4 from ady  ---
XLOOKUP still failing after (second) patch from tdf#127293 comment 44, dated
2024-02-09, using Calc dated 2024-02-11

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 17fc445938dedb05125a6d6a5b4ce7f34ea95f59
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-US (es_AR); UI: en-US
Calc: threaded

I have also tested with 2 other spreadsheet tools and using STR from comment 0
works correctly there, but generates #N/A (not available error) in LO Calc.

In Calc, attachment 192274 > worksheet "Ex5" > when the search string (cell
A12) is found in the list in range A2:A8, for the chained XLOOKUP to provide
the "correct" result (although, only by chance), the same string has to be also
part of the other list in range F2:F8 too. If the search string is not part of
the second range F2:F8 too, then the result is #N/A.

Or, IOW, the formula appears to be able to retrieve _the result_ from both
lists (B2:B8; G2:G8), but it is searching the criterion only on the second
range F2:F8.

Translated to the array formula:
=XLOOKUP(A12;A2:A8;B2:B8;XLOOKUP(A12;F2:F8;G2:G8))

... it is only executing the search of the criterion on the second XLOOKUP(),
which is the "Result_if_not_found" of the first XLOOKUP(), but it can retrieve
the result from the first XLOOKUP() (too).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159652] Finding a way to join a suffix to the word immediately before it, using autocorrect function

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159652

Shantanu  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
 CC||shantanu@gmail.com

--- Comment #4 from Shantanu  ---
Such a feature will also help Marathi language. The people incorrectly write
"घरा चा" or "घरा ची"  (with space) instead of "घराचा" / "घराची" (without 
space). There
should be a parameter to declare such suffixes to be joined with the earlier
word. The suffixes like "चा" or "ची" are not accepted words in Marathi and never
used separately after space. (like "ed" not a word in English but correct in
"worked")

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 159652] Finding a way to join a suffix to the word immediately before it, using autocorrect function

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159652

Shantanu  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
 CC||shantanu@gmail.com

--- Comment #4 from Shantanu  ---
Such a feature will also help Marathi language. The people incorrectly write
"घरा चा" or "घरा ची"  (with space) instead of "घराचा" / "घराची" (without 
space). There
should be a parameter to declare such suffixes to be joined with the earlier
word. The suffixes like "चा" or "ची" are not accepted words in Marathi and never
used separately after space. (like "ed" not a word in English but correct in
"worked")

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 141776] Shown mnemonic/accelerators in Start Center require + key on Windows

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141776

Mike Kaganski  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=15 |
   |2223|
 CC||bwwald...@gmail.com

--- Comment #21 from Mike Kaganski  ---
*** Bug 152223 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 152223] 7.4.3.2 Calc has a problem, some keys need [Alt] in quit dialog box

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152223

Mike Kaganski  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=14 |
   |1776|
 Resolution|NOTABUG |DUPLICATE
   Keywords|bibisectRequest,|
   |needsUXEval, regression |

--- Comment #10 from Mike Kaganski  ---
Here, two different things are mixed together.

1. In reply to Wally from comment #0:
> I can't use the N or the S or the C keys in the Save Document box without 
> using
> the ALT key with them.  Things work with ALT+S, ALT+, ALT+C.

This is unclear; was this about the *system's* File dialog? MS Windows itself
doesn't provide a mnemonic for e.g. Cancel button. Same happens in Notepad.exe
=> NOTABUG / NOTOURBUG (if this was about system dialogs). Nothing LibreOffice
could do. But - Alt+C doesn't work with that dialog, too. That contradicts the
comment 0 's "Things work with ... ALT+C".

LibreOffice's own dialogs, activated using Options->LibreOffice->General->Use
LibreOffice dialogs) have these mnemonics working without Alt, when out of edit
/ list boxes (where the characters indeed have their own meaning), since fix of
bug 157649.

2. In reply to Wally from comment #3:
> I open Calc to an empty screen.  I used to be able to just press the "O" key 
> to
> open my list of files.  I now have to use ALT+O.  I have to use the ALT key 
> with
> the other options in the list such as ALT+W for Writer, etc.

This changed with the fix to bug 151385. And this is a correct thing; it is not
an established practice to allow mnemonics without Alt in Windows programs'
main windows (as opposed to dialogs). The underline could be confusing (as in
141776); but now it is also removed in the fix to bug 54169.

*** This bug has been marked as a duplicate of bug 141776 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 141776] Shown mnemonic/accelerators in Start Center require + key on Windows

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141776

Mike Kaganski  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=15 |
   |2223|
 CC||bwwald...@gmail.com

--- Comment #21 from Mike Kaganski  ---
*** Bug 152223 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=98259
Bug 98259 depends on bug 141776, which changed state.

Bug 141776 Summary: Shown mnemonic/accelerators in Start Center require + 
key on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=141776

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 141776] Shown mnemonic/accelerators in Start Center require + key on Windows

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141776

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #20 from Stéphane Guillou (stragu) 
 ---
As per comment 19, let's close as "won't fix". Thanks everyone.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 141776] Shown mnemonic/accelerators in Start Center require + key on Windows

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141776

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #20 from Stéphane Guillou (stragu) 
 ---
As per comment 19, let's close as "won't fix". Thanks everyone.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 152223] 7.4.3.2 Calc has a problem, some keys need [Alt] in quit dialog box

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152223

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||1776

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 141776] Shown mnemonic/accelerators in Start Center require + key on Windows

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141776

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||2223

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 141776] Shown mnemonic/accelerators in Start Center require + key on Windows

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141776

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||2223

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 145337] Menu bar doesn't have underlined letter for shortcut in Linux version of LO

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145337

--- Comment #6 from Mike Kaganski  ---
(In reply to zhengzhou_zhang from comment #0)
> Is it able to add the line in the linux version without having to hold the 
> alt key?

As explained in bug 92630 comment 0:

> GTK+2 and GTK+3 include the mechanism to hide accelerator shortcuts 
> (indicated by
> underlines) in menus and windows. This behaviour is optional in GTK+2, but is 
> now
> mandated in GTK+3 and cannot be disabled - the underlines are only shown and 
> only
> functional while the Alt key is held.

So no, there is no system mechanism to enable mnemonics without Alt in all GTK
applications.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 92630] GTK+ auto-accelerator functionality missing

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=92630

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||5337

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 145337] Menu bar doesn't have underlined letter for shortcut in Linux version of LO

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145337

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=92
   ||630
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG

--- Comment #5 from Mike Kaganski  ---
This is not a bug: commit 74407aef94b6d8dfdd69891c4a6e578587ef3e71 for bug
92630 has implemented support for native GTK auto-accelerator feature; thus,
since version 5.1, LibreOffice behaves in the same way as other first-class GTK
applications work.

Now, as bug 54169 is finally also fixed, the next version will also not show
underlined mnemonics on Windows by default, because that's how all current
Windows versions are configured by default.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 145337] Menu bar doesn't have underlined letter for shortcut in Linux version of LO

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145337

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=54
   ||169

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159404] Frame _blank option in Edit Hyperlink dialog has no effect on exported PDF

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159404

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159399] Replacing a word at the beginning of a marked sequence loses marker color

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159399

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159398] EDITING: In Find and Replace, 'without case' doesn't work

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159398

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 155919] Auto-capitalization not working after some amount without typing

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155919

--- Comment #4 from QA Administrators  ---
Dear mfm008,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 155826] Flowchart, [Connect Standard] connects [Process] and [Start End], Press the [Ctrl] key, scrolls the mouse wheel, and the page zooms. The position and shape of [Connect Standard] changes

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155826

--- Comment #2 from QA Administrators  ---
Dear Charles,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159234] Format - Align text - Align Left/Center/Right Align does not always work

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159234

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159234] Format - Align text - Align Left/Center/Right Align does not always work

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159234

--- Comment #5 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 97122] Modes tab bar activates "Slide Master" when clicking "Normal"

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=97122

--- Comment #20 from QA Administrators  ---
Dear Samuel Mehrbrodt (allotropia),

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 155643] Assign Action buttons not visible in Control Properties of form elements

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155643

--- Comment #3 from QA Administrators  ---
Dear christophe.alviset,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 80177] Date values from registered database appear as numbers when using them in a Pivot table data

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=80177

--- Comment #28 from QA Administrators  ---
Dear mshiner,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 77131] Charts - Drop lines / High-low lines are not preserved while saving as docx.

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=77131

--- Comment #9 from QA Administrators  ---
Dear bisal.nayal,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 100526] [FILEOPEN] New line/paragraph missing after field in specific DOCX

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=100526

--- Comment #12 from QA Administrators  ---
Dear Cor Nouws,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 155710] Calc crashes every time when saving linked files on macOS

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155710

Patrick Luby  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |guibomac...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: vcl/source

2024-02-10 Thread Mike Kaganski (via logerrit)
 vcl/source/window/menu.cxx  |7 ---
 vcl/source/window/menubarwindow.cxx |   14 ++
 2 files changed, 2 insertions(+), 19 deletions(-)

New commits:
commit 7d594687216f183a681ecfe7e1d424d8a55422c2
Author: Mike Kaganski 
AuthorDate: Sat Feb 10 23:30:02 2024 +0600
Commit: Mike Kaganski 
CommitDate: Sun Feb 11 01:43:04 2024 +0100

tdf#54169: do not hide mnemonics in menu, when navigating using mouse

Pressing Alt (or F10) by itself would activate/highlight the menu, and
show mnemonics. But clicking such activated menu used to disable the
mnemonics. This change fixes it, making sure that they keep displaying
until closing the menu.

Change-Id: I60f04e1474a8eb1322e5ac75f74b02d67dce9b73
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163217
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/vcl/source/window/menu.cxx b/vcl/source/window/menu.cxx
index b72f2f8c8091..eb08c4de9848 100644
--- a/vcl/source/window/menu.cxx
+++ b/vcl/source/window/menu.cxx
@@ -2861,13 +2861,6 @@ bool PopupMenu::PrepareRun(const VclPtr& 
pParentWin, tools::Rectang
 if (!pSFrom && (vcl::IsInPopupMenuExecute() || !nItemCount))
 return false;
 
-// set the flag to hide or show accelerators in the menu depending on 
whether the menu was launched by mouse or keyboard shortcut
-if( pSFrom && pSFrom->IsMenuBar())
-{
-auto pMenuBarWindow = 
static_cast(pSFrom->pWindow.get());
-pMenuBarWindow->SetMBWHideAccel( !(pMenuBarWindow->GetMBWMenuKey()) );
-}
-
 mpLayoutData.reset();
 
 ImplSVData* pSVData = ImplGetSVData();
diff --git a/vcl/source/window/menubarwindow.cxx 
b/vcl/source/window/menubarwindow.cxx
index 4198c5a824c3..9fb3552ed17a 100644
--- a/vcl/source/window/menubarwindow.cxx
+++ b/vcl/source/window/menubarwindow.cxx
@@ -465,7 +465,8 @@ void MenuBarWindow::ChangeHighlightItem( sal_uInt16 n, bool 
bSelectEntry, bool b
 if( ! m_pMenu )
 return;
 
-SetMBWHideAccel(n == ITEMPOS_INVALID);
+if (n == ITEMPOS_INVALID)
+SetMBWHideAccel(true);
 
 // #57934# close active popup if applicable, as TH's background storage 
works.
 MenuItemData* pNextData = m_pMenu->pItemList->GetDataFromPos( n );
@@ -850,8 +851,6 @@ bool MenuBarWindow::HandleKeyEvent( const KeyEvent& 
rKEvent, bool bFromMenu )
 }
 }
 
-bool autoacc = ImplGetSVData()->maNWFData.mbAutoAccel;
-
 if ( !bDone && ( bFromMenu || rKEvent.GetKeyCode().IsMod2() ) )
 {
 sal_Unicode nCharCode = rKEvent.GetCharCode();
@@ -868,15 +867,6 @@ bool MenuBarWindow::HandleKeyEvent( const KeyEvent& 
rKEvent, bool bFromMenu )
 }
 }
 
-const bool bShowAccels = nCode != KEY_ESCAPE;
-if (GetMBWMenuKey() != bShowAccels)
-{
-SetMBWMenuKey(bShowAccels);
-SetMBWHideAccel(!bShowAccels);
-if (autoacc)
-Invalidate(InvalidateFlags::Update);
-}
-
 return bDone;
 }
 


[Bug 155710] Calc crashes every time when saving linked files on macOS

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155710

--- Comment #4 from Patrick Luby  ---
Created attachment 192502
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192502=edit
Crash log

I can reproduce this in my local master build. Crash log attached.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158124] Holding down delete key doesn't work and causes crash

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158124

Patrick Luby  changed:

   What|Removed |Added

 CC||guibomac...@gmail.com

--- Comment #8 from Patrick Luby  ---
@nicholasakers: can you attach a crash log? Or does LibreOffice's "Document
Recovery" appear instead of the usual macOS crash dialog?

If you only see the "Document Recovery" dialog, can you attach a sample of
LibreOffice using the Activity Monitor application? Below are the steps to get
a sample of LibreOffice:

1. In the Finder, open the /Applications/Utilities/Activity Monitor application
2. In the Activity Monitor window that opens, double-click on the LibreOffice
entry
3. In the dialog that appears, click the Sample button
4. In the window that appears, click the Save button
5. Attach saved file to this bug

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'distro/collabora/co-24.04' - helpcontent2

2024-02-10 Thread Andras Timar (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit fbe0fe6ccc2a0d83695cde653f5f377f01d8dc9f
Author: Andras Timar 
AuthorDate: Sun Feb 11 00:20:06 2024 +0200
Commit: Gerrit Code Review 
CommitDate: Sat Feb 10 23:20:06 2024 +0100

Update git submodules

* Update helpcontent2 from branch 'distro/collabora/co-24.04'
  to e5d0bcb12bde1a726205c3e21338a625fba625a5
  - remove references to missing embeds

Change-Id: I9e98ae0a4b283cafc7d6066d399226e661da3aed

  - remove references to missing embeds

Change-Id: Icb87f444535516b6aa02db6fdd1f975f612afe99

  - added 2 missing HIDs (2nd attempt)

Change-Id: Ib8d7c4c2c6a25bb6d3f7df05ae5bc3469ad13126

  - added 2 missing HIDs

Change-Id: I9e06554c33fcdf97f6ce7a40d87b1448298e8250

  - add a bookmark to Calc's Page Style page - COOL looks for this

Change-Id: I74f42cc2e19761c380dde43c725d18ab482ef603

  - add a bookmark to Document Properties page - COOL looks for this

Change-Id: If62790ac10535fd560844c7a1931c7e2040ba3d5

  - add a bookmark to Accessibility Check page - COOL looks for this

Change-Id: I7a7ccb275f7865d9e0efca9dd0199ba0b0b345fc

  - [cp] Xapian Omega setup for help.collaboraoffice.com

Change-Id: Iaa28803be627db8915e7f426b400ac3b26e7b3a2

  - [cp] help page footer

Change-Id: I257d7dd85a896ff69e391a05206c1cb419997331

  - [cp] Hide 'Please support us!' button

Change-Id: I003b30b6b47e1323f4ef2a504ed72585561a386f

  - [cp] Revert the .xhp parts of "Deploy videos in New Help (WIP)"

Partially reverts commit 93ebf037016819613322ef1c39951a3de893ec14.

Change-Id: I21224f97e9c47d5dfeb8e000102237a5664d3d41

  - [cp] Exchange the logo.

Change-Id: I138d97fd40764ff455354f4ad53f9a7fb72faba8
Reviewed-on: https://gerrit.libreoffice.org/58797
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 

diff --git a/helpcontent2 b/helpcontent2
index d6423aa35068..e5d0bcb12bde 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit d6423aa350685e984ac30209a0269b02c1cc145a
+Subproject commit e5d0bcb12bde1a726205c3e21338a625fba625a5


help.git: Branch 'distro/collabora/co-24.04' - 12 commits - AllLangHelp_shared.mk help3xsl/default.css help3xsl/online_transform.xsl help3xsl/xap_templ_query.xsl Package_html_media.mk source/media sou

2024-02-10 Thread Andras Timar (via logerrit)
 AllLangHelp_shared.mk |1 
 Package_html_media.mk |3 
 help3xsl/default.css  |7 +-
 help3xsl/online_transform.xsl |   14 +---
 help3xsl/xap_templ_query.xsl  |2 
 source/media/navigation/collabora-online-logo.svg |   77 ++
 source/media/navigation/libo-symbol-black.svg |3 
 source/media/navigation/libo-symbol-white.svg |1 
 source/text/sbasic/shared/main0601.xhp|1 
 source/text/scalc/01/0507.xhp |1 
 source/text/scalc/main.xhp|1 
 source/text/schart/main.xhp   |1 
 source/text/sdatabase/main.xhp|1 
 source/text/sdraw/main.xhp|1 
 source/text/shared/01/0110.xhp|1 
 source/text/shared/01/05210200.xhp|2 
 source/text/shared/01/themescolordialog.xhp   |1 
 source/text/shared/01/themesdialog.xhp|3 
 source/text/shared/05/new_help.xhp|1 
 source/text/shared/06/youtubevideos.xhp   |   24 --
 source/text/simpress/main.xhp |1 
 source/text/smath/main.xhp|1 
 source/text/swriter/01/accessibility_check.xhp|1 
 source/text/swriter/01/pagenumbering.xhp  |4 -
 source/text/swriter/main.xhp  |1 
 25 files changed, 94 insertions(+), 60 deletions(-)

New commits:
commit e5d0bcb12bde1a726205c3e21338a625fba625a5
Author: Andras Timar 
AuthorDate: Sun Oct 8 21:55:51 2023 +0200
Commit: Andras Timar 
CommitDate: Sat Feb 10 21:01:33 2024 +0100

remove references to missing embeds

Change-Id: I9e98ae0a4b283cafc7d6066d399226e661da3aed

diff --git a/source/text/shared/01/themescolordialog.xhp 
b/source/text/shared/01/themescolordialog.xhp
index 569d33cf67..64fcac15d3 100644
--- a/source/text/shared/01/themescolordialog.xhp
+++ b/source/text/shared/01/themescolordialog.xhp
@@ -27,7 +27,6 @@
 Creates a color 
theme.
 
 
-
 Choose 
Format - Theme and click on 
Add.
 
 
diff --git a/source/text/shared/01/themesdialog.xhp 
b/source/text/shared/01/themesdialog.xhp
index c374955425..ebf18b4b91 100644
--- a/source/text/shared/01/themesdialog.xhp
+++ b/source/text/shared/01/themesdialog.xhp
@@ -27,10 +27,7 @@
 The bundling of 
color, font and format settings is possible under the concept of 
Theme.
 
 
-
 Choose 
Format - Themes.
-
-Open the 
Design panel.
 
 Theme 
colors is a set of twelve colors, each color has 5 variations computed 
internally, defined by their RGB-value and only the RGB-value is written to 
document file. A color of an object can be defined by a reference into a color 
of the Theme colors set. This reference is done by keyword or 
index, depending on the context. 
 
commit fd3ac75dccdf977d1d26952e546b3a530db7202f
Author: Andras Timar 
AuthorDate: Sun Oct 8 20:16:17 2023 +0200
Commit: Andras Timar 
CommitDate: Sat Feb 10 21:01:23 2024 +0100

remove references to missing embeds

Change-Id: Icb87f444535516b6aa02db6fdd1f975f612afe99

diff --git a/source/text/swriter/01/pagenumbering.xhp 
b/source/text/swriter/01/pagenumbering.xhp
index 5e54de2baf..ada78ec078 100644
--- a/source/text/swriter/01/pagenumbering.xhp
+++ b/source/text/swriter/01/pagenumbering.xhp
@@ -25,11 +25,7 @@
 Use this command to 
quickly insert a page number in the header or footer of the current page 
style.
 
 
-
 Choose 
Insert - Page Number.
-
-Choose 
Layout - Page Number.
-In the 
Insert menu of the Insert tab, choose 
Page Numbers.
 
 
 Position
commit 72d99d70b3fcae4d16df95f3c1910edb97762f92
Author: Andras Timar 
AuthorDate: Sun Nov 19 23:11:00 2023 +0100
Commit: Andras Timar 
CommitDate: Sat Feb 10 20:57:23 2024 +0100

added 2 missing HIDs (2nd attempt)

Change-Id: Ib8d7c4c2c6a25bb6d3f7df05ae5bc3469ad13126

diff --git a/source/text/shared/01/05210200.xhp 
b/source/text/shared/01/05210200.xhp
index 52424f1322..4b2adfb10f 100644
--- a/source/text/shared/01/05210200.xhp
+++ b/source/text/shared/01/05210200.xhp
@@ -30,8 +30,8 @@
 
 
 
-
-
+
+
 
 colors;palette
 palette;document colors
commit 85fc2f4d232ebd726462a3c4a9896d7b7ac2ca18
Author: Andras Timar 
AuthorDate: Sun Nov 19 22:23:34 2023 +0100
Commit: Andras Timar 
CommitDate: Sat Feb 10 20:57:22 2024 +0100

added 2 missing HIDs

Change-Id: I9e06554c33fcdf97f6ce7a40d87b1448298e8250

diff --git a/source/text/shared/01/05210200.xhp 
b/source/text/shared/01/05210200.xhp
index dafde66c1f..52424f1322 100644
--- a/source/text/shared/01/05210200.xhp
+++ b/source/text/shared/01/05210200.xhp
@@ -30,6 +30,8 @@
 
 
 
+
+
 
 colors;palette
 palette;document colors
commit ee386edd45a3b8f251cdd5cb18934b1efed2b35c
Author: 

[Bug 159677] New: Error when trying to save file from remote webdav

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159677

Bug ID: 159677
   Summary: Error when trying to save file from remote webdav
   Product: LibreOffice
   Version: 24.2.0.3 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: 8fezlt...@mozmail.com

Description:
I open a document through webdav in dolphin in a libreoffice app. The title bar
contains the [title] + [(remote)]. When I am trying to save it, it gives the
error messages: Error saving the document <>:
General Internet error has occurred.
However, when opening other file formats, e.g. text editors, etc, they can be
saved succesfully.

Full path is
/run/user/1000/kio-fuse-GTQCkY/webdav/127.0.0.1:4443/InpBgIZC/Cloud
Drive/

The webdav local connection is made through megacmd.

Steps to Reproduce:
1.Open libreoffice through dolphin in kde (webdav megasync)
2.try to save
3.error message

Actual Results:
error message, unsuccesful save

Expected Results:
no error message


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Version: 24.2.0.3 (X86_64) / LibreOffice Community
Build ID: 420(Build:3)
CPU threads: 12; OS: Linux 6.7; UI render: default; VCL: kf5 (cairo+wayland)
Locale: en-US (C.UTF-8); UI: en-US
24.2.0-1
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159610] Used "Frame Styles" Not Appearing in Styles Sidebar with "Applied Styles" Selected

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159610

--- Comment #3 from Jim Raykowski  ---
I think this is reproducible using any document that has a frame style applied.
Here is a patch that makes the applied frame styles appear:
https://gerrit.libreoffice.org/c/core/+/163220

Possibly https://gerrit.libreoffice.org/c/core/+/155504 caused a regression
here. I haven't checked if the Applied Styles filter ever did show applied
frame styes.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: sc/inc sc/qa sc/source

2024-02-10 Thread Caolán McNamara (via logerrit)
 sc/inc/fillinfo.hxx |2 +-
 sc/qa/unit/ucalc_condformat.cxx |2 +-
 sc/source/core/data/fillinfo.cxx|9 +++--
 sc/source/ui/app/inputhdl.cxx   |2 +-
 sc/source/ui/miscdlgs/datatableview.cxx |2 +-
 sc/source/ui/view/gridwin.cxx   |2 +-
 sc/source/ui/view/gridwin4.cxx  |4 ++--
 sc/source/ui/view/printfun.cxx  |6 +++---
 8 files changed, 17 insertions(+), 12 deletions(-)

New commits:
commit 17fc445938dedb05125a6d6a5b4ce7f34ea95f59
Author: Caolán McNamara 
AuthorDate: Thu Feb 1 12:47:53 2024 +
Commit: Caolán McNamara 
CommitDate: Sat Feb 10 22:08:38 2024 +0100

perf: limit to max 1024 rows in cases where we originally allocated 1024 
rows

so everywhere before:

commit a86c00414a43c5d87981ffae1018cb242c5e5e1d
Date:   Fri Jan 19 14:27:10 2024 +0200

cool#6893 reduce allocation in ScGridWindow::PaintTile

where ScTableInfo was used with no args, pass true to indicate this is
just a hint, and where it was originally passed an explicit number, pass
false for "hint"

When hint is true limit to max of 1024 rows, and the issue
is visible in ScGridWindow::UpdateFormulaRange at

https://github.com/CollaboraOnline/online/issues/6893#issuecomment-1921141048

CppunitTest_sc_uicalc contains some examples of these where hidden rows
triggers the over allocs

Change-Id: Iebe890c3ac967800b60150aaa71f7e845a021f60
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162875
Reviewed-by: Szymon Kłos 
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Noel Grandin 
Reviewed-by: Caolán McNamara 
(cherry picked from commit e4410bd37fc018c851b5ebf9cf011d59af6a2ad9)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163016
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163060
Tested-by: Jenkins

diff --git a/sc/inc/fillinfo.hxx b/sc/inc/fillinfo.hxx
index 8ed8ac63b98f..caecd6a7072b 100644
--- a/sc/inc/fillinfo.hxx
+++ b/sc/inc/fillinfo.hxx
@@ -268,7 +268,7 @@ struct ScTableInfo
 SCSIZE  mnArrCapacity;
 boolmbPageMode;
 
-explicitScTableInfo(SCROW nStartRow, SCROW nEndRow);
+explicitScTableInfo(SCROW nStartRow, SCROW nEndRow, bool 
bHintOnly);
 ~ScTableInfo();
 ScTableInfo(const ScTableInfo&) = delete;
 const ScTableInfo& operator=(const ScTableInfo&) = delete;
diff --git a/sc/qa/unit/ucalc_condformat.cxx b/sc/qa/unit/ucalc_condformat.cxx
index 3416e4a39dc8..c4dd685c41a8 100644
--- a/sc/qa/unit/ucalc_condformat.cxx
+++ b/sc/qa/unit/ucalc_condformat.cxx
@@ -366,7 +366,7 @@ CPPUNIT_TEST_FIXTURE(TestCondformat, 
testColorScaleInMergedCell)
 m_pDoc->DoMerge(0, 0, 0, 1, 0);  // A1:A2
 CPPUNIT_ASSERT(m_pDoc->IsMerged(ScAddress(0, 0, 0)));
 
-ScTableInfo aTabInfo(0, 2);
+ScTableInfo aTabInfo(0, 2, false);
 m_pDoc->FillInfo(aTabInfo, 0, 0, 0, 1, 0, 1, 1, false, false);
 RowInfo* pRowInfo = aTabInfo.mpRowInfo.get();
 
diff --git a/sc/source/core/data/fillinfo.cxx b/sc/source/core/data/fillinfo.cxx
index b33a30f5fea2..8ab35f34c079 100644
--- a/sc/source/core/data/fillinfo.cxx
+++ b/sc/source/core/data/fillinfo.cxx
@@ -1074,14 +1074,19 @@ void ScDocument::FillInfo(
 
 /// We seem to need to allocate three extra rows here, not sure why
 ///
-ScTableInfo::ScTableInfo(SCROW nStartRow, SCROW nEndRow)
+ScTableInfo::ScTableInfo(SCROW nStartRow, SCROW nEndRow, bool bHintOnly)
 : mnArrCount(0)
 , mnArrCapacity(nEndRow - nStartRow + 4)
 , mbPageMode(false)
 {
 assert(nStartRow >= 0);
 assert(nEndRow >= nStartRow);
-mpRowInfo.reset(new RowInfo[nEndRow - nStartRow + 4] {});
+if (bHintOnly && mnArrCapacity > 1024)
+{
+SAL_INFO("sc.core", "ScTableInfo excessive capacity: " << 
mnArrCapacity << " start: " << nStartRow << " end: " << nEndRow);
+mnArrCapacity = 1024;
+}
+mpRowInfo.reset(new RowInfo[mnArrCapacity] {});
 }
 
 ScTableInfo::~ScTableInfo()
diff --git a/sc/source/ui/app/inputhdl.cxx b/sc/source/ui/app/inputhdl.cxx
index ce397be3f6cd..745e69158d3b 100644
--- a/sc/source/ui/app/inputhdl.cxx
+++ b/sc/source/ui/app/inputhdl.cxx
@@ -523,7 +523,7 @@ ReferenceMark ScInputHandler::GetReferenceMark( const 
ScViewData& rViewData, ScD
 Fraction aZoomX = rViewData.GetZoomX();
 Fraction aZoomY = rViewData.GetZoomY();
 
-ScTableInfo aTabInfo(nY1, nY2);
+ScTableInfo aTabInfo(nY1, nY2, true);
 pDocSh->GetDocument().FillInfo( aTabInfo, nX1, nY1, nX2, nY2,
 nTab, nPPTX, nPPTY, false, false );
 
diff --git a/sc/source/ui/miscdlgs/datatableview.cxx 
b/sc/source/ui/miscdlgs/datatableview.cxx
index 2ad901f4b110..e6f7373e0491 100644
--- a/sc/source/ui/miscdlgs/datatableview.cxx
+++ b/sc/source/ui/miscdlgs/datatableview.cxx
@@ -257,7 +257,7 @@ void ScDataTableView::Paint(vcl::RenderContext& 

core.git: sc/source

2024-02-10 Thread Caolán McNamara (via logerrit)
 sc/source/core/data/column2.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 9599edeeea12cb62df53308f820316ee8682575c
Author: Caolán McNamara 
AuthorDate: Sat Feb 10 19:27:57 2024 +
Commit: Caolán McNamara 
CommitDate: Sat Feb 10 21:33:06 2024 +0100

cid#1559951 silence Use after free

Change-Id: I3b64a77bfc8b305d73166eaa14d96301fa1aad05
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163219
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sc/source/core/data/column2.cxx b/sc/source/core/data/column2.cxx
index e5d69434a761..20e365acb06c 100644
--- a/sc/source/core/data/column2.cxx
+++ b/sc/source/core/data/column2.cxx
@@ -831,9 +831,9 @@ sal_uInt16 ScColumn::GetOptimalColWidth(
 nScript = ScGlobal::GetDefaultScriptType();
 
 const ScPatternAttr* pPattern = GetPattern(nRow);
-aOptions.aPattern.setScPatternAttr(pPattern);
 aOptions.bGetFont = (!ScPatternAttr::areSame(pPattern, 
pOldPattern) || nScript != SvtScriptType::NONE);
-pOldPattern = pPattern;
+aOptions.aPattern.setScPatternAttr(pPattern);
+pOldPattern = aOptions.aPattern.getScPatternAttr();
 sal_uInt16 nThis = static_cast(GetNeededSize(
 nRow, pDev, nPPTX, nPPTY, rZoomX, rZoomY, true, 
aOptions, ));
 if (nThis && (nThis > nWidth || !bFound))


core.git: sc/source

2024-02-10 Thread Caolán McNamara (via logerrit)
 sc/source/core/data/column2.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 428ab490cb39c43c88bfc0e06450bfc91ffdcff6
Author: Caolán McNamara 
AuthorDate: Sat Feb 10 16:59:33 2024 +
Commit: Caolán McNamara 
CommitDate: Sat Feb 10 21:31:14 2024 +0100

cid#1591764 silence Double free

Change-Id: I21af2580f35d716ed32d565f07f84b4bbfdd2507
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163218
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sc/source/core/data/column2.cxx b/sc/source/core/data/column2.cxx
index 4d7ef70448ae..e5d69434a761 100644
--- a/sc/source/core/data/column2.cxx
+++ b/sc/source/core/data/column2.cxx
@@ -1072,7 +1072,7 @@ void ScColumn::GetOptimalHeight(
 if (rCxt.isForceAutoSize() || 
!(rDocument.GetRowFlags(nRow, nTab) & CRFlags::ManualSize) )
 {
 aOptions.aPattern.setScPatternAttr(pPattern);
-aOldPattern.setScPatternAttr(pPattern);
+
aOldPattern.setScPatternAttr(aOptions.aPattern.getScPatternAttr());
 sal_uInt16 nHeight = static_cast(
 std::min(
 GetNeededSize( nRow, 
rCxt.getOutputDevice(), rCxt.getPPTX(), rCxt.getPPTY(),


[Bug 159676] Formula will not show results & tried using "Data Sources" & it doesn't work

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159676

ady  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #1 from ady  ---
Open the specific Calc document. Go to menu View > Show Formula.

If that is not enough, save and close the document and in LibreOffice go to
menu Help > Restart in Safe Mode. Test what happens in Safe Mode with the same
file.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159676] New: Formula will not show results & tried using "Data Sources" & it doesn't work

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159676

Bug ID: 159676
   Summary: Formula will not show results & tried using "Data
Sources" & it doesn't work
   Product: LibreOffice
   Version: 4.2 all versions
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: leo...@verizon.net

Description:
Libra Office Calc:  The first problem  has to do with formulas are not showing
results they only show the formula.… To add more crazyness to this topic… Under
the “View” option there is a selection labeled “Data Sources” That used to
allow you to switch from viewing either the formula or the results. Now what is
does is pop up at the top of the page called “Bibliography” and making that
worse, it’s not obvious how to remove it… you need to go back and re-select
“Data Sources” I also tried deleting the Lebreoffice app and re-installing. Now
running version 24.2.0.3 … nothing got better. MAJOR BUGS IN THE CODE"
Somebody HELP!

Steps to Reproduce:
1.from a different cell Select copy from a cell with something in it. 
2.results in displaying the formula
3.found nothing to be able to view the result

Actual Results:
Displays the formula

Expected Results:
Nothing works


Reproducible: Always


User Profile Reset: No

Additional Info:
either display the result or allow selecting either the result or the formula.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: vcl/source

2024-02-10 Thread Caolán McNamara (via logerrit)
 vcl/source/window/printdlg.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit edab3a9fd243c238f840db84af31c39c3617eb8c
Author: Caolán McNamara 
AuthorDate: Sat Feb 10 16:48:43 2024 +
Commit: Caolán McNamara 
CommitDate: Sat Feb 10 20:19:46 2024 +0100

cid#1591787 silence Arguments in wrong order

Change-Id: Iee6dba0a127a126bc47dcb5c98efa86274d79340
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163216
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/source/window/printdlg.cxx b/vcl/source/window/printdlg.cxx
index 66cadb91d18a..5b80ca57fa69 100644
--- a/vcl/source/window/printdlg.cxx
+++ b/vcl/source/window/printdlg.cxx
@@ -1033,6 +1033,7 @@ void PrintDialog::updatePageSize(int nOrientation)
 if ((nOrientation == ORIENTATION_PORTRAIT && aSize.Width() > 
aSize.Height())
 || (nOrientation == ORIENTATION_LANDSCAPE && aSize.Width() < 
aSize.Height()))
 {
+// coverity[swapped_arguments : FALSE] - this is in the intended 
order
 aSize = Size(aSize.Height(), aSize.Width());
 }
 }


[Bug 159529] Excessive memory consumption in v24.2

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159529

Telesto  changed:

   What|Removed |Added

   Priority|medium  |high
   Severity|normal  |major

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159529] Excessive memory consumption in v24.2

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159529

--- Comment #2 from Telesto  ---
Easy way to reproduce 
1. Open attachment https://bz.apache.org/ooo/attachment.cgi?id=12592
2. Edit -> Track Changes -> Manage -> Keep Pressing the reject button

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158312] Perhaps changing the orientation in Page Layout does not work conveniently for Calc

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158312

--- Comment #14 from Vladislav Tarakanov  ---
(In reply to Amin Irgaliev from comment #11)
> This feature was added (https://gerrit.libreoffice.org/c/core/+/162845). 
> 
> Since the
> functionality for changing orientation is now added to LO, perhaps it makes
> sense to also add a change in the displayed range of cells when changing the
> page format? So that in the print dialog, when changing, for example, A4 to
> A3, the range of cells also changes to A3 size.

It also looks like page resizing behavior, such as A4 -> A3, has already been
implemented as well. We apologize for not noticing this.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158312] Perhaps changing the orientation in Page Layout does not work conveniently for Calc

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158312

--- Comment #14 from Vladislav Tarakanov  ---
(In reply to Amin Irgaliev from comment #11)
> This feature was added (https://gerrit.libreoffice.org/c/core/+/162845). 
> 
> Since the
> functionality for changing orientation is now added to LO, perhaps it makes
> sense to also add a change in the displayed range of cells when changing the
> page format? So that in the print dialog, when changing, for example, A4 to
> A3, the range of cells also changes to A3 size.

It also looks like page resizing behavior, such as A4 -> A3, has already been
implemented as well. We apologize for not noticing this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158312] Perhaps changing the orientation in Page Layout does not work conveniently for Calc

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158312

--- Comment #13 from Vladislav Tarakanov  ---
(In reply to ady from comment #12)
> FWIW, ATM there is no explanation in tdf#155218 of what exactly was
> done/changed; I mean, in terms that could be understood by common users.
> 
> For example, the change _might_ mean that:
> * page styles are not modified by modifications in the Print dialogue (or
> related Print actions or Views in Calc).
> * Changes to the Print dialogue might override Page Styles settings for that
> specific Printing action allowing to print according to Print settings, but
> (as mentioned in the previous point) the Page Styles remain as they were
> previously defined, not changed.
> 
> I can think of _many_ variations on that made-up example, including up to
> the complete opposite case. And I don't discard RFE (or "bug reports"
> depending on users' expectations) at all. Please do not misunderstand this
> comment as an opposition to the change.
> 
> The point of this comment is that, whatever the patch changes, it has to be
> more clear for common users (and clearly explained and announced when the
> times come to 24.8.0).

Since we created almost the same patch locally, we can describe its effect for
users:

Users often encounter some misunderstanding about changing the layout
orientation in the print dialog specifically in tracing tables. This may be due
to habits from MSO where the orientation was changed right before printing and
a lack of skill in applying styles. In other modules, this problem is not so
noticeable, since pagination is immediately visible, but in tracing paper it is
not visible without enabling the desired setting or without turning preview on
and off. Based on this, it was made so that changing the layout orientation
also changed the orientation of the pages in Calc, immediately before printing.

The change in tdf#155218 does not change the styles, keeping them original.
However, now, after additional tests, one small side effect of the proposed
implementation is noticeable: after changing the page orientation and closing
the print dialog in Calc, you can still see incorrect print boundaries in some
cases, despite the fact that the original orientation is preserved in the
styles. But we’ll probably move the discussion of this bug into the report with
the patch, attaching a video.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158312] Perhaps changing the orientation in Page Layout does not work conveniently for Calc

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158312

--- Comment #13 from Vladislav Tarakanov  ---
(In reply to ady from comment #12)
> FWIW, ATM there is no explanation in tdf#155218 of what exactly was
> done/changed; I mean, in terms that could be understood by common users.
> 
> For example, the change _might_ mean that:
> * page styles are not modified by modifications in the Print dialogue (or
> related Print actions or Views in Calc).
> * Changes to the Print dialogue might override Page Styles settings for that
> specific Printing action allowing to print according to Print settings, but
> (as mentioned in the previous point) the Page Styles remain as they were
> previously defined, not changed.
> 
> I can think of _many_ variations on that made-up example, including up to
> the complete opposite case. And I don't discard RFE (or "bug reports"
> depending on users' expectations) at all. Please do not misunderstand this
> comment as an opposition to the change.
> 
> The point of this comment is that, whatever the patch changes, it has to be
> more clear for common users (and clearly explained and announced when the
> times come to 24.8.0).

Since we created almost the same patch locally, we can describe its effect for
users:

Users often encounter some misunderstanding about changing the layout
orientation in the print dialog specifically in tracing tables. This may be due
to habits from MSO where the orientation was changed right before printing and
a lack of skill in applying styles. In other modules, this problem is not so
noticeable, since pagination is immediately visible, but in tracing paper it is
not visible without enabling the desired setting or without turning preview on
and off. Based on this, it was made so that changing the layout orientation
also changed the orientation of the pages in Calc, immediately before printing.

The change in tdf#155218 does not change the styles, keeping them original.
However, now, after additional tests, one small side effect of the proposed
implementation is noticeable: after changing the page orientation and closing
the print dialog in Calc, you can still see incorrect print boundaries in some
cases, despite the fact that the original orientation is preserved in the
styles. But we’ll probably move the discussion of this bug into the report with
the patch, attaching a video.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 133092] [META] Crash bugs

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133092
Bug 133092 depends on bug 133942, which changed state.

Bug 133942 Summary: Crash ucrtbase!abort+0x4b: after Reject All tracked changes
https://bugs.documentfoundation.org/show_bug.cgi?id=133942

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 133942] Crash ucrtbase!abort+0x4b: after Reject All tracked changes

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133942

Telesto  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #13 from Telesto  ---
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: ba8f4bff6015013013df652efbfaf4d9ae10c881
CPU threads: 8; OS: macOS 14.3; UI render: Skia/Raster; VCL: osx
Locale: nl-NL (nl_NL.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 83946] [META] Tracking changes issues

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=83946
Bug 83946 depends on bug 133942, which changed state.

Bug 133942 Summary: Crash ucrtbase!abort+0x4b: after Reject All tracked changes
https://bugs.documentfoundation.org/show_bug.cgi?id=133942

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 105948] [META] Undo/Redo bugs and enhancements

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105948
Bug 105948 depends on bug 133942, which changed state.

Bug 133942 Summary: Crash ucrtbase!abort+0x4b: after Reject All tracked changes
https://bugs.documentfoundation.org/show_bug.cgi?id=133942

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 125934] No application icon on Wayland with the qt5 / kf5 backend

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125934

--- Comment #30 from Michael Weghorn  ---
(In reply to Gauthier from comment #28)
> Seems like there have been some update on this and apparently it is now
> doable since Qt 5.15.
> 
> https://bugreports.qt.io/browse/QTBUG-77182

[1] in there describes how Qt API can be used to make newly created windows use
a different icon than the first one, but IIUC that doesn't cover the LO use
case of changing the icon of an *existing* window.

Quoting also from the corresponding GTK issue (
https://gitlab.gnome.org/GNOME/gtk/-/issues/767 ):

"LibreOffice recycles toplevel windows, e.g. writer to start center to calc."

[1]
https://bugreports.qt.io/browse/QTBUG-77182?focusedId=728535=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-728535

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158069] Scroll through font selection listbox using arrow keys and preview change on document canvas

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158069

--- Comment #18 from Bob English  ---
The "This software dos/doesn't do it" is not valid argument to do or not do
something, as the reason for it is more important:  Did they even give it any
thought, is it just too hard to do, is it on a to do list, or is there a bad
reason for it or something?

Why not just see the logical reasoning behind my suggestion; The Convenience of
a live preview to better select a suitable font.  Other than a few added mouse
clicks or keystrokes, which may not even be needed, I cannot see any reason why
it could ever be a bad thing in an app that is able to make great looking and
functional documents.

I think it would be a great thing to implement it, and have LO do something
good M$ Office doesn't for a change, make it a first if no one else does, and
with it add to the reasons someone may choose LO over M$ office.  Something
tells me that if you do implement it you will get way more thanks and praise
for it, and very little flack, which if the latter will most likely be based on
bad reasoning.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 149763] Lots of Spaces get suppressed, when a Paragraph mark is added after this Sample

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149763

--- Comment #14 from Adalbert Hanßen  ---
I tested my example from the bug report with 

Version: 24.2.0.3 (X86_64) / LibreOffice Community
Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1
CPU threads: 4; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Calc: threaded

and the bug did not show up again. During my test, both options dealing with
spaces and tabs had checkmarks set for both columns were set, i.e. a total of
four checkmarks. But the indentation of the lines before the page break did not
change despite of this and Telesto's Comment 2.

I repeated the same test with the four checkmarks being removed: same result.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159577] Smallest size of Properties window exceeds vertical length of small displays

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159577

joey.joey...@gmail.com changed:

   What|Removed |Added

 Attachment #192412|0   |1
is obsolete||

--- Comment #4 from joey.joey...@gmail.com ---
Created attachment 192500
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192500=edit
Screenshots showing the differences in Properties window between 7.6 and 24.2

I think I found the problem. LibreOffice 24.2 introduced extra fields in File >
Properties > Description and I think that's the reason why the window is stuck
on a larger size.

A solution would be to add a scrollbar in order to make the window size more
flexible.

Can someone please confirm?

(In case anyone asks, the window sizes shown in the screenshots are the
smallest they can be resized to.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'distro/collabora/co-24.04' - vcl/jsdialog

2024-02-10 Thread Hubert Figuière (via logerrit)
 vcl/jsdialog/enabled.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 5fccf088d19af7af42e99780a9ae8eb780800a2c
Author: Hubert Figuière 
AuthorDate: Fri Feb 9 14:56:49 2024 -0500
Commit: Michael Meeks 
CommitDate: Sat Feb 10 18:28:54 2024 +0100

vcl: Enable sheet protection dialog

Change-Id: Ib8e8209225d027472c1f2eef57839df5784acf30
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163205
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Michael Meeks 
(cherry picked from commit 5c1c842863ee2a63ce69a75ef0820864864905f0)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163175
Tested-by: Michael Meeks 

diff --git a/vcl/jsdialog/enabled.cxx b/vcl/jsdialog/enabled.cxx
index d792128f3360..beb12b5dd081 100644
--- a/vcl/jsdialog/enabled.cxx
+++ b/vcl/jsdialog/enabled.cxx
@@ -128,6 +128,7 @@ bool isBuilderEnabled(std::u16string_view rUIFile, bool 
bMobile)
 || rUIFile == u"modules/scalc/ui/pastespecial.ui"
 || rUIFile == u"modules/scalc/ui/pivotfielddialog.ui"
 || rUIFile == u"modules/scalc/ui/pivottablelayoutdialog.ui"
+|| rUIFile == u"modules/scalc/ui/protectsheetdlg.ui"
 || rUIFile == u"modules/scalc/ui/regressiondialog.ui"
 || rUIFile == u"modules/scalc/ui/rowheightdialog.ui"
 || rUIFile == u"modules/scalc/ui/samplingdialog.ui"


[Bug 159675] FORMATTING - Text in column disappears when modified

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159675

--- Comment #2 from ludovic.cre...@gmail.com ---
Created attachment 192499
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192499=edit
Screenshot with wrong display

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 51510] FILESAVE: Exporting documents with embedded SVG (e.g. QR code) to doc or docx converts the image to low-resolution pixel graphics

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=51510

--- Comment #54 from Buovjaga  ---
(In reply to Piotr Osada from comment #53)
> Created attachment 192498 [details]
> Flag of Saint Pierre and Miquelon
> 
> Also OK.

Please, it is not necessary to attach every flag picture present in digiKam.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 51510] FILESAVE: Exporting documents with embedded SVG (e.g. QR code) to doc or docx converts the image to low-resolution pixel graphics

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=51510

--- Comment #53 from Piotr Osada  ---
Created attachment 192498
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192498=edit
Flag of Saint Pierre and Miquelon

Also OK.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159675] FORMATTING - Text in column disappears when modified

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159675

--- Comment #1 from ludovic.cre...@gmail.com ---
Created attachment 192497
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192497=edit
Screenshot before problem occurs

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 51510] FILESAVE: Exporting documents with embedded SVG (e.g. QR code) to doc or docx converts the image to low-resolution pixel graphics

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=51510

--- Comment #52 from Piotr Osada  ---
Created attachment 192496
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192496=edit
Flag of Afghanistan

This file is also OK.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 51510] FILESAVE: Exporting documents with embedded SVG (e.g. QR code) to doc or docx converts the image to low-resolution pixel graphics

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=51510

--- Comment #51 from Buovjaga  ---
(In reply to Piotr Osada from comment #49)
> (In reply to Buovjaga from comment #45)
> > Reason for revert: This can cause compatibility issues with OOXML
> 
> Confirm that: in .DOC files, SVG graphics are not saved by LO.

That's unrelated. DOCX is OOXML while .DOC is the legacy binary format. 

The implementation was done in bug 126084.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159675] New: FORMATTING - Text in column disappears when modified

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159675

Bug ID: 159675
   Summary: FORMATTING - Text in column disappears when modified
   Product: LibreOffice
   Version: 7.2.4.1 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ludovic.cre...@gmail.com

Description:
In a document with columns within columns, when I modify some texts, it
disappears and is replaced with a red triangle.

Steps to Reproduce:
1. Create a document with subdivided columns;
2. Fill them with text;
3. Add or remove a character.

Actual Results:
The whole sub-column is replaced by a small red triangle (pointing right), and
the next parts are messed up.

Expected Results:
Add or remove text, pushing to the next column if needed.


Reproducible: Sometimes


User Profile Reset: No

Additional Info:
Between screenshots 1 and 2, I just deleted the blank line above « Dons ».

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 144038] LO BASE numeric properties converted to locale format inside macro

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144038

--- Comment #3 from Richard Demattio  ---
Version: 7.6.4.1 (X86_64) / LibreOffice Community
Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1
CPU threads: 4; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: de-AT (en_US.UTF-8); UI: en-US
Calc: threaded


continues to be reproducable

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 51510] FILESAVE: Exporting documents with embedded SVG (e.g. QR code) to doc or docx converts the image to low-resolution pixel graphics

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=51510

--- Comment #50 from Piotr Osada  ---
Created attachment 192495
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192495=edit
Flag of Poland

You can find these files in digiKam instalation directory on Windows:

...
C:\Program Files\digiKam\data\flags\flag_pl.svg
...

This file shows no errors in web browsers.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 137566] FIREBIRD: some errors during - create Table and insert records via menue "tools/SQL"

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137566

--- Comment #8 from Richard Demattio  ---
Version: 7.6.4.1 (X86_64) / LibreOffice Community
Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1
CPU threads: 4; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: de-AT (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 51510] FILESAVE: Exporting documents with embedded SVG (e.g. QR code) to doc or docx converts the image to low-resolution pixel graphics

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=51510

--- Comment #49 from Piotr Osada  ---
Created attachment 192493
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192493=edit
Flag of Oman

(In reply to Roland Baudin from comment #48)
> OK, I tested the new LibreOffice 24.2 and the bug is indeed fixed. SVG

Version: 24.2.0.3 (X86_64) / LibreOffice Community
Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1
CPU threads: 4; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: pl-PL (pl_PL); UI: en-US
Calc: threaded

Yes, it works now. It's a great milestone in DOCX: LO <--> MSO
interoperability.  For me, it enables producing more professional documents
with vector graphics instead of the so far solution with PNG.

Thank you very much for this work, and I wish you the best. Shalom!

(In reply to Buovjaga from comment #45)
> Reason for revert: This can cause compatibility issues with OOXML

Confirm that: in .DOC files, SVG graphics are not saved by LO.

For some reason/in some cases, LO superior to MSO. For example, the attached
country flag (of Oman) is rendered by LibreOffice (in .odt and .docx) while by
Microsoft Word not.

Firefox doesn't render this file, and Chrome shows an error:

"""This page contains the following errors:
error on line 3 at column 94: Namespace prefix sodipodi on namedview is not
defined"""

So, maybe it's worth displaying some announcement, potentially displayed onto
of the graphic or in the information bar under the toolbar? This would lead to
an even higher level of convenience for professional users when using LO
software.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 51780] [META] Default to Firebird not HSQLDB in Base (for _new_ files)

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=51780
Bug 51780 depends on bug 137566, which changed state.

Bug 137566 Summary: FIREBIRD: some errors during - create Table and insert 
records via menue "tools/SQL"
https://bugs.documentfoundation.org/show_bug.cgi?id=137566

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 137566] FIREBIRD: some errors during - create Table and insert records via menue "tools/SQL"

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137566

Richard Demattio  changed:

   What|Removed |Added

Version|7.0.2.2 release |7.6.4.1 release
 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #7 from Richard Demattio  ---
about the Error on "create table AND insert record in one transaction"
I guess, the table must exist first (committed) and inserting a record makes
sense only afterwards.
~
inserting two or more records via "execute block" is an acceptable workaround
to avoid error when "inserting two records".
~
so:it works for me

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 141776] Shown mnemonic/accelerators in Start Center require + key on Windows

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141776

--- Comment #19 from Mike Kaganski  ---
So now, after tdf#54169 got fixed, there's no mnemonic shown in the start
center on Windows, until you press [Alt]. As said, my take on this is WF.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 141776] Shown mnemonic/accelerators in Start Center require + key on Windows

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141776

--- Comment #19 from Mike Kaganski  ---
So now, after tdf#54169 got fixed, there's no mnemonic shown in the start
center on Windows, until you press [Alt]. As said, my take on this is WF.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158312] Perhaps changing the orientation in Page Layout does not work conveniently for Calc

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158312

--- Comment #12 from ady  ---
FWIW, ATM there is no explanation in tdf#155218 of what exactly was
done/changed; I mean, in terms that could be understood by common users.

For example, the change _might_ mean that:
* page styles are not modified by modifications in the Print dialogue (or
related Print actions or Views in Calc).
* Changes to the Print dialogue might override Page Styles settings for that
specific Printing action allowing to print according to Print settings, but (as
mentioned in the previous point) the Page Styles remain as they were previously
defined, not changed.

I can think of _many_ variations on that made-up example, including up to the
complete opposite case. And I don't discard RFE (or "bug reports" depending on
users' expectations) at all. Please do not misunderstand this comment as an
opposition to the change.

The point of this comment is that, whatever the patch changes, it has to be
more clear for common users (and clearly explained and announced when the times
come to 24.8.0).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158312] Perhaps changing the orientation in Page Layout does not work conveniently for Calc

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158312

--- Comment #12 from ady  ---
FWIW, ATM there is no explanation in tdf#155218 of what exactly was
done/changed; I mean, in terms that could be understood by common users.

For example, the change _might_ mean that:
* page styles are not modified by modifications in the Print dialogue (or
related Print actions or Views in Calc).
* Changes to the Print dialogue might override Page Styles settings for that
specific Printing action allowing to print according to Print settings, but (as
mentioned in the previous point) the Page Styles remain as they were previously
defined, not changed.

I can think of _many_ variations on that made-up example, including up to the
complete opposite case. And I don't discard RFE (or "bug reports" depending on
users' expectations) at all. Please do not misunderstand this comment as an
opposition to the change.

The point of this comment is that, whatever the patch changes, it has to be
more clear for common users (and clearly explained and announced when the times
come to 24.8.0).

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 103303] [META] Desktop integration bugs and enhancements

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103303
Bug 103303 depends on bug 54169, which changed state.

Bug 54169 Summary: LibO doesn’t obey Windows OS setting “only show the 
accelerator underline when the Alt key is being pressed”
https://bugs.documentfoundation.org/show_bug.cgi?id=54169

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: vcl/inc vcl/source vcl/win

2024-02-10 Thread Mike Kaganski (via logerrit)
 vcl/inc/impdel.hxx   |6 
 vcl/source/window/window.cxx |4 ++
 vcl/win/window/salframe.cxx  |   59 ++-
 3 files changed, 46 insertions(+), 23 deletions(-)

New commits:
commit a2dd71feb75d93adf0f0daac899e7476f961ec34
Author: Mike Kaganski 
AuthorDate: Sat Feb 10 20:01:05 2024 +0600
Commit: Mike Kaganski 
CommitDate: Sat Feb 10 16:58:11 2024 +0100

tdf#54169: implement auto-accelerator feature on Windows

Change-Id: I219dfc0c8377628c10e5a19232d19260923bf614
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163215
Tested-by: Mike Kaganski 
Reviewed-by: Mike Kaganski 

diff --git a/vcl/inc/impdel.hxx b/vcl/inc/impdel.hxx
index b387c34a0974..3b9dbb60a45e 100644
--- a/vcl/inc/impdel.hxx
+++ b/vcl/inc/impdel.hxx
@@ -57,6 +57,12 @@ class DeletionListener
if( m_pNotifier )
m_pNotifier->addDel( this );
}
+DeletionListener(const DeletionListener& rOther)
+:  m_pNotifier(rOther.m_pNotifier)
+   {
+   if (m_pNotifier)
+   m_pNotifier->addDel(this);
+   }
~DeletionListener()
{
if( m_pNotifier )
diff --git a/vcl/source/window/window.cxx b/vcl/source/window/window.cxx
index 85454316acdf..ec3adaca4674 100644
--- a/vcl/source/window/window.cxx
+++ b/vcl/source/window/window.cxx
@@ -1808,15 +1808,17 @@ void Window::SimulateKeyPress( sal_uInt16 nKeyCode ) 
const
 
 void Window::KeyInput( const KeyEvent& rKEvt )
 {
+#ifndef _WIN32 // On Windows, dialogs react to accelerators  without Alt 
(tdf#157649)
 KeyCode cod = rKEvt.GetKeyCode ();
-bool autoacc = ImplGetSVData()->maNWFData.mbAutoAccel;
 
 // do not respond to accelerators unless Alt or Ctrl is held
 if (cod.GetCode () >= 0x200 && cod.GetCode () <= 0x219)
 {
+bool autoacc = ImplGetSVData()->maNWFData.mbAutoAccel;
 if (autoacc && cod.GetModifier () != KEY_MOD2 && !(cod.GetModifier() & 
KEY_MOD1))
 return;
 }
+#endif
 
 NotifyEvent aNEvt( NotifyEventType::KEYINPUT, this,  );
 if ( !CompatNotify( aNEvt ) )
diff --git a/vcl/win/window/salframe.cxx b/vcl/win/window/salframe.cxx
index ed8f7fddee7a..313ae0ffcf2d 100644
--- a/vcl/win/window/salframe.cxx
+++ b/vcl/win/window/salframe.cxx
@@ -301,6 +301,15 @@ static void UpdateDarkMode(HWND hWnd)
 DwmSetWindowAttribute(hWnd, 20, , sizeof(bDarkMode));
 }
 
+static void UpdateAutoAccel()
+{
+BOOL bUnderline = FALSE;
+SystemParametersInfoW(SPI_GETKEYBOARDCUES, 0, , 0);
+
+ImplSVData* pSVData = ImplGetSVData();
+pSVData->maNWFData.mbAutoAccel = !bUnderline;
+}
+
 SalFrame* ImplSalCreateFrame( WinSalInstance* pInst,
   HWND hWndParent, SalFrameStyleFlags 
nSalFrameStyle )
 {
@@ -3578,7 +3587,7 @@ static bool HandleAltNumPadCode(HWND hWnd, UINT nMsg, 
WPARAM wParam, LPARAM lPar
 if (!(keyFlags & KF_REPEAT))
 state.clear();
 state.started = true;
-return true;
+return false; // This must be processed further - e.g., to 
show accelerators
 }
 
 if (!state.started)
@@ -3637,8 +3646,6 @@ static bool ImplHandleKeyMsg( HWND hWnd, UINT nMsg,
 static WPARAM   nDeadChar   = 0;
 static WPARAM   nLastVKChar = 0;
 static sal_uInt16   nLastChar   = 0;
-static ModKeyFlags  nLastModKeyCode = ModKeyFlags::NONE;
-static bool bWaitForModKeyRelease = false;
 sal_uInt16  nRepeat = LOWORD( lParam );
 if (nRepeat)
 --nRepeat;
@@ -3774,14 +3781,11 @@ static bool ImplHandleKeyMsg( HWND hWnd, UINT nMsg,
 // MCD, 2003-01-13, Support for WM_UNICHAR & Keyman 6.0; addition ends
 else
 {
+static ModKeyFlags nLastModKeyCode = ModKeyFlags::NONE;
+
 // for shift, control and menu we issue a KeyModChange event
 if ( (wParam == VK_SHIFT) || (wParam == VK_CONTROL) || (wParam == 
VK_MENU) )
 {
-SalKeyModEvent aModEvt;
-aModEvt.mbDown = false; // auto-accelerator feature not supported 
here.
-aModEvt.mnCode = nModCode;
-aModEvt.mnModKeyCode = ModKeyFlags::NONE;   // no command events 
will be sent if this member is 0
-
 ModKeyFlags tmpCode = ModKeyFlags::NONE;
 if( GetKeyState( VK_LSHIFT )  & 0x8000 )
 tmpCode |= ModKeyFlags::LeftShift;
@@ -3796,22 +3800,16 @@ static bool ImplHandleKeyMsg( HWND hWnd, UINT nMsg,
 if( GetKeyState( VK_RMENU )  & 0x8000 )
 tmpCode |= ModKeyFlags::RightMod2;
 
-if( tmpCode < nLastModKeyCode )
+if (tmpCode != nLastModKeyCode)
 {
-aModEvt.mnModKeyCode = nLastModKeyCode;
-nLastModKeyCode = ModKeyFlags::NONE;
-bWaitForModKeyRelease = true;
+SalKeyModEvent aModEvt;
+aModEvt.mbDown = nMsg == WM_KEYDOWN || nMsg 

[Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=98259
Bug 98259 depends on bug 54169, which changed state.

Bug 54169 Summary: LibO doesn’t obey Windows OS setting “only show the 
accelerator underline when the Alt key is being pressed”
https://bugs.documentfoundation.org/show_bug.cgi?id=54169

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: 3 commits - include/vcl vcl/inc vcl/source vcl/win

2024-02-10 Thread Mike Kaganski (via logerrit)
 include/vcl/menu.hxx |2 +
 vcl/inc/win/saldata.hxx  |1 
 vcl/inc/win/wincomp.hxx  |9 --
 vcl/source/window/menu.cxx   |   41 ++-
 vcl/source/window/menubarwindow.cxx  |   29 +
 vcl/source/window/menubarwindow.hxx  |6 
 vcl/source/window/menufloatingwindow.cxx |   15 +++
 vcl/source/window/syswin.cxx |   13 -
 vcl/win/app/saldata.cxx  |   25 --
 vcl/win/window/salframe.cxx  |   34 ++---
 10 files changed, 110 insertions(+), 65 deletions(-)

New commits:
commit f2dfb95258215f90562617823b950c3ed151c1bf
Author: Mike Kaganski 
AuthorDate: Sat Feb 10 18:49:55 2024 +0600
Commit: Mike Kaganski 
CommitDate: Sat Feb 10 16:58:03 2024 +0100

tdf#54169: revert "gtk is the only case auto-accel is true, and the

... menubar is native gtk there" (commit 
3fbae5dc7e7b200776bbc8a7c2a43e1e04f15a2b
from 2021-08-05).
This will be needed for auto-accel on Windows.

Change-Id: Ie37de17e35658a0f7c748d3c9dd923dba954298c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163214
Tested-by: Mike Kaganski 
Reviewed-by: Mike Kaganski 

diff --git a/include/vcl/menu.hxx b/include/vcl/menu.hxx
index a28182e51fe2..9629a5fef39d 100644
--- a/include/vcl/menu.hxx
+++ b/include/vcl/menu.hxx
@@ -45,6 +45,7 @@ class MenuItemList;
 class Image;
 class PopupMenu;
 class KeyEvent;
+class CommandEvent;
 class MenuFloatingWindow;
 class SalMenu;
 class MenuBarWindow;
@@ -427,6 +428,7 @@ class VCL_DLLPUBLIC MenuBar final : public Menu
 SAL_DLLPRIVATE static VclPtr ImplCreate(vcl::Window* pParent, 
vcl::Window* pWindow, MenuBar* pMenu);
 SAL_DLLPRIVATE static void ImplDestroy(MenuBar* pMenu, bool bDelete);
 SAL_DLLPRIVATE bool ImplHandleKeyEvent(const KeyEvent& rKEvent);
+SAL_DLLPRIVATE bool ImplHandleCmdEvent(const CommandEvent& rCEvent);
 
 /// Return the MenuBarWindow.
 MenuBarWindow* getMenuBarWindow();
diff --git a/vcl/source/window/menu.cxx b/vcl/source/window/menu.cxx
index 387d74b0d1b3..b72f2f8c8091 100644
--- a/vcl/source/window/menu.cxx
+++ b/vcl/source/window/menu.cxx
@@ -1948,7 +1948,13 @@ void Menu::ImplPaint(vcl::RenderContext& rRenderContext, 
Size const & rSize,
 aTmpPos.setX( aPos.X() + nTextPos );
 aTmpPos.setY( aPos.Y() );
 aTmpPos.AdjustY(nTextOffsetY );
-DrawTextFlags nStyle = nTextStyle | 
DrawTextFlags::Mnemonic;
+DrawTextFlags nStyle = nTextStyle;
+
+const Menu *pMenu = this;
+while (!pMenu->IsMenuBar() && pMenu->pStartedFrom)
+pMenu = pMenu->pStartedFrom;
+if (!pMenu->IsMenuBar() || 
!static_cast(pMenu->pWindow.get())->GetMBWHideAccel())
+nStyle |= DrawTextFlags::Mnemonic;
 
 if (pData->bIsTemporary)
 nStyle |= DrawTextFlags::Disable;
@@ -2546,6 +2552,32 @@ bool MenuBar::ImplHandleKeyEvent( const KeyEvent& 
rKEvent )
 return bDone;
 }
 
+bool MenuBar::ImplHandleCmdEvent( const CommandEvent& rCEvent )
+{
+// No keyboard processing when system handles the menu or our menubar is 
invisible
+if( !IsDisplayable() ||
+( ImplGetSalMenu() && ImplGetSalMenu()->VisibleMenuBar() ) )
+return false;
+
+// check for enabled, if this method is called from another window...
+MenuBarWindow* pWin = static_cast(ImplGetWindow());
+if ( pWin && pWin->IsEnabled() && pWin->IsInputEnabled()  && ! 
pWin->IsInModalMode() )
+{
+if (rCEvent.GetCommand() == CommandEventId::ModKeyChange && 
ImplGetSVData()->maNWFData.mbAutoAccel)
+{
+const CommandModKeyData* pCData = rCEvent.GetModKeyData ();
+if (pWin->m_nHighlightedItem == ITEMPOS_INVALID)
+{
+if (pCData && pCData->IsMod2() && pCData->IsDown())
+pWin->SetMBWHideAccel(false);
+pWin->Invalidate(InvalidateFlags::Update);
+}
+return true;
+}
+}
+return false;
+}
+
 void MenuBar::SelectItem(sal_uInt16 nId)
 {
 if (!pWindow)
@@ -2829,6 +2861,13 @@ bool PopupMenu::PrepareRun(const VclPtr& 
pParentWin, tools::Rectang
 if (!pSFrom && (vcl::IsInPopupMenuExecute() || !nItemCount))
 return false;
 
+// set the flag to hide or show accelerators in the menu depending on 
whether the menu was launched by mouse or keyboard shortcut
+if( pSFrom && pSFrom->IsMenuBar())
+{
+auto pMenuBarWindow = 
static_cast(pSFrom->pWindow.get());
+pMenuBarWindow->SetMBWHideAccel( !(pMenuBarWindow->GetMBWMenuKey()) );
+}
+
 mpLayoutData.reset();
 
 ImplSVData* pSVData = ImplGetSVData();
diff --git a/vcl/source/window/menubarwindow.cxx 

[Bug 54169] LibO doesn’t obey Windows OS setting “only show the accelerator underline when the Alt key is being pressed”

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=54169

Mike Kaganski  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com
   |desktop.org |
   Keywords|difficultyInteresting,  |
   |easyHack, skillCpp, topicUI |
 Status|NEW |ASSIGNED

--- Comment #60 from Mike Kaganski  ---
Since it was marked an easyhack, things had changed; some functional required
to implement this was removed, and now that needed to be reverted. I take this.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159673] Selection of fonts, their efficiency, and compatibility with the Arabic language.

2024-02-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159673

V Stuart Foote  changed:

   What|Removed |Added

 OS|Linux (All) |All

-- 
You are receiving this mail because:
You are the assignee for the bug.

  1   2   >