[Bug 159709] Assignment of Shortcuts for Find messed up in the German version

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159709

--- Comment #4 from Rainer Bielefeld Retired  
---
Well, it IS unreleated to user profile, I tested (only 
"find, find  replace" with Version from #2 and brand new user profile.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: editeng/source

2024-02-13 Thread Andrea Gelmini (via logerrit)
 editeng/source/editeng/impedit3.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit fb35c64d5b7bb3c6763d09af613d9c79c657f7a9
Author: Andrea Gelmini 
AuthorDate: Tue Feb 13 18:40:43 2024 +0100
Commit: Julien Nabet 
CommitDate: Wed Feb 14 08:39:46 2024 +0100

Fix typo

Change-Id: I95fb4b60d5afa9b309c477896a6234c12d20ba92
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163318
Tested-by: Julien Nabet 
Reviewed-by: Julien Nabet 

diff --git a/editeng/source/editeng/impedit3.cxx 
b/editeng/source/editeng/impedit3.cxx
index 9892dfaa783f..51c922ce0b3f 100644
--- a/editeng/source/editeng/impedit3.cxx
+++ b/editeng/source/editeng/impedit3.cxx
@@ -725,7 +725,7 @@ bool ImpEditEngine::CreateLines( sal_Int32 nPara, 
sal_uInt32 nStartPosY )
 
 bool bQuickFormat = false;
 
-// Determine if quick formt should be used
+// Determine if quick format should be used
 if (!bEmptyNodeWithPolygon && !HasScriptType(nPara, 
i18n::ScriptType::COMPLEX))
 {
 if (rParaPortion.IsSimpleInvalid() &&


core.git: dbaccess/source

2024-02-13 Thread Andrea Gelmini (via logerrit)
 dbaccess/source/ui/dlg/dbadmin.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 12d91b562d3932c3b13a2954f63acab655dc02aa
Author: Andrea Gelmini 
AuthorDate: Tue Feb 13 18:42:59 2024 +0100
Commit: Julien Nabet 
CommitDate: Wed Feb 14 08:39:20 2024 +0100

Fix typo

Change-Id: I67e2769f3b60ef48a785d5eefc3dbad64b04b2eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163322
Tested-by: Julien Nabet 
Reviewed-by: Julien Nabet 

diff --git a/dbaccess/source/ui/dlg/dbadmin.cxx 
b/dbaccess/source/ui/dlg/dbadmin.cxx
index ee503f575e95..67cf6298f247 100644
--- a/dbaccess/source/ui/dlg/dbadmin.cxx
+++ b/dbaccess/source/ui/dlg/dbadmin.cxx
@@ -275,7 +275,7 @@ static ItemInfoPackage& getItemInfoPackageAdminDlg()
 { DSID_ORIGINALNAME, new SfxStringItem(DSID_ORIGINALNAME, 
OUString()), 0, SFX_ITEMINFOFLAG_NONE },
 { DSID_CONNECTURL, new SfxStringItem(DSID_CONNECTURL, OUString()), 
0, SFX_ITEMINFOFLAG_NONE },
 
-// gets added in costructor below once for LO runtime as static 
default
+// gets added in constructor below once for LO runtime as static 
default
 { DSID_TABLEFILTER, nullptr, 0, SFX_ITEMINFOFLAG_NONE },
 
 // gets added by callback for each new Pool as dynamic default


core.git: vcl/win

2024-02-13 Thread Andrea Gelmini (via logerrit)
 vcl/win/window/salframe.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit da3a624cfa19d0beaf83c64ddf16ef23f15808d9
Author: Andrea Gelmini 
AuthorDate: Tue Feb 13 18:50:25 2024 +0100
Commit: Julien Nabet 
CommitDate: Wed Feb 14 08:39:00 2024 +0100

Fix typo

Change-Id: Id0763e1bef326155afca27cea62258120323a44e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163323
Tested-by: Julien Nabet 
Reviewed-by: Julien Nabet 

diff --git a/vcl/win/window/salframe.cxx b/vcl/win/window/salframe.cxx
index 797b5a80fc14..81dcf341e60d 100644
--- a/vcl/win/window/salframe.cxx
+++ b/vcl/win/window/salframe.cxx
@@ -1959,7 +1959,7 @@ static bool EnableAttachThreadInputHack()
 bEnabled = s == "true";
 } else {
 // For backwards compatibility, for now also try to read the value 
from a [Win32] section of
-// bootstrap.ini if it is not set as a boostrap variable:
+// bootstrap.ini if it is not set as a bootstrap variable:
 bEnabled = false;
 OUString aBootstrapUri;
 if (osl_getProcessWorkingDir() == 
osl_Process_E_None) {


core.git: sw/source

2024-02-13 Thread Andrea Gelmini (via logerrit)
 sw/source/core/bastyp/init.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 37559bb3a19a3dd55eab6b7d5cbf346f4e683932
Author: Andrea Gelmini 
AuthorDate: Tue Feb 13 18:42:06 2024 +0100
Commit: Julien Nabet 
CommitDate: Wed Feb 14 08:38:37 2024 +0100

Fix typo

Change-Id: I8e02264f0edb300b7dec6db4b772fba13ae71c6e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163321
Tested-by: Julien Nabet 
Reviewed-by: Julien Nabet 

diff --git a/sw/source/core/bastyp/init.cxx b/sw/source/core/bastyp/init.cxx
index 050554301b80..35efce864431 100644
--- a/sw/source/core/bastyp/init.cxx
+++ b/sw/source/core/bastyp/init.cxx
@@ -361,7 +361,7 @@ ItemInfoPackage& getItemInfoPackageSwAttributes()
 { RES_PARATR_TABSTOP, new SvxTabStopItem( 1, SVX_TAB_DEFDIST, 
SvxTabAdjust::Default, RES_PARATR_TABSTOP ), SID_ATTR_TABSTOP, 
SFX_ITEMINFOFLAG_SUPPORT_SURROGATE  },
 
 // for this at the Item GetMaxHyphens() = 0 was called, do this 
now on-demand at construction time
-// it will get added in costructor below once for LO runtime as 
static default
+// it will get added in constructor below once for LO runtime as 
static default
 { RES_PARATR_HYPHENZONE, nullptr, SID_ATTR_PARA_HYPHENZONE, 
SFX_ITEMINFOFLAG_NONE  },
 
 { RES_PARATR_DROP, new SwFormatDrop, FN_FORMAT_DROPCAPS, 
SFX_ITEMINFOFLAG_NONE  },


core.git: sw/source

2024-02-13 Thread Andrea Gelmini (via logerrit)
 sw/source/core/bastyp/init.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit dd294936fd50abea99540e69091c120ba0e2ef64
Author: Andrea Gelmini 
AuthorDate: Tue Feb 13 18:41:27 2024 +0100
Commit: Julien Nabet 
CommitDate: Wed Feb 14 08:38:11 2024 +0100

Fix typo

Change-Id: Iacd32b9b7556e706b8bfdcce1738ec3925366020
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163319
Tested-by: Julien Nabet 
Reviewed-by: Julien Nabet 

diff --git a/sw/source/core/bastyp/init.cxx b/sw/source/core/bastyp/init.cxx
index 177b11433cd8..050554301b80 100644
--- a/sw/source/core/bastyp/init.cxx
+++ b/sw/source/core/bastyp/init.cxx
@@ -337,7 +337,7 @@ ItemInfoPackage& getItemInfoPackageSwAttributes()
 { RES_TXTATR_AUTOFMT, new SwFormatAutoFormat,  0, 
SFX_ITEMINFOFLAG_NONE },
 
 // We cannot yet create the SwFormatINetFormat, that would crash 
since SW_MOD
-// is not initialized and the translated ressource strings would 
not be available.
+// is not initialized and the translated resource strings would 
not be available.
 // Luckily this mechanism allows to also flag this ItemInfo as 
'incomplete' using
 // a nullptr as ItemPtr and implementing on-demand creation, see 
::getItemInfo
 { RES_TXTATR_INETFMT, nullptr,  FN_TXTATR_INET, 
SFX_ITEMINFOFLAG_SUPPORT_SURROGATE },


[Bug 159714] keep aspect ratio of pasted picture

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159714

--- Comment #2 from lvm  ---
Created attachment 192555
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192555=edit
screenshot 3

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159714] keep aspect ratio of pasted picture

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159714

lvm  changed:

   What|Removed |Added

 CC||lmiro...@yandex.ru

--- Comment #1 from lvm  ---
Created attachment 192554
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192554=edit
screenshot 2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159714] New: keep aspect ratio of pasted picture

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159714

Bug ID: 159714
   Summary: keep aspect ratio of pasted picture
   Product: LibreOffice
   Version: 24.2.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: lmiro...@yandex.ru

Created attachment 192553
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192553=edit
screenshot 1

When picture is pasted into a write document in place of existing picture its
aspect ratio changes to fit that of the original picture. While such behaviour
may be sometimes desirable, in general distorting a picture is not a good idea.
I'd like to be able to retain the aspect ratio of the pasted picture while
keeping other formatting options of the selected picture at least as an option,
probably as the default behaviour.

Consider the following scenario: 
1. create two objects in LibreOffice Draw - oblong rectangle and a circle
(screenshot 1)
2. copy the rectangle to the clipboard and paste into Write
3. copy the circle to the clipboard
4. click on the rectangle in Write to select it (screenshot 2)
5. paste the circle - an ellipse is pasted instead of a circle (screenshot 3)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 143781] [META] Development- and code-related bug reports and tasks

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143781
Bug 143781 depends on bug 141908, which changed state.

Bug 141908 Summary: CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 141908] CppUnittests: replace usage of sal_Int32 with colors

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141908

Buovjaga  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #46 from Buovjaga  ---
This is more or less done now, so let's close. Thanks to all involved :)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 141908] CppUnittests: replace usage of sal_Int32 with colors

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141908

--- Comment #45 from Commit Notification 
 ---
Ilmari Lauhakangas committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9798f383f82897b0021665f50f3a9f8153febbe8

tdf#141908 replace usage of sal_Int32 with colors in xmloff

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: xmloff/qa

2024-02-13 Thread Ilmari Lauhakangas (via logerrit)
 xmloff/qa/unit/style.cxx |   12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 9798f383f82897b0021665f50f3a9f8153febbe8
Author: Ilmari Lauhakangas 
AuthorDate: Tue Feb 13 14:41:13 2024 +0200
Commit: Ilmari Lauhakangas 
CommitDate: Wed Feb 14 08:22:29 2024 +0100

tdf#141908 replace usage of sal_Int32 with colors in xmloff

Change-Id: Ia2661fa0f6864d6553e5cca7469e1d351bb06d17
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163305
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 

diff --git a/xmloff/qa/unit/style.cxx b/xmloff/qa/unit/style.cxx
index 178b0f216154..3bf1391d842a 100644
--- a/xmloff/qa/unit/style.cxx
+++ b/xmloff/qa/unit/style.cxx
@@ -371,8 +371,8 @@ CPPUNIT_TEST_FIXTURE(XmloffStyleTest, testMCGR_OldToNew)
 CPPUNIT_ASSERT_EQUAL(u"red2yellow"_ustr, sGradientName);
 awt::Gradient2 aGradient;
 xShapeProperties->getPropertyValue("FillGradient") >>= aGradient;
-CPPUNIT_ASSERT_EQUAL(sal_Int32(0xFF), aGradient.StartColor);
-CPPUNIT_ASSERT_EQUAL(sal_Int32(0x00), aGradient.EndColor);
+CPPUNIT_ASSERT_EQUAL(COL_LIGHTRED, Color(ColorTransparency, 
aGradient.StartColor));
+CPPUNIT_ASSERT_EQUAL(COL_YELLOW, Color(ColorTransparency, 
aGradient.EndColor));
 
 // Test new properties
 auto aColorStopSeq = aGradient.ColorStops;
@@ -427,8 +427,8 @@ CPPUNIT_TEST_FIXTURE(XmloffStyleTest, 
testMCGR_OldToNew_opacity)
 // The old properties need to be still available, as they might be used in 
macros.
 awt::Gradient2 aGradient;
 xShapeProperties->getPropertyValue("FillTransparenceGradient") >>= 
aGradient;
-CPPUNIT_ASSERT_EQUAL(sal_Int32(0xE5E5E5), aGradient.StartColor);
-CPPUNIT_ASSERT_EQUAL(sal_Int32(0), aGradient.EndColor);
+CPPUNIT_ASSERT_EQUAL(Color(0xE5E5E5), Color(ColorTransparency, 
aGradient.StartColor));
+CPPUNIT_ASSERT_EQUAL(COL_BLACK, Color(ColorTransparency, 
aGradient.EndColor));
 CPPUNIT_ASSERT_EQUAL(sal_Int16(20), aGradient.Border);
 CPPUNIT_ASSERT_EQUAL(sal_Int16(50), aGradient.XOffset);
 CPPUNIT_ASSERT_EQUAL(sal_Int16(50), aGradient.YOffset);
@@ -493,8 +493,8 @@ CPPUNIT_TEST_FIXTURE(XmloffStyleTest, testMCGR_threeStops)
 CPPUNIT_ASSERT_EQUAL(u"threeStops"_ustr, sGradientName);
 awt::Gradient2 aGradient;
 xShapeProperties->getPropertyValue("FillGradient") >>= aGradient;
-CPPUNIT_ASSERT_EQUAL(sal_Int32(0xFF), aGradient.StartColor);
-CPPUNIT_ASSERT_EQUAL(sal_Int32(0x00), aGradient.EndColor);
+CPPUNIT_ASSERT_EQUAL(COL_LIGHTRED, Color(ColorTransparency, 
aGradient.StartColor));
+CPPUNIT_ASSERT_EQUAL(COL_YELLOW, Color(ColorTransparency, 
aGradient.EndColor));
 CPPUNIT_ASSERT_EQUAL(awt::GradientStyle_SQUARE, aGradient.Style);
 CPPUNIT_ASSERT_EQUAL(sal_Int16(0), aGradient.XOffset);
 CPPUNIT_ASSERT_EQUAL(sal_Int16(50), aGradient.YOffset);


[Bug 133092] [META] Crash bugs

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133092
Bug 133092 depends on bug 96489, which changed state.

Bug 96489 Summary: Writer crashes some times, if you edit own Templates and 
bigger documents.
https://bugs.documentfoundation.org/show_bug.cgi?id=96489

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 96489] Writer crashes some times, if you edit own Templates and bigger documents.

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=96489

Buovjaga  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #7 from Buovjaga  ---
No longer crashes with the steps from comment 0

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: dfcdef6d94993131b5f150d00d08cc81a987eebb
CPU threads: 2; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: chart2/source

2024-02-13 Thread Kurt Nordback (via logerrit)
 chart2/source/view/charttypes/PieChart.cxx |  286 -
 chart2/source/view/charttypes/PieChart.hxx |   14 +
 2 files changed, 173 insertions(+), 127 deletions(-)

New commits:
commit d81c98623b2abb991ca696b3b09011f6bb3de673
Author: Kurt Nordback 
AuthorDate: Fri Sep 1 16:13:15 2023 -0600
Commit: Noel Grandin 
CommitDate: Wed Feb 14 07:58:41 2024 +0100

tdf#50934: Restructuring for of-pie charts

Change-Id: I9682c314efb888d57e94f82f084cc6d0825a4408
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160723
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/chart2/source/view/charttypes/PieChart.cxx 
b/chart2/source/view/charttypes/PieChart.cxx
index 0f924de7c5ab..49cf48de3f05 100644
--- a/chart2/source/view/charttypes/PieChart.cxx
+++ b/chart2/source/view/charttypes/PieChart.cxx
@@ -790,13 +790,6 @@ void PieChart::createShapes()
 ///the angle axis scale range is [0, 1]. The max_offset parameter is used
 ///for exploded pie chart and its value is 0.5.
 
-///the `explodeable` ring is the first one except when the radius axis
-///orientation is reversed (always!?) and we are dealing with a donut: in
-///such a case the `explodeable` ring is the last one.
-std::vector< VDataSeriesGroup >::size_type nExplodeableSlot = 0;
-if( m_aPosHelper.isMathematicalOrientationRadius() && m_bUseRings )
-nExplodeableSlot = m_aZSlots.front().size()-1;
-
 m_aLabelInfoList.clear();
 m_fMaxOffset = std::numeric_limits::quiet_NaN();
 sal_Int32 n3DRelativeHeight = 100;
@@ -815,8 +808,6 @@ void PieChart::createShapes()
 ///(m_bUseRings||fSlotX<0.5)
 for( double fSlotX=0; aXSlotIter != aXSlotEnd && (m_bUseRings||fSlotX<0.5 
); ++aXSlotIter, fSlotX+=1.0 )
 {
-ShapeParam aParam;
-
 std::vector< std::unique_ptr >* pSeriesList = 
&(aXSlotIter->m_aSeriesVector);
 if(pSeriesList->empty())//there should be only one series in each x 
slot
 continue;
@@ -824,8 +815,6 @@ void PieChart::createShapes()
 if(!pSeries)
 continue;
 
-bool bHasFillColorMapping = pSeries->hasPropertyMapping("FillColor");
-
 /// The angle degree offset is set by the same property of the
 /// data series.
 /// Counter-clockwise offset from the 3 o'clock position.
@@ -835,6 +824,8 @@ void PieChart::createShapes()
 ///the current data series
 sal_Int32 nPointIndex=0;
 sal_Int32 nPointCount=pSeries->getTotalPointCount();
+ShapeParam aParam;
+
 for( nPointIndex = 0; nPointIndex < nPointCount; nPointIndex++ )
 {
 double fY = pSeries->getYValue( nPointIndex );
@@ -851,134 +842,175 @@ void PieChart::createShapes()
 // Total sum of all Y values in this series is zero. Skip the 
whole series.
 continue;
 
-double fLogicYForNextPoint = 0.0;
-///iterate through all points to create shapes
-for( nPointIndex = 0; nPointIndex < nPointCount; nPointIndex++ )
-{
-double fLogicInnerRadius, fLogicOuterRadius;
-
-///compute the maximum relative distance offset of the current 
slice
-///from the pie center
-///it is worth noting that after the first invocation the maximum
-///offset value is cached, so it is evaluated only once per each
-///call to `createShapes`
-double fOffset = getMaxOffset();
-
-///compute the outer and the inner radius for the current ring 
slice
-bool bIsVisible = m_aPosHelper.getInnerAndOuterRadius( fSlotX+1.0, 
fLogicInnerRadius, fLogicOuterRadius, m_bUseRings, fOffset );
-if( !bIsVisible )
-continue;
+switch (m_eSubType) {
+case PieChartSubType_NONE:
+createOneRing(SubPieType::NONE, fSlotX, aParam, xSeriesTarget, 
xTextTarget, pSeries, n3DRelativeHeight);
+break;
+case PieChartSubType_BAR:
+createOneRing(SubPieType::LEFT, fSlotX, aParam, xSeriesTarget, 
xTextTarget, pSeries, n3DRelativeHeight);
+break;
+case PieChartSubType_PIE:
+createOneRing(SubPieType::LEFT, fSlotX, aParam, xSeriesTarget, 
xTextTarget, pSeries, n3DRelativeHeight);
+break;
+default:
+assert(false); // this shouldn't happen
+}
+}//next x slot
+}
 
-aParam.mfDepth  = getTransformedDepth() * (n3DRelativeHeight / 
100.0);
+void PieChart::createOneRing([[maybe_unused]]enum SubPieType eType,
+double fSlotX,
+ShapeParam& aParam,
+const rtl::Reference& xSeriesTarget,
+const rtl::Reference& xTextTarget,
+VDataSeries* pSeries,
+sal_Int32 n3DRelativeHeight)
+{
+bool bHasFillColorMapping = pSeries->hasPropertyMapping("FillColor");
 
-rtl::Reference xSeriesGroupShape_Shapes = 
getSeriesGroupShape(pSeries, xSeriesTarget);
-

core.git: include/comphelper

2024-02-13 Thread Attila Szűcs (via logerrit)
 include/comphelper/oslfile2streamwrap.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0f4002378d7cbf20ed5f33cbdc4e3c8e01e0338d
Author: Attila Szűcs 
AuthorDate: Wed Feb 14 03:54:05 2024 +0100
Commit: Noel Grandin 
CommitDate: Wed Feb 14 07:57:24 2024 +0100

fix windows UNLESS_MERGELIBS

it was needed to fix a linker error in my system

Change-Id: I5eeebf0db569289aace32f61535ae2ba7148de48
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163327
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/include/comphelper/oslfile2streamwrap.hxx 
b/include/comphelper/oslfile2streamwrap.hxx
index 79bd808af452..84122624c8f7 100644
--- a/include/comphelper/oslfile2streamwrap.hxx
+++ b/include/comphelper/oslfile2streamwrap.hxx
@@ -58,7 +58,7 @@ private:
 class OSLOutputStreamWrapper final : public 
::cppu::WeakImplHelper
 {
 public:
-UNLESS_MERGELIBS(COMPHELPER_DLLPUBLIC) OSLOutputStreamWrapper(::osl::File& 
_rFile);
+COMPHELPER_DLLPUBLIC OSLOutputStreamWrapper(::osl::File& _rFile);
 
 private:
 virtual ~OSLOutputStreamWrapper() override;


core.git: fpicker/source

2024-02-13 Thread Noel Grandin (via logerrit)
 fpicker/source/aqua/FilterHelper.hxx |8 
 fpicker/source/aqua/FilterHelper.mm  |   14 +++---
 2 files changed, 11 insertions(+), 11 deletions(-)

New commits:
commit 5e70dd023525e69e49851ff8d44287ccf5e56f95
Author: Noel Grandin 
AuthorDate: Tue Feb 13 19:21:00 2024 +0200
Commit: Noel Grandin 
CommitDate: Wed Feb 14 07:51:41 2024 +0100

fix --enable-mergelibs=more on macos

fix duplicate symbols

Change-Id: I6ec0b07026db6df6b76228a6bedb95c610e7ea07
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163316
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/fpicker/source/aqua/FilterHelper.hxx 
b/fpicker/source/aqua/FilterHelper.hxx
index 21cb9c4b4464..56463126c945 100644
--- a/fpicker/source/aqua/FilterHelper.hxx
+++ b/fpicker/source/aqua/FilterHelper.hxx
@@ -39,7 +39,7 @@ typedef css::uno::Sequence< UnoFilterEntry >   UnoFilterList; 
 // can be transpo
 typedef ::std::list NSStringList;
 typedef ::std::list OUStringList;
 
-struct FilterEntry
+struct AquaFilterEntry
 {
 protected:
 OUStringm_sTitle;
@@ -47,13 +47,13 @@ protected:
 UnoFilterList   m_aSubFilters;
 
 public:
-FilterEntry( const OUString& _rTitle, const OUStringList _rFilter )
+AquaFilterEntry( const OUString& _rTitle, const OUStringList _rFilter )
 : m_sTitle( _rTitle )
 , m_sFilterSuffixList( _rFilter )
 {
 }
 
-FilterEntry( const OUString& _rTitle, const UnoFilterList& _rSubFilters );
+AquaFilterEntry( const OUString& _rTitle, const UnoFilterList& 
_rSubFilters );
 
 OUString const & getTitle() const { return m_sTitle; }
 OUStringList const & getFilterSuffixList() const { return 
m_sFilterSuffixList; }
@@ -72,7 +72,7 @@ public:
 const UnoFilterEntry*   endSubFilters() const { return 
m_aSubFilters.getConstArray() + m_aSubFilters.getLength(); }
 };
 
-typedef ::std::vector < FilterEntry >   FilterList;
+typedef ::std::vector < AquaFilterEntry >   FilterList;
 
 class FilterHelper {
 
diff --git a/fpicker/source/aqua/FilterHelper.mm 
b/fpicker/source/aqua/FilterHelper.mm
index f11d8447d91a..98c27b720728 100644
--- a/fpicker/source/aqua/FilterHelper.mm
+++ b/fpicker/source/aqua/FilterHelper.mm
@@ -48,14 +48,14 @@ void fillSuffixList(OUStringList& aSuffixList, 
std::u16string_view suffixString)
 
 #pragma mark FilterEntry
 
-FilterEntry::FilterEntry( const OUString& _rTitle, const UnoFilterList& 
_rSubFilters )
+AquaFilterEntry::AquaFilterEntry( const OUString& _rTitle, const 
UnoFilterList& _rSubFilters )
 :m_sTitle( _rTitle )
 ,m_aSubFilters( _rSubFilters )
 {
 }
 
 
-bool FilterEntry::hasSubFilters() const
+bool AquaFilterEntry::hasSubFilters() const
 {
 bool bReturn = ( 0 < m_aSubFilters.getLength() );
 
@@ -63,7 +63,7 @@ bool FilterEntry::hasSubFilters() const
 }
 
 
-sal_Int32 FilterEntry::getSubFilters( UnoFilterList& _rSubFilterList )
+sal_Int32 AquaFilterEntry::getSubFilters( UnoFilterList& _rSubFilterList )
 {
 _rSubFilterList = m_aSubFilters;
 sal_Int32 nReturn = m_aSubFilters.getLength();
@@ -135,7 +135,7 @@ public:
 FilterTitleMatch( const OUString& _rTitle ) : rTitle( _rTitle ) { }
 
 
-bool operator () ( const FilterEntry& _rEntry )
+bool operator () ( const AquaFilterEntry& _rEntry )
 {
 bool bMatch;
 if( !_rEntry.hasSubFilters() ) {
@@ -274,7 +274,7 @@ void FilterHelper::appendFilter(const OUString& aTitle, 
std::u16string_view aFil
 // append the filter
 OUStringList suffixList;
 fillSuffixList(suffixList, aFilterString);
-m_pFilterList->push_back(FilterEntry( aTitle, suffixList ) );
+m_pFilterList->push_back(AquaFilterEntry( aTitle, suffixList ) );
 }
 
 void FilterHelper::setCurrentFilter( const OUString& aTitle )
@@ -305,7 +305,7 @@ void FilterHelper::appendFilterGroup( const 
css::uno::Sequence< css::beans::Stri
 // append the filter
 if (bPrependSeparator) {
 OUStringList emptyList;
-m_pFilterList->push_back(FilterEntry("-", emptyList));
+m_pFilterList->push_back(AquaFilterEntry("-", emptyList));
 }
 
 const css::beans::StringPair* pSubFilters   = aFilters.getConstArray();
@@ -391,7 +391,7 @@ void FilterHelper::SetFilterAtIndex(unsigned index)
 if (m_pFilterList->size() <= index) {
 index = 0;
 }
-FilterEntry entry = m_pFilterList->at(index);
+AquaFilterEntry entry = m_pFilterList->at(index);
 SetCurFilter(entry.getTitle());
 }
 


[Bug 159708] High CPU usage UI ribbon/menu

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159708

--- Comment #1 from breadsath...@gmail.com ---
UX Team -- please take a look at this enhancement. Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159708] High CPU usage UI ribbon/menu

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159708

--- Comment #1 from breadsath...@gmail.com ---
UX Team -- please take a look at this enhancement. Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 159708] High CPU usage UI ribbon/menu

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159708

breadsath...@gmail.com changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||breadsath...@gmail.com,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org
 Status|UNCONFIRMED |NEW

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 159708] High CPU usage UI ribbon/menu

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159708

breadsath...@gmail.com changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||breadsath...@gmail.com,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org
 Status|UNCONFIRMED |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 113388] Support for Client Side Decoration CSD of appframe in LibreOffice

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113388

--- Comment #30 from haevalen...@gmail.com ---
(In reply to `{third: "Beedell", first: "Roke"}`{.JSON5} from comment #29)
> (In reply to Heiko Tietze from comment #28)
> > (In reply to V Stuart Foote from comment #27)
> > > If it is to be done, needs to be well thought out and the cost in dev 
> > > effort
> > > really examined.
> > UX advice: Make it optional
> 
> However, heiko.tie...@documentfoundation.org, that's obviously the problem —
> it's a damn lot of code complexity for such little benefit, if any at all,
> which much of the user base (especially outside specifically GNOME) wouldn't
> ever use.

A small comment here: Why do you define it as if it were a Linux issue?
Titlebars are generally no longer used in the most used operating systems such
as Windows and macOS. Microsoft Office or OnlyOffice among others no longer use
titlebar.

I understand that this is a huge effort and I agree that it is more important
to polish functionalities or interoperability with the OOXML format, however, I
think that if the titlebars disappeared and that were the default option, most
users I wouldn't touch the settings to go back.

The use of vertical space and aesthetics are things considered by the end user.
I remember similar discussions that resisted the existence of a ribbon-like
interface or that the first thing the user saw was the dialog that allows them
to change the interface (I think it now appears as the first tip of the day,
although I haven't restarted my profile in a long time). The end user values
consistency and modern look when using an application unfortunately.

Well, my point is that this is not something that only benefits GNOME users.

Cheers

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159355] don't italicize numbered lists

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159355

--- Comment #2 from David Melik  ---
I don't alpha-test.  It still happens to me on v24.2.0.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159463] Changing which list style a paragraph style is associated with does not affect existing lists

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159463

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159464] Short text in sections combined with long endnotes makes parts of text hidden under red arrow

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159464

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159211] Test failure 24.2.0.1 final only on s390x: testTdf157635::TestBody

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159211

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159456] FILEOPEN XLSX Y axis labels have different values if data table is enabled

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159456

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159454] FILEOPEN XLSX Empty line in data series name is rendered in data table

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159454

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159449] FILEOPEN XLSX Data table text is not vertically centered

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159449

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159445] FILEOPEN XLSX Data table second line of text has different formatting

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159445

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159411] Sluggish display of letters when entering text when using LO Writer

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159411

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159370] Form based on sections freezes where change the section

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159370

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 156335] Word -> Writer

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156335

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 36549] [META] ACCESSIBILITY: Tracking bug for issues affecting a11y ATK and GNOME Orca screen reader support

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=36549
Bug 36549 depends on bug 102046, which changed state.

Bug 102046 Summary: Split and group buttons not exposed correctly on Linux
https://bugs.documentfoundation.org/show_bug.cgi?id=102046

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 156335] Word -> Writer

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156335

--- Comment #3 from QA Administrators  ---
Dear Michael,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 102046] Split and group buttons not exposed correctly on Linux

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=102046

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 102046] Split and group buttons not exposed correctly on Linux

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=102046

--- Comment #10 from QA Administrators  ---
Dear Yousuf Philips (jay) (retired),

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 134785] FILEOPEN PPTX: text box and line not shown in presentation mode

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134785

--- Comment #10 from QA Administrators  ---
Dear Gerald Pfeifer,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: starmath/source

2024-02-13 Thread Mike Kaganski (via logerrit)
 starmath/source/unomodel.cxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit b6ef30d1b049977beb23d28a07d77012fa1daf47
Author: Mike Kaganski 
AuthorDate: Tue Feb 13 18:55:15 2024 +0100
Commit: Mike Kaganski 
CommitDate: Wed Feb 14 04:07:21 2024 +0100

tdf#159302: Another UNO property "BaseLine" needs to use mm/100s

Change-Id: I6688577a41590624f1e1f08112f1308e810a7e37
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/16
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/starmath/source/unomodel.cxx b/starmath/source/unomodel.cxx
index 8a9207a2244b..805c6566e7f3 100644
--- a/starmath/source/unomodel.cxx
+++ b/starmath/source/unomodel.cxx
@@ -918,7 +918,9 @@ void SmModel::_getPropertyValues( const PropertyMapEntry 
**ppEntries, Any *pValu
 {
 pDocSh->ArrangeFormula();
 
-*pValue <<= static_cast( 
pDocSh->GetFormulaTree()->GetFormulaBaseline() );
+*pValue <<= static_cast(
+
o3tl::convert(pDocSh->GetFormulaTree()->GetFormulaBaseline(),
+  SmO3tlLengthUnit(), 
o3tl::Length::mm100));
 }
 break;
 }


[Bug 39750] [META] General Math formula editor improvements

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=39750
Bug 39750 depends on bug 159302, which changed state.

Bug 159302 Summary: Formula OLE in a line of text or its full height frame is 
now misaligned vertically, due to change of sm map units
https://bugs.documentfoundation.org/show_bug.cgi?id=159302

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 132455] REF error after undo sheet deletion. Hard recalculate doens't fix it

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132455

--- Comment #8 from Tex2002ans  ---
Testing in Excel 365 (2401, Build 17231.20194), it just gave a warning:

> "Microsoft Excel will permanently delete this sheet. Do you want to continue?"

After deleting the sheet, pressing Ctrl+Z to undo did nothing, and Sheet2's
formula was stuck as:

- =#REF!A1

- - -

So, if this is too complicated to toss onto the undo stack, perhaps a warning
could work too.

"Hey! You have formulas pointing to this sheet. Are you SURE you want to
Delete?"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 132455] REF error after undo sheet deletion. Hard recalculate doens't fix it

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132455

--- Comment #7 from Tex2002ans  ---
Created attachment 192552
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192552=edit
Sheet2 with text from Sheet1

0. Open attached ODS file.

All it is:

Sheet1: A1: "TextfromSheet1"
Sheet2: A1: "Here is:"
Sheet2: B1: =$Sheet1.A1

- - -

1. Delete Sheet1.
2. Edit > Undo (Ctrl+Z)
3. Go back to Sheet2.

- - -

In Sheet2, Cell B1...

For values, you'll see:

Step 0: "TextfromSheet1"
Step 1: #REF!
Step 2: #REF!

For formulas, you'll see:

Step 0: =$Sheet1.A1
Step 1: =$#REF!.A1
Step 2: =$#REF!.A1

After Step 2, there is no amount of Undos you can do to return to the original
state.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 132455] REF error after undo sheet deletion. Hard recalculate doens't fix it

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132455

Tex2002ans  changed:

   What|Removed |Added

 CC||Tex2002ans+LibreOffice@gmai
   ||l.com

--- Comment #6 from Tex2002ans  ---
I confirm, still an issue in:

Version: 24.2.0.3 (X86_64) / LibreOffice Community
Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1
CPU threads: 8; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

Followed comment 0 exactly.

- - - - -

For example, in "Comparisons" sheet... Cell F2:

On load:

- =$FiltrageVent.$O2

After Step 2:

- =#REF!.$O2

and Step 3 (undoing the sheet delete), it still stays stuck as:

- =#REF!.$O2

Once they turn into #REF (at least on sheet deletion), seems like they never go
back.

- - -

And like Xisco wrote in comment 1:

- Probably would be a good idea to get a better minimal example too. :)

I'll attach a very simple one.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 63259] It should be possible to use shift + F3 case change (cycle case), when cursor is at the beginning or end of a word and not only in the middle

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=63259

--- Comment #17 from Commit Notification 
 ---
Oliver Specht committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/125fc2ce861c82592b261f2992c893b414396e56

tdf#63259 rotate case also at start/end of a word

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 63259] It should be possible to use shift + F3 case change (cycle case), when cursor is at the beginning or end of a word and not only in the middle

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=63259

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:24.8.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: sw/source

2024-02-13 Thread Oliver Specht (via logerrit)
 sw/source/uibase/shells/textsh.cxx |   15 ++-
 1 file changed, 14 insertions(+), 1 deletion(-)

New commits:
commit 125fc2ce861c82592b261f2992c893b414396e56
Author: Oliver Specht 
AuthorDate: Thu Jan 18 15:48:04 2024 +0100
Commit: Thorsten Behrens 
CommitDate: Wed Feb 14 00:52:53 2024 +0100

tdf#63259 rotate case also at start/end of a word

Rotate either rotates the selection or the word the cursor is directly 
before,
inside or directly after

Change-Id: Ia21e3120d2b00978b9f4ce06738b42e90d2ada62
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162256
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/sw/source/uibase/shells/textsh.cxx 
b/sw/source/uibase/shells/textsh.cxx
index c2d1d44068d9..c743ee3ffed7 100644
--- a/sw/source/uibase/shells/textsh.cxx
+++ b/sw/source/uibase/shells/textsh.cxx
@@ -877,7 +877,20 @@ void SwTextShell::ExecTransliteration( SfxRequest const & 
rReq )
 void SwTextShell::ExecRotateTransliteration( SfxRequest const & rReq )
 {
 if( rReq.GetSlot() == SID_TRANSLITERATE_ROTATE_CASE )
-GetShell().TransliterateText( m_aRotateCase.getNextMode() );
+{
+SwWrtShell& rSh = GetShell();
+if (rSh.HasSelection())
+{
+rSh.TransliterateText(m_aRotateCase.getNextMode());
+}
+else
+{
+rSh.Push(); // save cur cursor
+if ((rSh.IsEndWrd() || rSh.IsStartWord() || rSh.IsInWord()) && 
rSh.SelWrd())
+rSh.TransliterateText(m_aRotateCase.getNextMode());
+rSh.Pop(SwCursorShell::PopMode::DeleteCurrent);
+}
+}
 }
 
 SwTextShell::SwTextShell(SwView &_rView) :


[Bug 159713] On a sparkline, empty cells can't be taken as "gap"

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159713

--- Comment #1 from David García  ---
Created attachment 192551
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192551=edit
Spreadsheet

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159713] New: On a sparkline, empty cells can't be taken as "gap"

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159713

Bug ID: 159713
   Summary: On a sparkline, empty cells can't be taken as "gap"
   Product: LibreOffice
   Version: 24.2.0.3 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: vivada...@hotmail.com

Description:
When you create a sparkline, there's a setting called "Display empty cells as",
which offers you the possibility of selecting "gap". However, when I select
"gap", I get the same result as if I had selected "zero".

Steps to Reproduce:
1. I create a new sparkline.
2. I select "gap" under "Display empty cells as".


Actual Results:
The sparkline displays a zero value for the empty cells.

Expected Results:
The sparkline should display nothing for the empty cells.


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 24.2.0.3 (X86_64) / LibreOffice Community
Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-GB
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159712] Sparklines don't take the space of the whole merged cell

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159712

--- Comment #1 from David García  ---
Created attachment 192550
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192550=edit
Spreadsheet

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159712] New: Sparklines don't take the space of the whole merged cell

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159712

Bug ID: 159712
   Summary: Sparklines don't take the space of the whole merged
cell
   Product: LibreOffice
   Version: 24.2.0.3 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: vivada...@hotmail.com

Description:
Sparklines only take the space of the original first cell of a merged cell.

Steps to Reproduce:
1. I merge two cells.
2. I try to create a new sparkline and place it on the merged cell, but Calc
only allows me to place it on the fist original cell.
3. As expected, the sparkline only takes the space of the first original cell,
the second one remaining empty.

Actual Results:
The sparkline is placed on the first original cell of the merged cell.

Expected Results:
The sparkline should be placed on the whole merged cell.


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 24.2.0.3 (X86_64) / LibreOffice Community
Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-GB
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 146628] Outline-Folding Button Is Too Small [HiDPI]

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146628

Tex2002ans  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 146628] Outline-Folding Button Is Too Small [HiDPI]

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146628

Tex2002ans  changed:

   What|Removed |Added

 CC||Tex2002ans+LibreOffice@gmai
   ||l.com

--- Comment #6 from Tex2002ans  ---
Created attachment 192549
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192549=edit
Outline Folding - 400% vs 200% Zoom - LO 24.2.0 vs. Word 365.png

Yep, still an issue in:

Version: 24.2.0.3 (X86_64) / LibreOffice Community
Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1
CPU threads: 8; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

Attached is an image comparing:

- LO 24.2.0 vs. Word 365 (2401, build 17231.20194)
- 400% vs. 200% zoom

on:

- Windows 11
- 150% = Scale factor
- 3840x2160 = Resolution

= = = = = = =

Note: This feature isn't experimental (since LO 7.4).

So all you need to do now is:

1. Tools > Options.
2. LibreOffice Writer > View.
3. Under "Outline Folding":
   - Check box ON for "Show outline-folding buttons".

= = = = = = =

(In reply to Damian Hofmann from comment #5)
> note the size of the collapse button, [...] I think the
> button should be about the same height (and width) of a normal text line. Or
> about half the height and width of the toolbar buttons you see on this
> screen.

I agree. Also, if you zoom in:

- The folding button stays extremely tiny.

I'd expect the folding button to:

- Grow/scale "with the font size" (/ or line-height?) of the headings.

... or at least "stay a reasonable size" throughout.

Wouldn't want a:

- 96pt heading to have a GINORMOUS button.
- 8pt heading to have a teeny tiny, unclickable button.

- - -

I just tested in Word 365 (2401, build 17231.20194)...

And they actually have:

- Same size "collapse button" for all heading levels.
   - (Heading 1 + Heading 6 = same size "collapse arrow".)
   - (Font size = no change at all.)

Zooming in/out:

- Shrinks/Grows the size.
   - 100% looks ~ like height of a 12pt capital letter.
   - 200% looks ~ like height of a 12pt lowercase letter.
  - (Don't know if this is a bug? It shrinks smaller and smaller the
further you zoom. By 400%, it's almost 1/4 the size of a 12pt letter 'e'.)

It also feels like it has:

- A tiny bit of a "buffer" around it.
   - (Maybe a few pixels?)

This lets you more easily click to collapse headings.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159711] The minimum Navigator sidebar width should be lower

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159711

--- Comment #1 from Eyal Rozenberg  ---
Created attachment 192548
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192548=edit
Minimum-width styles sidebar for comparison

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159711] The minimum Navigator sidebar width should be lower

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159711

--- Comment #1 from Eyal Rozenberg  ---
Created attachment 192548
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192548=edit
Minimum-width styles sidebar for comparison

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 159711] The minimum Navigator sidebar width should be lower

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159711

Eyal Rozenberg  changed:

   What|Removed |Added

 Blocks||103030


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103030
[Bug 103030] [META] Navigator sidebar deck and floating window (also "Target in
Document")
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159711] The minimum Navigator sidebar width should be lower

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159711

Eyal Rozenberg  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159711] The minimum Navigator sidebar width should be lower

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159711

Eyal Rozenberg  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 103030] [META] Navigator sidebar deck and floating window (also "Target in Document")

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103030

Eyal Rozenberg  changed:

   What|Removed |Added

 Depends on||159711


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=159711
[Bug 159711] The minimum Navigator sidebar width should be lower
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159711] New: The minimum Navigator sidebar width should be lower

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159711

Bug ID: 159711
   Summary: The minimum Navigator sidebar width should be lower
   Product: LibreOffice
   Version: 24.8.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: eyalr...@gmx.com

Created attachment 192547
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192547=edit
Minimum-width Navigator sidebar

I believe the minimum width of the Navigator sidebar is too high, i.e. the
Navigator is always wide and can't be narrowed down to a reasonable width.

* At its minimum width, it is perhaps 10% wider than the Styles sidebar
minimum; 
* Its tree-ish content rectangle, in an empty document, uses up less than 35%
of its width
* Three of its four widget rows (other than the main content rectangle) require
no more than 70% of the current Navigator sidebar width

It's just the first row of widgets that's the culprit. And that can definitely
be made narrower! For example, the spinbox increment and decrement widges can
(one hopes!) be stacked vertically rather than horizontally, or even hidden
altogether, to save space; the collapsed category drop-down list could lose,
oh, 20% of its width in a pinch, even if the longest item would suffer when
displayed. And that's without considering hiding any widgets.

So, please make it happen.

Note: This bug may be VCL-specific.

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: ffccbf4762a9ae810bcdd21c41fccdd436e7bfc9
CPU threads: 4; OS: Linux 6.6; UI render: default; VCL: gtk3
Locale: he-IL (en_IL); UI: en-US

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158626] Cell background colour (from "Office" document theme) is changed on xlsx-ods-xlsx conversion

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158626

--- Comment #4 from nhatthinh.p...@iress.com ---
Hi team,

> In 24.2, it was fixed by b36f7769dd07a6b6f55cdf4ce76e2f39ed186e89 but this 
> commit wasn't cherrypicked to 7.6.

> Quikee, can you please have a look if this regression can be fixed in 7.6 
> too? I imagine b36f7769dd0 is too big as it is?

I would appriciate so much if you can cherry pick the pick to 7.6 version. Can
you please help resolve the issue?

Thank you very much,
Thinh

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 96489] Writer crashes some times, if you edit own Templates and bigger documents.

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=96489

Matt K  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #6 from Matt K  ---
Unable to repro with:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: eb68ed13c2bf1e6f338ef164be3dd834a3cbd1e6
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

Setting to NEEDINFO for better repro steps

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159707] CRASH: Changing to edit mode

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159707

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #2 from Julien Nabet  ---
Created attachment 192546
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192546=edit
bt

On pc Debian x86-64 with master sources updated today, I had an assertion.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159591] Calc Find keyboard shortcut wrong on macOS

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159591

Julien Nabet  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||9709

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159709] Assignment of Shortcuts for Find messed up in the German version

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159709

Julien Nabet  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||9591

--- Comment #3 from Julien Nabet  ---
There has been some changes with
https://cgit.freedesktop.org/libreoffice/core/commit/?id=e651d9e657f9b61fb45777d6e7edeb5cb95f8d27

Then I noticed tdf#159326 and I've submitted:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=20f122eb7b0d301d4e937c346f4c3c824690882d

To be sure it's taken into account, I suppose you'll need to start from a brand
new LO profile (see
https://wiki.documentfoundation.org/QA/FirstSteps#Corrupted_user_profile)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159591] Calc Find keyboard shortcut wrong on macOS

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159591

Julien Nabet  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||9326

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159709] Assignment of Shortcuts for Find messed up in the German version

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159709

Julien Nabet  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||9326
 CC||serval2...@yahoo.fr

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'libreoffice-24-2' - configure.ac

2024-02-13 Thread Michael Weghorn (via logerrit)
 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 9de87f990e6d9e48495bd6970a25eb1823d5b2ef
Author: Michael Weghorn 
AuthorDate: Mon Feb 12 10:38:03 2024 +0100
Commit: Taichi Haradaguchi <20001...@ymail.ne.jp>
CommitDate: Tue Feb 13 23:09:01 2024 +0100

kf6: Add missing include path to fix build

Many thanks to Andreas Sturmlechner for pointing
this out on #libreoffice-dev on 2024-02-12:

> [10:27]  michaelweghorn: I also had to apply a trivial
>  openmandriva patch to get it to build in the first place,
>  
https://github.com/gentoo/gentoo/blob/master/app-office/libreoffice/files/libreoffice-24.2-kf6-buildfix.patch

Change-Id: If86220e258336d84ffc30fd5da0f5d99dda59aff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163237
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 
(cherry picked from commit 30ec42fad4c0c61de93bea23e9f7d98acc6db0e6)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163272
Reviewed-by: Taichi Haradaguchi <20001...@ymail.ne.jp>

diff --git a/configure.ac b/configure.ac
index a5d9287e0808..b7042e9ee312 100644
--- a/configure.ac
+++ b/configure.ac
@@ -13493,7 +13493,7 @@ then
 AC_MSG_ERROR([KF6 libraries not found.  Please specify the root of 
your KF6 installation by exporting KF6DIR before running "configure".])
 fi
 
-KF6_CFLAGS="-I$kf6_incdir -I$kf6_incdir/KCoreAddons -I$kf6_incdir/KI18n 
-I$kf6_incdir/KConfigCore -I$kf6_incdir/KWindowSystem -I$kf6_incdir/KIO 
-I$kf6_incdir/KIOCore -I$kf6_incdir/KIOWidgets -I$kf6_incdir/KIOFileWidgets 
-I$qt6_incdir -I$qt6_incdir/QtCore -I$qt6_incdir/QtGui -I$qt6_incdir/QtWidgets 
-I$qt6_incdir/QtNetwork -DQT_CLEAN_NAMESPACE -DQT_THREAD_SUPPORT 
-DQT_NO_VERSION_TAGGING"
+KF6_CFLAGS="-I$kf6_incdir -I$kf6_incdir/KCoreAddons -I$kf6_incdir/KI18n 
-I$kf6_incdir/KConfig -I$kf6_incdir/KConfigCore -I$kf6_incdir/KWindowSystem 
-I$kf6_incdir/KIO -I$kf6_incdir/KIOCore -I$kf6_incdir/KIOWidgets 
-I$kf6_incdir/KIOFileWidgets -I$qt6_incdir -I$qt6_incdir/QtCore 
-I$qt6_incdir/QtGui -I$qt6_incdir/QtWidgets -I$qt6_incdir/QtNetwork 
-DQT_CLEAN_NAMESPACE -DQT_THREAD_SUPPORT -DQT_NO_VERSION_TAGGING"
 KF6_LIBS="-L$kf6_libdir -lKF6CoreAddons -lKF6I18n -lKF6ConfigCore 
-lKF6WindowSystem -lKF6KIOCore -lKF6KIOWidgets -lKF6KIOFileWidgets 
-L$qt6_libdir -lQt6Core -lQt6Gui -lQt6Widgets -lQt6Network"
 KF6_CFLAGS=$(printf '%s' "$KF6_CFLAGS" | sed -e "s/-I/${ISYSTEM?}/g")
 


core.git: sw/source

2024-02-13 Thread Andrea Gelmini (via logerrit)
 sw/source/core/bastyp/init.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5ae5728350e7b7b0392df2b3e27f55c6611f842e
Author: Andrea Gelmini 
AuthorDate: Tue Feb 13 18:41:39 2024 +0100
Commit: Taichi Haradaguchi <20001...@ymail.ne.jp>
CommitDate: Tue Feb 13 23:07:37 2024 +0100

Fix typo

Change-Id: I4d968280a5231bbd90496acc3ceabd065fc22fc2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163320
Tested-by: Jenkins
Reviewed-by: Taichi Haradaguchi <20001...@ymail.ne.jp>

diff --git a/sw/source/core/bastyp/init.cxx b/sw/source/core/bastyp/init.cxx
index 7827281b9fee..177b11433cd8 100644
--- a/sw/source/core/bastyp/init.cxx
+++ b/sw/source/core/bastyp/init.cxx
@@ -361,7 +361,7 @@ ItemInfoPackage& getItemInfoPackageSwAttributes()
 { RES_PARATR_TABSTOP, new SvxTabStopItem( 1, SVX_TAB_DEFDIST, 
SvxTabAdjust::Default, RES_PARATR_TABSTOP ), SID_ATTR_TABSTOP, 
SFX_ITEMINFOFLAG_SUPPORT_SURROGATE  },
 
 // for this at the Item GetMaxHyphens() = 0 was called, do this 
now on-demand at construction time
-// it willl get added in costructor below once for LO runtime as 
static default
+// it will get added in costructor below once for LO runtime as 
static default
 { RES_PARATR_HYPHENZONE, nullptr, SID_ATTR_PARA_HYPHENZONE, 
SFX_ITEMINFOFLAG_NONE  },
 
 { RES_PARATR_DROP, new SwFormatDrop, FN_FORMAT_DROPCAPS, 
SFX_ITEMINFOFLAG_NONE  },


[Bug 159710] paste not allowed on save dialog.

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159710

--- Comment #1 from Bogaboga Man  ---
Unable to reproduce with version 24.2.0.3 (X86_64) Windows 11 Home.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 45904] Move Java based API tests to C++

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=45904

--- Comment #378 from Commit Notification 
 ---
Luv Sharma committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9241b739c78c5becad434ac8d381104d8dc243aa

tdf#45904 Remove old SwXTextTable Java test

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: qadevOOo/Jar_OOoRunner.mk qadevOOo/objdsc qadevOOo/tests sw/qa

2024-02-13 Thread Luv Sharma (via logerrit)
 qadevOOo/Jar_OOoRunner.mk|1 
 qadevOOo/objdsc/sw/com.sun.star.comp.office.SwXTextTable.csv |   58 --
 qadevOOo/tests/java/mod/_sw/SwXTextTable.java|  235 ---
 sw/qa/unoapi/knownissues.xcl |3 
 sw/qa/unoapi/sw_4.sce|1 
 5 files changed, 298 deletions(-)

New commits:
commit 9241b739c78c5becad434ac8d381104d8dc243aa
Author: Luv Sharma 
AuthorDate: Mon Feb 12 18:37:01 2024 +0530
Commit: Taichi Haradaguchi <20001...@ymail.ne.jp>
CommitDate: Tue Feb 13 23:03:20 2024 +0100

tdf#45904 Remove old SwXTextTable Java test

Change-Id: I3670d01229a8f44691ac971196a6b0b929649896
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163248
Tested-by: Jenkins
Reviewed-by: Taichi Haradaguchi <20001...@ymail.ne.jp>

diff --git a/qadevOOo/Jar_OOoRunner.mk b/qadevOOo/Jar_OOoRunner.mk
index b57d3caa970f..a514d65ef8f8 100644
--- a/qadevOOo/Jar_OOoRunner.mk
+++ b/qadevOOo/Jar_OOoRunner.mk
@@ -1128,7 +1128,6 @@ $(eval $(call gb_Jar_add_sourcefiles,OOoRunner,\
 qadevOOo/tests/java/mod/_sw/SwXTextRanges \
 qadevOOo/tests/java/mod/_sw/SwXTextSearch \
 qadevOOo/tests/java/mod/_sw/SwXTextSection \
-qadevOOo/tests/java/mod/_sw/SwXTextTable \
 qadevOOo/tests/java/mod/_sw/SwXTextTableCursor \
 qadevOOo/tests/java/mod/_sw/SwXTextTableRow \
 qadevOOo/tests/java/mod/_sw/SwXTextView \
diff --git a/qadevOOo/objdsc/sw/com.sun.star.comp.office.SwXTextTable.csv 
b/qadevOOo/objdsc/sw/com.sun.star.comp.office.SwXTextTable.csv
deleted file mode 100644
index 14049f6d83ea..
--- a/qadevOOo/objdsc/sw/com.sun.star.comp.office.SwXTextTable.csv
+++ /dev/null
@@ -1,58 +0,0 @@
-"SwXTextTable";"com::sun::star::lang::XComponent";"dispose()"
-"SwXTextTable";"com::sun::star::lang::XComponent";"addEventListener()"
-"SwXTextTable";"com::sun::star::lang::XComponent";"removeEventListener()"
-"SwXTextTable";"com::sun::star::chart::XChartData";"addChartDataChangeEventListener()"
-"SwXTextTable";"com::sun::star::chart::XChartData";"removeChartDataChangeEventListener()"
-"SwXTextTable";"com::sun::star::chart::XChartData";"getNotANumber()"
-"SwXTextTable";"com::sun::star::chart::XChartData";"isNotANumber()"
-"SwXTextTable";"com::sun::star::text::TextContent";"AnchorType#optional"
-"SwXTextTable";"com::sun::star::text::TextContent";"AnchorTypes#optional"
-"SwXTextTable";"com::sun::star::text::TextContent";"TextWrap#optional"
-"SwXTextTable";"com::sun::star::table::XAutoFormattable";"autoFormat()"
-"SwXTextTable";"com::sun::star::text::XTextTable";"initialize()"
-"SwXTextTable";"com::sun::star::text::XTextTable";"getRows()"
-"SwXTextTable";"com::sun::star::text::XTextTable";"getColumns()"
-"SwXTextTable";"com::sun::star::text::XTextTable";"getCellByName()"
-"SwXTextTable";"com::sun::star::text::XTextTable";"getCellNames()"
-"SwXTextTable";"com::sun::star::text::XTextTable";"createCursorByCellName()"
-"SwXTextTable";"com::sun::star::table::XCellRange";"getCellByPosition()"
-"SwXTextTable";"com::sun::star::table::XCellRange";"getCellRangeByPosition()"
-"SwXTextTable";"com::sun::star::table::XCellRange";"getCellRangeByName()"
-"SwXTextTable";"com::sun::star::text::TextTable";"BreakType"
-"SwXTextTable";"com::sun::star::text::TextTable";"LeftMargin"
-"SwXTextTable";"com::sun::star::text::TextTable";"RightMargin"
-"SwXTextTable";"com::sun::star::text::TextTable";"HoriOrient"
-"SwXTextTable";"com::sun::star::text::TextTable";"KeepTogether"
-"SwXTextTable";"com::sun::star::text::TextTable";"Split"
-"SwXTextTable";"com::sun::star::text::TextTable";"PageNumberOffset"
-"SwXTextTable";"com::sun::star::text::TextTable";"PageDescName"
-"SwXTextTable";"com::sun::star::text::TextTable";"RelativeWidth"
-"SwXTextTable";"com::sun::star::text::TextTable";"IsWidthRelative"
-"SwXTextTable";"com::sun::star::text::TextTable";"RepeatHeadline"
-"SwXTextTable";"com::sun::star::text::TextTable";"ShadowFormat"
-"SwXTextTable";"com::sun::star::text::TextTable";"TopMargin"
-"SwXTextTable";"com::sun::star::text::TextTable";"BottomMargin"
-"SwXTextTable";"com::sun::star::text::TextTable";"BackTransparent"
-"SwXTextTable";"com::sun::star::text::TextTable";"Width"
-"SwXTextTable";"com::sun::star::text::TextTable";"ChartRowAsLabel"
-"SwXTextTable";"com::sun::star::text::TextTable";"ChartColumnAsLabel"
-"SwXTextTable";"com::sun::star::text::TextTable";"TableBorder"
-"SwXTextTable";"com::sun::star::text::TextTable";"TableColumnSeparators"
-"SwXTextTable";"com::sun::star::text::TextTable";"TableColumnRelativeSum"
-"SwXTextTable";"com::sun::star::text::TextTable";"BackColor"
-"SwXTextTable";"com::sun::star::text::TextTable";"BackGraphic"
-"SwXTextTable";"com::sun::star::text::TextTable";"BackGraphicLocation"
-"SwXTextTable";"com::sun::star::container::XNamed";"getName()"
-"SwXTextTable";"com::sun::star::container::XNamed";"setName()"

core.git: sw/source

2024-02-13 Thread Andrea Gelmini (via logerrit)
 sw/source/ui/frmdlg/frmpage.cxx |2 --
 1 file changed, 2 deletions(-)

New commits:
commit 947e472a41f5ff43f16288b3881a29119b0f269c
Author: Andrea Gelmini 
AuthorDate: Tue Feb 13 18:39:26 2024 +0100
Commit: Taichi Haradaguchi <20001...@ymail.ne.jp>
CommitDate: Tue Feb 13 23:01:00 2024 +0100

Remove duplicated include

Change-Id: If2b13ef3100203d461b96b3bae7541d4593ace09
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163317
Tested-by: Jenkins
Reviewed-by: Taichi Haradaguchi <20001...@ymail.ne.jp>

diff --git a/sw/source/ui/frmdlg/frmpage.cxx b/sw/source/ui/frmdlg/frmpage.cxx
index da72a4e73505..6d6a1fefd49a 100644
--- a/sw/source/ui/frmdlg/frmpage.cxx
+++ b/sw/source/ui/frmdlg/frmpage.cxx
@@ -76,8 +76,6 @@
 #include 
 #include 
 
-#include 
-
 using namespace ::com::sun::star;
 using namespace ::sfx2;
 


[Bug 159211] Test failure 24.2.0.1 final only on s390x: testTdf157635::TestBody

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159211

Dean  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||dean.ebon...@gmail.com
 Ever confirmed|0   |1

--- Comment #1 from Dean  ---
Hi Gwyn,

Thank you for reporting the bug.

Unfortunately, I cannot accessed the url that you have provided and when we
tried opening it. There's '404 not found' error. Also, without clear steps to
reproduce it, we cannot track down the origin of the problem. 

I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' once the steps are provided.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159175] 2 GB of ram used when clicking open new calc document 10 times

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159175

Dean  changed:

   What|Removed |Added

 CC||dean.ebon...@gmail.com

--- Comment #6 from Dean  ---
Hi,

Thanks for reporting. I have try to replicate the bug but no bug was present of
2 GB used. I originally have 9.4 GB available. I only found that the 10
documents opened only used 0.2 to 0.3 GB (~230 mb). 

Version: 24.2.0 (x86-64)
Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1
TinderBox: Windows 10 Pro, LibreOffice 24.2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159709] Assignment of Shortcuts for Find messed up in the German version

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159709

Rainer Bielefeld Retired  changed:

   What|Removed |Added

 CC||LibreOffice@bielefeldundbus
   ||s.de
   Severity|normal  |major

--- Comment #2 from Rainer Bielefeld Retired  
---
Also some small discussion on ircs://libera.chat/libreoffice-qa

[2024-02-13 17:44:35]  core - Version 24.2.0.3, tag libreoffice-24.2.0.3
-
https://git.libreoffice.org/core/commit/da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1
[2024-02-13 17:59:43]  in
https://wiki.documentfoundation.org/ReleaseNotes/24.2 I see Updated German
language shortcuts for general compatibility. 
[2024-02-13 18:04:42]  buovjaga: I doubt that I ever used
Software with German UI and  for "Find"
 Rainer_Bielefeld:
https://git.libreoffice.org/core/commit/4b81692f8f3236082f9ac989e4e21c8119ff6e64
[2024-02-13 18:08:26]  Also see
https://de.wikipedia.org/wiki/Tastenkombination
[2024-02-13 18:37:44]  core - German shortcut improvements for Calc: -
https://git.libreoffice.org/core/commit/e651d9e657f9b61fb45777d6e7edeb5cb95f8d27

Its not true that these changes will bring compatibility / unification.
I never used a German UI software with  for "find" – except Writer
And CALC has a different Shortcut 
And DRAW still 

Usability is completely messed with this shortcuts change, this is a major
issue! Needs to be reverted with very next Version.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159709] Assignment of Shortcuts for Find messed up in the German version

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159709

Rainer Bielefeld Retired  changed:

   What|Removed |Added

   Priority|medium  |high

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159697] BASE, EXTENSIONS, BaseDocumenter error Basic script crashes

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159697

--- Comment #3 from graham.w...@gmx.net  ---
You're correct - line 230.

Sample database attached.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159697] BASE, EXTENSIONS, BaseDocumenter error Basic script crashes

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159697

--- Comment #2 from graham.w...@gmx.net  ---
Created attachment 192545
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192545=edit
Sample database "PDB-copy-odb"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159709] Assignment of Shortcuts for Find messed up in the German version

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159709

Harald Berger  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from Harald Berger  ---
I can confirm that.

See also:
https://ask.libreoffice.org/t/lost-strg-f-nicht-mehr-die-funktion-find-aus/102031

(Note: I fear that even more keyborad shortcuts are affected.)

---
With me:
Version: 24.2.0.3 (X86_64) / LibreOffice Community
Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159710] paste not allowed on save dialog.

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159710

libreoff...@tamtec.com  changed:

   What|Removed |Added

   Hardware|All |ARM
 OS|All |macOS (All)
   Severity|normal  |minor

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159710] New: paste not allowed on save dialog.

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159710

Bug ID: 159710
   Summary: paste not allowed on save dialog.
   Product: LibreOffice
   Version: 7.6.4.1 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: libreoff...@tamtec.com

Saving a Text Document: Was not able to paste text copied from the document
into the save dialog.  Working on a Mac running Sonoma 14.3.1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159709] New: Assignment of Shortcuts for Find messed up in the German version

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159709

Bug ID: 159709
   Summary: Assignment of Shortcuts for Find messed up in the
German version
   Product: LibreOffice
   Version: 24.2.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: adalbert.hans...@gmx.de

This bug has been discussed in
https://ask.libreoffice.org/t/lost-strg-f-nicht-mehr-die-funktion-find-aus/102031
and from that discussion follows, that it has been introduced in the German
version of 

Version: 24.2.2.0.0+ (X86_64) / LibreOffice Community
Build ID: 46169670ef4031888e143823b263577296d7867f
CPU threads: 4; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Calc: threaded

According to erAck's comment the shortcut assignment for Search is unchanged in
the en-US version.

In many programs, the key combination Ctrl-F is assigned to the search function
("find"). In most cases, if something is selected, the selected item is
immediately fed in as a search pattern.

In the German localized version 24.2.2.0 the key combination Shift-Alt-F is
provided for "Search" alias "Find". Shift-Alt-F is unfavorable because one
easily hits the Super key instead of Alt. 

One can however manually assign "Search" to Ctl-F and re-establish the well
known standard behavior of this key combination. 

Before doing so in the mentioned version, Ctrl-F has the following effect:

* if the dock for style sheets (and possibly Navigator) are minimized, it makes
them visible,

* each further press switches between Styles alone and Styles+Navigator.

Ctl-F5 also does not work as advertised in the dropdown list of
Ansicht>Seitenleiste. It really is Ctl-F, as mentioned before, not Ctl-F5.

In the mentioned discussion, erAck also mentions inconsistency across Writer
Calc and so on. The last "slot assignment" changes there should be carefully
investigated.

Cave: If one assignment is shifted, others might be affected too. The
similarity of the printed strings Ctl-F and CTL-F5 also suggests that this
might merely be a typing error, which then may have been corrected by simply
using a new key combination, without considering that Ctl-F is used for
"Search" alias "Find" everywhere else.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'distro/collabora/co-24.04' - sc/source vcl/jsdialog

2024-02-13 Thread Hubert Figuière (via logerrit)
 sc/source/ui/attrdlg/attrdlg.cxx |7 +--
 vcl/jsdialog/enabled.cxx |1 +
 2 files changed, 2 insertions(+), 6 deletions(-)

New commits:
commit 11ccb687f6739d58d5ad878aece31db330825d08
Author: Hubert Figuière 
AuthorDate: Mon Feb 12 17:32:31 2024 -0500
Commit: Michael Meeks 
CommitDate: Tue Feb 13 20:58:26 2024 +0100

sc: add back protect cell tab from cell format dialog

Also enable the tab in jsdialogs

Signed-off-by: Hubert Figuière 
Change-Id: I2c4eac029568cc0de4be5ebb6b0f4ae47f2da1a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163263
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Michael Meeks 
(cherry picked from commit 6cda8155c66bfcd3ebda49ac8254d529629a300e)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163287
Tested-by: Michael Meeks 

diff --git a/sc/source/ui/attrdlg/attrdlg.cxx b/sc/source/ui/attrdlg/attrdlg.cxx
index faa08bf3ca00..c0653ad4f1d0 100644
--- a/sc/source/ui/attrdlg/attrdlg.cxx
+++ b/sc/source/ui/attrdlg/attrdlg.cxx
@@ -30,7 +30,6 @@
 #include 
 #include 
 #include 
-#include 
 
 ScAttrDlg::ScAttrDlg(weld::Window* pParent, const SfxItemSet* pCellAttrs)
 : SfxTabDialogController(pParent, "modules/scalc/ui/formatcellsdialog.ui",
@@ -58,11 +57,7 @@ ScAttrDlg::ScAttrDlg(weld::Window* pParent, const 
SfxItemSet* pCellAttrs)
 AddTabPage( "borders",  pFact->GetTabPageCreatorFunc( 
RID_SVXPAGE_BORDER ), nullptr );
 OSL_ENSURE(pFact->GetTabPageCreatorFunc( RID_SVXPAGE_BKG ), 
"GetTabPageCreatorFunc fail!");
 AddTabPage( "background",  pFact->GetTabPageCreatorFunc( RID_SVXPAGE_BKG 
), nullptr );
-
-if (!comphelper::LibreOfficeKit::isActive())
-AddTabPage( "cellprotection" ,  ScTabPageProtection::Create,
nullptr );
-else
-RemoveTabPage( "cellprotection" );
+AddTabPage( "cellprotection" ,  ScTabPageProtection::Create,nullptr );
 }
 
 ScAttrDlg::~ScAttrDlg()
diff --git a/vcl/jsdialog/enabled.cxx b/vcl/jsdialog/enabled.cxx
index beb12b5dd081..b04418257bff 100644
--- a/vcl/jsdialog/enabled.cxx
+++ b/vcl/jsdialog/enabled.cxx
@@ -97,6 +97,7 @@ bool isBuilderEnabled(std::u16string_view rUIFile, bool 
bMobile)
 // scalc
 || rUIFile == u"modules/scalc/ui/advancedfilterdialog.ui"
 || rUIFile == u"modules/scalc/ui/analysisofvariancedialog.ui"
+|| rUIFile == u"modules/scalc/ui/cellprotectionpage.ui"
 || rUIFile == u"modules/scalc/ui/chardialog.ui"
 || rUIFile == u"modules/scalc/ui/chisquaretestdialog.ui"
 || rUIFile == u"modules/scalc/ui/colwidthdialog.ui"


core.git: sc/source vcl/jsdialog

2024-02-13 Thread Hubert Figuière (via logerrit)
 sc/source/ui/attrdlg/attrdlg.cxx |7 +--
 vcl/jsdialog/enabled.cxx |1 +
 2 files changed, 2 insertions(+), 6 deletions(-)

New commits:
commit eeadb4d703659987c7f54ca296755f6e7e5ffd1e
Author: Hubert Figuière 
AuthorDate: Mon Feb 12 17:32:31 2024 -0500
Commit: Michael Meeks 
CommitDate: Tue Feb 13 20:58:01 2024 +0100

sc: add back protect cell tab from cell format dialog

Also enable the tab in jsdialogs

Signed-off-by: Hubert Figuière 
Change-Id: I2c4eac029568cc0de4be5ebb6b0f4ae47f2da1a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163263
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Michael Meeks 
(cherry picked from commit eb6674aa7899e7b9542bcc9e1ca5cb5c4dfee843)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163332
Tested-by: Jenkins

diff --git a/sc/source/ui/attrdlg/attrdlg.cxx b/sc/source/ui/attrdlg/attrdlg.cxx
index faa08bf3ca00..c0653ad4f1d0 100644
--- a/sc/source/ui/attrdlg/attrdlg.cxx
+++ b/sc/source/ui/attrdlg/attrdlg.cxx
@@ -30,7 +30,6 @@
 #include 
 #include 
 #include 
-#include 
 
 ScAttrDlg::ScAttrDlg(weld::Window* pParent, const SfxItemSet* pCellAttrs)
 : SfxTabDialogController(pParent, "modules/scalc/ui/formatcellsdialog.ui",
@@ -58,11 +57,7 @@ ScAttrDlg::ScAttrDlg(weld::Window* pParent, const 
SfxItemSet* pCellAttrs)
 AddTabPage( "borders",  pFact->GetTabPageCreatorFunc( 
RID_SVXPAGE_BORDER ), nullptr );
 OSL_ENSURE(pFact->GetTabPageCreatorFunc( RID_SVXPAGE_BKG ), 
"GetTabPageCreatorFunc fail!");
 AddTabPage( "background",  pFact->GetTabPageCreatorFunc( RID_SVXPAGE_BKG 
), nullptr );
-
-if (!comphelper::LibreOfficeKit::isActive())
-AddTabPage( "cellprotection" ,  ScTabPageProtection::Create,
nullptr );
-else
-RemoveTabPage( "cellprotection" );
+AddTabPage( "cellprotection" ,  ScTabPageProtection::Create,nullptr );
 }
 
 ScAttrDlg::~ScAttrDlg()
diff --git a/vcl/jsdialog/enabled.cxx b/vcl/jsdialog/enabled.cxx
index 6d5acc3dc538..c7973fad4d57 100644
--- a/vcl/jsdialog/enabled.cxx
+++ b/vcl/jsdialog/enabled.cxx
@@ -97,6 +97,7 @@ bool isBuilderEnabled(std::u16string_view rUIFile, bool 
bMobile)
 // scalc
 || rUIFile == u"modules/scalc/ui/advancedfilterdialog.ui"
 || rUIFile == u"modules/scalc/ui/analysisofvariancedialog.ui"
+|| rUIFile == u"modules/scalc/ui/cellprotectionpage.ui"
 || rUIFile == u"modules/scalc/ui/chardialog.ui"
 || rUIFile == u"modules/scalc/ui/chisquaretestdialog.ui"
 || rUIFile == u"modules/scalc/ui/colwidthdialog.ui"


[Bug 159706] Incorrect page boundary position when page gaps are collapsed

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159706

raal  changed:

   What|Removed |Added

   Keywords||bibisected, bisected
  Regression By||Miklos Vajna
 CC||vmik...@collabora.com

--- Comment #6 from raal  ---
This seems to have begun at the below commit in bibisect repository/OS
bibisect-linux-64-5.2.
Adding Cc: to Miklos Vajna ; Could you possibly take a look at this one?
Thanks

7a88da46b3a944639a614d2e80d3048074d7e73f is the first bad commit
commit 7a88da46b3a944639a614d2e80d3048074d7e73f
Author: Jenkins Build User 
Date:   Fri Dec 8 09:57:46 2017 +0100

source sha:6d8da2b2deb4be2182ca1852cec7eb38a4c654eb

21445: tdf#96943 sw Hide Whitespace: don't create pages for widow / orphan ...
| https://gerrit.libreoffice.org/c/core/+/21445

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159706] Incorrect page boundary position when page gaps are collapsed

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159706

raal  changed:

   What|Removed |Added

   Keywords||regression
Version|24.2.0.3 release|5.3.0.3 release
 CC||r...@post.cz
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #5 from raal  ---
Confirm with Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: f289fe3dca487c45417f7b40d51a4830f3369fb1
CPU threads: 4; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded Jumbo

and Version: 5.3.0.0.alpha1+

Works in Version: 5.2.0.0.alpha0+
Build ID: 3ca42d8d51174010d5e8a32b96e9b4c0b3730a53

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159692] Check Boxes are printed/exported at the wrong position

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159692

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #4 from raal  ---
No repro with Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: f289fe3dca487c45417f7b40d51a4830f3369fb1
CPU threads: 4; OS: Linux 6.5; UI render: default; VCL: x11
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded Jumbo

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158237] Use C++20 contains() instead of find() and end()

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158237

--- Comment #3 from Commit Notification 
 ---
AkshayWarrier committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/488cd78f3b30f8b43007a3250d0c11fd0416dde9

tdf#158237 comphelper: Use C++20 contains() instead of find() and end()

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: comphelper/source

2024-02-13 Thread AkshayWarrier (via logerrit)
 comphelper/source/container/embeddedobjectcontainer.cxx |6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

New commits:
commit 488cd78f3b30f8b43007a3250d0c11fd0416dde9
Author: AkshayWarrier 
AuthorDate: Sat Jan 20 22:42:58 2024 +0530
Commit: Hossein 
CommitDate: Tue Feb 13 19:54:07 2024 +0100

tdf#158237 comphelper: Use C++20 contains() instead of find() and end()

Change-Id: I99c27c2269051c6c145dbfd2ec12790d4bb1d5e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162338
Tested-by: Jenkins
Reviewed-by: Hossein 

diff --git a/comphelper/source/container/embeddedobjectcontainer.cxx 
b/comphelper/source/container/embeddedobjectcontainer.cxx
index d20e99d6632b..a66ac2dec527 100644
--- a/comphelper/source/container/embeddedobjectcontainer.cxx
+++ b/comphelper/source/container/embeddedobjectcontainer.cxx
@@ -238,8 +238,7 @@ bool EmbeddedObjectContainer::HasEmbeddedObjects() const
 
 bool EmbeddedObjectContainer::HasEmbeddedObject( const OUString& rName )
 {
-auto aIt = pImpl->maNameToObjectMap.find( rName );
-if (aIt != pImpl->maNameToObjectMap.end())
+if (pImpl->maNameToObjectMap.contains(rName))
 return true;
 if (!pImpl->mxStorage.is())
 return false;
@@ -256,8 +255,7 @@ bool 
EmbeddedObjectContainer::HasInstantiatedEmbeddedObject( const OUString& rNa
 // allows to detect whether the object was already instantiated
 // currently the filter instantiate it on loading, so this method allows
 // to avoid objects pointing to the same persistence
-auto aIt = pImpl->maNameToObjectMap.find( rName );
-return ( aIt != pImpl->maNameToObjectMap.end() );
+return pImpl->maNameToObjectMap.contains(rName);
 }
 
 OUString EmbeddedObjectContainer::GetEmbeddedObjectName( const 
css::uno::Reference < css::embed::XEmbeddedObject >& xObj ) const


[Bug 159618] Stürzt mit großen Tabellen regelmäßig ab

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159618

Telesto  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159302] Formula OLE in a line of text or its full height frame is now misaligned vertically, due to change of sm map units

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159302

Mike Kaganski  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com
   |desktop.org |
 Status|NEW |ASSIGNED

--- Comment #17 from Mike Kaganski  ---
https://gerrit.libreoffice.org/c/core/+/16

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: comphelper/source include/basegfx include/comphelper include/editeng include/vcl vcl/inc

2024-02-13 Thread Noel Grandin (via logerrit)
 comphelper/source/misc/errcode.cxx|4 ++--
 include/basegfx/utils/systemdependentdata.hxx |3 +--
 include/comphelper/seqstream.hxx  |2 +-
 include/editeng/unoedsrc.hxx  |2 +-
 include/vcl/toolkit/field.hxx |2 +-
 vcl/inc/headless/CairoCommon.hxx  |2 +-
 6 files changed, 7 insertions(+), 8 deletions(-)

New commits:
commit 34a09df2d112a9d6828a9a65d9965aacae6c7c41
Author: Noel Grandin 
AuthorDate: Tue Feb 13 16:15:43 2024 +0200
Commit: Noel Grandin 
CommitDate: Tue Feb 13 18:53:21 2024 +0100

fix windows --enable-mergelibs build

after
commit b663d94cf67a5af4fd89c1ac8bdffd6059f6bf85
Author: Noel Grandin 
Date:   Mon Feb 5 08:50:24 2024 +0200
create --enable-mergelibs=more

Change-Id: Ib9f0b3b28df70a9bab10d9bb0aa77a2b2decc616
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163308
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/comphelper/source/misc/errcode.cxx 
b/comphelper/source/misc/errcode.cxx
index e7b667745808..716daab1793e 100644
--- a/comphelper/source/misc/errcode.cxx
+++ b/comphelper/source/misc/errcode.cxx
@@ -21,7 +21,7 @@
 #include 
 #include 
 
-COMPHELPER_DLLPUBLIC OUString ErrCode::toString() const
+UNLESS_MERGELIBS(COMPHELPER_DLLPUBLIC) OUString ErrCode::toString() const
 {
 std::u16string_view pWarningError;
 if (IsWarning())
@@ -150,7 +150,7 @@ COMPHELPER_DLLPUBLIC std::ostream& operator<<(std::ostream& 
os, const ErrCode& e
 return os;
 }
 
-COMPHELPER_DLLPUBLIC OUString ErrCodeMsg::toString() const
+UNLESS_MERGELIBS(COMPHELPER_DLLPUBLIC) OUString ErrCodeMsg::toString() const
 {
 OUString s = mnCode.toString();
 if (!maArg1.isEmpty())
diff --git a/include/basegfx/utils/systemdependentdata.hxx 
b/include/basegfx/utils/systemdependentdata.hxx
index a77a8fb8f886..9304153c1327 100644
--- a/include/basegfx/utils/systemdependentdata.hxx
+++ b/include/basegfx/utils/systemdependentdata.hxx
@@ -9,7 +9,6 @@
 
 #pragma once
 
-#include 
 #include 
 #include 
 #include 
@@ -42,7 +41,7 @@ namespace basegfx
 virtual void flushAll() = 0;
 };
 
-class UNLESS_MERGELIBS(BASEGFX_DLLPUBLIC) SystemDependentData
+class BASEGFX_DLLPUBLIC SystemDependentData
 {
 private:
 // noncopyable
diff --git a/include/comphelper/seqstream.hxx b/include/comphelper/seqstream.hxx
index 405b7937407b..8e2ae36d17c2 100644
--- a/include/comphelper/seqstream.hxx
+++ b/include/comphelper/seqstream.hxx
@@ -33,7 +33,7 @@ namespace comphelper
 {
 
 /** Base class for wrappers around memory data that want to be exposed as an 
XInputStream */
-class UNLESS_MERGELIBS(COMPHELPER_DLLPUBLIC) MemoryInputStream
+class COMPHELPER_DLLPUBLIC MemoryInputStream
 : public ::cppu::WeakImplHelper< css::io::XInputStream, css::io::XSeekable 
>,
   public comphelper::ByteReader
 {
diff --git a/include/editeng/unoedsrc.hxx b/include/editeng/unoedsrc.hxx
index 82695e2e9031..1537f00a743c 100644
--- a/include/editeng/unoedsrc.hxx
+++ b/include/editeng/unoedsrc.hxx
@@ -138,7 +138,7 @@ public:
 SvxEditSource::UpdateData(). This copies back the data to the model's
 EditTextObject/OutlinerParaObject.
  */
-class UNLESS_MERGELIBS(EDITENG_DLLPUBLIC) SvxTextForwarder
+class EDITENG_DLLPUBLIC SvxTextForwarder
 {
 public:
 virtual ~SvxTextForwarder() COVERITY_NOEXCEPT_FALSE;
diff --git a/include/vcl/toolkit/field.hxx b/include/vcl/toolkit/field.hxx
index cbff835934f6..699d7bb74416 100644
--- a/include/vcl/toolkit/field.hxx
+++ b/include/vcl/toolkit/field.hxx
@@ -160,7 +160,7 @@ private:
 
 };
 
-class UNLESS_MERGELIBS(VCL_DLLPUBLIC) MetricFormatter : public NumericFormatter
+class VCL_DLLPUBLIC MetricFormatter : public NumericFormatter
 {
 public:
 virtual ~MetricFormatter() override;
diff --git a/vcl/inc/headless/CairoCommon.hxx b/vcl/inc/headless/CairoCommon.hxx
index 802e02b14f0f..80ada0dd2c61 100644
--- a/vcl/inc/headless/CairoCommon.hxx
+++ b/vcl/inc/headless/CairoCommon.hxx
@@ -20,7 +20,7 @@
 #pragma once
 
 #include 
-
+#include 
 #include 
 
 #include 


[Bug 159302] Formula OLE in a line of text or its full height frame is now misaligned vertically, due to change of sm map units

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159302

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bz.apache.org/ooo/s
   ||how_bug.cgi?id=972

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159589] Math baseline alignment doesn't work

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159589

Mike Kaganski  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=15 |
   |9302|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159302] Formula OLE in a line of text or its full height frame is now misaligned vertically, due to change of sm map units

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159302

Mike Kaganski  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=15 |
   |9589|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159302] Formula OLE in a line of text or its full height frame is now misaligned vertically, due to change of sm map units

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159302

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||7569

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159706] Incorrect page boundary position when page gaps are collapsed

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159706

--- Comment #4 from lvm  ---
> In the left image is 7.4, on the right is 24.2.
> Do you consider 7.4 is better than 24.2, or what is the exact bug?
As far as this bug is concerned they are exactly the same - thay have it. The
bug is that when the page gap is collapsed page break changes its position:
when the gap is expanded it is after the line "quis magna at dapibus. Proin nec
nulla quis odio commodo rutrum. Morbi fermentum euismod risus" two lines before
the end of the paragraph but when it is collapsed it is after "pellentesque."
at the very end of the paragraph.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: solenv/gbuild

2024-02-13 Thread Noel Grandin (via logerrit)
 solenv/gbuild/extensions/pre_MergedLibsList.mk |9 -
 1 file changed, 9 deletions(-)

New commits:
commit 29c9587df7f0e7ce27e616c6fc9640a1df0d20a7
Author: Noel Grandin 
AuthorDate: Tue Feb 13 16:20:07 2024 +0200
Commit: Noel Grandin 
CommitDate: Tue Feb 13 18:13:46 2024 +0100

fix --enable-mergelibs=more build on Windows

I was over-enthusiastic adding these to the merged list, they
are DLLs with their own DllMain functions

Change-Id: I78a4e026e746f9688bc982ea7c899b05cf8f441d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163309
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/solenv/gbuild/extensions/pre_MergedLibsList.mk 
b/solenv/gbuild/extensions/pre_MergedLibsList.mk
index c2ec1e3b083b..9a2fffa033ac 100644
--- a/solenv/gbuild/extensions/pre_MergedLibsList.mk
+++ b/solenv/gbuild/extensions/pre_MergedLibsList.mk
@@ -138,15 +138,9 @@ gb_MERGE_LIBRARY_LIST += \
) \
graphicfilter \
hwp \
-   $(if $(filter WNT,$(OS)), \
-   inprocserv \
-   ) \
log \
$(if $(ENABLE_LWP),lwpft) \
msforms \
-   $(if $(filter WNT,$(OS)), \
-   oleautobridge \
-   ) \
pdffilter \
pricing \
$(call gb_Helper_optional,SCRIPTING,protocolhandler) \
@@ -159,9 +153,6 @@ gb_MERGE_LIBRARY_LIST += \
svgfilter \
t602filter \
textconversiondlgs \
-   $(if $(filter WNT,$(OS)), \
-   UAccCOM \
-   ) \
$(call gb_Helper_optional,XMLHELP,ucpchelp1) \
$(if $(ENABLE_LIBCMIS),ucpcmis1) \
$(if $(WITH_WEBDAV),ucpdav1) \


[Bug 159690] “Wrap text automatically” badly handled in Calc 24.2

2024-02-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159690

raal  changed:

   What|Removed |Added

 CC||parisop...@gmail.com,
   ||r...@post.cz
  Regression By||Paris Oplopoios
   Keywords|bibisectRequest |bibisected, bisected
 OS|Windows (All)   |Linux (All)

--- Comment #10 from raal  ---
(In reply to maison from comment #5)
> Created attachment 192530 [details]
> First test file. As you start moving through the 3 cells, the “Wrap text
> automatically” option is set its way for each cell again.

This seems to have begun at the below commit in bibisect repository/OS
linux-64-24.2.
Adding Cc: to Paris Oplopoios ; Could you possibly take a look at this one?
Thanks

d536a038969c482dff40481d849d8671a9ac7f5f is the first bad commit
commit d536a038969c482dff40481d849d8671a9ac7f5f
Author: Jenkins Build User 
Date:   Thu Nov 23 16:18:50 2023 +0100

source sha:17e362e56f9e15d0214c441e632c91d22e58519d

159758: tdf#158252 sc: Enable text wrapping when inputting line breaks in cell
| https://gerrit.libreoffice.org/c/core/+/159758

-- 
You are receiving this mail because:
You are the assignee for the bug.

  1   2   >