date:20240214

core.git: i18npool/CppunitTest_i18npool_transliteration.mk i18npool/inc i18npool/Library_i18npool.mk i18npool/Library_index_data.mk i18npool/Module_i18npool.mk i18npool/source Repository.mk vcl/common

2024-02-14 Thread Noel Grandin (via logerrit)

 Repository.mk   |1 
 i18npool/CppunitTest_i18npool_transliteration.mk|3 
 i18npool/Library_i18npool.mk|7 +
 i18npool/Library_index_data.mk  |   19 
 i18npool/Module_i18npool.mk |1 
 i18npool/inc/indexentrysupplier_asian.hxx   |   22 -
 i18npool/inc/textToPronounce_zh.hxx |8 -
 i18npool/source/collator/gencoll_rule.cxx   |4 
 i18npool/source/indexentry/indexentrysupplier_asian.cxx |   68 +---
 i18npool/source/transliteration/textToPronounce_zh.cxx  |   44 --
 vcl/commonfuzzer.mk |1 
 11 files changed, 34 insertions(+), 144 deletions(-)

New commits:
commit de43ed10886ae041b3814f80ef0510f6ac18d515
Author: Noel Grandin 
AuthorDate: Wed Feb 14 10:14:13 2024 +0200
Commit: Noel Grandin 
CommitDate: Thu Feb 15 08:58:34 2024 +0100

merge index_data into i18npool

(*) it is a small library
(*) this avoids another dynamic symbol lookup
(*) this unblocks more --enable-mergedlibs optimisation

Change-Id: I9230230c3d72f4e9ce19408f4b5716452ccd4fad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163364
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/Repository.mk b/Repository.mk
index 8c9923bcc6c2..88d01380140c 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -701,7 +701,6 @@ $(eval $(call 
gb_Helper_register_libraries_for_install,PLAINLIBS_OOO,ooo, \
 $(eval $(call gb_Helper_register_plugins_for_install,PLAINLIBS_OOO,ooo, \
 dict_ja \
 dict_zh \
-index_data \
 localedata_en \
 localedata_es \
 localedata_euro \
diff --git a/i18npool/CppunitTest_i18npool_transliteration.mk 
b/i18npool/CppunitTest_i18npool_transliteration.mk
index 6c9f71916fef..45c2607d953a 100644
--- a/i18npool/CppunitTest_i18npool_transliteration.mk
+++ b/i18npool/CppunitTest_i18npool_transliteration.mk
@@ -20,6 +20,7 @@ $(eval $(call 
gb_CppunitTest_use_components,i18npool_transliteration, \
 $(eval $(call gb_CppunitTest_use_libraries,i18npool_transliteration, \
 cppu \
 cppuhelper \
+i18npool \
 sal \
 ))
 
@@ -27,6 +28,4 @@ $(eval $(call 
gb_CppunitTest_use_sdk_api,i18npool_transliteration))
 
 $(eval $(call gb_CppunitTest_use_ure,i18npool_transliteration))
 
-$(call gb_CppunitTest_get_target,i18npool_transliteration): $(call 
gb_Library_get_target,index_data)
-
 # vim: set noet sw=4 ts=4:
diff --git a/i18npool/Library_i18npool.mk b/i18npool/Library_i18npool.mk
index b7f28f67d8f4..4c35c26047f9 100644
--- a/i18npool/Library_i18npool.mk
+++ b/i18npool/Library_i18npool.mk
@@ -159,4 +159,11 @@ $(eval $(call gb_Library_add_generated_cobjects,i18npool,\
$(if $(filter GCC,$(COM)),-Wno-unused-macros) \
 ))
 
+# index data
+$(eval $(call gb_Library_add_generated_exception_objects,i18npool,\
+   $(foreach txt,$(wildcard 
$(SRCDIR)/i18npool/source/indexentry/data/*.txt),\
+   CustomTarget/i18npool/indexentry/$(notdir $(basename $(txt \
+))
+
+
 # vim: set noet sw=4 ts=4:
diff --git a/i18npool/Library_index_data.mk b/i18npool/Library_index_data.mk
deleted file mode 100644
index b00ede9d50ab..
--- a/i18npool/Library_index_data.mk
+++ /dev/null
@@ -1,19 +0,0 @@
-# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
-#
-# This file is part of the LibreOffice project.
-#
-# This Source Code Form is subject to the terms of the Mozilla Public
-# License, v. 2.0. If a copy of the MPL was not distributed with this
-# file, You can obtain one at http://mozilla.org/MPL/2.0/.
-#
-
-$(eval $(call gb_Library_Library,index_data))
-
-$(eval $(call gb_Library_set_plugin_for_nodep,index_data,i18npool))
-
-$(eval $(call gb_Library_add_generated_exception_objects,index_data,\
-   $(foreach txt,$(wildcard 
$(SRCDIR)/i18npool/source/indexentry/data/*.txt),\
-   CustomTarget/i18npool/indexentry/$(notdir $(basename $(txt \
-))
-
-# vim: set noet sw=4 ts=4:
diff --git a/i18npool/Module_i18npool.mk b/i18npool/Module_i18npool.mk
index 97c77a014389..69341fc744c0 100644
--- a/i18npool/Module_i18npool.mk
+++ b/i18npool/Module_i18npool.mk
@@ -20,7 +20,6 @@ $(eval $(call gb_Module_add_targets,i18npool,\
Library_dict_zh) \
Library_i18npool \
Library_i18nsearch \
-   Library_index_data \
Library_localedata_en \
Library_localedata_es \
Library_localedata_euro \
diff --git a/i18npool/inc/indexentrysupplier_asian.hxx 
b/i18npool/inc/indexentrysupplier_asian.hxx
index 52e452b17b01..8d733a0ce58b 100644
--- a/i18npool/inc/indexentrysupplier_asian.hxx
+++ b/i18npool/inc/indexentrysupplier_asian.hxx
@@ -21,7 +21,6 @@
 
 
 #include "indexentrysupplier_common.hxx"
-#include 
 
 namespace i18npool {
 
@@ -44,12 +43,25 @@ public:
 const css::lang::Locale& rLocale2 ) override;
 OUString SAL_CALL

core.git: bin/update_pch desktop/Pagein_draw.mk desktop/Pagein_impress.mk Repository.mk sd/CppunitTest_sd_dialogs_test.mk sd/inc sd/Library_sd.mk sd/Library_sdui.mk sd/Module_sd.mk sd/source sd/util

2024-02-14 Thread Noel Grandin (via logerrit)

 Repository.mk |1 
 bin/update_pch|1 
 desktop/Pagein_draw.mk|1 
 desktop/Pagein_impress.mk |1 
 sd/CppunitTest_sd_dialogs_test.mk |1 
 sd/Library_sd.mk  |   65 
 sd/Library_sdui.mk|  133 
 sd/Module_sd.mk   |1 
 sd/inc/pch/precompiled_sdui.cxx   |   12 
 sd/inc/pch/precompiled_sdui.hxx   |  529 ++
 sd/inc/sdabstdlg.hxx  |2 
 sd/source/console/presenter.component |   18 +
 sd/source/ui/dlg/copydlg.cxx  |   47 +--
 sd/source/ui/dlg/headerfooterdlg.cxx  |5 
 sd/source/ui/dlg/morphdlg.cxx |6 
 sd/source/ui/dlg/sdabstdlg.cxx|   33 ++
 sd/source/ui/dlg/sduiexp.cxx  |4 
 sd/util/sd.component  |6 
 18 files changed, 761 insertions(+), 105 deletions(-)

New commits:
commit 028affcf44b2e465a0a178e8ebe5682edfa68531
Author: Noel Grandin 
AuthorDate: Wed Feb 14 16:07:03 2024 +0100
Commit: Noel Grandin 
CommitDate: Thu Feb 15 08:57:53 2024 +0100

Revert "merge sdui library into sd"

This reverts commit 2cf7c26293462406d91ee050c6677930065e660b.

Reason for revert:

<_rene_> noelgrandin: sdui->sd... and what about people not needing that ui?
<_rene_> (e.g. --disable-gui and libreoffice-draw-nogui and impress-nogui)
<_rene_> i.e. the use case of --convert-to for ppt(x) etc

Change-Id: I6755c209e63f34b3fc9f9fdc4af7001b18579e8b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163348
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/Repository.mk b/Repository.mk
index add9133fefa4..8c9923bcc6c2 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -517,6 +517,7 @@ $(eval $(call 
gb_Helper_register_plugins_for_install,OOOLIBS,ooo, \
 cui \
 $(if $(USING_X11),desktop_detector) \
 icg \
+sdui \
 $(if $(ENABLE_GEN),vclplug_gen) \
 $(if $(filter $(OS),WNT),vclplug_win) \
 $(if $(filter $(OS),MACOSX),vclplug_osx) \
diff --git a/bin/update_pch b/bin/update_pch
index e7ede0a5d692..4719e5f9269f 100755
--- a/bin/update_pch
+++ b/bin/update_pch
@@ -92,6 +92,7 @@ DEFAULTS = \
 'sc.scui'   : ( 1, EXCLUDE, EXCLUDE, INCLUDE), #  
15.0
 'sc.vbaobj' : ( 1, EXCLUDE, EXCLUDE, INCLUDE), #  
17.3
 'sd.sd' : ( 4, EXCLUDE, EXCLUDE, INCLUDE), #  
47.4
+'sd.sdui'   : ( 4, EXCLUDE, INCLUDE, INCLUDE), #   
9.4
 'sdext.PresentationMinimizer'   : ( 2, EXCLUDE, INCLUDE, INCLUDE), #   
4.1
 'sdext.PresenterScreen' : ( 2, EXCLUDE, INCLUDE, EXCLUDE), #   
7.1
 'sfx2.sfx'  : ( 3, EXCLUDE, EXCLUDE, EXCLUDE), #  
27.4
diff --git a/desktop/Pagein_draw.mk b/desktop/Pagein_draw.mk
index abf7435032d6..2fd0ef6ba4ff 100644
--- a/desktop/Pagein_draw.mk
+++ b/desktop/Pagein_draw.mk
@@ -11,6 +11,7 @@ $(eval $(call gb_Pagein_Pagein,draw))
 
 $(eval $(call gb_Pagein_add_objects,draw,\
 sd \
+sdui \
 svx \
 svxcore \
 ))
diff --git a/desktop/Pagein_impress.mk b/desktop/Pagein_impress.mk
index 9b15cc1fe1ba..f3e4ff7b6d59 100644
--- a/desktop/Pagein_impress.mk
+++ b/desktop/Pagein_impress.mk
@@ -11,6 +11,7 @@ $(eval $(call gb_Pagein_Pagein,impress))
 
 $(eval $(call gb_Pagein_add_objects,impress,\
 sd \
+sdui \
 svx \
 svxcore \
 ))
diff --git a/sd/CppunitTest_sd_dialogs_test.mk 
b/sd/CppunitTest_sd_dialogs_test.mk
index fd3ca391477f..839f702de7ef 100644
--- a/sd/CppunitTest_sd_dialogs_test.mk
+++ b/sd/CppunitTest_sd_dialogs_test.mk
@@ -40,6 +40,7 @@ $(eval $(call gb_CppunitTest_use_libraries,sd_dialogs_test, \
 salhelper \
 sax \
 sd \
+sdui \
 sfx \
 sot \
 svl \
diff --git a/sd/Library_sd.mk b/sd/Library_sd.mk
index 8103d5cb0b01..01c546ad3dca 100644
--- a/sd/Library_sd.mk
+++ b/sd/Library_sd.mk
@@ -49,6 +49,7 @@ $(eval $(call gb_Library_set_include,sd,\
 
 $(eval $(call gb_Library_add_defs,sd,\
-DSD_DLLIMPLEMENTATION \
+   -DSDUI_DLL_NAME=\"$(call gb_Library_get_runtime_filename,$(call 
gb_Library__get_name,sdui))\" \
 ))
 
 ifneq ($(strip $(dbg_anim_log)$(DBG_ANIM_LOG)),)
@@ -77,7 +78,6 @@ $(eval $(call gb_Library_use_libraries,sd,\
drawinglayercore \
drawinglayer \
editeng \
-   fwk \
i18nlangtag \
i18nutil \
icg \
@@ -603,67 +603,4 @@ endif # ENABLE_SDREMOTE_BLUETOOTH=TRUE
 
 endif # ENABLE_SDREMOTE=TRUE
 
-$(eval $(call gb_Library_add_exception_objects,sd,\
-sd/source/ui/dlg/brkdlg \
-sd/source/ui/dlg/copydlg \
-sd/source/ui/dlg/custsdlg \
-sd/source/ui/dlg/dlgchar \
-sd/source/ui/dlg/dlgfield \
-sd/source/ui/dlg/dlgolbul \
-sd/source/ui/dlg/dlgpage \
-sd/source/ui/dlg/dlgsnap \
-sd/source/ui/dlg/headerfooterdlg \
-sd/source/ui/dlg/inspagob \
-

core.git: sw/qa

2024-02-14 Thread Xisco Fauli (via logerrit)

 0 files changed

New commits:
commit 7b658083c1935e1d74306e361c3d69f53eff4fef
Author: Xisco Fauli 
AuthorDate: Wed Feb 14 17:01:27 2024 +0100
Commit: Xisco Fauli 
CommitDate: Thu Feb 15 08:57:28 2024 +0100

sw: move some UItests from writer_tests7 to writer_tests8

writer_tests7 had 47 tests while writer_tests8 6
Now they have 31 and 22 respectively

Change-Id: Iac839c7328d346bc8342ce2f8a20359aeca1206a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163384
Tested-by: Xisco Fauli 
Reviewed-by: Xisco Fauli 

diff --git a/sw/qa/uitest/writer_tests7/tdf140117.py 
b/sw/qa/uitest/writer_tests8/tdf140117.py
similarity index 100%
rename from sw/qa/uitest/writer_tests7/tdf140117.py
rename to sw/qa/uitest/writer_tests8/tdf140117.py
diff --git a/sw/qa/uitest/writer_tests7/tdf140863.py 
b/sw/qa/uitest/writer_tests8/tdf140863.py
similarity index 100%
rename from sw/qa/uitest/writer_tests7/tdf140863.py
rename to sw/qa/uitest/writer_tests8/tdf140863.py
diff --git a/sw/qa/uitest/writer_tests7/tdf141158.py 
b/sw/qa/uitest/writer_tests8/tdf141158.py
similarity index 100%
rename from sw/qa/uitest/writer_tests7/tdf141158.py
rename to sw/qa/uitest/writer_tests8/tdf141158.py
diff --git a/sw/qa/uitest/writer_tests7/tdf141557.py 
b/sw/qa/uitest/writer_tests8/tdf141557.py
similarity index 100%
rename from sw/qa/uitest/writer_tests7/tdf141557.py
rename to sw/qa/uitest/writer_tests8/tdf141557.py
diff --git a/sw/qa/uitest/writer_tests7/tdf143785.py 
b/sw/qa/uitest/writer_tests8/tdf143785.py
similarity index 100%
rename from sw/qa/uitest/writer_tests7/tdf143785.py
rename to sw/qa/uitest/writer_tests8/tdf143785.py
diff --git a/sw/qa/uitest/writer_tests7/tdf144439.py 
b/sw/qa/uitest/writer_tests8/tdf144439.py
similarity index 100%
rename from sw/qa/uitest/writer_tests7/tdf144439.py
rename to sw/qa/uitest/writer_tests8/tdf144439.py
diff --git a/sw/qa/uitest/writer_tests7/tdf144578.py 
b/sw/qa/uitest/writer_tests8/tdf144578.py
similarity index 100%
rename from sw/qa/uitest/writer_tests7/tdf144578.py
rename to sw/qa/uitest/writer_tests8/tdf144578.py
diff --git a/sw/qa/uitest/writer_tests7/tdf145093.py 
b/sw/qa/uitest/writer_tests8/tdf145093.py
similarity index 100%
rename from sw/qa/uitest/writer_tests7/tdf145093.py
rename to sw/qa/uitest/writer_tests8/tdf145093.py
diff --git a/sw/qa/uitest/writer_tests7/tdf145158.py 
b/sw/qa/uitest/writer_tests8/tdf145158.py
similarity index 100%
rename from sw/qa/uitest/writer_tests7/tdf145158.py
rename to sw/qa/uitest/writer_tests8/tdf145158.py
diff --git a/sw/qa/uitest/writer_tests7/tdf145178.py 
b/sw/qa/uitest/writer_tests8/tdf145178.py
similarity index 100%
rename from sw/qa/uitest/writer_tests7/tdf145178.py
rename to sw/qa/uitest/writer_tests8/tdf145178.py
diff --git a/sw/qa/uitest/writer_tests7/tdf146605.py 
b/sw/qa/uitest/writer_tests8/tdf146605.py
similarity index 100%
rename from sw/qa/uitest/writer_tests7/tdf146605.py
rename to sw/qa/uitest/writer_tests8/tdf146605.py
diff --git a/sw/qa/uitest/writer_tests7/tdf150443.py 
b/sw/qa/uitest/writer_tests8/tdf150443.py
similarity index 100%
rename from sw/qa/uitest/writer_tests7/tdf150443.py
rename to sw/qa/uitest/writer_tests8/tdf150443.py
diff --git a/sw/qa/uitest/writer_tests7/tdf156783.py 
b/sw/qa/uitest/writer_tests8/tdf156783.py
similarity index 100%
rename from sw/qa/uitest/writer_tests7/tdf156783.py
rename to sw/qa/uitest/writer_tests8/tdf156783.py
diff --git a/sw/qa/uitest/writer_tests7/tdf156784.py 
b/sw/qa/uitest/writer_tests8/tdf156784.py
similarity index 100%
rename from sw/qa/uitest/writer_tests7/tdf156784.py
rename to sw/qa/uitest/writer_tests8/tdf156784.py
diff --git a/sw/qa/uitest/writer_tests7/tdf156900.py 
b/sw/qa/uitest/writer_tests8/tdf156900.py
similarity index 100%
rename from sw/qa/uitest/writer_tests7/tdf156900.py
rename to sw/qa/uitest/writer_tests8/tdf156900.py

core.git: 2 commits - sc/qa sw/qa

2024-02-14 Thread Xisco Fauli (via logerrit)

 sc/qa/uitest/calc_tests9/tdf159707.py   |   33 ++
 sc/qa/uitest/data/tdf159707.xls |binary
 sw/qa/uitest/data/tdf157569.docx|binary
 sw/qa/uitest/writer_tests6/tdf157569.py |   47 
 4 files changed, 80 insertions(+)

New commits:
commit 582dbb28efb39d93b6f9197590a5c64b69dec393
Author: Xisco Fauli 
AuthorDate: Wed Feb 14 16:31:07 2024 +0100
Commit: Xisco Fauli 
CommitDate: Thu Feb 15 08:56:50 2024 +0100

tdf#1575639: sw: Add UItest

I tried to implement this test as a CppUnittest but it fails with

- Expression: false
- Unexpected dialog: Error activating object Error: General OLE error.

See https://gerrit.libreoffice.org/c/core/+/160917

Change-Id: I36714146cc67119070b9799c4eb251a69f80b0cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163381
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sw/qa/uitest/data/tdf157569.docx b/sw/qa/uitest/data/tdf157569.docx
new file mode 100644
index ..2143a831a0dd
Binary files /dev/null and b/sw/qa/uitest/data/tdf157569.docx differ
diff --git a/sw/qa/uitest/writer_tests6/tdf157569.py 
b/sw/qa/uitest/writer_tests6/tdf157569.py
new file mode 100644
index ..1a9e3344ac8c
--- /dev/null
+++ b/sw/qa/uitest/writer_tests6/tdf157569.py
@@ -0,0 +1,47 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+from uitest.framework import UITestCase
+from uitest.uihelper.common import get_url_for_data_file
+from libreoffice.uno.propertyvalue import mkPropertyValues
+
+class tdf157569(UITestCase):
+
+def test_tdf157569(self):
+with self.ui_test.load_file(get_url_for_data_file("tdf157569.docx")) 
as document:
+
+xShape = document.getDrawPages()[0][0]
+nHeight = xShape.getSize().Height
+nWidth = xShape.getSize().Width
+
+# Without the fix in place, this test would have failed with
+# AssertionError: 1663 != 944
+self.assertEqual(1663, nHeight)
+self.assertEqual(2111, nWidth)
+
+xDoc = self.xUITest.getTopFocusWindow()
+xEditWin = xDoc.getChild("writer_edit")
+
+# Select the formula
+self.xUITest.executeCommand(".uno:JumpToNextFrame")
+xEditWin.executeAction("SELECT", 
mkPropertyValues({"OBJECT":"Object1"}))
+self.assertEqual("SwXTextEmbeddedObject", 
document.CurrentSelection.getImplementationName())
+
+# Go into edit mode
+xEditWin.executeAction("TYPE", 
mkPropertyValues({"KEYCODE":"RETURN"}))
+
+self.assertEqual(nHeight, xShape.getSize().Height)
+self.assertEqual(nWidth, xShape.getSize().Width)
+
+# leave edit mode
+xEditWin.executeAction("TYPE", mkPropertyValues({"KEYCODE":"ESC"}))
+
+self.assertEqual(nHeight, xShape.getSize().Height)
+self.assertEqual(nWidth, xShape.getSize().Width)
+
+# vim: set shiftwidth=4 softtabstop=4 expandtab:
commit fc1e5bf5c1c75acd6bb8f62b9363aa1a30b9acd6
Author: Xisco Fauli 
AuthorDate: Wed Feb 14 12:25:47 2024 +0100
Commit: Xisco Fauli 
CommitDate: Thu Feb 15 08:56:42 2024 +0100

tdf#159707: sc: Add UItest

I tried to create this test as a Cppunittest but it fails with

Run: 1   Failure total: 2   Failures: 1   Errors: 1
warn:vcl:428912:428912:vcl/source/app/svmain.cxx:494: DeInitVCL: some top 
Windows are still alive
text = "" type = "14FloatingWindow", ptr = 0x5608715e49e0
text = "tdf159707.xls (read-only) — LibreOfficeDev Calc" type = 
"10WorkWindow", ptr = 0x5608709ab420

Change-Id: I1b9e16d57050fe07f74c632d441e3a06f49e9438
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163363
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sc/qa/uitest/calc_tests9/tdf159707.py 
b/sc/qa/uitest/calc_tests9/tdf159707.py
new file mode 100644
index ..1e7b240f4b56
--- /dev/null
+++ b/sc/qa/uitest/calc_tests9/tdf159707.py
@@ -0,0 +1,33 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+from uitest.framework import UITestCase
+from uitest.uihelper.common import get_url_for_data_file
+
+from libreoffice.uno.propertyvalue import mkPropertyValues
+from com.sun.star.beans import PropertyValue
+
+class tdf159707(UITestCase):
+
+def test_tdf159707(self):
+
+with

Re: Our Clang --enable-pch setup is known broken

2024-02-14 Thread Stephan Bergmann


On 2/13/24 16:39, Stephan Bergmann wrote:
Maybe somebody has the inclination to dig into our artisanal approach 
and fix it (I assume that would involve fixing the underlying Clang 
machinery that we tap into there), or rework gbuild to use Clang's 
documented PCH approach.  Otherwise, I'd suggest to stick to the tried 
and tested approach of not trying to use PCH in the first place...


or  "Work around some 
Clang PCH consteval issue by disabling HAVE_CPP_CONSTEVAL" to the 
rescue, for now

core.git: Branch 'libreoffice-24-2' - filter/qa include/test sw/qa test/source

2024-02-14 Thread Xisco Fauli (via logerrit)

 filter/qa/unit/svg.cxx |   96 ++---
 include/test/unoapixml_test.hxx|7 ++
 sw/qa/extras/fodfexport/fodfexport.cxx |   36 ++--
 sw/qa/inc/swmodeltestbase.hxx  |7 --
 sw/qa/unit/swmodeltestbase.cxx |6 --
 test/source/unoapixml_test.cxx |6 ++
 6 files changed, 53 insertions(+), 105 deletions(-)

New commits:
commit a04a555497b054e83bc7c8462ba342286508d3a5
Author: Xisco Fauli 
AuthorDate: Tue Feb 13 14:35:33 2024 +0100
Commit: Xisco Fauli 
CommitDate: Thu Feb 15 08:36:05 2024 +0100

UnoApiXmlTest: factor out common code

Change-Id: I5c7f76b61a0dab8b4ebd1ac4680a7c25f982680c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163307
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 
Signed-off-by: Xisco Fauli 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163376

diff --git a/filter/qa/unit/svg.cxx b/filter/qa/unit/svg.cxx
index 8e4f5f5130a4..30a47557f9bb 100644
--- a/filter/qa/unit/svg.cxx
+++ b/filter/qa/unit/svg.cxx
@@ -19,6 +19,7 @@
 #include 
 #include 
 
+#include 
 #include 
 #include 
 #include 
@@ -53,18 +54,13 @@ CPPUNIT_TEST_FIXTURE(SvgFilterTest, testPreserveJpg)
 dispatchCommand(mxComponent, ".uno:JumpToNextFrame", {});
 
 // Export the selection to SVG.
-uno::Reference xStorable(mxComponent, 
uno::UNO_QUERY_THROW);
-SvMemoryStream aStream;
-uno::Reference xOut = new 
utl::OOutputStreamWrapper(aStream);
-utl::MediaDescriptor aMediaDescriptor;
-aMediaDescriptor["FilterName"] <<= OUString("writer_svg_Export");
-aMediaDescriptor["SelectionOnly"] <<= true;
-aMediaDescriptor["OutputStream"] <<= xOut;
-xStorable->storeToURL("private:stream", 
aMediaDescriptor.getAsConstPropertyValueList());
-aStream.Seek(STREAM_SEEK_TO_BEGIN);
+saveWithParams({
+comphelper::makePropertyValue("FilterName", u"writer_svg_Export"_ustr),
+comphelper::makePropertyValue("SelectionOnly", true),
+});
 
 // Make sure that the original JPG data is reused and we don't perform a 
PNG re-compress.
-xmlDocUniquePtr pXmlDoc = parseXmlStream();
+xmlDocUniquePtr pXmlDoc = parseExportedFile();
 OUString aAttributeValue = getXPath(pXmlDoc, "//svg:image"_ostr, 
"href"_ostr);
 
 // Without the accompanying fix in place, this test would have failed with:
@@ -81,17 +77,10 @@ CPPUNIT_TEST_FIXTURE(SvgFilterTest, testSemiTransparentLine)
 loadFromFile(u"semi-transparent-line.odg");
 
 // Export it to SVG.
-uno::Reference xStorable(mxComponent, 
uno::UNO_QUERY_THROW);
-SvMemoryStream aStream;
-uno::Reference xOut = new 
utl::OOutputStreamWrapper(aStream);
-utl::MediaDescriptor aMediaDescriptor;
-aMediaDescriptor["FilterName"] <<= OUString("draw_svg_Export");
-aMediaDescriptor["OutputStream"] <<= xOut;
-xStorable->storeToURL("private:stream", 
aMediaDescriptor.getAsConstPropertyValueList());
-aStream.Seek(STREAM_SEEK_TO_BEGIN);
+save("draw_svg_Export");
 
 // Get the style of the group around the actual  element.
-xmlDocUniquePtr pXmlDoc = parseXmlStream();
+xmlDocUniquePtr pXmlDoc = parseExportedFile();
 OUString aStyle = getXPath(
 pXmlDoc, 
"//svg:g[@class='com.sun.star.drawing.LineShape']/svg:g/svg:g"_ostr, 
"style"_ostr);
 // Without the accompanying fix in place, this test would have failed, as 
the style was
@@ -108,17 +97,10 @@ CPPUNIT_TEST_FIXTURE(SvgFilterTest, 
testSemiTransparentFillWithTransparentLine)
 loadFromFile(u"semi-transparent-fill.odg");
 
 // Export it to SVG.
-uno::Reference xStorable(mxComponent, 
uno::UNO_QUERY_THROW);
-SvMemoryStream aStream;
-uno::Reference xOut = new 
utl::OOutputStreamWrapper(aStream);
-utl::MediaDescriptor aMediaDescriptor;
-aMediaDescriptor["FilterName"] <<= OUString("draw_svg_Export");
-aMediaDescriptor["OutputStream"] <<= xOut;
-xStorable->storeToURL("private:stream", 
aMediaDescriptor.getAsConstPropertyValueList());
-aStream.Seek(STREAM_SEEK_TO_BEGIN);
+save("draw_svg_Export");
 
 // Get the style of the group around the actual  element.
-xmlDocUniquePtr pXmlDoc = parseXmlStream();
+xmlDocUniquePtr pXmlDoc = parseExportedFile();
 OUString aStyle
 = getXPath(pXmlDoc, 
"//svg:g[@class='com.sun.star.drawing.EllipseShape']/svg:g/svg:g"_ostr,
"style"_ostr);
@@ -146,18 +128,9 @@ CPPUNIT_TEST_FIXTURE(SvgFilterTest, 
testSemiTransparentText)
 loadFromFile(u"TransparentText.odg");
 
 // Export to SVG.
-uno::Reference xStorable(mxComponent, 
uno::UNO_QUERY_THROW);
-
-SvMemoryStream aStream;
-uno::Reference xOut = new 
utl::OOutputStreamWrapper(aStream);
-utl::MediaDescriptor aMediaDescriptor;
-aMediaDescriptor["FilterName"] <<= OUString("draw_svg_Export");
-aMediaDescriptor["OutputStream"] <<= xOut;
-xStorable->storeToURL("private:stream", 
aMediaDescriptor.getAsConstPropertyValueList());

[Bug 159727] LibreOffice_24.2.0_Win_x86-64.msi: saving the file with a password absolutely does not work!

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159727

--- Comment #2 from Imre Szabo  ---
Windows 7

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'distro/collabora/co-24.04' - download.lst

2024-02-14 Thread Andras Timar (via logerrit)

 download.lst |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 3682749333934523e24521eebb34570cfb283713
Author: Andras Timar 
AuthorDate: Wed Feb 14 22:18:30 2024 +0100
Commit: Andras Timar 
CommitDate: Thu Feb 15 08:18:02 2024 +0100

nss: upgrade to release 3.97

Change-Id: If0eaf6a93f57239d81491c635922745bf3f38fd5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163391
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Andras Timar 

diff --git a/download.lst b/download.lst
index 75917e55d553..db9dde12b00a 100644
--- a/download.lst
+++ b/download.lst
@@ -540,8 +540,8 @@ MYTHES_TARBALL := mythes-1.2.5.tar.xz
 # three static lines
 # so that git cherry-pick
 # will not run into conflicts
-NSS_SHA256SUM := 
f78ab1d911cae8bbc94758fb3bd0f731df4087423a4ff5db271ba65381f6b739
-NSS_TARBALL := nss-3.90-with-nspr-4.35.tar.gz
+NSS_SHA256SUM := 
a7a920d295998563b33d9e06c1a36b799201493d81b64537fab42f2a733411ce
+NSS_TARBALL := nss-3.97-with-nspr-4.35.tar.gz
 # three static lines
 # so that git cherry-pick
 # will not run into conflicts

[Bug 159728] picture cannot be resized if overlaps the footer

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159728

lvm  changed:

   What|Removed |Added

 Attachment #192574|text/plain  |application/x-drawio
  mime type||

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159728] picture cannot be resized if overlaps the footer

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159728

lvm  changed:

   What|Removed |Added

 CC||lmiro...@yandex.ru

--- Comment #1 from lvm  ---
Created attachment 192574
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192574=edit
testcase

In case you are interested in reproducing the full sequence, the test picture
was produced in drawio. Open the attached document, copy as picture
(ctrl-alt-x) and paste into a blank write document.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 130857] Qt5 implement theming using native widgets (weld)

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130857

--- Comment #11 from Commit Notification 
 ---
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6712963e231e7ab50a3d11b8a8c75e54e0c79b32

tdf#130857 qt weld: Implement QtInstanceDialog::{g,s}et_modal

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 130857] Qt5 implement theming using native widgets (weld)

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130857

--- Comment #12 from Commit Notification 
 ---
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9e40fc8c9458b937200ea56c96b89113c74b67f5

tdf#130857 qt weld: Set msg dialog parent

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 130857] Qt5 implement theming using native widgets (weld)

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130857

--- Comment #10 from Commit Notification 
 ---
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/092bcd7133c30c0614056928a16baea44704735e

tdf#130857 qt weld: Move QWidget* member to QtInstanceWidget

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: vcl/qt5

2024-02-14 Thread Michael Weghorn (via logerrit)

 vcl/qt5/QtInstance.cxx |   16 +++-
 1 file changed, 15 insertions(+), 1 deletion(-)

New commits:
commit 9e40fc8c9458b937200ea56c96b89113c74b67f5
Author: Michael Weghorn 
AuthorDate: Wed Feb 14 10:54:59 2024 +0100
Commit: Michael Weghorn 
CommitDate: Thu Feb 15 08:08:05 2024 +0100

tdf#130857 qt weld: Set msg dialog parent

If a parent is passed to `QtInstance::CreateMessageDialog`,
also set a parent for the `QMessageBox` that gets created
there:

If the passed parent is a native Qt one, use that one.
Otherwise, fall back to using the current active top-level
window, which is what usually makes most sense and is better
than having no parent at all.

With this change in place, the message dialog shown
when doing

1) start Writer
2) "File" -> "Properties" -> "Security" -> "Protect"
3) type 2 different passwords and confirm

is now modal and centered on top of the "Enter Password"
dialog on KDE Plasma Wayland when using the qt6 VCL plugin,
while it used to open at the top left of the screen and was
non-modal before.

The new behavior is in line with how it behaves for the
SAL_VCL_QT_NO_WELDED_WIDGETS=1 case.

Change-Id: Ibe95c2f0407edeba0fd9f76744bc087be7df6437
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163362
Tested-by: Jenkins
Reviewed-by: Omkar Acharekar  
Reviewed-by: Michael Weghorn 

diff --git a/vcl/qt5/QtInstance.cxx b/vcl/qt5/QtInstance.cxx
index f2f8caa6b86a..6b3bd0cc301a 100644
--- a/vcl/qt5/QtInstance.cxx
+++ b/vcl/qt5/QtInstance.cxx
@@ -792,7 +792,21 @@ weld::MessageDialog* 
QtInstance::CreateMessageDialog(weld::Widget* pParent,
 }
 else
 {
-QMessageBox* pMessageBox = new QMessageBox();
+QWidget* pQtParent = nullptr;
+if (pParent)
+{
+if (QtInstanceWidget* pQtInstanceWidget = 
dynamic_cast(pParent))
+{
+pQtParent = pQtInstanceWidget->getQWidget();
+}
+else
+{
+// the parent is not welded/not a native Qt widget; fall back 
to currently active window
+pQtParent = QApplication::activeWindow();
+}
+}
+
+QMessageBox* pMessageBox = new QMessageBox(pQtParent);
 pMessageBox->setText(toQString(rPrimaryMessage));
 pMessageBox->setIcon(vclMessageTypeToQtIcon(eMessageType));
 pMessageBox->setWindowTitle(vclMessageTypeToQtTitle(eMessageType));

core.git: 2 commits - vcl/inc vcl/qt5

2024-02-14 Thread Michael Weghorn (via logerrit)

 vcl/inc/qt5/QtInstanceContainer.hxx |2 ++
 vcl/inc/qt5/QtInstanceDialog.hxx|2 +-
 vcl/inc/qt5/QtInstanceWidget.hxx|6 ++
 vcl/inc/qt5/QtInstanceWindow.hxx|2 --
 vcl/qt5/QtInstanceContainer.cxx |5 +
 vcl/qt5/QtInstanceDialog.cxx|4 ++--
 vcl/qt5/QtInstanceWidget.cxx|6 ++
 vcl/qt5/QtInstanceWindow.cxx|7 +++
 8 files changed, 25 insertions(+), 9 deletions(-)

New commits:
commit 6712963e231e7ab50a3d11b8a8c75e54e0c79b32
Author: Michael Weghorn 
AuthorDate: Wed Feb 14 10:54:00 2024 +0100
Commit: Michael Weghorn 
CommitDate: Thu Feb 15 08:07:42 2024 +0100

tdf#130857 qt weld: Implement QtInstanceDialog::{g,s}et_modal

Change-Id: I975d10ccc73c79b34da733411097a7970c8bf916
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163361
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/vcl/inc/qt5/QtInstanceDialog.hxx b/vcl/inc/qt5/QtInstanceDialog.hxx
index 04b45d57a31f..303206be7194 100644
--- a/vcl/inc/qt5/QtInstanceDialog.hxx
+++ b/vcl/inc/qt5/QtInstanceDialog.hxx
@@ -37,7 +37,7 @@ public:
 
 virtual void add_button(const OUString&, int, const OUString& rHelpId = 
{}) override;
 
-virtual void set_modal(bool) override;
+virtual void set_modal(bool bModal) override;
 
 virtual bool get_modal() const override;
 
diff --git a/vcl/qt5/QtInstanceDialog.cxx b/vcl/qt5/QtInstanceDialog.cxx
index e65e4b749e13..cdd75cd9675f 100644
--- a/vcl/qt5/QtInstanceDialog.cxx
+++ b/vcl/qt5/QtInstanceDialog.cxx
@@ -41,9 +41,9 @@ void QtInstanceDialog::response(int) {}
 
 void QtInstanceDialog::add_button(const OUString&, int, const OUString&) {}
 
-void QtInstanceDialog::set_modal(bool) {}
+void QtInstanceDialog::set_modal(bool bModal) { m_pDialog->setModal(bModal); }
 
-bool QtInstanceDialog::get_modal() const { return true; }
+bool QtInstanceDialog::get_modal() const { return m_pDialog->isModal(); }
 
 weld::Button* QtInstanceDialog::weld_widget_for_response(int) { return 
nullptr; }
 
commit 092bcd7133c30c0614056928a16baea44704735e
Author: Michael Weghorn 
AuthorDate: Wed Feb 14 10:32:11 2024 +0100
Commit: Michael Weghorn 
CommitDate: Thu Feb 15 08:07:33 2024 +0100

tdf#130857 qt weld: Move QWidget* member to QtInstanceWidget

Move the `m_pWidget` member from `QtInstanceWindow`
to the base class `QtInstanceWidget` and add a getter
for it.

This allows to get the `QWidget` directly from the
base class, which will be used in an upcoming commit.

Change-Id: I9c41b48936e5a6051afb9721dae2fac5add22e4b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163360
Tested-by: Jenkins
Reviewed-by: Omkar Acharekar  
Reviewed-by: Michael Weghorn 

diff --git a/vcl/inc/qt5/QtInstanceContainer.hxx 
b/vcl/inc/qt5/QtInstanceContainer.hxx
index 87a89c48bd46..a0cd31869dc6 100644
--- a/vcl/inc/qt5/QtInstanceContainer.hxx
+++ b/vcl/inc/qt5/QtInstanceContainer.hxx
@@ -14,6 +14,8 @@
 class QtInstanceContainer : public QtInstanceWidget, public virtual 
weld::Container
 {
 public:
+QtInstanceContainer(QWidget* pWidget);
+
 virtual void move(weld::Widget*, weld::Container*) override;
 
 virtual css::uno::Reference CreateChildFrame() override;
diff --git a/vcl/inc/qt5/QtInstanceWidget.hxx b/vcl/inc/qt5/QtInstanceWidget.hxx
index ee0c5b8c451d..f5038ee5ad66 100644
--- a/vcl/inc/qt5/QtInstanceWidget.hxx
+++ b/vcl/inc/qt5/QtInstanceWidget.hxx
@@ -21,7 +21,13 @@
 
 class QtInstanceWidget : public virtual weld::Widget
 {
+QWidget* m_pWidget;
+
 public:
+QtInstanceWidget(QWidget* pWidget);
+
+QWidget* getQWidget() const { return m_pWidget; }
+
 virtual void set_sensitive(bool) override;
 
 virtual bool get_sensitive() const override;
diff --git a/vcl/inc/qt5/QtInstanceWindow.hxx b/vcl/inc/qt5/QtInstanceWindow.hxx
index c29863da4f67..db80a6e71458 100644
--- a/vcl/inc/qt5/QtInstanceWindow.hxx
+++ b/vcl/inc/qt5/QtInstanceWindow.hxx
@@ -13,8 +13,6 @@
 
 class QtInstanceWindow : public QtInstanceContainer, public virtual 
weld::Window
 {
-QWidget* m_pWidget;
-
 public:
 QtInstanceWindow(QWidget* pWidget);
 
diff --git a/vcl/qt5/QtInstanceContainer.cxx b/vcl/qt5/QtInstanceContainer.cxx
index e22b1afb2a55..35f0a4bbaa69 100644
--- a/vcl/qt5/QtInstanceContainer.cxx
+++ b/vcl/qt5/QtInstanceContainer.cxx
@@ -9,6 +9,11 @@
 
 #include 
 
+QtInstanceContainer::QtInstanceContainer(QWidget* pWidget)
+: QtInstanceWidget(pWidget)
+{
+}
+
 void QtInstanceContainer::move(weld::Widget*, weld::Container*) {}
 
 css::uno::Reference QtInstanceContainer::CreateChildFrame()
diff --git a/vcl/qt5/QtInstanceWidget.cxx b/vcl/qt5/QtInstanceWidget.cxx
index cbccac8799db..9c17ebe6cb1d 100644
--- a/vcl/qt5/QtInstanceWidget.cxx
+++ b/vcl/qt5/QtInstanceWidget.cxx
@@ -9,6 +9,12 @@
 
 #include 
 
+QtInstanceWidget::QtInstanceWidget(QWidget* pWidget)
+: m_pWidget(pWidget)
+{
+assert(pWidget);
+}
+
 void QtInstanceWidget::set_sensitive(bool) {}

[Bug 159728] New: picture cannot be resized if overlaps the footer

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159728

Bug ID: 159728
   Summary: picture cannot be resized if overlaps the footer
   Product: LibreOffice
   Version: 24.2.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: lmiro...@yandex.ru

Created attachment 192573
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192573=edit
testcase

Under certain conditions, which I cannot completely define but involve a
picture overlapping page footer, this picture cannot be resized. Consider the
attached document: it is a blank new document with a picture pasted into it and
nothing else. Click on the picture and then click and drag its right bottom
corner to resize - it doesn't work and page footer is selected. Top corner and
side resize anchors work fine, the issue is only with bottom corners.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159714] Pasting an image over an existing image in Writer may change its aspect ratio

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159714

lvm  changed:

   What|Removed |Added

Summary|Pasting an image over an|Pasting an image over an
   |existing image in Writer|existing image in Writer
   |does not update image size  |may change its aspect ratio

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159512] LibreOffice Calc ODS files saved with passwords under 7.6.4 (X86_64) cannot be opened in 24.2.0.3 (X86_64) (Windows 7)

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159512

Buovjaga  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #19 from Buovjaga  ---
NEW per dupe (waiting for info about Win version).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159727] LibreOffice_24.2.0_Win_x86-64.msi: saving the file with a password absolutely does not work!

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159727

Buovjaga  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED
 CC||ilmari.lauhakangas@libreoff
   ||ice.org

--- Comment #1 from Buovjaga  ---
There is already bug 159512 about this. Are you using Windows 7 or...?

*** This bug has been marked as a duplicate of bug 159512 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159512] LibreOffice Calc ODS files saved with passwords under 7.6.4 (X86_64) cannot be opened in 24.2.0.3 (X86_64) (Windows 7)

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159512

Buovjaga  changed:

   What|Removed |Added

 CC||imregep.sz...@gmail.com

--- Comment #18 from Buovjaga  ---
*** Bug 159727 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159714] Pasting an image over an existing image in Writer does not update image size

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159714

--- Comment #7 from lvm  ---
(In reply to Telesto from comment #6)
> Requested here: overwrite the current one for the new one. I have tendency
> to prefer overwrite above, replace as normal expectation. 
To make myself clear, I am not requesting to change dimensions to that of the
new image. I propose to scale the new image to fit the same space but retain
its aspect ratio while doing so. Of course it may create some unallocated space
which will require one of the dimensions to be shrunk, but no more than
necessary.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 134526] Update Firebird to latest upstream version

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=134526

Aron Budea  changed:

   What|Removed |Added

 CC||aron.bu...@gmail.com
 Whiteboard|target:24.8.0   |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159411] Sluggish display of letters when entering text when using LO Writer

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159411

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159464] Short text in sections combined with long endnotes makes parts of text hidden under red arrow

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159464

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159463] Changing which list style a paragraph style is associated with does not affect existing lists

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159463

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159486] Infobars' close (X) buttons' invisible hitboxes too small and hard to click

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159486

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159482] Editing and saving a docx file exported from memsource breaks it, preventing its import

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159482

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159477] There should be a way to insert blank spaces instead of "\t" in the Basic IDE when Tab is pressed

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159477

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159471] Make PDF CLI Parameters help page's examples use Writer's and Calc's filters

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159471

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159475] chart: missing style properties on custom label

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159475

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159462] chart: best fit algorithm should be able to "shrink" text width to fit into "vertical" slices

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159462

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159473] CXmail/PDFPh-C on exported PDFs

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159473

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 156148] Unattended Windows command line convert (headless) has inconsistant results

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=156148

--- Comment #3 from QA Administrators  ---
Dear michael,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 156586] Mailing Labels, navigation & inserting of columns

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=156586

--- Comment #2 from QA Administrators  ---
Dear forum-subs,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159311] Use xdg-desktop portals instead of static filesystem permissions

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159311

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 51430] FILEOPEN: HTML documents without META Content-Type are opened with a wrong codepage

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=51430

--- Comment #14 from QA Administrators  ---
Dear pcarmouze,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 105674] Calc will give a non-clickable error box when adding a gallery item which isn't accessible anymore

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105674

--- Comment #5 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 104983] Dragging on Slides sidebar vertically on a Windows touchscreen moving a page instead of scrolling

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104983

--- Comment #5 from QA Administrators  ---
Dear Volga,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 33680] THIRDPARTYLICENSEREADME.html / LICENSE.odt

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=33680

--- Comment #3 from measrasy  ---
Well, it seems that only PPC user might have errors with langpack_zh-TW
installation.

Can someone investigate into this problem?

pm: https://drift-boss.io

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 116736] Add morph transition like Microsoft has to impress.

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=116736

--- Comment #12 from ayman20...@gmail.com ---
I hope to add a morph feature in the next version of impress

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159678] heading fields in headers and footers do not track heading content through the document

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159678

Baole Fang  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |baole.f...@gmail.com
   |desktop.org |
 Status|NEW |ASSIGNED

--- Comment #3 from Baole Fang  ---
Sorry, start fixing it now.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159727] New: LibreOffice_24.2.0_Win_x86-64.msi: saving the file with a password absolutely does not work!

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159727

Bug ID: 159727
   Summary: LibreOffice_24.2.0_Win_x86-64.msi: saving the file
with a password absolutely does not work!
   Product: LibreOffice
   Version: 24.2.0.2 rc
  Hardware: IA64 (Itanium)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: imregep.sz...@gmail.com

Description:
Files saved with the "save with password" function in the previous LibreOffice
writer cannot be opened, because the new version detects the password as
incorrect and does not allow the file to be opened. At the same time, in
version 24.0.2, .odt files saved with "save password" are opened without asking
for a password! I had to revert to the previous version of LibreOffice!

Steps to Reproduce:
1.See Description
2.
3.

Actual Results:
See Description

Expected Results:
See Description


Reproducible: Always


User Profile Reset: Yes

Additional Info:
See Description

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159726] Copying two list styles in Impress resets target list style to none

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159726

--- Comment #2 from Gabor Kelemen (allotropia)  ---
Created attachment 192572
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192572=edit
Target formatting getting reset after copying

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159726] Copying two list styles in Impress resets target list style to none

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159726

--- Comment #1 from Gabor Kelemen (allotropia)  ---
Created attachment 192571
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192571=edit
Formatting before copying

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159726] New: Copying two list styles in Impress resets target list style to none

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159726

Bug ID: 159726
   Summary: Copying two list styles in Impress resets target list
style to none
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kelem...@ubuntu.com
Blocks: 102593

Created attachment 192570
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192570=edit
Example file from Impress

Attached example file contains two slides with example text.
Copying one paragraphs list formatting with the format paintbrush to the second
slide works (after commit bbe1f37645cf864c7c974d36cf2fe3a73d0c085f), but
copying two resets the target to have no list formatting at all.

1. Open attached file
2. From the first slide select the Def paragraph, click on the format
paintbrush
3. Copy the formatting to the second slides first paragraph 
-> it gets the Roman numbering
4. From the first slide select the Def and the Ghi paragraphs, click on the
format paintbrush
5. Copy the formatting to the second slides second and third paragraphs
-> their bullet/numbering gets turned off

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 3d3242ef3a6f111d6220c60d5c1b968c7f46fc5f
CPU threads: 15; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: default

and in 3.3, this never worked before.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102593
[Bug 102593] [META] Paste bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 102593] [META] Paste bugs and enhancements

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102593

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Depends on||159726


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=159726
[Bug 159726] Copying two list styles in Impress resets target list style to
none
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 108976] Crash in: OutputDevice::GetOutputSizePixel()

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108976

--- Comment #12 from Matt K  ---
No repro with:

Version: 7.6.5.0.0+ (X86_64) / LibreOffice Community
Build ID: 13c748e7998b6df02e23815f337e9ab4d04172f3
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

I did not even get a macro pop-up warning.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 95385] Sidebar : category General does not exist and inconsistent with cell formatting dialog (see comment 7, comment 8, comment 21)

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=95385

Amos Aidoo  changed:

   What|Removed |Added

   Assignee|aidooamo...@gmail.com   |libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 103427] [META] Styles and Formatting sidebar deck and floating window

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103427

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||159724


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=159724
[Bug 159724] The "No Character Style" list entry should always be offered in
the SB "Character Styles" content panel, even if only the "Applied Styles" is
the selected UI mode
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159724] The "No Character Style" list entry should always be offered in the SB "Character Styles" content panel, even if only the "Applied Styles" is the selected UI mode

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159724

V Stuart Foote  changed:

   What|Removed |Added

Summary|UI: No special character|The "No Character Style"
   |style should always be the  |list entry should always be
   |topmost offer even if only  |offered in the SB
   |applied character styles is |"Character Styles" content
   |selected|panel, even if only the
   ||"Applied Styles" is the
   ||selected UI mode
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||vsfo...@libreoffice.org
   Keywords||needsUXEval
 Blocks||103427

--- Comment #1 from V Stuart Foote  ---
+1

As corollary to the 'Default Paragraph Style' for paragraphs, agree always
exposing the 'No Character Style' on the the 'Character Styles' content panel
of  Styles SB deck  would be better UX.

Any reason we couldn't?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103427
[Bug 103427] [META] Styles and Formatting sidebar deck and floating window
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159724] The "No Character Style" list entry should always be offered in the SB "Character Styles" content panel, even if only the "Applied Styles" is the selected UI mode

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159724

V Stuart Foote  changed:

   What|Removed |Added

Summary|UI: No special character|The "No Character Style"
   |style should always be the  |list entry should always be
   |topmost offer even if only  |offered in the SB
   |applied character styles is |"Character Styles" content
   |selected|panel, even if only the
   ||"Applied Styles" is the
   ||selected UI mode
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||vsfo...@libreoffice.org
   Keywords||needsUXEval
 Blocks||103427

--- Comment #1 from V Stuart Foote  ---
+1

As corollary to the 'Default Paragraph Style' for paragraphs, agree always
exposing the 'No Character Style' on the the 'Character Styles' content panel
of  Styles SB deck  would be better UX.

Any reason we couldn't?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103427
[Bug 103427] [META] Styles and Formatting sidebar deck and floating window
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 80430] [META] Documentation gap for new features

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=80430

Olivier Hallot  changed:

   What|Removed |Added

 Depends on||159725


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=159725
[Bug 159725] [LOCALHELP] Add description for VBA function ExportAsFixedFormat
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159725] New: [LOCALHELP] Add description for VBA function ExportAsFixedFormat

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159725

Bug ID: 159725
   Summary: [LOCALHELP] Add description for VBA function
ExportAsFixedFormat
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: BASIC
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: olivier.hal...@libreoffice.org
Blocks: 80430

Per feature in 7.6 :

https://wiki.documentfoundation.org/ReleaseNotes/7.6#VBA_Support

Write help page for the function above mentioned.

Pointers in Help:

https://help.libreoffice.org/master/en-US/text/sbasic/shared/special_vba_func.html?DbPAR=BASIC


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=80430
[Bug 80430] [META] Documentation gap for new features
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 152680] Can't open the special pdf file

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=152680

--- Comment #5 from Dave Gilbert  ---
Created attachment 192569
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192569=edit
Current state 2024-02-14

My fix for 113050 is getting there, and is actually looking better on this one
so far.  This looks correct to me except the hashing is flipped.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 38164] Allow scrolling through Slides by Mouse wheel

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=38164

--- Comment #14 from Tex2002ans  ---
(In reply to Eyal Rozenberg from comment #12)
> I will make a potential alternative suggestion though; [...] Mousewheel 
> scrolls slides for zoom levels where the entire slide is in view, and scrolls 
> the viewport on higher zoom levels.

Yep. Full agree there.

That's how it works in SumatraPDF (and many other PDF readers), and it works
great:

- If entire page/slide fits on screen...
   - Mouse wheel jumps to previous/next page.
- If entire page/slide doesn't fit on screen...
   - Mouse wheel moves and scrolls the slide up/down.

- - - - - -

I just tested Powerpoint 365 (2401, Build 17231.20194), and it:

- Does the above.

AND when it's zoomed in + reaches near the bottom of slide 1:

- Loads/Scrolls seamlessly into the next slide.
   - So it looks like it's one long page with a dashed line between slides 1+2.

That, also, seems like a fantastic solution/workflow.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159724] UI: No special character style should always be the topmost offer even if only applied character styles is selected

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159724

Adalbert Hanßen  changed:

   What|Removed |Added

Summary|No special character style  |UI: No special character
   |should always be the|style should always be the
   |topmost offer even if only  |topmost offer even if only
   |applied character styles is |applied character styles is
   |selected|selected

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159724] New: No special character style should always be the topmost offer even if only applied character styles is selected

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159724

Bug ID: 159724
   Summary: No special character style should always be the
topmost offer even if only applied character styles is
selected
   Product: LibreOffice
   Version: 24.2.0.1 rc
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: adalbert.hans...@gmx.de

This problem arises in LibreOfficeWriter

Version: 24.2.2.0.0+ (X86_64) / LibreOffice Community
Build ID: 46169670ef4031888e143823b263577296d7867f
CPU threads: 4; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Calc: threaded

But I also encountered it in older versions. (sorry, 24.2.2.0.0 was not offered
in the bug report drop-down list, I selected another one close to that). 

Below the F11-function to select character styles, one can select categories,
e.g. All Styles, All User defined ones or all Applied Styles shall be displayed
for the choice to be taken from.

Of course, Applied Character Styles is the most used one, since one should stay
with a few carefully chosen character styles only, almost all formatting should
be done by the paragraph styles (and direct formatting should be avoided at
all).

In general No Character Style happens "almost everywhere" in a properly
formatted document with a few exceptions only, since in the first place the
styles from the paragraph styles should be used "almost everywhere".

If one wants to revert an improperly applied character style, unfortunately "No
Character Style" is not offered, when "Applied styles" are selected.

This is very cumbersome since one has to temporarily change what shall be
offered - and "No Character Style should" always be offered in the selection,
no matter what else the selection is restricted to (even in "User defined
Styles" is the restriction: despite the fact that "No Character Style"
definitely is not a user defined style).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159723] New: UI: Some of the shortcuts Ctl-0 … Ctl-9 don’t work reliably any more

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159723

Bug ID: 159723
   Summary: UI: Some of the shortcuts Ctl-0 … Ctl-9 don’t work
reliably any more
   Product: LibreOffice
   Version: 24.2.0.2 rc
  Hardware: x86-64 (AMD64)
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: adalbert.hans...@gmx.de

This problem arises in 

Version: 24.2.2.0.0+ (X86_64) / LibreOffice Community
Build ID: 46169670ef4031888e143823b263577296d7867f
CPU threads: 4; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Calc: threaded

It comes quite handy to use the shortcuts Ctl-0 (Text body), Ctl-1 (Heading 1st
order), Ctl-2 (Heading 2nd order) and so on when using LO Writer.
Some of them don’t work any longer as they did in previous versions. Some of
then still work.

(Perhaps this is another yet unreported part of the problem reported in
https://bugs.documentfoundation.org/show_bug.cgi?id=159709).

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: solenv/bin vcl/commonfuzzer.mk

2024-02-14 Thread Caolán McNamara (via logerrit)

 solenv/bin/native-code.py |2 +-
 vcl/commonfuzzer.mk   |1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 43d962c27b6efb04d22b05ad8dec08f6056078a0
Author: Caolán McNamara 
AuthorDate: Wed Feb 14 15:21:52 2024 +
Commit: Caolán McNamara 
CommitDate: Wed Feb 14 22:12:17 2024 +0100

ofz: don't need "bib" for fuzzing

Change-Id: Ie471593779bd44382ebc83355aef0c1fae87ae92
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163380
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/solenv/bin/native-code.py b/solenv/bin/native-code.py
index 955317ebc0ca..d14db957e3c9 100755
--- a/solenv/bin/native-code.py
+++ b/solenv/bin/native-code.py
@@ -144,7 +144,7 @@ core_constructor_list = [
 ("com_sun_star_comp_extensions_PlainTextFormatter", "#ifdef ANDROID"),
 ("com_sun_star_comp_extensions_SimpleTextFormatter", "#ifdef ANDROID"),
 # extensions/source/bibliography/bib.component
-"extensions_BibliographyLoader_get_implementation",
+("extensions_BibliographyLoader_get_implementation", "#if 
!ENABLE_FUZZERS"),
 # filter/source/config/cache/filterconfig1.component
 "filter_ConfigFlush_get_implementation",
 "filter_TypeDetection_get_implementation",
diff --git a/vcl/commonfuzzer.mk b/vcl/commonfuzzer.mk
index cca33194e9bc..dc967773df91 100644
--- a/vcl/commonfuzzer.mk
+++ b/vcl/commonfuzzer.mk
@@ -57,7 +57,6 @@ fuzzer_core_libraries = \
 basctl \
 basprov \
 ) \
-bib \
 canvastools \
 configmgr \
 cppcanvas \

[Bug 159722] New: UI: Sometimes strange behavior when you want to place a hyperlink to position in the same document

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159722

Bug ID: 159722
   Summary: UI: Sometimes strange behavior when you want to place
a hyperlink to position in the same document
   Product: LibreOffice
   Version: 24.2.0.0 beta1+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: adalbert.hans...@gmx.de

Created attachment 192568
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192568=edit
Bug report with screenshots

This problem arises in 

Version: 24.2.2.0.0+ (X86_64) / LibreOffice Community
Build ID: 46169670ef4031888e143823b263577296d7867f
CPU threads: 4; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Calc: threaded

In my notebook documents, I often use Hyperlinks to other similar topics, many
times in the same document. They look example like this: here I also deal with
topic 1, topic 2 and topic 3. They are all under this headline.
The keywords “topic x” are provided with bookmarks and I want to refer to them
as well as to the headline.

1.) While I am doing so accidentally another hyperlink is on the clipboard and
this one is first fed into the first entry “Pfad” of the dialog.

2.) Then have to remove the automatic target for the path from the dialog, e.g.
by first selecting everything in this field and then deleting it.

3.) But when I click on Dokument in order to select the bookmark with its
proper selection item, it sometimes happens, that the just deleted URL
reappears. It looks like that this reproducibly happens, if on the last usage
of associating hyperlinks, the last one was an Internet Link, i.e. if the left
uppermost button Internet is highlighted by a blue bar. . But as soon, as I
click on the button, I am back to where I started! 

By clicking on the button Document, the path in the field above re-appears,
which just had been deleted!

4.) If you start over again from this point by first leaving the whole dialog
and reopening it, the next time the blue bar is at Dokument and now one can
select the hyperlink in the same document by clicking to the button with the
mouse pointer in the screenshot in order to open the dialog Hyperelink. 

Further steps (three additional) to be taken until a hyperlink is successfully
inserted see attached document with screenshots.

If I count right, 7 steps have to be taken to associate a hyperlink to some
text tag. It might be done with fewer steps. But the endless loop (unless you
leave the dialog) in step 3 is definitely a bug. It is merely a question of
good UI design, if it could not be done with fewer steps and less nested dialog
windows.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: sw/inc sw/qa sw/source

2024-02-14 Thread Mike Kaganski (via logerrit)

 sw/inc/crsrsh.hxx |2 
 sw/inc/node.hxx   |2 
 sw/qa/extras/layout/data/largeTopMarginAndHiddenFirstSection.fodt |   15 +
 sw/qa/extras/layout/data/pageBreakInHiddenSection.fodt|   90 
+++
 sw/qa/extras/layout/layout3.cxx   |   68 -
 sw/qa/extras/uiwriter/data/hiddenSectionsAroundPageBreak.fodt |   21 +
 sw/qa/extras/uiwriter/uiwriter9.cxx   |   16 +
 sw/source/core/crsr/crsrsh.cxx|   12 -
 sw/source/core/crsr/pam.cxx   |5 
 sw/source/core/doc/docedt.cxx |4 
 sw/source/core/docnode/ndsect.cxx |4 
 sw/source/core/docnode/nodes.cxx  |6 
 sw/source/core/docnode/section.cxx|7 
 sw/source/core/edit/editsh.cxx|2 
 sw/source/core/inc/frame.hxx  |2 
 sw/source/core/inc/sectfrm.hxx|2 
 sw/source/core/inc/txtfrm.hxx |2 
 sw/source/core/layout/calcmove.cxx|   13 -
 sw/source/core/layout/findfrm.cxx |8 
 sw/source/core/layout/flowfrm.cxx |  119 
--
 sw/source/core/layout/frmtool.cxx |   23 -
 sw/source/core/layout/ftnfrm.cxx  |   10 
 sw/source/core/layout/pagechg.cxx |5 
 sw/source/core/layout/sectfrm.cxx |   37 +++
 sw/source/core/layout/tabfrm.cxx  |6 
 sw/source/core/layout/trvlfrm.cxx |   25 +-
 sw/source/core/text/txtfrm.cxx|   19 -
 27 files changed, 362 insertions(+), 163 deletions(-)

New commits:
commit 0c96119895b347f8eb5bb89f393351bd3c02b9f1
Author: Mike Kaganski 
AuthorDate: Fri Feb 9 11:56:19 2024 +0600
Commit: Mike Kaganski 
CommitDate: Wed Feb 14 21:54:55 2024 +0100

tdf#159565 prerequisite: make hidden sections have zero-height frames

As mentioned in commit bb733957dd39e6f0b9d80bb59eb0177188794797 (tdf#114973
sw: enable SelectAll with hidden para at start/end, 2023-01-27), the hidden
sections didn't have frames. That prevented correct handling of the case
when such a frame was in the beginning of the document.

This change re-implements the hidden section to use 0-height frames, like
hidden paragraphs, as a pre-requisite for a follow-up change.

Some layout breakages noticed while working on this are unit-tested now.

This change needed to handle the case when the first section is hidden, and
then goes a page break with page style. In this case, the page style must
apply to the very first page of the document. Implementing this now, when
the frame that defines the page style is not the first in the document, I
accidentally fixed also the previously broken case when the first paragraph
was hidden. Now the page style defined in the second paragraph's page break
will apply correctly.

This change makes hidden sections break outer section's frames. This means
that when text borders are shown, there will be an artifact in the place of
the hidden sections (a horizontal line breaking outer frame). I suppose
it's not a problem, actually helping to see the layout better, so in line
with the "show text borders" helper functionality. If this proves to be
problematic, this can be handled specially in a follow-up.

Change-Id: I14ebf0559b463186aba28902cd10c5cc978ba456
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163151
Tested-by: Mike Kaganski 
Reviewed-by: Mike Kaganski 

diff --git a/sw/inc/crsrsh.hxx b/sw/inc/crsrsh.hxx
index 5823a49a1599..eafc6a0c31e4 100644
--- a/sw/inc/crsrsh.hxx
+++ b/sw/inc/crsrsh.hxx
@@ -267,7 +267,7 @@ private:
 SAL_DLLPRIVATE bool LRMargin( bool, bool bAPI = false );
 SAL_DLLPRIVATE bool IsAtLRMargin( bool, bool bAPI = false ) const;
 
-SAL_DLLPRIVATE bool isInHiddenTextFrame(SwShellCursor* pShellCursor);
+SAL_DLLPRIVATE bool isInHiddenFrame(SwShellCursor* pShellCursor);
 
 SAL_DLLPRIVATE bool GoStartWordImpl();
 SAL_DLLPRIVATE bool GoEndWordImpl();
diff --git a/sw/inc/node.hxx b/sw/inc/node.hxx
index de7e24a0b152..b1e3309d596f 100644
--- a/sw/inc/node.hxx
+++ b/sw/inc/node.hxx
@@ -590,7 +590,7 @@ public:
 const SwSection& GetSection() const { return *m_pSection; }
   SwSection& GetSection()   { return *m_pSection; }
 
-SwFrame *MakeFrame( SwFrame* );
+SwFrame* MakeFrame(SwFrame* pSib, bool bHidden);

[Bug 159464] Short text in sections combined with long endnotes makes parts of text hidden under red arrow

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159464

Dieter  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #2 from Dieter  ---
I've tested with

Version: 24.2.0.2 (X86_64) / LibreOffice Community
Build ID: b1fd3a6f0759c6f806568e15c957f97194bbec8f
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL threaded

but I can't see anything strange. Could you please specify, what text is
missing?
=> NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159463] Changing which list style a paragraph style is associated with does not affect existing lists

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159463

Dieter  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||dgp-m...@gmx.de
 Ever confirmed|0   |1

--- Comment #1 from Dieter  ---
I can't confirm it with

Version: 24.2.0.2 (X86_64) / LibreOffice Community
Build ID: b1fd3a6f0759c6f806568e15c957f97194bbec8f
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL threaded

Bintero, I have two questions:
1. Is option "automatic update from document" selected in organizer tab of
paragraph style
2. Which version of LO do you use. Please test with actual version.

=> NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: bin/find-mergedlib-can-be-private.classes.results

2024-02-14 Thread Noel Grandin (via logerrit)

 bin/find-mergedlib-can-be-private.classes.results |9 +++--
 1 file changed, 7 insertions(+), 2 deletions(-)

New commits:
commit 3a0807b08f0254e89d361322bce1ef13df3427f2
Author: Noel Grandin 
AuthorDate: Wed Feb 14 09:50:22 2024 +0200
Commit: Noel Grandin 
CommitDate: Wed Feb 14 21:42:54 2024 +0100

update find-mergedlib-can-be-private results file

so that in future I know that these are false positives

Change-Id: Ic52b591f51f28e8f656465417da1d0714450094c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163367
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/bin/find-mergedlib-can-be-private.classes.results 
b/bin/find-mergedlib-can-be-private.classes.results
index c1c6acacb493..f8d8d501489f 100644
--- a/bin/find-mergedlib-can-be-private.classes.results
+++ b/bin/find-mergedlib-can-be-private.classes.results
@@ -14,8 +14,6 @@ DropdownDockingWindow
 E3dCompoundObject
 EditUndo
 EnhancedCustomShape
-ErrCode
-ErrCodeMsg
 FixedBitmap
 FixedImage
 FocusListenerMultiplexer
@@ -38,6 +36,7 @@ MetaPolyPolygonAction
 MetaPolygonAction
 MetaTextArrayAction
 MetaWallpaperAction
+MetricFormatter
 MouseListenerMultiplexer
 MouseMotionListenerMultiplexer
 MyThes
@@ -63,6 +62,7 @@ SvxCharView
 SvxShapeGroupAnyD
 SvxShowText
 SvxTPage
+SvxTextForwarder
 SyntaxHighlighter::Tokenizer
 SystemWindow::ImplData
 TBCExtraInfo
@@ -76,11 +76,14 @@ VclDrawingArea
 VclGrid
 WindowListenerMultiplexer
 basegfx::BColorModifier
+basegfx::SystemDependentData
 basegfx::SystemDependentDataHolder
 basegfx::SystemDependentDataManager
 basic::vba
 canvas
 chart
+comphelper::MemoryInputStream
+comphelper::OSLOutputStreamWrapper
 comphelper::date
 connectivity::sdbcx::IObjectCollection
 connectivity::sdbcx::OGroup
@@ -104,6 +107,7 @@ drawinglayer::primitive3d::SdrPrimitive3D
 formula::FormulaTokenIterator::Item
 legacy::CntInt32
 legacy::SfxBool
+oox::IProgressBar
 oox::drawingml::ShapePropertyInfo
 oox::ole::AxControlModelBase
 sdr::SelectionController
@@ -118,3 +122,4 @@ utl::DefaultFontConfiguration
 utl::detail::Options
 vcl::ExtOutDevData
 vcl::ILibreOfficeKitNotifier
+vcl::PrinterController

[Bug 159411] Sluggish display of letters when entering text when using LO Writer

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159411

Dieter  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|UNCONFIRMED |RESOLVED
 CC||dgp-m...@gmx.de

--- Comment #3 from Dieter  ---
(In reply to Haubenreisser from comment #1)
> Finally I decided to install the latest LO version 7.6.4. I haven't noticed
> any problems here so far.
Good to read. So let's close this bug as RESOLVED WORKSFORME. Feel free to
change it back to UNCONFIRMED, if the bug still appears in this version or a
more recent version.

> My conclusion is that you have to put a lot of effort into finding a Libre
> Office version that runs securely and without errors on your computer. 
No. If you install stable version (actually LO 7.6.4)you have an actual and
most stable version. If you want to use the latest features you should always
install LO fresh (actually LO 24.2). You always find both versions on LO
download page.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159664] Floatable table not visible in after paste in new document but shown in navigator

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159664

Telesto  changed:

   What|Removed |Added

Summary|Table (or frame around  |Floatable table not visible
   |table?) not visible in  |in after paste in new
   |after paste but shown in|document but shown in
   |navigator   |navigator

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159664] Table (or frame around table?) not visible in after paste but shown in navigator

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159664

Telesto  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159714] Pasting an image over an existing image in Writer does not update image size

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159714

Telesto  changed:

   What|Removed |Added

 CC||heiko.tietze@documentfounda
   ||tion.org

--- Comment #6 from Telesto  ---
Also in
Versie: 4.4.7.2 
Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600
Locale: nl_NL

and in
LibreOffice 3.5.7.2 
Build ID: 3215f89-f603614-ab984f2-7348103-1225a5b

The current behaviour is more or less a shortcut for right click context menu
-> replace function. To CTRL+V acts as 'replace' image (so not changing
dimensions).

Requested here: overwrite the current one for the new one. I have tendency to
prefer overwrite above, replace as normal expectation. 

Argument for doing nothing: CTRL+V being used to replace images.. breaking
current workflows.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Minutes from the UX/design meeting 2023-Feb-14

2024-02-14 Thread Heiko Tietze


Present: Sahil, Rafael, Hossein, Heiko
Comments: Stuart, Jean-Francois, Eyal, Stephané, Ady

Tickets/Topics

 * Freeze Zoom as a global LibreOffice preference
   + https://bugs.documentfoundation.org/show_bug.cgi?id=159156
   + assigning +0 to .uno:Zoom100Percent as fixed shortcut (Stuart)
   + though must not touch Ctrl+0 in Writer (Jean-Francois)
   + ignore zoom-in/-out via keyboard or lock zoom (Eyal)
   + could be an option "[ ] No zoom per touch pad" (Rafael)
   => add the option (perhaps macOS only)

 * Comment commands in Calc's menus need to be rearranged
   + https://bugs.documentfoundation.org/show_bug.cgi?id=158653
   + split of comment-related commands is not ideal (Stephané)
 + yet done intentionally for bug 91820
   + not convinced that changing the menus is the best path forward,
 it's basically grouping by action vs object (Ady)
   + other applications go with action-focused menus too (Hossein)
   + no better place for comments than under Sheet (Heiko)
   + when coming from the Notebookbar it feels wrong (Rafael)
   => resolve NAB/WF

 * Dialog Properties bigger then screen
   + https://bugs.documentfoundation.org/show_bug.cgi?id=159409
   + not confirmed, dialog is ~637px in height on win (Stuart)
   + but there is a duplicate report; and report is from gtk3
   + reduce the number of lines for the comments textbox (Hossein)
   + turning the wall of inputs into two columns (Rafael)
 + has the challenge to cover long labels (Heiko)
   + long term solution: add some mechanism to VCL/weld that restricts
 oversized dialogs and automatically adds scrolling (Hossein)
  => do it

 * Page direction not the same as sheet direction
   + https://bugs.documentfoundation.org/show_bug.cgi?id=158601
   + recent bug reports have proven that users do not agree (Ady)
   + if the request is to bind the UI-only setting Sheet > RTL to
 Page Style > Text Direction (the superordinate setting of
 the text direction in cells) the recommendation is to rather
 not do
   + Excel knows a "context" option for the cell direction meaning
 if the entered text is RTL the cell becomes RTL (Hossein)
   + The context option will handle the use case automatically, and
 also handles the situation with bilingual cells (Hossein)
   + problem accepted, solution rejected = WF


OpenPGP_signature.asc
Description: OpenPGP digital signature

Minutes from the UX/design meeting 2023-Feb-14

2024-02-14 Thread Heiko Tietze


Present: Sahil, Rafael, Hossein, Heiko
Comments: Stuart, Jean-Francois, Eyal, Stephané, Ady

Tickets/Topics

 * Freeze Zoom as a global LibreOffice preference
   + https://bugs.documentfoundation.org/show_bug.cgi?id=159156
   + assigning +0 to .uno:Zoom100Percent as fixed shortcut (Stuart)
   + though must not touch Ctrl+0 in Writer (Jean-Francois)
   + ignore zoom-in/-out via keyboard or lock zoom (Eyal)
   + could be an option "[ ] No zoom per touch pad" (Rafael)
   => add the option (perhaps macOS only)

 * Comment commands in Calc's menus need to be rearranged
   + https://bugs.documentfoundation.org/show_bug.cgi?id=158653
   + split of comment-related commands is not ideal (Stephané)
 + yet done intentionally for bug 91820
   + not convinced that changing the menus is the best path forward,
 it's basically grouping by action vs object (Ady)
   + other applications go with action-focused menus too (Hossein)
   + no better place for comments than under Sheet (Heiko)
   + when coming from the Notebookbar it feels wrong (Rafael)
   => resolve NAB/WF

 * Dialog Properties bigger then screen
   + https://bugs.documentfoundation.org/show_bug.cgi?id=159409
   + not confirmed, dialog is ~637px in height on win (Stuart)
   + but there is a duplicate report; and report is from gtk3
   + reduce the number of lines for the comments textbox (Hossein)
   + turning the wall of inputs into two columns (Rafael)
 + has the challenge to cover long labels (Heiko)
   + long term solution: add some mechanism to VCL/weld that restricts
 oversized dialogs and automatically adds scrolling (Hossein)
  => do it

 * Page direction not the same as sheet direction
   + https://bugs.documentfoundation.org/show_bug.cgi?id=158601
   + recent bug reports have proven that users do not agree (Ady)
   + if the request is to bind the UI-only setting Sheet > RTL to
 Page Style > Text Direction (the superordinate setting of
 the text direction in cells) the recommendation is to rather
 not do
   + Excel knows a "context" option for the cell direction meaning
 if the entered text is RTL the cell becomes RTL (Hossein)
   + The context option will handle the use case automatically, and
 also handles the situation with bilingual cells (Hossein)
   + problem accepted, solution rejected = WF


OpenPGP_signature.asc
Description: OpenPGP digital signature

[Bug 159664] Table (or frame around table?) not visible in after paste but shown in navigator

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159664

Rainer Bielefeld Retired  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #5 from Rainer Bielefeld Retired  
---
Additional info:

a) Disabling SKIA seems to have no effect
b) Saving the document after step 6 makes the table reappear
c) original report step 7 is not precise. This  step makes 2 Frames, each
   with a Table in it, reappear
d) I did not reproduce the problem with LibO 7.6

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159664] Table (or frame around table?) not visible in after paste but shown in navigator

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159664

Rainer Bielefeld Retired  changed:

   What|Removed |Added

Summary|Table not visible in after  |Table (or frame around
   |paste but shown in  |table?) not visible in
   |navigator   |after paste but shown in
   ||navigator
 CC||LibreOffice@bielefeldundbus
   ||s.de
 OS|All |Windows (All)

--- Comment #4 from Rainer Bielefeld Retired  
---
REPRODUCIBLE with Server Installation of 
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 125fc2ce861c82592b261f2992c893b414396e56
CPU threads: 12; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded

I wonder whether it really is a problem of the table. Might be a problem with
the frame around the table?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 75280] Convert inappropriate use of sal_uIntPtr to better integer types

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=75280

--- Comment #61 from Devansh Varshney  ---
I tried to look into this and there are 151 files with sal_uIntPtr remain. As
far my understanding goes after looking those I think there are no more of
these changes required. So, maybe we can close this.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: configure.ac

2024-02-14 Thread René Engelhard (via logerrit)

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5111a0b9bf3c36cd01beefbc6e47fd45836877d3
Author: René Engelhard 
AuthorDate: Wed Feb 14 18:21:50 2024 +0100
Commit: René Engelhard 
CommitDate: Wed Feb 14 18:52:58 2024 +0100

Revert "configure: clean up not needed abseil libs for the system-abseil 
case"

This reverts commit 89a0933968e4b9160613707301d1f5dd36d97282.

Reason for revert: we still need absl_inlined_vector, Linking test doesn't 
work, this is header-only but we should check for it being there to be sure

Change-Id: I55b4d645876d7080ee41917413e02cba930c9060
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163349
Tested-by: René Engelhard 
Reviewed-by: René Engelhard 

diff --git a/configure.ac b/configure.ac
index fc0fd16524f3..48b325790b80 100644
--- a/configure.ac
+++ b/configure.ac
@@ -12246,7 +12246,7 @@ if test "$ENABLE_PDFIUM" = "TRUE"; then
 AC_MSG_RESULT([external])
 SYSTEM_ABSEIL=TRUE
 AC_LANG_PUSH([C++])
-PKG_CHECK_MODULES(ABSEIL, absl_bad_variant_access )
+PKG_CHECK_MODULES(ABSEIL, absl_bad_optional_access 
absl_bad_variant_access absl_inlined_vector )
 AC_LANG_POP([C++])
 ABSEIL_CFLAGS=$(printf '%s' "$ABSEIL_CFLAGS" | sed -e 
"s/-I/${ISYSTEM?}/g")
 FilterLibs "${ABSEIL_LIBS}"

[Bug 101313] Copy-paste a Table With Merged Cells from Writer to Calc: Cells Placed in Wrong Position (Wrong cell offsets)

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101313

--- Comment #14 from Kevin Suo  ---
I have doing some debugging and have found the following, but I don't think I
can fix this, so could someone take a look:

The code works for the Writer table like this:
+---+++
|a  |b   |c   |
+---+++
|d   |e   |
+++

But does not work for a Writer table like this:

+---+++
|a  |b   |c   |
+---+---+++
|d  |e  |f   |g   |
+---+---+++

The difference between the two tables is that:

- In the first table, the 2nd row contains the merged cell. The right border
for *each* of the cells ("d" and "e") has a corresponding aligned border in its
top row (i.e. the right border of cells "b" aligns to the right border of cell
"d", and the right border of cell "c" aligns to the right border of cell "e").
In such case, ScRTFParser::SeekTwips successfully finds the "nTwips" through
the following code, for each of the "d" and "e" cells:

ScRTFColTwips::const_iterator it = aColTwips.find( nTwips );
bool bFound = it != aColTwips.end();
sal_uInt16 nPos = it - aColTwips.begin();
*pCol = static_cast(nPos);
if ( bFound )
return true;

-- In the second table, the 1st row contains the merged cell. The right border
of "d" in the 2nd row does not have a corresponding aligned border in the 1st
row (i.e. its top row), thus ScRTFParser::SeekTwips failes to find the "nTwips"
through:

ScRTFColTwips::const_iterator it = aColTwips.find( nTwips );
bool bFound = it != aColTwips.end();
sal_uInt16 nPos = it - aColTwips.begin();
*pCol = static_cast(nPos);

so it goes on to:
SCCOL nCol = *pCol;
// nCol is insertion position; the next one higher up is there (or not)
if ( nCol < static_cast(nCount) && ((aColTwips[nCol] -
SC_RTFTWIPTOL) <= nTwips) )
return true;

*Note* that aColTwips is always the list of right border twips of the cells in
the first row, and is not updated upon the rows that followed. (i.e, for the
2nd table, aColTwips always has 3 elements which are the twips of the first row
cels).

At this moment *pCol is 3 because after the "find" the iterator is at the
aColTwips.end(). the *pCol 3 is then passed to its caller "SeekTwips(
pE->nTwips,  )" in ScRTFParser::ColAdjust(), in which the column count
grows to 6, and the pasted result in Calc becomes:


+---+++
|a  |b   |c   |
+---+-+---+++
|d|e  |f   |g   |
+---+-+---+++

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Changes to 'refs/tags/cp-24.04.0-1'

2024-02-14 Thread Michael Meeks (via logerrit)

Tag 'cp-24.04.0-1' created by Andras Timar  at 
2024-02-14 17:29 +

cp-24.04.0-1

Changes since co-24.04-branch-point-367:
---
 0 files changed
---

translations.git: Changes to 'refs/tags/cp-24.04.0-1'

2024-02-14 Thread Christian Lohmaier (via logerrit)

Tag 'cp-24.04.0-1' created by Andras Timar  at 
2024-02-14 17:29 +

cp-24.04.0-1

Changes since co-24.04-branch-point-5:
---
 0 files changed
---

help.git: Changes to 'refs/tags/cp-24.04.0-1'

2024-02-14 Thread Andras Timar (via logerrit)

Tag 'cp-24.04.0-1' created by Andras Timar  at 
2024-02-14 17:29 +

cp-24.04.0-1

Changes since co-24.04-branch-point-22:
---
 0 files changed
---

dictionaries.git: Changes to 'refs/tags/cp-24.04.0-1'

2024-02-14 Thread Marco A.G.Pinto (via logerrit)

Tag 'cp-24.04.0-1' created by Andras Timar  at 
2024-02-14 17:29 +

cp-24.04.0-1

Changes since co-24.04-branch-point:
Marco A.G.Pinto (1):
  tdf#159164 Update the English dictionaries: GB+ZA+AU+CA+US

---
 en/changelog.txt   |   32 +
 en/description.xml |2 
 en/en_AU.aff   |6 
 en/en_CA.aff   |6 
 en/en_GB.aff   |2 
 en/en_GB.dic   | 1191 +
 en/en_US.aff   |6 
 en/en_ZA.aff   |   56 +-
 en/package-description.txt |   10 
 9 files changed, 869 insertions(+), 442 deletions(-)
---

core.git: Branch 'distro/collabora/co-24.04' - desktop/qa desktop/source include/comphelper include/LibreOfficeKit linguistic/source

2024-02-14 Thread Michael Meeks (via logerrit)

 desktop/qa/desktop_lib/test_desktop_lib.cxx |3 ++-
 desktop/source/lib/init.cxx |   23 +++
 include/LibreOfficeKit/LibreOfficeKit.h |3 +++
 include/LibreOfficeKit/LibreOfficeKit.hxx   |   12 +++-
 include/comphelper/lok.hxx  |8 
 linguistic/source/gciterator.cxx|8 
 linguistic/source/gciterator.hxx|7 ++-
 linguistic/source/lngsvcmgr.cxx |8 
 linguistic/source/lngsvcmgr.hxx |7 ++-
 9 files changed, 75 insertions(+), 4 deletions(-)

New commits:
commit 269a307da6bc4f8f4c759662703e20d4b6860f9a
Author: Michael Meeks 
AuthorDate: Tue Feb 6 18:05:09 2024 +
Commit: Michael Meeks 
CommitDate: Wed Feb 14 18:27:16 2024 +0100

lok: implement a joinThreads function - to wind down thread pools.

Necessary to do this before forking on Unix systems; use a
dynamic_cast interface since this is all for internal use.

Change-Id: I8a911322acd4ec5654eb0d14804c09d513a0bd4b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163210
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Michael Meeks 

diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx 
b/desktop/qa/desktop_lib/test_desktop_lib.cxx
index d9809cf56ce3..c9f276a67eeb 100644
--- a/desktop/qa/desktop_lib/test_desktop_lib.cxx
+++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx
@@ -3593,10 +3593,11 @@ void DesktopLOKTest::testABI()
 CPPUNIT_ASSERT_EQUAL(classOffset(17), offsetof(struct 
_LibreOfficeKitClass, trimMemory));
 CPPUNIT_ASSERT_EQUAL(classOffset(18), offsetof(struct 
_LibreOfficeKitClass, startURP));
 CPPUNIT_ASSERT_EQUAL(classOffset(19), offsetof(struct 
_LibreOfficeKitClass, stopURP));
+CPPUNIT_ASSERT_EQUAL(classOffset(20), offsetof(struct 
_LibreOfficeKitClass, joinThreads));
 
 // When extending LibreOfficeKit with a new function pointer,  add new 
assert for the offsetof the
 // new function pointer and bump this assert for the size of the class.
-CPPUNIT_ASSERT_EQUAL(classOffset(20), sizeof(struct _LibreOfficeKitClass));
+CPPUNIT_ASSERT_EQUAL(classOffset(21), sizeof(struct _LibreOfficeKitClass));
 
 CPPUNIT_ASSERT_EQUAL(documentClassOffset(0), offsetof(struct 
_LibreOfficeKitDocumentClass, destroy));
 CPPUNIT_ASSERT_EQUAL(documentClassOffset(1), offsetof(struct 
_LibreOfficeKitDocumentClass, saveAs));
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 0fd3e62a571c..3b97df3faa1c 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -2581,6 +2581,8 @@ lo_startURP(LibreOfficeKit* pThis, void* 
pReceiveURPFromLOContext, void* pSendUR
 
 static void lo_stopURP(LibreOfficeKit* pThis, void* pSendURPToLOContext);
 
+static int lo_joinThreads(LibreOfficeKit* pThis);
+
 static void lo_runLoop(LibreOfficeKit* pThis,
LibreOfficeKitPollCallback pPollCallback,
LibreOfficeKitWakeCallback pWakeCallback,
@@ -2625,6 +2627,7 @@ LibLibreOffice_Impl::LibLibreOffice_Impl()
 m_pOfficeClass->trimMemory = lo_trimMemory;
 m_pOfficeClass->startURP = lo_startURP;
 m_pOfficeClass->stopURP = lo_stopURP;
+m_pOfficeClass->joinThreads = lo_joinThreads;
 
 gOfficeClass = m_pOfficeClass;
 }
@@ -3357,6 +3360,26 @@ static void lo_stopURP(LibreOfficeKit* /* pThis */,
 
static_cast(pFunctionBasedURPConnection)->close();
 }
 
+
+static int lo_joinThreads(LibreOfficeKit* /* pThis */)
+{
+comphelper::ThreadPool  = 
comphelper::ThreadPool::getSharedOptimalPool();
+pool.joinThreadsIfIdle();
+
+//if (comphelper::getWorkerCount() > 0)
+//return 0;
+
+// Grammar checker thread
+css::uno::Reference xLangSrv =
+css::linguistic2::LinguServiceManager::create(xContext);
+
+auto joinable = dynamic_cast(xLangSrv.get());
+if (joinable && !joinable->joinThreads())
+return 0;
+
+return 1;
+}
+
 static void lo_registerCallback (LibreOfficeKit* pThis,
  LibreOfficeKitCallback pCallback,
  void* pData)
diff --git a/include/LibreOfficeKit/LibreOfficeKit.h 
b/include/LibreOfficeKit/LibreOfficeKit.h
index ed7f4e7f2d28..d924c416eb0b 100644
--- a/include/LibreOfficeKit/LibreOfficeKit.h
+++ b/include/LibreOfficeKit/LibreOfficeKit.h
@@ -140,6 +140,9 @@ struct _LibreOfficeKitClass
 
 /// @see lok::Office::stopURP
 void (*stopURP)(LibreOfficeKit* pThis, void* pSendURPToLOContext);
+
+/// @see lok::Office::joinThreads
+int (*joinThreads)(LibreOfficeKit* pThis);
 };
 
 #define LIBREOFFICEKIT_DOCUMENT_HAS(pDoc,member) 
LIBREOFFICEKIT_HAS_MEMBER(LibreOfficeKitDocumentClass,member,(pDoc)->pClass->nSize)
diff --git a/include/LibreOfficeKit/LibreOfficeKit.hxx 
b/include/LibreOfficeKit/LibreOfficeKit.hxx
index 6f75eb6be5cb..797dd6bca73b 100644
--- a/include/LibreOfficeKit/LibreOfficeKit.hxx
+++

[Bug 159277] It would be nice to have an exclude file type option from Recent Files.

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159277

--- Comment #21 from Ian Eales  ---
(In reply to Rafael Lima from comment #19)
> (In reply to Ian Eales from comment #17)
> > I often have one or more LO file open for several days and load many others
> > [some via automation] during that time - many of which will be intermediary
> > data files [csv;tab;txt...]
> 
> You could use other events such as "Open Document" or "Activate Document" to
> run this macro every time you either open or activate a document. This
> should suffice.

This is then machine specific. I use a desktop and two laptops. I'll never
recover the time I spent in my career fixing bugs introduced by version updates
of Office, Windows, SQL Server, Visual Studio, etc.

Thanks...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159697] BASE, EXTENSIONS, BaseDocumenter error Basic script crashes

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159697

Jean-Pierre Ledure  changed:

   What|Removed |Added

 Ever confirmed|0   |1
   Assignee|libreoffice-b...@lists.free |j...@ledure.be
   |desktop.org |
 Status|UNCONFIRMED |ASSIGNED

--- Comment #4 from Jean-Pierre Ledure  ---
I could reproduce the bug.

To fix it, in the BaseDocumenter Basic library, module BD_Html, replace line
230
If psTargetPage = kTableData Then
by
If sTargetPage = kTableData Then
(i.e. remove the leading "p" in psTargetPage).

Preferably do it manually. I will not post an update of the extension soon.

Note also that, when recompiling that module, an error appears due to a more
strict syntax checking by the Basic compiler since the last 4 years: on line
558 of the same module, add a closing bracket.

Thanks for reporting the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159277] It would be nice to have an exclude file type option from Recent Files.

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159277

--- Comment #20 from Ian Eales  ---
(In reply to V Stuart Foote from comment #18)
> The MRU list is held in the LibreOffice user profile in the XML text file
> 'registrysettings.xcu' simple to edit/filter directly.
> 
> And, some movement to cut the recent document history out of the XCU and
> place into a directory of its own in profile, see also bug 99716  
> And that might open additional means of sorting and pruning the MRU of
> specific file types/content.

I opened 'registrysettings.xcu' in Notepad++ and navigated through a few open
windows < and when I came back, the .xcu had changed, so
editing that in real time does not seem to be a reasonable option.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: configure.ac

2024-02-14 Thread Miklos Vajna (via logerrit)

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 89a0933968e4b9160613707301d1f5dd36d97282
Author: Miklos Vajna 
AuthorDate: Wed Feb 14 15:48:58 2024 +0100
Commit: Miklos Vajna 
CommitDate: Wed Feb 14 18:17:00 2024 +0100

configure: clean up not needed abseil libs for the system-abseil case

Noticed by Rene, found by emptying the list and then adding items back
till the linker succeeded again.

Change-Id: I0b68ad8c50659af2d3a9ff3abfad60990f25bd79
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163378
Tested-by: René Engelhard 
Reviewed-by: René Engelhard 

diff --git a/configure.ac b/configure.ac
index 48b325790b80..fc0fd16524f3 100644
--- a/configure.ac
+++ b/configure.ac
@@ -12246,7 +12246,7 @@ if test "$ENABLE_PDFIUM" = "TRUE"; then
 AC_MSG_RESULT([external])
 SYSTEM_ABSEIL=TRUE
 AC_LANG_PUSH([C++])
-PKG_CHECK_MODULES(ABSEIL, absl_bad_optional_access 
absl_bad_variant_access absl_inlined_vector )
+PKG_CHECK_MODULES(ABSEIL, absl_bad_variant_access )
 AC_LANG_POP([C++])
 ABSEIL_CFLAGS=$(printf '%s' "$ABSEIL_CFLAGS" | sed -e 
"s/-I/${ISYSTEM?}/g")
 FilterLibs "${ABSEIL_LIBS}"

Re: Is it still possible to compile LibreOffice 24 for Linux 32-bit? (part 2)

2024-02-14 Thread Rene Engelhard


Hi,

Am 14.02.24 um 15:50 schrieb Escuelas Linux:
Running 'make' alone fails because all warnings are treated as errors, 
so I added the following parameters



make CFLAGS="-Wno-error" CXXFLAGS="-Wno-error -g1"



Again: --disable-werror.

No need to fiddle with CFLAGS/CXXFLAGS to add -Wno-error.



However, it still stops with the following error:



(snip)

We use system-coin*. (As you did later too which disabled  this 
third-party module). And yes, that one might  have include fixes etc., 
didn't check but pretty likely.




(mdds)


So I copied the newly created mdds folder to liborcus with


cp -r mdds/ 
/home/linux/Downloads/libreoffice-24.2.0.3/workdir/UnpackedTarball/liborcus/src/liborcus/



Interesting. I use system-mdds and system-orcus BUT for 
bookworm-backports I do use internal ones (since it needs newer ones not 
in stable) and this just works, too.


[...]

(coin again)



And appeared a lot of errors that look like:


-

rdf_model.c:1891:17: error: invalid use of incomplete typedef 
'librdf_model' {aka 'struct librdf_model_s'}


1891 | return model->factory->transaction_get_handle(model);


rdfinit.c:162:10: error: invalid use of incomplete typedef 
'librdf_world' {aka 'struct librdf_world_s'}


162 | world->genid_base = 1;

-


Now I installed librdf0-dev and its dependencies, and added the 
following lines to autogen.input:



--with-system-redland


As you probably guessed we do that also ;)


And if there is build fixes (also for 32bit) those packages get it. As 
upstream doesn't do 32bit builds anymore I am quite sure (and we see 
this) that the internal modules might get  problems with that.


Regards,


Rene

Re: Is it still possible to compile LibreOffice 24 for Linux 32-bit? (part 2)

2024-02-14 Thread Rene Engelhard


Hi,

Am 14.02.24 um 17:48 schrieb Rene Engelhard:

Am 14.02.24 um 17:40 schrieb Rene Engelhard:
lobasis is a totally nonsensical name to begin with, exposing 
internals (basis what?) to the public noone needs.




More accurate: Once-have-been internals. There one was a oobasis 
directory in OOo. That's where the name get cargo-culted over.


See 
https://cgit.freedesktop.org/libreoffice/core/log/?qt=grep=basis=50 :)


And I never saw the reason why more -coreXY packages (except maybe epm 
limits?)


Regards,

Rene

[Bug 149151] Error in the Basic IIf function.

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149151

--- Comment #4 from Jean-Pierre Sanchez  
---

The following line raises an error
  arr = Iif(True, Array("A","B"), Array("B","A")) ' Raises an error

The following line does not work properly: arr = "A"
arr = Iif(False, Array("A","B"), Array("B","A")) ' 

IIF exposes the same issue when with functions returning an Array

Sub Main
arr = Iif(true, getArray1(), getArray2())   
End Sub

Function getArray1() As Variant
arr  = Array("A","B")
getArray1 = arr
End Function

Function getArray2() As Variant
arr  = Array("B","A")
getArray2 = arr
End Function

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159251] After using the navigator w/rtl user interface, text is garbled during selection / after hovering

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159251

--- Comment #14 from Yotam Benshalom  ---
...sorry, erase that - new documents still suffer from the same problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159156] Enhancement request : Freeze Zoom as a global LibreOffice preference

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159156

--- Comment #17 from V Stuart Foote  ---
(In reply to khindall from comment #16)

> If you're going to do it at all, shouldn't it be put on a different
> keystroke and be the same for all modules?

Actually the 100% zoom could be assigned globally to +0, but the Writer
assignment to the paragraph Text Body would override the global. Module
shortcuts take precedence over the LibreOffice shortcuts.

Users could then customize to remove the Text Body assignment in Writer if they
felt they needed the 100% zoom there as well.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 159156] Enhancement request : Freeze Zoom as a global LibreOffice preference

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159156

--- Comment #17 from V Stuart Foote  ---
(In reply to khindall from comment #16)

> If you're going to do it at all, shouldn't it be put on a different
> keystroke and be the same for all modules?

Actually the 100% zoom could be assigned globally to +0, but the Writer
assignment to the paragraph Text Body would override the global. Module
shortcuts take precedence over the LibreOffice shortcuts.

Users could then customize to remove the Text Body assignment in Writer if they
felt they needed the 100% zoom there as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Is it still possible to compile LibreOffice 24 for Linux 32-bit? (part 2)

2024-02-14 Thread Rene Engelhard


Hi,

Am 14.02.24 um 17:40 schrieb Rene Engelhard:
lobasis is a totally nonsensical name to begin with, exposing internals 
(basis what?) to the public noone needs.


NO distro calls their packages, ebuilds or whatever lobasis. Neither do 
they come out of LOs build system directly (as those packages do). So 
this question doesn about why it's not called lobasis doesn't really 
make sense.


As I said: the name of the software if LibreOffice -> libreoffice for 
package names (which are defined to be lowercase.).


Regards,

Rene

Re: Is it still possible to compile LibreOffice 24 for Linux 32-bit? (part 2)

2024-02-14 Thread Rene Engelhard


Hi,

Am 14.02.24 um 17:04 schrieb Escuelas Linux:

[ the LO .debs date after Debian did packages and that was carried over 
since ever. oobasisX.Y was done in some OOo time when they thougt they 
should do some "debs", after which they just shipped rpms you needed to 
use alien for ]


Just one more question. Why are the Debian packages of LibreOffice so 
different from the packages produced by the LO source? LO produces a 
bunch of libobasis* packages, while Debian does not offer a single 
libobasis* package, and they do not even match in name or even 
apparent purpose with those produced by LO source.


libreoffice-core


lobasis is a totally nonsensical name to begin with, exposing internals 
(basis what?) to the public noone needs.



Besides that the software is called libreoffice and not lobasis ;) (It 
contains lo, yes, but...)


Perhaps Debian uses LO source as a base, but also manages a custom 
layer to build its deb packages differently? If so, what would be the 
advantages of the Debian packages over the ones generated by LO source?


Integration. Proper packaging. (LO has no "real" packages, it has "stuff 
just packed up in .deb format). Proper dependencies where needed. Lesser 
duplication/getting security fixes directly instead of getting them in a 
later release by syncing third-party libs by just having it use the 
system version of the lib.


More architectures supported (as you say yourself, no i386 there, no 
arm32, ..)


And stuff Debian policy mandates which upstream doesn't do :)


Regards,

Rene

[Bug 101313] Copy-paste a Table With Merged Cells from Writer to Calc: Cells Placed in Wrong Position (Wrong cell offsets)

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101313

--- Comment #13 from Kevin Suo  ---
For those who are interested, this may be due to sth wrong in the sc RTF parser
 in ScRTFParser::SeekTwips() or ScRTFParser::ColAdjust()
https://opengrok.libreoffice.org/xref/core/sc/source/filter/rtf/rtfparse.cxx?r=4790ef5c

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'libreoffice-24-2' - sfx2/source

2024-02-14 Thread Julien Nabet (via logerrit)

 sfx2/source/doc/sfxbasemodel.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 39fa034db32fa07a7f2a7afe77f7d1c047b5cad8
Author: Julien Nabet 
AuthorDate: Wed Feb 14 10:21:20 2024 +0100
Commit: Xisco Fauli 
CommitDate: Wed Feb 14 17:37:42 2024 +0100

tdf#159707: fix crash when changing to edit mode (calc)

bt:
0x7f9eb4b902f2 in 
com::sun::star::uno::Reference::operator->() 
const (this=0x55b8c2b54888) at include/com/sun/star/uno/Reference.h:387
0x7f9eb4c03584 in 
ScVbaEventsHelper::notifyEvent(com::sun::star::document::EventObject const&) 
(this=0x55b8c2b54840, rEvent=...) at 
/home/julien/lo/libreoffice/sc/source/ui/vba/vbaeventshelper.cxx:605
0x7f9ef464bd3c in (anonymous 
namespace)::NotifySingleListenerIgnoreRE::operator()(com::sun::star::uno::Reference
 const&) const (this=0x7ffc5044dfc0, listener=uno::Reference to 
(ScVbaEventsHelper *) 0x55b8c2b54870) at 
/home/julien/lo/libreoffice/sfx2/source/doc/sfxbasemodel.cxx:3293
0x7f9ef463b8aa in 
comphelper::OInterfaceContainerHelper3::forEach<(anonymous
 
namespace)::NotifySingleListenerIgnoreRE >((anonymous 
namespace)::NotifySingleListenerIgnoreRE const&)
(this=0x55b8c2735c18, func=...) at 
include/comphelper/interfacecontainer3.hxx:279
0x7f9ef463b010 in SfxBaseModel::postEvent_Impl(rtl::OUString const&, 
com::sun::star::uno::Reference const&, 
com::sun::star::uno::Any const&)
(this=0x55b8c2308ae0, aName="OnUnload", xController=empty uno::Reference, 
supplement=uno::Any(void)) at 
/home/julien/lo/libreoffice/sfx2/source/doc/sfxbasemodel.cxx:3338
0x7f9ef463a089 in SfxBaseModel::Notify(SfxBroadcaster&, SfxHint const&) 
(this=0x55b8c2308ae0, rBC=..., rHint=...) at 
/home/julien/lo/libreoffice/sfx2/source/doc/sfxbasemodel.cxx:2960

See full bt here:
https://bugs.documentfoundation.org/attachment.cgi?id=192546

Regression from:

https://git.libreoffice.org/core/+/d2fccf0117a37f8aab8bb50ece419987f06af6b9%5E%21
"cool#6893 improve listeners in SfxBaseModel"

Change-Id: I372808dade20c47275ab599054d8e9572dc3da4d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163356
Reviewed-by: Julien Nabet 
Reviewed-by: Noel Grandin 
Tested-by: Jenkins
(cherry picked from commit 6c6b580428bc527da9af82da743616787617b39b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163344
Reviewed-by: Xisco Fauli 

diff --git a/sfx2/source/doc/sfxbasemodel.cxx b/sfx2/source/doc/sfxbasemodel.cxx
index 985af531358d..062c594f2c4f 100644
--- a/sfx2/source/doc/sfxbasemodel.cxx
+++ b/sfx2/source/doc/sfxbasemodel.cxx
@@ -2510,7 +2510,7 @@ void SAL_CALL SfxBaseModel::removeEventListener( const 
Reference< document::XEve
 {
 SfxModelGuard aGuard( *this );
 
-m_pData->m_aEventListeners.removeInterface( aListener );
+m_pData->m_aDocumentEventListeners1.removeInterface( aListener );
 }
 
 //  XShapeEventBroadcaster

[Bug 159156] Enhancement request : Freeze Zoom as a global LibreOffice preference

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159156

--- Comment #16 from khind...@thirteens.net ---
(In reply to V Stuart Foote from comment #15)

> +0 is not available in Writer --the default Writer assignment for
> 'Body Text' Paragraph style is OOo legacy as Jean-Frances notes.
> 
> Otherwise +0 could be assigned to 100% zoom for all other modules.
> 
> +1 to do so, but do not touch the current Writer style assignment, leave it
> the legacy exception.

If you're going to do it at all, shouldn't it be put on a different keystroke
and be the same for all modules?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159156] Enhancement request : Freeze Zoom as a global LibreOffice preference

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159156

--- Comment #16 from khind...@thirteens.net ---
(In reply to V Stuart Foote from comment #15)

> +0 is not available in Writer --the default Writer assignment for
> 'Body Text' Paragraph style is OOo legacy as Jean-Frances notes.
> 
> Otherwise +0 could be assigned to 100% zoom for all other modules.
> 
> +1 to do so, but do not touch the current Writer style assignment, leave it
> the legacy exception.

If you're going to do it at all, shouldn't it be put on a different keystroke
and be the same for all modules?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

core.git: desktop/qa desktop/source include/comphelper include/LibreOfficeKit linguistic/source

2024-02-14 Thread Michael Meeks (via logerrit)

 desktop/qa/desktop_lib/test_desktop_lib.cxx |3 ++-
 desktop/source/lib/init.cxx |   23 +++
 include/LibreOfficeKit/LibreOfficeKit.h |3 +++
 include/LibreOfficeKit/LibreOfficeKit.hxx   |   12 +++-
 include/comphelper/lok.hxx  |8 
 linguistic/source/gciterator.cxx|8 
 linguistic/source/gciterator.hxx|7 ++-
 linguistic/source/lngsvcmgr.cxx |8 
 linguistic/source/lngsvcmgr.hxx |7 ++-
 9 files changed, 75 insertions(+), 4 deletions(-)

New commits:
commit 52f2720af102c9a4800db085bbe09e60e5d6a3c7
Author: Michael Meeks 
AuthorDate: Tue Feb 6 18:05:09 2024 +
Commit: Michael Meeks 
CommitDate: Wed Feb 14 17:29:02 2024 +0100

lok: implement a joinThreads function - to wind down thread pools.

Necessary to do this before forking on Unix systems; use a
dynamic_cast interface since this is all for internal use.

Change-Id: I8a911322acd4ec5654eb0d14804c09d513a0bd4b
Signed-off-by: Michael Meeks 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163335
Tested-by: Jenkins

diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx 
b/desktop/qa/desktop_lib/test_desktop_lib.cxx
index d9809cf56ce3..c9f276a67eeb 100644
--- a/desktop/qa/desktop_lib/test_desktop_lib.cxx
+++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx
@@ -3593,10 +3593,11 @@ void DesktopLOKTest::testABI()
 CPPUNIT_ASSERT_EQUAL(classOffset(17), offsetof(struct 
_LibreOfficeKitClass, trimMemory));
 CPPUNIT_ASSERT_EQUAL(classOffset(18), offsetof(struct 
_LibreOfficeKitClass, startURP));
 CPPUNIT_ASSERT_EQUAL(classOffset(19), offsetof(struct 
_LibreOfficeKitClass, stopURP));
+CPPUNIT_ASSERT_EQUAL(classOffset(20), offsetof(struct 
_LibreOfficeKitClass, joinThreads));
 
 // When extending LibreOfficeKit with a new function pointer,  add new 
assert for the offsetof the
 // new function pointer and bump this assert for the size of the class.
-CPPUNIT_ASSERT_EQUAL(classOffset(20), sizeof(struct _LibreOfficeKitClass));
+CPPUNIT_ASSERT_EQUAL(classOffset(21), sizeof(struct _LibreOfficeKitClass));
 
 CPPUNIT_ASSERT_EQUAL(documentClassOffset(0), offsetof(struct 
_LibreOfficeKitDocumentClass, destroy));
 CPPUNIT_ASSERT_EQUAL(documentClassOffset(1), offsetof(struct 
_LibreOfficeKitDocumentClass, saveAs));
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 1742488a7cf9..7d5bbc66d492 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -2577,6 +2577,8 @@ lo_startURP(LibreOfficeKit* pThis, void* 
pReceiveURPFromLOContext, void* pSendUR
 
 static void lo_stopURP(LibreOfficeKit* pThis, void* pSendURPToLOContext);
 
+static int lo_joinThreads(LibreOfficeKit* pThis);
+
 static void lo_runLoop(LibreOfficeKit* pThis,
LibreOfficeKitPollCallback pPollCallback,
LibreOfficeKitWakeCallback pWakeCallback,
@@ -2621,6 +2623,7 @@ LibLibreOffice_Impl::LibLibreOffice_Impl()
 m_pOfficeClass->trimMemory = lo_trimMemory;
 m_pOfficeClass->startURP = lo_startURP;
 m_pOfficeClass->stopURP = lo_stopURP;
+m_pOfficeClass->joinThreads = lo_joinThreads;
 
 gOfficeClass = m_pOfficeClass;
 }
@@ -3353,6 +3356,26 @@ static void lo_stopURP(LibreOfficeKit* /* pThis */,
 
static_cast(pFunctionBasedURPConnection)->close();
 }
 
+
+static int lo_joinThreads(LibreOfficeKit* /* pThis */)
+{
+comphelper::ThreadPool  = 
comphelper::ThreadPool::getSharedOptimalPool();
+pool.joinThreadsIfIdle();
+
+//if (comphelper::getWorkerCount() > 0)
+//return 0;
+
+// Grammar checker thread
+css::uno::Reference xLangSrv =
+css::linguistic2::LinguServiceManager::create(xContext);
+
+auto joinable = dynamic_cast(xLangSrv.get());
+if (joinable && !joinable->joinThreads())
+return 0;
+
+return 1;
+}
+
 static void lo_registerCallback (LibreOfficeKit* pThis,
  LibreOfficeKitCallback pCallback,
  void* pData)
diff --git a/include/LibreOfficeKit/LibreOfficeKit.h 
b/include/LibreOfficeKit/LibreOfficeKit.h
index 963d7962a6c2..78651128d3ac 100644
--- a/include/LibreOfficeKit/LibreOfficeKit.h
+++ b/include/LibreOfficeKit/LibreOfficeKit.h
@@ -140,6 +140,9 @@ struct _LibreOfficeKitClass
 
 /// @see lok::Office::stopURP
 void (*stopURP)(LibreOfficeKit* pThis, void* pSendURPToLOContext);
+
+/// @see lok::Office::joinThreads
+int (*joinThreads)(LibreOfficeKit* pThis);
 };
 
 #define LIBREOFFICEKIT_DOCUMENT_HAS(pDoc,member) 
LIBREOFFICEKIT_HAS_MEMBER(LibreOfficeKitDocumentClass,member,(pDoc)->pClass->nSize)
diff --git a/include/LibreOfficeKit/LibreOfficeKit.hxx 
b/include/LibreOfficeKit/LibreOfficeKit.hxx
index 29e644900caf..e94053378355 100644
--- a/include/LibreOfficeKit/LibreOfficeKit.hxx
+++

[Bug 159721] New: Strange behavior of bullet points for stuff copied as HTML from the Internet via clipboard

2024-02-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=159721

Bug ID: 159721
   Summary: Strange behavior of bullet points for stuff copied as
HTML from the Internet via clipboard
   Product: LibreOffice
   Version: 24.2.0.0 beta1+
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: adalbert.hans...@gmx.de

Created attachment 192567
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192567=edit
Sample with screenshots to reproduce the bug

This problem arises in LibreOfficeWriter
Version: 24.2.2.0.0+ (X86_64) / LibreOffice Community
Build ID: 46169670ef4031888e143823b263577296d7867f
CPU threads: 4; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Calc: threaded

But I also encountered it in older versions. (sorry, 24.2.2.0.0 was not offered
in the bug report drop-down list, I selected another one close to that). There
is a very old bug 32400 which is told to have been fixed on 2010-12-14 19:44:23
UTC, but this is another one.

Steps to reproduce:

In the appended example try out applying the "bulleted list" tool button twice
on each bulleted list paragraph. They behave differently.

Expected result:

I expect, that they all result in the same bullet point size, preferably the
one which comes out of the first few bulleted paragraphs.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: helpcontent2

2024-02-14 Thread Dione Maddern (via logerrit)

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d87206370b840adef6dfd03ed280a1de5635fac6
Author: Dione Maddern 
AuthorDate: Wed Feb 14 17:22:36 2024 +0100
Commit: Gerrit Code Review 
CommitDate: Wed Feb 14 17:22:36 2024 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to ac406bcc94724248ab5d2327a65dd0bf821e18c3
  - Remove text/scalc/01/0212.xhp because it has been superseded by 
text/shared/01/05040300.xhp.

Change-Id: I1e38debd8a4a3148bf2f7184544d6208e8eb189b
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163346
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 8c2af651f933..ac406bcc9472 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 8c2af651f93318a13bb9246c3f8c7480f58a67a9
+Subproject commit ac406bcc94724248ab5d2327a65dd0bf821e18c3

help.git: AllLangHelp_scalc.mk source/text

2024-02-14 Thread Dione Maddern (via logerrit)

 AllLangHelp_scalc.mk  |1 
 source/text/scalc/01/0212.xhp |   40 --
 2 files changed, 41 deletions(-)

New commits:
commit ac406bcc94724248ab5d2327a65dd0bf821e18c3
Author: Dione Maddern 
AuthorDate: Wed Feb 14 15:17:49 2024 +0100
Commit: Olivier Hallot 
CommitDate: Wed Feb 14 17:22:36 2024 +0100

Remove text/scalc/01/0212.xhp because it has been superseded by 
text/shared/01/05040300.xhp.

Change-Id: I1e38debd8a4a3148bf2f7184544d6208e8eb189b
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163346
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/AllLangHelp_scalc.mk b/AllLangHelp_scalc.mk
index a8d529f631..9038e92f1a 100644
--- a/AllLangHelp_scalc.mk
+++ b/AllLangHelp_scalc.mk
@@ -29,7 +29,6 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,scalc,\
 helpcontent2/source/text/scalc/00/avail_release \
 helpcontent2/source/text/scalc/01/0112 \
 helpcontent2/source/text/scalc/01/0211 \
-helpcontent2/source/text/scalc/01/0212 \
 helpcontent2/source/text/scalc/01/02120100 \
 helpcontent2/source/text/scalc/01/0214 \
 helpcontent2/source/text/scalc/01/02140100 \
diff --git a/source/text/scalc/01/0212.xhp 
b/source/text/scalc/01/0212.xhp
deleted file mode 100644
index e8e06a7171..00
--- a/source/text/scalc/01/0212.xhp
+++ /dev/null
@@ -1,40 +0,0 @@
-
-
-
-
-
-  
-Headers  Footers
-/text/scalc/01/0212.xhp
-  
-
-
-
-
-Headers  
Footers
-Allows you to define and format 
headers and footers. 
-
-The 
Headers/Footers dialog contains the tabs for defining headers and 
footers. There will be separate tabs for the left and right page headers and 
footers if the Same content left/right option was not marked in 
the Page Style 
dialog.
-
-
-
-
-
-
-

1 2 3 >

1 - 100 of 229 matches

Mail list logo