[Bug 71183] Wrong rendering .cdr file
https://bugs.documentfoundation.org/show_bug.cgi?id=71183 --- Comment #9 from Jacckma --- Comment on attachment 88577 --> https://bugs.documentfoundation.org/attachment.cgi?id=88577 2 bts corresponding to logs Can i view this attachment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159748] UI: Cell protection dialog reference menu that don't exist
https://bugs.documentfoundation.org/show_bug.cgi?id=159748 Timur changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||ti...@libreoffice.org --- Comment #7 from Timur --- There is no need to repeat the same in many comments. I add UX mail. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159748] UI: Cell protection dialog reference menu that don't exist
https://bugs.documentfoundation.org/show_bug.cgi?id=159748 Timur changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||ti...@libreoffice.org --- Comment #7 from Timur --- There is no need to repeat the same in many comments. I add UX mail. -- You are receiving this mail because: You are on the CC list for the bug.
core.git: chart2/source
chart2/source/view/charttypes/PieChart.cxx | 83 ++---
1 file changed, 76 insertions(+), 7 deletions(-)
New commits:
commit e1573deaf1b2ecd946d23a4ce623546c08036ec7
Author: Kurt Nordback
AuthorDate: Mon Nov 20 11:46:10 2023 -0700
Commit: Noel Grandin
CommitDate: Sun Feb 18 07:33:18 2024 +0100
tdf#50934: Implement connector lines for pie-of-pie
Change-Id: Ifca083aa07b28d5c604382decaefedfe653ff8ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160731
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/chart2/source/view/charttypes/PieChart.cxx
b/chart2/source/view/charttypes/PieChart.cxx
index a946616ea5fe..9b1494596598 100644
--- a/chart2/source/view/charttypes/PieChart.cxx
+++ b/chart2/source/view/charttypes/PieChart.cxx
@@ -928,20 +928,26 @@ void PieChart::createShapes()
createOneBar(SubPieType::RIGHT, aParam, xSeriesTarget,
xTextTarget, pSeries, pDataSrc, n3DRelativeHeight);
-// draw connecting lines
+//
+// Draw connecting lines
+//
double xl0, xl1, yl0, yl1, x0, y0, x1, y1, y2, y3;
-if (m_aPosHelper.m_fAngleDegreeOffset < 90.0) {
+// Get coordinates of "corners" of left composite wedge
+sal_Int32 nEnd = pDataSrc->getNPoints(pSeries, SubPieType::LEFT);
+double compFrac = pDataSrc->getData(pSeries, nEnd - 1,
+SubPieType::LEFT) / aParam.mfLogicYSum;
+if (compFrac < 0.5) {
xl0 = aParam.mfUnitCircleOuterRadius * m_fLeftScale *
-cos(m_aPosHelper.m_fAngleDegreeOffset * M_PI / 180) +
-m_fLeftShift;
+cos(compFrac * M_PI) + m_fLeftShift;
yl0 = aParam.mfUnitCircleOuterRadius * m_fLeftScale *
-sin(m_aPosHelper.m_fAngleDegreeOffset * M_PI / 180);
+sin(compFrac * M_PI);
} else {
xl0 = m_fLeftShift;
yl0 = aParam.mfUnitCircleOuterRadius * m_fLeftScale;
}
+// Coordinates of bar top left corner
xl1 = m_fBarLeft;
yl1 = m_fFullBarHeight / 2;
@@ -974,12 +980,75 @@ void PieChart::createShapes()
break;
}
case PieChartSubType_PIE:
+{
pDataSrc =
createOneRing(SubPieType::LEFT, 0, aParam, xSeriesTarget,
xTextTarget, pSeries, pDataSrc, n3DRelativeHeight);
createOneRing(SubPieType::RIGHT, 0, aParam, xSeriesTarget,
xTextTarget, pSeries, pDataSrc, n3DRelativeHeight);
+
+//
+// Draw connecting lines
+//
+double xl0, xl1, yl0, yl1, x0, y0, x1, y1, y2, y3;
+
+// Get coordinates of "corners" of left composite wedge
+sal_Int32 nEnd = pDataSrc->getNPoints(pSeries, SubPieType::LEFT);
+double compFrac = pDataSrc->getData(pSeries, nEnd - 1,
+SubPieType::LEFT) / aParam.mfLogicYSum;
+if (compFrac < 0.5) {
+// Translated, per below
+xl0 = aParam.mfUnitCircleOuterRadius * m_fLeftScale *
+cos(compFrac * M_PI) + m_fLeftShift - m_fRightShift;
+yl0 = aParam.mfUnitCircleOuterRadius * m_fLeftScale *
+sin(compFrac * M_PI);
+} else {
+// Translated, per below
+xl0 = m_fLeftShift - m_fRightShift;
+yl0 = aParam.mfUnitCircleOuterRadius * m_fLeftScale;
+}
+
+// Compute tangent point on the right-hand circle of the line
+// through (xl0, yl0). If we translate things so the right-hand
+// circle is centered on the origin, then this point (x,y)
+// satisfies these two equations, where r is the radius of the
+// right-hand circle:
+// (1) x^2 + y^2 = r^2
+// (2) (y - yl0) / (x - xl0) = -x / y
+const double r = aParam.mfUnitCircleOuterRadius * m_fRightScale;
+
+xl1 = (r*r * xl0 + yl0 * r * sqrt(xl0*xl0 + yl0*yl0 - r*r)) /
+(xl0*xl0 + yl0*yl0);
+yl1 = sqrt(r*r - xl1*xl1);
+
+// Now translate back to the coordinates we use
+xl0 += m_fRightShift;
+xl1 += m_fRightShift;
+
+x0 = m_aPosHelper.transformUnitCircleToScene(0, xl0, 0).PositionX;
+y0 = m_aPosHelper.transformUnitCircleToScene(90, yl0, 0).PositionY;
+x1 = m_aPosHelper.transformUnitCircleToScene(0, xl1, 0).PositionX;
+y1 = m_aPosHelper.transformUnitCircleToScene(90, yl1, 0).PositionY;
+y2 = m_aPosHelper.transformUnitCircleToScene(90, -yl0,
0).PositionY;
+y3 = m_aPosHelper.transformUnitCircleToScene(90, -yl1,
0).PositionY;
+
+std::vector> linePts;
+linePts.resize(2);
+
[Bug 144973] Start center not painted in background when Alt-Tabbing away and back with dialog open
https://bugs.documentfoundation.org/show_bug.cgi?id=144973 Aron Budea changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.
[Bug 61914] [META] Start Center bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=61914 Bug 61914 depends on bug 144973, which changed state. Bug 144973 Summary: Start center not painted in background when Alt-Tabbing away and back with dialog open https://bugs.documentfoundation.org/show_bug.cgi?id=144973 What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|INSUFFICIENTDATA|--- -- You are receiving this mail because: You are the assignee for the bug.
[Bug 144973] Start center not painted in background when Alt-Tabbing away and back with dialog open
https://bugs.documentfoundation.org/show_bug.cgi?id=144973 Aron Budea changed: What|Removed |Added Ever confirmed|1 |0 Resolution|INSUFFICIENTDATA|--- Status|RESOLVED|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 84831] some icons not have a information message box
https://bugs.documentfoundation.org/show_bug.cgi?id=84831 --- Comment #13 from meeloun --- 留学论文代写 https://www.lxws.net/liuxuelunwen.html 服务的核心优势之一是高质量的定制作品。我们拥有一支由经验丰富、专业素养高的写手团队，涵盖各个学科领域和研究方向。无论您的学术任务是关于文学、商科、工程还是医学，我们都有相应专业的写手为您服务。 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159757] New: Complex script word-by-word navigation and selection does not work at all
https://bugs.documentfoundation.org/show_bug.cgi?id=159757 Bug ID: 159757 Summary: Complex script word-by-word navigation and selection does not work at all Product: LibreOffice Version: 24.2.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: stoomkra...@outlook.com Description: In build-in Windows programs like even notepad you can navigate a sentence with CTRL+LEFT/RIGHT cursor keys. In LibreOffice programs this ONLY works for languages with spaces as word separator. Example (Thai) คนไทยที่นับถือศาสนาพุทธเกินห้าสิบเปอร์เซ็นต์ Transliteration: kon tai têe náp tĕu sàat-sà-năa pút gern hâa sìp bper-sen As you can see, you can select individual words or navigate word by word through the sentence in any webbrowser using the standard ways (double click, ctrl+cursor keys). In LibreOffice this does not work at all, Steps to Reproduce: 1. copy paste คนไทยที่นับถือศาสนาพุทธเกินห้าสิบเปอร์เซ็นต์ 2. try to select random word (ie double click on บ Actual Results: บ is selected Expected Results: นับถือ should be selected All words: คน ไทย ที่ นับถือ ศาสนา พุทธ เกิน ห้า สิบ เปอร์เซ็นต์ Reproducible: Always User Profile Reset: No Additional Info: Version: 24.2.0.3 (X86_64) / LibreOffice Community Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: en-GB (en_GB); UI: en-GB Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159540] Personal salutation in mail merge (PDF attachment with email text) does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=159540 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156416] Keep losing my "COMMENTS".
https://bugs.documentfoundation.org/show_bug.cgi?id=156416 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156416] Keep losing my "COMMENTS".
https://bugs.documentfoundation.org/show_bug.cgi?id=156416 --- Comment #3 from QA Administrators --- Dear sr-...@outlook.com, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156196] document recovery sometimes ignores the last save
https://bugs.documentfoundation.org/show_bug.cgi?id=156196 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156196] document recovery sometimes ignores the last save
https://bugs.documentfoundation.org/show_bug.cgi?id=156196 --- Comment #3 from QA Administrators --- Dear peter josvai, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Bug 61914] [META] Start Center bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=61914 Bug 61914 depends on bug 144973, which changed state. Bug 144973 Summary: Start center not painted in background when Alt-Tabbing away and back with dialog open https://bugs.documentfoundation.org/show_bug.cgi?id=144973 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Bug 154258] Repeatedly wants to Recover Files that were left unsaved months ago
https://bugs.documentfoundation.org/show_bug.cgi?id=154258 --- Comment #4 from QA Administrators --- Dear Klaas Steyn, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Bug 154258] Repeatedly wants to Recover Files that were left unsaved months ago
https://bugs.documentfoundation.org/show_bug.cgi?id=154258 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Bug 147490] Drawing makes menus and dialogs blank
https://bugs.documentfoundation.org/show_bug.cgi?id=147490 --- Comment #3 from QA Administrators --- Dear Mike Kaganski, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 144973] Start center not painted in background when Alt-Tabbing away and back with dialog open
https://bugs.documentfoundation.org/show_bug.cgi?id=144973 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 144973] Start center not painted in background when Alt-Tabbing away and back with dialog open
https://bugs.documentfoundation.org/show_bug.cgi?id=144973 --- Comment #5 from QA Administrators --- Dear Aron Budea, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Bug 140473] SVG to PNG export is kind of fuzzy/blurred without with compression at 1, 999 DPI, 30cm width (and does export at 309)
https://bugs.documentfoundation.org/show_bug.cgi?id=140473 --- Comment #4 from QA Administrators --- Dear Telesto, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Bug 147363] F1 in Form Properties dialog goes to "Help Page Not Found"
https://bugs.documentfoundation.org/show_bug.cgi?id=147363 --- Comment #3 from QA Administrators --- Dear Mike Kaganski, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 140473] SVG to PNG export is kind of fuzzy/blurred without with compression at 1, 999 DPI, 30cm width (and does export at 309)
https://bugs.documentfoundation.org/show_bug.cgi?id=140473 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156844] FORMATTING carriage return at end of paragraph reverts applied custom paragraph style to text body
https://bugs.documentfoundation.org/show_bug.cgi?id=156844 --- Comment #2 from QA Administrators --- Dear ronjenson, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Bug 61618] : Word file import field conversion
https://bugs.documentfoundation.org/show_bug.cgi?id=61618 --- Comment #10 from QA Administrators --- Dear John, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 93635] FILEOPEN: Embedded Word file slowly loaded
https://bugs.documentfoundation.org/show_bug.cgi?id=93635 --- Comment #17 from QA Administrators --- Dear Matthew Holloway, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 55622] EDITING: Writer jumps to beginning of document when undoing the pasting of a frame
https://bugs.documentfoundation.org/show_bug.cgi?id=55622 --- Comment #14 from QA Administrators --- Dear stfhell, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 87964] FILESAVE: Line type - Stepped in Chart saved in XLS / XLSX as Smooth (comment 17)
https://bugs.documentfoundation.org/show_bug.cgi?id=87964 --- Comment #22 from QA Administrators --- Dear Hannes, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 50031] The field for equation AutoText is named just "Text"
https://bugs.documentfoundation.org/show_bug.cgi?id=50031 --- Comment #14 from QA Administrators --- Dear A. Syukri Abdollah, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159756] New: logical function error?
https://bugs.documentfoundation.org/show_bug.cgi?id=159756 Bug ID: 159756 Summary: logical function error? Product: LibreOffice Version: 7.4.0.3 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: dennis.r.dyks...@gmail.com Description: Why does the logical function =IF(OR(J6="",K6=""),"",J6+K6) return "" when the test is TRUE but the function =IF(OR(J6="",K6=""),J6+K6,"") return 0 when the test is false? Steps to Reproduce: 1.Why does the logical function =IF(OR(J6="",K6=""),"",J6+K6) return "" when the test is TRUE but the function =IF(OR(J6="",K6=""),J6+K6,"") returns 0 when the test is false? 2. 3. Actual Results: see above Expected Results: Following function should return "" (null) if test is false =IF(OR(J6="",K6=""),J6+K6,"") Reproducible: Always User Profile Reset: No Additional Info: return "" instead of zero -- You are receiving this mail because: You are the assignee for the bug.
core.git: configure.ac
configure.ac | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
New commits:
commit 670de4eadcbb84394fd49c1c0c949dd35bd2303b
Author: Stephan Bergmann
AuthorDate: Fri Feb 16 13:27:00 2024 +0100
Commit: Taichi Haradaguchi <20001...@ymail.ne.jp>
CommitDate: Sun Feb 18 01:45:59 2024 +0100
Latest VS 2022 Preview is 17.10.0 now
...while latest proper VS 2022 is 17.9.0
Change-Id: Idbd104d54dde1822957894d4f74b16e651a4c8b5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163485
Tested-by: Jenkins
Reviewed-by: Taichi Haradaguchi <20001...@ymail.ne.jp>
diff --git a/configure.ac b/configure.ac
index 61d6f5f3d5b6..276657f3cae1 100644
--- a/configure.ac
+++ b/configure.ac
@@ -4096,7 +4096,7 @@ map_vs_year_to_version()
2022)
vsversion=17;;
2022preview)
-vsversion=17.9;;
+vsversion=17.10;;
*)
AC_MSG_ERROR([Assertion failure - invalid argument "$1" to
map_vs_year_to_version()]);;
esac
@@ -4216,7 +4216,7 @@ find_msvc()
vcyear=2019
vctoolset=v142
;;
-17.0 | 17.9)
+17.0 | 17.10)
vcyear=2022
vctoolset=v143
;;
@@ -4388,7 +4388,7 @@ if test "$_os" = "WINNT"; then
# are always "better", we list them in reverse chronological order.
case "$vcnumwithdot" in
-16.0 | 17.0 | 17.9)
+16.0 | 17.0 | 17.10)
WINDOWS_SDK_ACCEPTABLE_VERSIONS="10.0 8.1A 8.1 8.0"
;;
esac
@@ -6755,7 +6755,7 @@ find_msms()
msmdir=
case "$VCVER" in
-16.0 | 17.0 | 17.9)
+16.0 | 17.0 | 17.10)
for l in `ls -1 $VC_PRODUCT_DIR/redist/MSVC/`; do
my_msm_dir="$VC_PRODUCT_DIR/redist/MSVC/$l/MergeModules/"
echo "$as_me:$LINENO: looking for $my_msm_dir${my_msm_file}])" >&5
@@ -6791,7 +6791,7 @@ find_msvc_x64_dlls()
msvcdllpath="$VC_PRODUCT_DIR/redist/x64/Microsoft.VC${VCVER}.CRT"
case "$VCVER" in
-16.0 | 17.0 | 17.9)
+16.0 | 17.0 | 17.10)
for crtver in 141 142 143; do
for l in `ls -1 $VC_PRODUCT_DIR/redist/MSVC/`; do
echo "$as_me:$LINENO: testing
$VC_PRODUCT_DIR/redist/MSVC/$l/x64/Microsoft.VC$crtver.CRT" >&5
[Bug 45904] Move Java based API tests to C++
https://bugs.documentfoundation.org/show_bug.cgi?id=45904 --- Comment #379 from Commit Notification --- Luv Sharma committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/35d859d1ae23ed1fe3ea92a1d75be5f31a4241b7 tdf#45904 Remove old SwXFootnoteProperties Java test It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
core.git: framework/qa qadevOOo/Jar_OOoRunner.mk qadevOOo/objdsc qadevOOo/tests sw/qa
framework/qa/complex/api_internal/api.lst |1 qadevOOo/Jar_OOoRunner.mk |1 qadevOOo/objdsc/sw/com.sun.star.comp.office.SwXFootnoteProperties.csv | 11 - qadevOOo/tests/java/mod/_sw/SwXFootnoteProperties.java| 108 -- sw/qa/unoapi/sw_2.sce |1 5 files changed, 122 deletions(-) New commits: commit 35d859d1ae23ed1fe3ea92a1d75be5f31a4241b7 Author: Luv Sharma AuthorDate: Sat Feb 17 11:34:41 2024 +0530 Commit: Taichi Haradaguchi <20001...@ymail.ne.jp> CommitDate: Sun Feb 18 01:42:32 2024 +0100 tdf#45904 Remove old SwXFootnoteProperties Java test Change-Id: I20f160d557364ffc5240403d6e2c53b5b135ba46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163524 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001...@ymail.ne.jp> diff --git a/framework/qa/complex/api_internal/api.lst b/framework/qa/complex/api_internal/api.lst index d783f5ac1f0b..8ae697a9d214 100644 --- a/framework/qa/complex/api_internal/api.lst +++ b/framework/qa/complex/api_internal/api.lst @@ -143,7 +143,6 @@ job208=sw.SwXDocumentIndexMark job209=sw.SwXEndnoteProperties job211=sw.SwXFieldMaster job212=sw.SwXFootnote -job213=sw.SwXFootnoteProperties job215=sw.SwXFootnoteText job216=sw.SwXFrames job217=sw.SwXHeadFootText diff --git a/qadevOOo/Jar_OOoRunner.mk b/qadevOOo/Jar_OOoRunner.mk index a514d65ef8f8..9a30d16bd686 100644 --- a/qadevOOo/Jar_OOoRunner.mk +++ b/qadevOOo/Jar_OOoRunner.mk @@ -1094,7 +1094,6 @@ $(eval $(call gb_Jar_add_sourcefiles,OOoRunner,\ qadevOOo/tests/java/mod/_sw/SwXEndnoteProperties \ qadevOOo/tests/java/mod/_sw/SwXFieldMaster \ qadevOOo/tests/java/mod/_sw/SwXFootnote \ -qadevOOo/tests/java/mod/_sw/SwXFootnoteProperties \ qadevOOo/tests/java/mod/_sw/SwXFootnoteText \ qadevOOo/tests/java/mod/_sw/SwXFrames \ qadevOOo/tests/java/mod/_sw/SwXHeadFootText \ diff --git a/qadevOOo/objdsc/sw/com.sun.star.comp.office.SwXFootnoteProperties.csv b/qadevOOo/objdsc/sw/com.sun.star.comp.office.SwXFootnoteProperties.csv deleted file mode 100644 index 29abe97f2d58.. --- a/qadevOOo/objdsc/sw/com.sun.star.comp.office.SwXFootnoteProperties.csv +++ /dev/null @@ -1,11 +0,0 @@ -"SwXFootnoteProperties";"com::sun::star::text::FootnoteSettings";"CharStyleName" -"SwXFootnoteProperties";"com::sun::star::text::FootnoteSettings";"NumberingType" -"SwXFootnoteProperties";"com::sun::star::text::FootnoteSettings";"PageStyleName" -"SwXFootnoteProperties";"com::sun::star::text::FootnoteSettings";"ParaStyleName" -"SwXFootnoteProperties";"com::sun::star::text::FootnoteSettings";"Prefix" -"SwXFootnoteProperties";"com::sun::star::text::FootnoteSettings";"StartAt" -"SwXFootnoteProperties";"com::sun::star::text::FootnoteSettings";"Suffix" -"SwXFootnoteProperties";"com::sun::star::text::FootnoteSettings";"BeginNotice#optional" -"SwXFootnoteProperties";"com::sun::star::text::FootnoteSettings";"EndNotice#optional" -"SwXFootnoteProperties";"com::sun::star::text::FootnoteSettings";"FootnoteCounting#optional" -"SwXFootnoteProperties";"com::sun::star::text::FootnoteSettings";"PositionEndOfDoc#optional" diff --git a/qadevOOo/tests/java/mod/_sw/SwXFootnoteProperties.java b/qadevOOo/tests/java/mod/_sw/SwXFootnoteProperties.java deleted file mode 100644 index c86bc30c7fff.. --- a/qadevOOo/tests/java/mod/_sw/SwXFootnoteProperties.java +++ /dev/null @@ -1,108 +0,0 @@ -/* - * This file is part of the LibreOffice project. - * - * This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. - * - * This file incorporates work covered by the following license notice: - * - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed - * with this work for additional information regarding copyright - * ownership. The ASF licenses this file to you under the Apache - * License, Version 2.0 (the "License"); you may not use this file - * except in compliance with the License. You may obtain a copy of - * the License at http://www.apache.org/licenses/LICENSE-2.0 . - */ - -package mod._sw; - -import java.io.PrintWriter; - -import lib.TestCase; -import lib.TestEnvironment; -import lib.TestParameters; -import util.SOfficeFactory; - -import com.sun.star.lang.XMultiServiceFactory; -import com.sun.star.text.XFootnote; -import com.sun.star.text.XFootnotesSupplier; -import com.sun.star.text.XText; -import com.sun.star.text.XTextCursor; -import com.sun.star.text.XTextDocument; -import com.sun.star.uno.UnoRuntime; -import com.sun.star.uno.XInterface; - - -/** - * Test for the object, which is represented as set of footnote properties - * (instance of com.sun.star.text.FootnoteSettings service). - *
[Bug 43959] Horizontal ruler updates bad when changing zoom level
https://bugs.documentfoundation.org/show_bug.cgi?id=43959 --- Comment #20 from Tex2002ans --- Still an issue on: Version: 24.2.0.3 (X86_64) / LibreOffice Community Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1 CPU threads: 8; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded - - - 1. Hold CTRL. 2. Scroll mouse-wheel DOWN or UP. - Zooms document in or out. 3. Let go of CTRL. Ruler now jerks into correct place. - - - If might feel a little better if ruler: - updated every zoom level (Step 2) instead of waiting for you to: - release the CTRL button (Step 3). (I just tested latest Word 365 (Version 2401, Build 17231.20236), and Step 2 is the way it works too.) (Seems like Sasha in comment 3 says Linux works this way too, but not Windows?) - - - Side Note: Now that I recently upgraded to a 4K monitor, I'm zooming in+out more often. And this is one of those tiny little visual bugs that, to me, just *feels* like a "lack of polish". -- You are receiving this mail because: You are the assignee for the bug.
[Bug 150582] Words with smart quotes/apostrophes get added to custom dictionaries via Writer but not Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=150582 Tex2002ans changed: What|Removed |Added CC||Tex2002ans+LibreOffice@gmai ||l.com --- Comment #3 from Tex2002ans --- Yep, looks like still an issue in: Version: 24.2.0.3 (X86_64) / LibreOffice Community Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1 CPU threads: 8; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded - - - - - - - If you have these 2 lines of text in your document: - BF's - BF’s 1st = dumb quote / straight quote - U+0027 = APOSTROPHE 2nd = smart quote / curly quote - U+2019 = RIGHT SINGLE QUOTATION MARK - - - If you: - Right-Click > Add to Dictionary on the 2nd type... This is what gets added: - BF's - Writer - = U+0027 - BF’s - Draw - = U+2019 You can verify this by going into: - Tools > Options - Languages and Locales > Writing Aids - Under "User-defined Dictionaries" - Highlighting "standard [All]" - Pressing the "Edit" button. - - - Like comment 0 says: > Words with apostrophes and smart quotes should be added under any context > using any LO application using any widget/tool whose context menu offers Add > To Dictionary I'd expect that too. Right now, it seems like 2 completely different codepaths for Draw vs. Writer. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159755] New: EDITING: Annoying Automatic Ddelink Bookmarks When Copying Text From LibreOffice Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=159755 Bug ID: 159755 Summary: EDITING: Annoying Automatic Ddelink Bookmarks When Copying Text From LibreOffice Writer Product: LibreOffice Version: 7.5.9.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rdiezmail-libreoff...@yahoo.de Description: Hi all: I was happily using LibreOffice Writer, obviously the best word processor ever ;-) , on my on Ubuntu MATE 22.04.3, when I noticed something weird. Sometimes, a piece of text in the document which I copied to the clipboard got surrounded with brackets [] in a light gray colour. After a while, I had such markers all over the place. I took me days to realise that those [] markers are showing the text that belongs to a Bookmark. You can see those Bookmarks in the Navigator panel. They are called something like "__DdeLink__0_2814443403". If you copy and paste text surrounded by the Bookmark marks, you then get a new Bookmark called "__DdeLink__0_2814443403 Copy 1". All very strange. You cannot select several Bookmarks at once in the Navigator, in order to delete many of them at once. But you can click on the first one and press the Del key many times in a row. Also, if you edit a Bookmark, you land in a dialog box where you can select and delete many bookmarks at the same time. It turns out that you can turn off those distracting [] Bookmark markers under: Tools, Options..., LibreOffice Writer, Formatting Aids, Display Formatting, Bookmarks [...] But that only turns off the markers, the Bookmarks are still automatically created. This is problematic: if you open a document only to copy some text off it, then the document becomes "modified". The undo button shows an action you didn't initiate titled "Insert bookmark: __DdeLink__0_2814443403". That is also distracting, because you wonder whether you made some change by mistake. To top it all, those Bookmarks are not immediately added, and sometimes not at all. It took me a few days to find out that the reason was I am running NetBeans on the PC. Copying a piece of text in LibreOffice Writer, and switching to a source code editor panel in NetBeans is what adds those Bookmarks to LibreOffice Writer. Not very intuitive at all. As usual with LibreOffice quirks, I wasn't the first one to notice: -8<-8<-8<- How to stop automatic creation of DdeLink bookmarks from copy or paste command? https://ask.libreoffice.org/t/how-to-stop-automatic-creation-of-ddelink-bookmarks-from-copy-or-paste-command/55708 Bug 106106 - Unexpected bookmark DdeLink appears after copying text, switching focus to NetBeans and back again RESOLVED NOTOURBUG https://bugs.documentfoundation.org/show_bug.cgi?id=106106 LibreOffice Writer: Automatic Bookmark Creation while Keyboard Maestro Engine is Running https://ask.libreoffice.org/t/libreoffice-writer-automatic-bookmark-creation-while-keyboard-maestro-engine-is-running/97599/3 Bug 137534 - EDITING Odd bookmark creation at copy action in presence of qlipper https://bugs.documentfoundation.org/show_bug.cgi?id=137534 -8<-8<-8<- A few years later you would have thought that the developers of the best word processor ever would have realised that this is a recurrent problem, and that you shouldn't really let users run into it again and again. But no worries, I am here to help!!! How about adding an option to turn off generating such "DDE Links"? Or disable DDE altogether. Wasn't that a Windows thing anyway? Are many people who still need this? How about adding a separate "Copy as DDE" menu option? This way, the normal "Copy" would never create DDE links. How about writing up what I need to tell the NetBeans people (and others), in order to prevent this annoyance? That is assuming they are willing to help, as they may create their own bug and close it with "NOTOURBUG" too. After all, who is responsible for this problematic interaction, NetBeans of LibreOffice? I am specifically looking for some technical description about what the NetBeans (and others) developers need to stop doing or filter out when using the system clipboard in order to prevent triggering this annoying behavior in LibreOffice. Thanks in advance, rdiez Steps to Reproduce: See above. Actual Results: See above. Expected Results: See above. Reproducible: Always User Profile Reset: No Additional Info: See above. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 112839] [META] Regressions from the cross-platform consistent line spacing in 5.3+
https://bugs.documentfoundation.org/show_bug.cgi?id=112839 Gabor Kelemen (allotropia) changed: What|Removed |Added Depends on||159488 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=159488 [Bug 159488] FILEOPEN DOCX Specific document is rendered more tightly as in Word -- You are receiving this mail because: You are the assignee for the bug.
[Bug 107830] [META] DOCX (OOXML) paragraph-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=107830 Gabor Kelemen (allotropia) changed: What|Removed |Added Depends on|159488 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=159488 [Bug 159488] FILEOPEN DOCX Specific document is rendered more tightly as in Word -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159488] FILEOPEN DOCX Specific document is rendered more tightly as in Word
https://bugs.documentfoundation.org/show_bug.cgi?id=159488 Gabor Kelemen (allotropia) changed: What|Removed |Added Blocks|107830 |112839 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107830 [Bug 107830] [META] DOCX (OOXML) paragraph-related issues https://bugs.documentfoundation.org/show_bug.cgi?id=112839 [Bug 112839] [META] Regressions from the cross-platform consistent line spacing in 5.3+ -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159488] FILEOPEN DOCX Specific document is rendered more tightly as in Word
https://bugs.documentfoundation.org/show_bug.cgi?id=159488 --- Comment #3 from Gabor Kelemen (allotropia) --- Created attachment 192615 --> https://bugs.documentfoundation.org/attachment.cgi?id=192615=edit Diffpdf view of the Word10-saved PDF and LO saved PDF Seems like there is less spacing between the bulleted paragraphs in Writer than in Word. The bibisected change has removed the upper spacing from the first paragraph after the page break, this looks like in Word 2010+. Manually removing this 0.42 cm before spacing makes the document 2 pages back until 5.3, but in 5.2 was still rendered as 3 pages under both Linux and Windows. Bibisected under linux-5.3 to: https://cgit.freedesktop.org/libreoffice/core/commit/?id=34d7602954d4483b3bc9db700e7df2c15348947a author Khaled Hosny 2016-11-09 15:22:43 +0200 committer Khaled Hosny 2016-11-22 15:32:11 + commit 34d7602954d4483b3bc9db700e7df2c15348947a (patch) tdf#55469 Consistent line spacing across platforms -- You are receiving this mail because: You are the assignee for the bug.
[Bug 134613] Copying a document slow because of EnumFontFamiliesExW
https://bugs.documentfoundation.org/show_bug.cgi?id=134613 --- Comment #5 from Tex2002ans --- It took: - ~1 min 45 secs in: Version: 24.2.0.3 (X86_64) / LibreOffice Community Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1 CPU threads: 8; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded - - - It took: - ~6 seconds to do the same in latest: - Microsoft Word 365 (Version 2401, Build 17231.20236) -- You are receiving this mail because: You are the assignee for the bug.
core.git: sw/source
sw/source/core/doc/DocumentRedlineManager.cxx | 12 +++-
sw/source/core/doc/docredln.cxx | 36 +++---
2 files changed, 37 insertions(+), 11 deletions(-)
New commits:
commit a0bd028a00165996224c93a4eba4b6affe6743e0
Author: Pranam Lashkari
AuthorDate: Wed Feb 14 15:07:38 2024 +0530
Commit: Caolán McNamara
CommitDate: Sat Feb 17 21:49:28 2024 +0100
writer: LOK: make sure redline comment undo/redo is notified
problem:
when actions were performed on comments and changes were tracked,
LOK was not notified and actions were not reflected
Change-Id: Iad4d9338a6205278b586106e8f39769b731f18dc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163357
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Gökay ŞATIR
(cherry picked from commit 0b7a9c231f66b5c2659ab3aa6a0f3c7991b9e721)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163502
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sw/source/core/doc/DocumentRedlineManager.cxx
b/sw/source/core/doc/DocumentRedlineManager.cxx
index 3f5ccfc0ec5c..710baaf41b94 100644
--- a/sw/source/core/doc/DocumentRedlineManager.cxx
+++ b/sw/source/core/doc/DocumentRedlineManager.cxx
@@ -20,6 +20,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -40,6 +41,7 @@
#include
#include
#include
+#include
using namespace com::sun::star;
@@ -383,8 +385,14 @@ void UpdateFramesForRemoveDeleteRedline(SwDoc & rDoc,
SwPaM const& rPam)
// fields last - SwGetRefField::UpdateField requires up-to-date frames
UpdateFieldsForRedline(rDoc.getIDocumentFieldsAccess()); // after footnotes
-// update SwPostItMgr / notes in the margin
-rDoc.GetDocShell()->Broadcast(
+const SwTextNode *pTextNode = rPam.GetPointNode().GetTextNode();
+SwTextAttr* pTextAttr = pTextNode ?
pTextNode->GetFieldTextAttrAt(rPam.GetPoint()->GetContentIndex() - 1,
::sw::GetTextAttrMode::Default) : nullptr;
+SwTextField *const
pTextField(static_txtattr_cast(pTextAttr));
+if (pTextField && comphelper::LibreOfficeKit::isActive() )
+rDoc.GetDocShell()->Broadcast(
+SwFormatFieldHint(>GetFormatField(),
SwFormatFieldHintWhich::INSERTED));
+else
+rDoc.GetDocShell()->Broadcast(
SwFormatFieldHint(nullptr, SwFormatFieldHintWhich::INSERTED) );
}
diff --git a/sw/source/core/doc/docredln.cxx b/sw/source/core/doc/docredln.cxx
index b8bb35056de1..a629d9d6b432 100644
--- a/sw/source/core/doc/docredln.cxx
+++ b/sw/source/core/doc/docredln.cxx
@@ -1372,6 +1372,22 @@ void SwRedlineData::dumpAsXml(xmlTextWriterPtr pWriter)
const
sal_uInt32 SwRangeRedline::s_nLastId = 1;
+namespace
+{
+void lcl_LOKBroadcastCommentOperation(RedlineType type, const SwPaM& rPam)
+{
+if (comphelper::LibreOfficeKit::isActive())
+{
+auto eHintType = RedlineType::Delete == type ?
SwFormatFieldHintWhich::REDLINED_DELETION: SwFormatFieldHintWhich::INSERTED;
+const SwTextNode *pTextNode = rPam.GetPointNode().GetTextNode();
+SwTextAttr* pTextAttr = pTextNode ?
pTextNode->GetFieldTextAttrAt(rPam.GetPoint()->GetContentIndex() - 1,
::sw::GetTextAttrMode::Default) : nullptr;
+SwTextField *const
pTextField(static_txtattr_cast(pTextAttr));
+if (pTextField)
+
const_cast(pTextField->GetFormatField()).Broadcast(SwFormatFieldHint(>GetFormatField(),
eHintType));
+}
+}
+} // anonymous namespace
+
SwRangeRedline::SwRangeRedline(RedlineType eTyp, const SwPaM& rPam, sal_uInt32
nMovedID )
: SwPaM( *rPam.GetMark(), *rPam.GetPoint() ), m_pRedlineData(
new SwRedlineData(eTyp,
GetDoc().getIDocumentRedlineAccess().GetRedlineAuthor(), nMovedID ) )
@@ -1393,15 +1409,7 @@ SwRangeRedline::SwRangeRedline(RedlineType eTyp, const
SwPaM& rPam, sal_uInt32 n
? SwResId(STR_REDLINE_COMMENT_DELETED)
: SwResId(STR_REDLINE_COMMENT_ADDED) );
-if (comphelper::LibreOfficeKit::isActive())
-{
-auto eHintType = RedlineType::Delete == eTyp ?
SwFormatFieldHintWhich::REDLINED_DELETION: SwFormatFieldHintWhich::INSERTED;
-const SwTextNode *pTextNode = rPam.GetPointNode().GetTextNode();
-SwTextAttr* pTextAttr = pTextNode ?
pTextNode->GetFieldTextAttrAt(rPam.GetPoint()->GetContentIndex() - 1,
::sw::GetTextAttrMode::Default) : nullptr;
-SwTextField *const
pTextField(static_txtattr_cast(pTextAttr));
-if (pTextField)
-
const_cast(pTextField->GetFormatField()).Broadcast(SwFormatFieldHint(>GetFormatField(),
eHintType));
-}
+lcl_LOKBroadcastCommentOperation(eTyp, rPam);
}
}
@@ -1417,6 +1425,16 @@ SwRangeRedline::SwRangeRedline( const SwRedlineData&
rData, const SwPaM& rPam )
m_bIsVisible = true;
if( !rPam.HasMark() )
DeleteMark();
+
+// set default comment for single annotations added or deleted
+if (
[Bug 159512] LibreOffice Calc ODS files saved with passwords under 7.6.4 (X86_64) cannot be opened in 24.2.0.3 (X86_64) (Windows 7)
https://bugs.documentfoundation.org/show_bug.cgi?id=159512 --- Comment #21 from ady --- The following side note might be related to the origin of the problem. Context: * VBox VM with *no network connection*. * Guest OS (plus VBox Guest Additions): Win 7 SP1 x32 (build 7601) from 2018-08 (aka August 2018 "refresh"). * Installed on the Guest OS: Current MS Visual C++ Redistributable x86 version 14.38.33135.0. * Installed on the Guest OS: LibreOffice 24.8 alpha 32 bits Win-x86 downloaded from: dev-builds.libreoffice.org/daily/master/Win-x86@39/2024-02-17_00.08.15 NAME: master~2024-02-17_00.08.15_LibreOfficeDev_24.8.0.0.alpha0_Win_x86.msi SIZE: 217'223'168 bytes MD5: 41344864ef938f290037ad93fd8fdb78 Note: I attempted to install KB3063858 (x86) mentioned in the System Requirements for Windows 7 SP1, but the procedure resulted in a message that says "The update is not applicable to your computer". I don't know whether this is because the Win 7 SP1 "refresh" is dated later than KB3063858 (which, AFAIU, it is), or because some other reason. RESULT: After installation, when trying to run LibreOffice, the following message is shown on screen (and LO does _not_ start): soffice.bin - Entry Point Not Found The procedure entry point BCCryptKeyDerivation could not be located in the dynamic link library bcrypt.dll. This suggests that LO (at least 24.8 alpha, and possibly other versions too) requires a specific version (or versions) of bcrypt.dll that is (are) not necessarily installed on every Windows 7 (SP1) system. Maybe an updated (after 2018-08) bcrypt.dll for Windows 7 might not have these problems; that is yet to be tested (by knowledgeable devs). There might be some MS's patch (whether after 2018-08, or rolling back to some older point) that might solve the bcrypt.dll problem. Or, there might be some legal way for users to obtain and install a valid bcrypt.dll file for Windows 7 SP1 that would not generate this (compatibility?) problem(s) for LO. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 45315] [UI] Some relation elements (precedes and following) shown with different font
https://bugs.documentfoundation.org/show_bug.cgi?id=45315 --- Comment #17 from Doramavip --- https://doramavip.com/;>DoramaVip es la mejor plataforma para ver dramas coreanos, dramas chinos, dramas tailandeses y más en subtítulos en español de forma gratuita. -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'libreoffice-24-2-1' - 2 commits - download.lst external/nss
download.lst|4 ++-- external/nss/README | 26 +++--- 2 files changed, 13 insertions(+), 17 deletions(-) New commits: commit 1742ce27ded54cc541356ae0a7b429a120341b70 Author: Michael Stahl AuthorDate: Fri Feb 16 10:34:54 2024 +0100 Commit: Caolán McNamara CommitDate: Sat Feb 17 20:33:40 2024 +0100 nss: upgrade to release 3.98 Fixes CVE-2023-5388 Also update README, and remove obsolete documentation of Debian's mangled SONAME; relevant Debian changelog: nss (2:3.13.4-2) unstable; urgency=low * debian/control, debian/libnss3*, debian/rules, mozilla/security/coreconf/*, mozilla/security/nss/lib/*/manifest.mn: Move to unversioned library. ABI compatibility is ensured upstream, and the SO version, if it needed a change at any time, would be a change in the library name. There is no reason to keep making compatibility more difficult with other distros and upstream binary releases. While previous versions were one-way compatible (binaries built against other distros or upstream nspr could work on Debian), this approach works both ways. -- Mike Hommey Thu, 17 May 2012 09:45:36 +0200 Change-Id: Ifc1eae68827fa88ae001a3903c8555af67b488ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163482 Tested-by: Michael Stahl Reviewed-by: Michael Stahl (cherry picked from commit c5e7af92ebcde59cb72fda2a88d08dc6656dc2e2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163504 Tested-by: Jenkins Reviewed-by: Xisco Fauli Signed-off-by: Xisco Fauli Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163520 Tested-by: Caolán McNamara Reviewed-by: Caolán McNamara diff --git a/download.lst b/download.lst index 11e012c78446..06d4416d09cf 100644 --- a/download.lst +++ b/download.lst @@ -477,8 +477,8 @@ MYTHES_TARBALL := mythes-1.2.5.tar.xz # three static lines # so that git cherry-pick # will not run into conflicts -NSS_SHA256SUM := a7a920d295998563b33d9e06c1a36b799201493d81b64537fab42f2a733411ce -NSS_TARBALL := nss-3.97-with-nspr-4.35.tar.gz +NSS_SHA256SUM := 59bb55a59b02e4004fc26ad0aa1a13fe8d73c6c90c447dd2f2efb73fb81083ed +NSS_TARBALL := nss-3.98-with-nspr-4.35.tar.gz # three static lines # so that git cherry-pick # will not run into conflicts diff --git a/external/nss/README b/external/nss/README index 6997cea6ca06..09931f64ea20 100644 --- a/external/nss/README +++ b/external/nss/README @@ -1,5 +1,16 @@ Contains the Network Security Services (NSS) libraries from Mozilla +== ESR versions == + +Upstream releases both regular and "ESR" versions, the latter go into Firefox +ESR and Thunderbird. + +There is a new ESR version about once a year, and a ESR version gets micro +updates only when there are security issues to fix, and it's not always obvious +from the release notes of a regular release if there are security issues that +are relevant to LibreOffice, hence it's probably best to bundle only the ESR +versions and upgrade for every micro release (as recommended by upstream). + == Fips 140 and signed libraries == Fips 140 mode is not supported. That is, the *.chk files containing the @@ -20,18 +31,3 @@ With all supported macOS SDK we use NSS_USE_SYSTEM_SQLITE=1 to build using the system sqlite. -== system NSS on Linux == - -Note that different Linux distributions use different SONAMEs for the -NSS libraries, so it is not possible to use --with-system-nss and build -a portable generic LO installation set, despite NSS upstream apparently -maintaining ABI compatibility. - -Debian Squeeze: -0x000e (SONAME) Library soname: [libnss3.so.1d] -Fedora 20: -0x000e (SONAME) Library soname: [libnss3.so] - -For the record, the LSB specified SONAME is libnss3.so -http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/libnss3.html - commit 743c626c7ebd04d06a4c8e71c21a7589dfa8ddd9 Author: Andras Timar AuthorDate: Wed Feb 14 22:18:30 2024 +0100 Commit: Caolán McNamara CommitDate: Sat Feb 17 20:33:30 2024 +0100 nss: upgrade to release 3.97 Change-Id: If0eaf6a93f57239d81491c635922745bf3f38fd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163410 Tested-by: Jenkins Reviewed-by: Caolán McNamara (cherry picked from commit f25b7efba56757b085f7a836f57d9c2fc8fd14b8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163407 Reviewed-by: Xisco Fauli (cherry picked from commit 74486211adfb81a8b4d23c51457ff62acd804956) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163498 Tested-by: Caolán McNamara diff --git a/download.lst b/download.lst index f3c7f038740b..11e012c78446 100644 --- a/download.lst +++ b/download.lst @@ -477,8 +477,8 @@ MYTHES_TARBALL := mythes-1.2.5.tar.xz # three static lines # so that git cherry-pick # will not run into conflicts -NSS_SHA256SUM
core.git: sw/source
sw/source/core/crsr/pam.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 974d6b443208050b0aa3ae8df32e121ab7a474ec
Author: Pranam Lashkari
AuthorDate: Fri Feb 16 00:59:49 2024 +0530
Commit: Caolán McNamara
CommitDate: Sat Feb 17 20:21:06 2024 +0100
avoid using subView on empty OUString
it causes assertion failure
rtl::OUString SwPaM::GetText() const: Assertion `(nEnd-nStart) ==
(aTmpStr.getLength() - nStart)' failed
Change-Id: Ie479f224e8a1516735f96c3a09181d4c46dba10d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163461
Reviewed-by: Noel Grandin
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Gökay ŞATIR
(cherry picked from commit 0b0b70772f2d9836010e523bff0132b626713862)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163501
Tested-by: Jenkins
diff --git a/sw/source/core/crsr/pam.cxx b/sw/source/core/crsr/pam.cxx
index 79d9718b59fd..6fc9c6f5d6b7 100644
--- a/sw/source/core/crsr/pam.cxx
+++ b/sw/source/core/crsr/pam.cxx
@@ -1323,7 +1323,7 @@ OUString SwPaM::GetText() const
}
const OUString& aTmpStr = pTextNode->GetText();
-if (bIsStartNode || bIsEndNode)
+if (!aTmpStr.isEmpty() && (bIsStartNode || bIsEndNode))
{
// Handle corner cases of start/end node(s)
const sal_Int32 nStart = bIsStartNode
core.git: sc/qa sc/source
sc/qa/unit/tiledrendering/data/edit-shape-text.ods |binary
sc/qa/unit/tiledrendering/tiledrendering.cxx | 54 +
sc/source/ui/view/gridwin4.cxx |7 +-
3 files changed, 59 insertions(+), 2 deletions(-)
New commits:
commit 021c93bbf36a9d25ad43da0aefd39d5e7bfdad19
Author: Caolán McNamara
AuthorDate: Thu Feb 15 21:41:34 2024 +
Commit: Caolán McNamara
CommitDate: Sat Feb 17 20:17:58 2024 +0100
kit: editing text in shapes outside the topleft tile has misplaced text
keep into account the zoom factor as we do elsewhere
Change-Id: I024ba16c2ef47c01f05ffb8630ec0ae3b2d2e5a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163515
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Caolán McNamara
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163526
Tested-by: Jenkins
diff --git a/sc/qa/unit/tiledrendering/data/edit-shape-text.ods
b/sc/qa/unit/tiledrendering/data/edit-shape-text.ods
new file mode 100644
index ..95fea6d3f738
Binary files /dev/null and b/sc/qa/unit/tiledrendering/data/edit-shape-text.ods
differ
diff --git a/sc/qa/unit/tiledrendering/tiledrendering.cxx
b/sc/qa/unit/tiledrendering/tiledrendering.cxx
index c7d43a141a84..d371d817ffa5 100644
--- a/sc/qa/unit/tiledrendering/tiledrendering.cxx
+++ b/sc/qa/unit/tiledrendering/tiledrendering.cxx
@@ -3712,6 +3712,60 @@ CPPUNIT_TEST_FIXTURE(ScTiledRenderingTest,
testExtendedAreasDontOverlap)
aView1.m_aInvalidations[1].Top());
}
+static Bitmap getTile(ScModelObj* pModelObj, int nTilePosX, int nTilePosY,
tools::Long nTileWidth, tools::Long nTileHeight)
+{
+size_t nCanvasSize = 1024;
+size_t nTileSize = 256;
+std::vector aPixmap(nCanvasSize * nCanvasSize * 4, 0);
+ScopedVclPtrInstance xDevice(DeviceFormat::WITHOUT_ALPHA);
+xDevice->SetBackground(Wallpaper(COL_TRANSPARENT));
+xDevice->SetOutputSizePixelScaleOffsetAndLOKBuffer(Size(nCanvasSize,
nCanvasSize),
+Fraction(1.0), Point(), aPixmap.data());
+pModelObj->paintTile(*xDevice, nCanvasSize, nCanvasSize, nTilePosX,
nTilePosY, nTileWidth, nTileHeight);
+xDevice->EnableMapMode(false);
+return xDevice->GetBitmap(Point(0, 0), Size(nTileSize, nTileSize));
+}
+
+// Ensure that editing a shape not in the topleft tile has its text shown
inside the shape
+// center while editing
+CPPUNIT_TEST_FIXTURE(ScTiledRenderingTest, testEditShapeText)
+{
+ScModelObj* pModelObj = createDoc("edit-shape-text.ods");
+
+// Set View to initial 100%
+pModelObj->setClientVisibleArea(tools::Rectangle(0, 0, 28050, 10605));
+pModelObj->setClientZoom(256, 256, 1920, 1920);
+
+ScTabViewShell* pView =
dynamic_cast(SfxViewShell::Current());
+CPPUNIT_ASSERT(pView);
+
+const bool bShapeSelected = pView->SelectObject(u"Shape 1");
+CPPUNIT_ASSERT(bShapeSelected);
+
+
CPPUNIT_ASSERT(ScDocShell::GetViewData()->GetScDrawView()->AreObjectsMarked());
+
+Scheduler::ProcessEventsToIdle();
+
+// Enter editing mode, shape start with no text
+pModelObj->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, awt::Key::F2);
+pModelObj->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, awt::Key::F2);
+
+Scheduler::ProcessEventsToIdle();
+
+// Grab a snapshot of the center of the shape
+Bitmap aBitmapBefore = getTile(pModelObj, 4096, 3584, 15360, 7680);
+
+// reuse this to type into the active shape edit
+lcl_typeCharsInCell("MMM", 0, 0, pView, pModelObj, true, false);
+
+// Grab a new snapshot of the center of the shape
+Bitmap aBitmapAfter = getTile(pModelObj, 4096, 3584, 15360, 7680);
+
+// Without the fix, the text is not inside this tile and the before and
+// after are the same.
+CPPUNIT_ASSERT_MESSAGE("Text is not visible", aBitmapBefore !=
aBitmapAfter);
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/ui/view/gridwin4.cxx b/sc/source/ui/view/gridwin4.cxx
index 463b5ac32704..6cd017d271b2 100644
--- a/sc/source/ui/view/gridwin4.cxx
+++ b/sc/source/ui/view/gridwin4.cxx
@@ -1062,8 +1062,11 @@ void ScGridWindow::DrawContent(OutputDevice ,
const ScTableInfo& rTableI
aOrigin.setY(o3tl::convert(aOrigin.getY(), o3tl::Length::twip,
o3tl::Length::px)
+ aOutputData.nScrY);
-aOrigin = Point(aOrigin.getX() * twipFactor,
-aOrigin.getY() * twipFactor);
+
+// keep into account the zoom factor
+aOrigin = Point((aOrigin.getX() * twipFactor) /
static_cast(aDrawMode.GetScaleX()),
+ (aOrigin.getY() * twipFactor) /
static_cast(aDrawMode.GetScaleY()));
+
MapMode aNew = rDevice.GetMapMode();
aNew.SetOrigin(aOrigin);
rDevice.SetMapMode(aNew);
[Bug 101313] Copy-paste a Table With Merged Cells from Writer to Calc: Cells Placed in Wrong Position (Wrong cell offsets)
https://bugs.documentfoundation.org/show_bug.cgi?id=101313 Commit Notification changed: What|Removed |Added Whiteboard|target:24.8.0 target:7.6.6 |target:24.8.0 target:7.6.6 ||target:24.2.2 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 101313] Copy-paste a Table With Merged Cells from Writer to Calc: Cells Placed in Wrong Position (Wrong cell offsets)
https://bugs.documentfoundation.org/show_bug.cgi?id=101313 Commit Notification changed: What|Removed |Added Whiteboard|target:24.8.0 |target:24.8.0 target:7.6.6 -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'libreoffice-7-6' - sc/source
sc/source/filter/rtf/rtfparse.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 034f6c29c309561e75719142c305245ac19f7ba9
Author: Noel Grandin
AuthorDate: Fri Feb 16 19:31:57 2024 +0200
Commit: Noel Grandin
CommitDate: Sat Feb 17 20:16:44 2024 +0100
tdf#101313 Copy-paste table from writer to calc
With Merged Cells from Writer to Calc,
Cells Placed in Wrong Position (Wrong cell offsets).
regression from
commit ed24564ce11683731b820c29d5a46e073ab7a2a7
Author: Noel Grandin
Date: Thu Jul 19 15:22:31 2012 +0200
SV_DECL_VARARR_SORT(ScRTFColTwips) o3tl::sorted_vector
Change-Id: I8c90c19f6a27a368fd5807b3eaab84ce820e26e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163518
Tested-by: Jenkins
Reviewed-by: Noel Grandin
(cherry picked from commit 4df426e429e1aed92f074d8acd3ba3a5ec335ba9)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163533
diff --git a/sc/source/filter/rtf/rtfparse.cxx
b/sc/source/filter/rtf/rtfparse.cxx
index b2d2b8c2521f..0617a86c62b1 100644
--- a/sc/source/filter/rtf/rtfparse.cxx
+++ b/sc/source/filter/rtf/rtfparse.cxx
@@ -101,8 +101,8 @@ inline void ScRTFParser::NextRow()
bool ScRTFParser::SeekTwips( sal_uInt16 nTwips, SCCOL* pCol )
{
-ScRTFColTwips::const_iterator it = aColTwips.find( nTwips );
-bool bFound = it != aColTwips.end();
+ScRTFColTwips::const_iterator it = aColTwips.lower_bound( nTwips );
+bool bFound = it != aColTwips.end() && *it == nTwips;
sal_uInt16 nPos = it - aColTwips.begin();
*pCol = static_cast(nPos);
if ( bFound )
core.git: Branch 'libreoffice-24-2' - sc/source
sc/source/filter/rtf/rtfparse.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit b5a5cae0e78e989c421a376bb55a724981c74d87
Author: Noel Grandin
AuthorDate: Fri Feb 16 19:31:57 2024 +0200
Commit: Noel Grandin
CommitDate: Sat Feb 17 20:16:35 2024 +0100
tdf#101313 Copy-paste table from writer to calc
With Merged Cells from Writer to Calc,
Cells Placed in Wrong Position (Wrong cell offsets).
regression from
commit ed24564ce11683731b820c29d5a46e073ab7a2a7
Author: Noel Grandin
Date: Thu Jul 19 15:22:31 2012 +0200
SV_DECL_VARARR_SORT(ScRTFColTwips) o3tl::sorted_vector
Change-Id: I8c90c19f6a27a368fd5807b3eaab84ce820e26e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163518
Tested-by: Jenkins
Reviewed-by: Noel Grandin
(cherry picked from commit 4df426e429e1aed92f074d8acd3ba3a5ec335ba9)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163532
diff --git a/sc/source/filter/rtf/rtfparse.cxx
b/sc/source/filter/rtf/rtfparse.cxx
index b2d2b8c2521f..0617a86c62b1 100644
--- a/sc/source/filter/rtf/rtfparse.cxx
+++ b/sc/source/filter/rtf/rtfparse.cxx
@@ -101,8 +101,8 @@ inline void ScRTFParser::NextRow()
bool ScRTFParser::SeekTwips( sal_uInt16 nTwips, SCCOL* pCol )
{
-ScRTFColTwips::const_iterator it = aColTwips.find( nTwips );
-bool bFound = it != aColTwips.end();
+ScRTFColTwips::const_iterator it = aColTwips.lower_bound( nTwips );
+bool bFound = it != aColTwips.end() && *it == nTwips;
sal_uInt16 nPos = it - aColTwips.begin();
*pCol = static_cast(nPos);
if ( bFound )
[Bug 67347] FILEOPEN: MS .pptx Textbox with stacked text imported wrong size
https://bugs.documentfoundation.org/show_bug.cgi?id=67347 --- Comment #36 from Gerald Pfeifer --- Looking at bug #151102 and the document from attachment #182595 there, this looks much, much better. Just the text is vertically higher than in Impress, see the new screenshot in attachment #192614 versus the original comparison in attachment #182596. Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 5a4ab8cb3a3fbf15de11afc5d8876aaa8a7784c9 CPU threads: 12; OS: Linux 6.7; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US -- You are receiving this mail because: You are the assignee for the bug.
[Bug 151102] FILEOPEN PPTX: text renders horizontally (and condensed) instead of vertically
https://bugs.documentfoundation.org/show_bug.cgi?id=151102 --- Comment #4 from Gerald Pfeifer --- Created attachment 192614 --> https://bugs.documentfoundation.org/attachment.cgi?id=192614=edit Screenshot with LibreOffice Impress as of 20240217 As of today, and after Attila Szűcs committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f846efa507252b0584d2753a251f2dd99c34541a tdf#67347 pptx import: stacked text, minimal impl. the situation has improved quite a bit; see this new screenshot. Just the text appears higher vertically than with PowerPoint. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 150884] [META] Sparklines bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=150884 BogdanB changed: What|Removed |Added Depends on||159712 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=159712 [Bug 159712] Sparklines don't take the space of the whole merged cell -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159712] Sparklines don't take the space of the whole merged cell
https://bugs.documentfoundation.org/show_bug.cgi?id=159712 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g Blocks||150884 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=150884 [Bug 150884] [META] Sparklines bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159753] bug inside the bug
https://bugs.documentfoundation.org/show_bug.cgi?id=159753 BogdanB changed: What|Removed |Added Product|Document Liberation Project |LibreOffice Resolution|--- |INVALID CC||buzea.bog...@libreoffice.or ||g Component|General |deletionRequest Status|UNCONFIRMED |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159543] Cannot resize graphical objects that overlap header/footer
https://bugs.documentfoundation.org/show_bug.cgi?id=159543 --- Comment #8 from Bob Harvey --- (In reply to Bogaboga Man from comment #7) > I see the issue. What needs to happen IMO, is to enable inserted object > manipulation by default no matter what the user may have as LO settings for > such an insertion. This way, the immediate urge to "put things right" is > possible. > > My trial with manipulation via its properties especially `wrap` yielded some > headway. I would also add the following as a feature request: > > * Change the frame window title from `Frame` to `Frame properties` It isn't, of course, just an issue with frames... -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159543] Cannot resize graphical objects that overlap header/footer
https://bugs.documentfoundation.org/show_bug.cgi?id=159543 --- Comment #8 from Bob Harvey --- (In reply to Bogaboga Man from comment #7) > I see the issue. What needs to happen IMO, is to enable inserted object > manipulation by default no matter what the user may have as LO settings for > such an insertion. This way, the immediate urge to "put things right" is > possible. > > My trial with manipulation via its properties especially `wrap` yielded some > headway. I would also add the following as a feature request: > > * Change the frame window title from `Frame` to `Frame properties` It isn't, of course, just an issue with frames... -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 159457] Nudging vertically Alt + Up/ Down doesn't work
https://bugs.documentfoundation.org/show_bug.cgi?id=159457 --- Comment #3 from Buovjaga --- Inkscape has the same shortcut for higher precision. Does vertical moving with Alt+Up/Down work for you in Inkscape? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159543] Cannot resize graphical objects that overlap header/footer
https://bugs.documentfoundation.org/show_bug.cgi?id=159543 Buovjaga changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159543] Cannot resize graphical objects that overlap header/footer
https://bugs.documentfoundation.org/show_bug.cgi?id=159543 Buovjaga changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval -- You are receiving this mail because: You are on the CC list for the bug.
core.git: chart2/source
chart2/source/view/charttypes/PieChart.cxx | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
New commits:
commit 5d0093e8c3a862172ca96081d68e7757dfdf6067
Author: Kurt Nordback
AuthorDate: Sat Nov 18 19:43:52 2023 -0700
Commit: Noel Grandin
CommitDate: Sat Feb 17 18:00:49 2024 +0100
tdf#50934: Improvements to fill color for of-pie composite wedge
Change-Id: Ib9f7e3b135bb86e1817edf97b963e3620af7fdf2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160730
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/chart2/source/view/charttypes/PieChart.cxx
b/chart2/source/view/charttypes/PieChart.cxx
index c3d36cd186fb..a946616ea5fe 100644
--- a/chart2/source/view/charttypes/PieChart.cxx
+++ b/chart2/source/view/charttypes/PieChart.cxx
@@ -227,7 +227,6 @@ PieChart::~PieChart()
void PieChart::setScales( std::vector< ExplicitScaleData >&& rScales, bool /*
bSwapXAndYAxis */ )
{
OSL_ENSURE(m_nDimension<=static_cast(rScales.size()),"Dimension
of Plotter does not fit two dimension of given scale sequence");
-m_aCartesianScales = m_pPosHelper->getScales();
m_aPosHelper.setScales( std::move(rScales), true );
}
@@ -1104,17 +1103,23 @@ void PieChart::createOneRing([[maybe_unused]]enum
SubPieType eType,
xPointProperties, aParam, nRingPtCnt,
bConcentricExplosion);
+// Handle coloring of the composite wedge
+sal_Int32 nEnd = pDataSrc->getNPoints(pSeries, eType);
+const sal_Int32 nPropIdx = (
+eType == SubPieType::LEFT && nPointIndex == nEnd - 1 ?
+pSeries->getTotalPointCount() :
+nPointIndex);
///point color:
if (!pSeries->hasPointOwnColor(nPointIndex) && m_xColorScheme.is())
{
xPointShape->setPropertyValue("FillColor",
-uno::Any(m_xColorScheme->getColorByIndex( nPointIndex )));
+uno::Any(m_xColorScheme->getColorByIndex( nPropIdx )));
}
if(bHasFillColorMapping)
{
-double nPropVal = pSeries->getValueByProperty(nPointIndex,
"FillColor");
+double nPropVal = pSeries->getValueByProperty(nPropIdx,
"FillColor");
if(!std::isnan(nPropVal))
{
xPointShape->setPropertyValue("FillColor",
uno::Any(static_cast( nPropVal)));
@@ -2106,16 +2111,16 @@ uno::Reference< beans::XPropertySet >
OfPieDataSrc::getProps(
const VDataSeries* pSeries, sal_Int32 nPtIdx,
enum SubPieType eType) const
{
-const sal_Int32 n = pSeries->getTotalPointCount() - 3;
+const sal_Int32 nPts = pSeries->getTotalPointCount();
+const sal_Int32 n = nPts - 3;
if (eType == SubPieType::LEFT) {
// nPtIdx should be in [0, n]
if (nPtIdx < n) {
return pSeries->getPropertiesOfPoint( nPtIdx );
} else {
-assert(nPtIdx == n);
// The aggregated wedge
-// Not sure what to do here, but this isn't right. TODO
-return pSeries->getPropertiesOfPoint(n);
+assert(nPtIdx == n);
+return pSeries->getPropertiesOfPoint(nPts);
}
} else {
assert(eType == SubPieType::RIGHT);
[Bug 154248] FILEOPEN PPTX: multiline field wrapping breaks rendering of links (and font changes)
https://bugs.documentfoundation.org/show_bug.cgi?id=154248 --- Comment #5 from Gerald Pfeifer --- This looks fine to me now with the latest daily snapshot of Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 5a4ab8cb3a3fbf15de11afc5d8876aaa8a7784c9 CPU threads: 12; OS: Linux 6.7; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US @Timur, you did the original visual analysis; can you confirm as well? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159543] Cannot resize graphical objects that overlap header/footer
https://bugs.documentfoundation.org/show_bug.cgi?id=159543 --- Comment #7 from Bogaboga Man --- I see the issue. What needs to happen IMO, is to enable inserted object manipulation by default no matter what the user may have as LO settings for such an insertion. This way, the immediate urge to "put things right" is possible. My trial with manipulation via its properties especially `wrap` yielded some headway. I would also add the following as a feature request: * Change the frame window title from `Frame` to `Frame properties` -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159543] Cannot resize graphical objects that overlap header/footer
https://bugs.documentfoundation.org/show_bug.cgi?id=159543 Buovjaga changed: What|Removed |Added Status|REOPENED|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159543] Cannot resize graphical objects that overlap header/footer
https://bugs.documentfoundation.org/show_bug.cgi?id=159543 Bob Harvey changed: What|Removed |Added Ever confirmed|0 |1 Status|RESOLVED|REOPENED Resolution|INVALID |--- --- Comment #6 from Bob Harvey --- Woah, just a minute. That's not "invalid". That's a hidden solution. Where in the user interface is that exposed? where in the help pages does it tell you to do that if you can't drag the handles? How the blue blistering blazes is someone supposed to guess they can do that? What about making it a bit more obvious what the problem is? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 151199] Cells and sheet protection
https://bugs.documentfoundation.org/show_bug.cgi?id=151199 Timur changed: What|Removed |Added CC||ti...@libreoffice.org Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #5 from Timur --- I think this may be closed, per explanation. -- You are receiving this mail because: You are the assignee for the bug.
Guidelines for LibreOffice release notes published
Based on ideas from Ady and Stéphane, I wrote a meta level page about release notes: https://wiki.documentfoundation.org/ReleaseNotes/Guidelines Ilmari
[Bug 159754] Bad formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=159754 --- Comment #1 from Eugene Savitsky --- I do not have MSO, but seems like a font problem. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159754] New: Bad formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=159754 Bug ID: 159754 Summary: Bad formatting Product: LibreOffice Version: 24.2.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: eugene.savit...@gmail.com Created attachment 192613 --> https://bugs.documentfoundation.org/attachment.cgi?id=192613=edit affected file See 3rd page. -- You are receiving this mail because: You are the assignee for the bug.
translations.git: Changes to 'refs/tags/libreoffice-7.6.5.2-hotfix1'
Tag 'libreoffice-7.6.5.2-hotfix1' created by Christian Lohmaier at 2024-02-17 13:05 + Tag libreoffice-7.6.5.2-hotfix1 -BEGIN PGP SIGNATURE- iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmXQrysACgkQ9DSh76/u rqNmUw//YE645MTikmmo2S+NkTsv+an7A3fl4hMD9dRn9UBFcBJZZFwy7dchmMBS nSUwdawsn1A+3yU+3ymCKWp77AC0U3yV9mACFrOCQEIvuWKFU+1ddL9+fmJFX2K+ jxCxcPsO7UDgi3hLxFhlw1uaYp8+67Ez0+k+SgVrUP780+saQO/HredQc83YBf+0 2wHl9M7llRkBpHpwBCDv2J5RJF6/MwQP1J97u6ldcKK10ZLcWkxZkpdshZ/u13I3 HwEvsNQiPGoJZCwfxJ2bP80u6Rra4UGayVO4pvnpsTHEWW05W1wEr/QryXHE3GRL pjzxia9ood6ydbIWkNNi8eXxPyF4cew5kNztZ6koLAR5TUhkZihf0vIIUCs2LJ6Z gJQC3lB1fLxlC9bZ0DziSqecLxwGluAmPMjdUZzoxo2CM5tKMizNqNPC4NS3t0ls CZE5RogEqkw0Ge1Fkd001TsDvpaTk79bf8NLpKKDvE+05T/0MCLM86TdI4EMgFPh x2RHVkJodXXMFmaQBz28br2bpiosQL/DHjIHfj2D8GJOpPgARbA3/bN/jyiWZ7NM a7iGzr6I4uTZTPTTaJZSGb/l0/vQZwZpLQZCgDe4j3bvoDwDMAprBZjEq/HQVWzH khS2jUQYmh4PcbXUhKk9/q1/aJ4BnYEE4gDCeseWNO4AVZBV8VM= =W5uX -END PGP SIGNATURE- Changes since libreoffice-7.6.5.2: Christian Lohmaier (1): Version 7.6.5.2, tag libreoffice-7.6.5.2-hotfix1 --- 0 files changed ---
core.git: Changes to 'refs/tags/libreoffice-7.6.5.2-hotfix1'
Tag 'libreoffice-7.6.5.2-hotfix1' created by Christian Lohmaier at 2024-02-17 13:05 + Tag libreoffice-7.6.5.2-hotfix1 -BEGIN PGP SIGNATURE- iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmXQrywACgkQ9DSh76/u rqNW8g/+LYFI0Yfve+DmKZCXBzQV/U0L+5vEzevRCF/Fzqro5c6OM7DDfUiZeB7E svEyrRbn/fRoHiy4KRMaF4Yxu3OGsqrWDnS66Yd/Elac+ja60g+q+I64MGMvm3T9 TAvNjmwAL1aFRBVHr+0cPq11x3purKamh+4n1nCbwxvo0R+RrQv6RvG/DGpdN+V2 veCE7E8/NTb/LZusyowc+c6ejdW1+28iZj4YzT/hufJOd2RR3/4gnIuNGqDHAbmW QpAimLyKQFobrrKdQZhIoKMCTGwp004ScP3HWIgLJT0psrjHGYfTxJuvzU4tUqhS nsf/hLdazgWK9aKuHARIk1ujJOJdKHOFcR2o+gCOqiFupW73yUpM3g3E1XS10F7Z P2nIpbI7yYN8vpFOscZQr+nnyZld3e3CpNU9IJ3L7niLLYSIu/3c29ocaSnq0Yl8 wmuUjUtXiGAsobppZRmQB0h7xD70k1Nl2fp46bJ60exMJA0KXSBD/T8IH3WQdUtU oy1jlkOTR5wYNB0q+LbnMuuUPsG+KMF+/uOevz6zyx17kaoIvtXqzkRmG8Cc+gjq L+cO55Xav2gaP1BStcdgjCP94Xa1glaocue4SWb/cZo4NXJcirrC6Dwb2k5H6FoN jf08mT1CFGyyiabFuvGcd4PdRVCumQ+ZKvaBq9Vtp+nkorcrUVY= =3NOe -END PGP SIGNATURE- Changes since libreoffice-7.6.5.2-4: --- 0 files changed ---
help.git: Changes to 'refs/tags/libreoffice-7.6.5.2-hotfix1'
Tag 'libreoffice-7.6.5.2-hotfix1' created by Christian Lohmaier at 2024-02-17 13:05 + Tag libreoffice-7.6.5.2-hotfix1 -BEGIN PGP SIGNATURE- iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmXQrysACgkQ9DSh76/u rqOxXA//a750+8HZVT0oFUozqvtqYvLHjYFJzdaPvSemZ6k7lbeoymva0pFuDyG/ kpET3Sb3QXX7ofrTrwIwszKnlBIvMdxZUitiDEW2iP2vCpnHXTkkwVwzqcxVP7US 2p/pkY38u2tR6sgdpL8XAEg7hDq3Zr6Jpaui20G/TVEt1aOGAuLs5RJiYgCOA7rG Povp7GRYTBLVpZ6yN3TRBFXtwaOTr9oFamNmJwHsuktZYbv7WA+WFgJDXrr9u04U D1HWxs5fdy4gFJ0uvjCKZjRuw758fA/yur+cgE+cTo2GgXgfoBNQ7oDA+DKHzk2J jkegC8zHnvyOuqUg+1F8+wLCQ5PAA/i/fty9UmrJqBr8I5rPJ4hiimyBW9E/ktqd c6E/p3GpBrlP+dmfk4oB0z0wue8JumNZdQcCDSOhN9MSJBkV64PR6i0X3/lkJv1n 51EzpIpXiSbQfX8e7tst1Rv88yVElbzBs21M/JoweywM0mQr0xp2GJSTcZ4Tyfod oKgeEbVrwPrQuoelAdkwNzCPo9RzXLIqresjCRjOcbaEE9JVMCq57LecwQ6jVgGK oRmcFH2G/H9J9W4y7Ie48zROV9SrlNUliv4phEf9DxIDnHFOLm4UPsNKvZr503KI 9K+5nU6AuchANF83shGT7HKFDo20jBpVxEBw7VQZrdT5smJyhA8= =fIle -END PGP SIGNATURE- Changes since libreoffice-7.6.5.2: Christian Lohmaier (1): Version 7.6.5.2, tag libreoffice-7.6.5.2-hotfix1 --- 0 files changed ---
dictionaries.git: Changes to 'refs/tags/libreoffice-7.6.5.2-hotfix1'
Tag 'libreoffice-7.6.5.2-hotfix1' created by Christian Lohmaier at 2024-02-17 13:05 + Tag libreoffice-7.6.5.2-hotfix1 -BEGIN PGP SIGNATURE- iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmXQrygACgkQ9DSh76/u rqNW+hAApepTa7BZ3Kc7d49lHRyoyTB4YeePkdI/HIORZr5Pj41uTklDBVEYhC43 hAnY/t2QXCWroBx+JeDkwmRnnsh/8ydWiXaGgfScWQOaOL84aGpqUwAo/l3tRwGd p5pteIu9JNWslyCtHA6H0xqeVudfdVcnmbrDsqz05CsG8FWURcBrbPcZc5gBIvm3 vBxdF8cgaWzZ/WVnX518RdVfgZ4S8N2rGhnbZx1x5r8l+O3ckY4TPwVjkbkKtERk 0cROUSPomDAf17i+a8tlpm+mWI8Le7sYxP0WTYGbg1rEzALcFUanhQn//FbOr00/ VbHcXQ9vfyQUim9JjNI1ULRbZwB6maFMSAR8Pu2azMghYT1fvwwVcbwpq/9mRrkP AQWN6R1GRpVzNfX+6fxxTtzsTGDrlpl4L/GuGsnB9SokS+CFxiRLpE577uw81y44 zSGpjFwdjyVJGobOyCAgwBg2jliNqzpobvoYBfhhpr4iC/cwASrJ9iFS0cK8fVJA 8LB5HFljtZx5e9UrrJXcQGr9hj7zcJfM/YrqY01G9L/7Q+zQISvxsd5STt6w5pUN eXIis01dEK8bK0bk+kVzN/Jis9HWwyMym2AluJ+TXB66RA5bL9+RgLJOB8ipbU+I 3vQ7bL44XX0RSW7Fvy+tm2FzBHhLVhrMTg4fj7t4upz9wt5/GwA= =Bm4Y -END PGP SIGNATURE- Changes since libreoffice-7.6.5.2: Christian Lohmaier (1): Version 7.6.5.2, tag libreoffice-7.6.5.2-hotfix1 --- 0 files changed ---
core.git: Branch 'libreoffice-7-6-5' - 2 commits - download.lst solenv/gbuild
download.lst|4 ++-- solenv/gbuild/platform/com_MSC_class.mk |8 ++-- 2 files changed, 8 insertions(+), 4 deletions(-) New commits: commit c1ba4bcef46433fe130ce36639d3cfead1b8b8d1 Author: Mike Kaganski AuthorDate: Fri Feb 16 13:43:20 2024 +0600 Commit: Christian Lohmaier CommitDate: Sat Feb 17 14:00:54 2024 +0100 OpenSSL: upgrade to 3.0.13 Change-Id: Ib03c99a2dbf0f7c932b8a6b953ac9eb9c43f978f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163493 Tested-by: Jenkins Reviewed-by: Christian Lohmaier (cherry picked from commit a268b95d73911f1b92482c4b06d480cfd6eeb0dc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163534 Tested-by: Christian Lohmaier diff --git a/download.lst b/download.lst index 7392c9efb737..63ad7a6b91d2 100644 --- a/download.lst +++ b/download.lst @@ -423,8 +423,8 @@ OPENLDAP_TARBALL := openldap-2.6.6.tgz # three static lines # so that git cherry-pick # will not run into conflicts -OPENSSL_SHA256SUM := b3425d3bb4a2218d0697eb41f7fc0cdede016ed19ca49d168b78e8d947887f55 -OPENSSL_TARBALL := openssl-3.0.11.tar.gz +OPENSSL_SHA256SUM := 88525753f79d3bec27d2fa7c66aa0b92b3aa9498dafd93d7cfa4b3780cdae313 +OPENSSL_TARBALL := openssl-3.0.13.tar.gz # three static lines # so that git cherry-pick # will not run into conflicts commit 755bafba7ea3642df99ca0bd2b77e608ffa3e4d3 Author: Hossein AuthorDate: Thu May 25 15:55:11 2023 +0200 Commit: Christian Lohmaier CommitDate: Sat Feb 17 14:00:43 2024 +0100 tdf#155446 Fix problem with ccache on Windows This patch fixes the recent problem with building LibreOffice with ccache on Windows which was caused by the lack of double quotation mark between ccache.exe and path to the MSVC compiler. Change-Id: I1a714513ccb8cd674895d0c887013ea862d3b544 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152277 Tested-by: Jenkins Reviewed-by: Hossein (cherry picked from commit 0c9f095a01682d8cb99a596e568bd81ae96906a5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163505 Reviewed-by: Xisco Fauli (cherry picked from commit aeca67238e26cd148083055e0f223753f7462c14) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163530 Tested-by: Christian Lohmaier Reviewed-by: Christian Lohmaier diff --git a/solenv/gbuild/platform/com_MSC_class.mk b/solenv/gbuild/platform/com_MSC_class.mk index ba42b0ba48df..d8cab84ff7c7 100644 --- a/solenv/gbuild/platform/com_MSC_class.mk +++ b/solenv/gbuild/platform/com_MSC_class.mk @@ -179,7 +179,7 @@ define gb_AsmObject__command $(call gb_Output_announce,$(2),$(true),ASM,3) $(call gb_Helper_abbreviate_dirs,\ mkdir -p $(dir $(1)) $(dir $(4)) && \ -"$(CC)" -nologo -EP -D_M_ARM64 $(SOLARINC) $(3) > $(subst .o,.asm,$(1)) && \ +$(CC) -nologo -EP -D_M_ARM64 $(SOLARINC) $(3) > $(subst .o,.asm,$(1)) && \ "$(ML_EXE)" $(gb_AFLAGS) -g -errorReport:prompt -o $(1) $(subst .o,.asm,$(1)), \ ) && \ echo "$(1) : $(3)" > $(4) @@ -664,8 +664,12 @@ gb_AUTOCONF_WRAPPERS = \ gb_ExternalProject_INCLUDE := \ $(subst -I,,$(subst $(WHITESPACE),;,$(SOLARINC))) +# Workaround for openssl build - it puts the CC var into additional pair of quotes. This breaks if +# CC consists of more than a single element such as when using "ccache compiler". In case the +# variables are exported for openssl, it closes and reopens the quotes after each element. gb_NMAKE_VARS = \ - CC="$(shell cygpath -w $(filter-out -%,$(CC))) $(filter -%,$(CC))" \ + CC="$(subst $(WHITESPACE),$(if $(filter openssl,$(1)),\" \", ),$(strip \ + $(shell cygpath -ws $(filter-out -%,$(CC))) $(filter -%,$(CC" \ INCLUDE="$(gb_ExternalProject_INCLUDE)" \ LIB="$(ILIB)" \ MAKEFLAGS= \
core.git: Branch 'libreoffice-7-6-5' - 2 commits - download.lst external/nss
download.lst|4 ++-- external/nss/README | 26 +++--- 2 files changed, 13 insertions(+), 17 deletions(-) New commits: commit a5087b37ffcc5f686f1fe9371ab411b81006ad92 Author: Michael Stahl AuthorDate: Fri Feb 16 10:34:54 2024 +0100 Commit: Christian Lohmaier CommitDate: Sat Feb 17 14:00:26 2024 +0100 nss: upgrade to release 3.98 Fixes CVE-2023-5388 Also update README, and remove obsolete documentation of Debian's mangled SONAME; relevant Debian changelog: nss (2:3.13.4-2) unstable; urgency=low * debian/control, debian/libnss3*, debian/rules, mozilla/security/coreconf/*, mozilla/security/nss/lib/*/manifest.mn: Move to unversioned library. ABI compatibility is ensured upstream, and the SO version, if it needed a change at any time, would be a change in the library name. There is no reason to keep making compatibility more difficult with other distros and upstream binary releases. While previous versions were one-way compatible (binaries built against other distros or upstream nspr could work on Debian), this approach works both ways. -- Mike Hommey Thu, 17 May 2012 09:45:36 +0200 Change-Id: Ifc1eae68827fa88ae001a3903c8555af67b488ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163494 Tested-by: Jenkins Reviewed-by: Christian Lohmaier (cherry picked from commit a3b49781403102ed8439fad11b1ba0c5457d7606) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163506 Tested-by: Christian Lohmaier diff --git a/download.lst b/download.lst index c034dca3ccd6..7392c9efb737 100644 --- a/download.lst +++ b/download.lst @@ -397,8 +397,8 @@ MYTHES_TARBALL := mythes-1.2.5.tar.xz # three static lines # so that git cherry-pick # will not run into conflicts -NSS_SHA256SUM := a7a920d295998563b33d9e06c1a36b799201493d81b64537fab42f2a733411ce -NSS_TARBALL := nss-3.97-with-nspr-4.35.tar.gz +NSS_SHA256SUM := 59bb55a59b02e4004fc26ad0aa1a13fe8d73c6c90c447dd2f2efb73fb81083ed +NSS_TARBALL := nss-3.98-with-nspr-4.35.tar.gz # three static lines # so that git cherry-pick # will not run into conflicts diff --git a/external/nss/README b/external/nss/README index 6997cea6ca06..09931f64ea20 100644 --- a/external/nss/README +++ b/external/nss/README @@ -1,5 +1,16 @@ Contains the Network Security Services (NSS) libraries from Mozilla +== ESR versions == + +Upstream releases both regular and "ESR" versions, the latter go into Firefox +ESR and Thunderbird. + +There is a new ESR version about once a year, and a ESR version gets micro +updates only when there are security issues to fix, and it's not always obvious +from the release notes of a regular release if there are security issues that +are relevant to LibreOffice, hence it's probably best to bundle only the ESR +versions and upgrade for every micro release (as recommended by upstream). + == Fips 140 and signed libraries == Fips 140 mode is not supported. That is, the *.chk files containing the @@ -20,18 +31,3 @@ With all supported macOS SDK we use NSS_USE_SYSTEM_SQLITE=1 to build using the system sqlite. -== system NSS on Linux == - -Note that different Linux distributions use different SONAMEs for the -NSS libraries, so it is not possible to use --with-system-nss and build -a portable generic LO installation set, despite NSS upstream apparently -maintaining ABI compatibility. - -Debian Squeeze: -0x000e (SONAME) Library soname: [libnss3.so.1d] -Fedora 20: -0x000e (SONAME) Library soname: [libnss3.so] - -For the record, the LSB specified SONAME is libnss3.so -http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/libnss3.html - commit 19115995ee7dcb760e8ad08457c012f28b86ec78 Author: Andras Timar AuthorDate: Wed Feb 14 22:18:30 2024 +0100 Commit: Christian Lohmaier CommitDate: Sat Feb 17 14:00:16 2024 +0100 nss: upgrade to release 3.97 Change-Id: If0eaf6a93f57239d81491c635922745bf3f38fd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163410 Tested-by: Jenkins Reviewed-by: Caolán McNamara (cherry picked from commit f25b7efba56757b085f7a836f57d9c2fc8fd14b8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163408 Reviewed-by: Xisco Fauli (cherry picked from commit 85c6a7a4944efa5b91e25a35860997e254d35f4c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163503 Tested-by: Christian Lohmaier Reviewed-by: Christian Lohmaier diff --git a/download.lst b/download.lst index 54c36e4ddbd0..c034dca3ccd6 100644 --- a/download.lst +++ b/download.lst @@ -397,8 +397,8 @@ MYTHES_TARBALL := mythes-1.2.5.tar.xz # three static lines # so that git cherry-pick # will not run into conflicts -NSS_SHA256SUM := f78ab1d911cae8bbc94758fb3bd0f731df4087423a4ff5db271ba65381f6b739 -NSS_TARBALL := nss-3.90-with-nspr-4.35.tar.gz +NSS_SHA256SUM :=
[Bug 158962] Assigning a different list style to nested list removes its indentation (see comment 6)
https://bugs.documentfoundation.org/show_bug.cgi?id=158962 --- Comment #10 from Buovjaga --- (In reply to bintoro from comment #9) > @Buovjaga: > > I’m not sure about the reworded summary. Removing a list’s indentation is > one thing; a workaround would be simply to re-indent. But the bug at hand is > about something different: Writer terminates the current list and starts a > new one. For that, there is no workaround. > > Also, if a list style is applied directly instead of via a paragraph style, > the apparent indentation level isn’t even reset. Writer creates a new list > and automatically adds empty levels to it in order to preserve the current > position. So, things appear to work just fine and you seem to be able to > format the sublist independently. But in actuality the structure is turned > into the one described in the initial comment. Ok, then feel free to tweak the summary. -- You are receiving this mail because: You are the assignee for the bug.
core.git: sw/inc sw/source
sw/inc/docary.hxx |7 ++-
sw/source/core/doc/docredln.cxx |2 +-
sw/source/core/doc/doctxm.cxx |6 +++---
sw/source/core/docnode/nodes.cxx |6 +++---
sw/source/core/layout/findfrm.cxx | 12 +---
sw/source/core/layout/tabfrm.cxx | 14 +++---
sw/source/core/layout/trvlfrm.cxx | 22 +++---
7 files changed, 32 insertions(+), 37 deletions(-)
New commits:
commit b065496b23f249d9c08a6267d2aaa2fd1c81e56a
Author: Mike Kaganski
AuthorDate: Sat Feb 17 16:41:41 2024 +0600
Commit: Mike Kaganski
CommitDate: Sat Feb 17 13:50:51 2024 +0100
Remove more unneeded const_cast
Change-Id: If62cf2011ae63501cdf5e87a6ee7402aa74b2b3b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163525
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sw/inc/docary.hxx b/sw/inc/docary.hxx
index dce6a44b7576..5cd132f0ef44 100644
--- a/sw/inc/docary.hxx
+++ b/sw/inc/docary.hxx
@@ -131,7 +131,7 @@ public:
erase( begin() + aStartIdx, begin() + aEndIdx);
}
-size_t GetPos(Value const& p) const
+size_t GetPos(typename std::remove_pointer_t const* const p) const
{
const_iterator const it = std::find(begin(), end(), p);
return it == end() ? SIZE_MAX : it - begin();
@@ -159,9 +159,6 @@ public:
virtual Value GetFormat(size_t idx) const override
{ return SwVectorModifyBase::operator[](idx); }
-size_t GetPos(const SwFormat *p) const
-{ return SwVectorModifyBase::GetPos( static_cast(
const_cast( p ) ) ); }
-
// Override return type to reduce casting
virtual Value FindFormatByName(const OUString& rName) const override
{ return static_cast(SwFormatsBase::FindFormatByName(rName)); }
@@ -230,7 +227,7 @@ private:
mutable sal_uInt32 m_nMaxMovedID = 1; //every move-redline pair get a
unique ID, so they can find each other.
public:
~SwRedlineTable();
-bool Contains(const SwRangeRedline* p) const { return
maVector.find(const_cast(p)) != maVector.end(); }
+bool Contains(const SwRangeRedline* p) const { return maVector.find(p) !=
maVector.end(); }
size_type GetPos(const SwRangeRedline* p) const;
bool Insert(SwRangeRedline*& p);
diff --git a/sw/source/core/doc/docredln.cxx b/sw/source/core/doc/docredln.cxx
index 32696630e591..b8bb35056de1 100644
--- a/sw/source/core/doc/docredln.cxx
+++ b/sw/source/core/doc/docredln.cxx
@@ -658,7 +658,7 @@ SwRedlineTable::~SwRedlineTable()
SwRedlineTable::size_type SwRedlineTable::GetPos(const SwRangeRedline* p) const
{
-vector_type::const_iterator it =
maVector.find(const_cast(p));
+vector_type::const_iterator it = maVector.find(p);
if( it == maVector.end() )
return npos;
return it - maVector.begin();
diff --git a/sw/source/core/doc/doctxm.cxx b/sw/source/core/doc/doctxm.cxx
index af957c8a7318..8acfafbe6dea 100644
--- a/sw/source/core/doc/doctxm.cxx
+++ b/sw/source/core/doc/doctxm.cxx
@@ -859,7 +859,7 @@ void SwTOXBaseSection::Update(const SfxItemSet* pAttr,
{
if (!GetFormat())
return;
-SwSectionNode const*const pSectNd(GetFormat()->GetSectionNode());
+SwSectionNode* const pSectNd(GetFormat()->GetSectionNode());
if (nullptr == pSectNd ||
!pSectNd->GetNodes().IsDocNodes() ||
IsHiddenFlag() ||
@@ -873,7 +873,7 @@ void SwTOXBaseSection::Update(const SfxItemSet* pAttr,
maMSTOCExpression.clear();
}
-SwDoc& rDoc = const_cast(pSectNd->GetDoc());
+SwDoc& rDoc = pSectNd->GetDoc();
if (pAttr && GetFormat())
rDoc.ChgFormat(*GetFormat(), *pAttr);
@@ -949,7 +949,7 @@ void SwTOXBaseSection::Update(const SfxItemSet* pAttr,
: nullptr;
SwNode2LayoutSaveUpperFrames aN2L(*pSectNd);
-const_cast(pSectNd)->DelFrames();
+pSectNd->DelFrames();
// This would be a good time to update the Numbering
rDoc.UpdateNumRule();
diff --git a/sw/source/core/docnode/nodes.cxx b/sw/source/core/docnode/nodes.cxx
index d180a3a584c6..23729d1bedc0 100644
--- a/sw/source/core/docnode/nodes.cxx
+++ b/sw/source/core/docnode/nodes.cxx
@@ -283,7 +283,7 @@ void SwNodes::ChgNode( SwNodeIndex const & rDelPos,
SwNodeOffset nSz,
SwTextField* pTextField =
static_txtattr_cast(pAttr);
rNds.GetDoc().getIDocumentFieldsAccess().InsDelFieldInFieldLst( !bToUndo,
*pTextField );
-const SwFieldType* pTyp =
pTextField->GetFormatField().GetField()->GetTyp();
+SwFieldType* pTyp =
pTextField->GetFormatField().GetField()->GetTyp();
if ( SwFieldIds::Postit == pTyp->Which() )
{
rNds.GetDoc().GetDocShell()->Broadcast(
@@ -296,9 +296,9 @@ void SwNodes::ChgNode( SwNodeIndex const & rDelPos,
SwNodeOffset nSz,
[Bug 159752] 17 Noto Fonts dropped from 24.2 bundle without notice (and 1 added)
https://bugs.documentfoundation.org/show_bug.cgi?id=159752 Julien Nabet changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||4591 CC||kha...@libreoffice.org, ||serval2...@yahoo.fr --- Comment #1 from Julien Nabet --- Khaled: thought you might be interested in this one. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159751] Text import dialogue does not show multiple column selection in 24.2 with Skia rendering
https://bugs.documentfoundation.org/show_bug.cgi?id=159751 ady changed: What|Removed |Added Summary|Text import dialogue does |Text import dialogue does |not show multiple column|not show multiple column |selection in 24.2 |selection in 24.2 with Skia ||rendering -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159751] Text import dialogue does not show multiple column selection in 24.2
https://bugs.documentfoundation.org/show_bug.cgi?id=159751 --- Comment #3 from ady --- Testing with a recent 24.8 alpha, I can see 1 difference regarding prior versions. NOTE: This problem happens with the setting "Use Skia for all rendering" ENABLED. Until LO 7.6, when using [CTRL] to select multiple columns in the import/paste unformatted dialogue, each selected column would be seen with its background color inverted (e.g. painted as black with white fonts). This identifies the selected columns more clearly. When testing with a recent LO 24.8, there is no _clear_ indication that multiple columns were selected. I can barely see some kind of edge/border (or it might be my imagination), but IMO it is not as a clear indication as the inverted background color. Having said that, the actual selection of multiple columns does occur; this is only a visual problem. For instance, select multiple columns and change them to "text". The selected columns will change to "text", although there was no inverted background color indicating that the columns were selected. As mentioned, this visual problem happens with Skia ON, same as the guiding edge when we drag a selected range to move/copy. This has been reported already in some other ticket (which should rather have a higher priority, IMHO) IMO, this SKIA issue should be resolved ASAP, before we get dozens of reports about the "same" problem starting in LO 24.2. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159751] Text import dialogue does not show multiple column selection in 24.2
https://bugs.documentfoundation.org/show_bug.cgi?id=159751 --- Comment #2 from ady --- (In reply to ady from comment #1) > NOTE: This problem happens with the setting "Use Skia for all rendering" > disabled. Oops!, this happens with that Skia option ENABLED. When disabling it, the old, normal, correct and expected visual behavior can be seen. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159751] Text import dialogue does not show multiple column selection in 24.2
https://bugs.documentfoundation.org/show_bug.cgi?id=159751 ady changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Keywords||bibisectRequest, ||regression, topicUI Summary|Text import doesn’t allow |Text import dialogue does |multiple column selection |not show multiple column |in 24.2 |selection in 24.2 CC||heiko.tietze@documentfounda ||tion.org --- Comment #1 from ady --- Testing with a recent 24.8 alpha, I can see 1 difference regarding prior versions. NOTE: This problem happens with the setting "Use Skia for all rendering" disabled. Until LO 7.6, when using [CTRL] to select multiple columns in the import/paste unformatted dialogue, each selected column would be seen with its background color inverted (e.g. painted as black with white fonts). This identifies the selected columns more clearly. When testing with a recent LO 24.8, there is no _clear_ indication that multiple columns were selected. I can barely see some kind of edge/border (or it might be my imagination), but IMO it is not as a clear indication as the inverted background color. Having said that, the actual selection of multiple columns does occur; this is only a visual problem. For instance, select multiple columns and change them to "text". The selected columns will change to "text", although there was no inverted background color indicating that the columns were selected. As mentioned, this visual problem happens with Skia OFF, same as the guiding edge when we drag a selected range to move/copy. This has been reported already in some other ticket (which should rather have a higher priority, IMHO) IMO, this SKIA issue should be resolved ASAP, before we get dozens of reports about the "same" problem starting in LO 24.2. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159746] MacMini M2Pro (Mac OS Sonoma 14.3.1) HUNG while editing a .docx document using LibreOffice Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=159746 --- Comment #5 from stepped_canyon...@icloud.com --- Created attachment 192612 --> https://bugs.documentfoundation.org/attachment.cgi?id=192612=edit Client Fact Find Questionnaire (.docx format) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159748] UI: Cell protection dialog reference menu that don't exist
https://bugs.documentfoundation.org/show_bug.cgi?id=159748 --- Comment #6 from ady --- (In reply to Timur from comment #5) > When user sees "Tools menu" in Tabbed, he will not look after how to turn > that manu, rather will just notice that Tools is missing. Seen multiple > times. > So it would be desirable to have text clear for user. > Either change contextually or add "Review tab" or remove "Tools menu". > I add UXeval, needs a mail also. I completely disagree. The menu items are more consistent than any of the diverse UI methods. At some version some UI variant gets changed, or added, or deprecated. Such modifications happen much less frequently on menu items and are more common in other spreadsheet tools too. The help text points to the item that is consistent in whichever UI. The fact that some users don't display the menu bar by default is not a reason to change the help text. If such were to be the normal procedure, developers would have to make every help text dependent on each and every possibility or combination of UI elements. As I mentioned, most users would just use the context menu on the worksheet tab (where the name of the worksheet is shown. And even then, you could have hidden worksheet, either protected or unprotected. It would make the help text dependent and varying on a lot of UI variations, and every time the layout and/or features of an UI variant would change, developers would have to review every single help text or tool tip in order to adapt it to some minor change. There is no workaround to learning what a _menu_ is vs what a toolbar is, especially when the software is not as simple as a basic/simple text editor. If users play with UI variants, they have to eventually learn these things too. Knowing where the menu is located and/or how to arrive to that element is much simpler than understanding how Protection works for spreadsheets. -- You are receiving this mail because: You are the assignee for the bug.
core.git: sc/source
sc/source/ui/view/gridwin4.cxx |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) New commits: commit 8baacea92374319e6f796dca4d1aec7663647105 Author: Caolán McNamara AuthorDate: Thu Feb 15 21:36:46 2024 + Commit: Caolán McNamara CommitDate: Sat Feb 17 12:15:27 2024 +0100 clarify that "twipFactor" converts from pixels to 100mm Change-Id: I7ce9a797b2a2132f0858dafc98bc3a105b8d0098 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163479 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/sc/source/ui/view/gridwin4.cxx b/sc/source/ui/view/gridwin4.cxx index f4aeabfc1447..463b5ac32704 100644 --- a/sc/source/ui/view/gridwin4.cxx +++ b/sc/source/ui/view/gridwin4.cxx @@ -658,6 +658,10 @@ Fraction GetZoom(const ScViewData& rViewData, int i) }; return (rViewData.*GetZooms[i])(); } + +// Multiplying by this is basically equivalent to o3tl::convert(foo, o3tl::Length::px, o3tl::Length::mm100) +// Where there are 15 twips in an ideal pixel and 1 twip is 0.0017638889 cm +constexpr double twipFactor = 15 * 1.7639; // 26.4585 } void ScGridWindow::DrawContent(OutputDevice , const ScTableInfo& rTableInfo, ScOutputData& aOutputData, @@ -1058,7 +1062,6 @@ void ScGridWindow::DrawContent(OutputDevice , const ScTableInfo& rTableI aOrigin.setY(o3tl::convert(aOrigin.getY(), o3tl::Length::twip, o3tl::Length::px) + aOutputData.nScrY); -const double twipFactor = 15 * 1.7639; // 26.4585 aOrigin = Point(aOrigin.getX() * twipFactor, aOrigin.getY() * twipFactor); MapMode aNew = rDevice.GetMapMode(); @@ -1154,7 +1157,6 @@ void ScGridWindow::DrawContent(OutputDevice , const ScTableInfo& rTableI rDevice.SetMapMode(aDrawMode); // keep into account the zoom factor -static const double twipFactor = 15 * 1.7639; // 26.4585 Point aNewOrigin((aOriginAbsPx.getX() * twipFactor) / static_cast(aDrawMode.GetScaleX()), (aOriginAbsPx.getY() * twipFactor) / static_cast(aDrawMode.GetScaleY()));
[Bug 159746] MacMini M2Pro (Mac OS Sonoma 14.3.1) HUNG while editing a .docx document using LibreOffice Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=159746 stepped_canyon...@icloud.com changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #4 from stepped_canyon...@icloud.com --- Good morning, copy of original .docx document attached (hopefully). 1. I had populated the Client Details, Contact Details, Family and Dependents, and Final Salary Pension sections and saved the document at this point. 2. In the Advice Areas table (foot of page 1 and top of Page 2 I then inserted three additional rows above the row "Savings and Retirement" at the top of page 2. 3. Unfortunately I did not save the document at this point!! 4. I scrolled up to view the graphic at the top of page 1 with a view to deleting it since it was occupying a lot of otherwise useful space in page 1. 5. The graphic appeared to be in the body of the page, not in a "page header" 6. The graphic looked rather simplistic (an outer frame surrounding a number of coloured frames) 7. Before I could look more closely the screen image crashed / "exploded" and the Apple "Beach Ball" appeared, initially rotating and moving around quite quickly. 8. The BeachBall then stopped moving around and the rotation slowed to the point that the rotation was very jerky, perhaps six to eight jerks per rotation. 9. At this point LibreOffice was consuming 99.7% cpu capacity according the Activity Monitor. -- You are receiving this mail because: You are the assignee for the bug.
core.git: 2 commits - editeng/inc editeng/source sc/inc sc/source
editeng/inc/ParagraphPortion.hxx|2 --
editeng/source/editeng/impedit3.cxx |2 +-
sc/inc/scerrors.hrc |2 +-
sc/inc/scerrors.hxx |1 +
sc/inc/strings.hrc |3 +++
sc/source/filter/excel/excel.cxx|9 +
sc/source/ui/docshell/docsh.cxx | 26 +++---
sc/source/ui/docshell/docshimp.hxx |3 +++
8 files changed, 41 insertions(+), 7 deletions(-)
New commits:
commit 923b1ad7b7bc249838aa619361974f0e3134ab6a
Author: Tomaž Vajngerl
AuthorDate: Sat Feb 17 00:19:41 2024 +0900
Commit: Tomaž Vajngerl
CommitDate: Sat Feb 17 12:07:28 2024 +0100
sc: Show warning for a XLS document with unknown encrypted part
If a document contains a "DRMContent" section that we don't know
how to decrypt, show a warning before showing the un-encrypted
content.
Change-Id: Id7f48b68e1d65ce46434906b2fb3c7912dcc5f49
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163513
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/sc/inc/scerrors.hrc b/sc/inc/scerrors.hrc
index 88b099f69107..b3fc7bd01ec1 100644
--- a/sc/inc/scerrors.hrc
+++ b/sc/inc/scerrors.hrc
@@ -101,7 +101,7 @@ const ErrMsgCode RID_ERRHDLSC[] =
SCWARN_EXPORT_NONCONVERTIBLE_CHARS },
{ NC_("RID_ERRHDLSC", "Format error discovered in the file in sub-document
$(ARG1) at $(ARG2)(row,col)."),
SCWARN_IMPORT_FILE_ROWCOL },
-{ NC_("RID_ERRHDLSC", "Not all attributes could be read.") ,
+{ NC_("RID_ERRHDLSC", "Not all attributes could be read."),
SCWARN_IMPORT_FEATURES_LOST },
{ {}, ERRCODE_NONE }
};
diff --git a/sc/inc/scerrors.hxx b/sc/inc/scerrors.hxx
index dcb734502eae..c425e2fe8862 100644
--- a/sc/inc/scerrors.hxx
+++ b/sc/inc/scerrors.hxx
@@ -47,6 +47,7 @@
#define SCERR_IMPORT_FILE_ROWCOLErrCode( ErrCodeArea::Sc,
ErrCodeClass::Read, 16 )
#define SCERR_IMPORT_FORMAT_ROWCOL ErrCode( ErrCodeArea::Sc,
ErrCodeClass::Read, 17 )
#define SCWARN_IMPORT_FILE_ROWCOL ErrCode( WarningFlag::Yes,
ErrCodeArea::Sc, ErrCodeClass::Read, 18 )
+#define SCWARN_IMPORT_UNKNOWN_ENCRYPTION ErrCode(WarningFlag::Yes,
ErrCodeArea::Sc, ErrCodeClass::Read, 19)
// ErrCodeClass::Write - file related, displays "Write-Error" in MsgBox
#define SCERR_EXPORT_CONNECTErrCode( ErrCodeArea::Sc,
ErrCodeClass::Write, 1 )
diff --git a/sc/inc/strings.hrc b/sc/inc/strings.hrc
index 266cb4cc6c5b..070f117a001e 100644
--- a/sc/inc/strings.hrc
+++ b/sc/inc/strings.hrc
@@ -412,4 +412,7 @@
#define STR_CONDITION_CONTAINS_TEXT
NC_("STR_CONDITION_CONTAINS_TEXT", "containing text")
#define STR_CONDITION_NOT_CONTAINS_TEXT
NC_("STR_CONDITION_NOT_CONTAINS_TEXT", "not containing text")
+#define STR_CONTENT_WITH_UNKNOWN_ENCRYPTION
NC_("STR_CONTENT_WITH_UNKNOWN_ENCRYPTION", "Document contains DRM content that
is encrypted with an unknown encryption method. Only the un-encrypted content
will be shown.")
+
+
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/filter/excel/excel.cxx b/sc/source/filter/excel/excel.cxx
index 3542208eb174..862e85d08545 100644
--- a/sc/source/filter/excel/excel.cxx
+++ b/sc/source/filter/excel/excel.cxx
@@ -165,6 +165,8 @@ ErrCode ScFormatFilterPluginImpl::ScImportExcel( SfxMedium&
rMedium, ScDocument*
SvStream* pBookStrm = nullptr;// The "Book"/"Workbook" stream
containing main data.
XclBiff eBiff = EXC_BIFF_UNKNOWN; // The BIFF version of the main stream.
+bool bUnableToDecryptContent = false;
+
// try to open an OLE storage
tools::SvRef xRootStrg;
tools::SvRef xStrgStrm;
@@ -186,6 +188,10 @@ ErrCode ScFormatFilterPluginImpl::ScImportExcel(
SfxMedium& rMedium, ScDocument*
auto pDecryptedStorage = lcl_DRMDecrypt(rMedium, xRootStrg,
aNewStorageStrm);
if (pDecryptedStorage)
xRootStrg = pDecryptedStorage;
+else
+{
+bUnableToDecryptContent = true;
+}
}
// try to open the "Book" stream
@@ -250,6 +256,9 @@ ErrCode ScFormatFilterPluginImpl::ScImportExcel( SfxMedium&
rMedium, ScDocument*
eRet = xFilter ? xFilter->Read() : SCERR_IMPORT_INTERNAL;
}
+if (bUnableToDecryptContent && eRet == ERRCODE_NONE)
+eRet = SCWARN_IMPORT_UNKNOWN_ENCRYPTION;
+
return eRet;
}
diff --git a/sc/source/ui/docshell/docsh.cxx b/sc/source/ui/docshell/docsh.cxx
index 1cfd3778d6be..5f0cf927cd1d 100644
--- a/sc/source/ui/docshell/docsh.cxx
+++ b/sc/source/ui/docshell/docsh.cxx
@@ -48,6 +48,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -775,6 +776,11 @@ void ScDocShell::Notify( SfxBroadcaster&, const SfxHint&
rHint )
}
}
#endif
+
+ScViewData* pViewData = GetViewData();
+SfxViewShell* pViewShell = pViewData ?
[Bug 158962] Assigning a different list style to nested list removes its indentation (see comment 6)
https://bugs.documentfoundation.org/show_bug.cgi?id=158962 --- Comment #9 from bintoro --- @Buovjaga: I’m not sure about the reworded summary. Removing a list’s indentation is one thing; a workaround would be simply to re-indent. But the bug at hand is about something different: Writer terminates the current list and starts a new one. For that, there is no workaround. Also, if a list style is applied directly instead of via a paragraph style, the apparent indentation level isn’t even reset. Writer creates a new list and automatically adds empty levels to it in order to preserve the current position. So, things appear to work just fine and you seem to be able to format the sublist independently. But in actuality the structure is turned into the one described in the initial comment. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 103314] [META] Templates bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103314 Bug 103314 depends on bug 158863, which changed state. Bug 158863 Summary: Impress templates from Indonesian LO Community do not contain README files https://bugs.documentfoundation.org/show_bug.cgi?id=158863 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156811] Document wrongly marked as modified, only because template has changed.
https://bugs.documentfoundation.org/show_bug.cgi?id=156811 Wungsten <2pet...@gmx.co.uk> changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 130564] ODBC: Unable to create view through Base-GUI, if no view is created before
https://bugs.documentfoundation.org/show_bug.cgi?id=130564 --- Comment #13 from Robert Großkopf --- Bug is still the same in LO 24.2.0.3 on OpenSUSE 15.4 64bit rpm Linux. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 130672] base sql query parameter with negative value fails
https://bugs.documentfoundation.org/show_bug.cgi?id=130672 Robert Großkopf changed: What|Removed |Added OS|Windows (All) |All -- You are receiving this mail because: You are the assignee for the bug.
[Bug 130672] base sql query parameter with negative value fails
https://bugs.documentfoundation.org/show_bug.cgi?id=130672 --- Comment #6 from Robert Großkopf --- Bug still exists in LO 24.2.0.3 on OpenSUSE 64bit rpm Linux. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 124531] PostgreSQL Native Driver: Unable to create view through Base-GUI
https://bugs.documentfoundation.org/show_bug.cgi?id=124531 --- Comment #20 from Robert Großkopf --- Bug is still the same in LO 24.2.0.3 on OpenSUSE 15.4 64bit rpm Linux. -- You are receiving this mail because: You are the assignee for the bug.
core.git: editeng/source include/o3tl o3tl/qa sw/inc sw/source xmloff/source
editeng/source/misc/svxacorr.cxx |2
include/o3tl/sorted_vector.hxx | 140 -
o3tl/qa/test-sorted_vector.cxx | 18 +-
sw/inc/docary.hxx |2
sw/inc/edglbldc.hxx|2
sw/inc/ndarr.hxx |4
sw/source/core/doc/docredln.cxx|2
sw/source/core/doc/doctxm.cxx |4
sw/source/core/docnode/ndnum.cxx |8
sw/source/core/docnode/node.cxx|5
sw/source/core/edit/ednumber.cxx |3
sw/source/core/inc/docfld.hxx |2
sw/source/core/inc/swblocks.hxx|2
sw/source/filter/html/htmlfly.hxx |2
sw/source/filter/html/wrthtml.hxx |2
sw/source/filter/inc/wrtswtbl.hxx |7
sw/source/filter/xml/xmltble.cxx |2
sw/source/uibase/docvw/OutlineContentVisibilityWin.cxx |3
sw/source/uibase/inc/dbinsdlg.hxx |2
sw/source/uibase/inc/redlndlg.hxx |2
sw/source/uibase/utlui/content.cxx |2
xmloff/source/style/XMLFontAutoStylePool.cxx |7
xmloff/source/text/XMLTextListAutoStylePool.cxx|7
23 files changed, 78 insertions(+), 152 deletions(-)
New commits:
commit 1f5efbf8b9ba3fd5887c58574dfed3bf31cd020e
Author: Mike Kaganski
AuthorDate: Fri Feb 16 23:58:01 2024 +0600
Commit: Mike Kaganski
CommitDate: Sat Feb 17 10:07:38 2024 +0100
Generalize search algorithms in sorted_vector
This allows to simplify the code somewhat, and also to relax requirements
to the arguments, e.g. allowing to pass const objects to search in vector
containing non-const objects.
Change-Id: Id34911a8694bbdec275d22b51ca4a0845c9fa4c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163519
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/editeng/source/misc/svxacorr.cxx b/editeng/source/misc/svxacorr.cxx
index d278b582e833..30c598594f5d 100644
--- a/editeng/source/misc/svxacorr.cxx
+++ b/editeng/source/misc/svxacorr.cxx
@@ -2114,7 +2114,7 @@ bool SvxAutoCorrect::FindInWordStartExceptList(
LanguageType eLang,
static bool lcl_FindAbbreviation(const SvStringsISortDtor* pList, const
OUString& sWord)
{
-SvStringsISortDtor::const_iterator it = pList->find( "~" );
+SvStringsISortDtor::const_iterator it = pList->find(u"~"_ustr);
SvStringsISortDtor::size_type nPos = it - pList->begin();
if( nPos < pList->size() )
{
diff --git a/include/o3tl/sorted_vector.hxx b/include/o3tl/sorted_vector.hxx
index 0f31bc517651..bf28b7166e41 100644
--- a/include/o3tl/sorted_vector.hxx
+++ b/include/o3tl/sorted_vector.hxx
@@ -21,9 +21,18 @@
namespace o3tl
{
-// forward declared because it's default template arg for sorted_vector
-template
-struct find_unique;
+/** the elements are totally ordered by Compare,
+for no 2 elements !Compare(a,b) && !Compare(b,a) is true
+ */
+template struct find_unique
+{
+template
+auto operator()(Iterator first, Iterator last, Comparable const& v)
+{
+auto const it = std::lower_bound(first, last, v, Compare());
+return std::make_pair(it, (it != last && !Compare()(v, *it)));
+}
+};
/** Represents a sorted vector of values.
@@ -34,12 +43,11 @@ struct find_unique;
template<
typename Value,
typename Compare = std::less,
- template class Find = find_unique,
- bool = std::is_copy_constructible::value >
+ template class Find = find_unique >
class sorted_vector
{
private:
-typedef Find Find_t;
+typedef Find Find_t;
typedef typename std::vector vector_t;
typedef typename std::vector::iterator iterator;
public:
@@ -55,10 +63,10 @@ public:
std::sort(m_vector.begin(), m_vector.end(), Compare());
}
sorted_vector() = default;
-sorted_vector(sorted_vector const&) = default;
+sorted_vector(sorted_vector const&) requires
std::is_copy_constructible_v = default;
sorted_vector(sorted_vector&&) = default;
-sorted_vector& operator=(sorted_vector const&) = default;
+sorted_vector& operator=(sorted_vector const&) requires
std::is_copy_constructible_v = default;
sorted_vector& operator=(sorted_vector&&) = default;
// MODIFIERS
@@ -192,12 +200,12 @@ public:
// OPERATIONS
-const_iterator lower_bound( const Value& x ) const
+template const_iterator lower_bound(const
Comparable& x) const
{
return std::lower_bound( m_vector.begin(), m_vector.end(), x,
Compare() );
}
-const_iterator upper_bound( const Value& x ) const
+template const_iterator upper_bound(const
Comparable& x) const
{
[Bug 159748] UI: Cell protection dialog reference menu that don't exist
https://bugs.documentfoundation.org/show_bug.cgi?id=159748 Timur changed: What|Removed |Added Keywords||needsUXEval --- Comment #5 from Timur --- When user sees "Tools menu" in Tabbed, he will not look after how to turn that manu, rather will just notice that Tools is missing. Seen multiple times. So it would be desirable to have text clear for user. Either change contextually or add "Review tab" or remove "Tools menu". I add UXeval, needs a mail also. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156811] Document wrongly marked as modified, only because template has changed.
https://bugs.documentfoundation.org/show_bug.cgi?id=156811 --- Comment #3 from Wungsten <2pet...@gmx.co.uk> --- We seem to differ on whether this is a bug or a feature. However, please try this: 1. Create a new test template. 2. Create a new document from the test template. 3. Save the new document and close Writer. 4. Change the test template and close Writer. 5. Open the document. You get a dialogue saying, "The template 'Default' ...". Note that the template name is INCORRECT. 6. Click 'Keep old styles'. Note that the document is marked as Modified, even though no changes are visible. Don't save the document, just close Writer. 7. Repeat step 6. 8. This time click 'Update Styles'. Note that the document is marked as Modified, even though no changes are visible - changes made to the template in step 4 are NOT applied. Maybe I am confused about the precise meaning of 'Styles' in this context. Nevertheless, it seems wrong that the document is marked as Modified, even though no changes are visible. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159210] Jumping to Last Page (Ctrl+End) in Document Extremely Slow
https://bugs.documentfoundation.org/show_bug.cgi?id=159210 --- Comment #6 from Buovjaga --- Yeah, I was doing it in the live stream, working on other bugs and checking the situation from time to time. After it didn't go (Not responding) anymore and the pagination had settled, I hit page up and didn't have to wait. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159543] Cannot resize graphical objects that overlap header/footer
https://bugs.documentfoundation.org/show_bug.cgi?id=159543 Buovjaga changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID --- Comment #5 from Buovjaga --- (In reply to m_a_riosv from comment #4) > Select the frame, > right-click on the border, > select properties, > on Position & Size tab, disable 'Autosize option' Thanks, let's close. -- You are receiving this mail because: You are the assignee for the bug.
