[Bug 159885] the latest text editing version hangs unexpectedly in the middle of writing
https://bugs.documentfoundation.org/show_bug.cgi?id=159885 --- Comment #4 from PAUL HOFSETH --- thanks for good advice, The only thing I ahve ever used the profile for is to put in my name, all versions since star office has wiroked perfectly with one or 200 pages. I keep using the "7 something" version which by now has been stable, but hesistate to work on longer manuscripts until stability is proven by experience. p. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 137067] User interface - Inconsistent fonts in tabbed style (Recent Documents looks out-of-place)
https://bugs.documentfoundation.org/show_bug.cgi?id=137067 Stéphane Guillou (stragu) changed: What|Removed |Added Summary|User interface -|User interface - |Inconsistent fonts in |Inconsistent fonts in |tabbed style (Remote|tabbed style (Recent |Documents looks |Documents looks |out-of-place) |out-of-place) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 64679] [META] Printer settings related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=64679 React Masters changed: What|Removed |Added OS|All |Windows (All) URL||https://reactmasters.in/ Component|Printing and PDF export |Documentation Keywords||skillJava, skillJavaScript, ||skillUI CC||olivier.hallot@libreoffice. ||org --- Comment #44 from React Masters --- which printer is best for my website logo designs? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159629] Table cells merge: some cells disappear
https://bugs.documentfoundation.org/show_bug.cgi?id=159629 Heiko Tietze changed: What|Removed |Added CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org Keywords|needsUXEval | --- Comment #17 from Heiko Tietze --- Whether the minimum row height is zero or takes some value from the paragraph style doesn't matter for the question what height a single cell has. The perceived issue here is that merged cells don't span over multiple rows when empty. And I think this is not a bug neither can be fixed without bringing cell height attributes into the format. Which in my opinion is not needed. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159629] Table cells merge: some cells disappear
https://bugs.documentfoundation.org/show_bug.cgi?id=159629 Heiko Tietze changed: What|Removed |Added CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org Keywords|needsUXEval | --- Comment #17 from Heiko Tietze --- Whether the minimum row height is zero or takes some value from the paragraph style doesn't matter for the question what height a single cell has. The perceived issue here is that merged cells don't span over multiple rows when empty. And I think this is not a bug neither can be fixed without bringing cell height attributes into the format. Which in my opinion is not needed. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 159908] LibreOffice crashes when using a constant as a loop variable in BASIC code, leading to data loss.
https://bugs.documentfoundation.org/show_bug.cgi?id=159908 Mike Kaganski changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com |desktop.org | Status|NEW |ASSIGNED --- Comment #2 from Mike Kaganski --- https://gerrit.libreoffice.org/c/core/+/164002 -- You are receiving this mail because: You are the assignee for the bug.
core.git: sw/source
sw/source/filter/ww8/rtfattributeoutput.cxx | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) New commits: commit 6931d41640e31db4f1ad07afb48ec4df7086f6bb Author: Justin Luth AuthorDate: Mon Feb 26 15:28:10 2024 -0500 Commit: Miklos Vajna CommitDate: Tue Feb 27 08:45:44 2024 +0100 address nit: use boolean flag instead of minor copy/paste Change-Id: I380ca73047fecefd9b7ff508eb6f8bf8202b1b62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163969 Tested-by: Jenkins Reviewed-by: Justin Luth Reviewed-by: Miklos Vajna diff --git a/sw/source/filter/ww8/rtfattributeoutput.cxx b/sw/source/filter/ww8/rtfattributeoutput.cxx index 0f2885068d12..36bb03149c06 100644 --- a/sw/source/filter/ww8/rtfattributeoutput.cxx +++ b/sw/source/filter/ww8/rtfattributeoutput.cxx @@ -3760,13 +3760,11 @@ void RtfAttributeOutput::FormatFillGradient(const XFillGradientItem& rFillGradie std::make_pair("fillAngle"_ostr, OString::number(nAngle))); } +bool bIsSymmetrical = true; if (rColorStops.size() < 3) { -if (rGradient.GetGradientStyle() == awt::GradientStyle_AXIAL) -{ -m_aFlyProperties.push_back( -std::make_pair("fillFocus"_ostr, OString::number(50))); -} +if (rGradient.GetGradientStyle() != awt::GradientStyle_AXIAL) +bIsSymmetrical = false; } else { @@ -3774,15 +3772,18 @@ void RtfAttributeOutput::FormatFillGradient(const XFillGradientItem& rFillGradie // FillModel::pushToPropMap 'fFocus' value and usage. // The 2nd color is the in-between color, use it aMSOEndColor = Color(rColorStops[1].getStopColor()); - -m_aFlyProperties.push_back( -std::make_pair("fillFocus"_ostr, OString::number(50))); } m_aFlyProperties.push_back(std::make_pair( "fillColor"_ostr, OString::number(wwUtility::RGBToBGR(aMSOStartColor; m_aFlyProperties.push_back(std::make_pair( "fillBackColor"_ostr, OString::number(wwUtility::RGBToBGR(aMSOEndColor; + +if (bIsSymmetrical) +{ +m_aFlyProperties.push_back( +std::make_pair("fillFocus"_ostr, OString::number(50))); +} } void RtfAttributeOutput::FormatBox(const SvxBoxItem& rBox)
core.git: sw/source writerfilter/source
sw/source/filter/ww8/rtfattributeoutput.cxx |5 +++-- writerfilter/source/rtftok/rtfsdrimport.cxx |3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) New commits: commit 9348677e040927a736e70797d07bb1de32d729ca Author: Justin Luth AuthorDate: Mon Feb 26 15:20:11 2024 -0500 Commit: Miklos Vajna CommitDate: Tue Feb 27 08:45:03 2024 +0100 address nit: use oox::drawingml::PER_DEGREE instead of 60,000 Change-Id: Ie3ca5a76376a3c26f0d3079b6e819ec29afd2c17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163968 Tested-by: Jenkins Reviewed-by: Justin Luth Reviewed-by: Miklos Vajna diff --git a/sw/source/filter/ww8/rtfattributeoutput.cxx b/sw/source/filter/ww8/rtfattributeoutput.cxx index 03fc0fa354cb..0f2885068d12 100644 --- a/sw/source/filter/ww8/rtfattributeoutput.cxx +++ b/sw/source/filter/ww8/rtfattributeoutput.cxx @@ -86,6 +86,7 @@ #include #include #include +#include #include #include #include @@ -3752,11 +3753,11 @@ void RtfAttributeOutput::FormatFillGradient(const XFillGradientItem& rFillGradie const Color aMSOStartColor(rColorStops.back().getStopColor()); Color aMSOEndColor(rColorStops.front().getStopColor()); -const sal_Int32 nAngle = toDegrees(rGradient.GetAngle()); +const sal_Int32 nAngle = toDegrees(rGradient.GetAngle()) * oox::drawingml::PER_DEGREE; if (nAngle != 0) { m_aFlyProperties.push_back( -std::make_pair("fillAngle"_ostr, OString::number(nAngle * 6))); +std::make_pair("fillAngle"_ostr, OString::number(nAngle))); } if (rColorStops.size() < 3) diff --git a/writerfilter/source/rtftok/rtfsdrimport.cxx b/writerfilter/source/rtftok/rtfsdrimport.cxx index 9c673e871835..812a8e69f318 100644 --- a/writerfilter/source/rtftok/rtfsdrimport.cxx +++ b/writerfilter/source/rtftok/rtfsdrimport.cxx @@ -42,6 +42,7 @@ #include "rtfreferenceproperties.hxx" #include #include +#include #include #include #include @@ -668,7 +669,7 @@ void RTFSdrImport::resolve(RTFShape& rShape, bool bClose, ShapeOrPict const shap } else if (rProperty.first == "fillAngle") { -aFillModel.moAngle = rProperty.second.toInt32() / 6; +aFillModel.moAngle = rProperty.second.toInt32() / oox::drawingml::PER_DEGREE; } else if (rProperty.first == "fillFocus") aFillModel.moFocus = rProperty.second.toDouble() / 100; // percent
core.git: sw/source
sw/source/filter/ww8/docxexport.cxx | 100 +++- sw/source/filter/ww8/docxexport.hxx |3 + 2 files changed, 56 insertions(+), 47 deletions(-) New commits: commit 2e073dc313cb2beaa7e4d2aef8584e7f76e9edee Author: Justin Luth AuthorDate: Mon Feb 26 14:24:14 2024 -0500 Commit: Miklos Vajna CommitDate: Tue Feb 27 08:44:16 2024 +0100 address nit: create separate WriteDocumentBackgroundFill function Change-Id: I4e204dfee51987112f1a4a4a052a11349ae3f373 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163966 Tested-by: Jenkins Reviewed-by: Justin Luth Reviewed-by: Miklos Vajna diff --git a/sw/source/filter/ww8/docxexport.cxx b/sw/source/filter/ww8/docxexport.cxx index 787c90e32b12..f1331ce4141e 100644 --- a/sw/source/filter/ww8/docxexport.cxx +++ b/sw/source/filter/ww8/docxexport.cxx @@ -1901,63 +1901,69 @@ bool DocxExport::isMirroredMargin() return bMirroredMargins; } -void DocxExport::WriteMainText() +void DocxExport::WriteDocumentBackgroundFill() { -// setup the namespaces -m_pDocumentFS->startElementNS( XML_w, XML_document, MainXmlNamespaces()); +const std::unique_ptr pBrush = getBackground(); +if (!pBrush) +return; -// reset the incrementing linked-textboxes chain ID before re-saving. -m_nLinkedTextboxesChainId=0; -m_aLinkedTextboxesHelper.clear(); +m_pDocumentFS->startElementNS(XML_w, XML_background, FSNS(XML_w, XML_color), + msfilter::util::ConvertColor(pBrush->GetColor())); -// Write background page color -if (std::unique_ptr oBrush = getBackground(); oBrush) +const SwAttrSet& rPageStyleAttrSet = m_rDoc.GetPageDesc(0).GetMaster().GetAttrSet(); +const drawing::FillStyle eFillType = rPageStyleAttrSet.Get(XATTR_FILLSTYLE).GetValue(); +const GraphicObject* pGraphicObj = pBrush->GetGraphicObject(); +if (pGraphicObj) // image/pattern/texture { -m_pDocumentFS->startElementNS(XML_w, XML_background, FSNS(XML_w, XML_color), - msfilter::util::ConvertColor(oBrush->GetColor())); - -const SwAttrSet& rPageStyleAttrSet = m_rDoc.GetPageDesc(0).GetMaster().GetAttrSet(); -const drawing::FillStyle eFillType = rPageStyleAttrSet.Get(XATTR_FILLSTYLE).GetValue(); -const GraphicObject* pGraphicObj = oBrush->GetGraphicObject(); -if (pGraphicObj) // image/pattern/texture +const OUString aRelId = m_pDrawingML->writeGraphicToStorage(pGraphicObj->GetGraphic()); +if (!aRelId.isEmpty()) { -const OUString aRelId = m_pDrawingML->writeGraphicToStorage(pGraphicObj->GetGraphic()); -if (!aRelId.isEmpty()) -{ -m_pDocumentFS->startElementNS(XML_v, XML_background); +m_pDocumentFS->startElementNS(XML_v, XML_background); -// Although MSO treats everything as tile, it is better for LO to not always tile -OString sType = "frame"_ostr; // single image -if (rPageStyleAttrSet.Get(XATTR_FILLBMP_TILE).GetValue()) -sType = "tile"_ostr; // primarily for patterns / textures -m_pDocumentFS->singleElementNS(XML_v, XML_fill, FSNS(XML_r, XML_id), aRelId, -XML_type, sType); +// Although MSO treats everything as tile, it is better for LO to not always tile +OString sType = "frame"_ostr; // single image +if (rPageStyleAttrSet.Get(XATTR_FILLBMP_TILE).GetValue()) +sType = "tile"_ostr; // primarily for patterns / textures +m_pDocumentFS->singleElementNS(XML_v, XML_fill, FSNS(XML_r, XML_id), aRelId, XML_type, + sType); -m_pDocumentFS->endElementNS(XML_v, XML_background); -} -} -else if (eFillType == drawing::FillStyle_GRADIENT) -{ -SfxItemSetFixed aSet(m_rDoc.GetAttrPool()); -aSet.Set(rPageStyleAttrSet); - -// Collect all of the gradient attributes into SdrExporter() AttrLists -m_pAttrOutput->OutputStyleItemSet(aSet, /*TestForDefault=*/true); -assert(SdrExporter().getFlyAttrList().is() && "type and fillcolor are always provided"); -assert(SdrExporter().getFlyFillAttrList().is() && "color2 is always provided"); - -rtl::Reference xFlyAttrList(SdrExporter().getFlyAttrList()); -rtl::Reference xFillAttrList(SdrExporter().getFlyFillAttrList()); -m_pDocumentFS->startElementNS(XML_v, XML_background, xFlyAttrList); -m_pDocumentFS->singleElementNS(XML_v, XML_fill, xFillAttrList); m_pDocumentFS->endElementNS(XML_v, XML_background); - -SdrExporter().getFlyAttrList().clear(); -SdrExporter().getFlyFillAttrList().clear(); } - -
core.git: oox/source sw/qa
oox/source/drawingml/fillproperties.cxx |2 + sw/qa/extras/ooxmlexport/ooxmlexport2.cxx | 30 +++ sw/qa/extras/ooxmlexport/ooxmlexport7.cxx | 26 +++- sw/qa/extras/rtfexport/rtfexport.cxx | 47 +++--- sw/qa/extras/rtfexport/rtfexport8.cxx | 15 + 5 files changed, 42 insertions(+), 78 deletions(-) New commits: commit 38083e4c0b5638d69162593c3fbf599da6cd499f Author: Justin Luth AuthorDate: Tue Feb 20 16:11:08 2024 -0500 Commit: Miklos Vajna CommitDate: Tue Feb 27 08:40:50 2024 +0100 related tdf#126533 dml/vml import: import radials as radials ... and not as symmetrical linear gradients. The benefit is that our export code will be able to intelligently export it. Apparently RTF export code does not intelligently export axials, (now fixed - tdf#159824) but VML and DML (and doc) do it well. Unfortunately charts can be badly affected, (avoided by ignoring when transparent) and unit tests are implementation-tested... This affects existing unit tests: -tdf128345_Legend_CS_TG_axial.pptx: label imports fine: lost on export (no change) -tdf128345_ChartWall_CS_TG.pptx: wall gradient now looks axial: lost on export (no change) -textframe-gradient.docx: still round-trips OK: no change -textframe-gradient.rtf: round-trips as linear: lost axial-ness (now fixed: tdf#159824) -fdo78663.docx: textbox font fill: still exports as solid: no change I ran the assert check against chart2, oox, and sw Change-Id: Ib16e9488a76b006bf335ff01a38acf7cde69cccb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163675 Tested-by: Jenkins Reviewed-by: Justin Luth Reviewed-by: Miklos Vajna diff --git a/oox/source/drawingml/fillproperties.cxx b/oox/source/drawingml/fillproperties.cxx index dec9ab9672cc..f24208722cb5 100644 --- a/oox/source/drawingml/fillproperties.cxx +++ b/oox/source/drawingml/fillproperties.cxx @@ -543,6 +543,8 @@ void FillProperties::pushToPropMap(ShapePropertyMap& rPropMap, const GraphicHelp // convert DrawingML angle (in 1/6 degrees) to API angle (in 1/10 degrees) aGradient.SetAngle(Degree10(static_cast< sal_Int16 >( (8100 - (nDmlAngle / (PER_DEGREE / 10))) % 3600 ))); +if (!bContainsTransparency) +aGradient.tryToConvertToAxial(); } if (awt::GradientStyle_RECT == aGradient.GetGradientStyle()) diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport2.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport2.cxx index f8defa15d1a2..72072bc5bb03 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport2.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport2.cxx @@ -577,34 +577,16 @@ DECLARE_OOXMLEXPORT_TEST(testTextframeGradient, "textframe-gradient.docx") uno::Reference xFrame(getShape(1), uno::UNO_QUERY); CPPUNIT_ASSERT_EQUAL(drawing::FillStyle_GRADIENT, getProperty(xFrame, "FillStyle")); awt::Gradient2 aGradient(getProperty(xFrame, "FillGradient")); - -// MCGR: Use the completely imported transparency gradient to check for correctness -basegfx::BColorStops aColorStops = model::gradient::getColorStopsFromUno(aGradient.ColorStops); - -CPPUNIT_ASSERT_EQUAL(size_t(3), aColorStops.size()); -CPPUNIT_ASSERT(basegfx::fTools::equal(aColorStops[0].getStopOffset(), 0.0)); -CPPUNIT_ASSERT_EQUAL(Color(0xd99594), Color(aColorStops[0].getStopColor())); -CPPUNIT_ASSERT(basegfx::fTools::equal(aColorStops[1].getStopOffset(), 0.5)); -CPPUNIT_ASSERT_EQUAL(Color(0xc0504d), Color(aColorStops[1].getStopColor())); -CPPUNIT_ASSERT(basegfx::fTools::equal(aColorStops[2].getStopOffset(), 1.0)); -CPPUNIT_ASSERT_EQUAL(Color(0xd99594), Color(aColorStops[2].getStopColor())); -CPPUNIT_ASSERT_EQUAL(awt::GradientStyle_LINEAR, aGradient.Style); +CPPUNIT_ASSERT_EQUAL(Color(0xC0504D), Color(ColorTransparency, aGradient.StartColor)); +CPPUNIT_ASSERT_EQUAL(Color(0xD99594), Color(ColorTransparency, aGradient.EndColor)); +CPPUNIT_ASSERT_EQUAL(awt::GradientStyle_AXIAL, aGradient.Style);; xFrame.set(getShape(2), uno::UNO_QUERY); CPPUNIT_ASSERT_EQUAL(drawing::FillStyle_GRADIENT, getProperty(xFrame, "FillStyle")); aGradient = getProperty(xFrame, "FillGradient"); - -// MCGR: Use the completely imported transparency gradient to check for correctness -aColorStops = model::gradient::getColorStopsFromUno(aGradient.ColorStops); - -CPPUNIT_ASSERT_EQUAL(size_t(3), aColorStops.size()); -CPPUNIT_ASSERT(basegfx::fTools::equal(aColorStops[0].getStopOffset(), 0.0)); -CPPUNIT_ASSERT_EQUAL(Color(0x66), Color(aColorStops[0].getStopColor())); -CPPUNIT_ASSERT(basegfx::fTools::equal(aColorStops[1].getStopOffset(), 0.5)); -CPPUNIT_ASSERT_EQUAL(Color(0x00), Color(aColorStops[1].getStopColor())); -
core.git: Branch 'distro/collabora/co-24.04' - sw/qa sw/source
sw/qa/extras/ww8export/ww8export3.cxx |7 +++ sw/source/filter/ww8/wrtw8esh.cxx |5 +++-- 2 files changed, 10 insertions(+), 2 deletions(-) New commits: commit 9b6754db7659e8b192c36c36807729d6c37cf340 Author: Justin Luth AuthorDate: Mon Feb 26 09:56:11 2024 -0500 Commit: Miklos Vajna CommitDate: Tue Feb 27 08:38:07 2024 +0100 related tdf#126533 doc export: don't lose "tiled" aspect of image fill. This affects patterns as well as textures/images. make CppunitTest_sw_ww8export3 CPPUNIT_TEST_NAME=testTdf101826_xattrTextBoxFill Change-Id: I2742a6f333fc6688b3570772a1dbc8371741f210 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163948 Tested-by: Jenkins Reviewed-by: Justin Luth (cherry picked from commit 93b14c1ba3afaf0a734ee5112444f0adbb35c428) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163970 Tested-by: Jenkins CollaboraOffice Reviewed-by: Miklos Vajna diff --git a/sw/qa/extras/ww8export/ww8export3.cxx b/sw/qa/extras/ww8export/ww8export3.cxx index 97ea979d01e8..66c5ae5c471c 100644 --- a/sw/qa/extras/ww8export/ww8export3.cxx +++ b/sw/qa/extras/ww8export/ww8export3.cxx @@ -11,6 +11,7 @@ #include #include +#include #include #include #include @@ -621,6 +622,12 @@ DECLARE_WW8EXPORT_TEST(testTdf101826_xattrTextBoxFill, "tdf101826_xattrTextBoxFi CPPUNIT_ASSERT_MESSAGE("background color", Color(0xFF, 0xFF, 0x00) != getProperty(getShape(4), "BackColor")); //Basic Picture Fill: Tux image CPPUNIT_ASSERT_EQUAL_MESSAGE("background image", drawing::FillStyle_BITMAP, getProperty(getShape(5), "FillStyle")); +// Basic Pattern fill: many thin, green, vertical stripes on yellow background +auto eMode = getProperty(getShapeByName(u"Frame2"), "FillBitmapMode"); +CPPUNIT_ASSERT_EQUAL_MESSAGE("tiled pattern", drawing::BitmapMode_REPEAT, eMode); +// Basic Texture fill: tiled blue denim texture +eMode = getProperty(getShapeByName(u"Frame6"), "FillBitmapMode"); +CPPUNIT_ASSERT_EQUAL_MESSAGE("tiled texture", drawing::BitmapMode_REPEAT, eMode); } DECLARE_WW8EXPORT_TEST(testTdf123433_fillStyleStop, "tdf123433_fillStyleStop.doc") diff --git a/sw/source/filter/ww8/wrtw8esh.cxx b/sw/source/filter/ww8/wrtw8esh.cxx index 19ac50ccf5c9..f9e1082f9276 100644 --- a/sw/source/filter/ww8/wrtw8esh.cxx +++ b/sw/source/filter/ww8/wrtw8esh.cxx @@ -1849,8 +1849,9 @@ void SwBasicEscherEx::WriteBrushAttr(const SvxBrushItem , nOpaque = 255 - pGraphicObject->GetAttr().GetAlpha(); if (0 != nOpaque) bSetOpacity = true; - -rPropOpt.AddOpt( ESCHER_Prop_fillType, ESCHER_FillPicture ); +const ESCHER_FillStyle eFillType += rBrush.GetGraphicPos() == GPOS_TILED ? ESCHER_FillTexture : ESCHER_FillPicture; +rPropOpt.AddOpt(ESCHER_Prop_fillType, eFillType); rPropOpt.AddOpt( ESCHER_Prop_fNoFillHitTest, 0x140014 ); rPropOpt.AddOpt( ESCHER_Prop_fillBackColor, 0 ); }
[Bug 159603] link the scaling-factor with the sheet-name
https://bugs.documentfoundation.org/show_bug.cgi?id=159603 --- Comment #8 from Heiko Tietze --- (In reply to Tracey from comment #7) > [automatic scale-to-content] is already functioning (and this is good). Maybe off-topic, but how? Changing the page style from A4 to A5 does not change the print-out scaling but the zoom factor on how that smaller page is shown in the print preview. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159863] Ctl + Shift + PgDn no longer assigned to JumpToFootnoteArea
https://bugs.documentfoundation.org/show_bug.cgi?id=159863 Heiko Tietze changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |heiko.tietze@documentfounda |desktop.org |tion.org Status|NEW |ASSIGNED --- Comment #16 from Heiko Tietze --- https://gerrit.libreoffice.org/c/core/+/164001 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 103303] [META] Desktop integration bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103303 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||159656 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=159656 [Bug 159656] "7.6" still shown in the taskbar thumbnail by KDE Plasma when running the v24 appimage -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159656] "7.6" still shown in the taskbar thumbnail by KDE Plasma when running the v24 appimage
https://bugs.documentfoundation.org/show_bug.cgi?id=159656 Stéphane Guillou (stragu) changed: What|Removed |Added Whiteboard| QA:needsComment| Ever confirmed|0 |1 Blocks||103303 CC||m.wegh...@posteo.de, ||stephane.guillou@libreoffic ||e.org Status|UNCONFIRMED |NEW Priority|medium |low --- Comment #1 from Stéphane Guillou (stragu) --- Do you still have 7.6 installed? I don't think this is related to the use of AppImage. I am on Ubuntu 22.04 + GNOME 42.9 and I have a similar issue. Interestingly, it depends on the component: - opening Writer 24.2 shows "7.6" in the dock (bad) - opening Impress or Draw 24.2 shows "24.2" in the dock (OK) - opening Writer 7.6 shows "7.6" in the dock (OK) - opening Impress or Draw 7.6 shows "24.2" in the dock (bad) - opening Calc or Math (regardless of version) shows the old Calc or Math icon in the dock, no version in tooltip (bad) - opening the Start Center (regardless of version) shows me 24.8 in the dock (the dev version I've also installed from deb) (bad) A bit of a mixed bag! Version: 24.2.0.3 (X86_64) / LibreOffice Community Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded I don't know if it's a Wayland issue, possibly related to bug 125934. But launching in a MetaWindowXwayland does not fix it. Michael, what do you think? Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103303 [Bug 103303] [META] Desktop integration bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 105948] [META] Undo/Redo bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=105948 Bug 105948 depends on bug 133968, which changed state. Bug 133968 Summary: Freeze hang after deleting index and undo with old swx https://bugs.documentfoundation.org/show_bug.cgi?id=133968 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Bug 89606] [META] Table of Contents and Indexes bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=89606 Bug 89606 depends on bug 133968, which changed state. Bug 133968 Summary: Freeze hang after deleting index and undo with old swx https://bugs.documentfoundation.org/show_bug.cgi?id=133968 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Bug 133968] Freeze hang after deleting index and undo with old swx
https://bugs.documentfoundation.org/show_bug.cgi?id=133968 Buovjaga changed: What|Removed |Added Resolution|--- |WORKSFORME Keywords|bibisectRequest | Status|NEW |RESOLVED --- Comment #10 from Buovjaga --- No freeze, let's close. Version: 24.2.0.3 (X86_64) / LibreOffice Community Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1 CPU threads: 2; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 132456] Lots of time spend in SfxBroadcaster::RemoveListener Undoing deleting a row (3/4 minutes)
https://bugs.documentfoundation.org/show_bug.cgi?id=132456 --- Comment #7 from Buovjaga --- Telesto: now would be a good time to retest this. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159920] Calc UI Incorrect rendering of rotated text
https://bugs.documentfoundation.org/show_bug.cgi?id=159920 David Lynch changed: What|Removed |Added CC||dlynch1...@googlemail.com --- Comment #1 from David Lynch --- Created attachment 192816 --> https://bugs.documentfoundation.org/attachment.cgi?id=192816=edit Exhibits bug 159920 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159920] New: Calc UI Incorrect rendering of rotated text
https://bugs.documentfoundation.org/show_bug.cgi?id=159920 Bug ID: 159920 Summary: Calc UI Incorrect rendering of rotated text Product: LibreOffice Version: 24.2.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: dlynch1...@googlemail.com Description: A small i is shown as I in Liberation Sans when rotated through 90 degrees. Steps to Reproduce: see attachment Actual Results: see attachment Expected Results: see attachment Reproducible: Always User Profile Reset: Yes Additional Info: Same in safe mode. Version: 24.2.0.3 (X86_64) / LibreOffice Community Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1 CPU threads: 12; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: en-GB (en_GB); UI: en-GB Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[RESOLVED] Re: TextureKind deprecated since 2000, should we use TextureKind2 everywhere?
I've just submitted a new patch concerning tdf#159874 since first attempt generated tdf#159911 (FILEOPEN: 3D object is displayed as black/white) see https://gerrit.libreoffice.org/c/core/+/163998
[Bug 159579] Charts in Calc converted from OLE to images when upgrading 7.5 to 7.6 and 7.6 to 24.2
https://bugs.documentfoundation.org/show_bug.cgi?id=159579 Stéphane Guillou (stragu) changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #6 from Stéphane Guillou (stragu) --- I have tested on Windows 11: 1. Create a chart in an ODS file with LO 7.6.5.2 2. Open ODS file in 24.2.0.3 I could not reproduce. Marking as "need info" while we wait for a potential example file. If you still have the original file (with OLE objects), you could try to reset your user profile (after backing up the original) and open the file again with the newer version, see if the issue persists. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159643] Too wide error message box for long error message
https://bugs.documentfoundation.org/show_bug.cgi?id=159643 Hossein changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #5 from Hossein --- (In reply to Stéphane Guillou (stragu) from comment #4) > Repro with LT 6.3.1 and: > > Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community > Build ID: d2fa44db6f8a1badece63856ee0f12db4cba9b28 > CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 > Locale: en-AU (en_AU.UTF-8); UI: en-US > Calc: threaded > > Same with gen VCL. > > Hossein, what do you think? Shouldn't Java error messages be automatically > wrapped (or maybe better: truncated, with option to copy text) in our > dialogs? > Or is this out of our control / should be handled by extension developers? @Stéphane: I think it is a reasonable request to have the error message box fit on the screen, and be able to use buttons on the message box. The error dialog box is not usable now. The extension developers can find ways to handle these overflow cases by making sure the lines are not too long. In this case for example, Languagetool developers can modify this part of code, as the stack trace suggests: https://github.com/languagetool-org/languagetool/blob/38ff53e9afb8bc266cdf7651d67df0d123b3313e/languagetool-core/src/main/java/org/languagetool/Languages.java#L234 But I think the dialog itself should handle such cases, and not let it overflow the screen. I also agree that being able to copy the message is very useful. -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'distro/collabora/co-23.05' - sw/qa sw/source
sw/qa/core/layout/data/floattable-not-wrapped-by-table.docx |binary sw/qa/core/layout/tabfrm.cxx| 22 sw/source/core/layout/tabfrm.cxx| 15 ++-- 3 files changed, 33 insertions(+), 4 deletions(-) New commits: commit 58b60a6b230cd916c6b278a5efe0987b9c23f8a5 Author: Miklos Vajna AuthorDate: Tue Jan 23 15:34:07 2024 +0100 Commit: Miklos Vajna CommitDate: Tue Feb 27 08:09:39 2024 +0100 tdf#159017 sw floattable: only shift to the right when needed Regression from commit 868140fcc1311259b9d5f37b33d226511a53 (tdf#60558 sw floattable: allow wrap of table on the right of a floattable, 2023-12-05), the document had an inline table, followed by a floating table, and we moved the inline table to the right even if the left hand side of the floating table already had enough space. What happens here is that nominally the inline table's original position overlaps, but because the table width is small enough, such an overlap doesn't actually happen. In this case, it's not needed to shift the inline table to the right. Fix the problem by making the check that decides whether it's necessary to increment the left margin of the table more strict: it's not enough to have enough space on the right of the fly, it's also needed to *not* have enough space on the left side. This keeps the original "floating table wrapped by inline table on the right" use-case working, but restores the ~no left margin for the inline table for the new bugdoc. Conflicts: sw/source/core/layout/tabfrm.cxx Change-Id: Ifb30d90ca6dba7cc4a402d8a4445251120b575ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162447 Reviewed-by: Miklos Vajna Tested-by: Jenkins (cherry picked from commit 6e3ad6ca0ae6cf62056610ddae9097973a887d99) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163953 Tested-by: Jenkins CollaboraOffice diff --git a/sw/qa/core/layout/data/floattable-not-wrapped-by-table.docx b/sw/qa/core/layout/data/floattable-not-wrapped-by-table.docx new file mode 100644 index ..2c255148d351 Binary files /dev/null and b/sw/qa/core/layout/data/floattable-not-wrapped-by-table.docx differ diff --git a/sw/qa/core/layout/tabfrm.cxx b/sw/qa/core/layout/tabfrm.cxx index 68c0821d46df..82d7b3b996d1 100644 --- a/sw/qa/core/layout/tabfrm.cxx +++ b/sw/qa/core/layout/tabfrm.cxx @@ -199,6 +199,28 @@ CPPUNIT_TEST_FIXTURE(Test, testSplitFlyWrappedByTable) // i.e. the inline table was under the floating one, not on the right of it. CPPUNIT_ASSERT_LESS(nFloatingBottom, nInlineTop); } + +CPPUNIT_TEST_FIXTURE(Test, testInlineTableThenSplitFly) +{ +// Given a document with a floating table ("right") and an inline table ("left"): +// When laying out the document: +createSwDoc("floattable-not-wrapped-by-table.docx"); + +// Then make sure the inline table is on the left (small negative offset): +SwDoc* pDoc = getSwDoc(); +SwRootFrame* pLayout = pDoc->getIDocumentLayoutAccess().GetCurrentLayout(); +auto pPage = pLayout->Lower()->DynCastPageFrame(); +CPPUNIT_ASSERT(pPage); +SwFrame* pBody = pPage->FindBodyCont(); +auto pTab = pBody->GetLower()->GetNext()->DynCastTabFrame(); +SwTwips nInlineLeft = pTab->getFramePrintArea().Left(); +// Without the accompanying fix in place, this test would have failed with: +// - Expected less than: 0 +// - Actual : 6958 +// i.e. "left" was on the right, its horizontal margin was not a small negative value but a +// large positive one. +CPPUNIT_ASSERT_LESS(static_cast(0), nInlineLeft); +} } /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/sw/source/core/layout/tabfrm.cxx b/sw/source/core/layout/tabfrm.cxx index fb0ebaa13425..c6d836cf7642 100644 --- a/sw/source/core/layout/tabfrm.cxx +++ b/sw/source/core/layout/tabfrm.cxx @@ -3136,6 +3136,7 @@ bool SwTabFrame::CalcFlyOffsets( SwTwips& rUpper, bool bShiftDown = css::text::WrapTextMode_NONE == nSurround; bool bSplitFly = pFly->IsFlySplitAllowed(); +const SwRect aFlyRectWithoutSpaces = pFly->GetObjRect(); if (!bShiftDown && bAddVerticalFlyOffsets) { if (nSurround == text::WrapTextMode_PARALLEL && isHoriOrientShiftDown) @@ -3150,7 +3151,6 @@ bool SwTabFrame::CalcFlyOffsets( SwTwips& rUpper, // Ignore spacing when determining the left/right edge of the fly, like // Word does. -const SwRect aFlyRectWithoutSpaces = pFly->GetObjRect(); basegfx::B1DRange aFlyRange(aRectFnSet.GetLeft(aFlyRectWithoutSpaces),
[Bug 159901] Calc=>Style: Hidden when print (Ukryj na wydruku)
https://bugs.documentfoundation.org/show_bug.cgi?id=159901 --- Comment #2 from Jaroslaw --- Created attachment 192815 --> https://bugs.documentfoundation.org/attachment.cgi?id=192815=edit file with how to work "hidden when print" This file included information in what set (Sytle, conditional formating) -- You are receiving this mail because: You are the assignee for the bug.
core.git: solenv/gbuild
solenv/gbuild/CppunitTest.mk |5 - 1 file changed, 5 deletions(-) New commits: commit c29d1d968acd53bd957eedc0d93bfaa620fc862b Author: Stephan Bergmann AuthorDate: Mon Feb 26 22:15:27 2024 +0100 Commit: Stephan Bergmann CommitDate: Tue Feb 27 07:56:12 2024 +0100 Remove unused gb_CppunitTest_localized_run ...that appears to be unused ever since it got introduced in d8a8ed04b14390d4469ea19b079778fa6f074bb2 "gbuild allow unitest to run once per lang in WITH_LANG_LIST" Change-Id: Id43b8498ca68c274902dfb3dfd4b035e199cb9b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163993 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/solenv/gbuild/CppunitTest.mk b/solenv/gbuild/CppunitTest.mk index 287ec84eb6c5..cfca2bbbf570 100644 --- a/solenv/gbuild/CppunitTest.mk +++ b/solenv/gbuild/CppunitTest.mk @@ -282,11 +282,6 @@ $(call gb_CppunitTest__use_vcl,$(1),$(false)) endef -define gb_CppunitTest_localized_run -$(call gb_CppunitTest_get_target,$(1)) : gb_CppunitTest_localized := $(true) - -endef - define gb_CppunitTest__use_api $(call gb_CppunitTest_get_target,$(1)) : $(call gb_UnoApi_get_target,$(2)) $(call gb_CppunitTest_get_target,$(1)) : UNO_TYPES += $(call gb_UnoApi_get_target,$(2))
core.git: Branch 'libreoffice-7-6' - android/source
android/source/res/values-cs/strings.xml |2 ++ 1 file changed, 2 insertions(+) New commits: commit 6ac9dc0b2f36c3483fd5c359462be1959e564ccf Author: Weblate AuthorDate: Sun Feb 25 08:37:27 2024 +0100 Commit: Michael Weghorn CommitDate: Tue Feb 27 07:42:47 2024 +0100 android-viewer translated using Weblate Czech currently translated at 54.6% (71 of 130 strings) Change-Id: I09c79e6b17038a16b7a46575259444c637388238 Co-authored-by: raal Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-7-6/cs/ Translation: android-viewer/android-strings-7-6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163901 Tested-by: Jenkins Reviewed-by: Michael Weghorn diff --git a/android/source/res/values-cs/strings.xml b/android/source/res/values-cs/strings.xml index aa5043220231..8cf0583a39f9 100644 --- a/android/source/res/values-cs/strings.xml +++ b/android/source/res/values-cs/strings.xml @@ -69,4 +69,6 @@ Upravit výšku Optimální výška Vyberte možnosti smazání: +Ikona souboru +Optimální šířka \ No newline at end of file
[Bug 159650] Double clicking on a cell containing Karasiewicz crashes LibreOffice Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=159650 --- Comment #7 from Stéphane Guillou (stragu) --- (In reply to Stéphane Guillou (stragu) from comment #6) > Nor on Windows 11: Version: 24.2.0.3 (X86_64) / LibreOffice Community Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1 CPU threads: 4; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159650] Double clicking on a cell containing Karasiewicz crashes LibreOffice Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=159650 Stéphane Guillou (stragu) changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 CC||stephane.guillou@libreoffic ||e.org --- Comment #6 from Stéphane Guillou (stragu) --- Does not crash with: Version: 24.2.0.3 (X86_64) / LibreOffice Community Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Nor on Windows 11: Version: 24.2.0.3 (X86_64) / LibreOffice Community Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Please share the full version information copied from Help > About > LibreOffice. If you see "UI Render: Skia/Vulkan", please: * share your Skia log, copied from Tools ▸ Options... ▸ LibreOffice ▸ View * see if it still crashes with Skia/Raster instead, by turning "Force Skia software rendering" on in the same dialog. -- You are receiving this mail because: You are the assignee for the bug.
core.git: extensions/test
extensions/test/ole/cpnt/cpnt.cxx | 48 +++--- 1 file changed, 24 insertions(+), 24 deletions(-) New commits: commit 9786fb8b94889072c2f5b3a7d4724d9bab6c3261 Author: AhmedHamed AuthorDate: Sat Feb 24 16:34:37 2024 +0200 Commit: Hossein CommitDate: Tue Feb 27 07:26:36 2024 +0100 tdf#145538 Use range based for loops Change-Id: I62ed915f3ac398ffdffb0a47e40ce23f0a893b3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163885 Tested-by: Jenkins Reviewed-by: Hossein diff --git a/extensions/test/ole/cpnt/cpnt.cxx b/extensions/test/ole/cpnt/cpnt.cxx index 41df66dba69f..ec7bac088b59 100644 --- a/extensions/test/ole/cpnt/cpnt.cxx +++ b/extensions/test/ole/cpnt/cpnt.cxx @@ -390,88 +390,88 @@ extern "C" SAL_DLLPUBLIC_EXPORT void * SAL_CALL component_getFactory( Sequence SAL_CALL OComponent::methodByte(const Sequence< sal_Int8 >& aSeq) throw( RuntimeException ) { sal_Int8 _x; -for( sal_Int16 i= 0; i < aSeq.getLength(); i++){ -_x= aSeq.getConstArray()[i]; +for( const auto& i : aSeq.getConstArray() ){ +_x= i; } return aSeq; } Sequence SAL_CALL OComponent::methodFloat(const Sequence< float>& aSeq) throw( RuntimeException ) { float _x; -for( sal_Int16 i= 0; i < aSeq.getLength(); i++){ -_x= aSeq.getConstArray()[i]; +for( const auto& i : aSeq.getConstArray() ){ +_x= i; } return aSeq; } Sequence SAL_CALL OComponent::methodDouble(const Sequence< double >& aSeq) throw( RuntimeException) { double _x; -for( sal_Int16 i= 0; i < aSeq.getLength(); i++){ -_x= aSeq.getConstArray()[i]; +for( const auto& i : aSeq.getConstArray() ){ +_x= i; } return aSeq; } Sequence< sal_Bool > SAL_CALL OComponent::methodBool(const Sequence< sal_Bool >& aSeq) throw( RuntimeException) { sal_Bool _x; -for( sal_Int16 i= 0; i < aSeq.getLength(); i++){ -_x= aSeq.getConstArray()[i]; +for( const auto& i : aSeq.getConstArray() ){ +_x= i; } return aSeq; } Sequence< sal_Int16 > SAL_CALL OComponent::methodShort(const Sequence< sal_Int16 >& aSeq) throw( RuntimeException ) { sal_Int16 _x; -for( sal_Int16 i= 0; i < aSeq.getLength(); i++){ -_x= aSeq.getConstArray()[i]; +for( const auto& i : aSeq.getConstArray() ){ +_x= i; } return aSeq; } Sequence< sal_uInt16 > SAL_CALL OComponent::methodUShort(const Sequence< sal_uInt16 >& aSeq) throw( RuntimeException ) { sal_uInt16 _x; -for( sal_Int16 i= 0; i < aSeq.getLength(); i++){ -_x= aSeq.getConstArray()[i]; +for( const auto& i : aSeq.getConstArray() ){ +_x= i; } return aSeq; } Sequence< sal_Int32 > SAL_CALL OComponent::methodLong(const Sequence< sal_Int32 >& aSeq) throw( RuntimeException) { sal_Int32 _x; -for( sal_Int16 i= 0; i < aSeq.getLength(); i++) { -_x= aSeq.getConstArray()[i]; +for( const auto& i : aSeq.getConstArray() ){ +_x= i; } return aSeq; } Sequence< sal_uInt32 > SAL_CALL OComponent::methodULong(const Sequence< sal_uInt32 >& aSeq) throw( RuntimeException) { sal_uInt32 _x; -for( sal_Int16 i= 0; i < aSeq.getLength(); i++){ -_x= aSeq.getConstArray()[i]; +for( const auto& i : aSeq.getConstArray() ){ +_x= i; } return aSeq; } Sequence< OUString > SAL_CALL OComponent::methodString(const Sequence< OUString >& aSeq) throw( RuntimeException) { OUString _x; -for( sal_Int16 i= 0; i < aSeq.getLength(); i++) { -_x= aSeq.getConstArray()[i]; +for( const auto& i : aSeq.getConstArray() ){ +_x= i; } return aSeq; } Sequence< sal_Unicode > SAL_CALL OComponent::methodChar(const Sequence< sal_Unicode >& aSeq) throw( RuntimeException) { sal_Unicode _x; -for( sal_Int16 i= 0; i < aSeq.getLength(); i++){ -_x= aSeq.getConstArray()[i]; +for( const auto& i : aSeq.getConstArray() ){ +_x= i; } return aSeq; } Sequence< Any > SAL_CALL OComponent::methodAny(const Sequence< Any >& aSeq) throw( RuntimeException) { Any _x; -for( sal_Int16 i= 0; i < aSeq.getLength(); i++){ -_x= aSeq.getConstArray()[i]; +for( const auto& i : aSeq.getConstArray() ){ +_x= i; TypeClass _t= _x.getValueTypeClass(); if( _t== TypeClass_STRING) OUString s(* (rtl_uString**)_x.getValue()); @@ -483,8 +483,8 @@ Sequence< Any > SAL_CALL OComponent::methodAny(const Sequence< Any >& aSeq) thro Sequence< Type > SAL_CALL OComponent::methodType(const Sequence< Type >& aSeq) throw( RuntimeException ) { Type _x; -for( sal_Int16 i= 0; i < aSeq.getLength(); i++){ -_x= aSeq.getConstArray()[i]; +for( const auto& i : aSeq.getConstArray() ){ +_x= i; } return aSeq; }
[Bug 145538] Use range based for loops
https://bugs.documentfoundation.org/show_bug.cgi?id=145538 --- Comment #36 from Commit Notification --- AhmedHamed committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9786fb8b94889072c2f5b3a7d4724d9bab6c3261 tdf#145538 Use range based for loops It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156676] Spreadsheet: converting formulas formatted as text to show formula result
https://bugs.documentfoundation.org/show_bug.cgi?id=156676 Stéphane Guillou (stragu) changed: What|Removed |Added OS|Linux (All) |All Hardware|x86-64 (AMD64) |All -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159898] Writer context menu displays greyed out non-available options
https://bugs.documentfoundation.org/show_bug.cgi?id=159898 --- Comment #7 from Tex2002ans --- Created attachment 192814 --> https://bugs.documentfoundation.org/attachment.cgi?id=192814=edit LO 24.2.0 with DontHideDisabledEntry set to "false" (In reply to David Robley from comment #6) > the officecfg::Office::Common::View::Menu::DontHideDisabledEntry setting is > configurable via expert configuration. [...] Yep, that does it. Attached is an image showing LO 24.2.0 with "DontHideDisabledEntry" set to false. - - - For those who want to go back to the minimal menu... Go to: 1. Tools > Options 2. LibreOffice > Advanced 3. Click on the "Open Expert Configuration" button. Now, in the "Expert Configuration" window: 4. Click in the search bar up top and type in: - DontHideDisabledEntry 5. Press the "Search" button. 6. Double-click on the row with "DontHideDisabledEntry" to set it from true -> false. 7. Press OK. - - - > Thus it seems the change is intentional and not a bug. Also CCing Jim, since it was his change I bibisected to. - - - Side Note: Also weird, do these Expert configs usually have "double negatives"? - "Hide Disabled Entry" = Enabled means "YES hide" = Disabled means "NO hide" vs. the current: - "Don't Hide Disabled Entry" = Enabled means "YES DO NOT hide!" = Disabled means "NO DO NOT hide!" seems pretty confusing to me. -- You are receiving this mail because: You are the assignee for the bug.
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 7 new defect(s) introduced to LibreOffice found with Coverity Scan. 3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 7 of 7 defect(s) ** CID 1592381:(OVERRUN) /oox/source/drawingml/scene3dhelper.cxx: 248 in oox::Scene3DHelper::getAPIAnglesFrom3DProperties(std::shared_ptr, const int &, double &, double &, double &)() /oox/source/drawingml/scene3dhelper.cxx: 250 in oox::Scene3DHelper::getAPIAnglesFrom3DProperties(std::shared_ptr, const int &, double &, double &, double &)() /oox/source/drawingml/scene3dhelper.cxx: 249 in oox::Scene3DHelper::getAPIAnglesFrom3DProperties(std::shared_ptr, const int &, double &, double &, double &)() *** CID 1592381:(OVERRUN) /oox/source/drawingml/scene3dhelper.cxx: 248 in oox::Scene3DHelper::getAPIAnglesFrom3DProperties(std::shared_ptr, const int &, double &, double &, double &)() 242 // OOXML markup are given, they overwrite the values from the preset camera type. Otherwise the 243 // values from the preset camera are used. OOXML requires that all three attributes must exist at 244 // the same time. Thus it is enough to test one of them. 245 if (!(*p3DProperties).maCameraRotation.mnRevolution.has_value()) 246 { 247 // The angles are given in 1/6 deg in aPrstCameraValuesArray. >>> CID 1592381:(OVERRUN) >>> Overrunning array "oox::aPrstCameraValuesArray" of 62 104-byte elements >>> at element index 62 (byte offset 6551) using index >>> "this->mnPrstCameraIndex" (which evaluates to 62). 248 nLatitude = aPrstCameraValuesArray[mnPrstCameraIndex].mfRotateAngleX; 249 nLongitude = aPrstCameraValuesArray[mnPrstCameraIndex].mfRotateAngleY; 250 nRevolution = aPrstCameraValuesArray[mnPrstCameraIndex].mfRotateAngleZ; 251 } 252 253 // MS Office applies the shape rotation after the rotations from camera in case of non-legacy /oox/source/drawingml/scene3dhelper.cxx: 250 in oox::Scene3DHelper::getAPIAnglesFrom3DProperties(std::shared_ptr, const int &, double &, double &, double &)() 244 // the same time. Thus it is enough to test one of them. 245 if (!(*p3DProperties).maCameraRotation.mnRevolution.has_value()) 246 { 247 // The angles are given in 1/6 deg in aPrstCameraValuesArray. 248 nLatitude = aPrstCameraValuesArray[mnPrstCameraIndex].mfRotateAngleX; 249 nLongitude = aPrstCameraValuesArray[mnPrstCameraIndex].mfRotateAngleY; >>> CID 1592381:(OVERRUN) >>> Overrunning array "oox::aPrstCameraValuesArray" of 62 104-byte elements >>> at element index 62 (byte offset 6551) using index >>> "this->mnPrstCameraIndex" (which evaluates to 62). 250 nRevolution = aPrstCameraValuesArray[mnPrstCameraIndex].mfRotateAngleZ; 251 } 252 253 // MS Office applies the shape rotation after the rotations from camera in case of non-legacy 254 // cameras, and before for legacy cameras. ODF specifies to first rotate the shape. Thus we need 255 // to add shape rotation to nRevolution in case of non-legacy cameras. The shape rotation has /oox/source/drawingml/scene3dhelper.cxx: 249 in oox::Scene3DHelper::getAPIAnglesFrom3DProperties(std::shared_ptr, const int &, double &, double &, double &)() 243 // values from the preset camera are used. OOXML requires that all three attributes must exist at 244 // the same time. Thus it is enough to test one of them. 245 if (!(*p3DProperties).maCameraRotation.mnRevolution.has_value()) 246 { 247 // The angles are given in 1/6 deg in aPrstCameraValuesArray. 248 nLatitude = aPrstCameraValuesArray[mnPrstCameraIndex].mfRotateAngleX; >>> CID 1592381:(OVERRUN) >>> Overrunning array "oox::aPrstCameraValuesArray" of 62 104-byte elements >>> at element index 62 (byte offset 6551) using index >>> "this->mnPrstCameraIndex" (which evaluates to 62). 249 nLongitude = aPrstCameraValuesArray[mnPrstCameraIndex].mfRotateAngleY; 250 nRevolution = aPrstCameraValuesArray[mnPrstCameraIndex].mfRotateAngleZ; 251 } 252 253 // MS Office applies the shape rotation after the rotations from camera in case of non-legacy 254 // cameras, and before for legacy cameras. ODF specifies to first rotate the shape. Thus we need ** CID 1592380: Incorrect expression (COPY_PASTE_ERROR) /sd/source/ui/slideshow/slideshowimpl.cxx: 3439 in sd::SlideshowImpl::Notify(SfxBroadcaster &, const SfxHint &)()
[Bug 157337] .uno:InsertTimeField and .uno:InsertDateField now insert variable time and date fields respectively instead the fixed variants, breaking macros
https://bugs.documentfoundation.org/show_bug.cgi?id=157337 Stéphane Guillou (stragu) changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #16 from Stéphane Guillou (stragu) --- thanks for reporting and verifying! :) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 103182] [META] GTK3-specific bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103182 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||159645 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=159645 [Bug 159645] CTRL-F after applying last used cell background color or font color does not focus search field (gtk3) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 102847] [META] Quick Find, Search and Replace
https://bugs.documentfoundation.org/show_bug.cgi?id=102847 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||159645 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=159645 [Bug 159645] CTRL-F after applying last used cell background color or font color does not focus search field (gtk3) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159645] CTRL-F after applying last used cell background color or font color does not focus search field (gtk3)
https://bugs.documentfoundation.org/show_bug.cgi?id=159645 Stéphane Guillou (stragu) changed: What|Removed |Added Summary|focus with CTRL-F in Find |CTRL-F after applying last |bar freezes after applying |used cell background color |last used background color |or font color does not |for cell|focus search field (gtk3) Blocks||103182, 102847 CC||caolan.mcnamara@collabora.c ||om, ||stephane.guillou@libreoffic ||e.org Regression By||Caolán McNamara Version|7.3.7.2 release |7.0.2.2 release Ever confirmed|0 |1 Whiteboard| QA:needsComment| Status|UNCONFIRMED |NEW Hardware|x86 (IA32) |All Keywords||bibisected, bisected, ||regression See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||5779 --- Comment #1 from Stéphane Guillou (stragu) --- Thanks for the report! (In reply to d4928443 from comment #0) > ==variant 1== > 5. at this point one can see already an odd behaviour (if you have more > search strings in the search field history): the pre filled search term > changes to another search string previously used, instead of leaving the > last used search word, in this case "apple" there. I can't reproduce this. > ==variant 2== > 9. use CTRL-F to go back to the search bar, and at this point the focus in > the search bar completely freezes. Reproduced, and the same happens with another split button like Font Colour. Version: 7.3.0.3 / LibreOffice Community Build ID: 0f246aa12d0eee4a0f7adcefbf7c878fc2238db3 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: d2fa44db6f8a1badece63856ee0f12db4cba9b28 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Not reproduced with gen VCL plugin not kf5, so gtk3-specific. Bibisected with linux-64-7.0 to first bad build [89a072a16c5f44658af2af88dd24ddc40e23a2c0] which is: commit 6a4dfa7469168207a9c11463d1b1c9cef5f86c3f author Caolán McNamara Sun Aug 23 20:12:28 2020 +0100 committer Michael Stahl Mon Aug 24 12:12:15 2020 +0200 tdf#135779 move focus back to usual parent before grabbing pointer Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101153 Caolán, can you please have a look? Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102847 [Bug 102847] [META] Quick Find, Search and Replace https://bugs.documentfoundation.org/show_bug.cgi?id=103182 [Bug 103182] [META] GTK3-specific bugs -- You are receiving this mail because: You are the assignee for the bug.
[Bug 48534] EDITING: No footnotes possible in frames including figure captions
https://bugs.documentfoundation.org/show_bug.cgi?id=48534 --- Comment #19 from Grantler --- > The structure of my document requires me to use captions for photographs, > but I also need to footnote the sources of the photographs. I've done hours > of work until I encountered this problem. Version: 24.2.0.3 (X86_64) / LibreOffice Community Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1 CPU threads: 2; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: threaded Problem still there on 24.2.0.3 Version (Windows). No footnotes possible in frames resp. for labeled images. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 132456] Lots of time spend in SfxBroadcaster::RemoveListener Undoing deleting a row (3/4 minutes)
https://bugs.documentfoundation.org/show_bug.cgi?id=132456 --- Comment #6 from Tex2002ans --- ~16 seconds in: Version: 24.2.0.3 (X86_64) / LibreOffice Community Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1 CPU threads: 8; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 133968] Freeze hang after deleting index and undo with old swx
https://bugs.documentfoundation.org/show_bug.cgi?id=133968 --- Comment #9 from Tex2002ans --- I did not get a hang on: Version: 24.2.0.3 (X86_64) / LibreOffice Community Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1 CPU threads: 8; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded - - - I was able to Delete the TOC + Undo, and everything seemed fine. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159643] Too wide error message box for long error message
https://bugs.documentfoundation.org/show_bug.cgi?id=159643 Stéphane Guillou (stragu) changed: What|Removed |Added Keywords||needsDevAdvice URL||https://forum.languagetool. ||org/t/libreoffice-extension ||-unrecognized-language-caus ||es-a-too-wide-error-message ||-box/9819 CC||hoss...@libreoffice.org, ||stephane.guillou@libreoffic ||e.org --- Comment #4 from Stéphane Guillou (stragu) --- Repro with LT 6.3.1 and: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: d2fa44db6f8a1badece63856ee0f12db4cba9b28 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Same with gen VCL. Hossein, what do you think? Shouldn't Java error messages be automatically wrapped (or maybe better: truncated, with option to copy text) in our dialogs? Or is this out of our control / should be handled by extension developers? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159633] UI: tables in which items can be "matched" by typing characters don't allow hyphen or underscore searches (- and _)
https://bugs.documentfoundation.org/show_bug.cgi?id=159633 --- Comment #3 from Stéphane Guillou (stragu) --- Created attachment 192813 --> https://bugs.documentfoundation.org/attachment.cgi?id=192813=edit sample ODS with named ranges and test styles Sample file to make it easy to test the filtering for named ranges and styles. (Same issue in Gallery sidebar deck, if custom themes are added.) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159418] Missing Navigation Arrows for Editing Index Entry
https://bugs.documentfoundation.org/show_bug.cgi?id=159418 --- Comment #7 from Tex2002ans --- Created attachment 192812 --> https://bugs.documentfoundation.org/attachment.cgi?id=192812=edit Edit Index Entry Menu - Missing Arrow Buttons in LO 24.2.0 I attached a PNG showing before/after (correct/wrong). You can see a 2x2 grid of left/right (previous/next) arrows showing in UI. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 103427] [META] Styles and Formatting sidebar deck and floating window
https://bugs.documentfoundation.org/show_bug.cgi?id=103427 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||159633 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=159633 [Bug 159633] UI: tables in which items can be "matched" by typing characters don't allow hyphen or underscore searches (- and _) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 109178] [META] Named Cell Ranges and Formula Expressions bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109178 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||159633 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=159633 [Bug 159633] UI: tables in which items can be "matched" by typing characters don't allow hyphen or underscore searches (- and _) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103341 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||159633 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=159633 [Bug 159633] UI: tables in which items can be "matched" by typing characters don't allow hyphen or underscore searches (- and _) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159633] UI: tables in which items can be "matched" by typing characters don't allow hyphen or underscore searches (- and _)
https://bugs.documentfoundation.org/show_bug.cgi?id=159633 Stéphane Guillou (stragu) changed: What|Removed |Added CC||caolan.mcnamara@collabora.c ||om, ||stephane.guillou@libreoffic ||e.org Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Version|24.2.0.3 release|4.0.0.3 release OS|Windows (All) |All Blocks||103341, 103427, 109178 Summary|AutoCorrect Repalce table |UI: tables in which items |list can not take hyphen|can be "matched" by typing |key words. (- and _)|characters don't allow ||hyphen or underscore ||searches (- and _) Component|Writer |UI --- Comment #2 from Stéphane Guillou (stragu) --- Thank you both. Reproduced as well in gen VCL plugin but not gtk3. Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: d2fa44db6f8a1badece63856ee0f12db4cba9b28 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: x11 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded This is also visible in other searchable tables e.g. the Styles sidebar deck: typing "-" and "_" won't jump to styles named e.g. "-test" and "_test". Same thing with Calc > Sheet > Named Ranges and Expressions > Manage (for underscore at least, as hyphens are not allowed). For the Stylist, I can reproduce in libreoffice-4.0.0.3, so it's a long-standing issue. Caolán, maybe you have some insights on this? Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103341 [Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=103427 [Bug 103427] [META] Styles and Formatting sidebar deck and floating window https://bugs.documentfoundation.org/show_bug.cgi?id=109178 [Bug 109178] [META] Named Cell Ranges and Formula Expressions bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159418] Missing Navigation Arrows for Editing Index Entry
https://bugs.documentfoundation.org/show_bug.cgi?id=159418 Tex2002ans changed: What|Removed |Added Keywords|bibisectRequest |bibisected CC||armin.le.gr...@me.com --- Comment #6 from Tex2002ans --- I think I was able to bibisect it to: - https://cgit.freedesktop.org/libreoffice/core/commit/?id=ab7c81f55621d7b0d1468c63305163016dd78837 Both in win64-24.2 branch + linux-64-24.2. (Hopefully I did it correct, it's only my 3rd bibisect ever.) - - - - - - - - - author Armin Le Grand (allotropia) 2023-10-04 15:42:27 +0200 committer Armin Le Grand 2023-11-07 18:07:13 +0100 commit ab7c81f55621d7b0d1468c63305163016dd78837 (patch) tree4fb039902ced911bb96660edd343ee5705e5688b parent 89780c208837973e21ddbf098d77f4369018ee9e (diff) ITEM: Get away from classic 'poolable' Item flag - - - - - - - - - And whoops, my instructions in comment 5 were wrong. Here's better instructions: 1. Insert > Table of Contents and Index > Index Entry 2. In "Entry" box: - Type "Test". 3. Press "Insert" button twice. 3. Back in document, on gray highlights: - Right-Click > "Edit Index Entry" The "Edit Index Entry" menu should have up to 4 arrow buttons (2 sets of 2) in UI. 2 left/right arrows: - Previous entry (same name) - Next entry (same name) 2 left/right arrows: - Previous entry - Next entry -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159898] Writer context menu displays greyed out non-available options
https://bugs.documentfoundation.org/show_bug.cgi?id=159898 --- Comment #6 from David Robley --- In reply to Tex2002ans comment: It transpires that the officecfg::Office::Common::View::Menu::DontHideDisabledEntry setting is configurable via expert configuration. Thus it seems the change is intentional and not a bug. To change the setting, go to Tools | Options | LibreOffice | Advanced and click on Open Expert Configuration. In the Search field type disabledentry and click Search. This will display the relevant entry; double click to toggle the value. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159846] Calc: Disappearing borders on tall merged cells
https://bugs.documentfoundation.org/show_bug.cgi?id=159846 ady changed: What|Removed |Added CC||noelgran...@gmail.com --- Comment #7 from ady --- (In reply to Tex2002ans from comment #6) > I believe I bibisected it to this commit: > > https://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=e27d4cc31e04be4c47b5085dfa2363ee45457e8a > > Could not reproduce in the 7.6 branch, but could in the 24.2 branch. Let's CC' Noel then. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 130830] Writer: Inconsistent language in table cell having multiple languages after applying Currency number format
https://bugs.documentfoundation.org/show_bug.cgi?id=130830 --- Comment #4 from Mike Kaganski --- Repro using Version: 24.2.1.1 (X86_64) / LibreOffice Community Build ID: 359ef544e625d2ffbfced462ab37bd593ca85fa7 CPU threads: 24; OS: Windows 10.0 Build 22631; UI render: default; VCL: win Locale: ru-RU (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159846] Calc: Disappearing borders on tall merged cells
https://bugs.documentfoundation.org/show_bug.cgi?id=159846 Tex2002ans changed: What|Removed |Added CC||Tex2002ans+LibreOffice@gmai ||l.com Keywords|bibisectRequest |bibisected --- Comment #6 from Tex2002ans --- I believe I bibisected it to this commit: https://cgit.freedesktop.org/libreoffice/core/commit/?id=e27d4cc31e04be4c47b5085dfa2363ee45457e8a (Hopefully I did this correct. Only my 2nd bibisect ever.) I tested in on Windows + followed the video attachment 192718's instructions exactly. Could not reproduce in the 7.6 branch, but could in the 24.2 branch. - - - - - - - author Noel Grandin 2023-06-19 12:23:55 +0200 committer Noel Grandin 2023-06-19 18:26:03 +0200 commit e27d4cc31e04be4c47b5085dfa2363ee45457e8a (patch) tree75aebab2bd9a0c2d0f152fb545757af0513f5aec parent 281bdb5a979f0516fe7a9cd35585fd3daf4021b1 (diff) tdf#150534 reduce the memory consumption of cells when calculating borders - if there are a lot hidden columns, we end up allocating a lot of cells. Since most of the cells have the same settings, use a SfxItemPool to consolidate them. Change-Id: If2dd77b3eabc5d37eb8804953f8c89ffa04f2400 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153258 Tested-by: Jenkins Reviewed-by: Noel Grandin -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159917] crash when copying text box from one graph to other
https://bugs.documentfoundation.org/show_bug.cgi?id=159917 Stéphane Guillou (stragu) changed: What|Removed |Added Ever confirmed|0 |1 Crash report or||[".LTHUNK9.lto_priv.11672"] crash signature|| Status|UNCONFIRMED |NEEDINFO CC||stephane.guillou@libreoffic ||e.org --- Comment #1 from Stéphane Guillou (stragu) --- Are you able to share an example file, maybe with more reliable steps to reproduce it? Also, many crashes have been fixed since 7.5.6, and the 7.5 branch is not maintained anymore. I would recommend moving to 7.6 or 24.2. I tried reproducing with your steps and couldn't crash it in: Version: 7.6.5.2 (X86_64) / LibreOffice Community Build ID: 38d5f62f85355c192ef5f1dd47c5c0c0c6d6598b CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159258] A picture placeholder with a background, imported from PPTX, is not shown when presenting
https://bugs.documentfoundation.org/show_bug.cgi?id=159258 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||6400 Version|unspecified |3.6.0.4 release CC||stephane.guillou@libreoffic ||e.org Keywords||bibisectRequest, regression --- Comment #7 from Stéphane Guillou (stragu) --- Repro in: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: d2fa44db6f8a1badece63856ee0f12db4cba9b28 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Checked with linux-64-releases bibisect repo: - libreoffice-3.4.6rc2: picture placeholder is solid dark green, seen the same in edit mode and presentation - since libreoffice-3.5.0rc3: picture placeholder has scaled up image icon on it, but seen the same in edit mode and presentation - since libreoffice-3.6.0.4: icon is now a normal size, but slide is blank in presentation mode. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156400] FILEOPEN PPTX: rogue image element appears (in presentation mode only)
https://bugs.documentfoundation.org/show_bug.cgi?id=156400 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||9258 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156400] FILEOPEN PPTX: rogue image element appears (in presentation mode only)
https://bugs.documentfoundation.org/show_bug.cgi?id=156400 Stéphane Guillou (stragu) changed: What|Removed |Added Version|3.6.5.2 release |3.5.0 release --- Comment #8 from Stéphane Guillou (stragu) --- (In reply to Stéphane Guillou (stragu) from comment #7) > it could have started at any stage between: > > build [17cbb2ce32a1c75418e0cc10a2a146576a1eb7ee] libreoffice-3.5.6rc2 > > and > > build [f8782458d3ba33ae31943025d61461580a26303b] libreoffice-3.6.5.2 Actually, could get libpng12 going on Ubuntu 22.04 [1], and that range about is wrong. Previous versions also needed skipping. First version affected is libreoffice-3.5.0rc3 for that repo. [1]: https://wiki.documentfoundation.org/QA/Bibisect/Linux#Setting_up_Environment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159691] Macro Security option in calc
https://bugs.documentfoundation.org/show_bug.cgi?id=159691 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159688] "Emphasis - Teeter" effects leaves image in random position
https://bugs.documentfoundation.org/show_bug.cgi?id=159688 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159890] FILEOPEN: DOCX: Most line styles ignored
https://bugs.documentfoundation.org/show_bug.cgi?id=159890 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159890] FILEOPEN: DOCX: Most line styles ignored
https://bugs.documentfoundation.org/show_bug.cgi?id=159890 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156533] Links NOT All Functional
https://bugs.documentfoundation.org/show_bug.cgi?id=156533 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156526] Crash
https://bugs.documentfoundation.org/show_bug.cgi?id=156526 --- Comment #4 from QA Administrators --- Dear neshana, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156526] Crash
https://bugs.documentfoundation.org/show_bug.cgi?id=156526 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157027] libreoffice calc does not open
https://bugs.documentfoundation.org/show_bug.cgi?id=157027 --- Comment #2 from QA Administrators --- Dear johnwatjen, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156533] Links NOT All Functional
https://bugs.documentfoundation.org/show_bug.cgi?id=156533 --- Comment #3 from QA Administrators --- Dear nik, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Bug 147531] Thai default font on Linux is too big
https://bugs.documentfoundation.org/show_bug.cgi?id=147531 --- Comment #7 from QA Administrators --- Dear Theppitak Karoonboonyanan, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156987] LibreOffice calc uses incorrect theme colors and ends up with black on black text
https://bugs.documentfoundation.org/show_bug.cgi?id=156987 --- Comment #3 from QA Administrators --- Dear Mikko Rantalainen, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Bug 147350] Horizontal alignment of a frame is not honored
https://bugs.documentfoundation.org/show_bug.cgi?id=147350 --- Comment #7 from QA Administrators --- Dear Jambunathan K, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 147192] Track changes registers 'portions' of changes while editing, after save and reload 2 remain
https://bugs.documentfoundation.org/show_bug.cgi?id=147192 --- Comment #8 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 132126] Result of exporting selection to HTML includes content from other sheet
https://bugs.documentfoundation.org/show_bug.cgi?id=132126 --- Comment #3 from QA Administrators --- Dear Buovjaga, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 130830] Writer: Inconsistent language in table cell having multiple languages after applying Currency number format
https://bugs.documentfoundation.org/show_bug.cgi?id=130830 --- Comment #3 from QA Administrators --- Dear Mike Kaganski, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 113325] Deleting and renaming a table style is not reflected in table style sidebar (until document closed)
https://bugs.documentfoundation.org/show_bug.cgi?id=113325 --- Comment #7 from QA Administrators --- Dear Ulrich Gemkow, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
core.git: sc/inc sc/source
sc/inc/column.hxx |3 ++- sc/inc/mtvelements.hxx |5 +++-- sc/source/core/data/column.cxx |6 +- sc/source/core/data/column2.cxx |4 +--- sc/source/core/data/column4.cxx | 12 sc/source/core/data/mtvelements.cxx |6 ++ 6 files changed, 29 insertions(+), 7 deletions(-) New commits: commit 25ffb54c6d8a5b52dca6b782282962766e7791de Author: Kohei Yoshida AuthorDate: Mon Feb 26 19:50:19 2024 -0500 Commit: Kohei Yoshida CommitDate: Tue Feb 27 04:02:57 2024 +0100 Make ScColumn::HasCellNotes() less expensive It's essentially the same idea as checking if the column has formula cells; by keeping track of the block creation and deletion events to count the number of cell notes block instances at any given moment, and use that information to see if the column has any cell notes. Change-Id: I95c5186bf1f21f23f85fa10ff3c2135388949c72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163996 Tested-by: Kohei Yoshida Reviewed-by: Kohei Yoshida diff --git a/sc/inc/column.hxx b/sc/inc/column.hxx index 0e07ed8142b0..7b07f310b23e 100644 --- a/sc/inc/column.hxx +++ b/sc/inc/column.hxx @@ -206,7 +206,8 @@ class ScColumn : protected ScColumnData // Sparklines sc::SparklineStoreType maSparklines; -size_t mnBlkCountFormula; +std::size_t mnBlkCountFormula; +std::size_t mnBlkCountCellNotes; SCCOL nCol; SCTAB nTab; diff --git a/sc/inc/mtvelements.hxx b/sc/inc/mtvelements.hxx index 156346a945ba..9a7b525fb82a 100644 --- a/sc/inc/mtvelements.hxx +++ b/sc/inc/mtvelements.hxx @@ -114,8 +114,9 @@ struct SparklineTraits : public mdds::mtv::default_traits using block_funcs = mdds::mtv::element_block_funcs; }; -struct CellNodeTraits : public mdds::mtv::default_traits +struct CellNoteTraits : public mdds::mtv::default_traits { +using event_func = CellStoreEvent; using block_funcs = mdds::mtv::element_block_funcs; }; @@ -140,7 +141,7 @@ struct CellStoreTraits : public mdds::mtv::default_traits typedef mdds::mtv::soa::multi_type_vector SparklineStoreType; /// Cell note container -typedef mdds::mtv::soa::multi_type_vector CellNoteStoreType; +typedef mdds::mtv::soa::multi_type_vector CellNoteStoreType; /// Broadcaster storage container typedef mdds::mtv::soa::multi_type_vector BroadcasterStoreType; diff --git a/sc/source/core/data/column.cxx b/sc/source/core/data/column.cxx index 4df322def537..22d8cec28bc3 100644 --- a/sc/source/core/data/column.cxx +++ b/sc/source/core/data/column.cxx @@ -82,15 +82,17 @@ ScNeededSizeOptions::ScNeededSizeOptions() : ScColumn::ScColumn(ScSheetLimits const & rSheetLimits) : maCellTextAttrs(rSheetLimits.GetMaxRowCount()), -maCellNotes(rSheetLimits.GetMaxRowCount()), +maCellNotes(sc::CellStoreEvent(this)), maBroadcasters(rSheetLimits.GetMaxRowCount()), maCells(sc::CellStoreEvent(this)), maSparklines(rSheetLimits.GetMaxRowCount()), mnBlkCountFormula(0), +mnBlkCountCellNotes(0), nCol( 0 ), nTab( 0 ), mbEmptyBroadcastersPending( false ) { +maCellNotes.resize(rSheetLimits.GetMaxRowCount()); maCells.resize(rSheetLimits.GetMaxRowCount()); } @@ -1829,7 +1831,9 @@ void ScColumn::SwapCol(ScColumn& rCol) // Swap all CellStoreEvent mdds event_func related. maCells.event_handler().swap(rCol.maCells.event_handler()); +maCellNotes.event_handler().swap(rCol.maCellNotes.event_handler()); std::swap( mnBlkCountFormula, rCol.mnBlkCountFormula); +std::swap(mnBlkCountCellNotes, rCol.mnBlkCountCellNotes); // notes update caption UpdateNoteCaptions(0, GetDoc().MaxRow()); diff --git a/sc/source/core/data/column2.cxx b/sc/source/core/data/column2.cxx index 20e365acb06c..b9dcbf68bef2 100644 --- a/sc/source/core/data/column2.cxx +++ b/sc/source/core/data/column2.cxx @@ -2275,9 +2275,7 @@ void ScColumn::DeleteCellNotes( sc::ColumnBlockPosition& rBlockPos, SCROW nRow1, bool ScColumn::HasCellNotes() const { -if (maCellNotes.block_size() == 1 && maCellNotes.begin()->type == sc::element_type_empty) -return false; // all elements are empty -return true; // otherwise some must be notes +return mnBlkCountCellNotes != 0; } SCROW ScColumn::GetCellNotesMaxRow() const diff --git a/sc/source/core/data/column4.cxx b/sc/source/core/data/column4.cxx index 2f9c46deb838..bd9bba3df1f4 100644 --- a/sc/source/core/data/column4.cxx +++ b/sc/source/core/data/column4.cxx @@ -2233,6 +2233,18 @@ void ScColumn::CheckIntegrity() const << mnBlkCountFormula << ")"; throw std::runtime_error(os.str()); } + +nCount = std::count_if(maCellNotes.cbegin(), maCellNotes.cend(), +[](const auto& blk) { return blk.type == sc::element_type_cellnote; } +); + +if (mnBlkCountCellNotes != nCount) +{ +std::ostringstream os; +os << "incorrect cached cell note block
[Bug 156400] FILEOPEN PPTX: rogue image element appears (in presentation mode only)
https://bugs.documentfoundation.org/show_bug.cgi?id=156400 Stéphane Guillou (stragu) changed: What|Removed |Added Version|24.2.0.0 alpha0+|3.6.5.2 release CC||stephane.guillou@libreoffic ||e.org Keywords||bibisectRequest, regression --- Comment #7 from Stéphane Guillou (stragu) --- Testing with linux-64-releases, I had to skip a few versions (because of libpng12.so.0) and it could have started at any stage between: build [17cbb2ce32a1c75418e0cc10a2a146576a1eb7ee] libreoffice-3.5.6rc2 and build [f8782458d3ba33ae31943025d61461580a26303b] libreoffice-3.6.5.2 ...if anyone is able to bibisect that with 43all. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159898] Writer context menu displays greyed out non-available options
https://bugs.documentfoundation.org/show_bug.cgi?id=159898 Tex2002ans changed: What|Removed |Added Keywords|bibisectRequest |bibisected --- Comment #5 from Tex2002ans --- I couldn't reproduce on Linux (LO 7.6 or 24.2 GTK3)... But I WAS able to reproduce+bibisect it on Windows. (This is my very first bibisect, so hopefully it's correct.) - - - I bibisected it down to: https://cgit.freedesktop.org/libreoffice/core/commit/?id=a0955317900075371d6adb7f924af24c22f02d09 - - - author Jim Raykowski2023-09-15 21:26:32 -0800 committer Jim Raykowski2023-09-27 07:12:30 +0200 commit a0955317900075371d6adb7f924af24c22f02d09 (patch) treec5194d62d6f7f9935e7f4d7a191b6283205b6613 parent c2930ebff82c4f7ffe8377ab82627131f8544226 (diff) tdf#139935 Part B: Show all menu items possible/potential actions, but grey-out and deactivate, when not applicable This patch makes VCL PopupMenu respect the officecfg::Office::Common::View::Menu::DontHideDisabledEntry setting. Change-Id: I4df0de82585b602e12481ae46bc4f94c2588970d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156979 Tested-by: Jenkins Reviewed-by: Heiko Tietze -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159919] New: EMBEDDED VIDEOS ONLY PLAYING IN SAFE MODE
https://bugs.documentfoundation.org/show_bug.cgi?id=159919 Bug ID: 159919 Summary: EMBEDDED VIDEOS ONLY PLAYING IN SAFE MODE Product: LibreOffice Version: 7.6.5.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: waypoint...@yahoo.com After updating to 7.6.5.2 embedded video only play in safe mode. This was a working slide show in Presenter and now only works in safe mode. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 103610] [META] Slide show (presentation mode) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103610 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||156830 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=156830 [Bug 156830] FILEOPEN PPTX: background image shifts down in presentation mode -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159622] PPTX file ends up with displaced background image when presenting
https://bugs.documentfoundation.org/show_bug.cgi?id=159622 Stéphane Guillou (stragu) changed: What|Removed |Added Summary|Powerpoint file ends up |PPTX file ends up with |with displaced background |displaced background image ||when presenting CC||stephane.guillou@libreoffic ||e.org Version|24.2.0.3 release|7.6.5.2 release Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #4 from Stéphane Guillou (stragu) --- This regression is reproduced in: Version: 7.6.5.2 (X86_64) / LibreOffice Community Build ID: 38d5f62f85355c192ef5f1dd47c5c0c0c6d6598b CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded and: Version: 24.2.0.3 (X86_64) / LibreOffice Community Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded But not anymore in: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: d2fa44db6f8a1badece63856ee0f12db4cba9b28 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Bibisected the fix to 84055d875ead6d7862cd8ddc5697a280240411fe, so marking as duplicate of bug 156830. The fix will be available in the soon to be released 24.1. Thank you! *** This bug has been marked as a duplicate of bug 156830 *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 37134] Tabbed UI: Document-per-tab (similar to Firefox, Opera, gedit) MDI
https://bugs.documentfoundation.org/show_bug.cgi?id=37134 --- Comment #99 from Roland Hughes --- (In reply to Sahil Gautam from comment #98) > I would like to work on this. I am working on other patches, so may take a > month or so to make some time. But yes I have it in my hit-list. > > How I imagine solving it: > > Suppose that the UI side is taken care of, then isn't opening a document in > a new tab same as clicking on some document from the startcenter (or opening > a new document), and just showing a box(tab) with it's name type and maybe > save state. And Closing a tab would be same as clicking on the cross button > on the top right corner. > > And talking about the UI, Notebookbar's "tags" like file, home etc,is the > closest analog to tabs I see in LIbreoffice's UI, and studying and modifying > that so as to dynamically create those "tags", but for files, with a cross > button on the right side, shouldn't be that complicated (maybe). "Would be > just the perfect bug for me to work on, incremental and challenging" :). Wl Before you dive into coding, you need to look at the comments someone hid claiming they have no value when they have near limitless value to one who is going to look into this. First, you have to know what "this" is. StarOffice which was a predecessor of OpenOffice whose code became Libre Office had one tab per document way back with version 5.2. Lotus Symphony for 32-bit Ubuntu 8.x also had tab interface and the Navigator. That code was returned by IBM to OpenOffice and by extension Libre Office. The Navigator made it into LO, the tabbed interface did not. 32-bit Symphony can be found here: https://www.logikalsolutions.com/wordpress/sdm_downloads/lotus-symphony-32-bit-for-ubuntu-8-04/ You can see how to set up Ubuntu 8 32-bit and get the download link for Symphony here: https://www.logikalsolutions.com/wordpress/information-technology/lotus-symphony/ That will give you a good idea how the one-tab-per-document functionality previously worked with a codebase ancestor. If you want to try to identify where/when the code was checked into Apache OpenOffice from IBM you can dig through this message thread. This might have been lost as part of the Java purge though. There is another bug which gets mentioned much but I don't know the number. That is the one that Tom, I, and many others wish existed. That "this" is Lotus WordPro with tabbed sections and divisions ___within___ a document and a multi-tabbed document interface. Very difficult to describe to one who hasn't used it. Kind of like trying to describe what salt tastes like to someone that has never had any. You can read about it and see screen shots here: https://www.logikalsolutions.com/wordpress/information-technology/thank-you-for-your-future-abandonware/ Do a Web search for "Lotus SmartSuite." There are "used software" places selling it. eBay, Amazon, even Offer-Up. https://offerup.com/item/detail/ee98975a-b2c4-3f55-8b5c-83c94c909e8a I see that one "reduced" it to $10 from $20. You really need to use the software for a bit to understand __how__ it functioned. Under the hood is different from the UI. It's the UI and single file capability everyone is talking about. After you've researched both of those you can decide which "this" you wish to work on. You will at least have a much better idea about how to implement without blocking any future enhancement. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 151643] Text animation loses the Delay value after saving the document
https://bugs.documentfoundation.org/show_bug.cgi?id=151643 Kevin Suo changed: What|Removed |Added CC||suokunl...@126.com --- Comment #5 from Kevin Suo --- I can still reproduce this on Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 907c5d684daeb055183abb9175405c6d68fb1f49 CPU threads: 4; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: zh-CN (zh_CN.UTF-8); UI: zh-CN Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159918] A11Y sidebar: Tabs used in TOC create warning
https://bugs.documentfoundation.org/show_bug.cgi?id=159918 --- Comment #1 from Gabor Kelemen (allotropia) --- Created attachment 192811 --> https://bugs.documentfoundation.org/attachment.cgi?id=192811=edit How the tab is used in the TOC, with the sidebar warning -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159918] New: A11Y sidebar: Tabs used in TOC create warning
https://bugs.documentfoundation.org/show_bug.cgi?id=159918 Bug ID: 159918 Summary: A11Y sidebar: Tabs used in TOC create warning Product: LibreOffice Version: 7.5.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kelem...@ubuntu.com Blocks: 154929 Created attachment 192810 --> https://bugs.documentfoundation.org/attachment.cgi?id=192810=edit Example file from Writer with tabs in TOC In the TOC it is possible to add Tab characters as separators between the parts of the TOC entries. The Accessibility sidebar gives a warning about these, as if they were in the text - but it is not needed. 1. Open attached document 2. Open the Accessibility sidebar ->Warning about tabs, which were added to the TOC Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 74185b8edf7f046a3372319da86a1d8ca0024c87 CPU threads: 15; OS: Windows 10.0 Build 19045; UI render: default; VCL: win Locale: hu-HU (hu_HU); UI: en-US Calc: default Seems to have started in 7.5, with the initial addition of the test for tabs: https://git.libreoffice.org/core/+/3c0be5564afe1b9cc843a49aba88b72af74c43ab author Paris Oplopoios Mon Oct 24 14:12:44 2022 +0300 committer Tomaž VajngerlWed Nov 09 23:54:58 2022 +0100 a11y: Add check for tabs used for formatting Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=154929 [Bug 154929] [META] Accessibility Check sidebar deck, Automatic Accessibility Checking -- You are receiving this mail because: You are the assignee for the bug.
[Bug 154929] [META] Accessibility Check sidebar deck, Automatic Accessibility Checking
https://bugs.documentfoundation.org/show_bug.cgi?id=154929 Gabor Kelemen (allotropia) changed: What|Removed |Added Depends on||159918 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=159918 [Bug 159918] A11Y sidebar: Tabs used in TOC create warning -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159621] Highlighting Positve Numbers Libre Office Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=159621 --- Comment #4 from Stéphane Guillou (stragu) --- (In reply to Heiko Tietze from comment #3) > Missing your use > case that requires numbers in red for positive value Just noting that OP was asking for positive numbers in green. But I also think that workarounds available are sufficient. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159621] Highlighting Positve Numbers Libre Office Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=159621 --- Comment #4 from Stéphane Guillou (stragu) --- (In reply to Heiko Tietze from comment #3) > Missing your use > case that requires numbers in red for positive value Just noting that OP was asking for positive numbers in green. But I also think that workarounds available are sufficient. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 159917] New: crash when copying text box from one graph to other
https://bugs.documentfoundation.org/show_bug.cgi?id=159917 Bug ID: 159917 Summary: crash when copying text box from one graph to other Product: LibreOffice Version: 7.5.6.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: hhol...@posteo.de Description: I did a stacked column graph and entered a text box as an explainer of something. I did another stacked column graph and wanted to copy/paste the text box from the first graph to this second (I can't seem to find the place to change default font/size for these boxes and I'm too lazy to format them each and every time). Upon pasting the box in the second graph, LO crashed. Crash report is here: https://crashreport.libreoffice.org/stats/crash_details/4654f08d-4fec-4cd0-a669-770d7ae44801; I tried to reproduce it but it didn't happen right away. Then, later, when still working with textboxes inside another graph, I simply double clicked on one to change the text inside it and LO crashed again. I suppose both are related. The second crash report is here: https://crashreport.libreoffice.org/stats/crash_details/a0727a3a-6d88-4800-9921-9d5bce241bbf Steps to Reproduce: 1. Create a simple graph in Calc. Add a text box inside the graph, e.g. to add the source of the data. 2. After re-entering the graph, try editing this text box or alternatively copy/paste it in another graph. 3. Actual Results: Libreoffice crashed without any further ado. Expected Results: I expected to be able to edit the text box or paste it inside the graph. Reproducible: Sometimes User Profile Reset: No Additional Info: Version: 7.5.6.2 (X86_64) / LibreOffice Community Build ID: f654817fb68d6d4600d7d2f6b647e47729f55f15 CPU threads: 6; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: de-DE (de_DE.UTF-8); UI: de-DE Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159909] FILESAVE DOCX PAC tool complains about too small contrast of paragraph with background color
https://bugs.documentfoundation.org/show_bug.cgi?id=159909 Gabor Kelemen (allotropia) changed: What|Removed |Added CC||vmik...@collabora.com Keywords||bibisected, bisected, ||regression Version|7.1.0.3 release |7.4.0.3 release --- Comment #3 from Gabor Kelemen (allotropia) --- Seems to have started in 7.4 with: https://git.libreoffice.org/core/+/30585873ca8c861aa2d13f85797930f62195ee55%5E%21/#F0 author Miklos Vajna Mon Feb 07 13:28:06 2022 +0100 committer Miklos Vajna Mon Feb 07 18:44:37 2022 +0100 PDF export: increase default precision of doubles Adding CC to: Miklos Vajna -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159839] Impossible to delete an empty line preceeding a list item without breaking the list
https://bugs.documentfoundation.org/show_bug.cgi?id=159839 Stéphane Guillou (stragu) changed: What|Removed |Added Priority|medium |low Severity|normal |minor --- Comment #4 from Stéphane Guillou (stragu) --- Fairly low priority, the workaround is to activate list again on that paragraph. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159839] Impossible to delete an empty line preceeding a list item without breaking the list
https://bugs.documentfoundation.org/show_bug.cgi?id=159839 Stéphane Guillou (stragu) changed: What|Removed |Added Version|7.6.4.1 release |Inherited From OOo --- Comment #3 from Stéphane Guillou (stragu) --- Same in OOo 3.3. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159515] Custom shape with bitmap fill with image with transparent parts is wrongly rendered in extrusion mode
https://bugs.documentfoundation.org/show_bug.cgi?id=159515 --- Comment #13 from Patrick Luby --- OK. The stack traces to my debug patch are nearly identical except that the cat photo in attachment #192332 goes through the GroupPrimitive2D class. That seems reasonable so maybe the inverted alpha channel happens at document load or change. Not sure where to look for that: frame #20: 0x000111a99a34 libdrawinglayerlo.dylib`drawinglayer::primitive2d::GroupPrimitive2D::getChildren(this=0x657af480, rVisitor=0x65f90f50) const at groupprimitive2d.hxx:76:90 frame #21: 0x000111ad5e60 libdrawinglayerlo.dylib`drawinglayer::primitive2d::GroupPrimitive2D::get2DDecomposition(this=0x657af480, rVisitor=0x65f90f50, (null)=0x65f90f58) const at groupprimitive2d.cxx:53:13 frame #22: 0x000111b576c4 libdrawinglayerlo.dylib`drawinglayer::processor2d::BaseProcessor2D::process(this=0x65f90f50, rCandidate=0x657af480) at baseprocessor2d.cxx:46:24 -- You are receiving this mail because: You are the assignee for the bug.
core.git: svx/source
svx/source/dialog/langbox.cxx | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) New commits: commit a1a1d8edb9d4a62b747aa7069b3026e2ba75704d Author: Mike Kaganski AuthorDate: Tue Feb 27 01:13:32 2024 +0600 Commit: Mike Kaganski CommitDate: Tue Feb 27 01:57:35 2024 +0100 Another attempt to ensure strict weak ordering when sorting The failure that Stephan noticed turns out to show a problem in the data - the use of the special LANGUAGE_USER_SYSTEM_CONFIG language type value. It should not appear in the sorted part of the list; if needed, it should be added explicitly, like the "default" entry is handled in SvxLanguageBox::SetLanguageList. So simplify the shortcut in GenericFirst::operator() again, and drop the special entries before sorting. Change-Id: If08e0ddbc5b597795e129fa4a2315c54205dab90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163964 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/svx/source/dialog/langbox.cxx b/svx/source/dialog/langbox.cxx index e8b82e3ac63c..8699a6798d59 100644 --- a/svx/source/dialog/langbox.cxx +++ b/svx/source/dialog/langbox.cxx @@ -219,8 +219,8 @@ static void SortLanguages(std::vector& rEntries) bool operator()(const EntryData& e1, const EntryData& e2) const { assert(e1.tag.getLanguage() == e2.tag.getLanguage()); -if (e1.entry.sId == e2.entry.sId || e1.tag.equals(e2.tag)) -return false; // shortcut; make sure to also compare tags, to resolve system locale +if (e1.entry.sId == e2.entry.sId) +return false; // shortcut // Make sure that e.g. generic 'Spanish {es}' goes before 'Spanish (Argentina)'. // We can't depend on MsLangId::getPrimaryLanguage/getSubLanguage, because e.g. @@ -267,7 +267,11 @@ static void SortLanguages(std::vector& rEntries) for (const auto& entry : rEntries) { -LanguageTag tag(LanguageType(entry.sId.toInt32())); +LanguageType languageType(entry.sId.toInt32()); +// Remove LANGUAGE_USER_SYSTEM_CONFIG special entry and friends from the list +if (languageType >= LanguageType(0xFFE0)) +continue; +LanguageTag tag(languageType); langToEntriesMap[tag.getLanguage()].insert({ tag, entry }); // also makes unique }
[Bug 159912] FILEOPEN: wrong rotation of 3D object
https://bugs.documentfoundation.org/show_bug.cgi?id=159912 --- Comment #2 from Regina Henschel --- Before the patch the image was imported without the 3D-properties. So it is more an implementation error than a regression. I'm unsure how to fix it. I could fix the import for the 3D-properties, but than it renders transparency wrongly (bug 159515). Or I could exclude images from 3D. Suggestion? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159897] FILEOPEN DOCX Hyperlink with ScreenTip is imported broken
https://bugs.documentfoundation.org/show_bug.cgi?id=159897 --- Comment #3 from Gabor Kelemen (allotropia) --- This changed to the current state in: https://git.libreoffice.org/core/+/4c30848c852c44cbad8509c770feed5244f1940f author Tünde Tóth Thu Jul 18 15:10:26 2019 +0200 committer László NémethThu Jul 25 09:31:34 2019 +0200 tdf#123627 DOCX import: fix relative hyperlinks to documents -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159515] Custom shape with bitmap fill with image with transparent parts is wrongly rendered in extrusion mode
https://bugs.documentfoundation.org/show_bug.cgi?id=159515 --- Comment #12 from Patrick Luby --- (In reply to Patrick Luby from comment #11) > Created attachment 192809 [details] > Stack trace where extruded shapes alpha mask is created I have done some debugging and I narrowed down where in the code the bug is occurring. Using the following debug patch, the roses in the two attached sample documents render correctly, but the debug patch makes the cat photo in attachment #192332 completely transparent. So, I am guessing that the alpha channel needs to be inverted higher up the stack in attachment #192809: diff --git a/drawinglayer/source/processor3d/zbufferprocessor3d.cxx b/drawinglayer/source/processor3d/zbufferprocessor3d.cxx index b9cb8ffb7a1d..2f24b916e587 100644 --- a/drawinglayer/source/processor3d/zbufferprocessor3d.cxx +++ b/drawinglayer/source/processor3d/zbufferprocessor3d.cxx @@ -302,7 +302,8 @@ void ZBufferRasterConverter3D::processLineSpan(const basegfx::RasterConversionLi if(nNewZ > rOldZ) { // detect color and opacity for this pixel -const sal_uInt16 nOpacity(std::max(sal_Int16(0), static_cast< sal_Int16 >(decideColorAndOpacity(aNewColor) * 255.0))); +// try inverting the opacity value +const sal_uInt16 nOpacity(255 - std::max(sal_Int16(0), static_cast< sal_Int16 >(decideColorAndOpacity(aNewColor) * 255.0))); if(nOpacity > 0) { -- You are receiving this mail because: You are the assignee for the bug.
[Bug 124498] Can't scale rotated images if that would make them larger than page in original orientation
https://bugs.documentfoundation.org/show_bug.cgi?id=124498 Regina Henschel changed: What|Removed |Added CC||o...@prosa.dk --- Comment #6 from Regina Henschel --- *** Bug 159913 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159913] Formatting: A rotated image cannot be resized bigger than the width of the page
https://bugs.documentfoundation.org/show_bug.cgi?id=159913 Regina Henschel changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE CC||rb.hensc...@t-online.de --- Comment #2 from Regina Henschel --- That is indeed an unsolved problem, see bug 124498. To workaround the problem, first insert the image in Draw. Then copy it from Draw. That way you get a "Draw"-image, which has no problems with rotation. The downside is, that "Draw"-images do not have the features "Image Map" and "Contour Polygon". But likely you will not need them. *** This bug has been marked as a duplicate of bug 124498 *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159515] Custom shape with bitmap fill with image with transparent parts is wrongly rendered in extrusion mode
https://bugs.documentfoundation.org/show_bug.cgi?id=159515 --- Comment #11 from Patrick Luby --- Created attachment 192809 --> https://bugs.documentfoundation.org/attachment.cgi?id=192809=edit Stack trace where extruded shapes alpha mask is created -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159885] the latest text editing version hangs unexpectedly in the middle of writing
https://bugs.documentfoundation.org/show_bug.cgi?id=159885 --- Comment #3 from m_a_riosv --- It is not a matter of necessary. If it is working in safe mode, something on the profile is broken. When restarting in safe mode, there are options to clean the profile, total or partially. See in the Reset to factory options. -- You are receiving this mail because: You are the assignee for the bug.