core.git: 3 commits - sc/inc sc/source

[Mike Kaganski (via logerrit)]

 sc/inc/drwlayer.hxx  |3 
 sc/source/core/data/drwlayer.cxx |  119 +++
 2 files changed, 61 insertions(+), 61 deletions(-)

New commits:
commit 68c6b970e45ac1971dd95c28a07063f38dc152e0
Author: Mike Kaganski 
AuthorDate: Sat Mar 2 06:57:53 2024 +0100
Commit: Mike Kaganski 
CommitDate: Sat Mar 2 08:45:03 2024 +0100

Simplify a bit

Change-Id: I5022d82e556f7cfb09f0dee397d93dd7514a22e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164202
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sc/inc/drwlayer.hxx b/sc/inc/drwlayer.hxx
index 6f1322b4b9d6..6bad650fd445 100644
--- a/sc/inc/drwlayer.hxx
+++ b/sc/inc/drwlayer.hxx
@@ -215,7 +215,8 @@ public:
 static ScDrawObjData* GetObjDataTab( SdrObject* pObj, SCTAB nTab );
 
 /** Returns true, if the passed object is the caption of a cell note. */
-static bool IsNoteCaption( SdrObject* pObj );
+static bool IsNoteCaption(const ScDrawObjData* pData);
+static bool IsNoteCaption(SdrObject* pObj) { return 
IsNoteCaption(GetObjData(pObj)); }
 
 /** Returns the object data, if the passed object is a cell note caption. 
*/
 static ScDrawObjData* GetNoteCaptionData( SdrObject* pObj, SCTAB nTab );
diff --git a/sc/source/core/data/drwlayer.cxx b/sc/source/core/data/drwlayer.cxx
index 480b779918d5..72273c2ed4d5 100644
--- a/sc/source/core/data/drwlayer.cxx
+++ b/sc/source/core/data/drwlayer.cxx
@@ -1786,70 +1786,73 @@ void ScDrawLayer::CopyToClip( ScDocument* pClipDoc, 
SCTAB nTab, const tools::Rec
 SdrObjListIter aIter( pSrcPage, SdrIterMode::Flat );
 while (SdrObject* pOldObject = aIter.Next())
 {
+// do not copy internal objects (detective) and note captions
+if (pOldObject->GetLayer() == SC_LAYER_INTERN)
+continue;
+
+const ScDrawObjData* pObjData = ScDrawLayer::GetObjData(pOldObject);
+if (IsNoteCaption(pObjData))
+continue;
+
 // Catch objects where the object itself is inside the rectangle to be 
copied.
 bool bObjectInArea = 
rRange.Contains(pOldObject->GetCurrentBoundRect());
 // Catch objects whose anchor is inside the rectangle to be copied.
-const ScDrawObjData* pObjData = ScDrawLayer::GetObjData(pOldObject);
-if (pObjData)
-bObjectInArea = bObjectInArea || 
aClipRange.Contains(pObjData->maStart);
-
-// do not copy internal objects (detective) and note captions
-if (bObjectInArea && pOldObject->GetLayer() != SC_LAYER_INTERN
-&& !IsNoteCaption(pOldObject))
+if (!bObjectInArea && pObjData)
+bObjectInArea = aClipRange.Contains(pObjData->maStart);
+if (!bObjectInArea)
+continue;
+
+if (!pDestModel)
 {
-if ( !pDestModel )
+pDestModel = pClipDoc->GetDrawLayer();  // does the document 
already have a drawing layer?
+if (!pDestModel)
 {
-pDestModel = pClipDoc->GetDrawLayer();  // does the 
document already have a drawing layer?
-if ( !pDestModel )
-{
-//  allocate drawing layer in clipboard document only if 
there are objects to copy
+//  allocate drawing layer in clipboard document only if there 
are objects to copy
 
-pClipDoc->InitDrawLayer();  //TODO: create 
contiguous pages
-pDestModel = pClipDoc->GetDrawLayer();
-}
-if (pDestModel)
-pDestPage = pDestModel->GetPage( 
static_cast(nTab) );
+pClipDoc->InitDrawLayer(); //TODO: create contiguous pages
+pDestModel = pClipDoc->GetDrawLayer();
 }
+if (pDestModel)
+pDestPage = pDestModel->GetPage(static_cast(nTab));
+}
 
-OSL_ENSURE( pDestPage, "no page" );
-if (pDestPage)
+OSL_ENSURE(pDestPage, "no page");
+if (pDestPage)
+{
+// Clone to target SdrModel
+rtl::Reference 
pNewObject(pOldObject->CloneSdrObject(*pDestModel));
+uno::Reference< chart2::XChartDocument > xOldChart( 
ScChartHelper::GetChartFromSdrObject( pOldObject ) );
+if(!xOldChart.is())//#i110034# do not move charts as they lose all 
their data references otherwise
 {
-// Clone to target SdrModel
-rtl::Reference 
pNewObject(pOldObject->CloneSdrObject(*pDestModel));
-uno::Reference< chart2::XChartDocument > xOldChart( 
ScChartHelper::GetChartFromSdrObject( pOldObject ) );
-if(!xOldChart.is())//#i110034# do not move charts as they lose 
all their data references otherwise
+if (pObjData)
 {
-if (pObjData)
-{
-// The object is anchored to cell. 

[Bug 135875] UI: Order of paragraph style tabs. Font effect should be followed by highlighting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=135875

--- Comment #10 from AmeerAlam  ---
A new major release of LibreOffice is available since this bug was reported.
Could you please try to reproduce it with the latest version of LibreOffice
from https://toprankingdirectory.com/   ?
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the bug is still present in the latest version.
[tag] [reply] [−]Co

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 157588] Misleading dialog label in Macro Security

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157588

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=98
   ||051

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 98051] Improve Macro Security warning

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98051

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||7588
 CC||kelem...@ubuntu.com,
   ||stephane.guillou@libreoffic
   ||e.org

--- Comment #11 from Stéphane Guillou (stragu) 
 ---
There's some improvement in wording since 24.2 with the fix for bug 157588.
Gabor and Andreas, what should we do with this report?

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: config_host.mk.in configure.ac ridljar/Jar_libreoffice.mk ridljar/Jar_unoloader.mk solenv/gbuild

[Fridrich Štrba (via logerrit)]

 config_host.mk.in |1 +
 configure.ac  |   20 +++-
 ridljar/Jar_libreoffice.mk|6 +++---
 ridljar/Jar_unoloader.mk  |8 
 solenv/gbuild/JavaClassSet.mk |6 +++---
 5 files changed, 26 insertions(+), 15 deletions(-)

New commits:
commit 4267c7124876b9213b3169a55731d260c8c63f7c
Author: Fridrich Štrba 
AuthorDate: Fri Mar 1 13:36:42 2024 +0100
Commit: Noel Grandin 
CommitDate: Sat Mar 2 06:29:50 2024 +0100

Allow building with Java 8

Change-Id: Ib1af1a98993aabb8a03f4ef19d8da4d9a71fdbc0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164226
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/config_host.mk.in b/config_host.mk.in
index 04745d508fc3..00dc7aa1f898 100644
--- a/config_host.mk.in
+++ b/config_host.mk.in
@@ -483,6 +483,7 @@ export MERGELIBS_MORE=@MERGELIBS_MORE@
 export ML_EXE=@ML_EXE@
 export MOC5=@MOC5@
 export MOC6=@MOC6@
+MODULAR_JAVA=@MODULAR_JAVA@
 export MPL_SUBSET=@MPL_SUBSET@
 export MSGFMT=@MSGFMT@
 export MSGUNIQ=@MSGUNIQ@
diff --git a/configure.ac b/configure.ac
index dd4ed7107aa8..b218120773d1 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2570,7 +2570,7 @@ AC_ARG_WITH(linker-hash-style,
 
 AC_ARG_WITH(jdk-home,
 AS_HELP_STRING([--with-jdk-home=],
-[If you have installed JDK 17 or later on your system please supply the
+[If you have installed JDK 8 or later on your system please supply the
  path here. Note that this is not the location of the java command but 
the
  location of the entire distribution. In case of cross-compiling, this
  is the JDK of the host os. Use --with-build-platform-configure-options
@@ -8647,7 +8647,7 @@ if test "$ENABLE_JAVA" != ""; then
 fi
 
 if ! test -f "$with_jdk_home/lib/jvm.lib" -a -f 
"$with_jdk_home/bin/java.exe"; then
-AC_MSG_ERROR([No JDK found, pass the --with-jdk-home option (or 
fix the path) pointing to a $WIN_HOST_BITS-bit JDK >= 17])
+AC_MSG_ERROR([No JDK found, pass the --with-jdk-home option (or 
fix the path) pointing to a $WIN_HOST_BITS-bit JDK >= 8])
 fi
 fi
 
@@ -8712,6 +8712,7 @@ dnl 
===
 # Whether all the complexity here actually is needed any more or not, no idea.
 
 JDK_SECURITYMANAGER_DISALLOWED=
+MODULAR_JAVA=
 if test "$ENABLE_JAVA" != "" -a "$cross_compiling" != "yes"; then
 _gij_longver=0
 AC_MSG_CHECKING([the installed JDK])
@@ -8732,8 +8733,8 @@ if test "$ENABLE_JAVA" != "" -a "$cross_compiling" != 
"yes"; then
 _jdk=`$JAVAINTERPRETER -version 2>&1 | $AWK -F'"' '{ print \$2 }' 
| $SED '/^$/d' | $SED s/[[-A-Za-z]]*//`
 _jdk_ver=`echo "$_jdk" | $AWK -F. '{ print (($1 * 100) + $2) * 100 
+ $3;}'`
 
-if test "$_jdk_ver" -lt 17; then
-AC_MSG_ERROR([JDK is too old, you need at least 17 ($_jdk_ver 
< 17)])
+if test "$_jdk_ver" -lt 10800; then
+AC_MSG_ERROR([JDK is too old, you need at least 8 ($_jdk_ver < 
10800)])
 fi
 dnl TODO: Presumably, the Security Manager will not merely be 
disallowed, but be
 dnl completely removed in some Java version > 18 (see
@@ -8748,13 +8749,21 @@ if test "$ENABLE_JAVA" != "" -a "$cross_compiling" != 
"yes"; then
 fi
 AC_MSG_RESULT([found $JAVA_HOME (JDK $_jdk)])
 
+dnl Check whether the build Java supports modules
+if test "$_jdk_ver" -ge 9; then
+MODULAR_JAVA=TRUE
+else
+AC_MSG_WARN([Modular jars will not be built. They need at 
least Java 9 ($_jdk_ver < 9)])
+add_warning "Modular jars will not be built. They need at 
least Java 9 ($_jdk_ver < 9)"
+fi
+
 # set to limit VM usage for JunitTests
 JAVAIFLAGS=-Xmx64M
 # set to limit VM usage for javac
 JAVACFLAGS=-J-Xmx128M
 fi
 else
-AC_MSG_ERROR([Java not found. You need at least JDK 17])
+AC_MSG_ERROR([Java not found. You need at least JDK 8])
 fi
 else
 if test -z "$ENABLE_JAVA"; then
@@ -9058,6 +9067,7 @@ AC_SUBST(JDK_FOR_BUILD)
 AC_SUBST(JDK_SECURITYMANAGER_DISALLOWED_FOR_BUILD)
 AC_SUBST(JAVA_SOURCE_VER)
 AC_SUBST(JAVA_TARGET_VER)
+AC_SUBST(MODULAR_JAVA)
 
 
 dnl ===
diff --git a/ridljar/Jar_libreoffice.mk b/ridljar/Jar_libreoffice.mk
index 76a56eedc078..77397bc246ee 100644
--- a/ridljar/Jar_libreoffice.mk
+++ b/ridljar/Jar_libreoffice.mk
@@ -36,12 +36,12 @@ $(eval $(call gb_Jar_add_manifest_classpath,libreoffice, \
 $(eval $(call gb_Jar_add_packagedirs,libreoffice,\
 $(call gb_CustomTarget_get_workdir,ridljar/javamaker)/com \
 $(call gb_CustomTarget_get_workdir,unoil/javamaker)/com \
-   $(call gb_JavaClassSet_get_classdir,$(call 

core.git: solenv/gbuild

[Noel Grandin (via logerrit)]

 solenv/gbuild/extensions/pre_MergedLibsList.mk |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 1cd0d13e9bb0c30d0a472acd95da727c571d843b
Author: Noel Grandin 
AuthorDate: Fri Mar 1 13:14:11 2024 +0200
Commit: Noel Grandin 
CommitDate: Sat Mar 2 06:28:28 2024 +0100

add wpft* to --enable-mergedlibs=more

Change-Id: I1168eb43638c3b18e3b9de96d89646420f80b52e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164218
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/solenv/gbuild/extensions/pre_MergedLibsList.mk 
b/solenv/gbuild/extensions/pre_MergedLibsList.mk
index 31182d006db3..2d1a397c757a 100644
--- a/solenv/gbuild/extensions/pre_MergedLibsList.mk
+++ b/solenv/gbuild/extensions/pre_MergedLibsList.mk
@@ -182,6 +182,9 @@ gb_MERGE_LIBRARY_LIST += \
$(if $(ENABLE_LIBCMIS),ucpcmis1) \
$(if $(WITH_WEBDAV),ucpdav1) \
ucppkg1 \
+   wpftdraw \
+   wpftimpress \
+   wpftwriter \
$(if $(filter WNT,$(OS)), \
wininetbe1 \
) \

core.git: solenv/gbuild

[Noel Grandin (via logerrit)]

 solenv/gbuild/extensions/pre_MergedLibsList.mk |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 065b1d030ea5e21dc91699cdaf8bcd03ed2ec807
Author: Noel Grandin 
AuthorDate: Fri Mar 1 12:28:01 2024 +0200
Commit: Noel Grandin 
CommitDate: Sat Mar 2 06:27:53 2024 +0100

add OGLTrans to --enable-mergedlibs=more

Change-Id: I6df8cd8a11681cac971d53ec52b6dd97c18fd459
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164217
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/solenv/gbuild/extensions/pre_MergedLibsList.mk 
b/solenv/gbuild/extensions/pre_MergedLibsList.mk
index 77a6bc99ba65..31182d006db3 100644
--- a/solenv/gbuild/extensions/pre_MergedLibsList.mk
+++ b/solenv/gbuild/extensions/pre_MergedLibsList.mk
@@ -159,6 +159,7 @@ gb_MERGE_LIBRARY_LIST += \
msforms \
$(call gb_Helper_optional,DBCONNECTIVITY,mysql_jdbc) \
$(call gb_Helper_optional,MARIADBC,$(call 
gb_Helper_optional,DBCONNECTIVITY,mysqlc)) \
+   OGLTrans \
odbc \
pdffilter \
$(if $(BUILD_POSTGRESQL_SDBC), \

core.git: solenv/gbuild

[Noel Grandin (via logerrit)]

 solenv/gbuild/extensions/pre_MergedLibsList.mk |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 19b7f833dd7aa4cb7eddb4ee9ccda202c8133bb8
Author: Noel Grandin 
AuthorDate: Fri Mar 1 12:16:09 2024 +0200
Commit: Noel Grandin 
CommitDate: Sat Mar 2 06:26:36 2024 +0100

add solver to --enable-mergedlibs=more

Change-Id: Ib3de04a85332430895bb6096a2cfaf1463f33b79
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164216
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/solenv/gbuild/extensions/pre_MergedLibsList.mk 
b/solenv/gbuild/extensions/pre_MergedLibsList.mk
index cad91095a4cc..77a6bc99ba65 100644
--- a/solenv/gbuild/extensions/pre_MergedLibsList.mk
+++ b/solenv/gbuild/extensions/pre_MergedLibsList.mk
@@ -172,6 +172,7 @@ gb_MERGE_LIBRARY_LIST += \
$(if $(filter WNT,$(OS)), \
smplmail \
) \
+   solver \
storagefd \
svgfilter \
t602filter \

core.git: solenv/gbuild

[Noel Grandin (via logerrit)]

 solenv/gbuild/extensions/pre_MergedLibsList.mk |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 2083679b61623cfe1dbd71f486ff4f63f837db2d
Author: Noel Grandin 
AuthorDate: Fri Mar 1 11:24:49 2024 +0200
Commit: Noel Grandin 
CommitDate: Sat Mar 2 06:25:52 2024 +0100

add ado to --enable-mergedlibs=more

Change-Id: I0d04eb2ab9b6384576194dc2c6421310da227b8c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164215
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/solenv/gbuild/extensions/pre_MergedLibsList.mk 
b/solenv/gbuild/extensions/pre_MergedLibsList.mk
index 91e40b381181..cad91095a4cc 100644
--- a/solenv/gbuild/extensions/pre_MergedLibsList.mk
+++ b/solenv/gbuild/extensions/pre_MergedLibsList.mk
@@ -119,6 +119,9 @@ ifneq ($(MERGELIBS_MORE),)
 
 gb_MERGE_LIBRARY_LIST += \
acc \
+   $(if $(filter $(OS),WNT), \
+   ado \
+   ) \
analysis \
animcore \
$(call gb_Helper_optional,AVMEDIA, \

core.git: vcl/source

[Mike Kaganski (via logerrit)]

 vcl/source/text/mnemonic.cxx |   23 ++-
 1 file changed, 6 insertions(+), 17 deletions(-)

New commits:
commit cde2bf606960b7bf0945b394a70e0e5c1a947ec0
Author: Mike Kaganski 
AuthorDate: Fri Mar 1 14:46:21 2024 +0600
Commit: Mike Kaganski 
CommitDate: Sat Mar 2 04:39:06 2024 +0100

Simplify removeMnemonicFromString

Change-Id: I38ed29cb9c6296c364330c667fccf573d3d5cd5f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164181
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/vcl/source/text/mnemonic.cxx b/vcl/source/text/mnemonic.cxx
index 7336032b8d12..9a63c2e7d785 100644
--- a/vcl/source/text/mnemonic.cxx
+++ b/vcl/source/text/mnemonic.cxx
@@ -18,33 +18,22 @@ OUString removeMnemonicFromString(OUString const& rStr)
 OUString removeMnemonicFromString(OUString const& rStr, sal_Int32& 
rMnemonicPos)
 {
 OUString aStr = rStr;
-sal_Int32 nLen = aStr.getLength();
-sal_Int32 i = 0;
+sal_Int32 nLen = aStr.getLength() - 1; // Don't remove trailing ~
 
 rMnemonicPos = -1;
-while (i < nLen)
+for (sal_Int32 i = 0; i < nLen; ++i)
 {
 if (aStr[i] == '~')
 {
-if (nLen <= i + 1)
-break;
-
-if (aStr[i + 1] != '~')
+aStr = aStr.replaceAt(i, 1, u"");
+nLen--;
+if (aStr[i] != '~')
 {
 if (rMnemonicPos == -1)
 rMnemonicPos = i;
-aStr = aStr.replaceAt(i, 1, u"");
-nLen--;
-}
-else
-{
-aStr = aStr.replaceAt(i, 1, u"");
-nLen--;
-i++;
 }
+// else skip the escaped second ~
 }
-else
-i++;
 }
 
 return aStr;

core.git: vcl/source

[Mike Kaganski (via logerrit)]

 vcl/source/gdi/pdfwriter_impl.cxx |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit f85d6a0edd509100af0c5f6b9249bcd0507be301
Author: Mike Kaganski 
AuthorDate: Fri Mar 1 10:36:38 2024 +0100
Commit: Mike Kaganski 
CommitDate: Sat Mar 2 04:38:43 2024 +0100

Drop unused variable

Change-Id: I913c25e0ab4fb593e6d85805ed677dbe4db94c35
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164127
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/vcl/source/gdi/pdfwriter_impl.cxx 
b/vcl/source/gdi/pdfwriter_impl.cxx
index 321f628cbf7a..123a5fcbfcd2 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -7247,11 +7247,10 @@ void PDFWriterImpl::drawText( const tools::Rectangle& 
rRect, const OUString& rOr
 Point   aPos= rRect.TopLeft();
 
 tools::LongnTextHeight = GetTextHeight();
-sal_Int32   nMnemonicPos= -1;
 
 OUString aStr = rOrigStr;
 if ( nStyle & DrawTextFlags::Mnemonic )
-aStr = removeMnemonicFromString( aStr, nMnemonicPos );
+aStr = removeMnemonicFromString(aStr);
 
 // multiline text
 if ( nStyle & DrawTextFlags::MultiLine )

[Bug 158353] FILEOPEN XLSX Wrong round

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158353

--- Comment #10 from Mike Kaganski  ---
(In reply to Thorsten Behrens (allotropia) from comment #9)

:-) It may be true, but completely orthogonal to the clarification requested in
my question? ;-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159951] Crashes immediately at startup of every component on a brand new Win11 notebook

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159951

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159965] FORMCONTROLS: Check box, Radio Button and Combo box won't be printed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159965

QA Administrators  changed:

   What|Removed |Added

   Keywords||bibisectRequest

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159951] Crashes immediately at startup of every component on a brand new Win11 notebook

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159951

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 156347] When using --show argument LibreOffice starts but presentation not visible

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=156347

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 156313] 'General error.General input/output error.'was reported when loading a .pdf file.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=156313

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 156347] When using --show argument LibreOffice starts but presentation not visible

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=156347

--- Comment #7 from QA Administrators  ---
Dear FingerlessGloves,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 157013] Clumsy navigation in document with tracked changes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157013

--- Comment #6 from QA Administrators  ---
Dear Nadie Nada Nunca,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 64914] FILEOPEN: Libreoffice freezes importing a file containing a chart with large data source

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=64914

--- Comment #18 from QA Administrators  ---
Dear Xisco Faulí,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 156313] 'General error.General input/output error.'was reported when loading a .pdf file.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=156313

--- Comment #7 from QA Administrators  ---
Dear 2318494274,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 156726] Crashes after some time passes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=156726

--- Comment #13 from QA Administrators  ---
Dear ca.wright626,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 99877] [CHART] XLTX wrongly imported chart

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99877

--- Comment #13 from QA Administrators  ---
Dear Dennis Roczek,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 135165] FILEOPEN DOCX: A frame of the hidden change appears on DOCX save, until resaved again

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=135165

--- Comment #10 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 131189] Cannot Format Data Label from PPTX chart

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131189

--- Comment #9 from QA Administrators  ---
Dear Timur,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158353] FILEOPEN XLSX Wrong round

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158353

Thorsten Behrens (allotropia)  changed:

   What|Removed |Added

 CC||er...@redhat.com,
   ||t...@libreoffice.org

--- Comment #9 from Thorsten Behrens (allotropia)  ---
(In reply to Mike Kaganski from comment #6)
> (In reply to Gabor Kelemen (allotropia) from comment #5)
> > Seems to have started with:
> 
> Started specifically what? The more numerically correct display, or the
> wrong save?

I guess for an XLSX file, the only correct way is to load & display it as Excel
does?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159992] New: file save dialog not allowing paste from clipboard

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159992

Bug ID: 159992
   Summary: file save dialog not allowing paste from clipboard
   Product: LibreOffice
   Version: 7.5.9.2 release
  Hardware: All
OS: macOS (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: josephderr...@gmail.com

Description:
cannot paste into the save file dialog on macOS

Steps to Reproduce:
1.try to save file
2.press cmd+v to no effect
3.

Actual Results:
nothing

Expected Results:
should paste from clipboard


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.5.9.2 (X86_64) / LibreOffice Community
Build ID: cdeefe45c17511d326101eed8008ac4092f278a9
CPU threads: 8; OS: Mac OS X 13.6.3; UI render: default; VCL: osx
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159652] Finding a way to join a suffix to the word immediately before it, using autocorrect function

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159652

--- Comment #6 from Mac  ---
Awesome! László's solution works for me like a charm. Thank you.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159652] Finding a way to join a suffix to the word immediately before it, using autocorrect function

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159652

--- Comment #6 from Mac  ---
Awesome! László's solution works for me like a charm. Thank you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 159984] FILESAVE PPTX asks to repair when opened with MSO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159984

--- Comment #2 from Regina Henschel  ---
The 0 in slideLayout0.xml comes in via 
PowerPointExport::GetLayoutFileId()
because mLayoutInfo[ nOffset ].mnFileIdArray.size() returns 0.

The call of GetLayoutFileId comes from
PowerPointExport::ImplWriteSlide() and therein from preparing the parameter
values for addRelation() in line#1380.

That is in file sd/source/filter/eppt/pptx-epptooxml.cxx.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 133092] [META] Crash bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=133092
Bug 133092 depends on bug 139004, which changed state.

Bug 139004 Summary: Crash with non-debug & assertion 
dynamic_cast(static_cast(pOldValue)->pChangedFormat)", file=ndtxt.cxx", line=5437
https://bugs.documentfoundation.org/show_bug.cgi?id=139004

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 102946] [META] Styles bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102946
Bug 102946 depends on bug 139004, which changed state.

Bug 139004 Summary: Crash with non-debug & assertion 
dynamic_cast(static_cast(pOldValue)->pChangedFormat)", file=ndtxt.cxx", line=5437
https://bugs.documentfoundation.org/show_bug.cgi?id=139004

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: sc/source

[Marco Cecchetti (via logerrit)]

 sc/source/ui/undo/undotab.cxx |   51 +++---
 1 file changed, 43 insertions(+), 8 deletions(-)

New commits:
commit fc9c15ec702d8a06e8747ee5b858751e5a90e30a
Author: Marco Cecchetti 
AuthorDate: Tue Feb 27 17:56:26 2024 +0100
Commit: Caolán McNamara 
CommitDate: Sat Mar 2 01:19:32 2024 +0100

lok: calc: sheet geometry not updated on undo a tab insert/delete/move

Change-Id: I1e12ca71771e746155afe48215ba2df4b35634d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164165
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Caolán McNamara 
(cherry picked from commit 86e6d67220d6d3d93c5decf04195b7f5025984ae)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164192
(cherry picked from commit fe0b935313b28003117a2d219fd2fe359947a11e)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164199
Tested-by: Jenkins

diff --git a/sc/source/ui/undo/undotab.cxx b/sc/source/ui/undo/undotab.cxx
index 670769e70ffc..8c3cdc1dfdf3 100644
--- a/sc/source/ui/undo/undotab.cxx
+++ b/sc/source/ui/undo/undotab.cxx
@@ -61,6 +61,24 @@ using namespace com::sun::star;
 using ::std::unique_ptr;
 using ::std::vector;
 
+namespace
+{
+void lcl_OnTabsChanged(const ScTabViewShell* pViewShell, const ScDocument& 
rDoc, SCTAB nTab, bool bInvalidateTiles = false)
+{
+for (SCTAB nTabIndex = nTab; nTabIndex < rDoc.GetTableCount(); ++nTabIndex)
+{
+if (!rDoc.IsVisible(nTabIndex))
+continue;
+if (bInvalidateTiles)
+pViewShell->libreOfficeKitViewInvalidateTilesCallback(nullptr, 
nTabIndex, 0);
+ScTabViewShell::notifyAllViewsSheetGeomInvalidation(
+pViewShell,
+true /* bColsAffected */, true /* bRowsAffected */,
+true /* bSizes*/, true /* bHidden */, true /* bFiltered */,
+true /* bGroups */, nTabIndex);
+}
+}
+}
 
 ScUndoInsertTab::ScUndoInsertTab( ScDocShell* pNewDocShell,
   SCTAB nTabNum,
@@ -119,6 +137,12 @@ void ScUndoInsertTab::Undo()
 if ( pChangeTrack )
 pChangeTrack->Undo( nEndChangeAction, nEndChangeAction );
 
+if (comphelper::LibreOfficeKit::isActive())
+{
+ScDocument& rDoc = pDocShell->GetDocument();
+lcl_OnTabsChanged(pViewShell, rDoc, nTab);
+}
+
 //  SetTabNo(...,sal_True) for all views to sync with drawing layer pages
 pDocShell->Broadcast( SfxHint( SfxHintId::ScForceSetTab ) );
 }
@@ -142,6 +166,12 @@ void ScUndoInsertTab::Redo()
 pDocShell->SetInUndo( false );  //! EndRedo
 
 SetChangeTrack();
+
+if (comphelper::LibreOfficeKit::isActive())
+{
+ScDocument& rDoc = pDocShell->GetDocument();
+lcl_OnTabsChanged(pViewShell, rDoc, nTab);
+}
 }
 
 void ScUndoInsertTab::Repeat(SfxRepeatTarget& rTarget)
@@ -360,6 +390,12 @@ void ScUndoDeleteTab::Undo()
 if ( pChangeTrack )
 pChangeTrack->Undo( nStartChangeAction, nEndChangeAction );
 
+ScTabViewShell* pViewShell = ScTabViewShell::GetActiveViewShell();
+if (comphelper::LibreOfficeKit::isActive() && !theTabs.empty())
+{
+lcl_OnTabsChanged(pViewShell, rDoc, theTabs[0]);
+}
+
 for(SCTAB nTab: theTabs)
 {
 pDocShell->Broadcast( ScTablesHint( SC_TAB_INSERTED, nTab) );
@@ -373,7 +409,6 @@ void ScUndoDeleteTab::Undo()
 pDocShell->PostPaint(0,0,0, rDoc.MaxCol(),rDoc.MaxRow(),MAXTAB, 
PaintPartFlags::All );  // incl. extras
 
 // not ShowTable due to SetTabNo(..., sal_True):
-ScTabViewShell* pViewShell = ScTabViewShell::GetActiveViewShell();
 if (pViewShell)
 pViewShell->SetTabNo( lcl_GetVisibleTabBefore( rDoc, theTabs[0] ), 
true );
 }
@@ -393,6 +428,12 @@ void ScUndoDeleteTab::Redo()
 
 SetChangeTrack();
 
+if (comphelper::LibreOfficeKit::isActive() && !theTabs.empty())
+{
+ScDocument& rDoc = pDocShell->GetDocument();
+lcl_OnTabsChanged(pViewShell, rDoc, theTabs[0]);
+}
+
 //  SetTabNo(...,sal_True) for all views to sync with drawing layer pages
 pDocShell->Broadcast( SfxHint( SfxHintId::ScForceSetTab ) );
 }
@@ -544,16 +585,10 @@ void ScUndoMoveTab::DoChange( bool bUndo ) const
 
 if (comphelper::LibreOfficeKit::isActive() && !mpNewTabs->empty())
 {
-tools::Rectangle aRectangle(0, 0, 10, 10);
 const auto newTabsMinIt = std::min_element(mpNewTabs->begin(), 
mpNewTabs->end());
 const auto oldTabsMinIt = std::min_element(mpOldTabs->begin(), 
mpOldTabs->end());
 SCTAB nTab = std::min(*newTabsMinIt, *oldTabsMinIt);
-for (SCTAB nTabIndex = nTab; nTabIndex < rDoc.GetTableCount(); 
++nTabIndex)
-{
-if (!rDoc.IsVisible(nTabIndex))
-continue;
-pViewShell->libreOfficeKitViewInvalidateTilesCallback(, 
nTabIndex, 0);
-}
+lcl_OnTabsChanged(pViewShell, rDoc, nTab, true /* bInvalidateTiles */);
 }
 
 SfxGetpApp()->Broadcast( SfxHint( 

[Bug 159100] Sidebar Hide/Show widget, the Show action is active beyond its button bounds

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159100

--- Comment #8 from vena.c...@virgin.net  ---
The bug is also present in the Linux version 24.2 of LibreOffice.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: helpcontent2

[Dione Maddern (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e137d43a1a42dd63d784b45929a6ccb1b5b48c6e
Author: Dione Maddern 
AuthorDate: Sat Mar 2 00:06:18 2024 +0100
Commit: Gerrit Code Review 
CommitDate: Sat Mar 2 00:06:18 2024 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 0b58cd7c6b04583935d6a25f28ec514c1e6424ba
  - tdf#148859 Fix link to Outline Bar help page

Add HID bookmark so that pressing F1 opens the correct help page for 
View > Toolbars > Outline

Change-Id: Ia9a7af6e01e7a71ceff0f35adcee4285228edf28
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164196
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 714426188f79..0b58cd7c6b04 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 714426188f79633f1f6e4f180c13aafda4fa4a4b
+Subproject commit 0b58cd7c6b04583935d6a25f28ec514c1e6424ba

help.git: source/text

[Dione Maddern (via logerrit)]

 source/text/simpress/main0211.xhp |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 0b58cd7c6b04583935d6a25f28ec514c1e6424ba
Author: Dione Maddern 
AuthorDate: Fri Mar 1 20:24:10 2024 +0100
Commit: Olivier Hallot 
CommitDate: Sat Mar 2 00:06:17 2024 +0100

tdf#148859 Fix link to Outline Bar help page

Add HID bookmark so that pressing F1 opens the correct help page for View > 
Toolbars > Outline

Change-Id: Ia9a7af6e01e7a71ceff0f35adcee4285228edf28
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164196
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/simpress/main0211.xhp 
b/source/text/simpress/main0211.xhp
index 031d412c05..e9d648258e 100644
--- a/source/text/simpress/main0211.xhp
+++ b/source/text/simpress/main0211.xhp
@@ -29,6 +29,7 @@
 
 
 
+
 Outline Bar
 In Outline View, the Outline bar contains frequently used 
editing tools. Click the arrow next to an icon to open a toolbar that 
contains additional commands.
 

core.git: helpcontent2

[Olivier Hallot (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 14ca02e58ede263e3cfafd172e164b7fc27dda45
Author: Olivier Hallot 
AuthorDate: Fri Mar 1 20:05:28 2024 -0300
Commit: Gerrit Code Review 
CommitDate: Sat Mar 2 00:05:28 2024 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 714426188f79633f1f6e4f180c13aafda4fa4a4b
  - tdf#94535 Corresponding Help page

Change-Id: Ic73d515a570fb0a8ae9e03f9d732c733715d71e3
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164230
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index acb79818f17b..714426188f79 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit acb79818f17b823827ff39871ea53ae3be0a9f1d
+Subproject commit 714426188f79633f1f6e4f180c13aafda4fa4a4b

help.git: source/text

[Olivier Hallot (via logerrit)]

 source/text/shared/01/0528.xhp |  255 -
 1 file changed, 143 insertions(+), 112 deletions(-)

New commits:
commit 714426188f79633f1f6e4f180c13aafda4fa4a4b
Author: Olivier Hallot 
AuthorDate: Fri Mar 1 16:17:29 2024 -0300
Commit: Olivier Hallot 
CommitDate: Sat Mar 2 00:05:27 2024 +0100

tdf#94535 Corresponding Help page

Change-Id: Ic73d515a570fb0a8ae9e03f9d732c733715d71e3
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164230
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/shared/01/0528.xhp 
b/source/text/shared/01/0528.xhp
index 8ecaf36822..ab461ec097 100644
--- a/source/text/shared/01/0528.xhp
+++ b/source/text/shared/01/0528.xhp
@@ -19,7 +19,7 @@
 
 
 
-Fontwork
+Text along Path
 /text/shared/01/0528.xhp
 
 
@@ -28,300 +28,331 @@
 
 
 
-
-
-
-Fontwork Dialog (for putting text along a 
curve)
-Simple tool for putting text along a curve without any 
fancy effects.UFI: see "Fontwork_ui" spec 
doc.
-
-This Fontwork dialog is meant for making 
text follow a curve. Draw a curve, double-click it and type text into it. With 
the curve selected, you can now activate the Fontwork command. Access the dialog by choosing 
Format - Text Box and Shape - 
FontworkFirst call Tools - 
Customize to add a menu command or a toolbar button to open the 
dialog. The Fontwork command is found in the Format category of 
the Customize dialog.
+
+
+
+Text along Path
+Simple tool for putting text along a curve without any 
fancy effects.UFI: see "Fontwork_ui" spec 
doc.
+
+
+
+
+Choose 
Format - Text Box and Shape - Text along Path
+
+
+
+
+Choose 
Format - Text along Path.
+
+Choose 
Text along Path.
+
+
+
+Choose 
Format - Text along Path.
+
+Choose 
Text along Path.
+
+
+
+
+
+
+Icon Text along 
Path
+
+
+Text 
along Path
+
+
+
+
+This Text along Path dialog is 
meant for making text follow a curve. Draw a curve, double-click it and type 
text into it. With the curve selected, you can now activate the Text 
along Path command.
 
-Alignment icons
-You can make 
text follow any shape. Most of the custom shapes available in the Drawing 
toolbar need to be converted to a different type before you can use them with 
Fontwork. In Impress or Draw, right-click the shape and select Convert - 
To Curve/Polygon/Contour. If you wish, you can now copy and paste the 
converted shape into Writer for use with Fontwork. Shapes in the Legacy 
Circles and Ovals and Legacy Rectangles toolbars do not 
need to be converted. The Arc included in the basic shapes is also 
a legacy shape.
+Style
+You can make text follow any 
shape. Most of the custom shapes available in the Drawing toolbar need to be 
converted to a different type before you can use them with Text along 
Path. In Impress or Draw, right-click the shape and select 
Convert - To Curve/Polygon/Contour. If you wish, you can now copy 
and paste the converted shape into Writer for use with Text along 
Path. Shapes in the Legacy Circles and Ovals and 
Legacy Rectangles toolbars do not need to be converted. The 
Arc included in the basic shapes is also a legacy 
shape.
 
-
+
 Baseline Off
-Removes baseline 
formatting.
+Removes baseline 
formatting.
 
 
 
-
-Icon 
Off
+
+Icon Off
 
 
-Baseline 
Off
+Baseline Off
 
 
 
 
-
+
 Rotate
-Uses the top or the bottom edge of the 
selected object as the text baseline.
+Uses the top or the bottom edge of the 
selected object as the text baseline.
 
 
 
-
-Icon
+
+Icon
 
 
-Rotate
+Rotate
 
 
 
 
-
+
 Upright
-Uses the top or the bottom edge of the 
selected object as the text baseline and preserves the original vertical 
alignment of the individual characters.
+Uses the top or the bottom edge of the 
selected object as the text baseline and preserves the original vertical 
alignment of the individual characters.
 
 
 
-
-Icon Upright
+
+Icon Upright
 
 
-Upright
+Upright
 
 
 
 
-
+
 Slant Horizontal
-Horizontally slants the characters in the 
text object.
+Horizontally slants the characters in the 
text object.
 
 
 
-
-Icon Slant 
Horizontal
+
+Icon Slant Horizontal
 
 
-Slant 
Horizontal
+Slant Horizontal
 
 
 
-
+
 Slant Vertical
-Vertically slants the characters in the text 
object.
+Vertically slants the characters in the text 
object.
 
 
 
-
-Icon Slant 
Vertical
+
+Icon Slant Vertical
 
 
-Slant 
Vertical
+Slant Vertical
 
 
 
-
-
+Adjust
+
 Orientation
-Reverses the text flow direction, and 
flips the text horizontally or vertically. To use this command, you must first 
apply a different baseline to the text.
+Reverses the text flow direction, and 
flips the text horizontally or vertically. To use this command, you must first 
apply a 

[Bug 94535] UI: Cannot open Fontwork dialog to adapt text to connect shape

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94535

--- Comment #14 from Commit Notification 
 ---
Olivier Hallot committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/714426188f79633f1f6e4f180c13aafda4fa4a4b

tdf#94535 Corresponding Help page

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159991] TOC page numbers do not match actual page numbers by constant offset - with workaround

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159991

--- Comment #2 from Tom Sullivan  ---
Created attachment 192900
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192900=edit
File that exhibits the workaround

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159991] TOC page numbers do not match actual page numbers by constant offset - with workaround

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159991

--- Comment #1 from Tom Sullivan  ---
Created attachment 192899
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192899=edit
File that exhibits the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159991] New: TOC page numbers do not match actual page numbers by constant offset - with workaround

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159991

Bug ID: 159991
   Summary: TOC page numbers do not match actual page numbers by
constant offset - with workaround
   Product: LibreOffice
   Version: 7.4.7.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: t...@sullivaninusa.com

Description:
With a fairly long, 341 page document, TOC page numbers do not match the actual
printed page numbers, which are correct. Various changes to the document, such
as deleting the last half then updating the TOC work once. After that the bug
reappears. The same was experienced by checking/unchecking options in Create
>From such as Index Marks. In other words, changes to things may work once or
twice, then fail once the index (TOC) is updated or edited. A workaround was
suggested to this author by a workaround for another bug in a forum (URL lost).
See below steps to reproduce.

Steps to Reproduce:
1. Use a big document with a very detailed outline.
2. Insert a TOC near the top, such as after title and copyright pages.
3. Use ctl-Enter to go to the next page.
4. Update the TOC if needed.


Actual Results:
Page numbers in the TOC are wrong, typically by a constant offset

Expected Results:
TOC page numbers would match page footer page numbers (which are correct).


Reproducible: Sometimes


User Profile Reset: No

Additional Info:
Workaround:
1. Delete all lines and text between TOC and text of next page.
2. Put in 2 or 3 blank lines (not sure this is needed, but is useful to be sure
what one is doing.
3. Go to menu/More Breaks/Manual Break ...
4. For page style, select Default Page Style
5. check Change page number and put the correct page number for the next page
in the below box.
6. Click OK
(weird, huh?)
(Note: I fear to reset my profile. I also do not think this worthwhile since
the bug also appears in a new install of 7.6)
I hope to attach 2 files: TreatiseSin.odt containing above workaround and
TreatiseSinBAD.odt which exhibits the bug. These uploads are necessary as small
test documents do not reliably exhibit the bug if at all.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159986] Slide Transition doesn't work for many Transitions (starting with "Tiles") with KDE (Linux)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159986

Julien Nabet  changed:

   What|Removed |Added

 CC||m.wegh...@posteo.de

--- Comment #4 from Julien Nabet  ---
Michael: thought you might be interested in this one.
It seems a QWindow is missing here.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159984] FILESAVE PPTX asks to repair when opened with MSO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159984

Regina Henschel  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
 CC||rb.hensc...@t-online.de
   Keywords||bibisectRequest, regression

--- Comment #1 from Regina Henschel  ---
I see the error in Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 39048e0c0e9af455197ff57cc2947f8fb23e8542
CPU threads: 32; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win
Locale: de-DE (de_DE); UI: en-US
Calc: threaded

It is OK in Version: 7.6.4.1 (X86_64) / LibreOffice Community
Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1
CPU threads: 32; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win
Locale: de-DE (de_DE); UI: en-US
Calc: threaded

I have tested it with template "Blue Curve".

It is likely the same problem as in bug 159931. I see the same error, that
ppt\slides\_rels\slide1.xml.rels refers a part
"../slideLayouts/slideLayout0.xml" which does not exist.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159986] Slide Transition doesn't work for many Transitions (starting with "Tiles") with KDE (Linux)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159986

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #3 from Julien Nabet  ---
Created attachment 192898
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192898=edit
gdb bt

On pc Debian x86-64 with master sources updated today I could reproduce this
with kf5 not with gtk3.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159990] Double filter doesn’t allow empty cells any longer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159990

--- Comment #1 from ady  ---
Please see tdf#159420.

Please test a new daily build and report back here whether the problem is
solved for you.



-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 49602] Remove deprecated OSL Profile functionality

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=49602

--- Comment #12 from seturajmatr...@gmail.com ---
Are there any previous api changes regarding osl::profile so I can refer them?
Also there is a recursive expandmacros function in the file

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98259
Bug 98259 depends on bug 159976, which changed state.

Bug 159976 Summary: Accelerators are shown as tildes instead of underlined 
characters
https://bugs.documentfoundation.org/show_bug.cgi?id=159976

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 85811] [META] Main menu bar bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85811
Bug 85811 depends on bug 159976, which changed state.

Bug 159976 Summary: Accelerators are shown as tildes instead of underlined 
characters
https://bugs.documentfoundation.org/show_bug.cgi?id=159976

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159990] New: Double filter doesn’t allow empty cells any longer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159990

Bug ID: 159990
   Summary: Double filter doesn’t allow empty cells any longer
   Product: LibreOffice
   Version: 7.6.5.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bugzi...@kgb.ovh

Description:
Another regression in the new version. Now in 7.6.5.2.

Steps to Reproduce:
1. Have several columns with filters. At least one of the columns should have
some empty cells as well.
2. Apply a filter to one column.
3. Apply a second filter to the column that has some empty cells.

Actual Results:
You can’t click the checkboxes so that you have a selection of the possible
values and also the empty cells at the same time. The empty cell checkbox is
greyed out.

Expected Results:
Like in older versions, let people select empty cells and at the same time
cells with some values.


Reproducible: Always


User Profile Reset: No

Additional Info:
I wish there were no so many regressions in new versions. I wish they were
tested more thoroughly.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: 2 commits - vcl/source

[Mike Kaganski (via logerrit)]

 vcl/source/outdev/text.cxx |   97 ++---
 1 file changed, 39 insertions(+), 58 deletions(-)

New commits:
commit 88ce6625a03d33d714a2e26d9c41a7fa15b363a5
Author: Mike Kaganski 
AuthorDate: Fri Mar 1 16:00:40 2024 +0600
Commit: Mike Kaganski 
CommitDate: Fri Mar 1 22:38:01 2024 +0100

Fix nIndex / nLen passed to mpAlphaVDev->DrawCtrlText

The corrected values along with original text make no sense

Change-Id: Id84728e7d23d8780c4e7b7a76091470a82206efd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164184
Reviewed-by: Noel Grandin 
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/vcl/source/outdev/text.cxx b/vcl/source/outdev/text.cxx
index 158cb20ce93c..80fb2b94bd40 100644
--- a/vcl/source/outdev/text.cxx
+++ b/vcl/source/outdev/text.cxx
@@ -1758,17 +1758,12 @@ tools::Rectangle OutputDevice::GetTextRect( const 
tools::Rectangle& rRect,
 }
 
 void OutputDevice::DrawCtrlText( const Point& rPos, const OUString& rStr,
- sal_Int32 nIndex, sal_Int32 nLen,
+ const sal_Int32 nIndex, const sal_Int32 nLen,
  DrawTextFlags nStyle, std::vector< 
tools::Rectangle >* pVector, OUString* pDisplayText,
  const SalLayoutGlyphs* pGlyphs )
 {
 assert(!is_double_buffered_window());
 
-if( (nLen < 0) || (nIndex + nLen >= rStr.getLength()))
-{
-nLen = rStr.getLength() - nIndex;
-}
-
 if ( !IsDeviceOutputNecessary() || (nIndex >= rStr.getLength()) )
 return;
 
@@ -1782,12 +1777,12 @@ void OutputDevice::DrawCtrlText( const Point& rPos, 
const OUString& rStr,
 if ( mbOutputClipped )
 return;
 
-if( nIndex >= rStr.getLength() )
-return;
-
-if( (nLen < 0) || (nIndex + nLen >= rStr.getLength()))
+// nIndex and nLen must go to mpAlphaVDev->DrawCtrlText unchanged
+sal_Int32 nCorrectedIndex = nIndex;
+sal_Int32 nCorrectedLen = nLen;
+if ((nCorrectedLen < 0) || (nCorrectedIndex + nCorrectedLen >= 
rStr.getLength()))
 {
-nLen = rStr.getLength() - nIndex;
+nCorrectedLen = rStr.getLength() - nCorrectedIndex;
 }
 sal_Int32  nMnemonicPos = -1;
 
@@ -1797,33 +1792,33 @@ void OutputDevice::DrawCtrlText( const Point& rPos, 
const OUString& rStr,
 const OUString aStr = removeMnemonicFromString(rStr, nMnemonicPos); // 
Strip mnemonics always
 if (nMnemonicPos != -1)
 {
-if (nMnemonicPos < nIndex)
+if (nMnemonicPos < nCorrectedIndex)
 {
---nIndex;
+--nCorrectedIndex;
 }
 else
 {
-if (nMnemonicPos < (nIndex + nLen))
---nLen;
+if (nMnemonicPos < (nCorrectedIndex + nCorrectedLen))
+--nCorrectedLen;
 }
 if (nStyle & DrawTextFlags::Mnemonic && !pVector
 && !(GetSettings().GetStyleSettings().GetOptions() & 
StyleSettingsOptions::NoMnemonics))
 {
-SAL_WARN_IF( nMnemonicPos >= (nIndex+nLen), "vcl", "Mnemonic 
underline marker after last character" );
+SAL_WARN_IF( nMnemonicPos >= (nCorrectedIndex+nCorrectedLen), 
"vcl", "Mnemonic underline marker after last character" );
 bool bInvalidPos = false;
 
-if( nMnemonicPos >= nLen )
+if (nMnemonicPos >= nCorrectedLen)
 {
 // may occur in BiDi-Strings: the '~' is sometimes found 
behind the last char
 // due to some strange BiDi text editors
 // -> place the underline behind the string to indicate a 
failure
 bInvalidPos = true;
-nMnemonicPos = nLen-1;
+nMnemonicPos = nCorrectedLen - 1;
 }
 
 KernArray aDXArray;
-GetTextArray(aStr, , nIndex, nLen, true, nullptr, 
pGlyphs);
-sal_Int32 nPos = nMnemonicPos - nIndex;
+GetTextArray(aStr, , nCorrectedIndex, nCorrectedLen, 
true, nullptr, pGlyphs);
+sal_Int32 nPos = nMnemonicPos - nCorrectedIndex;
 sal_Int32 lc_x1 = nPos ? aDXArray[nPos - 1] : 0;
 sal_Int32 lc_x2 = aDXArray[nPos];
 nMnemonicWidth = std::abs(lc_x1 - lc_x2);
@@ -1871,7 +1866,7 @@ void OutputDevice::DrawCtrlText( const Point& rPos, const 
OUString& rStr,
 SetTextColor( GetSettings().GetStyleSettings().GetDisableColor() );
 }
 
-DrawText(rPos, aStr, nIndex, nLen, pVector, pDisplayText, pGlyphs);
+DrawText(rPos, aStr, nCorrectedIndex, nCorrectedLen, pVector, 
pDisplayText, pGlyphs);
 if (nMnemonicPos != -1)
 ImplDrawMnemonicLine(nMnemonicX, nMnemonicY, nMnemonicWidth);
 
commit 4d39b88283d02eb44fe4cb8f3e4ec153ebf96a13
Author: Mike Kaganski 
AuthorDate: Fri Mar 1 14:42:05 2024 +0600
Commit: Mike Kaganski 
CommitDate: Fri Mar 1 22:37:49 2024 +0100

tdf#159976: make sure to always strip 

core.git: sc/source

[Marco Cecchetti (via logerrit)]

 sc/source/ui/undo/undotab.cxx  |   14 ++
 sc/source/ui/view/viewfun2.cxx |7 +++
 2 files changed, 21 insertions(+)

New commits:
commit 49aead6a7ff3933c127efe0f230a2630caa8f342
Author: Marco Cecchetti 
AuthorDate: Mon Feb 26 14:36:12 2024 +0100
Commit: Caolán McNamara 
CommitDate: Fri Mar 1 21:56:27 2024 +0100

lok: calc: tiles not invalidated on tab move

This patch fixes a regression started from
9f3ee2b2 "don't invalidate when switching tabs"

Change-Id: Icd560c73cff836b026b1ba69432bb712e36c035a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164164
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Caolán McNamara 
(cherry picked from commit cf4630887adcf3e9d8b7a2452f097bb2f564fc5c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164190
Tested-by: Jenkins

diff --git a/sc/source/ui/undo/undotab.cxx b/sc/source/ui/undo/undotab.cxx
index 4237aab46358..670769e70ffc 100644
--- a/sc/source/ui/undo/undotab.cxx
+++ b/sc/source/ui/undo/undotab.cxx
@@ -542,6 +542,20 @@ void ScUndoMoveTab::DoChange( bool bUndo ) const
 }
 }
 
+if (comphelper::LibreOfficeKit::isActive() && !mpNewTabs->empty())
+{
+tools::Rectangle aRectangle(0, 0, 10, 10);
+const auto newTabsMinIt = std::min_element(mpNewTabs->begin(), 
mpNewTabs->end());
+const auto oldTabsMinIt = std::min_element(mpOldTabs->begin(), 
mpOldTabs->end());
+SCTAB nTab = std::min(*newTabsMinIt, *oldTabsMinIt);
+for (SCTAB nTabIndex = nTab; nTabIndex < rDoc.GetTableCount(); 
++nTabIndex)
+{
+if (!rDoc.IsVisible(nTabIndex))
+continue;
+pViewShell->libreOfficeKitViewInvalidateTilesCallback(, 
nTabIndex, 0);
+}
+}
+
 SfxGetpApp()->Broadcast( SfxHint( SfxHintId::ScTablesChanged ) );// 
Navigator
 
 pDocShell->PostPaintGridAll();
diff --git a/sc/source/ui/view/viewfun2.cxx b/sc/source/ui/view/viewfun2.cxx
index b47bd907d1bd..19833c510599 100644
--- a/sc/source/ui/view/viewfun2.cxx
+++ b/sc/source/ui/view/viewfun2.cxx
@@ -91,6 +91,7 @@
 #include 
 
 #include 
+#include 
 
 using namespace com::sun::star;
 using ::editeng::SvxBorderLine;
@@ -3174,6 +3175,12 @@ void ScViewFunc::MoveTable(sal_uInt16 nDestDocNo, SCTAB 
nDestTab, bool bCopy,
 
 SCTAB nTab = GetViewData().GetTabNo();
 
+if (comphelper::LibreOfficeKit::isActive() && !pSrcTabs->empty())
+{
+ScModelObj* pModel = pDocShell->GetModel();
+SfxLokHelper::notifyDocumentSizeChangedAllViews(pModel);
+}
+
 if (bUndo)
 {
 if (bCopy)

[Bug 88278] [META] SVG import image filter (all modules)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88278
Bug 88278 depends on bug 159968, which changed state.

Bug 159968 Summary: LibreOffice can't render markers (eg. arrows) embeded to 
end of line
https://bugs.documentfoundation.org/show_bug.cgi?id=159968

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: svgio/inc svgio/qa svgio/source

[Xisco Fauli (via logerrit)]

 svgio/inc/svgstyleattributes.hxx  |   12 
 svgio/inc/svgtoken.hxx|1 
 svgio/qa/cppunit/SvgImportTest.cxx|   17 +++
 svgio/qa/cppunit/data/tdf159968.svg   |   37 +
 svgio/source/svgreader/svgstyleattributes.cxx |   38 +-
 svgio/source/svgreader/svgtoken.cxx   |1 
 6 files changed, 105 insertions(+), 1 deletion(-)

New commits:
commit a661f9a2e0a05de1705a8e9d930c148a1416be29
Author: Xisco Fauli 
AuthorDate: Fri Mar 1 16:42:27 2024 +0100
Commit: Xisco Fauli 
CommitDate: Fri Mar 1 21:46:01 2024 +0100

tdf#159968: Support overflow:visible in marker element

Change-Id: I4ea648cf94a4bb321a78843a9898769a69c5630d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164224
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/svgio/inc/svgstyleattributes.hxx b/svgio/inc/svgstyleattributes.hxx
index 4516773e83a6..bf921f8b1bb0 100644
--- a/svgio/inc/svgstyleattributes.hxx
+++ b/svgio/inc/svgstyleattributes.hxx
@@ -170,6 +170,13 @@ namespace svgio::svgreader
 Central
 };
 
+enum class Overflow
+{
+notset,
+hidden,
+visible
+};
+
 enum class Visibility
 {
 notset,
@@ -207,6 +214,7 @@ namespace svgio::svgreader
 TextAnchor  maTextAnchor;
 SvgPaintmaColor;
 SvgNumber   maOpacity;
+OverflowmaOverflow;
 Visibility  maVisibility;
 OUString   maTitle;
 OUString   maDesc;
@@ -410,6 +418,10 @@ namespace svgio::svgreader
 SvgNumber getOpacity() const;
 void setOpacity(const SvgNumber& rOpacity) { maOpacity = rOpacity; 
}
 
+/// Overflow
+Overflow getOverflow() const;
+void setOverflow(const Overflow aOverflow) { maOverflow = 
aOverflow; }
+
 /// Visibility
 Visibility getVisibility() const;
 void setVisibility(const Visibility aVisibility) { maVisibility = 
aVisibility; }
diff --git a/svgio/inc/svgtoken.hxx b/svgio/inc/svgtoken.hxx
index 8ad390f0b4a5..613b75049335 100644
--- a/svgio/inc/svgtoken.hxx
+++ b/svgio/inc/svgtoken.hxx
@@ -113,6 +113,7 @@ namespace svgio::svgreader
 Visibility,
 Title,
 Desc,
+Overflow,
 
 // AspectRatio and params
 PreserveAspectRatio,
diff --git a/svgio/qa/cppunit/SvgImportTest.cxx 
b/svgio/qa/cppunit/SvgImportTest.cxx
index 99541f0b63b7..708ab7dcc970 100644
--- a/svgio/qa/cppunit/SvgImportTest.cxx
+++ b/svgio/qa/cppunit/SvgImportTest.cxx
@@ -2013,6 +2013,23 @@ CPPUNIT_TEST_FIXTURE(Test, testTdf156271)
 assertXPath(pDocument, 
"/primitive2D/transform/mask/textsimpleportion[4]"_ostr, "dx1"_ostr, "23");
 }
 
+CPPUNIT_TEST_FIXTURE(Test, testTdf159968)
+{
+Primitive2DSequence aSequence = 
parseSvg(u"/svgio/qa/cppunit/data/tdf159968.svg");
+CPPUNIT_ASSERT_EQUAL(1, static_cast(aSequence.getLength()));
+
+drawinglayer::Primitive2dXmlDump dumper;
+xmlDocUniquePtr pDocument = 
dumper.dumpAndParse(Primitive2DContainer(aSequence));
+
+CPPUNIT_ASSERT (pDocument);
+
+// Check no mask is applied to the marker
+assertXPath(pDocument,
+
"/primitive2D/transform/transform/transform/transform/polypolygoncolor"_ostr, 
"color"_ostr, "#00");
+assertXPath(pDocument,
+
"/primitive2D/transform/transform/transform/transform/polypolygoncolor/polypolygon/polygon/point"_ostr,
 5);
+}
+
 CPPUNIT_TEST_FIXTURE(Test, testTdf149880)
 {
 Primitive2DSequence aSequence = 
parseSvg(u"/svgio/qa/cppunit/data/tdf149880.svg");
diff --git a/svgio/qa/cppunit/data/tdf159968.svg 
b/svgio/qa/cppunit/data/tdf159968.svg
new file mode 100644
index ..8c13f0864901
--- /dev/null
+++ b/svgio/qa/cppunit/data/tdf159968.svg
@@ -0,0 +1,37 @@
+
+
+http://www.w3.org/2000/svg;
+   xmlns:svg="http://www.w3.org/2000/svg;>
+  
+
+  
+
+  
+  
+
+  
+
diff --git a/svgio/source/svgreader/svgstyleattributes.cxx 
b/svgio/source/svgreader/svgstyleattributes.cxx
index e2088be449b3..cdebccbd2526 100644
--- a/svgio/source/svgreader/svgstyleattributes.cxx
+++ b/svgio/source/svgreader/svgstyleattributes.cxx
@@ -850,7 +850,8 @@ namespace svgio::svgreader
 const basegfx::B2DRange aTargetRange(0.0, 0.0, 
fTargetWidth, fTargetHeight);
 const SvgAspectRatio& rRatio = 
rMarker.getSvgAspectRatio();
 
-if(rRatio.isSet())
+
+if(rRatio.isSet() && Overflow::visible != 
rMarker.getSvgStyleAttributes()->getOverflow())
 {
 // let mapping be created from SvgAspectRatio
 rMarkerTransform 

core.git: svx/source

[Pranam Lashkari (via logerrit)]

 svx/source/svdraw/svdmrkv.cxx |   52 +-
 1 file changed, 51 insertions(+), 1 deletion(-)

New commits:
commit 948cd8b9f62e28883b691084a9bb83177422defd
Author: Pranam Lashkari 
AuthorDate: Wed Feb 28 04:55:46 2024 +0530
Commit: Caolán McNamara 
CommitDate: Fri Mar 1 21:39:07 2024 +0100

LOK: send inner text boundry information of shapes/textbox

Sends inner rectangle boundry info as part of 
LOK_CALLBACK_GRAPHIC_SELECTION message

Change-Id: Idc51e807bec01711c8a4326e3193127f0b2cd765
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164124
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/svx/source/svdraw/svdmrkv.cxx b/svx/source/svdraw/svdmrkv.cxx
index b0784449f159..b9a492aa35ad 100644
--- a/svx/source/svdraw/svdmrkv.cxx
+++ b/svx/source/svdraw/svdmrkv.cxx
@@ -40,6 +40,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -60,6 +61,8 @@
 #include 
 #include 
 
+#include 
+
 #include 
 
 #include 
@@ -759,6 +762,30 @@ bool 
SdrMarkView::dumpGluePointsToJSON(boost::property_tree::ptree& rTree)
 return result;
 }
 
+namespace
+{
+class TextBoundsExtractor final : public 
drawinglayer::processor2d::TextExtractor2D
+{
+private:
+basegfx::B2DRange maTextRange;
+void processTextPrimitive2D(const 
drawinglayer::primitive2d::BasePrimitive2D& rCandidate) override
+{
+maTextRange.expand(rCandidate.getB2DRange(getViewInformation2D()));
+}
+public:
+explicit TextBoundsExtractor(const 
drawinglayer::geometry::ViewInformation2D& rViewInformation)
+: drawinglayer::processor2d::TextExtractor2D(rViewInformation)
+{
+}
+
+basegfx::B2DRange getTextBounds(const sdr::contact::ViewObjectContact 
, sdr::contact::DisplayInfo )
+{
+this->process(rVOC.getPrimitive2DSequence(raDisplayInfo));
+return maTextRange;
+}
+};
+}
+
 void SdrMarkView::SetMarkHandlesForLOKit(tools::Rectangle const & rRect, const 
SfxViewShell* pOtherShell)
 {
 SfxViewShell* pViewShell = GetSfxViewShell();
@@ -837,6 +864,8 @@ void SdrMarkView::SetMarkHandlesForLOKit(tools::Rectangle 
const & rRect, const S
 bConnectorSelection = dumpGluePointsToJSON(aGluePointsTree);
 }
 
+SdrPageView* pPageView = GetSdrPageView();
+
 if (GetMarkedObjectCount())
 {
 SdrMark* pM = GetSdrMarkByIndex(0);
@@ -853,6 +882,27 @@ void SdrMarkView::SetMarkHandlesForLOKit(tools::Rectangle 
const & rRect, const S
 + "\",\"type\":"
 + 
OString::number(static_cast(pO->GetObjIdentifier(;
 
+if (mpMarkedObj && !pOtherShell)
+{
+const sdr::contact::ViewObjectContact& rVOC = 
mpMarkedObj->GetViewContact().GetViewObjectContact(
+pPageView->GetPageWindow(0)->GetObjectContact());
+
+sdr::contact::DisplayInfo aDisplayInfo;
+TextBoundsExtractor 
aTextBoundsExtractor(rVOC.GetObjectContact().getViewInformation2D());
+basegfx::B2DRange aRange = 
aTextBoundsExtractor.getTextBounds(rVOC, aDisplayInfo);
+if (!aRange.isEmpty()) {
+tools::Rectangle rect(aRange.getMinX(), aRange.getMinY(), 
aRange.getMaxX(), aRange.getMaxY());
+tools::Rectangle aRangeTWIP = o3tl::convert(rect, 
o3tl::Length::mm100, o3tl::Length::twip);
+OString innerTextInfo = ",\"innerTextRect\":[" +
+OString::number(aRangeTWIP.getX()) + "," +
+OString::number(aRangeTWIP.getY()) + "," +
+OString::number(aRangeTWIP.GetWidth()) + "," +
+OString::number(aRangeTWIP.GetHeight()) + "]";
+
+aExtraInfo.append(innerTextInfo);
+}
+}
+
 // In core, the gridOffset is calculated based on the LogicRect's 
TopLeft coordinate
 // In online, we have the SnapRect and we calculate it based on 
its TopLeft coordinate
 // SnapRect's TopLeft and LogicRect's TopLeft match unless there 
is rotation
@@ -862,7 +912,7 @@ void SdrMarkView::SetMarkHandlesForLOKit(tools::Rectangle 
const & rRect, const S
 // whether the shape is rotated or not, we will always have the 
correct gridOffset
 // Note that the gridOffset is calculated from the first selected 
obj
 basegfx::B2DVector aGridOffset(0.0, 0.0);
-if(getPossibleGridOffsetForSdrObject(aGridOffset, 
GetMarkedObjectByIndex(0), GetSdrPageView()))
+if(getPossibleGridOffsetForSdrObject(aGridOffset, 
GetMarkedObjectByIndex(0), pPageView))
 {
 Point p(aGridOffset.getX(), aGridOffset.getY());
 if (convertMapMode)

core.git: sd/qa sd/source

[Justin Luth (via logerrit)]

 sd/qa/uitest/impress_tests/tdf159927_dateTime.py |3 +--
 sd/source/ui/dlg/headerfooterdlg.cxx |2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

New commits:
commit de5816806589c6e6d1da11f50f9ceeb6f50dc3ef
Author: Justin Luth 
AuthorDate: Fri Mar 1 10:40:23 2024 -0500
Commit: Justin Luth 
CommitDate: Fri Mar 1 21:37:15 2024 +0100

fix build: UITest_impress_tests (re-enable date-time test)

accidental debugging change got mixed into a patch...

This reverts part of commit 99e33129346afeb0a386ffad859a9178290211a6
which shows I clearly failed to follow my normal practise of
properly reviewing the change in gerrit before submitting.

Change-Id: Iaa1d9a0eaa4f12c8a5786a29887a82b193baac38
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164223
Reviewed-by: Justin Luth 
Tested-by: Jenkins

diff --git a/sd/qa/uitest/impress_tests/tdf159927_dateTime.py 
b/sd/qa/uitest/impress_tests/tdf159927_dateTime.py
index 7225d5c96468..17c5f23caa3b 100644
--- a/sd/qa/uitest/impress_tests/tdf159927_dateTime.py
+++ b/sd/qa/uitest/impress_tests/tdf159927_dateTime.py
@@ -19,7 +19,6 @@ class tdf159927(UITestCase):
 language_list = xDialog.getChild("language_list")
 # Expected: the existing language of the date/time field: 
Finnish
 # Actual without the fix: the user's locale as specified in 
tools - options.
-# comment out uitest that fails regularly both on jenkins and my local box
-#
self.assertEqual(get_state_as_dict(language_list)["SelectEntryText"], "Finnish")
+
self.assertEqual(get_state_as_dict(language_list)["SelectEntryText"], "Finnish")
 
 # vim: set shiftwidth=4 softtabstop=4 expandtab:
diff --git a/sd/source/ui/dlg/headerfooterdlg.cxx 
b/sd/source/ui/dlg/headerfooterdlg.cxx
index 8aaf7fed1e47..92f7e9be1cb0 100644
--- a/sd/source/ui/dlg/headerfooterdlg.cxx
+++ b/sd/source/ui/dlg/headerfooterdlg.cxx
@@ -536,7 +536,7 @@ void HeaderFooterTabPage::GetOrSetDateTimeLanguage( 
LanguageType , boo
 }
 else
 {
-const sal_uInt16 nPageCount = 1;// 
mpDoc->GetMasterSdPageCount(PageKind::Standard);
+const sal_uInt16 nPageCount = 
mpDoc->GetMasterSdPageCount(PageKind::Standard);
 sal_uInt16 nPage;
 for( nPage = 0; nPage < nPageCount; nPage++ )
 {

[Bug 141216] Stock Chart - Type 2 2nd Data Series can not be formatted separately

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141216

--- Comment #10 from Ian Eales  ---
Created attachment 192897
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192897=edit
BACK TO SQUARE ONE - change type to Bar and all Sec Y  assignments are GONE

The loss of Sec Y Axis assignments is likely lost when Stock is chosen for the
chart type

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 141216] Stock Chart - Type 2 2nd Data Series can not be formatted separately

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141216

--- Comment #9 from Ian Eales  ---
Created attachment 192896
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192896=edit
Step 4 - change chart to Stock - Sec Y Axis DISAPPEARS

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 141216] Stock Chart - Type 2 2nd Data Series can not be formatted separately

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141216

--- Comment #8 from Ian Eales  ---
Created attachment 192895
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192895=edit
Step 3 - Sec Y Axis format colors change

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 141216] Stock Chart - Type 2 2nd Data Series can not be formatted separately

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141216

--- Comment #7 from Ian Eales  ---
Created attachment 192894
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192894=edit
Step 2 - Annual and Rain Year moved to Sec Y Axis

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 141216] Stock Chart - Type 2 2nd Data Series can not be formatted separately

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141216

--- Comment #6 from Ian Eales  ---
Created attachment 192893
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192893=edit
Step one - Chart all on Primary Y Axis

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 141216] Stock Chart - Type 2 2nd Data Series can not be formatted separately

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141216

Ian Eales  changed:

   What|Removed |Added

 CC||iea...@ielogical.com

--- Comment #5 from Ian Eales  ---
Created attachment 192892
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192892=edit
Duplicate Stock Type 2 Second Axis Fault

This bug has been open for more than 3 years and nothing has been done.

This issue is a MAJOR waste of time for people who follow the HELP instructions
only to find out it does not work.

What happens is the 2nd axis assignment is removed when the chart type is
changed to stock and the 2 axis items are not shown.

Example images of what happens follow

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 126635] HYPHENATION: Writer doesn't break the line correctly after closing double quotation mark and semicolon

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126635

Buovjaga  changed:

   What|Removed |Added

 Status|REOPENED|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159986] Slide Transition doesn't work for many Transitions (starting with "Tiles") with KDE (Linux)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159986

Julien Nabet  changed:

   What|Removed |Added

Summary|Slide Transition doesn't|Slide Transition doesn't
   |work for many Transitions   |work for many Transitions
   |(staring with "Tiles") with |(starting with "Tiles")
   |KDE (Linux) |with KDE (Linux)

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: sw/source

[Julien Nabet (via logerrit)]

 sw/source/uibase/uiview/view2.cxx |   13 ++---
 1 file changed, 10 insertions(+), 3 deletions(-)

New commits:
commit 4e060f854cd175ff7ef8f3c2dd3f0dbf5cc48ad2
Author: Julien Nabet 
AuthorDate: Fri Mar 1 12:14:52 2024 +0100
Commit: Julien Nabet 
CommitDate: Fri Mar 1 21:01:12 2024 +0100

tdf#159955: fix custom page number

Change-Id: I1a56a4ba266dfb3c21e3b77263ecaa44b4e6dad5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164210
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/sw/source/uibase/uiview/view2.cxx 
b/sw/source/uibase/uiview/view2.cxx
index 1845b99441bd..4957ba03c522 100644
--- a/sw/source/uibase/uiview/view2.cxx
+++ b/sw/source/uibase/uiview/view2.cxx
@@ -289,14 +289,21 @@ OUString SwView::GetPageStr(sal_uInt16 nPhyNum, 
sal_uInt16 nVirtNum, const OUStr
 ? SwResId(STR_PAGE_COUNT_PRINTED)
 : (extra.isEmpty() ? SwResId(STR_PAGE_COUNT) : 
SwResId(STR_PAGE_COUNT_CUSTOM)));
 aStr = aStr.replaceFirst("%1", OUString::number(nPhyNum));
-aStr = aStr.replaceFirst("%2", OUString::number(nPageCount));
 if (nPageCount != nPrintedPageCount)
 {
+aStr = aStr.replaceFirst("%2", OUString::number(nPageCount));
 aStr = aStr.replaceFirst("%3", OUString::number(nPrintedPhyNum));
 aStr = aStr.replaceFirst("%4", OUString::number(nPrintedPageCount));
 }
-else
-aStr = aStr.replaceFirst("%3", extra);
+else {
+if (extra.isEmpty())
+aStr = aStr.replaceFirst("%2", OUString::number(nPageCount));
+else
+{
+aStr = aStr.replaceFirst("%2", extra);
+aStr = aStr.replaceFirst("%3", OUString::number(nPageCount));
+}
+}
 
 return aStr;
 }

[Bug 159986] Slide Transition doesn't work for many Transitions (staring with "Tiles") with KDE (Linux)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159986

--- Comment #2 from Grantler  ---
Same problem here: Only transitions down to "Tiles" seem to work. "Cube" does
not.

Version: 7.6.5.2 (X86_64) / LibreOffice Community
Build ID: 60(Build:2)
CPU threads: 2; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: de-DE (de_DE.UTF-8); UI: en-US
Ubuntu package version: 4:7.6.5-0ubuntu0.20.04.1~lo1
Calc: threaded

On my desktop machine (CPU threads: 4) the problems don't appear.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: sc/source

[Miklos Vajna (via logerrit)]

 sc/source/ui/docshell/docsh6.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit b570bba64d688a906c51455e5bbda854f9eb8b7c
Author: Miklos Vajna 
AuthorDate: Fri Mar 1 08:34:00 2024 +0100
Commit: Miklos Vajna 
CommitDate: Fri Mar 1 20:44:18 2024 +0100

sc lok: make the formula separator warning dialog async

I'm not sure what exactly changed here, but recently online.git
unit-wopi-languages started to fail for me. First it was an assertion
failure:

/home/vmiklos/git/libreoffice/core/vcl/source/window/window.cxx:3186: void 
vcl::Window::SetLOKNotifier(const vcl::ILibreOfficeKitNotifier*, bool): 
Assertion `pNotifier' failed.

Once ScDocShell::CheckConfigOptions() is changed to pass in the view
shell explicitly, the next error is:

kit-26201-26149 2024-02-28 10:41:31.659255 +0100 [ kitbroker_002 ] ERR  
non-async dialog triggered

So convert it to async, similar to the chart2/ hunk of commit
4b33e878a446b0bcdb1d5f882a05a256967eea54 (Make format condition, chart
delete and pivot table error async, 2024-01-10).

Change-Id: I159278b24db0acd5fddb6f4d29dae9a35321e614
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164178
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sc/source/ui/docshell/docsh6.cxx b/sc/source/ui/docshell/docsh6.cxx
index eeb35327b333..9b3dd1f4a9ae 100644
--- a/sc/source/ui/docshell/docsh6.cxx
+++ b/sc/source/ui/docshell/docsh6.cxx
@@ -499,10 +499,10 @@ void ScDocShell::CheckConfigOptions()
 ScTabViewShell* pViewShell = GetBestViewShell();
 if (pViewShell)
 {
-std::unique_ptr 
xInfoBox(Application::CreateMessageDialog(pViewShell->GetFrameWeld(),
+std::shared_ptr 
xInfoBox(Application::CreateMessageDialog(pViewShell->GetFrameWeld(),
   
VclMessageType::Info, VclButtonsType::Ok,
-  
ScResId(STR_OPTIONS_WARN_SEPARATORS)));
-xInfoBox->run();
+  
ScResId(STR_OPTIONS_WARN_SEPARATORS), pViewShell));
+xInfoBox->runAsync(xInfoBox, [] (int) {});
 }
 
 // For now, this is the only option setting that could launch info

[Bug 120883] [META] Hyphenation bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120883
Bug 120883 depends on bug 126635, which changed state.

Bug 126635 Summary: HYPHENATION: Writer doesn't break the line correctly after 
closing double quotation mark and semicolon
https://bugs.documentfoundation.org/show_bug.cgi?id=126635

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 126635] HYPHENATION: Writer doesn't break the line correctly after closing double quotation mark and semicolon

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126635

João Paulo  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |---
 Status|RESOLVED|REOPENED

--- Comment #14 from João Paulo  ---
I am reopening this bug, as it is not fixed as I thought before.

I believe that when we use cross-references or any fields containing texts, the
double quotation mark is somehow "glued" to the field, but the semi-colon goes
to the next line, instead of Writer breaking the line before the last sillable.

Just open the "Source ODT" file attached to this bug and you'll see the result
is still the same as the PDF attached.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159569] Conditional Formatting dialog's fields are out of view when long message appears

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159569

--- Comment #6 from Gwenaël Q.  ---
Happened to me today.
Win 11 libo 7.6.5.2 and the previous version thad I had (7.6.2 or something
like that), French version.

bug is triggered when inputting a letter OR deleting something in that field

Wanted to share a gif screen capture I did but I realize it does not show more
than the attachment already there.

Thanks for listening

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159989] The now default inline Visual edit mode 'InlineEditEnable' for sm formula editor is poorly documented

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159989

V Stuart Foote  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de,
   ||sdc.bla...@youmail.dk,
   ||vsfo...@libreoffice.org
 Blocks||39750
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||9987

--- Comment #1 from V Stuart Foote  ---
Looks like we've never given any coverage to the Visual mode editor in the Math
Guide releases. So complete from scratch...


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=39750
[Bug 39750] [META] General Math formula editor improvements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159987] Math settings only available if launched as standalone app

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159987

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||9989

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 39750] [META] General Math formula editor improvements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=39750

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||159989


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=159989
[Bug 159989] The now default inline Visual edit mode 'InlineEditEnable' for sm
formula editor is poorly documented
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159989] New: The now default inline Visual edit mode 'InlineEditEnable' for sm formula editor is poorly documented

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159989

Bug ID: 159989
   Summary: The now default inline Visual edit mode
'InlineEditEnable' for sm formula editor is poorly
documented
   Product: LibreOffice
   Version: 24.2.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: vsfo...@libreoffice.org
CC: olivier.hal...@libreoffice.org

The inline Visual editor for the sm Formula editor module was "graduated" from
experimental at 24.2.0 [1] and includes a 'Settings' panel toggle, and an
expert configuration stanza 'InlineEditEnable' toggle, for what is now the
default for OLE formulas in other LO modules as well as the sm Formula editor.

Unfortunately, the Visual edit mode was never documented while in dev
experimental mode, and can be a bit jarring.

Some documentation effort is needed for this new 24.2 release default feature.

=-ref-=
[1] https://gerrit.libreoffice.org/c/core/+/156486

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 132584] Building cppunit with/for Visual Studio 2017/2019

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132584

--- Comment #2 from Sergey  ---
Hello everyone, if you are also a betting enthusiast I would recommend you to
check out the review on https://melbetlk.com/ I am new to this and thanks to
this review registration was surprisingly quick and easy. There were no
unnecessary hoops to jump through - just a seamless process that had me up and
running in no time. Melbetlk understands that my time is valuable, and they
ensured that signing up was a breeze, allowing me to focus on what matters most
- the thrill of the game. I highly recommend everyone to check out this review

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159988] New: LibreOffice 24.2.x can't import python binary

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159988

Bug ID: 159988
   Summary: LibreOffice 24.2.x can't import python binary
   Product: LibreOffice
   Version: 24.2.1.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Extensions
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: prrv...@gmail.com

Description:
I use Python packages providing binary files in my extensions:
- cffi
- ijson
- lxml

To package these 3 python libraries in the extension I just need to put a copy
of the library in the pythonpath folder of the extension with all the binary
files for all the different architectures.

It worked perfectly with LibreOffice 5.x, 6.x and 7.x on Windows and Linux, it
works with LibreOffice 24.2.1.2 on Windows 10.

With LibreOffice 24.2.x under Linux this no longer seems possible.

Steps to Reproduce:
1.Try to install the OAuth2OOo extension [1] with 24.2.x on Linux
2.During installation an error occurs when importing the lxml module
3.Installation is interrupted

Actual Results:
Unable to install python packages with binaries under LibreOffice 24.2.x on
Linux

Expected Results:
Be able to install python packages with binaries under LibreOffice 24.2.x on
Linux



Reproducible: Always


User Profile Reset: No

Additional Info:
[1] https://prrvchr.github.io/OAuth2OOo/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 39750] [META] General Math formula editor improvements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=39750

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||159987


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=159987
[Bug 159987] Math settings only available if launched as standalone app
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159987] Math settings only available if launched as standalone app

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159987

V Stuart Foote  changed:

   What|Removed |Added

 Blocks||39750
 Ever confirmed|0   |1
 CC||vsfo...@libreoffice.org
 Status|UNCONFIRMED |NEW

--- Comment #3 from V Stuart Foote  ---
Also noticed that the associated expert config stanza 'InlineEditEnable'
provided when visual mode was "graduated" from experimental [1] is not quite
right. 

Despite the noted inability to reach the Math module specific options during
OLE edit, the expert config should work from any module via Tools -> Options ->
Open Expert Configuration.

The stanza gets recorded from expert config to user profile
registrymodifications.xcu, but it does not override the value set apparently
*only* from the Tools -> Options -> Math -> Settings dialog.

Seems like the registry value should follow along with both the settings panel
and the expert config stanza. 

=-ref-=
https://gerrit.libreoffice.org/c/core/+/156486


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=39750
[Bug 39750] [META] General Math formula editor improvements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159986] Slide Transition doesn't work for many Transitions (staring with "Tiles") with KDE (Linux)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159986

Rafael Lima  changed:

   What|Removed |Added

Summary|Slide Transition doesn't|Slide Transition doesn't
   |work for many Transitions   |work for many Transitions
   |(staring with "Tiles") with |(staring with "Tiles") with
   |Intel graphic and KDE   |KDE (Linux)
   |(Linux) |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159987] Math settings only available if launched as standalone app

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159987

--- Comment #2 from RGB  ---
(In reply to Rafael Lima from comment #1)
> Other apps such as Writer and Calc also have their own entries available
> only when the application is running.

The problem here is that you cannot see the menu even when you are within a
Math object if on "OLE mode."

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159986] Slide Transition doesn't work for many Transitions (staring with "Tiles") with Intel graphic and KDE (Linux)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159986

Rafael Lima  changed:

   What|Removed |Added

   Keywords||bibisectRequest
 Blocks||103704


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103704
[Bug 103704] [META] Slide transition bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 103704] [META] Slide transition bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103704

Rafael Lima  changed:

   What|Removed |Added

 Depends on||159986


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=159986
[Bug 159986] Slide Transition doesn't work for many Transitions (staring with
"Tiles") with Intel graphic and KDE (Linux)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159986] Slide Transition doesn't work for many Transitions (staring with "Tiles") with Intel graphic and KDE (Linux)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159986

Rafael Lima  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||rafael.palma.l...@gmail.com
 Status|UNCONFIRMED |NEW

--- Comment #1 from Rafael Lima  ---
I can confirm the issue. The transition "Tiles" and all subsequent options
simply do not work. Nothing happens.

It is not an Intel graphics issue... I'm on a nVidia card and the problem also
happens.

Version: 7.6.5.2 (X86_64) / LibreOffice Community
Build ID: 60(Build:2)
CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Ubuntu package version: 4:7.6.5-0ubuntu0.23.10.1
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159987] Math settings only available if launched as standalone app

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159987

Rafael Lima  changed:

   What|Removed |Added

 CC||rafael.palma.l...@gmail.com

--- Comment #1 from Rafael Lima  ---
Other apps such as Writer and Calc also have their own entries available only
when the application is running.

TBH I don't know why we hide the options for apps that are not running. I would
show them all, all the time. LibreOffice is an office suite, and Tools -
Options should allow to configure the entire office suite, regardless of which
application is running.

Is there any technical issue that prevents showing all options when an
application is not running?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 156865] copying multiple HTML files with tables to Writer causes Writer to go berserk

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=156865

Dieter  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|UNCONFIRMED |RESOLVED

--- Comment #4 from Dieter  ---
(In reply to Robert McClure from comment #3)
> Have not been able to reproduce this bug in v 24.1 or 24.2 and assume that
> it has been repaired.

Thanks for retesting
=> RESOLVED WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159972] LO 7.6 Creates Duplicate / Unwanted Paragraph Direct Formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159972

--- Comment #1 from bugzi...@rhynas.com ---
Additional observations are:

1) Another adverse consequence of this bug is the potential loss of List
levels. For example: 
'Find and Replace' (Ctrl+H) > Other options > enable Paragraph Styles, then
e.g.  Find= 'List 1' Replace= 'List 2' paragraph styles.

The result under LO 7.6 (as before) is a change of the underlying style to
'List 2' but the numbering style of 'List 1' being retained. However all List
levels are changed to level one.  For example: A., A.1, A.1.a. become A., A.,
A. thus losing important document formatting.

LO 7.3 changes Paragraph style correctly and retains the original list Level
values.


2) To aid the identification in LO 7.6 of paragraphs containing Paragraph
Direct Formatting, enable the Spotlight function: 
Show Side Menu (F11) > select Styles button (Alt+2) > select Paragraph Styles
tab > enable Spotlight.

Diagonal background hatching (instead of solid) identifies the paragraphs
containing Direct Formatting making them easier to spot.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159987] New: Math settings only available if launched as standalone app

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159987

Bug ID: 159987
   Summary: Math settings only available if launched as standalone
app
   Product: LibreOffice
   Version: 24.2.1.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Formula Editor
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rgb.m...@gmail.com

The menu Tools → Options → LibreOffice Math → Settings is only available if
Math is launched as standalone application: if you insert a Math object in
Writer and then go to Tools → Options, the LibreOffice Math section is not
present. 

Math is best used as an OLE object inside other documents and not as a
standalone app, so being able to access its settings when used as an OLE object
is very important. That menu offers several options useful for most users, such
as the scale factor in the editor, deactivate the "visual edition" enabled by
default in 24.2, etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: formula/inc include/formula sc/inc sc/qa sc/README.md sc/source

[Balazs Varga (via logerrit)]

 formula/inc/core_resource.hrc  |6 
 include/formula/compiler.hxx   |3 
 include/formula/opcode.hxx |2 
 sc/README.md   |1 
 sc/inc/helpids.h   |1 
 sc/inc/scfuncs.hrc |   12 
 sc/inc/scmatrix.hxx|2 
 sc/qa/extras/scfunctionlistobj.cxx |2 
 sc/qa/unit/data/functions/spreadsheet/fods/filter.fods | 5061 +
 sc/qa/unit/ucalc.cxx   |1 
 sc/source/core/data/funcdesc.cxx   |3 
 sc/source/core/inc/interpre.hxx|1 
 sc/source/core/tool/interpr1.cxx   |  173 
 sc/source/core/tool/interpr4.cxx   |1 
 sc/source/core/tool/parclass.cxx   |1 
 sc/source/core/tool/scmatrix.cxx   |   35 
 sc/source/core/tool/token.cxx  |1 
 sc/source/filter/excel/xlformula.cxx   |3 
 sc/source/filter/oox/formulabase.cxx   |3 
 19 files changed, 5307 insertions(+), 5 deletions(-)

New commits:
commit b0791dd9216224bdb266fd0d8c87df253b6d0583
Author: Balazs Varga 
AuthorDate: Mon Feb 26 16:13:33 2024 +0100
Commit: Balazs Varga 
CommitDate: Fri Mar 1 18:31:35 2024 +0100

tdf#126573 Add Excel2021 array function FILTER to Calc

https://issues.oasis-open.org/browse/OFFICE-4156

TODO: add dynamic arrays would be useful: Older array formulas,
known as legacy array formulas, always return a fixed-size result
- they always spill into the same number of cells. The spilling behavior
described in this topic does not apply to legacy array formulas.

More info about it:

https://support.microsoft.com/en-gb/office/dynamic-array-formulas-and-spilled-array-behavior-205c6b06-03ba-4151-89a1-87a7eb36e531

Related Bug: https://bugs.documentfoundation.org/show_bug.cgi?id=127808

Change-Id: I1c3769ef33fa0207f55e1c96083717c2d90402e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163955
Tested-by: Jenkins
Reviewed-by: Balazs Varga 

diff --git a/formula/inc/core_resource.hrc b/formula/inc/core_resource.hrc
index 60460e93d38b..f0efc468ab6f 100644
--- a/formula/inc/core_resource.hrc
+++ b/formula/inc/core_resource.hrc
@@ -278,6 +278,7 @@ const std::pair 
RID_STRLIST_FUNCTION_NAMES_ENGLISH_ODFF[] =
 { "VLOOKUP" , SC_OPCODE_V_LOOKUP },
 { "COM.MICROSOFT.XLOOKUP" , SC_OPCODE_X_LOOKUP },
 { "HLOOKUP" , SC_OPCODE_H_LOOKUP },
+{ "COM.MICROSOFT.FILTER" , SC_OPCODE_FILTER },
 { "ORG.OPENOFFICE.MULTIRANGE" , SC_OPCODE_MULTI_AREA }, // legacy for 
range list (union)
 { "OFFSET" , SC_OPCODE_OFFSET },
 { "INDEX" , SC_OPCODE_INDEX },
@@ -727,6 +728,7 @@ const std::pair 
RID_STRLIST_FUNCTION_NAMES_ENGLISH_OOXML[] =
 { "VLOOKUP" , SC_OPCODE_V_LOOKUP },
 { "_xlfn.XLOOKUP" , SC_OPCODE_X_LOOKUP },
 { "HLOOKUP" , SC_OPCODE_H_LOOKUP },
+{ "_xlfn._xlws.FILTER" , SC_OPCODE_FILTER },
 { "_xlfn.ORG.OPENOFFICE.MULTIRANGE" , SC_OPCODE_MULTI_AREA }, // legacy 
for range list (union)
 { "OFFSET" , SC_OPCODE_OFFSET },
 { "INDEX" , SC_OPCODE_INDEX },
@@ -1179,6 +1181,7 @@ const std::pair 
RID_STRLIST_FUNCTION_NAMES_ENGLISH_PODF[] =
 { "VLOOKUP" , SC_OPCODE_V_LOOKUP },
 { "XLOOKUP" , SC_OPCODE_X_LOOKUP },
 { "HLOOKUP" , SC_OPCODE_H_LOOKUP },
+{ "FILTER" , SC_OPCODE_FILTER },
 { "MULTIRANGE" , SC_OPCODE_MULTI_AREA },// legacy for range list 
(union)
 { "OFFSET" , SC_OPCODE_OFFSET },
 { "INDEX" , SC_OPCODE_INDEX },
@@ -1632,6 +1635,7 @@ const std::pair 
RID_STRLIST_FUNCTION_NAMES_ENGLISH_API[] =
 { "VLOOKUP" , SC_OPCODE_V_LOOKUP },
 { "XLOOKUP" , SC_OPCODE_X_LOOKUP },
 { "HLOOKUP" , SC_OPCODE_H_LOOKUP },
+{ "FILTER" , SC_OPCODE_FILTER },
 { "MULTIRANGE" , SC_OPCODE_MULTI_AREA },// legacy for range list 
(union)
 { "OFFSET" , SC_OPCODE_OFFSET },
 { "INDEX" , SC_OPCODE_INDEX },  // ?? first character = I ??
@@ -2083,6 +2087,7 @@ const std::pair 
RID_STRLIST_FUNCTION_NAMES_ENGLISH[] =
 { "VLOOKUP" , SC_OPCODE_V_LOOKUP },
 { "XLOOKUP" , SC_OPCODE_X_LOOKUP },
 { "HLOOKUP" , SC_OPCODE_H_LOOKUP },
+{ "FILTER" , SC_OPCODE_FILTER },
 { "MULTIRANGE" , SC_OPCODE_MULTI_AREA },
 { "OFFSET" , SC_OPCODE_OFFSET },
 { "INDEX" , SC_OPCODE_INDEX },
@@ -2515,6 +2520,7 @@ const std::pair 
RID_STRLIST_FUNCTION_NAMES[] =
 { NC_("RID_STRLIST_FUNCTION_NAMES", "VLOOKUP") , SC_OPCODE_V_LOOKUP },
 { NC_("RID_STRLIST_FUNCTION_NAMES", "XLOOKUP") , SC_OPCODE_X_LOOKUP },
 { NC_("RID_STRLIST_FUNCTION_NAMES", "HLOOKUP") , SC_OPCODE_H_LOOKUP },
+{ NC_("RID_STRLIST_FUNCTION_NAMES", "FILTER") , SC_OPCODE_FILTER },
 { NC_("RID_STRLIST_FUNCTION_NAMES", "MULTIRANGE") , 

[Bug 159983] FILEOPEN ODS: Wrong text and cell background color

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159983

--- Comment #4 from Kevin Suo  ---
Oh? It was a bug when the auto text color is unreadable in bug 156182, but it
is not a bug when it is not readable in *this* one...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 149461] OpenGL slide transitions not working properly with kf5 VCL plugin

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149461

Robert Großkopf  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||9986

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159986] Slide Transition doesn't work for many Transitions (staring with "Tiles") with Intel graphic and KDE (Linux)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159986

Robert Großkopf  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||9461

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159986] Slide Transition doesn't work for many Transitions (staring with "Tiles") with Intel graphic and KDE (Linux)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159986

Robert Großkopf  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||5910
   Keywords||regression

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159986] New: Slide Transition doesn't work for many Transitions (staring with "Tiles") with Intel graphic and KDE (Linux)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159986

Bug ID: 159986
   Summary: Slide Transition doesn't work for many Transitions
(staring with "Tiles") with Intel graphic and KDE
(Linux)
   Product: LibreOffice
   Version: 7.3.6.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rob...@familiegrosskopf.de

Created attachment 192891
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192891=edit
Test document for slide transition. Start testing with "Tiles".

With all LO-Versions since LO 7.3.6.2. slide transition don't work for all
transitions starting with transition "Tiles".
Transition works with LO 7.2.5.1 without problems, fails with all newer
versions.

Note: The buggy behavior appears with all versions, which support
Tools → Options → LibreOffice → View → Run Graphics Test
The Graphics Test gives the following result:

Graphics Backend used: qt5svp
Passed Tests : 1
Quirky Tests : 0
Failed Tests : 0
Skipped Tests : 104

Current LO version:
Version: 24.2.1.2 (X86_64) / LibreOffice Community
Build ID: db4def46b0453cc22e2d0305797cf981b68ef5ac
CPU threads: 6; OS: Linux 5.14; UI render: default; VCL: kf5 (cairo+xcb)
Locale: de-DE (de_DE.UTF-8); UI: en-US
Calc: threaded

Running KDE with Intel Graphic.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'distro/collabora/co-24.04' - sc/source

[Marco Cecchetti (via logerrit)]

 sc/source/ui/undo/undotab.cxx |   48 ++
 1 file changed, 48 insertions(+)

New commits:
commit a0c9071c8f2e7d8aa255da21b5f6d85dbf5d34b5
Author: Marco Cecchetti 
AuthorDate: Thu Feb 29 16:09:14 2024 +0100
Commit: Caolán McNamara 
CommitDate: Fri Mar 1 18:18:24 2024 +0100

lok: calc: sheet position not restored on undo a tab insert/delete/move

Change-Id: I34158b267727048e703cf895cbc8e20b81da4944
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164166
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Caolán McNamara 
(cherry picked from commit 46211c06f51f37eeaa61407c1e7681aeb7a9514f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164193

diff --git a/sc/source/ui/undo/undotab.cxx b/sc/source/ui/undo/undotab.cxx
index 8c3cdc1dfdf3..20e40a416e7d 100644
--- a/sc/source/ui/undo/undotab.cxx
+++ b/sc/source/ui/undo/undotab.cxx
@@ -78,6 +78,46 @@ void lcl_OnTabsChanged(const ScTabViewShell* pViewShell, 
const ScDocument& rDoc,
 true /* bGroups */, nTabIndex);
 }
 }
+
+template
+void lcl_MakeJsonArray(tools::JsonWriter& rJson, const std::vector& v, 
const char *pArrayName)
+{
+if (!v.empty())
+{
+auto jsonArray = rJson.startArray(pArrayName);
+std::stringstream ss;
+for (std::size_t i = 0; i < v.size(); ++i)
+{
+SCTAB tabIndex = v[i];
+ss << tabIndex;
+if (i < v.size() - 1)
+ss << ",";
+ss << " ";
+}
+if (!ss.str().empty())
+rJson.putRaw(ss.str());
+}
+}
+
+void lcl_UndoCommandResult(const ScTabViewShell* pViewShell,
+   const char *pCmdName, const char *pCmdType,
+   const std::vector* pNewTabs,
+   const std::vector* pOldTabs = nullptr)
+{
+tools::JsonWriter aJson;
+aJson.put("commandName", pCmdName);
+aJson.put("success", true);
+{
+auto result = aJson.startNode("result");
+aJson.put("type", pCmdType);
+if (pNewTabs)
+lcl_MakeJsonArray(aJson, *pNewTabs, "newTabs");
+if (pOldTabs)
+lcl_MakeJsonArray(aJson, *pOldTabs, "oldTabs");
+}
+
+pViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_UNO_COMMAND_RESULT, 
aJson.finishAndGetAsOString());
+}
 }
 
 ScUndoInsertTab::ScUndoInsertTab( ScDocShell* pNewDocShell,
@@ -141,6 +181,9 @@ void ScUndoInsertTab::Undo()
 {
 ScDocument& rDoc = pDocShell->GetDocument();
 lcl_OnTabsChanged(pViewShell, rDoc, nTab);
+std::vector aTabs{nTab};
+lcl_UndoCommandResult(pViewShell, ".uno:Undo", "ScUndoInsertTab", 
);
+
 }
 
 //  SetTabNo(...,sal_True) for all views to sync with drawing layer pages
@@ -171,6 +214,8 @@ void ScUndoInsertTab::Redo()
 {
 ScDocument& rDoc = pDocShell->GetDocument();
 lcl_OnTabsChanged(pViewShell, rDoc, nTab);
+std::vector aTabs{nTab};
+lcl_UndoCommandResult(pViewShell, ".uno:Redo", "ScUndoInsertTab", 
);
 }
 }
 
@@ -394,6 +439,7 @@ void ScUndoDeleteTab::Undo()
 if (comphelper::LibreOfficeKit::isActive() && !theTabs.empty())
 {
 lcl_OnTabsChanged(pViewShell, rDoc, theTabs[0]);
+lcl_UndoCommandResult(pViewShell, ".uno:Undo", "ScUndoDeleteTab", 
);
 }
 
 for(SCTAB nTab: theTabs)
@@ -432,6 +478,7 @@ void ScUndoDeleteTab::Redo()
 {
 ScDocument& rDoc = pDocShell->GetDocument();
 lcl_OnTabsChanged(pViewShell, rDoc, theTabs[0]);
+lcl_UndoCommandResult(pViewShell, ".uno:Redo", "ScUndoDeleteTab", 
);
 }
 
 //  SetTabNo(...,sal_True) for all views to sync with drawing layer pages
@@ -589,6 +636,7 @@ void ScUndoMoveTab::DoChange( bool bUndo ) const
 const auto oldTabsMinIt = std::min_element(mpOldTabs->begin(), 
mpOldTabs->end());
 SCTAB nTab = std::min(*newTabsMinIt, *oldTabsMinIt);
 lcl_OnTabsChanged(pViewShell, rDoc, nTab, true /* bInvalidateTiles */);
+lcl_UndoCommandResult(pViewShell, bUndo ? ".uno:Undo" : ".uno:Redo", 
"ScUndoMoveTab", mpOldTabs.get(), mpNewTabs.get());
 }
 
 SfxGetpApp()->Broadcast( SfxHint( SfxHintId::ScTablesChanged ) );// 
Navigator

[Bug 159983] FILEOPEN ODS: Wrong text and cell background color

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159983

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |NOTABUG
 Status|UNCONFIRMED |RESOLVED

--- Comment #3 from Heiko Tietze  ---
Yes, intentionally done for bug 156182.

(In reply to Kevin Suo from comment #0)
> Good in 7.6 branch.
Bad in 7.6 because of low contrast ;-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 115515] Manage changes dialog should allow action on all filtered changes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115515

Eyal Rozenberg  changed:

   What|Removed |Added

 Resolution|INVALID |WORKSFORME
 Status|RESOLVED|VERIFIED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158945] Calc: crash when entering text in a cell

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158945

--- Comment #35 from gpapo...@gmail.com ---
I just posted the WORKING version.
The previous version was not working.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 45315] [UI] Some relation elements (precedes and following) shown with different font

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=45315

--- Comment #18 from john david  ---
Upgrade WhatsApp chatting with MBWhatsApp APK Download. Get cool privacy tools,
unlimited themes, scheduled texts, anti-revoke and more awesome features.
Latest version for Android/iOS for MBios. Customize to next level! Easy
download.[url=https://mbwhats.com]MBWhatsApp actualizar[/url]

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158945] Calc: crash when entering text in a cell

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158945

--- Comment #34 from gpapo...@gmail.com ---
Here it is
RenderMethod: vulkan
Vendor: 0x8086
Device: 0xa7a0
API: 1.3.275
Driver: 0.405.1237
DeviceType: integrated
DeviceName: Intel(R) Iris(R) Xe Graphics
Denylisted: no

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 99969] COPYING cells containing a chart and pasting as embedded spreadsheet doesn't copy the data chart (comment 14)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99969

--- Comment #15 from Mike Kaganski  ---
(In reply to Stéphane Guillou (stragu) from comment #14)

Oh, fun.
My change made the previous problem "fail correctly": previously, it
misinterpreted the DBL_MIN value (2.2250738585072014e-308) as 0, and the chart
showed these zeroes. After 1782810f886acd26db211d8fdd7ae8796d203c57, the value
is recognized correctly, and as it is used in chart to denote empty cells, all
the data is "empty" -> the chart is shown completely empty (actually, since
some other change, not shown at all).

The only thing that is needed here is passing the values (the
inherited-from-OOo problem). I will try to find the original problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.