[Bug 160165] UI: Wrong description for Keyboard Shortcuts "insert Time/Date"
https://bugs.documentfoundation.org/show_bug.cgi?id=160165 --- Comment #5 from Stéphane Guillou (stragu) --- (In reply to ady from comment #4) > @stragu, as you can read in comment 2, the "real" problem is not just with > German keyboard layout or with German UI or in the way it is presented in > the Customize dialogue. Reports keep showing up in different forms (e.g. the > shortcuts fail in many non-US keyboard layouts). > > Is comment 2 worth repeating/copying in any other report(s)? You're right, but in this case we have to pick one of several potential duplicate targets. I think your analysis is valuable, maybe you can add it to meta bug 107243? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158957] Keyboard inputs handled incorrectly on "end of slide" screen (Wayland)
https://bugs.documentfoundation.org/show_bug.cgi?id=158957 Stéphane Guillou (stragu) changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||stephane.guillou@libreoffic ||e.org --- Comment #7 from Stéphane Guillou (stragu) --- I feel like this might be a duplicate of bug 155920, and maybe the difference between your main OS test and your VM test is multi-monitor vs single monitor? Please test version 24.2 and let us know if it is indeed resolved. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160105] Infinite hang/freeze after pressing delete with a floating table below
https://bugs.documentfoundation.org/show_bug.cgi?id=160105 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=16 ||0493 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160493] Crash with floating table when changing to specific font size
https://bugs.documentfoundation.org/show_bug.cgi?id=160493 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=16 ||0105 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160242] Enhancement: Make possible 2 or more impress in fullscreen each on a dedicated monitor AND each seekable indipendently with user-defined hotkeys per each file.
https://bugs.documentfoundation.org/show_bug.cgi?id=160242 Stéphane Guillou (stragu) changed: What|Removed |Added Keywords||needsUXEval Whiteboard| QA:needsComment| CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||stephane.guillou@libreoffic ||e.org Version|unspecified |Inherited From OOo Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from Stéphane Guillou (stragu) --- There is a lot to the request: A. ability to run two presentations at the same time: already possible, when different files are open at the same time. B. change slides independently: already possible, but the presentation needs to be focused. So one would need to Alt + Tab to get to the right one. Or use the Impress Remote for one of them. Alternatively, since 7.6, we have the on-screen Navigation Panel that can be used with the mouse, so no need to Alt + Tab: https://wiki.documentfoundation.org/ReleaseNotes/7.6#Impress_&_Draw C. change slides for different slideshows using different shortcuts for unlimited number of presentation: not possible currently, but I can't see how separate windows would catch shortcuts at the same time... D. (dependent on C) save shortcuts per file In my view: - A and B are already covered - C is somewhat covered for two presentations (or for any number when using the Navigation Panel with the mouse) - D is outright feature creep What do you think? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160242] Enhancement: Make possible 2 or more impress in fullscreen each on a dedicated monitor AND each seekable indipendently with user-defined hotkeys per each file.
https://bugs.documentfoundation.org/show_bug.cgi?id=160242 Stéphane Guillou (stragu) changed: What|Removed |Added Keywords||needsUXEval Whiteboard| QA:needsComment| CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||stephane.guillou@libreoffic ||e.org Version|unspecified |Inherited From OOo Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from Stéphane Guillou (stragu) --- There is a lot to the request: A. ability to run two presentations at the same time: already possible, when different files are open at the same time. B. change slides independently: already possible, but the presentation needs to be focused. So one would need to Alt + Tab to get to the right one. Or use the Impress Remote for one of them. Alternatively, since 7.6, we have the on-screen Navigation Panel that can be used with the mouse, so no need to Alt + Tab: https://wiki.documentfoundation.org/ReleaseNotes/7.6#Impress_&_Draw C. change slides for different slideshows using different shortcuts for unlimited number of presentation: not possible currently, but I can't see how separate windows would catch shortcuts at the same time... D. (dependent on C) save shortcuts per file In my view: - A and B are already covered - C is somewhat covered for two presentations (or for any number when using the Navigation Panel with the mouse) - D is outright feature creep What do you think? -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 160256] Support marking text as having an undetermined language (ISO 639-2 "und" code)
https://bugs.documentfoundation.org/show_bug.cgi?id=160256 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=16 ||0249 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160249] Support marking text as having an arbitrary language
https://bugs.documentfoundation.org/show_bug.cgi?id=160249 Stéphane Guillou (stragu) changed: What|Removed |Added Severity|normal |enhancement See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=16 ||0256 CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||stephane.guillou@libreoffic ||e.org Keywords||needsUXEval Whiteboard| QA:needsComment| --- Comment #2 from Stéphane Guillou (stragu) --- UX/Design team, what do you think? We already have "no language", and bug 160256 asks for the "undetermined" code. Seems to me like very niche use case. Maybe the programming language example talks to me the most: it could be the missing block to allow extensions to deal with "spellchecking" and syntax highlighting on code snippets. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160249] Support marking text as having an arbitrary language
https://bugs.documentfoundation.org/show_bug.cgi?id=160249 Stéphane Guillou (stragu) changed: What|Removed |Added Severity|normal |enhancement See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=16 ||0256 CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||stephane.guillou@libreoffic ||e.org Keywords||needsUXEval Whiteboard| QA:needsComment| --- Comment #2 from Stéphane Guillou (stragu) --- UX/Design team, what do you think? We already have "no language", and bug 160256 asks for the "undetermined" code. Seems to me like very niche use case. Maybe the programming language example talks to me the most: it could be the missing block to allow extensions to deal with "spellchecking" and syntax highlighting on code snippets. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 106221] Use of Javascript for writing Macros and Extensions not documented
https://bugs.documentfoundation.org/show_bug.cgi?id=106221 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org --- Comment #7 from Stéphane Guillou (stragu) --- Just a note that the Rhino editor/debugger is removed with the Rhino 1.7.14 update: 58c4457a902c846229dc3383cc31bbc8f4b3aed9 (to be included in 24.8 release) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 127594] [META] Javascript Macro bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=127594 Bug 127594 depends on bug 118440, which changed state. Bug 118440 Summary: If a javascript macro embedded in a document has errors can't be edited https://bugs.documentfoundation.org/show_bug.cgi?id=118440 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug.
[Bug 118440] If a javascript macro embedded in a document has errors can't be edited
https://bugs.documentfoundation.org/show_bug.cgi?id=118440 Stéphane Guillou (stragu) changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX CC||sberg@gmail.com, ||stephane.guillou@libreoffic ||e.org --- Comment #11 from Stéphane Guillou (stragu) --- Reproduced as described with sample file in: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 069bf61cea5e3aea07ffd5a1bb9f55324651cb35 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: CL threaded However, with 58c4457a902c846229dc3383cc31bbc8f4b3aed9 now merged in trunk (and planned to be included in 24.8 release), the debugger/editor window is gone, so closing as "won't fix". -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160260] Draw PDF import shows message "This PDF file is encrypted and can't be opened." if Windows account contains special character
https://bugs.documentfoundation.org/show_bug.cgi?id=160260 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||3525 -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'distro/collabora/co-23.05' - sc/inc sc/source sc/uiconfig
sc/inc/strings.hrc| 14
sc/source/ui/condformat/condformateasydlg.cxx | 75 --
sc/source/ui/inc/condformateasydlg.hxx|1
sc/uiconfig/scalc/ui/conditionaleasydialog.ui | 28 -
4 files changed, 87 insertions(+), 31 deletions(-)
New commits:
commit b2ae21c9da28d79839c48768e7ed0b2cf734cf30
Author: codewithvk
AuthorDate: Mon Mar 25 22:42:25 2024 +0530
Commit: Tomaž Vajngerl
CommitDate: Wed Apr 3 06:08:49 2024 +0200
Conditional Formatting: Adding More Specified Dialogues
We have added additional single conditional dialogues to enhance the
conditional formatting options for conditions such as duplicates, N elements,
etc.
Signed-off-by: codewithvk
Change-Id: I46d069f259d47739ad1bc859b19513f19d414eb7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165290
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Szymon Kłos
(cherry picked from commit abcb07e2baf2d59904b50e9c20f8a108ab9f17de)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165325
diff --git a/sc/inc/strings.hrc b/sc/inc/strings.hrc
index 2c8bacfb4bea..c11b62fa7d9b 100644
--- a/sc/inc/strings.hrc
+++ b/sc/inc/strings.hrc
@@ -399,9 +399,21 @@
#define STR_CONDITION_NOT_EQUAL
NC_("STR_CONDITION_NOT_EQUAL", "not equal to")
#define STR_CONDITION_BETWEEN
NC_("STR_CONDITION_BETWEEN", "between")
-
+#define STR_CONDITION_NOT_BETWEEN
NC_("STR_CONDITION_NOT_BETWEEN", "not between")
+#define STR_CONDITION_DUPLICATE
NC_("STR_CONDITION_DUPLICATE", "duplicate")
+#define STR_CONDITION_NOT_DUPLICATE
NC_("STR_CONDITION_NOT_DUPLICATE", "not duplicate")
+#define STR_CONDITION_TOP_N_ELEMENTS
NC_("STR_CONDITION_TOP_N_ELEMENTS", "in top N elements")
+#define STR_CONDITION_BOTTOM_N_ELEMENTS
NC_("STR_CONDITION_BOTTOM_N_ELEMENTS", "in bottom N elements")
+#define STR_CONDITION_TOP_N_PERCENT
NC_("STR_CONDITION_TOP_N_PERCENT", "in top N percent")
+#define STR_CONDITION_BOTTOM_N_PERCENT
NC_("STR_CONDITION_BOTTOM_N_PERCENT", "in bottom N percent")
+#define STR_CONDITION_ABOVE_AVERAGE
NC_("STR_CONDITION_ABOVE_AVERAGE", "above average")
+#define STR_CONDITION_BELOW_AVERAGE
NC_("STR_CONDITION_BELOW_AVERAGE", "below average")
+#define STR_CONDITION_ABOVE_OR_EQUAL_AVERAGE
NC_("STR_CONDITION_ABOVE_OR_EQUAL_AVERAGE", "above or equal average")
+#define STR_CONDITION_BELOW_OR_EQUAL_AVERAGE
NC_("STR_CONDITION_BELOW_OR_EQUAL_AVERAGE", "below or equal average")
#define STR_CONDITION_ERROR NC_("STR_CONDITION_ERROR",
"with error ")
#define STR_CONDITION_NOERROR
NC_("STR_CONDITION_NOERROR", "without error ")
+#define STR_CONDITION_BEGINS_WITH
NC_("STR_CONDITION_BEGINS_WITH", "begins with")
+#define STR_CONDITION_ENDS_WITH
NC_("STR_CONDITION_ENDS_WITH", "ends with")
#define STR_CONDITION_CONTAINS_TEXT
NC_("STR_CONDITION_CONTAINS_TEXT", "containing text")
#define STR_CONDITION_NOT_CONTAINS_TEXT
NC_("STR_CONDITION_NOT_CONTAINS_TEXT", "not containing text")
diff --git a/sc/source/ui/condformat/condformateasydlg.cxx
b/sc/source/ui/condformat/condformateasydlg.cxx
index 1fed832b9811..a6f4d2ae23b8 100644
--- a/sc/source/ui/condformat/condformateasydlg.cxx
+++ b/sc/source/ui/condformat/condformateasydlg.cxx
@@ -66,6 +66,7 @@
ConditionalFormatEasyDialog::ConditionalFormatEasyDialog(SfxBindings* pBindings,
, mpDocument(>GetDocument())
, mxNumberEntry(m_xBuilder->weld_entry("entryNumber"))
, mxNumberEntry2(m_xBuilder->weld_entry("entryNumber2"))
+, mxAllInputs(m_xBuilder->weld_container("allInputs"))
, mxRangeEntry(new formula::RefEdit(m_xBuilder->weld_entry("entryRange")))
, mxButtonRangeEdit(new
formula::RefButton(m_xBuilder->weld_button("rbassign")))
, mxStyles(m_xBuilder->weld_combo_box("themeCombo"))
@@ -116,26 +117,62 @@
ConditionalFormatEasyDialog::ConditionalFormatEasyDialog(SfxBindings* pBindings,
SetDescription(ScResId(STR_CONDITION_BETWEEN));
mxNumberEntry2->show();
break;
-// NotBetween
-// Duplicate
-// NotDuplicate
-// Direct
-// Top10
-// Bottom10
-// TopPercent
-// BottomPercent
-// AboveAverage
-// BelowAverage
-// AboveEqualAverage
-// BelowEqualAverage
+case ScConditionMode::NotBetween:
+SetDescription(ScResId(STR_CONDITION_NOT_BETWEEN));
+mxNumberEntry2->show();
+break;
+case ScConditionMode::Duplicate:
+SetDescription(ScResId(STR_CONDITION_DUPLICATE));
+mxAllInputs->hide();
+break;
+case ScConditionMode::NotDuplicate:
+
[Bug 150819] CRASH & assert after a few paste and undo (Assertion failed: (abs(rNode.GetIndex() - pMoveText->pDestNode->GetIndex()) == SwNodeOffset(1)), function SwClientNotify, file txtfrm.cxx, line
https://bugs.documentfoundation.org/show_bug.cgi?id=150819 --- Comment #11 from Kira Tubo --- Created attachment 193453 --> https://bugs.documentfoundation.org/attachment.cgi?id=193453=edit debug error @Noel, also see attached image for error -- You are receiving this mail because: You are the assignee for the bug.
[Bug 150819] CRASH & assert after a few paste and undo (Assertion failed: (abs(rNode.GetIndex() - pMoveText->pDestNode->GetIndex()) == SwNodeOffset(1)), function SwClientNotify, file txtfrm.cxx, line
https://bugs.documentfoundation.org/show_bug.cgi?id=150819 Kira Tubo changed: What|Removed |Added CC||kira.t...@gmail.com --- Comment #10 from Kira Tubo --- Created attachment 193452 --> https://bugs.documentfoundation.org/attachment.cgi?id=193452=edit debug log of assert error. (In reply to Noel Grandin from comment #6) > Never mind, the assert and the crash are from different things, have found > the bug, will post a patch tomorrow @Noel, I'm attempting to write a unit test for this, but I'm running into an issue where errors occur if the bug is reproduced in the dev environment. See attached debug log. May be related to the assert issue that you found. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160276] Writer comment: Author and Date info should use same padding as is used for comment text
https://bugs.documentfoundation.org/show_bug.cgi?id=160276 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160270] Please always write acroform entries as indirect referenced objects
https://bugs.documentfoundation.org/show_bug.cgi?id=160270 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160377] UI: Label Description in the options tab of the in image properties dialog should be Alt-text
https://bugs.documentfoundation.org/show_bug.cgi?id=160377 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160453] LibreOffice Calc crashes when you change the background of the cells to "none".
https://bugs.documentfoundation.org/show_bug.cgi?id=160453 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 154924] FILESAVE shade/gradient slide background, increasing set in automatic mode when saving presentation, not saved desired numberwith
https://bugs.documentfoundation.org/show_bug.cgi?id=154924 --- Comment #5 from QA Administrators --- Dear luan.estevez.d, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160453] LibreOffice Calc crashes when you change the background of the cells to "none".
https://bugs.documentfoundation.org/show_bug.cgi?id=160453 --- Comment #7 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160377] UI: Label Description in the options tab of the in image properties dialog should be Alt-text
https://bugs.documentfoundation.org/show_bug.cgi?id=160377 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Bug 154924] FILESAVE shade/gradient slide background, increasing set in automatic mode when saving presentation, not saved desired numberwith
https://bugs.documentfoundation.org/show_bug.cgi?id=154924 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 92099] see forcibly resized page space & font size; is it hacker sabotage? virus or config error
https://bugs.documentfoundation.org/show_bug.cgi?id=92099 --- Comment #8 from QA Administrators --- Dear kenkoym, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157602] EDITING: Cannot move text box on chart
https://bugs.documentfoundation.org/show_bug.cgi?id=157602 --- Comment #6 from QA Administrators --- Dear Jean Gagnon, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157547] FILEOPEN "Write error. The file could not be written"
https://bugs.documentfoundation.org/show_bug.cgi?id=157547 --- Comment #4 from QA Administrators --- Dear Michael Dewsbury, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Bug 154606] TABLE
https://bugs.documentfoundation.org/show_bug.cgi?id=154606 --- Comment #9 from QA Administrators --- Dear Hartwig Mau, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Bug 141214] Border line drawn over content, if line width set in a specific way
https://bugs.documentfoundation.org/show_bug.cgi?id=141214 --- Comment #8 from QA Administrators --- Dear Fabio Z Tessitore, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 71024] FORMATTING: Copy/Paste of callout from Draw to Writer changes callout tail
https://bugs.documentfoundation.org/show_bug.cgi?id=71024 --- Comment #14 from QA Administrators --- Dear AxelF, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 147226] FORMATTING: Cell Style completely lost from imported xlsx
https://bugs.documentfoundation.org/show_bug.cgi?id=147226 --- Comment #4 from QA Administrators --- Dear Yves Maliet, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 147304] UI: Find and replace dialog is opened on wrong monitor in a multiple monitor setup
https://bugs.documentfoundation.org/show_bug.cgi?id=147304 --- Comment #11 from QA Administrators --- Dear HTK300, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 136761] QR code uneditable after reopening document
https://bugs.documentfoundation.org/show_bug.cgi?id=136761 --- Comment #3 from QA Administrators --- Dear jon.tech.uk, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 120903] Dialogs opening on different display (screen)
https://bugs.documentfoundation.org/show_bug.cgi?id=120903 --- Comment #10 from QA Administrators --- Dear Lorenzo, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 101641] Print and About Windows-dialogs appear on other monitor, if LO moved
https://bugs.documentfoundation.org/show_bug.cgi?id=101641 --- Comment #8 from QA Administrators --- Dear ken, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
core.git: basic/source
basic/source/runtime/runtime.cxx | 95 ---
1 file changed, 30 insertions(+), 65 deletions(-)
New commits:
commit f2482fd96eff00b806fae385096531f63f5f2bf5
Author: Mike Kaganski
AuthorDate: Tue Apr 2 23:57:16 2024 +0500
Commit: Mike Kaganski
CommitDate: Wed Apr 3 04:35:10 2024 +0200
Simplify VBALikeToRegexp a bit
This cleans up some unnecessary escaping both
inside and outside [] groups.
Change-Id: I5abcf0fce634f0d8809bf4d318f61b8c8f69a318
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165703
Tested-by: Mike Kaganski
Reviewed-by: Mike Kaganski
diff --git a/basic/source/runtime/runtime.cxx b/basic/source/runtime/runtime.cxx
index 20bbedc9d6f0..b2f493689c0b 100644
--- a/basic/source/runtime/runtime.cxx
+++ b/basic/source/runtime/runtime.cxx
@@ -1436,99 +1436,64 @@ void SbiRuntime::StepGE() { StepCompare( SbxGE );
}
namespace
{
-bool NeedEsc(sal_Unicode cCode)
+OUString VBALikeToRegexp(std::u16string_view sIn)
{
-if(!rtl::isAscii(cCode))
-{
-return false;
-}
-switch(cCode)
-{
-case '.':
-case '^':
-case '$':
-case '+':
-case '\':
-case '|':
-case '{':
-case '}':
-case '(':
-case ')':
-return true;
-default:
-return false;
-}
-}
-
-OUString VBALikeToRegexp(const OUString )
-{
-OUStringBuffer sResult;
-const sal_Unicode *start = rIn.getStr();
-const sal_Unicode *end = start + rIn.getLength();
-
-int seenright = 0;
-
-sResult.append("\A"); // Match at the beginning of the input
+OUStringBuffer sResult("\A"); // Match at the beginning of the input
-while (start < end)
+for (auto start = sIn.begin(), end = sIn.end(); start < end;)
{
-switch (*start)
+switch (auto ch = *start++)
{
case '?':
sResult.append('.');
-start++;
break;
case '*':
sResult.append(".*");
-start++;
break;
case '#':
sResult.append("[0-9]");
-start++;
-break;
-case ']':
-sResult.append('\');
-sResult.append(*start++);
break;
case '[':
-sResult.append(*start++);
-seenright = 0;
-if (start < end && *start == '!')
+sResult.append(ch);
+if (start < end)
{
-sResult.append('^');
-start++;
+if (*start == '!')
+{
+sResult.append('^');
+++start;
+}
+else if (*start == '^')
+sResult.append('\');
}
-while (start < end && !seenright)
+for (bool seenright = false; start < end && !seenright;
++start)
{
switch (*start)
{
case '[':
-case '?':
-case '*':
+case '\':
sResult.append('\');
-sResult.append(*start);
break;
case ']':
-sResult.append(*start);
-seenright = 1;
-break;
-default:
-if (NeedEsc(*start))
-{
-sResult.append('\');
-}
-sResult.append(*start);
+seenright = true;
break;
}
-start++;
+sResult.append(*start);
}
break;
+case '.':
+case '^':
+case '$':
+case '+':
+case '\':
+case '|':
+case '{':
+case '}':
+case '(':
+case ')':
+sResult.append('\');
+[[fallthrough]];
default:
-if (NeedEsc(*start))
-{
-sResult.append('\');
-}
-sResult.append(*start++);
+sResult.append(ch);
}
}
[Bug 160463] Libre Calc locks a file when it's opened in read-only mode via shortcut command.
https://bugs.documentfoundation.org/show_bug.cgi?id=160463 --- Comment #3 from Peter --- To me, it looks rather as a duplicate of Bug 137793. -- You are receiving this mail because: You are the assignee for the bug.
core.git: 2 commits - editeng/source include/editeng include/svl include/svx oox/inc oox/source sd/qa svx/source
editeng/source/editeng/impedit.hxx |9 +
editeng/source/editeng/impedit2.cxx| 22 +++
editeng/source/editeng/impedit3.cxx| 124 ++-
include/editeng/editdata.hxx |4
include/editeng/outliner.hxx |2
include/svl/solar.hrc |2
include/svx/sdtfsitm.hxx | 13 +-
include/svx/svdotext.hxx |6
include/svx/unoshprp.hxx | 16 +-
oox/inc/drawingml/textbodyproperties.hxx |1
oox/source/drawingml/diagram/diagram.cxx | 21 ++-
oox/source/drawingml/textbodypropertiescontext.cxx |5
oox/source/token/properties.txt|2
sd/qa/unit/TextFittingTest.cxx | 12 -
sd/qa/unit/data/xml/n593612_0.xml |4
sd/qa/unit/export-tests-ooxml2.cxx | 16 +-
sd/qa/unit/export-tests-ooxml3.cxx |2
sd/qa/unit/import-tests-smartart.cxx | 15 +-
sd/qa/unit/import-tests2.cxx |6
svx/source/svdraw/svdattr.cxx |5
svx/source/svdraw/svdotext.cxx | 133 +++--
svx/source/svdraw/svdotextdecomposition.cxx|4
svx/source/svdraw/svdotxed.cxx |2
svx/source/unodraw/unoshape.cxx| 48 +--
24 files changed, 261 insertions(+), 213 deletions(-)
New commits:
commit f61ea135430d7b4a1fac7de1e57a1314fbb1b49e
Author: Tomaž Vajngerl
AuthorDate: Thu Mar 28 12:30:34 2024 +0900
Commit: Tomaž Vajngerl
CommitDate: Wed Apr 3 04:06:50 2024 +0200
editeng: use text scaling that better mimics MSO text scaling
Implement text scaling algorithm that is similar to MSO text
scaling for text boxes for the compatibility purpuse, so that the
Impress slides better match how the PP slides are layed out.
This also moves the implementation into EditEng, where it is
possible to better control how searching for the best scaling
factor is performed without doing additional irrelevant work or
trigger invalidations that should not be triggered.
An additional change is that the paragraph with no content at the
end are ignored, and are not taken into account when determining
the height of the content. This is done for compatibility reasons.
Fix horizontal spacing of tabs - the spacing shouldn't be scaled
and the tab shouldn't include the space at the beginning of the
line.
Change-Id: Ie37fa67f1cf300e915a4ebaef2a7f968bf6c5744
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165441
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/editeng/source/editeng/impedit.hxx
b/editeng/source/editeng/impedit.hxx
index a694196dbade..e09712f74bad 100644
--- a/editeng/source/editeng/impedit.hxx
+++ b/editeng/source/editeng/impedit.hxx
@@ -571,6 +571,7 @@ private:
Color maBackgroundColor;
+ScalingParameters maCustomScalingParameters;
ScalingParameters maScalingParameters;
bool mbRoundToNearestPt;
@@ -657,6 +658,7 @@ private:
voidParaAttribsChanged( ContentNode const * pNode, bool
bIgnoreUndoCheck = false );
voidTextModified();
voidCalcHeight(ParaPortion& rParaPortion);
+bool isInEmptyClusterAtTheEnd(ParaPortion& rParaPortion);
voidInsertUndo( std::unique_ptr pUndo, bool
bTryMerge = false );
voidResetUndoManager();
@@ -977,8 +979,11 @@ public:
void SetMinColumnWrapHeight(tools::Long nVal) { mnMinColumnWrapHeight =
nVal; }
-voidFormatDoc();
-voidFormatFullDoc();
+tools::Long FormatParagraphs(o3tl::sorted_vector&
rRepaintParagraphs);
+void ScaleContentToFitWindow(o3tl::sorted_vector&
rRepaintParagraphs);
+void FormatDoc();
+void FormatFullDoc();
+
voidUpdateViews( EditView* pCurView = nullptr );
voidPaint( ImpEditView* pView, const tools::Rectangle&
rRect, OutputDevice* pTargetDevice );
voidPaint(OutputDevice& rOutDev, tools::Rectangle
aClipRect, Point aStartPos, bool bStripOnly = false, Degree10 nOrientation =
0_deg10);
diff --git a/editeng/source/editeng/impedit2.cxx
b/editeng/source/editeng/impedit2.cxx
index d3f07cec65ed..da4d851b3315 100644
--- a/editeng/source/editeng/impedit2.cxx
+++ b/editeng/source/editeng/impedit2.cxx
@@ -4388,12 +4388,31 @@ tools::Long ImpEditEngine::GetXPos(ParaPortion const&
rParaPortion, EditLine con
return nX;
}
+/** Is true if paragraph is in the empty cluster of paragraphs at the end */
+bool ImpEditEngine::isInEmptyClusterAtTheEnd(ParaPortion& rPortion)
+{
+sal_Int32 nPortion =
[Bug 137303] "This PDF file is encrypted and can't be opened. " when opening any pdf file from Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=137303 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org --- Comment #3 from Stéphane Guillou (stragu) --- Bob, do you remember by any chance if the user account had special characters (like accents) in their user name? See bug 160260. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 154602] Scrolling using keyboard very slow (GTK3) with 4K monitor
https://bugs.documentfoundation.org/show_bug.cgi?id=154602 --- Comment #15 from M. Knepper --- I don't think this should be marked as trivial because, for most people, the slowness of 4k scrolling makes LibreOffice so horrible that it's better to use something else. A bug so bad that it makes you want to use a different program is not trivial. This isn't a severe security thing, but it's still important. I wanted to add an update and say I'm still able to reproduce this bug. I haven't tried the latest packages on Arch, but it still exists on Debian, Ubuntu, and Fedora. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160260] Draw PDF import shows message "This PDF file is encrypted and can't be opened." if Windows account contains special character
https://bugs.documentfoundation.org/show_bug.cgi?id=160260 --- Comment #3 from Stéphane Guillou (stragu) --- To test on Windows, note that you can create a local account without needing an online account by disconnecting from the Internet. Settings > Accounts > Other Users > Add Account. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160461] Cannot change PageUp/PageDown keyboard shortcuts
https://bugs.documentfoundation.org/show_bug.cgi?id=160461 m_a_riosv changed: What|Removed |Added Resolution|--- |WORKSFORME Status|UNCONFIRMED |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 99746] [META] PDF import filter in Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=99746 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||160260 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160260 [Bug 160260] Draw PDF import shows message "This PDF file is encrypted and can't be opened." if Windows account contains special character -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160260] Draw PDF import shows message "This PDF file is encrypted and can't be opened." if Windows account contains special character
https://bugs.documentfoundation.org/show_bug.cgi?id=160260 Stéphane Guillou (stragu) changed: What|Removed |Added Ever confirmed|0 |1 CC||stephane.guillou@libreoffic ||e.org Summary|When opening any pdf file |Draw PDF import shows |in LibreOffice Draw get |message "This PDF file is |message "This PDF file is |encrypted and can't be |encrypted and can't be |opened." if Windows account |opened."|contains special character Blocks||99746 Status|UNCONFIRMED |NEW --- Comment #2 from Stéphane Guillou (stragu) --- Thanks for the report, Aruñas, what a great find! I just tested on Windows 11 and could reproduce, using the account username "Aruñas" as well. Opening a PDF in Draw 24.2 works with account "Quickemu", and comes up as "encrypted" with account "Aruñas". Version: 24.2.1.2 (X86_64) / LibreOffice Community Build ID: db4def46b0453cc22e2d0305797cf981b68ef5ac CPU threads: 4; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded On Ubuntu 22.04 + GNOME 42.9, I was not able to create an account with a special character, so could not reproduce. (I tried "Stéphane" and "Aruñas".) I asked in bug 158718 if their account name also has special characters. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=99746 [Bug 99746] [META] PDF import filter in Draw -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160457] Calculi don't change results when changing the operation.
https://bugs.documentfoundation.org/show_bug.cgi?id=160457 m_a_riosv changed: What|Removed |Added Resolution|FIXED |NOTABUG -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160494] Increase comment (annotations) width in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=160494 m_a_riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg Resolution|--- |NOTABUG Status|UNCONFIRMED |RESOLVED --- Comment #1 from m_a_riosv --- Please take a look into tdf#159851 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160493] Crash with floating table when changing to specific font size
https://bugs.documentfoundation.org/show_bug.cgi?id=160493 m_a_riosv changed: What|Removed |Added Ever confirmed|0 |1 CC||miguelangelrv@libreoffice.o ||rg Status|UNCONFIRMED |NEW Crash report or||https://crashreport.libreof crash signature||fice.org/stats/crash_detail ||s/2aae081f-3599-4d36-9506-8 ||365850dac7b --- Comment #1 from m_a_riosv --- Reproducible Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: c9d4f99b2bb54ac7735b3e0d0cadbafbd0279518 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: default; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Crash at opening with Version: 24.2.2.2 (X86_64) / LibreOffice Community Build ID: d56cc158d8a96260b836f100ef4b4ef25d6f1a01 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded I have tried to resave with Word but no success, still crash at opening. Added crash report signature. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158718] Any PDF import not work and display message "This PDF file is encrypted and can't be opened. "
https://bugs.documentfoundation.org/show_bug.cgi?id=158718 Stéphane Guillou (stragu) changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #14 from Stéphane Guillou (stragu) --- Jun, is what is your Windows account name? Is there an accent in it by any chance? Aruñas reports that it makes a difference for them in bug 160260. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160260] When opening any pdf file in LibreOffice Draw get message "This PDF file is encrypted and can't be opened."
https://bugs.documentfoundation.org/show_bug.cgi?id=160260 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||8718 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158718] Any PDF import not work and display message "This PDF file is encrypted and can't be opened. "
https://bugs.documentfoundation.org/show_bug.cgi?id=158718 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=16 ||0260 OS|All |Windows (All) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160491] In Calc "text to columns" produces two rows out of one row of data
https://bugs.documentfoundation.org/show_bug.cgi?id=160491 m_a_riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #2 from m_a_riosv --- Please attach a sample file. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160139] Header and footer gets removed in Writer and cannot be restored after pasting some text from a shape (steps in comment 2)
https://bugs.documentfoundation.org/show_bug.cgi?id=160139 Stéphane Guillou (stragu) changed: What|Removed |Added CC||tuque-hush...@icloud.com --- Comment #16 from Stéphane Guillou (stragu) --- *** Bug 160263 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160263] Occasionally pasting some unformatted text into Writer hangs LO and deletes the document's formatted header.
https://bugs.documentfoundation.org/show_bug.cgi?id=160263 Stéphane Guillou (stragu) changed: What|Removed |Added Resolution|--- |DUPLICATE Whiteboard| QA:needsComment| Status|UNCONFIRMED |RESOLVED --- Comment #2 from Stéphane Guillou (stragu) --- Thanks for the report! This issue is already tracked in bug 160139, let's mark as duplicate. *** This bug has been marked as a duplicate of bug 160139 *** -- You are receiving this mail because: You are the assignee for the bug.
help.git: source/text
source/text/shared/01/0107.xhp |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 336461782a58266eb90a0c96c6c48a5454fe6b7f Author: Dione Maddern AuthorDate: Tue Apr 2 19:14:25 2024 +0100 Commit: Olivier Hallot CommitDate: Wed Apr 3 02:12:33 2024 +0200 Fix broken help link for File > Save > Encrypt with GPG key Added a HID bookmark to text/shared/01/0107.xhp so that pressing F1 when hovering over "Encrypt with GPG key" opens the correct help page. Added a link to the help page for "Encrypting Documents with OpenPGP". Change-Id: I8ae984be20a1c60be03f3a535855fa6cab8194cc Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165628 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/shared/01/0107.xhp b/source/text/shared/01/0107.xhp index dac1f3aeda..9c957955aa 100644 --- a/source/text/shared/01/0107.xhp +++ b/source/text/shared/01/0107.xhp @@ -77,8 +77,9 @@ + Encrypt with GPG key -Use OpenPGP public keys to encrypt documents. +Use OpenPGP public keys to encrypt documents.
core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 6fd33d50603c2d12c0a1d88edb04c0890b6a1ef1 Author: Dione Maddern AuthorDate: Wed Apr 3 01:12:34 2024 +0100 Commit: Gerrit Code Review CommitDate: Wed Apr 3 02:12:34 2024 +0200 Update git submodules * Update helpcontent2 from branch 'master' to 336461782a58266eb90a0c96c6c48a5454fe6b7f - Fix broken help link for File > Save > Encrypt with GPG key Added a HID bookmark to text/shared/01/0107.xhp so that pressing F1 when hovering over "Encrypt with GPG key" opens the correct help page. Added a link to the help page for "Encrypting Documents with OpenPGP". Change-Id: I8ae984be20a1c60be03f3a535855fa6cab8194cc Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165628 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 6d4d158dee9e..336461782a58 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 6d4d158dee9ef0d47e25b756df24150c7de42773 +Subproject commit 336461782a58266eb90a0c96c6c48a5454fe6b7f
[Bug 160462] F10 key is marked reserved, but doesn't do anything
https://bugs.documentfoundation.org/show_bug.cgi?id=160462 --- Comment #3 from Tyler --- Yes, I found the ReservedKeys table, too, but didn't find any special treatment of plain F10. Shift+F10 works (toggle sidebar docking). F6 and Shift+F6 also work in the sense that the keys are recognized, but the focus cycles only between document canvas, docked sidebar, toolbars. Menubar and floating (i.e. undocked, top-level) windows are left out. Probably Linux-specific. PS: I've checked that F10 isn't gobbled up by the DE. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160497] New: FR: Print (or export) only tracked changes
https://bugs.documentfoundation.org/show_bug.cgi?id=160497
Bug ID: 160497
Summary: FR: Print (or export) only tracked changes
Product: LibreOffice
Version: 7.6.5.2 release
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: enhancement
Priority: medium
Component: Writer
Assignee: libreoffice-bugs@lists.freedesktop.org
Reporter: b...@xenotropic.net
Description:
In Microsoft Word, it is possible to print a list of tracked changes only,
without the rest of the document. See the first point of this blog post, which
gives a screenshot:
https://theopendesk.com/2018/09/19/summarising-tracked-changes-word/comment-page-1/
If there are many changes to a long document, this can help a reviewer quickly
see the edit history: who edited what, and when. Please consider implementing
something similar in Writer.
It would be really awesome if the output was to an ods file (or something else
import-able into Calc), with each edit on a separate line, with columns for
"Author", "Edit Time", "Changed Text","Added/Deleted" (i.e, what happened to
the "Changed Text"), and whatever the best positional information available is
(e.g., character position). That way one could then sort to see the most
salient information: changes in chronological order, changes by a particular
person, changes in document order, etc. That would I suppose have to be some
sort of export, rather than part of the printing functionality.
If you were doing it as a print output, there is similar functionality of
"print comments only" in the "LibreOffice" tab of the print dialog, so if that
were the method you choose (i.e., print rather than export), a
checkbox/dropdown there ("print changes only") would seem most logical UI.
Steps to Reproduce:
n/a
Actual Results:
n/a
Expected Results:
n/a
Reproducible: Always
User Profile Reset: No
Additional Info:
n/a
--
You are receiving this mail because:
You are the assignee for the bug.
core.git: sc/inc
sc/inc/table.hxx |2 --
1 file changed, 2 deletions(-)
New commits:
commit 74e1b694b853b3467ad5c819906a031edf207a10
Author: Andrea Gelmini
AuthorDate: Tue Apr 2 23:02:00 2024 +0200
Commit: Taichi Haradaguchi <20001...@ymail.ne.jp>
CommitDate: Wed Apr 3 01:50:32 2024 +0200
Remove duplicated include
Change-Id: I3255d4a4b4435c092def3c5d17eea27c6f59c491
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165706
Tested-by: Jenkins
Reviewed-by: Taichi Haradaguchi <20001...@ymail.ne.jp>
diff --git a/sc/inc/table.hxx b/sc/inc/table.hxx
index b630c5c6896a..f04b1fa0df7a 100644
--- a/sc/inc/table.hxx
+++ b/sc/inc/table.hxx
@@ -154,8 +154,6 @@ private:
const Iterator maEnd;
};
-#include "SolverSettings.hxx"
-
class ScTable
{
private:
[Bug 160496] Viewport jumps after moving cursor to different style
https://bugs.documentfoundation.org/show_bug.cgi?id=160496 --- Comment #1 from Tyler --- Oh, just forgot to add: The workaround is to set the zoom factor a few percent points off "entire page". -Tyler -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160461] Cannot change PageUp/PageDown keyboard shortcuts
https://bugs.documentfoundation.org/show_bug.cgi?id=160461 --- Comment #2 from Tyler --- Apologies, I've confused myself with the half-dozen or so different functions and got bitten by bug160496. I've now assigned my preferred page movement functions and the assignment works as expected. Please close as NAB. Regards, Tyler -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160495] FILESAVE, FORMATTING
https://bugs.documentfoundation.org/show_bug.cgi?id=160495 --- Comment #1 from ady --- Please attach a _minimal_ sample xls(x) file that shows the problem. Please consider that it will be publicly available. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160346] A huge floating table in header makes Writer hang
https://bugs.documentfoundation.org/show_bug.cgi?id=160346 --- Comment #8 from Patrick Luby (volunteer) --- With the following debug patch, I got attachment #193279 to load. Then, a see a hang for 1 to 2 minutes if I click in an unselected cell (see sample in attachment #193450): diff --git a/sw/source/core/crsr/crsrsh.cxx b/sw/source/core/crsr/crsrsh.cxx index 3e9ca93b3380..52d4093325ef 100644 --- a/sw/source/core/crsr/crsrsh.cxx +++ b/sw/source/core/crsr/crsrsh.cxx @@ -2298,7 +2298,9 @@ void SwCursorShell::UpdateCursor( sal_uInt16 eFlags, bool bIdleEnd ) -m_aCharRect.Width() : m_aCharRect.Height()); } -if( !bFirst && aOld == m_aCharRect ) +// In tdf#160346, the width and height in both rectangles are 1 but +// X is the same, and Y is different. Maybe a pattern? +if( !bFirst && ( aOld == m_aCharRect || ( m_aCharRect.Width() <= 1 && m_aCharRect.Height() <= 1 ) ) ) break; // if the layout says that we are after the 100th iteration still in -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160496] New: Viewport jumps after moving cursor to different style
https://bugs.documentfoundation.org/show_bug.cgi?id=160496 Bug ID: 160496 Summary: Viewport jumps after moving cursor to different style Product: LibreOffice Version: 7.6.5.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: t...@faehnle.net Created attachment 193451 --> https://bugs.documentfoundation.org/attachment.cgi?id=193451=edit Demo document to trigger "jumping viewport" Version: 7.6.5.2 (X86_64) / LibreOffice Community Build ID: 38d5f62f85355c192ef5f1dd47c5c0c0c6d6598b CPU threads: 16; OS: Linux 5.10; UI render: default; VCL: kf5 (cairo+xcb) Locale: de-DE (de_DE.UTF-8); UI: en-US Calc: threaded Hi there, this is a funny one: Cursor movement to a different paragraph or character style seems to trigger a viewport alignment to the closest page break iff the zoom level is set to "entire page". To reproduce: * Load attached document * Set View->Zoom->Entire page * Put the cursor on the line that reads "put cursor here" * Scroll down half a page using the mouse wheel. The gap between first and second document page should be in the middle of the screen. * Move the cursor up and down a few lines, using the arrow keys. Do it slowly, say one keystroke per sec. DON'T leave the visible region with the cursor Observation: When you reach the first "preformatted text" paragraph, the viewport scrolls up so that page 1 is visible in full. This happens with a few tenths of a second delay. Expectation: The viewport should stay where it is. As long as the cursor stays within the visible region, there's no reason for unsolicited viewport movement. According to my observations, the exact styles involved don't matter. It also doesn't seem to matter, how the cursor movement is accomplished: I can trigger this with arrow keys, by mouse clicking, or as a side effect of advancing by pages -- I discovered this bug while experimenting with the different next page/previous page UNO functions. Needless to say that this bug will drive you crazy if you're editing in the vicinity of a page break and happen to touch different para/char styles with the cursor. Cheers, Tyler -- You are receiving this mail because: You are the assignee for the bug.
core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e160bc46b1f51acef3715d3d43ae29842cff54a9 Author: Dione Maddern AuthorDate: Wed Apr 3 00:14:27 2024 +0100 Commit: Gerrit Code Review CommitDate: Wed Apr 3 01:14:27 2024 +0200 Update git submodules * Update helpcontent2 from branch 'master' to 6d4d158dee9ef0d47e25b756df24150c7de42773 - tdf#107081 Update instructions for inserting objects from the Gallery Updated text/shared/guide/gallery_insert.xhp to remove references to obsolete features and update instructions that no longer work. Expanded "Related Topics" section. Deleted: text/shared/guide/dragdrop_fromgallery.xhp text/swriter/guide/insert_graphic_gallery.xhp - because they cover the same subject matter as text/shared/guide/gallery_insert.xhp. Updated AllLangHelp_shared.mk to remove reference to text/shared/guide/dragdrop_fromgallery.xhp. Updated AllLangHelp_swriter.mk to remove reference to text/swriter/guide/insert_graphic_gallery.xhp. Updated auxilliary/shared.tree to redirect any references to text/shared/guide/dragdrop_fromgallery.xhp to text/shared/guide/gallery_insert.xhp. Updated auxilliary/writer.tree to redirect any references to text/swriter/guide/insert_graphic_gallery.xhp text/shared/guide/gallery_insert.xhp. Changed any links to text/shared/guide/dragdrop_fromgallery.xhp in the following files to links to to text/shared/guide/gallery_insert.xhp: text/sdraw/guide/graphic_insert.xhp text/sdraw/guide/main.xhp text/shared/01/gallery.xhp text/shared/guide/dragdrop.xhp text/shared/guide/dragdrop_beamer.xhp text/shared/guide/dragdrop_gallery.xhp text/shared/guide/dragdrop_graphic.xhp text/shared/guide/dragdrop_table.xhp text/shared/guide/main.xhp text/swriter/guide/dragdroptext.xhp Changed any links to text/swriter/guide/insert_graphic_gallery.xhp in the following files to links to to text/shared/guide/gallery_insert.xhp: text/sdraw/guide/graphic_insert.xhp text/shared/guide/insert_bitmap.xhp text/shared/guide/insert_graphic_drawit.xhp text/swriter/guide/insert_graphic.xhp text/swriter/guide/insert_graphic_dialog.xhp text/swriter/guide/insert_graphic_fromchart.xhp text/swriter/guide/insert_graphic_fromdraw.xhp text/swriter/guide/insert_graphic_scan.xhp text/swriter/guide/main.xhp Updated text/shared/01/gallery.xhp to update obsolete instructions. Added "How to Get" instructions for accessing the Gallery with a keyboard shortcut. Added additional keywords to make the page easier to find. Added additional HID bookmarks so that pressing F1 will now open the relevant help page for context menu items in the Gallery. Reorganinzed the article to improve clarity including adding additional headings. Added embed links for additional menu options to provide a more thorough explanation of the Gallery feature. Added an explanation of the "Title" option in the context menu. Removed the "hidden" tag from the description of the "Detailed view" and "Icon view" options. Updated the description of the Insert function in text/shared/00/0010.xhp to reflect how inserting an object from the Gallery currently works. Changed "Background" to "Insert as Background" to better reflect current menu options. Change-Id: Ib510289436a449a1581b2f9b6deacea3f5cfe37c Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165620 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index c2349a58a8e4..6d4d158dee9e 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit c2349a58a8e43f44a796f8e21053f4ca6de6fb4c +Subproject commit 6d4d158dee9ef0d47e25b756df24150c7de42773
help.git: AllLangHelp_shared.mk AllLangHelp_swriter.mk source/auxiliary source/text
AllLangHelp_shared.mk |1 AllLangHelp_swriter.mk|1 source/auxiliary/shared.tree |4 source/auxiliary/swriter.tree |4 source/text/sdraw/guide/graphic_insert.xhp|7 - source/text/sdraw/guide/main.xhp |1 source/text/shared/00/0010.xhp|8 - source/text/shared/01/gallery.xhp | 95 +-- source/text/shared/guide/dragdrop.xhp |2 source/text/shared/guide/dragdrop_beamer.xhp |2 source/text/shared/guide/dragdrop_fromgallery.xhp | 65 -- source/text/shared/guide/dragdrop_gallery.xhp |6 source/text/shared/guide/dragdrop_graphic.xhp |2 source/text/shared/guide/dragdrop_table.xhp |2 source/text/shared/guide/gallery_insert.xhp | 112 ++ source/text/shared/guide/insert_bitmap.xhp|2 source/text/shared/guide/insert_graphic_drawit.xhp|2 source/text/shared/guide/main.xhp |1 source/text/swriter/guide/dragdroptext.xhp|2 source/text/swriter/guide/insert_graphic.xhp |2 source/text/swriter/guide/insert_graphic_dialog.xhp |2 source/text/swriter/guide/insert_graphic_fromdraw.xhp |2 source/text/swriter/guide/insert_graphic_gallery.xhp | 53 source/text/swriter/guide/insert_graphic_scan.xhp |2 source/text/swriter/guide/main.xhp|2 25 files changed, 154 insertions(+), 228 deletions(-) New commits: commit 6d4d158dee9ef0d47e25b756df24150c7de42773 Author: Dione Maddern AuthorDate: Mon Apr 1 14:25:06 2024 +0100 Commit: Olivier Hallot CommitDate: Wed Apr 3 01:14:27 2024 +0200 tdf#107081 Update instructions for inserting objects from the Gallery Updated text/shared/guide/gallery_insert.xhp to remove references to obsolete features and update instructions that no longer work. Expanded "Related Topics" section. Deleted: text/shared/guide/dragdrop_fromgallery.xhp text/swriter/guide/insert_graphic_gallery.xhp - because they cover the same subject matter as text/shared/guide/gallery_insert.xhp. Updated AllLangHelp_shared.mk to remove reference to text/shared/guide/dragdrop_fromgallery.xhp. Updated AllLangHelp_swriter.mk to remove reference to text/swriter/guide/insert_graphic_gallery.xhp. Updated auxilliary/shared.tree to redirect any references to text/shared/guide/dragdrop_fromgallery.xhp to text/shared/guide/gallery_insert.xhp. Updated auxilliary/writer.tree to redirect any references to text/swriter/guide/insert_graphic_gallery.xhp text/shared/guide/gallery_insert.xhp. Changed any links to text/shared/guide/dragdrop_fromgallery.xhp in the following files to links to to text/shared/guide/gallery_insert.xhp: text/sdraw/guide/graphic_insert.xhp text/sdraw/guide/main.xhp text/shared/01/gallery.xhp text/shared/guide/dragdrop.xhp text/shared/guide/dragdrop_beamer.xhp text/shared/guide/dragdrop_gallery.xhp text/shared/guide/dragdrop_graphic.xhp text/shared/guide/dragdrop_table.xhp text/shared/guide/main.xhp text/swriter/guide/dragdroptext.xhp Changed any links to text/swriter/guide/insert_graphic_gallery.xhp in the following files to links to to text/shared/guide/gallery_insert.xhp: text/sdraw/guide/graphic_insert.xhp text/shared/guide/insert_bitmap.xhp text/shared/guide/insert_graphic_drawit.xhp text/swriter/guide/insert_graphic.xhp text/swriter/guide/insert_graphic_dialog.xhp text/swriter/guide/insert_graphic_fromchart.xhp text/swriter/guide/insert_graphic_fromdraw.xhp text/swriter/guide/insert_graphic_scan.xhp text/swriter/guide/main.xhp Updated text/shared/01/gallery.xhp to update obsolete instructions. Added "How to Get" instructions for accessing the Gallery with a keyboard shortcut. Added additional keywords to make the page easier to find. Added additional HID bookmarks so that pressing F1 will now open the relevant help page for context menu items in the Gallery. Reorganinzed the article to improve clarity including adding additional headings. Added embed links for additional menu options to provide a more thorough explanation of the Gallery feature. Added an explanation of the "Title" option in the context menu. Removed the "hidden" tag from the description of the "Detailed view" and "Icon view" options. Updated the description of the Insert function in text/shared/00/0010.xhp to reflect how inserting an object from the Gallery currently works. Changed "Background" to "Insert as Background" to better reflect current menu options.
[Bug 160346] A huge floating table in header makes Writer hang
https://bugs.documentfoundation.org/show_bug.cgi?id=160346 Patrick Luby (volunteer) changed: What|Removed |Added CC||guibomac...@gmail.com --- Comment #7 from Patrick Luby (volunteer) --- Created attachment 193450 --> https://bugs.documentfoundation.org/attachment.cgi?id=193450=edit Sample of LibreOffice after .docx finally loads and then hangs -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157203] CRASH when reset drawing object area fill to NONE
https://bugs.documentfoundation.org/show_bug.cgi?id=157203 --- Comment #25 from Matt K --- No repro with following daily build: Version: 7.6.7.0.0+ (X86_64) / LibreOffice Community Build ID: d6d502f41346b021d369c27c9ed969d75d680986 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'libreoffice-24-2' - desktop/source
desktop/source/deployment/registry/configuration/dp_configuration.cxx |8
++--
1 file changed, 6 insertions(+), 2 deletions(-)
New commits:
commit 27279b82c4e98271db9e999200c70ee8cba11c38
Author: Patrick Luby
AuthorDate: Tue Apr 2 10:38:58 2024 -0400
Commit: Adolfo Jayme Barrientos
CommitDate: Wed Apr 3 00:01:01 2024 +0200
tdf#159790 eliminate deadlock on main thread
A separate thread may have already acquired m_aMutex and that
thread will then try to acquire the solar mutex. However, when
the main thread calls this method, the main thread has already
acquired the solar mutex.
So, drop the desktop mutex before calling out.
Change-Id: Ic87063266ac5101b866df9f24067a403e1417745
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165682
Reviewed-by: Patrick Luby
Tested-by: Jenkins
Reviewed-by: Noel Grandin
(cherry picked from commit 89e23bb599104d3bde30878148e15cf4deb1593f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165629
Reviewed-by: Adolfo Jayme Barrientos
diff --git
a/desktop/source/deployment/registry/configuration/dp_configuration.cxx
b/desktop/source/deployment/registry/configuration/dp_configuration.cxx
index 622814248670..ceba81f9470a 100644
--- a/desktop/source/deployment/registry/configuration/dp_configuration.cxx
+++ b/desktop/source/deployment/registry/configuration/dp_configuration.cxx
@@ -654,7 +654,7 @@ OUString replaceOrigin(
void BackendImpl::PackageImpl::processPackage_(
-::osl::ResettableMutexGuard &,
+::osl::ResettableMutexGuard & guard,
bool doRegisterPackage,
bool startup,
::rtl::Reference const &,
@@ -689,7 +689,10 @@ void BackendImpl::PackageImpl::processPackage_(
if ((that->m_eContext != Context::Bundled && !startup)
|| comphelper::LibreOfficeKit::isActive())
{
-if (m_isSchema)
+bool bIsSchema = m_isSchema;
+// tdf#159790 prevent lock-ordering deadlock, the code below
might acquire the solar mutex
+guard.clear();
+if (bIsSchema)
{
css::configuration::Update::get(
that->m_xComponentContext)->insertExtensionXcsFile(
@@ -701,6 +704,7 @@ void BackendImpl::PackageImpl::processPackage_(
that->m_xComponentContext)->insertExtensionXcuFile(
that->m_eContext == Context::Shared,
expandUnoRcUrl(url));
}
+guard.reset();
}
that->addToConfigmgrIni( m_isSchema, true, url, xCmdEnv );
data.iniEntry = dp_misc::makeRcTerm(url);
[Bug 160495] New: FILESAVE, FORMATTING
https://bugs.documentfoundation.org/show_bug.cgi?id=160495 Bug ID: 160495 Summary: FILESAVE, FORMATTING Product: LibreOffice Version: 24.2.2.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: s.un...@checkpointmedia.com Created attachment 193449 --> https://bugs.documentfoundation.org/attachment.cgi?id=193449=edit no line brake after reopening an xls or xlsx file I found an almmost idential post of the issue from Jan '15 here: https://ask.libreoffice.org/t/calc-text-carriage-return-disappears-upon-re-open/11384 I too, have combined cells that have “text” cell-formatting. There is an auto carriage return for the text, depending on cell size. This used to work for like a decade, but lately, When I save this document in the latest two LO versions as .xlsx or .xls, and then close then reopen the file, all the carriage returns disappear. There's no problem as long as one keeps the file open. It saves and reopens with formatting OK in .odf, however this document is being worked on by other users running Excel on Mac and Win so going that route is no option. The last version I know of, not rendering this problem is 7.6.4. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 75057] [META] OOXML Chart object issues
https://bugs.documentfoundation.org/show_bug.cgi?id=75057 Bug 75057 depends on bug 78027, which changed state. Bug 78027 Summary: FILEOPEN: Importing of Excel files with non-uniform formated diagram title https://bugs.documentfoundation.org/show_bug.cgi?id=78027 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
core.git: chart2/qa chart2/source include/oox oox/source xmloff/source
chart2/qa/extras/chart2export3.cxx | 70 ++-
chart2/qa/extras/data/xlsx/tdf39052.xlsx |binary
chart2/source/controller/chartapiwrapper/TitleWrapper.cxx | 65 ++
chart2/source/controller/main/ChartController_TextEdit.cxx | 30
chart2/source/inc/TitleHelper.hxx |2
chart2/source/tools/TitleHelper.cxx| 31 +++-
include/oox/export/chartexport.hxx |4
oox/source/export/chartexport.cxx | 81 +
oox/source/export/drawingml.cxx|3
xmloff/source/chart/SchXMLAxisContext.cxx |1
xmloff/source/chart/SchXMLChartContext.cxx |2
xmloff/source/chart/SchXMLExport.cxx |3
12 files changed, 230 insertions(+), 62 deletions(-)
New commits:
commit 55e9a27afd2d6a13cf76b39641bf121c3ec4b45c
Author: Balazs Varga
AuthorDate: Fri Mar 29 23:00:50 2024 +0100
Commit: Balazs Varga
CommitDate: Tue Apr 2 23:27:26 2024 +0200
Related: tdf#39052 - chart ooxml: export formatted chart titles
texts properly to ooxml.
Also adding "FormattedStrings" property for title objects
to simplify the working of character formattings in editable
chart shapes.
TODO: odf import/export
Change-Id: Ie27b4dee72c24fa6a2a4e2a7db8da7fa50eb8937
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165583
Tested-by: Jenkins
Tested-by: Gabor Kelemen
Reviewed-by: Balazs Varga
diff --git a/chart2/qa/extras/chart2export3.cxx
b/chart2/qa/extras/chart2export3.cxx
index e1229b07720c..3d05495eff40 100644
--- a/chart2/qa/extras/chart2export3.cxx
+++ b/chart2/qa/extras/chart2export3.cxx
@@ -447,12 +447,13 @@ CPPUNIT_TEST_FIXTURE(Chart2ExportTest3,
testChartMainWithSubTitle)
xmlDocUniquePtr pXmlDoc = parseExport("xl/charts/chart1.xml");
CPPUNIT_ASSERT(pXmlDoc);
// test properties of title
-assertXPath(pXmlDoc,
"/c:chartSpace/c:chart/c:title/c:tx/c:rich/a:p/a:pPr/a:defRPr"_ostr, "sz"_ostr,
"1300");
-assertXPath(pXmlDoc,
"/c:chartSpace/c:chart/c:title/c:tx/c:rich/a:p/a:pPr/a:defRPr"_ostr, "b"_ostr,
"0");
-assertXPath(pXmlDoc,
"/c:chartSpace/c:chart/c:title/c:tx/c:rich/a:p/a:pPr/a:defRPr"_ostr, "i"_ostr,
"1");
-assertXPath(pXmlDoc,
"/c:chartSpace/c:chart/c:title/c:tx/c:rich/a:p/a:pPr/a:defRPr/a:solidFill/a:srgbClr"_ostr,
"val"_ostr, "f10d0c");
-assertXPath(pXmlDoc,
"/c:chartSpace/c:chart/c:title/c:tx/c:rich/a:p/a:r/a:rPr/a:latin"_ostr,
"typeface"_ostr, "Arial");
-assertXPathContent(pXmlDoc,
"/c:chartSpace/c:chart/c:title/c:tx/c:rich/a:p/a:r/a:t"_ostr, "It is a Maintitle
It is a Subtitle");
+assertXPath(pXmlDoc,
"/c:chartSpace/c:chart/c:title/c:tx/c:rich/a:p[1]/a:pPr/a:defRPr"_ostr,
"sz"_ostr, "1300");
+assertXPath(pXmlDoc,
"/c:chartSpace/c:chart/c:title/c:tx/c:rich/a:p[1]/a:pPr/a:defRPr"_ostr,
"b"_ostr, "0");
+assertXPath(pXmlDoc,
"/c:chartSpace/c:chart/c:title/c:tx/c:rich/a:p[1]/a:pPr/a:defRPr"_ostr,
"i"_ostr, "1");
+assertXPath(pXmlDoc,
"/c:chartSpace/c:chart/c:title/c:tx/c:rich/a:p[1]/a:pPr/a:defRPr/a:solidFill/a:srgbClr"_ostr,
"val"_ostr, "f10d0c");
+assertXPath(pXmlDoc,
"/c:chartSpace/c:chart/c:title/c:tx/c:rich/a:p[1]/a:r/a:rPr/a:latin"_ostr,
"typeface"_ostr, "Arial");
+assertXPathContent(pXmlDoc,
"/c:chartSpace/c:chart/c:title/c:tx/c:rich/a:p[1]/a:r/a:t"_ostr, "It is a
Maintitle");
+assertXPathContent(pXmlDoc,
"/c:chartSpace/c:chart/c:title/c:tx/c:rich/a:p[2]/a:r/a:t"_ostr, "It is a
Subtitle");
assertXPath(pXmlDoc,
"/c:chartSpace/c:chart/c:title/c:spPr/a:solidFill/a:srgbClr"_ostr, "val"_ostr,
"81d41a");
}
@@ -754,6 +755,63 @@ CPPUNIT_TEST_FIXTURE(Chart2ExportTest3, testTdf148142)
CPPUNIT_ASSERT(!aScaleData2.ShiftedCategoryPosition);
}
+CPPUNIT_TEST_FIXTURE(Chart2ExportTest3, testFormattedChartTitles)
+{
+loadFromFile(u"xlsx/tdf39052.xlsx");
+save("Calc Office Open XML");
+xmlDocUniquePtr pXmlDoc = parseExport("xl/charts/chart1.xml");
+CPPUNIT_ASSERT(pXmlDoc);
+
+// Check run level properties [1] - first paragraph
+assertXPath(pXmlDoc,
"/c:chartSpace/c:chart/c:title/c:tx/c:rich/a:p[1]/a:r[1]/a:rPr"_ostr, "b"_ostr,
"1");
+assertXPath(pXmlDoc,
"/c:chartSpace/c:chart/c:title/c:tx/c:rich/a:p[1]/a:r[1]/a:rPr"_ostr,
"sz"_ostr, "1400");
+assertXPath(pXmlDoc,
"/c:chartSpace/c:chart/c:title/c:tx/c:rich/a:p[1]/a:r[1]/a:rPr/a:solidFill/a:srgbClr"_ostr,
"val"_ostr, "ff");
+assertXPath(pXmlDoc,
"/c:chartSpace/c:chart/c:title/c:tx/c:rich/a:p[1]/a:r[1]/a:rPr/a:latin"_ostr,
"typeface"_ostr, "Aptos Narrow");
+assertXPathContent(pXmlDoc,
"/c:chartSpace/c:chart/c:title/c:tx/c:rich/a:p[1]/a:r[1]/a:t"_ostr, "This");
+// Check run level properties [2]
+assertXPath(pXmlDoc,
"/c:chartSpace/c:chart/c:title/c:tx/c:rich/a:p[1]/a:r[2]/a:rPr"_ostr, "b"_ostr,
core.git: chart2/source chart2/uiconfig
chart2/source/controller/dialogs/TitleDialogData.cxx|2
chart2/source/controller/inc/ChartController.hxx|5
chart2/source/controller/inc/SelectionHelper.hxx|1
chart2/source/controller/main/ChartController.cxx |6
chart2/source/controller/main/ChartController_TextEdit.cxx | 93 +++-
chart2/source/controller/main/ChartController_Tools.cxx | 11 +
chart2/source/controller/main/ChartController_Window.cxx| 10 -
chart2/source/controller/main/ControllerCommandDispatch.cxx |6
chart2/source/controller/main/SelectionHelper.cxx |5
chart2/source/controller/sidebar/ChartElementsPanel.cxx |3
chart2/source/inc/TitleHelper.hxx |4
chart2/source/tools/TitleHelper.cxx | 72 ++---
chart2/uiconfig/menubar/menubar.xml |1
chart2/uiconfig/toolbar/toolbar.xml |1
14 files changed, 180 insertions(+), 40 deletions(-)
New commits:
commit 4f994cec388377cc5c2bddb804bd92eb4cd7dc8d
Author: Balazs Varga
AuthorDate: Thu Mar 28 17:55:30 2024 +0100
Commit: Balazs Varga
CommitDate: Tue Apr 2 23:27:03 2024 +0200
tdf#39052 - Chart: make characters formatable in editable chart textshapes
Editable textshapes include main chart title, sub chart title, axis titles.
In chart2 the chart2::XFormattedString and chart2::XFormattedString2 store
the formatted characters from textshapes, so we need to set all the
character
properties from the EditTextObject and need to add them to to the
XFormattedString
array with all the related texts which are formatted individually.
For formatting of the characters the .uno:FontDialog command can be used,
which can be called from the chart menubar, toolbar and with right click
on the text when we are in edit mode in the textshape.
(Note: in the next patch the OOXML export will be fixed.)
Change-Id: I5750a5fe694b384dc6b28e2ef03ac1f2b03957db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165501
Tested-by: Jenkins
Tested-by: Gabor Kelemen
Reviewed-by: Balazs Varga
diff --git a/chart2/source/controller/dialogs/TitleDialogData.cxx
b/chart2/source/controller/dialogs/TitleDialogData.cxx
index 45dda2c897b0..b8f3ed6d9429 100644
--- a/chart2/source/controller/dialogs/TitleDialogData.cxx
+++ b/chart2/source/controller/dialogs/TitleDialogData.cxx
@@ -99,7 +99,7 @@ bool TitleDialogData::writeDifferenceToModel(
TitleHelper::getTitle( static_cast< TitleHelper::eTitleType >(
nN ), xChartModel ) );
if(xTitle.is())
{
-TitleHelper::setCompleteString( aTextList[nN], xTitle,
xContext );
+TitleHelper::setCompleteString( aTextList[nN], xTitle,
xContext, nullptr, true );
bChanged = true;
}
}
diff --git a/chart2/source/controller/inc/ChartController.hxx
b/chart2/source/controller/inc/ChartController.hxx
index d1e95efafac3..737d0cf3768f 100644
--- a/chart2/source/controller/inc/ChartController.hxx
+++ b/chart2/source/controller/inc/ChartController.hxx
@@ -323,6 +323,7 @@ public:
void setDrawMode( ChartDrawMode eMode ) { m_eDrawMode = eMode; }
bool isShapeContext() const;
+bool IsTextEdit() const;
ViewElementListProvider getViewElementListProvider();
DrawModelWrapper* GetDrawModelWrapper();
@@ -484,6 +485,8 @@ private:
void executeDispatch_MoveSeries( bool bForward );
bool EndTextEdit();
+css::uno::Sequence< css::uno::Reference>
GetFormattedTitle(
+const EditTextObject& aEdit, const css::uno::Reference<
css::drawing::XShape >& xShape );
void executeDispatch_View3D();
void executeDispatch_PositionAndSize( const ::css::uno::Sequence<
::css::beans::PropertyValue >* pArgs = nullptr );
@@ -514,7 +517,7 @@ private:
const css::uno::Sequence< css::beans::PropertyValue >& rArgs );
DECL_LINK( DoubleClickWaitingHdl, Timer*, void );
-void execute_DoubleClick( const Point* pMousePixel );
+void execute_DoubleClick( const Point* pMousePixel, bool );
void startDoubleClickWaiting();
void stopDoubleClickWaiting();
diff --git a/chart2/source/controller/inc/SelectionHelper.hxx
b/chart2/source/controller/inc/SelectionHelper.hxx
index ff0e95eee27a..119640bd4300 100644
--- a/chart2/source/controller/inc/SelectionHelper.hxx
+++ b/chart2/source/controller/inc/SelectionHelper.hxx
@@ -39,6 +39,7 @@ public: //methods
bool isResizeableObjectSelected() const;
bool isRotateableObjectSelected( const
rtl::Reference<::chart::ChartModel>& xChartModel ) const;
+bool isTitleObjectSelected() const;
bool isDragableObjectSelected() const;
bool isAdditionalShapeSelected() const;
diff --git a/chart2/source/controller/main/ChartController.cxx
b/chart2/source/controller/main/ChartController.cxx
core.git: chart2/source oox/inc oox/source
chart2/source/view/main/PropertyMapper.cxx |3
chart2/source/view/main/ShapeFactory.cxx| 72 ++--
oox/inc/drawingml/textcharacterproperties.hxx |8 +
oox/source/drawingml/chart/titleconverter.cxx | 11 ++
oox/source/drawingml/textcharacterpropertiescontext.cxx |3
5 files changed, 71 insertions(+), 26 deletions(-)
New commits:
commit f31a8ff9ea15ad81aeac265fce6eafe6342a68b7
Author: Balazs Varga
AuthorDate: Thu Mar 28 17:17:47 2024 +0100
Commit: Balazs Varga
CommitDate: Tue Apr 2 23:26:13 2024 +0200
tdf#78027 - Fix Chart OOXML Import with non-uniform formatted titles
Character formats are disappeared from Chart Title textobjects if they were
formatted non-uniform. In this patch only the OOXML import and the chartview
part will be fixed which make it visible after the import.
(Note: next patch will contain the chart controller part where the
characters
can be formatted during title editing).
Change-Id: I4fb5c3d80b7889935d198e70fb49e2c68108b235
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165500
Tested-by: Jenkins
Tested-by: Gabor Kelemen
Reviewed-by: Balazs Varga
diff --git a/chart2/source/view/main/PropertyMapper.cxx
b/chart2/source/view/main/PropertyMapper.cxx
index c3241049057a..79206624f436 100644
--- a/chart2/source/view/main/PropertyMapper.cxx
+++ b/chart2/source/view/main/PropertyMapper.cxx
@@ -268,7 +268,8 @@ const tPropertyNameMap&
PropertyMapper::getPropertyNameMapForCharacterProperties
{"CharColor","CharColor"},
{"CharContoured","CharContoured"},
{"CharEmphasis", "CharEmphasis"},//the service
style::CharacterProperties describes a property called 'CharEmphasize' which
is nowhere implemented
-
+{"CharEscapement", "CharEscapement"},
+{"CharEscapementHeight", "CharEscapementHeight"},
{"CharFontFamily", "CharFontFamily"},
{"CharFontFamilyAsian", "CharFontFamilyAsian"},
{"CharFontFamilyComplex","CharFontFamilyComplex"},
diff --git a/chart2/source/view/main/ShapeFactory.cxx
b/chart2/source/view/main/ShapeFactory.cxx
index 0e572a7e8dcb..c681c581a7b3 100644
--- a/chart2/source/view/main/ShapeFactory.cxx
+++ b/chart2/source/view/main/ShapeFactory.cxx
@@ -2183,7 +2183,8 @@ rtl::Reference
//set text and text properties
uno::Reference< text::XTextCursor > xTextCursor(
xShape->createTextCursor() );
-if( !xTextCursor.is() )
+uno::Reference< text::XTextCursor > xSelectionCursor(
xShape->createTextCursor() );
+if( !xTextCursor.is() || !xSelectionCursor.is() )
return xShape;
tPropertyNameValueMap aValueMap;
@@ -2232,18 +2233,32 @@ rtl::Reference
//if the characters should be stacked we use only the first
character properties for code simplicity
if( xFormattedString.hasElements() )
{
-OUString aLabel;
-for (const auto& i : xFormattedString)
-aLabel += i->getString();
-aLabel = ShapeFactory::getStackedString( aLabel,
bStackCharacters );
-
-xTextCursor->gotoEnd(false);
-xShape->insertString( xTextCursor, aLabel, false );
-xTextCursor->gotoEnd(true);
-uno::Reference< beans::XPropertySet > xSourceProps(
xFormattedString[0], uno::UNO_QUERY );
-
-PropertyMapper::setMappedProperties( *xShape, xSourceProps
-,
PropertyMapper::getPropertyNameMapForCharacterProperties() );
+size_t nLBreaks = xFormattedString.size() - 1;
+uno::Reference< beans::XPropertySet >
xSelectionProp(xSelectionCursor, uno::UNO_QUERY);
+for (const uno::Reference& rxFS :
xFormattedString)
+{
+if (!rxFS->getString().isEmpty())
+{
+xTextCursor->gotoEnd(false);
+xSelectionCursor->gotoEnd(false);
+OUString aLabel =
ShapeFactory::getStackedString(rxFS->getString(), bStackCharacters);
+if (nLBreaks-- > 0)
+aLabel += OUStringChar(' ');
+xShape->insertString(xTextCursor, aLabel, false);
+xSelectionCursor->gotoEnd(true); // select current
paragraph
+uno::Reference< beans::XPropertySet >
xSourceProps(rxFS, uno::UNO_QUERY);
+if (xFormattedString.size() > 1 && xSelectionProp.is())
+{
+
PropertyMapper::setMappedProperties(xSelectionProp, xSourceProps,
+
PropertyMapper::getPropertyNameMapForTextShapeProperties());
+}
+else
+
core.git: Branch 'libreoffice-7-6' - desktop/source
desktop/source/deployment/registry/configuration/dp_configuration.cxx |8
++--
1 file changed, 6 insertions(+), 2 deletions(-)
New commits:
commit 677b13aa5c695b44ada7a0b11d6c9b91fc38ff51
Author: Patrick Luby
AuthorDate: Tue Apr 2 10:38:58 2024 -0400
Commit: Adolfo Jayme Barrientos
CommitDate: Tue Apr 2 23:22:56 2024 +0200
tdf#159790 eliminate deadlock on main thread
A separate thread may have already acquired m_aMutex and that
thread will then try to acquire the solar mutex. However, when
the main thread calls this method, the main thread has already
acquired the solar mutex.
So, drop the desktop mutex before calling out.
Change-Id: Ic87063266ac5101b866df9f24067a403e1417745
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165682
Reviewed-by: Patrick Luby
Tested-by: Jenkins
Reviewed-by: Noel Grandin
(cherry picked from commit 89e23bb599104d3bde30878148e15cf4deb1593f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165710
Reviewed-by: Adolfo Jayme Barrientos
diff --git
a/desktop/source/deployment/registry/configuration/dp_configuration.cxx
b/desktop/source/deployment/registry/configuration/dp_configuration.cxx
index 622814248670..ceba81f9470a 100644
--- a/desktop/source/deployment/registry/configuration/dp_configuration.cxx
+++ b/desktop/source/deployment/registry/configuration/dp_configuration.cxx
@@ -654,7 +654,7 @@ OUString replaceOrigin(
void BackendImpl::PackageImpl::processPackage_(
-::osl::ResettableMutexGuard &,
+::osl::ResettableMutexGuard & guard,
bool doRegisterPackage,
bool startup,
::rtl::Reference const &,
@@ -689,7 +689,10 @@ void BackendImpl::PackageImpl::processPackage_(
if ((that->m_eContext != Context::Bundled && !startup)
|| comphelper::LibreOfficeKit::isActive())
{
-if (m_isSchema)
+bool bIsSchema = m_isSchema;
+// tdf#159790 prevent lock-ordering deadlock, the code below
might acquire the solar mutex
+guard.clear();
+if (bIsSchema)
{
css::configuration::Update::get(
that->m_xComponentContext)->insertExtensionXcsFile(
@@ -701,6 +704,7 @@ void BackendImpl::PackageImpl::processPackage_(
that->m_xComponentContext)->insertExtensionXcuFile(
that->m_eContext == Context::Shared,
expandUnoRcUrl(url));
}
+guard.reset();
}
that->addToConfigmgrIni( m_isSchema, true, url, xCmdEnv );
data.iniEntry = dp_misc::makeRcTerm(url);
[Bug 157285] FILEOPEN PPTX: Textbox too tall - import needs to look at the shape on the slide instead of the master page
https://bugs.documentfoundation.org/show_bug.cgi?id=157285 Gerald Pfeifer changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #9 from Gerald Pfeifer --- Happy to verify with Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 40d3d510fca99b555381deb74b9915c91c924de5 CPU threads: 12; OS: Linux 6.8; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US There is some follow-up in bug #160490 regarding comment #3 and comment #4 here, but the fundamental issue has been addressed. Thanks! -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 160490] FILEOPEN PPTX Automatically resized textbox is not exactly as tall as in PP
https://bugs.documentfoundation.org/show_bug.cgi?id=160490 Gerald Pfeifer changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #3 from Gerald Pfeifer --- Confirmed with Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 40d3d510fca99b555381deb74b9915c91c924de5 CPU threads: 12; OS: Linux 6.8; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US (In reply to Gabor Kelemen (allotropia) from comment #0) > This is a followup to bug 157285, before it was even more terrible. As the original reporter, I am quite happy about the progress. We've gone from "Ouch" to "Well, a bit of work left". :-) Thanks to Tibor and you! -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160494] Increase comment (annotations) width in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=160494 bilgehan_cagil...@yahoo.com changed: What|Removed |Added Keywords||accessibility CC||bilgehan_cagil...@yahoo.com -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160494] New: Increase comment (annotations) width in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=160494 Bug ID: 160494 Summary: Increase comment (annotations) width in Writer Product: LibreOffice Version: 7.6.6.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: bilgehan_cagil...@yahoo.com Description: This is in reference to the post by sbxjld (https://ask.libreoffice.org/t/increase-comment-annotations-width-in-writer/102950). I was unable to find an enhancement request made by them and took it upon myself to create it instead. As sbxjld descibes, the comments panel in the Writer app can be too narrow for certain situations. It is not rare for me to receive documents featuring long comments or writing long comments. An option to be able to extend the width of this panel/section would help in legibility for documents with a long or dense comments section. Steps to Reproduce: 1. Open LibreOffice Writer 2. Write a sample text 3. Highlight the text 4. right click on the highlighted text 5. select "insert comment" Actual Results: A "comments" tab appears to the right of the page. It is not possible to resize this tab by clicking the sides of the tab on the scale indicator at the top of the application. Similarly, it is not possible to resize this tab through the settings. The tab label on the scale indicator is not right-clickable, meaning this is not a possible method of modification either Expected Results: One of the three following options, or an alternative equally accessible method: - be able to drag the "comments" tab on the scale bar, such that it can resize - be able to right click the tab and select "modify width" from the possible options (if any). - go into settings and enter a new width value for this tab, which will take effect after applying said changes. This option is less preferred but still valid if a modification to the "core engine," as stated by ajlittoz, requires more steps. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.6.6.3 (X86_64) / LibreOffice Community Build ID: d97b2716a9a4a2ce1391dee1765565ea469b0ae7 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: en-US (C); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160106] Floating multipage table rendered (mostly) off-canvas after deleting a row; hiding >30 pages of content
https://bugs.documentfoundation.org/show_bug.cgi?id=160106 --- Comment #7 from Telesto --- (In reply to wjsim from comment #6) No crash for me when simply opening the file. Maybe related to font substitution or something like that? I did fiddle around a little and did find a crash: bug 160493 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160493] Crash with floating table when changing to specific font size
https://bugs.documentfoundation.org/show_bug.cgi?id=160493 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||8344 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158344] FILEOPEN DOCX Crash on opening file
https://bugs.documentfoundation.org/show_bug.cgi?id=158344 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=16 ||0493 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160493] Crash with floating table when changing to specific font size
https://bugs.documentfoundation.org/show_bug.cgi?id=160493 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=16 ||0106 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160106] Floating multipage table rendered (mostly) off-canvas after deleting a row; hiding >30 pages of content
https://bugs.documentfoundation.org/show_bug.cgi?id=160106 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=16 ||0493 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160493] New: Crash with floating table when changing to specific font size
https://bugs.documentfoundation.org/show_bug.cgi?id=160493 Bug ID: 160493 Summary: Crash with floating table when changing to specific font size Product: LibreOffice Version: 24.8.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Crash with floating table when changing to specific font size Steps to Reproduce: 1. Open attachment 191005 (bug 158344 and bug 160106) 2. Place the cursor in the table 3. CTRL+A (2x) 4. Change fontsize to 24 -> Crash Bonus: 5. Change font size to 26 -> Freeze Actual Results: Crash Expected Results: No crash Reproducible: Always User Profile Reset: No Additional Info: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 0020fc1167b3760d0631001689a44427b72b816e CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: nl-NL Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
core.git: sd/source
sd/source/ui/dlg/navigatr.cxx | 51 +-
1 file changed, 36 insertions(+), 15 deletions(-)
New commits:
commit 878ab17b0fad66fb7accd9573ef7f66403d593b9
Author: Jim Raykowski
AuthorDate: Sun Mar 31 13:56:36 2024 -0800
Commit: Jim Raykowski
CommitDate: Tue Apr 2 22:43:45 2024 +0200
tdf#139944 SdNavigator: disable in master mode
Improve where the disable is done and in addition to making disabled
also clear the objects tree.
Also fixes a drag and drop ordering scrolling bug introduced by commit
60e32969a98cad348cf8e55e8f93abc3d6e9c70c
Change-Id: I702c85bc1ba16837fb7f8c2246bdb29d96e6cc6f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165606
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
diff --git a/sd/source/ui/dlg/navigatr.cxx b/sd/source/ui/dlg/navigatr.cxx
index dbea0b6b4818..a329601a2a35 100644
--- a/sd/source/ui/dlg/navigatr.cxx
+++ b/sd/source/ui/dlg/navigatr.cxx
@@ -157,6 +157,24 @@ void SdNavigatorWin::FreshTree( const SdDrawDocument* pDoc
)
{
SdDrawDocument* pNonConstDoc = const_cast(pDoc); // const
as const can...
sd::DrawDocShell* pDocShell = pNonConstDoc->GetDocSh();
+::sd::ViewShell* pViewShell = pDocShell->GetViewShell();
+
+// tdf#139944 disable navigator in master mode
+if (pViewShell)
+{
+if (const sd::DrawViewShell* pDrawViewShell =
static_cast<::sd::DrawViewShell*>(pViewShell))
+{
+if (pDrawViewShell->GetEditMode() == EditMode::MasterPage)
+{
+m_xContainer->set_sensitive(false);
+mxTlbObjects->clear();
+return;
+}
+else
+m_xContainer->set_sensitive(true);
+}
+}
+
const OUString& aDocShName( pDocShell->GetName() );
OUString aDocName = pDocShell->GetMedium()->GetName();
if (!mxTlbObjects->IsEqualToDoc(pDoc))
@@ -165,7 +183,8 @@ void SdNavigatorWin::FreshTree( const SdDrawDocument* pDoc )
RefreshDocumentLB();
mxLbDocs->set_active_text(aDocShName);
}
-if (const sd::ViewShell* pViewShell = pDocShell->GetViewShell())
+
+if (pViewShell)
lcl_select_marked_object(pViewShell, mxTlbObjects.get());
}
@@ -176,6 +195,22 @@ void SdNavigatorWin::InitTreeLB( const SdDrawDocument*
pDoc )
OUString aDocShName( pDocShell->GetName() );
::sd::ViewShell* pViewShell = pDocShell->GetViewShell();
+// tdf#139944 disable navigator in master mode
+if (pViewShell)
+{
+if (const sd::DrawViewShell* pDrawViewShell =
static_cast<::sd::DrawViewShell*>(pViewShell))
+{
+if (pDrawViewShell->GetEditMode() == EditMode::MasterPage)
+{
+m_xContainer->set_sensitive(false);
+mxTlbObjects->clear();
+return;
+}
+else
+m_xContainer->set_sensitive(true);
+}
+}
+
// Restore the 'ShowAllShapes' flag from the last time (in this session)
// that the navigator was shown.
if (pViewShell != nullptr)
@@ -783,20 +818,6 @@ void
SdNavigatorControllerItem::StateChangedAtToolBoxControl( sal_uInt16 nSId,
if( !(pInfo && pInfo->IsActive()) )
return;
-if (::sd::DrawDocShell* pDrawDocShell = pInfo->GetDrawDocShell())
-{
-const auto pDrawViewShell =
-static_cast<::sd::DrawViewShell
*>(pDrawDocShell->GetViewShell());
-if (pDrawViewShell)
-{
-pNavigatorWin->FreshTree(pDrawDocShell->GetDoc());
-bool bEditModePage(pDrawViewShell->GetEditMode() ==
EditMode::Page);
-pNavigatorWin->mxToolbox->set_sensitive(bEditModePage);
-pNavigatorWin->mxLbDocs->set_sensitive(bEditModePage);
-pNavigatorWin->mxTlbObjects->set_sensitive(bEditModePage);
-}
-}
-
const SfxUInt32Item& rStateItem = dynamic_cast(*pItem);
NavState nState = static_cast(rStateItem.GetValue());
[Bug 160377] UI: Label Description in the options tab of the in image properties dialog should be Alt-text
https://bugs.documentfoundation.org/show_bug.cgi?id=160377 --- Comment #3 from Telesto --- (In reply to Haris from comment #2) > Hi Telesto, > > I checked out the "Help" page for the "Options" tab, and it seems like the > names for both "Text" and "Alt Text" were changed to "Text Alternative" and > "Description" respectively in the newer LibreOffice versions. I believe the > "Help" page might be outdated hence the inconsistency. > @Haris/Heiko I Bug 155044 renamed 'Description' field to Alt-Text. This applies to Forms; Shapes; OLE-objects across the applications within the suite. Also for images inserted into Calc have Alt-text The exception being Writer Image dialog (as far I'm aware). Where the 'same' field is called 'Description'. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 147615] PRINTING: macOS Impress print dialog does not provide access to select printer's Paper Size
https://bugs.documentfoundation.org/show_bug.cgi?id=147615 Sierk Bornemann changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||6212 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 146212] Print Preview Dialog: Page Orientation not shown on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=146212 Sierk Bornemann changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||7615 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 145538] Use range based for loops
https://bugs.documentfoundation.org/show_bug.cgi?id=145538 --- Comment #37 from Commit Notification --- RMZeroFour committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/03c9875b873d24d72587ab7d9f3190c7c0cf0e5e tdf#145538 Use range based for loops It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
core.git: cui/source
cui/source/tabpages/numpages.cxx |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
New commits:
commit 03c9875b873d24d72587ab7d9f3190c7c0cf0e5e
Author: RMZeroFour
AuthorDate: Sun Mar 31 19:42:57 2024 +0530
Commit: Michael Weghorn
CommitDate: Tue Apr 2 21:14:12 2024 +0200
tdf#145538 Use range based for loops
As part of the efforts in tdf#145538 to replace regular for
loops with range-based for loops in the codebase where suitable,
this commit does so in SvxNumOptionsTabPage::PageCreated.
PS-2: Renamed a variable.
Change-Id: I7ec813a3c6fead3246137a2841c9f3e80f5adc63
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165594
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/cui/source/tabpages/numpages.cxx b/cui/source/tabpages/numpages.cxx
index cbdf7fc5a23d..447638836add 100644
--- a/cui/source/tabpages/numpages.cxx
+++ b/cui/source/tabpages/numpages.cxx
@@ -3044,9 +3044,8 @@ void SvxNumOptionsTabPage::PageCreated(const
SfxAllItemSet& aSet)
if (pListItem)
{
const std::vector = pListItem->GetList();
-sal_uInt32 nCount = aList.size();
-for(sal_uInt32 i = 0; i < nCount; i++)
-m_xCharFmtLB->append_text(aList[i]);
+for (const auto& rItem : aList)
+m_xCharFmtLB->append_text(rItem);
}
if (pMetricItem)
SetMetric(static_cast(pMetricItem->GetValue()));
core.git: desktop/source
desktop/source/deployment/registry/configuration/dp_configuration.cxx |8
++--
1 file changed, 6 insertions(+), 2 deletions(-)
New commits:
commit 89e23bb599104d3bde30878148e15cf4deb1593f
Author: Patrick Luby
AuthorDate: Tue Apr 2 10:38:58 2024 -0400
Commit: Noel Grandin
CommitDate: Tue Apr 2 21:10:19 2024 +0200
tdf#159790 eliminate deadlock on main thread
A separate thread may have already acquired m_aMutex and that
thread will then try to acquire the solar mutex. However, when
the main thread calls this method, the main thread has already
acquired the solar mutex.
So, drop the desktop mutex before calling out.
Change-Id: Ic87063266ac5101b866df9f24067a403e1417745
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165682
Reviewed-by: Patrick Luby
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git
a/desktop/source/deployment/registry/configuration/dp_configuration.cxx
b/desktop/source/deployment/registry/configuration/dp_configuration.cxx
index 3bfac940bce6..9ef3cc969432 100644
--- a/desktop/source/deployment/registry/configuration/dp_configuration.cxx
+++ b/desktop/source/deployment/registry/configuration/dp_configuration.cxx
@@ -653,7 +653,7 @@ OUString replaceOrigin(
void BackendImpl::PackageImpl::processPackage_(
-::osl::ResettableMutexGuard &,
+::osl::ResettableMutexGuard & guard,
bool doRegisterPackage,
bool startup,
::rtl::Reference const &,
@@ -688,7 +688,10 @@ void BackendImpl::PackageImpl::processPackage_(
if ((that->m_eContext != Context::Bundled && !startup)
|| comphelper::LibreOfficeKit::isActive())
{
-if (m_isSchema)
+bool bIsSchema = m_isSchema;
+// tdf#159790 prevent lock-ordering deadlock, the code below
might acquire the solar mutex
+guard.clear();
+if (bIsSchema)
{
css::configuration::Update::get(
that->m_xComponentContext)->insertExtensionXcsFile(
@@ -700,6 +703,7 @@ void BackendImpl::PackageImpl::processPackage_(
that->m_xComponentContext)->insertExtensionXcuFile(
that->m_eContext == Context::Shared,
expandUnoRcUrl(url));
}
+guard.reset();
}
that->addToConfigmgrIni( m_isSchema, true, url, xCmdEnv );
data.iniEntry = dp_misc::makeRcTerm(url);
core.git: Branch 'libreoffice-24-2' - xmloff/source
xmloff/source/draw/eventimp.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit 3ec777c07ec25e537e5f84095c520100d706370f Author: Caolán McNamara AuthorDate: Wed Mar 27 17:07:20 2024 + Commit: Xisco Fauli CommitDate: Tue Apr 2 21:01:12 2024 +0200 add notify for script use Change-Id: I84af197cec7755f6803a578e1e21c03966ad5f3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165411 Tested-by: Jenkins Reviewed-by: Xisco Fauli diff --git a/xmloff/source/draw/eventimp.cxx b/xmloff/source/draw/eventimp.cxx index 2b8921ee27fa..2a6ce1fa2381 100644 --- a/xmloff/source/draw/eventimp.cxx +++ b/xmloff/source/draw/eventimp.cxx @@ -210,6 +210,9 @@ SdXMLEventContext::SdXMLEventContext( SvXMLImport& rImp, if( maData.mbValid ) maData.mbValid = !sEventName.isEmpty(); + +if (!maData.msMacroName.isEmpty()) +rImp.NotifyMacroEventRead(); } css::uno::Reference< css::xml::sax::XFastContextHandler > SdXMLEventContext::createFastChildContext(
core.git: Branch 'distro/collabora/co-24.04' - sc/source
sc/source/filter/html/htmlpars.cxx | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
New commits:
commit 91dfd7aac814bb47f1bdfc30b882238b42993bf7
Author: Caolán McNamara
AuthorDate: Fri Mar 29 19:53:17 2024 +
Commit: Caolán McNamara
CommitDate: Tue Apr 2 20:46:01 2024 +0200
ofz#67708 ignore oversized colspans
that can't fit in SCCOL
ignore negative colspan and rowspans too
Change-Id: I79a010bcd7d9d84de70f6dac2e09614d6d448227
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165482
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Caolán McNamara
diff --git a/sc/source/filter/html/htmlpars.cxx
b/sc/source/filter/html/htmlpars.cxx
index ede9eaf4912a..80277ae6b71b 100644
--- a/sc/source/filter/html/htmlpars.cxx
+++ b/sc/source/filter/html/htmlpars.cxx
@@ -1042,12 +1042,20 @@ void ScHTMLLayoutParser::TableDataOn( HtmlImportInfo*
pInfo )
{
case HtmlOptionId::COLSPAN:
{
-mxActEntry->nColOverlap =
static_cast(rOption.GetString().toInt32());
+sal_Int32 nColOverlap = rOption.GetString().toInt32();
+if (nColOverlap >= 0 && nColOverlap <= SCCOL_MAX)
+mxActEntry->nColOverlap = static_cast(nColOverlap);
+else
+SAL_WARN("sc", "ScHTMLLayoutParser::TableDataOn ignoring
colspan: " << nColOverlap);
}
break;
case HtmlOptionId::ROWSPAN:
{
-mxActEntry->nRowOverlap =
static_cast(rOption.GetString().toInt32());
+sal_Int32 nRowOverlap = rOption.GetString().toInt32();
+if (nRowOverlap >= 0)
+mxActEntry->nRowOverlap = static_cast(nRowOverlap);
+else
+SAL_WARN("sc", "ScHTMLLayoutParser::TableDataOn ignoring
rowspan: " << nRowOverlap);
}
break;
case HtmlOptionId::ALIGN:
core.git: Branch 'distro/collabora/co-23.05' - sc/source
sc/source/filter/html/htmlpars.cxx |5 +
1 file changed, 5 insertions(+)
New commits:
commit d7f0ffaaae601ec514e722ff99c14d9bf6b999e5
Author: Caolán McNamara
AuthorDate: Thu Mar 28 09:09:00 2024 +
Commit: Caolán McNamara
CommitDate: Tue Apr 2 20:45:32 2024 +0200
ofz: negative column offset
Change-Id: Ieeb06e5c5d28f1c457db369a732bc37a7d5f2be8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165420
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Szymon Kłos
diff --git a/sc/source/filter/html/htmlpars.cxx
b/sc/source/filter/html/htmlpars.cxx
index c90cc1be4ad7..f00e1f868bb6 100644
--- a/sc/source/filter/html/htmlpars.cxx
+++ b/sc/source/filter/html/htmlpars.cxx
@@ -841,6 +841,11 @@ void ScHTMLLayoutParser::SetWidths()
OSL_ENSURE( nCol < nColsPerRow,
"ScHTMLLayoutParser::SetWidths: column overflow" );
if (nCol >= nColsPerRow)
continue;
+if (nCol < 0)
+{
+SAL_WARN("sc", "negative offset: " << nCol);
+continue;
+}
pE->nOffset = pOffsets[nCol];
nCol = nCol + pE->nColOverlap;
if ( nCol > nColsPerRow )
core.git: Branch 'distro/collabora/co-24.04' - sc/source
sc/source/filter/html/htmlpars.cxx |5 +
1 file changed, 5 insertions(+)
New commits:
commit 01e4bcacbefe8c6a6ba4d7627dc7aab412218eb1
Author: Caolán McNamara
AuthorDate: Thu Mar 28 09:09:00 2024 +
Commit: Caolán McNamara
CommitDate: Tue Apr 2 20:45:44 2024 +0200
ofz: negative column offset
Change-Id: Ieeb06e5c5d28f1c457db369a732bc37a7d5f2be8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165421
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Caolán McNamara
diff --git a/sc/source/filter/html/htmlpars.cxx
b/sc/source/filter/html/htmlpars.cxx
index e5bcc4d2891b..ede9eaf4912a 100644
--- a/sc/source/filter/html/htmlpars.cxx
+++ b/sc/source/filter/html/htmlpars.cxx
@@ -837,6 +837,11 @@ void ScHTMLLayoutParser::SetWidths()
OSL_ENSURE( nCol < nColsPerRow,
"ScHTMLLayoutParser::SetWidths: column overflow" );
if (nCol >= nColsPerRow)
continue;
+if (nCol < 0)
+{
+SAL_WARN("sc", "negative offset: " << nCol);
+continue;
+}
pE->nOffset = pOffsets[nCol];
nCol = nCol + pE->nColOverlap;
if ( nCol > nColsPerRow )
core.git: include/svl sc/inc sc/source svl/source
include/svl/numformat.hxx |2 +-
sc/inc/interpretercontext.hxx |1 +
sc/source/core/tool/interpretercontext.cxx | 29 ++---
svl/source/numbers/zforlist.cxx| 19 ++-
4 files changed, 30 insertions(+), 21 deletions(-)
New commits:
commit db040630d664fa20bc4f8995d2168fcce51a8bfd
Author: Caolán McNamara
AuthorDate: Mon Apr 1 21:17:26 2024 +0100
Commit: Caolán McNamara
CommitDate: Tue Apr 2 20:45:14 2024 +0200
crashtesting: SvNFEngine::DefaultCurrencyRO assert
seen with forum-mso-en4-207468.xls
so we will have to ensure that nDefaultSystemCurrencyFormat
is set before using the RO mode
Change-Id: Ib1e755203917ddd751a1493c817cc8383bbbc043
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165658
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/include/svl/numformat.hxx b/include/svl/numformat.hxx
index 92f93bb1562a..484a2a1bfdb7 100644
--- a/include/svl/numformat.hxx
+++ b/include/svl/numformat.hxx
@@ -552,7 +552,6 @@ private:
OnDemandNativeNumberWrapper xNatNum; // Native number service loaded on
demand
Link aColorLink; // User defined color table CallBack
-SVL_DLLPRIVATE static volatile bool bCurrencyTableInitialized;
SVL_DLLPRIVATE static sal_uInt16 nSystemCurrencyPosition;
SVL_DLLPRIVATE static SvNumberFormatterRegistry_Impl* pFormatterRegistry;
@@ -651,6 +650,7 @@ public:
// return the corresponding date separator
const OUString& GetDateSep() const { return
m_aCurrentLanguage.GetDateSep(); }
+void PrepForRoMode();
const SvNFFormatData& GetROFormatData() const { return m_aFormatData; }
const SvNFLanguageData& GetROLanguageData() const { return
m_aCurrentLanguage; }
};
diff --git a/sc/inc/interpretercontext.hxx b/sc/inc/interpretercontext.hxx
index ead9b04c06c7..63d23bfe227a 100644
--- a/sc/inc/interpretercontext.hxx
+++ b/sc/inc/interpretercontext.hxx
@@ -121,6 +121,7 @@ private:
void Cleanup();
void ClearLookupCache(const ScDocument* pDoc);
void initFormatTable();
+void prepFormatterForRoMode(SvNumberFormatter* pFormatter);
// During threaded calculation, where we don't need to add to the number
// format data, we can access the numbering data with a RO unlocked view of
diff --git a/sc/source/core/tool/interpretercontext.cxx
b/sc/source/core/tool/interpretercontext.cxx
index e1fc5fb24252..557a9c766db1 100644
--- a/sc/source/core/tool/interpretercontext.cxx
+++ b/sc/source/core/tool/interpretercontext.cxx
@@ -44,12 +44,7 @@ ScInterpreterContext::ScInterpreterContext(const ScDocument&
rDoc, SvNumberForma
if (!pFormatter)
mpFormatData = nullptr;
else
-{
-mxLanguageData.reset(new
SvNFLanguageData(pFormatter->GetROLanguageData()));
-mxAuxFormatKeyMap.reset(new SvNFFormatData::DefaultFormatKeysMap);
-mpFormatData = >GetROFormatData();
-maROPolicy = SvNFEngine::GetROPolicy(*mpFormatData,
*mxAuxFormatKeyMap);
-}
+prepFormatterForRoMode(pFormatter);
}
ScInterpreterContext::~ScInterpreterContext() { ResetTokens(); }
@@ -73,28 +68,32 @@ void ScInterpreterContext::SetDocAndFormatter(const
ScDocument& rDoc, SvNumberFo
}
if (mpFormatter != pFormatter)
{
-// formatter has changed
-mxLanguageData.reset(new
SvNFLanguageData(pFormatter->GetROLanguageData()));
-mxAuxFormatKeyMap.reset(new SvNFFormatData::DefaultFormatKeysMap);
-mpFormatData = >GetROFormatData();
-maROPolicy = SvNFEngine::GetROPolicy(*mpFormatData,
*mxAuxFormatKeyMap);
mpFormatter = pFormatter;
+// formatter has changed
+prepFormatterForRoMode(pFormatter);
+
// drop cache
std::fill(maNFBuiltInCache.begin(), maNFBuiltInCache.end(),
NFBuiltIn());
std::fill(maNFTypeCache.begin(), maNFTypeCache.end(), NFType());
}
}
-void ScInterpreterContext::initFormatTable()
+void ScInterpreterContext::prepFormatterForRoMode(SvNumberFormatter*
pFormatter)
{
-mpFormatter = mpDoc->GetFormatTable(); // will assert if not main thread
-mpFormatData = >GetROFormatData();
-mxLanguageData.reset(new
SvNFLanguageData(mpFormatter->GetROLanguageData()));
+pFormatter->PrepForRoMode();
+mpFormatData = >GetROFormatData();
+mxLanguageData.reset(new
SvNFLanguageData(pFormatter->GetROLanguageData()));
mxAuxFormatKeyMap.reset(new SvNFFormatData::DefaultFormatKeysMap);
maROPolicy = SvNFEngine::GetROPolicy(*mpFormatData, *mxAuxFormatKeyMap);
}
+void ScInterpreterContext::initFormatTable()
+{
+mpFormatter = mpDoc->GetFormatTable(); // will assert if not main thread
+prepFormatterForRoMode(mpFormatter);
+}
+
void ScInterpreterContext::MergeDefaultFormatKeys(SvNumberFormatter&
rFormatter) const
{
rFormatter.MergeDefaultFormatKeys(*mxAuxFormatKeyMap);
diff --git a/svl/source/numbers/zforlist.cxx
[Bug 147676] Continue to show cell contents in the formula bar when another document gets the mouse focus.
https://bugs.documentfoundation.org/show_bug.cgi?id=147676 --- Comment #3 from DErik --- I have loaded the Apple Silicon version 24.2.2.2 (AARCH64) and this still exists. But let me add another wrinkle to this. I have one spreadsheet open, and two text documents. When I switch from the spreadsheet to either text, the formula gets wiped out. So it is still a problem. But I opened the "About LibreOffice" window with one of the text documents active. When I switch from the spreadsheet to that text document, the formula bar remains filled. But switching to the other text document, it gets wiped. I tried this with both text documents and it happens the same way with either displaying the "About" window - one text wipes out the formula and the other does not. But with no "About" window displayed, the formula bar is wiped with either text document active. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160482] Unformatted text pasted in merged cell not showed correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=160482 --- Comment #3 from ady --- I opened attachment 193435 using several different minor release versions of several branches (7.6, 7.5, 7.4, 7.3, 6.0, 5.4, 5.0, 3.3, and I might be forgetting some other test). My comment 1 reflects (in short) what I saw as the result of my tests. I also reported the simplest way I could refresh the screen in that test, so it can be confirmed that the problem is _visual_, not about actual calculation updates nor about saving the value. Maybe this visual issue happens under some particular conditions/settings but not under other settings. Other volunteers might test and report a different result. That is the reason to include the Help > About version info I posted. Please feel free to test and report any relevant feedback. For each test, please include the "Help > About" version info – the icon in that dialog allows to copy the info to the clipboard, so you can paste it here in a new comment. If someone knows of some other report that would reflect the same visual problem, this report might be set as dupe, or at least as "See also". -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160492] libcdr: recent CorelDraw files are not loaded
https://bugs.documentfoundation.org/show_bug.cgi?id=160492 --- Comment #1 from Manfredi Marceca --- Created attachment 193448 --> https://bugs.documentfoundation.org/attachment.cgi?id=193448=edit CDR, CMX test files -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160491] In Calc "text to columns" produces two rows out of one row of data
https://bugs.documentfoundation.org/show_bug.cgi?id=160491 Wolfgang Minderle changed: What|Removed |Added CC||wdm...@hotmail.com --- Comment #1 from Wolfgang Minderle --- Created attachment 193447 --> https://bugs.documentfoundation.org/attachment.cgi?id=193447=edit Result of "Text to Columns" function in Calc The screenshot shows the double lines produced by Calc. -- You are receiving this mail because: You are the assignee for the bug.
